Tuesday, 2015-03-17

*** sriram has joined #openstack-zaqar00:02
openstackgerritMasaki Matsushita proposed openstack/zaqar: Validate UUIDs (Message ID, Client UUID, Claim ID) before the driver sends it.  https://review.openstack.org/16467100:24
*** ericksonfgds_ has joined #openstack-zaqar00:33
*** reed has quit IRC00:39
*** achanda_ has quit IRC00:48
*** ericksonfgds_ has quit IRC00:54
*** exploreshaifali has quit IRC01:20
openstackgerritMasaki Matsushita proposed openstack/zaqar: Validate UUIDs before the driver sends it  https://review.openstack.org/16467101:51
*** achanda has joined #openstack-zaqar02:27
*** chandankumar has joined #openstack-zaqar02:51
*** achanda has quit IRC02:52
*** echevemaster has quit IRC03:05
*** echevemaster has joined #openstack-zaqar03:05
*** boris-42 has quit IRC03:12
*** sriram has quit IRC03:25
*** chandankumar has quit IRC03:42
*** flwang has quit IRC03:52
*** chandankumar has joined #openstack-zaqar03:57
*** cpallares has quit IRC03:58
*** chandankumar has quit IRC03:59
*** chandankumar has joined #openstack-zaqar04:00
*** achanda has joined #openstack-zaqar04:01
*** achanda has quit IRC04:46
*** achanda has joined #openstack-zaqar04:49
*** achanda has quit IRC04:49
*** exploreshaifali has joined #openstack-zaqar05:12
*** amalagon has quit IRC05:30
*** exploreshaifali has quit IRC05:30
*** achanda has joined #openstack-zaqar06:26
*** echevemaster has quit IRC06:43
*** exploreshaifali has joined #openstack-zaqar07:00
exploreshaifaliflwang1, ping!07:22
exploreshaifaliflwang1, I can not think of how to make send DataDriver instances, there we are have list of objects of MessageQueueHandler07:24
exploreshaifaliand MessageQueueHandler have _delete and _stats methods only in case of redis it also have _create method along with these 207:25
*** exploreshaifali has quit IRC07:28
*** achanda has quit IRC07:31
*** dynarro has joined #openstack-zaqar07:55
*** exploreshaifali has joined #openstack-zaqar08:34
*** boris-42 has joined #openstack-zaqar08:59
*** dynarro has quit IRC09:29
*** exploreshaifali has quit IRC09:45
*** dynarro has joined #openstack-zaqar09:54
*** dynarro has quit IRC10:24
*** achanda has joined #openstack-zaqar10:31
*** exploreshaifali has joined #openstack-zaqar10:34
*** achanda has quit IRC10:36
*** exploreshaifali has quit IRC10:41
*** flwang1 has quit IRC11:53
*** exploreshaifali has joined #openstack-zaqar11:53
*** flwang has joined #openstack-zaqar11:56
*** mpanetta has joined #openstack-zaqar12:29
*** exploreshaifali has quit IRC12:33
*** chandankumar has quit IRC12:33
*** dynarro has joined #openstack-zaqar12:42
*** flwang has quit IRC12:45
*** flwang has joined #openstack-zaqar12:48
*** exploreshaifali has joined #openstack-zaqar12:52
exploreshaifaliflwang, around?12:54
vkmcexploreshaifali, flwang is probably asleep heh :)13:01
exploreshaifalivkmc, okay!13:01
exploreshaifaliThanks :)13:01
vkmcnp13:01
vkmcwhat is the status of your change?13:01
exploreshaifalivkmc, as per last discussion with flwang , https://review.openstack.org/#/c/144340/25/zaqar/storage/pipeline.py  L99 here I am suppose to return DataDriver object rather than list13:03
exploreshaifaliatm we are returning list of MessageQueueHandler13:03
flaper87exploreshaifali: nope, you're suppose to return a list13:04
flaper87there could be more than one plugin13:04
flaper87what you need to do is call `extend` instead of `append` in L12813:04
flaper87and L14113:04
flaper87also, HELLLOOOOOOOOOOOOOOOOOOOOOOO!13:04
exploreshaifaliflaper87, o_O okay!!13:05
exploreshaifaligoooooooooooood morning :)13:05
exploreshaifali:D13:05
vkmcflaper87, did you hear the latest best news?13:05
flaper87vkmc: mmh, I'm afraid I didn't13:06
vkmcexploreshaifali, tell him :)13:06
exploreshaifaliflaper87, I am greatful to join whole Zaqar team in coming Design summit13:07
exploreshaifali:D13:07
flaper87exploreshaifali: O.O13:07
* flaper87 fainted13:07
exploreshaifalihahaha13:07
flaper87exploreshaifali: that means we can complete your internship by teaching you how to party properly13:07
exploreshaifalihaha13:07
flaper87*cough* I mean, work, obviously *cough*13:07
exploreshaifaliflaper87, yes ofcourse13:08
flaper87exploreshaifali: I'm SOOOO EXCITED!!!!!13:08
exploreshaifalivkmc, and I too13:08
exploreshaifali:D13:08
flaper87exploreshaifali: you are talking to me, just fyi13:08
flaper87I mean, you can mention vkmc all you want13:08
vkmcexploreshaifali, try to keep away from flaper87 when he says tequila is a bad idea13:09
flaper87but don't be rude13:09
flaper87:P13:09
exploreshaifalithe last lesson of intership will be most memorable one13:09
flaper87tequila is always a bad idea13:09
flaper87ALWAYS!13:09
flaper87for gods sake, how many times do I have to repeat this?13:09
vkmcexploreshaifali, for some reason he makes it look like a good idea13:09
exploreshaifaliokay13:09
exploreshaifalitequila - tequila13:09
vkmcflaper87, there are records of this statement13:10
flaper87vkmc: I have that statement in my twitter profile, I couldn't go any more public than that13:12
flaper87:P13:12
exploreshaifalivkmc, seems like flaper87 moved in his old memories13:12
flaper87exploreshaifali: lol, old... I'd say present :D13:12
vkmcflaper87, we have to recover the recordings on Travis phone haha13:12
exploreshaifali:D13:12
vkmcexploreshaifali, I'm so excited you can join us :) you will love the summit13:14
*** sriram has joined #openstack-zaqar13:14
exploreshaifaliyes yes!! I can't sleep for last while night13:14
exploreshaifaliwas dreaming about summit only13:14
flaper87vkmc: I think he deleted those13:15
exploreshaifalivkmc, thanks a lot for always being super supportive!13:15
flaper87we never created our app /cc kragniz13:15
*** flwang has quit IRC13:16
vkmcflaper87, I hope he did haha13:16
vkmcexploreshaifali, np, thanks for being such an amazing intern13:16
* exploreshaifali putting her hand on her eyes13:17
vkmc:)13:17
exploreshaifali:D13:17
*** flwang has joined #openstack-zaqar13:18
exploreshaifaliand thanks to flaper87 too for being super awesome mentor!13:18
exploreshaifaliflwang, goood morning!13:19
*** amalagon has joined #openstack-zaqar13:21
flaper87exploreshaifali: it's vkmc and me who should thank you for contributing13:25
flaper87exploreshaifali: btw, that reminds me13:25
flaper87The internship is almost done and I'm basically forced to ask: Will you continue working on that patch ?13:25
vkmcflaper87, the internship is done13:25
flaper87vkmc: sssssssssshhhhhhhhhhhhhhhh13:26
vkmc:D13:26
flaper87I'm playing with exploreshaifali's mind13:26
exploreshaifaliflaper87, well no13:26
exploreshaifalinot just with current patch13:27
exploreshaifaliI will continue contributing for OpenStack other the current patch too13:27
exploreshaifali:P13:27
flaper87exploreshaifali: you... scared me13:27
flaper87phew13:27
flaper87ok, cool, so, GET TO WORK NOW!!!!!!!!!13:27
flaper87:D13:27
exploreshaifaliyea13:28
exploreshaifalibtw - back to Work :D13:28
exploreshaifaliso since we are btw flaper87 using append or extend not changing any thing13:29
exploreshaifaliproblem is https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v2_0/queues.py#L8013:29
exploreshaifaliself._queue_controller does not have create method13:29
exploreshaifalierror message comes for that line is AttributeError: 'list' object has no attribute 'create'13:30
exploreshaifalimessageQueueHandler that we have defined only have _delete and _stats method13:31
*** flwang has quit IRC13:37
*** flwang has joined #openstack-zaqar13:38
exploreshaifaliflaper87, here https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v2_0/queues.py#L37 we have13:41
exploreshaifali[<zaqar.storage.mongodb.messages.MessageQueueHandler instance at 0x7f0187fa1368>, <zaqar.storage.sqlalchemy.messages.MessageQueueHandler object at 0x7f0187f8fa50>, <zaqar.storage.redis.messages.MessageQueueHandler object at 0x7f0187f8fcd0>, <zaqar.common.pipeline.Pipeline object at 0x7f0187f8f950>, <zaqar.storage.sqlalchemy.queues.QueueController object at 0x7f0187f8f5d0>])13:41
flaper87exploreshaifali: mmh, why are there so many instances of MessageQueueHandler13:42
flaper87?13:42
exploreshaifalithey are coming from pipeline13:43
exploreshaifalihttps://review.openstack.org/#/c/144340/25/zaqar/storage/pipeline.py L9613:44
exploreshaifalione instance of MessageQueueHandler for each data-store13:45
* flaper87 clicks13:50
flaper87exploreshaifali: ahh wait, gotcha13:51
flaper87lemme take a look again at how that works13:51
*** amitgandhinz has joined #openstack-zaqar13:59
*** cpallares has joined #openstack-zaqar14:03
kragnizwoo, there's going to be an exploreshaifali in vancouver!14:27
exploreshaifalikragniz, yeah!!! :D14:27
exploreshaifaliexicited to meet you all guyz!14:28
kragniz:D14:28
kragnizflaper87: sad we never made that app14:28
*** achanda has joined #openstack-zaqar14:34
flaper87is there going to be a kragniz in vancouver ?14:37
kragnizflaper87: there will be!14:40
exploreshaifalithat is great :D14:41
flaper87kragniz: aaaaaaaaaaaaaaaaaaawesome!14:43
*** achanda has quit IRC14:43
flaper87exploreshaifali: still around ?14:57
exploreshaifaliyup14:57
exploreshaifaliflaper87, yes14:57
exploreshaifaliflaper87, on your head14:57
exploreshaifali:P14:57
flaper87exploreshaifali: ok, looking at that thing14:57
vkmcI spend my whole day yesterday reinstalling things15:00
vkmchope I can get back to code soon15:00
vkmcdamn15:00
*** chandankumar has joined #openstack-zaqar15:04
*** chandankumar has quit IRC15:26
flaper87exploreshaifali: so, the error there is that queue_controller, message_controller, claim_controller, etc, should return a Pipeline, not a list15:38
flaper87exploreshaifali: The pipeline class is in zaqar.common.pipeline15:39
flaper87not sure when that was changed nor how it passed the gate15:39
flaper87there should be tests for that15:39
flaper87exploreshaifali: do you want to work on a fix for that in a separate patch?15:39
flaper87dynarro: ^15:39
flaper87otherwise, I can do it myself15:39
dynarroflaper87: I could work on it ;)15:41
flaper87dynarro: sounds good15:42
flaper87dynarro: https://bugs.launchpad.net/zaqar/+bug/143315815:45
openstackLaunchpad bug 1433158 in zaqar "The pipeline should return a `zaqar.common.pipeline.Pipeline` object instead of a list" [Undecided,New]15:45
flaper87it's yours15:45
dynarroflaper87: thanks!15:46
vkmcflaper87, could you review the patches for websocket? if those look good, I can move forward adding the remainding endpoints and tests15:47
flaper87vkmc: I'll get to it right now15:50
flaper87exploreshaifali: lemme know when you read my messages and if they make sense to you15:50
vkmcthanks15:50
flaper87also, wait for dynarro's patches15:51
flaper87vkmc: you know how to thank me, words ain't enough15:51
* flaper87 wants gummy, gummy, GUMMY BEARS!15:51
vkmcI'll pay you back with a bag of taffies next time I meet with you15:51
flaper87sounds good15:52
flaper87exploreshaifali: one more lesson, don't work for free... People are always willing to pay ^15:53
flaper87:P15:53
flaper87mmh, I really want to fix the pooling issue in the gate15:53
flaper87I'll make zaqar a devstack plugin and that should give us more control over it15:53
flaper87zhiyan: btw, I reviewed your OSProfile patch, let me know your thoughts15:54
flaper87ah wait, you actually replied15:54
flaper87T_T15:54
vkmcexploreshaifali, one review, one bag of candies... street laws apply here15:54
exploreshaifaliwhaaaat.... I am stuck at one bag of candies!15:55
exploreshaifalicannot move above it, what is written there?15:55
exploreshaifali:P15:55
exploreshaifaliflaper87, okay I will work for that but I need pointers15:56
flaper87exploreshaifali: dynarro took it, just wait for her patch15:56
exploreshaifaliammm okay15:56
exploreshaifaliI missed it15:56
exploreshaifalibut fine with dynarro :)15:56
flaper87zhiyan: replied16:04
flaper87vkmc: I don't want to be supper, silly, nitpicky but https://review.openstack.org/#/c/164007/4/zaqar/api/v1_1/endpoints.py,cm16:05
vkmcflaper87, for the zaqar pool thing I remember we discussed that we needed to create some demo pools16:05
flaper87What do you think about `status` ?16:05
flaper87or `code` ?16:05
flaper87`status_code` seems long and it'll require more data to travel16:06
vkmcomg16:06
vkmcreally flaper87?16:06
vkmclol, sure, I thought about it :)16:06
flaper87vkmc: shut up16:06
vkmcyou are one of those... nitpickers... nitpicking everything on your way16:06
vkmcstatus sounds good16:07
* flaper87 pulls vkmc chair and watches her fall16:07
flaper87vkmc: ok, I'll +2 after that, lets ping flwang for reviews16:07
vkmcthanks for checking it out16:07
vkmcsure16:07
vkmcI was concerned about the json schema doc... messages, pools and flavors were missing16:08
vkmcshould I add the admin flag for pools/flavors?16:08
vkmcI also added the base endpoints (ping and homedoc)16:08
*** chandankumar has joined #openstack-zaqar16:11
flaper87vkmc: pools and flavors are admin endpoints16:16
flaper87yes16:16
flaper87vkmc: awesome16:16
flaper87vkmc: could you move the jsonschema patch at the top of the dependency chain16:17
flaper87?16:17
flaper87actually16:17
flaper87could you remove it from that chain?16:17
flaper87it doesn't make sense to create a dependency there16:17
vkmcsure thing16:18
vkmcthanks flaper8716:18
flaper87vkmc: np, girl. here to help16:19
flaper87(or at least pretending to)16:19
*** mpanetta has quit IRC16:32
*** chandankumar has quit IRC16:48
*** chandankumar has joined #openstack-zaqar17:08
*** chandankumar has quit IRC17:18
openstackgerritDoraly Navarro proposed openstack/zaqar: Make the Pipeline inmutable.  https://review.openstack.org/16515317:26
dynarroexploreshaifali: it's done ^17:28
exploreshaifalidynarro, Thanks!17:28
dynarroexploreshaifali: np17:28
dynarro:)17:28
flaper87dynarro: exploreshaifali awesome17:29
flaper87thanks to both of you17:29
flaper87exploreshaifali: you need to make your patch depend on that one17:29
flaper87it should be easy/simple to do17:29
exploreshaifaliokay!17:29
flaper87I mean, it shouldn't conflict with your work17:29
flaper87That's wait I meant with easy/simple17:29
flaper87in other words, straightforward17:29
flaper87and I'll now stfu and leave!17:29
flaper87ttyl girls17:30
exploreshaifaliok ok17:30
exploreshaifali:D17:30
*** dynarro has quit IRC17:30
*** achanda has joined #openstack-zaqar17:34
*** chandankumar has joined #openstack-zaqar17:34
*** exploreshaifali has quit IRC17:36
*** reed has joined #openstack-zaqar17:42
*** chandankumar has quit IRC17:50
*** csoukup has joined #openstack-zaqar17:55
*** exploreshaifali has joined #openstack-zaqar17:59
*** chandankumar has joined #openstack-zaqar18:04
*** achanda has quit IRC18:16
*** chandankumar has quit IRC18:16
*** achanda has joined #openstack-zaqar18:21
*** chandankumar has joined #openstack-zaqar18:41
*** chandankumar has quit IRC18:55
*** ametts has quit IRC18:56
*** exploreshaifali has quit IRC19:17
*** achanda has quit IRC19:33
*** flwang1 has joined #openstack-zaqar20:05
*** fifieldt has quit IRC20:08
*** achanda has joined #openstack-zaqar20:19
*** fifieldt has joined #openstack-zaqar20:21
openstackgerritVictoria Martínez de la Cruz proposed openstack/zaqar: Update json schema for API v1_1  https://review.openstack.org/14841420:27
*** boris-42 has quit IRC20:42
*** achanda has quit IRC20:44
*** achanda has joined #openstack-zaqar20:45
*** sriram has quit IRC21:22
openstackgerritVictoria Martínez de la Cruz proposed openstack/zaqar: Adds a status code field to the Response  https://review.openstack.org/16400721:29
*** csoukup has quit IRC22:11
flwangflaper87: ping22:31
cpallaresflwang: I think you missed him again.22:31
flwang;-)22:33
*** amitgandhinz has quit IRC22:42
*** reed has quit IRC22:53
vkmcflwang, hey there!22:58
flwangvkmc: hey22:59
vkmcflwang, how is it going? I saw exploreshaifali was working on something for the notifications patch?23:00
flwangvkmc: really?23:00
flwangvkmc: I think he/she is stilling working on splitting the queue controller23:00
flwangthe relationship between the patch and notification is if his/her patch works, then my patches' jenkins failure could be gone23:01
vkmcflwang, I see23:01
flwangvkmc: but23:01
vkmcflwang, yes, she is working on the slip queue controller change23:01
flwangi have downloaded his/her code and try to run it in my local env23:02
flwangit's totally broken :(23:02
flwangand almost all the unit test failed as well23:02
flwangso i'm not confident to depend on that23:03
vkmchmm23:03
flwangthat's why I'm also working on the redis driver in parallel23:03
vkmcso, notifications is blocked with it?23:03
flwangtechnically, or I would  say it's blocked by the redis driver23:03
openstackgerritVictoria Martínez de la Cruz proposed openstack/zaqar: Adds a status code field to the Response  https://review.openstack.org/16400723:04
flwangflaper87 told me with exploreshaifali's patch, jenkins would be happy even there is no redis driver for notification23:04
vkmcI see...23:04
vkmcyes23:04
vkmcI wonder if with a few tweaks it will be finished23:05
flwangbut now I'm not really sure if it could be23:05
vkmcI'll download it in my env23:05
flwangvkmc: not really23:05
vkmcbo :(23:05
vkmcok23:05
flwangit's adding many pipeline stages for queue23:05
flwangas a result, when you start zaqar server, the queue_controller will be instantiated as a DataDriver list instead of a DataDriver instance23:06
flwangso, everything is broken23:06
flwangI mean any action related to queue23:06
openstackgerritVictoria Martínez de la Cruz proposed openstack/zaqar: Make the Pipeline inmutable  https://review.openstack.org/16515323:08
flwangvkmc: did you try ^ patch with exploreshaifali's patch?23:12
vkmcyep, I'm rebasing shaifali's patch23:12
flwangso it works?23:13
vkmcrunning py27 tests now23:13
vkmchopefully23:13
flwang:-D23:13
vkmc:D23:13
vkmcwhile it runs, I'll review your patches23:13
flwangvkmc: I'm wondering if the change will impact the basic pipeline logic, I will test your pipeline fix with my webhook patch23:15
vkmcit shouldn't... but yes, we better fix that23:15
vkmcs/fix/test23:17
flwangvkmc: brb,  grab some lunch, leave msg for me :)23:20
vkmcflwang, sure23:20
vkmctests for the pipeline change are passing23:28
vkmcbut the splitting is still broken23:28
vkmcI'll debug it a little more and try to fix it23:28
vkmcI'll upload the rebase anyway, so we can see the output :)23:30
openstackgerritVictoria Martínez de la Cruz proposed openstack/zaqar: Removing QueueController from data to control plane  https://review.openstack.org/14434023:31

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!