| *** achanda has quit IRC | 00:00 | |
| *** davideagnello has joined #openstack-zaqar | 00:37 | |
| *** davideagnello has quit IRC | 00:43 | |
| *** cpallares has quit IRC | 00:51 | |
| *** achanda has joined #openstack-zaqar | 01:01 | |
| *** achanda has quit IRC | 01:06 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement redis driver for notifications https://review.openstack.org/164893 | 02:29 |
|---|---|---|
| *** chandankumar has joined #openstack-zaqar | 02:58 | |
| *** chandankumar has quit IRC | 03:13 | |
| *** AAzza_afk has joined #openstack-zaqar | 03:53 | |
| *** AAzza has quit IRC | 03:55 | |
| *** AAzzal has joined #openstack-zaqar | 03:55 | |
| *** AAzzam has joined #openstack-zaqar | 03:56 | |
| *** AAzzam is now known as AAzza | 03:56 | |
| *** AAzza_afk has quit IRC | 03:59 | |
| *** AAzzal has quit IRC | 04:00 | |
| *** AAzza_afk has joined #openstack-zaqar | 04:14 | |
| *** AAzza has quit IRC | 04:16 | |
| *** AAzza_afk is now known as AAzza | 04:16 | |
| *** AAzza has quit IRC | 04:21 | |
| *** AAzza_afk has joined #openstack-zaqar | 04:21 | |
| *** AAzza_afk is now known as AAzza | 04:22 | |
| *** achanda has joined #openstack-zaqar | 04:24 | |
| *** chandankumar has joined #openstack-zaqar | 04:27 | |
| *** JAHoagie has joined #openstack-zaqar | 04:33 | |
| *** achanda has quit IRC | 05:22 | |
| *** achanda_ has joined #openstack-zaqar | 05:22 | |
| *** achanda has joined #openstack-zaqar | 05:29 | |
| *** achanda_ has quit IRC | 05:30 | |
| *** JAHoagie has quit IRC | 05:34 | |
| *** amalagon has joined #openstack-zaqar | 05:55 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Imported Translations from Transifex https://review.openstack.org/168789 | 06:03 |
| flaper87 | flwang: ping | 06:57 |
| *** vkmc has quit IRC | 07:00 | |
| openstackgerrit | Flavio Percoco proposed openstack/zaqar: Allow for internal pipelines to be defined https://review.openstack.org/168283 | 07:01 |
| flaper87 | flwang: pls pls pls, could you review this? https://review.openstack.org/#/c/168283/ | 07:01 |
| flaper87 | You need that one for your notifications work | 07:01 |
| *** vkmc has joined #openstack-zaqar | 07:03 | |
| *** achanda has quit IRC | 07:08 | |
| *** chandankumar has quit IRC | 07:42 | |
| *** chandankumar has joined #openstack-zaqar | 07:43 | |
| *** davideagnello has joined #openstack-zaqar | 07:53 | |
| *** davideagnello has quit IRC | 07:57 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Add REST API for notification/subscriptions https://review.openstack.org/142432 | 08:31 |
| *** flwang1 has joined #openstack-zaqar | 08:33 | |
| flwang1 | flaper87: ping | 08:33 |
| flaper87 | flwang1: pong | 09:31 |
| flwang1 | flaper87: https://review.openstack.org/164893 | 09:31 |
| flwang1 | https://review.openstack.org/142432 | 09:32 |
| flaper87 | flwang1: I need to go afk for a bit again. Could you please review the pipeline patch ? | 09:32 |
| flwang1 | flaper87: pls help review the redis driver | 09:32 |
| flaper87 | flwang1: awesome, I'll review those today | 09:32 |
| flaper87 | highest priority on my list | 09:32 |
| flwang1 | flaper87: i did | 09:32 |
| flwang1 | i tried to let my patch depends on that, but my patch will still fail | 09:32 |
| flaper87 | flwang1: https://review.openstack.org/#/c/168283/ <- this one ? | 09:32 |
| flwang1 | but TBH, i haven't dig into the code | 09:33 |
| flwang1 | yes | 09:33 |
| flaper87 | mmh, I don't see your comments/vote | 09:33 |
| flaper87 | did you submit them ? | 09:33 |
| *** amalagon has quit IRC | 09:34 | |
| flaper87 | ok, brb, pls, cast your vote on the patch. I'll brb. It's really important to get those in *today* | 09:34 |
| flwang1 | https://review.openstack.org/#/c/142432/14//COMMIT_MSG | 09:34 |
| *** amalagon has joined #openstack-zaqar | 09:34 | |
| flwang1 | flaper87: ok, sure | 09:34 |
| flwang1 | ttyl | 09:34 |
| *** amalagon has quit IRC | 09:39 | |
| flaper87 | flwang1: I still don't see your vote on the pipeline patch | 10:46 |
| flwang1 | flaper87: it's happening when you're asking :) | 10:47 |
| flaper87 | flwang1: awesome, I was freaking out. I was like DON'T GO TO SLEEP WITHOUT VOTING! | 10:48 |
| flaper87 | I'm reviewing your patches now | 10:48 |
| flwang1 | flaper87: lol | 10:48 |
| flaper87 | flwang1: thanks, I'll ask vkmc to review when she'll be around | 10:48 |
| flwang1 | flaper87: btw, should I submit an formal FFE request for notification? | 10:49 |
| flaper87 | flwang1: mmh, I'd say yes. | 10:52 |
| flwang1 | send it out to mail list? | 10:52 |
| flaper87 | flwang1: thing is, I think the FFE due date is today, I mean. FFE should land today so, I guess it's quite pointless to send it | 10:53 |
| flaper87 | so don't send it, we'll just focus on making this work | 10:53 |
| flwang1 | flaper87: ok, cool | 10:54 |
| flwang1 | flaper87: i'm working on the test for redis driver | 11:09 |
| flwang1 | so do we have to merge the code today? | 11:10 |
| flwang1 | or today is just the FFE request last day? | 11:10 |
| flaper87 | flwang1: merge :/ | 11:10 |
| flaper87 | at least the API changes | 11:10 |
| flaper87 | The API patch, that is | 11:10 |
| flwang1 | flaper87: ah, ok | 11:10 |
| flaper87 | I just reviewed it | 11:10 |
| flwang1 | i saw that | 11:10 |
| flaper87 | if you can't address those comments, I'll do it for you | 11:10 |
| flaper87 | if you don't mind | 11:10 |
| flaper87 | here to help, heads down on Zaqar | 11:11 |
| flwang1 | I'm going to submit a PS soon | 11:14 |
| flwang1 | flaper87: is there any other comments? | 11:15 |
| flaper87 | flwang1: nope | 11:15 |
| flaper87 | O | 11:15 |
| flaper87 | I'll +@ after that | 11:15 |
| flwang1 | flaper87: cool | 11:16 |
| flwang1 | i will let you know when it's ready for next fight | 11:16 |
| openstackgerrit | Merged openstack/zaqar: Imported Translations from Transifex https://review.openstack.org/168789 | 11:23 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement redis driver for notifications https://review.openstack.org/164893 | 11:25 |
| vkmc | hi hi hi | 11:43 |
| flwang1 | vkmc: :) | 11:48 |
| flaper87 | vkmc: hey | 11:52 |
| flaper87 | :) | 11:52 |
| vkmc | o/ | 11:52 |
| flaper87 | vkmc: how was your weekend ? | 11:52 |
| vkmc | it was quite good :) yours? | 11:53 |
| flaper87 | it was great. Lambdacon was really good | 11:54 |
| vkmc | oh I saw some tweets :D | 11:54 |
| vkmc | how was your prez? | 11:55 |
| flaper87 | It went good, apparently. People liked it so, I'm happy. :) | 11:56 |
| flaper87 | vkmc: could you review the pending patches for zaqar? | 12:03 |
| flaper87 | :) | 12:03 |
| vkmc | flaper87, sure | 12:03 |
| vkmc | flaper87, could you review the websockets tests? https://review.openstack.org/#/c/144803/ | 12:05 |
| * flaper87 is doing that | 12:06 | |
| vkmc | I'm working in the messages one too | 12:06 |
| flwang1 | flaper87: https://review.openstack.org/#/c/164893/ | 12:07 |
| flwang1 | vkmc: https://review.openstack.org/#/c/164893/ | 12:07 |
| flaper87 | flwang1: danke | 12:07 |
| vkmc | wohoo, thanks flwang1! | 12:08 |
| flwang1 | vkmc: as for the websocket patch, why do we need a detailed conf file? https://review.openstack.org/#/c/144803/11/tests/etc/websocket_mongodb.conf | 12:09 |
| vkmc | flwang1, that's actually not needed, its enough with the selection of transport and storage | 12:09 |
| flwang1 | vkmc: ok, I will leave a comment on that | 12:09 |
| vkmc | thx | 12:10 |
| vkmc | working on the messages endpoint yesterday, I was wondering how this https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/utils.py#L76-L116 works | 12:20 |
| vkmc | I mean, filter() works with a function and iterator, and at first sight we are passing a dict to it | 12:20 |
| flwang1 | vkmc: flaper87: i have to offline now | 12:22 |
| flwang1 | it's 1:20AM now | 12:22 |
| vkmc | flwang1, sure, thanks for everything Fei, we will keep reviewing/fixing things :) | 12:22 |
| vkmc | oh too late | 12:22 |
| flaper87 | flwang1: iugh, take care buddy | 12:22 |
| flaper87 | have some rest | 12:22 |
| flaper87 | we'll take it from here | 12:22 |
| flwang1 | flaper87: pls review the notification patches, thanks a lot, guys | 12:22 |
| flaper87 | thank you | 12:24 |
| flaper87 | I will review | 12:24 |
| vkmc | flaper87, whenever you have a moment, could you checkout that function I mentioned? ^ | 12:31 |
| * flaper87 clicks | 12:32 | |
| flaper87 | vkmc: I'm reviewing your patch (not distracted, I swear) | 12:32 |
| flaper87 | who am I kidding... | 12:32 |
| vkmc | ¬¬ | 12:33 |
| flaper87 | vkmc: what's up with that function ? | 12:34 |
| vkmc | flaper87, I want to do something similar with the messages in the websocket driver | 12:35 |
| vkmc | I have a different approach to do it, but I wanted to follow how things are doing in the wsgi one | 12:35 |
| vkmc | and I saw that the filter() function is supposed to have a function as a first parameter | 12:36 |
| vkmc | we are passing a dict | 12:36 |
| vkmc | or at least, that is what I understood | 12:36 |
| vkmc | I wonder how its even working | 12:36 |
| flaper87 | vkmc: wait, you're talking about the built-in filter function, right ? | 12:37 |
| vkmc | yes | 12:37 |
| flaper87 | vkmc: that's not the one being called: https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/utils.py#L119 | 12:37 |
| flaper87 | :) | 12:37 |
| vkmc | OH | 12:37 |
| vkmc | LOL | 12:37 |
| flaper87 | We should change the name of that function | 12:37 |
| vkmc | I was missing something | 12:37 |
| vkmc | :x | 12:37 |
| flaper87 | overriding the built-in functions is bad practice | 12:37 |
| flaper87 | very bad practice | 12:37 |
| vkmc | haha | 12:38 |
| vkmc | I'll open a bug report | 12:38 |
| *** dynarro has joined #openstack-zaqar | 12:39 | |
| flaper87 | vkmc: danke | 12:45 |
| vkmc | np | 12:46 |
| *** flwang1 has quit IRC | 12:53 | |
| openstackgerrit | Merged openstack/zaqar: Allow for internal pipelines to be defined https://review.openstack.org/168283 | 12:57 |
| flaper87 | vkmc: thanks for the review | 12:58 |
| flaper87 | vkmc: is that test actually being executed ? | 13:24 |
| flaper87 | What pulls in `websocket` ? | 13:24 |
| flaper87 | is that an autoban's dependency ? | 13:24 |
| vkmc | flaper87, nope, is another library | 13:24 |
| vkmc | its websocket-client | 13:24 |
| flaper87 | is that part of the requirements already ? | 13:24 |
| vkmc | and its not being executed automatically | 13:25 |
| vkmc | that I wanted to ask to you :) | 13:25 |
| vkmc | nope | 13:25 |
| flaper87 | ah ok, so my guess was correct | 13:25 |
| flaper87 | mmh, ok. So, that test, as-is, looks like a functional test | 13:25 |
| flaper87 | you're expecting a server to be running | 13:25 |
| flaper87 | which is fine, for a functional test | 13:25 |
| vkmc | flaper87, unit testing for wsgi is doing likewise | 13:26 |
| vkmc | s/doing/done | 13:26 |
| flaper87 | vkmc: it does not connect to the server | 13:27 |
| flaper87 | it just calls the wsgi app object | 13:27 |
| flaper87 | (reviewed the patch) | 13:27 |
| vkmc | thx | 13:28 |
| flaper87 | vkmc: I can help out with the test if you want | 13:28 |
| flaper87 | it's a small change to what you have already | 13:28 |
| vkmc | what change should I do? I'm not following | 13:30 |
| vkmc | :| | 13:30 |
| flaper87 | vkmc: https://review.openstack.org/#/c/144803/11/zaqar/tests/unit/transport/websocket/v1_1/test_queue_lifecycle.py,cm | 13:32 |
| flaper87 | vkmc: that `self.ws` instance is a websocket client that needs to call a server | 13:32 |
| flaper87 | right ? | 13:32 |
| vkmc | flaper87, oh I understand you now | 13:33 |
| vkmc | yes | 13:33 |
| *** exploreshaifali has joined #openstack-zaqar | 13:33 | |
| vkmc | self.ws has an instance of a ws client | 13:33 |
| vkmc | and thorough the test, I use it to send and receive request/responses | 13:34 |
| flaper87 | Right, that's a functional test | 13:34 |
| flaper87 | it requires a zaqar server running | 13:34 |
| vkmc | yup | 13:34 |
| flaper87 | which is fine... for a functional test | 13:34 |
| flaper87 | Now, in order to make it a unittest | 13:34 |
| flaper87 | We'd need to use an instance of the API server. For example, you could have an instance of the Protocol there | 13:35 |
| flaper87 | and call the `onMessage` method directly | 13:35 |
| flaper87 | However, I'd prefer doing it a higher level | 13:35 |
| vkmc | in that level you don't have much control over the stream | 13:35 |
| flaper87 | For example, would it be possible to use the factory directly? | 13:36 |
| vkmc | autobahn starts an eventloop and you cannot assert anything | 13:36 |
| flaper87 | yeah, we don't want to start the event loop there | 13:36 |
| flaper87 | not for the unittest | 13:36 |
| vkmc | what we discussed, a week ago I think, is that another approach we could have is to test the API | 13:37 |
| vkmc | but we won't be testing the transport | 13:37 |
| vkmc | and IMO, the code looked too obscure | 13:37 |
| flaper87 | mmh, why was it obscure ? | 13:38 |
| flaper87 | If you look at our wsgi tests, we call the wsgi app directly without going through the wire | 13:39 |
| flaper87 | that's what I would expect in a unittest for the websocket transport | 13:39 |
| vkmc | but Fla, in the wsgi tests we are using the Falcon framework to communicate with the server | 13:39 |
| flaper87 | sure, but falcon *is* the server. We access the wsgi object directly | 13:39 |
| flaper87 | We can do the same here | 13:40 |
| flaper87 | without requiring a client | 13:40 |
| * flaper87 checks autoban's tests | 13:40 | |
| flaper87 | autobahn* | 13:40 |
| flaper87 | nice, no tests | 13:41 |
| vkmc | http://autobahn.ws/testsuite/ | 13:41 |
| flaper87 | vkmc: thanks | 13:42 |
| vkmc | np | 13:42 |
| vkmc | should I move those tests, then, to the functional side and write new unit ones? | 13:48 |
| *** chandankumar has quit IRC | 13:50 | |
| flaper87 | vkmc: I'd just tweak them a bit and make them unittests. We'll tackle functional tests later | 13:50 |
| flaper87 | what do you say? | 13:50 |
| vkmc | sure | 13:50 |
| flaper87 | again, I can help if you want | 13:51 |
| vkmc | honestly I'm not sure how to make it work without the client | 13:51 |
| flaper87 | vkmc: lets do this, I'll write a patch on top of yours | 13:51 |
| flaper87 | you can merge them together later if you want | 13:51 |
| vkmc | sure | 13:52 |
| vkmc | we have to change everything there though | 13:52 |
| *** sriram has joined #openstack-zaqar | 14:00 | |
| *** JAHoagie has joined #openstack-zaqar | 14:02 | |
| *** ametts has joined #openstack-zaqar | 14:12 | |
| *** ametts_ has joined #openstack-zaqar | 14:13 | |
| *** ametts_ has quit IRC | 14:15 | |
| *** achanda has joined #openstack-zaqar | 14:33 | |
| *** kgriffs|afk is now known as kgriffs | 14:37 | |
| *** JAHoagie has quit IRC | 14:40 | |
| *** achanda has quit IRC | 14:44 | |
| *** cpallares has joined #openstack-zaqar | 14:50 | |
| *** reed has joined #openstack-zaqar | 15:01 | |
| vkmc | >.< | 15:03 |
| cpallares | vkmc: <.> | 15:06 |
| cpallares | Mmm... Visually that doesn't make sense. | 15:07 |
| cpallares | vkmc: ^.^ | 15:07 |
| vkmc | cpallares, ^_^ | 15:08 |
| * cpallares attempts to make noise | 15:09 | |
| cpallares | HI VKMC!!!!!!!!! | 15:09 |
| vkmc | hiiiiii cpallares! | 15:09 |
| cpallares | vkmc: Funny story, every time I try to log into the vpn I sometimes type vkmc instead of vpnc D: | 15:10 |
| vkmc | haha | 15:11 |
| vkmc | Initialization Sequence Completed | 15:11 |
| *** chandankumar has joined #openstack-zaqar | 15:15 | |
| *** sriram has quit IRC | 15:18 | |
| flaper87 | vkmc: why did you write so many tests/ | 15:22 |
| flaper87 | ? | 15:22 |
| flaper87 | ah ? | 15:22 |
| vkmc | because I know you love to have lots of LOC | 15:23 |
| vkmc | and I care about you | 15:23 |
| flaper87 | vkmc: I was this ' ' close to believe you | 15:24 |
| vkmc | flaper87, could you made it work with the app directly? | 15:25 |
| vkmc | gosh this laptop has a spanish keyboard and I'm not used to it | 15:25 |
| * vkmc is frustrated | 15:25 | |
| flaper87 | vkmc: yup, I can submit what I have and you keep going :D | 15:25 |
| vkmc | flaper87, k k | 15:26 |
| vkmc | I'm writting the tests for messages so... I can submit both for later today | 15:26 |
| vkmc | glad to hear you could make it work | 15:26 |
| openstackgerrit | Flavio Percoco proposed openstack/zaqar: Adds message processing to WebSockets driver https://review.openstack.org/144803 | 15:27 |
| flaper87 | vkmc: ^ | 15:27 |
| vkmc | <3 | 15:27 |
| vkmc | thx | 15:27 |
| flaper87 | vkmc: look at the first 3 tests | 15:27 |
| vkmc | oki | 15:28 |
| flaper87 | vkmc: does it make sense? | 15:34 |
| vkmc | flaper87, yes | 15:41 |
| vkmc | thanks | 15:41 |
| flaper87 | COOL | 15:47 |
| vkmc | MUCH WOW | 15:48 |
| *** amitgandhinz has joined #openstack-zaqar | 15:56 | |
| *** mpanetta has joined #openstack-zaqar | 15:56 | |
| *** mpanetta has quit IRC | 15:57 | |
| *** mpanetta has joined #openstack-zaqar | 15:57 | |
| *** JAHoagie has joined #openstack-zaqar | 16:07 | |
| vkmc | flaper87, why you wrote so many tests? | 16:09 |
| flaper87 | vkmc: loool | 16:11 |
| vkmc | flaper87, did you run the tests? | 16:27 |
| *** amitgandhinz has quit IRC | 16:35 | |
| *** amitgandhinz has joined #openstack-zaqar | 16:35 | |
| flaper87 | vkmc: yes, the first 3 | 16:37 |
| flaper87 | :) | 16:37 |
| flaper87 | the rest of the tests are failing | 16:37 |
| vkmc | flaper87, how do you run those? | 16:37 |
| flaper87 | vkmc: tox -epy27 -- glance.tests.unit.v2.test_images_resource.TestImagesController.test_update_add_locations_status | 16:38 |
| flaper87 | erm | 16:38 |
| flaper87 | wait | 16:38 |
| vkmc | s/glance/zaqar | 16:38 |
| flaper87 | nosetests -s zaqar.tests.unit.transport.websocket.v1_1.test_queue_lifecycle:QueueLifecycleBaseTest | 16:38 |
| flaper87 | that | 16:38 |
| flaper87 | vkmc: ^ | 16:38 |
| flaper87 | wrong copy :P | 16:38 |
| flaper87 | I guess eventually they should be executed automatically | 16:38 |
| vkmc | huh, odd, running nosetests test_queue_lifecycle.py fails | 16:39 |
| flaper87 | There should be something in tests/unit/transport/wsgi/test_v1_1.py etc | 16:39 |
| flaper87 | vkmc: mmh, from where are you running that? | 16:40 |
| flaper87 | I excute the tests from zaqar's root | 16:40 |
| flaper87 | you might need to export some variables | 16:40 |
| vkmc | yeah | 16:40 |
| vkmc | thx | 16:42 |
| *** dynarro has quit IRC | 16:59 | |
| *** JAHoagie has quit IRC | 17:01 | |
| *** davideagnello has joined #openstack-zaqar | 17:06 | |
| *** JAHoagie has joined #openstack-zaqar | 17:12 | |
| vkmc | flaper87, can you retrieve a return value from a side effect? | 17:17 |
| *** achanda has joined #openstack-zaqar | 17:24 | |
| *** amitgandhinz has quit IRC | 17:25 | |
| *** chandankumar has quit IRC | 17:28 | |
| *** ametts has quit IRC | 17:32 | |
| *** amitgandhinz has joined #openstack-zaqar | 17:39 | |
| *** ametts has joined #openstack-zaqar | 17:43 | |
| *** chandankumar has joined #openstack-zaqar | 17:52 | |
| vkmc | flaper87, ^ | 17:56 |
| flaper87 | vkmc: mmh, what do you mean? | 18:00 |
| flaper87 | you can use `return_value_ instead | 18:01 |
| vkmc | yeah, but that is used for assertions | 18:02 |
| vkmc | nevermind | 18:03 |
| vkmc | I think this can work | 18:03 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds message processing to WebSockets driver https://review.openstack.org/144803 | 18:08 |
| vkmc | boom | 18:08 |
| vkmc | 800 LOC | 18:08 |
| vkmc | I need to refactor that | 18:08 |
| *** chandankumar has quit IRC | 18:10 | |
| vkmc | flaper87, let me know what you think ^ | 18:22 |
| vkmc | brv | 18:22 |
| vkmc | brb* | 18:23 |
| *** exploreshaifali has quit IRC | 18:33 | |
| *** achanda has quit IRC | 18:38 | |
| *** chandankumar has joined #openstack-zaqar | 18:43 | |
| *** achanda has joined #openstack-zaqar | 18:57 | |
| *** achanda has quit IRC | 18:57 | |
| *** achanda has joined #openstack-zaqar | 18:58 | |
| *** exploreshaifali has joined #openstack-zaqar | 19:29 | |
| *** exploreshaifali has quit IRC | 19:42 | |
| *** ametts has quit IRC | 19:58 | |
| kgriffs | flaper87: so, I heard Zaqar was migrating from Python to Go? | 20:05 |
| * kgriffs ducks | 20:05 | |
| flwang | flaper87: vkmc: ping | 20:06 |
| *** mpanetta has quit IRC | 20:09 | |
| * flaper87 back | 20:10 | |
| flaper87 | flwang: pong | 20:10 |
| flaper87 | reviewing | 20:10 |
| flwang | 8-) | 20:11 |
| flaper87 | kgriffs: LOL | 20:11 |
| flaper87 | no no, haskell | 20:11 |
| flaper87 | :P | 20:11 |
| flaper87 | flwang: u didn't address my comments here: https://review.openstack.org/#/c/142432/ | 20:12 |
| flwang | flaper87: ah, I was looking at the redis driver patch since I believe it should be merged firstly | 20:13 |
| flwang | ok, looking the comments in the rest api patch | 20:13 |
| flaper87 | vkmc: could you please review flwang's redis patch for subscriptions ? | 20:13 |
| flwang | flaper87: i know what happened, seems the rest api patch is overrided | 20:14 |
| flwang | I will upload a new ps soon | 20:14 |
| *** cpallares has quit IRC | 20:52 | |
| vkmc | sure | 20:53 |
| *** sriram has joined #openstack-zaqar | 21:05 | |
| *** sriram has quit IRC | 21:09 | |
| *** sriram has joined #openstack-zaqar | 21:09 | |
| *** chandankumar has quit IRC | 21:11 | |
| *** boris-42 has quit IRC | 21:18 | |
| *** boris-42 has joined #openstack-zaqar | 21:30 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Add REST API for notification/subscriptions https://review.openstack.org/142432 | 21:41 |
| flwang | flaper87: vkmc: ^ | 21:43 |
| vkmc | thanks flwang | 21:55 |
| flwang | vkmc: i'm waiting for your bless on the redis driver :) | 21:55 |
| *** mpanetta has joined #openstack-zaqar | 22:04 | |
| *** mpanetta has quit IRC | 22:05 | |
| *** mpanetta has joined #openstack-zaqar | 22:05 | |
| *** amitgandhinz has quit IRC | 22:18 | |
| vkmc | flwang, https://review.openstack.org/#/c/164893/3/zaqar/storage/redis/subscriptions.py | 22:39 |
| vkmc | a pdb breakpoint went through | 22:39 |
| vkmc | L76-77 | 22:40 |
| flwang | vkmc: shit | 22:40 |
| flwang | vkmc: I will upload a new ps soon | 22:40 |
| flwang | sorry for the shit :( | 22:40 |
| vkmc | hahaha | 22:41 |
| vkmc | no worries | 22:41 |
| flwang | so you're running it on your local? | 22:41 |
| flwang | any other problem? | 22:41 |
| vkmc | not that I can recall of | 22:44 |
| vkmc | it looks really good :) | 22:44 |
| flwang | vkmc: cool | 22:46 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement redis driver for notifications https://review.openstack.org/164893 | 22:46 |
| flwang | vkmc: ^ | 22:47 |
| flwang | vkmc: as flaper87 said, today is the last day of FFE | 22:47 |
| vkmc | yeah | 22:47 |
| flwang | so we need to merge the websocket and the notification service as much as we can :) | 22:47 |
| vkmc | agree | 22:47 |
| vkmc | I'm addressing the comments in the websockets patch | 22:48 |
| vkmc | and I was working on the impl + tests for messages | 22:48 |
| flwang | vkmc: I will revisit as it's ready | 22:48 |
| flwang | pls ping me | 22:48 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds message processing to WebSockets driver https://review.openstack.org/144803 | 22:50 |
| vkmc | :D | 22:50 |
| vkmc | flaper87, come baaaaaaaaaaaaaaaack we need a robot to review our things! | 22:51 |
| *** mpanetta has quit IRC | 23:11 | |
| vkmc | flwang, dunno if you see how we wrote the tests for websockets | 23:12 |
| vkmc | flaper87 suggested me to use mock because the way they were written seemed more to be a functional test rather than a unit test | 23:12 |
| vkmc | but now... I'm a bit constrained on the asserts I can do | 23:12 |
| vkmc | for instance, in L534 here https://review.openstack.org/#/c/144803/14/zaqar/tests/unit/transport/websocket/v1_1/test_queue_lifecycle.py | 23:13 |
| vkmc | what if I would like to retrieve a field in the request to be used in another test? | 23:14 |
| *** sriram has quit IRC | 23:33 | |
| *** kgriffs is now known as kgriffs|afk | 23:35 | |
| *** mpanetta has joined #openstack-zaqar | 23:42 | |
| *** mpanetta has quit IRC | 23:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!