vkmc | flwang, ^? | 00:00 |
---|---|---|
*** achanda_ has joined #openstack-zaqar | 00:03 | |
*** achanda has quit IRC | 00:07 | |
*** achanda_ has quit IRC | 00:08 | |
*** JAHoagie has quit IRC | 00:10 | |
*** mpanetta has joined #openstack-zaqar | 00:12 | |
*** mpanetta has quit IRC | 00:20 | |
flwang | vkmc: just back from lunch | 00:33 |
flwang | looking... | 00:33 |
vkmc | flwang, thx | 00:36 |
*** mpanetta has joined #openstack-zaqar | 00:51 | |
*** mpanetta has joined #openstack-zaqar | 00:52 | |
*** amalagon has joined #openstack-zaqar | 01:04 | |
*** mpanetta has quit IRC | 01:21 | |
*** chandankumar has joined #openstack-zaqar | 01:49 | |
*** chandankumar has quit IRC | 02:04 | |
*** achanda has joined #openstack-zaqar | 02:34 | |
flwang | vkmc: ping | 02:38 |
*** achanda has quit IRC | 02:44 | |
*** achanda has joined #openstack-zaqar | 02:45 | |
vkmc | flwang, pong | 02:59 |
*** amalagon has quit IRC | 03:00 | |
flwang | just reviewed the code https://review.openstack.org/#/c/144803/14/zaqar/tests/unit/transport/websocket/v1_1/test_queue_lifecycle.py would you mind explaining "I'm a bit constrained on the asserts I can do"? | 03:01 |
vkmc | sure | 03:01 |
vkmc | well, for the queue tests it was ok | 03:02 |
vkmc | I'm working on the messages tests | 03:02 |
vkmc | and in some cases, I need to retrieve the response in order to make test cases more real | 03:02 |
vkmc | given that we are using and event loop (server side) | 03:03 |
vkmc | we need to emulate it with side effects | 03:04 |
vkmc | that is... we create a mock for the onMessage function (triggered when the server receives a message) | 03:04 |
flwang | yes, i saw that | 03:05 |
vkmc | and then we retrieve the response with the validator function | 03:05 |
vkmc | thing is... the response is not accessible from outside that function | 03:05 |
vkmc | and I cannot think on an elegant solution for it | 03:05 |
flwang | so you want a 'real' response instead of mocking it? | 03:08 |
vkmc | I would need a way to get the response, as we are doing now, and be able to access it from other tests (not only inside validator()) | 03:10 |
vkmc | hmm its hard to explain without the code | 03:18 |
*** mpanetta has joined #openstack-zaqar | 03:22 | |
*** mpanetta has quit IRC | 03:27 | |
*** amalagon has joined #openstack-zaqar | 03:31 | |
*** jasondotstar has quit IRC | 04:12 | |
*** achanda has quit IRC | 04:12 | |
*** jasondotstar has joined #openstack-zaqar | 04:14 | |
*** achanda has joined #openstack-zaqar | 04:19 | |
*** mpanetta has joined #openstack-zaqar | 04:23 | |
*** achanda has quit IRC | 04:27 | |
*** mpanetta has quit IRC | 04:27 | |
*** achanda has joined #openstack-zaqar | 04:30 | |
*** achanda has quit IRC | 04:40 | |
*** achanda has joined #openstack-zaqar | 04:40 | |
*** chandankumar has joined #openstack-zaqar | 04:47 | |
*** achanda has quit IRC | 04:51 | |
*** JAHoagie has joined #openstack-zaqar | 05:21 | |
*** achanda has joined #openstack-zaqar | 05:22 | |
*** exploreshaifali has joined #openstack-zaqar | 05:40 | |
*** reed has quit IRC | 05:47 | |
*** exploreshaifali has quit IRC | 05:53 | |
*** chandankumar has quit IRC | 06:06 | |
*** achanda has quit IRC | 06:08 | |
*** achanda has joined #openstack-zaqar | 06:08 | |
*** chandankumar has joined #openstack-zaqar | 06:43 | |
*** achanda has quit IRC | 07:05 | |
*** mpanetta has joined #openstack-zaqar | 07:24 | |
*** mpanetta has quit IRC | 07:29 | |
*** JAHoagie has quit IRC | 07:33 | |
*** amalagon has quit IRC | 08:41 | |
*** amalagon has joined #openstack-zaqar | 08:42 | |
*** amalagon has quit IRC | 08:46 | |
-openstackstatus- NOTICE: CI Check/Gate pipelines currently stuck due to a bad dependency creeping in the system. No need to recheck your patches at the moment. | 08:55 | |
*** ChanServ changes topic to "CI Check/Gate pipelines currently stuck due to a bad dependency creeping in the system. No need to recheck your patches at the moment." | 08:55 | |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: Remove QueueController from data to control plane https://review.openstack.org/144340 | 09:59 |
*** achanda has joined #openstack-zaqar | 10:06 | |
*** achanda has quit IRC | 10:10 | |
*** chandankumar has quit IRC | 10:50 | |
*** chandankumar has joined #openstack-zaqar | 11:04 | |
*** flaper87 has quit IRC | 11:10 | |
*** vkmc has quit IRC | 11:10 | |
*** flaper87 has joined #openstack-zaqar | 11:22 | |
*** mpanetta has joined #openstack-zaqar | 11:26 | |
*** flaper87 has quit IRC | 11:26 | |
*** flaper87 has joined #openstack-zaqar | 11:26 | |
*** mpanetta has quit IRC | 11:30 | |
*** chandankumar has quit IRC | 11:38 | |
*** amalagon has joined #openstack-zaqar | 11:41 | |
*** ChanServ changes topic to "OpenStack Queuing and Notification Service || Smile :D || Meetings every Monday @ 21:00 UTC/15:00 UTC || Wiki: https://wiki.openstack.org/wiki/Zaqar || Paste: http://paste.openstack.org/ || Send messages and make some noise :D" | 11:51 | |
-openstackstatus- NOTICE: Check/Gate unstuck, feel free to recheck your abusively-failed changes. | 11:51 | |
*** vkmc has joined #openstack-zaqar | 11:51 | |
vkmc | morning | 11:51 |
flaper87 | vkmc: morning girl | 12:26 |
flaper87 | I'm rechecking all the patches now that the gate is unstuck | 12:26 |
vkmc | thx flaper87 | 12:26 |
*** chandankumar has joined #openstack-zaqar | 12:27 | |
*** mpanetta has joined #openstack-zaqar | 12:39 | |
*** dynarro has joined #openstack-zaqar | 12:44 | |
openstackgerrit | Merged openstack/zaqar: Implement redis driver for notifications https://review.openstack.org/164893 | 13:05 |
*** sriram has joined #openstack-zaqar | 13:05 | |
flaper87 | w00000t | 13:05 |
openstackgerrit | Merged openstack/zaqar: Adds message processing to WebSockets driver https://review.openstack.org/144803 | 13:06 |
vkmc | :D | 13:06 |
vkmc | omg omg omg | 13:06 |
*** chandankumar has quit IRC | 13:23 | |
*** JAHoagie has joined #openstack-zaqar | 13:27 | |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: Move devstack's Zaqar code into the codebase https://review.openstack.org/169305 | 13:30 |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: Move devstack's Zaqar code into the codebase https://review.openstack.org/169305 | 13:33 |
flaper87 | vkmc: https://review.openstack.org/#/c/142432/ | 13:36 |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: Add websockets to our test suite https://review.openstack.org/169313 | 13:45 |
*** amitgandhinz has joined #openstack-zaqar | 13:46 | |
flaper87 | vkmc: ^ | 13:46 |
vkmc | thx | 13:47 |
vkmc | one nit | 13:47 |
vkmc | a temp file made it through https://review.openstack.org/#/c/169313/1/tests/unit/transport/websocket/test_v1_1.py~ | 13:47 |
vkmc | and let me see the devstack one | 13:48 |
flaper87 | fuck | 13:49 |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: Add websockets to our test suite https://review.openstack.org/169313 | 13:50 |
flaper87 | vkmc: fixed | 13:50 |
vkmc | tx | 13:51 |
*** ametts has joined #openstack-zaqar | 13:59 | |
*** cpallares has joined #openstack-zaqar | 14:00 | |
*** JAHoagie has quit IRC | 14:13 | |
*** kgriffs|afk is now known as kgriffs | 14:28 | |
*** chandankumar has joined #openstack-zaqar | 14:50 | |
flaper87 | vkmc: https://review.openstack.org/#/c/166145/ | 14:55 |
flaper87 | vkmc: btw, https://review.openstack.org/#/c/144340/ <- all green! | 14:57 |
flaper87 | :) | 14:57 |
* vkmc nods | 14:57 | |
vkmc | w00000t | 14:57 |
flaper87 | flwang: ^^^^^^ | 14:57 |
flaper87 | pls pls pls, review zaqar patches | 14:57 |
flaper87 | pls | 14:57 |
flaper87 | I know you're a busy man but PLEASE! | 14:57 |
vkmc | flwang, ^^^^^^^^^ | 14:57 |
vkmc | hahaha | 14:57 |
flaper87 | :P | 14:58 |
flaper87 | vkmc: team work! | 14:58 |
* flaper87 highfives vkmc | 14:58 | |
* vkmc highfives back flaper87 | 14:58 | |
*** JAHoagie has joined #openstack-zaqar | 15:06 | |
openstackgerrit | Victoria MartÃnez de la Cruz proposed openstack/zaqar: API v1.1 Messages endpoints https://review.openstack.org/166076 | 15:13 |
*** reed has joined #openstack-zaqar | 15:13 | |
vkmc | flaper87, ^ | 15:15 |
flaper87 | vkmc: already clicked ! | 15:18 |
* flaper87 is one step ahead | 15:18 | |
vkmc | flaper87, ^ | 15:18 |
* vkmc can be really annoying | 15:18 | |
flaper87 | vkmc: ^ | 15:19 |
*** exploreshaifali has joined #openstack-zaqar | 15:25 | |
*** chandankumar has quit IRC | 15:27 | |
openstackgerrit | Merged openstack/zaqar: Updates the readme.rst file to add dependencies steps https://review.openstack.org/166145 | 15:31 |
*** amalagon has quit IRC | 15:52 | |
*** chandankumar has joined #openstack-zaqar | 15:55 | |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: API v1.1 Messages endpoints https://review.openstack.org/166076 | 16:00 |
*** JAHoagie has quit IRC | 16:02 | |
*** JAHoagie has joined #openstack-zaqar | 16:10 | |
flaper87 | vkmc: https://review.openstack.org/#/c/142432/ | 16:11 |
flaper87 | :P | 16:11 |
*** JAHoagie has quit IRC | 16:14 | |
*** kgriffs is now known as kgriffs|afk | 16:21 | |
*** JAHoagie has joined #openstack-zaqar | 16:42 | |
*** chandankumar has quit IRC | 16:44 | |
*** chandankumar has joined #openstack-zaqar | 16:48 | |
*** dynarro has quit IRC | 16:57 | |
*** amalagon has joined #openstack-zaqar | 17:03 | |
*** JAHoagie has quit IRC | 17:04 | |
*** chandankumar has quit IRC | 17:06 | |
*** amalagon has quit IRC | 17:08 | |
*** JAHoagie has joined #openstack-zaqar | 17:21 | |
*** chandankumar has joined #openstack-zaqar | 17:22 | |
*** achanda has joined #openstack-zaqar | 17:23 | |
vkmc | flaper87, I think I found a bug | 17:29 |
vkmc | when queues are lazily created we don't perform any validation | 17:30 |
*** JAHoagie has quit IRC | 17:31 | |
vkmc | https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v2_0/messages.py#L176-L177 | 17:31 |
flaper87 | vkmc: I think you're right | 17:32 |
flaper87 | :/ | 17:32 |
flaper87 | We don't need to check if the queue exists but we do need to check the name | 17:32 |
flaper87 | As in, the lenght | 17:32 |
vkmc | yeah | 17:32 |
vkmc | and ifs ascii or not | 17:32 |
vkmc | s/ifs/if it is | 17:33 |
flaper87 | right | 17:33 |
flaper87 | vkmc: good catch | 17:33 |
sriram | I think I'm the one to blame here. I wrote that code :/ ( if I remember correctly) | 17:33 |
vkmc | >:) | 17:33 |
vkmc | no sriram... its kgriffs|afk fault | 17:33 |
flaper87 | sriram: hehe, it's always kgriffs|afk fault | 17:33 |
flaper87 | LOL | 17:33 |
vkmc | lol | 17:33 |
sriram | heh | 17:33 |
flaper87 | sriram: we miss you here :( | 17:34 |
flaper87 | come back | 17:34 |
flaper87 | please | 17:34 |
vkmc | yeah | 17:34 |
flaper87 | I can pay you with gummy bears | 17:34 |
* vkmc sad panda | 17:34 | |
* flaper87 big sad, hungry panda | 17:34 | |
sriram | haha, maybe I can pick up on some things to work on weekends :) | 17:34 |
sriram | do you still have low hanging fruits available? :P | 17:35 |
vkmc | there will be always a low hanging fruit in Zaqar | 17:38 |
*** mpanetta has quit IRC | 17:39 | |
sriram | cool, I'll go take a look, and pick something up to work on weekends. | 17:39 |
*** mpanetta has joined #openstack-zaqar | 17:39 | |
vkmc | yaay | 17:40 |
vkmc | go sriram :D | 17:40 |
sriram | :) | 17:40 |
*** JAHoagie has joined #openstack-zaqar | 17:41 | |
flaper87 | http://readwrite.com/2015/03/30/github-biggest-ddos-attack | 17:41 |
flaper87 | vkmc: flwang https://review.openstack.org/#/c/169305/ | 17:44 |
flaper87 | vkmc: https://review.openstack.org/#/c/142432/ | 17:44 |
* flaper87 keeps putting preasure on vkmc | 17:44 | |
vkmc | I want gummybears | 17:51 |
sriram | might actually go out and buy some today :P | 17:52 |
vkmc | flaper87, today is the last day for features | 17:52 |
vkmc | sriram, you totally should | 17:52 |
mpanetta | sriram: Don't buy the sugar free ones! | 17:53 |
vkmc | shh mpanetta | 17:53 |
vkmc | the sugar free ones are the most fun | 17:53 |
sriram | mpanetta: yeah, I heard they're no good. :P | 17:53 |
mpanetta | vkmc: haha, for a joke maybe :P | 17:53 |
mpanetta | sriram: something like that :P | 17:54 |
vkmc | sriram, mpanetta, will you be attending the summit? | 17:54 |
mpanetta | Not I | 17:54 |
sriram | nope | 17:54 |
vkmc | boo | 17:54 |
mpanetta | amitgandhinz: is tho | 17:54 |
vkmc | ok, I won't bring gummybears then | 17:55 |
sriram | malini might be as well ;) | 17:55 |
vkmc | :D | 17:55 |
amitgandhinz | yup, malini and I will be there | 17:59 |
vkmc | yaay, hope we can finally meet! | 18:10 |
*** chandankumar has quit IRC | 18:31 | |
openstackgerrit | Merged openstack/zaqar: Add REST API for notification/subscriptions https://review.openstack.org/142432 | 18:31 |
vkmc | wut wut wut | 18:33 |
*** achanda has quit IRC | 18:49 | |
*** kgriffs|afk is now known as kgriffs | 18:54 | |
*** kgriffs is now known as kgriffs|afk | 18:54 | |
*** cpallares has quit IRC | 18:55 | |
*** ametts has quit IRC | 18:59 | |
*** dynarro has joined #openstack-zaqar | 19:16 | |
*** achanda has joined #openstack-zaqar | 19:27 | |
*** reed has quit IRC | 19:36 | |
*** reed has joined #openstack-zaqar | 19:36 | |
flaper87 | vkmc: something urgent that needs to be taken care of ? | 19:54 |
flaper87 | flwang: around? | 19:54 |
vkmc | flaper87, nothing I can recall of | 19:54 |
vkmc | I'm fixing some stuff, I'll upload soon for review | 19:55 |
flaper87 | vkmc: coole, ping me | 19:55 |
flwang | flaper87: i'm here | 19:59 |
flwang | i'm reviewing your devstack patch | 19:59 |
flaper87 | flwang: hey :) | 19:59 |
flaper87 | flwang: thank you! | 19:59 |
flaper87 | so, most of your patches landed | 19:59 |
flaper87 | what's missing now? | 19:59 |
flwang | and going to rebase the webhook patch | 19:59 |
flaper87 | how can I help? | 19:59 |
flaper87 | AWESOME! | 19:59 |
flwang | if you can be around for 1 or 2 hours, i need your review :) | 20:00 |
flaper87 | I'll likely be | 20:00 |
flwang | but I assume it is not so urgent | 20:00 |
flwang | flaper87: https://review.openstack.org/#/c/169305/2/devstack/settings line 3 | 20:00 |
flwang | why "we have to add ec2-api to enabled services for screen_it to work"? | 20:01 |
flaper87 | LOL | 20:06 |
flaper87 | I copy/paste that | 20:06 |
flaper87 | it's jsut a comment, lemme fix it | 20:06 |
openstackgerrit | Flavio Percoco proposed openstack/zaqar: Move devstack's Zaqar code into the codebase https://review.openstack.org/169305 | 20:07 |
flaper87 | flwang: ^ | 20:07 |
flwang | flaper87: :) | 20:13 |
flwang | flaper87: so do we need to keep the consistence with the plugin in devstack in the future? | 20:14 |
flaper87 | flwang: no, the code in devstack will go away | 20:16 |
flaper87 | we need to land this first | 20:16 |
flaper87 | then make the gate use the plugin | 20:16 |
flaper87 | and then remove the code in devstack | 20:16 |
flwang | flaper87: ok, is it a new plan for all the services not the 'integrated' status? | 20:19 |
*** achanda has quit IRC | 20:20 | |
*** dynarro has quit IRC | 20:29 | |
vkmc | :x | 20:48 |
vkmc | sorry | 20:48 |
openstackgerrit | Victoria MartÃnez de la Cruz proposed openstack/zaqar: API v1.1 Messages endpoints https://review.openstack.org/166076 | 20:49 |
vkmc | flaper87, flwang ^ | 20:59 |
flwang | vkmc: will do | 20:59 |
vkmc | thx | 21:00 |
* flaper87 clicks | 21:00 | |
vkmc | good morning :) | 21:00 |
flaper87 | flwang: it's more like most of the projects will follow that | 21:00 |
flwang | flaper87: ok, cool | 21:03 |
*** sriram has quit IRC | 21:12 | |
*** achanda has joined #openstack-zaqar | 21:14 | |
*** mpanetta has quit IRC | 21:20 | |
*** exploreshaifali has quit IRC | 21:25 | |
*** amitgandhinz has quit IRC | 22:01 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement webhook notifier driver https://review.openstack.org/151529 | 22:07 |
*** flwang has quit IRC | 23:00 | |
*** flwang has joined #openstack-zaqar | 23:13 | |
*** davideagnello has quit IRC | 23:15 | |
*** davideagnello has joined #openstack-zaqar | 23:24 | |
*** achanda has quit IRC | 23:41 | |
*** achanda has joined #openstack-zaqar | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!