*** openstackgerrit has quit IRC | 00:01 | |
*** openstackgerrit has joined #openstack-zaqar | 00:02 | |
*** achanda has quit IRC | 00:02 | |
*** david-lyle has joined #openstack-zaqar | 00:03 | |
*** mdnadeem_ has joined #openstack-zaqar | 00:06 | |
flwang | https://etherpad.openstack.org/p/mitaka-zaqar-client | 00:06 |
---|---|---|
*** JAHoagie has quit IRC | 00:08 | |
*** dynarro has joined #openstack-zaqar | 00:14 | |
*** flwang has quit IRC | 00:25 | |
*** mdnadeem_ has quit IRC | 00:34 | |
*** mdnadeem_ has joined #openstack-zaqar | 00:39 | |
*** david-lyle has quit IRC | 00:42 | |
*** dynarro has quit IRC | 00:49 | |
*** david-lyle has joined #openstack-zaqar | 00:50 | |
*** flwang has joined #openstack-zaqar | 00:57 | |
*** csoukup has joined #openstack-zaqar | 01:00 | |
*** flwang has quit IRC | 01:01 | |
*** dynarro has joined #openstack-zaqar | 01:01 | |
*** csoukup has quit IRC | 01:04 | |
*** flwang has joined #openstack-zaqar | 01:21 | |
*** mdnadeem_ has quit IRC | 01:25 | |
*** dynarro has quit IRC | 01:25 | |
*** inteq has joined #openstack-zaqar | 01:30 | |
*** david-lyle has quit IRC | 01:32 | |
*** njohnston is now known as nate_gone | 01:35 | |
*** flwang has quit IRC | 01:39 | |
*** dynarro has joined #openstack-zaqar | 01:56 | |
*** nate_gone is now known as njohnston | 01:56 | |
*** david-lyle has joined #openstack-zaqar | 01:58 | |
*** flwang has joined #openstack-zaqar | 02:03 | |
*** flwang has quit IRC | 02:10 | |
*** achanda has joined #openstack-zaqar | 02:25 | |
*** njohnston is now known as nate_gone | 02:38 | |
*** dynarro has quit IRC | 02:39 | |
*** david-lyle has quit IRC | 02:41 | |
*** khushbu has joined #openstack-zaqar | 02:45 | |
*** flwang has joined #openstack-zaqar | 02:45 | |
*** flwang has quit IRC | 02:46 | |
*** flwang has joined #openstack-zaqar | 02:47 | |
*** david-lyle has joined #openstack-zaqar | 02:49 | |
*** nate_gone is now known as njohnston | 02:52 | |
*** david-lyle has quit IRC | 02:58 | |
*** khushbu has quit IRC | 03:00 | |
*** njohnston is now known as nate_gone | 03:03 | |
*** flwang has quit IRC | 03:17 | |
*** khushbu has joined #openstack-zaqar | 03:19 | |
*** achanda has quit IRC | 03:25 | |
*** david-lyle has joined #openstack-zaqar | 03:29 | |
*** david-lyle has quit IRC | 03:34 | |
*** khushbu has quit IRC | 03:41 | |
*** achanda has joined #openstack-zaqar | 03:45 | |
*** khushbu_ has joined #openstack-zaqar | 03:46 | |
*** khushbu_ has quit IRC | 03:57 | |
*** flwang has joined #openstack-zaqar | 04:01 | |
*** flwang has quit IRC | 04:05 | |
*** khushbu_ has joined #openstack-zaqar | 04:07 | |
*** pt_15 has quit IRC | 04:08 | |
*** akanksha_ has quit IRC | 04:08 | |
*** khushbu_ has quit IRC | 04:09 | |
*** itisha has quit IRC | 04:11 | |
*** khushbu_ has joined #openstack-zaqar | 04:21 | |
*** khushbu_ has quit IRC | 04:24 | |
*** khushbu_ has joined #openstack-zaqar | 04:29 | |
*** khushbu_ has quit IRC | 04:43 | |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Adding 'messaging' as prefix for Zaqar commands https://review.openstack.org/240112 | 04:44 |
*** khushbu_ has joined #openstack-zaqar | 04:46 | |
*** khushbu_ has quit IRC | 04:51 | |
*** khushbu_ has joined #openstack-zaqar | 04:55 | |
openstackgerrit | Merged openstack/python-zaqarclient: improve readme contents https://review.openstack.org/235247 | 04:56 |
*** nate_gone is now known as njohnston | 04:57 | |
*** david-lyle has joined #openstack-zaqar | 05:00 | |
*** khushbu_ has quit IRC | 05:02 | |
*** davideagnello has quit IRC | 05:06 | |
*** david-ly_ has joined #openstack-zaqar | 05:19 | |
*** david-lyle has quit IRC | 05:19 | |
*** david-ly_ has quit IRC | 05:37 | |
*** david-lyle has joined #openstack-zaqar | 05:41 | |
*** mdnadeem_ has joined #openstack-zaqar | 05:55 | |
*** dynarro has joined #openstack-zaqar | 06:04 | |
*** mdnadeem_ has quit IRC | 06:06 | |
*** njohnston is now known as nate_gone | 06:41 | |
*** dynarro has quit IRC | 06:57 | |
*** khushbu has joined #openstack-zaqar | 06:59 | |
*** nate_gone is now known as njohnston | 07:03 | |
*** david-lyle has quit IRC | 07:11 | |
*** david-lyle has joined #openstack-zaqar | 07:11 | |
*** njohnston is now known as nate_gone | 07:13 | |
*** kgriffs|afk has quit IRC | 07:15 | |
*** david-lyle has quit IRC | 07:15 | |
*** kgriffs|afk has joined #openstack-zaqar | 07:21 | |
*** kgriffs|afk is now known as kgriffs | 07:21 | |
*** khushbu has quit IRC | 07:24 | |
*** khushbu_ has joined #openstack-zaqar | 07:28 | |
*** achanda has quit IRC | 07:39 | |
*** khushbu_ has quit IRC | 07:40 | |
*** david-lyle has joined #openstack-zaqar | 07:40 | |
*** khushbu_ has joined #openstack-zaqar | 07:42 | |
*** khushbu_ has quit IRC | 07:45 | |
*** nate_gone is now known as njohnston | 08:05 | |
*** david-lyle has quit IRC | 08:12 | |
*** khushbu has joined #openstack-zaqar | 08:12 | |
*** khushbu has quit IRC | 08:15 | |
*** khushbu_ has joined #openstack-zaqar | 08:28 | |
*** khushbu_ has quit IRC | 08:31 | |
*** khushbu_ has joined #openstack-zaqar | 08:38 | |
*** khushbu_ has quit IRC | 08:40 | |
*** khushbu_ has joined #openstack-zaqar | 08:49 | |
*** khushbu_ has quit IRC | 08:51 | |
*** achanda has joined #openstack-zaqar | 09:00 | |
*** achanda has quit IRC | 09:05 | |
*** khushbu_ has joined #openstack-zaqar | 09:06 | |
*** bradjones has quit IRC | 09:07 | |
*** khushbu_ has quit IRC | 09:08 | |
*** akanksha_ has joined #openstack-zaqar | 10:34 | |
*** bradjones has joined #openstack-zaqar | 10:45 | |
*** bradjones has joined #openstack-zaqar | 10:45 | |
*** vkmc has quit IRC | 12:12 | |
*** flaper87 has quit IRC | 12:14 | |
*** cpallares has quit IRC | 12:18 | |
*** khushbu has joined #openstack-zaqar | 12:39 | |
*** khushbu has quit IRC | 12:48 | |
*** khushbu has joined #openstack-zaqar | 12:50 | |
*** vkmc has joined #openstack-zaqar | 12:58 | |
*** cpallares has joined #openstack-zaqar | 12:59 | |
*** flaper87 has joined #openstack-zaqar | 12:59 | |
*** khushbu has quit IRC | 13:03 | |
*** cpallares has quit IRC | 13:04 | |
*** flaper87 has quit IRC | 13:04 | |
*** vkmc has quit IRC | 13:06 | |
*** flaper87 has joined #openstack-zaqar | 13:06 | |
*** vkmc has joined #openstack-zaqar | 13:07 | |
*** khushbu_ has joined #openstack-zaqar | 13:08 | |
*** flaper87 has quit IRC | 13:12 | |
*** sriram has joined #openstack-zaqar | 13:14 | |
*** flaper87 has joined #openstack-zaqar | 13:15 | |
*** vkmc has quit IRC | 13:16 | |
*** flaper87 has quit IRC | 13:19 | |
*** khushbu_ has quit IRC | 13:29 | |
*** khushbu_ has joined #openstack-zaqar | 13:41 | |
*** vkmc has joined #openstack-zaqar | 13:45 | |
*** vkmc has quit IRC | 13:52 | |
*** cpallares has joined #openstack-zaqar | 14:06 | |
*** vkmc has joined #openstack-zaqar | 14:07 | |
*** khushbu_ has quit IRC | 14:07 | |
*** cpallares has quit IRC | 14:11 | |
*** vkmc has quit IRC | 14:12 | |
*** mpanetta has joined #openstack-zaqar | 14:16 | |
*** csoukup has joined #openstack-zaqar | 14:19 | |
*** akanksha_ has quit IRC | 14:28 | |
*** khushbu_ has joined #openstack-zaqar | 14:32 | |
*** vkmc has joined #openstack-zaqar | 14:34 | |
*** cpallares has joined #openstack-zaqar | 14:35 | |
*** khushbu_ has quit IRC | 14:46 | |
*** khushbu_ has joined #openstack-zaqar | 14:49 | |
*** khushbu_ has quit IRC | 15:22 | |
*** khushbu has joined #openstack-zaqar | 15:27 | |
*** pt_15 has joined #openstack-zaqar | 15:30 | |
*** khushbu has quit IRC | 15:31 | |
*** akanksha_ has joined #openstack-zaqar | 15:32 | |
*** khushbu_ has joined #openstack-zaqar | 15:44 | |
*** khushbu_ has quit IRC | 15:48 | |
*** kgriffs is now known as kgriffs|afk | 15:50 | |
*** kgriffs|afk is now known as kgriffs | 15:55 | |
*** ametts has joined #openstack-zaqar | 16:08 | |
*** cpallares has quit IRC | 16:25 | |
*** vkmc has quit IRC | 16:27 | |
*** achanda has joined #openstack-zaqar | 16:42 | |
*** davideagnello has joined #openstack-zaqar | 16:43 | |
openstackgerrit | Akanksha Srivastava proposed openstack/zaqar: Decorator fuction to Validate UUIDs in Redis Driver https://review.openstack.org/165632 | 16:43 |
openstackgerrit | Akanksha Srivastava proposed openstack/zaqar: Decorator fuction to Validate UUIDs in Redis Driver https://review.openstack.org/165632 | 16:44 |
*** davideagnello has quit IRC | 16:44 | |
*** itisha has joined #openstack-zaqar | 16:45 | |
*** davideagnello has joined #openstack-zaqar | 16:45 | |
*** vkmc has joined #openstack-zaqar | 16:45 | |
*** cpallares has joined #openstack-zaqar | 16:47 | |
*** khushbu_ has joined #openstack-zaqar | 17:18 | |
*** khushbu_ has quit IRC | 17:32 | |
*** khushbu_ has joined #openstack-zaqar | 17:37 | |
*** khushbu_ has quit IRC | 17:47 | |
*** kgriffs is now known as kgriffs|afk | 17:55 | |
openstackgerrit | Akanksha Srivastava proposed openstack/zaqar: Decorator fuction to Validate UUIDs in Redis Driver https://review.openstack.org/165632 | 17:57 |
akanksha_ | ryansb: ping? | 17:58 |
ryansb | akanksha_: ack | 17:58 |
akanksha_ | I had a doubt about the code. https://github.com/openstack/zaqar/blob/master/zaqar/storage/redis/messages.py#L393 This line in this method, I cannot quite understand whats happening with the pipeline. | 18:01 |
ryansb | so what's your question? | 18:08 |
ryansb | the pipeline opens up a sort of transaction with redis | 18:09 |
ryansb | basically grouping all of the GETs for the group of messages and sending them in one shot | 18:10 |
akanksha_ | my question is how is the deletion of messages carried out? And whether or not there is a call to the single delete function in messages.py | 18:10 |
ryansb | uh, you sent a link to the bulk_get function | 18:10 |
akanksha_ | ryansb: the code is similar in all the bulk_* where a pipe is created and then according to bulk_get or bulk_delete the hgetall() and delete() is called on the pipeline. | 18:17 |
akanksha_ | My question was that whether these bulk_get and bulk_delete function utilise the single delete or single get functions or not? | 18:18 |
akanksha_ | Sorry for being unclear earlier. | 18:18 |
ryansb | no, so the bulk_delete function takes many redis "delete" commands and puts them into a single big request | 18:19 |
ryansb | then sends them to the redis server, where it processes them all and sends a response back | 18:19 |
ryansb | does that make sense? | 18:19 |
akanksha_ | Yes it does. I was trying to find out the various places that maybe required for using my validate uuid decorator. I think then I will need to add support for bulk_ functions as well in the decorator. | 18:20 |
ryansb | ah, I see, yes that'd be right | 18:20 |
akanksha_ | Thanks a lot ryansb :) | 18:20 |
ryansb | also, you should try doing the zqar benchmarks with and without your function if you can | 18:20 |
ryansb | so you can see if there's any performance implications | 18:21 |
akanksha_ | ^Hmm. Alright. Will look into that. :) | 18:21 |
*** mpanetta has quit IRC | 18:58 | |
*** kgriffs|afk is now known as kgriffs | 19:00 | |
*** mpanetta has joined #openstack-zaqar | 19:04 | |
akanksha_ | kgriffs: can you review this please? https://review.openstack.org/#/c/234769/ I came across your NOTE in the code to make this change and then implemented it | 19:07 |
*** mpanetta has quit IRC | 19:09 | |
*** kgriffs is now known as kgriffs|afk | 19:41 | |
*** kgriffs|afk is now known as kgriffs | 19:55 | |
*** achanda has quit IRC | 20:09 | |
*** davideagnello has quit IRC | 20:19 | |
*** davideagnello has joined #openstack-zaqar | 20:20 | |
*** achanda has joined #openstack-zaqar | 21:01 | |
*** sriram has quit IRC | 21:24 | |
*** ametts has quit IRC | 21:25 | |
*** achanda has quit IRC | 21:33 | |
*** kgriffs is now known as kgriffs|afk | 21:52 | |
*** kgriffs|afk is now known as kgriffs | 22:02 | |
*** dynarro has joined #openstack-zaqar | 23:00 | |
*** njohnston is now known as nate_gone | 23:00 | |
*** dynarro has quit IRC | 23:15 | |
*** achanda has joined #openstack-zaqar | 23:16 | |
*** csoukup has quit IRC | 23:17 | |
Eva-i | Hello. Is it important how to name local branch? For example, I have a bug which can be only solved by many code changes. So locally I will need to have many branches to solve one single bug. And these branches can't have same name. Can I name my first branch bug/1234567_0 and the second one bug/1234567_1? | 23:31 |
ryansb | you can make multiple commits to a branch, say bug/1234 | 23:33 |
ryansb | and when you git review they will all have that name as their ropic | 23:33 |
ryansb | err, topic | 23:33 |
ryansb | that way you can have all the patches as members of one series, which makes reviewers happy | 23:33 |
Eva-i | Will they be shown in gerrit as single code change or multiple code changes? | 23:34 |
*** stevelle has joined #openstack-zaqar | 23:34 | |
ryansb | multiple patches | 23:34 |
stevelle | what are pool groups and where is this discussed? | 23:34 |
ryansb | 1 commit == 1 patch | 23:35 |
ryansb | branch name == topic name of all the patches | 23:35 |
Eva-i | ryansb: by multiple patches you mean multiple "patch sets" as shown in gerrit? For example, in this change https://review.openstack.org/#/c/220849/ there are three patches? | 23:45 |
*** achanda has quit IRC | 23:47 | |
*** achanda has joined #openstack-zaqar | 23:49 | |
*** _elmiko is now known as elmiko | 23:50 | |
Eva-i | ryansb: lets use git and gerrit terminology. "git commit" = new "code change", "git commit -a --amend" = new "patch set"? | 23:53 |
*** kgriffs is now known as kgriffs|afk | 23:57 | |
*** achanda has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!