*** david-lyle has joined #openstack-zaqar | 00:03 | |
*** achanda has joined #openstack-zaqar | 00:04 | |
*** elmiko is now known as _elmiko | 00:09 | |
*** achanda has quit IRC | 00:11 | |
Eva-i | ryansb: I'm going to sleep now, but you still can leave a message for me if you want, I'll check it out later | 00:15 |
---|---|---|
*** nate_gone is now known as njohnston | 00:20 | |
*** davideagnello has quit IRC | 00:23 | |
*** kgriffs|afk is now known as kgriffs | 00:29 | |
ryansb | Eva-i: I mean multiple patches, and you could --amend them and produce new patchsets | 00:31 |
*** njohnston is now known as nate_gone | 00:34 | |
*** nate_gone is now known as njohnston | 00:36 | |
*** akanksha_ has quit IRC | 00:38 | |
*** njohnston is now known as nate_gone | 00:50 | |
*** nate_gone is now known as njohnston | 00:57 | |
*** dynarro has joined #openstack-zaqar | 01:00 | |
*** kgriffs is now known as kgriffs|afk | 01:01 | |
*** exploreshaifali has joined #openstack-zaqar | 01:04 | |
*** achanda has joined #openstack-zaqar | 01:26 | |
*** achanda has quit IRC | 01:30 | |
*** njohnston is now known as nate_gone | 01:36 | |
*** khushbu has joined #openstack-zaqar | 01:56 | |
*** khushbu_ has joined #openstack-zaqar | 01:56 | |
*** khushbu has quit IRC | 01:56 | |
*** khushbu_ has quit IRC | 01:56 | |
*** khushbu_ has joined #openstack-zaqar | 02:02 | |
*** mdnadeem_ has joined #openstack-zaqar | 02:05 | |
*** khushbu_ has quit IRC | 02:12 | |
*** khushbu_ has joined #openstack-zaqar | 02:16 | |
*** khushbu_ has quit IRC | 02:40 | |
*** dynarro has quit IRC | 02:45 | |
*** achanda has joined #openstack-zaqar | 02:56 | |
*** ameade has quit IRC | 03:06 | |
*** ameade has joined #openstack-zaqar | 03:09 | |
*** achanda has quit IRC | 03:15 | |
*** exploreshaifali has quit IRC | 03:17 | |
*** david-lyle has quit IRC | 03:20 | |
*** david-lyle has joined #openstack-zaqar | 03:21 | |
*** mdnadeem_ has quit IRC | 03:25 | |
*** david-lyle has quit IRC | 03:25 | |
*** khushbu_ has joined #openstack-zaqar | 03:27 | |
*** khushbu_ has quit IRC | 03:30 | |
*** khushbu has joined #openstack-zaqar | 03:41 | |
*** khushbu has quit IRC | 03:47 | |
*** khushbu_ has joined #openstack-zaqar | 03:56 | |
*** khushbu_ has quit IRC | 03:57 | |
*** davideagnello has joined #openstack-zaqar | 03:58 | |
*** khushbu_ has joined #openstack-zaqar | 04:01 | |
*** khushbu_ has quit IRC | 04:05 | |
*** _elmiko has quit IRC | 04:07 | |
*** _elmiko has joined #openstack-zaqar | 04:08 | |
*** khushbu_ has joined #openstack-zaqar | 04:09 | |
*** achanda has joined #openstack-zaqar | 04:43 | |
*** david-lyle has joined #openstack-zaqar | 04:53 | |
*** david-lyle has quit IRC | 04:57 | |
*** khushbu_ has quit IRC | 04:58 | |
*** david-lyle has joined #openstack-zaqar | 04:58 | |
*** david-lyle has quit IRC | 05:10 | |
*** khushbu_ has joined #openstack-zaqar | 05:23 | |
*** khushbu_ has quit IRC | 05:27 | |
*** khushbu_ has joined #openstack-zaqar | 05:30 | |
*** khushbu_ has quit IRC | 05:48 | |
*** khushbu_ has joined #openstack-zaqar | 05:51 | |
*** openstack has joined #openstack-zaqar | 06:04 | |
*** khushbu_ has quit IRC | 06:14 | |
*** khushbu_ has joined #openstack-zaqar | 06:20 | |
*** khushbu_ has quit IRC | 06:24 | |
*** khushbu_ has joined #openstack-zaqar | 06:29 | |
*** itisha has quit IRC | 06:41 | |
*** pt_15 has quit IRC | 06:48 | |
*** openstackgerrit has quit IRC | 07:01 | |
*** openstackgerrit has joined #openstack-zaqar | 07:01 | |
*** khushbu_ has quit IRC | 07:06 | |
*** openstack has joined #openstack-zaqar | 07:19 | |
*** khushbu_ has joined #openstack-zaqar | 07:24 | |
*** khushbu_ has quit IRC | 07:29 | |
*** khushbu_ has joined #openstack-zaqar | 07:34 | |
*** khushbu_ has quit IRC | 07:35 | |
*** khushbu_ has joined #openstack-zaqar | 07:38 | |
*** achanda has quit IRC | 07:43 | |
*** achanda has joined #openstack-zaqar | 07:46 | |
*** achanda has quit IRC | 07:47 | |
*** khushbu_ has quit IRC | 08:07 | |
*** pt_15 has joined #openstack-zaqar | 08:07 | |
*** akanksha_ has joined #openstack-zaqar | 08:08 | |
*** itisha has joined #openstack-zaqar | 08:17 | |
*** khushbu has joined #openstack-zaqar | 08:23 | |
*** khushbu has quit IRC | 08:24 | |
*** khushbu_ has joined #openstack-zaqar | 08:34 | |
*** khushbu_ has quit IRC | 08:35 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-zaqarclient: Updated from global requirements https://review.openstack.org/232905 | 09:10 |
Eva-i | ryansb: thanks for answering, I'll put everything in one single "code change", but if this change will be to big, it will not be hard for me to split this change. I just was under impression of this article https://wiki.openstack.org/wiki/GitCommitMessages, it says to split code changes where it's possible. | 09:38 |
therve | Eva-i, That's what Ryan said AFAIU | 09:46 |
therve | Use multiple patchs if you can | 09:47 |
Eva-i | i'm very confused now | 09:47 |
therve | Seems like it | 09:47 |
therve | I don't know how else explain it to you. Do several git commit in the same branch if you can split the changes in logical parts. | 09:51 |
Eva-i | okay | 09:51 |
*** AAzza has quit IRC | 09:52 | |
*** AAzza has joined #openstack-zaqar | 09:54 | |
*** Eva-i has quit IRC | 09:57 | |
*** Eva-i has joined #openstack-zaqar | 10:00 | |
*** AAzza has quit IRC | 10:20 | |
*** AAzza has joined #openstack-zaqar | 10:21 | |
*** pt_15 has quit IRC | 10:48 | |
*** AAzza has quit IRC | 10:49 | |
*** AAzza has joined #openstack-zaqar | 10:50 | |
*** AAzza has quit IRC | 10:54 | |
*** AAzza has joined #openstack-zaqar | 10:55 | |
*** AAzza has quit IRC | 11:01 | |
*** AAzza has joined #openstack-zaqar | 11:02 | |
*** mpanetta has joined #openstack-zaqar | 11:04 | |
ryansb | Eva-i: make a branch in git (called, say, bug/1234) and make all your commits | 12:05 |
ryansb | then do "git review" and it will make that many patches | 12:06 |
ryansb | and each patch will have 1 patch set | 12:06 |
ryansb | this patch, for example, has 3 patch sets but is one patch https://review.openstack.org/#/c/220849/ | 12:06 |
*** exploreshaifali has joined #openstack-zaqar | 12:17 | |
*** pt_15 has joined #openstack-zaqar | 12:18 | |
*** inteq has quit IRC | 12:19 | |
*** khushbu has joined #openstack-zaqar | 12:20 | |
*** khushbu has quit IRC | 12:20 | |
Eva-i | ryansb: okay, I understand you | 12:26 |
*** khushbu_ has joined #openstack-zaqar | 12:34 | |
*** khushbu_ has quit IRC | 12:35 | |
*** exploreshaifali has quit IRC | 12:38 | |
*** khushbu has joined #openstack-zaqar | 12:43 | |
*** khushbu has quit IRC | 12:43 | |
*** khushbu_ has joined #openstack-zaqar | 12:57 | |
*** khushbu_ has quit IRC | 12:58 | |
*** csoukup has joined #openstack-zaqar | 13:05 | |
*** khushbu_ has joined #openstack-zaqar | 13:07 | |
*** khushbu_ has quit IRC | 13:07 | |
*** sriram1 has joined #openstack-zaqar | 13:10 | |
*** khushbu_ has joined #openstack-zaqar | 13:11 | |
*** khushbu_ has quit IRC | 13:12 | |
*** khushbu has joined #openstack-zaqar | 13:16 | |
*** khushbu has quit IRC | 13:19 | |
*** khushbu_ has joined #openstack-zaqar | 13:21 | |
*** khushbu_ has quit IRC | 13:22 | |
ryansb | Great - the terminology can get confusing darn quick. Today's XKCD is particularly funny since we just had all this confusion http://xkcd.com/1597/ | 13:26 |
*** khushbu_ has joined #openstack-zaqar | 13:26 | |
therve | Gerrit doesn't make things easier either | 13:27 |
*** khushbu_ has quit IRC | 13:28 | |
ryansb | yeah right | 13:28 |
*** mdnadeem_ has joined #openstack-zaqar | 13:31 | |
*** khushbu_ has joined #openstack-zaqar | 13:35 | |
Eva-i | =) | 13:45 |
*** mdnadeem_ has quit IRC | 13:50 | |
*** ametts has joined #openstack-zaqar | 13:53 | |
*** khushbu_ has quit IRC | 14:01 | |
*** khushbu_ has joined #openstack-zaqar | 14:06 | |
*** khushbu_ has quit IRC | 14:08 | |
*** cpallares has quit IRC | 14:12 | |
*** achanda has joined #openstack-zaqar | 14:14 | |
*** vkmc has quit IRC | 14:14 | |
*** akanksha_ has quit IRC | 14:18 | |
*** khushbu has joined #openstack-zaqar | 14:22 | |
*** kgriffs|afk is now known as kgriffs | 14:25 | |
*** khushbu has quit IRC | 14:25 | |
*** sriram1 has quit IRC | 14:25 | |
*** sriram1 has joined #openstack-zaqar | 14:25 | |
*** sriram1 is now known as sriram | 14:25 | |
*** vkmc has joined #openstack-zaqar | 14:26 | |
*** vkmc has quit IRC | 14:30 | |
*** achanda has quit IRC | 15:03 | |
*** pt_15 has quit IRC | 15:08 | |
*** kgriffs is now known as kgriffs|afk | 15:43 | |
*** davideagnello has quit IRC | 15:52 | |
*** kgriffs|afk is now known as kgriffs | 16:02 | |
*** khushbu_ has joined #openstack-zaqar | 16:05 | |
*** khushbu_ has quit IRC | 16:12 | |
*** khushbu has joined #openstack-zaqar | 16:18 | |
*** khushbu has quit IRC | 16:21 | |
*** khushbu_ has joined #openstack-zaqar | 16:35 | |
*** khushbu_ has quit IRC | 16:36 | |
*** vkmc has joined #openstack-zaqar | 16:38 | |
*** khushbu_ has joined #openstack-zaqar | 16:41 | |
*** itisha has quit IRC | 16:41 | |
*** khushbu_ has quit IRC | 16:42 | |
*** vkmc has quit IRC | 16:45 | |
*** achanda has joined #openstack-zaqar | 16:53 | |
*** davideagnello has joined #openstack-zaqar | 16:57 | |
*** vkmc has joined #openstack-zaqar | 17:14 | |
*** JAHoagie has joined #openstack-zaqar | 17:17 | |
*** cpallares has joined #openstack-zaqar | 17:17 | |
*** vkmc has quit IRC | 17:26 | |
*** cpallares has quit IRC | 17:28 | |
*** achanda has quit IRC | 17:33 | |
*** achanda has joined #openstack-zaqar | 17:52 | |
*** achanda has quit IRC | 17:53 | |
*** achanda has joined #openstack-zaqar | 17:59 | |
*** khushbu has joined #openstack-zaqar | 18:30 | |
*** khushbu has quit IRC | 18:31 | |
*** kgriffs is now known as kgriffs|afk | 18:31 | |
*** khushbu_ has joined #openstack-zaqar | 18:36 | |
*** khushbu_ has quit IRC | 18:36 | |
*** khushbu_ has joined #openstack-zaqar | 18:45 | |
*** achanda has quit IRC | 18:56 | |
*** achanda has joined #openstack-zaqar | 19:01 | |
*** khushbu_ has quit IRC | 19:05 | |
*** achanda has quit IRC | 19:17 | |
*** itisha has joined #openstack-zaqar | 19:18 | |
*** achanda has joined #openstack-zaqar | 19:27 | |
*** kgriffs|afk is now known as kgriffs | 19:31 | |
*** achanda has quit IRC | 19:33 | |
*** mpanetta has quit IRC | 19:47 | |
*** JAHoagie has quit IRC | 20:24 | |
*** achanda has joined #openstack-zaqar | 20:29 | |
*** JAHoagie has joined #openstack-zaqar | 20:31 | |
*** achanda has quit IRC | 20:46 | |
*** achanda has joined #openstack-zaqar | 21:24 | |
*** sriram has quit IRC | 21:32 | |
*** akanksha_ has joined #openstack-zaqar | 21:40 | |
openstackgerrit | Akanksha Srivastava proposed openstack/zaqar: Decorator fuction to Validate UUIDs in Redis Driver https://review.openstack.org/165632 | 21:41 |
*** achanda has quit IRC | 22:01 | |
*** achanda has joined #openstack-zaqar | 22:02 | |
*** csoukup has quit IRC | 22:12 | |
*** ametts has quit IRC | 22:16 | |
*** achanda has quit IRC | 22:17 | |
*** kgriffs is now known as kgriffs|afk | 22:23 | |
*** achanda has joined #openstack-zaqar | 22:24 | |
*** kgriffs|afk is now known as kgriffs | 22:52 | |
*** kgriffs is now known as kgriffs|afk | 23:05 | |
*** AAzza has quit IRC | 23:28 | |
*** AAzza has joined #openstack-zaqar | 23:28 | |
*** achanda has quit IRC | 23:28 | |
*** achanda has joined #openstack-zaqar | 23:30 | |
*** JAHoagie has quit IRC | 23:38 | |
*** AAzza has quit IRC | 23:48 | |
*** AAzza has joined #openstack-zaqar | 23:48 | |
*** mdnadeem_ has joined #openstack-zaqar | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!