| *** davideagnello has joined #openstack-zaqar | 00:01 | |
| flwang | doraly was trying to split the classes under https://github.com/openstack/python-zaqarclient/tree/master/zaqarclient/tests/queues to different versions | 00:02 |
|---|---|---|
| flwang | and that patch was merged for some reasons | 00:02 |
| flwang | but personally, i don't think that's the right direction, at least for now | 00:03 |
| *** davideagnello has quit IRC | 00:06 | |
| Eva-i | flwang: yes, I figured this out. What I don't know still is why there are "zaqarclient/tests" and "tests" directories in python-zaqarclient. | 00:08 |
| flwang | i think we're coping the same mode like zaqar, the 'tests' folder at the sub level is like a test stub which can be reused for unit test and functional test | 00:10 |
| Eva-i | flwang: thanks, now I understand | 00:12 |
| flwang | no problem | 00:12 |
| flwang | Eva-i: did you test the patch? | 00:47 |
| flwang | or just rebased | 00:48 |
| Eva-i | flwang: just rebased, I'm gonna test it soon after I set up the environment right | 00:49 |
| flwang | Eva-i: ok, i see. thanks | 00:50 |
| *** Qiming has joined #openstack-zaqar | 01:07 | |
| *** davideagnello has joined #openstack-zaqar | 01:10 | |
| *** davideagnello has quit IRC | 01:14 | |
| *** davideagnello has joined #openstack-zaqar | 02:18 | |
| *** davideagnello has quit IRC | 02:22 | |
| flwang | Eva-i: ping | 02:57 |
| Eva-i | flwang: pong, almost finished testing | 02:57 |
| flwang | Eva-i: do you have a workable zaqar? | 02:57 |
| flwang | can you help try the policy? | 02:57 |
| flwang | i just found it doesn't work since the oslo.policy upgrade | 02:58 |
| flwang | like use a non-admin user access the pool and flavor | 02:58 |
| Eva-i | flwang: I can try, but I have not much experience with policies | 02:58 |
| flwang | just switch to use a normal user to list pools | 02:58 |
| *** davideagnello has joined #openstack-zaqar | 02:59 | |
| *** mdnadeem has joined #openstack-zaqar | 02:59 | |
| Eva-i | flwang: i just need to list pools when authenticated by non-admin user? | 03:00 |
| *** mdnadeem has quit IRC | 03:01 | |
| *** mdnadeem has joined #openstack-zaqar | 03:02 | |
| flwang | yes | 03:03 |
| *** davideagnello has quit IRC | 03:04 | |
| Eva-i | flwang: ok, got the result. When I run "openstack pool list" when authenticated as demo user I don't see any errors about not enough rights. | 03:08 |
| Eva-i | flwang: and that's bad, right? | 03:08 |
| flwang | can you try curl or any other http client? | 03:08 |
| Eva-i | flwang: okay, I'll try curl now | 03:09 |
| Eva-i | flwang: I got an interesting result: http://pastebin.com/Yrx4wfQp | 03:18 |
| Eva-i | flwang: the difference between these two requests in API. Seems like API v2 works normally, but API v1.1 not. | 03:19 |
| flwang | Eva-i: it's expected, since we support policy since v2 | 03:20 |
| flwang | so you mean the policy.json works fine on your local | 03:21 |
| Eva-i | flwang: oh, I see | 03:21 |
| flwang | for v2, right? | 03:21 |
| Eva-i | flwang: let me test same curl as admin | 03:22 |
| flwang | cool, thanks | 03:23 |
| Eva-i | flwang: okay, tested as admin. So suppose it works normally | 03:23 |
| Eva-i | flwang: what wrong behavior do you observe with the policy? A normal user is able to list pools on API v2? | 03:26 |
| flwang | Eva-i: yep :) | 03:27 |
| flwang | no worries, i will test it again in a clear env | 03:27 |
| flwang | but, as you found, maybe we should improve zaqar client to let it works better for the policy | 03:27 |
| Eva-i | flwang: how is access to admin things is managed on v1.1 API? | 03:28 |
| Eva-i | flwang: i.e. before policies | 03:28 |
| flwang | for v1.1, non-admin role should get 404 error since they can't see the endpoint | 03:29 |
| Eva-i | flwang: but as you see in my log when I tried APIv1.1 while logged as normal user, there was no 404 error. | 03:30 |
| Eva-i | "maybe we should improve zaqar client to let it works better for the policy" good point | 03:33 |
| flwang | as for 404, my statement is not really accurate, see https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v1_1/homedoc.py#L270 | 03:36 |
| flwang | if you're enabling admin_mode, then those admin endpoints will be published, otherwise you won't see them | 03:37 |
| flwang | i assume in your env, it's true | 03:37 |
| Eva-i | flwang: so on APIv1.1 the only way to restrict access to pools and flavors is admin_mode variable? | 03:38 |
| flwang | IIRC, it's true | 03:38 |
| flwang | that's why we use policy to improve it | 03:39 |
| Eva-i | flwang: all right, now it all makes sense | 03:39 |
| Eva-i | flwang: yes | 03:39 |
| flwang | i'm the original author of our policy support, so i know some of its history :) | 03:39 |
| Eva-i | flwang: I'm thinking about the problem. Maybe you just forgot that there can be two "policy.json" in environment. Tne located in "~/.zaqar/" directory overrides the one in "/etc/zaqar/" directory. And maybe you checked the one in "/etc/zaqar/" while there was a permissive one in "~/.zaqar/"? | 03:46 |
| Eva-i | *The one located in "~/.zaqar/" directory | 03:46 |
| flwang | i do have two for sure, but they are same and kept as default | 03:47 |
| Eva-i | flwang: okay | 03:47 |
| Eva-i | flwang: maybe you have found a security hole. =) And in this case it's good to not to delete the environment and try to inspect it. | 03:50 |
| flwang | maybe :) | 03:51 |
| flwang | i'm working on the subscription patch and then run into this issue | 03:51 |
| Eva-i | flwang: mmm... | 03:51 |
| flwang | i prefer to take it as an env issue, but will dig | 03:51 |
| Eva-i | I got up at sunday. I'm supersleepy now and going to bed. Good night. | 03:52 |
| Eva-i | *woke up | 03:53 |
| flwang | cya | 03:54 |
| *** flwang1 has quit IRC | 03:56 | |
| *** davideagnello has joined #openstack-zaqar | 04:07 | |
| *** davideagnello has quit IRC | 04:11 | |
| *** Qiming has quit IRC | 04:29 | |
| *** VeggieMeat has quit IRC | 04:36 | |
| *** VeggieMeat_ has joined #openstack-zaqar | 04:36 | |
| *** ig0r_ has quit IRC | 04:50 | |
| *** ig0r_ has joined #openstack-zaqar | 04:54 | |
| *** davideagnello has joined #openstack-zaqar | 05:15 | |
| *** davideagnello has quit IRC | 05:20 | |
| *** Qiming has joined #openstack-zaqar | 05:21 | |
| *** Qiming has quit IRC | 05:47 | |
| *** ig0r_ has quit IRC | 06:12 | |
| *** davideagnello has joined #openstack-zaqar | 06:37 | |
| *** davideagnello has quit IRC | 06:42 | |
| *** rcernin has joined #openstack-zaqar | 07:01 | |
| *** openstackstatus has joined #openstack-zaqar | 07:06 | |
| *** ChanServ sets mode: +v openstackstatus | 07:06 | |
| *** boris-42_ has joined #openstack-zaqar | 07:09 | |
| *** openstackgerrit has joined #openstack-zaqar | 07:10 | |
| *** davideagnello has joined #openstack-zaqar | 07:17 | |
| *** davideagnello has quit IRC | 07:23 | |
| *** davideagnello has joined #openstack-zaqar | 07:59 | |
| *** davideagnello has quit IRC | 08:03 | |
| *** davideagnello has joined #openstack-zaqar | 09:07 | |
| *** davideagnello has quit IRC | 09:12 | |
| *** ig0r_ has joined #openstack-zaqar | 09:38 | |
| *** davideagnello has joined #openstack-zaqar | 09:48 | |
| *** davideagnello has quit IRC | 09:52 | |
| *** rcernin has quit IRC | 10:25 | |
| *** davideagnello has joined #openstack-zaqar | 10:28 | |
| *** davideagnello has quit IRC | 10:33 | |
| *** davideagnello has joined #openstack-zaqar | 11:23 | |
| *** davideagnello has quit IRC | 11:28 | |
| *** malini has joined #openstack-zaqar | 11:38 | |
| *** davideagnello has joined #openstack-zaqar | 12:03 | |
| *** dmowrer has joined #openstack-zaqar | 12:07 | |
| *** davideagnello has quit IRC | 12:08 | |
| *** malini has quit IRC | 12:39 | |
| *** davideagnello has joined #openstack-zaqar | 12:58 | |
| *** davideagnello has quit IRC | 13:03 | |
| *** davideagnello has joined #openstack-zaqar | 13:26 | |
| *** davideagnello has quit IRC | 13:31 | |
| *** tej has joined #openstack-zaqar | 13:40 | |
| *** mdnadeem1 has joined #openstack-zaqar | 13:50 | |
| *** mdnadeem1 has quit IRC | 13:57 | |
| *** mdnadeem1 has joined #openstack-zaqar | 13:57 | |
| *** mdnadeem1 has quit IRC | 14:06 | |
| *** mdnadeem1 has joined #openstack-zaqar | 14:08 | |
| *** mdnadeem1 has joined #openstack-zaqar | 14:09 | |
| *** mdnadeem1 has quit IRC | 14:11 | |
| *** davideagnello has joined #openstack-zaqar | 14:20 | |
| *** dynarro has joined #openstack-zaqar | 14:21 | |
| *** mdnadeem1 has joined #openstack-zaqar | 14:22 | |
| *** davideagnello has quit IRC | 14:25 | |
| ryansb | morning zaqarians | 14:33 |
| *** ametts has joined #openstack-zaqar | 14:34 | |
| *** mpanetta has joined #openstack-zaqar | 14:36 | |
| vkmc | morning ryansb! | 14:37 |
| dynarro | mooooorning! | 14:48 |
| Eva-i | hello | 14:48 |
| vkmc | hey there dynarro, Eva-i! | 14:50 |
| Eva-i | vkmc: yes, hello! =) There will be a meeting soon? | 14:53 |
| vkmc | I think so... this week is at 15.00utc? | 14:53 |
| Eva-i | vkmc: yes | 14:54 |
| vkmc | Eva-i, thanks for the heads up | 14:54 |
| dynarro | vkmc, o/ | 14:54 |
| *** malini has joined #openstack-zaqar | 14:55 | |
| mdnadeem1 | morning | 14:55 |
| mdnadeem1 | although, here is night, lolz | 14:55 |
| vkmc | mdnadeem, what time is it there Nadeem? | 14:56 |
| Eva-i | dynarro: hello, I'm an Outreachy intern of this round =) | 14:56 |
| mdnadeem1 | 8:30 pm | 14:56 |
| dynarro | Eva-i, hey! nice to meet you!! awesome, I was in the last round! I hope you enjoy it like I did ;) | 14:57 |
| *** flwang1 has joined #openstack-zaqar | 14:57 | |
| Eva-i | dynarro: nice to meet you too! I've read your blog recently. And yes, I'm enjoying internship. =) | 14:58 |
| dynarro | cool =) | 15:00 |
| flwang1 | meeting time, guys | 15:00 |
| vkmc | flwang1, hey there! | 15:01 |
| flwang1 | vkmc: hey :) | 15:01 |
| flwang1 | Eva-i: dynarro: mdnadeem: mdnadeem1: #openstack-meeting-3 | 15:02 |
| flwang1 | flaper87: ^ | 15:03 |
| dynarro | flaper87, ^ | 15:03 |
| *** sriram has joined #openstack-zaqar | 15:03 | |
| *** ig0r_ has quit IRC | 15:04 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:07 | |
| flaper87 | vkmc: ^ | 15:16 |
| vkmc | flaper87, ^ | 15:16 |
| flaper87 | dynarro: ^ | 15:16 |
| dynarro | LOL | 15:16 |
| flaper87 | dynarro: you broke the pattern.... | 15:17 |
| * flaper87 shakes dynarro | 15:17 | |
| dynarro | flaper87, I started the pattern, I can break it haha | 15:17 |
| flaper87 | no no no, flwang1 started it. It should've ended there | 15:19 |
| dynarro | damn it! your right hahaha | 15:21 |
| *** dmowrer has quit IRC | 15:37 | |
| *** dmowrer has joined #openstack-zaqar | 15:37 | |
| *** davideagnello has joined #openstack-zaqar | 15:41 | |
| *** dmowrer has quit IRC | 15:42 | |
| *** davideagnello has quit IRC | 15:47 | |
| flwang1 | vkmc: flaper87: ryansb: pls review our zaqar client patch and the UI patch, thanks | 16:03 |
| *** amitgandhinz has quit IRC | 16:04 | |
| Eva-i | flwang1: we must come up with something if we want to start working on API ref now. Soon docbook/wadl format for API ref will be changed to swagger and rst. Should I start making API ref in the old format? :o | 16:07 |
| Eva-i | flwang1: I'll review UI patch today | 16:08 |
| flwang1 | Eva-i: no, we don't need to waste time on the old format, IMO | 16:08 |
| ryansb | I'd really rather the new format | 16:08 |
| ryansb | docbook/wadl format sucks to work on | 16:08 |
| *** davideagnello has joined #openstack-zaqar | 16:09 | |
| Eva-i | To make API ref in the new format I will need an example of API ref in this format, something which I can use as a base. | 16:10 |
| flwang1 | Eva-i: then you need to talk with doc team | 16:11 |
| Eva-i | Also I wanted to ask: when I use python-zaqarclient and ask the claim's age, it's always returns "0" even if there was a delay between claim creation and asking the claim's age. Is it normal? | 16:11 |
| Eva-i | flwang1: alright | 16:11 |
| flwang1 | Anne G ? | 16:11 |
| flwang1 | let's address one by one | 16:11 |
| flwang1 | so are you ok with the api format question? | 16:12 |
| Eva-i | flwang1: what do you mean if I'm okay with my question? | 16:13 |
| *** davideagnello has quit IRC | 16:13 | |
| Eva-i | flwang1: I'm okay with your replies. And I will contact Anne Gentle soon. | 16:15 |
| *** mdnadeem1 has quit IRC | 16:17 | |
| flwang1 | Eva-i: sorry, just away for a coffee | 16:21 |
| flwang1 | i'm sleepy since i wake up too early today | 16:22 |
| Eva-i | flwang1: oki | 16:22 |
| flwang1 | ok, let's back to the claim question | 16:22 |
| flwang1 | Eva-i: so you mean after you claimed a queue, and then query the claim based on the claim id, the age of the claim is not correct, is it? | 16:23 |
| *** amitgandhinz has joined #openstack-zaqar | 16:27 | |
| *** csoukup has joined #openstack-zaqar | 16:28 | |
| Eva-i | flwang1: not exaclty, I'm just using "claim" object instance to ask age | 16:28 |
| Eva-i | flwang1: here's tiny code example http://paste.openstack.org/show/8tsqFgx5Q0qOeGyiYpU0/ | 16:29 |
| *** dynarro has quit IRC | 16:29 | |
| Eva-i | flwang1: oh, I had to simplify the code more... | 16:35 |
| flwang1 | Eva-i: paste is slow for me :( | 16:35 |
| Eva-i | flwang1: okay, will upload to pastebin | 16:35 |
| Eva-i | flwang1: here: http://pastebin.com/RES48cFu | 16:36 |
| *** dmowrer has joined #openstack-zaqar | 16:39 | |
| flwang1 | mdnadeem: still around? | 16:40 |
| flwang1 | mdnadeem: the patch set you summited against claims v2 is not really correct, you can't change the patch author | 16:41 |
| Eva-i | flwang1: am I using the age property right? | 16:43 |
| Eva-i | flwang1: I'm looking at the code defining this property and I'm not sure the code is right. | 16:44 |
| flwang1 | how did you create the claim? | 16:44 |
| *** dmowrer has quit IRC | 16:45 | |
| Eva-i | flwang1: just like in the example I posted in pastebin.com. Does pastebin.com work for you? | 16:45 |
| flwang1 | Eva-i: it looks ok, i will give it a try later and let you know | 16:48 |
| Eva-i | flwang1: oki, thank you | 16:49 |
| *** davideagnello has joined #openstack-zaqar | 16:49 | |
| Eva-i | mdnadeem: ryansb: vkmc: Can you please check if subscriptions work in "examples/websocket.html" example and tell me later the result? | 16:50 |
| Eva-i | mdnadeem: ryansb: vkmc: for me it doesn't work. =/ | 16:51 |
| *** davideagnello has quit IRC | 16:54 | |
| Eva-i | flwang1: so, describing in two words what I said: I think that https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/queues/v1/claim.py#L81 is not correct. | 17:00 |
| flwang1 | why? | 17:04 |
| Eva-i | flwang1: this property is defined in a way that it only queries claim's age from the server on the first call. On sequential calls it will just return the same age as in the first call. But claim's age is changing with the time flow, and this property must return an updated age on each call. | 17:11 |
| flwang1 | Eva-i: i can see your point now, i think we should remove the line 83 | 17:13 |
| flwang1 | can you give it a try? | 17:13 |
| Eva-i | flwang1: already given and it works | 17:13 |
| Eva-i | *gave | 17:14 |
| flwang1 | awesome | 17:14 |
| *** malini has quit IRC | 17:14 | |
| Eva-i | flwang1: but it's not enough to fix this. | 17:14 |
| Eva-i | flwang: so I will report a bug and then fix it properly, okay? | 17:15 |
| flwang1 | Eva-i: yep, thanks and it's a nice catch i think | 17:18 |
| Eva-i | flwang1: thanks for confirming it =) I decided that from now on I'll be more confident and will just report the bugs when see unexpected behavior instead of discussing it first in the chat. ;) | 17:19 |
| flwang1 | sure, since i will review the bug reports :) | 17:20 |
| *** openstackstatus has quit IRC | 17:20 | |
| *** openstackstatus has joined #openstack-zaqar | 17:23 | |
| *** ChanServ sets mode: +v openstackstatus | 17:23 | |
| *** dmowrer has joined #openstack-zaqar | 17:42 | |
| *** davideagnello has joined #openstack-zaqar | 17:44 | |
| Eva-i | hehe, I reported many important bugs today | 17:47 |
| *** dmowrer has quit IRC | 17:47 | |
| *** davideagnello has quit IRC | 17:49 | |
| *** dmowrer has joined #openstack-zaqar | 17:56 | |
| *** flwang1 has quit IRC | 18:34 | |
| *** ig0r_ has joined #openstack-zaqar | 18:39 | |
| *** david-lyle_ has joined #openstack-zaqar | 18:42 | |
| *** david-lyle has quit IRC | 18:45 | |
| *** davideagnello has joined #openstack-zaqar | 18:52 | |
| *** davideagnello has quit IRC | 18:54 | |
| *** davideagnello has joined #openstack-zaqar | 18:55 | |
| *** malini has joined #openstack-zaqar | 18:58 | |
| *** mdnadeem has quit IRC | 19:11 | |
| *** malini has quit IRC | 19:41 | |
| *** malini has joined #openstack-zaqar | 19:50 | |
| *** malini has quit IRC | 20:03 | |
| *** whydidyoustealmy has quit IRC | 20:07 | |
| *** shakamunyi has quit IRC | 20:07 | |
| *** david-lyle_ has quit IRC | 20:10 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar-specs: HTTP PUT improvement for existing resource https://review.openstack.org/246147 | 20:11 |
| *** david-lyle has joined #openstack-zaqar | 20:13 | |
| openstackgerrit | Merged openstack/zaqar-specs: Support for binary data in the websocket transport https://review.openstack.org/249257 | 20:17 |
| Eva-i | flwang: wow, thanks for approving my spec | 20:19 |
| flwang | Eva-i: :) | 20:19 |
| flwang | Eva-i: btw, md's patchset for claims is not really correct i think | 20:25 |
| Eva-i | flwang: why do you think so? | 20:27 |
| *** flwang1 has joined #openstack-zaqar | 20:28 | |
| flwang | 1. he should not change the author name | 20:29 |
| flwang | 2. i think his patch set is missing some tests | 20:29 |
| Eva-i | flwang: 1. So he must either to remove Co-Authored-By tag or add Doraly Navarro as the second author? | 20:32 |
| flwang | Eva-i: did you see this line? Authormd nadeem<mail2nadeem92@gmail.com>Dec 10, 2015 11:47 PM | 20:33 |
| flwang | under the patch set 11 | 20:33 |
| flwang | you can compare it with patch set 10 | 20:33 |
| Eva-i | flwang: oh, I see now. I wonder how is it possible. | 20:34 |
| Eva-i | flwang: 2. Okay, I will inspect if this patch is missing some tests related to API v2. For now we have discovered that both v1.1 and v2 APIs are missing a test case where the claim's age is properly tested. | 20:35 |
| flwang | i haven't dig into the code of test, so i'm holding on to approve it before some tests | 20:35 |
| flwang | Eva-i: agree, you can add the test cases in you fix | 20:35 |
| flwang | for age, i mean | 20:35 |
| Eva-i | flwang: yes, I'm planning to do so. You can confirm this bug officially https://bugs.launchpad.net/python-zaqarclient/+bug/1525994. | 20:37 |
| openstack | Launchpad bug 1525994 in Python client library for Zaqar "Age property of Claim object returns wrong values on subsequent calls" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 20:37 |
| flwang | Eva-i: done | 20:39 |
| Eva-i | flwang: thanks | 20:40 |
| *** david-lyle has quit IRC | 21:01 | |
| *** david-lyle has joined #openstack-zaqar | 21:07 | |
| *** david-lyle has quit IRC | 21:12 | |
| *** mpanetta has quit IRC | 21:56 | |
| *** sriram has quit IRC | 21:58 | |
| *** dmowrer has quit IRC | 22:27 | |
| *** dmowrer has joined #openstack-zaqar | 22:27 | |
| *** Eva-i has quit IRC | 22:30 | |
| *** dmowrer has quit IRC | 22:31 | |
| *** Eva-i has joined #openstack-zaqar | 22:32 | |
| *** david-lyle has joined #openstack-zaqar | 22:39 | |
| *** amitgandhinz has quit IRC | 22:45 | |
| *** csoukup has quit IRC | 23:19 | |
| *** ametts has quit IRC | 23:24 | |
| *** dmowrer has joined #openstack-zaqar | 23:28 | |
| *** dmowrer has quit IRC | 23:35 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!