*** stanchan has quit IRC | 00:42 | |
openstackgerrit | Merged openstack/zaqar: Deprecated tox -downloadcache option removed https://review.openstack.org/256733 | 00:43 |
---|---|---|
openstackgerrit | Merged openstack/zaqar: Changing LOG.warn to LOG.warning https://review.openstack.org/263169 | 01:03 |
*** eliqiao has quit IRC | 01:12 | |
*** eliqiao has joined #openstack-zaqar | 01:13 | |
*** kgriffs is now known as kgriffs|afk | 01:51 | |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription list v2 https://review.openstack.org/263531 | 02:32 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/258076 | 02:46 |
*** dmowrer has joined #openstack-zaqar | 03:42 | |
*** dmowrer has quit IRC | 03:46 | |
*** dmowrer has joined #openstack-zaqar | 07:42 | |
*** dmowrer has quit IRC | 07:46 | |
openstackgerrit | wangxiyuan proposed openstack/zaqar: Fix the docs link https://review.openstack.org/263634 | 08:46 |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/zaqar: Replace deprecated LOG.warn with LOG.warning https://review.openstack.org/263323 | 09:21 |
*** dynarro has joined #openstack-zaqar | 09:33 | |
*** boris-42 has quit IRC | 10:03 | |
*** dynarro has quit IRC | 11:14 | |
*** bradjones has joined #openstack-zaqar | 11:44 | |
*** bradjones has joined #openstack-zaqar | 11:44 | |
*** dmowrer has joined #openstack-zaqar | 12:05 | |
*** chestack has joined #openstack-zaqar | 12:50 | |
*** mdnadeem has joined #openstack-zaqar | 13:38 | |
*** sriram has quit IRC | 13:42 | |
*** chestack has quit IRC | 13:46 | |
*** dmowrer has quit IRC | 13:54 | |
*** dmowrer has joined #openstack-zaqar | 13:55 | |
*** dmowrer has quit IRC | 13:59 | |
*** mdnadeem has quit IRC | 14:12 | |
*** dmowrer has joined #openstack-zaqar | 14:17 | |
*** mpanetta has joined #openstack-zaqar | 14:17 | |
*** malini has joined #openstack-zaqar | 14:49 | |
*** dynarro has joined #openstack-zaqar | 14:50 | |
*** ametts has joined #openstack-zaqar | 14:54 | |
*** amitgandhinz has joined #openstack-zaqar | 14:58 | |
openstackgerrit | Merged openstack/zaqar: Trival: Remove unused logging import In some files https://review.openstack.org/261895 | 15:38 |
*** csoukup has joined #openstack-zaqar | 15:49 | |
*** kgriffs|afk is now known as kgriffs | 15:49 | |
*** sriram has joined #openstack-zaqar | 15:52 | |
*** shakamunyi has joined #openstack-zaqar | 16:14 | |
*** barra204 has quit IRC | 16:15 | |
*** pradk has joined #openstack-zaqar | 16:26 | |
*** dynarro has quit IRC | 16:35 | |
openstackgerrit | Ryan Brown proposed openstack/python-zaqarclient: First pass at CLI for signed URLs https://review.openstack.org/253731 | 16:40 |
*** kgriffs is now known as kgriffs|afk | 16:42 | |
*** kgriffs|afk is now known as kgriffs | 16:42 | |
*** kgriffs is now known as kgriffs|afk | 16:43 | |
*** kgriffs|afk is now known as kgriffs | 16:55 | |
*** kgriffs is now known as kgriffs|afk | 16:58 | |
*** dmowrer has quit IRC | 17:10 | |
*** dmowrer has joined #openstack-zaqar | 17:11 | |
*** kgriffs|afk is now known as kgriffs | 17:13 | |
Eva-i | ping flwang | 17:13 |
*** kgriffs is now known as kgriffs|afk | 17:15 | |
*** dmowrer has quit IRC | 17:15 | |
*** kgriffs|afk is now known as kgriffs | 17:22 | |
*** kgriffs is now known as kgriffs|afk | 17:27 | |
*** kgriffs|afk is now known as kgriffs | 17:28 | |
*** dmowrer has joined #openstack-zaqar | 17:36 | |
*** kgriffs is now known as kgriffs|afk | 17:37 | |
*** kgriffs|afk is now known as kgriffs | 17:42 | |
*** kgriffs is now known as kgriffs|afk | 17:48 | |
*** kgriffs|afk is now known as kgriffs | 17:49 | |
*** kgriffs is now known as kgriffs|afk | 17:49 | |
*** kgriffs|afk is now known as kgriffs | 17:56 | |
*** kgriffs is now known as kgriffs|afk | 18:00 | |
*** malini has quit IRC | 18:27 | |
*** dmowrer has quit IRC | 18:43 | |
*** njohnsto_ has joined #openstack-zaqar | 18:54 | |
*** malini has joined #openstack-zaqar | 18:57 | |
*** dmowrer has joined #openstack-zaqar | 19:09 | |
*** dmowrer has quit IRC | 19:09 | |
*** dmowrer has joined #openstack-zaqar | 19:10 | |
*** kgriffs|afk is now known as kgriffs | 19:13 | |
*** davideagnello has quit IRC | 19:21 | |
*** kgriffs is now known as kgriffs|afk | 19:28 | |
*** kgriffs|afk is now known as kgriffs | 19:37 | |
*** davideagnello has joined #openstack-zaqar | 19:47 | |
flwang | Eva-i: pong | 19:49 |
Eva-i | flwang: hello | 19:49 |
flwang | Eva-i: hi, what's up | 19:50 |
Eva-i | flwang: look, Doc team proposed solution that might satisfy all https://review.openstack.org/#/c/263405/ (Gauvain Pocentek comment) | 19:50 |
Eva-i | flwang: would you like me to add hook to openstack-doc-tools repo, that will allow extraction of config options from Zaqar? | 19:51 |
Eva-i | *automatic extraction | 19:52 |
flwang | Eva-i: so that means we just need to add a function in https://github.com/openstack/openstack-doc-tools/blob/master/autogenerate_config_docs/hooks.py for zaqar and doesn't need to change zaqar's code, right? | 19:53 |
Eva-i | flwang: absolutely | 19:53 |
Eva-i | flwang: I tried it and it works | 19:54 |
flwang | Eva-i: that's great | 19:54 |
Eva-i | flwang: I'm sending a patch then... | 19:55 |
openstackgerrit | Merged openstack/python-zaqarclient: Put py34 first in the env order of tox https://review.openstack.org/260503 | 19:56 |
*** dmowrer has quit IRC | 19:57 | |
Eva-i | flwang: here it is https://review.openstack.org/#/c/263879/ | 19:57 |
flwang | Eva-i: cool, then we may need to remove the manual table in https://review.openstack.org/#/c/263405/, right? | 19:58 |
*** dmowrer has joined #openstack-zaqar | 19:59 | |
Eva-i | that's right, I'll reply to Gauvain Pocentek and move tables out of "manual" directory | 19:59 |
*** dmowrer_ has joined #openstack-zaqar | 20:01 | |
flwang | Eva-i: pls paste the patch link with a comment so that those reviewers can know where it's | 20:02 |
*** dmowrer has quit IRC | 20:04 | |
*** Eva-i has quit IRC | 20:06 | |
*** kgriffs is now known as kgriffs|afk | 20:07 | |
*** Eva-i has joined #openstack-zaqar | 20:09 | |
openstackgerrit | Merged openstack/zaqar: Drop MANIFEST.in - it's not needed with PBR https://review.openstack.org/252194 | 20:12 |
Eva-i | flwang: yes, of course. Sorry for, my computer seriously glitched. | 20:13 |
Eva-i | *sorry for delay | 20:13 |
flwang | Eva-i: awesome, thanks :) | 20:19 |
*** kgriffs|afk is now known as kgriffs | 20:37 | |
*** malini has quit IRC | 20:54 | |
Eva-i | flwang: have you started working on this bug https://bugs.launchpad.net/zaqar/+bug/1518618 ? | 21:06 |
openstack | Launchpad bug 1518618 in zaqar "Tests from zaqar.tests.unit.transport.websocket.v1_1 do not execute(and fail if made executed)" [Low,Triaged] - Assigned to Fei Long Wang (flwang) | 21:06 |
flwang | Eva-i: yes, i'm | 21:07 |
flwang | oh, sorry | 21:08 |
flwang | i forgot it i think, patch is coming soon | 21:08 |
Eva-i | flwang: oki | 21:09 |
flwang | TBH, i think the test case is weird | 21:11 |
flwang | the patch is assuming using websocket v1.1 to access subscriptions which is only supported in v2 | 21:11 |
Eva-i | flwang: you are talking about zaqar client patch? I asked about Zaqar server's one | 21:13 |
*** njohnsto_ has quit IRC | 21:15 | |
flwang | Eva-i: i'm talking about the one you're pasting | 21:16 |
flwang | https://bugs.launchpad.net/zaqar/+bug/1518618 | 21:16 |
openstack | Launchpad bug 1518618 in zaqar "Tests from zaqar.tests.unit.transport.websocket.v1_1 do not execute(and fail if made executed)" [Low,Triaged] - Assigned to Fei Long Wang (flwang) | 21:16 |
Eva-i | flwang: ah, yes | 21:16 |
flwang | see https://github.com/openstack/zaqar/tree/master/zaqar/tests/unit/transport/websocket/v1_1 | 21:17 |
flwang | there is only one test files against subscriptions | 21:17 |
flwang | however, it's not really make sense for me | 21:17 |
flwang | since subscription is supported since v2 | 21:17 |
flwang | so do a test from v1.1 websocket against v2 subscriptions is weird | 21:17 |
Eva-i | flwang: you're right | 21:17 |
flwang | i'm going to fix it by move it to v2 folder and remove the v1.1 folder | 21:18 |
Eva-i | flwang: sounds good | 21:18 |
*** amitgandhinz has quit IRC | 21:19 | |
flwang | Eva-i: it's a nice catch, thanks | 21:19 |
Eva-i | flwang: I'm still stuck with websocket subscriptions. When I'm expecting notification from Zaqar server, I see nothing in html client. This is a part of Zaqar server's log, when it must send notification: http://paste.openstack.org/show/unSFZmOYXq0juBCRi4Qc/ | 21:19 |
Eva-i | As you can see there's an error related to webhook, it's strange because the notification must be websocket one, not webhook one. Have I misconfigured Zaqar, what do you think? | 21:19 |
*** amitgandhinz has joined #openstack-zaqar | 21:20 | |
flwang | i think i know the root cause | 21:21 |
flwang | when you create the subscription, how did you set the body? | 21:22 |
Eva-i | flwang: I use html client and it uses this body: {'queue_name': get_selected_queue(), 'ttl': 3600} | 21:23 |
Eva-i | get_selected_queue() is queue name | 21:24 |
flwang | Eva-i: unfortunately, it's not correct for your case | 21:24 |
flwang | you need to specify the subscriber | 21:24 |
flwang | otherwise, the script will use current websocket connection as the subscriber | 21:25 |
flwang | otherwise, after post the request to zaqar, (IIRC), there is a refresh for the html page | 21:25 |
Eva-i | This is full websocket payload send by html client: 'subscription_create', {'queue_name': get_selected_queue(), 'ttl': 3600} | 21:25 |
flwang | then the websocket will reconnect | 21:25 |
flwang | and as a result, it will generate a new connection | 21:26 |
flwang | yep, i know, for some cases, it should work | 21:26 |
flwang | but for the sample html, it's not correct | 21:27 |
Eva-i | but I think I want to use current websocket connection as subscriber | 21:27 |
flwang | yep, i know. but let's make sure if that's the root cause before fixing it | 21:27 |
flwang | can you try specify a subscriber | 21:27 |
Eva-i | flwang: oh, I'll try to do it. Now I don't know how | 21:28 |
*** mdnadeem has joined #openstack-zaqar | 21:29 | |
flwang | {'queue_name': get_selected_queue(), 'ttl': 3600, 'subscriber': 'http://127.0.0.1:8080'} | 21:30 |
*** flwang1 has joined #openstack-zaqar | 21:31 | |
Eva-i | flwang: should I deploy mini listening server on port 8080 in this example to test it | 21:31 |
Eva-i | ? | 21:31 |
flwang1 | Eva-i: yes, use this http://paste.openstack.org/show/483075/ | 21:31 |
Eva-i | flwang: oki | 21:32 |
*** njohnsto_ has joined #openstack-zaqar | 21:34 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Move subscription test from v1_1 to v2 https://review.openstack.org/263920 | 21:38 |
*** mdnadeem has quit IRC | 21:39 | |
Eva-i | flwang: okay, I tested it. Notification came to mini-server. But surprisingly it's webhook notification (HTTP POST). Is there a way to receive notifications over websocket? | 21:53 |
*** mpanetta has quit IRC | 21:54 | |
Eva-i | flwang: btw "nc -k -l 8080" linux command seems to be alternative to mini-server python script | 21:55 |
*** stanchan has joined #openstack-zaqar | 22:02 | |
*** dmowrer_ has quit IRC | 22:10 | |
flwang | nc command is ok for some cases, but personally i like to use my server script | 22:11 |
flwang | why you say surprisingly? | 22:11 |
*** dmowrer has joined #openstack-zaqar | 22:11 | |
flwang | i think it's expected behaviour based on the test | 22:11 |
Eva-i | flwang: yes, I mistaken, no surprise. | 22:11 |
flwang | Eva-i: so the websocket + subscription works fine when there is pre-defined 'subscriber' | 22:12 |
flwang | so next we can focus on the subscriber auto-fill case | 22:12 |
Eva-i | flwang: yes | 22:12 |
flwang | Eva-i: see https://github.com/openstack/zaqar/blob/master/examples/websocket.html#L192 | 22:14 |
Eva-i | flwang: I try to run two instances of html client with different client ids to test websocket subscriptions. One client is subscribed to queue, another one sends messages. I see no updates in the subscribed client, when I send messages. | 22:14 |
flwang | it's not related to client id | 22:14 |
flwang | it's related to the websocket connection | 22:15 |
flwang | my suggestion is change the script and use ajax to talk with zaqar server | 22:15 |
flwang | otherwise, when you click the button of the form, it will refresh the page, IIRC | 22:15 |
flwang | after the refresh, websocket will have to **reconnect** to zaqar and as a result, a **new** connection will be created | 22:16 |
Eva-i | flwang: refresh behavior occurs when Subscribe button is clicked? | 22:17 |
flwang | that's why the 'subscriber' based on the previous connection can't be accessed | 22:17 |
flwang | Eva-i: yes | 22:17 |
flwang | i noticed the issue when i do the test for horizon integration, but i don't have bandwidth to fix it | 22:18 |
Eva-i | flwang: hm, I haven't noticed refresh. Do you mean whole web page refresh or message pane refresh? | 22:18 |
*** dmowrer has quit IRC | 22:19 | |
*** kgriffs is now known as kgriffs|afk | 22:19 | |
*** boris-42 has joined #openstack-zaqar | 22:20 | |
flwang | Eva-i: maybe refresh is not an accurate word, you can print out the connection info for each time | 22:20 |
flwang | i can't remember clearly, sorry | 22:21 |
*** kgriffs|afk is now known as kgriffs | 22:22 | |
Eva-i | flwang: thanks, I'll check if a new connection is opened on the client when Subscribe button is clicked | 22:23 |
flwang | Eva-i: yep, that's the key point | 22:23 |
*** sriram has quit IRC | 22:28 | |
*** dmowrer has joined #openstack-zaqar | 22:33 | |
*** dmowrer has quit IRC | 22:38 | |
*** amitgandhinz has quit IRC | 22:47 | |
*** amitgandhinz has joined #openstack-zaqar | 22:48 | |
Eva-i | flwang: no, I can't reproduce. When I hit "Subscribe" button in both Zaqar-server and the html client I don't see that the new connection is being opened. The old connection keeps being reused. Also the html client's webpage do not refresh, just the message about successful subscription creation is added to the message pane ("Logs"). | 22:51 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription create v2 https://review.openstack.org/249395 | 22:52 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription show v2 https://review.openstack.org/261282 | 22:53 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription delete v2 https://review.openstack.org/261280 | 22:53 |
*** amitgandhinz has quit IRC | 22:57 | |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription update v2 https://review.openstack.org/261303 | 22:58 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription list v2 https://review.openstack.org/263531 | 23:03 |
*** ametts has quit IRC | 23:12 | |
*** csoukup has quit IRC | 23:12 | |
Eva-i | flwang: I'm going to bed right now, thank you for today, Fei Long. You can still leave messages for me, I'll read them by the morning. | 23:19 |
flwang | Eva-i: cool, thanks, have a good night | 23:19 |
*** kgriffs is now known as kgriffs|afk | 23:47 | |
*** kgriffs|afk is now known as kgriffs | 23:49 | |
*** kgriffs is now known as kgriffs|afk | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!