openstackgerrit | Fei Long Wang proposed openstack/zaqar: Move subscription test from v1_1 to v2 https://review.openstack.org/263920 | 00:30 |
---|---|---|
*** stanchan has quit IRC | 01:21 | |
*** stanchan has joined #openstack-zaqar | 02:21 | |
*** njohnst__ has joined #openstack-zaqar | 02:36 | |
*** njohnsto_ has quit IRC | 02:40 | |
*** flwang1 has quit IRC | 03:57 | |
*** davideagnello has quit IRC | 04:05 | |
*** stanchan has quit IRC | 04:32 | |
*** stanchan has joined #openstack-zaqar | 04:44 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/258076 | 04:58 |
*** davideagnello has joined #openstack-zaqar | 05:06 | |
*** davideagnello has quit IRC | 05:11 | |
*** davideagnello has joined #openstack-zaqar | 07:07 | |
*** davideagnello has quit IRC | 07:13 | |
*** stanchan has quit IRC | 07:19 | |
*** stanchan has joined #openstack-zaqar | 08:26 | |
*** AAzza has quit IRC | 08:42 | |
*** davideagnello has joined #openstack-zaqar | 09:09 | |
*** dmowrer has joined #openstack-zaqar | 09:12 | |
*** davideagnello has quit IRC | 09:14 | |
*** dmowrer has quit IRC | 09:16 | |
*** dynarro has joined #openstack-zaqar | 09:38 | |
*** AAzza has joined #openstack-zaqar | 09:42 | |
*** AAzza has quit IRC | 10:52 | |
*** AAzza has joined #openstack-zaqar | 10:53 | |
*** dynarro has quit IRC | 10:56 | |
*** AAzza has quit IRC | 11:04 | |
*** GB21 has joined #openstack-zaqar | 11:07 | |
*** AAzza has joined #openstack-zaqar | 11:07 | |
*** davideagnello has joined #openstack-zaqar | 11:10 | |
*** davideagnello has quit IRC | 11:15 | |
*** dmowrer has joined #openstack-zaqar | 12:10 | |
*** GB21 has quit IRC | 12:22 | |
*** pradk has quit IRC | 12:45 | |
*** mdnadeem has joined #openstack-zaqar | 13:13 | |
*** mdnadeem has quit IRC | 13:47 | |
*** njohnst__ has quit IRC | 13:55 | |
openstackgerrit | Ryan Brown proposed openstack/python-zaqarclient: Claim create CLI support for v1 https://review.openstack.org/258381 | 14:10 |
*** mpanetta has joined #openstack-zaqar | 14:32 | |
*** amitgandhinz has joined #openstack-zaqar | 14:42 | |
*** pradk has joined #openstack-zaqar | 14:42 | |
openstackgerrit | Tahio Avila proposed openstack/zaqar: Move in-line function outside method https://review.openstack.org/264210 | 14:55 |
*** ametts has joined #openstack-zaqar | 14:56 | |
*** sriram has joined #openstack-zaqar | 15:00 | |
*** malini has joined #openstack-zaqar | 15:07 | |
*** davideagnello has joined #openstack-zaqar | 15:12 | |
*** davideagnello has quit IRC | 15:16 | |
*** amitgandhinz has quit IRC | 15:16 | |
*** amitgandhinz has joined #openstack-zaqar | 15:17 | |
*** kgriffs|afk is now known as kgriffs | 15:37 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/zaqar: Use assertTrue/False instead of assertEqual(T/F) https://review.openstack.org/264240 | 15:53 |
*** stanchan has quit IRC | 15:56 | |
*** dynarro has joined #openstack-zaqar | 16:02 | |
*** kgriffs is now known as kgriffs|afk | 16:02 | |
*** kgriffs|afk is now known as kgriffs | 16:11 | |
*** davideagnello has joined #openstack-zaqar | 16:12 | |
*** davideagnello has quit IRC | 16:14 | |
*** davideagnello has joined #openstack-zaqar | 16:14 | |
*** dmowrer_ has joined #openstack-zaqar | 16:14 | |
*** dmowrer has quit IRC | 16:17 | |
*** dmowrer_ has quit IRC | 16:24 | |
*** dmowrer has joined #openstack-zaqar | 16:32 | |
*** davideagnello has quit IRC | 16:39 | |
*** dmowrer has quit IRC | 16:42 | |
*** dmowrer has joined #openstack-zaqar | 16:42 | |
*** kgriffs is now known as kgriffs|afk | 16:50 | |
*** stanchan has joined #openstack-zaqar | 17:13 | |
*** dmowrer has quit IRC | 17:18 | |
*** stanchan has quit IRC | 17:23 | |
*** dynarro has quit IRC | 17:26 | |
*** kgriffs|afk is now known as kgriffs | 17:42 | |
*** dmowrer has joined #openstack-zaqar | 18:01 | |
*** stanchan has joined #openstack-zaqar | 18:16 | |
*** kgriffs is now known as kgriffs|afk | 18:26 | |
*** malini has quit IRC | 18:32 | |
*** stanchan has quit IRC | 18:33 | |
*** stanchan has joined #openstack-zaqar | 18:39 | |
*** malini has joined #openstack-zaqar | 19:06 | |
flwang | jasondotstar: ping | 19:55 |
jasondotstar | flwang: happy new year | 19:55 |
flwang | jasondotstar: you too :) | 19:55 |
flwang | jasondotstar: as for the puppet zaqar patches, i asked my colleague Xav to help review it | 19:56 |
jasondotstar | sure | 19:56 |
flwang | hope it's helpful | 19:56 |
jasondotstar | I've got merge conflicts that I need to clean up :-( | 19:56 |
flwang | yep, i see | 19:57 |
*** flwang1 has joined #openstack-zaqar | 19:57 | |
*** dmowrer has quit IRC | 20:01 | |
jasondotstar | so I think the best course of action is to abandon those changes | 20:01 |
jasondotstar | and send up a new change for review. | 20:01 |
jasondotstar | I'll work on that. | 20:03 |
flwang | jasondotstar: ok, cool, good to know | 20:05 |
flwang | jasondotstar: so are you still optimistic to complete this in Mitaka? | 20:06 |
jasondotstar | oh yes | 20:06 |
jasondotstar | absolutely | 20:06 |
*** kgriffs|afk is now known as kgriffs | 20:06 | |
flwang | jasondotstar: then all good :D | 20:07 |
flwang | jasondotstar: thank you so much for your hard work | 20:07 |
jasondotstar | no worries. there's more work to be done. | 20:07 |
flwang | zaqar team really appreciate that | 20:07 |
jasondotstar | we're in the new year now | 20:08 |
flwang | haha | 20:08 |
jasondotstar | so much more to do. | 20:08 |
flwang | yep | 20:08 |
*** stanchan has quit IRC | 20:11 | |
openstackgerrit | Merged openstack/zaqar: Use assertTrue/False instead of assertEqual(T/F) https://review.openstack.org/264240 | 20:21 |
*** stanchan has joined #openstack-zaqar | 20:22 | |
*** stanchan has quit IRC | 21:03 | |
*** malini has quit IRC | 21:07 | |
*** stanchan has joined #openstack-zaqar | 21:09 | |
*** stanchan has quit IRC | 21:10 | |
*** stanchan has joined #openstack-zaqar | 21:10 | |
*** kragniz is now known as {^-^} | 21:17 | |
*** {^-^} is now known as Guest46353 | 21:18 | |
*** Guest46353 is now known as kragniz | 21:18 | |
*** vipul has quit IRC | 21:21 | |
*** mdnadeem has joined #openstack-zaqar | 21:29 | |
*** mdnadeem has quit IRC | 21:36 | |
*** mpanetta has quit IRC | 21:57 | |
*** bradjones has quit IRC | 22:04 | |
*** VeggieMeat_ has joined #openstack-zaqar | 22:04 | |
*** bradjones has joined #openstack-zaqar | 22:04 | |
*** bradjones has joined #openstack-zaqar | 22:04 | |
*** VeggieMeat has quit IRC | 22:05 | |
flwang | ryansb: ping | 22:06 |
ryansb | sup? | 22:07 |
flwang | are you ok with this https://review.openstack.org/#/c/249395/18/zaqarclient/queues/v2/subscription.py ? | 22:07 |
ryansb | my problem is that it isn't required in the constructor | 22:08 |
ryansb | so if it's required by the API, it should be required to make a Subscription object | 22:08 |
*** VeggieMeat_ is now known as VeggieMeat | 22:08 | |
ryansb | because I could do | 22:09 |
ryansb | s = Subscription(client, queue_name); | 22:09 |
ryansb | s.ensure_exists() | 22:09 |
ryansb | and I'd likely get a non-obvious exception | 22:09 |
*** dmowrer has joined #openstack-zaqar | 22:10 | |
flwang | ryansb: ah, i can see your point | 22:10 |
flwang | thanks | 22:11 |
ryansb | so it's not an issue for your CLI, but it's not a great Python API uses other than the CLI | 22:11 |
flwang | ryansb: i see | 22:11 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription create v2 https://review.openstack.org/249395 | 22:17 |
openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription update v2 https://review.openstack.org/261303 | 22:18 |
flwang | ryansb: pls revisit them :) thanks | 22:19 |
Eva-i | flwang: would you like me to fix this bug https://bugs.launchpad.net/python-zaqarclient/+bug/1529846 ? | 22:20 |
openstack | Launchpad bug 1529846 in Python client library for Zaqar "CLI fails to parse v2 pool list entry point" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 22:20 |
flwang | sure, pls | 22:21 |
Eva-i | flwang: first the bug must be confirmed by someone | 22:22 |
ryansb | flwang: gotta run, but will do as soon as I can | 22:22 |
flwang | ryansb: no problem, thanks | 22:22 |
flwang | Eva-i: done | 22:23 |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Move subscription test from v1_1 to v2 https://review.openstack.org/263920 | 22:25 |
*** sriram has quit IRC | 22:27 | |
Eva-i | flwang: thank you | 22:27 |
openstackgerrit | Eva Balycheva proposed openstack/python-zaqarclient: Fix bad "pool list" api v2 entry point for CLI https://review.openstack.org/264388 | 22:41 |
Eva-i | flwang: do you have any new thoughts about websocket subscriptions? Would you like to talk about it? | 22:45 |
flwang | new thoughts? | 22:46 |
flwang | depends on your test i think :) | 22:47 |
flwang | when you create a new subscription, did you print out the connection info? | 22:47 |
openstackgerrit | Merged openstack/zaqar: Move in-line function outside method https://review.openstack.org/264210 | 22:51 |
openstackgerrit | Merged openstack/zaqar: Updated from global requirements https://review.openstack.org/258076 | 22:51 |
openstackgerrit | Merged openstack/zaqar: Replace assertEqual(None, *) with assertIsNone in tests https://review.openstack.org/259036 | 22:51 |
openstackgerrit | Merged openstack/zaqar: Fix the docs link https://review.openstack.org/263634 | 22:53 |
openstackgerrit | Merged openstack/zaqar: Replace deprecated LOG.warn with LOG.warning https://review.openstack.org/263323 | 22:53 |
flwang | vkmc: pls review the subscriptions patches of client at your most convenience, thanks | 22:55 |
Eva-i | flwang: yes, I leaved a message about the test result yesterday. I didn't print out connection info on each click on "Subscribe" button (I don't know how), but there is "socket.onopen" event hook which already notifies in the "Logs" message pane if the new connection is being opened. | 22:55 |
Eva-i | The test result is: I don't see that the new connection is being opened when I click on Subscribe button, also I don't see any web page refresh - I see only successful subscription creation message in "Log". The old connection keeps being reused according to Zaqar server log and "Log" message pane in the client | 22:55 |
*** davideagnello has joined #openstack-zaqar | 22:57 | |
flwang | and you still can't get notification? | 22:59 |
Eva-i | flwang: yes, I don't get notifications | 23:00 |
flwang | Eva-i: ok, can you show me the log of zaqar? | 23:01 |
Eva-i | flwang: okay, I will also post my zaqar.conf. Maybe I messed something in [storage] section. | 23:02 |
flwang | nope, i don't think so | 23:03 |
flwang | since you can get notification with a specified subscriber | 23:03 |
Eva-i | flwang: okay, I just thought it might be bad that I assigned "zaqar.notification.notifier" to each pipeline in the [storage] section. | 23:04 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-zaqarclient: Updated from global requirements https://review.openstack.org/264408 | 23:11 |
*** amitgandhinz has quit IRC | 23:18 | |
openstackgerrit | Merged openstack/python-zaqarclient: Fix bad "pool list" api v2 entry point for CLI https://review.openstack.org/264388 | 23:18 |
*** pradk has quit IRC | 23:18 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-zaqarclient: Updated from global requirements https://review.openstack.org/264408 | 23:19 |
*** davideagnello has quit IRC | 23:20 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/264472 | 23:20 |
*** davideagnello has joined #openstack-zaqar | 23:21 | |
*** stanchan has quit IRC | 23:21 | |
*** davideagnello has quit IRC | 23:25 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/264472 | 23:29 |
*** stanchan has joined #openstack-zaqar | 23:33 | |
*** davideagnello has joined #openstack-zaqar | 23:34 | |
Eva-i | flwang: I will not provide the log. I finally found a bug in html client. I'm going to report it and fix it. After, the websocket binary support patch will be made in no time. =) | 23:37 |
*** ametts has quit IRC | 23:41 | |
*** stanchan has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!