| Eva-i | flwang: can you please address these things: https://etherpad.openstack.org/p/temp | 00:00 |
|---|---|---|
| flwang | Eva-i: i can't access the link above | 00:06 |
| Eva-i | flwang: oki, here's another link http://paste.openstack.org/show/7zdNTPj69JWmSofFzNIm/ | 00:07 |
| flwang | Eva-i: In APIs v1 and v1.1 it's possible to create queue with attributes, but there is no validation of their values. Is it okay? why do we need to check the attributes ? | 00:09 |
| flwang | Eva-i: for your 2nd question, the answer is yes. but I would like to do it in a separate patch | 00:12 |
| flwang | and i hate to duplicate the work for websocket and wsgi :( | 00:12 |
| Eva-i | flwang: if you want, I will make this duplicate work. | 00:55 |
| Eva-i | flwang: "why do we need to check the attributes ?" Maybe because we don't want bad values to be written to database. Or because it can cause unexpected behavior. | 00:57 |
| *** kgriffs is now known as kgriffs|afk | 01:01 | |
| *** achanda has quit IRC | 01:03 | |
| flwang | Eva-i: i have added the websocket part | 01:04 |
| flwang | Eva-i: what's the bad values? | 01:04 |
| flwang | for the metadata | 01:04 |
| Eva-i | flwang: negative default ttl, for example? | 01:05 |
| flwang | are we on the same page? | 01:06 |
| flwang | i'm talking about this " In APIs v1 and v1.1 it's possible to create queue with attributes, but there is no validation of their values." | 01:06 |
| flwang | for v1 and v1.1, of course, user can add any k-v pair for metadata | 01:06 |
| Eva-i | flwang: yes | 01:07 |
| flwang | and i don't think in this patch we should care about that | 01:07 |
| Eva-i | flwang: yes, in this patch you try to modify API v2 only. But user actions in API v1 and API v1.1 in our case will affect Zaqar's behavior in API v2, because API v2 is using same database for functioning. | 01:13 |
| flwang | Eva-i: i see | 01:15 |
| flwang | but | 01:15 |
| flwang | it's user's queue, right? | 01:15 |
| Eva-i | flwang: yes | 01:15 |
| flwang | so technically, they should know what they're doing | 01:15 |
| flwang | just like i said above, if user set the max post size as -1 or 0, they know what they are doing | 01:16 |
| flwang | if user create the queue with v1 and set the metadata with a unreasonable value, then i don't think we should cover this case | 01:17 |
| flwang | let's see the other reviewers comments | 01:17 |
| *** sriram has joined #openstack-zaqar | 01:32 | |
| Eva-i | flwang: oki, I'll try to post messages with ttl: "hey, I'm ttl" string as value and see if Zaqar will still behave correctly. | 01:33 |
| flwang | for v1 and v2? | 01:33 |
| flwang | you can try, but i think you will get a validation error | 01:34 |
| Eva-i | flwang1: I'll create a queue with default ttl attribute "hey, I'm ttl" in API v1 and then try to post messages via API v2. | 01:34 |
| flwang | oh, does your v2 include my patch? | 01:35 |
| Eva-i | flwang: yes | 01:36 |
| flwang | and you can post messages? | 01:38 |
| flwang | let me check | 01:38 |
| Eva-i | flwang: it's okay, I'm going to test if it's possible | 01:38 |
| Eva-i | flwang: I think now it's possible. | 01:38 |
| openstackgerrit | wanghao proposed openstack/zaqar: Show default attributes for queue https://review.openstack.org/286433 | 01:43 |
| wanghao | flwang: ping | 01:47 |
| wanghao | flwang: I found we miss metadata validation too in patch :https://review.openstack.org/#/c/280941/7. Please see my commit. | 01:48 |
| *** achanda has joined #openstack-zaqar | 01:51 | |
| flwang | wanghao: nice catch | 01:51 |
| wanghao | flwang: :) | 01:51 |
| wanghao | flwang: about this " In APIs v1 and v1.1 it's possible to create queue with attributes, but there is no validation of their values." I suggest we don't change v1 and v1.1 since we should consider backward compatible. For future development, we can deprecate v1(or v1.1) step by step like other projecting is doing. | 02:18 |
| Eva-i | wanghao: yes, deprecating is a nice option I think. | 02:18 |
| Eva-i | wanghao: our Zaqar wiki says that if new Zaqar API gets released, the previous API is automatically considered as deprecated. | 02:19 |
| Eva-i | wanghao: much time passed since our API v1 and API v1.1 were deprecated. Maybe we should stop supporting them. | 02:19 |
| wanghao | Eva-i: Yes, agree with you. | 02:20 |
| wanghao | Eva-i: So if we found some bugs in deprecated API, we just need to avoid them in new API. | 02:23 |
| Eva-i | wanghao: personally I think the change can be considered as backward compatible to all Zaqar APIs, because there's very low probability that someone was using such names like "_max_messages_post_size" as keys inside queue metadata. | 02:24 |
| flwang | v1.1 is still the default version in openstack client | 02:29 |
| Eva-i | wanghao: yes, that's the ideal behavior we should do. But flwang is not ready for new API. | 02:29 |
| flwang | v1 is still used by rackspace | 02:29 |
| Eva-i | wanghao: flaper87 (our previous PTL) said that we need to maintain backward compatibility even in Zaqar API v2. But seems like we do not to follow this rule. | 02:29 |
| flwang | Eva-i: i don't agree with you | 02:29 |
| Eva-i | flwang: in what? | 02:29 |
| flwang | flaper87 (our previous PTL) said that we need to maintain backward compatibility even in Zaqar API v2. But seems like we do not to follow this rule. | 02:30 |
| flwang | we should and we are following the rule | 02:30 |
| flwang | in generally | 02:30 |
| flwang | for some reason, we have to break it a little bit | 02:30 |
| flwang | such as security hole | 02:30 |
| Eva-i | flwang: yes =/ | 02:31 |
| flwang | so pls don't say we're not following the rule | 02:31 |
| flwang | since it may confuse some new comers :) | 02:32 |
| Eva-i | oki, breaking a bit doesn't count =) | 02:33 |
| wanghao | flwang, Eva-i: If we still support V1 and V1.1 for a time, then I think we add validation about "_max_mesages_post_size" and "_default_message_ttl" is not a bad thing. | 02:33 |
| wanghao | flwang, Eva-i: in V1 and V1.1 API. | 02:34 |
| Eva-i | flwang: wanghao: here's my testing report http://paste.openstack.org/show/EXBDnXNZw6vzVPd9R9d0/ | 02:35 |
| Eva-i | flwang: wanghao: for the patch https://review.openstack.org/#/c/265723/ | 02:35 |
| flwang | Eva-i: can you paste the error log of zaqar? | 02:39 |
| Eva-i | flwang: yes | 02:40 |
| Eva-i | flwang: here http://paste.openstack.org/show/kRIshUxXNtz5D3NQcVYP/ | 02:41 |
| Eva-i | flwang: but the order of requests is different from my report. In the report I moved up request that caused 500 error. | 02:42 |
| flwang | Eva-i: cool, so \ | 02:42 |
| flwang | the error is happening at the validation level | 02:42 |
| flwang | that means we just need to handle it there and don't have to change anything for v1 and v1.1 | 02:42 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support metadata update issue for v1.1 and v2 https://review.openstack.org/280941 | 02:43 |
| Eva-i | flwang: who knows, maybe we will make some a patch to Zaqar in the future and the error will happen in some other place. | 02:43 |
| Eva-i | flwang: it's hard to predict | 02:44 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support metadata update issue for v1.1 and v2 https://review.openstack.org/280941 | 02:45 |
| Eva-i | if we are not allowed to make backward incompatible changes to all our APIs, but we still want to make such change, why not to make this change to all APIs, so there will be at least some integrity. | 02:47 |
| flwang | Eva-i: i didn't see there is any integrity issue, it's new feature | 02:48 |
| flwang | we don't want to touch the old version code for new feature if we can | 02:48 |
| flwang | and again, i didn't see any backward compatibility issue for this change, as for the 500 error you mentioned above, i think it only happens on py3.x | 02:49 |
| Eva-i | flwang: yes, on python 3 | 02:50 |
| flwang | you won't see any error for py2.7 | 02:50 |
| flwang | i'm happy to fix it | 02:50 |
| Eva-i | flwang: what about 400 error responses? It's something we can live with? | 02:51 |
| flwang | if we can fix that, do you still think it's a backward compatibility issue? | 02:51 |
| flwang | if the max post size isn't a int, we will compare the message size with the max size defined in config | 02:52 |
| Eva-i | I don't understand the question. | 02:52 |
| flwang | Eva-i: ok, so what's the backward compatibility you're talking about? | 02:53 |
| Eva-i | flwang: I responded to wanghao's message: "I suggest we don't change v1 and v1.1 since we should consider backward compatible. For future development, we can deprecate v1(or v1.1) step by step like other projecting is doing.". Later I said that I don't see a problem with it on all APIs, because "there's very low probability that someone was using such names like "_max_messages_post_size" as keys inside queue metadata." | 02:56 |
| flwang | i see. so the 500 error issue you raised above, i think it's not a backward compatibility issue, agree? | 02:59 |
| Eva-i | flwang: yes | 02:59 |
| flwang | ok, cool | 03:00 |
| flwang | wanghao: Eva-i: so are we on the same page now? | 03:00 |
| Eva-i | Oki, I have nothing to say about https://review.openstack.org/#/c/265723/. I already provided all information about my concerns about storing bad values in database. | 03:00 |
| flwang | we don't have to change the v1 and v1.1 api | 03:00 |
| Eva-i | flwang: I better think about other patches now.. | 03:00 |
| flwang | Eva-i: hehe, cool | 03:01 |
| flwang | Eva-i: as for the negative/0 issue, i will fix it | 03:01 |
| flwang | wxy: wanghao: if you guys can help fix the functional test error of https://review.openstack.org/276548 it would awesome | 03:06 |
| flwang | feel free submit a new patch set and add yourself as a co-author | 03:06 |
| wxy | flwang: I'll have a try later. I'm looking at the osprofiler patch : https://review.openstack.org/#/c/141356/15 | 03:10 |
| flwang | wxy: oh, nice, if you can take over that one, it would be nice | 03:11 |
| wxy | I think it's useful to introduce this feature to zaqar. | 03:11 |
| flwang | zhiyan has moved to alibaba, won't work for openstack | 03:11 |
| wxy | flwang: :) | 03:14 |
| zhiyan | :) | 03:15 |
| Eva-i | :) | 03:16 |
| flwang | zhiyan: you're around, i can't believe my eyes | 03:16 |
| flwang | how are you | 03:16 |
| flwang | zhiyan: are you still working for ali? | 03:17 |
| zhiyan | I'm petty cool atm, I'm joining a startup, some Alibaba/ex-alibaba Cloud employees working in it atm | 03:18 |
| zhiyan | How are you feilong? | 03:19 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 03:19 |
| wanghao | flwang: Sure, I will fix this. | 03:21 |
| flwang | zhiyan: working as the zaqar PTL, and have fun :D | 03:23 |
| flwang | zhiyan: what's your company name? | 03:23 |
| flwang | link? | 03:24 |
| zhiyan | For now we are working on company registration process and dev some initial features for our idea | 03:24 |
| *** david-lyle has joined #openstack-zaqar | 03:24 | |
| flwang | zhiyan: ah, pretty cool | 03:24 |
| zhiyan | flwang: yes I noticed the information form mail list . And it pretty pity I have no time for community contributions. | 03:28 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Add `_max_messages_post_size` and `_default_message_ttl` for queue https://review.openstack.org/265723 | 03:36 |
| *** shu-mutou-AFK is now known as shu-mutou | 03:53 | |
| *** sriram has quit IRC | 03:56 | |
| *** flwang1 has quit IRC | 03:59 | |
| openstackgerrit | wanghao proposed openstack/zaqar: Fix the TTL issue of subscriptions for Redis https://review.openstack.org/276548 | 04:01 |
| Eva-i | flwang: can you talk with me a bit about flavors? | 04:11 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 04:14 |
| *** akanksha_ has joined #openstack-zaqar | 04:30 | |
| *** GB21 has joined #openstack-zaqar | 05:02 | |
| *** achanda has quit IRC | 05:35 | |
| *** pcaruana has joined #openstack-zaqar | 05:36 | |
| openstackgerrit | wanghao proposed openstack/zaqar: Fix the TTL issue of subscriptions for Redis https://review.openstack.org/276548 | 05:38 |
| *** achanda has joined #openstack-zaqar | 05:39 | |
| openstackgerrit | Merged openstack/python-zaqarclient: Update pool on pool create if it exists https://review.openstack.org/266808 | 05:39 |
| *** achanda has quit IRC | 05:39 | |
| *** pcaruana has quit IRC | 05:49 | |
| *** rcernin has joined #openstack-zaqar | 05:51 | |
| *** GB21 has quit IRC | 05:57 | |
| *** achanda has joined #openstack-zaqar | 06:00 | |
| *** exploreshaifali has joined #openstack-zaqar | 06:25 | |
| openstackgerrit | Shu Muto proposed openstack/zaqar-ui: Add update queue action https://review.openstack.org/286468 | 06:43 |
| *** jtomasek has joined #openstack-zaqar | 07:19 | |
| *** khushbu_ has joined #openstack-zaqar | 07:53 | |
| *** pcaruana has joined #openstack-zaqar | 08:02 | |
| *** achanda has quit IRC | 08:03 | |
| *** exploreshaifali has quit IRC | 08:06 | |
| *** GB21 has joined #openstack-zaqar | 08:06 | |
| *** achanda has joined #openstack-zaqar | 08:07 | |
| *** achanda has quit IRC | 08:18 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 08:19 |
| *** GB21 has quit IRC | 08:21 | |
| *** GB21 has joined #openstack-zaqar | 08:23 | |
| *** exploreshaifali has joined #openstack-zaqar | 08:48 | |
| *** khushbu_ has quit IRC | 09:00 | |
| *** flwang1 has joined #openstack-zaqar | 09:14 | |
| *** exploreshaifali has quit IRC | 09:41 | |
| *** lane_kong is now known as lynn | 09:45 | |
| *** lynn is now known as Guest29970 | 09:46 | |
| *** Guest29970 is now known as lynn_kong | 09:46 | |
| *** GB21 has quit IRC | 09:47 | |
| *** GB21 has joined #openstack-zaqar | 09:50 | |
| *** AAzza has quit IRC | 09:53 | |
| *** AAzza has joined #openstack-zaqar | 09:53 | |
| *** GB21 has quit IRC | 09:57 | |
| *** AAzza has quit IRC | 09:57 | |
| *** AAzza has joined #openstack-zaqar | 09:58 | |
| *** GB21 has joined #openstack-zaqar | 10:00 | |
| *** exploreshaifali has joined #openstack-zaqar | 10:02 | |
| *** flwang1 has quit IRC | 10:03 | |
| *** lynn_kong is now known as Larrie | 10:12 | |
| *** flwang1 has joined #openstack-zaqar | 10:12 | |
| *** Larrie is now known as larrie | 10:12 | |
| *** shu-mutou is now known as shu-mutou-AFK | 10:18 | |
| *** flwang1 has quit IRC | 10:25 | |
| *** larrie is now known as larrie_kong | 10:28 | |
| *** wxy has quit IRC | 10:39 | |
| *** rguichard has joined #openstack-zaqar | 10:45 | |
| rguichard | Hi everyone | 10:45 |
| rguichard | I was wondering if a zaqar queue created by tenant A can be reachable by tenant B ? | 10:46 |
| rguichard | I'm talking about true inter-tenant queues | 10:47 |
| *** AAzza has quit IRC | 10:48 | |
| therve | rguichard, If you use signed URL to skip authentication then yes | 10:50 |
| *** AAzza has joined #openstack-zaqar | 10:50 | |
| *** rguichard has quit IRC | 10:58 | |
| *** rguichard has joined #openstack-zaqar | 11:01 | |
| rguichard | therve: by skipping auth, user (without access to tenant A) can access to a queue created by tenant A ? | 11:02 |
| rguichard | i'm not familiar with signed url, I might have misunderstood ^^ | 11:03 |
| therve | rguichard, Yes it relies on a shared secret | 11:04 |
| therve | Unfortunately it doesn't look very well documented | 11:04 |
| *** rguichard has quit IRC | 11:08 | |
| *** GB21 has quit IRC | 11:09 | |
| openstackgerrit | wanghao proposed openstack/python-zaqarclient: Show default attributes for queue https://review.openstack.org/287114 | 11:09 |
| openstackgerrit | wanghao proposed openstack/zaqar: Show default attributes for queue https://review.openstack.org/286433 | 11:13 |
| openstackgerrit | wanghao proposed openstack/python-zaqarclient: Show default attributes for queue https://review.openstack.org/287114 | 11:14 |
| *** khushbu_ has joined #openstack-zaqar | 11:15 | |
| *** GB21 has joined #openstack-zaqar | 11:21 | |
| *** AAzza has quit IRC | 11:49 | |
| *** AAzza has joined #openstack-zaqar | 11:50 | |
| *** AAzza has quit IRC | 12:05 | |
| *** AAzza has joined #openstack-zaqar | 12:08 | |
| *** GB21 has quit IRC | 12:13 | |
| *** akanksha_ has quit IRC | 12:17 | |
| *** rguichard has joined #openstack-zaqar | 12:26 | |
| *** GB21 has joined #openstack-zaqar | 12:37 | |
| *** GB21 has quit IRC | 12:44 | |
| *** amitgandhinz has joined #openstack-zaqar | 13:57 | |
| *** kgriffs|afk is now known as kgriffs | 14:04 | |
| *** exploreshaifali has quit IRC | 14:18 | |
| *** khushbu_ has quit IRC | 14:19 | |
| *** mpanetta has joined #openstack-zaqar | 14:40 | |
| *** GB21 has joined #openstack-zaqar | 14:43 | |
| *** itisha has joined #openstack-zaqar | 14:44 | |
| *** GB21 has quit IRC | 14:53 | |
| *** rguichard has quit IRC | 14:54 | |
| *** pt_15 has joined #openstack-zaqar | 14:55 | |
| *** GB21 has joined #openstack-zaqar | 15:05 | |
| *** sriram has joined #openstack-zaqar | 15:21 | |
| *** GB21 has quit IRC | 15:22 | |
| *** pcaruana has quit IRC | 16:05 | |
| *** exploreshaifali has joined #openstack-zaqar | 16:13 | |
| *** larrie_kong has quit IRC | 16:15 | |
| *** larrie_kong has joined #openstack-zaqar | 16:15 | |
| *** larrie_kong has quit IRC | 16:15 | |
| *** larrie_kong has joined #openstack-zaqar | 16:15 | |
| *** david-lyle has quit IRC | 16:36 | |
| *** david-lyle has joined #openstack-zaqar | 16:38 | |
| *** kgriffs is now known as kgriffs|afk | 16:56 | |
| *** kgriffs|afk is now known as kgriffs | 16:57 | |
| *** venkat has joined #openstack-zaqar | 17:02 | |
| *** venkat has quit IRC | 17:06 | |
| *** venkat has joined #openstack-zaqar | 17:08 | |
| *** achanda has joined #openstack-zaqar | 17:12 | |
| *** malini has joined #openstack-zaqar | 17:27 | |
| *** achanda has quit IRC | 17:27 | |
| *** venkat has quit IRC | 17:33 | |
| *** boris-42 has joined #openstack-zaqar | 17:35 | |
| *** malini1 has joined #openstack-zaqar | 17:45 | |
| *** achanda has joined #openstack-zaqar | 17:45 | |
| *** malini has quit IRC | 17:46 | |
| *** khushbu_ has joined #openstack-zaqar | 18:03 | |
| *** malini1 has quit IRC | 18:05 | |
| *** david-lyle has quit IRC | 18:12 | |
| *** david-lyle has joined #openstack-zaqar | 18:13 | |
| *** flwang1 has joined #openstack-zaqar | 18:33 | |
| *** flwang1 has quit IRC | 18:34 | |
| *** mpanetta has quit IRC | 18:36 | |
| *** amitgandhinz has quit IRC | 18:42 | |
| *** amitgandhinz has joined #openstack-zaqar | 18:45 | |
| *** malini has joined #openstack-zaqar | 18:57 | |
| *** malini has quit IRC | 19:05 | |
| *** kgriffs is now known as kgriffs|afk | 19:32 | |
| *** exploreshaifali has quit IRC | 19:38 | |
| *** davideagnello is now known as davideagnello__ | 19:40 | |
| *** davideagnello__ is now known as davide85_ | 19:45 | |
| *** kgriffs|afk is now known as kgriffs | 19:53 | |
| *** khushbu_ has quit IRC | 20:01 | |
| flwang | Eva-i: ping | 20:28 |
| Eva-i | flwang: hello! | 20:28 |
| flwang | Eva-i: i'm reviewing your comment on ps 10 for https://review.openstack.org/#/c/265723/ | 20:29 |
| Eva-i | flwang: I was just repeating myself, you already know all that | 20:30 |
| Eva-i | flwang: I was repeating myself, so others could know the problem | 20:30 |
| flwang | yep, but I want to make it clear to avoid any confusion | 20:30 |
| flwang | so you still think the 400 error is problem/issue? | 20:31 |
| Eva-i | flwang: just a minor problem | 20:31 |
| Eva-i | flwang: personally I can live with it | 20:31 |
| flwang | 400 error is an expected error | 20:32 |
| flwang | just like a validation fail | 20:32 |
| Eva-i | flwang: oki... | 20:33 |
| flwang | ryansb: vkmc: may i get your guys comments on https://review.openstack.org/265723 ? | 20:33 |
| flwang | we only have 2 days | 20:33 |
| *** rcernin has quit IRC | 20:36 | |
| Eva-i | flwang: oki, so the user should know what he's doing | 20:36 |
| Eva-i | flwang: In all other aspects I like this patch. I guess I should mark the patch +1 or +2. | 20:37 |
| flwang | Eva-i: i can definately see your point on this patch. But just like I said before, 1. I don't want to touch old api version code given it's a new feature. 2. I don't want to change too much code since it's a performance impact change | 20:39 |
| flwang | that said i don't want to add too much check to impact any performance | 20:39 |
| flwang | zaqar is not like other projects, zaqar is really sensitive to performance | 20:41 |
| flwang | personally, i don't want to make a perfect(too many checks) validation to lose any performance, that's my baseline | 20:41 |
| flwang | there are something we should teach(by document) user how to use it instead of adding so many checks to let them try the barrier | 20:43 |
| flwang | that's just my 2 cents | 20:43 |
| Eva-i | flwang: when I was learning zaqar and trying different requests on different APIs, I opened API reference only in cases when Zaqar returned some error. | 20:44 |
| ryansb | I disagree: a performant system that doesn't verify inputs isn't really ready for consumption | 20:45 |
| ryansb | esp not in a public cloud setting | 20:45 |
| *** david-lyle has quit IRC | 20:45 | |
| *** david-lyle has joined #openstack-zaqar | 20:47 | |
| Eva-i | flwang: yes, this is a new feature for API v2. I don't wish to modify message posting in API v1 and API v1.1, but just modify putting metadata to queue, so bad data can't reach database. And about performance. AFAIK new queue putting happens not so often, but I might be wrong. | 20:58 |
| Eva-i | flwang: If you think queue putting happens often and you're concerned about performance, it was not very good decision for you to add new exception catching in API v2 message posting, when queue does not exist (see L168 in https://review.openstack.org/#/c/265723/10/zaqar/transport/wsgi/v2_0/messages.py). I tried to measure how new exception catching might affect performance, but HTTP delays were so big, so it was impossible to measure. | 21:02 |
| Eva-i | flwang: but in general patch is good, I like it | 21:02 |
| flwang | ryansb: not doesn't verify ;) | 21:03 |
| flwang | ryansb: you may need to read the whole story | 21:03 |
| ryansb | I see - will do | 21:03 |
| flwang | ryansb: but firstly, just review the code :D | 21:04 |
| ryansb | yeah, haven't for a couple revisions | 21:04 |
| flwang | ryansb: any progress of the queue metadata update client patch? | 21:12 |
| flwang | do you need any help? | 21:12 |
| ryansb | nope, I'm all set. Just been fighting to get enough time to finish it up :) | 21:12 |
| flwang | ryansb: we need to get it in by Fri, if possible | 21:13 |
| ryansb | yeah, should be able to do that | 21:13 |
| ryansb | After all, there's a new core to help me merge it | 21:14 |
| ryansb | ;) | 21:14 |
| flwang | ryansb: cool, thanks | 21:14 |
| Eva-i | Is it possible to list claims that queue has? | 21:14 |
| ryansb | Not sure, you can get the count of claimed messages by listing the stats for the queue | 21:15 |
| ryansb | afaik the claim controller doesn't let you list them | 21:16 |
| Eva-i | ryansb: alright, just wanted to know, thanks | 21:17 |
| *** njohnston has left #openstack-zaqar | 21:18 | |
| *** flwang1 has joined #openstack-zaqar | 21:19 | |
| flwang | ryansb: https://review.openstack.org/#/c/270464/ | 21:25 |
| flwang | ryansb: https://review.openstack.org/#/c/276603/ | 21:25 |
| ryansb | hm, thought I merged that one | 21:26 |
| flwang | ryansb: i think https://review.openstack.org/#/c/276603/ is the last one we want to merge for client release | 21:26 |
| flwang | ryansb: yep, it's rebased | 21:26 |
| ryansb | gotcha | 21:27 |
| flwang | ryansb: thanks | 21:27 |
| flwang | i'm going to release zaqar client :D | 21:27 |
| ryansb | don't you want to wait for my patch on queue updates this wk? | 21:27 |
| ryansb | or do we plan on another release soon? | 21:27 |
| flwang | ryansb: aaaaaaaaaaaaaaah sorry | 21:28 |
| flwang | ryansb: yep, i should wait for you :D | 21:28 |
| flwang | sorry about that | 21:28 |
| flwang | Eva-i: can you help review https://review.openstack.org/276548? | 21:28 |
| Eva-i | flwang: i'm currently reviewing it. Found some problems with subscription API in general | 21:29 |
| flwang | Eva-i: cool, thanks | 21:30 |
| flwang | Eva-i: and https://review.openstack.org/280941 though there is a py34 failure, but i don't think it's related | 21:30 |
| Eva-i | flwang: yes, I will | 21:49 |
| *** jtomasek has quit IRC | 21:50 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Fix freeze on some requests https://review.openstack.org/284897 | 21:58 |
| *** achanda has quit IRC | 22:06 | |
| *** achanda has joined #openstack-zaqar | 22:13 | |
| *** achanda has quit IRC | 22:20 | |
| flwang | ryansb: urgent patch https://review.openstack.org/#/c/284897/8 new to be reviewed, thanks | 22:21 |
| *** amitgandhinz has quit IRC | 22:28 | |
| *** sriram has quit IRC | 23:00 | |
| openstackgerrit | Merged openstack/python-zaqarclient: "pool_group" word should be used instead "pool" https://review.openstack.org/276603 | 23:16 |
| *** achanda has joined #openstack-zaqar | 23:20 | |
| *** achanda has quit IRC | 23:28 | |
| *** pt_15 has quit IRC | 23:35 | |
| *** itisha has quit IRC | 23:39 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!