| flwang | Eva-i: ping | 00:32 |
|---|---|---|
| Eva-i | flwang: hello | 00:32 |
| flwang | Eva-i: for comments in https://review.openstack.org/276548 which one is the -1 come from? | 00:33 |
| Eva-i | flwang: all without NIT prefix. But the most important comment is this https://review.openstack.org/#/c/276548/5/zaqar/storage/redis/subscriptions.py@115 | 00:34 |
| flwang | Eva-i: ok, actually, we don't need expires for now, since redis can't use it for auto expires | 00:38 |
| flwang | but as you mentioned, we may use it for age | 00:38 |
| flwang | so that's why i would like to keep it | 00:38 |
| Eva-i | flwang: that's right, it's only needed for age | 00:38 |
| Eva-i | flwang: so you will revert it back to linux time? | 00:39 |
| flwang | and the reason why i would like to keep it as a date format, is i would like to be consistent with mongodb driver | 00:39 |
| Eva-i | flwang: in mongodb driver it's int, not dateformat | 00:40 |
| flwang | linux tme? do you mean time in seconds? | 00:40 |
| Eva-i | not linux time, I mean timestamp | 00:41 |
| flwang | in mongdb, it's Date, i'm pretty sure | 00:41 |
| flwang | that's what i'm fixing in https://review.openstack.org/#/c/270464/10/zaqar/storage/mongodb/subscriptions.py | 00:41 |
| *** shu-mutou-AFK is now known as shu-mutou | 00:42 | |
| Eva-i | flwang: https://github.com/openstack/zaqar/blob/master/zaqar/storage/mongodb/subscriptions.py#L96 | 00:42 |
| flwang | Eva-i: you need to take a rest :) | 00:43 |
| Eva-i | flwang: :o | 00:45 |
| flwang | Eva-i: :D | 00:45 |
| flwang | mongodb's expires() doesn't work with non-Date value, that's what i'm fixing | 00:45 |
| flwang | and with datetime format, we can also calculate the age in the future, it's not a problem | 00:46 |
| flwang | does that address your concern? | 00:46 |
| Eva-i | flwang: oh, thanks, that's a very good explanation. Okay, then you need to modify other functions in redis driver that still expect "expires" to be int | 00:48 |
| flwang | Eva-i: ok, no problem. those are nice catch :D | 00:49 |
| flwang | i'm happy to have you in the team to always stop me when i'm rush :D | 00:49 |
| Eva-i | flwang: oh, maybe it's not a very good thing. But the good thing is that I prevent bugs. So maybe I save time in the long run. | 00:52 |
| Eva-i | Hm. Maybe there's no need to make redis driver internally more similar to mongodb driver. | 00:56 |
| flwang | Eva-i: i see. but i can't see any benefit to keep the 'expires' as a init | 00:56 |
| Eva-i | flwang: keeping it int: 1. no much refactoring so quick and easy to review 2. faster to use 3. smaller | 00:57 |
| flwang | i can't follow #2 and #3 | 00:58 |
| openstackgerrit | David Cusatis proposed openstack/zaqar-ui: Add Subscriptions to Queue drawer https://review.openstack.org/284921 | 01:00 |
| flwang | david_cu: thanks :) | 01:03 |
| david_cu | hang on | 01:03 |
| david_cu | don't look at that one yet :) | 01:03 |
| david_cu | having a lot of git review troubles atm | 01:03 |
| flwang | david_cu: haha | 01:03 |
| david_cu | accidentally pushed the wrong patch! | 01:03 |
| flwang | david_cu: oh, ok :) | 01:03 |
| Eva-i | flwang: after all redis driver just need to return these fields related to expiration date: ttl and age. | 01:04 |
| *** larrie_kong is now known as kong | 01:04 | |
| flwang | Eva-i: so you mean given we don't the field, so we don't have to convert it, is that all the point? | 01:05 |
| Eva-i | flwang: #2. Zaqar make comparisons of dates in redis driver. Comparing ints is faster. And there's convertation, yes #3. Seems like I'm wrong about size in redis. | 01:07 |
| Eva-i | flwang: but oki, feel free to do what is comfortable to you | 01:07 |
| flwang | Eva-i: ok, i will keep it as int, until we found it's not suitable | 01:08 |
| flwang | btw, i don't think the 'data model' change is a big problem | 01:09 |
| flwang | given we're using NOSQL | 01:09 |
| flwang | and we just totally skip the set for subscriber | 01:09 |
| flwang | so even there is a user using redis who want to migrate to Mitaka, i don't see any migration problem | 01:09 |
| openstackgerrit | David Cusatis proposed openstack/zaqar-ui: Add Subscriptions to Queue drawer https://review.openstack.org/284921 | 01:10 |
| Eva-i | flwang: yeah, me too. I see no problem with not using <project_id>.<queue_name>.subscribers key anymore. NoSQL doesn't guarantee that the change is always compatible. For example, if we would have added new key, there might be some problems. | 01:12 |
| david_cu | that is the right patch set now, though still WIP we're getting close flwang! git review has been a thorn in my side all day | 01:14 |
| flwang | david_cu: got, thank you | 01:15 |
| flwang | Eva-i: what's your current time now? | 01:15 |
| Eva-i | flwang: 4 AM. But I got up late today. | 01:16 |
| flwang1 | Eva-i: oh my god | 01:16 |
| flwang1 | Eva-i: pls go to bed | 01:16 |
| Eva-i | flwang1: but I'm doing it for months... And it's good that we're active at the same time. But if you want, I can go to bed. :o | 01:17 |
| flwang | take a rest, you have worked very hard | 01:23 |
| Eva-i | flwang: oki. But if I was doing something wrong, we can discuss it later. I'm still a bit inexperienced, you know... | 01:28 |
| flwang | Eva-i: no worries, you're doing great job | 01:30 |
| *** wxy has joined #openstack-zaqar | 01:38 | |
| *** openstackgerrit has quit IRC | 01:47 | |
| *** openstackgerrit has joined #openstack-zaqar | 01:48 | |
| *** eliqiao_ has joined #openstack-zaqar | 02:20 | |
| *** therve has quit IRC | 02:23 | |
| *** eliqiao has quit IRC | 02:23 | |
| *** therve has joined #openstack-zaqar | 02:23 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 02:26 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 02:30 |
| *** eliqiao_ is now known as eliqiao | 02:37 | |
| *** kgriffs is now known as kgriffs|afk | 02:38 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Fix the TTL issue of subscriptions for Redis https://review.openstack.org/276548 | 02:45 |
| *** achanda has joined #openstack-zaqar | 03:11 | |
| *** ryansb has quit IRC | 03:26 | |
| *** Eva-i has quit IRC | 03:26 | |
| *** Eva-i has joined #openstack-zaqar | 03:27 | |
| *** ryansb has joined #openstack-zaqar | 03:28 | |
| *** ryansb has quit IRC | 03:28 | |
| *** ryansb has joined #openstack-zaqar | 03:28 | |
| *** kgriffs|afk is now known as kgriffs | 03:36 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 03:54 |
| *** flwang1 has quit IRC | 04:07 | |
| *** achanda has quit IRC | 04:28 | |
| *** kgriffs is now known as kgriffs|afk | 04:49 | |
| *** achanda has joined #openstack-zaqar | 05:11 | |
| *** eliqiao_ has joined #openstack-zaqar | 05:13 | |
| *** eliqiao has quit IRC | 05:16 | |
| *** mdnadeem has quit IRC | 06:27 | |
| *** mdnadeem has joined #openstack-zaqar | 06:27 | |
| *** jtomasek has joined #openstack-zaqar | 06:33 | |
| *** eliqiao_ is now known as eliqiao | 06:39 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 06:45 |
| *** mdnadeem has quit IRC | 07:16 | |
| *** mdnadeem has joined #openstack-zaqar | 07:16 | |
| openstackgerrit | wanghao proposed openstack/zaqar-specs: subscription confirmation support https://review.openstack.org/284555 | 07:19 |
| *** achanda has quit IRC | 07:31 | |
| *** boris-42 has quit IRC | 07:34 | |
| *** boris-42 has joined #openstack-zaqar | 07:35 | |
| *** pcaruana has joined #openstack-zaqar | 07:45 | |
| *** achanda has joined #openstack-zaqar | 07:49 | |
| openstackgerrit | wanghao proposed openstack/zaqar-specs: Subscription confirmation support https://review.openstack.org/284555 | 07:55 |
| *** itisha has joined #openstack-zaqar | 07:59 | |
| *** eliqiao has quit IRC | 08:01 | |
| *** eliqiao has joined #openstack-zaqar | 08:07 | |
| *** GB21 has joined #openstack-zaqar | 08:17 | |
| *** achanda has quit IRC | 08:32 | |
| *** eliqiao_ has joined #openstack-zaqar | 08:35 | |
| *** eliqiao has quit IRC | 08:35 | |
| openstackgerrit | wanghao proposed openstack/zaqar-specs: Subscription confirmation support https://review.openstack.org/284555 | 08:38 |
| openstackgerrit | Shu Muto proposed openstack/zaqar-ui: Update use of action registration service https://review.openstack.org/287657 | 08:56 |
| openstackgerrit | Shu Muto proposed openstack/zaqar-ui: Add update queue action https://review.openstack.org/286468 | 09:06 |
| *** eliqiao_ is now known as eliqiao | 09:07 | |
| *** mdnadeem_ has joined #openstack-zaqar | 09:47 | |
| *** mdnadeem has quit IRC | 09:50 | |
| *** openstackgerrit_ has joined #openstack-zaqar | 09:53 | |
| *** openstackgerrit_ has quit IRC | 10:02 | |
| *** boris-42 has quit IRC | 10:04 | |
| *** GB21 has quit IRC | 11:00 | |
| *** shu-mutou is now known as shu-mutou-OFF | 11:01 | |
| *** mdnadeem_ has quit IRC | 11:03 | |
| *** flwang1 has joined #openstack-zaqar | 11:09 | |
| flwang1 | ryansb: any progress about the metadata update client patch? | 11:15 |
| flwang1 | vkmc: ping re code review m-3 | 11:16 |
| flwang1 | flaper87: if you have a moment, this one https://review.openstack.org/270464 needs your bless, thanks | 11:19 |
| *** GB21 has joined #openstack-zaqar | 11:31 | |
| *** mdnadeem has joined #openstack-zaqar | 11:37 | |
| *** kukacz has joined #openstack-zaqar | 11:52 | |
| *** openstackgerrit has quit IRC | 12:03 | |
| *** openstackgerrit has joined #openstack-zaqar | 12:03 | |
| kukacz | hi. I'm operating an multitenant openstack service. one tenant request access to underlying rabbitmq to consume their resource-related notifications, like instance deleted etc. | 12:06 |
| kukacz | naturally we don't want to allow tenant access the infrastructure tasks | 12:07 |
| kukacz | so I wonder - is that a scenario which can be solved with Zaqar ? | 12:07 |
| *** itisha has quit IRC | 12:09 | |
| *** flwang1 has quit IRC | 12:10 | |
| *** flwang1 has joined #openstack-zaqar | 12:11 | |
| flwang1 | vkmc: ryansb: flaper87: Eva-i: when you see this message, pls help review below patches asap, today is the last day of m-3, thanks | 12:12 |
| flwang1 | 1. Subscription TTL mongodb fix https://review.openstack.org/270464 | 12:13 |
| flwang1 | 2. Subscription TTL redis fix https://review.openstack.org/276548 | 12:13 |
| flwang1 | 3. Queue metadata update https://review.openstack.org/280941 | 12:13 |
| flwang1 | 4. More built-in attributes of queue https://review.openstack.org/265723 | 12:14 |
| flwang1 | thanks a lot | 12:15 |
| *** flwang1 has quit IRC | 12:29 | |
| *** GB21 has quit IRC | 12:30 | |
| wanghao | hi guys, BP: Subscription confirmation support has updated, welcome to review. | 13:06 |
| ryansb | wanghao: noted | 13:06 |
| ryansb | and flwang saw your reviews :) | 13:06 |
| wanghao | ryansb: thanks | 13:06 |
| Eva-i | ryansb: wanghao: hello =) | 13:47 |
| wanghao | Eva-i: hi | 13:47 |
| *** GB21 has joined #openstack-zaqar | 13:58 | |
| ryansb | \o | 13:59 |
| Eva-i | ryansb: can we postpone a bit mondodb ttl patch? | 14:08 |
| Eva-i | ryansb: I want to discuss one problem | 14:08 |
| ryansb | sure | 14:08 |
| * ryansb removes +A | 14:09 | |
| Eva-i | ryansb: thanks | 14:09 |
| *** GB21 has quit IRC | 14:11 | |
| *** amitgandhinz has joined #openstack-zaqar | 14:17 | |
| Eva-i | wanghao: ryansb: please see my last comment in this patch https://review.openstack.org/#/c/270464/. What do you think? | 14:19 |
| *** GB21 has joined #openstack-zaqar | 14:21 | |
| *** sriram has joined #openstack-zaqar | 14:41 | |
| wanghao | Eva-i: hi | 14:42 |
| Eva-i | wanghao: hello, thanks for replying to comment | 14:43 |
| wanghao | Eva-i: yeah, I perfer to your option, that looks easily to implement now. | 14:43 |
| Eva-i | ryansb: okay, If you agree with me and wanghao regarding my comment in mongodb subscription ttl patch, let's merge this patch. ;) | 14:44 |
| *** kgriffs|afk is now known as kgriffs | 14:47 | |
| *** GB21 has quit IRC | 14:55 | |
| ryansb | Eva-i: I think a type-check should be possible | 15:04 |
| *** rcernin has joined #openstack-zaqar | 15:04 | |
| Eva-i | ryansb: alright! | 15:05 |
| ryansb | I would rather *not* do a migration | 15:05 |
| Eva-i | yeah | 15:05 |
| ryansb | it does look like the type changes -- great catch on that | 15:06 |
| Eva-i | ryansb: I also noticed that at L115 there's no self.assertEqual https://review.openstack.org/#/c/270464/10/zaqar/tests/unit/transport/wsgi/v2_0/test_validation.py. Maybe I should quickly modify this patch? | 15:08 |
| ryansb | why, does that test fail? | 15:10 |
| ryansb | I'm pretty sure self.assertEqual is a thingg | 15:10 |
| Eva-i | ryansb: the test just doesn't perform a check in the end | 15:10 |
| openstackgerrit | Merged openstack/zaqar: Fix freeze on some requests https://review.openstack.org/284897 | 15:12 |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Fix the TTL issue of subscriptions for MongoDB https://review.openstack.org/270464 | 15:20 |
| *** achanda has joined #openstack-zaqar | 15:33 | |
| *** achanda has quit IRC | 15:39 | |
| openstackgerrit | Merged openstack/zaqar: Fix the TTL issue of subscriptions for Redis https://review.openstack.org/276548 | 15:46 |
| *** mpanetta has joined #openstack-zaqar | 15:49 | |
| vkmc | Eva-i, did you have the chance to discuss this with Fei? https://review.openstack.org/#/c/280941/9 | 16:02 |
| Eva-i | vkmc: still not, I'll try today | 16:04 |
| vkmc | Eva-i, what do you think about adding that change to v1.1? | 16:04 |
| Eva-i | vkmc: I still don't have opinion, I'll reply to you soon | 16:05 |
| vkmc | Eva-i, k k :) | 16:05 |
| *** rcernin has quit IRC | 16:06 | |
| Eva-i | vkmc: okay, I commented in review | 16:30 |
| vkmc | thanks Eva-i | 16:31 |
| *** exploreshaifali has joined #openstack-zaqar | 16:45 | |
| Eva-i | vkmc: ryansb: okay, I'm merging this patch https://review.openstack.org/#/c/265723/ ? | 17:01 |
| vkmc | let me check Eva-i | 17:02 |
| Eva-i | vkmc: please look at my last comment at this patch. =) | 17:02 |
| vkmc | yeah, I'm on that | 17:02 |
| Eva-i | *in | 17:02 |
| *** exploreshaifali has quit IRC | 17:04 | |
| Eva-i | ryansb: I added a check to the test case in patch https://review.openstack.org/#/c/270464/. Would you like to +2 it again? | 17:12 |
| vkmc | Eva-i, re https://review.openstack.org/#/c/265723/ | 17:15 |
| vkmc | we should add a sanitize there | 17:15 |
| vkmc | for metadata | 17:15 |
| vkmc | considering we have to cut M3 now, I'd say we merge this and add a follow up patch with the sanitize for RC1 | 17:15 |
| Eva-i | vkmc: we do sanitize in API v2. Do you mean do sanitize in API v1 and API v1.1? | 17:17 |
| vkmc | yeah | 17:17 |
| Eva-i | vkmc: I'm not sure Fei Long will agree to modiy API v1 and API v1.1 =/ | 17:21 |
| Eva-i | vkmc: oki, merging | 17:21 |
| Eva-i | I feel I can't do anything else now about this patch | 17:22 |
| openstackgerrit | Merged openstack/zaqar: Fix the TTL issue of subscriptions for MongoDB https://review.openstack.org/270464 | 17:42 |
| *** exploreshaifali has joined #openstack-zaqar | 18:19 | |
| *** kgriffs is now known as kgriffs|afk | 18:39 | |
| *** rcernin has joined #openstack-zaqar | 18:44 | |
| *** flwang1 has joined #openstack-zaqar | 19:06 | |
| *** flwang1 has quit IRC | 19:09 | |
| *** amitgandhinz has quit IRC | 19:16 | |
| openstackgerrit | Ryan Brown proposed openstack/python-zaqarclient: Support PATCH of queue metadata https://review.openstack.org/288073 | 19:20 |
| *** mpanetta has quit IRC | 19:40 | |
| *** amitgandhinz has joined #openstack-zaqar | 19:46 | |
| *** exploreshaifali has quit IRC | 19:48 | |
| *** boris-42 has joined #openstack-zaqar | 19:54 | |
| *** amitgandhinz has quit IRC | 20:02 | |
| openstackgerrit | Merged openstack/zaqar: Add `_max_messages_post_size` and `_default_message_ttl` for queue https://review.openstack.org/265723 | 20:03 |
| *** kgriffs|afk is now known as kgriffs | 20:06 | |
| *** amitgandhinz has joined #openstack-zaqar | 20:17 | |
| flwang | morning guys | 20:52 |
| *** dhellmann has joined #openstack-zaqar | 20:52 | |
| flwang | thanks for the hard work and nice review ;) | 20:53 |
| Eva-i | flwang: good morning | 20:53 |
| Eva-i | flwang: one patch left | 20:53 |
| dhellmann | flwang : can you drop by #openstack-release to talk about the milestone when you have a minute? | 20:53 |
| flwang | dhellmann: sure | 20:54 |
| ryansb | morning, flwang | 20:54 |
| *** itisha has joined #openstack-zaqar | 20:55 | |
| flwang | ryansb: we need to merge the metadata update soon | 20:56 |
| flwang | flaper87: are you around for discussing the metadata update? | 20:56 |
| flwang | flaper87: please!!! need your comment here | 20:57 |
| ryansb | Yeah, I am | 20:58 |
| ryansb | oh, you were asking if flaper was around, not me | 20:58 |
| ryansb | anyways, I don't like that a PATCH replaces the whole metadata object | 20:59 |
| *** kgriffs is now known as kgriffs|afk | 20:59 | |
| ryansb | It should update the dict (as I mentioned in the review) | 20:59 |
| flwang | ryansb: looking | 20:59 |
| vkmc | flwang, what are the patch sets we have pending and we want to get merged? | 21:00 |
| vkmc | priorities that is | 21:00 |
| flwang | vkmc: only the queue metadata update | 21:00 |
| Eva-i | vkmc: https://review.openstack.org/280941 | 21:00 |
| flwang | we have client and sever patch | 21:00 |
| vkmc | +1 | 21:00 |
| flwang | and it's blocking the release | 21:01 |
| Eva-i | ryansb: I don't mind updating dict partially. If you think we must do it, let's do it. | 21:01 |
| flwang | vkmc: firstly, we need to make sure if we want to update v1.1 | 21:02 |
| flwang | ryansb: i saw your patch, and i think it makes sense for me | 21:02 |
| vkmc | flwang, ok... the only problem I see with updating v1.1 is that we consider it stable already and adding this feature changes the api | 21:02 |
| vkmc | but... on the other hand, it's an addition, it doesn't change anything about the behavior it has now | 21:03 |
| *** flwang1 has joined #openstack-zaqar | 21:03 | |
| Eva-i | all our APIs are stable =) | 21:03 |
| vkmc | Eva-i, heh, you think so? | 21:03 |
| flwang | vkmc: i don't mind remove the v1.1 change | 21:04 |
| vkmc | flwang, it's ok for me, either of the changes | 21:04 |
| flwang | and in Newton, i'm going to make the default version of openstack client with v2 | 21:04 |
| vkmc | let's do a quick voting | 21:04 |
| Eva-i | vkmc: I'm not... | 21:04 |
| flwang | ryansb: i think the server side change make impact your client patch if we remove the support for v1.1 | 21:05 |
| vkmc | #poll remove keep patch for queues metadata in v1.1 | 21:05 |
| vkmc | bu | 21:05 |
| Eva-i | vkmc:we can implement a change in API v1.1, but if the user downgrade zaqar and expect the API v1.1 act the same, there will be surprise for him | 21:05 |
| ryansb | flwang: Yeah, but it'd be an easy fix | 21:05 |
| ryansb | I think make it v2 only | 21:05 |
| flwang | Eva-i: they won't be surprise | 21:05 |
| flwang | like we said many times, it's an addition | 21:06 |
| flwang | but anyway | 21:06 |
| Eva-i | flwang: okay, I trust you | 21:06 |
| Eva-i | keep | 21:06 |
| vkmc | keep | 21:06 |
| flwang | keep the v1.1 change? | 21:06 |
| Eva-i | yeah | 21:06 |
| flwang | i vote for keep | 21:06 |
| vkmc | yup | 21:07 |
| flwang | ryansb: ? | 21:07 |
| ryansb | flwang: I vote v2-only | 21:07 |
| flwang | ryansb: i remembered last time when i discussed this with you, you said you don't mind keep it :D | 21:08 |
| vkmc | therve, can you add to this? ^ | 21:08 |
| ryansb | I don't mind keeping it, but you asked what I *wanted* | 21:08 |
| ryansb | I want v2 only, but I won't stop a v1.1-also patch | 21:09 |
| * ryansb is not a dictator | 21:09 | |
| flwang | therve: flaper87: ^ | 21:11 |
| ryansb | flwang: therve probably isn't awake | 21:11 |
| flwang | personally, i feel shame to have a really big function gap in v1.1 | 21:11 |
| flwang | that's why i want to fill it | 21:11 |
| vkmc | yeah me too | 21:11 |
| * Eva-i started to make patch for this: https://bugs.launchpad.net/zaqar/+bug/1552845 | 21:15 | |
| openstack | Launchpad bug 1552845 in zaqar "Subscriptions don't show their "age"" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 21:15 |
| ryansb | flwang: therve probably isn't awake | 21:16 |
| flwang | so how about let's remove it for M-3 | 21:16 |
| flwang | and after some discussion we can get it in RC1? | 21:16 |
| ryansb | that'd be a fair FFE | 21:17 |
| ryansb | +1 | 21:17 |
| flwang | but basically, we may need a new client release | 21:17 |
| ryansb | that's ok, IMO | 21:17 |
| flwang | vkmc: does that sound a plan? | 21:18 |
| Eva-i | we're allowed to fix things after milestone? | 21:18 |
| Eva-i | right? | 21:18 |
| ryansb | yeah | 21:18 |
| flwang | Eva-i: there is release candidate | 21:19 |
| vkmc | +1 | 21:22 |
| vkmc | yes | 21:22 |
| vkmc | gotta go | 21:22 |
| flwang | ryansb: cool, then can you update your client patch | 21:27 |
| flwang | ryansb: i have fix your comments and going to submit a new patch set for server change | 21:28 |
| ryansb | uh, I made my client patch assuming v1.1 and v2, so it should be fine | 21:28 |
| Eva-i | ryansb: should I review the client patch now? | 21:34 |
| ryansb | you can. I'm adding some tests atm but you can take a look | 21:35 |
| flwang | ryansb: left a comment | 21:35 |
| *** ametts has joined #openstack-zaqar | 21:38 | |
| ryansb | thank you | 21:41 |
| *** rcernin has quit IRC | 21:45 | |
| flwang | ryansb: so do you mean when user want to clear all metadata, your change will call PUT /v2/queues/myqueue ? | 21:48 |
| ryansb | yes | 21:48 |
| flwang | ryansb: but unfortunately, it won't work :( | 21:48 |
| flwang | since https://review.openstack.org/#/c/280941/1 | 21:48 |
| flwang | that's the first patch i proposed | 21:49 |
| flwang | now | 21:49 |
| flwang | when zaqar found the queue has been existing, zaqar will just return 204 and won't update the metadata | 21:49 |
| ryansb | dang.. hm. | 21:49 |
| ryansb | so how should a user clear the metadata? | 21:50 |
| flwang | maybe i should get that change back? | 21:51 |
| flwang | user can clear metadata before i addressed your latest comment ;) | 21:51 |
| Eva-i | flwang: that's possible solution | 21:51 |
| flwang | but after respect the PATCH | 21:51 |
| flwang | now they can't | 21:51 |
| Eva-i | lol | 21:51 |
| ryansb | hm, dangit. Shot myself in the foot there didn't I | 21:52 |
| flwang | but i prefer to fix it in RC1, any object? | 21:52 |
| *** sriram has quit IRC | 21:53 | |
| flwang | given your client patch is there, so we don't need another client release | 21:53 |
| ryansb | ok by me | 21:53 |
| flwang | we just need to fix it in RC1 on server side | 21:53 |
| flwang | now it's to rush to fix it | 21:53 |
| Eva-i | flwang: if it will work, no objections | 21:54 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support metadata update issue for v1.1 and v2 https://review.openstack.org/280941 | 21:54 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support metadata update issue for v1.1 and v2 https://review.openstack.org/280941 | 21:55 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support metadata update issue for v2 https://review.openstack.org/280941 | 21:57 |
| Eva-i | flwang: I thought we decided to keep in API v1.1 update metadata :o | 21:58 |
| ryansb | Eva-i: we did, but we also found an implementation detail about clearing metadata we have to fix | 21:58 |
| flwang | Eva-i: we decided to add it later in RC1 after some discussion | 21:58 |
| ryansb | different reason for delay | 21:58 |
| flwang | which won't impact ryansb's client change | 21:59 |
| Eva-i | flwang: oki | 21:59 |
| flwang | so our tech debt for rc1 now is 1. v1.1's queue metadata update 2. queue PUT should update metadata | 22:01 |
| flwang | ryansb: Eva-i: vkmc: pls revisit https://review.openstack.org/280941 thanks | 22:02 |
| flwang | after it merged, i will release M-3 | 22:02 |
| Eva-i | flwang: yes | 22:02 |
| ryansb | actually that code doesn't work, dict.update is an in-place operation | 22:09 |
| ryansb | k, I've gotta run, but I'll be back on in a couple hours to take another pass at that review | 22:10 |
| *** shu-mutou-OFF has quit IRC | 22:10 | |
| Eva-i | flwang: I review slow. Until everything is checked I usually don't hit "reply" button. But today I'll post small portions of review, so you can already start fixing problems. | 22:17 |
| *** jtomasek has quit IRC | 22:19 | |
| flwang | Eva-i: ok | 22:21 |
| *** amitgandhinz has quit IRC | 22:25 | |
| Eva-i | flwang: zaqar/transport/wsgi/v1_0/metadata.py#on_put here's nice example of what exceptions should be catched and how to log them | 22:30 |
| Eva-i | flwang: though I don't much like catching Exception | 22:30 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support metadata update issue for v2 https://review.openstack.org/280941 | 22:36 |
| flwang | Eva-i: see the new patchset | 22:39 |
| Eva-i | flwang: yes | 22:40 |
| flwang | Eva-i: ryansb: pls review the new patchset, release team is pushing us | 22:48 |
| *** kgriffs|afk is now known as kgriffs | 22:50 | |
| flwang | Eva-i: ryansb: vkmc: flaper87: pls help review https://review.openstack.org/280941 thanks | 22:51 |
| Eva-i | flwang: ryansb runned away, it's you and me =) | 22:52 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support metadata update issue for v2 https://review.openstack.org/280941 | 22:52 |
| flwang | Eva-i: :( | 22:53 |
| Eva-i | flwang: I feel myself important in this kind of situation =) | 22:54 |
| flwang | Eva-i: haha, you're always important | 22:54 |
| flwang | i really need another +2 | 22:54 |
| flwang | i'm going to have lunch and will be back in 1 hour | 22:57 |
| Eva-i | flwang: oki, I'll be there | 22:57 |
| Eva-i | *here | 22:57 |
| flwang | if i can't get another +2 in next 2-3 hours, i maybe nijia approve it | 22:58 |
| flwang | Eva-i: pls review ryansb's client patch, thanks | 22:58 |
| Eva-i | flwang: yes | 22:58 |
| flwang | Eva-i: and feel free upload new patchset and add yourself as co-author, we need to get that done asap | 22:58 |
| *** ametts has quit IRC | 23:00 | |
| *** GB21 has joined #openstack-zaqar | 23:09 | |
| *** itisha has quit IRC | 23:39 | |
| ryansb | Eva-i: I'm still about | 23:51 |
| ryansb | +A'd | 23:52 |
| Eva-i | ryansb: hello | 23:55 |
| ryansb | \o | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!