Eva-i | ryansb: thank you for reviewing server patch | 00:03 |
---|---|---|
Eva-i | ryansb: I left some comments for the client patch: https://review.openstack.org/#/c/288073 | 00:04 |
ryansb | cool, thanks | 00:06 |
openstackgerrit | Merged openstack/zaqar: Support metadata update issue for v2 https://review.openstack.org/280941 | 00:06 |
ryansb | \o/ merged | 00:08 |
Eva-i | yay | 00:10 |
flwang | yeah! thank you guys | 00:12 |
Eva-i | https://review.openstack.org/#/c/288073 is still not merged | 00:14 |
Eva-i | flwang: maybe you will answer the question in this patch? | 00:15 |
Eva-i | flwang: at L102 | 00:15 |
flwang | Eva-i: for now, user can't clear all the metadata | 00:16 |
flwang | i'm think that's a good reason why we keep the put for update against pool and flavor | 00:17 |
Eva-i | flwang: we are going to modify queue put method in zaqar server? | 00:17 |
flwang | Eva-i: yep, i will propose a patch soon which will be merged in RC1 | 00:17 |
Eva-i | flwang: oki | 00:17 |
ryansb | yeah, that'll be a feature freeze exception | 00:18 |
Eva-i | flwang: if we have a bit time, can we add a check for new_meta's type? | 00:19 |
ryansb | Eva-i: I'm going to revise the client patch a bit | 00:19 |
ryansb | also adding tests | 00:19 |
Eva-i | ryansb: that's nice. But tests might be not full or fail, because we still haven't modified zaqar's queue put method. | 00:20 |
ryansb | The ones that aren't implemented will be unit-level | 00:21 |
ryansb | not functional | 00:21 |
Eva-i | ryansb: oh, good idea | 00:21 |
ryansb | I'm personally big on unit-level tests for the client since it's way faster to get feedback while dev'ing locally | 00:22 |
Eva-i | ryansb: indeed =) | 00:24 |
flwang | Eva-i: we do have a bit of time, but we need to be quick | 00:24 |
Eva-i | flwang: oki, let's wait for Ryan's unit tests. I'll be happy also without adding check. | 00:27 |
flwang | ryansb: ^ | 00:28 |
ryansb | yeah, also can't we just cut a client release later before RC1? | 00:28 |
flwang | ryansb: seems no, we can release another version | 00:30 |
flwang | but we need to release client today | 00:30 |
ryansb | Ah, well why not just cut one today, then we can do another one later? | 00:30 |
ryansb | IMO the client shouldn't be locked to a release that way, but oh well | 00:31 |
flwang | ryansb: so how about we get the patch in asap and fix any critical bug and release another version | 00:32 |
flwang | given we have waited it a while | 00:32 |
ryansb | sure, it's mergeable now | 00:33 |
ryansb | I can follow-on with more validation & tests no problem | 00:33 |
flwang | Eva-i: ^ | 00:33 |
Eva-i | ryansb: flwang: that means no unit tests for this patch today? Okay, I'll merge | 00:34 |
Eva-i | ryansb: would you like to read my internship blog? =) | 00:38 |
flwang | Eva-i: ryansb: thanks | 00:42 |
flwang | I'm going to release zaqar client after it merged | 00:42 |
Eva-i | flwang: the patch is under tests now, hope I understand you correctly guys | 00:42 |
Eva-i | flwang: oki | 00:42 |
ryansb | Eva-i: yeah sure | 00:49 |
ryansb | Love me some blog posts :) | 00:49 |
* Eva-i sending link in PM | 00:50 | |
openstackgerrit | Merged openstack/python-zaqarclient: Support PATCH of queue metadata https://review.openstack.org/288073 | 01:02 |
flwang | Eva-i: the core member thing should be mentioned in your blog :) | 01:12 |
*** achanda has joined #openstack-zaqar | 01:14 | |
Eva-i | flwang: yes, definitely, in the next post =) | 01:17 |
*** kgriffs is now known as kgriffs|afk | 01:35 | |
*** GB21 has quit IRC | 02:04 | |
*** kgriffs|afk is now known as kgriffs | 02:11 | |
*** shu-mutou has joined #openstack-zaqar | 02:52 | |
openstackgerrit | wangxiyuan proposed openstack/zaqar: Fix the subscription update error in redis backend. https://review.openstack.org/279946 | 03:11 |
openstackgerrit | wanghao proposed openstack/zaqar: Show default attributes for queue https://review.openstack.org/286433 | 03:12 |
*** GB21 has joined #openstack-zaqar | 03:13 | |
openstackgerrit | wangxiyuan proposed openstack/zaqar: Fix the subscription update error in redis backend. https://review.openstack.org/279946 | 03:13 |
*** GB21 has quit IRC | 03:18 | |
*** kgriffs is now known as kgriffs|afk | 03:46 | |
openstackgerrit | wanghao proposed openstack/zaqar: Show default attributes for queue https://review.openstack.org/286433 | 03:48 |
openstackgerrit | wangxiyuan proposed openstack/zaqar: Fix the subscription update error in redis backend. https://review.openstack.org/279946 | 03:57 |
*** flwang1 has quit IRC | 03:58 | |
*** david_cu has quit IRC | 04:27 | |
*** openstack has joined #openstack-zaqar | 04:28 | |
*** openstack has quit IRC | 04:30 | |
*** openstack has joined #openstack-zaqar | 04:31 | |
*** openstack has quit IRC | 04:34 | |
*** openstack has joined #openstack-zaqar | 04:35 | |
*** openstack has quit IRC | 04:36 | |
*** openstack has joined #openstack-zaqar | 04:37 | |
*** openstack has quit IRC | 04:39 | |
*** openstack has joined #openstack-zaqar | 14:06 | |
*** amitgandhinz has joined #openstack-zaqar | 14:07 | |
*** khushbu has quit IRC | 14:28 | |
*** openstackgerrit_ has quit IRC | 14:36 | |
*** openstackgerrit_ has joined #openstack-zaqar | 14:37 | |
*** ametts has joined #openstack-zaqar | 14:43 | |
*** sriram has joined #openstack-zaqar | 15:15 | |
*** amitgandhinz has quit IRC | 15:16 | |
*** kgriffs|afk is now known as kgriffs | 15:22 | |
*** AAzza has quit IRC | 15:34 | |
*** david_lyle__ has joined #openstack-zaqar | 15:34 | |
*** AAzza has joined #openstack-zaqar | 15:36 | |
*** scallops_ has joined #openstack-zaqar | 15:36 | |
*** david-lyle has quit IRC | 15:37 | |
*** amitgandhinz has joined #openstack-zaqar | 16:02 | |
*** khushbu_ has joined #openstack-zaqar | 16:10 | |
*** david_lyle__ is now known as david_lyle | 16:17 | |
*** achanda has joined #openstack-zaqar | 16:19 | |
*** achanda has quit IRC | 16:20 | |
*** AAzza has quit IRC | 16:29 | |
*** rcernin has quit IRC | 16:51 | |
*** AAzza has joined #openstack-zaqar | 17:01 | |
*** AAzza has quit IRC | 17:05 | |
*** AAzza has joined #openstack-zaqar | 17:09 | |
*** AAzza has quit IRC | 17:13 | |
*** AAzza has joined #openstack-zaqar | 17:17 | |
*** AAzza has quit IRC | 17:22 | |
*** scallops_ has quit IRC | 17:24 | |
*** AAzza has joined #openstack-zaqar | 17:25 | |
*** fribeiro has joined #openstack-zaqar | 17:35 | |
*** wxy has quit IRC | 17:59 | |
*** khushbu_ has quit IRC | 18:14 | |
*** itisha has joined #openstack-zaqar | 18:15 | |
*** khushbu_ has joined #openstack-zaqar | 18:18 | |
*** shakamunyi has joined #openstack-zaqar | 18:29 | |
*** akanksha_ has quit IRC | 18:37 | |
*** pcaruana has quit IRC | 18:41 | |
*** achanda has joined #openstack-zaqar | 18:44 | |
*** sriram has quit IRC | 19:48 | |
Eva-i | Hello, dear Zaqarians | 19:50 |
*** tqtran has joined #openstack-zaqar | 19:54 | |
*** AAzza has quit IRC | 19:59 | |
*** AAzza has joined #openstack-zaqar | 19:59 | |
*** AAzza has quit IRC | 20:21 | |
*** AAzza has joined #openstack-zaqar | 20:22 | |
*** AAzza has quit IRC | 20:27 | |
*** AAzza has joined #openstack-zaqar | 20:30 | |
*** khushbu_ has quit IRC | 20:31 | |
*** jtomasek has quit IRC | 20:33 | |
*** fribeiro has quit IRC | 20:47 | |
*** fribeiro has joined #openstack-zaqar | 21:17 | |
openstackgerrit | David Cusatis proposed openstack/zaqar-ui: Add Subscriptions to Queue drawer https://review.openstack.org/284921 | 21:31 |
*** pcaruana has joined #openstack-zaqar | 21:58 | |
*** amitgandhinz has quit IRC | 22:39 | |
*** kgriffs is now known as kgriffs|afk | 22:41 | |
*** kgriffs|afk is now known as kgriffs | 22:42 | |
*** fribeiro has quit IRC | 22:43 | |
*** ametts has quit IRC | 23:08 | |
*** kgriffs is now known as kgriffs|afk | 23:47 | |
*** kgriffs|afk is now known as kgriffs | 23:47 | |
*** itisha has quit IRC | 23:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!