| wanghao | Eva-i: ping | 01:23 |
|---|---|---|
| Eva-i | wanghao: pong | 01:23 |
| wanghao | Eva-i: send you a pm :) | 01:24 |
| *** mpanetta has quit IRC | 01:26 | |
| wanghao | flwang: Fei Long, I plan to commit the first patch about the subscription confirmation, I think we have enough discussion about the email way. | 01:30 |
| wanghao | flwang: what you think? | 01:30 |
| flwang | wanghao: i think wxy has already submit patches | 01:34 |
| wanghao | flwang: wow, okay, I'll talked with him to allocate the work. | 01:37 |
| flwang | wanghao: https://review.openstack.org/#/c/316601/ | 01:38 |
| wanghao | flwang: yeah, got it. | 01:39 |
| Eva-i | flwang: have you fixed this bug: https://bugs.launchpad.net/zaqar/+bug/1553834 by this patch: https://review.openstack.org/#/c/317134/ ? :o | 01:41 |
| openstack | Eva-i: Error: malone bug 1553834 not found | 01:41 |
| flwang | Eva-i: i think so, can you help verify? | 01:46 |
| flwang | btw, you found it on mitaka, right? | 01:46 |
| Eva-i | flwang: yes | 01:46 |
| Eva-i | flwang: okay, I'll try to veryfy it tomorrow. | 01:47 |
| flwang | Eva-i: awesome, thanks | 01:48 |
| wanghao | flwang, Eva-i: FYI, I saw the test is fail when running "tox -e py34 TestMessagesMongoDBPooled" since copy.copy(conf) in M. | 01:50 |
| wanghao | flwang, Eva-i: But I can't reproduce it by 'curl' way... | 01:52 |
| openstackgerrit | wanghao proposed openstack/zaqar-specs: Subscription confirmation support https://review.openstack.org/284555 | 02:09 |
| wanghao | flwang, wxy: Spec of subscription confirmation has been updated, plz have a look. | 02:11 |
| flwang | wanghao: cool, will take a look later | 02:14 |
| wanghao | flwang: thanks | 02:21 |
| *** mdnadeem_ has quit IRC | 02:27 | |
| openstackgerrit | Merged openstack/zaqar: Replace tempest-lib with tempest.lib https://review.openstack.org/299727 | 02:27 |
| *** kgriffs has quit IRC | 02:30 | |
| Kevin_Zheng | that one finally got merged | 02:30 |
| *** kgriffs has joined #openstack-zaqar | 02:32 | |
| *** openstackgerrit has quit IRC | 02:36 | |
| *** openstackgerrit has joined #openstack-zaqar | 02:42 | |
| *** openstackgerrit has quit IRC | 02:56 | |
| -openstackstatus- NOTICE: Gerrit is going offline briefly to check possible filesystem corruption | 03:03 | |
| *** ChanServ changes topic to "Gerrit is going offline briefly to check possible filesystem corruption" | 03:03 | |
| *** openstackgerrit has joined #openstack-zaqar | 03:18 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: (test)Support Tempest test as gate job https://review.openstack.org/320737 | 03:20 |
| *** ChanServ changes topic to "OpenStack Queuing and Notification Service || Smile :D || Meetings every Monday @ 21:00 UTC/15:00 UTC || Wiki: https://wiki.openstack.org/wiki/Zaqar || Paste: http://paste.openstack.org/ || Send messages and make some noise :D" | 03:22 | |
| -openstackstatus- NOTICE: after a quick check, gerrit and its filesystem have been brought back online and should be working again | 03:22 | |
| flwang | wanghao: wxy: ping | 03:37 |
| wxy | flwang: here | 03:38 |
| wanghao | flwang: pong | 03:38 |
| flwang | i have a question about the rest api impact #2 https://review.openstack.org/#/c/284555/14/specs/newton/subscription-confirmation-support.rst | 03:38 |
| flwang | i'm trying to figure out why do we have to add the /send_confirm | 03:38 |
| flwang | so based on my understanding, /confirm is used to send by user to confirm the subscription | 03:40 |
| wxy | yes | 03:40 |
| wanghao | flwang: send_confirm is for user who creat the subscription. | 03:41 |
| flwang | to send the confirmation request to the subscriber again? | 03:41 |
| wanghao | flwang: yes, for retrying | 03:42 |
| flwang | if so, why don't just get rid of it | 03:42 |
| flwang | oh, wait, let me think | 03:42 |
| wanghao | flwang: even using email, subscriber may miss this email, so user can send the confirmation again after a time waiting. | 03:43 |
| flwang | so based on my understanding, this api is mostly called by the dashboard, right? | 03:43 |
| flwang | with a button or hyperlink? | 03:43 |
| wanghao | flwang: yes, | 03:43 |
| flwang | so can we do something like this? | 03:44 |
| wxy | flwang: I suppose so. | 03:44 |
| flwang | just try to post the subscription info again | 03:44 |
| flwang | if we found the subsriber has been existing and the confirm status is NO, then send the confirm request again? | 03:45 |
| wxy | thinking | 03:45 |
| wanghao | flwang: right, just post the request again, same context, maybe just sending time is changed. | 03:45 |
| flwang | TBH, this endpoint is a little bit weird for me, though it makes sense | 03:45 |
| flwang | wanghao: we can check it before saving it to DB | 03:45 |
| flwang | and we are doing it right now | 03:46 |
| flwang | to avoid duplicate subscriber | 03:46 |
| flwang | if we found it's confirmed, then do nothing | 03:46 |
| wanghao | flwang: yes | 03:46 |
| flwang | btw, does SNS has a similar api like that? | 03:47 |
| wxy | if we found it's confirmed, we should raise duplicate error. | 03:47 |
| wanghao | SNS have a button named 'request confirmations' | 03:47 |
| wanghao | That will send confirmation again for unconfirmed subscription. | 03:48 |
| flwang | wxy: it's ok for me :) | 03:48 |
| flwang | wanghao: can you see the js code? | 03:48 |
| wxy | wanghao: Is it a new endpoint? | 03:49 |
| flwang | wxy: anyway, we can avoid that api | 03:49 |
| wxy | sounds ok, I need time to think more. | 03:53 |
| flwang | wxy: cool | 03:55 |
| wanghao | flwang: I check the js code, feel not a new endpoint | 03:58 |
| flwang | wanghao: can you paste the code? | 03:59 |
| wanghao | flwang: okay. wait mintues | 03:59 |
| wanghao | flwang, wxy: See this paste: paste.openstack.org/show/505805/ | 04:12 |
| flwang | wanghao: seems i'm correct :) | 04:14 |
| wanghao | flwang, wxy: there're the js requests to SNS, they're same between subscribe first and request again. | 04:14 |
| wanghao | flwang: Yes, we didn't need a new endpoint | 04:14 |
| wanghao | flwang: we need this function, but no new endpoint. | 04:15 |
| wanghao | flwang: if user create a same subscription, zaqar will check it and if it's unconfirmed yet, will send the confirmation request again. | 04:16 |
| flwang | wanghao: exactly | 04:22 |
| flwang | wanghao: so can you update the spec? | 04:22 |
| flwang | after that, i think it's good to go | 04:22 |
| wanghao | flwang: no problem | 04:22 |
| flwang | wanghao: and again, we should be very careful about this api design | 04:22 |
| flwang | since it will be hard to change | 04:22 |
| flwang | wxy must know some story of glance :) | 04:23 |
| wanghao | flwang: emm agree with you, we should discuss it more carefully. | 04:23 |
| wanghao | flwang, wxy: hahaha, yes... | 04:23 |
| flwang | all the details can be improved later | 04:23 |
| flwang | wanghao: besides, it would be nice if you can compate the api between sns and our new api | 04:24 |
| flwang | about this feature | 04:24 |
| flwang | s/compate/compare | 04:24 |
| flwang | and add it in the spec | 04:24 |
| flwang | it would be nice for all the reviewers | 04:24 |
| wanghao | flwang: sure, I will add a section for this. | 04:25 |
| flwang | wanghao: awesome, that would be cool | 04:28 |
| wanghao | flwang: :) | 04:30 |
| *** adu has joined #openstack-zaqar | 04:37 | |
| *** flwang1 has quit IRC | 04:56 | |
| *** mdnadeem has joined #openstack-zaqar | 05:02 | |
| *** shu-mutou-AFK is now known as shu-mutou | 05:02 | |
| *** adu has quit IRC | 05:20 | |
| *** rcernin has joined #openstack-zaqar | 06:04 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: (test)Support Tempest test as gate job https://review.openstack.org/320737 | 06:10 |
| *** rcernin has quit IRC | 06:15 | |
| *** rcernin has joined #openstack-zaqar | 06:20 | |
| -openstackstatus- NOTICE: zuul required a restart due to network outages. If your change is not listed on http://status.openstack.org/zuul/ and is missing results, please issue a 'recheck'. | 07:14 | |
| *** tesseract has joined #openstack-zaqar | 07:36 | |
| *** flwang1 has joined #openstack-zaqar | 09:01 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: (test)Support Tempest test as gate job https://review.openstack.org/320737 | 09:16 |
| *** openstackgerrit has quit IRC | 10:47 | |
| *** openstackgerrit has joined #openstack-zaqar | 10:48 | |
| *** shu-mutou is now known as shu-mutou-AFK | 11:07 | |
| *** openstackgerrit has quit IRC | 11:47 | |
| *** openstackgerrit has joined #openstack-zaqar | 11:48 | |
| *** exploreshaifali has joined #openstack-zaqar | 12:13 | |
| *** openstackgerrit has quit IRC | 12:48 | |
| *** openstackgerrit has joined #openstack-zaqar | 12:48 | |
| *** Eva-i has quit IRC | 13:41 | |
| *** exploreshaifali has quit IRC | 13:42 | |
| *** itisha has joined #openstack-zaqar | 13:56 | |
| *** Ravikiran_K has joined #openstack-zaqar | 14:09 | |
| *** openstackgerrit has quit IRC | 14:18 | |
| *** openstackgerrit has joined #openstack-zaqar | 14:18 | |
| *** wxy has quit IRC | 14:30 | |
| *** pt_15 has joined #openstack-zaqar | 14:36 | |
| *** tesseract has quit IRC | 15:11 | |
| *** rcernin has quit IRC | 15:24 | |
| *** pt_15 has quit IRC | 16:46 | |
| *** tqtran has joined #openstack-zaqar | 17:27 | |
| *** Eva-i has joined #openstack-zaqar | 18:44 | |
| *** openstack has joined #openstack-zaqar | 21:42 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Init commit to add API ref in tree https://review.openstack.org/321344 | 21:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!