opendevreview | Merged openstack/puppet-ceilometer master: Add support for oslo.reports options https://review.opendev.org/c/openstack/puppet-ceilometer/+/907077 | 01:25 |
---|---|---|
zigo | tkajinam: Our approach is from the Swift doc's: https://docs.openstack.org/swift/latest/admin_guide.html#preventing-disk-full-scenarios | 08:59 |
tkajinam | are they serious ??? | 09:01 |
tkajinam | :-( | 09:01 |
tkajinam | I'd prefer adding that script to swift itself and use that script | 09:01 |
tkajinam | instead of maintaining that script by ourselves | 09:01 |
tkajinam | if they recommend that approach then it'd make much more sense that swift itself vendors that script, instead of asking people to implementing it | 09:02 |
zigo | I can try to add such a merge request in swift, yes, but that will be double backporting work for me if I want to have this in production. | 09:02 |
zigo | I thought it was a way more easy to have it directly in the puppet module ... | 09:02 |
tkajinam | but that mess up our future maintenance | 09:03 |
zigo | BTW, the approach to have /etc/rsync.d/disable_%s.conf doesn't work, because if you have "max connections" in the main rsyncd.conf already, the /etc/rcync.d folder doesn't overrides it. | 09:03 |
zigo | Right, I'll try what you say then. | 09:04 |
tkajinam | some of the hard-coded options such as DEVICES should be configurable so having a more generic tool sounds better to me | 09:04 |
tkajinam | hm | 09:04 |
zigo | That old code is even python2 ... | 09:05 |
zigo | (see the shebang) | 09:05 |
zigo | We already have something better. | 09:06 |
tkajinam | swift still supports python 2 so they may not accept python 3 shebangs | 09:06 |
zigo | I don't think that's the case anymore, but ok. | 09:06 |
tkajinam | and ask you to replace it during packaging, as is done in several distros, like RDO | 09:06 |
tkajinam | at least python 2.7 was still listed in setup.cfg when I checked it a few days ago | 09:06 |
zigo | What we did is having a script that reads all from /srv/node, and it has a number of GiB as parameter to do the work. | 09:06 |
zigo | I don't think the script is in Swift at all, but only in the docs. Let me check for that fact. | 09:07 |
zigo | Yeah, I'm correct. | 09:07 |
tkajinam | > BTW, the approach to have /etc/rsync.d/disable_%s.conf doesn't work, | 09:10 |
tkajinam | I wonder if this is true. Can it be because of missing include option in rsyncd.conf ? | 09:11 |
zigo | It's just that you can only set options once... | 09:11 |
tkajinam | hm, ok | 09:13 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration master: Capture rsync config file https://review.opendev.org/c/openstack/puppet-openstack-integration/+/907395 | 09:16 |
opendevreview | Takashi Kajinami proposed openstack/puppet-tempest master: Add support for min/max micro version options https://review.opendev.org/c/openstack/puppet-tempest/+/907399 | 09:43 |
opendevreview | Takashi Kajinami proposed openstack/puppet-ceph master: Fix broken links https://review.opendev.org/c/openstack/puppet-ceph/+/907462 | 17:10 |
*** tosky_ is now known as tosky | 23:14 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!