| opendevreview | Tobias Urdin proposed openstack/puppet-openstack_extras master: Dont crash when rexml is not installed https://review.opendev.org/c/openstack/puppet-openstack_extras/+/907518 | 07:51 |
|---|---|---|
| tobias-urdin | tkajinam: ^ started unpinning and cleaning up stuff internally and puppet autoloads this provider so even though we don't use it we would need that gem installed | 07:51 |
| tobias-urdin | that code is 10 years old at this point :D | 07:51 |
| tobias-urdin | if we get puppet-pacemaker removed we should probably nuke that code as well | 07:52 |
| tkajinam | tobias-urdin, puppet-pacemaker is being removed. it's part of TripleO and is subject for complete retirement soon | 12:14 |
| tkajinam | tobias-urdin, however that is the code used by openstack_extras::pacemaker::service, which we deprecated during the previous cycle. because of SLURP we are supposed to remove it AFTER 2024.1 . | 12:15 |
| tkajinam | I'm fine with the proposed change. we may be able to add some validation to fail properly in case the library is absent but that code is actually used. However the code has been broken (because it's not compatible with underlying puppet-corosync) so I don't think it's worth paying effort for | 12:16 |
| tobias-urdin | tkajinam: ack sounds good, if it's ok for you i would like to just backport that fix for all stable branches | 13:04 |
| opendevreview | Tobias Urdin proposed openstack/puppet-openstack_extras stable/2023.2: Dont crash when rexml is not installed https://review.opendev.org/c/openstack/puppet-openstack_extras/+/907545 | 13:32 |
| opendevreview | Tobias Urdin proposed openstack/puppet-openstack_extras stable/2023.1: Dont crash when rexml is not installed https://review.opendev.org/c/openstack/puppet-openstack_extras/+/907546 | 13:32 |
| opendevreview | Tobias Urdin proposed openstack/puppet-openstack_extras stable/zed: Dont crash when rexml is not installed https://review.opendev.org/c/openstack/puppet-openstack_extras/+/907547 | 13:33 |
| opendevreview | Tobias Urdin proposed openstack/puppet-openstack_extras stable/yoga: Dont crash when rexml is not installed https://review.opendev.org/c/openstack/puppet-openstack_extras/+/907548 | 13:33 |
| tkajinam | tobias-urdin, sounds good to me | 13:35 |
| opendevreview | Merged openstack/puppet-openstack_extras master: Dont crash when rexml is not installed https://review.opendev.org/c/openstack/puppet-openstack_extras/+/907518 | 17:09 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!