*** Qiming has quit IRC | 00:06 | |
*** pratikmallya has quit IRC | 00:22 | |
*** xuhaiwei has quit IRC | 00:43 | |
*** lkarm has quit IRC | 00:51 | |
*** Qiming has joined #senlin | 01:00 | |
*** lkarm has joined #senlin | 01:03 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: Change developer/user docs about profile-update https://review.openstack.org/246717 | 01:04 |
---|---|---|
Qiming | morning | 01:05 |
*** lkarm has quit IRC | 01:08 | |
openstackgerrit | Merged openstack/senlin: Change developer/user docs about profile-update https://review.openstack.org/246717 | 01:18 |
*** Liuqing has joined #senlin | 01:29 | |
*** zhenguo has joined #senlin | 01:37 | |
*** Yanyanhu has joined #senlin | 01:43 | |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Reimplement authenticate method in sdk driver https://review.openstack.org/249043 | 01:57 |
Qiming | please help review this: https://review.openstack.org/249104 | 01:58 |
Yanyanhu | ok | 01:58 |
Qiming | it is a dependency from proposal on project-config: https://review.openstack.org/249244 | 01:58 |
openstackgerrit | Merged openstack/senlin: Update doc environ to use OpenStack docs theme https://review.openstack.org/248335 | 01:59 |
Yanyanhu | this is great | 02:00 |
Yanyanhu | Qiming, so this is for doc publishing progress? | 02:04 |
Qiming | no, this is for release notes | 02:04 |
Yanyanhu | ok | 02:04 |
Qiming | community has come up with a RElease NOtes management process | 02:04 |
Qiming | each project can maintain its own release notes in tree | 02:05 |
Yanyanhu | ok, that's a good news | 02:05 |
Qiming | at the end of a release cycle, release notes is there for use | 02:05 |
Yanyanhu | understand. | 02:05 |
Qiming | with this patch merged and gate prepared | 02:06 |
Qiming | I can try show the team how to add a release note | 02:06 |
Qiming | I myself is learning it | 02:06 |
Yanyanhu | cool, I'm expecting it | 02:06 |
Qiming | that said, I'm not quite sure we will need bug report for all patches | 02:06 |
Qiming | that is purely a process thing, it is making our lives much harder than simpler | 02:07 |
Yanyanhu | rn can be used to manage patches? | 02:07 |
Qiming | I will try that later | 02:07 |
Yanyanhu | ok | 02:07 |
Yanyanhu | seems merge conflict happened | 02:08 |
Qiming | you can add 'features', 'issues', 'upgrade', 'critical', 'fixes', 'other' types of items when submitting a patch | 02:08 |
Qiming | it is supposed to be part of our daily patch review work | 02:09 |
Yanyanhu | ok, that's very useful | 02:09 |
openstackgerrit | Merged openstack/senlin: Reimplement authenticate method in sdk driver https://review.openstack.org/249043 | 02:09 |
Yanyanhu | and after the release is done, a list will be generated automatically based on project's patch history | 02:09 |
Yanyanhu | based on the tag of patches? | 02:10 |
Qiming | no, along with a patch, you will add a yaml file under releasenotes/notes/ | 02:10 |
Yanyanhu | oh, I see | 02:10 |
Yanyanhu | so this part is handled manually | 02:10 |
Qiming | there is no magic | 02:11 |
Yanyanhu | :) | 02:11 |
Qiming | merge conflict caused by test-requirements I think | 02:11 |
Qiming | looking | 02:12 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Add reno for release notes generation https://review.openstack.org/249104 | 02:24 |
*** jdandrea has quit IRC | 02:38 | |
*** xuhaiwei has joined #senlin | 02:44 | |
openstackgerrit | Merged openstack/senlin: Add reno for release notes generation https://review.openstack.org/249104 | 02:57 |
*** yuanying has quit IRC | 03:21 | |
*** lkarm has joined #senlin | 03:27 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: Remove 'trigger' support from rpc client https://review.openstack.org/249535 | 03:29 |
*** lkarm has quit IRC | 03:30 | |
*** lkarm has joined #senlin | 03:31 | |
*** lkarm has quit IRC | 03:35 | |
*** elynn has joined #senlin | 03:37 | |
openstackgerrit | Merged openstack/senlin: Remove 'trigger' from api layer https://review.openstack.org/249261 | 03:51 |
*** yuanying has joined #senlin | 04:06 | |
*** Liuqing has quit IRC | 04:41 | |
*** Liuqing has joined #senlin | 04:42 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: Remove 'trigger' support from rpc client https://review.openstack.org/249535 | 05:15 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Remove 'trigger' from engine layer https://review.openstack.org/249554 | 05:19 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Fix PEP8 error in doc source file https://review.openstack.org/249555 | 05:21 |
Yanyanhu | hi, Qiming, I noticed brain proposed a patch to unify the naming of input param of find proxy call to 'name_or_id', so should I also make a change to my patch following this way | 05:27 |
Yanyanhu | https://review.openstack.org/#/c/249537/1 | 05:28 |
Yanyanhu | brain's patch | 05:28 |
Yanyanhu | and mine https://review.openstack.org/#/c/242969/ | 05:28 |
Qiming | Yanyanhu, yes | 05:29 |
Yanyanhu | ok, will make a change | 05:29 |
Qiming | seems he has changed his mind | 05:29 |
Yanyanhu | ok | 05:29 |
Qiming | previously, he -1'ed one of my patch for the 'name_or_id' parameter in a find method | 05:30 |
Qiming | anyway, be consistent is more important | 05:30 |
Yanyanhu | yea | 05:30 |
*** Liuqing has quit IRC | 05:47 | |
*** Liuqing has joined #senlin | 05:48 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: Add backlog for release notes during mitaka https://review.openstack.org/249573 | 05:49 |
*** elynn has quit IRC | 05:50 | |
openstackgerrit | Merged openstack/senlin: Fix PEP8 error in doc source file https://review.openstack.org/249555 | 06:01 |
openstackgerrit | Merged openstack/senlin: Remove 'trigger' from engine layer https://review.openstack.org/249554 | 06:01 |
openstackgerrit | Merged openstack/senlin: Remove 'trigger' support from rpc client https://review.openstack.org/249535 | 06:02 |
Qiming | Yanyanhu, minor nit regarding patch https://review.openstack.org/242969 | 06:10 |
Qiming | the commit message says: Make nova server_interface function calls workable | 06:10 |
Qiming | you can instead just say: Make nova server_interface function calls work | 06:11 |
Yanyanhu | ok, will change it :) | 06:11 |
Qiming | don't need to submit a new patchset | 06:11 |
Qiming | just change in in web would suffice | 06:11 |
Yanyanhu | ok | 06:11 |
Qiming | I wasn't changing it because once I do that, the commiter becomes me, :) | 06:12 |
Yanyanhu | ok, understand | 06:12 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Remove trigger implementations https://review.openstack.org/249580 | 06:14 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Remove environment support for triggers https://review.openstack.org/249585 | 06:23 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Remove DB support to triggers https://review.openstack.org/249586 | 06:36 |
Qiming | okay, I think the #249586 patch is the last one for removing trigger support | 06:37 |
Qiming | bybye, trigger, see you next time | 06:37 |
Yanyanhu | :) | 06:37 |
*** Liuqing_ has joined #senlin | 06:38 | |
*** Liuqing has quit IRC | 06:39 | |
openstackgerrit | xu-haiwei proposed openstack/python-senlinclient: Fix 'endpoint missing' error caused by SDK's change https://review.openstack.org/249588 | 06:40 |
xuhaiwei | Yanyanhu, see this patch ^^^ | 06:41 |
xuhaiwei | I think this is the bug you met yesterday | 06:41 |
Yanyanhu | ok :) | 06:41 |
Qiming | thanks, xuhaiwei | 07:15 |
xuhaiwei | nope | 07:15 |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Enable update of image property for nova server profile https://review.openstack.org/248555 | 07:16 |
openstackgerrit | Merged openstack/python-senlinclient: Fix 'endpoint missing' error caused by SDK's change https://review.openstack.org/249588 | 07:16 |
openstackgerrit | Merged openstack/senlin: Remove trigger implementations https://review.openstack.org/249580 | 07:34 |
openstackgerrit | Merged openstack/senlin: Remove environment support for triggers https://review.openstack.org/249585 | 07:34 |
openstackgerrit | Merged openstack/senlin: Remove DB support to triggers https://review.openstack.org/249586 | 07:35 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Fixed a typo in error message https://review.openstack.org/249617 | 07:42 |
xuhaiwei | Yanyanhu | 07:54 |
*** Qiming has quit IRC | 07:54 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: Minor tweaking of an error message https://review.openstack.org/249622 | 07:54 |
*** Yanyanhu has quit IRC | 07:54 | |
*** Qiming has joined #senlin | 07:54 | |
*** Yanyanhu has joined #senlin | 07:54 | |
xuhaiwei | Yanyanhu | 07:54 |
Yanyanhu | hi | 07:55 |
xuhaiwei | I am reviewing this patch https://review.openstack.org/#/c/248555/4/senlin/drivers/openstack/nova_v2.py | 07:55 |
xuhaiwei | the method rebuild_server is not merged in SDK? | 07:55 |
xuhaiwei | that method | 07:55 |
Yanyanhu | yes, it is still pending there | 07:56 |
xuhaiwei | ok, can you show me the link? | 07:56 |
Qiming | ah, then you need to add a depends-on: tag in the message | 07:56 |
Yanyanhu | hope can get consensus with sdk team this week | 07:56 |
Yanyanhu | yes | 07:56 |
Yanyanhu | will add a dependency there | 07:57 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Fixed a typo in error message https://review.openstack.org/249617 | 08:32 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Minor tweaking of an error message https://review.openstack.org/249622 | 08:37 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Fixed a typo in error message https://review.openstack.org/249617 | 08:41 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Minor tweaking of an error message https://review.openstack.org/249622 | 08:43 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Parameter checking for cluster-policy-detach https://review.openstack.org/249640 | 08:54 |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Set auth_plugin type to password when building sdk connection https://review.openstack.org/249642 | 08:58 |
openstackgerrit | Merged openstack/senlin: Fixed a typo in error message https://review.openstack.org/249617 | 09:09 |
openstackgerrit | Merged openstack/senlin: Minor tweaking of an error message https://review.openstack.org/249622 | 09:10 |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Enable update of image property for nova server profile https://review.openstack.org/248555 | 09:11 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Parameter checking for cluster-policy-update https://review.openstack.org/249651 | 09:12 |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Enable update of image property for nova server profile https://review.openstack.org/248555 | 09:12 |
*** Liuqing_ has quit IRC | 09:15 | |
Yanyanhu | hi, Qiming, if I have a patch A that depends on another patch B proposed in other project, A will be marked as merge conflict as well if B is in merge conflict status? | 09:15 |
Yanyanhu | like this one... https://review.openstack.org/#/c/248555/ | 09:15 |
*** Liuqing has joined #senlin | 09:15 | |
Qiming | emm, that's funny | 09:16 |
Qiming | never saw that before | 09:16 |
Yanyanhu | yes... never met this situation... | 09:16 |
Qiming | anyway, you will need to make sdk side patch work first | 09:18 |
Yanyanhu | yes | 09:18 |
*** Liuqing has quit IRC | 09:41 | |
*** zhenguo has quit IRC | 10:01 | |
*** Qiming has quit IRC | 10:05 | |
*** Liuqing has joined #senlin | 10:05 | |
*** Yanyanhu has quit IRC | 10:15 | |
*** Liuqing has quit IRC | 10:22 | |
*** Liuqing has joined #senlin | 10:23 | |
*** Liuqing has quit IRC | 10:29 | |
*** Liuqing has joined #senlin | 10:30 | |
*** gongysh_ has quit IRC | 11:19 | |
*** lvdongbing has joined #senlin | 11:21 | |
*** Qiming has joined #senlin | 11:27 | |
*** lvdongbing has quit IRC | 12:17 | |
openstackgerrit | Merged openstack/senlin: Add backlog for release notes during mitaka https://review.openstack.org/249573 | 13:04 |
openstackgerrit | Merged openstack/senlin: Set auth_plugin type to password when building sdk connection https://review.openstack.org/249642 | 13:18 |
*** zhenguo has joined #senlin | 13:59 | |
*** openstackgerrit has quit IRC | 14:06 | |
*** openstackgerrit has joined #senlin | 14:07 | |
*** lkarm has joined #senlin | 14:07 | |
*** lkarm has quit IRC | 14:33 | |
*** Tiancheng has joined #senlin | 14:37 | |
*** lkarm has joined #senlin | 15:02 | |
*** lkarm has quit IRC | 15:06 | |
*** pratikmallya has joined #senlin | 15:55 | |
*** Qiming has quit IRC | 16:05 | |
*** jdandrea has joined #senlin | 16:09 | |
*** jdandrea has quit IRC | 16:09 | |
*** jdandrea has joined #senlin | 16:10 | |
*** jdandrea has quit IRC | 16:11 | |
*** jdandrea has joined #senlin | 16:12 | |
*** pratikma_ has joined #senlin | 16:21 | |
*** Tiancheng has quit IRC | 16:21 | |
*** pratikmallya has quit IRC | 16:24 | |
*** zhenguo has quit IRC | 16:25 | |
*** Liuqing has quit IRC | 16:40 | |
*** pratikma_ is now known as pratikmallya | 17:39 | |
*** xuhaiwei has quit IRC | 17:46 | |
*** pratikmallya has quit IRC | 18:05 | |
*** pratikmallya has joined #senlin | 18:33 | |
*** lkarm has joined #senlin | 19:45 | |
*** lkarm has quit IRC | 19:50 | |
*** pratikma_ has joined #senlin | 20:21 | |
*** pratikmallya has quit IRC | 20:24 | |
*** pratikma_ has quit IRC | 21:12 | |
*** openstackgerrit has quit IRC | 21:36 | |
*** openstackgerrit has joined #senlin | 21:37 | |
*** pratikmallya has joined #senlin | 21:45 | |
*** pratikmallya has quit IRC | 22:05 | |
*** pratikmallya has joined #senlin | 22:15 | |
*** Qiming has joined #senlin | 23:26 | |
*** Qiming has quit IRC | 23:31 | |
*** Qiming_ has joined #senlin | 23:31 | |
*** xuhaiwei has joined #senlin | 23:51 | |
*** Qiming_ has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!