| *** lvdongbing has joined #senlin | 00:20 | |
| *** lkarm has joined #senlin | 00:42 | |
| *** yuanying has quit IRC | 00:44 | |
| *** yuanying has joined #senlin | 00:44 | |
| *** lkarm has quit IRC | 00:46 | |
| openstackgerrit | xu-haiwei proposed openstack/python-senlinclient: Make '_short_id' method a public method https://review.openstack.org/250091 | 00:56 |
|---|---|---|
| *** lvdongbing has quit IRC | 00:58 | |
| *** pratikmallya has quit IRC | 01:09 | |
| *** pratikmallya has joined #senlin | 01:09 | |
| *** pratikmallya has quit IRC | 01:14 | |
| *** Qiming has joined #senlin | 01:16 | |
| *** lvdongbing has joined #senlin | 01:17 | |
| *** zhenguo has joined #senlin | 01:23 | |
| openstackgerrit | junxu proposed openstack/senlin: Remove examples for triggers https://review.openstack.org/250103 | 01:28 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Force releasenotes warnings to be treated as errors https://review.openstack.org/250107 | 01:35 |
| *** Yanyanhu has joined #senlin | 01:40 | |
| openstackgerrit | xu-haiwei proposed openstack/python-senlinclient: Remove Trigger related sources in client side https://review.openstack.org/250111 | 01:40 |
| *** lvdongbing has quit IRC | 01:44 | |
| *** lvdongbing has joined #senlin | 01:54 | |
| *** pratikmallya has joined #senlin | 01:57 | |
| *** Qiming has quit IRC | 02:03 | |
| *** Qiming has joined #senlin | 02:03 | |
| openstackgerrit | lvdongbing proposed openstack/senlin: Update node status when fail to create nova instance https://review.openstack.org/238753 | 02:08 |
| *** Tiancheng has joined #senlin | 02:29 | |
| openstackgerrit | Merged openstack/senlin: Parameter checking for cluster-policy-detach https://review.openstack.org/249640 | 03:04 |
| openstackgerrit | Merged openstack/senlin: Parameter checking for cluster-policy-update https://review.openstack.org/249651 | 03:04 |
| openstackgerrit | Merged openstack/senlin: Remove examples for triggers https://review.openstack.org/250103 | 03:13 |
| *** gongysh_ has joined #senlin | 03:19 | |
| *** yuanying has quit IRC | 03:22 | |
| *** Qiming has quit IRC | 03:25 | |
| *** Qiming has joined #senlin | 03:26 | |
| *** pratikmallya has quit IRC | 04:05 | |
| *** pratikmallya has joined #senlin | 04:05 | |
| *** yuanying has joined #senlin | 04:07 | |
| *** pratikmallya has quit IRC | 04:09 | |
| xuhaiwei | ping Qiming | 05:26 |
| Qiming | hi | 05:27 |
| xuhaiwei | I am writing client test case | 05:27 |
| xuhaiwei | when testing webhook, I tried to create one, but failed for some reason | 05:28 |
| xuhaiwei | I noticed this patch https://review.openstack.org/#/c/216751/2/senlin/api/middleware/webhook.py | 05:28 |
| Qiming | you mean a failure at server side? | 05:28 |
| xuhaiwei | seems so | 05:28 |
| *** gongysh_ has quit IRC | 05:29 | |
| *** gongysh has quit IRC | 05:29 | |
| xuhaiwei | I read this patch, and found someting seem wrong | 05:29 |
| Qiming | okay? | 05:29 |
| xuhaiwei | you tried to get 'key' from url, but key is not in it | 05:29 |
| *** gongysh has joined #senlin | 05:29 | |
| *** gongysh_ has joined #senlin | 05:29 | |
| xuhaiwei | the url is something like http://xxxx/v1/d59cb05324954496b86475cc9afbbd65/webhooks | 05:30 |
| xuhaiwei | the key is in request body | 05:31 |
| Qiming | key is not in request body | 05:38 |
| Qiming | that will be a malformed url I think | 05:38 |
| xuhaiwei | the key should be the 'credential'? | 05:39 |
| Qiming | no, key is key | 05:39 |
| Qiming | credential is stored encrypted in db | 05:39 |
| Qiming | you will use the key to decrypt the credential | 05:39 |
| Qiming | see line 95-103 | 05:40 |
| xuhaiwei | how does the 'key' get into the url? | 05:40 |
| Qiming | read the webhook-create api | 05:41 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Enable update of image property for nova server profile https://review.openstack.org/248555 | 05:41 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Rename image_get_by_name to image_find https://review.openstack.org/250154 | 05:41 |
| Qiming | it is part of the webhook url when a webhook is created | 05:42 |
| xuhaiwei | I think the url I gave is request url which is different from webhook url | 05:43 |
| xuhaiwei | the 'key' should be in webhook url, right? | 05:43 |
| Qiming | when you do a webhook trigger, key should be in the url | 05:43 |
| xuhaiwei | in request url? | 05:44 |
| xuhaiwei | that is webhook url i think, they are different | 05:44 |
| Qiming | I don't know what do you mean by request url | 05:45 |
| Qiming | how about check the test case here? https://review.openstack.org/#/c/216751/2/senlin/tests/unit/middleware/test_webhook_middleware.py | 05:45 |
| xuhaiwei | the url which is used to find webhook api | 05:45 |
| Qiming | by reading the setUp() call, you will understand the proper format of a url for webhook trigger | 05:46 |
| xuhaiwei | the webhook url is created in senlin/engine/webhook.py, right? | 05:47 |
| Qiming | yes | 05:47 |
| Qiming | the webhook "alarm" url | 05:47 |
| xuhaiwei | but senlin/api/middleware/webhook.py is executed before engine/webhook.py | 05:48 |
| xuhaiwei | so in middleware/webhook.py, webhook 'alarm' url is not created yet | 05:49 |
| Qiming | are you talking about webhook creation or webhook triggering? | 05:50 |
| xuhaiwei | creation | 05:50 |
| Qiming | webhook middleware will only affect webhook trigger | 05:50 |
| Qiming | if it is not a webhook trigger call, the middleware will be skipped, http://git.openstack.org/cgit/openstack/senlin/tree/senlin/api/middleware/webhook.py#n44 | 05:51 |
| xuhaiwei | I think I got your idea | 05:53 |
| Qiming | great | 05:53 |
| xuhaiwei | there should be somewhere else wrong, currently webhook is not correctly created | 05:53 |
| Qiming | ok | 05:53 |
| *** openstack has joined #senlin | 05:57 | |
| Qiming | welcome back, openstack | 05:57 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Enable a new role for migrated node https://review.openstack.org/250165 | 06:11 |
| Qiming | https://review.openstack.org/#/c/250164/ | 06:25 |
| Qiming | just trying to invite openstackstatus to #senlin channel | 06:25 |
| Qiming | :) | 06:25 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Rename image_get_by_name to image_find https://review.openstack.org/250154 | 06:25 |
| Yanyanhu | the one who will respond to bug/review number? | 06:26 |
| Qiming | no, the 'one' who tells us that gerrit is down | 06:28 |
| Qiming | gerrit is slow | 06:29 |
| Yanyanhu | oh | 06:29 |
| Qiming | Yanyanhu, you are building a train of patches where the first car is broken | 06:31 |
| Qiming | looking at it now | 06:31 |
| Yanyanhu | yes... | 06:32 |
| Yanyanhu | 4 carriages | 06:33 |
| Qiming | can cross projects | 06:34 |
| Yanyanhu | umm | 06:35 |
| Yanyanhu | not sure whether SDK guys are ok with the latest change of nova-server-interface patch | 06:35 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Rename image_get_by_name to image_find https://review.openstack.org/250154 | 06:37 |
| Qiming | Yanyanhu, I'm looking at it | 06:50 |
| Yanyanhu | ok | 06:50 |
| Qiming | the question I have is about the relationship between 'server' and 'value' | 06:51 |
| Qiming | there are two possibilities in general | 06:51 |
| Qiming | if 'value' is an instance of ServerInterface, you can get server_id there | 06:51 |
| Yanyanhu | yes | 06:52 |
| Qiming | or else, 'value' will be treated as the ID of the ServerInterface, you will need the 'server' variable to get the server_id | 06:52 |
| Yanyanhu | yes | 06:52 |
| Qiming | can we use name of a server interface when doing find? | 06:56 |
| Yanyanhu | no, since server interface doesn't have name attr | 06:56 |
| Yanyanhu | it only has an ID attr which is actually the port_id | 06:57 |
| Qiming | okay | 06:57 |
| Qiming | posted some comments, hope they are helpful | 06:58 |
| Yanyanhu | ok, will check it, thanks | 06:58 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Let node-join return 400 if cluster is not found https://review.openstack.org/250202 | 07:12 |
| *** Qiming_ has joined #senlin | 07:24 | |
| *** yuanying_ has joined #senlin | 07:25 | |
| *** openstack has quit IRC | 07:28 | |
| *** openstack has joined #senlin | 14:08 | |
| *** zhenguo has joined #senlin | 14:17 | |
| *** Qiming has quit IRC | 15:22 | |
| *** pratikmallya has joined #senlin | 16:07 | |
| *** zhenguo has quit IRC | 16:21 | |
| *** gongysh has quit IRC | 16:35 | |
| *** gongysh has joined #senlin | 16:37 | |
| *** gongysh has quit IRC | 16:58 | |
| *** gongysh has joined #senlin | 17:00 | |
| *** gongysh has quit IRC | 17:14 | |
| *** gongysh has joined #senlin | 17:17 | |
| *** gongysh has quit IRC | 17:43 | |
| *** gongysh has joined #senlin | 17:43 | |
| *** openstackgerrit has quit IRC | 18:49 | |
| *** pratikmallya has quit IRC | 19:01 | |
| *** openstackgerrit has joined #senlin | 19:10 | |
| *** pratikmallya has joined #senlin | 19:14 | |
| *** gongysh has quit IRC | 19:26 | |
| *** gongysh has joined #senlin | 19:28 | |
| *** openstackgerrit has quit IRC | 21:06 | |
| *** openstackgerrit has joined #senlin | 21:07 | |
| *** Qiming has joined #senlin | 23:47 | |
| *** openstackgerrit has quit IRC | 23:47 | |
| *** openstackgerrit_ has joined #senlin | 23:48 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:48 | |
| openstackgerrit | Merged openstack/senlin: Let node-join return 400 if cluster is not found https://review.openstack.org/250202 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!