| *** catintheroof has joined #senlin | 00:11 | |
| *** catintheroof has quit IRC | 01:09 | |
| *** yanyanhu has joined #senlin | 01:33 | |
| openstackgerrit | Aaron Ding proposed openstack/senlin: Fix cluster-list failed of ResourceNotFound problem https://review.openstack.org/421008 | 01:35 |
|---|---|---|
| *** zhurong has joined #senlin | 01:41 | |
| ruijie | hi, Qiming, around? | 01:49 |
| Qiming | ya | 01:49 |
| ruijie | Do you think we need to add some exception type into senlin | 01:50 |
| ruijie | https://review.openstack.org/gitweb?p=openstack/senlin.git;a=blob;f=senlin/engine/service.py;h=9e122a71c4491219ecb0b5934eecea0a340bde9c;hb=ed9f0887d4f9017897ac5236e969669286575cfa#l1135 | 01:50 |
| Qiming | honestly I don't see such a need | 01:51 |
| ruijie | Agreed, but the exception message will contains "The request is malformed..." | 01:55 |
| ruijie | since we raised a Badrequest in service layer | 01:56 |
| Qiming | yes, the reason string is verbose | 01:57 |
| Qiming | it can be simplified here: http://git.openstack.org/cgit/openstack/senlin/tree/senlin/common/exception.py#n84 | 01:57 |
| ruijie | sorry , Qiming, just saw that | 01:57 |
| Qiming | Just make it msg_fmt = _("%(msg)s") would be fine | 01:58 |
| ruijie | And another on is about the NotFound, when we operating cluster, we will raise BadRequest if we cannot find the node resource | 01:58 |
| Qiming | yes | 01:59 |
| ruijie | the format is different with ResourceNotFound | 01:59 |
| Qiming | that is true | 01:59 |
| Qiming | they are different exception types, even from client perspective | 01:59 |
| Qiming | ResourceNotFound is 404, BadRequest is 400 | 02:00 |
| *** chohoor has joined #senlin | 02:00 | |
| ruijie | So, we just make the BadRequest exception's message as the same as ResourceNotFound? | 02:00 |
| Qiming | yes | 02:00 |
| Qiming | oh, no | 02:00 |
| ruijie | :( | 02:01 |
| Qiming | why the message should be the same? | 02:01 |
| ruijie | you forgot your comment under the review :( | 02:01 |
| Qiming | when raising BadRequest, we are explicitly spelling out the complete message | 02:01 |
| ruijie | https://review.openstack.org/#/c/420526/ | 02:01 |
| Qiming | sorry I didn't make it clear enough | 02:02 |
| Qiming | the inconsistency I was referring to is about the use of () and '' | 02:02 |
| Qiming | ideally, we should be consistent about this in any message | 02:03 |
| Qiming | either we always use (), or we always use single quote '' | 02:03 |
| Qiming | it is a little bit ugly today | 02:03 |
| ruijie | yes Qiming, I see | 02:04 |
| Qiming | there are two different topics: one is to remove the "The request is malformed: " part, so that BadRequest only accepts the message string without adding adding additional words | 02:05 |
| Qiming | the other topic is about converge to either (foobar) or 'foobar' in all messages, avoid the mixture | 02:05 |
| ruijie | single quotes might be better? | 02:06 |
| XueFeng | +1 | 02:07 |
| Qiming | I"m fine with either one | 02:13 |
| XueFeng | :) | 02:14 |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add angular policies table https://review.openstack.org/389076 | 02:33 |
| openstackgerrit | Aaron Ding proposed openstack/senlin: Fix cluster-list failed of ResourceNotFound problem https://review.openstack.org/421008 | 02:36 |
| wllabs | what do i need to do | 02:41 |
| Qiming | wllabs, you mean? | 02:42 |
| wllabs | I would like to participate in community work, I would like to coding | 02:45 |
| wllabs | I do openstack development of three or four years | 02:45 |
| openstackgerrit | Merged openstack/senlin: Updated from global requirements https://review.openstack.org/419941 | 02:52 |
| *** Drago has quit IRC | 02:56 | |
| Qiming | okay, wllabs, thanks for your interests in senlin | 02:56 |
| Qiming | you can start by helping write some unit tests, pick up whatever you want to work on from the TODO.rst file, .. | 02:57 |
| Qiming | you can also help review patches committed by others | 02:58 |
| *** yuanying has quit IRC | 03:01 | |
| *** yuanying has joined #senlin | 03:01 | |
| *** yuanying has quit IRC | 03:01 | |
| *** yuanying has joined #senlin | 03:02 | |
| openstackgerrit | Merged openstack/senlin: Fix _add_listener cannot get project https://review.openstack.org/420631 | 03:02 |
| *** yuanying has quit IRC | 03:06 | |
| wllabs | how to review code, I have not been involved in the community before | 03:08 |
| yanyanhu | hi, wllabs. you can open the following web page which is the list of patches to a project, e.g. senlin | 03:11 |
| yanyanhu | https://review.openstack.org/#/q/project:openstack/senlin | 03:11 |
| yanyanhu | and then check a patch which is still in "open" status | 03:11 |
| yanyanhu | and read its code and leave your comment | 03:11 |
| wllabs | ok, thank you | 03:11 |
| yanyanhu | my pleasure. The entire code review workflow is supported by gerrit. You can try to get familiar with its web ui first. | 03:13 |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin: revise BadRequest exception message https://review.openstack.org/421045 | 03:17 |
| Qiming | wllabs, if you are willing to contribute by writing test cases, you can do this: | 03:19 |
| Qiming | tox -e cover | 03:19 |
| Qiming | you will find 'cover' and 'cover-master' subdirectory | 03:20 |
| Qiming | open the 'index.html' file under one of them, you will see the statistics about each module | 03:21 |
| Qiming | the overall unit test coverage today is 91% for senlin | 03:21 |
| wllabs | I tried next | 03:21 |
| Qiming | we can improve that to ensure the important paths are covered by unit tests | 03:21 |
| *** zhurong has quit IRC | 03:40 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 03:46 | |
| *** yuanying has joined #senlin | 04:02 | |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add angular policies table https://review.openstack.org/389076 | 04:07 |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add angular policies table https://review.openstack.org/389076 | 04:24 |
| *** Drago1 has joined #senlin | 04:42 | |
| *** yuanying has quit IRC | 04:55 | |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add details view into Policies panel https://review.openstack.org/421072 | 05:00 |
| *** yuanying has joined #senlin | 05:03 | |
| openstackgerrit | Merged openstack/senlin: revise tempest api test for cluster-1 https://review.openstack.org/420606 | 05:32 |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add delete action for policies panel https://review.openstack.org/421078 | 05:34 |
| openstackgerrit | Merged openstack/senlin: revise tempest api test for cluster policy https://review.openstack.org/420526 | 05:44 |
| *** elynn has joined #senlin | 05:45 | |
| *** yuanying has quit IRC | 05:46 | |
| *** yuanying has joined #senlin | 05:47 | |
| *** yuanying has quit IRC | 05:51 | |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add delete action for policies panel https://review.openstack.org/421078 | 05:57 |
| *** Jeffrey4l_ has joined #senlin | 06:30 | |
| *** Jeffrey4l has quit IRC | 06:34 | |
| *** Jeffrey4l_ is now known as Jeffrey4l | 06:34 | |
| *** zhurong has joined #senlin | 06:36 | |
| *** eandersson_ has joined #senlin | 06:48 | |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add delete action for policies panel https://review.openstack.org/421078 | 06:50 |
| *** eandersson has quit IRC | 06:51 | |
| *** yuanying has joined #senlin | 07:23 | |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin: revise BadRequest exception message https://review.openstack.org/421045 | 07:41 |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin: unify exceptions' message https://review.openstack.org/421109 | 07:41 |
| *** Drago1 has quit IRC | 07:54 | |
| *** Drago1 has joined #senlin | 08:05 | |
| openstackgerrit | Shu Muto proposed openstack/senlin-dashboard: Add create and update actions for policy https://review.openstack.org/421119 | 08:08 |
| *** shu-mutou is now known as shu-mutou-AWAY | 08:15 | |
| wllabs | how to generate senlin-wsgi-api | 08:20 |
| openstackgerrit | Merged openstack/senlin: improve tempest test for action list https://review.openstack.org/420466 | 08:23 |
| openstackgerrit | RUIJIE YUAN proposed openstack/senlin: revise BadRequest exception message https://review.openstack.org/421045 | 08:25 |
| Qiming | wllabs, it is generated when you do pip install | 08:31 |
| Qiming | see setup.cfg | 08:31 |
| wllabs | does python setup.py can generate wsgi-api ? | 08:32 |
| Qiming | not sure | 08:45 |
| Qiming | it should do | 08:45 |
| *** ruijie has quit IRC | 08:55 | |
| xuhaiweixuhaiwei | Hi Qiming, yanyanhu, there will be a discussion about senlin integration with Tacker in tomorrow's tacker meeting, can one of you join? | 09:01 |
| xuhaiweixuhaiwei | 13:30 beijing time | 09:01 |
| xuhaiweixuhaiwei | oh, my name is strange | 09:02 |
| yanyanhu | yes, I can be there | 09:02 |
| yanyanhu | in #openstack-meeting channel? | 09:02 |
| xuhaiweixuhaiwei | yes | 09:03 |
| yanyanhu | will add this item to the agenda of tonight's meeting | 09:03 |
| yanyanhu | I believe more people are interested to join it :) | 09:03 |
| yanyanhu | e.g. xinhui and ethan | 09:03 |
| xuhaiweixuhaiwei | that will be great | 09:04 |
| xuhaiweixuhaiwei | because Kanagaraj is still asking questions in the spec about how to auto-scalie some specific vms, for this function senlin should first make the vms to be nodes of a senlin cluster, and then auto-scale them | 09:05 |
| xuhaiweixuhaiwei | It seems senlin will support this function soon, yanyanhu? | 09:06 |
| yanyanhu | xuhaiweixuhaiwei, you mean vm adoption? | 09:07 |
| yanyanhu | yes, we will. That work item is in the list and has high priority I think | 09:07 |
| xuhaiweixuhaiwei | yes | 09:07 |
| xuhaiweixuhaiwei | ok, got it | 09:08 |
| yanyanhu | we plan to work on it soon but not sure whether it can be done in ocata cycle since only 1 month left before final release | 09:08 |
| yanyanhu | and still some technical detail need to figure out | 09:08 |
| Qiming | "autoscaing specific VDU" means scaling to an existing node? or node adoption? | 09:09 |
| xuhaiweixuhaiwei | tacker team want senlin integration feature to be merged in ocata cycle, it seems difficult too | 09:09 |
| Qiming | what is the exact requirement? | 09:09 |
| xuhaiweixuhaiwei | Qiming, I think the exact requirement is writing a heat template, configure the necessary properties of some vms, and then deploy it, senlin will make these vms belong to a newly created cluster | 09:11 |
| yanyanhu | xuhaiweixuhaiwei, if so, why don't we use senlin to deploy those vms at the beginning? | 09:12 |
| yanyanhu | I mean for those new created VMs | 09:12 |
| Qiming | that is the explanation of "autoscaling specific VDU"? | 09:12 |
| xuhaiweixuhaiwei | yes, I think it is | 09:12 |
| xuhaiweixuhaiwei | yanyanhu, that is the use case that user want to senlin to manage the vms which are not created by senlin | 09:13 |
| yanyanhu | I see | 09:13 |
| yanyanhu | if so, it makes sense | 09:13 |
| Qiming | better clarify this first | 09:14 |
| Qiming | KM didn't explain his words | 09:14 |
| xuhaiweixuhaiwei | Qiming, yes, I asked him in the last tacker meeting | 09:15 |
| Qiming | okay | 09:15 |
| Qiming | I'm still feeing it more straightforward to get the VDU created as a single node senlin cluster if there is a scaling policy attached to it | 09:17 |
| xuhaiweixuhaiwei | yes, that is the main use case I think, KM just wants senlin to support both | 09:18 |
| Qiming | okay, for the latter one, we are working on it | 09:19 |
| Qiming | it is a little bit tricky how we are gonna manage the lifecycles of resources (VDUs, ports) we adopted as senlin nodes | 09:20 |
| Qiming | this feature will be of high priority, but I am not very optimistic that it will land in Ocata | 09:21 |
| xuhaiweixuhaiwei | tacker's ptl said I should add the life cycle manage api in tacker by requesting senlin-api | 09:21 |
| Qiming | this Ocata cycle is too short .... | 09:21 |
| Qiming | say a VDU is adopted into senlin cluster as a node | 09:22 |
| Qiming | and senlin doesn't have to worry about whether and how that node will be changed or deleted? | 09:22 |
| xuhaiweixuhaiwei | I am also suspecting if they want this feature merged in tacker, they even dont review the spec | 09:22 |
| Qiming | I believe sridahar has seen it | 09:23 |
| xuhaiweixuhaiwei | in ocata I mean | 09:23 |
| xuhaiweixuhaiwei | they want to merge it I think, but some cores may have different opinions | 09:24 |
| xuhaiweixuhaiwei | Qiming, I think all the vdu changes or deletion will be done through senlin-api | 09:24 |
| *** zhurong has quit IRC | 09:44 | |
| Qiming | ok | 09:49 |
| *** yanyanhu has quit IRC | 10:24 | |
| *** chohoor has quit IRC | 10:52 | |
| *** ruijie_ has joined #senlin | 11:47 | |
| *** Drago1 has quit IRC | 12:22 | |
| *** catintheroof has joined #senlin | 12:32 | |
| *** elynn has quit IRC | 12:37 | |
| *** elynn has joined #senlin | 12:45 | |
| *** yanyanhu has joined #senlin | 12:52 | |
| yanyanhu | hi, guys, meeting will start in minutes in openstack-meeting channel | 12:52 |
| yanyanhu | hi, guys, meeting have started | 13:01 |
| *** XueFengLiu has joined #senlin | 13:11 | |
| wllabs | Senlin can improve scale-out operation so that it can add existing nodes to | 13:25 |
| wllabs | a cluster when doing scale-out. We are not intended to scale to nodes not | 13:25 |
| wllabs | created by Senlin. | 13:25 |
| wllabs | Adoption of Nodes | 13:25 |
| wllabs | ----------------- | 13:25 |
| wllabs | There have been requirements on adopting existing resources (e.g. nova | 13:25 |
| wllabs | servers) to be managed by Senlin. | 13:25 |
| wllabs | Will support nova vm added to the Senlin cluster? | 13:26 |
| *** yanyanhu has quit IRC | 13:35 | |
| XueFengLiu | Yes | 13:39 |
| wllabs | We are not intended to scale to nodes not created by Senlin. There have been requirements on adopting existing resources (e.g. nova servers) to be managed by Senlin. | 13:40 |
| wllabs | These two sentences seem contradictory | 13:41 |
| ruijie_ | e.g. We already have a VM to provide service before we using Senlin. | 14:02 |
| *** XueFengLiu has quit IRC | 14:04 | |
| *** XueFengLiu has joined #senlin | 14:06 | |
| *** elynn has quit IRC | 15:36 | |
| *** Drago has joined #senlin | 15:56 | |
| *** jslater has quit IRC | 18:11 | |
| *** XueFengLiu has quit IRC | 18:28 | |
| *** Drago has quit IRC | 21:07 | |
| *** Drago has joined #senlin | 21:16 | |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** Jeffrey4l has joined #senlin | 21:48 | |
| *** catintheroof has quit IRC | 22:20 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!