| *** burper has joined #storyboard | 01:32 | |
| *** burper has left #storyboard | 01:32 | |
| *** burper has joined #storyboard | 02:12 | |
| *** burper has left #storyboard | 02:12 | |
| *** reed has joined #storyboard | 04:05 | |
| *** alexismonville has joined #storyboard | 04:31 | |
| *** alexismonville has quit IRC | 04:38 | |
| *** reed has quit IRC | 04:41 | |
| *** alexismonville has joined #storyboard | 05:40 | |
| *** alexismonville has quit IRC | 06:14 | |
| *** mrmartin has joined #storyboard | 06:24 | |
| *** jtomasek has joined #storyboard | 07:01 | |
| *** mrmartin has quit IRC | 07:05 | |
| *** coolsvap|afk is now known as coolsvap | 07:06 | |
| *** jtomasek has quit IRC | 07:15 | |
| *** mrmartin has joined #storyboard | 07:19 | |
| *** jcoufal has joined #storyboard | 07:32 | |
| *** petefoth has joined #storyboard | 08:08 | |
| *** ssam2 has joined #storyboard | 08:16 | |
| *** wdutch has joined #storyboard | 08:24 | |
| *** MaxV has joined #storyboard | 08:48 | |
| *** alexismonville has joined #storyboard | 09:03 | |
| *** alexismonville has quit IRC | 09:07 | |
| *** k4n0 has joined #storyboard | 09:29 | |
| *** k4n0 has quit IRC | 09:36 | |
| *** CTtpollard has joined #storyboard | 09:56 | |
| *** jtomasek has joined #storyboard | 10:06 | |
| *** alexismonville has joined #storyboard | 10:11 | |
| *** coolsvap is now known as coolsvap|afk | 11:10 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Add button to remove all recent events in dashboard https://review.openstack.org/147105 | 11:14 |
|---|---|---|
| *** alexismonville has quit IRC | 11:18 | |
| *** CTtpollard has quit IRC | 12:12 | |
| *** CTtpollard has joined #storyboard | 12:13 | |
| *** alexismonville has joined #storyboard | 12:24 | |
| *** alexismonville has quit IRC | 12:25 | |
| *** mase_x200 has joined #storyboard | 12:34 | |
| *** alexismonville has joined #storyboard | 12:45 | |
| openstackgerrit | Merged openstack-infra/storyboard: Team and project groups delete methods https://review.openstack.org/143675 | 13:14 |
| *** jcoufal_ has joined #storyboard | 13:14 | |
| *** jcoufal has quit IRC | 13:17 | |
| *** jtomasek has quit IRC | 14:02 | |
| *** jtomasek_ has joined #storyboard | 14:02 | |
| *** alexismonville has quit IRC | 14:32 | |
| *** mase_x200 has quit IRC | 14:35 | |
| *** alexismonville has joined #storyboard | 14:55 | |
| *** rcarrillocruz has quit IRC | 15:25 | |
| *** rcarrillocruz has joined #storyboard | 15:25 | |
| *** mrmartin has quit IRC | 15:30 | |
| *** petefoth has quit IRC | 15:45 | |
| openstackgerrit | Aleksey proposed openstack-infra/storyboard: Convert db exceptions to api exceptions https://review.openstack.org/144442 | 15:52 |
| *** jedimike has joined #storyboard | 15:54 | |
| *** reed has joined #storyboard | 15:57 | |
| *** mrmartin has joined #storyboard | 16:04 | |
| *** mattfarina has joined #storyboard | 16:13 | |
| *** ssam2 has quit IRC | 16:14 | |
| *** alexismonville has quit IRC | 16:14 | |
| *** alexismonville has joined #storyboard | 16:22 | |
| *** wdutch has quit IRC | 16:59 | |
| *** MaxV has quit IRC | 17:03 | |
| *** MaxV has joined #storyboard | 17:04 | |
| *** MaxV has quit IRC | 17:09 | |
| *** jtomasek_ has quit IRC | 17:19 | |
| *** Piet has joined #storyboard | 17:20 | |
| *** mrmartin has quit IRC | 17:36 | |
| *** miqui_ has joined #storyboard | 17:54 | |
| *** alexismonville has quit IRC | 17:56 | |
| *** alexismonville has joined #storyboard | 17:58 | |
| *** alexismonville1 has joined #storyboard | 18:09 | |
| *** alexismonville has quit IRC | 18:10 | |
| *** mrmartin has joined #storyboard | 18:38 | |
| *** wuhg has quit IRC | 18:44 | |
| yolanda | hi krotscheck, i saw you proposed some changes to the task statuses, that's nice | 19:11 |
| krotscheck | yolanda: Yeah, I figured it’d be easier to have our API be consistent, allowing us to use our existing resource factory to handle caching. | 19:12 |
| krotscheck | yolanda: btw, you’ve got +2 on python-storyboardclient. There’s a couple of things there you can land :) | 19:12 |
| yolanda | heh, you give me the honours :) | 19:13 |
| krotscheck | yolanda: Hey, as long as we have two +2’s I don’t care who lands it :) | 19:13 |
| yolanda | let me check them a bit, i'm actively reviewing storyboard and storyboard-client but forgot a bit about pyhon-storyboard | 19:14 |
| yolanda | krotscheck, my normal behaviour is that if the change is done by a core as well, i give a +2 but i leave the approval to the one that created it, so he can babysit | 19:18 |
| yolanda | does this apply here? | 19:18 |
| krotscheck | I believe that the person who +A’s a thing is responsible for babysitting it :) | 19:18 |
| krotscheck | So if you don’t want to babysit it, no worries. | 19:18 |
| yolanda | gradually :) | 19:20 |
| yolanda | that's what we tend to do internally, because the one that created the change is mostly the one that knows more about it | 19:21 |
| yolanda | oh, i like how Nikita does the tests on python-storyboard, using assert_called | 19:22 |
| krotscheck | yolanda: About the delete-all-events button, I’m not certain that the browser guarantees the API query order. So if you loop over a thing that generates a lot of HTTP requests, and then issue a GET, I thinkg the user may still get some records that aren’t deleted because the HTTP Delete request has not yet finished. | 19:23 |
| *** alexismonville1 has quit IRC | 19:23 | |
| krotscheck | i.e. if you go delete delete delete delete get, the browser may actually fire delete delete get delete | 19:23 |
| yolanda | i didn't like the approach of deleting ALL event notifications because i think it's dangerous to delete something you are not seeing | 19:24 |
| krotscheck | yolanda: That’s not what I’m saying. | 19:24 |
| krotscheck | Sec, lemme pastebin something. | 19:24 |
| yolanda | mm, i follow you | 19:25 |
| yolanda | but the loadEvents() is done after all the deletes | 19:25 |
| *** reed has quit IRC | 19:26 | |
| krotscheck | yolanda: Yes, but the deletes are asynchronous and are dependent on the browser’s query queue. | 19:26 |
| yolanda | i follow what you say, yes | 19:26 |
| *** reed_ has joined #storyboard | 19:26 | |
| yolanda | so we can have a massive delete passing a list of ids | 19:26 |
| yolanda | and do a refresh when the call returns? | 19:27 |
| yolanda | have a bulkDelete method | 19:27 |
| krotscheck | yolanda: http://paste.openstack.org/show/158153/ | 19:27 |
| krotscheck | Basically, collect all the promises from the delete loop, and use $q.all() to chain the load event after all those complete. | 19:28 |
| yolanda | ah promises... | 19:28 |
| yolanda | you know far more angular than me :) | 19:28 |
| krotscheck | I’ve just been doing asynchronous programming for a bit longer :D | 19:28 |
| yolanda | what do you think about the bulkDelete, to don't overkill the api? | 19:29 |
| yolanda | instead of 25 requests, just one? | 19:29 |
| yolanda | someone can have pagination of 100 recent events... | 19:29 |
| krotscheck | I think we should implement a bulk delete api, yes :) | 19:29 |
| krotscheck | And I have thoughts on how to do that :) | 19:30 |
| yolanda | do you want me to do that prior to this change? | 19:30 |
| yolanda | what are you thinking about? | 19:30 |
| yolanda | added the tasks and the comments for the review, i will grab some time tomorrow for it, i just want to pass a list of ids and generate proper query | 19:46 |
| *** jcoufal_ has quit IRC | 19:58 | |
| *** jtomasek_ has joined #storyboard | 20:14 | |
| *** jtomasek_ has quit IRC | 20:25 | |
| *** jedimike has quit IRC | 21:26 | |
| *** MaxV has joined #storyboard | 21:48 | |
| *** mrmartin has quit IRC | 21:49 | |
| *** wuhg has joined #storyboard | 21:57 | |
| *** MaxV has quit IRC | 22:00 | |
| *** MaxV has joined #storyboard | 22:00 | |
| *** MaxV has quit IRC | 22:05 | |
| krotscheck | For this review just use the promise approach I gave you. The batch requesting we’re actually going to implement at the HTTP layer. | 22:37 |
| krotscheck | yolanda: I was thinking of emulating this in a piece of middleware: https://cloud.google.com/prediction/docs/reference/v1.6/batch | 22:38 |
| *** openstack has joined #storyboard | 23:03 | |
| *** omnibus7 has joined #storyboard | 23:06 | |
| *** zaro has joined #storyboard | 23:06 | |
| *** mordred has joined #storyboard | 23:06 | |
| *** jesusaurus has joined #storyboard | 23:06 | |
| *** phschwartz has joined #storyboard | 23:06 | |
| *** yolanda has joined #storyboard | 23:06 | |
| *** SotK has joined #storyboard | 23:06 | |
| *** ongk has joined #storyboard | 23:06 | |
| *** wendar_ has joined #storyboard | 23:06 | |
| *** tteggel_ has joined #storyboard | 23:06 | |
| *** miqui_ has joined #storyboard | 23:06 | |
| *** rcarrillocruz has joined #storyboard | 23:06 | |
| *** ttx has joined #storyboard | 23:06 | |
| *** cody-somerville has joined #storyboard | 23:06 | |
| *** openstackgerrit has joined #storyboard | 23:06 | |
| *** anteaya has joined #storyboard | 23:06 | |
| *** gothicmindfood has joined #storyboard | 23:06 | |
| *** coolsvap|afk has joined #storyboard | 23:06 | |
| *** ChanServ has joined #storyboard | 23:06 | |
| *** sendak.freenode.net sets mode: +o ChanServ | 23:06 | |
| *** lifeless has joined #storyboard | 23:07 | |
| *** openstackgerrit has quit IRC | 23:07 | |
| *** cody-somerville has quit IRC | 23:07 | |
| *** cody-somerville has joined #storyboard | 23:08 | |
| *** ruhe has joined #storyboard | 23:08 | |
| *** CTtpollard has joined #storyboard | 23:09 | |
| *** jeblair has joined #storyboard | 23:12 | |
| *** pleia2 has joined #storyboard | 23:12 | |
| *** SergeyLukjanov has joined #storyboard | 23:12 | |
| *** ctgriffiths_ has joined #storyboard | 23:12 | |
| *** NikitaKonovalov has joined #storyboard | 23:12 | |
| *** openstackgerrit has joined #storyboard | 23:13 | |
| *** krotscheck has joined #storyboard | 23:13 | |
| *** wuhg has joined #storyboard | 23:13 | |
| *** pleia2 has quit IRC | 23:34 | |
| *** pleia2 has joined #storyboard | 23:34 | |
| *** alexismonville has joined #storyboard | 23:50 | |
| *** miqui_ has quit IRC | 23:52 | |
| *** reed_ has joined #storyboard | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!