*** Piet has joined #storyboard | 00:10 | |
*** reed_ has quit IRC | 00:10 | |
*** miqui_ has joined #storyboard | 00:12 | |
*** alexismonville has quit IRC | 00:16 | |
*** omnibus7 is now known as davidlenwell | 00:49 | |
*** davidlenwell is now known as davidlenwell__ | 00:50 | |
*** davidlenwell__ is now known as davidlenwell | 00:50 | |
*** openstack has joined #storyboard | 01:36 | |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Created Subscriber Utility https://review.openstack.org/146956 | 03:09 |
---|---|---|
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 03:09 |
*** wuhg has quit IRC | 04:04 | |
*** mrmartin has joined #storyboard | 05:39 | |
*** alexismonville has joined #storyboard | 06:10 | |
*** alexismonville has quit IRC | 06:31 | |
*** alexismonville has joined #storyboard | 06:39 | |
*** wuhg has joined #storyboard | 07:00 | |
*** petefoth has joined #storyboard | 07:27 | |
*** jtomasek_ has joined #storyboard | 07:41 | |
*** mrmartin has quit IRC | 07:49 | |
*** jtomasek_ has quit IRC | 08:31 | |
*** jtomasek has joined #storyboard | 08:35 | |
*** jtomasek has quit IRC | 08:50 | |
*** wdutch has joined #storyboard | 09:02 | |
*** coolsvap|afk is now known as coolsvap | 09:03 | |
openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Add button to remove all recent events in dashboard https://review.openstack.org/147105 | 09:13 |
*** jtomasek has joined #storyboard | 09:15 | |
*** MaxV has joined #storyboard | 09:24 | |
*** MaxV has quit IRC | 09:34 | |
*** MaxV has joined #storyboard | 09:35 | |
*** MaxV has quit IRC | 09:37 | |
*** MaxV has joined #storyboard | 09:37 | |
*** jcoufal has joined #storyboard | 09:38 | |
*** ilyashakhat has joined #storyboard | 09:39 | |
*** MaxV has quit IRC | 09:40 | |
*** MaxV_ has joined #storyboard | 09:40 | |
*** MaxV_ has quit IRC | 09:41 | |
*** wuhg has quit IRC | 09:54 | |
*** jedimike has joined #storyboard | 09:55 | |
*** MaxV has joined #storyboard | 09:59 | |
ttx | yolanda: around? | 10:39 |
yolanda | ttx yes | 10:40 |
ttx | yolanda: About the may_mutate_to list -- how would you implement it ? With a specific table ? | 10:40 |
yolanda | specific table looks correct to me | 10:41 |
yolanda | alternative option should be a text storing a set of separated values or a json | 10:41 |
ttx | ok | 10:41 |
* ttx adds it to story types spec | 10:41 | |
yolanda | great | 10:41 |
ttx | done @ https://review.openstack.org/#/c/129267/ | 10:55 |
ttx | yolanda: ^ | 10:55 |
yolanda | thx ttx, taking a look | 10:55 |
*** petefoth has left #storyboard | 10:56 | |
yolanda | ttx, i miss the description of UI or administration of that | 10:57 |
yolanda | we need to be able to define the story type, with settings, status they can mutate? | 10:57 |
yolanda | do you think it's worth adding that as well? | 10:57 |
ttx | yolanda: I would rather leave that part to whoever would implement it | 10:57 |
yolanda | ok | 10:57 |
yolanda | i think that specs gives us freedom for all types of workflows now | 10:58 |
ttx | yolanda: I don't expect the types to change that much once they are defined | 10:58 |
ttx | so a UI could be overkill | 10:58 |
ttx | or at least, could be low priority | 10:59 |
yolanda | just feeding data in the databse initially? | 10:59 |
ttx | or use the APi to do it | 10:59 |
ttx | we'll need at least one type in there | 10:59 |
ttx | or you won't be able to do much | 11:00 |
yolanda | yes, initial data is needed | 11:00 |
ttx | but it's an implementation detail imho | 11:00 |
yolanda | +1 on it | 11:01 |
ttx | I'm fine with the implementer refining the spec's implementation section | 11:01 |
yolanda | ttx, talking about specs, i created the one for duplicates https://review.openstack.org/147253 | 11:01 |
ttx | since I'll likely not do the work, I'd rather not be too prescriptive there :) | 11:01 |
ttx | yeah, I'm about to review it | 11:01 |
yolanda | low priority but i think it's useful | 11:02 |
* yolanda whishes to have more time to actually work on the project | 11:03 | |
yolanda | ttx, saw your comments. The latest one is just caused by spec being copy/pasted from another | 11:22 |
yolanda | :) | 11:22 |
yolanda | i will review that with care | 11:22 |
yolanda | i filed the spec with a bugfix, but i'm on you on the story relationships | 11:43 |
*** mase_x200 has joined #storyboard | 12:42 | |
*** alexismonville has joined #storyboard | 13:04 | |
*** mattfarina has joined #storyboard | 14:18 | |
*** coolsvap is now known as coolsvap|afk | 14:55 | |
*** mase_x200 has quit IRC | 15:04 | |
*** CTtpollard has quit IRC | 15:26 | |
*** jcoufal_ has joined #storyboard | 15:30 | |
*** jcoufal has quit IRC | 15:33 | |
*** jcoufal_ has quit IRC | 15:40 | |
*** CTtpollard has joined #storyboard | 15:41 | |
*** jcoufal has joined #storyboard | 15:45 | |
*** jtomasek has quit IRC | 16:19 | |
yolanda | hi Krotscheck | 16:37 |
krotscheck | Hey! | 16:37 |
yolanda | i would just raise an exception if templates don't exist | 16:37 |
krotscheck | yolanda: Gotcha. That’s what it does already. | 16:37 |
krotscheck | yolanda: But I can add a few tests to assert that. | 16:38 |
yolanda | so the get_template raises an exception? | 16:38 |
yolanda | i may be missing something, i was looking at the env.get_template method | 16:39 |
openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Send a 400 error code when duplicate user is created https://review.openstack.org/147915 | 16:43 |
krotscheck | yolanda: Yep, i don’t recall where the exception is thrown though, it’s a few layers down. | 16:47 |
krotscheck | yolanda: I’ll add some tests to assert that, it’ll make it clearer. | 16:47 |
yolanda | ah ok, i was just looking for sanity checks as the others, but it's ok for me if that is thrown later | 16:47 |
yolanda | i wanted to avoid empty emails being sent | 16:48 |
*** mrmartin has joined #storyboard | 16:49 | |
*** mrmartin has quit IRC | 16:54 | |
yolanda | krotscheck, i was looking at the "story with no task is not being shown" | 16:56 |
yolanda | actually it shows but with invalid status | 16:56 |
yolanda | is that what we are expecting? | 16:56 |
krotscheck | yolanda: I think I may have fixed that when I dropped that big search patch a while ago. | 16:57 |
krotscheck | yolanda: Wait, no. There was another one where I changed the key that we were grouping on. | 16:57 |
krotscheck | yolanda: And yeah, now that I think about it, it’s totally accurate. | 16:58 |
krotscheck | yolanda: What do yo uthink? | 16:58 |
yolanda | it was confusing by me until i reached the code | 16:58 |
yolanda | because initially we are filtering by "active" status | 16:58 |
yolanda | what i would do is raise an alert if someone tries to remove the unique task of a story | 16:59 |
yolanda | because well, initially all stories have one task, right? | 16:59 |
krotscheck | yolanda: That makes sense. | 17:00 |
* krotscheck needs to wear a suit to work more often. | 17:01 | |
yolanda | i will allow to remove the task but i will popup a modal alerting of the thing and telling that the story is going to be considered invalid, something like that... | 17:01 |
krotscheck | perfect | 17:02 |
yolanda | krotscheck, what are you doing with suit?! | 17:02 |
*** CTtpollard has quit IRC | 17:02 | |
krotscheck | yolanda: Oh, I just feel way more awesome and productive right now. | 17:02 |
yolanda | :) | 17:03 |
yolanda | i don't feel any productive on a friday afternoon... | 17:07 |
*** mrmartin has joined #storyboard | 17:13 | |
*** MaxV has quit IRC | 17:17 | |
*** yolanda has quit IRC | 17:30 | |
*** yolanda has joined #storyboard | 17:30 | |
*** wdutch has quit IRC | 17:53 | |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 18:04 |
*** alexismonville has quit IRC | 18:20 | |
*** jcoufal has quit IRC | 18:41 | |
*** jcoufal has joined #storyboard | 18:54 | |
*** jcoufal has quit IRC | 18:55 | |
*** mrmartin has quit IRC | 20:11 | |
*** wendar_ is now known as wendar | 20:38 | |
*** mattfarina has quit IRC | 22:11 | |
*** openstackgerrit has quit IRC | 23:19 | |
*** openstackgerrit has joined #storyboard | 23:19 | |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Created Subscriber Utility https://review.openstack.org/146956 | 23:31 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Explicit Event API https://review.openstack.org/145874 | 23:31 |
*** jedimike has quit IRC | 23:42 | |
openstackgerrit | Merged openstack-infra/python-storyboardclient: Setting up base classes https://review.openstack.org/138092 | 23:44 |
openstackgerrit | Merged openstack-infra/python-storyboardclient: Update method improved https://review.openstack.org/146840 | 23:44 |
krotscheck | To what extend to we want ot force class documentation on methods in python-storyboardclient? I feel that as a developer, I often read the code of my clients directly, and thus the method documentation is my primary source of figuring out what something does and/or how it does it. | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!