| *** jamesmcarthur has joined #storyboard | 00:15 | |
| *** anteaya has quit IRC | 00:37 | |
| *** jamesmcarthur has quit IRC | 01:02 | |
| *** jamesmcarthur has joined #storyboard | 01:06 | |
| *** jamesmcarthur has quit IRC | 01:07 | |
| *** jamesmcarthur has joined #storyboard | 01:08 | |
| *** jamesmca_ has joined #storyboard | 01:10 | |
| *** jamesmcarthur has quit IRC | 01:12 | |
| *** jamesmca_ has quit IRC | 01:15 | |
| *** francoblanco has quit IRC | 05:23 | |
| *** betherly has quit IRC | 05:23 | |
| *** sparkycollier has quit IRC | 05:24 | |
| *** zaro has quit IRC | 05:25 | |
| *** jjardon has quit IRC | 05:25 | |
| *** sparkycollier has joined #storyboard | 05:28 | |
| *** zaro has joined #storyboard | 05:32 | |
| *** francoblanco has joined #storyboard | 05:33 | |
| *** jjardon has joined #storyboard | 05:33 | |
| *** betherly has joined #storyboard | 05:37 | |
| *** betherly has quit IRC | 06:08 | |
| *** betherly has joined #storyboard | 06:12 | |
| betherly | Morning!! | 07:32 |
|---|---|---|
| *** jtomasek_ has joined #storyboard | 07:39 | |
| *** alexismonville has joined #storyboard | 07:47 | |
| SotK | morning! | 07:53 |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** openstackgerrit has joined #storyboard | 08:03 | |
| *** jtomasek_ has quit IRC | 08:05 | |
| *** jtomasek_ has joined #storyboard | 08:38 | |
| *** jtomasek_ has quit IRC | 09:03 | |
| Zara | morning! | 09:04 |
| *** bethwhite has joined #storyboard | 09:06 | |
| Zara | oh, that's lovely, and a big improvement; you even have different icons for story changes vs task-changes! and I like the simplicity of making comments stand out via the branding colour (though I still think collapsibility should be an option for non-comment-things) | 09:15 |
| Zara | (finally saw wip patch :) | 09:15 |
| SotK | is collapsibility something more than changing your preferences? | 09:16 |
| Zara | (I understand that this patch is just about how the list looks, so we shouldn't expect auto-loading or anything now; please correct me if wrong) | 09:16 |
| Zara | well in the past there was a story for having just comments show by default, with a 'show all' button to give the full list, which I liked | 09:17 |
| Zara | so yeah, preference-changing, but not in the place we currently change it | 09:17 |
| Zara | but on the list itself to quickly toggle between 'just comments' and 'full events timeline'. | 09:17 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: WIP: Rework timeline events into a timeline https://review.openstack.org/327231 | 11:21 |
| SotK | dmsimard: I tried to implement your suggestions in that new version ^ | 11:22 |
| *** alexismonville has quit IRC | 11:49 | |
| dmsimard | SotK: awesome, I'll look, thanks! | 12:01 |
| pedroalvarez | SotK: wow, that timeline looks lovely | 12:11 |
| * pedroalvarez sees the pagination of the timeline in: http://docs-draft.openstack.org/31/327231/4/check/gate-storyboard-webclient-js-draft/4c25690//dist/#!/story/11 | 12:12 | |
| pedroalvarez | "NaN to 13 of 13" | 12:12 |
| pedroalvarez | also, tried to modify one task: 400: GET https://storyboard-dev.openstack.org/api/v1/stories/11/events: Invalid input for field/attribute offset. Value: 'NaN'. unable to convert to int | 12:13 |
| SotK | yeah, the docs-draft breaks pagination on every patch for some reason | 12:13 |
| pedroalvarez | grr | 12:13 |
| pedroalvarez | wasn't aware of that | 12:13 |
| SotK | the task will still be modified, its just reloading the events that failed | 12:14 |
| SotK | me neither until yesterday when I looked at my timeline patch :( | 12:14 |
| Zara | hm, looking at the wip, I've noticed that task status seems to not be coloured in when a user is logged out. I doubt that's just on the wip | 12:38 |
| betherly | SotK: Zara: sorry took sooooo long to get round to it but about to put up a new patch for a proposed favicon | 12:38 |
| Zara | hahaha, I like the favicon saga | 12:38 |
| pedroalvarez | betherly: that was my request :) nothing to worry about, really | 12:42 |
| pedroalvarez | and sorry if the favicon saga is distracting you from doing other more-important things | 12:42 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add a cancel button to the Add Tag text box https://review.openstack.org/325904 | 12:43 |
| betherly | pedroalvarez: no dont worry on that at all. im taking a break from bashing my head against the desk | 12:44 |
| SotK | Zara: doesn't happen on my test instance | 12:44 |
| Zara | maybe it's a browser thing again | 12:45 |
| SotK | http://docs-draft.openstack.org/31/327231/4/check/gate-storyboard-webclient-js-draft/4c25690//dist/#!/story/10 looks right to me too | 12:47 |
| Zara | ohhh, my mistake | 12:47 |
| Zara | it's because 'todo' and 'invalid' were the same | 12:47 |
| Zara | so it looked like it wasn't picking up on differences | 12:48 |
| SotK | \o/ | 12:49 |
| Zara | maybe that should change, but I'm not too fussed and it's not urgent | 12:49 |
| Zara | eh, if someone else gets confused later | 12:49 |
| openstackgerrit | Beth Elwell proposed openstack-infra/storyboard-webclient: New Favicon https://review.openstack.org/327639 | 12:52 |
| Zara | hm, timeline seems not to know when story description changes... I thought it knew but didn't give a useful description? | 12:52 |
| * pedroalvarez gets excited and opens ^ link five times | 12:53 | |
| Zara | ahh no it's only showing the first 10 things, I thought it was showing all as pagination was broken | 12:54 |
| * Zara picks a different story to test with | 12:54 | |
| Zara | ace | 12:54 |
| pedroalvarez | betherly: nice! | 12:56 |
| pedroalvarez | any other opinions/bikesheeding? | 12:56 |
| persia | betherly: So, from curiosity, why push the favicon to a new change, rather than taking over the old change? I feel like I'm missing something cultural here. | 12:56 |
| betherly | persia: krotscheck abandoned the old one | 12:57 |
| persia | Ah, so the normal thing to do is take over unabandoned changes, but not take over abandoned changes? | 12:57 |
| Zara | I think it's clearer to see what it is than the old propoesd one, but possibly looks a bit like a refresh wheel from a distance (the pin and corner-fold look a little like they're arrows), but I wouldn't know how to fix that | 12:59 |
| persia | I actually really like the new one: I just had trouble digging about for the old one (mostly because I didn't read the commit message carefully enough), hence my question. | 13:00 |
| Zara | ^ me provides bikeshed as requested | 13:00 |
| * SotK thinks its great | 13:01 | |
| pedroalvarez | yay! | 13:02 |
| pedroalvarez | nothing has been triggered in zuul, btw | 13:03 |
| betherly | awesome glad people like it! | 13:03 |
| betherly | re Zara's point would it work better if the pin was more central and upright rather than where it is? | 13:04 |
| Zara | I have no idea, unfortunately, I'd only know after seeing it. BUT also my motivation for this is just to have a different icon from the standard | 13:05 |
| Zara | so that I can tell if my tab is the docs page | 13:05 |
| Zara | or a storyboard instance | 13:05 |
| Zara | so I'm not too fussed about how it looks for my own purposes xD | 13:05 |
| pedroalvarez | that's the main point, yes | 13:05 |
| Zara | I was just asked to bikeshed and wanted to make sure I bikeshedded appropriately | 13:05 |
| Zara | idealllly it'd derive its colour from branding, so I could distinguish between different storyboard instances | 13:06 |
| Zara | but is that even possible? | 13:06 |
| pedroalvarez | that might be over-complicated | 13:06 |
| SotK | definitely over-complicated | 13:06 |
| Zara | yes, especially as very few people have multiple instances | 13:07 |
| SotK | if people want to brand their own icon, they can edit the icon | 13:07 |
| Zara | mainly giving context on my use case and why I cared about it | 13:07 |
| Zara | which isn't the same as 'you should do this' xD | 13:07 |
| betherly | ok cool :) | 13:10 |
| betherly | Ye probably having different colours like that is a bit over complicated really | 13:11 |
| Zara | just a bit ;) | 13:14 |
| dmsimard | SotK: the tag/status/priority changes are welcome :) | 13:40 |
| dmsimard | I don't know if it's in the scope of that review | 13:40 |
| * SotK thinks they may as well be there since he already had to basically rewrite the template | 13:43 | |
| dmsimard | I think I'd do away with the relative duration since the event (i.e, 5 minutes ago) in favor of timestamps. Maybe there could be some alt text over the timestamp for the relative duration, it's still useful information. Timestamps should probably be left aligned since the length of the timestamp will be the same and it'd make that information easy to find. | 13:43 |
| Zara | the style of representing time shouldn't changed in that patch; it's a separate thing, across storyboard | 13:44 |
| dmsimard | Ack :) | 13:44 |
| SotK | yeah, that's roughly my plan (hence the nonsensical "on 3 hours ago" at the moment) | 13:44 |
| Zara | in that it's better to keep it consistent. | 13:44 |
| Zara | because we get requests for different types of displays from different people | 13:45 |
| SotK | its already inconsistent in fairness | 13:45 |
| *** alexismonville has joined #storyboard | 13:45 | |
| pedroalvarez | favicon visible at: http://docs-draft.openstack.org/39/327639/1/check/gate-storyboard-webclient-js-draft/6688ac2//dist/#!/dashboard/stories | 13:46 |
| Zara | :) my understanding is that that patch is for making it easier for a user to see which fields in the events timeline are relevant. | 13:46 |
| dmsimard | I'm no UI/UX expert, just giving feedback when I have the opportunity to. I think information that is "standard" across all events should be found at the same place on every line so they can easily be compared. | 13:46 |
| Zara | so I'm wary of the timestamps discussion to hold up that patch, because this is a case where different parties clash | 13:46 |
| dmsimard | I'm going to add my project to storyboard soon | 13:46 |
| SotK | I was contemplating putting the dates on the left hand side of the timeline circle things at one point | 13:46 |
| dmsimard | btw, I happened to browse storyboard on my cellphone last night | 13:47 |
| dmsimard | and there are some quirks here and there | 13:47 |
| dmsimard | but I really appreciate that it works mostly well | 13:47 |
| SotK | :) | 13:47 |
| Zara | hah, storyboard on phones is an exciting adventure... | 13:48 |
| dmsimard | it's probably far from being a priority but it's nice that it mostly "just works" | 13:48 |
| SotK | yeah, I use it on my phone occasionally but fixing the weird bits of that use-case isn't a priority for me right now | 13:48 |
| Zara | some context on timestamps specifically, and why I would much rather silo that discussion: https://storyboard.openstack.org/#!/story/2000397 vs https://storyboard.openstack.org/#!/story/2000639 | 13:49 |
| Zara | so if it's already inconsistent, I'm happy with however sotk wants to represent it there, I don't want that patch to be the place where people discuss the representation :P | 13:54 |
| dmsimard | Zara: fair | 13:54 |
| SotK | I'm at least going to stop it being "3 hours ago" because I also find that annoying | 13:55 |
| SotK | especially when my computer's time is out of sync with the server, and I get "in 2 minutes" | 13:55 |
| dmsimard | LOL | 13:55 |
| Zara | pffft, that's the best feature | 13:55 |
| SotK | oh, I think I made that be a timestamp already actually | 13:56 |
| SotK | but then it switches to "a few seconds ago" after a couple of minutes | 13:56 |
| Zara | and yeah, it's such a pretty patch; I don't want to hold it up! I should be sad that I didn't get to it, but I'm glad it ended up being you because mine would be nowhere near as pretty | 13:58 |
| SotK | :) | 14:00 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: WIP: Remove pagination for timeline events https://review.openstack.org/327682 | 14:00 |
| dmsimard | with pagination removed and the new timeline | 14:04 |
| dmsimard | it's really good | 14:04 |
| dmsimard | keep on rocking. | 14:04 |
| *** Zara has quit IRC | 14:04 | |
| *** zara_the_lemur__ has joined #storyboard | 14:06 | |
| *** alexismonville has quit IRC | 14:06 | |
| SotK | :) | 14:07 |
| SotK | thanks | 14:07 |
| zara_the_lemur__ | (so I'm not saying that I tried to do a comedy mockup of my idea of an events timeline on an online paint program, saved it, got one of those really long urls that crashes your terminal, and am now waiting for it to calm down, but that might've happened) | 14:07 |
| SotK | this is why you do it on an offline paint program, and upload it to imgur :) | 14:08 |
| zara_the_lemur__ | yeah, normally I do that... but I wondered if there were a decent online one | 14:08 |
| zara_the_lemur__ | there isn't | 14:08 |
| zara_the_lemur__ | how likely are we to get loads of events to the point where things slow down? | 14:09 |
| dmsimard | There you go: https://review.openstack.org/#/c/327693/ :) | 14:09 |
| zara_the_lemur__ | \o/ | 14:10 |
| SotK | nice :D | 14:10 |
| SotK | zara_the_lemur__: define "things slow down" | 14:10 |
| * zara_the_lemur__ awaits the pitchforks | 14:10 | |
| *** Zara has joined #storyboard | 14:10 | |
| Zara | oh hi me | 14:11 |
| * SotK is intending to implement the preference filtering in the backend which should mitigate that a little with better defaults | 14:11 | |
| Zara | so, aiui we don't have unlimited results displayed for stories et al, as with a large quantity of results, storyboard slows down loads | 14:11 |
| SotK | correct | 14:11 |
| SotK | well, the response takes ages to arrive | 14:11 |
| Zara | so... just that. I didn't have any clearer an idea of it in my head | 14:12 |
| SotK | shouldn't actually cause much global slowdown unless we're under heavy load I imagine | 14:12 |
| SotK | so, if a story gets to a few hundred comments/events it'll start loading noticably slowly I expect | 14:13 |
| Zara | yeah, I'm wondering how likely that actually is | 14:13 |
| Zara | I can see it happening with events, less likely for comments | 14:14 |
| Zara | but it might be worth looking at gerrit threads for the busier projects | 14:14 |
| Zara | https://storyboard.openstack.org/#!/story/2000175 is on 189 | 14:15 |
| Zara | I would imagine nova could be significantly higher | 14:15 |
| SotK | we should look at launchpad | 14:15 |
| Zara | ah, that's a better idea than looking at gerrit, yeah | 14:16 |
| SotK | we can't paginate easily if we want permalinks or non-annoying commenting | 14:16 |
| SotK | at least, I haven't thought of a way | 14:17 |
| SotK | and have been thinking about it for ages | 14:17 |
| Zara | so is there another way to ameliorate the slowdown? | 14:18 |
| Zara | I think in practice it'll just discourage people from going on bigger stories... well, maybe that's fine. :P but it might encourage people to ignore history. | 14:19 |
| SotK | if we set the default preferences to only include interesting events and filter on the server-side it'll probably be ok unless someone asks to see the whole lot | 14:20 |
| Zara | okay, if we're relying on that I think we should try to avoid 'see the whole lot' ever being settable as a default | 14:27 |
| Zara | otherwise we could get a repeat of zaro's battle with recent events | 14:28 |
| Zara | well, maybe not. I'm still not sure what numbers to expect. | 14:28 |
| persia | Would it be possible to consume the response as it is arriving, rather than waiting until it has all arrived? | 14:30 |
| SotK | perhaps, but I'm not sure if promises work like that off the top of my head | 14:32 |
| SotK | also, can we please merge https://review.openstack.org/#/c/325196/ ? | 14:32 |
| zaro | i’m in battle? | 14:40 |
| Zara | zaro: ahaha, I meant when your dashboard was frozen and crashing, before we merged that patch at the summit | 14:42 |
| persia | SotK: +1 | 14:42 |
| Zara | I could see users getting into a similar situation with timeline events. | 14:42 |
| zaro | Zara: ahh yes, i don’t think task transitions will be a big burden to SB, comments will probably much larger volume. | 14:44 |
| zaro | i was probably generating a ton of events for myself while testing the integration | 14:55 |
| Zara | yeah, it might not be so bad even if there are loads of events, as users (currently) don't have to go to any story when they log in... though it could be different if we implemented something like 'go to last story visited whenever you log in' | 14:57 |
| Zara | then they might get stuck if they were using a story as a testing ground | 14:58 |
| Zara | worst case, we patch it later, I just know to keep an eye on it now | 14:59 |
| SotK | that would be very annoying for me | 14:59 |
| SotK | I'd be surprised if we had a story with as many events as zaro had | 15:00 |
| pedroalvarez | story number 42, I'm sure :) | 15:02 |
| Zara | xD | 15:10 |
| Zara | that was task 42! | 15:10 |
| Zara | though yeah, I was thinking of cases where someone was testing using storyboard-dev and effectively locked themselves out. which is a weird corner-case, but I'm wondering if it means there are less weird cases that I haven't thought of yet. | 15:11 |
| Zara | oh yeah, https://review.openstack.org/#/c/325247/ is blocked because of linting rules, not because it needs a recheck | 15:23 |
| SotK | grrr | 15:25 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Only update changed fields when editing tasks https://review.openstack.org/325247 | 15:25 |
| Zara | sorry, I left a message on the thread the other day, but gerrit sends a lot of emails so... | 15:27 |
| Zara | thank you :) | 15:28 |
| *** anteaya has joined #storyboard | 16:09 | |
| *** alexismonville has joined #storyboard | 16:26 | |
| anteaya | Zara: thanks for reading my story https://storyboard.openstack.org/#!/story/2000639 the timeline says you edited the story but I don't see what you edited | 16:33 |
| anteaya | and I agree the timeline tuneup patch was the motivation for the timestamps conversation but should not be held up by it | 16:34 |
| anteaya | and it is a shame jim and Paul seem to be taking opposite opinions on this issue, I see no point trying to put energy into working for convergence here | 16:35 |
| anteaya | would it be possible to make time output be a configured by a global setting that a storyboard admin could set for a given instance? | 16:36 |
| anteaya | that way Paul's instance could have it his way 'just rationalise to one timezone and be done' which works really well when all users are in the same timezone and the infra instance could have it infra's way, which is the preference for users in many timezones | 16:37 |
| *** alexismonville has quit IRC | 16:37 | |
| SotK | I think we would be better making it per-user configurable | 16:40 |
| SotK | maybe with a per-server default configurable | 16:41 |
| pedroalvarez | these things are normally per-user configurable in other places, ime | 16:43 |
| Zara | ah, the project was changed in that story, from storyboard to storyboard-webclient, since it's a web ui issue. the timeline should say that and doesn't. there might even be a task for that somewhere. :D | 16:45 |
| Zara | https://review.openstack.org/#/c/320516/ is failing the lint check, I'm not sure if it's a problem with lint rules or not | 16:46 |
| anteaya | SotK: I don't think infra would like per user | 16:46 |
| anteaya | per server would work fine | 16:46 |
| anteaya | Zara: ah thank you | 16:46 |
| SotK | Zara: doesn't look like it's a lint issue | 16:46 |
| Zara | it says 'callback called more than once' but no line is cited and it seems a bit strange | 16:46 |
| anteaya | yes I do just set everything to storyboard since I don't know if that is right or not, thanks for fixing that | 16:46 |
| Zara | yeah | 16:47 |
| SotK | anteaya: then infra could set a server-wide default, and leave their timestamps as the default | 16:47 |
| SotK | I don't think its good UX to force a certain format on people who find it harder to read than other formats | 16:47 |
| SotK | especially when we format the dates dynamically anyway | 16:47 |
| anteaya | fungi: since the utc timestamps storyboard issue is a direct clash with the codethink person who is funding the code think developers, we could live with a per server config of timestamps, yeah? | 16:48 |
| SotK | since at that point we are essentially making it hard for those people deliberately | 16:48 |
| anteaya | fungi: and then codethink instances could have time be displayed the way the codethink people like it to be | 16:48 |
| SotK | ftr, I'm happy to make the default server-default be a proper timestamp | 16:48 |
| Zara | (np, in general if you've encountered it in the web ui, then it's likely to be a web ui issue. sometimes there's an api change that's needed too. but I periodically go through and tidy up anyway.) | 16:48 |
| anteaya | SotK: oh thank you, I would like that very much | 16:48 |
| anteaya | Zara: awessome, thank you, I will do my best and thank you for tidying up behind me | 16:49 |
| anteaya | Zara: you do a great job | 16:49 |
| fungi | anteaya: SotK: seems like it could be made a user preference pretty easily? with a deployment default state that's configurable too if you want | 16:49 |
| SotK | that was what I was suggesting we do, yeah | 16:50 |
| anteaya | fungi: jeblair had said that some things he didn't want on a per user basis, like timeline config, which is why I asked for per server here | 16:50 |
| anteaya | fungi: but your call | 16:50 |
| anteaya | fungi: and thank you | 16:50 |
| fungi | user preference would entirely solve it for us i think, since people could decide themselves whether they want relative or absolute times (and possibly whether they want them translated into their browser's timezone or have it reported in utc) | 16:51 |
| fungi | not sure what jeblair's concern was over making it a user preference | 16:52 |
| SotK | I thought he just wanted better defaults? | 16:52 |
| fungi | but if the default can be set globally for the server, that gives us the ability to default to absolute times on storyboard.o.o and let individual users there still select relative times if they want them | 16:52 |
| anteaya | fungi: okay can you take a peek at https://storyboard.openstack.org/#!/story/2000620 | 16:53 |
| fungi | can in a bit once i free up | 16:53 |
| anteaya | fungi: Jim said "Yes, the problem with the red gear is that it requires users to perform an action in order to see important information which is normally hidden. Users often have no idea there are relevant comments buried on "page 5" of the timeline past all of those "foo did bar" entries." | 16:53 |
| anteaya | fungi: yes, thanks | 16:53 |
| anteaya | fungi: and in irc he said he doesn't feel that users should be required to set things that should be the same for the whole instance (my paraphrase) | 16:54 |
| anteaya | http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2016-06-03.log.html#t2016-06-03T16:45:41 | 16:55 |
| SotK | that is what I read as him wanting better defaults, rather than wanting to remove the user choice altogether | 16:56 |
| anteaya | so I'm fine with whatever Jim will accept here | 16:56 |
| anteaya | SotK: agreed | 16:56 |
| * SotK disappears | 16:57 | |
| fungi | anteaya: oh, yes it looks like that was a discussion about pagination defaults, so i don't read that as necessarily meaning that he'd object to needing to adjust a (persistent) user preference once to get absolute times in all timelines instead of relative times. but i also agree (as someone who prefers absolute to relative) that having the ability to set absolute as a server-wide default would help | 17:04 |
| anteaya | fungi: okay thanks, I appreciate you looking and understanding the interpretation I took based on that conversation | 17:05 |
| anteaya | and also willing to declare what we can live with as ptl | 17:05 |
| anteaya | SotK: so whatever makes fungi happy and thank you | 17:06 |
| *** bethwhite has quit IRC | 17:16 | |
| *** zara_the_lemur__ has quit IRC | 18:05 | |
| *** jjardon has quit IRC | 18:12 | |
| *** jjardon has joined #storyboard | 18:17 | |
| *** jjardon has quit IRC | 18:22 | |
| *** jjardon has joined #storyboard | 18:22 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Create a StoryBoard gui manual https://review.openstack.org/325474 | 18:23 |
| *** jamesmcarthur has joined #storyboard | 22:49 | |
| *** jamesmcarthur has quit IRC | 22:53 | |
| *** jamesmcarthur has joined #storyboard | 22:59 | |
| *** jamesmcarthur has quit IRC | 23:08 | |
| *** jamesmcarthur has joined #storyboard | 23:17 | |
| *** jamesmcarthur has quit IRC | 23:22 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!