*** davidlenwell has quit IRC | 04:37 | |
*** davidlenwell has joined #storyboard | 04:49 | |
*** jtomasek has joined #storyboard | 07:28 | |
*** bethwhite_ has joined #storyboard | 08:41 | |
*** zara_the_lemur has joined #storyboard | 09:23 | |
zara_the_lemur | gah, turned my computer on; it didn't have enough power and turned off again. have plugged it in but it's not letting me turn it on yet (hopefully it will in a bit) | 09:24 |
---|---|---|
zara_the_lemur | (not writing this telepathically; have other systems, but they're not so good for storyboard development) | 09:24 |
zara_the_lemur | yay hard reset worked | 09:30 |
*** zara_the_lemur has quit IRC | 09:31 | |
*** openstackstatus has quit IRC | 10:28 | |
*** yarkot1 has quit IRC | 11:00 | |
*** yarkot has quit IRC | 11:04 | |
*** yarkot has joined #storyboard | 11:20 | |
*** yarkot1 has joined #storyboard | 11:20 | |
*** alexismonville has joined #storyboard | 11:32 | |
Zara | just trying to break my scripts | 11:51 |
*** alexismonville has quit IRC | 11:51 | |
Zara | discovered that if the last story in your instance has been deleted, the 'make stories with tasks' one won't play nice | 11:51 |
Zara | because IDs aren't reused on story deletion | 11:52 |
persia | For the examples, maybe it is better to do it the awkward way (create a story in one request, add tasks in the next request) ,rather than trying to do it all at once. | 11:53 |
Zara | yeah, that would work. you'd just repeat the query to get the new highest story id, instead of guessing that it's the old one +1. | 11:53 |
Zara | it's a bit of a corner case anyway but I'd rather the script not have a chance of giving someone a strange 404 | 11:54 |
Zara | though the danger of that is if someone else creates a story midway through | 11:54 |
Zara | and then the tasks would get assigned to that one instead | 11:54 |
* SotK suspects that it might be useful for the python client library to provide some helper method for creating a story with tasks in one go | 11:55 | |
Zara | though you could just get the id of the thing you'd just made. | 11:55 |
SotK | the POST request should return the thing it created | 11:55 |
Zara | yeah | 11:56 |
Zara | (for all I know there is a helper method and I just failed to find it.) | 11:56 |
Zara | I was just thinking out loud, sorry :P | 11:56 |
* SotK has never noticed one if there is | 11:56 | |
Zara | I'm debating the wisdom of documenting deletes at all. I feel like someone can easily work it out if they need to, but it might not be a good idea to put something down that folks can copy-paste with ease. | 12:02 |
persia | I think the best path is to document archival, and not deletes. | 12:13 |
persia | deletion? | 12:13 |
* persia fails at grammar | 12:13 | |
persia | Ah. "removal". yes. | 12:13 |
Zara | :) | 12:13 |
Zara | looking at the db, they seem to be removed. | 12:16 |
persia | I believe that is the API response to HTTP DELETE. | 12:16 |
persia | I thought there was a separate way to indicate whether a story was archived or not. | 12:17 |
Zara | (at any rate, they're not in the 'stories' table) yeah, it isn't always so wanted to check, but we're the ones who shifted it towards archival | 12:17 |
Zara | that was for worklists/boards | 12:17 |
persia | Documenting that folk should update the archive bit is probably more useful, as otherwise I think folk will just use DELETE. | 12:17 |
persia | I thought tasks could also be archived. Hrmm. | 12:17 |
persia | Well, nevermind. I do not believe it should be possible to actually remove anything from the API, and that DELETE should archive records, but I understand that mine is a minority view. | 12:18 |
persia | So perhaps I'm just suggesting that not documenting deletion clearly is probably not something to consider a critical issue :) | 12:19 |
Zara | I think tasks just aren't deleted when stories are deleted. | 12:19 |
* persia ponders the idea of a means to express negative priorities: of a set of tasks, which is most important to not do? | 12:19 | |
Zara | so they end up 'archived' by virtue of persisting when a story is deleted unless they're explicitly removed separately | 12:19 |
persia | I also think tasks are not deleted when stories are deleted. | 12:19 |
Zara | (in practice nobody does it, so they stick around.) | 12:20 |
persia | I further suspect comments, etc. are not deleted. | 12:20 |
Zara | also I would much prefer to archive over delete, just not a high priority. does mean anyone using sb should be keeping backups | 12:21 |
Zara | but I'm mentioning it here so that people know why I think we shouldn't document doing deletes with the client, and avoid going 'hm, this is missing, I'll add this' (or +1ing a patch for the same) | 12:22 |
Zara | (and I will remove the corresponding lines for 'TODO' in the docs now) | 12:23 |
SotK | persia: I agree with your view :) | 12:39 |
openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Update 'usage' https://review.openstack.org/372454 | 12:39 |
Zara | (very small patch; I noticed some other things were missing) | 12:44 |
Zara | oh lol I should be using docstrings in those examples... | 12:46 |
openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Add some sample pythonclient scripts https://review.openstack.org/371620 | 13:00 |
Zara | turned out they needed some other fixes. | 13:00 |
*** alexismonville has joined #storyboard | 13:02 | |
Zara | (I'm going to go through and do docstring things now. I err on the side of posting to review more often, so that things are in public asap and is safe if my laptop suddenly sets on fire or something. so I'll update that patch again in a minute. The one before it should be ready for review, though. | 13:02 |
Zara | ) | 13:02 |
Zara | s/is/are/ | 13:02 |
Zara | (all my comments in those examples are inconsistent with the project style (mine are above the code, and use #; figure they should be below and use '''').) | 13:04 |
Zara | irritating thing to notice after the fact. | 13:04 |
Zara | *""" | 13:05 |
Zara | oh actually, our codebase is inconsistent | 13:07 |
Zara | eh if it doesn't matter, ace | 13:07 |
Zara | <_< >_> nobody heard me say that. | 13:07 |
Zara | guess that's ready for review, then, anyway. | 13:09 |
*** alexismonville has quit IRC | 13:58 | |
*** alexismonville has joined #storyboard | 14:03 | |
*** openstackgerrit has quit IRC | 14:37 | |
*** openstackgerrit has joined #storyboard | 14:37 | |
*** alexismonville has quit IRC | 16:04 | |
*** alexismonville has joined #storyboard | 16:07 | |
*** alexismonville has quit IRC | 16:35 | |
*** yarkot1 has quit IRC | 16:57 | |
*** bethwhite_ has quit IRC | 17:54 | |
*** bethwhite_ has joined #storyboard | 17:57 | |
*** bethwhite_ has quit IRC | 18:05 | |
*** alexismonville has joined #storyboard | 18:19 | |
*** davidlenwell has quit IRC | 19:17 | |
*** davidlenwell has joined #storyboard | 19:29 | |
*** alexismonville has quit IRC | 21:46 | |
*** jtomasek has quit IRC | 21:51 | |
*** jtomasek has joined #storyboard | 21:51 | |
*** alexismonville has joined #storyboard | 22:29 | |
*** alexismonville has quit IRC | 23:07 | |
*** openstackgerrit has quit IRC | 23:42 | |
*** openstackgerrit has joined #storyboard | 23:47 | |
*** openstackgerrit has quit IRC | 23:51 | |
*** openstackgerrit has joined #storyboard | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!