*** lennyb has quit IRC | 00:03 | |
*** lennyb has joined #zuul | 00:04 | |
*** clarkb has quit IRC | 01:15 | |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul feature/zuulv3: Allow empty job and build for formatUrlPattern https://review.openstack.org/463437 | 02:01 |
---|---|---|
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul feature/zuulv3: Expose ref to the executor and url formatter https://review.openstack.org/463457 | 04:28 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Allow github trigger to match on branches/refs https://review.openstack.org/445625 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add cachecontrol to requests to github https://review.openstack.org/461587 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for requiring github pr head status https://review.openstack.org/449390 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Create github client each time it's called. https://review.openstack.org/463421 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Use integration_id with github https://review.openstack.org/463420 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Refactor integration key loading to always load https://review.openstack.org/463423 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Decode JSON body once for requests https://review.openstack.org/463422 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support for github commit status https://review.openstack.org/444060 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Merge pull requests from github reporter https://review.openstack.org/444463 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Include exc_info in reporter failure https://review.openstack.org/460765 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for github enterprise https://review.openstack.org/449258 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Log GitHub API rate limit https://review.openstack.org/446150 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Ensure PRs arent rejected for stale negative reviews https://review.openstack.org/460700 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Comment on PRs if a remote call to merge a change failed https://review.openstack.org/460762 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: support github pull request labels https://review.openstack.org/444511 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Set filter according to PR/Change in URL https://review.openstack.org/446782 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support for dependent pipelines with github https://review.openstack.org/445292 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Adds github triggering from status updates https://review.openstack.org/453844 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement trigger require/reject-approvals https://review.openstack.org/463387 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement pipeline requirement on github reviews https://review.openstack.org/453845 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement github trigger requirement status https://review.openstack.org/463386 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Actually filter status triggers https://review.openstack.org/463385 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Represent github change ID in status page by PR number https://review.openstack.org/460716 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Better merge message for GitHub pull reqeusts https://review.openstack.org/445644 | 05:08 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Test gerrit and github drivers in same tenant https://review.openstack.org/448257 | 05:09 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Encapsulate determining the event purpose https://review.openstack.org/445242 | 05:09 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Save installation ids to a cache and fetch them per project https://review.openstack.org/463424 | 05:09 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Catch integration key file not found in zuul https://review.openstack.org/463425 | 05:09 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: GitHub file matching support https://review.openstack.org/446113 | 05:09 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add trigger capability on github pr review https://review.openstack.org/449365 | 05:09 |
*** jamielennox is now known as jamielennox|away | 05:12 | |
*** jamielennox|away is now known as jamielennox | 05:18 | |
*** jamielennox is now known as jamielennox|away | 05:20 | |
*** jamielennox|away is now known as jamielennox | 05:23 | |
*** isaacb has joined #zuul | 06:22 | |
jamielennox | jeblair or others: can you explain defining job variants to me a bit | 07:00 |
jamielennox | my scenario is i'm defining jobs like: https://github.com/jamielennox/requests-mock/commit/4479ba7d65790d82b5d6fd34388f217887c2c601 | 07:01 |
jamielennox | to me, i expect i've defined the tox job, then i'm defining two actual builds of the tox job, one with py27, one with pep8 (i know i could combine them - not the point of the test) | 07:02 |
jamielennox | now only 1 build actually gets run, in this case pep8 | 07:02 |
jamielennox | I'm trying to step through the createJobGraph stuff and understand the logic here but if someone could give me a how/why those jobs are being combined it would be useful. | 07:03 |
jamielennox | note: i see what's happening, i think i understand why so you can override something defined in a more global scope, but having two individually defined jobs like that being combined is unintuitive and i can't tell if it's on purpose or a mistake | 07:21 |
*** bhavik1 has joined #zuul | 07:46 | |
*** TheJulia has quit IRC | 07:57 | |
*** TheJulia has joined #zuul | 07:58 | |
*** jamielennox is now known as jamielennox|away | 08:19 | |
*** hashar has joined #zuul | 08:22 | |
*** jamielennox|away is now known as jamielennox | 08:51 | |
*** bhavik1 has quit IRC | 09:45 | |
*** jkilpatr has joined #zuul | 11:26 | |
*** hashar has quit IRC | 11:28 | |
jeblair | jamielennox: a job only runs once for a change; if you want to do two different things (run pep8, run py27) you want two different jobs (with different names). it's generally probably an error to have two job entries in a project-pipeline with the same match criteria. we could consider trapping that. | 11:58 |
jeblair | jamielennox: to get the reusability you want, create tox-py27 and tox-pep8 jobs and inherit from tox, overriding only the env var. | 11:59 |
jeblair | jamielennox: i put up a WIP first draft doc change that stats to cover this. if you want to take a look at that and see if it would have explained this sufficiently or if there are still areas of confusion, that would be great. | 12:01 |
jeblair | jamielennox: https://review.openstack.org/463328 | 12:01 |
jeblair | s/stats to cover/starts to cover/ | 12:02 |
*** hashar has joined #zuul | 12:08 | |
*** jkilpatr has quit IRC | 12:09 | |
*** dkranz_ has joined #zuul | 12:20 | |
*** jkilpatr has joined #zuul | 13:48 | |
pabelanger | BTW: if we want zuulv3 to +1 again, we need to land: https://review.openstack.org/#/q/status:open+topic:openstack-zuul-jobs | 14:12 |
pabelanger | if people would like to review | 14:13 |
*** jkilpatr has quit IRC | 14:14 | |
Shrews | pabelanger: lgtm. didn't +A anything to give others a chance | 14:23 |
*** jkilpatr has joined #zuul | 14:32 | |
*** jkilpatr has quit IRC | 14:43 | |
openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Python 3.x incompatible use of print operator https://review.openstack.org/463586 | 15:01 |
*** jkilpatr has joined #zuul | 15:02 | |
openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use io.StringIO for python3 https://review.openstack.org/463587 | 15:09 |
*** isaacb has quit IRC | 15:13 | |
*** jkilpatr has quit IRC | 15:21 | |
*** jkilpatr has joined #zuul | 15:23 | |
*** Cibo has joined #zuul | 15:50 | |
*** jkilpatr has quit IRC | 16:06 | |
*** Cibo has quit IRC | 16:10 | |
*** Cibo has joined #zuul | 16:10 | |
openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use raise Exception for python3 https://review.openstack.org/463594 | 16:10 |
openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use urllib for python3 https://review.openstack.org/463595 | 16:10 |
*** isaacb has joined #zuul | 16:11 | |
*** jkilpatr has joined #zuul | 16:14 | |
*** Cibo_ has joined #zuul | 16:16 | |
*** Cibo has quit IRC | 16:16 | |
*** jkilpatr has quit IRC | 16:25 | |
openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use six.moves.urllib for python3 compat https://review.openstack.org/463595 | 16:27 |
openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use raise Exception for python3 https://review.openstack.org/463594 | 16:27 |
openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use six.StringIO for python3 compat https://review.openstack.org/463587 | 16:27 |
pabelanger | will battle imports next time | 16:27 |
*** jkilpatr has joined #zuul | 16:28 | |
SpamapS | pabelanger: oh.. uh | 16:38 |
SpamapS | pabelanger: I made a thing | 16:38 |
SpamapS | pabelanger: https://review.openstack.org/461468 | 16:39 |
SpamapS | doors seem to be open for lunch stuffs | 16:41 |
*** jkilpatr has quit IRC | 16:43 | |
*** bhavik1 has joined #zuul | 16:43 | |
*** hashar has quit IRC | 16:44 | |
Shrews | SpamapS: oh, i also made a thing https://review.openstack.org/463358 | 16:52 |
Shrews | needed that to at least build a py3.5 env | 16:52 |
Shrews | i will abandon mine | 16:58 |
*** isaacb has quit IRC | 17:00 | |
*** jkilpatr has joined #zuul | 17:04 | |
*** jkilpatr has quit IRC | 17:08 | |
*** bhavik1 has quit IRC | 17:10 | |
*** jkilpatr has joined #zuul | 17:45 | |
*** jkilpatr has quit IRC | 17:52 | |
*** Cibo_ has quit IRC | 17:56 | |
*** jkilpatr has joined #zuul | 17:59 | |
*** jkilpatr has quit IRC | 18:27 | |
pabelanger | Shrews: Oh, mything is for nodepool | 18:31 |
Shrews | pabelanger: yep. SpamapS and myself both had changes for zuul, though | 18:32 |
pabelanger | coolio | 18:36 |
pabelanger | py3 all the things | 18:36 |
SpamapS | zuul's going to be hard | 18:39 |
jlk | Pardon the incoming flood. | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add cachecontrol to requests to github https://review.openstack.org/461587 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Set filter according to PR/Change in URL https://review.openstack.org/446782 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for requiring github pr head status https://review.openstack.org/449390 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement trigger require/reject-approvals https://review.openstack.org/463387 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Adds github triggering from status updates https://review.openstack.org/453844 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement github trigger requirement status https://review.openstack.org/463386 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement pipeline requirement on github reviews https://review.openstack.org/453845 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Actually filter status triggers https://review.openstack.org/463385 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Create github client each time it's called. https://review.openstack.org/463421 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Use integration_id with github https://review.openstack.org/463420 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Refactor integration key loading to always load https://review.openstack.org/463423 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Represent github change ID in status page by PR number https://review.openstack.org/460716 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Decode JSON body once for requests https://review.openstack.org/463422 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Test gerrit and github drivers in same tenant https://review.openstack.org/448257 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Save installation ids to a cache and fetch them per project https://review.openstack.org/463424 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Catch integration key file not found in zuul https://review.openstack.org/463425 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Include exc_info in reporter failure https://review.openstack.org/460765 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for github enterprise https://review.openstack.org/449258 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add trigger capability on github pr review https://review.openstack.org/449365 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Ensure PRs arent rejected for stale negative reviews https://review.openstack.org/460700 | 18:52 |
openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Comment on PRs if a remote call to merge a change failed https://review.openstack.org/460762 | 18:52 |
Shrews | wow. if nothing else, jlk alone has given me much more confidence in the v3 nodepool | 19:07 |
jlk | ENJOY THE TRAFFIC! | 19:07 |
dmsimard | them stackalytics stats | 19:12 |
SpamapS | test all t3h patches | 19:16 |
jlk | mordred: jeblair: jamielennox: the log streamer y'all are working on, is there any way to insert some sort of filtering logic into it, so that we could watch for secret variable names/content and mask them out of anything that comes through from the node? | 19:17 |
jlk | A whole lot more +1s on this rebase. | 19:19 |
Shrews | jlk: jamielennox asked something very similar yesterday. check backscroll | 19:20 |
jlk | ah | 19:20 |
*** jkilpatr has joined #zuul | 19:20 | |
jlk | oh right, he was asking about formatting it for various reasons | 19:21 |
jlk | I was thinking of a way to prevent exposure of private data. | 19:21 |
jlk | (given what happened at Travis) | 19:22 |
*** jkilpatr has quit IRC | 19:27 | |
*** jkilpatr has joined #zuul | 19:30 | |
Shrews | mordred: ugh. i think your javascript is, to put it technically, "no worky" | 19:54 |
Shrews | which means i now must re-learn javascript | 19:54 |
Shrews | and you know how i love anything even REMOTELY associated with java | 19:55 |
* Shrews tries not to get stabby so early in the week | 19:55 | |
jlk | hold your nose and re-write it in Node! | 19:58 |
*** jkilpatr has quit IRC | 20:26 | |
*** jkilpatr has joined #zuul | 20:34 | |
*** jkilpatr has quit IRC | 20:37 | |
*** jkilpatr has joined #zuul | 20:39 | |
SpamapS | javascript's not really associated with java | 20:43 |
SpamapS | other than when java was the way you ran client side code, they said "we need a scripting version" | 20:44 |
pabelanger | Shrews: ya, I haven't seen any issues with nodepoolv3 since PTG things we found | 20:53 |
Shrews | SpamapS: it has java in the name. that's already too much association | 20:54 |
*** jkilpatr has quit IRC | 21:01 | |
openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming https://review.openstack.org/463353 | 21:23 |
openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming https://review.openstack.org/463353 | 21:24 |
Shrews | mordred: ^^^ that changes the js code to be much cleaner. now need to figure out why no messages are getting back to the client | 21:27 |
*** jamielennox is now known as jamielennox|away | 23:07 | |
*** jamielennox|away is now known as jamielennox | 23:11 | |
jamielennox | jeblair: wow, that doc is great | 23:31 |
jamielennox | re the variances though, i would say that behaviour is correct for any top level (term?) job definitions | 23:32 |
jamielennox | however i'd argue that any jobs defined within a project: {jobs: []} section should be consider individual build requests | 23:32 |
jamielennox | or if not, then project: {jobs: []} should accept only string names so that it's more obvious that these jobs refer to a global job rather than something unique to that project | 23:35 |
jamielennox | (or if not then catching it as a validation error will at least prevent the confusion for now) | 23:45 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!