Tuesday, 2017-05-09

*** lennyb has quit IRC00:03
*** lennyb has joined #zuul00:04
*** clarkb has quit IRC01:15
openstackgerritJamie Lennox proposed openstack-infra/zuul feature/zuulv3: Allow empty job and build for formatUrlPattern  https://review.openstack.org/46343702:01
openstackgerritJamie Lennox proposed openstack-infra/zuul feature/zuulv3: Expose ref to the executor and url formatter  https://review.openstack.org/46345704:28
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Allow github trigger to match on branches/refs  https://review.openstack.org/44562505:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Add cachecontrol to requests to github  https://review.openstack.org/46158705:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for requiring github pr head status  https://review.openstack.org/44939005:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Create github client each time it's called.  https://review.openstack.org/46342105:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Use integration_id with github  https://review.openstack.org/46342005:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Refactor integration key loading to always load  https://review.openstack.org/46342305:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Decode JSON body once for requests  https://review.openstack.org/46342205:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Support for github commit status  https://review.openstack.org/44406005:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Merge pull requests from github reporter  https://review.openstack.org/44446305:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Include exc_info in reporter failure  https://review.openstack.org/46076505:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for github enterprise  https://review.openstack.org/44925805:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Log GitHub API rate limit  https://review.openstack.org/44615005:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Ensure PRs arent rejected for stale negative reviews  https://review.openstack.org/46070005:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Comment on PRs if a remote call to merge a change failed  https://review.openstack.org/46076205:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: support github pull request labels  https://review.openstack.org/44451105:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Set filter according to PR/Change in URL  https://review.openstack.org/44678205:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Support for dependent pipelines with github  https://review.openstack.org/44529205:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Adds github triggering from status updates  https://review.openstack.org/45384405:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement trigger require/reject-approvals  https://review.openstack.org/46338705:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement pipeline requirement on github reviews  https://review.openstack.org/45384505:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement github trigger requirement status  https://review.openstack.org/46338605:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Actually filter status triggers  https://review.openstack.org/46338505:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Represent github change ID in status page by PR number  https://review.openstack.org/46071605:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Better merge message for GitHub pull reqeusts  https://review.openstack.org/44564405:08
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Test gerrit and github drivers in same tenant  https://review.openstack.org/44825705:09
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Encapsulate determining the event purpose  https://review.openstack.org/44524205:09
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Save installation ids to a cache and fetch them per project  https://review.openstack.org/46342405:09
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Catch integration key file not found in zuul  https://review.openstack.org/46342505:09
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: GitHub file matching support  https://review.openstack.org/44611305:09
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Add trigger capability on github pr review  https://review.openstack.org/44936505:09
*** jamielennox is now known as jamielennox|away05:12
*** jamielennox|away is now known as jamielennox05:18
*** jamielennox is now known as jamielennox|away05:20
*** jamielennox|away is now known as jamielennox05:23
*** isaacb has joined #zuul06:22
jamielennoxjeblair or others: can you explain defining job variants to me a bit07:00
jamielennoxmy scenario is i'm defining jobs like: https://github.com/jamielennox/requests-mock/commit/4479ba7d65790d82b5d6fd34388f217887c2c60107:01
jamielennoxto me, i expect i've defined the tox job, then i'm defining two actual builds of the tox job, one with py27, one with pep8 (i know i could combine them - not the point of the test)07:02
jamielennoxnow only 1 build actually gets run, in this case pep807:02
jamielennoxI'm trying to step through the createJobGraph stuff and understand the logic here but if someone could give me a how/why those jobs are being combined it would be useful.07:03
jamielennoxnote: i see what's happening, i think i understand why so you can override something defined in a more global scope, but having two individually defined jobs like that being combined is unintuitive and i can't tell if it's on purpose or a mistake07:21
*** bhavik1 has joined #zuul07:46
*** TheJulia has quit IRC07:57
*** TheJulia has joined #zuul07:58
*** jamielennox is now known as jamielennox|away08:19
*** hashar has joined #zuul08:22
*** jamielennox|away is now known as jamielennox08:51
*** bhavik1 has quit IRC09:45
*** jkilpatr has joined #zuul11:26
*** hashar has quit IRC11:28
jeblairjamielennox: a job only runs once for a change; if you want to do two different things (run pep8, run py27) you want two different jobs (with different names).  it's generally probably an error to have two job entries in a project-pipeline with the same match criteria.  we could consider trapping that.11:58
jeblairjamielennox: to get the reusability you want, create tox-py27 and tox-pep8 jobs and inherit from tox, overriding only the env var.11:59
jeblairjamielennox: i put up a WIP first draft doc change that stats to cover this.  if you want to take a look at that and see if it would have explained this sufficiently or if there are still areas of confusion, that would be great.12:01
jeblairjamielennox: https://review.openstack.org/46332812:01
jeblairs/stats to cover/starts to cover/12:02
*** hashar has joined #zuul12:08
*** jkilpatr has quit IRC12:09
*** dkranz_ has joined #zuul12:20
*** jkilpatr has joined #zuul13:48
pabelangerBTW: if we want zuulv3 to +1 again, we need to land: https://review.openstack.org/#/q/status:open+topic:openstack-zuul-jobs14:12
pabelangerif people would like to review14:13
*** jkilpatr has quit IRC14:14
Shrewspabelanger: lgtm. didn't +A anything to give others a chance14:23
*** jkilpatr has joined #zuul14:32
*** jkilpatr has quit IRC14:43
openstackgerritPaul Belanger proposed openstack-infra/nodepool feature/zuulv3: Python 3.x incompatible use of print operator  https://review.openstack.org/46358615:01
*** jkilpatr has joined #zuul15:02
openstackgerritPaul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use io.StringIO for python3  https://review.openstack.org/46358715:09
*** isaacb has quit IRC15:13
*** jkilpatr has quit IRC15:21
*** jkilpatr has joined #zuul15:23
*** Cibo has joined #zuul15:50
*** jkilpatr has quit IRC16:06
*** Cibo has quit IRC16:10
*** Cibo has joined #zuul16:10
openstackgerritPaul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use raise Exception for python3  https://review.openstack.org/46359416:10
openstackgerritPaul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use urllib for python3  https://review.openstack.org/46359516:10
*** isaacb has joined #zuul16:11
*** jkilpatr has joined #zuul16:14
*** Cibo_ has joined #zuul16:16
*** Cibo has quit IRC16:16
*** jkilpatr has quit IRC16:25
openstackgerritPaul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use six.moves.urllib for python3 compat  https://review.openstack.org/46359516:27
openstackgerritPaul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use raise Exception for python3  https://review.openstack.org/46359416:27
openstackgerritPaul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use six.StringIO for python3 compat  https://review.openstack.org/46358716:27
pabelangerwill battle imports next time16:27
*** jkilpatr has joined #zuul16:28
SpamapSpabelanger: oh.. uh16:38
SpamapSpabelanger: I made a thing16:38
SpamapSpabelanger: https://review.openstack.org/46146816:39
SpamapSdoors seem to be open for lunch stuffs16:41
*** jkilpatr has quit IRC16:43
*** bhavik1 has joined #zuul16:43
*** hashar has quit IRC16:44
ShrewsSpamapS: oh, i also made a thing https://review.openstack.org/46335816:52
Shrewsneeded that to at least build a py3.5 env16:52
Shrewsi will abandon mine16:58
*** isaacb has quit IRC17:00
*** jkilpatr has joined #zuul17:04
*** jkilpatr has quit IRC17:08
*** bhavik1 has quit IRC17:10
*** jkilpatr has joined #zuul17:45
*** jkilpatr has quit IRC17:52
*** Cibo_ has quit IRC17:56
*** jkilpatr has joined #zuul17:59
*** jkilpatr has quit IRC18:27
pabelangerShrews: Oh, mything is for nodepool18:31
Shrewspabelanger: yep. SpamapS and myself both had changes for zuul, though18:32
pabelangercoolio18:36
pabelangerpy3 all the things18:36
SpamapSzuul's going to be hard18:39
jlkPardon the incoming flood.18:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Add cachecontrol to requests to github  https://review.openstack.org/46158718:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Set filter according to PR/Change in URL  https://review.openstack.org/44678218:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for requiring github pr head status  https://review.openstack.org/44939018:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement trigger require/reject-approvals  https://review.openstack.org/46338718:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Adds github triggering from status updates  https://review.openstack.org/45384418:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement github trigger requirement status  https://review.openstack.org/46338618:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement pipeline requirement on github reviews  https://review.openstack.org/45384518:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Actually filter status triggers  https://review.openstack.org/46338518:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Create github client each time it's called.  https://review.openstack.org/46342118:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Use integration_id with github  https://review.openstack.org/46342018:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Refactor integration key loading to always load  https://review.openstack.org/46342318:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Represent github change ID in status page by PR number  https://review.openstack.org/46071618:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Decode JSON body once for requests  https://review.openstack.org/46342218:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Test gerrit and github drivers in same tenant  https://review.openstack.org/44825718:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Save installation ids to a cache and fetch them per project  https://review.openstack.org/46342418:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Catch integration key file not found in zuul  https://review.openstack.org/46342518:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Include exc_info in reporter failure  https://review.openstack.org/46076518:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for github enterprise  https://review.openstack.org/44925818:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Add trigger capability on github pr review  https://review.openstack.org/44936518:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Ensure PRs arent rejected for stale negative reviews  https://review.openstack.org/46070018:52
openstackgerritJesse Keating proposed openstack-infra/zuul feature/zuulv3: Comment on PRs if a remote call to merge a change failed  https://review.openstack.org/46076218:52
Shrewswow. if nothing else, jlk alone has given me much more confidence in the v3 nodepool19:07
jlkENJOY THE TRAFFIC!19:07
dmsimardthem stackalytics stats19:12
SpamapStest all t3h patches19:16
jlkmordred: jeblair: jamielennox: the log streamer y'all are working on, is there any way to insert some sort of filtering logic into it, so that we could watch for secret variable names/content and mask them out of anything that comes through from the node?19:17
jlkA whole lot more +1s on this rebase.19:19
Shrewsjlk: jamielennox asked something very similar yesterday. check backscroll19:20
jlkah19:20
*** jkilpatr has joined #zuul19:20
jlkoh right, he was asking about formatting it for various reasons19:21
jlkI was thinking of a way to prevent exposure of private data.19:21
jlk(given what happened at Travis)19:22
*** jkilpatr has quit IRC19:27
*** jkilpatr has joined #zuul19:30
Shrewsmordred: ugh. i think your javascript is, to put it technically, "no worky"19:54
Shrewswhich means i now must re-learn javascript19:54
Shrewsand you know how i love anything even REMOTELY associated with java19:55
* Shrews tries not to get stabby so early in the week19:55
jlkhold your nose and re-write it in Node!19:58
*** jkilpatr has quit IRC20:26
*** jkilpatr has joined #zuul20:34
*** jkilpatr has quit IRC20:37
*** jkilpatr has joined #zuul20:39
SpamapSjavascript's not really associated with java20:43
SpamapSother than when java was the way you ran client side code, they said "we need a scripting version"20:44
pabelangerShrews: ya, I haven't seen any issues with nodepoolv3 since PTG things we found20:53
ShrewsSpamapS: it has java in the name. that's already too much association20:54
*** jkilpatr has quit IRC21:01
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming  https://review.openstack.org/46335321:23
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming  https://review.openstack.org/46335321:24
Shrewsmordred: ^^^ that changes the js code to be much cleaner. now need to figure out why no messages are getting back to the client21:27
*** jamielennox is now known as jamielennox|away23:07
*** jamielennox|away is now known as jamielennox23:11
jamielennoxjeblair: wow, that doc is great23:31
jamielennoxre the variances though, i would say that behaviour is correct for any top level (term?) job definitions23:32
jamielennoxhowever i'd argue that any jobs defined within a project: {jobs: []} section should be consider individual build requests23:32
jamielennoxor if not, then project: {jobs: []} should accept only string names so that it's more obvious that these jobs refer to a global job rather than something unique to that project23:35
jamielennox(or if not then catching it as a validation error will at least prevent the confusion for now)23:45

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!