| openstackgerrit | Jamie Lennox proposed openstack-infra/zuul feature/zuulv3: Add tenant to url formatting. https://review.openstack.org/463628 | 00:31 |
|---|---|---|
| jamielennox | so i haven't been able to run zuul tests for ages, but | 04:11 |
| jamielennox | pymysql.err.OperationalError: (2003, "Can't connect to MySQL server on 'localhost' ([Errno 0] Error)") | 04:11 |
| jamielennox | *** Error in `python': double free or corruption (out): 0x00007fad10006610 *** | 04:11 |
| jamielennox | is new | 04:11 |
| *** isaacb has joined #zuul | 06:31 | |
| *** Cibo_ has joined #zuul | 07:22 | |
| *** hashar has joined #zuul | 07:37 | |
| *** Cibo has joined #zuul | 09:11 | |
| *** Cibo_ has quit IRC | 09:13 | |
| *** Cibo has quit IRC | 09:36 | |
| *** bhavik1 has joined #zuul | 10:04 | |
| mordred | jamielennox: that doesn't seem good | 10:15 |
| *** bhavik1 has quit IRC | 10:42 | |
| Shrews | wow, we made python crash? neat | 11:04 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming https://review.openstack.org/463353 | 11:11 |
| jeblair | jamielennox: there are several places where we make the assumption that we only run one instance of a job for a change. aside from that, there are two reasons we allow implied job variants in the project pipeline config: first, so that you can add extra selectors to a job for only a single project (ie, only run devstack on changes to neutron if these files are changed). having that at the global job level rather than at the project level is ... | 11:15 |
| jeblair | ... one of the worst things about zuulv2 (it has made openstack's config incomprehensible). second, implied project variants are the only way to modify a job defined in another project (because it's not safe to globally modify a job definition from a different project). | 11:15 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming https://review.openstack.org/463353 | 11:28 |
| SpamapS | Shrews: are we moving forward on that w/o asyncio? | 12:25 |
| * SpamapS hasn't looked at the actual patch just curious | 12:25 | |
| Shrews | SpamapS: it still makes heavy use of asyncio | 12:26 |
| Shrews | i'm still figuring it out. i *just* got it to successfully stream random text, so that's fun | 12:26 |
| SpamapS | ah, so we'll just python3 that bit | 12:29 |
| Shrews | yup | 12:29 |
| SpamapS | I keep getting distracted off of it, but I'd like to see us start running tox py3 tests on whatever tests do pass now. | 12:32 |
| *** jkilpatr has joined #zuul | 13:01 | |
| *** jkilpatr has quit IRC | 13:48 | |
| pabelanger | morning | 13:49 |
| pabelanger | SpamapS: if you are around this morning, would love to chat about flatpak, if you are aware of it | 13:49 |
| *** jkilpatr has joined #zuul | 13:55 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use six.moves.urllib for python3 compat https://review.openstack.org/463595 | 13:57 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use raise Exception for python3 https://review.openstack.org/463594 | 13:57 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Remove FakeFile from fakeprovider.py https://review.openstack.org/463587 | 13:57 |
| *** isaacb has quit IRC | 13:58 | |
| jeblair | i found a cozy spot near room 108 if anyone wants to join me | 14:02 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming https://review.openstack.org/463353 | 14:03 |
| *** isaacb has joined #zuul | 14:22 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: WIP: Fix imports for python3 https://review.openstack.org/463769 | 14:23 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming https://review.openstack.org/463353 | 14:24 |
| pabelanger | Shrews: ^maybe you have a few minutes today to help explain imports for nodepool, because imports for py27 are not working local for me and I do not know why | 14:26 |
| Shrews | pabelanger: relative imports changed | 14:30 |
| Shrews | pabelanger: so "import zk" needs to be "from . import zk", for example | 14:30 |
| Shrews | the 2nd form should work for both version | 14:31 |
| Shrews | pabelanger: what's not working for you? | 14:32 |
| pabelanger | Shrews: I am having this issue: http://logs.openstack.org/69/463769/1/check/gate-nodepool-python27-ubuntu-xenial/fef81bd/console.html#_2017-05-10_14_27_43_616052 | 14:34 |
| pabelanger | which the gate has also found, yay | 14:34 |
| pabelanger | agree, from . import exceptions should work | 14:35 |
| pabelanger | let me make a change | 14:35 |
| * SpamapS doesn't like . | 14:35 | |
| SpamapS | I prefer the full module path. | 14:35 |
| pabelanger | agree, I thought: from nodepool import exceptions was that, full module path | 14:37 |
| pabelanger | but, I must be wrong | 14:37 |
| Shrews | i do not know why the full path is not working for you | 14:38 |
| pabelanger | I am assuming tox might be doing something here, but haven't figure it out yet | 14:38 |
| *** jkilpatr has quit IRC | 14:40 | |
| Shrews | pabelanger: is that the only file where you get that error? | 14:40 |
| Shrews | if so, it might have something to do with the name of the file also being 'nodepool', so maybe it's confusing the .py file and the entire library? not sure | 14:41 |
| pabelanger | Shrews: Oh, that could be | 14:42 |
| pabelanger | Shrews: Yes, i think that is correct | 14:42 |
| pabelanger | Shrews: thank you | 14:43 |
| Shrews | that's caught me before in other scenarios | 14:44 |
| pabelanger | agree, I think for now we can easy mode with from . import foo | 14:44 |
| pabelanger | but maybe start to break up nodepool.py into other bits | 14:44 |
| pabelanger | laster | 14:44 |
| pabelanger | later* | 14:44 |
| *** jkilpatr has joined #zuul | 14:47 | |
| *** hashar has quit IRC | 14:50 | |
| pabelanger | Shrews: jeblair: clarkb: SpamapS: So, for python3 imports, maybe it is better just to rename nodepool.py now? instead of from . import foo. So, if we want to bikeshed on new filename does nodepool.py->pool.py work? | 14:50 |
| Shrews | i think launcher.py makes sense since i've had that in the back of my head since the daemon rename | 14:51 |
| pabelanger | Yes, that does make sense actually | 14:51 |
| SpamapS | +1 | 14:52 |
| jeblair | wfm | 15:05 |
| *** jkilpatr has quit IRC | 15:07 | |
| *** isaacb has quit IRC | 15:08 | |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming https://review.openstack.org/463353 | 15:19 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Rename nodepool.py to launcher.py https://review.openstack.org/463807 | 15:23 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Fix imports for python3 https://review.openstack.org/463808 | 15:23 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: WIP: Add web-based console log streaming https://review.openstack.org/463353 | 15:24 |
| *** jkilpatr has joined #zuul | 15:32 | |
| *** jkilpatr has quit IRC | 15:41 | |
| *** DangerousDaren has joined #zuul | 15:47 | |
| *** hashar has joined #zuul | 15:53 | |
| *** Cibo has joined #zuul | 16:52 | |
| *** hashar has quit IRC | 17:05 | |
| *** hashar has joined #zuul | 17:06 | |
| *** hashar has quit IRC | 17:07 | |
| *** jkilpatr has joined #zuul | 17:10 | |
| *** smyers has quit IRC | 17:15 | |
| *** smyers has joined #zuul | 17:16 | |
| *** DangerousDaren has quit IRC | 17:20 | |
| *** tobiash_ has joined #zuul | 17:36 | |
| *** jkilpatr has quit IRC | 17:42 | |
| tobiash_ | hi, is there already a way in zuulv3 to add deployment defined variables to the jobs? | 17:42 |
| tobiash_ | e.g I have an automated deployment together with an automatic creation of a cache server which is not known in advance | 17:43 |
| tobiash_ | so I would like to have some way to add a (ansible generated) variable to the zuul config (tenant config?) which is then accessible by any job | 17:45 |
| tobiash_ | I'm thinking of something like http://paste.openstack.org/show/609295/ | 17:54 |
| pabelanger | tobiash_: we actually talked a little about this today in person. But I think we have the need for a playbook to generare some variable, which is dynamic, so the next playbook run is able to consume it | 18:09 |
| tobiash_ | pabelanger: ah, ok | 18:11 |
| tobiash_ | so you mean a trusted playbook could generate some variables (depending on stuff on the executor as it's not running sandboxed) which can be used on later (untrusted) playbooks? | 18:13 |
| pabelanger | tobiash_: I believe jeblair and mordred will be able to provide more information too | 18:13 |
| tobiash_ | sounds pretty generic | 18:13 |
| SpamapS | tobiash_: indeed, your timing is excellent. I think we have a good plan and I expect us to express it in doc/spec form soon. | 18:13 |
| tobiash_ | :) | 18:13 |
| pabelanger | tobiash_: yes, or even untrusted to untrusted in different repos | 18:13 |
| SpamapS | I believe the idea was for every playbook to generate variables for zuul or the next job to inspect. | 18:13 |
| tobiash_ | I think that would be a good fit for my use case | 18:14 |
| tobiash_ | I hope you enjoy the summit. Unfortunately I wasn't able to attend. Would have been cool to meet you guys in person. | 18:16 |
| jeblair | tobiash_: indeed! we'll cross paths eventually :) | 18:17 |
| jeblair | tobiash_: to add to what SpamapS and pabelanger said: we'll also probably have something like this change: https://review.openstack.org/447734 to add zuul site variables too. | 18:18 |
| tobiash_ | Judging from your timezones I assume no one will attend the german openstack days end of june? | 18:18 |
| tobiash_ | jeblair: cool, looks like I overlooked this change | 18:19 |
| jeblair | tobiash_: mordred sometimes travels to those, we should check with him. it's not on my calendar at the moment, though that could change | 18:19 |
| tobiash_ | this year it's just in the neighbor building of my employer... | 18:21 |
| SpamapS | jeblair: so I just pushed a change to gear that does appendData. But I'm wondering if, instead, we should make a TextList which is just a list that converts appends/extends on write, so we don't API-break. | 18:22 |
| *** clarkb has joined #zuul | 18:22 | |
| SpamapS | (but I know we said it should be ok to API-break because of the language port) | 18:22 |
| SpamapS | we could also just tag this 0.8 and call it macaroni | 18:23 |
| jeblair | tobiash_: oh nice! looks like that's the weekend after ansiblefest london (which mordred and i are attending) | 18:23 |
| jeblair | SpamapS: TextList wfm | 18:24 |
| tobiash_ | interesting | 18:25 |
| *** Cibo has quit IRC | 18:30 | |
| *** Cibo has joined #zuul | 18:39 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Rename nodepool.py to launcher.py https://review.openstack.org/463807 | 18:40 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Fix imports for python3 https://review.openstack.org/463808 | 18:40 |
| *** jkilpatr has joined #zuul | 18:41 | |
| jeblair | jlk: question on 444511 | 18:43 |
| *** tobiash_ has quit IRC | 18:54 | |
| SpamapS | jeblair: unfortunately this wasn't the problem causing my internal geard to disconnect. :-/ | 18:55 |
| SpamapS | actually hm | 18:56 |
| jeblair | jlk: and let me know if you want to chat about 445292 | 18:56 |
| SpamapS | this is interesting... | 18:56 |
| jeblair | SpamapS: i'll start setting up a test env | 18:57 |
| SpamapS | http://paste.openstack.org/show/609302/ | 18:57 |
| SpamapS | the test passes | 18:57 |
| SpamapS | but the teardown gets stuck | 18:57 |
| SpamapS | which I think is actually better than before | 18:57 |
| SpamapS | jeblair: I'm over by 108 again, will be heading to airport in about 45-60 minu | 18:58 |
| jeblair | SpamapS: yeah, that doesn't, at first glance, look gear related | 18:58 |
| jeblair | SpamapS: is there an open seat near you? | 18:59 |
| SpamapS | http://paste.openstack.org/show/609303/ | 18:59 |
| SpamapS | jeblair: there is one yes | 18:59 |
| jeblair | SpamapS: be right there | 18:59 |
| *** jkilpatr has quit IRC | 19:12 | |
| *** jkilpatr has joined #zuul | 19:16 | |
| jlk | jeblair: I'm in now, happy to chat. Looking at the reviews now | 19:39 |
| SpamapS | woohoo, got a test to pass in py35! | 19:39 |
| jlk | A+ | 19:39 |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: WIP: working on python3 compat https://review.openstack.org/461468 | 19:40 |
| SpamapS | now time to go fly home :-P | 19:41 |
| *** jkilpatr has quit IRC | 19:42 | |
| SpamapS | That commit at least gets the test suite to run without locking up... | 19:42 |
| * SpamapS waiting for how many tests actually pass | 19:42 | |
| SpamapS | Length too long: 15870087 | 19:42 |
| SpamapS | "too many" | 19:43 |
| jlk | jeblair: Reading coment on 445292, I see what you mean. we can definitely set that value when an event comes in and we do the API call to get the pull request object. What I wasn't sure of is the action path should this method return a False, stating that the change cannot be merged. Since that's going to be a fairly common result. | 19:45 |
| *** jkilpatr has joined #zuul | 20:29 | |
| jeblair | jlk: in a dependent pipeline, it will not enqueue the change if it's false at enqueue time. if it changes while already in the queue, it should get kicked out | 20:32 |
| jlk | alright, so for GitHub, the simple data we can get from the event will say mergeable basically if the patch(es) can merge cleanly. It doesn't look at vote status at all. So yeah, we'd get some false positives on "this could merge" when in reality it may not have all the required things in place. | 20:35 |
| jeblair | jlk: oh, well we can perform that api call then, right? | 20:37 |
| jlk | No, because the API call also doesn't give you that information | 20:37 |
| jlk | at this time, github does not expose a True/False value for whether or not all the merge requirements are in place | 20:37 |
| jeblair | jlk: i'm confused :( | 20:38 |
| jlk | The best we could do is query the branch object through the API to discover what "protections" are in place for the branch, and then investigate the PullRequest to see if the PR has met all those requirements. | 20:38 |
| jlk | Github doesn't have a vote requirement system like gerrit | 20:38 |
| jlk | what it has is "branch protection" | 20:38 |
| jeblair | jlk: that's pretty close, in spirit, to what we do for gerrit | 20:38 |
| jlk | you can configure each branch to be "protected" from improper merges | 20:39 |
| jlk | protections can be "needs a human with write access to review it", can be "needs these passing statuses set on the tip of the PR", and could even be "only allow this sub-set of people to commit to the branch" | 20:40 |
| jeblair | jlk: then that's probably what we should be doing here. i don't think we need to worry about file-level merge conflicts in relation to this | 20:40 |
| jlk | and the even MORE insane one of "must be a fast forward merge" essentially. | 20:40 |
| jlk | Would you be willing to accept us just returning True here in this PR, and having a follow up one to do the investigation for more accurate data? | 20:41 |
| jlk | We don't even support depends-on type changes anyway yet | 20:41 |
| jeblair | jlk: absolutely | 20:41 |
| jeblair | jlk: i mostly didn't want to land a todo which looked wrong :) | 20:42 |
| jlk | gotcha. I'll fix that up and continue the rebase-a-thon | 20:43 |
| SpamapS | oh that's fun. | 21:33 |
| SpamapS | in py3k, if you define __eq__ , __hash__ gets undefined | 21:33 |
| jlk | er,... what? | 21:34 |
| SpamapS | (to coerce you into making things that are equal likely to have the same hash) | 21:34 |
| jlk | why would it do that? | 21:34 |
| jlk | eww | 21:34 |
| jlk | I mean, there's probably a good reason, but that seems heavy handed | 21:34 |
| SpamapS | you can just do __hash__ = object.__hash__ if you want python 2's behavior | 21:34 |
| SpamapS | which is to return the id | 21:34 |
| SpamapS | jlk: I guess they figure you're going to have to revisit every object anyway | 21:35 |
| jlk | INCOMING! | 21:40 |
| * SpamapS ducks | 21:41 | |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Allow github trigger to match on branches/refs https://review.openstack.org/445625 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add cachecontrol to requests to github https://review.openstack.org/461587 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for requiring github pr head status https://review.openstack.org/449390 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Create github client each time it's called. https://review.openstack.org/463421 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Use integration_id with github https://review.openstack.org/463420 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Refactor integration key loading to always load https://review.openstack.org/463423 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Decode JSON body once for requests https://review.openstack.org/463422 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Include exc_info in reporter failure https://review.openstack.org/460765 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for github enterprise https://review.openstack.org/449258 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Log GitHub API rate limit https://review.openstack.org/446150 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Ensure PRs arent rejected for stale negative reviews https://review.openstack.org/460700 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Comment on PRs if a remote call to merge a change failed https://review.openstack.org/460762 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: support github pull request labels https://review.openstack.org/444511 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Set filter according to PR/Change in URL https://review.openstack.org/446782 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support for dependent pipelines with github https://review.openstack.org/445292 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Adds github triggering from status updates https://review.openstack.org/453844 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement trigger require/reject-approvals https://review.openstack.org/463387 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement pipeline requirement on github reviews https://review.openstack.org/453845 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement github trigger requirement status https://review.openstack.org/463386 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Actually filter status triggers https://review.openstack.org/463385 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Represent github change ID in status page by PR number https://review.openstack.org/460716 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Better merge message for GitHub pull reqeusts https://review.openstack.org/445644 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Test gerrit and github drivers in same tenant https://review.openstack.org/448257 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Encapsulate determining the event purpose https://review.openstack.org/445242 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Save installation ids to a cache and fetch them per project https://review.openstack.org/463424 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Catch integration key file not found in zuul https://review.openstack.org/463425 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: GitHub file matching support https://review.openstack.org/446113 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add trigger capability on github pr review https://review.openstack.org/449365 | 21:41 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Include tenant name in github context https://review.openstack.org/463871 | 21:41 |
| SpamapS | wow this is a special type of error | 21:50 |
| SpamapS | TypeError: initializer for ctype 'unsigned char *' must be a bytes or list or tuple, not str | 21:50 |
| clarkb | because str is list of ints? | 21:52 |
| SpamapS | probably | 21:52 |
| SpamapS | bytes is a list of ints too | 21:52 |
| SpamapS | actually no, in this case, it's because str's aren't bytes period | 21:58 |
| SpamapS | so there's no way to feed that into a C lib | 21:58 |
| SpamapS | which is really the whole point of the bytes/str change | 21:58 |
| *** jkilpatr has quit IRC | 22:11 | |
| jeblair | SpamapS: where's that from? | 22:24 |
| jamielennox | oh, in case anyone is interested: https://github.com/BonnyCI/requests-mock/pull/1 is zuul v3 leaving status on a github PR via integration | 23:46 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!