| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: [wip] add openstackci-mirrors element for centos/ubuntu testing https://review.openstack.org/634366 | 00:21 |
|---|---|---|
| *** sdake has quit IRC | 00:25 | |
| *** sdake has joined #zuul | 00:29 | |
| *** sdake has quit IRC | 00:30 | |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: [wip] add openstackci-mirrors element for centos/ubuntu testing https://review.openstack.org/634366 | 00:37 |
| *** dkehn has joined #zuul | 00:38 | |
| *** pleia2 has quit IRC | 00:42 | |
| *** pleia2 has joined #zuul | 00:43 | |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: [wip] add openstackci-mirrors element for centos/ubuntu testing https://review.openstack.org/634366 | 00:50 |
| *** sdake has joined #zuul | 00:57 | |
| *** jesusaur has quit IRC | 01:01 | |
| *** sdake has quit IRC | 01:03 | |
| *** jesusaur has joined #zuul | 01:06 | |
| *** sdake has joined #zuul | 01:19 | |
| *** sdake has quit IRC | 01:27 | |
| *** sdake has joined #zuul | 01:35 | |
| *** sdake has quit IRC | 01:52 | |
| *** sdake has joined #zuul | 02:20 | |
| *** rlandy|bbl is now known as rlandy | 02:32 | |
| *** sanjayu_ has joined #zuul | 02:46 | |
| *** bhavikdbavishi has joined #zuul | 03:03 | |
| *** bhavikdbavishi1 has joined #zuul | 03:07 | |
| *** bhavikdbavishi has quit IRC | 03:08 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:08 | |
| *** chandankumar has joined #zuul | 03:17 | |
| *** sdake has quit IRC | 03:17 | |
| *** sdake has joined #zuul | 03:18 | |
| *** sdake has quit IRC | 03:35 | |
| *** rlandy has quit IRC | 03:42 | |
| *** chandankumar has quit IRC | 03:51 | |
| *** rfolco has quit IRC | 03:54 | |
| *** sdake has joined #zuul | 03:57 | |
| *** sdake has quit IRC | 04:16 | |
| *** chandankumar has joined #zuul | 04:32 | |
| *** chandankumar is now known as chkumar|ruck | 04:32 | |
| *** sdake has joined #zuul | 04:43 | |
| *** chkumar|ruck has quit IRC | 04:56 | |
| *** chkumar|ruck has joined #zuul | 04:57 | |
| tobiash | SpamapS: the service worker can be disabled optionally (at compile time). This is the change corvus was referring to: https://review.openstack.org/609626 | 05:12 |
| SpamapS | tobiash: yeah that looks exactly like my problem. | 05:22 |
| SpamapS | tobiash: what does one lose by disabling service worker? | 05:23 |
| tobiash | SpamapS: offline functionality | 05:23 |
| tobiash | But zuul is not really useful as an offline webapp... | 05:24 |
| tobiash | The regular browser cache still works | 05:24 |
| SpamapS | hah yeah, not useful at all, so seems like we should just ditch it. | 05:25 |
| SpamapS | Been meaning to revisit my zuul container builds to be not-alpine, I'll add that to the compile step. Thanks! | 05:26 |
| tobiash | I think folks didn't want to ditch it completely so I made it optionally ditchable ;) | 05:27 |
| *** chkumar|ruck has quit IRC | 05:48 | |
| *** chkumar|ruck has joined #zuul | 05:48 | |
| *** swest has joined #zuul | 06:01 | |
| *** sdake has quit IRC | 06:03 | |
| *** badboy has joined #zuul | 06:11 | |
| *** quique|rover|off is now known as quiquell|rover | 06:20 | |
| *** sanjayu_ has quit IRC | 06:29 | |
| *** saneax has joined #zuul | 06:50 | |
| *** chkumar|ruck has quit IRC | 07:10 | |
| *** hashar has joined #zuul | 07:13 | |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: config: add playbooks to job.toDict() https://review.openstack.org/621343 | 07:29 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Add API endpoint to get frozen jobs https://review.openstack.org/607077 | 07:29 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Get executor job params https://review.openstack.org/607078 | 07:29 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Separate out executor server from runner https://review.openstack.org/607079 | 07:29 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: implement prep-workspace https://review.openstack.org/607082 | 07:29 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: web: add /connections route https://review.openstack.org/631703 | 07:29 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: use connections endpoint for prepare-workspace https://review.openstack.org/631704 | 07:29 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add execute sub-command https://review.openstack.org/630944 | 07:29 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add support for depends-on https://review.openstack.org/632064 | 07:29 |
| *** quiquell|rover is now known as quiquell|brb | 07:32 | |
| *** pcaruana has joined #zuul | 07:45 | |
| *** chkumar|ruck has joined #zuul | 07:47 | |
| *** hashar has quit IRC | 08:00 | |
| *** quiquell|brb is now known as quiquell|rover | 08:05 | |
| *** panda is now known as panda|ko | 08:05 | |
| *** hashar has joined #zuul | 08:10 | |
| openstackgerrit | Simon Westphahl proposed openstack-infra/zuul master: Retry jobs on WinRM read timeout error https://review.openstack.org/634880 | 08:16 |
| *** saneax has quit IRC | 08:25 | |
| *** jpena|off is now known as jpena | 08:33 | |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: Add openstackci-mirrors element for centos/ubuntu functional tests https://review.openstack.org/634366 | 08:40 |
| *** lennyb has quit IRC | 08:55 | |
| *** lennyb has joined #zuul | 08:58 | |
| *** gtema has joined #zuul | 09:00 | |
| *** quiquell|rover has quit IRC | 09:06 | |
| *** quiquell has joined #zuul | 09:06 | |
| quiquell | tristanC: we are affected by https://softwarefactory-project.io/r/gitweb?p=software-factory%2Fsf-config.git;a=commit;h=27110c9477b34785850723ba7fcd064a0b604012 | 09:09 |
| *** saneax has joined #zuul | 09:35 | |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Add API endpoint to get frozen jobs https://review.openstack.org/607077 | 09:47 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Get executor job params https://review.openstack.org/607078 | 09:47 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Separate out executor server from runner https://review.openstack.org/607079 | 09:47 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: implement prep-workspace https://review.openstack.org/607082 | 09:47 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: web: add /connections route https://review.openstack.org/631703 | 09:47 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: use connections endpoint for prepare-workspace https://review.openstack.org/631704 | 09:47 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add execute sub-command https://review.openstack.org/630944 | 09:47 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add support for depends-on https://review.openstack.org/632064 | 09:47 |
| zbr|ssbarnea | mordred: pabelanger: a 2nd review on https://review.openstack.org/#/c/633948/13 is needed. (install-docker role) | 09:51 |
| zbr|ssbarnea | if people want I could make a CR to add testing of roles via molecule for zuul-jobs itself. | 09:52 |
| *** bhavikdbavishi1 has joined #zuul | 10:03 | |
| *** bhavikdbavishi has quit IRC | 10:05 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 10:05 | |
| *** chkumar|ruck has quit IRC | 10:09 | |
| *** bhavikdbavishi has quit IRC | 10:12 | |
| *** chandankumar has joined #zuul | 10:15 | |
| *** chandankumar is now known as chkumar|ruck | 10:15 | |
| *** bjackman has joined #zuul | 10:18 | |
| openstackgerrit | Quique Llorente proposed openstack-infra/zuul master: Escape jinja2 stuff from inventory https://review.openstack.org/633930 | 10:23 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: web: add /connections route https://review.openstack.org/631703 | 10:38 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: use connections endpoint for prepare-workspace https://review.openstack.org/631704 | 10:38 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add execute sub-command https://review.openstack.org/630944 | 10:38 |
| openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add support for depends-on https://review.openstack.org/632064 | 10:38 |
| *** saneax has quit IRC | 10:42 | |
| *** saneax has joined #zuul | 10:42 | |
| *** hashar has quit IRC | 10:56 | |
| *** irclogbot_3 has quit IRC | 11:05 | |
| *** dkehn has quit IRC | 11:05 | |
| *** bhavikdbavishi has joined #zuul | 11:11 | |
| *** jesusaur has quit IRC | 11:31 | |
| openstackgerrit | Quique Llorente proposed openstack-infra/zuul master: Escape jinja2 stuff from inventory https://review.openstack.org/633930 | 11:33 |
| *** jesusaur has joined #zuul | 11:35 | |
| openstackgerrit | Quique Llorente proposed openstack-infra/zuul master: Escape jinja2 stuff from inventory https://review.openstack.org/633930 | 11:49 |
| *** quiquell has quit IRC | 11:52 | |
| *** quiquell has joined #zuul | 11:52 | |
| *** bhavikdbavishi has quit IRC | 11:53 | |
| *** jpena is now known as jpena|lunch | 11:57 | |
| *** quiquell is now known as quique|rover|eat | 12:03 | |
| *** quique|rover|eat is now known as quiquell|rover | 12:06 | |
| *** hashar has joined #zuul | 12:12 | |
| *** quiquell|rover is now known as quique|rover|eat | 12:14 | |
| *** quique|rover|eat is now known as quiquell|rover | 12:28 | |
| *** bjackman has quit IRC | 12:36 | |
| *** rfolco has joined #zuul | 12:37 | |
| *** bjackman has joined #zuul | 12:38 | |
| *** sdake has joined #zuul | 13:05 | |
| *** bjackman has quit IRC | 13:11 | |
| *** gtema has quit IRC | 13:12 | |
| *** jpena|lunch is now known as jpena | 13:17 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/zuul-jobs master: WIP: example of using molecule to test install-docker role https://review.openstack.org/634934 | 13:25 |
| *** rlandy has joined #zuul | 13:38 | |
| mordred | SpamapS: I don't know if you saw the other day, but we've got a regular dockerfile now in tree - so if you revisit your image builds, you might be able to re-use the upstream dockerfile (or not) | 13:50 |
| mordred | SpamapS: we might need to plumb that build envvar into the Dockerfile as an ARG so that it's settable in a job | 13:54 |
| *** sdake has quit IRC | 13:54 | |
| mordred | tobiash: actually ^^ ... should we add all of the various env vars the build responds to as ARG in the Dockerfile? | 13:54 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Add react build env vars to Dockerfile https://review.openstack.org/634940 | 14:00 |
| mordred | tobiash, SpamapS: ^^ | 14:00 |
| *** sdake has joined #zuul | 14:05 | |
| *** chkumar|ruck has quit IRC | 14:05 | |
| tobiash | mordred: commented | 14:08 |
| mordred | tobiash: heh. thanks :) | 14:09 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Add react build env vars to Dockerfile https://review.openstack.org/634940 | 14:10 |
| mordred | tobiash: turns out - that's because I copy-pasta'd from somewhere with a typo - fix those as well | 14:10 |
| *** hashar has quit IRC | 14:14 | |
| *** sdake has quit IRC | 14:17 | |
| *** gtema has joined #zuul | 14:24 | |
| quiquell|rover | tristanC: you there ? | 14:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Add react build env vars to Dockerfile https://review.openstack.org/634940 | 14:33 |
| *** sdake has joined #zuul | 14:34 | |
| *** zbr has joined #zuul | 14:39 | |
| *** zbr|ssbarnea has quit IRC | 14:40 | |
| ttx | Hi Zuulites! I found a weird bug in the UI -- First time users get a 404 if they access https://zuul.opendev.org/t/kata-containers/status without accessing https://zuul.opendev.org/ (which drops a giant cookie) first | 14:42 |
| ttx | That makes direct-linking to that page a bit hazardous | 14:43 |
| ttx | To reproduce: go to for example https://zuul.opendev.org/t/openstack/status, clear cookies from zuul.opendev.org, then reload page | 14:44 |
| *** sdake has quit IRC | 14:45 | |
| *** sdake has joined #zuul | 14:49 | |
| *** zbr|ssbarnea has joined #zuul | 14:53 | |
| *** zbr has quit IRC | 14:55 | |
| mordred | ttx: yes - I can verify that direct linking in that scenario does not work as expected | 14:55 |
| *** sdake has quit IRC | 14:56 | |
| mordred | this may be related to the service worker thing that we were just poking at with SpamapS and tobiash | 14:57 |
| quiquell|rover | nhicher: hello | 14:57 |
| quiquell|rover | mordred: maybe you know | 14:57 |
| quiquell|rover | mordred: after openstack RDO has update gerrit looks like host key is not compatible with paramiko | 14:58 |
| quiquell|rover | mordred: Do you know a way to force ask for RSA host key at zuul ? | 14:58 |
| quiquell|rover | mordred: similar to ssh-keyscan | 14:58 |
| nhicher | quiquell|rover: the issue is on review.rdo ? Do you have any logs ? | 14:59 |
| quiquell|rover | nhicher: yep | 15:01 |
| quiquell|rover | rlandy: | 15:01 |
| quiquell|rover | ^ | 15:01 |
| nhicher | quiquell|rover: we can swith on #rdo, it's not a zuul upstream issue | 15:01 |
| *** sdake has joined #zuul | 15:04 | |
| *** sanjayu_ has joined #zuul | 15:06 | |
| mordred | quiquell|rover, nhicher: there is an issue related to gerrit and host keys - I thnik there's some scrollback in here from a few days ago about it | 15:07 |
| quiquell|rover | mordred: nhicher is going to fix it | 15:07 |
| mordred | awesome | 15:07 |
| *** saneax has quit IRC | 15:08 | |
| *** zbr has joined #zuul | 15:13 | |
| nhicher | mordred: FYI, the issue is with gerrit 2.14, if gerrit ssh-ed25519 is defined before ssh-rsa on zuul/.ssh/known_hosts it fails | 15:14 |
| mordred | nhicher: yeah - that's the one I was thinking of! | 15:15 |
| *** zbr|ssbarnea has quit IRC | 15:15 | |
| quiquell|rover | btw, looks like paramiko bug for non RSA keys is quite old | 15:16 |
| quiquell|rover | is there any alternative for paramiko to use at zuul ? | 15:17 |
| nhicher | quiquell|rover: if you remove ssh-ed25519 from zuul/.ssh/know_hosts on your deployment, it should do the job | 15:23 |
| quiquell|rover | nhicher: the docker scheduler image has no known_hosts | 15:25 |
| quiquell|rover | docker container I mean | 15:25 |
| nhicher | quiquell|rover: ok, but the issue is how zuul-scheduler detect the key, we can't fix anything on gerrit side on sf or rdo | 15:34 |
| quiquell|rover | nhicher: I suppose is the same at software factory zuul | 15:35 |
| quiquell|rover | nhicher: Maybe we have to configure something ? | 15:35 |
| quiquell|rover | nhicher: zuul scheduler need to get the RSA version of the host key | 15:36 |
| quiquell|rover | nhicher: otherwise paramiko blows up | 15:36 |
| nhicher | quiquell|rover: on sf our solution was to remove ssh-ed25519 from know_hosts, but I don't know how your system works | 15:37 |
| quiquell|rover | nhicher: Have to be similar | 15:38 |
| quiquell|rover | rlandy: ^ so looks like we have to discover where the hell zuul-scheduler deal with known_hosts there is no file there | 15:42 |
| * rlandy reads back | 15:45 | |
| rlandy | quiquell|rover; k - let me get the latest to m test box and try it out | 15:46 |
| rlandy | quiquell|rover: I clear my testbox yesterday because I hit the selinux vpn issue | 15:46 |
| rlandy | it took me a bit to remember marios reporting that | 15:47 |
| quiquell|rover | rlandy: Thing is I don't know where zuul-scheduler get known_hosts could be memory | 15:47 |
| quiquell|rover | rlandy: sure it's not out of docker container | 15:48 |
| rlandy | does it pick up the user known_hosts? | 15:48 |
| rlandy | or /var/ssh? | 15:48 |
| corvus | rlandy: zuul-scheduler just uses the normal known hosts. | 15:51 |
| corvus | quiquell|rover: this is a gerrit bug, not a paramiko bug (you don't see this in openssh because openssh prefers the rsa keys). | 15:52 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul master: Allow run to be list of playbooks https://review.openstack.org/592160 | 15:52 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/zuul-jobs master: WIP: example of using molecule to test install-docker role https://review.openstack.org/634934 | 15:53 |
| pabelanger | tobiash: corvus: ^updated to address feedback | 15:53 |
| quiquell|rover | corvus: we are running the zuul-scheduler docker container from quick-start but there is no known_hosts | 15:54 |
| quiquell|rover | corvus: maybe we have to compose it ? | 15:54 |
| quiquell|rover | corvus: inside the docker container | 15:54 |
| *** zbr|ssbarnea has joined #zuul | 15:56 | |
| *** quiquell|rover is now known as quique|rover|off | 15:57 | |
| *** hashar has joined #zuul | 15:57 | |
| corvus | quiquell|rover: yeah, you'll need to put it in there somehow -- there's no config setting or env variable. maybe update the run command or add a volume or something. | 15:57 |
| *** zbr has quit IRC | 15:59 | |
| AJaeger | corvus, team: do you want to review the job writing guidelines for zuul-jobs in https://review.openstack.org/#/c/631507/ ? It has now four +4s and I think we should merge it since upload was on the 21st... | 16:00 |
| quique|rover|off | corvus: thanks will look tomorrow | 16:01 |
| corvus | AJaeger: yes. i have a question though -- | 16:05 |
| corvus | tobiash, mnaser: why didn't you ask zbr|ssbarnea to use the os-specific variables support described in 631507 in 633948? | 16:07 |
| zbr|ssbarnea | corvus: i will make another change to eliminate the need for the var. I was working on it now. | 16:07 |
| mnaser | corvus: reading throughout the reviews "For the moment I decided to drop the conditions and hardcode it to 'docker'. It would be up to consumer to define docker_group variable if they need. We may improve this with disto vars in another change but for the moment this should be more than ok." | 16:07 |
| corvus | zbr|ssbarnea: oh, that wasn't clear. i thought you were going to leave it for the future. | 16:08 |
| zbr|ssbarnea | corvus: i will keep the var, but its default value will be dynamic. | 16:08 |
| corvus | okay, that should be future-compatible | 16:09 |
| mnaser | right, the changed seemed like it wouldn't break anything moving backwards | 16:09 |
| zbr|ssbarnea | the main issue was that I found no way to determine the docker-group at runtime. it will have to be something like if redhat os and upstrea-docker is false use dockerroot. | 16:09 |
| corvus | i guess i just didn't see the rush -- we've got a system for handling os-specific vars, and we've more or less agreed that's what we should use in that case. why not do it right the first time? :) | 16:09 |
| corvus | zbr|ssbarnea: yes, that's exactly it. 631507 has a framework you can copy for that | 16:10 |
| zbr|ssbarnea | corvus: the problem is that knowing the os does not mean you know the docker group, depends on where are you installing docker from on that distro. | 16:11 |
| zbr|ssbarnea | corvus: but I will use that pattern anyway. i used something almost identical in other places. | 16:11 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Make install-docker compatible with centos https://review.openstack.org/633948 | 16:11 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: upload-pypi: add option to register packages https://review.openstack.org/629018 | 16:11 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Add docker insecure registries feature https://review.openstack.org/624484 | 16:11 |
| mnaser | corvus: i'll try to be more careful in the future about zuul-jobs reviews, i'll stick to +2cr for now given that zuul-jobs has probably matured a lot more since i was added to it | 16:12 |
| *** bhavikdbavishi has joined #zuul | 16:15 | |
| corvus | mnaser: well, we haven't even landed those guidelines yet :). i don't think this is a big deal, but i thought it worth talking about as we're developing things. | 16:15 |
| mordred | corvus: when you have a sec - see ttx comments from scrollback and the tobiash/SpamapS conversation --- and I'm starting to think we should try disabling service worker by default - it seems to cause issues for people and I'm not sure, given what zuul dashboard does, it's not a super big win | 16:15 |
| corvus | mordred: yeah, i was reading that. i believe i'm in favor of flipping the default. | 16:16 |
| corvus | mordred: i'm going to leave the +3 of https://review.openstack.org/631507 to you | 16:18 |
| mordred | corvus: kk | 16:18 |
| *** panda|ko is now known as panda|off | 16:22 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/zuul-jobs master: WIP: example of using molecule to test install-docker role https://review.openstack.org/634934 | 16:24 |
| zbr|ssbarnea | corvus: can you give me some hints regarding testing roles on multiple platforms? i didn't see anything being run when I raise it so that why i tried to use molecule to run it on multiple platforms. | 16:26 |
| corvus | zbr|ssbarnea: dmsimard can probably help you out, he's set up some testing there | 16:28 |
| zbr|ssbarnea | sure, i will check with him. still, my idea was that I could run the role testing locally with molecule before raising the CR to zuul, which is of great value (short feedback loop) | 16:29 |
| *** bjackman has joined #zuul | 16:32 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Disable service workers by default https://review.openstack.org/634975 | 16:35 |
| *** openstackgerrit has quit IRC | 16:35 | |
| *** bjackman has quit IRC | 16:41 | |
| SpamapS | mordred: yep, I have that first time 404 thing too | 16:46 |
| mordred | SpamapS: k. I just pushed up ^^ that patch | 16:48 |
| mordred | SpamapS: it's seeming like the service worker code is causing more problems for all of us than it's worth | 16:49 |
| mordred | corvus: I left a response to your commemnt on https://review.openstack.org/#/c/631507 - but I think it's worth +3ing already | 16:49 |
| corvus | mordred: thanks, and i agree | 16:49 |
| corvus | we can come back and elaborate on that | 16:50 |
| mordred | yeah | 16:50 |
| corvus | (i'm also wondering if we should make a skeleton role, with vars files and a conditional install loop) | 16:50 |
| corvus | so you can just copy that | 16:50 |
| mordred | corvus: maybe not a bad idea | 16:53 |
| corvus | sqlalchemy.exc.InvalidRequestError: Attribute name 'metadata' is reserved for the MetaData instance when using a declarative base class. | 17:06 |
| corvus | sigh | 17:06 |
| mordred | corvus: you have chosen ... poorly | 17:11 |
| *** openstackgerrit has joined #zuul | 17:14 | |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Propose some job writing guidelines https://review.openstack.org/631507 | 17:14 |
| SpamapS | mordred: your release note fails to parse | 17:21 |
| SpamapS | which is interesting, as I assume it was produced by reno. | 17:21 |
| mordred | SpamapS: I think I failed at indentation | 17:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Disable service workers by default https://review.openstack.org/634975 | 17:23 |
| SpamapS | mordred: indeed you did. :) | 17:24 |
| daniel2 | So in the meantime I have to get nodepool 0.5.0 working and then plan the upgrade in the future. What is the latest version of zuul to work with 0.5.0? | 17:28 |
| SpamapS | Probably 2.5.something | 17:29 |
| *** gtema has quit IRC | 17:29 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul-jobs master: Fix ownership change in stage-output https://review.openstack.org/634992 | 17:33 |
| tobiash | corvus: 633948 looked backwards compatible to me (I've pushed up a zuul change with a depends-on to verify) and I've read the comment mnaser cited above so I thought that would be ok | 17:36 |
| * tobiash is looking at 634825 now | 17:37 | |
| *** jpena is now known as jpena|off | 17:46 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Return artifacts as dicts and add metadata https://review.openstack.org/634825 | 17:49 |
| *** hashar has quit IRC | 17:51 | |
| tobiash | corvus: I like (and commented on) ^ | 17:56 |
| *** gtema has joined #zuul | 17:57 | |
| tobiash | mordred: what does that unregister do at https://review.openstack.org/#/c/634975/2/web/src/registerServiceWorker.js ? | 18:02 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Return artifacts as dicts and add metadata https://review.openstack.org/634825 | 18:03 |
| corvus | tobiash: i don't know, but i assumed it would remove the service worker from previous browser installations. or whatever that's called. at least, that's what i'm hoping. | 18:03 |
| corvus | tobiash: thanks, re 634825 -- i made a small change based on your comment | 18:04 |
| tobiash | corvus: ah maybe for the upgrade from service worker enabled deployments, thanks | 18:04 |
| tobiash | corvus: so 'a' in this case is the database model of artifact and not a dict? | 18:06 |
| corvus | tobiash: ah, yes. | 18:06 |
| tobiash | thanks so I guess a.meta is None or something but existing in any case | 18:06 |
| corvus | yep, if there was no 'metadata' entry in zuul_return for that artifact, the db field will be NULL, and the orm object attribute will be None | 18:07 |
| tobiash | k, understood, thx | 18:08 |
| *** sdake has quit IRC | 18:11 | |
| *** sanjayu_ has quit IRC | 18:16 | |
| *** sanjayu_ has joined #zuul | 18:16 | |
| mordred | tobiash: yah - it should unregister it from previous installations - at least that's the idea | 18:16 |
| tobiash | corvus: do you want to re-review 633514? PS2 was a rebase to fix a merge conflict in test_v3.py (two changes added a new test case at the bottom) | 18:17 |
| tobiash | mordred: got it, thanks | 18:17 |
| *** sanjayu__ has joined #zuul | 18:18 | |
| tobiash | mordred: I've unregistered back then by wiping the browser cache ;-) | 18:18 |
| mordred | tobiash: :) | 18:19 |
| *** sanjayu_ has quit IRC | 18:20 | |
| *** bhavikdbavishi has quit IRC | 18:39 | |
| openstackgerrit | Merged openstack-infra/zuul master: Use node v10 instead of node v8 https://review.openstack.org/632165 | 18:40 |
| mordred | corvus: https://review.openstack.org/#/c/634975/ is green now | 18:43 |
| corvus | woot, the whole stack is +3 | 18:44 |
| openstackgerrit | Merged openstack-infra/zuul master: Add react build env vars to Dockerfile https://review.openstack.org/634940 | 18:46 |
| openstackgerrit | Merged openstack-infra/zuul master: Fix wedged scheduler on force-merge of non-existing template https://review.openstack.org/633514 | 18:49 |
| *** sdake has joined #zuul | 18:52 | |
| tobiash | \o/ | 18:56 |
| *** sanjayu__ has quit IRC | 18:56 | |
| pabelanger | corvus: mordred: https://review.openstack.org/592160/ should be ready now to review again, this is list of playbooks for job.run | 18:59 |
| pabelanger | feels like we might be considering a zuul release, and wouldn't mind getting it in | 19:00 |
| tobiash | 631721 (Fix missing semaphore release on node failure) would need a second review (and should be probably considered for the next release) | 19:04 |
| mordred | tobiash: +3 | 19:07 |
| tobiash | \o/ | 19:07 |
| mordred | pabelanger: I'd like corvus to weigh in on that one since he had comments/concerns in the past | 19:08 |
| tobiash | mordred: 634634 could make our tests a bit more stable | 19:08 |
| pabelanger | mordred: me too! | 19:09 |
| mordred | tobiash: I like more stable tests | 19:09 |
| *** gtema has quit IRC | 19:09 | |
| openstackgerrit | Merged openstack-infra/zuul master: Disable service workers by default https://review.openstack.org/634975 | 19:16 |
| *** pcaruana has quit IRC | 19:27 | |
| corvus | pabelanger: okay i see what's going on now. you have misleading task names in your ansible. I read "Assert parent.txt" and assumed that the task was asserting that it existed, but it asserts that it does not exist. | 19:40 |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: [dnm] testing a low timeout on functional tests https://review.openstack.org/635020 | 19:40 |
| corvus | pabelanger: so i think my request still stands, but it's now inverted -- | 19:40 |
| openstackgerrit | Merged openstack-infra/zuul master: Fix missing semaphore release on node failure https://review.openstack.org/631721 | 19:41 |
| corvus | pabelanger: i want to make sure that the test that a child job with a list of playbooks overrides a parent job's list, and does not get combined, is really clear and robust. so you *are* asserting that parent.txt doesn't exist, which is great. but it would be good if you also had a job that asserted (when "run:" is not overridden) that it *does* exist. just to make sure the test is working. | 19:42 |
| corvus | pabelanger: i left inline comments | 19:42 |
| pabelanger | corvus: looking | 19:43 |
| pabelanger | making updates now | 19:45 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul master: Allow run to be list of playbooks https://review.openstack.org/592160 | 19:52 |
| corvus | sorry to be picky on this -- it's just this is a major point and it'll be good to not have any confusion in the tests | 19:52 |
| pabelanger | np! don't mind adding them | 19:53 |
| corvus | pabelanger: thanks, +2 tobiash ^ | 19:53 |
| pabelanger | yay | 19:53 |
| pabelanger | thank yoU! | 19:54 |
| openstackgerrit | Merged openstack-infra/zuul master: Increase timeout for zuul to settle in tests https://review.openstack.org/634634 | 19:55 |
| tobiash | lgtm | 19:58 |
| *** sshnaidm is now known as sshnaidm|afk | 19:58 | |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Fix ownership change in stage-output https://review.openstack.org/634992 | 19:58 |
| *** dkehn has joined #zuul | 20:19 | |
| *** gtema has joined #zuul | 20:25 | |
| *** zbr has joined #zuul | 20:56 | |
| *** zbr|ssbarnea has quit IRC | 20:58 | |
| *** sdake has quit IRC | 21:39 | |
| *** gtema has quit IRC | 21:43 | |
| *** mookins has joined #zuul | 22:10 | |
| *** rlandy is now known as rlandy|afk | 22:27 | |
| *** sdake has joined #zuul | 22:27 | |
| *** zbr|ssbarnea has joined #zuul | 22:32 | |
| *** zbr has quit IRC | 22:33 | |
| *** sdake has quit IRC | 22:34 | |
| *** sdake has joined #zuul | 22:36 | |
| *** zbr has joined #zuul | 22:55 | |
| *** zbr|ssbarnea has quit IRC | 22:56 | |
| *** rlandy|afk is now known as rlandy | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!