| opendevreview | Zitoun proposed openstack/cloudkitty master: CREATE INDEX idx_tenantid_begin_end ON rated_data_frames (tenant_id,begin,end) https://review.opendev.org/c/openstack/cloudkitty/+/865435 | 12:06 |
|---|---|---|
| opendevreview | guest proposed openstack/cloudkitty master: CREATE INDEX idx_tenantid_begin_end ON rated_data_frames (tenant_id,begin,end) https://review.opendev.org/c/openstack/cloudkitty/+/865435 | 12:29 |
| opendevreview | Merged openstack/cloudkitty master: Announce future deprecation of Elasticsearch https://review.opendev.org/c/openstack/cloudkitty/+/864412 | 13:37 |
| rafaelweingartner | Hello guys! | 13:58 |
| priteau | Hi | 14:00 |
| mkarpiarz | Hi! | 14:01 |
| rafaelweingartner | #startmeeting cloudkitty | 14:01 |
| opendevmeet | Meeting started Mon Nov 28 14:01:58 2022 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:01 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:01 |
| rafaelweingartner | Roll count | 14:02 |
| priteau | o/ | 14:02 |
| rafaelweingartner | \0 | 14:02 |
| mkarpiarz | Hi1 | 14:03 |
| rafaelweingartner | #topic deprecate ElasticSearch support in favor of OpenSearch | 14:04 |
| rafaelweingartner | The patch https://review.opendev.org/c/openstack/cloudkitty/+/864412 has been merged | 14:04 |
| rafaelweingartner | Therefore, we have put the announce out there | 14:04 |
| rafaelweingartner | do we need to do something else? | 14:04 |
| priteau | We may want to announce it on the ML | 14:05 |
| rafaelweingartner | Wasn't it before? | 14:05 |
| priteau | There was a message from you about Monasca | 14:07 |
| rafaelweingartner | I see, I might have mixed up things then | 14:07 |
| priteau | It was also mentioned in your Antelope summary | 14:07 |
| priteau | But I expect few people read it | 14:07 |
| rafaelweingartner | yes, I agree | 14:08 |
| rafaelweingartner | we need a separated and specific email for that | 14:08 |
| priteau | Maybe we should make a bit more progress on the OpenSearch support first | 14:08 |
| priteau | At least get it running in devstack | 14:08 |
| rafaelweingartner | I thought that iw as already being used there | 14:09 |
| rafaelweingartner | I thought that it was already being used there | 14:09 |
| priteau | What do you mean? | 14:09 |
| rafaelweingartner | in devstack, because of Kolla-ansible adoption of OpenSearch | 14:09 |
| priteau | devstack != kolla-ansible | 14:09 |
| priteau | They are entirely different projets | 14:10 |
| priteau | projects | 14:10 |
| rafaelweingartner | I know, but I thought kolla-ansible was used there | 14:10 |
| priteau | No | 14:10 |
| rafaelweingartner | I might have mistaken, just because we use kolla-ansible in our labs | 14:10 |
| rafaelweingartner | sorry for the mistake then | 14:10 |
| priteau | Currently we install ES ourselves using our devstack plugin: https://opendev.org/openstack/cloudkitty/src/branch/master/devstack/plugin.sh#L304-L314 | 14:11 |
| priteau | By we, I mean the cloudkitty CI/CD | 14:11 |
| rafaelweingartner | I see | 14:12 |
| rafaelweingartner | In theory, we could just change that, right? | 14:12 |
| rafaelweingartner | to use OpenSearch, and if they are both compatible, everything else would be fine | 14:13 |
| priteau | Plus verify that it still works ;-) | 14:13 |
| priteau | So I would like to see a bit more progress on opensearch testing, before we announce to the whole world that we are dropping it | 14:13 |
| priteau | *that we are dropping ES* | 14:13 |
| rafaelweingartner | ok | 14:13 |
| rafaelweingartner | Noted here | 14:14 |
| priteau | We could try to get it done during the next two weeks? | 14:14 |
| mkarpiarz | Will we need to add OpenSearch support to Devstack first then? | 14:14 |
| rafaelweingartner | I guess so | 14:14 |
| priteau | And if it works fine, we can announce before the end of the year | 14:14 |
| priteau | mkarpiarz: we absolutely need to test with opensearch in devstack, this is our CI/CD gate | 14:14 |
| mkarpiarz | Yes, but can we switch to a different plugin or do we have to write the OpenSearch plugin first? | 14:15 |
| priteau | There is no other plugin to switch to. This is cloudkitty's only plugin | 14:16 |
| rafaelweingartner | I guess it is compatible from what we discussed in the last meetings. Therefore, it would be a matter of changing in DevStack and then checking to see what happens | 14:16 |
| priteau | Note that Elasticsearch install is only a small part of the devstack plugin, all the other stuff stays valid. | 14:16 |
| mkarpiarz | I see. | 14:16 |
| priteau | I guess there is another decision to take | 14:17 |
| priteau | We have the storage backend type configured as [storage]/backend | 14:18 |
| priteau | Currently, influxdb or elasticsearch | 14:18 |
| priteau | Do we need to have an "opensearch" option too? | 14:19 |
| rafaelweingartner | hmm | 14:19 |
| rafaelweingartner | for now for testins we would not need | 14:19 |
| priteau | Even if the code is the same, I would guess yes. Otherwise it would be confusing. | 14:19 |
| priteau | Of course, but for shipping in the release | 14:19 |
| rafaelweingartner | however, after the deprecation, we should create OpenSearch | 14:19 |
| rafaelweingartner | and log a warning message for people using ElasticSearch type | 14:19 |
| rafaelweingartner | and then, we remove it in B release | 14:20 |
| priteau | So in Antelope, we would have the two options: elasticsearch and opensearch. And then in B, just openseaerch | 14:20 |
| rafaelweingartner | exactly | 14:21 |
| priteau | I can try to make some progress on testing during the coming cycle. | 14:22 |
| priteau | I mean, two weeks cycle. | 14:22 |
| priteau | Until the next meeting | 14:22 |
| rafaelweingartner | That would help | 14:22 |
| priteau | #action Pierre to update the devstack plugin to use OpenSearch | 14:24 |
| rafaelweingartner | I guess that is all about opensearch. Do you guys have something else to add? | 14:24 |
| priteau | No | 14:26 |
| mkarpiarz | I'll install OpenSearch in my kolla-ansible test environment and see how this goes. | 14:27 |
| priteau | mkarpiarz: the upstream support has not landed yet: https://review.opendev.org/c/openstack/kolla-ansible/+/856610 | 14:27 |
| rafaelweingartner | I see, thanks | 14:28 |
| mkarpiarz | That's fine. I'll simply replace the ElasticSearch container with the OpenSearch one. | 14:28 |
| mkarpiarz | https://opensearch.org/docs/latest/opensearch/install/docker/ | 14:28 |
| rafaelweingartner | So, moving on to the next topic. | 14:29 |
| mkarpiarz | This should tell us whether the change is likely to "just work". :) | 14:29 |
| rafaelweingartner | #topic Monasca deprecation | 14:29 |
| rafaelweingartner | I sent some emails to the community regarding this topic, but I got no feedback | 14:29 |
| rafaelweingartner | therefore, I am assuming that nobody is using it | 14:29 |
| rafaelweingartner | So, shall we move with the process? | 14:29 |
| mkarpiarz | I think so. | 14:30 |
| priteau | +1 | 14:30 |
| rafaelweingartner | Ok, so, I will add that in my list here | 14:31 |
| rafaelweingartner | Next topic | 14:33 |
| rafaelweingartner | #topic CloudKitty API reference docs (https://docs.openstack.org/cloudkitty/latest/api-reference/index.html) to https://docs.openstack.org/api-ref/ | 14:33 |
| rafaelweingartner | Do we need to do something there? | 14:33 |
| rafaelweingartner | I mean, I recall and email from Mariusz, but I am not sure about the conclusion | 14:33 |
| mkarpiarz | If we are OK with not changing v1 docs, then I'm ready to submit my changes for a review. | 14:34 |
| rafaelweingartner | I am ok with it | 14:34 |
| priteau | I am afraid I don't know the answer for this one | 14:35 |
| mkarpiarz | OK, I'll do it then and we can have a discussion in the comments. | 14:35 |
| rafaelweingartner | ok | 14:36 |
| rafaelweingartner | thanks! | 14:36 |
| rafaelweingartner | so, moving on | 14:37 |
| rafaelweingartner | #topic Target review of the meeting | 14:37 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/862824 | 14:38 |
| rafaelweingartner | It is a patch that I proposed, to add a description option in the rating definition | 14:38 |
| rafaelweingartner | Could you guys review it? | 14:38 |
| mkarpiarz | The code looks good to me. | 14:42 |
| priteau | Reviewing now | 14:43 |
| rafaelweingartner | thanks! | 14:44 |
| priteau | Please check comments | 14:44 |
| rafaelweingartner | Checked | 14:47 |
| rafaelweingartner | I would not expect the value to be replicated in the backend | 14:47 |
| rafaelweingartner | I am using the same method to store it as the "alt_name" | 14:48 |
| rafaelweingartner | I never checked thouhg in Influx how this data is persisted | 14:48 |
| rafaelweingartner | have you guys checked? | 14:48 |
| mkarpiarz | OK, I'll add this patch to my test environemnt and report back on how it looks in Influx. | 14:51 |
| rafaelweingartner | thanks! | 14:52 |
| rafaelweingartner | The other one, #link https://review.opendev.org/c/openstack/cloudkitty/+/861908 | 14:52 |
| priteau | It is stored in the datapoint itself: https://review.opendev.org/c/openstack/cloudkitty/+/862824/1/cloudkitty/dataframe.py | 14:52 |
| rafaelweingartner | I have not had time to work on it to add tempest tests for it | 14:52 |
| priteau | So I assume you will see it in every dataframe object in influxdb, and in every document in ES | 14:52 |
| rafaelweingartner | Since we are running out of time, I would like peole to check these two #https://review.opendev.org/c/openstack/cloudkitty/+/864269 and #https://review.opendev.org/c/openstack/cloudkitty/+/864578 | 14:53 |
| rafaelweingartner | they are important fixes for CloudKitty | 14:54 |
| mkarpiarz | OK | 14:54 |
| rafaelweingartner | one is an optimization to reduce the memmory footprint when loading scope IDs | 14:54 |
| rafaelweingartner | and the other is a fix for pyscripts that were not working for over 3 years | 14:54 |
| mkarpiarz | I just want to say 864578 didn't fix PyScripts in my test environment. | 14:55 |
| rafaelweingartner | What is the problem you are having? | 14:56 |
| rafaelweingartner | I am using it | 14:56 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add description option to a rating metric definition https://review.opendev.org/c/openstack/cloudkitty/+/862824 | 14:57 |
| mkarpiarz | Yeah, for me the code never enters the PyScripts constructor so this might be something with my setup. | 14:57 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Optimize Gnocchi fetcher https://review.opendev.org/c/openstack/cloudkitty/+/864269 | 14:57 |
| mkarpiarz | With either my metrics or the script. | 14:57 |
| mkarpiarz | *metrics.yml | 14:58 |
| priteau | mkarpiarz: You have enabled the pyscripts plugin? | 14:58 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Optimize Gnocchi fetcher https://review.opendev.org/c/openstack/cloudkitty/+/864269 | 14:58 |
| priteau | I will try to review these patches before the next meeting | 15:00 |
| rafaelweingartner | ok, thanks! | 15:00 |
| opendevreview | guest proposed openstack/cloudkitty master: CREATE INDEX idx_tenantid_begin_end ON rated_data_frames (tenant_id,begin,end) https://review.opendev.org/c/openstack/cloudkitty/+/865435 | 15:00 |
| rafaelweingartner | I guess that is all for today | 15:00 |
| mkarpiarz | Yes, the plugin is enabled and the script I'm using is the one mentioned in docs. | 15:00 |
| rafaelweingartner | do you guys have something else to add? | 15:00 |
| mkarpiarz | https://docs.openstack.org/cloudkitty/latest/user/rating/pyscripts.html | 15:01 |
| rafaelweingartner | mkarpiarz: the docs example would not work | 15:01 |
| rafaelweingartner | I updated the docs in my patch as well | 15:01 |
| priteau | There is this patch submitted by Olivier Chaze that we should review. | 15:01 |
| rafaelweingartner | yes, I am reviewing it | 15:01 |
| priteau | Looks like he needs some help with writing a DB migration | 15:02 |
| rafaelweingartner | I guess so | 15:02 |
| priteau | I left comments for him. | 15:04 |
| rafaelweingartner | cool, thanks | 15:04 |
| rafaelweingartner | I guess that is all then | 15:04 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 15:04 |
| mkarpiarz | Thank you! | 15:06 |
| rafaelweingartner | #endmeeting | 15:06 |
| opendevmeet | Meeting ended Mon Nov 28 15:06:33 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:06 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-11-28-14.01.html | 15:06 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-11-28-14.01.txt | 15:06 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-11-28-14.01.log.html | 15:06 |
| opendevreview | guest proposed openstack/cloudkitty master: CREATE INDEX idx_tenantid_begin_end ON rated_data_frames (tenant_id,begin,end) https://review.opendev.org/c/openstack/cloudkitty/+/865435 | 15:24 |
| opendevreview | guest proposed openstack/cloudkitty master: Create indexes to allow SQL rewrites and optimizations https://review.opendev.org/c/openstack/cloudkitty/+/865435 | 15:35 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!