| -@gerrit:opendev.org- Zuul merged on behalf of Elod Illes: [openstack/project-config] 989179: [release-tool] check-approval use only governance data https://review.opendev.org/c/openstack/project-config/+/989179 | 09:49 | |
| @harbott.osism.tech:regio.chat | new gerrit is spamming my tab list even more than before, the "Your / Changes" action now always spawns a new tab instead of reusing the current one :-/ | 06:07 |
|---|---|---|
| @harbott.osism.tech:regio.chat | it also looks like gerrit is showing false positives for merge-conflicts now, like https://review.opendev.org/c/openstack/requirements/+/987877 and https://review.opendev.org/c/openstack/requirements/+/987879 are two patches that are part of a single stack, still gerrit shows each in the merge-conflicts list for the other one, which doesn't make sense to me at all | 06:26 |
| @mordred:waterwanders.com | Jens Harbott: oh - I hadn't noticed the Your / Changes in a new tab. that's ... annoying | 10:21 |
| @tkajinam:matrix.org | I was about to report that tab behavior :-P | 14:08 |
| @tkajinam:matrix.org | it's wiered that behavior is specific to items under "your" and changes / open does not open a new tabe for example. | 14:09 |
| @clarkb:matrix.org | Jens Harbott: I wonder if it is checking them directly against each other full combinatorial mode rather than taking the tree into account | 14:25 |
| @clarkb:matrix.org | But that may explain the conflict. They would be in conflict if they didn't have a built in resolution via the tree relationship? | 14:26 |
| -@gerrit:opendev.org- Roja Eswaran proposed: [openstack/diskimage-builder] 987717: Replace debootstrap with mmdebstrap https://review.opendev.org/c/openstack/diskimage-builder/+/987717 | 14:48 | |
| @clarkb:matrix.org | for the new tab opening behavior what link are you selecting? There is no Your -> Changes option | 14:50 |
| @clarkb:matrix.org | and clicking the links under the your menu does not appear to open them in new tabs for me in firefox | 14:51 |
| @fungicide:matrix.org | i'm going to disappear shortly to grab lunch and run several errands, should be back around 17:30 unless something takes longer than planned | 15:11 |
| -@gerrit:opendev.org- Clark Boylan proposed: [opendev/system-config] 991946: Add Gerrit 3.14 image builds and testing https://review.opendev.org/c/opendev/system-config/+/991946 | 15:33 | |
| @mordred:waterwanders.com | Clark: ^^ that's what opens in a new tab for me | 16:55 |
| @clarkb:matrix.org | huh I literally do not have that link. I wonder is it possible you're still using the 3.12 web client? | 16:58 |
| @clarkb:matrix.org | I would take a screenshot but opening the screenshot tool seems to close the drop down :/ | 16:59 |
| @jim:acmegating.com | i may be in the same state as Clark | 17:00 |
| @clarkb:matrix.org | maybe I've got the old client? But I've hard refreshed many times. I have Your -> Dashboard / Draft Comments / Edits / Watched Changes / Starred Changes / All Visible Changes/ Groups | 17:01 |
| @mordred:waterwanders.com | I just tried hard-refreshing, menu is the same | 17:04 |
| @jim:acmegating.com | Clark: shift-printscr closes the menu for me, but just hitting printscr and then opening in the gimp and cropping works | 17:04 |
| @mordred:waterwanders.com | OH - well lookie there ... | 17:05 |
| @clarkb:matrix.org | I just checked the two held nodes from testing in separate/new private browsing windows to avoid caching. Logged in as Zuul and both 3.12 and 3.13 have what corvus and I are seeing | 17:05 |
| @clarkb:matrix.org | https://213.32.78.192 <- 3.12 https://158.69.71.235 <- 3.13 | 17:06 |
| @mordred:waterwanders.com | Jens Harbott: ^^ check your preferences | 17:06 |
| @jim:acmegating.com | mordred: did you create the "Unfinished" menu item? | 17:06 |
| @clarkb:matrix.org | mordred: oh interesting my config has new tab all unchecked and I guess the names are user specific defined through user config | 17:06 |
| @mordred:waterwanders.com | corvus: I think so - but like, a _loooong_ time ago? | 17:07 |
| @clarkb:matrix.org | so maybe those of us that haven't edited those entries get defaults that work the way we expect but for those of you that have edited them the new tab is added? Or vice versa | 17:07 |
| @clarkb:matrix.org | I guess that solves the mystery around the behavior but not why we have different configs. But also that probably isn't a big deal | 17:09 |
| @mordred:waterwanders.com | nah. totally solvable. also - I hadn't noticed it (because I normally have a billion tabs anyway) until Jens pointed it out. so it might not be a deep widespread issue | 17:11 |
| @clarkb:matrix.org | 991946 built and tested our first Gerrit 3.14 image and reports success on that subset of jobs (other jobs are still running). I have an appointment in a few minuets i need to pop out to but then I'll look at a followup change to test the 3.13 to 3.14 upgrade path | 17:17 |
| @clarkb:matrix.org | and then I'll work on getting the meeting agenda out. Please let me know if there is anything to add to the agenda or feel free to add it yourself | 17:18 |
| @ashinclouds:matrix.org | Question, are there any known issues post upgrade, I keep getting an error on changes about how robot comments are not allowed | 17:21 |
| @mordred:waterwanders.com | well - most relevant, robot comments aren't a thing anymore, so robots have to use normal comment api | 17:24 |
| @ashinclouds:matrix.org | I'm just using the webui and clicked into a change recently updated and got a popup error which then cleared like a minute later | 17:25 |
| @clarkb:matrix.org | ashinclouds: yes this was noted in teh announcement email | 17:26 |
| @clarkb:matrix.org | https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/thread/UIFRQR34WYMF3KDMNQFMO222DIK3HTUD/ basically the api doesn't exist anymore so you may need to hard refresh your client to get updated client code that stops fetching the api | 17:27 |
| @clarkb:matrix.org | `You can safely dismiss these error messages then perform a hard refresh of your browser client to fetch the new 3.13 client implementation which should prevent it from happening again.` | 17:27 |
| @ashinclouds:matrix.org | Hmm, interesting. Okay, thanks! | 17:27 |
| @clarkb:matrix.org | gerrit does version specific client bundles (browser specific too iirc), but for whatever reason browsers don't always see the current code as invalid when there is new code | 17:28 |
| @clarkb:matrix.org | so sometimes you need to force it via a hard refresh. This is a noticeable scenario for that because the api is simply gone and the prior version uses it | 17:28 |
| @fungicide:matrix.org | it's been that way for so many releases now, you'd think they'd have implemented client versioning with a feature to pop up a messagebox or something at least telling you that your browser window needs a hard refresh to update to the latest client (even if it's only via the oob notifications channel, which admittedly i set my browser to ignore/deny) | 17:49 |
| @ashinclouds:matrix.org | It didn't do that, just said there was an error. FWIW. I guess even with a few refreshes, its likely picking up old content from the local cache or something funky | 18:17 |
| @clarkb:matrix.org | I think you need to do a hard refresh not a normal one | 18:55 |
| @clarkb:matrix.org | ctrl + shift + r or whatever it is | 18:55 |
| @fungicide:matrix.org | yes, the gerrit webui is a monolithic javascript application implemented entirely client-side in the browser, and merely performs callouts to gerrit's rest api, so a simple reload doesn't replace the local application | 18:58 |
| @ashinclouds:matrix.org | Yeah, short of auditing the headers placed on all original respondant files, no way to really know beyond just trying again. On a plus side, it hasn't happened again today so \o/ | 19:10 |
| @clarkb:matrix.org | infra-root I've got a change to upgrade grafana here: https://review.opendev.org/c/opendev/system-config/+/991155 with a held node at https://23.253.20.165/ I've spot checked some dashboards and they seem to function. Should we go ahead and upgrade? | 19:21 |
| @mordred:waterwanders.com | Clark: my spotchecks look ok. they also underscore some opportunities for cleaning up old unused dashboards | 19:24 |
| @clarkb:matrix.org | ya grafana has been pretty append only since deleting dashboards is a bit manual iirc | 19:25 |
| @clarkb:matrix.org | but agreed we could trim down some of them | 19:26 |
| @clarkb:matrix.org | and thank you for checking | 19:26 |
| @mordred:waterwanders.com | I haven't found any that have data in prod that don't look pretty much the same on your held node | 19:26 |
| -@gerrit:opendev.org- Clark Boylan proposed: | 19:28 | |
| - [opendev/system-config] 991946: Add Gerrit 3.14 image builds and testing https://review.opendev.org/c/opendev/system-config/+/991946 | ||
| - [opendev/system-config] 992342: Test Gerrit 3.13 to 3.14 upgrades https://review.opendev.org/c/opendev/system-config/+/992342 | ||
| @fungicide:matrix.org | i'm also unsure how to go about clearing out old volumes from the afs dashboard on grafana, after deleting the references in our config didn't do it | 19:35 |
| @clarkb:matrix.org | fungi: iirc there is an api token like etheropad used to use on disk somewhere. Then we have to make an explicit api call to delete the dashboard using that api token/key | 19:38 |
| @fungicide:matrix.org | well, in the case i'm talking about, the dashboard itself is still useful it just contains some graphs that are no longer in its configuration afaict | 19:42 |
| @clarkb:matrix.org | oh I thought grafyaml will update definitions | 19:44 |
| @clarkb:matrix.org | but maybe only to graphs that you want to keep and it won't remove old graphs. In theory deleting the whole dashboard and letting grafyaml recreate it is safe | 19:44 |
| @fungicide:matrix.org | entirely possible it does and i've missed something in the cleanup | 19:44 |
| @fungicide:matrix.org | but i've been hesitant to try to remove anything else until i figure out why the removed volumes are still being displayed | 19:45 |
| @clarkb:matrix.org | if the graphs are autogenerated from graphite contents then simply removing them from afs itself may not clean up graphite so the graphs stay around too | 19:47 |
| @clarkb:matrix.org | I don't know if those graphs work that way but some of them do in grafyaml. Where you query for a set of options out of graphite then graph them from there | 19:47 |
| @fungicide:matrix.org | https://grafana.opendev.org/d/9871b26303/afs shows a graph for mirror.openeuler and i don't know where that's coming from | 19:50 |
| @fungicide:matrix.org | mirror.opensuse as well | 19:51 |
| @clarkb:matrix.org | those two seem to be explicitly defined. Here https://opendev.org/openstack/project-config/src/branch/master/grafana/afs.yaml#L513-L528 and here https://opendev.org/openstack/project-config/src/branch/master/grafana/afs.yaml#L462-L477 | 19:53 |
| @clarkb:matrix.org | So in theory we can drop them from there and grafyaml will update the existing dashboard | 19:53 |
| @fungicide:matrix.org | oh, yes i just thought to codesearch for mirror.openeuler and i guess it's not actually been deleted from the config | 19:53 |
| @fungicide:matrix.org | the others are mirror.centos and mirror.opensuse which are also still there | 19:54 |
| @fungicide:matrix.org | okay, i'll try to get that trimmed up | 19:54 |
| @fungicide:matrix.org | for some reason i expected our grafana configuration to be in opendev/system-config rather than openstack/project-config but i guess we never got around to moving it | 19:55 |
| @clarkb:matrix.org | ya it probably could/should be moved, but hasn't | 19:56 |
| @clarkb:matrix.org | This is interesting the gerrit 3.14 relaese notes indicate you need to reindex gerrit changes offline when upgrading to 3.14. But I decided to test it without that step and the logs indicate online reindexing is performed here: https://zuul.opendev.org/t/openstack/build/b21ec122793244c1878129073ef95c2a/log/review99.opendev.org/logs/error_log#144 | 20:42 |
| @clarkb:matrix.org | I guess I need to followup on that in discord | 20:42 |
| @fungicide:matrix.org | yeah, i wonder if there's something the online reindexing misses? | 20:45 |
| @clarkb:matrix.org | ya or maybe the server isn't fully compatible with version 87 and 88 at the same time? | 20:46 |
| @clarkb:matrix.org | I've just sent a query on discord and will report back if I learn anything useful | 20:46 |
| @clarkb:matrix.org | until we hear back I think we can proceed using the online reindex since the job passes. That means this stack: https://review.opendev.org/c/opendev/system-config/+/992342 should be ready for review and is ready to merge as soon as we're happy to drop 3.12 image builds | 20:48 |
| @clarkb:matrix.org | I'll be sure to put the grafana upgrade and gerrit upgrade followup stuff on the meeting agenda for tomorow | 20:48 |
| @clarkb:matrix.org | I'll put that together as soon as the school run is done | 20:48 |
| @clarkb:matrix.org | The meeting agenda has my first pass edits in it now: https://wiki.openstack.org/wiki/Meetings/InfraTeamMeeting#Agenda_for_next_meeting please let me know if I'm overlooking anything | 21:25 |
| @fungicide:matrix.org | thanks! lgtm | 21:28 |
| @diablo_rojo:matrix.org | Hello! Question! So, the FLOSS Mentoring group has reached out to me and asked to retire their ML because they have moved to google forum stuff (*cries*). How is best to do that? Just throw out a patch to delete the ML? or is there a nice way of archiving it? | 21:34 |
| @clarkb:matrix.org | I don't know that we've done one of those under mailman3 before. But I think we would pull the list out of our configuration management so that we don't try to manage it anymore then a list admin or a server admin can essentially disable the list and turn it off and put a note that it is there for historical purposes | 21:42 |
| @clarkb:matrix.org | fungi: probably has thoughts as he has done most of the list management stuff like that in hte past | 21:42 |
| @diablo_rojo:matrix.org | Okay then I can push up a patch to remove it. | 21:44 |
| @fungicide:matrix.org | yes, take it out of our config, then i'll set it to disallow all further posts and hide it from the list index | 21:45 |
| @fungicide:matrix.org | we'll keep the archives around for posterity, of course | 21:45 |
| @fungicide:matrix.org | you'll still be able to access them from direct links, but they won't be as easily discoverable | 21:45 |
| @fungicide:matrix.org | also i'll adjust the list description to note that it's retired, in case anyone directly references the list info page | 21:46 |
| -@gerrit:opendev.org- Kendall Nelson proposed: [opendev/system-config] 992370: Remove FLOSS Mentoring ML https://review.opendev.org/c/opendev/system-config/+/992370 | 21:47 | |
| @diablo_rojo:matrix.org | That is perfect. | 21:47 |
| @diablo_rojo:matrix.org | Thank you fungi . Is there anything else I need to do on my end aside from making sure the patch lands? | 21:48 |
| @mnasiadka:matrix.org | Hello | 22:00 |
| @mnasiadka:matrix.org | Clark: is there anything to do from my side to land the Prometheus patches? After that probably we could try provisioning the VM in some region and try to make it work? I might have some time in the remaining of this week to address some comments if they arise | 22:02 |
| @clarkb:matrix.org | mnasiadka: I think its mostly about reviews at this point. Then ya we can boot the node and add the deployment jobs (the current chagnes don't have deployment jobs yet which is fine we can add those when we update the inventory) | 22:05 |
| @clarkb:matrix.org | I'll rereview them now as it looks like there are updates since I last looked | 22:06 |
| @mnasiadka:matrix.org | Thanks | 22:06 |
| @mnasiadka:matrix.org | 11pm here, but happy to address anything in my morning | 22:07 |
| @fungicide:matrix.org | diablo_rojo: no, nothing else for you, just remind me i said all these things since i have a mind like a steel sieve | 22:11 |
| @fungicide:matrix.org | just ping me when you push the patch and i'll review/approve, then take care of the additional steps myself | 22:12 |
| @fungicide:matrix.org | it's not a thing we do often, so kinda off-the-cuff and i'll figure it out as i go | 22:12 |
| @clarkb:matrix.org | mnasiadka: ok I +2'd the changes but left some thoughts on how some additional small improvements can be made. I don't think those need to be done in these changes if we prefer using followup changes. I'll defer that decision to you and then do my best to review things however they get pushed | 22:44 |
| @clarkb:matrix.org | I got a response about Gerrit online vs offline reindexing for the 3.14 upgrade. Sounds like the main consideration there is gerrit performance. It wasn't explicitly stated but seems implied this particular reindexing is computationally expensive so you may not want it to be running while the server is also running. Given that we probably should consider doing the offline reindexing so that it can be completed and over with before starting gerrit back up. But I'll try to learn more about this | 23:04 |
| -@gerrit:opendev.org- Zuul merged on behalf of Kendall Nelson: [opendev/system-config] 992370: Remove FLOSS Mentoring ML https://review.opendev.org/c/opendev/system-config/+/992370 | 23:04 | |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!