*** yoctozepto8 is now known as yoctozepto | 00:33 | |
*** yoctozepto6 is now known as yoctozepto | 01:21 | |
*** yoctozepto3 is now known as yoctozepto | 02:12 | |
*** yoctozepto8 is now known as yoctozepto | 03:43 | |
*** yoctozepto8 is now known as yoctozepto | 03:57 | |
*** yoctozepto0 is now known as yoctozepto | 04:12 | |
*** yoctozepto1 is now known as yoctozepto | 04:40 | |
*** yoctozepto7 is now known as yoctozepto | 05:43 | |
yoctozepto | #startmeeting masakari | 06:10 |
---|---|---|
opendevmeet | Meeting started Tue Aug 24 06:10:28 2021 UTC and is due to finish in 60 minutes. The chair is yoctozepto. Information about MeetBot at http://wiki.debian.org/MeetBot. | 06:10 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 06:10 |
opendevmeet | The meeting name has been set to 'masakari' | 06:10 |
yoctozepto | \o/ | 06:10 |
yoctozepto | (we need to reschedule or just accept this delay) | 06:10 |
yoctozepto | (the daylight time saving will go away soon though so I will change my habits anyhow, let's see then) | 06:11 |
yoctozepto | anyone else around? | 06:12 |
yoctozepto | suzhengwei, shenxinxin? | 06:13 |
yoctozepto | let me kickstart the meeting by a quick announcement | 06:14 |
suzhengwei | sorry, I am here | 06:14 |
yoctozepto | http://lists.openstack.org/pipermail/openstack-discuss/2021-August/024253.html | 06:14 |
yoctozepto | ^ I have nominated myself for the role of PTL for another cycle | 06:15 |
suzhengwei | ok | 06:17 |
shenxinxin | ok | 06:19 |
yoctozepto0 | meh, internet issues it seems | 06:20 |
yoctozepto0 | I was writing that | 06:20 |
yoctozepto0 | you can still nominate yourself if any of you want to be the PTL | 06:21 |
yoctozepto0 | I can help with the process | 06:21 |
yoctozepto0 | anyhow, the project has its future secured for now | 06:21 |
yoctozepto0 | let's start with the agenda | 06:21 |
yoctozepto0 | * CI status | 06:21 |
yoctozepto0 | * Important pending reviews (important bugfixes, backports) | 06:21 |
yoctozepto0 | * Next release planning | 06:21 |
yoctozepto0 | * Open discussion | 06:21 |
yoctozepto0 | #topic CI status | 06:21 |
yoctozepto0 | seems green | 06:22 |
yoctozepto0 | I want to extend our CI coverage though, expect more jobs running around | 06:23 |
yoctozepto0 | #topic Important pending reviews (important bugfixes, backports) | 06:23 |
yoctozepto0 | I don't think we have any but let's check | 06:23 |
*** yoctozepto0 is now known as yoctozepto | 06:24 | |
suzhengwei_ | yes, none. | 06:26 |
yoctozepto | yes | 06:27 |
yoctozepto | my internet connection is lagging greatly | 06:27 |
yoctozepto | #topic Next release planning | 06:27 |
yoctozepto | ok, so I looked at the current situation | 06:27 |
yoctozepto | and we don't have much time left | 06:27 |
yoctozepto | I suggest we focus on a single feature for this cycle :-( | 06:28 |
suzhengwei_ | agree | 06:28 |
yoctozepto | I think consul-based monitoring would be best | 06:28 |
yoctozepto | as it has the least of interdependencies and has been discussed the most | 06:28 |
yoctozepto | and it seems directly valuable to the community | 06:28 |
yoctozepto | what do you think? | 06:29 |
suzhengwei_ | Let's try our best to complete Xena release. | 06:30 |
yoctozepto | indeed, but what should we focus on? I suggested consul | 06:31 |
suzhengwei_ | Consul driverd hostmonitor is most potential. | 06:32 |
suzhengwei_ | me too | 06:32 |
yoctozepto | ok, great | 06:32 |
yoctozepto | then we have consensus :-) | 06:32 |
yoctozepto | #agreed focus on consul-based hostmonitor as the flag feature of this cycle (xena) | 06:33 |
yoctozepto | ok, so, focusing on that... I see you have updated the spec, thanks | 06:33 |
yoctozepto | I see also it fails in CI | 06:34 |
yoctozepto | I will fix it | 06:34 |
suzhengwei_ | a little weird. No file added or deleted. | 06:35 |
suzhengwei_ | It passed last time but failed this time. | 06:36 |
yoctozepto | suzhengwei_: it just says "/home/zuul/src/opendev.org/openstack/masakari-specs/doc/source/specs/xena/approved/host-monitor-by-consul.rst:76:Blank line required after table." | 06:36 |
yoctozepto | so it's a simple fix ;-) | 06:36 |
suzhengwei_ | It gives me misunderstood message. | 06:37 |
suzhengwei_ | stderr: 'fatal: There is no path doc/source/specs/xena/approved/host-monitor-by-consul.rst in the commit | 06:37 |
opendevreview | Radosław Piliszek proposed openstack/masakari-specs master: host monitor by consul https://review.opendev.org/c/openstack/masakari-specs/+/734017 | 06:38 |
yoctozepto | suzhengwei_: nah, ignore that because zuul tries to match the ephemeral file to files in the commit | 06:38 |
yoctozepto | just read the job logs | 06:39 |
yoctozepto | if you click on the job that failed | 06:39 |
yoctozepto | you get to a screen with results | 06:39 |
suzhengwei_ | thanks for your fix. | 06:39 |
yoctozepto | could you update the image? | 06:43 |
yoctozepto | if it's too hard, I can just write in text that it's inaccurate and should be interpreted differently | 06:43 |
suzhengwei_ | It's really tough to edit the image. | 06:47 |
yoctozepto | ok | 06:48 |
yoctozepto | I will add a sufficient description and we can merge | 06:49 |
yoctozepto | how's the implementation? is it now following the current spec? | 06:49 |
suzhengwei_ | yes, it follows the spec. | 06:50 |
yoctozepto | ok | 06:50 |
yoctozepto | we also need a way to deploy consul; I want to avoid the situation with current hostmonitor where it's not documented well nor tested thoroughly in CI | 06:51 |
suzhengwei_ | I add a simple doc about consul usage. | 06:52 |
suzhengwei_ | I would like to give some help to deploy guide in kolla or other tools. | 06:53 |
suzhengwei_ | Would you like try to | 06:54 |
suzhengwei_ | integrate it with Kolla? | 06:54 |
suzhengwei_ | :) | 06:55 |
yoctozeptoclone | I have no idea if there were any replies nor if my messages went through | 06:57 |
yoctozeptoclone | the internet connection is a joke today | 06:57 |
yoctozeptoclone | my last message was: | 06:58 |
yoctozeptoclone | we also need a way to deploy consul; I want to avoid the situation with current hostmonitor where it's not documented well nor tested thoroughly in CI | 06:58 |
suzhengwei_ | I add a simple doc about consul usage. I would like to give some deploy guide. | 06:59 |
yoctozepto9 | ok, very well | 06:59 |
suzhengwei_ | Would you like try to integrate it with Kolla? :) | 06:59 |
yoctozepto9 | yeah, I was planning to but I can't promise delivery in this cycle unless someone helps :-) | 07:00 |
yoctozepto9 | ok, need to wrap up; the time is up | 07:00 |
*** yoctozepto9 is now known as yoctozepto | 07:00 | |
yoctozepto | thank you for the discussion today | 07:00 |
yoctozepto | #endmeeting | 07:00 |
opendevmeet | Meeting ended Tue Aug 24 07:00:38 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 07:00 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/masakari/2021/masakari.2021-08-24-06.10.html | 07:00 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/masakari/2021/masakari.2021-08-24-06.10.txt | 07:00 |
opendevmeet | Log: https://meetings.opendev.org/meetings/masakari/2021/masakari.2021-08-24-06.10.log.html | 07:00 |
shenxinxin | yoctozepto:I want to talk about this spec:vm evacuations for host recovery. | 07:36 |
yoctozepto | shenxinxin: as long as my internet allows, we can discuss :-) did not we merge that spec? I think only the implementation remains | 07:38 |
shenxinxin | I think this spec should be adjusted by adding "id" field to the evacuation table.:) | 07:42 |
shenxinxin | I found that many DBdata in the code include id when displaying the results. If the sorting key is not specified, default_keys will be used. Default_keys contains create_at and id. Please see https://github.com/openstack/masakari/blob/master/masakari/db/sqlalchemy/api.py#L138 | 07:43 |
yoctozeptoclone | meh, the internet really is a joke today | 07:49 |
yoctozeptoclone | regarding the topic | 07:49 |
yoctozeptoclone | id is legacy; we should use uuid as planned | 07:49 |
yoctozeptoclone | let's make sure it works with uuids | 07:50 |
yoctozeptoclone | shenxinxin: ^^^ | 07:51 |
*** yoctozepto1 is now known as yoctozepto | 07:52 | |
shenxinxin | But this kind of error will appear in my actual use: | 07:58 |
shenxinxin | File "/opt/shen/masakari/masakari/db/sqlalchemy/api.py", line 740, in evacuation_get_all_by_filters | 07:58 |
shenxinxin | raise exception.InvalidSortKey(err) | 07:58 |
shenxinxin | masakari.exception.InvalidSortKey: Sort key supplied is invalid: id | 07:58 |
shenxinxin | :) | 07:58 |
yoctozeptoclone | you just need to customise the sort keys | 08:01 |
shenxinxin | Will this not add default_keys to result_keys? https://github.com/openstack/masakari/blob/master/masakari/db/sqlalchemy/api.py#L181 | 08:10 |
yoctozeptoclone | shenxinxin: just modify default_keys? | 08:20 |
yoctozeptoclone | they can be modified on call | 08:20 |
shenxinxin | OK, I got it. Thanks. | 08:24 |
yoctozeptoclone | you are welcome :-) | 08:40 |
* yoctozeptoclone off | 08:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!