gouthamr | #startmeeting manila | 15:00 |
---|---|---|
opendevmeet | Meeting started Thu Jun 17 15:00:27 2021 UTC and is due to finish in 60 minutes. The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'manila' | 15:00 |
carloss | o/ | 15:00 |
dviroel | o/ | 15:00 |
caiquemello | o/ | 15:00 |
vhari | hi | 15:00 |
kafilat | o/ | 15:01 |
gouthamr | courtesy ping: ganso vkmc tbarron felipe_rodrigues ecsantos vhari | 15:01 |
felipe_rodrigues | hi | 15:01 |
ecsantos | o/ | 15:01 |
vkmc | o/ | 15:01 |
gouthamr | hello folks! | 15:01 |
gouthamr | thank you for joining! here's our agenda for today: https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting | 15:02 |
gouthamr | lets get started | 15:02 |
gouthamr | #topic Announcements | 15:02 |
tbarron | hi | 15:02 |
fabiooliveira | o/ | 15:02 |
* gouthamr was hunting for a link | 15:03 | |
gouthamr | wanted to give a shout out to vkmc archanaserver ashrod98 and diablo_rojo for today's openinfra.live talk | 15:04 |
gouthamr | if anyone's got a link to the live stream that just ended, please add it here :) | 15:04 |
vhari | How to Start Contributing Upstream to OpenInfra https://www.youtube.com/watch?v=4kGtM4J_hjM | 15:04 |
vhari | :) | 15:04 |
gouthamr | vhari++ | 15:04 |
gouthamr | #link https://www.youtube.com/watch?v=4kGtM4J_hjM (How to Start Contributing Upstream to OpenInfra) | 15:05 |
vkmc | :D | 15:05 |
vhari | vkmc++ | 15:05 |
gouthamr | if you didn't get a chance to attend, please check it out; our community was well represented! :) | 15:05 |
vkmc | thanks gouthamr++ | 15:05 |
gouthamr | there's a lot to take away from that talk.. | 15:06 |
gouthamr | on our regular announcements :), we're 16 weeks away from the Xena release | 15:07 |
gouthamr | #link https://releases.openstack.org/xena/schedule.html (Xena Schedule) | 15:07 |
gouthamr | Next week is our spec submission deadline | 15:07 |
gouthamr | if you're thinking about writing a spec/lite-spec, this is the last call | 15:08 |
gouthamr | that's all i had for announcements today | 15:09 |
gouthamr | does anyone else have any? | 15:09 |
gouthamr | thank you all for participating in the bug squash last week! | 15:10 |
gouthamr | and for vhari, vkmc for the efforts in organizing it. I definitely enjoyed our very first collab review for the release | 15:11 |
vhari | gouthamr, we had a great turnout \o/ | 15:11 |
vhari | thanks everyone! | 15:11 |
gouthamr | we'll discuss some untriaged bugs later in this meeting - and we must be able to share some statistics/summary with you next week | 15:12 |
gouthamr | lets move down our agenda | 15:12 |
gouthamr | #topic Manila UI stable CI problems | 15:13 |
gouthamr | we had users report a peculiar problem with manila-ui downstream, that wasn't easy to reproduce | 15:13 |
gouthamr | the issue is described in https://bugs.launchpad.net/manila-ui/+bug/1931641 | 15:13 |
gouthamr | #link https://bugs.launchpad.net/manila-ui/+bug/1931641 (Unable to select share networks with share types that have a hyphen in their name) | 15:14 |
gouthamr | #link https://review.opendev.org/c/openstack/manila-ui/+/796384 (Fix parsing names in switched fields) | 15:14 |
gouthamr | the fix is really a workaround | 15:15 |
gouthamr | we've rarely back-ported fixes to older stable branches in manila-ui | 15:15 |
gouthamr | but this is one of those critical bugs for end users that needs to be addressed all the way back to stable/train | 15:16 |
gouthamr | so, looking at the backports, i ran into a familiar issue on the stable branches for manila-ui | 15:17 |
gouthamr | the lower-constraints job fails | 15:17 |
gouthamr | the failure is legitimate; some of the lower bounds of the requirements we claim aren't really co-installable | 15:18 |
gouthamr | we've approached this by painstakingly fixing them up on stable branches for the manila repo | 15:19 |
gouthamr | however, i'm not convinced if the effort is worth it for anyone | 15:19 |
gouthamr | iirc we fixed requirement and lower-constraints files for stable branches of manila and python-manilaclient repos | 15:20 |
gouthamr | and disap fixed the development branch of manila-ui earlier this year: https://review.opendev.org/c/openstack/manila-ui/+/767397 | 15:21 |
gouthamr | post these, we had a discussion as a community to verify who cares about lower bounds testing | 15:22 |
gouthamr | this discussion was summarized here | 15:23 |
gouthamr | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-March/021204.html ([all][tc] Dropping lower-constraints testing from all projects) | 15:23 |
gouthamr | since we have the job working on the development branches in all the repos we maintain, i don't want to discuss dropping the job across the repos | 15:24 |
gouthamr | i wanted to check however, if we're okay dropping them in manila-ui | 15:24 |
gouthamr | the main reason is that backports here have been rare | 15:25 |
gouthamr | and second is the learning we have from the community-wide discussion that lower-constraints testing the way we do is less useful to consumers | 15:26 |
gouthamr | we could also take a bigger blanket discussion of dropping it across all stable branches - something that some other project teams have done | 15:27 |
tbarron | fwiw I agree with this. We need to focus on fixing test infra issues where fixing test failures makes our core product better and | 15:28 |
tbarron | I don't see gain commensarate with maintenance effort for this on the stable branches | 15:28 |
gouthamr | ++ it makes lesser sense as we go back to the really old branches we are talking about | 15:29 |
vkmc | ++ agree too | 15:29 |
carloss | ++ | 15:30 |
gouthamr | does it make sense to vote on this and drop the jobs across all stable branches? | 15:30 |
gouthamr | #startvote Should we drop lower-constraints testing on all stable branches of manila repos? Yes, No | 15:33 |
opendevmeet | Begin voting on: Should we drop lower-constraints testing on all stable branches of manila repos? Valid vote options are Yes, No. | 15:33 |
opendevmeet | Vote using '#vote OPTION'. Only your last vote counts. | 15:33 |
gouthamr | ^ please go ahead :) | 15:33 |
tbarron | #vote yes | 15:33 |
carloss | #vote Yes | 15:33 |
tbarron | #vote yes | 15:33 |
opendevmeet | tbarron: yes is not a valid option. Valid options are Yes, No. | 15:33 |
tbarron | testing | 15:33 |
dviroel | #vote Yes | 15:33 |
ecsantos | #vote Yes | 15:33 |
tbarron | #vote Yes | 15:33 |
vkmc | #vote yes | 15:33 |
gouthamr | #vote Yes | 15:34 |
fabiooliveira | #vote Yes | 15:34 |
caiquemello | #vote Yes | 15:34 |
gouthamr | waiting another minute | 15:35 |
gouthamr | #endvote | 15:37 |
opendevmeet | Voted on "Should we drop lower-constraints testing on all stable branches of manila repos?" Results are | 15:37 |
opendevmeet | Yes (8): dviroel, caiquemello, gouthamr, tbarron, carloss, fabiooliveira, ecsantos, vkmc | 15:37 |
tbarron | good, it only let me vote once | 15:37 |
gouthamr | awesome, thanks everyone; i've patches ready for train--->victoria on manila-ui | 15:37 |
gouthamr | #link https://review.opendev.org/q/topic:%22drop-lower-constraints-testing%22+(status:open%20OR%20status:merged) | 15:37 |
gouthamr | #agreed we're dropping lower-constraints testing on all stable branches across manila repositories | 15:38 |
gouthamr | if you see missing branches, let me know, or go ahead and submit a fix if you like | 15:38 |
gouthamr | code deletions are fun | 15:39 |
vkmc | :D | 15:39 |
gouthamr | cool, anything else regarding $topic? | 15:40 |
gouthamr | #topic Reviews needing attention | 15:40 |
gouthamr | #link https://etherpad.opendev.org/p/manila-xena-review-focus | 15:40 |
gouthamr | it looks like everything on here is still getting worked on, or waiting for review | 15:40 |
gouthamr | if there are any more, please add them to the list | 15:41 |
gouthamr | reviewers (telling myself as well), please take a look at this list and lets wrap these up | 15:41 |
gouthamr | lets move on to bug triage since we know we left some for this meeting | 15:42 |
gouthamr | #topic Bugs (vhari) | 15:42 |
gouthamr | o/ vhari - the floor is yours | 15:42 |
vhari | gouthamr, there were no new bugs in 2 weeks :D | 15:42 |
gouthamr | \m/ | 15:42 |
vkmc | :D | 15:42 |
gouthamr | our work is done | 15:43 |
vhari | so, we can pick up where we left off at bug squash | 15:43 |
* gouthamr not so fast | 15:43 | |
vhari | we can take a look at #link https://bugs.launchpad.net/manila/+bug/1881865 | 15:43 |
vhari | and pace through the list as time permits | 15:44 |
gouthamr | ack | 15:44 |
gouthamr | #link https://bugs.launchpad.net/manila/+bug/1881865 | 15:44 |
* gouthamr rebases the fix | 15:45 | |
gouthamr | carloss: o/ this fix is not exercisable in isolation, no? | 15:45 |
gouthamr | so i kinda see haixin's point of combining the snapshot querying into this | 15:46 |
carloss | yeah | 15:47 |
carloss | me too... | 15:47 |
carloss | I gues I even mentioned breaking this change into two in the past | 15:47 |
gouthamr | haha, okay this is ripe for re-review then | 15:48 |
carloss | but haixin's made his point explaining that it would be nice to have both in a single patch | 15:48 |
carloss | yep :) | 15:48 |
gouthamr | awesome, thanks for bubbling this up vhari | 15:49 |
gouthamr | we'll get this one reviewed and merged | 15:49 |
vhari | cool gouthamr | 15:49 |
vhari | time for one more | 15:49 |
vhari | #link https://bugs.launchpad.net/manila/+bug/1818569 | 15:49 |
vhari | proposed fix merged .. can be close if no more thought on it | 15:50 |
vhari | #link https://bugs.launchpad.net/manila/+bug/1818569 | 15:51 |
gouthamr | hmm, i recall this bug | 15:52 |
gouthamr | but don't recall discussing at a ptg per the bug report | 15:52 |
gouthamr | the problem here is that the access rule de-duplication code doesn't seem to work with high concurrency | 15:54 |
tbarron | The reason I did that experiment was that we saw the issue intermittently in CI | 15:55 |
gouthamr | i think the duplicate rules get past the check happening in the database in parallel and avoid each other - which i can see happening, there's nothing preventing that code to run in parallel | 15:55 |
gouthamr | oh | 15:55 |
tbarron | Dunno if we still do much though | 15:56 |
gouthamr | not latelyt | 15:56 |
tbarron | It may not be a likely customer scenario | 15:56 |
gouthamr | but, if its easily reproducible with the script you have in the bug report - its a corner case that we ought to fix | 15:57 |
tbarron | Yeah, it's worth fixing, just questioning why I set it to Medium | 15:57 |
gouthamr | ack, we can set to Low, anyone looking for a good concurrency bug to fix? | 15:58 |
kiwi_36 | I can pick it up gouthamr | 15:59 |
gouthamr | o/ kiwi_36 | 15:59 |
gouthamr | ++ awesome, please grab it | 15:59 |
kiwi_36 | \o | 16:00 |
gouthamr | alright, we're at the top of the hour | 16:00 |
gouthamr | no time for open discussion today | 16:00 |
gouthamr | please hop on over to #openstack-manila if you want to chat about anything else | 16:00 |
gouthamr | thank you all for attending! | 16:00 |
gouthamr | stay safe | 16:00 |
gouthamr | #endmeeting | 16:00 |
opendevmeet | Meeting ended Thu Jun 17 16:00:54 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2021/manila.2021-06-17-15.00.html | 16:00 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2021/manila.2021-06-17-15.00.txt | 16:00 |
opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2021/manila.2021-06-17-15.00.log.html | 16:00 |
*** dviroel is now known as dviroel|away | 18:05 | |
*** dviroel|away is now known as dviroel | 18:53 | |
archanaserver | thanks gouthamr :) | 19:06 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!