*** dviroel|out is now known as dviroel | 11:18 | |
rosmaita | #startmeeting cinder | 14:00 |
---|---|---|
opendevmeet | Meeting started Wed Sep 22 14:00:33 2021 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
opendevmeet | The meeting name has been set to 'cinder' | 14:00 |
rosmaita | #topic roll call | 14:00 |
simondodsley | Hi | 14:00 |
e0ne | hi | 14:00 |
eharney | hi | 14:00 |
enriquetaso | hi | 14:00 |
walshh_ | Hi | 14:01 |
whoami-rajat | Hi | 14:01 |
fabiooliveira | hi | 14:02 |
TusharTgite | hi | 14:02 |
tosky | hi | 14:02 |
rosmaita | hello everyone | 14:02 |
rosmaita | let's get started | 14:02 |
rosmaita | #link https://etherpad.opendev.org/p/cinder-xena-meetings | 14:02 |
rosmaita | #topic announcements | 14:03 |
rosmaita | we will be doing an RC-2 | 14:03 |
rosmaita | there are some requirements changes that we needed to make, and some release critical bugs | 14:03 |
rosmaita | we'll go over those in a few minutes | 14:03 |
rosmaita | i'll just continue with the announcements | 14:03 |
hemna | hi | 14:04 |
rosmaita | next week is the final Release Candidate | 14:04 |
rosmaita | traditionally on Thursday | 14:04 |
rosmaita | we'll talk about whether we should do an RC-2 quickly and then possibly another, or just do an RC-2 | 14:04 |
rosmaita | next announcement: | 14:05 |
rosmaita | next week's meeting is the last of the month, so will be our usual video meeting | 14:05 |
rosmaita | next, the Outreachy proposal deadline is 29 September | 14:05 |
rosmaita | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-September/024992.html | 14:06 |
rosmaita | you can read ^^ to see what that's about | 14:06 |
rosmaita | i don't know whether i will put in a proposal or not | 14:06 |
rosmaita | it's a good mentoring opportunity, if you would like to do that | 14:07 |
rosmaita | and might get some work done on cinder | 14:07 |
rosmaita | let me know if you are interested, and i will work with you to get a proposal together | 14:07 |
rosmaita | but think about it fast, because the proposal is due in one week | 14:08 |
rosmaita | finally, the Yoga PTG is the week of 18 October | 14:08 |
rosmaita | #link https://etherpad.opendev.org/p/yoga-ptg-cinder-planning | 14:08 |
rosmaita | add topics to ^^ | 14:08 |
rosmaita | also, info is on the etherpad for registering for the PTG | 14:08 |
rosmaita | it's free, but the foundation asks you to register | 14:09 |
rosmaita | i guess so that they can remind you about the code of conduct | 14:09 |
rosmaita | i think that's all | 14:09 |
rosmaita | #topic RC-2 | 14:10 |
rosmaita | #link https://etherpad.opendev.org/p/cinder-xena-final-patches-for-RC | 14:10 |
rosmaita | ok, please open ^^ | 14:10 |
rosmaita | since the stable/xena branch has been cut, everything must merge first to master and then be backported to stable/xena | 14:10 |
rosmaita | there are a few requirements changes we have to make | 14:11 |
rosmaita | namely, raising the minimum in requirements.txt | 14:11 |
rosmaita | i think everything has merged to master at this point, but we need to get teh backports merged too | 14:12 |
rosmaita | so stable cores, please note the etherpad and keep an eye on it | 14:12 |
rosmaita | after we found a few minimum versions of some requirements that broke tests, i put together a quick lower-constraints kind of job | 14:13 |
rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/810131 | 14:13 |
rosmaita | ^^ if anyone wants to check my work | 14:13 |
rosmaita | all the tests passed with the current xena backports and the generated lower constraints file | 14:13 |
rosmaita | so, everything seems to work with the current requirements minima (after the patches on lines 1-18 on the etherpad merge) | 14:14 |
rosmaita | but, i noticed a few things that might be a bit out of whack: | 14:14 |
rosmaita | #link https://paste.opendev.org/raw/809501/ | 14:14 |
rosmaita | so, please open ^^ so we can discuss | 14:14 |
rosmaita | btw, i did not check all our requirements against current upper constraints, just some that i thought might be worth looking at | 14:15 |
rosmaita | you can see that for pretty much all the oslo stuff, there are only minor version changes, so i don't think we need to worry about them | 14:16 |
rosmaita | the exceptions are oslo.db and PyMySQL | 14:16 |
eharney | i think our PyMySQL req is only for tests so it's not very interesting | 14:16 |
rosmaita | here's the change log for oslo.db: | 14:16 |
rosmaita | #link https://paste.opendev.org/raw/809503/ | 14:16 |
rosmaita | there doesn't look like a lot in there, but i wonder whether we should raise the min to the xena release of oslo.db ? | 14:17 |
rosmaita | to remind you what this means: | 14:17 |
rosmaita | we are testing (usually) with whatever is in upper constraints | 14:18 |
rosmaita | so all the recent jobs are using oslo.db 11.0.0 | 14:18 |
rosmaita | for the past few weeks | 14:18 |
rosmaita | but if the min in requrements is 8.4.0, then we are saying that it's ok to package cinder with oslo.db 8.4.0 | 14:19 |
rosmaita | and that may be fine, all our unit tests pass with that version | 14:19 |
eharney | we should raise it IMO | 14:19 |
rosmaita | eharney: ty, i agree | 14:19 |
rosmaita | anyone else? | 14:20 |
e0ne | +1 | 14:20 |
rosmaita | thanks ivan | 14:20 |
rosmaita | ok, i will put up a patch | 14:20 |
rosmaita | #action rosmaita patch to raise oslo.db min in requirements to 11.0.0 | 14:20 |
rosmaita | ok, the other one is PyMySQL | 14:20 |
rosmaita | the changelog is here: | 14:20 |
rosmaita | #link https://github.com/PyMySQL/PyMySQL/blob/main/CHANGELOG.md | 14:21 |
rosmaita | it looks to me like the major changes are to remove py2.7 and py3.5 support | 14:21 |
rosmaita | and stop supporting MySQL 5.5 (which we talked about last week!) | 14:22 |
rosmaita | i think we should probably raise this one too ... any thoughts? | 14:23 |
eharney | i'm not sure we should depend on it directly | 14:24 |
eharney | see https://opendev.org/openstack/oslo.db/src/branch/master/setup.cfg#L25 | 14:24 |
e0ne | what version of mysql is available in official repos of supported OSes? | 14:24 |
rosmaita | e0ne: not sure | 14:25 |
rosmaita | eharney: you have a good point, we should probably let oslo.db set the version | 14:26 |
rosmaita | ok, so for pymysql i propose to do nothing | 14:29 |
rosmaita | not as big a deal, it's in test-requrements whereas oslo.db is in real requirements.txt | 14:29 |
eharney | sounds good | 14:29 |
rosmaita | ok, thanks | 14:30 |
rosmaita | on to some release critical bugs | 14:30 |
rosmaita | line 23 in https://etherpad.opendev.org/p/cinder-xena-final-patches-for-RC | 14:30 |
rosmaita | this was reported for nova, but since we have a lot of the same changes for the sqlalchemy-migrate -> alembic transition, it probably applies to us too | 14:31 |
enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/810288 | 14:31 |
enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/810000 | 14:31 |
rosmaita | the two patches for master look ok, one is in recheck | 14:31 |
rosmaita | thanks enriquetaso | 14:31 |
rosmaita | so i think we need to get these reviewed, merged, and backported befor RC2 | 14:32 |
rosmaita | next one is the cgroupv2 thing: https://bugs.launchpad.net/cinder/+bug/1942203 | 14:32 |
rosmaita | i will try to get a patch up for that one in the next day or two | 14:33 |
rosmaita | i'm not sure how many people actually use the throttling | 14:33 |
rosmaita | but it would be better to have it fixed for the release than not | 14:33 |
rosmaita | next one is a bug that maybe requires a "known issue" release note | 14:34 |
rosmaita | #link https://bugs.launchpad.net/cinder/+bug/1909207 | 14:34 |
rosmaita | i think at one point we were thinking this might not be a bug? | 14:35 |
enriquetaso | 1909207 i think this issues isn't a rbd problem so far | 14:35 |
eharney | this probably does need more investigation | 14:36 |
eharney | it was on my list at one point but clearly i lost track of it | 14:36 |
enriquetaso | maybe we can ask for the backend xuanyandong is using | 14:36 |
eharney | we can just try to reproduce it | 14:37 |
eharney | and investigate if this is a thing that can happen | 14:37 |
rosmaita | does anyone have time to look at this before the next meeting? | 14:37 |
rosmaita | we can always have in "known issues" that this has been reported and may affect some backends | 14:39 |
enriquetaso | sounds good, I'm going PTO but I can try to reproduce it for next meeting. | 14:39 |
rosmaita | merging a release note is pretty fast, so we can decide next week | 14:39 |
rosmaita | thanks enriquetaso | 14:39 |
rosmaita | since enriquetaso will be on pto, though, if anyone else is interested in this, would be good to help out | 14:40 |
rosmaita | ok, we have another known issue that we discussed at the midcycle | 14:40 |
rosmaita | #link https://wiki.openstack.org/wiki/CinderXenaMidCycleSummary#what_to_do_about_qcow2-v2_support_being_yanked_from_various_linux_distros | 14:40 |
rosmaita | there was an action item to look into this | 14:41 |
rosmaita | what i found out is that we do look at whether the volume being managed is actually a qcow2 | 14:41 |
rosmaita | but we only reject it if it has a backing file | 14:41 |
rosmaita | (because that's a security issue) | 14:41 |
rosmaita | i will write up a release note patch and bug people to review it | 14:42 |
rosmaita | as far as issues for the xena release, that's all i'm aware of | 14:42 |
rosmaita | anyone here run into anything? | 14:43 |
rosmaita | enriquetaso: that rbd trash bug might be a candidate | 14:44 |
rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/810402 | 14:44 |
enriquetaso | yes | 14:45 |
enriquetaso | I think we may want ^ merged before RC1 | 14:45 |
rosmaita | well, RC2, anyway | 14:45 |
rosmaita | let's discuss at the bug meeting, then | 14:46 |
enriquetaso | sure | 14:46 |
rosmaita | #topic deprecations | 14:46 |
rosmaita | I forgot to bring up the RateLimitingMiddleware deprecation last week, but since we're doing an RC-2, we still have time to decide for Xena | 14:46 |
rosmaita | i sent an email to the ML aimed at operators | 14:47 |
rosmaita | the response was ... nothing | 14:47 |
jungleboyj | So, it would be nice to assume that means it isn't being used. | 14:48 |
rosmaita | my feeling is that since nova doesn't have it any more, anyone interested in this is using a different solution for nova, and probably that same solution for any other services that need rate limiting | 14:48 |
jungleboyj | ++ | 14:49 |
jungleboyj | That makes sense to me. | 14:49 |
rosmaita | i think eharney was skeptical about removing this, anyone else? | 14:49 |
rosmaita | one thing that did come up is that sfinucane had a docs patch up for this that's been sitting for a while | 14:50 |
rosmaita | which we don't need if we deprecate the rate limiting middleware | 14:50 |
rosmaita | but made me think that we are missing some docs patches in the Festival of Reviews | 14:50 |
rosmaita | so we may want to start emphasizing that | 14:51 |
rosmaita | anyway, i guess my ask is that if we are going to deprecate this, we need to do it this week | 14:51 |
rosmaita | so please leave comments on the patch: | 14:51 |
rosmaita | https://review.opendev.org/c/openstack/cinder/+/807469 | 14:52 |
rosmaita | #topic stable release update | 14:52 |
rosmaita | whoami-rajat: that's you | 14:52 |
whoami-rajat | thanks | 14:52 |
whoami-rajat | so there's a patch up for victoria release, which i had to revise since it had some patches that doesn't exist in wallaby | 14:53 |
whoami-rajat | and in Ussuri, there was one patch left which is approved and in gate, so I've proposed the ussuri release patch as well | 14:53 |
whoami-rajat | victoria | 14:54 |
whoami-rajat | #link https://review.opendev.org/c/openstack/releases/+/809892 | 14:54 |
whoami-rajat | ussuri | 14:54 |
whoami-rajat | #link https://review.opendev.org/c/openstack/releases/+/810442 | 14:54 |
whoami-rajat | since train is EM, we won't be doing any release for it | 14:54 |
whoami-rajat | thanks everyone who helped with the reviews and made these releases possible! | 14:54 |
rosmaita | for victoria, you mean there were patches that are in stable/wallaby, but were not included in the most recent wallaby release? | 14:55 |
rosmaita | so you couldn't include them in the victoria release, either? | 14:55 |
whoami-rajat | yes, (I always word it wrong), they are merged in wallaby but not there in recent wallaby release 18.1.0 | 14:55 |
rosmaita | ok, cool, just wanted to be clear | 14:55 |
whoami-rajat | I've recently updated the hash for the victoria release patch so would be great if you can take a look | 14:56 |
rosmaita | ok, will do | 14:56 |
whoami-rajat | that's all from me | 14:56 |
whoami-rajat | thanks | 14:56 |
rosmaita | thanks whoami-rajat | 14:56 |
hemna | fwiw I think we are using the rate limit middleware | 14:56 |
rosmaita | hemna: ok, that is good to know | 14:57 |
rosmaita | please leave a comment on that review | 14:57 |
hemna | sorry about the late response, too dang busy to follow everything | 14:57 |
rosmaita | #topic os-brick bug ? | 14:57 |
rosmaita | simondodsley: that's you | 14:57 |
simondodsley | thanks - we can take this to the cinder channel due to time constraints if you want. | 14:57 |
rosmaita | hemna: np, glad you brought i up because i was inclined to deprecate and remove | 14:58 |
rosmaita | simondodsley: that's a good idea, since the bug squad meeting is in cinder channel in 2 minutes! | 14:58 |
rosmaita | #topic open discussion | 14:58 |
rosmaita | 90 seconds for anything on anyone's mind | 14:58 |
eharney | i started poking at volume manage + encryption re: the bug earlier -- think i already found an issue in there, will probably write up a new, specific, bug report | 14:58 |
enriquetaso | maybe we can use the recording of the bug meeting for the os-brick bug so keep track somewhere simondodsley | 14:59 |
rosmaita | eharney: sounds good, ty | 14:59 |
rosmaita | well, that's all we have time for | 15:00 |
rosmaita | thanks everyone | 15:00 |
rosmaita | don't forget, video meeting next week | 15:00 |
jungleboyj | Thanks! | 15:00 |
e0ne | see you next week | 15:00 |
simondodsley | ttfn | 15:00 |
rosmaita | #endmeeting | 15:00 |
opendevmeet | Meeting ended Wed Sep 22 15:00:58 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-09-22-14.00.html | 15:00 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-09-22-14.00.txt | 15:00 |
opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-09-22-14.00.log.html | 15:00 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!