Wednesday, 2021-09-22

*** dviroel|out is now known as dviroel11:18
rosmaita#startmeeting cinder14:00
opendevmeetMeeting started Wed Sep 22 14:00:33 2021 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'cinder'14:00
rosmaita#topic roll call14:00
simondodsleyHi14:00
e0nehi14:00
eharneyhi14:00
enriquetasohi14:00
walshh_Hi14:01
whoami-rajatHi14:01
fabiooliveirahi14:02
TusharTgitehi14:02
toskyhi14:02
rosmaitahello everyone14:02
rosmaitalet's get started14:02
rosmaita#link https://etherpad.opendev.org/p/cinder-xena-meetings14:02
rosmaita#topic announcements14:03
rosmaitawe will be doing an RC-214:03
rosmaitathere are some requirements changes that we needed to make, and some release critical bugs14:03
rosmaitawe'll go over those in a few minutes14:03
rosmaitai'll just continue with the announcements14:03
hemnahi14:04
rosmaitanext week is the final Release Candidate14:04
rosmaitatraditionally on Thursday14:04
rosmaitawe'll talk about whether we should do an RC-2 quickly and then possibly another, or just do an RC-214:04
rosmaitanext announcement:14:05
rosmaitanext week's meeting is the last of the month, so will be our usual video meeting14:05
rosmaitanext, the Outreachy proposal deadline is 29 September14:05
rosmaita#link http://lists.openstack.org/pipermail/openstack-discuss/2021-September/024992.html14:06
rosmaitayou can read ^^ to see what that's about14:06
rosmaitai don't know whether i will put in a proposal or not14:06
rosmaitait's a good mentoring opportunity, if you would like to do that14:07
rosmaitaand might get some work done on cinder14:07
rosmaitalet me know if you are interested, and i will work with you to get a proposal together14:07
rosmaitabut think about it fast, because the proposal is due in one week14:08
rosmaitafinally, the Yoga PTG is the week of 18 October14:08
rosmaita#link https://etherpad.opendev.org/p/yoga-ptg-cinder-planning14:08
rosmaitaadd topics to ^^14:08
rosmaitaalso, info is on the etherpad for registering for the PTG14:08
rosmaitait's free, but the foundation asks you to register 14:09
rosmaitai guess so that they can remind you about the code of conduct14:09
rosmaitai think that's all14:09
rosmaita#topic RC-214:10
rosmaita#link https://etherpad.opendev.org/p/cinder-xena-final-patches-for-RC14:10
rosmaitaok, please open ^^14:10
rosmaitasince the stable/xena branch has been cut, everything must merge first to master and then be backported to stable/xena14:10
rosmaitathere are a few requirements changes we have to make14:11
rosmaitanamely, raising the minimum in requirements.txt14:11
rosmaitai think everything has merged to master at this point, but we need to get teh backports merged too14:12
rosmaitaso stable cores, please note the etherpad and keep an eye on it14:12
rosmaitaafter we found a few minimum versions of some requirements that broke tests, i put together a quick lower-constraints kind of job14:13
rosmaita#link https://review.opendev.org/c/openstack/cinder/+/81013114:13
rosmaita^^ if anyone wants to check my work14:13
rosmaitaall the tests passed with the current xena backports and the generated lower constraints file14:13
rosmaitaso, everything seems to work with the current requirements minima (after the patches on lines 1-18 on the etherpad merge)14:14
rosmaitabut, i noticed a few things that might be a bit out of whack:14:14
rosmaita#link https://paste.opendev.org/raw/809501/14:14
rosmaitaso, please open ^^ so we can discuss14:14
rosmaitabtw, i did not check all our requirements against current upper constraints, just some that i thought might be worth looking at14:15
rosmaitayou can see that for pretty much all the oslo stuff, there are only minor version changes, so i don't think we need to worry about them14:16
rosmaitathe exceptions are oslo.db and PyMySQL14:16
eharneyi think our PyMySQL req is only for tests so it's not very interesting14:16
rosmaitahere's the change log for oslo.db:14:16
rosmaita#link https://paste.opendev.org/raw/809503/14:16
rosmaitathere doesn't look like a lot in there, but i wonder whether we should raise the min to the xena release of oslo.db ?14:17
rosmaitato remind you what this means:14:17
rosmaitawe are testing (usually) with whatever is in upper constraints14:18
rosmaitaso all the recent jobs are using oslo.db 11.0.014:18
rosmaitafor the past few weeks14:18
rosmaitabut if the min in requrements is 8.4.0, then we are saying that it's ok to package cinder with oslo.db 8.4.014:19
rosmaitaand that may be fine, all our unit tests pass with that version14:19
eharneywe should raise it IMO14:19
rosmaitaeharney: ty, i agree14:19
rosmaitaanyone else?14:20
e0ne+114:20
rosmaitathanks ivan14:20
rosmaitaok, i will put up a patch14:20
rosmaita#action rosmaita patch to raise oslo.db min in requirements to 11.0.014:20
rosmaitaok, the other one is PyMySQL14:20
rosmaitathe changelog is here:14:20
rosmaita#link https://github.com/PyMySQL/PyMySQL/blob/main/CHANGELOG.md14:21
rosmaitait looks to me like the major changes are to remove py2.7 and py3.5 support14:21
rosmaitaand stop supporting MySQL 5.5 (which we talked about last week!)14:22
rosmaitai think we should probably raise this one too ... any thoughts?14:23
eharneyi'm not sure we should depend on it directly14:24
eharneysee https://opendev.org/openstack/oslo.db/src/branch/master/setup.cfg#L2514:24
e0newhat version of mysql is available in official repos of supported OSes?14:24
rosmaitae0ne: not sure14:25
rosmaitaeharney: you have a good point, we should probably let oslo.db set the version 14:26
rosmaitaok, so for pymysql i propose to do nothing14:29
rosmaitanot as big a deal, it's in test-requrements whereas oslo.db is in real requirements.txt14:29
eharneysounds good14:29
rosmaitaok, thanks14:30
rosmaitaon to some release critical bugs14:30
rosmaitaline 23 in https://etherpad.opendev.org/p/cinder-xena-final-patches-for-RC14:30
rosmaitathis was reported for nova, but since we have a lot of the same changes for the sqlalchemy-migrate -> alembic transition, it probably applies to us too14:31
enriquetaso#link https://review.opendev.org/c/openstack/cinder/+/81028814:31
enriquetaso#link https://review.opendev.org/c/openstack/cinder/+/81000014:31
rosmaitathe two patches for master look ok, one is in recheck14:31
rosmaitathanks enriquetaso14:31
rosmaitaso i think we need to get these reviewed, merged, and backported befor RC214:32
rosmaitanext one is the cgroupv2 thing: https://bugs.launchpad.net/cinder/+bug/194220314:32
rosmaitai will try to get a patch up for that one in the next day or two14:33
rosmaitai'm not sure how many people actually use the throttling14:33
rosmaitabut it would be better to have it fixed for the release than not14:33
rosmaitanext one is a bug that maybe requires a "known issue" release note14:34
rosmaita#link https://bugs.launchpad.net/cinder/+bug/190920714:34
rosmaitai think at one point we were thinking this might not be a bug?14:35
enriquetaso1909207 i think this issues isn't a rbd problem so far14:35
eharneythis probably does need more investigation14:36
eharneyit was on my list at one point but clearly i lost track of it14:36
enriquetasomaybe we can ask for the backend xuanyandong  is using14:36
eharneywe can just try to reproduce it14:37
eharneyand investigate if this is a thing that can happen14:37
rosmaitadoes anyone have time to look at this before the next meeting?14:37
rosmaitawe can always have in "known issues" that this has been reported and may affect some backends14:39
enriquetasosounds good, I'm going PTO but I can try to reproduce it for next meeting.14:39
rosmaitamerging a release note is pretty fast, so we can decide next week14:39
rosmaitathanks enriquetaso14:39
rosmaitasince enriquetaso will be on pto, though, if anyone else is interested in this, would be good to help out14:40
rosmaitaok, we have another known issue that we discussed at the midcycle14:40
rosmaita#link https://wiki.openstack.org/wiki/CinderXenaMidCycleSummary#what_to_do_about_qcow2-v2_support_being_yanked_from_various_linux_distros14:40
rosmaitathere was an action item to look into this14:41
rosmaitawhat i found out is that we do look at whether the volume being managed is actually a qcow214:41
rosmaitabut we only reject it if it has a backing file14:41
rosmaita(because that's a security issue)14:41
rosmaitai will write up a release note patch and bug people to review it14:42
rosmaitaas far as issues for the xena release, that's all i'm aware of14:42
rosmaitaanyone here run into anything?14:43
rosmaitaenriquetaso: that rbd trash bug might be a candidate14:44
rosmaita#link https://review.opendev.org/c/openstack/cinder/+/81040214:44
enriquetasoyes14:45
enriquetasoI think we may want ^ merged before RC114:45
rosmaitawell, RC2, anyway14:45
rosmaitalet's discuss at the bug meeting, then14:46
enriquetasosure14:46
rosmaita#topic deprecations14:46
rosmaitaI forgot to bring up the RateLimitingMiddleware deprecation last week, but since we're doing an RC-2, we still have time to decide for Xena14:46
rosmaitai sent an email to the ML aimed at operators14:47
rosmaitathe response was ... nothing14:47
jungleboyjSo, it would be nice to assume that means it isn't being used.14:48
rosmaitamy feeling is that since nova doesn't have it any more, anyone interested in this is using a different solution for nova, and probably that same solution for any other services that need rate limiting14:48
jungleboyj++14:49
jungleboyjThat makes sense to me.14:49
rosmaitai think eharney was skeptical about removing this, anyone else?14:49
rosmaitaone thing that did come up is that sfinucane had a docs patch up for this that's been sitting for a while14:50
rosmaitawhich we don't need if we deprecate the rate limiting middleware14:50
rosmaitabut made me think that we are missing some docs patches in the Festival of Reviews14:50
rosmaitaso we may want to start emphasizing that14:51
rosmaitaanyway, i guess my ask is that if we are going to deprecate this, we need to do it this week14:51
rosmaitaso please leave comments on the patch:14:51
rosmaitahttps://review.opendev.org/c/openstack/cinder/+/80746914:52
rosmaita#topic stable release update14:52
rosmaitawhoami-rajat: that's you14:52
whoami-rajatthanks14:52
whoami-rajatso there's a patch up for victoria release, which i had to revise since it had some patches that doesn't exist in wallaby14:53
whoami-rajatand in Ussuri, there was one patch left which is approved and in gate, so I've proposed the ussuri release patch as well14:53
whoami-rajatvictoria14:54
whoami-rajat#link https://review.opendev.org/c/openstack/releases/+/80989214:54
whoami-rajatussuri 14:54
whoami-rajat#link https://review.opendev.org/c/openstack/releases/+/81044214:54
whoami-rajatsince train is EM, we won't be doing any release for it14:54
whoami-rajatthanks everyone who helped with the reviews and made these releases possible!14:54
rosmaitafor victoria, you mean there were patches that are in stable/wallaby, but were not included in the most recent wallaby release?14:55
rosmaitaso you couldn't include them in the victoria release, either?14:55
whoami-rajatyes, (I always word it wrong), they are merged in wallaby but not there in recent wallaby release 18.1.014:55
rosmaitaok, cool, just wanted to be clear14:55
whoami-rajatI've recently updated the hash for the victoria release patch so would be great if you can take a look14:56
rosmaitaok, will do14:56
whoami-rajatthat's all from me14:56
whoami-rajatthanks14:56
rosmaitathanks whoami-rajat14:56
hemnafwiw I think we are using the rate limit middleware14:56
rosmaitahemna: ok, that is good to know14:57
rosmaitaplease leave a comment on that review14:57
hemnasorry about the late response, too dang busy to follow everything14:57
rosmaita#topic os-brick bug ?14:57
rosmaitasimondodsley: that's you14:57
simondodsleythanks - we can take this to the cinder channel due to time constraints if you want.14:57
rosmaitahemna: np, glad you brought i up because i was inclined to deprecate and remove14:58
rosmaitasimondodsley: that's a good idea, since the bug squad meeting is in cinder channel in 2 minutes!14:58
rosmaita#topic open discussion14:58
rosmaita90 seconds for anything on anyone's mind14:58
eharneyi started poking at volume manage + encryption re: the bug earlier -- think i already found an issue in there, will probably write up a new, specific, bug report14:58
enriquetasomaybe we can use the recording of the bug meeting for the os-brick bug so keep track somewhere simondodsley 14:59
rosmaitaeharney: sounds good, ty14:59
rosmaitawell, that's all we have time for15:00
rosmaitathanks everyone15:00
rosmaitadon't forget, video meeting next week15:00
jungleboyjThanks!15:00
e0nesee you next week15:00
simondodsleyttfn15:00
rosmaita#endmeeting15:00
opendevmeetMeeting ended Wed Sep 22 15:00:58 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:00
opendevmeetMinutes:        https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-09-22-14.00.html15:00
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-09-22-14.00.txt15:00
opendevmeetLog:            https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-09-22-14.00.log.html15:00

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!