Wednesday, 2022-01-12

*** hemna0 is now known as hemna07:38
*** dviroel_ is now known as dviroel11:21
SachinMorehi brian13:59
rosmaitahello14:00
rosmaitaguess it's time to start14:00
rosmaita#startmeeting cinder14:00
opendevmeetMeeting started Wed Jan 12 14:00:17 2022 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'cinder'14:00
rosmaita#topic roll call14:00
jungleboyjo/14:00
toskyo/14:00
eharneyhi14:00
enriquetasohi14:00
SachinMorehi14:00
*** dasm|off is now known as dasm14:00
simondodsleyhi14:00
fabiooliveirahi14:00
felipe_rodrigueshi14:01
nahimsouza[m]o/14:01
LeoCampeloo/14:01
walshh_hi14:02
rosmaitahello everyone14:04
rosmaita#link https://etherpad.opendev.org/p/cinder-yoga-meetings14:04
rosmaita#topic announcements14:04
rosmaitafirst, a reminder about the OpenInfrastructure Foundation election/polling happening this week14:04
rosmaitait closes on Friday 14 Jan at 1800 UTC14:04
rosmaitai think that as openstack contributors, you are all also signed up as individual foundation members14:05
rosmaita(not sure about that though)14:05
rosmaitaanyway, you should have received a customized email with a personalized link to the voting website14:05
rosmaitalook for email with subject "2022 Individual Director Election and Bylaws Amendments"14:06
rosmaitasecond announcement: new driver merge deadline is 21 January14:06
rosmaitawhich is really soon14:06
rosmaitawe are tracking new driver patches here:14:06
rosmaita#link https://etherpad.opendev.org/p/cinder-yoga-new-drivers14:06
rosmaitaobviously, the review priority until 21 January is new drivers14:07
rosmaitaso people who have other patches, if you help review new drivers, we can get that done faster and can get back to reviewing other stuff14:07
rosmaitaand people who have new drivers, you can speed things up by checking the review guidelines and make sure your CI is working properly14:08
rosmaita#link https://docs.openstack.org/cinder/latest/contributor/new_driver_checklist.html14:08
rosmaitathat link is also helpful for people doing the reviews, of course14:08
rosmaitawe have a variety of drivers of various complexity this cycle14:09
rosmaitasome simple wrappers, and one that requires a new os-brick connector, plus the driver, plus a driver for nova14:09
rosmaitaok, other upcoming stuff:14:09
rosmaitafestival of xs reviews next friday14:10
rosmaita(which is 21 January)14:10
rosmaitayoga midcycle-2 on 26 January14:10
rosmaitayoga os-brick release week of 7 February14:10
rosmaitayoga feature freeze week of 21 February14:10
rosmaitathat's all the announcements I have ... anyone else have something to share?14:11
rosmaitaok, moving on14:12
rosmaita#topic Discuss revert-to-snapshot potential issue14:12
rosmaitasimondodsley: that's you14:12
simondodsleyThanks14:12
simondodsleyReading the spoec for revert from any snapshot (https://review.opendev.org/c/openstack/cinder-specs/+/736111) I noticed that the main revert from snapshot functionality doesn't set volume creation name to the creation date of the snapshot after reversion. Without this there is no way to tell if a volume has actually been reverted. Not only does this stop the revert from any snapshot spec moving forward, it seems 14:12
simondodsleyto me like a big hole for operators.14:12
simondodsleyDiscuss...14:12
simondodsleyAm I missing something obvious here, or is that actually a failing of the feature?14:13
rosmaitawell, the idea of the feature is that as far as the end user is concerned, it's the same volume14:13
rosmaitaso i think the creation date is supposed to stay the same?14:13
eharneythat's my first thought as well14:14
simondodsleyYEs, but they have no idea if it has been reverted. It makes sense that the volume creation time should be the time of the snapshot 14:14
simondodsleyHow do 3rd party backends deal with this? I know Pure will reset the volume creation time to the snapshot creation time on reversion14:14
simondodsleyIf the revert to any snapshot feature is to move forward there has to be a way to tell if a volume has been reset14:15
rosmaitaso from the Pure point of view, the reverted volume actually is a different volume, is that correct?14:15
eharneyi'm not sure we have anything defining details of how the volume creation timestamp works in general and the details of what it would mean in this situation14:15
simondodsleyNot really, it is just overwritten with the snapshot14:16
rosmaitaok14:16
eharneyresetting the creation timestamp on revert would also mean you can end up with snapshots that have a creation time earlier than the volume's creation time14:16
simondodsleyif you have a DB running on the volume  you would potentially need to know that a snapshot reversion has taken place so you know where your data is at14:16
simondodsleyeharney, exactly, so that would tell you that those snapshots are no longer valid or are available for reversion to an earlier timestamp if the initial reversion didn't go far enough back14:17
simondodsleythink about DB recover from corruption etc14:18
eharneywell they should still be valid14:18
simondodsleybut the operator/user has no idea which are valid if they weren't the person who did the original reversion.14:18
simondodsleyyou are assuming only one operator who has a perfect memory14:19
rosmaitathis sounds like a case for volume metadata14:19
simondodsleywithout knowing the timestamp of the reverted snapshot onto the underlying volume you can leave yourself open to data corruption14:20
simondodsleyyes - metadata wolkd be a good use of this, but there would have to be a standard name for it that all drivers used. 14:20
eharneywhy data corruption?14:20
simondodsleyAs it is I think every driver would have to be patched to fx this14:20
jungleboyj:-(14:22
rosmaitawell, the spec hasn't been approved yet (I hope), so we can work out a standard way to record this14:22
simondodsleyeharney, because you could revert to snapshot 3, then do work and create a new snapshots (4 and 5), but someone and in the future there is a need to go back to snapshot 4, but a user who can't see snashot timestamps could pick snashot 2 not knowing about the snaspht 3 reversion14:22
rosmaitai am kind of leery of messing with the volume creation timestamp though14:22
rosmaitaeharney has been pointing out on that spec review that some kind of tracking needs to happen, but the proposers haven't really addressed that, i don't think14:24
simondodsleyI would be OK with metadata being used to this, but a regular user, using Horizon would not see the metadata (unless they do additional actions) and as I say it would need to be a standard name that all drivers had to amend. 14:25
jungleboyjDoes sound like this requires additional thought/design.14:25
simondodsleyI would like to know what other vendors do with snashot recovery to the underlying volume timestamp. Anyone care to comment?14:25
simondodsleythis would inform the way forewsard for revert and this spec14:26
rosmaitakind of quiet in here today, maybe we need to take this to the mailing list14:26
rosmaitawhat i mean is the question of whether changing the semantics of the volume create timestamp is a good way forward here, or whether we need something else14:27
jungleboyjOr a topic for the next mid-cycle?14:27
eharneyi think it would be better to use something else14:27
rosmaitaor both!14:27
eharneythe volume timestamp still represents when the volume was created, that isn't really related to snapshots being reverted to etc...14:27
simondodsleybut it soet of is as the volume is recreated14:28
simondodsleybase don the timestamp of the snapshot14:28
eharneythe volume isn't recreated from a cinder point of view (and presumably not on a good number of backends either?)14:28
rosmaitayeah, i am inclined to agree with eharney, but if a lot of backends do what Pure does, maybe user expectations are different from my intuition14:29
simondodsleythat is what i'm trying to find out - even in Pure we do not recreate the volume, just apply a bunch of changes that make the volume look like it was at the time of the snaphot14:29
rosmaitai think simondodsley definitely makes a good case that we want some kind of tracking here14:29
jungleboyjrosmaita: ++14:30
simondodsleymaybe a direct mail to the driver maintainers as not all of them read the mailing list14:30
rosmaitaok, simondodsley how about we draft out something to the ML on an etherpad14:30
simondodsleysounds good14:31
rosmaitawell, they should read the ML, so i would prefer conversation on the ML, with a direct email informing them about the discussion14:31
rosmaita#action simondodsley, rosmaita - draft email to the ML about volume revert tracking14:31
rosmaitaok thanks simondodsley, let's move on14:32
rosmaita#topic removing contrib/black-box from the code tree14:32
rosmaitathis is prompted by a comment from hemna on an eharney patch14:33
rosmaitawe have this contrib/black-box/* in the code tree14:33
rosmaitait has been marked as 'unsupported' since 20 Jan 202014:33
rosmaita#link https://review.opendev.org/c/openstack/cinder/+/70197414:33
rosmaitalooks like it has definitely not been maintained14:33
rosmaitait looks like it only builds properly with stable/ocata (and that branch no longer exists)14:34
rosmaitaso i think we should remove it14:34
rosmaitais anyone horrified by that suggestion?14:34
eharneyi think it's a good idea14:35
rosmaitai just wanted to get an initial reaction before proposing this on the ML14:35
rosmaitasounds like we have no black-box fans present today14:35
jungleboyjI agree.14:35
simondodsley++14:35
rosmaita#action rosmaita - proposal to remove blackbox support this cycle to the ML14:35
rosmaitaok, thanks for the feedback!14:36
eharneyblockbox :)14:36
rosmaita3topci coordination and strategy for the changes required in devstack-plugin-ceph14:36
toskymissed a # and topic spelling14:36
rosmaitaoops, block-box14:37
jungleboyjHe he.14:37
rosmaitayes, let me try again14:37
rosmaita#topic coordination and strategy for the changes required in devstack-plugin-ceph14:37
rosmaitaok tosky has the floor14:37
toskyhi, you are probably aware that the new way to install ceph is cephadm, and talking about this with manila people, they are experimenting with it (hi vkmc :) 14:37
toskythe experiments are being done outside devstack-plugin-ceph , but I think the final code should live there.14:37
toskyNow, there are several consumers for devstack-plugin-ceph (cinder, glance, manila, nova, and generally QA), so maybe it would make sense to setup a popup team to handle the cephadm migration?14:37
toskyThat would mean (if the TC and all the affected groups approve it) a few more meetings and some volunteer to handle it. I can help with it but it would be better if I wouldn't be the only one.14:37
toskyAny thoughts in general?14:37
* vkmc sneaks in 14:38
vkmco/ 14:38
rosmaitai agree with everything you have said14:38
rosmaitahello vkmc14:38
eharneymakes sense to add it as a new mode/option to devstack-plugin-ceph14:38
jungleboyjvkmc:  Long time no see!14:38
vkmcjungleboyj, indeed :D14:39
eharneyi can help with reviews etc at least14:39
toskyor can we just solve it without an additional team and meetings?14:39
rosmaitawell, the popup team doesn't actually have to hold meetings, just an etherpad to keep people informed14:40
rosmaitabut quick meetings are probably good to make people focus on the work14:40
rosmaitathough we don't want to add unnecessary overhead to this work14:41
rosmaitabut since vkmc is actually doing work on this, her opinion is important here14:42
rosmaitai guess the question is, what kind of coordination would be useful?14:42
vkmca weekly sync up would be useful for those interested14:43
rosmaitathat sounds reasonable14:43
rosmaitatosky: do you want to represent cinder, or were you saying earlier that you are interested in helping, but not specifically representing cinder?14:44
vkmcright now the goal is to build a plugin that can be used externally and make sure that main functionality for all services work as expected14:44
vkmcperhaps we would need to setup environments with devstack, cephadm and run tempest there14:44
vkmc(debug and fix whatever comes from there)14:44
rosmaitathat sounds right14:45
toskyrosmaita: whatever is needed to move this forward, keeping in mind I can help more with testing and maybe not much with the code14:45
vkmconce we got that working, we could see how to integrate that to what we have 14:45
toskyvkmc: wouldn't it be more work to write an external code and integrate it back later?14:45
vkmctosky, it's ok for me in any case14:47
rosmaitavkmc: so are you thinking of a changing the devstack ceph plugin architecture so that it would take a plugin for cephadm-type services?14:47
rosmaitaactually, i guess architecture would be a good topic for your first meeting14:48
rosmaitavkmc: are you willing to start a pop-up team for this?14:48
vkmcrosmaita, that's what we need to figure out... I don't know if it makes sense to do that if we are going to start using cephadm as the reference tool for ceph deployments14:49
vkmcyep, discussing how we are going to tackle this would be a great topic for the first meeting 14:49
vkmcrosmaita, of course, I can do that14:49
rosmaitavkmc: my impression is that the ceph project is moving to cephadm, so i'm assuming everyone else should too14:50
vkmcrosmaita, my impression too14:50
rosmaitaok, cool14:50
toskyrosmaita: that may have an impact on the version supported by cinder, not sure about the services14:50
toskythe other services14:50
rosmaitawell, we have a support statement somewhere, we only support officially like 1 year older than ceph itself14:50
vkmcwe can keep the devstack-plugin-ceph for testing in stable branches, and slightly adopt a new plugin with time... but we should discuss this in a specific meeting, I don't want to hijack this meeting :) 14:51
toskydevstack-plugin-ceph is branched14:51
rosmaitavkmc: sounds good, we will look for your announcement on the ML about the pop-up team, please include [cinder] in the subject14:51
vkmcyes, I'm aware... but little of what we have in that repo would be useful for us if we start using cephadm as the deployment tool14:51
enriquetasoCephadm is new in the Octopus v15.2.0 release and does not support older versions of Ceph.14:51
vkmcrosmaita, sure14:52
rosmaitaand thanks tosky for pushing this14:52
enriquetaso#link https://docs.ceph.com/en/octopus/cephadm/14:52
rosmaitawell, as long as devstack-plugin-ceph is branched, backcompat shouldn't be a problem (i don't think)14:53
enriquetasosure14:53
vkmcenriquetaso, thanks, that's helpful to decide what we end up doing :) 14:53
enriquetasothanks vkmc 14:53
rosmaitaok thanks14:53
rosmaitaSachinMore: do you have a specific comment about those patches you listed on the agenda?14:53
SachinMorewhat can we do to help get patches 806687, 811717 and 811718 in upstream? These patches fix bugs in KIOXIA's code.14:54
simondodsleythese are all os-brick patches, correct?14:54
SachinMoreyes14:54
toskyrosmaita: topic change ?14:55
rosmaita#topic aging os-brick patches14:56
rosmaita#link https://review.opendev.org/c/openstack/os-brick/+/81171814:56
rosmaita#link https://review.opendev.org/c/openstack/os-brick/+/81171714:56
rosmaita#link https://review.opendev.org/c/openstack/os-brick/+/80668714:56
rosmaitaok, one thing is that it looks like some of them need a rebase (since the patches are stacked)14:58
rosmaitabut we do need to review these14:58
rosmaitasince the os-brick release has to happen shortly after the new driver merge deadline, i should revise my earlier statement14:58
rosmaitareview priorities over the next week should be: os-brick + new drivers14:59
rosmaitaSachinMore: thanks for bringing these to our attention14:59
SachinMorethanks, rosmaita15:00
SachinMoreplease let us know if something is needed from our side15:00
rosmaitawill do15:00
rosmaitaok, we are out of time ... thanks everyone!15:01
SachinMorethanks everyone!15:01
geguileowhat is the replica_count?15:01
geguileois a new field on the conn info?15:01
jungleboyjThank you!15:01
rosmaita#endmeeting15:02
opendevmeetMeeting ended Wed Jan 12 15:02:34 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:02
opendevmeetMinutes:        https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-01-12-14.00.html15:02
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-01-12-14.00.txt15:02
opendevmeetLog:            https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-01-12-14.00.log.html15:02
rosmaitageguileo: SachinMore: maybe you can discuss in #openstack-cinder15:02
SachinMoreok15:03
*** dviroel is now known as dviroel|lunch15:13
*** dviroel|lunch is now known as dviroel16:11
*** dviroel is now known as dviroel|afk20:04
*** dasm is now known as dasm|off22:45

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!