| *** mhen_ is now known as mhen | 01:32 | |
| jbernard | #startmeeting cinder | 14:04 |
|---|---|---|
| opendevmeet | Meeting started Wed Aug 13 14:04:14 2025 UTC and is due to finish in 60 minutes. The chair is jbernard. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:04 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:04 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:04 |
| jbernard | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney jbernard hemna fabiooliveira yuval tobias-urdin adiare happystacker dosaboy hillpd msaravan sp-bmilanov Luzi sfernand simondodsley: courtesy reminder | 14:04 |
| jbernard | #link https://etherpad.opendev.org/p/cinder-flamingo-meetings | 14:04 |
| Luzi | o/ | 14:04 |
| jbernard | #topic roll call | 14:04 |
| mhen | o/ | 14:04 |
| gireesh | o/ | 14:04 |
| hillpd | o/ | 14:04 |
| pedrovlf | o/ | 14:04 |
| jungleboyj | o/ | 14:04 |
| tosky | o/ | 14:05 |
| vivek__ | o/ | 14:05 |
| anthonygamboa | o/ | 14:05 |
| jayaanand | o/ | 14:06 |
| sp-bmilanov | o/ | 14:06 |
| Anoop_Shukla | o/ | 14:06 |
| yuval | o-/ | 14:06 |
| hvlcchao1 | o/ | 14:06 |
| jbernard | hello everyone | 14:07 |
| jbernard | i see a nova spec being added to the agenda, while that happens some quick reminders | 14:08 |
| jbernard | Monday, Aug 18 is our midcycle/review session at 1400 UTC (this slot) | 14:08 |
| jbernard | #link https://releases.openstack.org/flamingo/schedule.html | 14:09 |
| * sp-bmilanov is adding things at the last moment | 14:09 | |
| sp-bmilanov | (I can elaborate a bit more when I have the floor) | 14:10 |
| jbernard | sp-bmilanov: sure, go ahead | 14:10 |
| sp-bmilanov | hi, thanks, so we hit a case where, during a live migration of an instance, the OOM killer kills the nova agent at the source, but in just the right moment so that the instance is now running at the destination | 14:11 |
| sp-bmilanov | but it is not reflected in OpenStack's state | 14:11 |
| sp-bmilanov | and when you boot the instance again, it gets started on the source hypervisor | 14:12 |
| sp-bmilanov | leading to data corruption for the volumes that are attached at both the source and destination | 14:12 |
| jbernard | yikes | 14:12 |
| sp-bmilanov | I've brought this up with Nova, hence the spec, but I was wondering if there is something more we can do to eliminate double-attachments as a whole | 14:13 |
| sp-bmilanov | the StorPool storage system can force-detach from all but the instance that is being powered on (the linked change), so you don't at least have data corruption | 14:14 |
| sp-bmilanov | (https://review.opendev.org/c/openstack/os-brick/+/940245) | 14:14 |
| sp-bmilanov | what I wanted to discuss is does it make sense to generalize this a bit and ship it as something other drivers can implement? | 14:14 |
| sp-bmilanov | (something like an invariant that storage systems, where possible, to check that some invariants hold) | 14:15 |
| sp-bmilanov | ok, wrong link -- https://review.opendev.org/c/openstack/os-brick/+/957117 | 14:16 |
| sp-bmilanov | and the context in which it can be called -- https://review.opendev.org/c/openstack/nova/+/957119 | 14:17 |
| sp-bmilanov | currently, it makes a lot of assumptions, might not cover edge cases, etc, but the spirit of the change is "consult the storage system that it's ok to boot" | 14:18 |
| jbernard | this will certainly require nova's input, | 14:19 |
| jbernard | the source of the bug is restarting on the source when an instance is in a trasitional state, no? | 14:19 |
| sp-bmilanov | in a transitional state from the PoV of OpenStack, yes, from what I've gathered, the instance was fully migrated on the destination, there was just some bookeeping and cleanup left on the source | 14:20 |
| jbernard | we support multiattach, so there are at least some cases where eliminating this would not be desired... (im reading as fast as i can, there's quite a bit to think about) | 14:21 |
| sp-bmilanov | yep, no rush, I just wanted to get the idea out there | 14:21 |
| sp-bmilanov | and yes, I am not sure how this will mesh with multi-attach | 14:21 |
| jbernard | sp-bmilanov: if finalizing cleanup is necessary, wouldn't bringing up the instance again on the source be the wrong thing to do? | 14:22 |
| sp-bmilanov | yep, but from what I gathered, a restart was issued, which made OpenStack recreate the instance at the source | 14:23 |
| sp-bmilanov | (there are also discussions to look into maybe adding more obstacles if OpenStack detects that a migration has failed) | 14:24 |
| sp-bmilanov | more obstacles to get a VM restarted | 14:24 |
| jbernard | but i would hope a restart on a migrated instance would be able to correct for this case | 14:24 |
| sp-bmilanov | it's a known defect, the source doesn't check if the instance is running on the destination | 14:24 |
| jbernard | im resisitant to adding additional logic to cinder if nova is capable of improving the restart logic (as a general idea) | 14:25 |
| sp-bmilanov | (the spec will aim to address this and maybe describe that the source checking the destination for running instances is the way to go) | 14:25 |
| jbernard | i think the source of the problme is the best place to address it, instead of adding safeguards in cinder to work around it (if possible) | 14:25 |
| sp-bmilanov | makes sense | 14:26 |
| jbernard | i want to hear nova's take on it | 14:26 |
| sp-bmilanov | I will bring it up again on the Nova weekly next week | 14:28 |
| jbernard | sp-bmilanov: what is the lp bug for this? im not seeing it' | 14:28 |
| sp-bmilanov | https://bugs.launchpad.net/nova/+bug/2092391 | 14:29 |
| jbernard | ahh, sean has some comments on the spec, need to look at that closer | 14:29 |
| jbernard | sp-bmilanov: thanks | 14:29 |
| sp-bmilanov | you're welcome, yes, and https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2025-07-29.log.html https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2025-07-22.log.html | 14:30 |
| sp-bmilanov | I need to update the spec proposal with what we've discussed in the meets, but the focus in the spec is the cleanup enhancement | 14:31 |
| jbernard | #action sp-bmilanov to raise restart/migration issue in nova meeting and report back | 14:31 |
| jbernard | sp-bmilanov: it could be that nova cannot handle it any better, i just want to understand | 14:32 |
| sp-bmilanov | it can, and in that specific case it will solve the issue, but I was wondering if a more general approach would be even better | 14:32 |
| sp-bmilanov | in order to avoid a potential next double-attach-start situation | 14:33 |
| sp-bmilanov | "in that specific case it will solve the issue" it = a potential enhancement to the cleanup | 14:33 |
| jbernard | ok, im interested in addressing the immediate issue first | 14:35 |
| sp-bmilanov | ack | 14:35 |
| jbernard | im skeptical of solutions in need of problems, but it's certainly something we can dicuss, perhaps you have a reproducer some additional analysis | 14:36 |
| jbernard | #topic open discussion | 14:37 |
| yuval | hey | 14:37 |
| yuval | when is feature freeze for 2025.2? | 14:37 |
| jbernard | https://releases.openstack.org/flamingo/schedule.html#f-ff | 14:38 |
| yuval | did I missed it already? | 14:38 |
| vivek__ | Hello, | 14:38 |
| jbernard | R-5 i believe | 14:38 |
| vivek__ | https://review.opendev.org/c/openstack/cinder/+/951829 | 14:38 |
| Luzi | hi i just wanted to know: how is the review state for the image encryption patches? Is there anything we still need to do? | 14:38 |
| jbernard | yuval: not yet | 14:38 |
| yuval | 28.8? | 14:38 |
| Luzi | Aug 25 - Aug 29 | 14:38 |
| jbernard | Luzi: i need another core reviewer | 14:38 |
| anthonygamboa | Hey everyone, I have what I think is a basic question here but is there detailed documentation on how to modify an existing gerrit merge request submitted by someone else for cinder specifically? I've checked here https://docs.openstack.org/project-team-guide/review-the-openstack-way.html#modifying-a-change and here https://docs.opendev.org/opendev/infra-manual/latest/developers.html#updating-a-change but con | 14:39 |
| jayaanand | https://review.opendev.org/c/openstack/cinder/+/955054 raised patch 10 days back. Please help with review | 14:39 |
| jbernard | Luzi: i was hoping to get it merged early so that we could address any regressions should they arise, but everyone is quite busy this cycle. im still hoping to get it merged, ill try to raise it in Monday's meeting | 14:39 |
| pedrovlf | folks we will talk about the https://review.opendev.org/c/openstack/os-brick/+/955379 (agenda) ? | 14:39 |
| Luzi | thank you jbernard | 14:40 |
| vivek__ | Need review for CINDER plugin registration https://review.opendev.org/c/openstack/cinder/+/951829. As I have updated the patch and removed the OS version as it was having GDPR implications. | 14:40 |
| jbernard | anthonygamboa: merge request, as in: a patch submitted for review? | 14:41 |
| jbernard | anthonygamboa: anyone can update an existing patch, you can use git-review and the author and uploader will then show different values | 14:42 |
| jbernard | anthonygamboa: but it will kindof overwrite someone elses work, so make sure you're being helpful and it's the right action to take | 14:43 |
| jbernard | pedrovlf: sure, what's up? | 14:44 |
| pedrovlf | Hi jbernard we would like a review on the that patch we submit cc: hillpd | 14:45 |
| hillpd | We found a an issue in os-brick where multiple iSCSI logins per path aren’t handled correctly. The current logic stops after finding the first session. In practice, we found that this can prevent the clean-up of devices configured under other sessions. | 14:45 |
| jbernard | pedrovlf: yes, im aware, i haven't had time to look at it yet | 14:46 |
| hillpd | We have a proposed fix and were looking for feedback on this solution. Re: https://review.opendev.org/c/openstack/os-brick/+/955379 | 14:46 |
| hillpd | okay, thanks | 14:46 |
| pedrovlf | also we described the full situation on the https://bugs.launchpad.net/os-brick/+bug/2116553 | 14:47 |
| jbernard | ok, the patch may well be in fine shape, it just needs someone with time to take a look | 14:47 |
| Sandip | Hello Joe, Can you please review this CINDER plugin registration https://review.opendev.org/c/openstack/cinder/+/951829. | 14:48 |
| jbernard | pedrovlf, hillpd: we can raise this in Monday's session | 14:48 |
| * jungleboyj is looking at that one. | 14:48 | |
| Sandip | We have dropped mail regarding previous review comments. | 14:49 |
| pedrovlf | thank you jbernard let us know if you need any other detail | 14:49 |
| jbernard | yep, i see it, it's in the review queue as well | 14:49 |
| jbernard | Sandip: ^ | 14:49 |
| jbernard | pedrovlf: ok, thanks for reaching out | 14:49 |
| vivek__ | Thanks Joe. | 14:49 |
| jbernard | ok, last call for problems, issues, dumpster fires, etc | 14:54 |
| jbernard | good news is alwasy welcome too :) | 14:54 |
| jbernard | thanks everyone! | 14:56 |
| jbernard | #endmeeting | 14:56 |
| opendevmeet | Meeting ended Wed Aug 13 14:56:30 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:56 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2025/cinder.2025-08-13-14.04.html | 14:56 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2025/cinder.2025-08-13-14.04.txt | 14:56 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2025/cinder.2025-08-13-14.04.log.html | 14:56 |
| sp-bmilanov | thanks jbernard! | 14:56 |
| jungleboyj | Thanks! | 14:56 |
| hillpd | Thanks! | 14:56 |
| anthonygamboa | jbernard: thank you. I've tried using git review to check out the change and amend the commit but always get an error "commit 38c9d0d: not Signed-off-by author/committer/uploader in message footer." The thing is, commit 38c9d0d is not the current commit, it's one back | 15:03 |
| anthonygamboa | If I try to sign off on that merge by squashing, I get an error that it is closed and cannot be edited | 15:04 |
| jbernard | anthonygamboa: what is the current commit in that case? | 15:05 |
| jbernard | anthonygamboa: and what is the review number? | 15:05 |
| anthonygamboa | Review number is 869991. Current commit is 1b447e7a8911668fc0062025d045a3cc6f2b66e2 | 15:06 |
| jbernard | anthonygamboa: this is the hitachi replication patch? | 15:10 |
| anthonygamboa | jbernard: yes | 15:11 |
| jbernard | you're doing something wrong, start with a clean cinder checkout | 15:11 |
| jbernard | and then: git review -d 869991 | 15:11 |
| jbernard | you should very probably not be trying to squash anything | 15:12 |
| jbernard | and do make sure you have permission from the author before you overwrite anything | 15:12 |
| anthonygamboa | sure thing, I've already started clean a few times lol | 15:12 |
| jbernard | it worked fine for me | 15:13 |
| anthonygamboa | then just make any change, add it, and amend the current commit to include sign-off? | 15:14 |
| jbernard | yep, that should do it | 15:14 |
| anthonygamboa | did you have to resolve a merge conflict? | 15:17 |
| jbernard | no | 15:17 |
| jbernard | there is no merge conflict | 15:17 |
| jbernard | the review command give you the patch | 15:18 |
| jbernard | make whatever changes | 15:18 |
| jbernard | ammend the commit | 15:18 |
| jbernard | push the changes | 15:18 |
| jbernard | if you're seeing merge conflict, something not right is happening | 15:18 |
| jbernard | there should be no merge operation at all | 15:19 |
| jbernard | or squashing, etc | 15:19 |
| anthonygamboa | I do changes, amend, git review, and get error: | 15:19 |
| anthonygamboa | Auto-merging releasenotes/notes/hitachi-fix-gad-vol-compatibility-e9c62c18f7a12bc7.yaml CONFLICT (add/add): Merge conflict in releasenotes/notes/hitachi-fix-gad-vol-compatibility-e9c62c18f7a12bc7.yaml error: could not apply ff2ebfef3... Hitachi: Fix to have compatibility of GAD volumes | 15:19 |
| jbernard | can you paste all of the terminal interaction to a pastebin? | 15:20 |
| jbernard | start from the beginning | 15:20 |
| anthonygamboa | will do | 15:20 |
| anthonygamboa | pastebin was giving me trouble, hope this works: https://justpaste.it/afkyo | 15:26 |
| jbernard | all of the rev-parse/chmod can be omitted, git-review will do that for you | 15:28 |
| jbernard | just git clone | 15:28 |
| jbernard | git-review -d | 15:28 |
| jbernard | <make edits> | 15:28 |
| jbernard | git commit --amend ... | 15:28 |
| jbernard | there should not be a rebase operation, can you paste your gitconfig? | 15:29 |
| anthonygamboa | git config: https://justpaste.it/emgtb | 15:31 |
| anthonygamboa | got it, I'll try it again with a clean repo | 15:31 |
| jbernard | no, i need to see ~/.gitconfig or ~/.config/git/config | 15:32 |
| jbernard | git config --list shows the repository configuration, i need to see the command configuration | 15:32 |
| jbernard | if you have some auto-rebase thing happening, that could be the cause of this | 15:33 |
| jbernard | in which case a clean repo will not help | 15:33 |
| anthonygamboa | only have a ~/.gitconfig file and here's all that's in it: https://justpaste.it/ah3mp | 15:34 |
| jbernard | try commenting out the [gitreivew] part | 15:34 |
| jbernard | you shoulnd't need additional configuration | 15:34 |
| jbernard | beyond just email and name | 15:34 |
| jbernard | i dont understand what is asking git to rebase when you amend a commit, that is unusual | 15:35 |
| jbernard | yeah, i wonder if the remote=origin causes this | 15:36 |
| jbernard | it comes from your git-review command | 15:37 |
| anthonygamboa | I removed the remote origin and all the extra stuff at checkout https://justpaste.it/gj0g4 | 15:46 |
| jbernard | try recloning the cinder repo | 15:47 |
| jbernard | network unreachable is a different problem | 15:48 |
| jbernard | but lets start with a clean repo | 15:48 |
| jbernard | you have a ssh key setup in the gerrit interface? | 15:49 |
| jbernard | it guess it doesn't matter yet, connect to host fails | 15:49 |
| jbernard | lets see | 15:50 |
| anthonygamboa | it's connected before.. yes, ssh set up | 15:51 |
| anthonygamboa | now git review -d is timing out | 15:51 |
| jbernard | same error? | 15:51 |
| jbernard | ok, that's a networking issue likely | 15:52 |
| jbernard | try this: | 15:52 |
| jbernard | telnet review.opendev.org 29418 | 15:52 |
| jbernard | that should show you the gerrit-ssh ident string | 15:52 |
| anthonygamboa | Trying 162.253.55.233... Trying 2604:e100:1:0:f816:3eff:fe31:926a... telnet: Unable to connect to remote host: Network is unreachable | 15:55 |
| anthonygamboa | yeah, looks like network issue | 15:55 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!