| *** liuyulong_ is now known as liuyulong | 02:25 | |
| *** rpittau|afk is now known as rpittau | 07:13 | |
| yasufum | hi tacker team | 08:00 |
|---|---|---|
| masaki-ueno | hi | 08:00 |
| manpreetk | hi | 08:01 |
| ueha | hi | 08:02 |
| yasufum | hi | 08:02 |
| takahashi-tsc | hi | 08:02 |
| yasufum | #startmeeting tacker | 08:02 |
| opendevmeet | Meeting started Tue Jun 15 08:02:40 2021 UTC and is due to finish in 60 minutes. The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:02 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:02 |
| opendevmeet | The meeting name has been set to 'tacker' | 08:02 |
| yasufum | #link https://etherpad.opendev.org/p/tacker-meeting | 08:02 |
| yasufum | we have one topic today from manpreet. | 08:04 |
| yasufum | could you start it? | 08:04 |
| manpreetk | yes, thanks | 08:04 |
| yasufum | #topic Migration for SQLAlchemy 1.4 | 08:04 |
| manpreetk | The OpenStack has migrated to SqlAlchemy 1.4,this change has cause gate job failures in the tacker. | 08:05 |
| manpreetk | Proposed solution, https://review.opendev.org/c/openstack/tacker/+/796160 | 08:05 |
| manpreetk | But the proposed patch is failing for an open bug in SQLAlchemy. | 08:05 |
| manpreetk | https://github.com/juliotrigo/sqlalchemy-filters/issues/61 | 08:05 |
| manpreetk | 08:05 | |
| manpreetk | Would like to know how to address/resolve this problem in tacker. | 08:05 |
| yasufum | umm | 08:07 |
| yasufum | Have you tried to run unit tests on your local env? | 08:07 |
| manpreetk | yes | 08:08 |
| manpreetk | same results its failing | 08:08 |
| yasufum | I’m not sure from the zuul log at a glance, but seems happened something in sqlalchemy, not in tacker… | 08:14 |
| manpreetk | yes its sqlalchemy problem | 08:14 |
| yasufum | and caused several time through the test. | 08:15 |
| yasufum | Are you sure which version of sqlalchemy running on zuul and your local? Are there the same? | 08:16 |
| manpreetk | Yes i rechecked both versions are same, SQLAlchemy==1.4.15,sqlalchemy-filters==0.12.0 | 08:19 |
| yasufum | got it | 08:19 |
| yasufum | I also would like to know this error happens other patches than yours. | 08:20 |
| yasufum | if you know. | 08:20 |
| manpreetk | i did tried to find the same error in other projects but hard luck :( seems its tacker that is using apply_filters method | 08:21 |
| * yasufum Oops, I’ve found other ones also the same situation, such as https://zuul.opendev.org/t/openstack/build/56881bc1fc2a4fa7b9d8ae7848073e7d | 08:22 | |
| yasufum | https://review.opendev.org/c/openstack/tacker/+/676918 | 08:22 |
| yasufum | manpreet: OK, thanks | 08:22 |
| yasufum | It must be a problem for all updates for tacker, so we should fix it. | 08:24 |
| yasufum | Anyway, I’ll try to find the cause of the error. | 08:26 |
| yasufum | Do you anyone have a comment or suggestion for the issue? | 08:27 |
| ueha | BTW, Looking at the FT error, it seems that the DB migration of barbican failed. | 08:28 |
| ueha | ++ /opt/stack/barbican/devstack/lib/barbican:init_barbican:178 : /usr/local/bin/barbican-manage db upgrade -v head | 08:28 |
| ueha | ERROR: The argument passed to Dialect.has_table() should be a <class 'sqlalchemy.engine.base.Connection'>, got <class 'sqlalchemy.engine.base.Engine'>. Additionally, the Dialect.has_table() method is for internal dialect use only; please use ``inspect(some_engine).has_table(<tablename>>)`` for public API use. | 08:28 |
| manpreetk | Thanks for pointing out, will look into this as well | 08:29 |
| ueha | Barbican seems to be working on migrating Sqlalchemy with the following patch, and Tacker's FT doesn't seem to work until it is merged. | 08:29 |
| ueha | https://review.opendev.org/c/openstack/barbican/+/796059 & https://review.opendev.org/c/openstack/barbican/+/796284 | 08:29 |
| ueha | or either. | 08:30 |
| yasufum | ueha: thank you for sharing. | 08:33 |
| ueha | That's all from my side, I'll also try to find the cause of the error. Thanks. | 08:33 |
| manpreetk | Thanks, would like to know direction for the solution, shall we revisit the tacker query or fix issue in sqlalchemy? | 08:33 |
| yasufum | Although it depends on the situation, I think we’d better to revisit tacker first. | 08:36 |
| manpreetk | Hmm fair enough, would revisit tacker query for solution. Thanks for help, thats all from my side. | 08:37 |
| yasufum | Thanks | 08:39 |
| yasufum | If no more comment, go to next topic. | 08:40 |
| yasufum | or close this meeting if no topics anymore. | 08:40 |
| yasufum | Do you have any topic? | 08:43 |
| ueha | Nothing from my side today, let me talk a little about Zuul FT of Mgmt Driver next week. | 08:43 |
| yasufum | sure | 08:44 |
| takahashi-tsc | Nothing from my side. | 08:44 |
| ueha | Thank you. | 08:44 |
| yasufum | takahashi-tsc: Can I ask you to review patches waiting for another +2? | 08:45 |
| yasufum | After the issue of sqlalchemy is fixed. | 08:45 |
| takahashi-tsc | Sure | 08:45 |
| yasufum | Ah, I should ask team one more thing. | 08:47 |
| yasufum | Asking for voting for the name of Y has posted on ML, so please vote it. | 08:48 |
| yasufum | Thank you for joining today. I’d close this meeting. | 08:48 |
| yasufum | Bye | 08:48 |
| manpreetk | thanks and bye. | 08:49 |
| ueha | Thanks, bye | 08:49 |
| yasufum | #endmeeting tacker | 08:49 |
| opendevmeet | Meeting ended Tue Jun 15 08:49:18 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 08:49 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-06-15-08.02.html | 08:49 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-06-15-08.02.txt | 08:49 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-06-15-08.02.log.html | 08:49 |
| masaki-ueno | bye | 08:49 |
| *** rpittau is now known as rpittau|afk | 14:29 | |
| *** ricolin_ is now known as ricolin | 16:26 | |
| *** ricolin_ is now known as ricolin | 17:32 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!