Tuesday, 2021-06-29

Haunted330This channel is closed after 5pm EST. You are going to have to leave.00:37
yasufumhi tacker team08:00
yasufum#startmeeting tacker08:04
opendevmeetMeeting started Tue Jun 29 08:04:18 2021 UTC and is due to finish in 60 minutes.  The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot.08:04
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.08:04
opendevmeetThe meeting name has been set to 'tacker'08:04
yasufumWe have two topics today from h_asahina and masaki-ueno.08:05
yasufum#link https://etherpad.opendev.org/p/tacker-meeting08:05
yasufumh_asahina: Can you start from your topic?08:06
h_asahinaI pushed a patch today. https://review.opendev.org/c/openstack/tacker/+/79840908:07
h_asahinaThis patch will reorganize the User Guide in the official document according to the revise document plan proposed previsouly.08:07
h_asahinaSince it makes a big change, I'd like to share you all in advance.08:08
h_asahinaThat's all from my side.08:08
yasufumthanks, I agree with your update.08:10
h_asahinathank you08:11
yasufumGo to the next topic if no more comments.08:12
yasufummasaki-ueno: please share your topic.08:13
masaki-uenoWe've uploaded and discussed on two specs in the previous vPTG,08:14
masaki-uenoone is " Alert server for Prometheus with K8s cluster VNF" https://review.opendev.org/c/openstack/tacker-specs/+/78657308:14
masaki-uenoand another is Support Multi-tenant for Kubernetes VIM https://review.opendev.org/c/openstack/tacker-specs/+/78658008:14
masaki-uenoIn those specs, there are some remaining `TBD` part, as Manpreet-san pointed out on Gerrit comments.08:16
masaki-uenoThrough our discussion after the previous vPTG, we found that we need more precise consideration to determine API and Data model in Tacker implementation to fill in those `TBD` parts..08:18
masaki-uenoSo we'd like to postpone merging those two specs, and we'd like to re-discuss in Tacker Y vPTG.08:18
masaki-uenoThat's all from my side, thank you.08:19
yasufumI’ve understand current discussion on these topics.08:22
uehaShould it change to "abandoned" once? or should it change to WIP and move it when the Y release folder is created?08:25
yasufumNo need to do so, but it’s helpful for reviewers to add a comment for describing current your decision.08:26
masaki-uenoSure, I'll post the discussion above and decision on Gerrit comment later.08:27
yasufumIt’s simply listed on the specs of next release.08:27
masaki-uenoThank you :)08:28
yasufumIs there any comment?08:31
yasufumseems nothing.08:32
takahashi-tscNot from my side, they seems not core features for k8s, so postpone is OK.08:32
yasufumDo you have any other topic?08:37
manpreetksorry I added topic quiet late. Its regarding SQL migration08:38
manpreetkOne of the problem in that proposed patch is that it drops "sqlalchemy_filters" and adds new method which just apply filters.08:40
manpreetkFollowing are few possibilities to look into this issue08:40
manpreetk1. Align our method with the method definition provided by "sqlalchemy_filters". I have less/no experience in SqlAlchemy, so probably this solution will take time. 08:40
manpreetk2. Ask the SqlAlchemy community to fix the reported bug https://github.com/juliotrigo/sqlalchemy-filters/issues/61 08:40
manpreetk3. Temporarily switch to the older version of SQLAlchemy for eg. 1.3.23, until the current release 1.4 issues are resolve. This might not be a good idea, and not sure whether it's doable.08:40
manpreetkThanks, thats all from my side.08:40
yasufumDo you mean your current fix is not enough?08:42
yasufumI mean about your comment on etherpad “various other tasks”.08:42
manpreetkYes, what I understood from method imported from sqlalchemy_filters definition does auto join query, then apply filters08:44
yasufumI prefer to replace sqlalchemy_filter with another code in tacker local repo working similar as you suggested.08:51
yasufumI remember that some other projects using similar way, right?08:51
yasufumIs it not helpful for us actually?08:52
yasufumthe project is aodh correctly.08:54
manpreetkIn aodh, customize method was just applying filter nothing more than that. But in tacker we are using ready-made function, and i would like to know why are we using it as I couldn't find any comment regarding the same.08:55
manpreetkhttps://review.opendev.org/c/openstack/tacker/+/716249 this was review ID when this method was introduce.08:57
yasufumI agree your option 3 is not good.09:01
manpreetkyes that doesnt seem doable also09:01
yasufumI think we had better to try to replace it while waiting for update of sqlalchemy_filters.09:02
yasufumI also try to do that.09:05
manpreetkThanks 09:06
uehaI'm also trying in https://review.opendev.org/c/openstack/tacker/+/79780909:06
yasufummanpreet: By the way, I have make some changes for your patch, and uploaded on your PS wrongly. Please ignore if it does not work.09:06
manpreetkueha: thanks for help09:07
uehaI have removed one error, so I would like to give you feedback. https://review.opendev.org/c/openstack/tacker/+/797809/1/tacker/objects/vnf_lcm_op_occs.py09:07
uehaI will try modifying apply_filter too. thanks09:09
manpreetkThanks will update patch as per suggestion09:10
yasufumIf no other comments or topics, lets close this meeting.09:12
uehaNothing from my side.09:13
yasufumThank you for joining.09:15
uehathanks, bye09:15
takahashi-tscthanks bye09:15
manpreetkthanks, bye09:15
opendevmeetMeeting ended Tue Jun 29 09:15:41 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)09:15
opendevmeetMinutes:        https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-06-29-08.04.html09:15
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-06-29-08.04.txt09:15
opendevmeetLog:            https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-06-29-08.04.log.html09:15

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!