| tonyb | melwitt: Thanks. It looks likew we don't 'package' I only spent 2mins looking. I'll just grab it from github and source it. | 00:01 |
|---|---|---|
| *** artom has quit IRC | 00:01 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove compat_instance() https://review.openstack.org/192708 | 00:02 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove flavor migration from db_api and nova-manage https://review.openstack.org/196911 | 00:02 |
| openstackgerrit | Dan Smith proposed openstack/nova: Convert test_compute_utils to use Instance object https://review.openstack.org/196912 | 00:02 |
| *** Longgeek has quit IRC | 00:03 | |
| *** sorrison_laptop has joined #openstack-nova | 00:04 | |
| melwitt | tonyb: yeah, I don't know the packaging situation. quick searching suggests that file should be installed as 'nova' under /etc/bash_completion.d/ so out of curiosity I'll probably find out how we could make the package do that | 00:06 |
| *** sdake has quit IRC | 00:07 | |
| *** dboik has joined #openstack-nova | 00:11 | |
| *** dims has joined #openstack-nova | 00:12 | |
| *** tsekiyam_ has joined #openstack-nova | 00:13 | |
| *** dboik has quit IRC | 00:15 | |
| *** sajeesh has joined #openstack-nova | 00:16 | |
| *** mtanino has quit IRC | 00:16 | |
| *** tsekiyama has quit IRC | 00:17 | |
| *** SourabhP has quit IRC | 00:17 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Convert test_compute_utils to use Instance object https://review.openstack.org/196912 | 00:18 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove flavor migration from db_api and nova-manage https://review.openstack.org/196911 | 00:18 |
| *** marun has joined #openstack-nova | 00:18 | |
| *** tjones1 has quit IRC | 00:18 | |
| sajeesh | ping jaypipes | 00:18 |
| *** tsekiyam_ has quit IRC | 00:18 | |
| *** claudiub has joined #openstack-nova | 00:21 | |
| openstackgerrit | Michael Still proposed openstack/nova: log meaningful error message on download exception https://review.openstack.org/164039 | 00:21 |
| openstackgerrit | Michael Still proposed openstack/nova: Cleanup log lines in nova.image.glance https://review.openstack.org/196914 | 00:21 |
| *** SourabhP has joined #openstack-nova | 00:23 | |
| *** SourabhP has quit IRC | 00:27 | |
| *** ildikov_ has quit IRC | 00:28 | |
| *** boris-42 has joined #openstack-nova | 00:31 | |
| openstackgerrit | Tony Breeds proposed openstack/python-novaclient: Add bash completion to /etc https://review.openstack.org/196919 | 00:34 |
| *** marun_ has joined #openstack-nova | 00:40 | |
| *** ildikov_ has joined #openstack-nova | 00:41 | |
| *** marun has quit IRC | 00:41 | |
| *** gibi_ has quit IRC | 00:42 | |
| *** gmann has quit IRC | 00:48 | |
| *** thorst has joined #openstack-nova | 00:48 | |
| *** nic1 has joined #openstack-nova | 00:49 | |
| *** nic has quit IRC | 00:50 | |
| *** patrickeast has quit IRC | 00:53 | |
| *** gmann has joined #openstack-nova | 01:00 | |
| *** marun_ has quit IRC | 01:01 | |
| *** annegentle has joined #openstack-nova | 01:02 | |
| *** otter768 has joined #openstack-nova | 01:03 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me - trying oslo.* master against Nova unit tests https://review.openstack.org/186413 | 01:03 |
| tonyb | Is anyone else seeing tox -epy27 fail ing with: http://paste.openstack.org/show/326540/ ? | 01:03 |
| *** gibi has joined #openstack-nova | 01:04 | |
| *** annegentle has quit IRC | 01:06 | |
| dims | tonyb: https://review.openstack.org/#/c/196826/1/global-requirements.txt,cm | 01:06 |
| *** zhenguo has joined #openstack-nova | 01:07 | |
| *** otter768 has quit IRC | 01:07 | |
| *** ildikov_ has quit IRC | 01:11 | |
| openstackgerrit | Fei Long Wang proposed openstack/nova: Fix nova backup for volume-backed instance https://review.openstack.org/164494 | 01:14 |
| *** markvoelker has quit IRC | 01:19 | |
| *** markvoelker has joined #openstack-nova | 01:19 | |
| tonyb | dims: Ahh okay thanks. | 01:20 |
| *** pixelb has quit IRC | 01:20 | |
| *** pixelb has joined #openstack-nova | 01:21 | |
| *** markvoelker has quit IRC | 01:22 | |
| *** markvoelker has joined #openstack-nova | 01:23 | |
| *** markvoelker has quit IRC | 01:23 | |
| *** markvoelker has joined #openstack-nova | 01:24 | |
| *** lucas__ has joined #openstack-nova | 01:26 | |
| *** otter768 has joined #openstack-nova | 01:27 | |
| *** lucas__ has quit IRC | 01:28 | |
| *** dave-mccowan has quit IRC | 01:28 | |
| *** nic1 has quit IRC | 01:30 | |
| *** jasondotstar has quit IRC | 01:30 | |
| *** piyanai has joined #openstack-nova | 01:30 | |
| *** dave-mccowan has joined #openstack-nova | 01:32 | |
| *** agireud has joined #openstack-nova | 01:33 | |
| *** Sukhdev has quit IRC | 01:34 | |
| *** timsim has joined #openstack-nova | 01:38 | |
| *** timsim has left #openstack-nova | 01:38 | |
| *** tobe has joined #openstack-nova | 01:38 | |
| *** tobe has quit IRC | 01:39 | |
| *** yamahata has quit IRC | 01:43 | |
| *** Marga_ has joined #openstack-nova | 01:45 | |
| *** Marga_ has quit IRC | 01:48 | |
| *** Marga_ has joined #openstack-nova | 01:49 | |
| *** otter768 has quit IRC | 01:55 | |
| sajeesh | ping dims | 01:56 |
| dims | sajeesh: pong | 01:57 |
| sajeesh | hi dims ...tempest tests are failing for https://review.openstack.org/#/c/182140 | 01:57 |
| sajeesh | I think it is because I am removing project_id from wsgi.py file | 01:58 |
| *** jasondotstar has joined #openstack-nova | 01:59 | |
| sajeesh | what is the best way to pass this test. Can I edit https://github.com/openstack/tempest/blob/master/tempest/api/compute/test_authorization.py#L195-L216 | 01:59 |
| *** jasondotstar has quit IRC | 02:00 | |
| *** jasondotstar has joined #openstack-nova | 02:00 | |
| dims | sajeesh: 3 tests fail? | 02:02 |
| *** ijw has quit IRC | 02:02 | |
| sajeesh | yes | 02:03 |
| dims | are the tests wrong? | 02:04 |
| sajeesh | whether editing the above file will be good idea to pass one of those tests ? | 02:04 |
| sajeesh | test is not wrong...but it is expecting project_id,which was earlier there | 02:05 |
| dims | same thing for all 3? | 02:05 |
| sajeesh | only one I have checked | 02:06 |
| *** jasondotstar has quit IRC | 02:06 | |
| *** jasondotstar has joined #openstack-nova | 02:06 | |
| *** SourabhP has joined #openstack-nova | 02:06 | |
| *** SourabhP has quit IRC | 02:06 | |
| dims | see what you end up with to pass the tests | 02:07 |
| sajeesh | ? | 02:07 |
| dims | see what you have to change to pass the tests | 02:07 |
| sajeesh | I think I have to edit the above file ,such that it don't expect project_id | 02:08 |
| *** agireud has quit IRC | 02:08 | |
| *** mutoulbj has joined #openstack-nova | 02:10 | |
| *** dave-mccowan has quit IRC | 02:13 | |
| *** sorrison_laptop has quit IRC | 02:13 | |
| *** tobe has joined #openstack-nova | 02:16 | |
| *** mriedem_away has quit IRC | 02:16 | |
| *** unicell has quit IRC | 02:19 | |
| *** tojuvone has joined #openstack-nova | 02:20 | |
| *** kylek3h has joined #openstack-nova | 02:26 | |
| *** hemna has quit IRC | 02:28 | |
| *** asselin has quit IRC | 02:28 | |
| *** hemna has joined #openstack-nova | 02:29 | |
| *** sambol has joined #openstack-nova | 02:29 | |
| *** asselin has joined #openstack-nova | 02:29 | |
| *** baoli has joined #openstack-nova | 02:31 | |
| *** bkopilov has quit IRC | 02:32 | |
| *** agireud has joined #openstack-nova | 02:39 | |
| *** ijw has joined #openstack-nova | 02:44 | |
| *** mriedem has joined #openstack-nova | 02:45 | |
| mriedem | well, the gate is wedged http://lists.openstack.org/pipermail/openstack-dev/2015-June/068289.html | 02:46 |
| mriedem | circular dependency city | 02:47 |
| mriedem | haypo: how is https://review.openstack.org/#/c/196719/ passing when oslo.db 2.0 isn't out yet? | 02:48 |
| mriedem | but this is failing http://logs.openstack.org/25/194325/9/check/gate-nova-python27/ba2a040/console.html#_2015-06-29_22_29_22_094 | 02:48 |
| *** sajeesh has quit IRC | 02:49 | |
| *** mmedvede has quit IRC | 02:50 | |
| dims | mriedem: i am working another angle - https://review.openstack.org/196926 - trying to see if we can get a 0.5.1 of o.vo out | 02:50 |
| *** agireud has quit IRC | 02:51 | |
| mriedem | ok | 02:56 |
| mriedem | dims: we still have the circular dep in nova though | 02:57 |
| mriedem | oh i guess oslo.db 2.0.0 is out now | 02:58 |
| mriedem | so, i basically need to squash haypo's change with the g-r update | 02:59 |
| *** Longgeek has joined #openstack-nova | 03:00 | |
| dims | mriedem: yep | 03:05 |
| *** Longgeek has quit IRC | 03:05 | |
| mriedem | working on it | 03:05 |
| *** kevinbenton has joined #openstack-nova | 03:08 | |
| *** piyanai has quit IRC | 03:08 | |
| *** piyanai has joined #openstack-nova | 03:09 | |
| *** flashgordon has quit IRC | 03:13 | |
| *** claudiub has quit IRC | 03:15 | |
| *** diogogmt has joined #openstack-nova | 03:15 | |
| *** baoli has quit IRC | 03:18 | |
| openstackgerrit | lifeless proposed openstack/nova: Remove python3 specific test-requirements file. https://review.openstack.org/196934 | 03:19 |
| mriedem | heh, we probably need that too ^ | 03:21 |
| mriedem | this is a fine mess | 03:21 |
| lifeless | feel free to take it over | 03:25 |
| lifeless | I'm going to work on the infra side job in a little bit | 03:25 |
| *** kylek3h has quit IRC | 03:25 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Fix Python 3 issues in nova.db.sqlalchemy https://review.openstack.org/195191 | 03:28 |
| mriedem | lifeless: squashed there ^ added you as co-author | 03:28 |
| mriedem | haypo: dims: dansmith: ^ | 03:28 |
| *** diogogmt_ has joined #openstack-nova | 03:29 | |
| *** diogogmt has quit IRC | 03:29 | |
| *** diogogmt_ is now known as diogogmt | 03:29 | |
| *** diogogmt has quit IRC | 03:31 | |
| *** masayukig has quit IRC | 03:31 | |
| *** markvoelker has quit IRC | 03:31 | |
| *** ijw_ has joined #openstack-nova | 03:32 | |
| mriedem | lifeless: or not, damn https://jenkins07.openstack.org/job/gate-nova-requirements/262/console | 03:32 |
| lifeless | mriedem: is that from my patch ? | 03:33 |
| mriedem | lifeless: it's from the squashed one with your change | 03:34 |
| mriedem | https://review.openstack.org/#/c/195191/ | 03:34 |
| lifeless | https://review.openstack.org/196940 is the infra side fix | 03:34 |
| *** piyanai has quit IRC | 03:35 | |
| mriedem | ok, i'll add the depends-on | 03:35 |
| *** ijw has quit IRC | 03:35 | |
| lifeless | won't help | 03:36 |
| lifeless | thats not CIable | 03:36 |
| *** masayukig has joined #openstack-nova | 03:36 | |
| lifeless | its the code that runs in the job to do check-requirements | 03:36 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Fix Python 3 issues in nova.db.sqlalchemy https://review.openstack.org/195191 | 03:36 |
| *** thorst has quit IRC | 03:36 | |
| *** Longgeek has joined #openstack-nova | 03:37 | |
| dims | mriedem: back to my 0.5.1 plan? | 03:38 |
| mriedem | dims: that won't help | 03:38 |
| mriedem | dims: b/c it would require a g-r update anyway | 03:38 |
| lifeless | mriedem: the co-authored-by-tere shold be my hp address btw | 03:38 |
| mriedem | which won't work w/o haypo's fix for the oslo.db change and lifeless' change | 03:38 |
| mriedem | lifeless: want to give me the full thing? | 03:38 |
| lifeless | mriedem: rbtcollins@hp.com - but only if you have to respin it | 03:39 |
| lifeless | mriedem: gr blacklists 0.5.0 now | 03:39 |
| mriedem | lifeless: still use lifeless or call out your human name? | 03:39 |
| lifeless | mriedem: so there's no need to change g-r to unwedge nova | 03:39 |
| lifeless | mriedem: either is fine :) | 03:40 |
| dims | mriedem: no my 0.5.1 will not need a g-r update | 03:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Fix Python 3 issues in nova.db.sqlalchemy https://review.openstack.org/195191 | 03:40 |
| mriedem | dims: couldn't hurt at this point | 03:41 |
| mriedem | 0.5.1 i mean | 03:41 |
| *** SpamapS has joined #openstack-nova | 03:41 | |
| lifeless | mriedem: is /nova/ wedged | 03:41 |
| lifeless | mriedem: or the integrated gate? | 03:41 |
| *** yamahata has joined #openstack-nova | 03:41 | |
| mriedem | lifeless: nova | 03:42 |
| lifeless | mriedem: so with g-r updated | 03:42 |
| lifeless | if anything installed versionedobjects before nova is installed | 03:42 |
| lifeless | nova will be fine | 03:42 |
| mriedem | well, we still need haypo's set of fixes in nova for oslo.db 2.0 changes | 03:43 |
| mriedem | but i could undo the bigger squash here | 03:43 |
| lifeless | well | 03:43 |
| lifeless | lets wait and see | 03:43 |
| mriedem | yeah, honestly, i'm not going to be up another hour monitoring htis | 03:43 |
| lifeless | if it works. I say unfuck things. | 03:43 |
| mriedem | yeah i'm watching https://review.openstack.org/#/c/196926/ in the gate | 03:45 |
| dims | mriedem: am turning in too. will check on things first thing when i wake up | 03:46 |
| *** jasondotstar has quit IRC | 03:47 | |
| dims | 196926 is in gate (got past check). i have to run it against nova unit tests and then cut 0.5.1 | 03:47 |
| *** dims has quit IRC | 03:48 | |
| *** bkopilov has joined #openstack-nova | 03:52 | |
| *** mriedem has quit IRC | 03:53 | |
| *** otter768 has joined #openstack-nova | 03:56 | |
| *** otter768 has quit IRC | 04:01 | |
| *** Longgeek has quit IRC | 04:05 | |
| *** Longgeek has joined #openstack-nova | 04:06 | |
| *** coolsvap|away is now known as coolsvap | 04:08 | |
| *** sdake has joined #openstack-nova | 04:09 | |
| *** sdake_ has joined #openstack-nova | 04:10 | |
| *** unicell has joined #openstack-nova | 04:12 | |
| *** david-lyle has quit IRC | 04:13 | |
| *** rajesht has joined #openstack-nova | 04:13 | |
| *** achanda has joined #openstack-nova | 04:13 | |
| *** sdake has quit IRC | 04:13 | |
| *** david-lyle has joined #openstack-nova | 04:14 | |
| *** ekhugen has quit IRC | 04:14 | |
| *** zz_jgrimm has quit IRC | 04:15 | |
| *** timello has quit IRC | 04:15 | |
| *** maurosr has quit IRC | 04:15 | |
| *** bkopilov has quit IRC | 04:17 | |
| openstackgerrit | javeme proposed openstack/nova: VMware: Prefer ShutdownGuest to PowerOffVM_Task https://review.openstack.org/181634 | 04:19 |
| *** kmartin_ has joined #openstack-nova | 04:19 | |
| *** kmartin has quit IRC | 04:19 | |
| *** unicell1 has joined #openstack-nova | 04:22 | |
| *** bkopilov has joined #openstack-nova | 04:23 | |
| *** ekhugen has joined #openstack-nova | 04:23 | |
| *** unicell has quit IRC | 04:23 | |
| *** timello has joined #openstack-nova | 04:24 | |
| *** agireud has joined #openstack-nova | 04:24 | |
| *** sdake has joined #openstack-nova | 04:25 | |
| *** zz_jgrimm has joined #openstack-nova | 04:26 | |
| *** varunarya has joined #openstack-nova | 04:27 | |
| *** maurosr has joined #openstack-nova | 04:27 | |
| *** sdake_ has quit IRC | 04:29 | |
| *** achanda has quit IRC | 04:30 | |
| *** tobe has quit IRC | 04:31 | |
| *** hogepodge has quit IRC | 04:32 | |
| *** markvoelker has joined #openstack-nova | 04:32 | |
| *** ijw has joined #openstack-nova | 04:32 | |
| *** tobe has joined #openstack-nova | 04:32 | |
| *** hogepodge has joined #openstack-nova | 04:32 | |
| *** sambol has quit IRC | 04:32 | |
| *** ijw__ has joined #openstack-nova | 04:33 | |
| *** ijw_ has quit IRC | 04:35 | |
| *** ijw_ has joined #openstack-nova | 04:35 | |
| *** ijw has quit IRC | 04:36 | |
| *** ijw_ has quit IRC | 04:36 | |
| *** ijw has joined #openstack-nova | 04:36 | |
| *** markvoelker has quit IRC | 04:36 | |
| *** ijw_ has joined #openstack-nova | 04:37 | |
| *** ekhugen has quit IRC | 04:39 | |
| *** timello has quit IRC | 04:39 | |
| *** zz_jgrimm has quit IRC | 04:39 | |
| *** irenab has quit IRC | 04:40 | |
| *** agireud has quit IRC | 04:40 | |
| *** maurosr has quit IRC | 04:40 | |
| *** ijw__ has quit IRC | 04:40 | |
| *** ekhugen has joined #openstack-nova | 04:41 | |
| *** zz_jgrimm has joined #openstack-nova | 04:42 | |
| *** maurosr has joined #openstack-nova | 04:42 | |
| *** timello has joined #openstack-nova | 04:42 | |
| *** ijw__ has joined #openstack-nova | 04:43 | |
| *** zsais has joined #openstack-nova | 04:44 | |
| *** ijw___ has joined #openstack-nova | 04:44 | |
| *** ijw__ has quit IRC | 04:45 | |
| *** ijw has quit IRC | 04:46 | |
| *** ijw_ has quit IRC | 04:47 | |
| *** ijw has joined #openstack-nova | 04:49 | |
| *** amotoki_ has joined #openstack-nova | 04:49 | |
| *** arnaud____ has joined #openstack-nova | 04:50 | |
| *** ijw___ has quit IRC | 04:51 | |
| *** kiran-r has joined #openstack-nova | 04:52 | |
| *** agireud has joined #openstack-nova | 04:53 | |
| *** arnaud____ has quit IRC | 04:54 | |
| *** agireud has quit IRC | 04:57 | |
| *** sdake_ has joined #openstack-nova | 04:59 | |
| *** kiran-r has quit IRC | 05:00 | |
| *** arnaud____ has joined #openstack-nova | 05:00 | |
| *** erlon has quit IRC | 05:00 | |
| *** kiran-r has joined #openstack-nova | 05:03 | |
| *** sdake has quit IRC | 05:03 | |
| *** tjones1 has joined #openstack-nova | 05:04 | |
| *** prashup has joined #openstack-nova | 05:12 | |
| *** kiran-r has quit IRC | 05:17 | |
| *** zsais has quit IRC | 05:18 | |
| *** fawadkhaliq has joined #openstack-nova | 05:18 | |
| *** ijw_ has joined #openstack-nova | 05:18 | |
| *** kiran-r has joined #openstack-nova | 05:18 | |
| *** oro has joined #openstack-nova | 05:21 | |
| *** prashant_ has joined #openstack-nova | 05:21 | |
| *** wanghua has quit IRC | 05:22 | |
| *** _kiran_ has joined #openstack-nova | 05:23 | |
| *** ildikov has joined #openstack-nova | 05:23 | |
| *** zhenguo has quit IRC | 05:23 | |
| *** wanghua has joined #openstack-nova | 05:24 | |
| *** amotoki__ has joined #openstack-nova | 05:24 | |
| *** kiran-r has quit IRC | 05:24 | |
| *** amotoki_ has quit IRC | 05:24 | |
| *** prashup has quit IRC | 05:25 | |
| *** nihilifer has joined #openstack-nova | 05:25 | |
| *** prashant__ has joined #openstack-nova | 05:25 | |
| *** _kiran_ is now known as kiran-r | 05:27 | |
| *** Sukhdev has joined #openstack-nova | 05:28 | |
| *** prashant_ has quit IRC | 05:29 | |
| *** prashant_ has joined #openstack-nova | 05:31 | |
| *** arnaud____ has quit IRC | 05:31 | |
| *** xyhuang has joined #openstack-nova | 05:34 | |
| *** prashant__ has quit IRC | 05:35 | |
| *** Dev_Jin has joined #openstack-nova | 05:35 | |
| *** prashant__ has joined #openstack-nova | 05:36 | |
| *** ijw_ has quit IRC | 05:38 | |
| *** ajayaa has joined #openstack-nova | 05:39 | |
| openstackgerrit | Tony Breeds proposed openstack/nova: Add support for one time tokens in consoleauth https://review.openstack.org/182129 | 05:39 |
| *** prashant_ has quit IRC | 05:39 | |
| *** prashant_ has joined #openstack-nova | 05:41 | |
| *** asettle has joined #openstack-nova | 05:42 | |
| *** hogepodge has quit IRC | 05:42 | |
| *** hogepodge has joined #openstack-nova | 05:42 | |
| *** Marga_ has quit IRC | 05:43 | |
| *** nkrinner has joined #openstack-nova | 05:44 | |
| *** tjones1 has quit IRC | 05:44 | |
| *** prashant__ has quit IRC | 05:44 | |
| *** prashant__ has joined #openstack-nova | 05:46 | |
| *** kiran-r has quit IRC | 05:46 | |
| *** achanda has joined #openstack-nova | 05:48 | |
| *** ijw has quit IRC | 05:48 | |
| *** prashant_ has quit IRC | 05:49 | |
| *** prashant_ has joined #openstack-nova | 05:49 | |
| *** Jeffrey4l has joined #openstack-nova | 05:51 | |
| *** garyk has joined #openstack-nova | 05:51 | |
| *** browne has quit IRC | 05:53 | |
| *** Murali has joined #openstack-nova | 05:53 | |
| *** prashant__ has quit IRC | 05:53 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for keypair https://review.openstack.org/176231 | 05:53 |
| *** radek_ has joined #openstack-nova | 05:53 | |
| *** prashant__ has joined #openstack-nova | 05:54 | |
| *** markvoelker has joined #openstack-nova | 05:56 | |
| *** otter768 has joined #openstack-nova | 05:57 | |
| *** prashant_ has quit IRC | 05:57 | |
| *** rajesht has quit IRC | 05:58 | |
| *** deepthi has joined #openstack-nova | 05:58 | |
| *** prashant_ has joined #openstack-nova | 05:59 | |
| *** browne has joined #openstack-nova | 06:00 | |
| *** ankit_ag has joined #openstack-nova | 06:00 | |
| *** xgsa has joined #openstack-nova | 06:00 | |
| *** markvoelker has quit IRC | 06:01 | |
| *** otter768 has quit IRC | 06:02 | |
| *** prashant__ has quit IRC | 06:03 | |
| *** achanda has quit IRC | 06:04 | |
| *** arnaud____ has joined #openstack-nova | 06:06 | |
| *** irenab has joined #openstack-nova | 06:07 | |
| *** Sukhdev_ has joined #openstack-nova | 06:08 | |
| *** prashant__ has joined #openstack-nova | 06:08 | |
| *** xgsa has quit IRC | 06:09 | |
| *** Sukhdev has quit IRC | 06:11 | |
| *** prashant_ has quit IRC | 06:12 | |
| *** agireud has joined #openstack-nova | 06:21 | |
| *** prashant__ has quit IRC | 06:21 | |
| *** Marga_ has joined #openstack-nova | 06:26 | |
| *** achanda has joined #openstack-nova | 06:26 | |
| *** prashup has joined #openstack-nova | 06:28 | |
| *** varunarya has quit IRC | 06:29 | |
| *** sdake_ has quit IRC | 06:29 | |
| *** mpaolino has joined #openstack-nova | 06:30 | |
| *** lsmola has joined #openstack-nova | 06:33 | |
| *** scheuran has joined #openstack-nova | 06:33 | |
| *** ajayaa_ has joined #openstack-nova | 06:34 | |
| *** ajayaa has quit IRC | 06:34 | |
| *** prashant_ has joined #openstack-nova | 06:38 | |
| *** asettle has quit IRC | 06:39 | |
| *** SourabhP has joined #openstack-nova | 06:41 | |
| *** sirushti has joined #openstack-nova | 06:41 | |
| *** prashup has quit IRC | 06:42 | |
| *** Sukhdev_ has quit IRC | 06:47 | |
| *** prashant__ has joined #openstack-nova | 06:47 | |
| *** prashant_ has quit IRC | 06:50 | |
| *** belmoreira has joined #openstack-nova | 06:52 | |
| *** browne has quit IRC | 06:52 | |
| *** doude has joined #openstack-nova | 06:53 | |
| *** prashant_ has joined #openstack-nova | 06:56 | |
| *** prashant__ has quit IRC | 06:59 | |
| *** arnaud____ has quit IRC | 07:01 | |
| *** boris-42 has quit IRC | 07:02 | |
| *** achanda has quit IRC | 07:03 | |
| *** SourabhP has quit IRC | 07:04 | |
| *** prashant__ has joined #openstack-nova | 07:06 | |
| *** kiran-r has joined #openstack-nova | 07:09 | |
| *** prashant_ has quit IRC | 07:09 | |
| *** moshele has joined #openstack-nova | 07:10 | |
| *** agireud has quit IRC | 07:17 | |
| *** prashant_ has joined #openstack-nova | 07:17 | |
| *** markus_z has joined #openstack-nova | 07:19 | |
| *** kaisers1 has joined #openstack-nova | 07:19 | |
| *** prashant__ has quit IRC | 07:20 | |
| *** ijw has joined #openstack-nova | 07:21 | |
| *** ijw_ has joined #openstack-nova | 07:22 | |
| *** ijw__ has joined #openstack-nova | 07:24 | |
| *** romainh has joined #openstack-nova | 07:25 | |
| *** romainh has left #openstack-nova | 07:25 | |
| *** humble_ has joined #openstack-nova | 07:26 | |
| *** wanghua has quit IRC | 07:26 | |
| *** ijw_ has quit IRC | 07:27 | |
| *** lpetrut has joined #openstack-nova | 07:28 | |
| *** ijw__ has quit IRC | 07:29 | |
| *** ijw_ has joined #openstack-nova | 07:29 | |
| *** kaisers1 has quit IRC | 07:29 | |
| *** kaisers1 has joined #openstack-nova | 07:29 | |
| *** oro has quit IRC | 07:29 | |
| *** irenab has quit IRC | 07:30 | |
| *** matrohon has joined #openstack-nova | 07:30 | |
| *** irenab has joined #openstack-nova | 07:30 | |
| *** subscope has quit IRC | 07:31 | |
| *** prashant_ has quit IRC | 07:32 | |
| *** jlanoux has joined #openstack-nova | 07:37 | |
| *** pask81 has joined #openstack-nova | 07:38 | |
| *** sahid has quit IRC | 07:38 | |
| *** sahid has joined #openstack-nova | 07:39 | |
| *** ndipanov has quit IRC | 07:42 | |
| *** ijw has quit IRC | 07:43 | |
| *** jistr has joined #openstack-nova | 07:43 | |
| *** ndipanov has joined #openstack-nova | 07:44 | |
| *** markvoelker has joined #openstack-nova | 07:45 | |
| *** subscope has joined #openstack-nova | 07:47 | |
| *** rotbeard has joined #openstack-nova | 07:47 | |
| *** armax has quit IRC | 07:48 | |
| *** mpavone has joined #openstack-nova | 07:49 | |
| *** markvoelker has quit IRC | 07:50 | |
| *** amotoki__ has quit IRC | 07:50 | |
| *** zhenguo has joined #openstack-nova | 07:50 | |
| *** yamahata has quit IRC | 07:52 | |
| *** sdake_ has joined #openstack-nova | 07:55 | |
| *** subscope has quit IRC | 07:55 | |
| *** xgsa has joined #openstack-nova | 07:56 | |
| *** otter768 has joined #openstack-nova | 07:58 | |
| *** claudiub has joined #openstack-nova | 08:02 | |
| *** otter768 has quit IRC | 08:02 | |
| *** jistr has quit IRC | 08:03 | |
| *** lucasagomes has joined #openstack-nova | 08:05 | |
| *** Kevin_Zheng has joined #openstack-nova | 08:10 | |
| *** Administrator__ has joined #openstack-nova | 08:10 | |
| *** Administrator__ has quit IRC | 08:10 | |
| *** jistr has joined #openstack-nova | 08:10 | |
| *** garyk has quit IRC | 08:10 | |
| *** subscope has joined #openstack-nova | 08:11 | |
| *** danpb has joined #openstack-nova | 08:12 | |
| *** garyk has joined #openstack-nova | 08:13 | |
| *** foexle has joined #openstack-nova | 08:13 | |
| haypo | morning. i see that oslo.db 2.0 was released, and that most nova gates are "UNSTABLE" :-( | 08:16 |
| haypo | https://review.openstack.org/#/c/195191/ was not merged yet... | 08:16 |
| haypo | crap | 08:16 |
| *** tobe has quit IRC | 08:17 | |
| danpb | what does it even mean when jenkins reports it as "UNSTABLE" ? | 08:20 |
| wanghao | I wanna know it too. | 08:21 |
| *** lpetrut has quit IRC | 08:22 | |
| *** derekh has joined #openstack-nova | 08:22 | |
| *** Dev_Jin has quit IRC | 08:23 | |
| openstackgerrit | Victor Stinner proposed openstack/nova: Update test_db_api for oslo.db 2.0 https://review.openstack.org/196719 | 08:23 |
| *** subscope has quit IRC | 08:24 | |
| bauzas | haypo: yup, the gate is wedged since yesterday evening | 08:24 |
| bauzas | haypo: https://bugs.launchpad.net/oslo.versionedobjects/+bug/1469865 | 08:24 |
| openstack | Launchpad bug 1469865 in OpenStack Compute (nova) "oslo.versionedobjects breaks nova/cinder tests" [Critical,In progress] - Assigned to Matt Riedemann (mriedem) | 08:24 |
| haypo | danpb, dansmith : https://review.openstack.org/196719 fixes nova.tests.unit.db.test_db_api.InstanceExtraTestCase.test_instance_extra_get_with_columns - oslo.db 2.0 was released | 08:24 |
| openstackgerrit | garyk proposed openstack/nova: Compute: enable admin to decide action for conflicting states https://review.openstack.org/190047 | 08:24 |
| bauzas | haypo: have you seen mriedem's email ? | 08:25 |
| haypo | i rewrote https://review.openstack.org/196719 to not depend on my python 3 patch | 08:25 |
| haypo | bauzas: ah there is an email? i will read it | 08:25 |
| bauzas | haypo: yup, look at the bug and see mriedem's email, sec getting it | 08:25 |
| haypo | bauzas: he wrote " But that's failing unit tests which should be fixed in: https://review.openstack.org/#/c/196719/ " | 08:26 |
| haypo | but this patch becomes huge and contains other changes that i don't understand (changes on requirements) | 08:26 |
| haypo | i suggest to merge https://review.openstack.org/196719 instead | 08:26 |
| haypo | i don't know if it's technically possible if they are other issues on the check jobs :-p | 08:27 |
| haypo | what a mess:) | 08:27 |
| bauzas | haypo: unfortunately, I got to bed before knowing the last results of that | 08:27 |
| bauzas | haypo: but the emails are pretty good and see the #openstack-nova logs for further info | 08:28 |
| bauzas | haypo: http://lists.openstack.org/pipermail/openstack-dev/2015-June/068289.html | 08:28 |
| bauzas | haypo: I was about to reply | 08:28 |
| *** garyk has quit IRC | 08:31 | |
| lifeless | haypo: the requirements changes I can explain :) | 08:32 |
| lifeless | haypo: -py3 is deprecated | 08:32 |
| lifeless | haypo: (pbr isn't warning yet, it will soon - see my mail about that) | 08:32 |
| *** neiljerram has joined #openstack-nova | 08:32 | |
| haypo | lifeless: why does someone modified my patch to change requirements? | 08:33 |
| haypo | did* | 08:33 |
| lifeless | haypo: mrieden was gathering together all the things that were broken at once | 08:33 |
| lifeless | and the requirements update needed to get the != 0.5.0 for oslo.versionedobjects was blocked on the duplicate entries in test-requirements{,-py3}.txt | 08:33 |
| lifeless | which my requirements patch fixes | 08:34 |
| lifeless | I don't think that needs to be in the merged together patch now, because dims did a 0.5.1 release | 08:34 |
| lifeless | to unwind the damage | 08:34 |
| *** yassine_ has joined #openstack-nova | 08:34 | |
| haypo | lifeless: oh, i see "oslo.versionedobjects!=0.5.0,>=0.3.0" in requirements.txt | 08:34 |
| bauzas | lifeless: releasing a new o.vo sounds the correct approach, right ? | 08:34 |
| *** oro has joined #openstack-nova | 08:35 | |
| lifeless | bauzas: oh, dims *was going to* | 08:35 |
| lifeless | but its not on pypi | 08:35 |
| lifeless | that might be because something came up | 08:35 |
| bauzas | lifeless: okay, so we are stuck | 08:35 |
| lifeless | or jenkins fell over :/ | 08:35 |
| bauzas | lifeless: yup, jenkins is wedged too AFAICS | 08:35 |
| lifeless | you're stuck until we fix jenkins no matter what | 08:35 |
| lifeless | :0 | 08:35 |
| alex_xu_ | I saw UNSTABLE also... | 08:35 |
| bauzas | http://logs.openstack.org/91/195191/6/check/gate-nova-python27/4a1fdae/console.html#_2015-06-30_05_44_40_808 | 08:36 |
| bauzas | lifeless: ^ | 08:36 |
| *** ijw has joined #openstack-nova | 08:36 | |
| bauzas | lifeless: which is broken by http://logs.openstack.org/91/195191/6/check/gate-nova-python27/4a1fdae/console.html#_2015-06-30_05_44_39_393 | 08:37 |
| *** Nikolay_St has joined #openstack-nova | 08:37 | |
| *** Kennan has quit IRC | 08:38 | |
| *** Kennan has joined #openstack-nova | 08:38 | |
| *** subscope has joined #openstack-nova | 08:38 | |
| *** alex_xu_ is now known as alex_xu | 08:38 | |
| lifeless | bauzas: -> -infra :) | 08:39 |
| bauzas | lifeless: was about :) | 08:39 |
| bauzas | lifeless: was sending an email before :) | 08:39 |
| lifeless | bauzas: and no, pretty sure the nose thing is 100% unrelated | 08:39 |
| lifeless | bauzas: if you look at the java traceback.... | 08:39 |
| bauzas | lifeless: agreed, but that just prevents any forward move | 08:39 |
| lifeless | bauzas: | 08:40 |
| lifeless | bauzas: no | 08:40 |
| lifeless | bauzas: its -unrelated- | 08:40 |
| lifeless | bauzas: its a warn, not an error | 08:40 |
| lifeless | http://logs.openstack.org/91/195191/6/check/gate-nova-python27/4a1fdae/console.html#_2015-06-30_05_44_40_798 | 08:40 |
| lifeless | bauzas: ^ thats the thing its trying to do when it fails | 08:40 |
| bauzas | lifeless: agreed, that's what I said ^ | 08:40 |
| bauzas | :) | 08:41 |
| bauzas | oh my bad | 08:41 |
| bauzas | I see... | 08:41 |
| lifeless | and we have a winner | 08:41 |
| lifeless | xfs volume is readonly | 08:41 |
| *** dguitarbite has joined #openstack-nova | 08:42 | |
| openstackgerrit | Victor Stinner proposed openstack/nova: Update test_db_api for oslo.db 2.0 https://review.openstack.org/196719 | 08:42 |
| johnthetubaguy | kfox1111: I was asleep when you pinged me, currently having to catch up with non-spec review work | 08:43 |
| haypo | lifeless, bauzas : hum ok, i also added "oslo.versionedobjects!=0.5.0,>=0.3.0" in my fix, so this short patch ^^ should be enough to fix nova gates | 08:43 |
| lifeless | haypo: nope | 08:43 |
| lifeless | haypo: not without the project-config fix, static fielsystem recovered and maybe more | 08:44 |
| lifeless | haypo: :/ | 08:44 |
| haypo | lifeless: which project-config fix?7 | 08:45 |
| *** sdake_ has quit IRC | 08:45 | |
| lifeless | haypo: the one for merging requirements | 08:45 |
| haypo | lifeless: "I don't think that needs to be in the merged together patch now, because dims did a 0.5.1 release" there is no 0.5.1 release on PyPI yet. we need something to fix gates right now, no? | 08:45 |
| lifeless | haypo: yes, but -nothing- until infra is intact again and running the new images | 08:47 |
| bauzas | haypo: I think Jenkins has to recover first, before anything | 08:47 |
| haypo | lifeless: i don't know this fix. do you mean that gates will reject my patch https://review.openstack.org/196719 ? i see "oslo.versionedobjects>=0.3.0,!=0.5.0" in global requirements | 08:47 |
| bauzas | haypo: tbc, #status alert OpenStack CI is down due to hard drive failures | 08:48 |
| lifeless | haypo: yes, with the previous images because of the duplication in -py3.txt | 08:48 |
| lifeless | haypo: which I put a fix up for for project-config, which is merged, but sort-of deployed | 08:48 |
| -openstackstatus- NOTICE: OpenStack CI is down due to hard drive failures | 08:48 | |
| *** ChanServ changes topic to "OpenStack CI is down due to hard drive failures" | 08:49 | |
| lifeless | haypo: because the static disk is broken | 08:49 |
| *** ijw has quit IRC | 08:49 | |
| lifeless | haypo: so - its hurry up and wait for a bit | 08:49 |
| *** ijw has joined #openstack-nova | 08:51 | |
| *** ijw__ has joined #openstack-nova | 08:53 | |
| *** moshele has quit IRC | 08:54 | |
| *** prashant_ has joined #openstack-nova | 08:54 | |
| *** bradjones has quit IRC | 08:55 | |
| *** garyk has joined #openstack-nova | 08:55 | |
| *** ijw_ has quit IRC | 08:57 | |
| *** bradjones has joined #openstack-nova | 08:57 | |
| *** bradjones has quit IRC | 08:57 | |
| *** bradjones has joined #openstack-nova | 08:57 | |
| *** moshele has joined #openstack-nova | 08:57 | |
| *** prashant__ has joined #openstack-nova | 09:00 | |
| *** prashant_ has quit IRC | 09:04 | |
| *** prashant_ has joined #openstack-nova | 09:06 | |
| *** ijw__ has quit IRC | 09:09 | |
| *** prashant__ has quit IRC | 09:10 | |
| *** ijw has quit IRC | 09:10 | |
| *** lpetrut has joined #openstack-nova | 09:11 | |
| *** karimb has joined #openstack-nova | 09:12 | |
| *** prashup has joined #openstack-nova | 09:12 | |
| *** prashant_ has quit IRC | 09:15 | |
| *** pask81 has quit IRC | 09:16 | |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce GuestBlock to wrap around Block API https://review.openstack.org/190210 | 09:17 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: update swap volume to use Guest https://review.openstack.org/190211 | 09:17 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: rename GuestVCPUInfo to VCPUInfo https://review.openstack.org/194133 | 09:17 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: make unit tests concise by setup guest object https://review.openstack.org/190963 | 09:17 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce method to wait for block device job https://review.openstack.org/190214 | 09:17 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: update live snapshot to use Guest object https://review.openstack.org/190212 | 09:17 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: update volume delete snapshot to use Guest https://review.openstack.org/190213 | 09:17 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: make host return guest information https://review.openstack.org/191046 | 09:17 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: make host return power state of guest https://review.openstack.org/191047 | 09:17 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: save the memory state of guest https://review.openstack.org/196991 | 09:17 |
| *** casusbelli has joined #openstack-nova | 09:17 | |
| openstackgerrit | Tony Breeds proposed openstack/nova: Fix is_image_extendable() thinko https://review.openstack.org/196992 | 09:18 |
| *** prashant_ has joined #openstack-nova | 09:19 | |
| openstackgerrit | sahid proposed openstack/nova: libvirt: make unit tests concise by setup guest object https://review.openstack.org/190963 | 09:20 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: make host return guest information https://review.openstack.org/191046 | 09:20 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: make host return power state of guest https://review.openstack.org/191047 | 09:20 |
| *** sudipto has joined #openstack-nova | 09:22 | |
| *** prashup has quit IRC | 09:23 | |
| sahid | danpb: hello, any chance i have one your eyes on this serie ^ | 09:23 |
| *** prashant__ has joined #openstack-nova | 09:25 | |
| *** Jeffrey4l has quit IRC | 09:28 | |
| *** prashant_ has quit IRC | 09:28 | |
| *** eliqiao has joined #openstack-nova | 09:29 | |
| *** prashant_ has joined #openstack-nova | 09:31 | |
| *** tdurakov has joined #openstack-nova | 09:32 | |
| *** markvoelker has joined #openstack-nova | 09:34 | |
| *** Jeffrey4l has joined #openstack-nova | 09:36 | |
| *** prashant__ has quit IRC | 09:36 | |
| *** prashant__ has joined #openstack-nova | 09:38 | |
| *** KLB has joined #openstack-nova | 09:38 | |
| *** irenab has quit IRC | 09:39 | |
| KLB | Is nova able to discover/pick up instances created outside of openstack? For example through virsh | 09:39 |
| *** irenab has joined #openstack-nova | 09:39 | |
| *** markvoelker has quit IRC | 09:39 | |
| garyk | KLB: no | 09:40 |
| KLB | garyk: thanks | 09:40 |
| garyk | KLB: it has come up a number of times and the community did not want openstack to discover running VM's and add them to openstack | 09:40 |
| *** prashant_ has quit IRC | 09:42 | |
| *** subscope has quit IRC | 09:44 | |
| *** prashant_ has joined #openstack-nova | 09:44 | |
| *** aix has quit IRC | 09:46 | |
| *** prashant__ has quit IRC | 09:48 | |
| *** prashant__ has joined #openstack-nova | 09:50 | |
| *** ociuhandu has quit IRC | 09:52 | |
| *** irenab has quit IRC | 09:52 | |
| *** karimb has quit IRC | 09:53 | |
| *** ijw has joined #openstack-nova | 09:53 | |
| *** prashant_ has quit IRC | 09:53 | |
| *** Dev_Jin has joined #openstack-nova | 09:54 | |
| *** irenab has joined #openstack-nova | 09:54 | |
| *** karimb has joined #openstack-nova | 09:56 | |
| *** prashant_ has joined #openstack-nova | 09:56 | |
| johnthetubaguy | KLB: garyk is spot on, its something we have decided not to do, its is assumed Nova has full control of the hypervisor. I just realised we probably need to add that in here: http://docs.openstack.org/developer/nova/project_scope.html | 09:57 |
| *** tojuvone has quit IRC | 09:58 | |
| *** Dev_Jin has quit IRC | 09:58 | |
| *** Dev_Jin has joined #openstack-nova | 09:59 | |
| *** otter768 has joined #openstack-nova | 09:59 | |
| *** ijw has quit IRC | 09:59 | |
| *** prashant__ has quit IRC | 10:00 | |
| *** subscope has joined #openstack-nova | 10:01 | |
| *** arnaud____ has joined #openstack-nova | 10:02 | |
| *** prashant__ has joined #openstack-nova | 10:02 | |
| *** moshele has quit IRC | 10:03 | |
| *** Dev_Jin has quit IRC | 10:03 | |
| *** Dev_Jin has joined #openstack-nova | 10:04 | |
| *** otter768 has quit IRC | 10:04 | |
| *** sahid has quit IRC | 10:04 | |
| *** prashant_ has quit IRC | 10:06 | |
| *** irenab has quit IRC | 10:07 | |
| *** arnaud____ has quit IRC | 10:07 | |
| *** prashant_ has joined #openstack-nova | 10:09 | |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Fix overloading of block device on boot by device name https://review.openstack.org/190324 | 10:10 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: API: make sure a blank volume with no size is rejected https://review.openstack.org/188913 | 10:10 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Make Nova better at keeping track of volume sizes in BDM https://review.openstack.org/188914 | 10:10 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Make swap_volume with resize updates BDM size https://review.openstack.org/188915 | 10:10 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: snapshot: Add device_name to the snapshot bdms https://review.openstack.org/190323 | 10:10 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Add documentation for block device mapping https://review.openstack.org/192651 | 10:10 |
| *** sahid has joined #openstack-nova | 10:11 | |
| *** prashant__ has quit IRC | 10:13 | |
| *** coolsvap is now known as coolsvap|away | 10:14 | |
| *** prashant__ has joined #openstack-nova | 10:15 | |
| *** mutoulbj has quit IRC | 10:17 | |
| *** aix has joined #openstack-nova | 10:17 | |
| *** gszasz has joined #openstack-nova | 10:18 | |
| *** prashant_ has quit IRC | 10:18 | |
| *** prashant_ has joined #openstack-nova | 10:21 | |
| *** moshele has joined #openstack-nova | 10:21 | |
| prashant_ | checking alive* | 10:21 |
| *** irenab has joined #openstack-nova | 10:22 | |
| *** ijw has joined #openstack-nova | 10:23 | |
| *** prashant__ has quit IRC | 10:24 | |
| *** irenab has quit IRC | 10:25 | |
| *** prashant__ has joined #openstack-nova | 10:27 | |
| *** mpaolino_ has joined #openstack-nova | 10:27 | |
| *** jlanoux_ has joined #openstack-nova | 10:29 | |
| *** ijw has quit IRC | 10:29 | |
| *** prashant_ has quit IRC | 10:31 | |
| *** jlanoux has quit IRC | 10:31 | |
| *** apuimedo has joined #openstack-nova | 10:32 | |
| *** prashant_ has joined #openstack-nova | 10:34 | |
| *** irenab has joined #openstack-nova | 10:37 | |
| *** irenab has quit IRC | 10:37 | |
| *** ajayaa_ has quit IRC | 10:38 | |
| *** prashant__ has quit IRC | 10:38 | |
| *** irenab has joined #openstack-nova | 10:38 | |
| *** irenab has quit IRC | 10:39 | |
| *** deepthi has quit IRC | 10:39 | |
| *** prashant__ has joined #openstack-nova | 10:40 | |
| *** claudiub has quit IRC | 10:40 | |
| *** irenab has joined #openstack-nova | 10:43 | |
| *** moshele has quit IRC | 10:43 | |
| *** prashant_ has quit IRC | 10:43 | |
| *** karmatronic has joined #openstack-nova | 10:43 | |
| *** karimb has quit IRC | 10:44 | |
| *** prashant_ has joined #openstack-nova | 10:45 | |
| *** moshele has joined #openstack-nova | 10:46 | |
| *** karmatronic has quit IRC | 10:48 | |
| *** prashant__ has quit IRC | 10:49 | |
| *** prashant__ has joined #openstack-nova | 10:49 | |
| *** ociuhandu has joined #openstack-nova | 10:50 | |
| *** jlanoux has joined #openstack-nova | 10:51 | |
| *** prashant_ has quit IRC | 10:53 | |
| *** ajayaa_ has joined #openstack-nova | 10:54 | |
| *** prashant_ has joined #openstack-nova | 10:54 | |
| *** jlanoux_ has quit IRC | 10:55 | |
| *** piyanai has joined #openstack-nova | 10:57 | |
| *** prashant__ has quit IRC | 10:58 | |
| andreykurilin | alex_xu, johnthetubaguy, sdague: hi guys! Should I ask for spec freeze exception for novaclient's microversion support? | 10:59 |
| *** prashant__ has joined #openstack-nova | 10:59 | |
| *** karmatronic has joined #openstack-nova | 11:00 | |
| johnthetubaguy | andreykurilin: its part of the priority effort | 11:02 |
| johnthetubaguy | andreykurilin: it should be listed on the priority etherpad, and not the exception freeze etherpad | 11:02 |
| johnthetubaguy | andreykurilin: have you got a link to that one again? | 11:02 |
| *** prashant_ has quit IRC | 11:03 | |
| *** prashant_ has joined #openstack-nova | 11:03 | |
| andreykurilin | johnthetubaguy: this one? https://etherpad.openstack.org/p/liberty-nova-priorities | 11:05 |
| johnthetubaguy | andreykurilin: this one: https://etherpad.openstack.org/p/liberty-nova-priorities-tracking rather than this one: https://etherpad.openstack.org/p/YVR-nova-liberty-summit-action-items | 11:06 |
| *** karmatronic has quit IRC | 11:06 | |
| *** karimb has joined #openstack-nova | 11:06 | |
| andreykurilin | johnthetubaguy: thanks | 11:06 |
| *** dims has joined #openstack-nova | 11:07 | |
| *** prashant__ has quit IRC | 11:07 | |
| bauzas | johnthetubaguy: heard about the nova gate wedged ? | 11:08 |
| johnthetubaguy | bauzas: yes, heard talk of that earlier | 11:09 |
| bauzas | johnthetubaguy: FYI http://lists.openstack.org/pipermail/openstack-dev/2015-June/068289.html | 11:09 |
| bauzas | johnthetubaguy: okay, I just hitted you for making sure you were aware of | 11:09 |
| bauzas | dims: around ? | 11:09 |
| *** prashant__ has joined #openstack-nova | 11:10 | |
| dims | bauzas: y, just opened up my laptop | 11:10 |
| bauzas | dims: cool | 11:10 |
| * johnthetubaguy is running away to lunch | 11:10 | |
| bauzas | dims: take your time | 11:10 |
| bauzas | dims: but I think we need to discuss on the nova gate problems | 11:10 |
| dims | matt and i were working on the gate wedge last night, checking on status now | 11:10 |
| dims | yes | 11:10 |
| bauzas | dims: yup, I was there yesterday :) | 11:11 |
| bauzas | dims: and I saw your discussions | 11:11 |
| dims | i am in the process of trying the o.vo master with a revert against nova unit tests. if it works then cut 0.5.1 o.vo | 11:12 |
| johnthetubaguy | andreykurilin: the best bet is to try get lots of the API folks to review that, although I think sdague is away this week, and joe is no longer working on Nova, and alex has a new child to look after, so that might be tricky right now | 11:12 |
| bauzas | dims: so, before that, there is an infra problem with the static objects | 11:12 |
| dims | "static objects"? | 11:13 |
| bauzas | dims: see $topic, there is an hard drive failure not yet fixed which means that Jenkins will say UNSTABLE | 11:13 |
| garyk | sahid: thanks for making the chnages | 11:13 |
| bauzas | dims: yup, where the files are going to | 11:13 |
| *** prashant_ has quit IRC | 11:13 | |
| *** exploreshaifali has joined #openstack-nova | 11:13 | |
| dims | bauzas: ah thanks | 11:13 |
| dims | unrelated to our issues | 11:14 |
| bauzas | dims: so, while infra folks work on fixing the hardware problem, I would like to discuss on how to fix the nova gate | 11:14 |
| andreykurilin | johnthetubaguy: ok, I'll try to ping more folks :) | 11:14 |
| bauzas | dims: because we have 2 problems, one with oslo.db and one with o.vo AFAICS | 11:14 |
| dims | bauzas: try the o.vo master (it has a revert). if it works, i'll cut 0.5.1 then we can just merge the oslo.db change first and then the g-r update | 11:16 |
| dims | in that order | 11:16 |
| bauzas | dims: haypo provided a patch for that | 11:17 |
| bauzas | dims: https://review.openstack.org/#/c/196719/3 see PS3 | 11:17 |
| andreykurilin | bauzas, dims: hey hey:) what do you say if I ask you to review my spec related to novalclient support of microversions?:) all previous comments were fixed. also implementation is ready too... | 11:18 |
| bauzas | andreykurilin: sure thing | 11:18 |
| dims | andreykurilin: hit me with the url :) will review after this gate wedge thing | 11:18 |
| dims | bauzas: that looks right | 11:18 |
| andreykurilin | bauzas, dims: thanks. https://review.openstack.org/#/c/188410/ | 11:18 |
| *** IanGovett has joined #openstack-nova | 11:18 | |
| bauzas | andreykurilin: is the spec in the priorities tracking etherpad ? (aka. etherpad of the doom) | 11:18 |
| andreykurilin | bauzas: yes | 11:18 |
| bauzas | andreykurilin: coolio, will do then | 11:19 |
| *** prashant__ has quit IRC | 11:20 | |
| andreykurilin | bauzas: it is the first one in the list of API V2.1 "Specs the subteam are needing to review:" | 11:20 |
| haypo | garyk: hi. for https://review.openstack.org/#/c/196719/3/requirements.txt you wrote "you first need to get this approved in the requirements project" but "!=0.5.0,>=0.3.0" is already in global requirements, it's just in the reverse order (">=0.3.0,!=0.5.0") | 11:20 |
| bauzas | andreykurilin: yeah, I know your spec, I reviewed it a whole days before | 11:21 |
| haypo | garyk: do you mean that a check will reject my patch because the order was different? | 11:21 |
| andreykurilin | bauzas: nice | 11:21 |
| andreykurilin | thanks | 11:21 |
| garyk | haypo: yes, that is correct. pep8 should fail if the requirements are different | 11:22 |
| garyk | haypo: it is odd that the pep8 passed - but in general the bot should do this update. | 11:22 |
| *** mpaolino_ has quit IRC | 11:23 | |
| *** mpaolino has quit IRC | 11:23 | |
| garyk | haypo: the process is that you should first update the requirements project and then when that is approved a bot will automatically update this file | 11:23 |
| openstackgerrit | Victor Stinner proposed openstack/nova: Update test_db_api for oslo.db 2.0 https://review.openstack.org/196719 | 11:23 |
| garyk | so if someone approves this patch the next time the bot updates your code will be overwritten | 11:23 |
| *** ijw has joined #openstack-nova | 11:23 | |
| haypo | garyk: "!=0.5.0" was already merged -- patch written by dims yesterday, https://review.openstack.org/#/c/196826/ | 11:24 |
| *** markvoelker has joined #openstack-nova | 11:24 | |
| *** mutoulbj has joined #openstack-nova | 11:24 | |
| haypo | garyk: i know for the bot, but i wrote this patch to fix nova check jobs | 11:24 |
| haypo | garyk: (well, to fix the 2 regressions caused by oslo.db and oslo.versionedobjects releases) | 11:24 |
| garyk | haypo: ok, understood. thanks for the clarifications. i'll remove the -1 | 11:25 |
| haypo | garyk: i rewrote the requirements in the same order than global requirements :) | 11:25 |
| garyk | haypo: ok, thanks | 11:26 |
| haypo | well, the infra still look broken right now :-p | 11:26 |
| garyk | haypo: if it aint broken don't fix it :) | 11:26 |
| bauzas | haypo: yup, no progress on -infra :( | 11:27 |
| *** thorst has joined #openstack-nova | 11:28 | |
| *** markvoelker has quit IRC | 11:29 | |
| *** ijw has quit IRC | 11:29 | |
| *** subscope has quit IRC | 11:31 | |
| *** ildikov has quit IRC | 11:38 | |
| *** dprince has joined #openstack-nova | 11:40 | |
| *** baoli has joined #openstack-nova | 11:40 | |
| *** tojuvone has joined #openstack-nova | 11:44 | |
| *** subscope has joined #openstack-nova | 11:47 | |
| *** liusheng has quit IRC | 11:48 | |
| *** piyanai has quit IRC | 11:50 | |
| bauzas | dims: sorry was diverted, but using the master for o.vo in my venv made nova.tests.unit.objects.test_instance_numa_topology.TestInstanceNUMATopologyRemote.test_save OK | 11:50 |
| bauzas | dims: so the revert fixes the issue IMHO | 11:51 |
| *** fawadkhaliq has quit IRC | 11:51 | |
| bauzas | dims: checking with http://logs.openstack.org/79/196179/1/gate/gate-nova-python27/4c58cb8/console.html | 11:51 |
| *** ildikov has joined #openstack-nova | 11:51 | |
| *** karimb has quit IRC | 11:53 | |
| *** karimb has joined #openstack-nova | 11:53 | |
| *** mwagner_lap has joined #openstack-nova | 11:54 | |
| *** hshiina has joined #openstack-nova | 11:55 | |
| dims | ack bauzas | 11:56 |
| bauzas | dims: I checked all of the failures and all are fixed, but there is still the oslo.db issue | 11:56 |
| bauzas | dims: IIUC http://paste.openstack.org/show/328273/ | 11:57 |
| * bauzas going out to lunch | 11:57 | |
| *** jistr is now known as jistr|class | 11:59 | |
| *** otter768 has joined #openstack-nova | 12:00 | |
| *** bkopilov has quit IRC | 12:01 | |
| *** markvoelker has joined #openstack-nova | 12:02 | |
| *** pask81 has joined #openstack-nova | 12:04 | |
| *** otter768 has quit IRC | 12:05 | |
| *** jistr|class is now known as jistr | 12:07 | |
| *** jyuso1 has quit IRC | 12:07 | |
| *** claudiub has joined #openstack-nova | 12:10 | |
| dims | bauzas: thanks for confirming | 12:10 |
| *** markvoelker_ has joined #openstack-nova | 12:11 | |
| *** markvoel_ has joined #openstack-nova | 12:13 | |
| *** markvoelker has quit IRC | 12:13 | |
| *** belmoreira has quit IRC | 12:15 | |
| *** sudipto has quit IRC | 12:16 | |
| openstackgerrit | Baodong (Robert) Li proposed openstack/nova: Handle port delete initiated by neutron https://review.openstack.org/179390 | 12:16 |
| *** markvoelker_ has quit IRC | 12:17 | |
| *** subscope has quit IRC | 12:17 | |
| *** Marga_ has quit IRC | 12:21 | |
| *** Marga_ has joined #openstack-nova | 12:21 | |
| *** ijw has joined #openstack-nova | 12:23 | |
| kashyap | markus_z: Saw the comment on your review, that's how I applied the fix - http://paste.openstack.org/show/328320/. I'll re-test in a few w/ current Git master, and reply on the review. | 12:29 |
| *** ijw has quit IRC | 12:29 | |
| *** apuimedo has quit IRC | 12:29 | |
| *** lucasagomes is now known as lucas-hungry | 12:30 | |
| *** ivasev has joined #openstack-nova | 12:31 | |
| *** ajayaa_ has quit IRC | 12:31 | |
| *** aysyd has joined #openstack-nova | 12:32 | |
| * jaypipes puts on some deadmau5, tackles morning email | 12:33 | |
| *** ivasev has quit IRC | 12:34 | |
| *** vladikr has joined #openstack-nova | 12:36 | |
| *** mmedvede has joined #openstack-nova | 12:38 | |
| *** dave-mccowan has joined #openstack-nova | 12:38 | |
| *** edmondsw has joined #openstack-nova | 12:39 | |
| nihilifer | could any core look at this patch? https://review.openstack.org/#/c/195783/ | 12:39 |
| alex_xu | andreykurilin: will catch up review tomorrow | 12:39 |
| *** ivasev has joined #openstack-nova | 12:42 | |
| *** zhenguo has quit IRC | 12:43 | |
| *** dave-mccowan has quit IRC | 12:44 | |
| *** mpaolino_ has joined #openstack-nova | 12:45 | |
| *** mpaolino has joined #openstack-nova | 12:45 | |
| *** mpavone has quit IRC | 12:46 | |
| markus_z | kashyap: That's weird, thanks for double-checking. You've seen the code, it's as harmless as it gets | 12:46 |
| sahid | danpb: i'm thinking about the realtime bp. we do not let operator configure the schdular policy and priority - so i guess since all thread will have the same policy we have to use the round robin one, right? | 12:46 |
| sahid | kashyap: ^ | 12:47 |
| kashyap | markus_z: Yeah, it's mostly my env I guess, I'll add a comment and remove my -1. `make stack` in progress | 12:47 |
| danpb | sahid: at least initially i think we'll have a pre-defined fixed policy | 12:47 |
| jaypipes | nihilifer: I'll try to do a thorough review later today. | 12:48 |
| sahid | sorry i wanted to say. all thread will have he same priority (example 1) | 12:48 |
| sahid | so a fifo policy will not help | 12:48 |
| danpb | sure | 12:49 |
| nihilifer | thanks jaypipes | 12:49 |
| sahid | danpb: so i pre define it to round robin | 12:49 |
| sahid | right? | 12:49 |
| *** scheuran has quit IRC | 12:49 | |
| *** rfolco has joined #openstack-nova | 12:50 | |
| *** markvoel_ has quit IRC | 12:51 | |
| *** _diana_ has joined #openstack-nova | 12:51 | |
| *** Guest27041 has joined #openstack-nova | 12:51 | |
| *** markvoelker_ has joined #openstack-nova | 12:52 | |
| danpb | sahid: sure | 12:53 |
| sahid | hum will push some codes with the default pre-defined configuration for the scheduler as "rr" and we will see in the review. (will be better than my terrible english) | 12:53 |
| sahid | danpb: ah cool thank you i wanted you to confirm ! | 12:53 |
| *** kylek3h has joined #openstack-nova | 12:54 | |
| ndipanov | johnthetubaguy, (or danpb) - a very easy one - already has +1s from all "steakholders" :) | 12:56 |
| ndipanov | https://review.openstack.org/#/c/193576/ | 12:56 |
| ankit_ag | Hi all, can someone please help reviewing https://review.openstack.org/#/c/194063/ | 12:56 |
| kashyap | sahid: You got a more meaingful response there. :-) | 12:57 |
| johnthetubaguy | ndipanov: yeah, that one is important, taking a look | 12:57 |
| *** irenab has quit IRC | 12:57 | |
| ndipanov | mmm steak holder | 12:58 |
| *** markvoelker_ has quit IRC | 13:02 | |
| *** markvoelker has joined #openstack-nova | 13:02 | |
| *** markvoelker_ has joined #openstack-nova | 13:03 | |
| *** ankit_ag has quit IRC | 13:05 | |
| openstackgerrit | Roman Dobosz proposed openstack/nova: Refactoring of the os-services module https://review.openstack.org/185279 | 13:05 |
| *** markvoelker_ has quit IRC | 13:05 | |
| *** markvoelker_ has joined #openstack-nova | 13:06 | |
| *** zzzeek has joined #openstack-nova | 13:06 | |
| *** changbl has quit IRC | 13:06 | |
| openstackgerrit | Roman Dobosz proposed openstack/nova: Introducing new forced_down field for a Service object https://review.openstack.org/185280 | 13:06 |
| *** markvoelker has quit IRC | 13:07 | |
| *** beagles is now known as beagles_biab | 13:08 | |
| *** piyanai has joined #openstack-nova | 13:08 | |
| *** rlrossit has joined #openstack-nova | 13:09 | |
| bauzas | ndipanov: I'm not vegan, you can call me steak holder | 13:10 |
| *** kylek3h_ has joined #openstack-nova | 13:10 | |
| *** kylek3h has quit IRC | 13:11 | |
| *** kylek3h_ is now known as kylek3h | 13:11 | |
| bauzas | johnthetubaguy: while you're there reviewing some changes, could I hassle you with https://review.openstack.org/#/c/179224/ ? :) | 13:11 |
| *** kylek3h has quit IRC | 13:12 | |
| johnthetubaguy | bauzas: sorry, not going to get to that one today, I really need to start some of my community building work | 13:13 |
| bauzas | jaypipes: (commercial ad voice) you don't know what to do today? you wonder how to have a good day ? you want to see bright days ? come with us and review https://review.openstack.org/#/c/179224/ or call 555-MAKE-BAUZAS-HAPPY (end of commercial) | 13:13 |
| bauzas | johnthetubaguy: np :) | 13:14 |
| nagyz | if I want to work on and see the ceph encryption support for nova in L, do I need a blueprint? if so, what's the deadline for such a blueprint? | 13:14 |
| jaypipes | bauzas: lol :) | 13:15 |
| *** oro has quit IRC | 13:15 | |
| * bauzas wonders if he made a good career choice | 13:15 | |
| * ndipanov wanders what you get if you call 555-BAUZAS-MAKES-HAPPY | 13:16 | |
| openstackgerrit | Roman Dobosz proposed openstack/nova: New nova API call to mark nova-compute down https://review.openstack.org/184086 | 13:16 |
| openstackgerrit | Roman Dobosz proposed openstack/nova: Service group drivers forced_down flag utilization https://review.openstack.org/197063 | 13:16 |
| * ndipanov wonders even | 13:16 | |
| bauzas | ndipanov: I won't trick all the details, you just need to call and see (and pay) | 13:17 |
| bauzas | no credit card asked tho | 13:17 |
| *** ijuwang_away is now known as ijuwang | 13:18 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: configuration for interface driver options https://review.openstack.org/128826 | 13:20 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: enable virtio-net multiqueue https://review.openstack.org/128829 | 13:20 |
| *** nihilifer has quit IRC | 13:21 | |
| *** _gryf is now known as _gryf|afk | 13:21 | |
| *** Guest27041 is now known as agentle | 13:21 | |
| *** ijw has joined #openstack-nova | 13:23 | |
| *** angular_mike_ has joined #openstack-nova | 13:24 | |
| garyk | is the gate still broken? | 13:24 |
| angular_mike_ | how do you delete an instance on Juno if `delete --force` and reset state don't help? | 13:25 |
| *** kyleh_ has joined #openstack-nova | 13:25 | |
| ndipanov | `sudo delete --force` ? | 13:25 |
| * ndipanov jokes | 13:25 | |
| angular_mike_ | ha | 13:26 |
| angular_mike_ | ha | 13:26 |
| johnthetubaguy | ndipanov: quick question on that spec, you don't mention this existing model: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L713 | 13:26 |
| *** nelsnelson has joined #openstack-nova | 13:27 | |
| johnthetubaguy | ndipanov: I figured it was going to expand the existing model that used for migrations, and used that for live-migrate, etc | 13:27 |
| johnthetubaguy | ndipanov: I guess I am missing something somwhere | 13:27 |
| ndipanov | johnthetubaguy, well not expand as much as just use as is | 13:27 |
| ndipanov | actually dansmith is already putting that in | 13:27 |
| ndipanov | I will just move it around a bit | 13:27 |
| johnthetubaguy | ndipanov: cool, thats what I though | 13:27 |
| johnthetubaguy | ndipanov: sweet, all good then | 13:28 |
| *** kylek3h has joined #openstack-nova | 13:28 | |
| ndipanov | johnthetubaguy, https://review.openstack.org/#/c/183331/ | 13:28 |
| *** ijw has quit IRC | 13:29 | |
| dims | bauzas: 0.5.1 of o.vo is out | 13:29 |
| bauzas | dims: okay, now I wonder how to fix properly | 13:30 |
| bauzas | dims: seen my comment on haypo's change ? | 13:30 |
| andreykurilin | alex_xu: thanks! | 13:30 |
| dims | bauzas: haypo: remove the requirements.txt in https://review.openstack.org/#/c/196719/ and recheck please | 13:30 |
| dims | bauzas: haypo: once that's good we can request cores to merge that and unblock | 13:30 |
| *** boris-42 has joined #openstack-nova | 13:31 | |
| *** kylek3h has quit IRC | 13:31 | |
| *** thangp has joined #openstack-nova | 13:31 | |
| dims | haypo: around? | 13:31 |
| haypo | dims: i will update my patch | 13:32 |
| dims | thanks | 13:32 |
| *** lucas-hungry is now known as lucasagomes | 13:32 | |
| dims | johnthetubaguy: ndipanov: we'll need 196719 to unclog the nova gate once haypo updates it please. | 13:33 |
| *** kyleh_ has quit IRC | 13:33 | |
| openstackgerrit | Victor Stinner proposed openstack/nova: Update test_db_api for oslo.db 2.0 https://review.openstack.org/196719 | 13:34 |
| bauzas | dims: cool, so no capping for both oslo.db, neither o.vo | 13:34 |
| *** ajayaa_ has joined #openstack-nova | 13:34 | |
| *** kylek3h has joined #openstack-nova | 13:34 | |
| haypo | dims: by the way, do you know if nova kilo will get oslo.db 2.0 or not? | 13:34 |
| bauzas | haypo: +1'd it | 13:35 |
| haypo | ah! i see "oslo.db>=1.7.0,<1.8.0 # Apache-2.0" in kilo. so no: nova kilo is not impacted by the oslo.db change | 13:35 |
| *** htruta has joined #openstack-nova | 13:35 | |
| bauzas | haypo: https://github.com/openstack/nova/blob/stable/kilo/requirements.txt | 13:35 |
| bauzas | jinxed | 13:35 |
| angular_mike_ | compute log says deletion complete, "Instance disappeared during terminate" | 13:35 |
| haypo | bauzas: caped to < 1.8, it's good ;) | 13:36 |
| *** ctrath has joined #openstack-nova | 13:36 | |
| angular_mike_ | but it is still shown with DELETING state | 13:36 |
| bauzas | so, once the infra statics will be fixed, we should be good to go | 13:36 |
| ndipanov | dims, haypo how come we dropped the requirements change | 13:37 |
| johnthetubaguy | haypo: dims: let me know when we are happy to try out a fix | 13:37 |
| ndipanov | don't we want to keep it foreva? | 13:37 |
| ndipanov | if it was a bad release? | 13:37 |
| garyk | haypo: i see that you droped the requirements :) | 13:37 |
| haypo | garyk: yes: 15:29 < dims> bauzas: 0.5.1 of o.vo is out | 13:37 |
| bauzas | ndipanov: https://github.com/openstack/nova/blob/master/requirements.txt#L49 is safe, but we could modify g-r later to avoid o.vo==0.5.0 | 13:39 |
| *** mriedem has joined #openstack-nova | 13:39 | |
| ndipanov | g-r? | 13:39 |
| bauzas | ndipanov: global-reqs | 13:39 |
| bauzas | ndipanov: and I prefer by far having a single change for a single issue | 13:39 |
| ndipanov | right | 13:39 |
| bauzas | ndipanov: that whole mix of 2 distinct problems made me uncomfortable when I +1'd it | 13:40 |
| *** bkopilov has joined #openstack-nova | 13:40 | |
| ndipanov | yes those are unrelated ok | 13:40 |
| mriedem | so dims released o.vo 0.5.1 | 13:40 |
| ndipanov | actually mriedem can +2 this | 13:41 |
| bauzas | mriedem: yup | 13:41 |
| mriedem | so now we just need this right? https://review.openstack.org/#/c/196719/ | 13:41 |
| bauzas | mriedem: I tested it and it fixes the init() issues | 13:41 |
| bauzas | mriedem: yup | 13:41 |
| bauzas | mriedem: the o.vo issue is fixed by 0.5.1, there is still the oslo.db issue with 0.2 | 13:41 |
| *** ZZelle has quit IRC | 13:41 | |
| bauzas | mriedem: which is fixed by this | 13:41 |
| *** zz_jgrimm is now known as jgrimm | 13:42 | |
| *** ZZelle has joined #openstack-nova | 13:42 | |
| mriedem | right | 13:42 |
| mriedem | per the ML | 13:42 |
| bauzas | mriedem: at least, once the infra disk issue is resolved | 13:42 |
| mriedem | +2 | 13:42 |
| *** agentle has quit IRC | 13:43 | |
| bauzas | mriedem: IIUC, fungi made a fsck on the faulty disk | 13:43 |
| dims | mriedem: crossing my fingers :) | 13:44 |
| mriedem | haypo: so we can break this apart again to it's original change https://review.openstack.org/#/c/195191/ | 13:44 |
| mriedem | haypo: and probably make https://review.openstack.org/#/c/195191/ depend on https://review.openstack.org/#/c/196719/ | 13:44 |
| mriedem | haypo: i could do that quick since i did all the squashing last night | 13:45 |
| kashyap | markus_z: Hmm, I still see the same dreadful error "AssertionError: There is no script for 294 version" with your patch (tested twice w/ F22), not sure what is wrong in my env -- http://paste.openstack.org/show/328435/ | 13:45 |
| *** sudipto has joined #openstack-nova | 13:45 | |
| dansmith | kashyap: you have a .pyc | 13:45 |
| dansmith | kashyap: in the migrations directory, leftover from another change that had a new migration | 13:45 |
| kashyap | dansmith: Shouldn't the darn DevStack clean up everything when I say `make unstack`? :-) | 13:46 |
| bauzas | mriedem: Gerrit is telling me that the change is independent | 13:46 |
| haypo | mriedem: i would prefer to only patch python 3 things in https://review.openstack.org/#/c/195191/ | 13:46 |
| dansmith | kashyap: rm -f $(find . -name '*.ptc') | 13:46 |
| dansmith | kashyap: er, pyc | 13:46 |
| mriedem | haypo: yes i know | 13:46 |
| mriedem | haypo: i'll fix it up | 13:46 |
| kashyap | dansmith: I recall trying that last week. But let me try again. | 13:46 |
| haypo | mriedem: thanks | 13:47 |
| *** artom has joined #openstack-nova | 13:51 | |
| *** ijw has joined #openstack-nova | 13:51 | |
| *** Murali has quit IRC | 13:52 | |
| *** eharney has joined #openstack-nova | 13:55 | |
| *** dave-mccowan has joined #openstack-nova | 13:56 | |
| *** burt has joined #openstack-nova | 13:56 | |
| *** fawadkhaliq has joined #openstack-nova | 13:57 | |
| *** yamahata has joined #openstack-nova | 13:58 | |
| *** baoli has quit IRC | 13:59 | |
| *** jecarey has joined #openstack-nova | 14:00 | |
| *** baoli has joined #openstack-nova | 14:00 | |
| *** wxy has joined #openstack-nova | 14:00 | |
| *** artom has quit IRC | 14:00 | |
| *** dims has quit IRC | 14:01 | |
| *** belmoreira has joined #openstack-nova | 14:01 | |
| *** otter768 has joined #openstack-nova | 14:01 | |
| *** dims has joined #openstack-nova | 14:01 | |
| *** marun has joined #openstack-nova | 14:01 | |
| *** kiran-r has quit IRC | 14:02 | |
| *** dboik has joined #openstack-nova | 14:02 | |
| *** artom has joined #openstack-nova | 14:02 | |
| *** sudipto has quit IRC | 14:03 | |
| *** sudipto has joined #openstack-nova | 14:05 | |
| *** browne has joined #openstack-nova | 14:05 | |
| *** otter768 has quit IRC | 14:06 | |
| kashyap | dansmith: Thanks, that was it (removing the stale .pyc files)! <-- markus_z -- So, please disregard me. | 14:06 |
| markus_z | kashyap: always ;) | 14:06 |
| *** ijuwang has quit IRC | 14:07 | |
| kashyap | :-) Yeah, sorry for the noise. | 14:07 |
| markus_z | jk, thanks for the time you spent on that | 14:07 |
| *** zsais has joined #openstack-nova | 14:07 | |
| *** hshiina has quit IRC | 14:09 | |
| *** scheuran has joined #openstack-nova | 14:09 | |
| andreykurilin | dansmith, mriedem: hi guys! Can I ask you to review a spec related to novaclient's support of microversions? Btw, implementation is ready(first patch-set was published at 3 February:( ) | 14:09 |
| dansmith | andreykurilin: is melwitt +1 on it yet? | 14:09 |
| andreykurilin | dansmith: not yet | 14:10 |
| dansmith | andreykurilin: I would work on that :) | 14:10 |
| andreykurilin | dansmith: but sdague put his +1 for one of the latest patch-sets | 14:11 |
| *** mtanino has joined #openstack-nova | 14:11 | |
| dansmith | okay, that's good | 14:11 |
| dansmith | I'd still like to see melwitt on there | 14:12 |
| dims | johnthetubaguy: dansmith: one of you please bless https://review.openstack.org/#/c/196719/ | 14:12 |
| dansmith | andreykurilin: link? | 14:12 |
| andreykurilin | dansmith: https://review.openstack.org/#/c/188410/ | 14:12 |
| dims | haypo: mriedem: ^^ (196719 made it past check) | 14:12 |
| dansmith | dims: yep | 14:12 |
| dims | dansmith: thanks! | 14:12 |
| *** beagles_biab is now known as beagles | 14:13 | |
| *** annegentle has joined #openstack-nova | 14:14 | |
| *** wxy has left #openstack-nova | 14:16 | |
| *** nihilifer has joined #openstack-nova | 14:17 | |
| nagyz | mriedem, will I need a blueprint for the ceph rbd work, and if so what's the deadline? I'd argue that it's just actually fixing a bug, but not sure what you think. :) | 14:17 |
| mriedem | nagyz: i'd say it's a bug fix | 14:18 |
| nagyz | just don't wanna miss any deadlines as I need to make sure that support ends up in L | 14:18 |
| mriedem | contrary to what ndipanov believes, we don't need blueprints and specs for everything :P | 14:18 |
| mriedem | nagyz: spec proposal freeze was last week anyway | 14:18 |
| nagyz | yeah I was sure I don't need a spec for it :) | 14:18 |
| *** baoli has quit IRC | 14:18 | |
| andreykurilin | dansmith: thanks:) | 14:18 |
| nagyz | just not sure about a blueprint | 14:18 |
| dansmith | andreykurilin: I thought we decided to get rid of X.latest so that we know what version all our clients are | 14:18 |
| haypo | dims: gate-nova-python27 SUCCESS, gate-nova-python34 SUCCESS. cool. i like that :-) dansmith approved 196719 | 14:19 |
| *** dbite has joined #openstack-nova | 14:19 | |
| *** sambol has joined #openstack-nova | 14:20 | |
| *** r-daneel has joined #openstack-nova | 14:20 | |
| nagyz | I've pushed a very simple (2 lines) patch yesterday and I can't get all the CI stuff to agree if it succeeds or not... once jenkins does a +1, xen does a -1, recheck breaks jenkins but xen is +1... madness. :) | 14:20 |
| andreykurilin | dansmith: I missed that. | 14:21 |
| *** unicell has joined #openstack-nova | 14:21 | |
| mriedem | nagyz: the xen stuff has been pretty flaky | 14:21 |
| *** baoli has joined #openstack-nova | 14:22 | |
| mriedem | nagyz: and jenkins is basically fubar since yesterday | 14:22 |
| andreykurilin | dansmith: Imo, X.latest is useful to use latest supported version. | 14:22 |
| dansmith | andreykurilin: I'll comment | 14:22 |
| *** unicell1 has quit IRC | 14:22 | |
| ndipanov | mriedem, I see what you did there... | 14:22 |
| dansmith | andreykurilin: it's not because (a) it means we have no idea based on public cloud logs whether the client supports 2.1 or 2.500 and (b) latest will change and the client will not | 14:22 |
| *** _diana_ has quit IRC | 14:23 | |
| mriedem | ndipanov: heh | 14:23 |
| dansmith | andreykurilin: anyway, I will comment and we'll see what others say | 14:23 |
| andreykurilin | dansmith: but latest is not hardcoded value | 14:23 |
| *** karmatronic has joined #openstack-nova | 14:23 | |
| *** tojuvone has quit IRC | 14:23 | |
| *** tonytan4ever has joined #openstack-nova | 14:23 | |
| dansmith | andreykurilin: Major part can be only numeric and Y can be numeric or "latest" | 14:24 |
| dansmith | andreykurilin: that means the client actually provides the string "2.latest" right? | 14:24 |
| *** karimb has quit IRC | 14:24 | |
| nagyz | mriedem, right. it's a simple 2 line patch as I mentioned so I'm actually pretty sure it doesn't break a thing. it fixes a stacktrace that I've seen in a live system, but I guess I'll ask for a recheck once jenkins is back again | 14:24 |
| andreykurilin | dansmith: client discover what versions are supported by server and decides what is the latest version | 14:24 |
| andreykurilin | dansmith: yes | 14:24 |
| andreykurilin | dansmith: client supports "latest" version, which is equal to some hardcoded variable and strings like "2.latest" | 14:25 |
| dansmith | if it does that, why doesn't it just request 2.7 if 7 is the latest version as reported by the server? | 14:26 |
| mriedem | danpb: fyi, incoming rehash of https://review.openstack.org/#/c/122200/ :) | 14:27 |
| andreykurilin | dansmith: if "2.latest" is specified, client will discover that 2.7 is a latest version, which are supported by both client and server side, and than will use 2.7 | 14:27 |
| andreykurilin | dansmith: so actually "latest" value will be not used in header | 14:27 |
| *** zsais1 has joined #openstack-nova | 14:28 | |
| andreykurilin | dansmith: proposed implementation of discovering latest version - https://review.openstack.org/#/c/184281/ | 14:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Fix Python 3 issues in nova.db.sqlalchemy https://review.openstack.org/195191 | 14:28 |
| mriedem | haypo: ^ back to patch set 3 minus the oslo.db 2.0 fix (which is the dependency) | 14:28 |
| dansmith | andreykurilin: the spec makes it sound like that's what goes in the header | 14:28 |
| dansmith | andreykurilin: if that is in a config file or something, then words need to change to explain that | 14:28 |
| *** karmatronic has quit IRC | 14:29 | |
| *** zsais1 has quit IRC | 14:29 | |
| dansmith | andreykurilin: I think I get it now from reading it again | 14:30 |
| dansmith | andreykurilin: I left a comment about making that more clear, because I read it many times and didn't get that | 14:30 |
| andreykurilin | dansmith: thanks | 14:30 |
| *** baoli has quit IRC | 14:30 | |
| *** baoli has joined #openstack-nova | 14:31 | |
| andreykurilin | dansmith: my english is bad, so I'm really glad to see some comments and advices:) | 14:31 |
| markus_z | This change has 2*+2 and W+1 https://review.openstack.org/#/c/186335/ "recheck" doesn't trigger the gate tests. | 14:31 |
| *** zsais has quit IRC | 14:32 | |
| markus_z | Maybe dependent to the gate issues we have/had. | 14:32 |
| dansmith | andreykurilin: np | 14:32 |
| mriedem | markus_z: see all the UNSTABLE in there? | 14:32 |
| *** baoli has quit IRC | 14:33 | |
| markus_z | mriedem: jepp, the first time I see that. | 14:33 |
| *** baoli has joined #openstack-nova | 14:33 | |
| *** baoli has quit IRC | 14:33 | |
| markus_z | unstable jenkins check blocks jenkins gate? | 14:34 |
| markus_z | When is a job "unstable"? | 14:34 |
| *** baoli has joined #openstack-nova | 14:34 | |
| mriedem | markus_z: did you see the ML threads this morning? | 14:34 |
| kashyap | markus_z: Seems like infra is having issues | 14:34 |
| kashyap | mriedem: C'mon, just answer him already :-) | 14:34 |
| mriedem | http://lists.openstack.org/pipermail/openstack-dev/2015-June/068311.html | 14:35 |
| *** FL1SK has quit IRC | 14:35 | |
| *** sudipto has quit IRC | 14:35 | |
| markus_z | mriedem: Yes, I've read it but the full impact was not clear to me. | 14:36 |
| *** karimb has joined #openstack-nova | 14:36 | |
| kashyap | markus_z: There's also a bot 'openstackstatus' that throws out these notices, but it's very hard to notice unless you're paying attention to IRC all the time. | 14:36 |
| mriedem | markus_z: things are fubar until we get the all clear signal | 14:36 |
| garyk | kashyap: markus_z: it looks like things are back to usual. no sure though | 14:37 |
| mriedem | it looks like they are yes | 14:37 |
| mriedem | 196719 is nearly merged | 14:37 |
| dansmith | kashyap: except that it sets the channel topic | 14:38 |
| dansmith | kashyap: which clearly identifies the problem :) | 14:38 |
| *** irenab has joined #openstack-nova | 14:39 | |
| mriedem | no one reads the channel topic | 14:39 |
| markus_z | garyk: kashyap: Thanks. I didn't understand the full impact. | 14:39 |
| mriedem | 'hi, i'm trying to run a grizzly deployment and having problems booting an instance with a neutron networking setup, can anyone help me?' | 14:39 |
| *** lucas___ has joined #openstack-nova | 14:39 | |
| mriedem | 'my midonet neutron plugin is having some problems in havana, help plz thx!' | 14:39 |
| kashyap | mriedem: Everybody is in a big hurry on the internet. | 14:40 |
| kashyap | :-) | 14:40 |
| markus_z | dansmith: nope, didn't read the channel topic. | 14:41 |
| markus_z | nevermind, didn't want to hurry. | 14:41 |
| *** sudipto has joined #openstack-nova | 14:42 | |
| beagles | danpb, if it is okay with you I'm going to see about adding https://review.openstack.org/#/c/193668/ to the https://etherpad.openstack.org/p/liberty-spec-freeze-exceptions etherpad . Any objections? | 14:42 |
| *** ijuwang has joined #openstack-nova | 14:43 | |
| *** zsais has joined #openstack-nova | 14:43 | |
| beagles | johnthetubaguy, I have a question about a specific spec and the spec freeze exceptions etherpad | 14:43 |
| danpb | beagles: sure | 14:44 |
| beagles | danpb, cool | 14:44 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: configuration for interface driver options https://review.openstack.org/128826 | 14:44 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: enable virtio-net multiqueue https://review.openstack.org/128829 | 14:44 |
| *** rushiagr_away is now known as rushiagr | 14:45 | |
| beagles | johnthetubaguy, basically wondering about the proper placement of https://review.openstack.org/#/c/193668/ | 14:47 |
| mriedem | beagles: throw it under vendor support | 14:48 |
| mriedem | since it enables vendor vif stuff | 14:48 |
| dansmith | +1 | 14:48 |
| beagles | mriedem, sounds good to me... yeah, it was a toss up between that or Cross Project | 14:48 |
| beagles | cool thanks! | 14:48 |
| mriedem | crown me PTL, thanks! | 14:48 |
| beagles | :) | 14:48 |
| johnthetubaguy | beagles: I think that works, I mean to me its more cross project features, but its no big deal | 14:50 |
| beagles | johnthetubaguy, cool | 14:50 |
| johnthetubaguy | beagles: while you are here, are there any bit things in the Neutron world Nova needs to know about, while we go through this release planning stuff? | 14:51 |
| *** subscope has joined #openstack-nova | 14:52 | |
| zzzeek | mriedem: so, it’s time for me to backport my virt index fix :) https://review.openstack.org/#/c/197116/ https://review.openstack.org/#/c/197122/ can you tell me if I’m doing it right for juno/kilo, just plain add a new migration + next consecutive number, right | 14:52 |
| *** doude has quit IRC | 14:52 | |
| mriedem | zzzeek: well, your cherry picked from line is a bit manual huh :) | 14:52 |
| zzzeek | mriedem: Sure, just nit it, so I can get these in | 14:53 |
| mriedem | zzzeek: do we really need this all the way back to juno? | 14:53 |
| zzzeek | mriedem: well, redhat downstream wants it | 14:53 |
| zzzeek | mriedem: so i can patch it locally as an alterantive | 14:53 |
| *** irenab has quit IRC | 14:53 | |
| zzzeek | mriedem: though, that’s tricky, if juno adds a new migration upstream, then RH’s downtstream is borked | 14:54 |
| dansmith | ugh, | 14:54 |
| dansmith | is this really necessary to backport? | 14:54 |
| mriedem | ha | 14:54 |
| dansmith | AFAIK, we'd only consider a backport of a migration if we have to fix something like a CVE | 14:54 |
| *** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. -=- master is open for Lemming development" | 14:54 | |
| neiljerram | johnthetubaguy, beagles: well there is the "get me a network" spec that was just discussed in the Neutron meeting | 14:54 |
| -openstackstatus- NOTICE: The log volume was repaired and brought back online at 14:00 UTC. Log links today from before that time may be missing, and changes should be rechecked if fresh job logs are desired for them. | 14:54 | |
| johnthetubaguy | neiljerram: yeah, I was wondering how thats going, any major news there? | 14:55 |
| neiljerram | johnthetubaguy: Not sure that's relevant to your point about release planning, though. | 14:55 |
| beagles | johnthetubaguy, phew... good question. I'm sure there are a few things. I'll get together with sc68cal and see if we can tidy up the https://etherpad.openstack.org/p/nova-neutron pad | 14:55 |
| beagles | that "get me a network" spec that neiljerram is the first one that comes to mind :) | 14:55 |
| *** piyanai has quit IRC | 14:55 | |
| neiljerram | johnthetubaguy: IIUC, main current question is whether or not network auto-creation is needed, as opposed to use of a pre-created shared network. | 14:55 |
| beagles | but with the same caveats... I guess it depends on what interaction related nova specs might benefit or run awry of it | 14:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Store correct VirtCPUTopology https://review.openstack.org/197125 | 14:56 |
| neiljerram | Review requested from mordred and jaypipes in particular, on https://review.openstack.org/#/c/184857/ and https://review.openstack.org/#/c/196803/ | 14:57 |
| *** piyanai has joined #openstack-nova | 14:57 | |
| jaypipes | neiljerram: yep, will do this afternoon... | 14:57 |
| *** fawadkhaliq has quit IRC | 14:58 | |
| sc68cal | beagles: we probably need to add the os-vif spec too | 14:58 |
| *** jaypipes has quit IRC | 14:58 | |
| ndipanov | mriedem, isthegatefixed.com ? | 14:58 |
| sc68cal | beagles: https://review.openstack.org/#/c/193668/ | 14:58 |
| mriedem | ndipanov: not sure yet, the thing we need in nova has been sitting in the gate queue for awhile, all of the jobs passed | 14:58 |
| beagles | sc68cal, yup that's what brought this up :) | 14:59 |
| *** doude has joined #openstack-nova | 14:59 | |
| ndipanov | ok will wait a bit before hitting rechecks on those patches you were going to review ;) ;) | 14:59 |
| ndipanov | mriedem, ^ | 14:59 |
| mriedem | ndipanov: your bdm thingies that i ask all of my boot_index questions? | 15:00 |
| *** nkrinner has quit IRC | 15:00 | |
| mriedem | ndipanov: btw, boot_index -1 - what does that signify? | 15:00 |
| mriedem | i wish some of that was documented in the code, like in the bdm object fields or something | 15:00 |
| *** exploreshaifali has quit IRC | 15:01 | |
| *** Dev_Jin has quit IRC | 15:01 | |
| ndipanov | mriedem, it means don't boot from it | 15:01 |
| ndipanov | mriedem, I documented it on that documentation patch but yar it could be on the object too | 15:01 |
| dims | 196719 has merged, gate should be good now | 15:01 |
| mriedem | ndipanov: ok i haven't seen that yet | 15:02 |
| *** piyanai has quit IRC | 15:02 | |
| bauzas | nova-scheduler meeting now at #openstack-meeting | 15:02 |
| mriedem | but yeah, i always end up having to dig through a bunch of block device code to figure out what these values mean each time i review something like this | 15:02 |
| *** Guest82972 is now known as PaulMurray | 15:02 | |
| *** irenab has joined #openstack-nova | 15:03 | |
| *** oro has joined #openstack-nova | 15:03 | |
| mriedem | and the fact that the block_device_mapping parameter is sometimes a single object and sometimes a list always confuses the hell out of me | 15:03 |
| ndipanov | mriedem, https://review.openstack.org/#/c/192651/ | 15:03 |
| ndipanov | well usually bdm is a single object but yes... | 15:03 |
| mriedem | yeah sometimes it's a BlockDeviceMappingList | 15:03 |
| mriedem | so i wish we'd call those block_device_mappings to signify plurality | 15:04 |
| mriedem | but that's a personal preference nit | 15:04 |
| mriedem | ndipanov: i'll review https://review.openstack.org/#/c/192651/ for sure | 15:04 |
| mriedem | thanks | 15:04 |
| *** fawadkhaliq has joined #openstack-nova | 15:04 | |
| ndipanov | it's cunningly placed at the end of a series so w merge it quicker :) | 15:05 |
| mriedem | ndipanov: yeah i see that | 15:05 |
| mriedem | sneaky | 15:05 |
| mriedem | i can't have my pudding if i don't eat my meat | 15:05 |
| *** _diana_ has joined #openstack-nova | 15:05 | |
| *** agireud has joined #openstack-nova | 15:07 | |
| *** irenab has quit IRC | 15:08 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Store correct VirtCPUTopology https://review.openstack.org/197129 | 15:08 |
| *** aix has quit IRC | 15:09 | |
| *** scheuran has quit IRC | 15:11 | |
| openstackgerrit | Matthew Gilliard proposed openstack/nova: WIP: Define system_family for libvirt guests https://review.openstack.org/197132 | 15:11 |
| *** xyang1 has joined #openstack-nova | 15:13 | |
| *** apuimedo has joined #openstack-nova | 15:14 | |
| *** kiran-r has joined #openstack-nova | 15:16 | |
| openstackgerrit | Ryan Rossiter proposed openstack/nova: Set vif and allocated when associating fixed ip https://review.openstack.org/197135 | 15:16 |
| rlrossit | mriedem: I don't know if I'm even close to being right on that vif change, but I at least gave it a shot | 15:16 |
| *** belmoreira has quit IRC | 15:17 | |
| mriedem | rlrossit: yeah, added myself | 15:17 |
| ildikov | johnthetubaguy: hi. are you around? | 15:19 |
| johnthetubaguy | ildikov: yes | 15:19 |
| ildikov | johnthetubaguy: I just would like to double check whether I did all the administration I had to, if you have a few seconds or maybe a minute :) | 15:19 |
| openstackgerrit | Andrey Kurilin proposed openstack/nova-specs: Nova API Microversions support in NovaClient https://review.openstack.org/188410 | 15:19 |
| *** tsekiyama has joined #openstack-nova | 15:20 | |
| *** mikeit has joined #openstack-nova | 15:20 | |
| andreykurilin | dansmith: done | 15:21 |
| ildikov | johnthetubaguy: I added the multi-attach spec extension patch to the freeze exception etherpad and I also found the service status notification one on the priority etherpad, so I left it untouched, I assume it's ok now that way | 15:21 |
| mriedem | rlrossit: -1 :) | 15:21 |
| *** belmoreira has joined #openstack-nova | 15:21 | |
| *** lucas___ has quit IRC | 15:21 | |
| ildikov | johnthetubaguy: is there anything regarding to these two specs, I would need to do, but missed it because of any reason? | 15:22 |
| *** _diana_ has quit IRC | 15:22 | |
| dansmith | andreykurilin: that's not exactly what I was going for.. can I update it myself for your review? | 15:23 |
| andreykurilin | dansmith: sure | 15:23 |
| PaulMurray | dansmith, johnthetubaguy, jaypipes thanks for working on https://review.openstack.org/#/c/160942 in my absence | 15:24 |
| andreykurilin | dansmith: thanks | 15:24 |
| dansmith | PaulMurray: aye | 15:24 |
| PaulMurray | dansmith, what is the state of play on that patch? | 15:24 |
| *** aix has joined #openstack-nova | 15:24 | |
| *** haypo has left #openstack-nova | 15:24 | |
| dansmith | PaulMurray: there were a few comments still from melwitt.. not sure if those got resolved | 15:24 |
| PaulMurray | dansmith, last I looked at it (about patch set 14) there was a test that used a dict instead of object as a fixture - when I changed it a bunch of tests broke | 15:25 |
| dansmith | I fixed that I think | 15:25 |
| PaulMurray | dansmith, I don't think that's been touched | 15:25 |
| *** _diana_ has joined #openstack-nova | 15:25 | |
| rlrossit | mriedem: thanks! totally expected that. here's an accurate description of me with this change: https://www.rover.com/blog/wp-content/uploads/2014/10/bailey-computer1.png | 15:26 |
| *** yamahata has quit IRC | 15:26 | |
| *** foexle has quit IRC | 15:26 | |
| dansmith | PaulMurray: yeah, there are some functional failures, but those might be related to the gate troubles yesterday | 15:26 |
| PaulMurray | dansmith, https://review.openstack.org/#/c/160942/19/nova/tests/unit/compute/test_resource_tracker.py#L239 | 15:26 |
| mriedem | rlrossit: ha, nice | 15:26 |
| mriedem | rlrossit: some other comments in there, you have some other object versions to bump | 15:26 |
| dansmith | PaulMurray: but melwitt has unanswered comments, so I'd fix those up and push a new version to let jenkins do a fresh run now that things are fixed | 15:26 |
| PaulMurray | dansmith, ok - I can do that now | 15:27 |
| dansmith | cool | 15:27 |
| *** armax has joined #openstack-nova | 15:27 | |
| ildikov | johnthetubaguy: we also have a chain of patches that implements a blueprint, which was reapproved for Liberty. is there a good way of getting some eyes on it? | 15:28 |
| dansmith | andreykurilin: actually, I see you added more which makes it clearer | 15:28 |
| dansmith | andreykurilin: I'm still going to swizzle a few words around since I already started | 15:28 |
| *** pask81 has quit IRC | 15:28 | |
| johnthetubaguy | ildikov: is your blueprint up to date, marked as needscodereview | 15:28 |
| rlrossit | mriedem: so I noticed that the floating ip versioned object hasn't been bumped since fixed ip version 1.6... will I just jump it's held fixed ip up to 1.11 now? | 15:28 |
| andreykurilin | dansmith: ok :) | 15:29 |
| mriedem | rlrossit: hrm, we'd have to ask dansmith | 15:29 |
| ildikov | johnthetubaguy: yeap, it is | 15:29 |
| openstackgerrit | Dan Smith proposed openstack/nova-specs: Nova API Microversions support in NovaClient https://review.openstack.org/188410 | 15:29 |
| dansmith | andreykurilin: ^ | 15:29 |
| *** bradjones has quit IRC | 15:30 | |
| dansmith | mriedem: rlrossit back in a sec | 15:30 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: rename ResizeClaim to MoveClaim https://review.openstack.org/197137 | 15:30 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: generalize claim code tobe useful for other move actions https://review.openstack.org/197138 | 15:30 |
| *** lucas___ has joined #openstack-nova | 15:31 | |
| andreykurilin | dansmith: thanks | 15:31 |
| *** changbl has joined #openstack-nova | 15:31 | |
| andreykurilin | dansmith: any other comments? | 15:31 |
| *** bradjones has joined #openstack-nova | 15:32 | |
| *** bradjones has quit IRC | 15:32 | |
| *** bradjones has joined #openstack-nova | 15:32 | |
| *** moshele has quit IRC | 15:32 | |
| dansmith | andreykurilin: I need to go through the rest of the doc yet | 15:33 |
| *** marun has quit IRC | 15:34 | |
| *** kiran-r has quit IRC | 15:35 | |
| *** _diana_ has quit IRC | 15:35 | |
| dansmith | rlrossit: gdi | 15:35 |
| ildikov | johnthetubaguy: let me know if I would need to do anything more to avoid missing the deadline again, same for the blueprint freeze procedure. thanks! | 15:35 |
| dansmith | rlrossit: I bet this is because of the circular dependency we added.. I was concerned about something like this | 15:35 |
| *** _diana_ has joined #openstack-nova | 15:35 | |
| * rlrossit points finger at mriedem | 15:35 | |
| rlrossit | he made me do it | 15:36 |
| rlrossit | :) | 15:36 |
| mriedem | i seem to remember this being a known issue | 15:36 |
| dansmith | mriedem: I think it must be because the circular dependency foils the test that validates this | 15:37 |
| mriedem | i'm on a call and missing the circular dep | 15:38 |
| mriedem | fixedip has instance, floatingip has fixedip | 15:38 |
| dansmith | floating -> fixed -> floating | 15:39 |
| dansmith | well, | 15:39 |
| dansmith | floating->fixed->floatinglist->floating | 15:39 |
| mriedem | oh right | 15:39 |
| nagyz | does the CI system work again? | 15:39 |
| mriedem | fck a dck | 15:39 |
| mriedem | nagyz: yeah | 15:39 |
| nagyz | can I submit rechecks? | 15:39 |
| nagyz | ok | 15:39 |
| dansmith | rlrossit: give me a few minutes to try to figure out why the test isn't catching this | 15:40 |
| rlrossit | dansmith: alrighty. thanks | 15:40 |
| dansmith | oh | 15:40 |
| dansmith | I bet it's because lists have their children set differently and this test doesn't follow that link | 15:41 |
| dansmith | which is probably why it works at all | 15:41 |
| dansmith | sonofa | 15:41 |
| bauzas | johnthetubaguy: given http://eavesdrop.openstack.org/meetings/nova_scheduler/2015/nova_scheduler.2015-06-30-14.59.html we agreed on not having https://review.openstack.org/#/c/190322/7 as a priority | 15:43 |
| bauzas | johnthetubaguy: for the scheduler | 15:43 |
| johnthetubaguy | bauzas: cool, did you all vote on that spec to say that? | 15:43 |
| bauzas | johnthetubaguy: that said, I'm huge fan of the spec and I think it deserves a spec freeze exception | 15:43 |
| bauzas | johnthetubaguy: yup, see the minutes | 15:43 |
| bauzas | johnthetubaguy: point 2.c | 15:44 |
| lxsli | bauzas: think he means on the spec itself | 15:44 |
| bauzas | lxsli: oh man, nope | 15:44 |
| bauzas | johnthetubaguy: I can put a comment proxying the vote :) | 15:44 |
| johnthetubaguy | bauzas: just a comment on there will do, just don't want me to forget | 15:45 |
| bauzas | johnthetubaguy: sure, commenting out | 15:45 |
| mriedem | ndipanov: how would you feel about some constants for all of the various bdm enums, like source_type/destination_type? | 15:46 |
| mriedem | global constants like we have for vm_state | 15:47 |
| *** aix has quit IRC | 15:48 | |
| dansmith | we have an enumfield now | 15:49 |
| *** kiran-r has joined #openstack-nova | 15:49 | |
| *** xyhuang has quit IRC | 15:49 | |
| mriedem | in o.vo | 15:49 |
| *** annashen has joined #openstack-nova | 15:49 | |
| mriedem | yeah, that would help | 15:49 |
| dansmith | in nova | 15:49 |
| mriedem | just quickly glancing, we have nova.block_device, nova.virt.block_device, nova.objects.block_device | 15:49 |
| mriedem | it gets confusing | 15:50 |
| *** belmoreira has quit IRC | 15:50 | |
| *** kiran-r has quit IRC | 15:51 | |
| dansmith | aye | 15:51 |
| mriedem | so maybe i'll throw that on my list | 15:51 |
| mriedem | convert bdm.source_type and destination_type fields from string fields to enum fields | 15:52 |
| bauzas | johnthetubaguy: done | 15:52 |
| johnthetubaguy | bauzas: sweet, thank you | 15:52 |
| danpb | mriedem: yeah, we should define an Enum subclass for those valid values and reference it from the object model | 15:52 |
| mriedem | danpb: ack | 15:53 |
| * mriedem writes it on the whiteboard | 15:53 | |
| danpb | see eg SCSIModel in nova/objects/fields.py | 15:53 |
| *** Marga_ has quit IRC | 15:53 | |
| *** xyhuang has joined #openstack-nova | 15:53 | |
| dansmith | rlrossit: so, you're looking for small chunks of work to do to get started...right? :D | 15:53 |
| *** sdake has joined #openstack-nova | 15:54 | |
| rlrossit | dansmith: oh gosh... what am I agreeing to this time? | 15:54 |
| *** sudipto has quit IRC | 15:54 | |
| dansmith | rlrossit: so there is some cleanup needed in the object stuff that would have caught this version mismatch thing | 15:54 |
| dansmith | rlrossit: and I'm just looking at it and thinking it's actually not too complicated | 15:55 |
| mriedem | rlrossit would be happy to work on it | 15:55 |
| dansmith | rlrossit: it's probably two patches, all unit-test-contained | 15:55 |
| dansmith | rlrossit: and it's good stuff to understand | 15:55 |
| dansmith | rlrossit: mostly because mriedem doesn't understand it and you can hold it over his head for some time | 15:55 |
| mriedem | true story | 15:55 |
| rlrossit | dansmith: stop tempting me... | 15:55 |
| dansmith | let me create bugs for them and outline what needs to be done and then we can talk it through | 15:56 |
| rlrossit | alrighty | 15:56 |
| *** achanda has joined #openstack-nova | 15:56 | |
| *** sdake_ has joined #openstack-nova | 15:56 | |
| *** kylek3h has quit IRC | 15:57 | |
| *** unicell has quit IRC | 15:58 | |
| dansmith | rlrossit: first one: https://bugs.launchpad.net/nova/+bug/1470153 | 15:59 |
| openstack | Launchpad bug 1470153 in OpenStack Compute (nova) "Nova object relationships ignore List objects" [Low,Confirmed] - Assigned to Ryan Rossiter (rlrossit) | 15:59 |
| *** markus_z has quit IRC | 15:59 | |
| *** achanda has quit IRC | 16:00 | |
| *** apuimedo is now known as apuimedo|shoppin | 16:00 | |
| ndipanov | mriedem, very good | 16:00 |
| *** sdake has quit IRC | 16:00 | |
| *** aix has joined #openstack-nova | 16:00 | |
| *** jistr has quit IRC | 16:01 | |
| ndipanov | actually I was gonna add them for migration states that I am working on now too | 16:01 |
| *** aix has quit IRC | 16:01 | |
| ndipanov | dansmith, so about this https://review.openstack.org/#/c/183354/ | 16:01 |
| *** _diana_ has quit IRC | 16:01 | |
| ndipanov | can I base my resource tracking stuff on it | 16:02 |
| *** otter768 has joined #openstack-nova | 16:02 | |
| *** zsais1 has joined #openstack-nova | 16:02 | |
| ndipanov | I mean - is it on your priority list to get in asap? | 16:02 |
| *** kiran-r has joined #openstack-nova | 16:02 | |
| dansmith | rlrossit: second one: https://bugs.launchpad.net/nova/+bug/1470154 | 16:02 |
| openstack | Launchpad bug 1470154 in OpenStack Compute (nova) "List objects should use obj_relationships" [Low,Confirmed] - Assigned to Ryan Rossiter (rlrossit) | 16:02 |
| dansmith | ndipanov: yeah, I want it in | 16:03 |
| dansmith | ndipanov: it has gone unreviewed for a bit, I just haven't respun it to address melwitt's thing yet | 16:03 |
| ndipanov | there is a my thing too | 16:04 |
| *** zsais1 has quit IRC | 16:04 | |
| dansmith | yep, just saw | 16:04 |
| ndipanov | plus https://review.openstack.org/#/c/194373/3 is basically what I want toi do but with a claim so I might just take ove that one | 16:04 |
| ndipanov | let me see | 16:04 |
| mriedem | mnestratov: you work on the parallels stuff right? | 16:04 |
| mnestratov | mriedem: yes | 16:05 |
| *** zsais has quit IRC | 16:05 | |
| *** jlanoux has quit IRC | 16:05 | |
| mriedem | mnestratov: i see in this code that for parallels a device_type value for a bdm can be 'fs': http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/blockinfo.py#n264 | 16:06 |
| mriedem | mnestratov: but 'fs' isn't in the list of supported device types here: http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/blockinfo.py#n91 | 16:06 |
| dansmith | ndipanov: that one is complicated enough without RT stuff in it, so I'd rather you append to it | 16:06 |
| mriedem | mnestratov: should it be? | 16:06 |
| *** otter768 has quit IRC | 16:07 | |
| lxsli | bauzas: are you happy for xyhuang's patch to go in despite it adding a field to request_spec? | 16:07 |
| dansmith | rlrossit: if these tests were correct, the unit tests would have warned you about the thing that mriedem pointed out on the review | 16:07 |
| lxsli | bauzas: it seems good but you'll need to rebase | 16:07 |
| dansmith | rlrossit: they're designed to make sure that we don't just have to rely on crackerjack reviewers like mriedem to catch issues like this | 16:07 |
| bauzas | lxsli: I first wanted to think about how to provide a way to the scheduler about networks | 16:08 |
| mnestratov | mriedem: let me see | 16:08 |
| bauzas | lxsli: not sure that a request field is the best one or not - yet | 16:08 |
| * bauzas is leaving | 16:08 | |
| lxsli | o/ | 16:08 |
| *** arnaud____ has joined #openstack-nova | 16:10 | |
| rlrossit | dansmith: which one of these should be done first? or are they independent? | 16:10 |
| *** karimb has quit IRC | 16:10 | |
| *** mpaolino_ has quit IRC | 16:11 | |
| dansmith | rlrossit: I think the first one I linked would best be done first | 16:11 |
| dansmith | rlrossit: with the second stacked on top | 16:11 |
| rlrossit | man that sounded like the harder one... :/ | 16:11 |
| *** annashen has quit IRC | 16:11 | |
| dansmith | rlrossit: which the first? I don't think so.. I put more words in there to get you up to speed, but I think it's actually just commenting out one line and then updating a dict :) | 16:12 |
| dansmith | rlrossit: go have a look at that test and see what you think | 16:12 |
| *** lucas___ has quit IRC | 16:13 | |
| *** piyanai has joined #openstack-nova | 16:14 | |
| *** kiran-r has quit IRC | 16:15 | |
| rlrossit | dansmith: ....huh... http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/objects/test_objects.py#n1308 | 16:15 |
| PaulMurray | dansmith, I don't think there is a simple equivalent of self.compute_node.get('pci_device_pools') in object notation - right? | 16:16 |
| dansmith | rlrossit: that's not related to the test I mentioned in the bug, right? | 16:16 |
| *** xyhuang has left #openstack-nova | 16:17 | |
| dansmith | PaulMurray: not sure what you mean | 16:17 |
| dansmith | PaulMurray: you can .get() on an object | 16:17 |
| dansmith | PaulMurray: her point was that it's never not set anymore, so you might as well just do self.compute_node.pci_device_pools | 16:17 |
| mriedem | crackerjack huh | 16:18 |
| PaulMurray | dansmith, I was going to stick with .get() - just checking that's ok | 16:18 |
| PaulMurray | dansmith, melwitt's comment was: Do we still need to do a dict-get on compute_node here now that it's an object? | 16:18 |
| dansmith | PaulMurray: right, so why do you need to do a .get()? | 16:19 |
| rlrossit | dansmith: I thought it was using that to get the objects it needed when testing relationships, but nevermind, it looks like it isn't | 16:19 |
| PaulMurray | dansmith, I'm not sure it is always there | 16:19 |
| *** beekneemech is now known as bnemec | 16:19 | |
| dansmith | rlrossit: yeah, that's a different test | 16:19 |
| dansmith | PaulMurray: okay, well, that's a reasonable response. However, .get() behaves a teensy bit differently on objects: | 16:19 |
| dansmith | PaulMurray: if you do obj.get('foo'), it will trigger a lazy-load if it's not set. If you don't want that, you need to provide a default like: obj.get('foo', None) | 16:20 |
| *** _diana_ has joined #openstack-nova | 16:21 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick https://review.openstack.org/175569 | 16:23 |
| *** piyanai_ has joined #openstack-nova | 16:24 | |
| mnestratov | mriedem: looks like we don't need 'fs' to be in the SUPPORTED_DEVICE_TYPES, because it's ok if it is treated as 'disk' | 16:25 |
| mriedem | mnestratov: ok, i was looking to make bdm.device_type an enum | 16:26 |
| *** jaypipes has joined #openstack-nova | 16:26 | |
| *** Mike_D_laptop has joined #openstack-nova | 16:27 | |
| *** garyk1 has joined #openstack-nova | 16:28 | |
| *** piyanai has quit IRC | 16:28 | |
| *** piyanai_ is now known as piyanai | 16:28 | |
| *** unicell has joined #openstack-nova | 16:28 | |
| *** andreykurilin__ has joined #openstack-nova | 16:28 | |
| *** garyk has quit IRC | 16:28 | |
| *** _diana_ has quit IRC | 16:28 | |
| *** dontalton has joined #openstack-nova | 16:29 | |
| *** baoli has quit IRC | 16:29 | |
| *** doude has quit IRC | 16:30 | |
| *** baoli_ has joined #openstack-nova | 16:31 | |
| *** piyanai has quit IRC | 16:31 | |
| rlrossit | dansmith: uff da... there are a lot of list objects... | 16:32 |
| dansmith | rlrossit: yep | 16:32 |
| dansmith | rlrossit: did you just find the thing I wanted you to find such that you're being told about all the objects? :) | 16:33 |
| mnestratov | mriedem: by the way, your comments seem to be addressed | 16:33 |
| mnestratov | https://review.openstack.org/#/c/182390/ | 16:33 |
| mnestratov | https://review.openstack.org/#/c/182257 | 16:33 |
| rlrossit | dansmith: should I just jump them all to current? or increment all one by one? | 16:33 |
| rlrossit | yep I found it: http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/objects/test_objects.py#n1253 | 16:33 |
| dansmith | rlrossit: yep, cool.. you're not bumping anything, you're just filling in the gaps in the record, so to speak | 16:34 |
| *** piyanai has joined #openstack-nova | 16:34 | |
| dansmith | rlrossit: so just add the stuff into the relationship map so that the test is happy. you're not changing history, you're just recording it | 16:34 |
| *** kiran-r has joined #openstack-nova | 16:34 | |
| *** achanda has joined #openstack-nova | 16:35 | |
| *** piyanai has quit IRC | 16:36 | |
| mriedem | this is timely since i'm going to be bumping some bdm object versions and i remember that's in some fun relationships | 16:36 |
| *** FL1SK has joined #openstack-nova | 16:36 | |
| dansmith | yeah | 16:36 |
| dansmith | mriedem: rlrossit can explain all this to you when you're ready for that | 16:37 |
| mriedem | this must be shit on mriedem day | 16:37 |
| dansmith | hehe | 16:37 |
| dansmith | I kid, I kid | 16:37 |
| rlrossit | that isn't every day? | 16:37 |
| rlrossit | dansmith: just to make sure I'm on the right track... I need to update this guy with all of the lists now right? http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/objects/test_objects.py#n1137 | 16:39 |
| dansmith | rlrossit: yep | 16:39 |
| rlrossit | thank goodness for diffs | 16:40 |
| *** rotbeard has quit IRC | 16:43 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 16:45 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Add os-brick based LibvirtVolumeDriver for ScaleIO https://review.openstack.org/194454 | 16:45 |
| *** yassine_ has quit IRC | 16:47 | |
| *** piyanai has joined #openstack-nova | 16:48 | |
| *** veena has joined #openstack-nova | 16:50 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Make evacuate update the migration object along the way https://review.openstack.org/194373 | 16:50 |
| openstackgerrit | Dan Smith proposed openstack/nova: Add some notifications to the evacuate path https://review.openstack.org/194372 | 16:50 |
| openstackgerrit | Dan Smith proposed openstack/nova: Make evacuate leave a record for the source compute host to process https://review.openstack.org/183354 | 16:50 |
| *** openstackgerrit has quit IRC | 16:50 | |
| *** openstackgerrit has joined #openstack-nova | 16:51 | |
| openstackgerrit | Ryan Rossiter proposed openstack/nova: Test relationships of List objects https://review.openstack.org/197176 | 16:52 |
| *** ildikov has quit IRC | 16:53 | |
| *** piyanai has quit IRC | 16:54 | |
| *** gszasz has quit IRC | 16:54 | |
| openstackgerrit | Jesse J. Cook proposed openstack/nova: Cells: distribute build requests across cells https://review.openstack.org/195757 | 16:54 |
| dansmith | rlrossit: almost perfect | 16:55 |
| mriedem | dansmith: i have a thing in there also | 16:55 |
| dansmith | rlrossit: mriedem's point is good too | 16:55 |
| rlrossit | sonofagun... that's what I get for not looking.... | 16:55 |
| dansmith | rlrossit: the reason is that there were two tests, one for lists, one for non-lists, so we never got Obj->List->Obj relationship tracking | 16:56 |
| rlrossit | dansmith: oh so the child_version thing was testing what I am supposed to be not using anymore after I do the second bug? | 16:57 |
| *** fawadkhaliq has quit IRC | 16:57 | |
| dansmith | rlrossit: yep | 16:57 |
| *** marun has joined #openstack-nova | 16:57 | |
| dansmith | rlrossit: make them all use obj_relationships(), which will work after this first patch, and then remove the child_versions and relates test(s) | 16:57 |
| *** kylek3h has joined #openstack-nova | 16:58 | |
| *** derekh has quit IRC | 16:59 | |
| *** matrohon has quit IRC | 16:59 | |
| *** ociuhandu has quit IRC | 17:00 | |
| *** nic has joined #openstack-nova | 17:01 | |
| *** novauser has joined #openstack-nova | 17:01 | |
| *** lucasagomes is now known as lucas-dinner | 17:02 | |
| *** kiran-r has quit IRC | 17:02 | |
| *** thangp has quit IRC | 17:02 | |
| *** kiran-r has joined #openstack-nova | 17:03 | |
| *** fawadkhaliq has joined #openstack-nova | 17:04 | |
| *** piyanai has joined #openstack-nova | 17:04 | |
| *** _gryf has joined #openstack-nova | 17:06 | |
| *** samueldmq has quit IRC | 17:08 | |
| dansmith | alaski: so are you cool with this now? https://review.openstack.org/#/c/195156/ | 17:08 |
| dansmith | alaski: thinking more about your rpc version idea, | 17:08 |
| *** tonytan4ever has quit IRC | 17:08 | |
| *** samueldmq has joined #openstack-nova | 17:08 | |
| dansmith | alaski: I think we should aim for making M auto-adjust its rpc versions based on the minimum service version of the computes | 17:08 |
| *** lucas___ has joined #openstack-nova | 17:08 | |
| dansmith | alaski: not having to do manual pins in Mita would be fairly awesome | 17:08 |
| *** danpb has quit IRC | 17:09 | |
| *** baoli_ has quit IRC | 17:10 | |
| *** novauser has quit IRC | 17:11 | |
| openstackgerrit | Andrew Bogott proposed openstack/nova: Include project_id in instance metadata. https://review.openstack.org/197185 | 17:12 |
| *** annashen has joined #openstack-nova | 17:12 | |
| *** thangp has joined #openstack-nova | 17:14 | |
| *** _diana_ has joined #openstack-nova | 17:14 | |
| *** garyk1 has quit IRC | 17:15 | |
| openstackgerrit | Paul Murray proposed openstack/nova: Convert RT compute_node to be a ComputeNode object https://review.openstack.org/160942 | 17:15 |
| *** mpaolino has quit IRC | 17:15 | |
| melwitt | alaski, bauzas: cells job is finally voting! | 17:17 |
| *** piyanai has quit IRC | 17:17 | |
| *** annashen has quit IRC | 17:17 | |
| *** sdake has joined #openstack-nova | 17:18 | |
| dansmith | woot | 17:18 |
| mriedem | now to whittle down that regex list of excluded tests | 17:19 |
| *** apuimedo|shoppin is now known as apuimedo | 17:21 | |
| *** mikeit has quit IRC | 17:21 | |
| PaulMurray | dansmith, jaypipes I put up a new version of the compute_node patch ^^^^ | 17:21 |
| *** sdake_ has quit IRC | 17:21 | |
| dansmith | PaulMurray: yeah, was just reviewing your comments | 17:21 |
| dansmith | melwitt: you want to run through that again first? | 17:21 |
| melwitt | mriedem: right, switching to the config options | 17:22 |
| *** kiran-r has quit IRC | 17:22 | |
| melwitt | dansmith: yeah, currently looking at it | 17:22 |
| dansmith | sweet | 17:22 |
| PaulMurray | dansmith, jaypipes I undid the change to _create_compute_node_object() so it reads from db format again - you'll see why in the comments | 17:22 |
| melwitt | dansmith: it looks good to me | 17:25 |
| dansmith | melwitt: cool, I'll pull it up | 17:25 |
| *** Piet has quit IRC | 17:26 | |
| *** PaulMurray is now known as ptm_away | 17:26 | |
| *** Mike_D_laptop has quit IRC | 17:27 | |
| jaypipes | ptm_away: k, thanks. that test code in test_resource_tracker.py has to go away eevntually... | 17:27 |
| *** annegentle has quit IRC | 17:28 | |
| dansmith | jaypipes: ptm_away: melwitt: looks good to me too, I just +2d | 17:29 |
| dansmith | someone should +W it to put it out of its misery | 17:29 |
| dansmith | or put us out of its misery | 17:29 |
| melwitt | will do | 17:29 |
| melwitt | haha | 17:29 |
| *** fawadkhaliq has quit IRC | 17:33 | |
| *** _diana_ has quit IRC | 17:35 | |
| *** lucas___ has quit IRC | 17:36 | |
| *** kiran-r has joined #openstack-nova | 17:37 | |
| *** baoli has joined #openstack-nova | 17:37 | |
| *** baoli has quit IRC | 17:38 | |
| openstackgerrit | Chinmaya Bharadwaj proposed openstack/nova: VMware: Fix for instance creation fails using block device mapping https://review.openstack.org/197192 | 17:38 |
| *** achanda_ has joined #openstack-nova | 17:38 | |
| ptm_away | jaypipes, melwitt cool thanks, now lets see if it passes the checks :) | 17:38 |
| *** dboik has quit IRC | 17:39 | |
| *** baoli has joined #openstack-nova | 17:39 | |
| *** dboik has joined #openstack-nova | 17:39 | |
| *** patrickeast has joined #openstack-nova | 17:39 | |
| *** achanda has quit IRC | 17:40 | |
| *** annashen has joined #openstack-nova | 17:41 | |
| *** veena has quit IRC | 17:41 | |
| openstackgerrit | Ryan Rossiter proposed openstack/nova: Test relationships of List objects https://review.openstack.org/197176 | 17:41 |
| *** annegentle has joined #openstack-nova | 17:41 | |
| *** achanda has joined #openstack-nova | 17:42 | |
| *** neiljerram_bb has joined #openstack-nova | 17:43 | |
| *** irenab has joined #openstack-nova | 17:43 | |
| *** jecarey has quit IRC | 17:43 | |
| *** lyarwood has quit IRC | 17:43 | |
| *** lyarwood has joined #openstack-nova | 17:43 | |
| mriedem | why are these temorary imports? http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/fields.py#n22 | 17:44 |
| dansmith | mriedem: because he's going to move all that stuff out of hardware and into fields because it only needs to be there | 17:44 |
| *** kylek3h has quit IRC | 17:44 | |
| *** achanda_ has quit IRC | 17:44 | |
| dansmith | but there is a transition of converting to enums and then dropping those checks in the hardware code | 17:44 |
| mriedem | dansmith: ok, so when i make bdm.source_type an enum field, i should just have the constants defined in that enum class | 17:45 |
| dansmith | mriedem: yeah | 17:45 |
| mriedem | ok | 17:45 |
| dansmith | mriedem: jaypipes has an example up | 17:45 |
| mriedem | gets a bit long to ref the constant in code, e.g. return self.source_type == fields.BlockDeviceSourceTypeField.IMAGE | 17:45 |
| *** kiran-r has quit IRC | 17:45 | |
| *** mgarza_ has joined #openstack-nova | 17:46 | |
| dansmith | mriedem: https://review.openstack.org/#/c/196179/1/nova/objects/fields.py,cm | 17:46 |
| dansmith | mriedem: why do you need to do that? | 17:46 |
| mriedem | yeah ok, i have the exact same thing | 17:46 |
| mriedem | well i want to use the constants in code rather than hardcoding 'image' and 'volume' and 'blank' everywhere, but i guess we don't have to | 17:46 |
| jaypipes | mriedem: https://review.openstack.org/#/c/196179/ | 17:46 |
| jaypipes | doh, dansmith beat me. | 17:47 |
| mriedem | yeah my change is basically the same | 17:47 |
| dansmith | mriedem: well, you don't have to for protection, but if you want to do a thing if image == blank, then yeah | 17:47 |
| *** sdake_ has joined #openstack-nova | 17:47 | |
| dansmith | mriedem: fwiw, what jaypipes has is exactly the pattern danpb set up, so you should try to follow that if possible | 17:47 |
| mriedem | dansmith: it actually coerces it ok so i don't really need to change any of the hard-coded string usage | 17:47 |
| jaypipes | mriedem: you can always do something like this at the top of the module: IMAGE = fields.BlockDeviceMappingSourceField.IMAGE | 17:47 |
| dansmith | not sure how similar "basically the same" is | 17:48 |
| jaypipes | mriedem: just to shorten it with an alias. | 17:48 |
| mriedem | dansmith: yeah, i'm already following danpb's pattern | 17:48 |
| dansmith | jaypipes: yep | 17:48 |
| dansmith | mriedem: okay sweet | 17:48 |
| *** lyarwood has quit IRC | 17:48 | |
| mriedem | basically the same: http://paste.openstack.org/show/329182/ | 17:49 |
| *** lyarwood has joined #openstack-nova | 17:49 | |
| dansmith | yeah cool | 17:49 |
| mriedem | but i wasn't just converting to enums for protention | 17:49 |
| dansmith | look at us being all organized | 17:49 |
| *** moshele has joined #openstack-nova | 17:49 | |
| *** lsmola has quit IRC | 17:49 | |
| mriedem | i wanted to have something in the code that people can refer to see what all of the valid types are when they are seeing bdm.source_type used in nova.compute.api, for example | 17:50 |
| mriedem | rather than just seeing 'image' hard-coded and wondering what the others were | 17:50 |
| dansmith | yeah, certainly helps | 17:50 |
| *** fawadkhaliq has joined #openstack-nova | 17:50 | |
| *** sdake has quit IRC | 17:50 | |
| *** sdake_ is now known as sdake | 17:50 | |
| mriedem | that could/should be a separate change since it's just going to be a bunch of find/replace | 17:50 |
| dansmith | sure | 17:51 |
| dansmith | as long as rlrossit is okay with that... | 17:51 |
| mriedem | but hey, high fives for consistency | 17:51 |
| rlrossit | I'm not okay with anything mriedem does | 17:51 |
| rlrossit | but what are we talking about? | 17:51 |
| dansmith | agreeing with mriedem is generally a pretty safe bet on most things | 17:52 |
| dansmith | just a protip | 17:52 |
| mriedem | shiiit | 17:52 |
| mriedem | tell my wife that | 17:52 |
| dansmith | heh | 17:52 |
| jaypipes | dansmith, mriedem: does recheck no longer work to put a patch back into the verify queue? do I need to use reverify? | 17:52 |
| dansmith | no | 17:52 |
| dansmith | recheck should workl | 17:52 |
| dansmith | but it has to go through check again | 17:53 |
| mriedem | jaypipes: there is no difference anymore | 17:53 |
| dansmith | and it is | 17:53 |
| dansmith | I see it in check | 17:53 |
| jaypipes | kk | 17:53 |
| *** lucas___ has joined #openstack-nova | 17:53 | |
| *** neelashah has quit IRC | 17:53 | |
| openstackgerrit | Roman Dobosz proposed openstack/nova: Introducing new forced_down field for a Service object https://review.openstack.org/185280 | 17:55 |
| openstackgerrit | Roman Dobosz proposed openstack/nova: New nova API call to mark nova-compute down https://review.openstack.org/184086 | 17:55 |
| openstackgerrit | Roman Dobosz proposed openstack/nova: Service group drivers forced_down flag utilization https://review.openstack.org/197063 | 17:55 |
| openstackgerrit | Roman Dobosz proposed openstack/nova: Refactoring of the os-services module https://review.openstack.org/185279 | 17:55 |
| dansmith | melwitt: eff eff ess | 17:55 |
| openstackgerrit | Amador Pahim proposed openstack/nova: Detach volumes from soft-deleted instance https://review.openstack.org/197201 | 17:55 |
| *** jecarey has joined #openstack-nova | 17:56 | |
| alaski | dansmith: will look once I escape blocks of meetings | 17:56 |
| dansmith | alaski: thanks | 17:56 |
| alaski | melwitt: \o/ | 17:56 |
| melwitt | dansmith: :( | 17:56 |
| dansmith | melwitt: I should have made it evac.* | 17:56 |
| melwitt | lol | 17:56 |
| dansmith | melwitt: evacu-knowwhatImean | 17:56 |
| *** angdraug has joined #openstack-nova | 17:57 | |
| *** ijw has quit IRC | 17:57 | |
| *** lucas___ has quit IRC | 17:57 | |
| melwitt | 'evacuate' action naming strikes again! | 17:58 |
| dansmith | yeah | 17:58 |
| *** baoli has quit IRC | 17:58 | |
| *** yamahata has joined #openstack-nova | 17:58 | |
| *** baoli has joined #openstack-nova | 17:59 | |
| *** tonytan4ever has joined #openstack-nova | 18:01 | |
| *** otter768 has joined #openstack-nova | 18:03 | |
| dansmith | rlrossit: first commit? | 18:03 |
| mriedem | this might be his first that actually lands | 18:03 |
| rlrossit | yep! | 18:04 |
| mriedem | https://review.openstack.org/#/q/owner:rlrossit%2540us.ibm.com,n,z | 18:04 |
| *** chinmay_ has joined #openstack-nova | 18:04 | |
| mriedem | rlrossit's previous adventures in horizon didn't work out so well | 18:04 |
| rlrossit | don't remind me mriedem | 18:04 |
| mriedem | rlrossit: nice commit message btw | 18:05 |
| *** jlanoux has joined #openstack-nova | 18:05 | |
| rlrossit | mriedem: thanks! I always feel like I never say enough | 18:06 |
| mriedem | orly | 18:06 |
| *** agireud has quit IRC | 18:06 | |
| mriedem | chew on this https://review.openstack.org/#/c/193673/ | 18:06 |
| mriedem | https://review.openstack.org/#/c/193830/ | 18:06 |
| *** otter768 has quit IRC | 18:07 | |
| rlrossit | yeah that's exactly why I don't think I say enough. I'm not a professional wordsmith like you mriedem | 18:08 |
| *** lucas__ has joined #openstack-nova | 18:08 | |
| *** ajayaa_ has quit IRC | 18:08 | |
| dansmith | rlrossit: so after you do the second bug, rebase your original patch on this and see if it points to what mriedem said | 18:08 |
| rlrossit | dansmith: okie dokie | 18:09 |
| rlrossit | dansmith: that other change isn't merged yet so I'll still have to branch off that one for the second bug right? | 18:10 |
| *** moshele_ has joined #openstack-nova | 18:10 | |
| mriedem | rlrossit: git review -d | 18:10 |
| *** moshele_ has quit IRC | 18:10 | |
| *** moshele has quit IRC | 18:10 | |
| dansmith | rlrossit: stack 'em up | 18:10 |
| mriedem | rlrossit: http://docs.openstack.org/infra/manual/developers.html#adding-a-dependency | 18:10 |
| dansmith | mriedem: he doesn't need -d because he already has the other one in his tree, I assume | 18:10 |
| mriedem | yeah | 18:11 |
| mriedem | rlrossit: so just new commit in the same topic branch i guess | 18:11 |
| mriedem | even though it's a separate bug | 18:11 |
| rlrossit | don't worry mriedem I know really well how dependencies work... | 18:11 |
| mriedem | you know about git review -R? | 18:11 |
| rlrossit | that involves rebase in some way right? | 18:12 |
| mriedem | yeah | 18:12 |
| rlrossit | *checks help docs* | 18:12 |
| mriedem | yeah, it's in that doc | 18:12 |
| mriedem | same section | 18:12 |
| mriedem | basically, don't rebase the dependent changes in my topic branch | 18:12 |
| mriedem | helpful when you already have those approved | 18:12 |
| *** lucas__ has quit IRC | 18:13 | |
| rlrossit | I didn't think about that... that could mess up your tree pretty bad | 18:13 |
| *** lucas__ has joined #openstack-nova | 18:13 | |
| mriedem | well, not really | 18:13 |
| mriedem | if you hvae merge conflicts you're goign to have to rebase sooner or later | 18:13 |
| mriedem | the point is to not lose your +W | 18:13 |
| *** annegentle has quit IRC | 18:13 | |
| mriedem | and then have to harass someone to re-approve | 18:13 |
| *** ericksonsantos has joined #openstack-nova | 18:14 | |
| *** tellesnobrega_ has joined #openstack-nova | 18:15 | |
| *** annegentle has joined #openstack-nova | 18:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add BlockDeviceSourceType enum field https://review.openstack.org/197208 | 18:16 |
| *** Sukhdev_ has joined #openstack-nova | 18:16 | |
| *** ildikov has joined #openstack-nova | 18:18 | |
| *** rushiagr is now known as rushiagr_away | 18:18 | |
| *** tellesnobrega_ has quit IRC | 18:20 | |
| *** achanda has quit IRC | 18:21 | |
| openstackgerrit | Chinmaya Bharadwaj proposed openstack/nova: VMware: Fix for instance creation fails using block device mapping https://review.openstack.org/197192 | 18:23 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/197213 | 18:24 |
| *** gyee has joined #openstack-nova | 18:24 | |
| *** chinmay_ has quit IRC | 18:25 | |
| openstackgerrit | Chinmaya Bharadwaj proposed openstack/nova: VMware: Fix for instance creation fails using block device mapping https://review.openstack.org/197214 | 18:26 |
| *** tsekiyama has quit IRC | 18:27 | |
| *** lpetrut has quit IRC | 18:28 | |
| openstackgerrit | Chinmaya Bharadwaj proposed openstack/nova: VMware: Fix for instance creation fails using block device mapping https://review.openstack.org/197192 | 18:28 |
| *** jlanoux has quit IRC | 18:29 | |
| *** tjones1 has joined #openstack-nova | 18:32 | |
| *** ZZelle_ has joined #openstack-nova | 18:33 | |
| *** tsekiyama has joined #openstack-nova | 18:38 | |
| *** davideagnello has quit IRC | 18:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add BlockDeviceDestinationType enum field https://review.openstack.org/197223 | 18:40 |
| *** arnaud____ has quit IRC | 18:41 | |
| *** annegentle has quit IRC | 18:43 | |
| *** davideagnello has joined #openstack-nova | 18:44 | |
| *** chuckcarmack has joined #openstack-nova | 18:46 | |
| *** sdake has quit IRC | 18:46 | |
| *** sdake has joined #openstack-nova | 18:47 | |
| *** irenab has quit IRC | 18:50 | |
| *** irenab has joined #openstack-nova | 18:50 | |
| *** jwcroppe has quit IRC | 18:53 | |
| *** busterswt has joined #openstack-nova | 18:54 | |
| *** jwcroppe has joined #openstack-nova | 18:54 | |
| *** mutoulbj has quit IRC | 18:56 | |
| mriedem | dansmith: this is a hypothetical right now, but if someone added a new value to an enum type field, would that require a version bump on any objects with fields using that type? | 18:57 |
| *** Longgeek has quit IRC | 18:57 | |
| dansmith | yep | 18:57 |
| mriedem | ok, that's what i thought | 18:57 |
| dansmith | and the tests will catch it | 18:57 |
| beagles | edleafe: I was reading https://review.openstack.org/#/c/188410/13/specs/liberty/approved/novaclient-api-microversions.rst and noticed your comment about the "X-" prefix. Is there a discussion on this somewhere or something that I could peruse for background? | 18:57 |
| dansmith | uh, yeah, because that would be a breaking API change | 18:58 |
| *** Longgeek has joined #openstack-nova | 18:58 | |
| *** tnorth_ has joined #openstack-nova | 18:58 | |
| *** jwcroppe has quit IRC | 18:59 | |
| mriedem | dansmith: talking to me or beagles? | 18:59 |
| dansmith | mriedem: edleafe through beagles | 18:59 |
| beagles | meaning it is going to be X- lest it be a a breaking API change? | 19:00 |
| tnorth_ | hello! I was wondering if anyones had the following problem: I have an instance that was booted from volume (/dev/vda is a cinder volume) and when I booted I set the "delete_on_termination" field. Is there a way to query the "delete_on_termination" field from the Nova API? | 19:00 |
| beagles | dansmith, ^^ | 19:00 |
| tnorth_ | i found where it is in the nova db, just not where its exposed in the API | 19:00 |
| *** browne has quit IRC | 19:00 | |
| dansmith | beagles: yeah | 19:00 |
| beagles | dansmith, right on.. makes sense | 19:00 |
| *** agireud has joined #openstack-nova | 19:01 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: Refactor unit test for InstanceGroup objects https://review.openstack.org/197228 | 19:02 |
| mriedem | tnorth_: i'm not seeing anything exposing that in the nova api | 19:04 |
| *** dboik has quit IRC | 19:04 | |
| mriedem | server get doesn't appear to list the bdm deatils | 19:04 |
| mriedem | *details | 19:04 |
| *** dboik has joined #openstack-nova | 19:04 | |
| tnorth_ | do you know what part in the nova code I should be looking mriedem ? | 19:05 |
| tnorth_ | i was gonna write up a bug for launchpad this afternoon | 19:05 |
| mriedem | tnorth_: it wouldn't be a bug | 19:05 |
| mriedem | tnorth_: i was looking here http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/views | 19:05 |
| tnorth_ | feature | 19:05 |
| mriedem | specifically servers.py | 19:05 |
| mriedem | tnorth_: yeah this would be a microversion which would require a blueprint and a spec | 19:05 |
| mriedem | for the v2.1 api | 19:05 |
| *** busterswt has quit IRC | 19:05 | |
| *** irenab has quit IRC | 19:06 | |
| *** Guest80179 has joined #openstack-nova | 19:06 | |
| jaypipes | dansmith: k, so regarding your question about the MonitorMetric.source field... here is all the "documentation" available about what the source field should contain :( https://github.com/openstack/nova/blob/master/nova/compute/monitors/__init__.py#L120 | 19:07 |
| tnorth_ | mriedem: cool, thanks much! | 19:07 |
| dansmith | jaypipes: lol | 19:08 |
| mriedem | tnorth_: np | 19:08 |
| dansmith | jaypipes: I did some reading and grepping after reviewing | 19:08 |
| jaypipes | dansmith: and the only implemented plugin has this: | 19:08 |
| jaypipes | https://github.com/openstack/nova/blob/master/nova/compute/monitors/virt/cpu_monitor.py#L48 | 19:08 |
| dansmith | jaypipes: and I'm definitely glad to be constraining the values with the enum | 19:08 |
| mriedem | dansmith: but then you remove pluggability?! | 19:09 |
| dansmith | jaypipes: what complaint of mine specifically? | 19:09 |
| mriedem | for my vendor monitor plugin thingy | 19:09 |
| jaypipes | dansmith: I actually think the source should be the plugin's full class name... | 19:09 |
| jaypipes | dansmith: you wrote in the review about the source field: "We *could* do some more validation on this particular bit if we wanted to make sure it's always a class path..." | 19:09 |
| *** achanda has joined #openstack-nova | 19:10 | |
| dansmith | jaypipes: oh, right, I'm saying it'd be nice to validate/enforce that it is actually the path, or even not let them pass it in and us get it from stevedore | 19:10 |
| jaypipes | dansmith: yeah, I was thinking about the latter option there. | 19:11 |
| dansmith | mriedem: I'm not just going to remove it, I'm going to take it out in a field and kick it to death to the tune of mild gangsta rap | 19:11 |
| mriedem | back up your ass with the resurrection | 19:11 |
| jaypipes | holla. | 19:11 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Adds MonitorMetric object https://review.openstack.org/196180 | 19:13 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Rework monitor plugin interface and API https://review.openstack.org/196181 | 19:13 |
| dansmith | LOL | 19:13 |
| *** Mike_D_laptop has joined #openstack-nova | 19:13 | |
| *** Guest80179 has quit IRC | 19:14 | |
| *** busterswt has joined #openstack-nova | 19:15 | |
| openstackgerrit | Chinmaya Bharadwaj proposed openstack/nova: VMware: Fixes instance creation failure using block device mapping https://review.openstack.org/197192 | 19:16 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Use stevedore for loading monitor extensions https://review.openstack.org/196182 | 19:16 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Enable python34 tests for nova/tests/unit/objects/test*.py https://review.openstack.org/187785 | 19:16 |
| *** tonytan4ever has quit IRC | 19:16 | |
| edleafe | beagles: that was in the same ML thread: http://lists.openstack.org/pipermail/openstack-dev/2015-June/067009.html | 19:16 |
| edleafe | beagles: it refers to https://tools.ietf.org/html/rfc6648 | 19:17 |
| *** mgarza_ has quit IRC | 19:18 | |
| dansmith | edleafe: but really, that ship has sailed, right? | 19:19 |
| *** chuckcarmack has left #openstack-nova | 19:19 | |
| *** piyanai has joined #openstack-nova | 19:20 | |
| edleafe | dansmith: sure, but I just noted that 'this might change' | 19:20 |
| dansmith | I don't think it will change, but if it does, the impact to the client will be the least of our problems | 19:21 |
| dansmith | but... okay :) | 19:21 |
| edleafe | dansmith: just wearing my api-wg advisory hat :) | 19:22 |
| * dansmith steals edleafe's hat and tosses it to beagles for fun | 19:22 | |
| * edleafe starts crying | 19:23 | |
| dansmith | hah | 19:23 |
| openstackgerrit | Kevin Fox proposed openstack/nova-specs: Instance Users for Cloud Interaction https://review.openstack.org/186617 | 19:24 |
| *** annashen has quit IRC | 19:24 | |
| *** piyanai has quit IRC | 19:25 | |
| *** igordcard has joined #openstack-nova | 19:25 | |
| *** tnorth_ has quit IRC | 19:25 | |
| *** Marga_ has joined #openstack-nova | 19:26 | |
| openstackgerrit | Kevin Fox proposed openstack/nova-specs: Instance Users for Cloud Interaction https://review.openstack.org/186617 | 19:26 |
| *** busterswt has quit IRC | 19:28 | |
| *** igordcard_ has joined #openstack-nova | 19:30 | |
| mriedem | tnorth is gone, but he probably wanted http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/plugins/v3/volumes.py#n235 | 19:30 |
| *** tonytan4ever has joined #openstack-nova | 19:30 | |
| *** busterswt has joined #openstack-nova | 19:30 | |
| melwitt | dansmith: what does the statement on L68 do? https://review.openstack.org/#/c/192708/10/nova/scheduler/utils.py,cm I don't understand why it's needed, what "detach" means | 19:31 |
| dansmith | melwitt: it's obscure | 19:31 |
| dansmith | melwitt: it makes a copy of system_metadata | 19:31 |
| dansmith | melwitt: obj_to_primitive() doesn't do a deep enough copy, | 19:32 |
| *** Marga_ has quit IRC | 19:32 | |
| dansmith | melwitt: so when we convert that from an object to a dict-ish instance, the result shares system_metadata with the original object | 19:32 |
| dansmith | melwitt: so if we then go modify it with save_flavor_info(), we're modifying the dict and the object's system_metadata | 19:32 |
| *** Marga_ has joined #openstack-nova | 19:32 | |
| dansmith | melwitt: "doesn't copy this enough" was me trying to say the above | 19:33 |
| *** armax has quit IRC | 19:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add BlockDeviceType enum field https://review.openstack.org/197237 | 19:34 |
| *** aysyd has quit IRC | 19:34 | |
| *** Marga_ has quit IRC | 19:36 | |
| *** Marga__ has joined #openstack-nova | 19:36 | |
| melwitt | dansmith: I understood the "didn't copy it" but I thought the save_flavor_info wanted to save the object's system_metadata | 19:37 |
| *** READ10 has joined #openstack-nova | 19:37 | |
| dansmith | melwitt: it modifies in-place | 19:38 |
| *** xyang1 has quit IRC | 19:38 | |
| melwitt | dansmith: I think maybe I get it now, the primitive should be a totally separate copy from the object | 19:38 |
| dansmith | right | 19:38 |
| *** xyang1 has joined #openstack-nova | 19:38 | |
| dansmith | this is also really dumb because we're just trying to be nice about not sending a different thing over rpc to a thing we own | 19:39 |
| dansmith | but because filters might have been written that care | 19:39 |
| melwitt | dansmith: I think I was getting confused about the "instance" variable changing from one to the other, in the save_flavor_info(instance.get) it made me think "save this to the instance" and I wasn't thinking "the primitive instance" | 19:40 |
| melwitt | dansmith: makes sense now, thanks | 19:41 |
| dansmith | it's really silly | 19:41 |
| dansmith | if you think more words in a comment would be good, that's totally legit of course | 19:42 |
| *** nihilifer has quit IRC | 19:44 | |
| melwitt | I think it's okay, just my lack of experience with modifying a field after primitivizing | 19:47 |
| *** penick has joined #openstack-nova | 19:47 | |
| *** lpetrut has joined #openstack-nova | 19:48 | |
| *** baoli has quit IRC | 19:48 | |
| *** aysyd has joined #openstack-nova | 19:50 | |
| *** dboik has quit IRC | 19:50 | |
| *** dboik has joined #openstack-nova | 19:51 | |
| *** Marga__ has quit IRC | 19:53 | |
| *** yamahata has quit IRC | 19:54 | |
| *** yamahata has joined #openstack-nova | 19:54 | |
| *** achanda has quit IRC | 19:54 | |
| *** lpetrut has quit IRC | 19:54 | |
| *** aysyd has quit IRC | 19:55 | |
| *** achanda has joined #openstack-nova | 19:55 | |
| *** mutoulbj has joined #openstack-nova | 19:56 | |
| *** mutoulbj has quit IRC | 19:56 | |
| *** browne has joined #openstack-nova | 19:58 | |
| *** fawadkhaliq has quit IRC | 19:59 | |
| *** achanda has quit IRC | 19:59 | |
| openstackgerrit | Thomas Maddox proposed openstack/nova: Adding IPv6 static routes and static routes template https://review.openstack.org/187012 | 20:00 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/194325 | 20:01 |
| *** patrickeast_ has joined #openstack-nova | 20:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/197281 | 20:03 |
| *** otter768 has joined #openstack-nova | 20:03 | |
| *** patrickeast has quit IRC | 20:04 | |
| *** patrickeast_ is now known as patrickeast | 20:04 | |
| *** rook has joined #openstack-nova | 20:05 | |
| *** _gryf has quit IRC | 20:05 | |
| *** armax has joined #openstack-nova | 20:07 | |
| *** otter768 has quit IRC | 20:08 | |
| *** aysyd has joined #openstack-nova | 20:08 | |
| *** gokrokve has joined #openstack-nova | 20:10 | |
| alaski | dansmith: finally read https://review.openstack.org/#/c/195156 again | 20:11 |
| dansmith | cool | 20:11 |
| alaski | dansmith: looks good to me, though I wonder if the version should be a string vs an int | 20:11 |
| dansmith | why? | 20:11 |
| alaski | only because that allows for some semantic versioning, if we want that | 20:11 |
| dansmith | hmm | 20:11 |
| alaski | would it be useful to indicate a backwards compatible version bump? | 20:12 |
| dansmith | alaski: I guess I had envisioned this as purely a monotonic integer and we apply the semantics we want each time | 20:12 |
| dansmith | meaning, each thing we're doing, we'll interpret the version however we need | 20:12 |
| dansmith | so, we may say that if (max(version) - my_version) > 5, then we exit | 20:12 |
| dansmith | but we may say if (max(version) - min(version) > 1) then don't do any migrations yet | 20:13 |
| alaski | okay, I like that after thinking on it for a sec. it provides more flexibility | 20:13 |
| dansmith | I think it's just going to be a tool for us to do (or not do) things | 20:13 |
| dansmith | but what we use it for in each case will differ | 20:13 |
| dansmith | if we use it for rpc pinning, | 20:14 |
| *** nihilifer has joined #openstack-nova | 20:14 | |
| dansmith | we'll just find the minimum compute service version, look up what rpc version that matches in a table and use that | 20:14 |
| dansmith | if we use it for failing to join the cluster, it may be some interval that is allowed | 20:14 |
| alaski | yeah, I was wondering if having the option of more complex versions would be nice. but that gets overly complex if the version is shared for multiple things, like rpc pinning and db upgrades | 20:15 |
| dansmith | in fact, if we do this, we might even be able to drop the major.minor stuff in the rpc layer | 20:15 |
| *** changbl has quit IRC | 20:15 | |
| dansmith | alaski: yeah, I was just thinking of this as a vector for positioning yourself at some point in time | 20:15 |
| alaski | cool, works for me. just needed to walk through it | 20:16 |
| *** annashen has joined #openstack-nova | 20:16 | |
| dansmith | trying to think if there is any reason to have a minor version for backports | 20:16 |
| *** Sukhdev_ has quit IRC | 20:16 | |
| dansmith | if we did, though, I think I'd want it to be an integer, | 20:16 |
| dansmith | because I think that if we're going to potentially look at this at startup and refresh it, it'd be nice to be able to have the db server do the math for us | 20:17 |
| dansmith | SELECT MIN(service.version) WHERE binary='compute' | 20:17 |
| dansmith | is real nice | 20:17 |
| lifeless | yeah | 20:17 |
| lifeless | teaching db's about semver | 20:17 |
| lifeless | not trivial | 20:17 |
| dansmith | heh | 20:17 |
| *** claudiub has quit IRC | 20:18 | |
| lifeless | you could do a tuple of ints - three columns major minor patch | 20:18 |
| lifeless | that lets you query the same way | 20:18 |
| lifeless | without getting into the full custom datatype madness | 20:18 |
| dansmith | yes, I was going to say we could always add a ver_minor column later if we need it | 20:18 |
| dansmith | but I don't want to do it unless we have a use for it | 20:18 |
| lifeless | [I've been down that route and done it successfully, but I think you need a really strong justification] | 20:18 |
| mriedem | so while i was commenting in the spec we should use semver, it seems you're already talking about it | 20:18 |
| mriedem | 012000000 = liberty | 20:19 |
| mriedem | 013000000 = M | 20:19 |
| dansmith | I really don't want to use anything release-related to this | 20:19 |
| mriedem | it doesn't have to be release related | 20:19 |
| dansmith | because this will change multiple times per release | 20:19 |
| mriedem | it's package released | 20:19 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Rework monitor plugin interface and API https://review.openstack.org/196181 | 20:19 |
| mriedem | well, i guess that would be release related | 20:20 |
| mriedem | but yeah | 20:20 |
| dansmith | I really just want a vector | 20:20 |
| dansmith | the version doesn't have semantics, | 20:20 |
| mriedem | given i have no idea how we're going to be doing like a 13.0.1 | 20:20 |
| mriedem | 13.1.0 | 20:20 |
| dansmith | the things we're driving based on it do have semantics | 20:20 |
| *** jwcroppe has joined #openstack-nova | 20:21 | |
| *** neiljerram_bb has quit IRC | 20:22 | |
| *** piyanai has joined #openstack-nova | 20:24 | |
| *** Mike_D_laptop has quit IRC | 20:25 | |
| mriedem | it appears we've f'ed up the gate again | 20:25 |
| mriedem | oh nvm | 20:26 |
| openstackgerrit | Dan Smith proposed openstack/nova-specs: Add service-version-number spec https://review.openstack.org/195156 | 20:27 |
| dansmith | mriedem: see if that extra paragraph is illuminative | 20:27 |
| dansmith | mriedem: alaski: do you think I need a section of "why this isn't semver-able" ? | 20:28 |
| mriedem | is that a word? | 20:28 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: hypervisor support matrix: fix snapshot for libvirt Xen https://review.openstack.org/197301 | 20:28 |
| dansmith | which, illuminative or semver-able? | 20:28 |
| mriedem | former, but it is | 20:28 |
| mriedem | i'll be damned | 20:28 |
| dansmith | oh, mriedem just said yes to my question | 20:28 |
| *** nihilifer has quit IRC | 20:28 | |
| alaski | dansmith: it wouldn't hurt | 20:28 |
| dansmith | yep, okay | 20:28 |
| dims | mriedem: you scare me :) | 20:31 |
| mriedem | ? | 20:31 |
| *** mgarza has joined #openstack-nova | 20:31 | |
| dims | mriedem: " f'ed up the gate again" | 20:31 |
| mriedem | oh | 20:31 |
| mriedem | yeah | 20:31 |
| *** dprince has quit IRC | 20:31 | |
| *** vladikr has quit IRC | 20:33 | |
| dansmith | mriedem: did you read that new paragraph? | 20:33 |
| mriedem | not yet | 20:33 |
| dansmith | ready to resubmit, but can hold on if you want to check that first | 20:33 |
| dansmith | I didn't use any big words | 20:33 |
| mriedem | thanks! | 20:33 |
| dansmith | heh | 20:34 |
| mriedem | commented | 20:35 |
| dansmith | cool | 20:35 |
| * mriedem goes back to staring at flashy keys | 20:35 | |
| dansmith | mriedem: I'm going to add another sentence instead of just a parenthetical to highlight the restriction | 20:36 |
| dansmith | but I think you'll be okay with it | 20:36 |
| mriedem | well we'll see | 20:36 |
| openstackgerrit | Dan Smith proposed openstack/nova-specs: Add service-version-number spec https://review.openstack.org/195156 | 20:37 |
| *** READ10 has quit IRC | 20:37 | |
| *** piyanai has quit IRC | 20:38 | |
| *** lucas__ has quit IRC | 20:38 | |
| dansmith | I should really ask wo@mpstor.com to review this | 20:38 |
| *** lucas__ has joined #openstack-nova | 20:38 | |
| mriedem | he's on vacation | 20:39 |
| alaski | have to wait until Thursday the 9th | 20:39 |
| dansmith | oh, really? how do you know? | 20:39 |
| mriedem | "I am currently travelling and am out of the office until Thursday the 9th July, I will be picking up emails periodically." | 20:39 |
| dansmith | he should really send that to the dev list once an hour so we know... | 20:39 |
| mriedem | isn't there a list admin or something that can kick them out? | 20:40 |
| dansmith | sure | 20:40 |
| *** lucas__ has quit IRC | 20:40 | |
| dansmith | ten more days of that could get annoying | 20:40 |
| *** lucas__ has joined #openstack-nova | 20:40 | |
| mriedem | ooo i have a real name | 20:40 |
| mriedem | http://marc.info/?l=u-boot&m=127792717940898&w=2 | 20:40 |
| mriedem | william oppermann | 20:41 |
| mriedem | https://www.linkedin.com/in/mpstor | 20:41 |
| mriedem | ooo | 20:41 |
| mriedem | i can send him a message via linkedin to stop spamming the openstack-dev mailing list | 20:41 |
| dansmith | lol | 20:41 |
| *** ijw has joined #openstack-nova | 20:42 | |
| mriedem | co-founder and ceo | 20:43 |
| mriedem | nice | 20:43 |
| openstackgerrit | Jesse J. Cook proposed openstack/nova: Cells: limit slots by io_ops https://review.openstack.org/195756 | 20:43 |
| dansmith | co-founder and Chief Spam Officer | 20:43 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Rework monitor plugin interface and API https://review.openstack.org/196181 | 20:44 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Use stevedore for loading monitor extensions https://review.openstack.org/196182 | 20:44 |
| *** ivasev has quit IRC | 20:45 | |
| edleafe | "I know technology, except how email works" | 20:46 |
| dansmith | hehe | 20:46 |
| mriedem | dansmith: well, i'm +1 on your spec | 20:47 |
| mriedem | i know that means a lot | 20:47 |
| dansmith | \o/ | 20:47 |
| dansmith | a blessing from mriedem is as good as from the pope | 20:47 |
| *** andreykurilin__ has quit IRC | 20:47 | |
| *** matrohon has joined #openstack-nova | 20:47 | |
| mriedem | hey, don't group me in with that guy, he's in all sorts of trouble | 20:47 |
| dansmith | heh | 20:47 |
| *** claudiub has joined #openstack-nova | 20:47 | |
| *** ociuhandu_ has joined #openstack-nova | 20:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtQuobyteVolumeDriver into the quobyte module https://review.openstack.org/193236 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move volume/remotefs/quobyte modules under volume subdir https://review.openstack.org/193223 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtNFSVolumeDriver into it's own module https://review.openstack.org/196859 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtScalityVolumeDriver into it's own module https://review.openstack.org/193249 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtGlusterfsVolumeDriver into it's own module https://review.openstack.org/193380 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtFibreChannelVolumeDriver into it's own module https://review.openstack.org/193278 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move lvm/dmcrypt/rbd_utils modules under storage subdir https://review.openstack.org/193195 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move fibre channel specific utilities into fc module https://review.openstack.org/193317 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtGPFSVolumeDriver into it's own module https://review.openstack.org/193240 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtSMBFSVolumeDriver into it's own module https://review.openstack.org/196380 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtAOEVolumeDriver into it's own module https://review.openstack.org/196276 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtISERVolumeDriver into it's own module https://review.openstack.org/197311 | 20:50 |
| *** karimb has joined #openstack-nova | 20:50 | |
| *** ZZelle_ has quit IRC | 20:51 | |
| *** lucas__ has quit IRC | 20:51 | |
| *** lucas__ has joined #openstack-nova | 20:55 | |
| *** ociuhandu_ has quit IRC | 20:55 | |
| *** dboik has quit IRC | 20:55 | |
| dansmith | rlrossit: you're dangerously close to being a nova ATC | 20:55 |
| *** lucas___ has joined #openstack-nova | 20:56 | |
| *** Aless has joined #openstack-nova | 20:56 | |
| *** lucas___ has quit IRC | 20:57 | |
| Aless | Hey there, is Spice currently a working and supported channel for accessing a servers terminal? | 20:57 |
| Aless | i have it all configured but it doesnt take keyboard inputs at all, and shuts down randomly | 20:58 |
| Aless | this is with kilo | 20:58 |
| Aless | and the latest html5-spice code | 20:58 |
| *** lucas__ has quit IRC | 20:59 | |
| *** thangp has quit IRC | 20:59 | |
| mriedem | Aless: no idea, directxman12 is who i'd ask but he's not here right now | 21:00 |
| *** andreykurilin__ has joined #openstack-nova | 21:00 | |
| mriedem | else report a bug and tag it with 'console' | 21:00 |
| Aless | mriedem: i was just wondering in general whether its supported and if to what extend | 21:00 |
| melwitt | Aless, mriedem: according to the docs it's a thing that's supposed to work http://docs.openstack.org/admin-guide-cloud/content/spice-console.html | 21:01 |
| mriedem | Aless: as far as i know it's supposed to work | 21:01 |
| mriedem | but we don't do integration testing on it as far as i know | 21:01 |
| Aless | ok weird. :-) | 21:01 |
| mriedem | Aless: i would not be surprised if it doesn't work | 21:01 |
| mriedem | due to lack of QA | 21:01 |
| *** matrohon has quit IRC | 21:02 | |
| rlrossit | dansmith: it almost sounds like you're watching this closer than I am | 21:02 |
| mriedem | rlrossit: he's probably watching it in zuul | 21:02 |
| Aless | I see, I wouldnt even know what to report because it doesnt really works but doesnt throw errors either | 21:02 |
| mriedem | http://zuul.openstack.org/ | 21:02 |
| Aless | s/works/work/ | 21:03 |
| mriedem | Aless: i guess you'd report which version you're on, whether or not it's from upstream or a vendor, what your config is, and what issues you're seeing | 21:03 |
| mriedem | typical bug reporting stuff | 21:03 |
| *** armax has quit IRC | 21:03 | |
| mriedem | if you're using rdo or something, i'd ask about it in the rdo channel | 21:03 |
| Aless | Will do thanks, it just would have been more helpful with an actual clue :-) | 21:04 |
| *** dave-mccowan has quit IRC | 21:04 | |
| mriedem | directxman12 holds the clues | 21:04 |
| *** lucas__ has joined #openstack-nova | 21:04 | |
| Aless | I'm not its actually directly built from git | 21:04 |
| Aless | will attack him at some point, thanks. :-) | 21:04 |
| mriedem | np | 21:04 |
| dansmith | rlrossit: I have the gate on permanent display on the screen above my head | 21:04 |
| *** piyanai has joined #openstack-nova | 21:04 | |
| *** aysyd has quit IRC | 21:06 | |
| *** casusbelli has quit IRC | 21:07 | |
| *** angdraug has quit IRC | 21:07 | |
| *** lucas__ has quit IRC | 21:08 | |
| *** armax has joined #openstack-nova | 21:11 | |
| *** lucas-dinner has quit IRC | 21:14 | |
| *** piyanai has quit IRC | 21:15 | |
| *** lucas__ has joined #openstack-nova | 21:16 | |
| *** claudiub has quit IRC | 21:17 | |
| mriedem | oh ELO, take me away... | 21:20 |
| *** lucas__ has quit IRC | 21:20 | |
| melwitt | are our db schemas always backward-compatible between versions? I looked for docs about it but found only https://wiki.openstack.org/wiki/Upgrade-with-minimal-downtime#Backwards_Compatible_Schemas | 21:22 |
| *** tonytan4ever has quit IRC | 21:22 | |
| mriedem | i don't think so....? | 21:23 |
| mriedem | melwitt: have an example? | 21:24 |
| *** sahid has quit IRC | 21:25 | |
| mriedem | if we add/drop columns during a migration, for example, i'd expect things to be a bit wonky | 21:25 |
| mriedem | and the code would have to handle it | 21:25 |
| rlrossit | dansmith: mriedem: yay I did it! | 21:25 |
| melwitt | mriedem: I shared dansmith's blog post about minimal downtime upgrades and someone asked me how can we upgrade the db schema first, it means the previous version must be able to work with the new version. and I was thinking hm, must have to be backward compatible but I didn't know we had that as a rule | 21:26 |
| mriedem | rlrossit: way2go | 21:26 |
| mriedem | the top secret upgrades blog post? :) | 21:27 |
| *** dave-mccowan has joined #openstack-nova | 21:28 | |
| *** rfolco has quit IRC | 21:28 | |
| mriedem | melwitt: yeah i wouldn't think that would work if we drop a column for example and then some code is trying to access that | 21:28 |
| mriedem | i guess that's just why we never delete anything ever | 21:28 |
| melwitt | mriedem: yeah, that's what I was thinking. I think sometimes we would drop something | 21:30 |
| *** otter768 has joined #openstack-nova | 21:32 | |
| dansmith | melwitt: the rule is no subtractive changes right now | 21:33 |
| melwitt | dansmith: okay, thanks | 21:34 |
| dansmith | melwitt: we decided that end of juno and at the kilo summit, which worked well | 21:34 |
| dansmith | melwitt: the online schema changes stuff is what we're mostly counting on for removing things I think | 21:34 |
| dansmith | melwitt: if we need to remove something before then, we have a little monkeywork to do, but it's certainly possible | 21:35 |
| *** ijw has quit IRC | 21:35 | |
| *** kylek3h has joined #openstack-nova | 21:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtNETVolumeDriver into it's own module https://review.openstack.org/197341 | 21:35 |
| melwitt | dansmith: I see | 21:35 |
| *** ijw has joined #openstack-nova | 21:36 | |
| *** thorst has quit IRC | 21:38 | |
| *** annashen has quit IRC | 21:38 | |
| *** fifieldt has quit IRC | 21:39 | |
| *** busterswt has quit IRC | 21:41 | |
| *** mriedem has quit IRC | 21:41 | |
| *** angdraug has joined #openstack-nova | 21:41 | |
| *** Aless has quit IRC | 21:42 | |
| *** kylek3h has quit IRC | 21:42 | |
| *** annashen has joined #openstack-nova | 21:42 | |
| *** kylek3h has joined #openstack-nova | 21:43 | |
| *** ijw_ has joined #openstack-nova | 21:46 | |
| *** ZZelle_ has joined #openstack-nova | 21:46 | |
| *** edmondsw has quit IRC | 21:46 | |
| *** ociuhandu has joined #openstack-nova | 21:46 | |
| *** kylek3h has quit IRC | 21:47 | |
| *** pkholkin has quit IRC | 21:49 | |
| *** Nikolay_St has quit IRC | 21:49 | |
| *** tdurakov has quit IRC | 21:49 | |
| *** obondarev has quit IRC | 21:49 | |
| *** snikitin_ has quit IRC | 21:49 | |
| *** ijw has quit IRC | 21:50 | |
| edleafe | rlrossit: congrats! Start packing for Tokyo! :) | 21:51 |
| *** fifieldt has joined #openstack-nova | 21:52 | |
| rlrossit | thanks edleafe! | 21:52 |
| dansmith | ugh | 21:54 |
| dansmith | we dropped a thing in 292 | 21:54 |
| dansmith | it's dims' fault | 21:55 |
| dansmith | but it looks like all is not lost | 21:55 |
| *** jecarey has quit IRC | 21:57 | |
| melwitt | gasp! | 21:58 |
| dansmith | it would suck to be super awesome for juno->kilo and regress | 21:59 |
| dansmith | melwitt: I will have a patch for you to review in mere moments | 21:59 |
| melwitt | dansmith: oh good, there's a solution :) | 22:00 |
| *** otter768 has quit IRC | 22:00 | |
| *** agireud has quit IRC | 22:00 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Block subtractive operations in migrations for Kilo and beyond https://review.openstack.org/197349 | 22:03 |
| dansmith | melwitt: see what you think of that | 22:03 |
| dansmith | we really should have had that in place long ago | 22:03 |
| *** burt has quit IRC | 22:03 | |
| * melwitt looks | 22:04 | |
| *** yamahata has quit IRC | 22:04 | |
| *** ijw_ has quit IRC | 22:06 | |
| *** ijw has joined #openstack-nova | 22:07 | |
| *** gokrokve has quit IRC | 22:07 | |
| dansmith | I think I'm supposed to have unit tests for a fixture | 22:08 |
| *** davideag_ has joined #openstack-nova | 22:09 | |
| melwitt | dansmith: I thought the online schema changes allow us to have subtractive things now, but not prior to when that merged? I must not have understood that | 22:11 |
| dansmith | melwitt: it won't fix it for static migrations like this | 22:12 |
| *** claudiub has joined #openstack-nova | 22:12 | |
| dansmith | melwitt: it will make it possible far in the future, but right now the drop part of the online stuff isn't even complete because it will destroy data if you don't handle that case yourself | 22:12 |
| *** davideagnello has quit IRC | 22:13 | |
| melwitt | dansmith: ah, right. the spec said with online changes there will be no migrations, so these are different | 22:13 |
| dansmith | right | 22:13 |
| *** ctrath has quit IRC | 22:15 | |
| *** dims_ has joined #openstack-nova | 22:19 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Block subtractive operations in migrations for Kilo and beyond https://review.openstack.org/197349 | 22:19 |
| dansmith | += unit tests | 22:19 |
| *** dims has quit IRC | 22:22 | |
| *** gokrokve has joined #openstack-nova | 22:22 | |
| melwitt | dansmith: cool. is there a reason not to use "self.useFixture" in the test_migrations.py instead of the separate setUp and cleanUp? | 22:23 |
| *** rlrossit has left #openstack-nova | 22:24 | |
| *** pedroalvarez_ has joined #openstack-nova | 22:26 | |
| dansmith | melwitt: yeah, if we do do self.useFixture(), then we add it to our own list of cleanups | 22:29 |
| dansmith | melwitt: since I need to only do it for non-excepted migrations, | 22:29 |
| dansmith | I need to use and un-use it around each | 22:29 |
| dansmith | I could do a context-manager and have it look cleaner, but I think we're supposed to be using fixtures | 22:30 |
| dansmith | (unless fixtures are automatically context managers) | 22:30 |
| dansmith | actually, maybe they are | 22:31 |
| *** jgrimm is now known as zz_jgrimm | 22:31 | |
| *** pedroalvarez has quit IRC | 22:32 | |
| *** mriedem has joined #openstack-nova | 22:32 | |
| *** pedroalvarez_ is now known as pedroalvarez | 22:34 | |
| *** ijuwang has quit IRC | 22:36 | |
| *** dontalton has quit IRC | 22:37 | |
| melwitt | dansmith: okay, I was thinking the self.useFixture inside the if statement would use and un-use it but was based on assuming it's like a context manager. let me double check | 22:37 |
| dansmith | melwitt: it will attempt to re-cleanup when our class exits | 22:37 |
| dansmith | since this does multiple migrations in a single test run, we don't want that | 22:38 |
| dansmith | melwitt: I have it changed to be much nicer, just a sec | 22:38 |
| melwitt | dansmith: oh, okay, that's what I was missing | 22:38 |
| openstackgerrit | Dan Smith proposed openstack/nova: Block subtractive operations in migrations for Kilo and beyond https://review.openstack.org/197349 | 22:38 |
| dansmith | melwitt: see if you fancy that ^ | 22:38 |
| *** zz_jgrimm is now known as jgrimm | 22:40 | |
| dansmith | melwitt: don't feel pressured to +2 this if you want others to weigh in on the policy aspect | 22:40 |
| dansmith | (this or anything ever, of course) | 22:41 |
| mriedem | how did belliott get in there? | 22:42 |
| dansmith | hey, he's still allowd | 22:43 |
| dansmith | er, allowed | 22:43 |
| *** kylek3h has joined #openstack-nova | 22:43 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/194325 | 22:44 |
| *** gokrokve has quit IRC | 22:44 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/197281 | 22:45 |
| *** nelsnels_ has joined #openstack-nova | 22:50 | |
| *** eharney has quit IRC | 22:53 | |
| *** nelsnelson has quit IRC | 22:53 | |
| openstackgerrit | Jesse J. Cook proposed openstack/nova: Cells: Add cells filter RamByInstanceTypeFilter https://review.openstack.org/195755 | 22:55 |
| *** otter768 has joined #openstack-nova | 22:56 | |
| melwitt | dansmith: looks cool to me but I do want to let the db experts comment on it first | 22:57 |
| dansmith | melwitt: sure, thanks for looking | 22:57 |
| *** karimb has quit IRC | 22:59 | |
| *** dims_ has quit IRC | 23:01 | |
| *** annashen has quit IRC | 23:02 | |
| *** rlrossit has joined #openstack-nova | 23:03 | |
| *** annashen has joined #openstack-nova | 23:03 | |
| *** markvoelker_ has quit IRC | 23:06 | |
| edleafe | Heading out for the week. See you all on Monday! | 23:07 |
| *** annashen has quit IRC | 23:07 | |
| *** annashen has joined #openstack-nova | 23:07 | |
| *** tsbot_ has quit IRC | 23:07 | |
| *** kylek3h_ has joined #openstack-nova | 23:09 | |
| *** kylek3h has quit IRC | 23:10 | |
| *** pedroalvarez has quit IRC | 23:10 | |
| *** ZZelle_ has quit IRC | 23:10 | |
| *** pedroalvarez has joined #openstack-nova | 23:11 | |
| *** mgarza has quit IRC | 23:15 | |
| *** mgarza_ has joined #openstack-nova | 23:15 | |
| melwitt | dansmith: what do you think of the latest comment on https://bugs.launchpad.net/nova/+bug/1404795 ? I'm guessing we won't want to try to recover host/node info (we're erroring out the instance) but I think he has a point about the migration record | 23:15 |
| openstack | Launchpad bug 1404795 in OpenStack Compute (nova) "instance's host and node are target host's while evacuate failed" [Critical,In progress] - Assigned to ChangBo Guo(gcb) (glongwave) | 23:15 |
| *** mwagner_lap has quit IRC | 23:15 | |
| *** mgarza_ has quit IRC | 23:16 | |
| dansmith | melwitt: I think that person misunderstands what is supposed to happen | 23:16 |
| dansmith | yes, I think that marking the migration as errored whenever we can catch it is good of course | 23:17 |
| *** zzzeek has quit IRC | 23:18 | |
| dansmith | that's the subject of the later patch that updates the object along the way | 23:18 |
| melwitt | dansmith: yeah, I'm trying to figure out what I'll respond | 23:19 |
| *** oro has quit IRC | 23:19 | |
| melwitt | dansmith: yeah, I was just looking at it to see if it was doing anything with setting migration to failed. I see that for live migration and other stuff | 23:20 |
| dansmith | yeah, doesn't I don't think | 23:20 |
| dansmith | I meant *that* is where we should do extra work to record failures | 23:20 |
| dansmith | there is a lot of that path that is fairly lossy, but I'm sure there are some places we can do it | 23:21 |
| melwitt | yes, understood | 23:21 |
| *** claudiub_ has joined #openstack-nova | 23:23 | |
| *** kylek3h_ has quit IRC | 23:23 | |
| *** krtaylor has quit IRC | 23:23 | |
| *** hemna is now known as hemnafk | 23:24 | |
| *** SourabhP has joined #openstack-nova | 23:25 | |
| *** claudiub has quit IRC | 23:25 | |
| *** yamahata has joined #openstack-nova | 23:28 | |
| *** ijw_ has joined #openstack-nova | 23:28 | |
| *** SourabhP has quit IRC | 23:28 | |
| *** SourabhP has joined #openstack-nova | 23:28 | |
| *** radek_ has quit IRC | 23:29 | |
| *** ijw has quit IRC | 23:31 | |
| dansmith | mriedem: what ELO song earlier? | 23:31 |
| *** annashen has quit IRC | 23:33 | |
| *** annashen has joined #openstack-nova | 23:33 | |
| *** angdraug has quit IRC | 23:34 | |
| *** SourabhP has quit IRC | 23:37 | |
| melwitt | dansmith: so what is supposed to happen if an evacuate fails to create on the target? it's true we don't care about whether the local disk is kept, but what about the instance overall? what if it's not been created on the target? that's what the bug reporter is talking about | 23:37 |
| *** annashen has quit IRC | 23:38 | |
| dansmith | melwitt: right, so IMHO if we do an evacuate and the rebuild fails to succeed on the target node, it's just dead and the client should re-evacuate to try something/somewhere else | 23:38 |
| dansmith | melwitt: once we have tasks we could decide to make evacuate try and retry a number of times before giving up, but... we don't have that and especially if we expose enough info to the client, the client can just do it | 23:40 |
| melwitt | dansmith: okay, and then this thing is only deleting the local stuff (driver.destroy()) but not the "instance" so it would still show up in 'nova show' and then they could retry the evacuate? | 23:40 |
| dansmith | yup | 23:41 |
| melwitt | okay, I kept getting mixed up | 23:41 |
| dansmith | the point of an evacuation (of an ephemeral instance anyway) is to keep the same uuid, ip, etc | 23:41 |
| *** krtaylor has joined #openstack-nova | 23:41 | |
| dansmith | and all of that is just stuff in the db, not anything that lives on a node | 23:41 |
| dansmith | I know, it's confusing | 23:41 |
| melwitt | right. okay | 23:41 |
| melwitt | I think I understand enough to be able to explain in this bug report what evacuate means and does heh | 23:42 |
| *** rlrossit has left #openstack-nova | 23:43 | |
| *** SourabhP has joined #openstack-nova | 23:44 | |
| *** dims has joined #openstack-nova | 23:45 | |
| *** dims has quit IRC | 23:46 | |
| *** markvoelker has joined #openstack-nova | 23:47 | |
| *** ijw has joined #openstack-nova | 23:48 | |
| *** marun has quit IRC | 23:51 | |
| *** ijw_ has quit IRC | 23:51 | |
| *** RuiChen has quit IRC | 23:53 | |
| *** RuiChen has joined #openstack-nova | 23:53 | |
| *** zzzeek has joined #openstack-nova | 23:55 | |
| *** dboik has joined #openstack-nova | 23:56 | |
| *** ianbrown has joined #openstack-nova | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
