Wednesday, 2015-07-01

*** dboik has quit IRC00:00
*** asettle has joined #openstack-nova00:01
*** claudiub_ has quit IRC00:02
*** penick has quit IRC00:03
dansmithmelwitt: can you link me to that low-hanging-fruit page?00:05
dansmithI want to rage-add some things :D00:05
*** thorst has joined #openstack-nova00:07
*** pixelb has quit IRC00:07
*** tjones1 has quit IRC00:08
*** Piet has joined #openstack-nova00:10
*** thorst has quit IRC00:11
*** tsekiyam_ has joined #openstack-nova00:12
mriedemdansmith: turn to stone00:14
dansmithmriedem: rock on00:15
*** mwagner_lap has joined #openstack-nova00:15
*** mtanino has quit IRC00:15
*** tsekiyama has quit IRC00:16
mriedemdansmith: https://etherpad.openstack.org/p/nova-low-hanging-fruit00:16
*** tsekiyam_ has quit IRC00:17
dansmithah, thanks00:17
mriedem"Conversion from mox to mock unit tests"00:17
mriedemi thought that was a thing we said not to do00:17
mriedem#4 here http://docs.openstack.org/infra/manual/developers.html#peer-review00:18
dansmithyeah, but jaypipes just told someone to do that over the weekend00:18
dansmithso I dunno00:19
*** ijw_ has joined #openstack-nova00:19
*** logan2 has quit IRC00:19
dansmithI wouldn't mind getting rid of mox tests, but also don't really care to spend time reviewing that stuff00:19
dansmithso meh00:19
mriedemyeah i don't want to review it00:19
*** otter768 has quit IRC00:20
mriedemsure it's low hanging fruit, but it's a big waste of time for review bandwidth00:20
dansmithyep00:20
mriedemdansmith: did you just add this? "A lot of tests still need to be converted. Almost anywhere you see a mock or stub for a db.instance_* method, that thing should be mocking out the object layer instead. Exceptions would be tests of the objects themselves, tests of the DB API layer, and probably some legacy EC2 tests that are hardly worth converting."00:21
dansmithyes00:21
dansmithI rage-added it00:21
dansmithbecause I'm in test hell00:21
*** SourabhP_ has joined #openstack-nova00:21
*** ijw has quit IRC00:22
mriedemthere is A LOT of that db.* stubbing out in the api extension unit tests00:22
mriedemthey mock out the db api calls that the objects make from nova.compute.api00:22
*** logan2 has joined #openstack-nova00:22
mriedembut actually testing way up in the api extensions00:22
*** rlrossit has joined #openstack-nova00:22
dansmithyep, that's the hell I'm in00:22
dansmithI'm like this >< close to scratching my own eyes out00:23
dansmithall I want to do is effing remove the flavor compat shit from the instance object00:23
*** SourabhP has quit IRC00:24
*** SourabhP_ is now known as SourabhP00:24
*** rlrossit has left #openstack-nova00:24
*** nic has quit IRC00:25
mriedeme.g. http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/api/openstack/compute/test_servers.py#n17600:25
dansmithyep00:25
dansmithand those god-awful tests also do a lot of mocking per test00:25
dansmithso it's like a million places to fix00:25
dansmithI've got a nearly 500 line patch going so far00:26
dansmithjust to clean those up00:26
dansmithbut I'm pretty close to just deleting it00:26
mriedemi heard rlrossit loves to work on that stuff00:26
dansmithorly00:26
dansmithI would buy rlrossit beers in minnesota00:27
mriedemunfortunately he's not around00:27
dansmiththink of the learning experience00:27
dansmithexternal api, internal api, db api, objects00:27
*** pedroalvarez has quit IRC00:27
mriedemha yeah, riiight00:27
dansmithhehe00:28
*** sirushti has quit IRC00:28
*** anish has quit IRC00:29
*** sdake has quit IRC00:29
*** pedroalvarez has joined #openstack-nova00:29
*** jasondotstar has joined #openstack-nova00:30
*** dims has joined #openstack-nova00:32
*** sirushti has joined #openstack-nova00:33
*** kfox1111 is now known as kfox1111_away00:33
*** yingjun has joined #openstack-nova00:33
*** otter768 has joined #openstack-nova00:34
*** annashen has joined #openstack-nova00:34
*** anish has joined #openstack-nova00:35
*** dims_ has joined #openstack-nova00:35
*** kylek3h has joined #openstack-nova00:36
*** annashen has quit IRC00:38
*** dprince has joined #openstack-nova00:39
*** dims has quit IRC00:39
*** asettle has quit IRC00:40
*** kylek3h has quit IRC00:40
*** RuiChen has quit IRC00:43
*** RuiChen has joined #openstack-nova00:44
*** zhenguo has joined #openstack-nova00:47
*** IanGovett has quit IRC00:48
*** eliqiao has quit IRC00:52
gmannmriedem: Can you please review - https://review.openstack.org/#/c/195412/00:56
gmannmriedem: this is for bug about list server filter with --tenant-id implies all_tenant flag00:57
*** eliqiao has joined #openstack-nova00:57
*** eliqiao has left #openstack-nova00:58
*** annegentle has joined #openstack-nova01:01
*** boris-42 has quit IRC01:02
*** igordcard has quit IRC01:04
mriedemgmann: added myself, won't get to reviewing it tonight01:04
*** tellesnobrega_ has joined #openstack-nova01:05
gmannmriedem: ohk. Thanks01:05
*** Jeffrey4l has quit IRC01:07
*** kiran-r has joined #openstack-nova01:10
*** dprince has quit IRC01:10
*** piyanai has joined #openstack-nova01:11
*** r-daneel has quit IRC01:11
*** armax has quit IRC01:12
tonybis this http://logs.openstack.org/25/194325/11/check/gate-nova-python27/6cbe0ac/console.html#_2015-07-01_00_04_39_110 a known thing or should I look into it?01:14
*** heyongli has quit IRC01:14
*** heyongli has joined #openstack-nova01:15
*** armax has joined #openstack-nova01:18
*** changbl has joined #openstack-nova01:18
*** ijw has joined #openstack-nova01:20
*** Jeffrey4l has joined #openstack-nova01:20
openstackgerritGhanshyam Mann proposed openstack/nova: Merge V2 and V2.1 keypair functional tests  https://review.openstack.org/17617701:20
*** armax has quit IRC01:22
*** zzzeek has quit IRC01:23
*** ijw_ has quit IRC01:23
*** artom has quit IRC01:24
*** patrickeast has quit IRC01:24
jaypipesmriedem, dansmith: :( sorry if you guys are angry at me about adding that section on unit test refactoring to the low-hanging fruit etherpad.01:28
dansmithjaypipes: you bastard!01:28
dansmithno, it's fine01:28
jaypipesdansmith: BTW, did you see my review of the RBD snapshot spec? Looks like jdurgin thinks my proposal will work, with a minor adjustment.01:30
dansmithjaypipes: yeah, I didn't read it in depth, but I saw a proposed solution and jdurgin's happy reply01:31
dansmithjaypipes: thanks for that01:31
jaypipesno worries.01:31
*** liusheng has joined #openstack-nova01:31
dansmithI knew problems+glance+rbd+jay=solution01:31
*** Marga_ has joined #openstack-nova01:32
*** jlearman has left #openstack-nova01:33
*** annashen has joined #openstack-nova01:35
*** edleafe has quit IRC01:35
*** otter768 has quit IRC01:36
*** edleafe has joined #openstack-nova01:37
*** andreykurilin__ has quit IRC01:37
*** Kevin_Zheng has quit IRC01:38
*** shihanzhang has joined #openstack-nova01:38
*** Kevin_Zheng has joined #openstack-nova01:38
*** tellesnobrega_ has quit IRC01:38
*** annashen has quit IRC01:39
*** hanzhang has quit IRC01:41
*** annegentle has quit IRC01:42
openstackgerritGhanshyam Mann proposed openstack/nova: Modified testscenario for micro version 2.4  https://review.openstack.org/19739401:42
*** varunarya has joined #openstack-nova01:42
mriedemtonyb: i haven't seen it01:42
mriedeminfinite loop in someone's change01:42
tonybmriedem: but the vewies that causes that is an update to requirements01:48
tonybmriedem: https://review.openstack.org/#/c/194325/1101:48
tonybmriedem: if you haven't seen it I'll play locally and see if I can narrow it down to the requirements change01:49
openstackgerritGhanshyam Mann proposed openstack/nova: Merge availability_zone tests between v2 and v2.1  https://review.openstack.org/17101701:49
mriedemtonyb: run it through logstash01:51
*** ijw_ has joined #openstack-nova01:52
dansmithoye01:52
*** varunarya has quit IRC01:52
dansmithmriedem: tonyb I bet that's related to the patch we just merged01:52
dansmithtonyb: https://review.openstack.org/#/c/197176/01:53
dansmithtonyb: if that fails unreliably, then maybe we need some memory in the test to make sure we don't loop01:53
* dansmith grumbles again about the circular dep01:53
dansmithtonyb: there is a circular object dependency between fixed and floating ips01:53
*** ijw has quit IRC01:53
*** varunarya has joined #openstack-nova01:54
tonybdansmith: ok.01:54
* tonyb will try to understand that test and come up with a fix.01:55
mriedemhttp://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiUnVudGltZUVycm9yOiBtYXhpbXVtIHJlY3Vyc2lvbiBkZXB0aCBleGNlZWRlZFwiIEFORCB0YWdzOlwiY29uc29sZVwiIEFORCBidWlsZF9xdWV1ZTpcImdhdGVcIiBBTkQgYnVpbGRfbmFtZTpcImdhdGUtbm92YS1weXRob24yN1wiIiwiZmllbGRzIjpbXSwib2Zmc2V0IjowLCJ0aW1lZnJhbWUiOiI2MDQ4MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sInN0YW1wIjoxNDM1NzE1Njg3MDU0LCJtb2RlIjoiIiwiYW5hbHl6ZV9maWVsZCI6IiJ901:55
* tonyb really wants the requirements patch to land ;P01:55
dansmithI thought that it stops recursing for objects it knows about, but maybe there is a way for it to slip past01:55
mriedemit only failed in the gate on this one change https://review.openstack.org/#/c/197176/01:56
mriedemnot sure why the gate didn't kick it out01:56
tonybmriedem: that's the change I want to land :)01:57
mriedemtonyb: hmm, that's the only change it's failed in the check queue01:59
mriedemwhich would mean it's fairly rare01:59
mriedemtonyb: i guess start by filing a bug01:59
tonybmriedem: or it's related to the new oslo libraries somehow01:59
mriedemdoubt it01:59
*** ijw_ has quit IRC01:59
mriedemthe only change for oslo.versionedobjects in that g-r update is to exclude 0.5.0 which we aren't testing with anyway since 0.5.1 is out02:00
mriedemand i doubt oslo.concurrency is involved02:00
mriedemit failed in the gate on https://review.openstack.org/#/c/197176/ but didn't kick it out of the gate, which really confuses me02:00
tonybmriedem: mmkay I'll file a bug with your logstash and then dig into it02:01
mriedemalright good b/c i'm bailing out for the night02:01
mriedemjust make mikal fix it02:02
*** jwcroppe has quit IRC02:02
tonybmriedem: I see you need to understand how this "management" thing works ;P02:02
*** jwcroppe has joined #openstack-nova02:02
*** huazhihao has joined #openstack-nova02:03
*** yamahata has quit IRC02:05
*** jwcroppe has quit IRC02:07
*** kylek3h has joined #openstack-nova02:07
*** jasondotstar has quit IRC02:07
*** annegentle has joined #openstack-nova02:08
*** ijw has joined #openstack-nova02:09
*** Longgeek_ has joined #openstack-nova02:10
*** Kevin_Zheng has quit IRC02:10
*** sdake has joined #openstack-nova02:11
*** shihanzhang has quit IRC02:11
*** shihanzhang has joined #openstack-nova02:11
*** varunarya has quit IRC02:11
*** Longgeek has quit IRC02:12
*** coolsvap|away has quit IRC02:13
*** kylek3h has quit IRC02:13
*** haomaiwa_ has joined #openstack-nova02:14
*** kiran-r has quit IRC02:14
*** coolsvap|away has joined #openstack-nova02:15
*** piyanai has quit IRC02:15
*** mriedem has quit IRC02:16
*** mutoulbj has joined #openstack-nova02:18
*** huazhihao has quit IRC02:18
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_disassociate  https://review.openstack.org/16162402:20
openstackgerritTony Breeds proposed openstack/nova: libvirt: Correct domxml node name.  https://review.openstack.org/19739802:22
*** xyang1 has quit IRC02:23
*** ijw has quit IRC02:25
*** yingjun has quit IRC02:26
*** tobe has joined #openstack-nova02:29
*** unicell has quit IRC02:29
*** yingjun has joined #openstack-nova02:30
*** mutoulbj_ has joined #openstack-nova02:30
*** mutoulbj has quit IRC02:34
*** baoli has joined #openstack-nova02:34
*** annashen has joined #openstack-nova02:36
*** Kennan has quit IRC02:38
*** Kennan has joined #openstack-nova02:38
*** haomaiwa_ has quit IRC02:39
*** Longgeek_ has quit IRC02:39
*** haomaiw__ has joined #openstack-nova02:40
*** Longgeek has joined #openstack-nova02:41
*** annashen has quit IRC02:41
*** marun has joined #openstack-nova02:43
*** baoli has quit IRC02:47
*** lucas__ has joined #openstack-nova02:47
openstackgerritDan Smith proposed openstack/nova: Block subtractive operations in migrations for Kilo and beyond  https://review.openstack.org/19734902:49
*** baoli has joined #openstack-nova02:49
*** unicell has joined #openstack-nova02:52
*** gyee has quit IRC02:52
*** annegentle has quit IRC02:53
*** piyanai has joined #openstack-nova02:59
*** annegentle has joined #openstack-nova03:04
openstackgerritHiroyuki Eguchi proposed openstack/nova: allow live migration in case of a booted from volume instance  https://review.openstack.org/19588503:09
*** haomaiw__ has quit IRC03:09
*** haomaiwang has joined #openstack-nova03:10
*** lucas__ has quit IRC03:10
*** Longgeek has quit IRC03:14
*** mutoulbj_ has quit IRC03:18
openstackgerritHiroyuki Eguchi proposed openstack/nova: allow live migration in case of a booted from volume instance  https://review.openstack.org/19588503:21
*** mutoulbj has joined #openstack-nova03:21
*** lucas__ has joined #openstack-nova03:21
*** unicell has quit IRC03:22
*** unicell has joined #openstack-nova03:23
*** mutoulbj has quit IRC03:23
*** lucas__ has quit IRC03:26
*** zzzeek has joined #openstack-nova03:26
*** zzzeek has quit IRC03:26
*** baoli has quit IRC03:26
*** annegentle has quit IRC03:31
*** mutoulbj has joined #openstack-nova03:32
*** SourabhP has quit IRC03:35
*** annashen has joined #openstack-nova03:37
*** otter768 has joined #openstack-nova03:37
*** annegentle has joined #openstack-nova03:38
*** jyuso1 has joined #openstack-nova03:41
*** annashen has quit IRC03:41
*** otter768 has quit IRC03:42
*** jecarey has joined #openstack-nova03:43
*** Longgeek has joined #openstack-nova03:44
*** yingjun has quit IRC03:45
*** hemna has joined #openstack-nova03:45
*** ildikov has quit IRC03:47
*** annegentle has quit IRC03:48
*** Longgeek has quit IRC03:49
*** jogo has joined #openstack-nova03:50
*** varunarya has joined #openstack-nova03:50
*** hemna has quit IRC03:53
openstackgerritZhenyu Zheng proposed openstack/nova: glance:check the num_retries option  https://review.openstack.org/12331803:55
*** liusheng has quit IRC03:55
*** liusheng has joined #openstack-nova03:55
*** heyongli has quit IRC03:57
*** heyongli has joined #openstack-nova03:58
*** Jeffrey4l has quit IRC03:58
*** Jeffrey4l has joined #openstack-nova03:59
*** jwcroppe has joined #openstack-nova04:00
*** ijw has joined #openstack-nova04:02
*** sudipto has joined #openstack-nova04:02
*** varunarya has quit IRC04:02
*** dims_ has quit IRC04:03
*** tojuvone has joined #openstack-nova04:04
*** asettle has joined #openstack-nova04:06
*** heyongli has quit IRC04:07
*** heyongli has joined #openstack-nova04:08
*** Alexandra_ has joined #openstack-nova04:08
*** dave-mccowan has quit IRC04:09
*** armax has joined #openstack-nova04:10
*** asettle has quit IRC04:10
*** coolsvap|away is now known as coolsvap04:14
*** Alexandra_ has quit IRC04:14
*** xyhuang has joined #openstack-nova04:19
*** achanda has joined #openstack-nova04:19
*** hemna has joined #openstack-nova04:20
*** hemna has quit IRC04:21
*** jecarey has quit IRC04:21
*** morganfainberg is now known as caerbannograbbit04:24
*** caerbannograbbit is now known as CaerbannogRabbit04:24
*** tobe has quit IRC04:26
*** piyanai has quit IRC04:31
*** Longgeek has joined #openstack-nova04:34
*** ijw has quit IRC04:35
*** annashen has joined #openstack-nova04:37
*** achanda has quit IRC04:38
*** browne1 has joined #openstack-nova04:40
*** browne has quit IRC04:40
*** kiran-r has joined #openstack-nova04:41
*** nkrinner has joined #openstack-nova04:41
*** annashen has quit IRC04:42
*** fawadkhaliq has joined #openstack-nova04:43
*** ajayaa_ has joined #openstack-nova04:45
*** garyk has joined #openstack-nova04:46
*** annegentle has joined #openstack-nova04:49
*** garyk has quit IRC04:49
*** garyk1 has joined #openstack-nova04:49
*** ijw has joined #openstack-nova04:49
*** irenab has joined #openstack-nova04:54
*** annegentle has quit IRC04:55
*** kiran-r has quit IRC04:56
*** kiran-r has joined #openstack-nova04:56
*** nihilifer has joined #openstack-nova04:58
*** ajayaa_ has quit IRC05:01
*** pkholkin has joined #openstack-nova05:02
*** tdurakov has joined #openstack-nova05:02
*** snikitin has joined #openstack-nova05:02
*** sudipto has quit IRC05:02
*** Nikolay_St has joined #openstack-nova05:06
*** dims has joined #openstack-nova05:07
*** exploreshaifali has joined #openstack-nova05:10
*** dims has quit IRC05:12
*** arnaud____ has joined #openstack-nova05:17
*** _gryf|afk is now known as _gryf05:19
*** Dev_Jin has joined #openstack-nova05:21
*** arnaud____ has quit IRC05:22
*** prashant__ has joined #openstack-nova05:23
*** huazhihao has joined #openstack-nova05:23
*** marun has quit IRC05:23
*** tobe has joined #openstack-nova05:26
*** snikitin has quit IRC05:28
*** snikitin has joined #openstack-nova05:28
*** heyongli has quit IRC05:30
*** prashant_ has joined #openstack-nova05:31
*** haomaiwang has quit IRC05:33
*** oro has joined #openstack-nova05:34
*** prashant__ has quit IRC05:34
*** ijw has quit IRC05:36
*** heyongli has joined #openstack-nova05:37
*** haomaiwa_ has joined #openstack-nova05:38
*** otter768 has joined #openstack-nova05:38
*** annashen has joined #openstack-nova05:39
*** mmedvede has quit IRC05:40
*** kaisers1 has quit IRC05:43
*** otter768 has quit IRC05:43
*** annashen has quit IRC05:43
*** garyk1 has quit IRC05:45
*** garyk has joined #openstack-nova05:47
*** prashant__ has joined #openstack-nova05:54
*** jgrimm is now known as zz_jgrimm05:55
*** garyk has quit IRC05:56
*** jdurgin has quit IRC05:57
*** prashant_ has quit IRC05:57
*** garyk has joined #openstack-nova05:57
*** prashant_ has joined #openstack-nova05:58
*** varunarya has joined #openstack-nova05:59
*** tobe has quit IRC05:59
*** davideag_ has quit IRC06:00
openstackgerritJesse J. Cook proposed openstack/nova: Cells: distribute build requests across cells  https://review.openstack.org/19575706:00
openstackgerritJesse J. Cook proposed openstack/nova: Cells: - weight_offset; + selection_multiplier  https://review.openstack.org/19742406:00
openstackgerritJesse J. Cook proposed openstack/nova: Cells: decrement available slots  https://review.openstack.org/19742506:00
*** prashant__ has quit IRC06:01
*** prashant__ has joined #openstack-nova06:02
*** fawadkhaliq has quit IRC06:04
*** SourabhP has joined #openstack-nova06:05
*** prashant_ has quit IRC06:06
*** deepthi has joined #openstack-nova06:06
*** prashant_ has joined #openstack-nova06:07
*** oro has quit IRC06:07
*** prashant__ has quit IRC06:10
*** prashant__ has joined #openstack-nova06:11
*** SourabhP has quit IRC06:12
*** prashant_ has quit IRC06:15
*** gokrokve has joined #openstack-nova06:16
*** Murali has joined #openstack-nova06:16
*** garyk has quit IRC06:16
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex  https://review.openstack.org/19721306:16
*** prashant_ has joined #openstack-nova06:16
*** Jeffrey4l has quit IRC06:17
*** gokrokve has quit IRC06:18
*** prashant__ has quit IRC06:19
*** ajayaa_ has joined #openstack-nova06:19
*** marun has joined #openstack-nova06:20
*** scheuran has joined #openstack-nova06:20
*** browne1 has quit IRC06:21
*** irenab has quit IRC06:22
openstackgerritGhanshyam Mann proposed openstack/nova: Merge server password tests between v2 and v2.1  https://review.openstack.org/19743506:22
*** prashant_ has quit IRC06:23
*** fawadkhaliq has joined #openstack-nova06:25
*** marun has quit IRC06:25
*** varunarya has quit IRC06:26
*** fawadkhaliq has quit IRC06:31
*** yingjun has joined #openstack-nova06:34
*** ianbrown has quit IRC06:35
*** tdurakov has quit IRC06:35
*** pkholkin has quit IRC06:35
*** snikitin has quit IRC06:36
openstackgerritFeodor Tersin proposed openstack/nova: Ignore image's min_disk and size for volume-backed instances  https://review.openstack.org/19656906:39
*** yamahata has joined #openstack-nova06:39
*** sahid has joined #openstack-nova06:39
*** annashen has joined #openstack-nova06:39
*** asettle has joined #openstack-nova06:43
*** annashen has quit IRC06:44
*** moshele has joined #openstack-nova06:46
*** radek_ has joined #openstack-nova06:48
*** ildikov has joined #openstack-nova06:49
*** annegentle has joined #openstack-nova06:51
*** radek_ has quit IRC06:52
*** tobe has joined #openstack-nova06:53
*** prashant_ has joined #openstack-nova06:53
*** garyk has joined #openstack-nova06:53
*** radek_ has joined #openstack-nova06:53
*** belmoreira has joined #openstack-nova06:54
*** snikitin has joined #openstack-nova06:56
*** pkholkin has joined #openstack-nova06:56
*** tdurakov has joined #openstack-nova06:56
*** annegentle has quit IRC06:56
*** ndipanov has quit IRC06:57
*** prashant__ has joined #openstack-nova06:58
*** otter768 has joined #openstack-nova07:00
*** prashant_ has quit IRC07:02
*** Marga_ has quit IRC07:02
*** doude has joined #openstack-nova07:03
*** asettle has quit IRC07:04
*** otter768 has quit IRC07:06
*** prashant_ has joined #openstack-nova07:06
*** huazhihao has quit IRC07:07
*** irenab has joined #openstack-nova07:09
*** prashant__ has quit IRC07:10
*** prashant__ has joined #openstack-nova07:10
*** matrohon has joined #openstack-nova07:12
*** abhishekk has joined #openstack-nova07:12
*** mpavone has joined #openstack-nova07:12
*** prashant_ has quit IRC07:14
*** prashant_ has joined #openstack-nova07:16
*** armax has quit IRC07:18
openstackgerritsahid proposed openstack/nova-specs: console: convert consoles code to use objects framework  https://review.openstack.org/16583807:20
*** prashant__ has quit IRC07:20
*** romainh has joined #openstack-nova07:22
*** Jeffrey4l has joined #openstack-nova07:23
*** subscope has quit IRC07:24
*** lyarwood has quit IRC07:25
*** lyarwood has joined #openstack-nova07:26
*** prashant__ has joined #openstack-nova07:26
*** Kevin_Zheng has joined #openstack-nova07:29
*** mjturek1 has quit IRC07:29
*** mnestratov|2 has joined #openstack-nova07:29
*** prashant_ has quit IRC07:30
*** mjturek1 has joined #openstack-nova07:30
*** Jeffrey4l has quit IRC07:31
*** Jeffrey4l has joined #openstack-nova07:31
*** zz_jgrimm has quit IRC07:31
*** mpaolino has joined #openstack-nova07:32
*** zhenguo has quit IRC07:32
*** mnestratov has quit IRC07:32
*** zhenguo has joined #openstack-nova07:33
*** zz_jgrimm has joined #openstack-nova07:33
*** prashant_ has joined #openstack-nova07:33
*** haypo has joined #openstack-nova07:34
*** unicell has quit IRC07:35
*** subscope has joined #openstack-nova07:37
*** prashant__ has quit IRC07:37
*** prashant__ has joined #openstack-nova07:39
*** annashen has joined #openstack-nova07:40
*** yingjun has quit IRC07:41
*** Marga_ has joined #openstack-nova07:42
*** yingjun has joined #openstack-nova07:42
*** jlanoux has joined #openstack-nova07:43
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for floating_ip_dns  https://review.openstack.org/15071007:43
*** prashant_ has quit IRC07:43
*** eliqiao has joined #openstack-nova07:44
*** eliqiao has left #openstack-nova07:45
*** annashen has quit IRC07:45
*** jistr has joined #openstack-nova07:45
*** prashant_ has joined #openstack-nova07:46
openstackgerritwangxiyuan proposed openstack/python-novaclient: Add 'deleted' status check in image-create  https://review.openstack.org/19745707:46
*** jcoufal has joined #openstack-nova07:49
*** prashant__ has quit IRC07:50
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host  https://review.openstack.org/16162507:51
*** lucasagomes has joined #openstack-nova07:51
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host  https://review.openstack.org/16162507:51
*** prashant__ has joined #openstack-nova07:52
*** kiran-r has quit IRC07:52
*** prashant_ has quit IRC07:55
*** mpaolino has quit IRC07:56
*** liudong has joined #openstack-nova07:57
openstackgerritsahid proposed openstack/nova-specs: Libvirt real time instances  https://review.openstack.org/13968807:57
*** eglynn has joined #openstack-nova07:57
*** prashant_ has joined #openstack-nova07:58
liudong\?07:59
*** liudong has left #openstack-nova07:59
*** karimb has joined #openstack-nova08:01
openstackgerritRui Chen proposed openstack/nova: Fix incomplete error message of quota exceeded  https://review.openstack.org/19746008:02
*** prashant__ has quit IRC08:02
*** Marga_ has quit IRC08:02
*** apuimedo_ has joined #openstack-nova08:07
*** prashant__ has joined #openstack-nova08:08
*** marun has joined #openstack-nova08:09
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host  https://review.openstack.org/16162508:09
*** kylek3h has joined #openstack-nova08:09
*** prashant_ has quit IRC08:12
*** prashant_ has joined #openstack-nova08:13
*** BobBall_AWOL is now known as BobBall08:14
*** marun has quit IRC08:14
*** kylek3h has quit IRC08:15
*** prashant__ has quit IRC08:17
*** prashant__ has joined #openstack-nova08:21
*** liusheng has quit IRC08:23
*** arnaud____ has joined #openstack-nova08:23
*** liusheng has joined #openstack-nova08:23
*** Marga_ has joined #openstack-nova08:23
*** prashant_ has quit IRC08:25
*** yamahata has quit IRC08:26
openstackgerritJeffrey Zhang proposed openstack/nova: Support all_tenants search_opts for neutron  https://review.openstack.org/18765708:26
*** danpb has joined #openstack-nova08:27
*** arnaud____ has quit IRC08:28
*** lsmola has joined #openstack-nova08:29
*** prashant_ has joined #openstack-nova08:31
*** exploreshaifali has quit IRC08:35
*** prashant__ has quit IRC08:35
*** mutoulbj_ has joined #openstack-nova08:36
*** yassine__ has joined #openstack-nova08:36
*** prashant__ has joined #openstack-nova08:37
*** obondarev has joined #openstack-nova08:39
*** rdo has quit IRC08:39
*** mutoulbj has quit IRC08:39
*** dguitarbite has quit IRC08:40
*** lpetrut has joined #openstack-nova08:40
*** rdo has joined #openstack-nova08:41
*** prashant_ has quit IRC08:41
*** annashen has joined #openstack-nova08:41
*** prashant_ has joined #openstack-nova08:43
*** annashen has quit IRC08:46
*** pixelb has joined #openstack-nova08:46
*** prashant__ has quit IRC08:47
*** aix has joined #openstack-nova08:48
*** jasondotstar has joined #openstack-nova08:48
*** prashant__ has joined #openstack-nova08:48
*** prashant_ has quit IRC08:52
*** prashup has joined #openstack-nova08:52
*** irenab has quit IRC08:54
*** prashant__ has quit IRC08:55
*** irenab has joined #openstack-nova08:55
*** prashant_ has joined #openstack-nova08:55
*** humble_ has quit IRC08:57
*** prashup has quit IRC08:59
johnthetubaguydanpb: I think your vif lib depends on this spec, any chance you could give that a review please? https://review.openstack.org/#/c/190917/6/specs/liberty/approved/nova-neutron-binding-negotiation.rst,cm09:00
johnthetubaguydanpb: it would be good to quickly catch up on your plans for the os-vif-lib effort09:01
johnthetubaguydanpb: is it something you think can make progress during liberty, like would making it a priority help?09:01
*** prashant__ has joined #openstack-nova09:02
*** otter768 has joined #openstack-nova09:02
*** prashant_ has quit IRC09:05
*** exploreshaifali has joined #openstack-nova09:06
*** prashup has joined #openstack-nova09:06
*** liudong has joined #openstack-nova09:06
*** otter768 has quit IRC09:07
openstackgerritRoman Dobosz proposed openstack/nova: Introducing new forced_down field for a Service object  https://review.openstack.org/18528009:07
openstackgerritRoman Dobosz proposed openstack/nova: New nova API call to mark nova-compute down  https://review.openstack.org/18408609:07
openstackgerritRoman Dobosz proposed openstack/nova: Service group drivers forced_down flag utilization  https://review.openstack.org/19706309:07
openstackgerritRoman Dobosz proposed openstack/nova: Refactoring of the os-services module  https://review.openstack.org/18527909:07
openstackgerritRong Han proposed openstack/nova: modify '<nosharedpages/>' to '<nosharepages/>'.  https://review.openstack.org/19748009:08
*** xgsa1 has joined #openstack-nova09:08
*** dims has joined #openstack-nova09:08
*** prashant__ has quit IRC09:09
openstackgerritRong Han proposed openstack/nova: modify '<nosharedpages/>' to '<nosharepages/>'.  https://review.openstack.org/19748009:12
*** irenab has quit IRC09:12
*** prashant_ has joined #openstack-nova09:13
*** irenab has joined #openstack-nova09:14
*** dims has quit IRC09:14
*** rajesht has joined #openstack-nova09:15
*** xgsa has quit IRC09:15
rajeshthi09:16
rajeshtcan anybody tell me how can I downgrade my db schema09:16
rajeshtI tried nova-manage db sync <migrate_version_to_downgrade>09:16
rajeshtbut looks like the support is removed for it.09:17
rajeshtcould you please tell me any other alternatives ?09:17
bauzasrajesht: https://github.com/openstack/openstack-specs/blob/master/specs/no-downward-sql-migration.rst09:17
*** prashup has quit IRC09:17
*** prashant__ has joined #openstack-nova09:18
rajeshtbauzas: https://github.com/openstack/openstack-specs/blob/master/specs/no-downward-sql-migration.rst#alternatives09:19
rajeshtbauzas: thanks, I checked that but couldn't find other alternative.09:19
bauzasrajesht: read the references09:20
rajeshtbauzas: thanks, will go through it09:21
*** haomaiwa_ has quit IRC09:21
*** prashant_ has quit IRC09:22
*** afazekas has joined #openstack-nova09:24
johnthetubaguyrajesht: let us know if thats an issue, but you are right, we have dropped db downgrades, mostly because they basically don't work, so we wanted to stop people using a broken thing. Let us know if there are more docs we need so its clear what the recommended route is.09:25
johnthetubaguyrajesht: there is an expectation on testing out migrations on backups of production DBs before doing it in production, etc, etc.09:25
*** prashant_ has joined #openstack-nova09:27
rajeshtjohnthetubaguy: there is no issue, I just wanted to downgrade db schema for testing purpose.09:27
rajeshtjohnthetubaguy: https://github.com/openstack/openstack-specs/blob/master/specs/no-downward-sql-migration.rst#alternatives09:27
johnthetubaguyrajesht: ah, I see09:27
rajeshtjohnthetubaguy: is there any alternative ?09:27
rajeshtjohnthetubaguy: as mentioned in above link09:27
johnthetubaguyrajesht: so that spec section is about alternatives to the implementation, not replacements09:28
johnthetubaguyrajesht: in summary, there is no way to downgrade any more09:28
rajeshtjohnthetubaguy: oh, got it.09:28
rajeshtjohnthetubaguy: thanks :)09:28
johnthetubaguyrajesht: now I don't remember us discussing test uses of the feature, so thats interesting09:28
openstackgerritRong Han proposed openstack/nova: modify '<nosharedpages/>' to '<nosharepages/>'.  https://review.openstack.org/19748609:29
*** yingjun has quit IRC09:30
tojuvonebauzas: I'd like to continue still the "mark host down" by having it updating somehow the server states, just should get this forwards and do it within liberty: https://review.openstack.org/19224609:30
*** dheeraj-gupta-4 has joined #openstack-nova09:31
*** prashant__ has quit IRC09:31
*** aix has quit IRC09:31
*** prashant__ has joined #openstack-nova09:32
*** prashant_ has quit IRC09:36
*** ociuhandu has quit IRC09:39
*** prashant_ has joined #openstack-nova09:40
*** liudong has quit IRC09:42
*** annashen has joined #openstack-nova09:42
*** prashant__ has quit IRC09:43
*** bradjones has quit IRC09:44
*** sdake has quit IRC09:46
*** bradjones has joined #openstack-nova09:46
*** bradjones has quit IRC09:46
*** bradjones has joined #openstack-nova09:46
*** annashen has quit IRC09:46
danpbjohnthetubaguy: so in the VIF config object/plugins spec, really the only issue is getting buy in / sign off from all the required parties in Nova and Neutron09:47
BobBalljohnthetubaguy: Don't forget to give me a +2 on https://review.openstack.org/#/c/193647/ ! :)09:47
*** mikeit has joined #openstack-nova09:47
*** prashant__ has joined #openstack-nova09:47
danpbjohnthetubaguy: given the timing, i was somewhat unsure whether that was at all practical for Liberty or would have to wait until the Muppet cycle09:47
johnthetubaguydanpb: just worried the dependent spec isn't getting much review09:47
abhishekksnikitin: hi, you around?09:48
danpbjohnthetubaguy: i just commented in that spec - i'm wondering if we should just fold it into the other spec09:48
danpbjohnthetubaguy: as it is really mutually dependant at the implementation point09:48
danpband is a pretty minor detail in the bigger picture so possibly doesn't need to be a separate spec09:48
johnthetubaguydanpb: hmm, maybe, I just think the spec is too big already, the other is quite nice and self contained at the moment, which might be handy09:49
johnthetubaguydanpb: I guess this could rumble on outside of nova quite happily, maybe approving it on the backlog might be better?09:49
johnthetubaguydanpb: so leave the integration with Nova bit to Muppet, although that feels like a shame09:50
danpbthe problem is that the impl of the other spec would need to quite significantly change09:50
*** ftersin has joined #openstack-nova09:50
snikitinabhishekk: I'm here09:50
*** prashant_ has quit IRC09:51
danpbwhat is proposed is to just pass a list of vif type names, which is insufficient for the bigger spec09:51
abhishekksnikitin: sorry to disturb, any update on NFS shared storage space count?09:51
johnthetubaguydanpb: ah, OK09:51
johnthetubaguydanpb: you want to version the data, or make it richer in some way?09:51
danpbyes, we need to include version information primarily09:52
johnthetubaguyI see that as neutron's API09:52
danpbbut also, the single list will have to split into two lists09:52
johnthetubaguyso really they should have the spec for that API09:52
danpbas we need to represent VIF configs separately from VIF plugins09:52
abhishekksnikitin: are you planning to prepare specs for this?09:52
danpbultimately the data that we need to supply from nova to neutron will be determined by the design of the os-vif object model09:53
danpbjohnthetubaguy: yes, the split of responsibility between neutron & nova is complex - technically it is neutron's API we're calling09:53
*** prashant_ has joined #openstack-nova09:53
danpbjohnthetubaguy: but the bulk of the data handling burden probably falls on nova09:54
johnthetubaguydanpb: so I am thinking we should do a virtual summit session on this?09:54
johnthetubaguydanpb: well, virtual midcycle thing09:55
danpbi guess anything to get the nova and neutron cores to talk & agre on direction would be useful09:55
danpbif we can't do that in the spec, then a virtual meeting would work09:55
johnthetubaguyI think we need something high bandwidth here, to make it quicker09:56
johnthetubaguyit feels that way09:56
johnthetubaguyso here is an idea09:56
*** lucas__ has joined #openstack-nova09:56
danpbbtw, there is one way to make the work a bit more managable if we don't want to agree on a stable API right away09:56
johnthetubaguydanpb: I think we have to do oslo incubator style for a release09:57
danpb we could define the VIF config object classes inside nova, and convert Nova to use them, and provide some legacy plugin impls09:57
johnthetubaguydanpb: yep, I think thats what I am trying to say be oslo incubator style, but in reverse09:57
danpbthis would prove the design without having to commit to anything public between nova & neutron09:57
johnthetubaguyyeah09:57
*** prashant__ has quit IRC09:57
openstackgerritDheeraj Gupta proposed openstack/nova: Add HostMapping object  https://review.openstack.org/19209809:57
*** marun has joined #openstack-nova09:58
danpbbasically this would do 100% of the nova side of the work, but we'd simply not allow neutron to request any of the new VIF types09:58
danpbneutron would continue 100% with existing VIF types and nova would silently convert them ot the new types internally09:58
johnthetubaguydanpb: so I think a "go refactor" very lightweight spec that gives some ground rules is the best way to go09:58
johnthetubaguyyeah, I like that09:58
*** aix has joined #openstack-nova09:58
danpbthis would probably mean this ends up spanning 2 cycles09:58
johnthetubaguyagreed, but it should mean it actually happens, which is great09:59
danpbwe'd still want to ensure neutron folks buy into the design though09:59
*** dims has joined #openstack-nova09:59
danpbso that once we've converted nova they don't complain about what we ended up with09:59
johnthetubaguyso I have a feeling this is an "add a seam", then discuss kind of problem10:00
*** sudipto has joined #openstack-nova10:00
johnthetubaguylets do what looks best on our side, then take what we have to neutron to see if we need to evolve that?10:00
johnthetubaguyI mean we should talk to them about the ideas too10:00
danpbso far everyone from neutron commenting on the spec has been positive10:00
danpbbut i'm not sure who the really important people are in neutron core who need convincing10:01
danpband whether they've actually looked at it10:01
*** lucas__ has quit IRC10:01
sahidmikal: i had to fix some typos and add a note on the spec https://review.openstack.org/#/c/139688/ can we re-have your +2 please10:01
snikitinabhishekk: Unfortunately I have bad news :( 25 June we got a nova-spec-freeze. https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule So I can't merge spec in Liberty ( Nova community have a very short time to merge a spec. And my team doesn't merged no one spec in Liberty. Sorry, but I cant do it in Lyberty( If you really need this spec I think it would be better to find another developer, because my work on this spec goes very slow.. Sorry10:01
*** _gryf has quit IRC10:02
abhishekksnikitin: no problem, could you please share your ideas with me if possible?10:02
*** marun has quit IRC10:02
abhishekkabhishekk: when you get some time?10:02
*** mutoulbj_ has quit IRC10:03
johnthetubaguydanpb: so I think we need to get a virtual meeting together to discuss things, any chance you can work with kyle to get that arranged?10:04
danpbi'm actually about to go on holiday for 2 weeks, so we'll probably have to wait till i return at this point10:05
danpbeg, 2nd half of july10:05
*** _gryf has joined #openstack-nova10:05
*** prashant__ has joined #openstack-nova10:08
*** itzikb_ has joined #openstack-nova10:08
itzikb_heyongli: hi, can you please comment on https://bugs.launchpad.net/nova/+bug/1466451?10:08
openstackLaunchpad bug 1466451 in OpenStack Compute (nova) "Nova should verify that devname in pci_passthrough_whitelist is not empty" [Undecided,In progress] - Assigned to Wen Zhi Yu (yuywz)10:08
openstackgerritsahid proposed openstack/nova-specs: console: convert consoles code to use objects framework  https://review.openstack.org/16583810:09
snikitinabhishekk: Ok. give me some time10:10
danpbbtw, do we actually have a Mxxx release name yet ?   i've just been calling it Muppet so far10:10
abhishekksnikitin: sure, thank you10:10
*** prashant_ has quit IRC10:11
*** prashant_ has joined #openstack-nova10:12
johnthetubaguydanpb: ah, thats a good heads up, OK, sounds like it has to wait10:12
johnthetubaguydanpb: I think the TC said there were trademark issues being chased, I think10:12
*** prashant__ has quit IRC10:15
ftersindanpb: hi. could you please answer my questions in https://review.openstack.org/#/c/170243 ? it would be great to have your answers before your vacation10:15
*** Dev_Jin has quit IRC10:15
openstackgerritStephen Finucane proposed openstack/nova: Store correct VirtCPUTopology  https://review.openstack.org/19712510:16
*** romainh has quit IRC10:16
bauzasdanpb: not sure you saw http://civs.cs.cornell.edu/cgi-bin/results.pl?id=E_4983776e190c8dbc10:19
*** prashant__ has joined #openstack-nova10:19
*** dheeraj-gupta-4 has quit IRC10:19
bauzasdanpb: like johnthetubaguy said, it's under the hood of the foundation for any tm issues10:19
danpbftersin: ok, i've replied but not in general that when patches are showing in merge conflict they tend to be ignored by reviewers10:19
danpbs/not/note/10:20
*** prashant_ has quit IRC10:22
ftersinthanks, will keep it on mind10:23
*** Dev_Jin has joined #openstack-nova10:24
*** prashup has joined #openstack-nova10:24
*** xgsa1 has quit IRC10:24
*** lpetrut has quit IRC10:24
*** prashant__ has quit IRC10:26
johnthetubaguysnikitin: abhishekk: we are going through the spec freeze process right now to make sure we didn't miss any major ones, which is the spec you are needing?10:29
*** prashant_ has joined #openstack-nova10:29
*** xgsa has joined #openstack-nova10:32
ftersindanpb: could you also answer the second question in the commit message: how to split the patch10:32
*** prashup has quit IRC10:33
*** Marga_ has quit IRC10:34
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Enable python34 tests for nova/tests/unit/objects/test*.py  https://review.openstack.org/18778510:34
*** prashant__ has joined #openstack-nova10:34
*** ndipanov has joined #openstack-nova10:36
*** prashant_ has quit IRC10:38
tonybjohnthetubaguy: Can you look at: https://review.openstack.org/#/c/197507/ (Update XenAPI team meeting) and +1 if you're cool with it10:38
johnthetubaguytonyb: sure, thanks for pointing at that one10:39
*** exploreshaifali has quit IRC10:39
* BobBall steals the powah!10:40
tonybjohnthetubaguy: np.10:40
* tonyb waves at BobBall 10:40
*** prashant_ has joined #openstack-nova10:40
johnthetubaguyBobBall: can you create a Xen subteam for things like this: https://review.openstack.org/#/c/193647/ you do that by looking at the usual etherpad (down the bottom) https://etherpad.openstack.org/p/liberty-nova-priorities-tracking10:40
* BobBall waves back10:40
BobBallSure thing johnthetubaguy10:41
BobBallAnyone at rax who should be named as a subteam member there?10:42
*** annashen has joined #openstack-nova10:43
johnthetubaguyBobBall: not sure right now10:43
*** prashant__ has quit IRC10:43
*** gszasz has joined #openstack-nova10:43
johnthetubaguyBobBall: not needing to do loads of work on the driver right now10:43
BobBallIndeed - Loving the stability.  As long as you don't use the console... (the race I just fixed :D)10:44
johnthetubaguyBobBall: being asking for test to check that since I wrote it, they still haven't got to that10:45
*** lucasagomes is now known as lucas-bbl10:45
*** prashant__ has joined #openstack-nova10:46
*** claudiub has joined #openstack-nova10:46
BobBallhuh? *confused*10:46
openstackgerritRui Chen proposed openstack/nova: Fix incomplete error message of quota exceeded  https://review.openstack.org/19746010:47
*** annashen has quit IRC10:48
*** prashant_ has quit IRC10:49
*** prashant_ has joined #openstack-nova10:51
*** mutoulbj has joined #openstack-nova10:53
*** zhenguo has quit IRC10:54
snikitinjohnthetubaguy, abhishekk: We need a spec about "right" way of working with shared storages like Ceph. Because nova has a several bugs about incorrect statistics of shared storages. https://bugs.launchpad.net/nova/+bug/1252321 https://bugs.launchpad.net/nova/+bug/1387812 https://bugs.launchpad.net/nova/+bug/141443210:54
openstackLaunchpad bug 1252321 in OpenStack Compute (nova) "Nova counts NFS shared storage space on each node" [Medium,Confirmed]10:54
openstackLaunchpad bug 1387812 in OpenStack Compute (nova) "Hypervisor summary shows incorrect total storage (Ceph)" [Low,In progress] - Assigned to Sergey Nikitin (snikitin)10:54
openstackLaunchpad bug 1414432 in OpenStack Compute (nova) "nova hypervisor-stats shows wrong disk usage with shared storage" [Low,Confirmed] - Assigned to ChangBo Guo(gcb) (glongwave)10:54
*** prashant__ has quit IRC10:55
*** prashant_ has quit IRC10:58
danpbhonestly, the entire concept  of reporting storage per compute host and then summing it up across hosts is just doomed by design and any code doing that needs to be killed10:58
BobBallWe could add the concept of having a UUID for the storage we might be able to sum them sensibly?11:00
*** dprince has joined #openstack-nova11:01
tonybThat'd make detecting shared storage easier aswell11:03
*** ociuhandu has joined #openstack-nova11:03
*** RuiChen has quit IRC11:04
openstackgerritChung Chih, Hung proposed openstack/nova: Creating intance fail when inject ssh key in cells mode  https://review.openstack.org/19751411:04
*** IanGovett has joined #openstack-nova11:09
*** kylek3h has joined #openstack-nova11:10
*** abhishekk has quit IRC11:11
*** abhishekk has joined #openstack-nova11:12
*** mikeit has quit IRC11:14
*** ankit_ag has joined #openstack-nova11:14
*** kylek3h has quit IRC11:15
*** romainh has joined #openstack-nova11:15
*** ajayaa_ has quit IRC11:23
garykdanpb: can you please address the comments in https://review.openstack.org/#/c/188789/ - this has been blocked for quite some time11:24
*** matrohon has quit IRC11:27
*** matrohon has joined #openstack-nova11:28
*** Aless has joined #openstack-nova11:30
openstackgerritNikola Dipanov proposed openstack/nova: rt: generalize claim code to be useful for other move actions  https://review.openstack.org/19713811:30
openstackgerritNikola Dipanov proposed openstack/nova: compute: rename ResizeClaim to MoveClaim  https://review.openstack.org/19713711:30
openstackgerritNikola Dipanov proposed openstack/nova: tests: move a test to the proper class in test_resource_tracker  https://review.openstack.org/19752511:30
openstackgerritNikola Dipanov proposed openstack/nova: tests: Move test_resource_tracker to Instance objects  https://review.openstack.org/19752611:30
ndipanovdanpb, the bottom two are nice test clanups if you are looking for easy +2s ^^11:30
*** itzikb has joined #openstack-nova11:31
*** itzikb_ has quit IRC11:32
*** itzikb_ has joined #openstack-nova11:32
*** jasondotstar has quit IRC11:35
*** jasondotstar has joined #openstack-nova11:36
*** itzikb has quit IRC11:36
*** itzikb has joined #openstack-nova11:36
*** ajayaa_ has joined #openstack-nova11:39
*** kylek3h has joined #openstack-nova11:40
*** itzikb_ has quit IRC11:40
*** Marga_ has joined #openstack-nova11:40
*** itzikb_ has joined #openstack-nova11:40
*** jasondotstar has quit IRC11:41
*** jcoufal has quit IRC11:42
*** itzikb has quit IRC11:42
*** itzikb has joined #openstack-nova11:42
*** Marga_ has quit IRC11:43
*** annashen has joined #openstack-nova11:44
*** Marga_ has joined #openstack-nova11:44
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Enable python34 tests for nova/tests/unit/scheduler/test*.py  https://review.openstack.org/18796811:44
*** itzikb_ has quit IRC11:45
*** tobe has quit IRC11:46
*** marun has joined #openstack-nova11:46
*** piyanai has joined #openstack-nova11:47
*** annashen has quit IRC11:48
*** Jeffrey4l has quit IRC11:49
*** jcoufal has joined #openstack-nova11:49
*** jcoufal is now known as Guest5216811:50
*** Guest52168 has quit IRC11:50
*** jcoufal_ has joined #openstack-nova11:50
openstackgerritgaryk proposed openstack/nova: Compute: enable admin to decide action for conflicting states  https://review.openstack.org/19004711:51
*** marun has quit IRC11:52
*** deepthi has quit IRC11:52
andreykurilingaryk: hi! I understand that such requests are annoying, but can you review my spec related to novaclient support of microversions?11:53
*** xgsa1 has joined #openstack-nova11:55
*** tojuvone has quit IRC11:55
*** itzikb_ has joined #openstack-nova11:55
*** itzikb has quit IRC11:55
garykandreykurilin: sure. please post me the link11:58
*** Longgeek has quit IRC11:59
*** thorst has joined #openstack-nova12:01
*** itzikb has joined #openstack-nova12:02
*** sudipto has quit IRC12:02
*** _diana_ has joined #openstack-nova12:02
*** Jeffrey4l has joined #openstack-nova12:03
*** itzikb_ has quit IRC12:03
*** matrohon has quit IRC12:04
*** matrohon has joined #openstack-nova12:05
*** lpetrut has joined #openstack-nova12:05
openstackgerritJohn Garbutt proposed openstack/nova-specs: api: relax validation for unversioned requests  https://review.openstack.org/17324312:06
*** lyarwood has quit IRC12:07
*** lyarwood has joined #openstack-nova12:07
*** itzikb has quit IRC12:08
*** itzikb has joined #openstack-nova12:08
*** LukeHinds has joined #openstack-nova12:09
*** ociuhandu has quit IRC12:09
*** andreykurilin__ has joined #openstack-nova12:11
*** dave-mccowan has joined #openstack-nova12:13
*** Marga_ has quit IRC12:13
*** Marga__ has joined #openstack-nova12:13
*** markvoelker has quit IRC12:14
johnthetubaguyalaski: I updated the API spec to take into account your comments, I moved the controversial bit into the alternatives section for now: https://review.openstack.org/#/c/173243/17/specs/liberty/approved/api-relax-validation.rst,cm12:14
*** Marga__ has quit IRC12:14
*** markvoelker has joined #openstack-nova12:14
*** eharney has joined #openstack-nova12:14
danpbjohnthetubaguy: so do you think i should re-write my vif spec to just cover the initial proof of concept internal to nova  and the create a second backlog spec for turning that into a stable API ?12:15
*** Marga_ has joined #openstack-nova12:15
*** mpavone has quit IRC12:16
openstackgerritRong Han proposed openstack/nova: Catch NovaException from post_live_migration_at_destination, set instance vm_state error.  https://review.openstack.org/18663412:18
*** raginbajin has quit IRC12:18
*** _diana_ has quit IRC12:18
*** kiran-r has joined #openstack-nova12:18
*** _diana_ has joined #openstack-nova12:19
andreykurilin__garyk: it was approved while I was asking you about review:) but any way, thanks12:19
*** raginbajin has joined #openstack-nova12:19
*** ociuhandu has joined #openstack-nova12:21
*** jcoufal_ has quit IRC12:23
openstackgerritVictor Stinner proposed openstack/nova: Use oslo_utils instead of deprecated oslo.utils  https://review.openstack.org/19754612:23
openstackgerritVictor Stinner proposed openstack/nova: Close temporary files in virt/disk/test_api.py  https://review.openstack.org/19754712:23
*** heyongli has quit IRC12:24
*** Longgeek has joined #openstack-nova12:25
*** kylek3h has quit IRC12:26
*** heyongli has joined #openstack-nova12:27
sahidndipanov, johnthetubaguy i have updated the spec consoles-objects please let me know if that resolves your complaints https://review.openstack.org/#/c/165838/12:28
*** zigo has quit IRC12:28
_gryfhey, is there anything bad going on with the gates? I've got error on the gate-nova-python27 with the first of my patch in the set, but there is no error on the patch depended on it.12:28
*** mutoulbj has quit IRC12:28
_gryfand all unit tests are fine locally12:29
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/19432512:29
*** zigo has joined #openstack-nova12:29
*** mutoulbj has joined #openstack-nova12:29
*** itzikb has quit IRC12:29
*** mutoulbj has quit IRC12:30
*** rfolco has joined #openstack-nova12:30
*** aysyd has joined #openstack-nova12:30
*** mutoulbj has joined #openstack-nova12:30
*** mpavone has joined #openstack-nova12:31
*** Longgeek has quit IRC12:31
*** kiran-r has quit IRC12:32
*** nihilifer has quit IRC12:32
*** edmondsw has joined #openstack-nova12:32
openstackgerritNikola Dipanov proposed openstack/nova: rt: generalize claim code to be useful for other move actions  https://review.openstack.org/19713812:34
openstackgerritNikola Dipanov proposed openstack/nova: compute: rename ResizeClaim to MoveClaim  https://review.openstack.org/19713712:34
openstackgerritNikola Dipanov proposed openstack/nova: tests: move a test to the proper class in test_resource_tracker  https://review.openstack.org/19752512:34
openstackgerritNikola Dipanov proposed openstack/nova: tests: Move test_resource_tracker to Instance objects  https://review.openstack.org/19752612:34
*** RuiChen has joined #openstack-nova12:36
*** _diana_ has quit IRC12:36
*** annegentle has joined #openstack-nova12:37
*** tojuvone has joined #openstack-nova12:37
*** _gryf is now known as _gryf|afk12:37
*** ankit_ag has quit IRC12:38
*** rotbeard has joined #openstack-nova12:38
*** Aless has quit IRC12:39
*** tellesnobrega_ has joined #openstack-nova12:40
*** thangp has joined #openstack-nova12:42
*** RuiChen has quit IRC12:42
*** _diana_ has joined #openstack-nova12:43
garykndipanov: if you are looking for a no brainr review - https://review.openstack.org/19551812:43
*** baoli has joined #openstack-nova12:44
*** annashen has joined #openstack-nova12:45
*** rlrossit has joined #openstack-nova12:45
dimsgaryk: can you please bless this? (oslo.vmware) https://review.openstack.org/#/c/196408/12:46
*** tellesnobrega__ has joined #openstack-nova12:47
*** baoli_ has joined #openstack-nova12:48
*** annegentle has quit IRC12:48
*** annegentle has joined #openstack-nova12:49
*** tellesnobrega_ has quit IRC12:49
*** annashen has quit IRC12:49
*** Longgeek has joined #openstack-nova12:49
*** exploreshaifali has joined #openstack-nova12:50
*** baoli has quit IRC12:51
*** romainh has quit IRC12:53
*** gszasz has quit IRC12:54
openstackgerritAndrew Bogott proposed openstack/nova: Include project_id in instance metadata.  https://review.openstack.org/19718512:54
*** matrohon has quit IRC12:54
*** tellesnobrega__ has quit IRC12:55
*** matrohon has joined #openstack-nova12:55
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/19432512:56
*** annegentle has quit IRC12:57
*** ivasev has joined #openstack-nova12:58
*** annegentle has joined #openstack-nova12:58
*** RuiChen has joined #openstack-nova12:59
*** flip214 has quit IRC13:00
*** jecarey has joined #openstack-nova13:00
bauzasdanpb: I have a question re: https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L4713:02
RuiChenhi johnthetubaguy, can you take a look this spec https://review.openstack.org/#/c/169638/ ?13:02
bauzasdanpb: do you know the new attribute name ? can't find it :(13:02
RuiChenjohnthetubaguy, I think we don't need to modify many logic to implement it, just passthrough subnet_id into neutron create port api13:03
johnthetubaguyRuiChen: I voted on it this morning I think13:03
bauzasRuiChen: please provide your spec in https://etherpad.openstack.org/p/liberty-spec-freeze-exceptions13:03
johnthetubaguyand +1 to bauzas comment13:03
*** kbyrne has quit IRC13:03
RuiChenyeah, I had add it in the link13:03
openstackgerritsahid proposed openstack/nova: libvirt: rework membacking config to support future features  https://review.openstack.org/19756613:03
openstackgerritsahid proposed openstack/nova: libvirt: add cpu schedular priority config  https://review.openstack.org/19756713:03
openstackgerritsahid proposed openstack/nova: virt: add contraint to handle realtime policy  https://review.openstack.org/19756813:03
openstackgerritsahid proposed openstack/nova: libvirt: add realtime support  https://review.openstack.org/19756913:03
johnthetubaguyRuiChen the problem is any API change we have to live with for a _long_ time, so its a very high bar to change the API13:03
openstackgerritjaveme proposed openstack/nova: remove the method _set_vm_state in _live_migrate()  https://review.openstack.org/19757013:04
*** otter768 has joined #openstack-nova13:04
danpbbauzas: i believe we missed that in ImageObjectProps class13:04
bauzasdanpb: oh man... :(13:04
bauzasdanpb: I hate those dicts13:05
danpbindeed13:05
bauzasdanpb: I have the same problem with filt_props13:05
danpbwe do however have a HVTypeField() already defined as an enum13:06
danpbso we just need to add an  hw_hv_type  property of type HVTypeField13:06
danpbwhat is filt_props ??13:06
bauzasdanpb: filter_properties, ugly dict for the scheduler13:06
danpboh right13:07
bauzasdanpb: ok, do you want me to bump a new version for the ImageProps ?13:07
RuiChenjohnthetubaguy, yes, so I hope some API group guys can review it.13:07
bauzasdanpb: I can put it in the bottom of my series13:07
danpbbauzas: sure, go for it13:07
bauzasdanpb: okay13:08
bauzasI need a rebase anyway...13:08
*** otter768 has quit IRC13:09
*** heyongli has quit IRC13:09
bauzasdanpb: while you're here, look at https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L7613:12
bauzasdanpb: same problem here :(13:12
bauzasdanpb: so I'll provide an Integer() for it13:12
bauzasor a Float even, need to compare with the ComputeNode field13:13
johnthetubaguyRuiChen: as I said on the review, I think we need people to start forming a full plan for the networking APIs, once thats in place, it will be much clearer about what we should do13:13
bauzasdanpb: mmm, IntegerField() in ComputeNode13:13
*** heyongli has joined #openstack-nova13:13
alex_xudanpb: would you like take a look at https://review.openstack.org/168982 before your holiday? I'm not sure I can get exception for it, but I will give a try. thanks in advance13:13
*** yingjun has joined #openstack-nova13:14
*** Longgeek has quit IRC13:14
*** Longgeek has joined #openstack-nova13:14
danpbbauzas: sigh, so many utterly insane image properties13:15
*** romainh has joined #openstack-nova13:15
bauzasdanpb: yup, we need to pay the debt13:15
RuiChenjohnthetubaguy, you means the spec should been delay until the networking plan more clear?13:15
bauzasdanpb: even if someone else left us a debt13:15
danpbbauzas: i'm inclear if that image prop actually takes a number, or a dotted decimal string ?13:15
danpbideally i think it would be a dotted decimal string13:16
bauzasdanpb: by looking at the filter, it basically matches the number with the one given by the host13:16
johnthetubaguyRuiChen: since there are one two or three weeks left to get all the code up for review, that seems like the best trade off at this point13:16
danpbas that's far more friendly that expecting the user to convert a x.y.z number into  x << 16 | y << 8 | z13:16
danpbso i'd be inclined to subclass  IntegerField and adding a VersionField() which accepts a dotted decimal string and converts it to an integer13:16
*** rajesht_ has joined #openstack-nova13:17
*** mmedvede has joined #openstack-nova13:17
bauzasdanpb: mmm13:17
bauzasdanpb: it uses the VersionPredicate stuff for comparing13:18
*** heyongli has quit IRC13:18
RuiChenjohnthetubaguy, all the code about this spec is ready for reveiwing, I means if the spec can be approved https://review.openstack.org/#/q/status:open+branch:master+topic:bp/selecting-subnet-when-creating-vm,n,z13:19
*** ijuwang has joined #openstack-nova13:19
andreykurilinjohnthetubaguy: thanks for approving spec13:19
*** ociuhandu has quit IRC13:19
johnthetubaguyRuiChen: hmm, OK, although we still need to agree the future direction there, the cost of merging the wrong API is very high13:20
*** ociuhandu has joined #openstack-nova13:20
johnthetubaguyRuiChen: this is something I really want to be a priority in M, not sure if others will agree, but I want to see v2.1 usable before we focus on these kinds of changes13:20
andreykurilinmelwitt: hi! can you remove your -2 for https://review.openstack.org/#/c/152569/ , since spec is already approved?13:21
*** rajesht has quit IRC13:21
johnthetubaguyRuiChen: right now, we need a good plan for the network API that we can start getting folks to think about, so we would be ready to implement in M, at least thats where I am thinking right now13:21
*** matrohon has quit IRC13:21
*** heyongli has joined #openstack-nova13:21
johnthetubaguyandreykurilin: I probably need to approve the blueprint now the spec is merged, I will try get to that ASAP13:21
andreykurilinjohnthetubaguy: https://blueprints.launchpad.net/python-novaclient/+spec/api-microversion-support13:22
*** kbyrne has joined #openstack-nova13:22
*** matrohon has joined #openstack-nova13:22
johnthetubaguyandreykurilin: I generally wait till it gets published here: http://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/13:22
*** lucas-bbl is now known as lucasagomes13:22
andreykurilinjohnthetubaguy: ok, got it.13:22
johnthetubaguyandreykurilin: it shouldn't be too much longer now13:23
*** Piet has quit IRC13:23
andreykurilinjohnthetubaguy: :) thanks13:23
johnthetubaguyalex_xu: that cpu spec probably wants to be on the exception request list I assume? https://etherpad.openstack.org/p/liberty-spec-freeze-exceptions13:24
*** nihilifer has joined #openstack-nova13:24
alex_xujohnthetubaguy: yea, I put that in the etherpad already13:24
RuiChenjohnthetubaguy, ok, thank you, maybe it's not a good time to implement it now, i hope i can merge it in M, please think about this spec when we do the networking API plan13:25
*** coolsvap is now known as coolsvap|away13:26
*** ociuhandu has quit IRC13:27
johnthetubaguyRuiChen: it would be great if you can help write that13:27
*** mriedem has joined #openstack-nova13:27
johnthetubaguyalex_xu: ah, sorry, I didn't see it yet I guess13:27
alex_xuandreykurilin: congratulation :) let's move focus on patch13:27
alex_xujohnthetubaguy: np, thanks for the reminder!13:27
RuiChenjohnthetubaguy, yeah i can try my best13:28
*** browne has joined #openstack-nova13:28
*** xgsa has quit IRC13:29
andreykurilinalex_xu: thanks! as far as I understand, the main discussion will be at https://review.openstack.org/#/c/184281/ :) what about the first patches and support of 2.2 microversion?13:29
alex_xuandreykurilin: yea, I still think that isn't right, we should treat microversion as global version. I will move my comment to that patch :)13:30
*** jcoufal has joined #openstack-nova13:30
*** ociuhandu has joined #openstack-nova13:30
*** irenab has quit IRC13:32
mriedemanyone else noticing an uptick in failed turbo-hipster runs?13:33
mriedemon non-db related changes13:33
mriedemjhesketh: ^13:33
mriedemalso, logs aren't pointing to the failed runs13:33
*** jcoufal has quit IRC13:33
mriedemlike here https://review.openstack.org/#/c/197208/13:33
*** rlrossit has left #openstack-nova13:33
*** ctrath has joined #openstack-nova13:34
jheskethmriedem: I'll take a look13:34
jheskethmriedem: do you have other examples?13:34
mriedemjhesketh: i saw one yesterday but at this point i'd be lost trying to find it13:34
jheskethokay I'll take a look13:34
*** marun has joined #openstack-nova13:35
*** jcoufal has joined #openstack-nova13:35
*** xgsa has joined #openstack-nova13:36
*** Jeffrey4l has quit IRC13:36
jheskethmriedem: could be noisy neighbours or something causing the timing of the jobs to be wrong13:36
jheskethmy scraping tool finds 6 failed th runs13:37
*** lucas__ has joined #openstack-nova13:37
*** heyongli has quit IRC13:37
mriedemok, i guess i just got 2 of those :) i'm lucky13:37
*** abhishekk has quit IRC13:38
jheskethmriedem: heh, I'll shoot off a recheck on those and given that it's late I'll turn negative voting off over night and check closer tomorrow13:38
dansmithjhesketh: hey, can we change the timing requirements for just nova migrations?13:38
dansmithjhesketh: like, say that they have to complete in 10 seconds...13:39
ctrathmriedem: I looked at https://bugs.launchpad.net/nova/+bug/1186354 .. Do we want to just throw an exception in the limits methods if the request was made from neutron?13:39
openstackLaunchpad bug 1186354 in OpenStack Compute (nova) "Limits API doesn't work with Neutron" [Medium,Confirmed] - Assigned to Cale Rath (ctrath)13:39
mriedemctrath: yes13:39
mriedemctrath: a 40013:39
jheskethdansmith: the default migration timeout on our large dataset sample is 60 seconds13:39
ctrathmriedem: ok.. good enough.  thanks13:39
*** mpavone has quit IRC13:40
jheskethdansmith: these are adjustable though13:40
*** baoli_ has quit IRC13:40
*** marun has quit IRC13:40
dansmithjhesketh: I'd like us to cut that down to as low as possible to catch migrations trying to touch data13:40
*** heyongli has joined #openstack-nova13:40
dansmithjhesketh: do you think that's doable or likely to be too sensitive?13:40
mriedemgreat, i just hit this fixed ip allocation race in n-net again even after we thought we narrowed that race down13:41
*** READ10 has joined #openstack-nova13:41
jheskethdansmith: it's quite crude in that it just watches the time it takes between two migrations13:41
*** lucas__ has quit IRC13:41
jheskethwhich means it's subject to a lot of conditions on the host13:41
jheskethwe do what we can to isolate it, but these recent failures are likely an example of that failing13:41
*** ZZelle has quit IRC13:42
dansmithhmm, okay13:42
*** lucas__ has joined #openstack-nova13:42
jheskethdansmith: we also measure innodb rows read and rows changed, but those defaults are quite high13:42
*** ZZelle has joined #openstack-nova13:42
dansmithjhesketh: but those numbers would be high even for a legit schema-only change?13:42
jheskethdansmith: right13:43
jheskethoh you mean where the rows aren't modified13:43
jheskethno, they shouldn't need to be high13:43
openstackgerritMatthew Gilliard proposed openstack/nova: WIP: Define system_family for libvirt guests  https://review.openstack.org/19713213:43
dansmithjhesketh: even if we make something nullable or change a default or something?13:44
jheskethI'd have to check what MySQL does sorry13:44
dansmithokay13:44
dansmithwell, if that's doable, we should cut that down super low to catch anything doing data manipulation13:44
jheskethdansmith: what about a 1st party non-voting (ie advisory) job that introspecs the migration to see what operations are being done and gives a warning if it'd modify production data13:44
*** baoli has joined #openstack-nova13:44
*** mpavone has joined #openstack-nova13:45
jheskethif you want to catch anything that modifies data, that could be done as a 1st party test... turbo-hipster just needs to catch pain points for operators13:45
dansmithjhesketh: well, I was looking at our test_migrations to see if I could reasonably do something like that13:45
*** annashen has joined #openstack-nova13:45
dansmithjhesketh: sure, if it's easily doable13:46
dansmithjhesketh: https://review.openstack.org/#/c/197349/13:46
dansmithjhesketh: I guess I should be able to mock insert, update, and delete, huh?13:46
*** Dev_Jin has quit IRC13:46
*** dbite has quit IRC13:46
jheskethdansmith: that's probably going to give you better control than th13:47
dansmithokay13:47
dansmithI'm just used to th being the thing we use to ensure well-behaved migrations :)13:47
jheskethI'm glad :-)13:48
dansmithheh13:48
jheskethdansmith: is wanting to lock down modifying changes a result of something bad getting past?13:49
jheskethor is it just to make people think twice before doing it (ie exceptions are still made)13:49
*** Jeffrey4l has joined #openstack-nova13:49
dansmithjhesketh: no, it's a result our upgrade strategy and our desire to be able to apply the schema quickly and firstly13:49
dansmithand of course, the long-term of not having migrations at all13:50
dansmithi.e. the online schema changes work13:50
*** annashen has quit IRC13:50
*** rlrossit has joined #openstack-nova13:50
kashyapWould be nice if a different pair of eyes could review this non-invasive backport: https://review.openstack.org/#/c/193497 -- "libvirt: handle code=38 + sigkill (ebusy) in destroy()"13:50
jheskethdansmith: okay cool :-)13:51
*** ociuhandu has quit IRC13:51
*** ociuhandu has joined #openstack-nova13:53
openstackgerritsahid proposed openstack/nova: libvirt: add cpu schedular priority config  https://review.openstack.org/19756713:53
openstackgerritsahid proposed openstack/nova: libvirt: rework membacking config to support future features  https://review.openstack.org/19756613:53
openstackgerritsahid proposed openstack/nova: virt: add contraint to handle realtime policy  https://review.openstack.org/19756813:53
openstackgerritsahid proposed openstack/nova: libvirt: add realtime support  https://review.openstack.org/19756913:53
*** dboik has joined #openstack-nova13:54
*** dboik has quit IRC13:55
*** dboik has joined #openstack-nova13:55
*** gokrokve has joined #openstack-nova13:56
*** jcoufal has quit IRC13:56
*** zzzeek has joined #openstack-nova13:56
*** jcoufal has joined #openstack-nova13:57
*** ctrath has quit IRC13:57
*** kiran-r has joined #openstack-nova13:58
*** jcoufal has quit IRC13:58
*** dane-fichter has joined #openstack-nova13:58
mriedemtonyb: whatever happened with the infinite recursion issue?13:59
*** dims has quit IRC13:59
*** jcoufal has joined #openstack-nova14:00
*** _diana_ has quit IRC14:00
*** dims has joined #openstack-nova14:00
*** mtanino has joined #openstack-nova14:02
*** subscope has quit IRC14:03
*** exploreshaifali has quit IRC14:03
dansmithmriedem: do you have the logstash query to see if it kept happening??14:05
*** ctrath has joined #openstack-nova14:05
dansmither, s/??/?14:05
mriedemdansmith: yeah sec14:06
mriedemheh, yeah, it's happening14:07
mriedemhttp://goo.gl/TtN8mI14:07
*** Murali has quit IRC14:07
*** kiran-r has quit IRC14:07
*** lpetrut has quit IRC14:07
*** RuiChen has quit IRC14:08
*** joshw42 has quit IRC14:08
mriedemhere is the bug that tonyb opened https://bugs.launchpad.net/nova/+bug/147030214:08
openstackLaunchpad bug 1470302 in OpenStack Compute (nova) "gate-nova-python27 fails with "RuntimeError: maximum recursion depth exceeded"" [Undecided,New]14:08
dansmithhrm, yeah14:08
dansmithlet me see if I can get it to happen locally with a few runs14:08
*** lpetrut has joined #openstack-nova14:09
*** piyanai has quit IRC14:09
*** jcoufal has quit IRC14:11
*** raildo has quit IRC14:12
*** burt has joined #openstack-nova14:12
*** jcoufal has joined #openstack-nova14:13
openstackgerritJay Pipes proposed openstack/nova: Refactor unit test for InstanceGroup objects  https://review.openstack.org/19722814:14
*** zhenguo has joined #openstack-nova14:14
jaypipesgaryk: ^^ addressed your concerns. thanks muchfor the review!14:14
*** tjones1 has joined #openstack-nova14:14
jaypipesalex_xu: ping. can we talk about the monitor plugin interface, please?14:14
*** kiran-r has joined #openstack-nova14:14
alex_xujaypipes: yea, sure14:14
openstackgerritVictor Stinner proposed openstack/nova: Replace parse_strtime() with parse_isotime()  https://review.openstack.org/19760114:14
*** piyanai has joined #openstack-nova14:15
*** matrohon has quit IRC14:15
*** piyanai has quit IRC14:15
*** raildo has joined #openstack-nova14:15
dansmithmriedem: yeah, see there is a limit there to avoid recursion.. "if obj_name in tree"14:15
rlrossitdansmith: is changing child_versions->obj_relationships on all of the list objects a change to how these will get passed over RPC (meaning, do I have to update the versions on all of these list objects)? (https://bugs.launchpad.net/nova/+bug/1470154)14:15
openstackLaunchpad bug 1470154 in OpenStack Compute (nova) "List objects should use obj_relationships" [Low,Confirmed] - Assigned to Ryan Rossiter (rlrossit)14:15
openstackgerritBaodong (Robert) Li proposed openstack/nova: Handle port delete initiated by neutron  https://review.openstack.org/17939014:15
alex_xujaypipes: I still didn't get the strong reason to disable user create new type prviate monitor, and in nova code we didn't have any code depend on specific metric key name14:16
*** matrohon has joined #openstack-nova14:16
dansmithrlrossit: nope, that's local only, so no version change required14:16
rlrossitdansmith: ok, so I'll just have to update the hashes in the unit tests then14:16
jaypipesalex_xu: OK, so the idea is that plugin developers should feel free to implement a plugin that returns a specific set of monitor metrics in any way they choose. For instance, if I wanted to create a plugin that used Nagios to query the CPU stats instead of using the virt driver's get_host_cpu_stats() call, I could do that. But, I'm a strong -1 on having plugins just able to invent their own metric names, because there14:16
jaypipeswould be no way to standardize those metric names.14:16
dansmithyep14:16
rlrossitwell there are a few that have stale object versions, so those need to get updated14:16
dansmithjaypipes: +2 on your -114:16
dansmithrlrossit: yeah14:17
jaypipesalex_xu: I realize that the current MetricsWeigher doesn't depend on a particular string key.14:17
rlrossitcool. I kinda feel like I know what I'm doing. or at least I can start faking it soon14:17
jaypipesalex_xu: and that it just allows any old random key/value to be set in the weigher_setting CONF setting.14:17
dansmithrlrossit: cool :)14:18
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/19432514:18
*** apuimedo_ has quit IRC14:18
jaypipesalex_xu: however, the idea from sudipta and others is to create new weigher classes that actually understand what the specific metrics are and make more intelligent decisions that what is possible with something like weigher_setting = cpu.frequency=1.0,cpu.idle.time=1014:18
garykjaypipes: thanks14:19
jaypipesalex_xu: and if there is no standardization of those metric names, it's going to be REALLY difficult to implement those advanced weighers if you can't count on the names of the metrics being codified.14:19
jaypipesalex_xu: does that make a little more sense?14:19
alex_xujaypipes: emm...if there are someone really want to depend on specific metric key to coding something, that make sense to me14:20
jaypipesalex_xu: https://blueprints.launchpad.net/nova/+spec/filter-mem-bw14:21
jaypipesalex_xu: that's one example.14:21
*** Jeffrey4l has quit IRC14:22
alex_xujaypipes: it just add new type metric? or I misunderstood14:22
openstackgerritMatt Riedemann proposed openstack/nova: n-net: add more debug logging to release_fixed_ip  https://review.openstack.org/19760814:22
jaypipesalex_xu: https://blueprints.launchpad.net/nova/+spec/add-utilization-based-weighers is another example.14:22
*** heyongli has quit IRC14:22
bauzasjaypipes: I don't have the whole context, so sorry if I'm missing something, but I'm -1 on in-tree monitors possibly providing metrics from elsewhere than just the virt driver14:23
jaypipesalex_xu: the memory bandwidth one would add a new base type of monitor plugin for bandwidth statistics, yes. and the plugins can implement the gathering of that information in any way they see fit.14:23
jaypipesbauzas: who said it would be in-tree? :)14:24
bauzasjaypipes: nah, was just making sure that we're sync14:24
*** jcoufal has quit IRC14:24
bauzasjaypipes: I need to review your bug series14:24
jaypipesbauzas: with the changes to use stevedore for the loading of the extensions, out-of-tree plugins are completely possible.14:24
*** heyongli has joined #openstack-nova14:24
bauzasjaypipes: totall14:24
bauzastotally even14:24
jaypipesalex_xu: and another one: https://blueprints.launchpad.net/nova/+spec/node-cached-image-weigher14:25
bauzasjaypipes: my point was just saying "please use the virt interface for getting the metrics or leave your monitor out-of-tree" :)14:25
*** jcoufal has joined #openstack-nova14:25
bauzasjaypipes: could you please give me again your series so I can star them ?14:26
jaypipesbauzas: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1468012,n,z14:27
bauzasjaypipes: coolio, thanks14:27
dansmithmriedem: I found the problem14:27
mriedemorly14:28
dansmithmriedem: yeah, the problem is I'm a giant drooling idiot14:28
mriedemwell that's not so bad14:29
openstackgerritVictor Stinner proposed openstack/nova: Replace parse_strtime() with parse_isotime()  https://review.openstack.org/19760114:29
*** tonytan4ever has joined #openstack-nova14:30
openstackgerritDan Smith proposed openstack/nova: Avoid recursion in object relationships test  https://review.openstack.org/19761114:32
dansmithmriedem: ^14:32
*** zz_jgrimm is now known as jgrimm14:32
alex_xujaypipes: ok, so any data expose to scheduler from compute node is part of contract.14:32
jaypipesalex_xu: yes.14:32
mriedemkashyap: reviewed your backport, one little issue in one of the tests14:33
*** igordcard_ has quit IRC14:33
alex_xujaypipes: ok, thanks for the explanation, I think I see now.14:34
*** heyongli has quit IRC14:35
alex_xujaypipes: that also help us ensure all the hypervisors expose same data out, like we treat other data from RT.14:35
jaypipesalex_xu: ++ exactly.14:36
jaypipesalso see lianhao lu's spec about exposing the metric names in the REST API...14:36
*** matrohon has quit IRC14:36
mriedemdansmith: reviewing14:36
*** yamahata has joined #openstack-nova14:37
*** ociuhandu_ has joined #openstack-nova14:37
*** jwang__ has joined #openstack-nova14:37
*** andreykurilin__ has quit IRC14:37
*** heyongli has joined #openstack-nova14:37
*** nagyz_ has joined #openstack-nova14:37
*** matrohon has joined #openstack-nova14:38
*** matrohon has quit IRC14:38
*** matrohon has joined #openstack-nova14:39
*** kiran-r has quit IRC14:40
*** xgsa2 has joined #openstack-nova14:40
*** Longgeek has quit IRC14:40
*** kudryashova_ has joined #openstack-nova14:41
*** devanand1 has joined #openstack-nova14:41
*** Nakato_ has joined #openstack-nova14:41
*** s1rp_ has joined #openstack-nova14:41
*** doude_ has joined #openstack-nova14:41
*** nikhil_k1away has joined #openstack-nova14:42
*** mpavone has quit IRC14:42
mriedemdansmith: +2 with comments14:42
mriedemjaypipes: do it to it https://review.openstack.org/#/c/197611/14:42
dansmithmriedem: yep, thanks14:42
*** Kevin_Zheng has quit IRC14:43
*** Kevin_Zheng has joined #openstack-nova14:43
rlrossitmriedem: dansmith: are circular dependencies in objects not a bad thing? because this recursion will only fail when we have a circular dependency right?14:44
rlrossit"fail" meaning infinitely recurse14:44
mriedemhonestly i'm not sure how this isn't failing all the time14:44
dansmithrlrossit: circular deps are a bad thing, IMHO, yes, but we have one14:44
jaypipesmriedem: done.14:44
*** angular_mike__ has joined #openstack-nova14:44
rlrossitagreed mriedem14:44
mriedemi guess it's the order that it pulls things out of the registry for processing14:45
dansmithmriedem: it shouldn't fail because it checks to see if obj_name is already in the tree14:45
mriedemyeah14:45
*** adreznec has joined #openstack-nova14:45
*** mtreinish_ has joined #openstack-nova14:45
dansmiththe reason it does I think is because we call build_tree before we do tree.setdefault()14:45
*** EmilienM_ has joined #openstack-nova14:45
*** vish1 has joined #openstack-nova14:45
dansmithso if you process the loop in the right order, you'll hit this14:45
*** dgonzalez_ has joined #openstack-nova14:45
mriedemif we sorted somewhere in here it'd be more deterministic14:45
mriedems/more//14:45
mriedembut anyway, we don't need to recurse so just avoid it14:45
dansmithwell, not doing the recursion makes it better anyway14:46
dansmithyeah14:46
*** mrodden_ has joined #openstack-nova14:46
*** melwitt_ has joined #openstack-nova14:46
*** tjones1 has quit IRC14:46
rlrossitis long term solution get rid of the circular dependency? because to me this getting rid of recursion is just a bandaid14:46
dansmithit's not a bandaid14:46
*** ociuhandu has quit IRC14:46
*** xgsa has quit IRC14:46
*** aysyd has quit IRC14:46
*** doude has quit IRC14:46
*** pkholkin has quit IRC14:46
*** mtreinish has quit IRC14:46
*** kudryashova has quit IRC14:46
*** rushiagr_away has quit IRC14:46
*** melwitt has quit IRC14:46
*** angular_mike_ has quit IRC14:46
*** jwang_ has quit IRC14:46
*** EmilienM has quit IRC14:46
*** adreznec_ has quit IRC14:46
*** rpodolyaka has quit IRC14:46
*** nagyz has quit IRC14:46
*** rex_lee has quit IRC14:46
*** kun_huang has quit IRC14:46
*** aweeks has quit IRC14:46
*** devananda has quit IRC14:46
*** flaper87 has quit IRC14:46
*** lxsli has quit IRC14:46
*** mrodden has quit IRC14:46
*** Nakato has quit IRC14:46
*** s1rp has quit IRC14:46
*** dgonzalez has quit IRC14:46
*** vishy has quit IRC14:46
*** nikhil_k-away has quit IRC14:46
*** EmilienM_ is now known as EmilienM14:46
*** vish1 is now known as vishy14:46
*** strictlyb is now known as sb14:46
*** ociuhandu_ is now known as ociuhandu14:46
dansmithgetting rid of the loop we have now is hard14:46
*** mtreinish_ is now known as mtreinish14:46
*** mrodden_ is now known as mrodden14:46
*** dgonzalez_ is now known as dgonzalez14:46
*** annashen has joined #openstack-nova14:46
*** annegentle has quit IRC14:47
mriedemrlrossit: the recursion in the test wasn't necessary, it was redundant14:47
mriedemso was just a latent bug that wasn't exposed until your change14:47
*** Marga_ has quit IRC14:47
*** nkrinner has quit IRC14:47
*** rpodolyaka has joined #openstack-nova14:47
rlrossityeah agreed but it (intermittently) showed a circular dependency, which if we are stuck with the circular dependency, then yeah that solves everything14:48
*** nelsnels_ has quit IRC14:49
rlrossitmy limited software experience says circular dependencies are bad :)14:49
*** flaper87 has joined #openstack-nova14:49
*** flaper87 has quit IRC14:49
*** flaper87 has joined #openstack-nova14:49
mriedemi for one have always appreciated the joy that circular dependencies bring to my life14:49
*** nelsnelson has joined #openstack-nova14:49
mriedemparticularly when my previous project was related to delivering software updates14:49
*** heyongli has quit IRC14:49
*** _diana_ has joined #openstack-nova14:50
dansmithit's really only a circular dependency if you assume the theoretical case,14:50
*** sb has quit IRC14:51
dansmithwhich we don't have in production, which is why this isn't a problem14:51
*** kiran-r has joined #openstack-nova14:51
dansmithbut the test was very academic, of course14:51
*** yassine__ has quit IRC14:51
*** annashen has quit IRC14:51
dansmithI'd prefer we didn't have the loop we have, but it was added for a reason and that reason is performance, so..14:51
* mriedem writes that down for when it is a problem in production14:51
*** strictlyb has joined #openstack-nova14:51
dansmithall statements apply to git hash e4e16e9077b5e78f809c6c634153fa62a5facb16 only :P14:52
dansmithso, write that down too :P14:52
jaypipesbauzas: https://review.openstack.org/#/c/179224/ reviewed. I have a suggestion to make the wording and proposed REST API changes simpler.14:52
mriedemsorry, my buffer is full14:52
*** aysyd has joined #openstack-nova14:52
*** aweeks has joined #openstack-nova14:52
*** heyongli has joined #openstack-nova14:52
bauzasjaypipes: oh great14:53
*** matrohon has quit IRC14:53
*** matrohon has joined #openstack-nova14:53
bauzasjaypipes: evacuate is no longer accepted ? I missed the convo14:53
*** pkholkin has joined #openstack-nova14:53
*** lxsli has joined #openstack-nova14:53
bauzasjaypipes: I mean, do we plan to change the API resource name ?14:53
jaypipesbauzas: hmm? no, I mean the actual method call is called rebuild_instance() in the conductor :)14:53
bauzasjaypipes: oh, correctr14:54
bauzasjaypipes: I was lazy14:54
bauzasjaypipes: agreed with your REST API comment, just one clarification14:55
bauzasjaypipes: 1/ no host provided => call the sched, ack14:56
bauzasjaypipes: 2/ host provided, if --force, no calling the sched, ack14:56
bauzasjaypipes: 3/ host provided, if not --force then serve a HTTP 409 ?14:56
bauzasright?14:56
*** danpb has quit IRC14:56
jaypipesbauzas: zactly.14:56
bauzasack14:56
bauzasok, will change14:57
jaypipessahid: see my request on https://review.openstack.org/#/c/190962/...14:57
*** danpb has joined #openstack-nova14:57
*** irenab has joined #openstack-nova14:57
*** subscope has joined #openstack-nova14:57
*** heyongli has quit IRC14:57
*** heyongli has joined #openstack-nova14:59
*** kun_huang has joined #openstack-nova14:59
*** angular_mike__ is now known as angular_mike_15:00
*** devanand1 is now known as devananda15:01
*** xyang1 has joined #openstack-nova15:02
*** Marga_ has joined #openstack-nova15:02
*** derekh has joined #openstack-nova15:03
*** yingjun has quit IRC15:04
*** rex_lee has joined #openstack-nova15:05
*** otter768 has joined #openstack-nova15:05
*** ajayaa_ has quit IRC15:07
*** Longgeek has joined #openstack-nova15:07
*** Jeffrey4l has joined #openstack-nova15:07
*** lucas__ has quit IRC15:07
*** Longgeek has quit IRC15:07
*** mmedvede has quit IRC15:08
*** Longgeek has joined #openstack-nova15:08
*** jlanoux_ has joined #openstack-nova15:08
*** jlanoux has quit IRC15:09
*** otter768 has quit IRC15:10
*** belmoreira has quit IRC15:10
*** yingjun has joined #openstack-nova15:10
*** Longgeek has quit IRC15:12
mriedemdansmith: i'm hitting something in the test_relationships test that i'm not seeing the issue, http://paste.openstack.org/show/332379/ for change https://review.openstack.org/#/c/197208/1/nova/objects/block_device.py15:12
mriedemi have the bdm and bdmlist versions bumped15:12
mriedemi'm not sure why fixedip/instance are listed there15:13
*** agireud has joined #openstack-nova15:13
mriedembdm is the parent of instance, but i don't need to bump the version on instance b/c bdm changes, right?15:13
mriedemoh sec, probably b/c i rebased and picked up https://review.openstack.org/#/c/197176/2/nova/tests/unit/objects/test_objects.py but didn't change that value15:14
dansmiththey're not telling you to change them right?15:14
*** Longgeek has joined #openstack-nova15:14
mriedemgot it, i didn't bump the version in the object_relationships map after rebased in https://review.openstack.org/#/c/197176/2/nova/tests/unit/objects/test_objects.py15:15
*** piyanai has joined #openstack-nova15:15
mriedemwell it says, "Some objects have changed dependencies. Please make sure to bump the versions of parent objects and provide a rule in their obj_make_compatible() routines to backlevel the child object. "15:15
dansmithright, and it is trying to show you just the changes15:16
mriedemit should probably also say, make sure you update the versions in the object_relationships map too15:16
dansmithI just don't see the changes15:16
*** piyanai has quit IRC15:16
dansmithbut I'm distracted15:16
mriedemthe object_relationships map in the test had this due to rlrossit's change yesterday: 'BlockDeviceMappingList': {'BlockDeviceMapping': '1.9'},15:16
mriedemthat 1.9 needs to be a 1.10 from my change15:16
mriedemthe error message in the test misled me15:16
mriedemso, i'll push a change to add some extra wording in that message15:17
dansmithokay15:17
mriedemyou can review when the price is right is over15:17
dansmithheh15:17
openstackgerritDan Smith proposed openstack/nova: Make evacuate update the migration object along the way  https://review.openstack.org/19437315:18
openstackgerritDan Smith proposed openstack/nova: Add some notifications to the evacuate path  https://review.openstack.org/19437215:18
openstackgerritDan Smith proposed openstack/nova: Make evacuate leave a record for the source compute host to process  https://review.openstack.org/18335415:18
*** kodoku has joined #openstack-nova15:19
*** lucas__ has joined #openstack-nova15:22
*** armax has joined #openstack-nova15:22
ndipanovdansmith, you might like this one https://review.openstack.org/#/c/197526/ (and the one before)15:22
*** unicell has joined #openstack-nova15:23
dansmithndipanov: ah, yep, I actually have a change just like that queued up15:24
* dansmith deletes15:24
*** Sukhdev has joined #openstack-nova15:24
*** afazekas has quit IRC15:26
*** scheuran has quit IRC15:26
*** Jeffrey4l has quit IRC15:26
*** piyanai has joined #openstack-nova15:26
*** lucas__ has quit IRC15:27
*** rajesht_ has quit IRC15:28
*** Jeffrey4l has joined #openstack-nova15:28
dansmithmriedem: so how come jenkins didn't fail that test?15:28
mriedemdansmith: in the gate?15:29
mriedemno idea15:29
dansmithyeah15:29
dansmithkinda concerning..15:29
mriedemyeah15:29
mriedemi'd ask sdague if he was around15:29
*** CaerbannogRabbit is now known as morganfainberg15:30
*** gszasz has joined #openstack-nova15:30
*** root has joined #openstack-nova15:30
*** root is now known as Guest5055315:31
*** Guest50553 has left #openstack-nova15:31
*** Jeffrey4l has quit IRC15:31
*** lyarwood has quit IRC15:32
*** marun has joined #openstack-nova15:32
mriedemkanboard is pretty full of itself: http://kanboard.net/15:32
mriedemi mean sure, if you don't want to do things the right way, go ahead15:32
*** lyarwood has joined #openstack-nova15:33
*** coolsvap|away is now known as coolsvap15:33
dansmith...random...15:33
mriedemi'm getting kanboard from every directio nthis week15:33
mriedemand i thought "Kanboard is not for everybody, it's made for people who want to manage their projects efficiently and simply." was funny15:34
dansmithheh15:34
*** mmedvede has joined #openstack-nova15:34
dansmithhe puts "improve docs" on the backlog, so you could certainly fire back something for that15:34
dimsbig mistake if you don't use it :)15:34
*** kfox1111_away is now known as kfox111115:35
*** tsekiyama has joined #openstack-nova15:36
*** jaypipes has quit IRC15:37
*** kodoku has quit IRC15:37
*** unicell has quit IRC15:39
*** root____ has joined #openstack-nova15:40
*** root____ is now known as Jeffrey4l15:40
mriedemdims: i think i'll survive15:41
*** Marga_ has quit IRC15:41
*** yingjun has quit IRC15:42
*** ddaskal has joined #openstack-nova15:42
*** lucas__ has joined #openstack-nova15:44
*** coolsvap is now known as coolsvap|away15:44
*** piyanai has quit IRC15:45
openstackgerritVictor Stinner proposed openstack/nova: Close temporary files in virt/disk/test_api.py  https://review.openstack.org/19754715:45
openstackgerritMatt Riedemann proposed openstack/nova: Add BlockDeviceType enum field  https://review.openstack.org/19723715:46
openstackgerritMatt Riedemann proposed openstack/nova: Add BlockDeviceDestinationType enum field  https://review.openstack.org/19722315:46
openstackgerritMatt Riedemann proposed openstack/nova: Add BlockDeviceSourceType enum field  https://review.openstack.org/19720815:46
*** annashen has joined #openstack-nova15:47
*** lucas__ has quit IRC15:48
*** ajayaa_ has joined #openstack-nova15:48
*** lucas__ has joined #openstack-nova15:48
*** kiran-r has quit IRC15:48
*** piyanai has joined #openstack-nova15:49
*** annashen has quit IRC15:52
*** Jeffrey4l has quit IRC15:53
*** Jeffrey4l has joined #openstack-nova15:53
*** tojuvone has quit IRC15:53
*** Jeffrey4l has quit IRC15:54
*** hemnafk is now known as hemna15:55
*** patrickeast has joined #openstack-nova15:55
*** irenab has quit IRC15:57
*** flip214 has joined #openstack-nova15:57
*** erlon has joined #openstack-nova15:57
*** busterswt has joined #openstack-nova15:58
*** irenab has joined #openstack-nova15:59
*** sudipto has joined #openstack-nova16:00
*** armax has quit IRC16:00
*** Jeffrey4l has joined #openstack-nova16:01
*** lpetrut has quit IRC16:04
*** lpetrut has joined #openstack-nova16:05
*** lpetrut has quit IRC16:05
*** _diana_ has quit IRC16:06
*** Longgeek has quit IRC16:06
*** _diana_ has joined #openstack-nova16:07
*** tjones1 has joined #openstack-nova16:07
*** _diana_ has quit IRC16:07
*** Longgeek has joined #openstack-nova16:08
*** jistr has quit IRC16:08
rlrossitmriedem: possibly stupid question... but why are (some of) my unit tests running twice in debug mode? They pass on the first and fail on the second...16:08
*** jcoufal has quit IRC16:08
mriedemrlrossit: i'm told this should be an easy fix https://bugs.launchpad.net/nova/+bug/147014216:08
openstackLaunchpad bug 1470142 in OpenStack Compute (nova) "Nova volume encryptors attach volume fails for NFS and FC (rootwrap)" [Medium,Triaged]16:08
rlrossitblargh16:08
dansmithrlrossit: object tests?16:09
mriedemrlrossit: running twice in debug mode?16:09
*** andreykurilin__ has joined #openstack-nova16:09
rlrossityes16:09
*** lyarwood has quit IRC16:09
rlrossitto both16:09
*** lyarwood has joined #openstack-nova16:09
mriedemhemna: will check it out outside the cinder meeting16:09
hemnaok thanks16:09
*** unicell has joined #openstack-nova16:12
hemnamriedem, any idea why my os-brick patch is marked as -1 from Jenkins and yet every voting CI is marked as Success ?16:12
hemnahttps://review.openstack.org/#/c/175569/16:12
hemnaI don't get that16:12
*** Longgeek has quit IRC16:12
mriedemhemna: gate-nova-requirements http://logs.openstack.org/69/175569/20/check/gate-nova-requirements/3119838/ : Incompatible requirement found; see https://wiki.openstack.org/wiki/Requirements in 59s16:12
hemnaI don't see that being reported on the patch ?16:14
dimsmriedem: note that the log does not say what's wrong :(16:15
mriedemhemna: it's in the jenkins results when you toggle ci at the bottom16:15
*** irenab has quit IRC16:16
hemnaoh!16:17
hemnahah, I had that toggled off.16:17
hemnatrying to find the issue in the log....16:18
dimshemna: i just commented above, the log does not say what the issue was/is16:18
dimsi have the same problem with another review in oslo.messaging16:18
hemna:(16:19
dimswill have to talk to lifeless later in the day16:19
*** kiran-r has joined #openstack-nova16:19
*** _kiran_ has joined #openstack-nova16:19
*** _kiran_ has quit IRC16:19
hemnadims, maybe a rebase might fix it16:20
*** danpb1 has joined #openstack-nova16:20
openstackgerritWalter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick  https://review.openstack.org/17556916:20
*** danpb has quit IRC16:20
dimshemna: https://review.openstack.org/#/c/192382/ multiple rechecks and rebases - no dice16:21
hemnadang ok.  well, I'm guessing the rebase I just did will puke as well then.16:21
*** jlanoux_ has quit IRC16:21
*** ajayaa_ has quit IRC16:22
*** ajayaa has joined #openstack-nova16:22
*** whenry_ has joined #openstack-nova16:24
*** sdake has joined #openstack-nova16:24
openstackgerritQin Zhao proposed openstack/nova: Refuse to delete compute service if host is in host aggregate  https://review.openstack.org/19764816:25
*** irenab has joined #openstack-nova16:25
*** flwang1 has quit IRC16:25
*** rushiagr_away has joined #openstack-nova16:26
*** matrohon has quit IRC16:27
*** Marga_ has joined #openstack-nova16:28
*** _diana_ has joined #openstack-nova16:29
dansmithrlrossit: object tests run twice, once in "local" and once in "remote" mode16:29
dansmithrlrossit: to make sure whatever you did works in both cases16:29
dansmithrlrossit: the kindof "point" of objects is that they behave the same regardless of if we're local to the db or not16:29
*** Piet has joined #openstack-nova16:30
rlrossitdansmith: gotcha... so changing over the list objects causes one, but not both, of them to fail then16:30
*** karimb has quit IRC16:31
*** tsbot_ has joined #openstack-nova16:31
*** irenab has quit IRC16:32
dansmithrlrossit: okay, I'm on a call.. ping me again in 30-45 minutes16:33
rlrossitalrighty. thanks in advance dansmith!16:34
*** _diana_ has quit IRC16:34
*** vilobhmm has joined #openstack-nova16:35
*** jwcroppe_ has joined #openstack-nova16:38
*** ociuhandu has quit IRC16:38
*** derekh has quit IRC16:39
*** jwcroppe has quit IRC16:40
*** piyanai has quit IRC16:43
*** rotbeard has quit IRC16:43
*** piyanai has joined #openstack-nova16:43
*** piyanai has quit IRC16:44
*** Marga_ has quit IRC16:44
*** Longgeek has joined #openstack-nova16:45
*** marun has left #openstack-nova16:47
*** annashen has joined #openstack-nova16:48
*** piyanai has joined #openstack-nova16:48
*** Jeffrey4l has quit IRC16:52
*** armax has joined #openstack-nova16:52
*** annashen has quit IRC16:53
*** Jeffrey4l has joined #openstack-nova16:54
*** aix has quit IRC16:55
*** belmoreira has joined #openstack-nova16:55
johnthetubaguymelwitt_: this one has the blueprint approved now, in case you don't see the mail: https://review.openstack.org/#/c/179059/16:55
*** melwitt_ is now known as melwitt16:55
melwittjohnthetubaguy: cool, thank you16:56
*** baoli has quit IRC16:58
*** ferest has joined #openstack-nova16:59
*** piyanai has quit IRC16:59
*** davideagnello has joined #openstack-nova17:01
*** browne has quit IRC17:02
*** Longgeek has quit IRC17:02
*** lyarwood has quit IRC17:02
*** lyarwood has joined #openstack-nova17:02
*** piyanai has joined #openstack-nova17:03
*** patrickeast has quit IRC17:03
*** baoli has joined #openstack-nova17:03
*** ijw has joined #openstack-nova17:04
*** hemna is now known as hemnafk17:04
*** sudipto has quit IRC17:04
*** lpetrut has joined #openstack-nova17:04
*** ijw_ has joined #openstack-nova17:04
*** Marga_ has joined #openstack-nova17:05
*** otter768 has joined #openstack-nova17:06
*** romainh has quit IRC17:06
*** kiran-r has quit IRC17:07
*** yamahata has quit IRC17:07
*** dboik has quit IRC17:09
*** vilobhmm has quit IRC17:10
*** annashen has joined #openstack-nova17:10
*** vilobhmm has joined #openstack-nova17:10
*** otter768 has quit IRC17:11
*** lucasagomes is now known as lucas-dinner17:14
*** Piet has quit IRC17:17
*** piyanai has quit IRC17:18
openstackgerritQin Zhao proposed openstack/nova: Make compute rpc api to send instance object  https://review.openstack.org/19479117:18
*** moshele has quit IRC17:18
*** sdake_ has joined #openstack-nova17:18
openstackgerritNikola Dipanov proposed openstack/nova: Introduce a simple state machine module  https://review.openstack.org/19766817:19
openstackgerritNikola Dipanov proposed openstack/nova: WIP: Define migration states and transitions and use when changing status  https://review.openstack.org/19766917:19
ndipanovdansmith, mriedem ^^17:19
ndipanovyou like this kind of stuff17:19
ndipanovsome food for thought17:19
ndipanovdansmith, if we like it - might be good to get this in before the evacuate changes17:19
dansmithndipanov: you're going to have a hard time proving to me that you cover all the possibilities for all virt drivers17:20
dansmithsurely agree that we need to do that, but it's going to be rough I think17:21
ndipanovwhat possibilities17:21
dansmithmaybe make the new model advisory, log a warning any time we violate it, and watch it for a while17:21
ndipanovI mean17:21
*** lpetrut has quit IRC17:21
*** dboik has joined #openstack-nova17:21
ndipanovyes that was what I was gonna do actually17:21
ndipanovand turn exceptions on in tests17:21
*** sdake has quit IRC17:21
*** patrickeast has joined #openstack-nova17:21
ndipanovbut this should not be related to driver logic dansmith17:22
dansmithyou're talking about things like vm_state, yes?17:22
ndipanovwell for now just migration state17:22
ndipanovbut eventually maybe17:22
ndipanovVM state is also Nova wide should not be specific to drivers17:22
*** jaypipes has joined #openstack-nova17:22
dansmithriiiiight17:22
ndipanovlol17:23
ndipanov:)17:23
*** dboik_ has joined #openstack-nova17:23
ndipanovwell even if we make it as loose as possible it's still better than not defined whatever17:23
*** achanda has joined #openstack-nova17:23
ndipanovand for migrations it should be more straightforward17:23
ndipanovI mean - if we want to eliminate guessing - which is the point of some of this work17:24
ndipanovthis is one place to do it17:24
*** Sukhdev has quit IRC17:24
dansmithyeah17:24
dansmithmy evacuate stuff has been sitting for a while and I'm kind of sick of rebasing it, but...17:25
*** Sukhdev has joined #openstack-nova17:25
*** irenab has joined #openstack-nova17:25
dansmithlemme finish the other intolerable task I'm doing now and I'll look/think about it17:25
ndipanovawesome17:25
ndipanovI'll log off soon so leave comments pls - thanks!!!17:26
*** dboik has quit IRC17:26
*** gokrokve_ has joined #openstack-nova17:26
bauzasoh a Nova state machine !17:27
bauzasis it Christmas ?17:27
*** gokrokve has quit IRC17:27
*** nic has joined #openstack-nova17:28
openstackgerritNikola Dipanov proposed openstack/nova: WIP: Define migration states and transitions and use when changing status  https://review.openstack.org/19766917:29
openstackgerritNikola Dipanov proposed openstack/nova: Introduce a simple state machine module  https://review.openstack.org/19766817:29
*** piyanai has joined #openstack-nova17:33
*** lyarwood has quit IRC17:33
*** lyarwood has joined #openstack-nova17:33
*** doude_ has quit IRC17:36
*** ijw has quit IRC17:37
*** armax has quit IRC17:37
*** belmoreira has quit IRC17:38
*** ildikov has quit IRC17:39
*** sdake_ is now known as sdake17:39
*** ndipanov has quit IRC17:41
*** armax has joined #openstack-nova17:43
*** lyarwood has quit IRC17:44
*** lyarwood has joined #openstack-nova17:44
*** piyanai has quit IRC17:44
*** sdake has quit IRC17:44
*** thangp is now known as thangp_afk17:45
*** browne has joined #openstack-nova17:45
*** mestery_ has joined #openstack-nova17:46
*** sdake has joined #openstack-nova17:46
*** dane-fichter has quit IRC17:46
*** piyanai has joined #openstack-nova17:46
*** exploreshaifali has joined #openstack-nova17:46
*** vilobhmm has quit IRC17:47
*** sdake has quit IRC17:48
*** mestery has quit IRC17:49
*** sdake has joined #openstack-nova17:49
*** rwsu has quit IRC17:50
*** lyarwood has quit IRC17:50
*** Piet has joined #openstack-nova17:51
*** lyarwood has joined #openstack-nova17:52
*** penick has joined #openstack-nova17:52
*** piyanai has quit IRC17:52
openstackgerritMatt Riedemann proposed openstack/nova: Add wording to error message in TestObjectVersions.test_relationships  https://review.openstack.org/19768417:52
*** hemnafk is now known as hemna17:53
*** penick_ has joined #openstack-nova17:54
*** rwsu has joined #openstack-nova17:54
*** Marga_ has quit IRC17:55
*** lpetrut has joined #openstack-nova17:56
*** sudipto has joined #openstack-nova17:56
*** thorst has quit IRC17:57
*** penick has quit IRC17:57
*** penick_ is now known as penick17:57
*** jogo has quit IRC17:58
*** sudipto has quit IRC17:59
*** browne has quit IRC18:01
*** browne has joined #openstack-nova18:02
*** lpetrut has quit IRC18:03
*** tjones1 has quit IRC18:03
*** mestery_ is now known as mestery18:04
*** Kennan has quit IRC18:04
hemnamriedem, whoa.  my os-brick patch just puked on that TestObjectVersions.test_relationships error.  infinite recursion looks like18:04
*** tjones1 has joined #openstack-nova18:04
mriedemhemna: there should be a fix for that merged by now18:05
*** Kennan has joined #openstack-nova18:05
hemnamriedem, ok I'll recheck thanks.18:05
mriedemhemna: https://review.openstack.org/#/c/197611/18:05
openstackgerritWalter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick  https://review.openstack.org/17556918:05
mriedemhemna: it's been one of those weeks18:05
hemnaheh yah it has.18:06
openstackgerritWalter A. Boring IV (hemna) proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector  https://review.openstack.org/19441218:06
*** thorst has joined #openstack-nova18:06
openstackgerritWalter A. Boring IV (hemna) proposed openstack/nova: Add os-brick based LibvirtVolumeDriver for ScaleIO  https://review.openstack.org/19445418:07
*** danpb1 has quit IRC18:07
*** igordcard_ has joined #openstack-nova18:10
openstackgerritSylvain Bauza proposed openstack/nova-specs: Proposes to check destination on migrations  https://review.openstack.org/17922418:11
rlrossitdansmith: I think we have a problem...18:11
rlrossithttp://git.openstack.org/cgit/openstack/oslo.versionedobjects/tree/oslo_versionedobjects/base.py#n772 makes everything blow up18:11
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/19432518:11
dansmithrlrossit: ah, nice18:12
*** ZZelle_ has joined #openstack-nova18:12
*** romainh has joined #openstack-nova18:12
rlrossitdansmith: are we going to have to work some magic in nova's object list base to work around this?18:12
*** Marga_ has joined #openstack-nova18:12
dansmithyeah, so, here's what I'd do:18:12
dansmith1. Override this method in nova's list base, make it look first in obj_relationships, and fall back to child_versions18:13
dansmith2. Port that change over to oslo.versionedobjects18:13
dansmith3. Convert all the nova objects to use obj_relationships18:13
*** sudipto has joined #openstack-nova18:13
dansmith4. When we get a new o.vo, we can drop nova's override18:14
openstackgerritMarian Horban proposed openstack/nova: libvirt:Rsync remote FS driver was added  https://review.openstack.org/14688718:14
dansmiththat will decouple the change from having to modify all the list objects at once too18:14
dansmithwhich is kinda nice to prove that we work in both ways18:14
dansmiththe library will have to keep the either/or behavior for some time, but that's fine18:14
dansmithrlrossit: make sense?18:14
*** thangp_afk is now known as thangp18:14
rlrossitdansmith: yes, but I'm not sure how I should orchestrate this18:15
*** jogo has joined #openstack-nova18:15
mriedemrlrossit: steps 1-4?18:15
dansmithrlrossit: those steps ^18:15
mriedemha18:15
dansmithheh18:15
rlrossitdo #1 totally separate from the obj_relationships change that I'm making right now?18:15
dansmithrlrossit: #1 and #3 will be in place of what you're doing now18:16
mriedem2 is a copy of 1 but in the oslo.versionedobjects repo18:16
dansmithwell, #3 above is basically what you're doing now18:16
mriedemwhich should eventually replace all of the nova object base stuff18:16
rlrossityeah so for #2 should I open a bug to oslo?18:16
dansmithrlrossit: you can if you want, sure18:16
dansmithrlrossit: I'll give you a tip though.. the owner of oslo.versionedobjects is a real dick, so be careful when you go propose that.. have all your ducks in a row18:17
*** kiran-r has joined #openstack-nova18:18
dimsLOL!18:19
*** Sukhdev has quit IRC18:19
dansmithdims: amirite?18:19
rlrossitwait I'm not sure now... is the owner dims or dansmith?18:20
dansmithhaha18:20
dansmithrlrossit: second hint: dims is not a dick18:20
mriedemrlrossit: https://review.openstack.org/#/admin/groups/600,members18:20
mriedemjaypipes: is the dick in that list for sure18:20
dimsdansmith: totally wrong :)18:20
dansmithheh18:20
dimsrlrossit: hahaha18:21
bauzaslol18:21
rlrossita can of worms was not the best thing to open on my last day before taking off until Tuesday...18:21
* bauzas is sorry about saying the word 'lol' here18:21
dansmithrlrossit: you mean the who-is-a-dick can of worms, or this object stuff?18:21
rlrossitthe object stuff18:22
dansmithnah, it's all good18:22
dimsrlrossit: we are not that bad :) go forth and submit ur reviews!18:22
dansmithI'm super happy you landed the first one to fix the test18:22
rlrossitI'll make sure to leave myself a big steaming pile of code to come back to on Tuesday18:22
*** nihilifer has quit IRC18:22
dansmiththat prevents more breakage.. the cleanup bits can wait until next week18:22
jaypipesmriedem: :(18:22
jaypipesmriedem: you are more than welcome to replace me, sir.18:22
mriedemjaypipes: you know i'm joking18:22
rlrossitmriedem: you never joke18:22
mriedemjaypipes: b/c it can't be dan, since that'd be self incriminating, and i know it's not doug18:22
dansmithjaypipes: you and me on the same list, it's pretty obvious who the larger dick is18:22
rlrossityou're the most serious guy I know18:23
jaypipesdansmith: s/the larger/has the larger/18:23
dansmither, maybe I should change those words18:23
*** thangp has quit IRC18:23
dansmithhaha18:23
mriedemi knew that was coing18:23
jaypipes:)18:23
*** piyanai has joined #openstack-nova18:23
*** Marga_ has quit IRC18:25
* dims tags channel as NSFW18:26
jaypipeshehe18:26
jaypipesdansmith started it.18:26
dansmithum, my comment was G-rated18:26
rlrossitnot sure what tv you watch dansmith, but I don't think calling people dicks is G rated :)18:27
dansmithjaypipes: you should commend jaypipes for not having structured parameters to his tag18:27
mriedemrlrossit: he's thinking G-rated for the 80s18:27
dansmithhah18:27
mriedemratings in the 80s were much more lax18:27
* bauzas thanks UrbanDictionary18:27
rlrossitmriedem: well.... I wasn't alive in the 80's so I wouldn't know!18:28
*** thangp has joined #openstack-nova18:28
mriedemi know18:28
* jaypipes feels quite old now.18:28
rlrossitI'm one of those kids that needs to get off people's lawns18:28
mriedemclassic example: http://www.imdb.com/title/tt0080339/18:28
*** romainh has left #openstack-nova18:28
mriedemthat's PG18:28
mriedemand has swearing and a full bare boob shot18:28
mriedemplus probably your standard early 80s racism18:29
rlrossitreally? I'm pretty sure I watched that movie when I was like 818:29
*** packet has joined #openstack-nova18:29
mriedemwatch it again18:29
mriedemit's amazing18:29
bauzas++18:29
rlrossitoh I've seen it a bunch18:29
*** ildikov has joined #openstack-nova18:29
rlrossitgive me ham on 1, hold the mayo18:29
rlrossitsmoking or non-smoking?18:29
dansmithin my house,18:29
mriedemi meant, amazing that it's pg18:29
dansmithsaying "roger" implies followup with ", roger, what's your vector victor?"18:30
*** vishwanathj has joined #openstack-nova18:30
rlrossityou ever been to a turkish prison?18:30
mriedemhow often do you say 'roger' in your house?18:30
* dims threatens to start asking for reviews now to change conversation!18:30
jaypipesDo you like gladiator movies, Johnny?18:30
dansmithmriedem: pretty soon the only thing G-rated will be animated18:30
dansmithmriedem: quite a bit actually18:30
dansmithmriedem: the smith household is run paramilitary style18:31
jaypipesdims: :)18:31
dansmithalways on at least defcon 218:31
jaypipesdims: what reviews do you need done, fine sir?18:31
* bauzas threatens to show "Y a t'il un pilote dans l'avion" with French dubbed jokes18:31
mriedemdansmith: so like the NRA18:31
dansmith...and rifles standing by the door18:31
*** nihilifer has joined #openstack-nova18:31
*** Nikolay_St has quit IRC18:31
dimsjaypipes: nothing urgent jay :)18:31
jaypipesdims: roger that.18:32
dimsthanks for asking :)18:32
jaypipes:)18:32
*** READ10 has quit IRC18:32
dansmithroger roger.18:33
*** Nikolay_St has joined #openstack-nova18:33
mriedemso i have an actual real question about a real thing18:34
*** piyanai has quit IRC18:34
mriedemfor rootwrap filters, when a command is listed in the wrong module, but it shows up in multiple places, do we list the other multiple places (there are only 2), or just leave the wrong module path in the comment?18:34
mriedemhttps://github.com/openstack/nova/blob/master/etc/nova/rootwrap.d/compute.filters#L21518:35
mriedemthat doesn't actually happen in volume.py, it happens in the cryptsetup and luks modules for encryptors18:35
*** tongli has joined #openstack-nova18:35
*** piyanai has joined #openstack-nova18:35
mriedemi guess mkfs lists the modules it's called from, so nvm: https://github.com/openstack/nova/blob/master/etc/nova/rootwrap.d/compute.filters#L16818:35
sudipto dims given that your review https://review.openstack.org/195578 has merged, is it correct to assume that if i make changes based on these and submit the patchset in nova - jenkins would be happy?18:36
sudiptodims, or does it have a time period - after which it starts to work?18:36
*** andreykurilin__ has quit IRC18:37
*** kiran-r has quit IRC18:38
*** irenab has quit IRC18:38
*** sdake has quit IRC18:38
*** dprince has quit IRC18:38
*** sdake has joined #openstack-nova18:38
*** kiran-r has joined #openstack-nova18:39
*** dprince has joined #openstack-nova18:39
jaypipesbauzas: https://review.openstack.org/#/c/145528/ needs a rebase please sir.18:39
jaypipesbauzas: I'd like to get that patch series reviewed and merged within next week.18:39
bauzasjaypipes: yup, I'm on it, but I discovered something really really bad18:39
*** piyanai has quit IRC18:39
jaypipesbauzas: what's that?18:40
*** Marga_ has joined #openstack-nova18:40
bauzasjaypipes: so, the thing is, the ImageMeta object is missing a property18:40
jaypipesbauzas: so add one :)18:40
bauzasjaypipes: at the moment, I'm also changing all the filters in one row to use the object - that's pretty time consuming :-)18:40
bauzasjaypipes: so I expect to send the updated series by tomorrow18:41
*** sdake_ has joined #openstack-nova18:41
*** doude has joined #openstack-nova18:41
bauzasI know that you US guys are going on vacation while our proud French boys will still be working, but that's fair18:41
*** Marga__ has joined #openstack-nova18:42
mriedembauzas: doesn't france have like mandatory 3 month vacation for everyone or something?18:42
*** Marga__ has quit IRC18:42
dansmithyeah, no complaints18:42
bauzasmriedem: don't leave me explain what some people here are asking for18:42
bauzasthat's kind of a joke18:43
*** Marga__ has joined #openstack-nova18:43
mriedemthis weekend we celebrate our independence from johnthetubaguy by blowing things up and eating many grilled meats18:43
bauzasmriedem: at least you have a movie which explains that to us18:44
mriedemha18:44
mriedemwith the aliens?18:44
bauzasmriedem: yup18:44
mriedemterrible18:44
bauzasmriedem: I'm sincerely sorry about that one18:44
mriedemnothing says 'merica like will smith punching an alien in the face18:44
*** sdake has quit IRC18:44
*** Marga_ has quit IRC18:44
*** Sukhdev has joined #openstack-nova18:44
*** kiran-r has quit IRC18:44
dansmithlol18:44
dansmithyes, Independence Day (tm) is exactly what happens every fourth18:45
mriedemdon't forget that randy quaid has a starring role18:45
*** lucas__ has quit IRC18:45
mriedembefore he was living in a trash can18:45
*** mutoulbj has quit IRC18:46
bauzas:)18:46
*** ctrath1 has joined #openstack-nova18:47
*** Mike_D_laptop has joined #openstack-nova18:47
mriedemsudipto: what is your nova change?18:47
mriedemsudipto: nova changes won't pick up oslo.db changes until a release of oslo.db with the change is out18:47
sudiptomriedem, oh k. Here's the nova patchset.18:48
sudiptomriedem, a UT was fails due to a dependency in the oslo.db project...the oslo patchset has got merged a few hours back...and i have a patchset built on top of that.18:49
sudipto*a UT was failing.18:49
*** lucas__ has joined #openstack-nova18:50
*** gokrokve_ has quit IRC18:50
*** ctrath has quit IRC18:50
*** bradjones has quit IRC18:51
rlrossitmriedem: how *dare* you insult will smith's greatest adult role18:52
*** bradjones has joined #openstack-nova18:52
*** bradjones has quit IRC18:52
*** bradjones has joined #openstack-nova18:52
mriedembrb18:53
*** sudipto has quit IRC18:53
rlrossitdansmith: with this ovo bug, does that mean I'm supposed to start harassing you on the oslo channel too now?18:53
dansmithrlrossit: it doesn't really matter for this, and I'll be less grumpy if I have to keep switching channels :)18:54
rlrossitwell, since I'm already here... https://bugs.launchpad.net/oslo.versionedobjects/+bug/1470617 is up for your scrutiny18:56
openstackLaunchpad bug 1470617 in oslo.versionedobjects "ObjectListBase only checks child_versions in obj_make_compatible()" [Undecided,New]18:56
*** Marga__ has quit IRC18:56
*** Marga_ has joined #openstack-nova18:57
dansmithrlrossit: looks good, thanks18:57
rlrossitdansmith: which change would you prefer to get first, the oslo one or the nova one?18:57
rlrossitI'll spend my dwindling work hours on whichever you choose18:58
dansmithrlrossit: I think it'll be easier to show that it works in nova, so I'd do that first18:58
dansmithrlrossit: it's a little backwards, but o.vo spawned to absorb nova's object code, so we're still kindof in backslide mode at the moment18:58
rlrossitisn't that how every project starts? it gets incubated in nova :P18:59
*** irenab has joined #openstack-nova19:01
*** LukeHinds has quit IRC19:02
dansmithrlrossit: you catch on fast19:02
*** unicell has quit IRC19:03
*** otter768 has joined #openstack-nova19:07
*** tongli has quit IRC19:07
*** Marga_ has quit IRC19:09
*** erlon has quit IRC19:10
*** nihilifer has quit IRC19:10
*** gokrokve has joined #openstack-nova19:10
*** otter768 has quit IRC19:11
openstackgerritMatt Riedemann proposed openstack/nova: rootwrap: update ln --symbolic filter for FS and FC type volume drivers  https://review.openstack.org/19771319:12
*** boris-42 has joined #openstack-nova19:13
*** gszasz has quit IRC19:21
*** sdake has joined #openstack-nova19:21
*** sdake has quit IRC19:23
*** sdake has joined #openstack-nova19:23
*** zhenguo has quit IRC19:23
*** aysyd has quit IRC19:23
*** apuimedo has quit IRC19:24
*** piyanai has joined #openstack-nova19:25
*** sdake_ has quit IRC19:25
*** aysyd has joined #openstack-nova19:25
*** thangp has quit IRC19:26
*** kiran-r has joined #openstack-nova19:26
nagyz_mriedem, nice fix on the rootwrap issue. I was looking at it but it looked much more complicated to me :)19:28
mriedemnagyz_: thanks, looking at https://bugs.launchpad.net/nova/+bug/1470562 now19:29
openstackLaunchpad bug 1470562 in OpenStack Compute (nova) "'in use' error when Nova volume encryptors format cinder volumes" [Medium,Confirmed]19:29
mriedemnot sure if a simple retry will help in there or not19:29
mriedemdocs on cryptsetup kind of suck19:29
*** Marga_ has joined #openstack-nova19:29
*** annashen has quit IRC19:29
nagyz_cryptseutp sucks.19:30
*** dansmith has quit IRC19:30
nagyz_I'm still not sure why there is a separate luks and cryptsetup encryptor?19:30
*** annashen has joined #openstack-nova19:30
*** dansmith has joined #openstack-nova19:30
nagyz_would you mind taking a quick look at one of my 2 line fixes? I think it's a very simple fix. :)19:31
*** lyarwood has quit IRC19:31
mriedemlink19:32
*** lyarwood has joined #openstack-nova19:33
*** nihilifer has joined #openstack-nova19:33
nagyz_https://review.openstack.org/#/c/196647/19:33
*** lpetrut has joined #openstack-nova19:34
*** armax has quit IRC19:34
nagyz_not sure about the underlying issue, tho, so this might just be a cosmetic fix - I've applied the same fix that seems to be used for this kind of issues19:34
*** piyanai has quit IRC19:34
*** annashen has quit IRC19:34
*** gokrokve has quit IRC19:36
*** ociuhandu has joined #openstack-nova19:36
*** aysyd has quit IRC19:37
*** Mike_D_laptop has quit IRC19:38
*** lyarwood has quit IRC19:38
*** lyarwood_ has joined #openstack-nova19:38
*** aysyd has joined #openstack-nova19:39
lifelessdims: about ?19:39
*** nkrinner has joined #openstack-nova19:40
lifelessdims: mriedem: That looks like my I1d254c42e0bc2550ceeb768532448b5797d87caf isn't live yet19:41
*** agireud has quit IRC19:41
*** kiran-r has quit IRC19:42
*** nadirvardar has joined #openstack-nova19:42
*** armax has joined #openstack-nova19:42
*** emagana has joined #openstack-nova19:43
emaganaHi Nova Devs!19:43
emaganaIn Icehouse when I fire up a VM with a 4096 MB or higher, it's stuck forever on "Spawning". Smaller flavors works fine. Any idea why this is happening? I have plenty of memory in my compute nodes!19:44
*** vishwana_ has joined #openstack-nova19:45
*** mutoulbj has joined #openstack-nova19:47
*** vishwanathj has quit IRC19:47
*** unicell has joined #openstack-nova19:53
*** piyanai has joined #openstack-nova19:53
dansmithmriedem: oh my god19:54
dansmithmriedem: the horrific test_servers tests are mirrored for v3 in plugins/v3/test_servers19:54
mriedemnagyz_: the change seems OK but could you add a simple unit test?19:54
mriedemdansmith: you might also like to look at this given the instance event callback stuff happening https://review.openstack.org/#/c/196647/19:54
*** mutoulbj has quit IRC19:54
mriedemdansmith: double the tests, double your fun19:54
*** agireud has joined #openstack-nova19:55
*** yamahata has joined #openstack-nova19:55
dansmithokay, opened the tab19:55
*** lpetrut has quit IRC19:56
lifelessgaryk: hi if you have time - https://review.openstack.org/#/c/189934/19:57
lifelessgaryk: (we're -two- patches away from having constraints live)19:57
*** tjones1 has quit IRC19:58
mriedemlifeless: are you going to rebase this? https://review.openstack.org/#/c/196934/19:59
mriedemlifeless: i think you're missing some g-r updates since that first patch19:59
*** ajayaa has quit IRC19:59
*** flwang has joined #openstack-nova20:00
*** tjones1 has joined #openstack-nova20:00
*** penick has quit IRC20:01
*** achanda has quit IRC20:03
lifelessmriedem: I can sure20:03
*** achanda has joined #openstack-nova20:07
*** achanda has quit IRC20:09
lifelessmriedem: http://logs.openstack.org/34/196934/1/check/gate-nova-python27/d3fa8c5/20:09
mriedemlifeless: needs a rebase20:10
lifelessmriedem: is that why? ok.20:10
mriedemyeah, that test was fixed20:10
lifelessmriedem: if the test was fixed in trunk a simple recheck will do20:10
mriedemyeah it was20:10
mriedemrecheck away20:10
lifelessmriedem: but I can resync with requirements too anyhow20:10
lifelessso let me do that20:10
*** belmoreira has joined #openstack-nova20:11
openstackgerritMatt Riedemann proposed openstack/nova: Try luksFormat up to 3 times in case the device is in use  https://review.openstack.org/19772120:11
mriedememagana: first, see channel topic, second, turn on debug logging and tail the logs to see where the instance is stuck20:12
*** nic has quit IRC20:13
emaganamriedem: sorry about that.. not sure which channel to use20:14
mriedememagana: see topic :)20:14
mriedemit holds the secrets20:14
emaganamriedem: logs do not show much but I will stop this thread in this channel.. thanks!20:14
openstackgerritlifeless proposed openstack/nova: Remove python3 specific test-requirements file.  https://review.openstack.org/19693420:14
lifelessmriedem: ^20:15
mriedememagana: otherwise try getting a guru meditation report20:15
mriedememagana: http://docs.openstack.org/developer/nova/devref/gmr.html20:15
*** belmoreira has quit IRC20:15
emaganamriedem: thanks for the pointer!20:15
* dims peeks at scrollback20:16
mriedemdansmith: do you know how we get the hudson-openstack lp user in the nova bug team again?20:17
mriedemhttps://launchpad.net/~nova-bugs/+members#active20:17
mriedemthat's why we're not seeing patches linked to nova bug reports20:17
*** lucas-dinner has quit IRC20:19
mriedemnvm20:19
*** cburgess_ has quit IRC20:23
*** cburgess has joined #openstack-nova20:23
openstackgerritjichenjc proposed openstack/nova: Soft delete system_metadata when destroy instance  https://review.openstack.org/11087520:24
*** ivasev has quit IRC20:26
openstackgerritEarle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector  https://review.openstack.org/19441220:27
*** packet has quit IRC20:28
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Enable python34 tests for nova/tests/unit/objects/test*.py  https://review.openstack.org/18778520:29
*** jgrimm is now known as zz_jgrimm20:29
dansmithmriedem: weird20:31
mriedemdansmith: fungi has a fix up https://review.openstack.org/#/c/197725/20:31
*** lucas-dinner has joined #openstack-nova20:31
dansmithah, cool20:31
*** romainh has joined #openstack-nova20:32
*** earlephilhower has joined #openstack-nova20:36
*** ijw_ has quit IRC20:36
*** openstackgerrit has quit IRC20:37
*** Marga_ has quit IRC20:37
*** openstackgerrit has joined #openstack-nova20:37
*** romainh has left #openstack-nova20:37
*** sahid has quit IRC20:41
*** nkrinner has quit IRC20:44
*** Sukhdev has quit IRC20:44
*** unicell1 has joined #openstack-nova20:45
*** unicell has quit IRC20:45
*** Sukhdev has joined #openstack-nova20:45
*** neiljerram_bb has joined #openstack-nova20:45
*** annashen has joined #openstack-nova20:46
*** neiljerram_bb has quit IRC20:46
htrutahi guys! Is there a reason for nova does not consider ram overcommit when live migrating an instance?20:47
htrutaor is it a bug?20:47
*** mriedem has quit IRC20:49
bauzashtruta: look at https://review.openstack.org/#/c/179224/20:50
*** thumpba has joined #openstack-nova20:51
bauzashtruta: also https://review.openstack.org/#/c/180151/20:51
htrutabauzas: nice. I kind of liked the patch :) but will take a deeper look at the spec tonight20:53
htrutathanks20:53
bauzasnp20:54
*** jasondotstar has joined #openstack-nova21:01
*** varunarya has joined #openstack-nova21:01
*** thorst has quit IRC21:05
*** sdake_ has joined #openstack-nova21:07
*** otter768 has joined #openstack-nova21:08
*** lucas__ has quit IRC21:09
*** sdake has quit IRC21:09
*** lucas__ has joined #openstack-nova21:10
*** aysyd has quit IRC21:11
*** otter768 has quit IRC21:12
*** mnestratov has joined #openstack-nova21:15
*** tjones1 has quit IRC21:16
*** mnestratov|2 has quit IRC21:18
*** tjones1 has joined #openstack-nova21:18
*** exploreshaifali has quit IRC21:21
*** rlrossit has left #openstack-nova21:21
*** heyongli has quit IRC21:23
*** karimb has joined #openstack-nova21:23
*** lucas__ has quit IRC21:24
*** heyongli has joined #openstack-nova21:24
*** edmondsw has quit IRC21:28
*** thumpba has quit IRC21:28
*** heyongli has quit IRC21:29
*** lucas__ has joined #openstack-nova21:29
*** lucas__ has quit IRC21:30
*** jasondotstar has quit IRC21:30
*** busterswt has quit IRC21:30
*** lucas__ has joined #openstack-nova21:30
*** heyongli has joined #openstack-nova21:31
*** ddaskal has quit IRC21:31
*** lucas__ has quit IRC21:35
*** tjones2 has joined #openstack-nova21:36
*** tjones1 has quit IRC21:37
*** doude has quit IRC21:38
*** doude has joined #openstack-nova21:38
*** dprince has quit IRC21:39
*** varunarya has quit IRC21:40
*** Jeffrey4l has quit IRC21:41
*** doude has quit IRC21:42
*** doude has joined #openstack-nova21:43
*** Jeffrey4l has joined #openstack-nova21:43
*** READ10 has joined #openstack-nova21:45
*** doude has quit IRC21:47
*** lucas__ has joined #openstack-nova21:47
*** mmedvede has quit IRC21:48
*** doude has joined #openstack-nova21:48
openstackgerritVictor Stinner proposed openstack/nova: Port crypto to Python 3  https://review.openstack.org/19774821:50
*** lucas__ has quit IRC21:52
*** varunarya has joined #openstack-nova21:52
*** _diana_ has joined #openstack-nova21:53
*** _diana_ has quit IRC21:54
*** _diana_ has joined #openstack-nova21:54
*** ianbrown has joined #openstack-nova21:55
*** burt has quit IRC22:00
*** annegentle has joined #openstack-nova22:02
*** nihilifer_ has joined #openstack-nova22:04
*** nihilifer has quit IRC22:04
*** nihilifer_ is now known as nihilifer22:04
openstackgerritZoltan Arnold Nagy proposed openstack/nova: Handle unexpected clear events call  https://review.openstack.org/19664722:06
*** ZZelle_ has quit IRC22:08
*** xyhuang has quit IRC22:10
*** _cerberus_ has quit IRC22:12
*** ijw has joined #openstack-nova22:14
*** mmedvede has joined #openstack-nova22:16
*** sdake_ is now known as sdake22:17
*** doude has quit IRC22:17
*** dims_ has joined #openstack-nova22:17
*** annashen has quit IRC22:20
*** dims has quit IRC22:21
*** annashen has joined #openstack-nova22:21
*** nadirvardar has quit IRC22:23
*** annashen has quit IRC22:25
*** sambol has quit IRC22:26
tonybmriedem: I tried to reproduce it with a few different systems/changes and I couldn't22:27
tonybmriedem: so my grand plan became "leave it for 24 hours and see if it still happens"22:28
tonybmriedem: I only see the 2 hits from yesterday22:29
*** sdake is now known as sdake_22:29
*** _cerberus_ has joined #openstack-nova22:30
*** ctrath1 has quit IRC22:32
*** agireud has quit IRC22:33
*** _cerberus_ has quit IRC22:34
*** _diana_ has quit IRC22:34
dansmithtonyb: I fixed it22:35
tonybdansmith: Oh!22:35
* tonyb goes looking for the review22:36
dansmithtonyb: the reason for the bug was long and complex22:36
dansmithtonyb: but the tl;dr is: I'm a dolt22:37
dansmithhttps://review.openstack.org/#/c/197611/22:37
*** emagana has quit IRC22:37
openstackgerritZoltan Arnold Nagy proposed openstack/nova: Handle unexpected clear events call  https://review.openstack.org/19664722:37
tonybdansmith: Thanks.  I look forward to reading about how you're a dolt :)22:37
dansmithheh22:37
*** _cerberus_ has joined #openstack-nova22:38
*** ijuwang has quit IRC22:38
tonybdansmith: So the change makes sense but why didn't it hit everytime?22:40
dansmithtonyb: because we didn't put the thing into the tree until the setdefault() call, which we did after the recurision22:40
dansmithif it's in there, then the check at the top prevents us from recursing22:41
dansmithso we had to arrive at the classes in just the right order to disappear down the rabbit hole :)22:41
*** browne has quit IRC22:43
*** Sukhdev has quit IRC22:45
*** Sukhdev has joined #openstack-nova22:45
melwittdansmith: looks like we can use the proposed patch after all (latest comment) for https://bugs.launchpad.net/nova/+bug/1404795 because evacuate can't be retried if instance.host isn't a down host22:45
openstackLaunchpad bug 1404795 in OpenStack Compute (nova) "instance's host and node are target host's while evacuate failed" [Critical,In progress] - Assigned to ChangBo Guo(gcb) (glongwave)22:45
dansmithmelwitt: hmm22:46
*** nihilifer has quit IRC22:46
melwittdansmith: let me know what you think22:47
openstackgerritVictor Stinner proposed openstack/nova: Enable oslo.vmware dependency on Python 3  https://review.openstack.org/19776222:47
tonybdansmith: Ahh I see.  Thanks for the education.22:48
tonybdansmith: lets hope I remember it :)22:48
dansmithheh22:49
*** nihilifer has joined #openstack-nova22:52
dansmithmelwitt: I can tell you one thing I think and  that is that the bug shouldn't be critical :)22:53
*** sdake_ has quit IRC22:54
melwittdansmith: heh. yeah, I should change it22:54
*** nihilifer has quit IRC22:56
dansmithmelwitt: you should do two things22:57
*** lucas-dinner has quit IRC22:57
dansmithmelwitt: (1) prepare for the tongue-in-cheek rubber stamp +2 requests that befit a core22:57
dansmithmelwitt: (2) You should approve this and the patch below it because I need them: https://review.openstack.org/#/c/197526/222:57
dansmith:)22:57
melwittlol22:57
*** jecarey has quit IRC22:57
dansmithalthough I just noticed a typo in the commit message22:58
openstackgerritDan Smith proposed openstack/nova: tests: Move test_resource_tracker to Instance objects  https://review.openstack.org/19752622:58
dansmithapprove _that_ ^ :)22:59
* melwitt looks23:01
dansmithpretty boring dict-to-object test conversions23:02
*** tonytan4ever has quit IRC23:02
*** radek_ has quit IRC23:05
*** tjones2 has quit IRC23:05
*** nelsnelson has quit IRC23:07
*** otter768 has joined #openstack-nova23:08
*** lucas-dinner has joined #openstack-nova23:09
*** jasondotstar has joined #openstack-nova23:09
*** annegentle has quit IRC23:10
*** READ10 has quit IRC23:11
melwittdansmith: +Warthog'd23:12
dansmithmelwitt: thanks!23:13
*** otter768 has quit IRC23:13
*** zhenguo has joined #openstack-nova23:14
*** lucas-dinner has quit IRC23:14
dansmithmelwitt: you saw I commented on that evac patch I assume23:16
melwittdansmith: I did23:17
melwittthanks. what you said makes sense, I wasn't sure which direction to go about it, whether to "roll back to source" vs change evacuate's criteria a bit23:18
dansmithyeah, I think rolling back to source is potentially problematic if you race with the node coming back up23:18
dansmithI *think* a rebuild of that instance would work, but it might only try to rebuild on the new destination23:18
dansmithwhich if it broke because that host is broken, might not be very useful23:18
*** piyanai has quit IRC23:19
*** Nakato_ is now known as Nakato23:19
melwittah, yeah23:20
openstackgerritDan Smith proposed openstack/nova: Convert test_compute_utils to use Instance object  https://review.openstack.org/19691223:20
openstackgerritDan Smith proposed openstack/nova: Remove compat_instance()  https://review.openstack.org/19270823:20
openstackgerritDan Smith proposed openstack/nova: Remove flavor migration from db_api and nova-manage  https://review.openstack.org/19691123:20
openstackgerritDan Smith proposed openstack/nova: Decouple instance object tests from the api fakes module  https://review.openstack.org/19776923:20
openstackgerritDan Smith proposed openstack/nova: Refactor test_servers to use instance objects  https://review.openstack.org/19777023:20
openstackgerritDan Smith proposed openstack/nova: WIP: Remove legacy flavor compatibility code from Instance  https://review.openstack.org/19777123:20
*** mutoulbj has joined #openstack-nova23:22
alex_xubauzas: jaypipes I think we should return 400, not 409 for both host and force provided https://review.openstack.org/#/c/179224/23:26
alex_xuAPI-WG guideline isn't very clear for this case. Looks like it's time to be liaison23:27
*** IanGovett has quit IRC23:30
*** otter768 has joined #openstack-nova23:30
*** tjones1 has joined #openstack-nova23:31
*** annegentle has joined #openstack-nova23:34
*** browne has joined #openstack-nova23:39
*** baoli has quit IRC23:41
*** mutoulbj has quit IRC23:46
*** tjones1 has quit IRC23:48
*** tjones1 has joined #openstack-nova23:50
*** annashen has joined #openstack-nova23:51
*** jasondotstar has quit IRC23:52
jaypipesalex_xu: :)23:53
*** ijw has quit IRC23:54
*** annashen has quit IRC23:56
*** ijw_ has joined #openstack-nova23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!