*** dboik has quit IRC | 00:00 | |
*** asettle has joined #openstack-nova | 00:01 | |
*** claudiub_ has quit IRC | 00:02 | |
*** penick has quit IRC | 00:03 | |
dansmith | melwitt: can you link me to that low-hanging-fruit page? | 00:05 |
---|---|---|
dansmith | I want to rage-add some things :D | 00:05 |
*** thorst has joined #openstack-nova | 00:07 | |
*** pixelb has quit IRC | 00:07 | |
*** tjones1 has quit IRC | 00:08 | |
*** Piet has joined #openstack-nova | 00:10 | |
*** thorst has quit IRC | 00:11 | |
*** tsekiyam_ has joined #openstack-nova | 00:12 | |
mriedem | dansmith: turn to stone | 00:14 |
dansmith | mriedem: rock on | 00:15 |
*** mwagner_lap has joined #openstack-nova | 00:15 | |
*** mtanino has quit IRC | 00:15 | |
*** tsekiyama has quit IRC | 00:16 | |
mriedem | dansmith: https://etherpad.openstack.org/p/nova-low-hanging-fruit | 00:16 |
*** tsekiyam_ has quit IRC | 00:17 | |
dansmith | ah, thanks | 00:17 |
mriedem | "Conversion from mox to mock unit tests" | 00:17 |
mriedem | i thought that was a thing we said not to do | 00:17 |
mriedem | #4 here http://docs.openstack.org/infra/manual/developers.html#peer-review | 00:18 |
dansmith | yeah, but jaypipes just told someone to do that over the weekend | 00:18 |
dansmith | so I dunno | 00:19 |
*** ijw_ has joined #openstack-nova | 00:19 | |
*** logan2 has quit IRC | 00:19 | |
dansmith | I wouldn't mind getting rid of mox tests, but also don't really care to spend time reviewing that stuff | 00:19 |
dansmith | so meh | 00:19 |
mriedem | yeah i don't want to review it | 00:19 |
*** otter768 has quit IRC | 00:20 | |
mriedem | sure it's low hanging fruit, but it's a big waste of time for review bandwidth | 00:20 |
dansmith | yep | 00:20 |
mriedem | dansmith: did you just add this? "A lot of tests still need to be converted. Almost anywhere you see a mock or stub for a db.instance_* method, that thing should be mocking out the object layer instead. Exceptions would be tests of the objects themselves, tests of the DB API layer, and probably some legacy EC2 tests that are hardly worth converting." | 00:21 |
dansmith | yes | 00:21 |
dansmith | I rage-added it | 00:21 |
dansmith | because I'm in test hell | 00:21 |
*** SourabhP_ has joined #openstack-nova | 00:21 | |
*** ijw has quit IRC | 00:22 | |
mriedem | there is A LOT of that db.* stubbing out in the api extension unit tests | 00:22 |
mriedem | they mock out the db api calls that the objects make from nova.compute.api | 00:22 |
*** logan2 has joined #openstack-nova | 00:22 | |
mriedem | but actually testing way up in the api extensions | 00:22 |
*** rlrossit has joined #openstack-nova | 00:22 | |
dansmith | yep, that's the hell I'm in | 00:22 |
dansmith | I'm like this >< close to scratching my own eyes out | 00:23 |
dansmith | all I want to do is effing remove the flavor compat shit from the instance object | 00:23 |
*** SourabhP has quit IRC | 00:24 | |
*** SourabhP_ is now known as SourabhP | 00:24 | |
*** rlrossit has left #openstack-nova | 00:24 | |
*** nic has quit IRC | 00:25 | |
mriedem | e.g. http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/api/openstack/compute/test_servers.py#n176 | 00:25 |
dansmith | yep | 00:25 |
dansmith | and those god-awful tests also do a lot of mocking per test | 00:25 |
dansmith | so it's like a million places to fix | 00:25 |
dansmith | I've got a nearly 500 line patch going so far | 00:26 |
dansmith | just to clean those up | 00:26 |
dansmith | but I'm pretty close to just deleting it | 00:26 |
mriedem | i heard rlrossit loves to work on that stuff | 00:26 |
dansmith | orly | 00:26 |
dansmith | I would buy rlrossit beers in minnesota | 00:27 |
mriedem | unfortunately he's not around | 00:27 |
dansmith | think of the learning experience | 00:27 |
dansmith | external api, internal api, db api, objects | 00:27 |
*** pedroalvarez has quit IRC | 00:27 | |
mriedem | ha yeah, riiight | 00:27 |
dansmith | hehe | 00:28 |
*** sirushti has quit IRC | 00:28 | |
*** anish has quit IRC | 00:29 | |
*** sdake has quit IRC | 00:29 | |
*** pedroalvarez has joined #openstack-nova | 00:29 | |
*** jasondotstar has joined #openstack-nova | 00:30 | |
*** dims has joined #openstack-nova | 00:32 | |
*** sirushti has joined #openstack-nova | 00:33 | |
*** kfox1111 is now known as kfox1111_away | 00:33 | |
*** yingjun has joined #openstack-nova | 00:33 | |
*** otter768 has joined #openstack-nova | 00:34 | |
*** annashen has joined #openstack-nova | 00:34 | |
*** anish has joined #openstack-nova | 00:35 | |
*** dims_ has joined #openstack-nova | 00:35 | |
*** kylek3h has joined #openstack-nova | 00:36 | |
*** annashen has quit IRC | 00:38 | |
*** dprince has joined #openstack-nova | 00:39 | |
*** dims has quit IRC | 00:39 | |
*** asettle has quit IRC | 00:40 | |
*** kylek3h has quit IRC | 00:40 | |
*** RuiChen has quit IRC | 00:43 | |
*** RuiChen has joined #openstack-nova | 00:44 | |
*** zhenguo has joined #openstack-nova | 00:47 | |
*** IanGovett has quit IRC | 00:48 | |
*** eliqiao has quit IRC | 00:52 | |
gmann | mriedem: Can you please review - https://review.openstack.org/#/c/195412/ | 00:56 |
gmann | mriedem: this is for bug about list server filter with --tenant-id implies all_tenant flag | 00:57 |
*** eliqiao has joined #openstack-nova | 00:57 | |
*** eliqiao has left #openstack-nova | 00:58 | |
*** annegentle has joined #openstack-nova | 01:01 | |
*** boris-42 has quit IRC | 01:02 | |
*** igordcard has quit IRC | 01:04 | |
mriedem | gmann: added myself, won't get to reviewing it tonight | 01:04 |
*** tellesnobrega_ has joined #openstack-nova | 01:05 | |
gmann | mriedem: ohk. Thanks | 01:05 |
*** Jeffrey4l has quit IRC | 01:07 | |
*** kiran-r has joined #openstack-nova | 01:10 | |
*** dprince has quit IRC | 01:10 | |
*** piyanai has joined #openstack-nova | 01:11 | |
*** r-daneel has quit IRC | 01:11 | |
*** armax has quit IRC | 01:12 | |
tonyb | is this http://logs.openstack.org/25/194325/11/check/gate-nova-python27/6cbe0ac/console.html#_2015-07-01_00_04_39_110 a known thing or should I look into it? | 01:14 |
*** heyongli has quit IRC | 01:14 | |
*** heyongli has joined #openstack-nova | 01:15 | |
*** armax has joined #openstack-nova | 01:18 | |
*** changbl has joined #openstack-nova | 01:18 | |
*** ijw has joined #openstack-nova | 01:20 | |
*** Jeffrey4l has joined #openstack-nova | 01:20 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge V2 and V2.1 keypair functional tests https://review.openstack.org/176177 | 01:20 |
*** armax has quit IRC | 01:22 | |
*** zzzeek has quit IRC | 01:23 | |
*** ijw_ has quit IRC | 01:23 | |
*** artom has quit IRC | 01:24 | |
*** patrickeast has quit IRC | 01:24 | |
jaypipes | mriedem, dansmith: :( sorry if you guys are angry at me about adding that section on unit test refactoring to the low-hanging fruit etherpad. | 01:28 |
dansmith | jaypipes: you bastard! | 01:28 |
dansmith | no, it's fine | 01:28 |
jaypipes | dansmith: BTW, did you see my review of the RBD snapshot spec? Looks like jdurgin thinks my proposal will work, with a minor adjustment. | 01:30 |
dansmith | jaypipes: yeah, I didn't read it in depth, but I saw a proposed solution and jdurgin's happy reply | 01:31 |
dansmith | jaypipes: thanks for that | 01:31 |
jaypipes | no worries. | 01:31 |
*** liusheng has joined #openstack-nova | 01:31 | |
dansmith | I knew problems+glance+rbd+jay=solution | 01:31 |
*** Marga_ has joined #openstack-nova | 01:32 | |
*** jlearman has left #openstack-nova | 01:33 | |
*** annashen has joined #openstack-nova | 01:35 | |
*** edleafe has quit IRC | 01:35 | |
*** otter768 has quit IRC | 01:36 | |
*** edleafe has joined #openstack-nova | 01:37 | |
*** andreykurilin__ has quit IRC | 01:37 | |
*** Kevin_Zheng has quit IRC | 01:38 | |
*** shihanzhang has joined #openstack-nova | 01:38 | |
*** Kevin_Zheng has joined #openstack-nova | 01:38 | |
*** tellesnobrega_ has quit IRC | 01:38 | |
*** annashen has quit IRC | 01:39 | |
*** hanzhang has quit IRC | 01:41 | |
*** annegentle has quit IRC | 01:42 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Modified testscenario for micro version 2.4 https://review.openstack.org/197394 | 01:42 |
*** varunarya has joined #openstack-nova | 01:42 | |
mriedem | tonyb: i haven't seen it | 01:42 |
mriedem | infinite loop in someone's change | 01:42 |
tonyb | mriedem: but the vewies that causes that is an update to requirements | 01:48 |
tonyb | mriedem: https://review.openstack.org/#/c/194325/11 | 01:48 |
tonyb | mriedem: if you haven't seen it I'll play locally and see if I can narrow it down to the requirements change | 01:49 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge availability_zone tests between v2 and v2.1 https://review.openstack.org/171017 | 01:49 |
mriedem | tonyb: run it through logstash | 01:51 |
*** ijw_ has joined #openstack-nova | 01:52 | |
dansmith | oye | 01:52 |
*** varunarya has quit IRC | 01:52 | |
dansmith | mriedem: tonyb I bet that's related to the patch we just merged | 01:52 |
dansmith | tonyb: https://review.openstack.org/#/c/197176/ | 01:53 |
dansmith | tonyb: if that fails unreliably, then maybe we need some memory in the test to make sure we don't loop | 01:53 |
* dansmith grumbles again about the circular dep | 01:53 | |
dansmith | tonyb: there is a circular object dependency between fixed and floating ips | 01:53 |
*** ijw has quit IRC | 01:53 | |
*** varunarya has joined #openstack-nova | 01:54 | |
tonyb | dansmith: ok. | 01:54 |
* tonyb will try to understand that test and come up with a fix. | 01:55 | |
mriedem | http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiUnVudGltZUVycm9yOiBtYXhpbXVtIHJlY3Vyc2lvbiBkZXB0aCBleGNlZWRlZFwiIEFORCB0YWdzOlwiY29uc29sZVwiIEFORCBidWlsZF9xdWV1ZTpcImdhdGVcIiBBTkQgYnVpbGRfbmFtZTpcImdhdGUtbm92YS1weXRob24yN1wiIiwiZmllbGRzIjpbXSwib2Zmc2V0IjowLCJ0aW1lZnJhbWUiOiI2MDQ4MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sInN0YW1wIjoxNDM1NzE1Njg3MDU0LCJtb2RlIjoiIiwiYW5hbHl6ZV9maWVsZCI6IiJ9 | 01:55 |
* tonyb really wants the requirements patch to land ;P | 01:55 | |
dansmith | I thought that it stops recursing for objects it knows about, but maybe there is a way for it to slip past | 01:55 |
mriedem | it only failed in the gate on this one change https://review.openstack.org/#/c/197176/ | 01:56 |
mriedem | not sure why the gate didn't kick it out | 01:56 |
tonyb | mriedem: that's the change I want to land :) | 01:57 |
mriedem | tonyb: hmm, that's the only change it's failed in the check queue | 01:59 |
mriedem | which would mean it's fairly rare | 01:59 |
mriedem | tonyb: i guess start by filing a bug | 01:59 |
tonyb | mriedem: or it's related to the new oslo libraries somehow | 01:59 |
mriedem | doubt it | 01:59 |
*** ijw_ has quit IRC | 01:59 | |
mriedem | the only change for oslo.versionedobjects in that g-r update is to exclude 0.5.0 which we aren't testing with anyway since 0.5.1 is out | 02:00 |
mriedem | and i doubt oslo.concurrency is involved | 02:00 |
mriedem | it failed in the gate on https://review.openstack.org/#/c/197176/ but didn't kick it out of the gate, which really confuses me | 02:00 |
tonyb | mriedem: mmkay I'll file a bug with your logstash and then dig into it | 02:01 |
mriedem | alright good b/c i'm bailing out for the night | 02:01 |
mriedem | just make mikal fix it | 02:02 |
*** jwcroppe has quit IRC | 02:02 | |
tonyb | mriedem: I see you need to understand how this "management" thing works ;P | 02:02 |
*** jwcroppe has joined #openstack-nova | 02:02 | |
*** huazhihao has joined #openstack-nova | 02:03 | |
*** yamahata has quit IRC | 02:05 | |
*** jwcroppe has quit IRC | 02:07 | |
*** kylek3h has joined #openstack-nova | 02:07 | |
*** jasondotstar has quit IRC | 02:07 | |
*** annegentle has joined #openstack-nova | 02:08 | |
*** ijw has joined #openstack-nova | 02:09 | |
*** Longgeek_ has joined #openstack-nova | 02:10 | |
*** Kevin_Zheng has quit IRC | 02:10 | |
*** sdake has joined #openstack-nova | 02:11 | |
*** shihanzhang has quit IRC | 02:11 | |
*** shihanzhang has joined #openstack-nova | 02:11 | |
*** varunarya has quit IRC | 02:11 | |
*** Longgeek has quit IRC | 02:12 | |
*** coolsvap|away has quit IRC | 02:13 | |
*** kylek3h has quit IRC | 02:13 | |
*** haomaiwa_ has joined #openstack-nova | 02:14 | |
*** kiran-r has quit IRC | 02:14 | |
*** coolsvap|away has joined #openstack-nova | 02:15 | |
*** piyanai has quit IRC | 02:15 | |
*** mriedem has quit IRC | 02:16 | |
*** mutoulbj has joined #openstack-nova | 02:18 | |
*** huazhihao has quit IRC | 02:18 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_disassociate https://review.openstack.org/161624 | 02:20 |
openstackgerrit | Tony Breeds proposed openstack/nova: libvirt: Correct domxml node name. https://review.openstack.org/197398 | 02:22 |
*** xyang1 has quit IRC | 02:23 | |
*** ijw has quit IRC | 02:25 | |
*** yingjun has quit IRC | 02:26 | |
*** tobe has joined #openstack-nova | 02:29 | |
*** unicell has quit IRC | 02:29 | |
*** yingjun has joined #openstack-nova | 02:30 | |
*** mutoulbj_ has joined #openstack-nova | 02:30 | |
*** mutoulbj has quit IRC | 02:34 | |
*** baoli has joined #openstack-nova | 02:34 | |
*** annashen has joined #openstack-nova | 02:36 | |
*** Kennan has quit IRC | 02:38 | |
*** Kennan has joined #openstack-nova | 02:38 | |
*** haomaiwa_ has quit IRC | 02:39 | |
*** Longgeek_ has quit IRC | 02:39 | |
*** haomaiw__ has joined #openstack-nova | 02:40 | |
*** Longgeek has joined #openstack-nova | 02:41 | |
*** annashen has quit IRC | 02:41 | |
*** marun has joined #openstack-nova | 02:43 | |
*** baoli has quit IRC | 02:47 | |
*** lucas__ has joined #openstack-nova | 02:47 | |
openstackgerrit | Dan Smith proposed openstack/nova: Block subtractive operations in migrations for Kilo and beyond https://review.openstack.org/197349 | 02:49 |
*** baoli has joined #openstack-nova | 02:49 | |
*** unicell has joined #openstack-nova | 02:52 | |
*** gyee has quit IRC | 02:52 | |
*** annegentle has quit IRC | 02:53 | |
*** piyanai has joined #openstack-nova | 02:59 | |
*** annegentle has joined #openstack-nova | 03:04 | |
openstackgerrit | Hiroyuki Eguchi proposed openstack/nova: allow live migration in case of a booted from volume instance https://review.openstack.org/195885 | 03:09 |
*** haomaiw__ has quit IRC | 03:09 | |
*** haomaiwang has joined #openstack-nova | 03:10 | |
*** lucas__ has quit IRC | 03:10 | |
*** Longgeek has quit IRC | 03:14 | |
*** mutoulbj_ has quit IRC | 03:18 | |
openstackgerrit | Hiroyuki Eguchi proposed openstack/nova: allow live migration in case of a booted from volume instance https://review.openstack.org/195885 | 03:21 |
*** mutoulbj has joined #openstack-nova | 03:21 | |
*** lucas__ has joined #openstack-nova | 03:21 | |
*** unicell has quit IRC | 03:22 | |
*** unicell has joined #openstack-nova | 03:23 | |
*** mutoulbj has quit IRC | 03:23 | |
*** lucas__ has quit IRC | 03:26 | |
*** zzzeek has joined #openstack-nova | 03:26 | |
*** zzzeek has quit IRC | 03:26 | |
*** baoli has quit IRC | 03:26 | |
*** annegentle has quit IRC | 03:31 | |
*** mutoulbj has joined #openstack-nova | 03:32 | |
*** SourabhP has quit IRC | 03:35 | |
*** annashen has joined #openstack-nova | 03:37 | |
*** otter768 has joined #openstack-nova | 03:37 | |
*** annegentle has joined #openstack-nova | 03:38 | |
*** jyuso1 has joined #openstack-nova | 03:41 | |
*** annashen has quit IRC | 03:41 | |
*** otter768 has quit IRC | 03:42 | |
*** jecarey has joined #openstack-nova | 03:43 | |
*** Longgeek has joined #openstack-nova | 03:44 | |
*** yingjun has quit IRC | 03:45 | |
*** hemna has joined #openstack-nova | 03:45 | |
*** ildikov has quit IRC | 03:47 | |
*** annegentle has quit IRC | 03:48 | |
*** Longgeek has quit IRC | 03:49 | |
*** jogo has joined #openstack-nova | 03:50 | |
*** varunarya has joined #openstack-nova | 03:50 | |
*** hemna has quit IRC | 03:53 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: glance:check the num_retries option https://review.openstack.org/123318 | 03:55 |
*** liusheng has quit IRC | 03:55 | |
*** liusheng has joined #openstack-nova | 03:55 | |
*** heyongli has quit IRC | 03:57 | |
*** heyongli has joined #openstack-nova | 03:58 | |
*** Jeffrey4l has quit IRC | 03:58 | |
*** Jeffrey4l has joined #openstack-nova | 03:59 | |
*** jwcroppe has joined #openstack-nova | 04:00 | |
*** ijw has joined #openstack-nova | 04:02 | |
*** sudipto has joined #openstack-nova | 04:02 | |
*** varunarya has quit IRC | 04:02 | |
*** dims_ has quit IRC | 04:03 | |
*** tojuvone has joined #openstack-nova | 04:04 | |
*** asettle has joined #openstack-nova | 04:06 | |
*** heyongli has quit IRC | 04:07 | |
*** heyongli has joined #openstack-nova | 04:08 | |
*** Alexandra_ has joined #openstack-nova | 04:08 | |
*** dave-mccowan has quit IRC | 04:09 | |
*** armax has joined #openstack-nova | 04:10 | |
*** asettle has quit IRC | 04:10 | |
*** coolsvap|away is now known as coolsvap | 04:14 | |
*** Alexandra_ has quit IRC | 04:14 | |
*** xyhuang has joined #openstack-nova | 04:19 | |
*** achanda has joined #openstack-nova | 04:19 | |
*** hemna has joined #openstack-nova | 04:20 | |
*** hemna has quit IRC | 04:21 | |
*** jecarey has quit IRC | 04:21 | |
*** morganfainberg is now known as caerbannograbbit | 04:24 | |
*** caerbannograbbit is now known as CaerbannogRabbit | 04:24 | |
*** tobe has quit IRC | 04:26 | |
*** piyanai has quit IRC | 04:31 | |
*** Longgeek has joined #openstack-nova | 04:34 | |
*** ijw has quit IRC | 04:35 | |
*** annashen has joined #openstack-nova | 04:37 | |
*** achanda has quit IRC | 04:38 | |
*** browne1 has joined #openstack-nova | 04:40 | |
*** browne has quit IRC | 04:40 | |
*** kiran-r has joined #openstack-nova | 04:41 | |
*** nkrinner has joined #openstack-nova | 04:41 | |
*** annashen has quit IRC | 04:42 | |
*** fawadkhaliq has joined #openstack-nova | 04:43 | |
*** ajayaa_ has joined #openstack-nova | 04:45 | |
*** garyk has joined #openstack-nova | 04:46 | |
*** annegentle has joined #openstack-nova | 04:49 | |
*** garyk has quit IRC | 04:49 | |
*** garyk1 has joined #openstack-nova | 04:49 | |
*** ijw has joined #openstack-nova | 04:49 | |
*** irenab has joined #openstack-nova | 04:54 | |
*** annegentle has quit IRC | 04:55 | |
*** kiran-r has quit IRC | 04:56 | |
*** kiran-r has joined #openstack-nova | 04:56 | |
*** nihilifer has joined #openstack-nova | 04:58 | |
*** ajayaa_ has quit IRC | 05:01 | |
*** pkholkin has joined #openstack-nova | 05:02 | |
*** tdurakov has joined #openstack-nova | 05:02 | |
*** snikitin has joined #openstack-nova | 05:02 | |
*** sudipto has quit IRC | 05:02 | |
*** Nikolay_St has joined #openstack-nova | 05:06 | |
*** dims has joined #openstack-nova | 05:07 | |
*** exploreshaifali has joined #openstack-nova | 05:10 | |
*** dims has quit IRC | 05:12 | |
*** arnaud____ has joined #openstack-nova | 05:17 | |
*** _gryf|afk is now known as _gryf | 05:19 | |
*** Dev_Jin has joined #openstack-nova | 05:21 | |
*** arnaud____ has quit IRC | 05:22 | |
*** prashant__ has joined #openstack-nova | 05:23 | |
*** huazhihao has joined #openstack-nova | 05:23 | |
*** marun has quit IRC | 05:23 | |
*** tobe has joined #openstack-nova | 05:26 | |
*** snikitin has quit IRC | 05:28 | |
*** snikitin has joined #openstack-nova | 05:28 | |
*** heyongli has quit IRC | 05:30 | |
*** prashant_ has joined #openstack-nova | 05:31 | |
*** haomaiwang has quit IRC | 05:33 | |
*** oro has joined #openstack-nova | 05:34 | |
*** prashant__ has quit IRC | 05:34 | |
*** ijw has quit IRC | 05:36 | |
*** heyongli has joined #openstack-nova | 05:37 | |
*** haomaiwa_ has joined #openstack-nova | 05:38 | |
*** otter768 has joined #openstack-nova | 05:38 | |
*** annashen has joined #openstack-nova | 05:39 | |
*** mmedvede has quit IRC | 05:40 | |
*** kaisers1 has quit IRC | 05:43 | |
*** otter768 has quit IRC | 05:43 | |
*** annashen has quit IRC | 05:43 | |
*** garyk1 has quit IRC | 05:45 | |
*** garyk has joined #openstack-nova | 05:47 | |
*** prashant__ has joined #openstack-nova | 05:54 | |
*** jgrimm is now known as zz_jgrimm | 05:55 | |
*** garyk has quit IRC | 05:56 | |
*** jdurgin has quit IRC | 05:57 | |
*** prashant_ has quit IRC | 05:57 | |
*** garyk has joined #openstack-nova | 05:57 | |
*** prashant_ has joined #openstack-nova | 05:58 | |
*** varunarya has joined #openstack-nova | 05:59 | |
*** tobe has quit IRC | 05:59 | |
*** davideag_ has quit IRC | 06:00 | |
openstackgerrit | Jesse J. Cook proposed openstack/nova: Cells: distribute build requests across cells https://review.openstack.org/195757 | 06:00 |
openstackgerrit | Jesse J. Cook proposed openstack/nova: Cells: - weight_offset; + selection_multiplier https://review.openstack.org/197424 | 06:00 |
openstackgerrit | Jesse J. Cook proposed openstack/nova: Cells: decrement available slots https://review.openstack.org/197425 | 06:00 |
*** prashant__ has quit IRC | 06:01 | |
*** prashant__ has joined #openstack-nova | 06:02 | |
*** fawadkhaliq has quit IRC | 06:04 | |
*** SourabhP has joined #openstack-nova | 06:05 | |
*** prashant_ has quit IRC | 06:06 | |
*** deepthi has joined #openstack-nova | 06:06 | |
*** prashant_ has joined #openstack-nova | 06:07 | |
*** oro has quit IRC | 06:07 | |
*** prashant__ has quit IRC | 06:10 | |
*** prashant__ has joined #openstack-nova | 06:11 | |
*** SourabhP has quit IRC | 06:12 | |
*** prashant_ has quit IRC | 06:15 | |
*** gokrokve has joined #openstack-nova | 06:16 | |
*** Murali has joined #openstack-nova | 06:16 | |
*** garyk has quit IRC | 06:16 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/197213 | 06:16 |
*** prashant_ has joined #openstack-nova | 06:16 | |
*** Jeffrey4l has quit IRC | 06:17 | |
*** gokrokve has quit IRC | 06:18 | |
*** prashant__ has quit IRC | 06:19 | |
*** ajayaa_ has joined #openstack-nova | 06:19 | |
*** marun has joined #openstack-nova | 06:20 | |
*** scheuran has joined #openstack-nova | 06:20 | |
*** browne1 has quit IRC | 06:21 | |
*** irenab has quit IRC | 06:22 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge server password tests between v2 and v2.1 https://review.openstack.org/197435 | 06:22 |
*** prashant_ has quit IRC | 06:23 | |
*** fawadkhaliq has joined #openstack-nova | 06:25 | |
*** marun has quit IRC | 06:25 | |
*** varunarya has quit IRC | 06:26 | |
*** fawadkhaliq has quit IRC | 06:31 | |
*** yingjun has joined #openstack-nova | 06:34 | |
*** ianbrown has quit IRC | 06:35 | |
*** tdurakov has quit IRC | 06:35 | |
*** pkholkin has quit IRC | 06:35 | |
*** snikitin has quit IRC | 06:36 | |
openstackgerrit | Feodor Tersin proposed openstack/nova: Ignore image's min_disk and size for volume-backed instances https://review.openstack.org/196569 | 06:39 |
*** yamahata has joined #openstack-nova | 06:39 | |
*** sahid has joined #openstack-nova | 06:39 | |
*** annashen has joined #openstack-nova | 06:39 | |
*** asettle has joined #openstack-nova | 06:43 | |
*** annashen has quit IRC | 06:44 | |
*** moshele has joined #openstack-nova | 06:46 | |
*** radek_ has joined #openstack-nova | 06:48 | |
*** ildikov has joined #openstack-nova | 06:49 | |
*** annegentle has joined #openstack-nova | 06:51 | |
*** radek_ has quit IRC | 06:52 | |
*** tobe has joined #openstack-nova | 06:53 | |
*** prashant_ has joined #openstack-nova | 06:53 | |
*** garyk has joined #openstack-nova | 06:53 | |
*** radek_ has joined #openstack-nova | 06:53 | |
*** belmoreira has joined #openstack-nova | 06:54 | |
*** snikitin has joined #openstack-nova | 06:56 | |
*** pkholkin has joined #openstack-nova | 06:56 | |
*** tdurakov has joined #openstack-nova | 06:56 | |
*** annegentle has quit IRC | 06:56 | |
*** ndipanov has quit IRC | 06:57 | |
*** prashant__ has joined #openstack-nova | 06:58 | |
*** otter768 has joined #openstack-nova | 07:00 | |
*** prashant_ has quit IRC | 07:02 | |
*** Marga_ has quit IRC | 07:02 | |
*** doude has joined #openstack-nova | 07:03 | |
*** asettle has quit IRC | 07:04 | |
*** otter768 has quit IRC | 07:06 | |
*** prashant_ has joined #openstack-nova | 07:06 | |
*** huazhihao has quit IRC | 07:07 | |
*** irenab has joined #openstack-nova | 07:09 | |
*** prashant__ has quit IRC | 07:10 | |
*** prashant__ has joined #openstack-nova | 07:10 | |
*** matrohon has joined #openstack-nova | 07:12 | |
*** abhishekk has joined #openstack-nova | 07:12 | |
*** mpavone has joined #openstack-nova | 07:12 | |
*** prashant_ has quit IRC | 07:14 | |
*** prashant_ has joined #openstack-nova | 07:16 | |
*** armax has quit IRC | 07:18 | |
openstackgerrit | sahid proposed openstack/nova-specs: console: convert consoles code to use objects framework https://review.openstack.org/165838 | 07:20 |
*** prashant__ has quit IRC | 07:20 | |
*** romainh has joined #openstack-nova | 07:22 | |
*** Jeffrey4l has joined #openstack-nova | 07:23 | |
*** subscope has quit IRC | 07:24 | |
*** lyarwood has quit IRC | 07:25 | |
*** lyarwood has joined #openstack-nova | 07:26 | |
*** prashant__ has joined #openstack-nova | 07:26 | |
*** Kevin_Zheng has joined #openstack-nova | 07:29 | |
*** mjturek1 has quit IRC | 07:29 | |
*** mnestratov|2 has joined #openstack-nova | 07:29 | |
*** prashant_ has quit IRC | 07:30 | |
*** mjturek1 has joined #openstack-nova | 07:30 | |
*** Jeffrey4l has quit IRC | 07:31 | |
*** Jeffrey4l has joined #openstack-nova | 07:31 | |
*** zz_jgrimm has quit IRC | 07:31 | |
*** mpaolino has joined #openstack-nova | 07:32 | |
*** zhenguo has quit IRC | 07:32 | |
*** mnestratov has quit IRC | 07:32 | |
*** zhenguo has joined #openstack-nova | 07:33 | |
*** zz_jgrimm has joined #openstack-nova | 07:33 | |
*** prashant_ has joined #openstack-nova | 07:33 | |
*** haypo has joined #openstack-nova | 07:34 | |
*** unicell has quit IRC | 07:35 | |
*** subscope has joined #openstack-nova | 07:37 | |
*** prashant__ has quit IRC | 07:37 | |
*** prashant__ has joined #openstack-nova | 07:39 | |
*** annashen has joined #openstack-nova | 07:40 | |
*** yingjun has quit IRC | 07:41 | |
*** Marga_ has joined #openstack-nova | 07:42 | |
*** yingjun has joined #openstack-nova | 07:42 | |
*** jlanoux has joined #openstack-nova | 07:43 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for floating_ip_dns https://review.openstack.org/150710 | 07:43 |
*** prashant_ has quit IRC | 07:43 | |
*** eliqiao has joined #openstack-nova | 07:44 | |
*** eliqiao has left #openstack-nova | 07:45 | |
*** annashen has quit IRC | 07:45 | |
*** jistr has joined #openstack-nova | 07:45 | |
*** prashant_ has joined #openstack-nova | 07:46 | |
openstackgerrit | wangxiyuan proposed openstack/python-novaclient: Add 'deleted' status check in image-create https://review.openstack.org/197457 | 07:46 |
*** jcoufal has joined #openstack-nova | 07:49 | |
*** prashant__ has quit IRC | 07:50 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host https://review.openstack.org/161625 | 07:51 |
*** lucasagomes has joined #openstack-nova | 07:51 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host https://review.openstack.org/161625 | 07:51 |
*** prashant__ has joined #openstack-nova | 07:52 | |
*** kiran-r has quit IRC | 07:52 | |
*** prashant_ has quit IRC | 07:55 | |
*** mpaolino has quit IRC | 07:56 | |
*** liudong has joined #openstack-nova | 07:57 | |
openstackgerrit | sahid proposed openstack/nova-specs: Libvirt real time instances https://review.openstack.org/139688 | 07:57 |
*** eglynn has joined #openstack-nova | 07:57 | |
*** prashant_ has joined #openstack-nova | 07:58 | |
liudong | \? | 07:59 |
*** liudong has left #openstack-nova | 07:59 | |
*** karimb has joined #openstack-nova | 08:01 | |
openstackgerrit | Rui Chen proposed openstack/nova: Fix incomplete error message of quota exceeded https://review.openstack.org/197460 | 08:02 |
*** prashant__ has quit IRC | 08:02 | |
*** Marga_ has quit IRC | 08:02 | |
*** apuimedo_ has joined #openstack-nova | 08:07 | |
*** prashant__ has joined #openstack-nova | 08:08 | |
*** marun has joined #openstack-nova | 08:09 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host https://review.openstack.org/161625 | 08:09 |
*** kylek3h has joined #openstack-nova | 08:09 | |
*** prashant_ has quit IRC | 08:12 | |
*** prashant_ has joined #openstack-nova | 08:13 | |
*** BobBall_AWOL is now known as BobBall | 08:14 | |
*** marun has quit IRC | 08:14 | |
*** kylek3h has quit IRC | 08:15 | |
*** prashant__ has quit IRC | 08:17 | |
*** prashant__ has joined #openstack-nova | 08:21 | |
*** liusheng has quit IRC | 08:23 | |
*** arnaud____ has joined #openstack-nova | 08:23 | |
*** liusheng has joined #openstack-nova | 08:23 | |
*** Marga_ has joined #openstack-nova | 08:23 | |
*** prashant_ has quit IRC | 08:25 | |
*** yamahata has quit IRC | 08:26 | |
openstackgerrit | Jeffrey Zhang proposed openstack/nova: Support all_tenants search_opts for neutron https://review.openstack.org/187657 | 08:26 |
*** danpb has joined #openstack-nova | 08:27 | |
*** arnaud____ has quit IRC | 08:28 | |
*** lsmola has joined #openstack-nova | 08:29 | |
*** prashant_ has joined #openstack-nova | 08:31 | |
*** exploreshaifali has quit IRC | 08:35 | |
*** prashant__ has quit IRC | 08:35 | |
*** mutoulbj_ has joined #openstack-nova | 08:36 | |
*** yassine__ has joined #openstack-nova | 08:36 | |
*** prashant__ has joined #openstack-nova | 08:37 | |
*** obondarev has joined #openstack-nova | 08:39 | |
*** rdo has quit IRC | 08:39 | |
*** mutoulbj has quit IRC | 08:39 | |
*** dguitarbite has quit IRC | 08:40 | |
*** lpetrut has joined #openstack-nova | 08:40 | |
*** rdo has joined #openstack-nova | 08:41 | |
*** prashant_ has quit IRC | 08:41 | |
*** annashen has joined #openstack-nova | 08:41 | |
*** prashant_ has joined #openstack-nova | 08:43 | |
*** annashen has quit IRC | 08:46 | |
*** pixelb has joined #openstack-nova | 08:46 | |
*** prashant__ has quit IRC | 08:47 | |
*** aix has joined #openstack-nova | 08:48 | |
*** jasondotstar has joined #openstack-nova | 08:48 | |
*** prashant__ has joined #openstack-nova | 08:48 | |
*** prashant_ has quit IRC | 08:52 | |
*** prashup has joined #openstack-nova | 08:52 | |
*** irenab has quit IRC | 08:54 | |
*** prashant__ has quit IRC | 08:55 | |
*** irenab has joined #openstack-nova | 08:55 | |
*** prashant_ has joined #openstack-nova | 08:55 | |
*** humble_ has quit IRC | 08:57 | |
*** prashup has quit IRC | 08:59 | |
johnthetubaguy | danpb: I think your vif lib depends on this spec, any chance you could give that a review please? https://review.openstack.org/#/c/190917/6/specs/liberty/approved/nova-neutron-binding-negotiation.rst,cm | 09:00 |
johnthetubaguy | danpb: it would be good to quickly catch up on your plans for the os-vif-lib effort | 09:01 |
johnthetubaguy | danpb: is it something you think can make progress during liberty, like would making it a priority help? | 09:01 |
*** prashant__ has joined #openstack-nova | 09:02 | |
*** otter768 has joined #openstack-nova | 09:02 | |
*** prashant_ has quit IRC | 09:05 | |
*** exploreshaifali has joined #openstack-nova | 09:06 | |
*** prashup has joined #openstack-nova | 09:06 | |
*** liudong has joined #openstack-nova | 09:06 | |
*** otter768 has quit IRC | 09:07 | |
openstackgerrit | Roman Dobosz proposed openstack/nova: Introducing new forced_down field for a Service object https://review.openstack.org/185280 | 09:07 |
openstackgerrit | Roman Dobosz proposed openstack/nova: New nova API call to mark nova-compute down https://review.openstack.org/184086 | 09:07 |
openstackgerrit | Roman Dobosz proposed openstack/nova: Service group drivers forced_down flag utilization https://review.openstack.org/197063 | 09:07 |
openstackgerrit | Roman Dobosz proposed openstack/nova: Refactoring of the os-services module https://review.openstack.org/185279 | 09:07 |
openstackgerrit | Rong Han proposed openstack/nova: modify '<nosharedpages/>' to '<nosharepages/>'. https://review.openstack.org/197480 | 09:08 |
*** xgsa1 has joined #openstack-nova | 09:08 | |
*** dims has joined #openstack-nova | 09:08 | |
*** prashant__ has quit IRC | 09:09 | |
openstackgerrit | Rong Han proposed openstack/nova: modify '<nosharedpages/>' to '<nosharepages/>'. https://review.openstack.org/197480 | 09:12 |
*** irenab has quit IRC | 09:12 | |
*** prashant_ has joined #openstack-nova | 09:13 | |
*** irenab has joined #openstack-nova | 09:14 | |
*** dims has quit IRC | 09:14 | |
*** rajesht has joined #openstack-nova | 09:15 | |
*** xgsa has quit IRC | 09:15 | |
rajesht | hi | 09:16 |
rajesht | can anybody tell me how can I downgrade my db schema | 09:16 |
rajesht | I tried nova-manage db sync <migrate_version_to_downgrade> | 09:16 |
rajesht | but looks like the support is removed for it. | 09:17 |
rajesht | could you please tell me any other alternatives ? | 09:17 |
bauzas | rajesht: https://github.com/openstack/openstack-specs/blob/master/specs/no-downward-sql-migration.rst | 09:17 |
*** prashup has quit IRC | 09:17 | |
*** prashant__ has joined #openstack-nova | 09:18 | |
rajesht | bauzas: https://github.com/openstack/openstack-specs/blob/master/specs/no-downward-sql-migration.rst#alternatives | 09:19 |
rajesht | bauzas: thanks, I checked that but couldn't find other alternative. | 09:19 |
bauzas | rajesht: read the references | 09:20 |
rajesht | bauzas: thanks, will go through it | 09:21 |
*** haomaiwa_ has quit IRC | 09:21 | |
*** prashant_ has quit IRC | 09:22 | |
*** afazekas has joined #openstack-nova | 09:24 | |
johnthetubaguy | rajesht: let us know if thats an issue, but you are right, we have dropped db downgrades, mostly because they basically don't work, so we wanted to stop people using a broken thing. Let us know if there are more docs we need so its clear what the recommended route is. | 09:25 |
johnthetubaguy | rajesht: there is an expectation on testing out migrations on backups of production DBs before doing it in production, etc, etc. | 09:25 |
*** prashant_ has joined #openstack-nova | 09:27 | |
rajesht | johnthetubaguy: there is no issue, I just wanted to downgrade db schema for testing purpose. | 09:27 |
rajesht | johnthetubaguy: https://github.com/openstack/openstack-specs/blob/master/specs/no-downward-sql-migration.rst#alternatives | 09:27 |
johnthetubaguy | rajesht: ah, I see | 09:27 |
rajesht | johnthetubaguy: is there any alternative ? | 09:27 |
rajesht | johnthetubaguy: as mentioned in above link | 09:27 |
johnthetubaguy | rajesht: so that spec section is about alternatives to the implementation, not replacements | 09:28 |
johnthetubaguy | rajesht: in summary, there is no way to downgrade any more | 09:28 |
rajesht | johnthetubaguy: oh, got it. | 09:28 |
rajesht | johnthetubaguy: thanks :) | 09:28 |
johnthetubaguy | rajesht: now I don't remember us discussing test uses of the feature, so thats interesting | 09:28 |
openstackgerrit | Rong Han proposed openstack/nova: modify '<nosharedpages/>' to '<nosharepages/>'. https://review.openstack.org/197486 | 09:29 |
*** yingjun has quit IRC | 09:30 | |
tojuvone | bauzas: I'd like to continue still the "mark host down" by having it updating somehow the server states, just should get this forwards and do it within liberty: https://review.openstack.org/192246 | 09:30 |
*** dheeraj-gupta-4 has joined #openstack-nova | 09:31 | |
*** prashant__ has quit IRC | 09:31 | |
*** aix has quit IRC | 09:31 | |
*** prashant__ has joined #openstack-nova | 09:32 | |
*** prashant_ has quit IRC | 09:36 | |
*** ociuhandu has quit IRC | 09:39 | |
*** prashant_ has joined #openstack-nova | 09:40 | |
*** liudong has quit IRC | 09:42 | |
*** annashen has joined #openstack-nova | 09:42 | |
*** prashant__ has quit IRC | 09:43 | |
*** bradjones has quit IRC | 09:44 | |
*** sdake has quit IRC | 09:46 | |
*** bradjones has joined #openstack-nova | 09:46 | |
*** bradjones has quit IRC | 09:46 | |
*** bradjones has joined #openstack-nova | 09:46 | |
*** annashen has quit IRC | 09:46 | |
danpb | johnthetubaguy: so in the VIF config object/plugins spec, really the only issue is getting buy in / sign off from all the required parties in Nova and Neutron | 09:47 |
BobBall | johnthetubaguy: Don't forget to give me a +2 on https://review.openstack.org/#/c/193647/ ! :) | 09:47 |
*** mikeit has joined #openstack-nova | 09:47 | |
*** prashant__ has joined #openstack-nova | 09:47 | |
danpb | johnthetubaguy: given the timing, i was somewhat unsure whether that was at all practical for Liberty or would have to wait until the Muppet cycle | 09:47 |
johnthetubaguy | danpb: just worried the dependent spec isn't getting much review | 09:47 |
abhishekk | snikitin: hi, you around? | 09:48 |
danpb | johnthetubaguy: i just commented in that spec - i'm wondering if we should just fold it into the other spec | 09:48 |
danpb | johnthetubaguy: as it is really mutually dependant at the implementation point | 09:48 |
danpb | and is a pretty minor detail in the bigger picture so possibly doesn't need to be a separate spec | 09:48 |
johnthetubaguy | danpb: hmm, maybe, I just think the spec is too big already, the other is quite nice and self contained at the moment, which might be handy | 09:49 |
johnthetubaguy | danpb: I guess this could rumble on outside of nova quite happily, maybe approving it on the backlog might be better? | 09:49 |
johnthetubaguy | danpb: so leave the integration with Nova bit to Muppet, although that feels like a shame | 09:50 |
danpb | the problem is that the impl of the other spec would need to quite significantly change | 09:50 |
*** ftersin has joined #openstack-nova | 09:50 | |
snikitin | abhishekk: I'm here | 09:50 |
*** prashant_ has quit IRC | 09:51 | |
danpb | what is proposed is to just pass a list of vif type names, which is insufficient for the bigger spec | 09:51 |
abhishekk | snikitin: sorry to disturb, any update on NFS shared storage space count? | 09:51 |
johnthetubaguy | danpb: ah, OK | 09:51 |
johnthetubaguy | danpb: you want to version the data, or make it richer in some way? | 09:51 |
danpb | yes, we need to include version information primarily | 09:52 |
johnthetubaguy | I see that as neutron's API | 09:52 |
danpb | but also, the single list will have to split into two lists | 09:52 |
johnthetubaguy | so really they should have the spec for that API | 09:52 |
danpb | as we need to represent VIF configs separately from VIF plugins | 09:52 |
abhishekk | snikitin: are you planning to prepare specs for this? | 09:52 |
danpb | ultimately the data that we need to supply from nova to neutron will be determined by the design of the os-vif object model | 09:53 |
danpb | johnthetubaguy: yes, the split of responsibility between neutron & nova is complex - technically it is neutron's API we're calling | 09:53 |
*** prashant_ has joined #openstack-nova | 09:53 | |
danpb | johnthetubaguy: but the bulk of the data handling burden probably falls on nova | 09:54 |
johnthetubaguy | danpb: so I am thinking we should do a virtual summit session on this? | 09:54 |
johnthetubaguy | danpb: well, virtual midcycle thing | 09:55 |
danpb | i guess anything to get the nova and neutron cores to talk & agre on direction would be useful | 09:55 |
danpb | if we can't do that in the spec, then a virtual meeting would work | 09:55 |
johnthetubaguy | I think we need something high bandwidth here, to make it quicker | 09:56 |
johnthetubaguy | it feels that way | 09:56 |
johnthetubaguy | so here is an idea | 09:56 |
*** lucas__ has joined #openstack-nova | 09:56 | |
danpb | btw, there is one way to make the work a bit more managable if we don't want to agree on a stable API right away | 09:56 |
johnthetubaguy | danpb: I think we have to do oslo incubator style for a release | 09:57 |
danpb | we could define the VIF config object classes inside nova, and convert Nova to use them, and provide some legacy plugin impls | 09:57 |
johnthetubaguy | danpb: yep, I think thats what I am trying to say be oslo incubator style, but in reverse | 09:57 |
danpb | this would prove the design without having to commit to anything public between nova & neutron | 09:57 |
johnthetubaguy | yeah | 09:57 |
*** prashant__ has quit IRC | 09:57 | |
openstackgerrit | Dheeraj Gupta proposed openstack/nova: Add HostMapping object https://review.openstack.org/192098 | 09:57 |
*** marun has joined #openstack-nova | 09:58 | |
danpb | basically this would do 100% of the nova side of the work, but we'd simply not allow neutron to request any of the new VIF types | 09:58 |
danpb | neutron would continue 100% with existing VIF types and nova would silently convert them ot the new types internally | 09:58 |
johnthetubaguy | danpb: so I think a "go refactor" very lightweight spec that gives some ground rules is the best way to go | 09:58 |
johnthetubaguy | yeah, I like that | 09:58 |
*** aix has joined #openstack-nova | 09:58 | |
danpb | this would probably mean this ends up spanning 2 cycles | 09:58 |
johnthetubaguy | agreed, but it should mean it actually happens, which is great | 09:59 |
danpb | we'd still want to ensure neutron folks buy into the design though | 09:59 |
*** dims has joined #openstack-nova | 09:59 | |
danpb | so that once we've converted nova they don't complain about what we ended up with | 09:59 |
johnthetubaguy | so I have a feeling this is an "add a seam", then discuss kind of problem | 10:00 |
*** sudipto has joined #openstack-nova | 10:00 | |
johnthetubaguy | lets do what looks best on our side, then take what we have to neutron to see if we need to evolve that? | 10:00 |
johnthetubaguy | I mean we should talk to them about the ideas too | 10:00 |
danpb | so far everyone from neutron commenting on the spec has been positive | 10:00 |
danpb | but i'm not sure who the really important people are in neutron core who need convincing | 10:01 |
danpb | and whether they've actually looked at it | 10:01 |
*** lucas__ has quit IRC | 10:01 | |
sahid | mikal: i had to fix some typos and add a note on the spec https://review.openstack.org/#/c/139688/ can we re-have your +2 please | 10:01 |
snikitin | abhishekk: Unfortunately I have bad news :( 25 June we got a nova-spec-freeze. https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule So I can't merge spec in Liberty ( Nova community have a very short time to merge a spec. And my team doesn't merged no one spec in Liberty. Sorry, but I cant do it in Lyberty( If you really need this spec I think it would be better to find another developer, because my work on this spec goes very slow.. Sorry | 10:01 |
*** _gryf has quit IRC | 10:02 | |
abhishekk | snikitin: no problem, could you please share your ideas with me if possible? | 10:02 |
*** marun has quit IRC | 10:02 | |
abhishekk | abhishekk: when you get some time? | 10:02 |
*** mutoulbj_ has quit IRC | 10:03 | |
johnthetubaguy | danpb: so I think we need to get a virtual meeting together to discuss things, any chance you can work with kyle to get that arranged? | 10:04 |
danpb | i'm actually about to go on holiday for 2 weeks, so we'll probably have to wait till i return at this point | 10:05 |
danpb | eg, 2nd half of july | 10:05 |
*** _gryf has joined #openstack-nova | 10:05 | |
*** prashant__ has joined #openstack-nova | 10:08 | |
*** itzikb_ has joined #openstack-nova | 10:08 | |
itzikb_ | heyongli: hi, can you please comment on https://bugs.launchpad.net/nova/+bug/1466451? | 10:08 |
openstack | Launchpad bug 1466451 in OpenStack Compute (nova) "Nova should verify that devname in pci_passthrough_whitelist is not empty" [Undecided,In progress] - Assigned to Wen Zhi Yu (yuywz) | 10:08 |
openstackgerrit | sahid proposed openstack/nova-specs: console: convert consoles code to use objects framework https://review.openstack.org/165838 | 10:09 |
snikitin | abhishekk: Ok. give me some time | 10:10 |
danpb | btw, do we actually have a Mxxx release name yet ? i've just been calling it Muppet so far | 10:10 |
abhishekk | snikitin: sure, thank you | 10:10 |
*** prashant_ has quit IRC | 10:11 | |
*** prashant_ has joined #openstack-nova | 10:12 | |
johnthetubaguy | danpb: ah, thats a good heads up, OK, sounds like it has to wait | 10:12 |
johnthetubaguy | danpb: I think the TC said there were trademark issues being chased, I think | 10:12 |
*** prashant__ has quit IRC | 10:15 | |
ftersin | danpb: hi. could you please answer my questions in https://review.openstack.org/#/c/170243 ? it would be great to have your answers before your vacation | 10:15 |
*** Dev_Jin has quit IRC | 10:15 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Store correct VirtCPUTopology https://review.openstack.org/197125 | 10:16 |
*** romainh has quit IRC | 10:16 | |
bauzas | danpb: not sure you saw http://civs.cs.cornell.edu/cgi-bin/results.pl?id=E_4983776e190c8dbc | 10:19 |
*** prashant__ has joined #openstack-nova | 10:19 | |
*** dheeraj-gupta-4 has quit IRC | 10:19 | |
bauzas | danpb: like johnthetubaguy said, it's under the hood of the foundation for any tm issues | 10:19 |
danpb | ftersin: ok, i've replied but not in general that when patches are showing in merge conflict they tend to be ignored by reviewers | 10:19 |
danpb | s/not/note/ | 10:20 |
*** prashant_ has quit IRC | 10:22 | |
ftersin | thanks, will keep it on mind | 10:23 |
*** Dev_Jin has joined #openstack-nova | 10:24 | |
*** prashup has joined #openstack-nova | 10:24 | |
*** xgsa1 has quit IRC | 10:24 | |
*** lpetrut has quit IRC | 10:24 | |
*** prashant__ has quit IRC | 10:26 | |
johnthetubaguy | snikitin: abhishekk: we are going through the spec freeze process right now to make sure we didn't miss any major ones, which is the spec you are needing? | 10:29 |
*** prashant_ has joined #openstack-nova | 10:29 | |
*** xgsa has joined #openstack-nova | 10:32 | |
ftersin | danpb: could you also answer the second question in the commit message: how to split the patch | 10:32 |
*** prashup has quit IRC | 10:33 | |
*** Marga_ has quit IRC | 10:34 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Enable python34 tests for nova/tests/unit/objects/test*.py https://review.openstack.org/187785 | 10:34 |
*** prashant__ has joined #openstack-nova | 10:34 | |
*** ndipanov has joined #openstack-nova | 10:36 | |
*** prashant_ has quit IRC | 10:38 | |
tonyb | johnthetubaguy: Can you look at: https://review.openstack.org/#/c/197507/ (Update XenAPI team meeting) and +1 if you're cool with it | 10:38 |
johnthetubaguy | tonyb: sure, thanks for pointing at that one | 10:39 |
*** exploreshaifali has quit IRC | 10:39 | |
* BobBall steals the powah! | 10:40 | |
tonyb | johnthetubaguy: np. | 10:40 |
* tonyb waves at BobBall | 10:40 | |
*** prashant_ has joined #openstack-nova | 10:40 | |
johnthetubaguy | BobBall: can you create a Xen subteam for things like this: https://review.openstack.org/#/c/193647/ you do that by looking at the usual etherpad (down the bottom) https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 10:40 |
* BobBall waves back | 10:40 | |
BobBall | Sure thing johnthetubaguy | 10:41 |
BobBall | Anyone at rax who should be named as a subteam member there? | 10:42 |
*** annashen has joined #openstack-nova | 10:43 | |
johnthetubaguy | BobBall: not sure right now | 10:43 |
*** prashant__ has quit IRC | 10:43 | |
*** gszasz has joined #openstack-nova | 10:43 | |
johnthetubaguy | BobBall: not needing to do loads of work on the driver right now | 10:43 |
BobBall | Indeed - Loving the stability. As long as you don't use the console... (the race I just fixed :D) | 10:44 |
johnthetubaguy | BobBall: being asking for test to check that since I wrote it, they still haven't got to that | 10:45 |
*** lucasagomes is now known as lucas-bbl | 10:45 | |
*** prashant__ has joined #openstack-nova | 10:46 | |
*** claudiub has joined #openstack-nova | 10:46 | |
BobBall | huh? *confused* | 10:46 |
openstackgerrit | Rui Chen proposed openstack/nova: Fix incomplete error message of quota exceeded https://review.openstack.org/197460 | 10:47 |
*** annashen has quit IRC | 10:48 | |
*** prashant_ has quit IRC | 10:49 | |
*** prashant_ has joined #openstack-nova | 10:51 | |
*** mutoulbj has joined #openstack-nova | 10:53 | |
*** zhenguo has quit IRC | 10:54 | |
snikitin | johnthetubaguy, abhishekk: We need a spec about "right" way of working with shared storages like Ceph. Because nova has a several bugs about incorrect statistics of shared storages. https://bugs.launchpad.net/nova/+bug/1252321 https://bugs.launchpad.net/nova/+bug/1387812 https://bugs.launchpad.net/nova/+bug/1414432 | 10:54 |
openstack | Launchpad bug 1252321 in OpenStack Compute (nova) "Nova counts NFS shared storage space on each node" [Medium,Confirmed] | 10:54 |
openstack | Launchpad bug 1387812 in OpenStack Compute (nova) "Hypervisor summary shows incorrect total storage (Ceph)" [Low,In progress] - Assigned to Sergey Nikitin (snikitin) | 10:54 |
openstack | Launchpad bug 1414432 in OpenStack Compute (nova) "nova hypervisor-stats shows wrong disk usage with shared storage" [Low,Confirmed] - Assigned to ChangBo Guo(gcb) (glongwave) | 10:54 |
*** prashant__ has quit IRC | 10:55 | |
*** prashant_ has quit IRC | 10:58 | |
danpb | honestly, the entire concept of reporting storage per compute host and then summing it up across hosts is just doomed by design and any code doing that needs to be killed | 10:58 |
BobBall | We could add the concept of having a UUID for the storage we might be able to sum them sensibly? | 11:00 |
*** dprince has joined #openstack-nova | 11:01 | |
tonyb | That'd make detecting shared storage easier aswell | 11:03 |
*** ociuhandu has joined #openstack-nova | 11:03 | |
*** RuiChen has quit IRC | 11:04 | |
openstackgerrit | Chung Chih, Hung proposed openstack/nova: Creating intance fail when inject ssh key in cells mode https://review.openstack.org/197514 | 11:04 |
*** IanGovett has joined #openstack-nova | 11:09 | |
*** kylek3h has joined #openstack-nova | 11:10 | |
*** abhishekk has quit IRC | 11:11 | |
*** abhishekk has joined #openstack-nova | 11:12 | |
*** mikeit has quit IRC | 11:14 | |
*** ankit_ag has joined #openstack-nova | 11:14 | |
*** kylek3h has quit IRC | 11:15 | |
*** romainh has joined #openstack-nova | 11:15 | |
*** ajayaa_ has quit IRC | 11:23 | |
garyk | danpb: can you please address the comments in https://review.openstack.org/#/c/188789/ - this has been blocked for quite some time | 11:24 |
*** matrohon has quit IRC | 11:27 | |
*** matrohon has joined #openstack-nova | 11:28 | |
*** Aless has joined #openstack-nova | 11:30 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: generalize claim code to be useful for other move actions https://review.openstack.org/197138 | 11:30 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: rename ResizeClaim to MoveClaim https://review.openstack.org/197137 | 11:30 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: tests: move a test to the proper class in test_resource_tracker https://review.openstack.org/197525 | 11:30 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: tests: Move test_resource_tracker to Instance objects https://review.openstack.org/197526 | 11:30 |
ndipanov | danpb, the bottom two are nice test clanups if you are looking for easy +2s ^^ | 11:30 |
*** itzikb has joined #openstack-nova | 11:31 | |
*** itzikb_ has quit IRC | 11:32 | |
*** itzikb_ has joined #openstack-nova | 11:32 | |
*** jasondotstar has quit IRC | 11:35 | |
*** jasondotstar has joined #openstack-nova | 11:36 | |
*** itzikb has quit IRC | 11:36 | |
*** itzikb has joined #openstack-nova | 11:36 | |
*** ajayaa_ has joined #openstack-nova | 11:39 | |
*** kylek3h has joined #openstack-nova | 11:40 | |
*** itzikb_ has quit IRC | 11:40 | |
*** Marga_ has joined #openstack-nova | 11:40 | |
*** itzikb_ has joined #openstack-nova | 11:40 | |
*** jasondotstar has quit IRC | 11:41 | |
*** jcoufal has quit IRC | 11:42 | |
*** itzikb has quit IRC | 11:42 | |
*** itzikb has joined #openstack-nova | 11:42 | |
*** Marga_ has quit IRC | 11:43 | |
*** annashen has joined #openstack-nova | 11:44 | |
*** Marga_ has joined #openstack-nova | 11:44 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Enable python34 tests for nova/tests/unit/scheduler/test*.py https://review.openstack.org/187968 | 11:44 |
*** itzikb_ has quit IRC | 11:45 | |
*** tobe has quit IRC | 11:46 | |
*** marun has joined #openstack-nova | 11:46 | |
*** piyanai has joined #openstack-nova | 11:47 | |
*** annashen has quit IRC | 11:48 | |
*** Jeffrey4l has quit IRC | 11:49 | |
*** jcoufal has joined #openstack-nova | 11:49 | |
*** jcoufal is now known as Guest52168 | 11:50 | |
*** Guest52168 has quit IRC | 11:50 | |
*** jcoufal_ has joined #openstack-nova | 11:50 | |
openstackgerrit | garyk proposed openstack/nova: Compute: enable admin to decide action for conflicting states https://review.openstack.org/190047 | 11:51 |
*** marun has quit IRC | 11:52 | |
*** deepthi has quit IRC | 11:52 | |
andreykurilin | garyk: hi! I understand that such requests are annoying, but can you review my spec related to novaclient support of microversions? | 11:53 |
*** xgsa1 has joined #openstack-nova | 11:55 | |
*** tojuvone has quit IRC | 11:55 | |
*** itzikb_ has joined #openstack-nova | 11:55 | |
*** itzikb has quit IRC | 11:55 | |
garyk | andreykurilin: sure. please post me the link | 11:58 |
*** Longgeek has quit IRC | 11:59 | |
*** thorst has joined #openstack-nova | 12:01 | |
*** itzikb has joined #openstack-nova | 12:02 | |
*** sudipto has quit IRC | 12:02 | |
*** _diana_ has joined #openstack-nova | 12:02 | |
*** Jeffrey4l has joined #openstack-nova | 12:03 | |
*** itzikb_ has quit IRC | 12:03 | |
*** matrohon has quit IRC | 12:04 | |
*** matrohon has joined #openstack-nova | 12:05 | |
*** lpetrut has joined #openstack-nova | 12:05 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: api: relax validation for unversioned requests https://review.openstack.org/173243 | 12:06 |
*** lyarwood has quit IRC | 12:07 | |
*** lyarwood has joined #openstack-nova | 12:07 | |
*** itzikb has quit IRC | 12:08 | |
*** itzikb has joined #openstack-nova | 12:08 | |
*** LukeHinds has joined #openstack-nova | 12:09 | |
*** ociuhandu has quit IRC | 12:09 | |
*** andreykurilin__ has joined #openstack-nova | 12:11 | |
*** dave-mccowan has joined #openstack-nova | 12:13 | |
*** Marga_ has quit IRC | 12:13 | |
*** Marga__ has joined #openstack-nova | 12:13 | |
*** markvoelker has quit IRC | 12:14 | |
johnthetubaguy | alaski: I updated the API spec to take into account your comments, I moved the controversial bit into the alternatives section for now: https://review.openstack.org/#/c/173243/17/specs/liberty/approved/api-relax-validation.rst,cm | 12:14 |
*** Marga__ has quit IRC | 12:14 | |
*** markvoelker has joined #openstack-nova | 12:14 | |
*** eharney has joined #openstack-nova | 12:14 | |
danpb | johnthetubaguy: so do you think i should re-write my vif spec to just cover the initial proof of concept internal to nova and the create a second backlog spec for turning that into a stable API ? | 12:15 |
*** Marga_ has joined #openstack-nova | 12:15 | |
*** mpavone has quit IRC | 12:16 | |
openstackgerrit | Rong Han proposed openstack/nova: Catch NovaException from post_live_migration_at_destination, set instance vm_state error. https://review.openstack.org/186634 | 12:18 |
*** raginbajin has quit IRC | 12:18 | |
*** _diana_ has quit IRC | 12:18 | |
*** kiran-r has joined #openstack-nova | 12:18 | |
*** _diana_ has joined #openstack-nova | 12:19 | |
andreykurilin__ | garyk: it was approved while I was asking you about review:) but any way, thanks | 12:19 |
*** raginbajin has joined #openstack-nova | 12:19 | |
*** ociuhandu has joined #openstack-nova | 12:21 | |
*** jcoufal_ has quit IRC | 12:23 | |
openstackgerrit | Victor Stinner proposed openstack/nova: Use oslo_utils instead of deprecated oslo.utils https://review.openstack.org/197546 | 12:23 |
openstackgerrit | Victor Stinner proposed openstack/nova: Close temporary files in virt/disk/test_api.py https://review.openstack.org/197547 | 12:23 |
*** heyongli has quit IRC | 12:24 | |
*** Longgeek has joined #openstack-nova | 12:25 | |
*** kylek3h has quit IRC | 12:26 | |
*** heyongli has joined #openstack-nova | 12:27 | |
sahid | ndipanov, johnthetubaguy i have updated the spec consoles-objects please let me know if that resolves your complaints https://review.openstack.org/#/c/165838/ | 12:28 |
*** zigo has quit IRC | 12:28 | |
_gryf | hey, is there anything bad going on with the gates? I've got error on the gate-nova-python27 with the first of my patch in the set, but there is no error on the patch depended on it. | 12:28 |
*** mutoulbj has quit IRC | 12:28 | |
_gryf | and all unit tests are fine locally | 12:29 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/194325 | 12:29 |
*** zigo has joined #openstack-nova | 12:29 | |
*** mutoulbj has joined #openstack-nova | 12:29 | |
*** itzikb has quit IRC | 12:29 | |
*** mutoulbj has quit IRC | 12:30 | |
*** rfolco has joined #openstack-nova | 12:30 | |
*** aysyd has joined #openstack-nova | 12:30 | |
*** mutoulbj has joined #openstack-nova | 12:30 | |
*** mpavone has joined #openstack-nova | 12:31 | |
*** Longgeek has quit IRC | 12:31 | |
*** kiran-r has quit IRC | 12:32 | |
*** nihilifer has quit IRC | 12:32 | |
*** edmondsw has joined #openstack-nova | 12:32 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: generalize claim code to be useful for other move actions https://review.openstack.org/197138 | 12:34 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: rename ResizeClaim to MoveClaim https://review.openstack.org/197137 | 12:34 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: tests: move a test to the proper class in test_resource_tracker https://review.openstack.org/197525 | 12:34 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: tests: Move test_resource_tracker to Instance objects https://review.openstack.org/197526 | 12:34 |
*** RuiChen has joined #openstack-nova | 12:36 | |
*** _diana_ has quit IRC | 12:36 | |
*** annegentle has joined #openstack-nova | 12:37 | |
*** tojuvone has joined #openstack-nova | 12:37 | |
*** _gryf is now known as _gryf|afk | 12:37 | |
*** ankit_ag has quit IRC | 12:38 | |
*** rotbeard has joined #openstack-nova | 12:38 | |
*** Aless has quit IRC | 12:39 | |
*** tellesnobrega_ has joined #openstack-nova | 12:40 | |
*** thangp has joined #openstack-nova | 12:42 | |
*** RuiChen has quit IRC | 12:42 | |
*** _diana_ has joined #openstack-nova | 12:43 | |
garyk | ndipanov: if you are looking for a no brainr review - https://review.openstack.org/195518 | 12:43 |
*** baoli has joined #openstack-nova | 12:44 | |
*** annashen has joined #openstack-nova | 12:45 | |
*** rlrossit has joined #openstack-nova | 12:45 | |
dims | garyk: can you please bless this? (oslo.vmware) https://review.openstack.org/#/c/196408/ | 12:46 |
*** tellesnobrega__ has joined #openstack-nova | 12:47 | |
*** baoli_ has joined #openstack-nova | 12:48 | |
*** annegentle has quit IRC | 12:48 | |
*** annegentle has joined #openstack-nova | 12:49 | |
*** tellesnobrega_ has quit IRC | 12:49 | |
*** annashen has quit IRC | 12:49 | |
*** Longgeek has joined #openstack-nova | 12:49 | |
*** exploreshaifali has joined #openstack-nova | 12:50 | |
*** baoli has quit IRC | 12:51 | |
*** romainh has quit IRC | 12:53 | |
*** gszasz has quit IRC | 12:54 | |
openstackgerrit | Andrew Bogott proposed openstack/nova: Include project_id in instance metadata. https://review.openstack.org/197185 | 12:54 |
*** matrohon has quit IRC | 12:54 | |
*** tellesnobrega__ has quit IRC | 12:55 | |
*** matrohon has joined #openstack-nova | 12:55 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/194325 | 12:56 |
*** annegentle has quit IRC | 12:57 | |
*** ivasev has joined #openstack-nova | 12:58 | |
*** annegentle has joined #openstack-nova | 12:58 | |
*** RuiChen has joined #openstack-nova | 12:59 | |
*** flip214 has quit IRC | 13:00 | |
*** jecarey has joined #openstack-nova | 13:00 | |
bauzas | danpb: I have a question re: https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L47 | 13:02 |
RuiChen | hi johnthetubaguy, can you take a look this spec https://review.openstack.org/#/c/169638/ ? | 13:02 |
bauzas | danpb: do you know the new attribute name ? can't find it :( | 13:02 |
RuiChen | johnthetubaguy, I think we don't need to modify many logic to implement it, just passthrough subnet_id into neutron create port api | 13:03 |
johnthetubaguy | RuiChen: I voted on it this morning I think | 13:03 |
bauzas | RuiChen: please provide your spec in https://etherpad.openstack.org/p/liberty-spec-freeze-exceptions | 13:03 |
johnthetubaguy | and +1 to bauzas comment | 13:03 |
*** kbyrne has quit IRC | 13:03 | |
RuiChen | yeah, I had add it in the link | 13:03 |
openstackgerrit | sahid proposed openstack/nova: libvirt: rework membacking config to support future features https://review.openstack.org/197566 | 13:03 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add cpu schedular priority config https://review.openstack.org/197567 | 13:03 |
openstackgerrit | sahid proposed openstack/nova: virt: add contraint to handle realtime policy https://review.openstack.org/197568 | 13:03 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add realtime support https://review.openstack.org/197569 | 13:03 |
johnthetubaguy | RuiChen the problem is any API change we have to live with for a _long_ time, so its a very high bar to change the API | 13:03 |
openstackgerrit | javeme proposed openstack/nova: remove the method _set_vm_state in _live_migrate() https://review.openstack.org/197570 | 13:04 |
*** otter768 has joined #openstack-nova | 13:04 | |
danpb | bauzas: i believe we missed that in ImageObjectProps class | 13:04 |
bauzas | danpb: oh man... :( | 13:04 |
bauzas | danpb: I hate those dicts | 13:05 |
danpb | indeed | 13:05 |
bauzas | danpb: I have the same problem with filt_props | 13:05 |
danpb | we do however have a HVTypeField() already defined as an enum | 13:06 |
danpb | so we just need to add an hw_hv_type property of type HVTypeField | 13:06 |
danpb | what is filt_props ?? | 13:06 |
bauzas | danpb: filter_properties, ugly dict for the scheduler | 13:06 |
danpb | oh right | 13:07 |
bauzas | danpb: ok, do you want me to bump a new version for the ImageProps ? | 13:07 |
RuiChen | johnthetubaguy, yes, so I hope some API group guys can review it. | 13:07 |
bauzas | danpb: I can put it in the bottom of my series | 13:07 |
danpb | bauzas: sure, go for it | 13:07 |
bauzas | danpb: okay | 13:08 |
bauzas | I need a rebase anyway... | 13:08 |
*** otter768 has quit IRC | 13:09 | |
*** heyongli has quit IRC | 13:09 | |
bauzas | danpb: while you're here, look at https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L76 | 13:12 |
bauzas | danpb: same problem here :( | 13:12 |
bauzas | danpb: so I'll provide an Integer() for it | 13:12 |
bauzas | or a Float even, need to compare with the ComputeNode field | 13:13 |
johnthetubaguy | RuiChen: as I said on the review, I think we need people to start forming a full plan for the networking APIs, once thats in place, it will be much clearer about what we should do | 13:13 |
bauzas | danpb: mmm, IntegerField() in ComputeNode | 13:13 |
*** heyongli has joined #openstack-nova | 13:13 | |
alex_xu | danpb: would you like take a look at https://review.openstack.org/168982 before your holiday? I'm not sure I can get exception for it, but I will give a try. thanks in advance | 13:13 |
*** yingjun has joined #openstack-nova | 13:14 | |
*** Longgeek has quit IRC | 13:14 | |
*** Longgeek has joined #openstack-nova | 13:14 | |
danpb | bauzas: sigh, so many utterly insane image properties | 13:15 |
*** romainh has joined #openstack-nova | 13:15 | |
bauzas | danpb: yup, we need to pay the debt | 13:15 |
RuiChen | johnthetubaguy, you means the spec should been delay until the networking plan more clear? | 13:15 |
bauzas | danpb: even if someone else left us a debt | 13:15 |
danpb | bauzas: i'm inclear if that image prop actually takes a number, or a dotted decimal string ? | 13:15 |
danpb | ideally i think it would be a dotted decimal string | 13:16 |
bauzas | danpb: by looking at the filter, it basically matches the number with the one given by the host | 13:16 |
johnthetubaguy | RuiChen: since there are one two or three weeks left to get all the code up for review, that seems like the best trade off at this point | 13:16 |
danpb | as that's far more friendly that expecting the user to convert a x.y.z number into x << 16 | y << 8 | z | 13:16 |
danpb | so i'd be inclined to subclass IntegerField and adding a VersionField() which accepts a dotted decimal string and converts it to an integer | 13:16 |
*** rajesht_ has joined #openstack-nova | 13:17 | |
*** mmedvede has joined #openstack-nova | 13:17 | |
bauzas | danpb: mmm | 13:17 |
bauzas | danpb: it uses the VersionPredicate stuff for comparing | 13:18 |
*** heyongli has quit IRC | 13:18 | |
RuiChen | johnthetubaguy, all the code about this spec is ready for reveiwing, I means if the spec can be approved https://review.openstack.org/#/q/status:open+branch:master+topic:bp/selecting-subnet-when-creating-vm,n,z | 13:19 |
*** ijuwang has joined #openstack-nova | 13:19 | |
andreykurilin | johnthetubaguy: thanks for approving spec | 13:19 |
*** ociuhandu has quit IRC | 13:19 | |
johnthetubaguy | RuiChen: hmm, OK, although we still need to agree the future direction there, the cost of merging the wrong API is very high | 13:20 |
*** ociuhandu has joined #openstack-nova | 13:20 | |
johnthetubaguy | RuiChen: this is something I really want to be a priority in M, not sure if others will agree, but I want to see v2.1 usable before we focus on these kinds of changes | 13:20 |
andreykurilin | melwitt: hi! can you remove your -2 for https://review.openstack.org/#/c/152569/ , since spec is already approved? | 13:21 |
*** rajesht has quit IRC | 13:21 | |
johnthetubaguy | RuiChen: right now, we need a good plan for the network API that we can start getting folks to think about, so we would be ready to implement in M, at least thats where I am thinking right now | 13:21 |
*** matrohon has quit IRC | 13:21 | |
*** heyongli has joined #openstack-nova | 13:21 | |
johnthetubaguy | andreykurilin: I probably need to approve the blueprint now the spec is merged, I will try get to that ASAP | 13:21 |
andreykurilin | johnthetubaguy: https://blueprints.launchpad.net/python-novaclient/+spec/api-microversion-support | 13:22 |
*** kbyrne has joined #openstack-nova | 13:22 | |
*** matrohon has joined #openstack-nova | 13:22 | |
johnthetubaguy | andreykurilin: I generally wait till it gets published here: http://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/ | 13:22 |
*** lucas-bbl is now known as lucasagomes | 13:22 | |
andreykurilin | johnthetubaguy: ok, got it. | 13:22 |
johnthetubaguy | andreykurilin: it shouldn't be too much longer now | 13:23 |
*** Piet has quit IRC | 13:23 | |
andreykurilin | johnthetubaguy: :) thanks | 13:23 |
johnthetubaguy | alex_xu: that cpu spec probably wants to be on the exception request list I assume? https://etherpad.openstack.org/p/liberty-spec-freeze-exceptions | 13:24 |
*** nihilifer has joined #openstack-nova | 13:24 | |
alex_xu | johnthetubaguy: yea, I put that in the etherpad already | 13:24 |
RuiChen | johnthetubaguy, ok, thank you, maybe it's not a good time to implement it now, i hope i can merge it in M, please think about this spec when we do the networking API plan | 13:25 |
*** coolsvap is now known as coolsvap|away | 13:26 | |
*** ociuhandu has quit IRC | 13:27 | |
johnthetubaguy | RuiChen: it would be great if you can help write that | 13:27 |
*** mriedem has joined #openstack-nova | 13:27 | |
johnthetubaguy | alex_xu: ah, sorry, I didn't see it yet I guess | 13:27 |
alex_xu | andreykurilin: congratulation :) let's move focus on patch | 13:27 |
alex_xu | johnthetubaguy: np, thanks for the reminder! | 13:27 |
RuiChen | johnthetubaguy, yeah i can try my best | 13:28 |
*** browne has joined #openstack-nova | 13:28 | |
*** xgsa has quit IRC | 13:29 | |
andreykurilin | alex_xu: thanks! as far as I understand, the main discussion will be at https://review.openstack.org/#/c/184281/ :) what about the first patches and support of 2.2 microversion? | 13:29 |
alex_xu | andreykurilin: yea, I still think that isn't right, we should treat microversion as global version. I will move my comment to that patch :) | 13:30 |
*** jcoufal has joined #openstack-nova | 13:30 | |
*** ociuhandu has joined #openstack-nova | 13:30 | |
*** irenab has quit IRC | 13:32 | |
mriedem | anyone else noticing an uptick in failed turbo-hipster runs? | 13:33 |
mriedem | on non-db related changes | 13:33 |
mriedem | jhesketh: ^ | 13:33 |
mriedem | also, logs aren't pointing to the failed runs | 13:33 |
*** jcoufal has quit IRC | 13:33 | |
mriedem | like here https://review.openstack.org/#/c/197208/ | 13:33 |
*** rlrossit has left #openstack-nova | 13:33 | |
*** ctrath has joined #openstack-nova | 13:34 | |
jhesketh | mriedem: I'll take a look | 13:34 |
jhesketh | mriedem: do you have other examples? | 13:34 |
mriedem | jhesketh: i saw one yesterday but at this point i'd be lost trying to find it | 13:34 |
jhesketh | okay I'll take a look | 13:34 |
*** marun has joined #openstack-nova | 13:35 | |
*** jcoufal has joined #openstack-nova | 13:35 | |
*** xgsa has joined #openstack-nova | 13:36 | |
*** Jeffrey4l has quit IRC | 13:36 | |
jhesketh | mriedem: could be noisy neighbours or something causing the timing of the jobs to be wrong | 13:36 |
jhesketh | my scraping tool finds 6 failed th runs | 13:37 |
*** lucas__ has joined #openstack-nova | 13:37 | |
*** heyongli has quit IRC | 13:37 | |
mriedem | ok, i guess i just got 2 of those :) i'm lucky | 13:37 |
*** abhishekk has quit IRC | 13:38 | |
jhesketh | mriedem: heh, I'll shoot off a recheck on those and given that it's late I'll turn negative voting off over night and check closer tomorrow | 13:38 |
dansmith | jhesketh: hey, can we change the timing requirements for just nova migrations? | 13:38 |
dansmith | jhesketh: like, say that they have to complete in 10 seconds... | 13:39 |
ctrath | mriedem: I looked at https://bugs.launchpad.net/nova/+bug/1186354 .. Do we want to just throw an exception in the limits methods if the request was made from neutron? | 13:39 |
openstack | Launchpad bug 1186354 in OpenStack Compute (nova) "Limits API doesn't work with Neutron" [Medium,Confirmed] - Assigned to Cale Rath (ctrath) | 13:39 |
mriedem | ctrath: yes | 13:39 |
mriedem | ctrath: a 400 | 13:39 |
jhesketh | dansmith: the default migration timeout on our large dataset sample is 60 seconds | 13:39 |
ctrath | mriedem: ok.. good enough. thanks | 13:39 |
*** mpavone has quit IRC | 13:40 | |
jhesketh | dansmith: these are adjustable though | 13:40 |
*** baoli_ has quit IRC | 13:40 | |
*** marun has quit IRC | 13:40 | |
dansmith | jhesketh: I'd like us to cut that down to as low as possible to catch migrations trying to touch data | 13:40 |
*** heyongli has joined #openstack-nova | 13:40 | |
dansmith | jhesketh: do you think that's doable or likely to be too sensitive? | 13:40 |
mriedem | great, i just hit this fixed ip allocation race in n-net again even after we thought we narrowed that race down | 13:41 |
*** READ10 has joined #openstack-nova | 13:41 | |
jhesketh | dansmith: it's quite crude in that it just watches the time it takes between two migrations | 13:41 |
*** lucas__ has quit IRC | 13:41 | |
jhesketh | which means it's subject to a lot of conditions on the host | 13:41 |
jhesketh | we do what we can to isolate it, but these recent failures are likely an example of that failing | 13:41 |
*** ZZelle has quit IRC | 13:42 | |
dansmith | hmm, okay | 13:42 |
*** lucas__ has joined #openstack-nova | 13:42 | |
jhesketh | dansmith: we also measure innodb rows read and rows changed, but those defaults are quite high | 13:42 |
*** ZZelle has joined #openstack-nova | 13:42 | |
dansmith | jhesketh: but those numbers would be high even for a legit schema-only change? | 13:42 |
jhesketh | dansmith: right | 13:43 |
jhesketh | oh you mean where the rows aren't modified | 13:43 |
jhesketh | no, they shouldn't need to be high | 13:43 |
openstackgerrit | Matthew Gilliard proposed openstack/nova: WIP: Define system_family for libvirt guests https://review.openstack.org/197132 | 13:43 |
dansmith | jhesketh: even if we make something nullable or change a default or something? | 13:44 |
jhesketh | I'd have to check what MySQL does sorry | 13:44 |
dansmith | okay | 13:44 |
dansmith | well, if that's doable, we should cut that down super low to catch anything doing data manipulation | 13:44 |
jhesketh | dansmith: what about a 1st party non-voting (ie advisory) job that introspecs the migration to see what operations are being done and gives a warning if it'd modify production data | 13:44 |
*** baoli has joined #openstack-nova | 13:44 | |
*** mpavone has joined #openstack-nova | 13:45 | |
jhesketh | if you want to catch anything that modifies data, that could be done as a 1st party test... turbo-hipster just needs to catch pain points for operators | 13:45 |
dansmith | jhesketh: well, I was looking at our test_migrations to see if I could reasonably do something like that | 13:45 |
*** annashen has joined #openstack-nova | 13:45 | |
dansmith | jhesketh: sure, if it's easily doable | 13:46 |
dansmith | jhesketh: https://review.openstack.org/#/c/197349/ | 13:46 |
dansmith | jhesketh: I guess I should be able to mock insert, update, and delete, huh? | 13:46 |
*** Dev_Jin has quit IRC | 13:46 | |
*** dbite has quit IRC | 13:46 | |
jhesketh | dansmith: that's probably going to give you better control than th | 13:47 |
dansmith | okay | 13:47 |
dansmith | I'm just used to th being the thing we use to ensure well-behaved migrations :) | 13:47 |
jhesketh | I'm glad :-) | 13:48 |
dansmith | heh | 13:48 |
jhesketh | dansmith: is wanting to lock down modifying changes a result of something bad getting past? | 13:49 |
jhesketh | or is it just to make people think twice before doing it (ie exceptions are still made) | 13:49 |
*** Jeffrey4l has joined #openstack-nova | 13:49 | |
dansmith | jhesketh: no, it's a result our upgrade strategy and our desire to be able to apply the schema quickly and firstly | 13:49 |
dansmith | and of course, the long-term of not having migrations at all | 13:50 |
dansmith | i.e. the online schema changes work | 13:50 |
*** annashen has quit IRC | 13:50 | |
*** rlrossit has joined #openstack-nova | 13:50 | |
kashyap | Would be nice if a different pair of eyes could review this non-invasive backport: https://review.openstack.org/#/c/193497 -- "libvirt: handle code=38 + sigkill (ebusy) in destroy()" | 13:50 |
jhesketh | dansmith: okay cool :-) | 13:51 |
*** ociuhandu has quit IRC | 13:51 | |
*** ociuhandu has joined #openstack-nova | 13:53 | |
openstackgerrit | sahid proposed openstack/nova: libvirt: add cpu schedular priority config https://review.openstack.org/197567 | 13:53 |
openstackgerrit | sahid proposed openstack/nova: libvirt: rework membacking config to support future features https://review.openstack.org/197566 | 13:53 |
openstackgerrit | sahid proposed openstack/nova: virt: add contraint to handle realtime policy https://review.openstack.org/197568 | 13:53 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add realtime support https://review.openstack.org/197569 | 13:53 |
*** dboik has joined #openstack-nova | 13:54 | |
*** dboik has quit IRC | 13:55 | |
*** dboik has joined #openstack-nova | 13:55 | |
*** gokrokve has joined #openstack-nova | 13:56 | |
*** jcoufal has quit IRC | 13:56 | |
*** zzzeek has joined #openstack-nova | 13:56 | |
*** jcoufal has joined #openstack-nova | 13:57 | |
*** ctrath has quit IRC | 13:57 | |
*** kiran-r has joined #openstack-nova | 13:58 | |
*** jcoufal has quit IRC | 13:58 | |
*** dane-fichter has joined #openstack-nova | 13:58 | |
mriedem | tonyb: whatever happened with the infinite recursion issue? | 13:59 |
*** dims has quit IRC | 13:59 | |
*** jcoufal has joined #openstack-nova | 14:00 | |
*** _diana_ has quit IRC | 14:00 | |
*** dims has joined #openstack-nova | 14:00 | |
*** mtanino has joined #openstack-nova | 14:02 | |
*** subscope has quit IRC | 14:03 | |
*** exploreshaifali has quit IRC | 14:03 | |
dansmith | mriedem: do you have the logstash query to see if it kept happening?? | 14:05 |
*** ctrath has joined #openstack-nova | 14:05 | |
dansmith | er, s/??/? | 14:05 |
mriedem | dansmith: yeah sec | 14:06 |
mriedem | heh, yeah, it's happening | 14:07 |
mriedem | http://goo.gl/TtN8mI | 14:07 |
*** Murali has quit IRC | 14:07 | |
*** kiran-r has quit IRC | 14:07 | |
*** lpetrut has quit IRC | 14:07 | |
*** RuiChen has quit IRC | 14:08 | |
*** joshw42 has quit IRC | 14:08 | |
mriedem | here is the bug that tonyb opened https://bugs.launchpad.net/nova/+bug/1470302 | 14:08 |
openstack | Launchpad bug 1470302 in OpenStack Compute (nova) "gate-nova-python27 fails with "RuntimeError: maximum recursion depth exceeded"" [Undecided,New] | 14:08 |
dansmith | hrm, yeah | 14:08 |
dansmith | let me see if I can get it to happen locally with a few runs | 14:08 |
*** lpetrut has joined #openstack-nova | 14:09 | |
*** piyanai has quit IRC | 14:09 | |
*** jcoufal has quit IRC | 14:11 | |
*** raildo has quit IRC | 14:12 | |
*** burt has joined #openstack-nova | 14:12 | |
*** jcoufal has joined #openstack-nova | 14:13 | |
openstackgerrit | Jay Pipes proposed openstack/nova: Refactor unit test for InstanceGroup objects https://review.openstack.org/197228 | 14:14 |
*** zhenguo has joined #openstack-nova | 14:14 | |
jaypipes | garyk: ^^ addressed your concerns. thanks muchfor the review! | 14:14 |
*** tjones1 has joined #openstack-nova | 14:14 | |
jaypipes | alex_xu: ping. can we talk about the monitor plugin interface, please? | 14:14 |
*** kiran-r has joined #openstack-nova | 14:14 | |
alex_xu | jaypipes: yea, sure | 14:14 |
openstackgerrit | Victor Stinner proposed openstack/nova: Replace parse_strtime() with parse_isotime() https://review.openstack.org/197601 | 14:14 |
*** piyanai has joined #openstack-nova | 14:15 | |
*** matrohon has quit IRC | 14:15 | |
*** piyanai has quit IRC | 14:15 | |
*** raildo has joined #openstack-nova | 14:15 | |
dansmith | mriedem: yeah, see there is a limit there to avoid recursion.. "if obj_name in tree" | 14:15 |
rlrossit | dansmith: is changing child_versions->obj_relationships on all of the list objects a change to how these will get passed over RPC (meaning, do I have to update the versions on all of these list objects)? (https://bugs.launchpad.net/nova/+bug/1470154) | 14:15 |
openstack | Launchpad bug 1470154 in OpenStack Compute (nova) "List objects should use obj_relationships" [Low,Confirmed] - Assigned to Ryan Rossiter (rlrossit) | 14:15 |
openstackgerrit | Baodong (Robert) Li proposed openstack/nova: Handle port delete initiated by neutron https://review.openstack.org/179390 | 14:15 |
alex_xu | jaypipes: I still didn't get the strong reason to disable user create new type prviate monitor, and in nova code we didn't have any code depend on specific metric key name | 14:16 |
*** matrohon has joined #openstack-nova | 14:16 | |
dansmith | rlrossit: nope, that's local only, so no version change required | 14:16 |
rlrossit | dansmith: ok, so I'll just have to update the hashes in the unit tests then | 14:16 |
jaypipes | alex_xu: OK, so the idea is that plugin developers should feel free to implement a plugin that returns a specific set of monitor metrics in any way they choose. For instance, if I wanted to create a plugin that used Nagios to query the CPU stats instead of using the virt driver's get_host_cpu_stats() call, I could do that. But, I'm a strong -1 on having plugins just able to invent their own metric names, because there | 14:16 |
jaypipes | would be no way to standardize those metric names. | 14:16 |
dansmith | yep | 14:16 |
rlrossit | well there are a few that have stale object versions, so those need to get updated | 14:16 |
dansmith | jaypipes: +2 on your -1 | 14:16 |
dansmith | rlrossit: yeah | 14:17 |
jaypipes | alex_xu: I realize that the current MetricsWeigher doesn't depend on a particular string key. | 14:17 |
rlrossit | cool. I kinda feel like I know what I'm doing. or at least I can start faking it soon | 14:17 |
jaypipes | alex_xu: and that it just allows any old random key/value to be set in the weigher_setting CONF setting. | 14:17 |
dansmith | rlrossit: cool :) | 14:18 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/194325 | 14:18 |
*** apuimedo_ has quit IRC | 14:18 | |
jaypipes | alex_xu: however, the idea from sudipta and others is to create new weigher classes that actually understand what the specific metrics are and make more intelligent decisions that what is possible with something like weigher_setting = cpu.frequency=1.0,cpu.idle.time=10 | 14:18 |
garyk | jaypipes: thanks | 14:19 |
jaypipes | alex_xu: and if there is no standardization of those metric names, it's going to be REALLY difficult to implement those advanced weighers if you can't count on the names of the metrics being codified. | 14:19 |
jaypipes | alex_xu: does that make a little more sense? | 14:19 |
alex_xu | jaypipes: emm...if there are someone really want to depend on specific metric key to coding something, that make sense to me | 14:20 |
jaypipes | alex_xu: https://blueprints.launchpad.net/nova/+spec/filter-mem-bw | 14:21 |
jaypipes | alex_xu: that's one example. | 14:21 |
*** Jeffrey4l has quit IRC | 14:22 | |
alex_xu | jaypipes: it just add new type metric? or I misunderstood | 14:22 |
openstackgerrit | Matt Riedemann proposed openstack/nova: n-net: add more debug logging to release_fixed_ip https://review.openstack.org/197608 | 14:22 |
jaypipes | alex_xu: https://blueprints.launchpad.net/nova/+spec/add-utilization-based-weighers is another example. | 14:22 |
*** heyongli has quit IRC | 14:22 | |
bauzas | jaypipes: I don't have the whole context, so sorry if I'm missing something, but I'm -1 on in-tree monitors possibly providing metrics from elsewhere than just the virt driver | 14:23 |
jaypipes | alex_xu: the memory bandwidth one would add a new base type of monitor plugin for bandwidth statistics, yes. and the plugins can implement the gathering of that information in any way they see fit. | 14:23 |
jaypipes | bauzas: who said it would be in-tree? :) | 14:24 |
bauzas | jaypipes: nah, was just making sure that we're sync | 14:24 |
*** jcoufal has quit IRC | 14:24 | |
bauzas | jaypipes: I need to review your bug series | 14:24 |
jaypipes | bauzas: with the changes to use stevedore for the loading of the extensions, out-of-tree plugins are completely possible. | 14:24 |
*** heyongli has joined #openstack-nova | 14:24 | |
bauzas | jaypipes: totall | 14:24 |
bauzas | totally even | 14:24 |
jaypipes | alex_xu: and another one: https://blueprints.launchpad.net/nova/+spec/node-cached-image-weigher | 14:25 |
bauzas | jaypipes: my point was just saying "please use the virt interface for getting the metrics or leave your monitor out-of-tree" :) | 14:25 |
*** jcoufal has joined #openstack-nova | 14:25 | |
bauzas | jaypipes: could you please give me again your series so I can star them ? | 14:26 |
jaypipes | bauzas: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1468012,n,z | 14:27 |
bauzas | jaypipes: coolio, thanks | 14:27 |
dansmith | mriedem: I found the problem | 14:27 |
mriedem | orly | 14:28 |
dansmith | mriedem: yeah, the problem is I'm a giant drooling idiot | 14:28 |
mriedem | well that's not so bad | 14:29 |
openstackgerrit | Victor Stinner proposed openstack/nova: Replace parse_strtime() with parse_isotime() https://review.openstack.org/197601 | 14:29 |
*** tonytan4ever has joined #openstack-nova | 14:30 | |
openstackgerrit | Dan Smith proposed openstack/nova: Avoid recursion in object relationships test https://review.openstack.org/197611 | 14:32 |
dansmith | mriedem: ^ | 14:32 |
*** zz_jgrimm is now known as jgrimm | 14:32 | |
alex_xu | jaypipes: ok, so any data expose to scheduler from compute node is part of contract. | 14:32 |
jaypipes | alex_xu: yes. | 14:32 |
mriedem | kashyap: reviewed your backport, one little issue in one of the tests | 14:33 |
*** igordcard_ has quit IRC | 14:33 | |
alex_xu | jaypipes: ok, thanks for the explanation, I think I see now. | 14:34 |
*** heyongli has quit IRC | 14:35 | |
alex_xu | jaypipes: that also help us ensure all the hypervisors expose same data out, like we treat other data from RT. | 14:35 |
jaypipes | alex_xu: ++ exactly. | 14:36 |
jaypipes | also see lianhao lu's spec about exposing the metric names in the REST API... | 14:36 |
*** matrohon has quit IRC | 14:36 | |
mriedem | dansmith: reviewing | 14:36 |
*** yamahata has joined #openstack-nova | 14:37 | |
*** ociuhandu_ has joined #openstack-nova | 14:37 | |
*** jwang__ has joined #openstack-nova | 14:37 | |
*** andreykurilin__ has quit IRC | 14:37 | |
*** heyongli has joined #openstack-nova | 14:37 | |
*** nagyz_ has joined #openstack-nova | 14:37 | |
*** matrohon has joined #openstack-nova | 14:38 | |
*** matrohon has quit IRC | 14:38 | |
*** matrohon has joined #openstack-nova | 14:39 | |
*** kiran-r has quit IRC | 14:40 | |
*** xgsa2 has joined #openstack-nova | 14:40 | |
*** Longgeek has quit IRC | 14:40 | |
*** kudryashova_ has joined #openstack-nova | 14:41 | |
*** devanand1 has joined #openstack-nova | 14:41 | |
*** Nakato_ has joined #openstack-nova | 14:41 | |
*** s1rp_ has joined #openstack-nova | 14:41 | |
*** doude_ has joined #openstack-nova | 14:41 | |
*** nikhil_k1away has joined #openstack-nova | 14:42 | |
*** mpavone has quit IRC | 14:42 | |
mriedem | dansmith: +2 with comments | 14:42 |
mriedem | jaypipes: do it to it https://review.openstack.org/#/c/197611/ | 14:42 |
dansmith | mriedem: yep, thanks | 14:42 |
*** Kevin_Zheng has quit IRC | 14:43 | |
*** Kevin_Zheng has joined #openstack-nova | 14:43 | |
rlrossit | mriedem: dansmith: are circular dependencies in objects not a bad thing? because this recursion will only fail when we have a circular dependency right? | 14:44 |
rlrossit | "fail" meaning infinitely recurse | 14:44 |
mriedem | honestly i'm not sure how this isn't failing all the time | 14:44 |
dansmith | rlrossit: circular deps are a bad thing, IMHO, yes, but we have one | 14:44 |
jaypipes | mriedem: done. | 14:44 |
*** angular_mike__ has joined #openstack-nova | 14:44 | |
rlrossit | agreed mriedem | 14:44 |
mriedem | i guess it's the order that it pulls things out of the registry for processing | 14:45 |
dansmith | mriedem: it shouldn't fail because it checks to see if obj_name is already in the tree | 14:45 |
mriedem | yeah | 14:45 |
*** adreznec has joined #openstack-nova | 14:45 | |
*** mtreinish_ has joined #openstack-nova | 14:45 | |
dansmith | the reason it does I think is because we call build_tree before we do tree.setdefault() | 14:45 |
*** EmilienM_ has joined #openstack-nova | 14:45 | |
*** vish1 has joined #openstack-nova | 14:45 | |
dansmith | so if you process the loop in the right order, you'll hit this | 14:45 |
*** dgonzalez_ has joined #openstack-nova | 14:45 | |
mriedem | if we sorted somewhere in here it'd be more deterministic | 14:45 |
mriedem | s/more// | 14:45 |
mriedem | but anyway, we don't need to recurse so just avoid it | 14:45 |
dansmith | well, not doing the recursion makes it better anyway | 14:46 |
dansmith | yeah | 14:46 |
*** mrodden_ has joined #openstack-nova | 14:46 | |
*** melwitt_ has joined #openstack-nova | 14:46 | |
*** tjones1 has quit IRC | 14:46 | |
rlrossit | is long term solution get rid of the circular dependency? because to me this getting rid of recursion is just a bandaid | 14:46 |
dansmith | it's not a bandaid | 14:46 |
*** ociuhandu has quit IRC | 14:46 | |
*** xgsa has quit IRC | 14:46 | |
*** aysyd has quit IRC | 14:46 | |
*** doude has quit IRC | 14:46 | |
*** pkholkin has quit IRC | 14:46 | |
*** mtreinish has quit IRC | 14:46 | |
*** kudryashova has quit IRC | 14:46 | |
*** rushiagr_away has quit IRC | 14:46 | |
*** melwitt has quit IRC | 14:46 | |
*** angular_mike_ has quit IRC | 14:46 | |
*** jwang_ has quit IRC | 14:46 | |
*** EmilienM has quit IRC | 14:46 | |
*** adreznec_ has quit IRC | 14:46 | |
*** rpodolyaka has quit IRC | 14:46 | |
*** nagyz has quit IRC | 14:46 | |
*** rex_lee has quit IRC | 14:46 | |
*** kun_huang has quit IRC | 14:46 | |
*** aweeks has quit IRC | 14:46 | |
*** devananda has quit IRC | 14:46 | |
*** flaper87 has quit IRC | 14:46 | |
*** lxsli has quit IRC | 14:46 | |
*** mrodden has quit IRC | 14:46 | |
*** Nakato has quit IRC | 14:46 | |
*** s1rp has quit IRC | 14:46 | |
*** dgonzalez has quit IRC | 14:46 | |
*** vishy has quit IRC | 14:46 | |
*** nikhil_k-away has quit IRC | 14:46 | |
*** EmilienM_ is now known as EmilienM | 14:46 | |
*** vish1 is now known as vishy | 14:46 | |
*** strictlyb is now known as sb | 14:46 | |
*** ociuhandu_ is now known as ociuhandu | 14:46 | |
dansmith | getting rid of the loop we have now is hard | 14:46 |
*** mtreinish_ is now known as mtreinish | 14:46 | |
*** mrodden_ is now known as mrodden | 14:46 | |
*** dgonzalez_ is now known as dgonzalez | 14:46 | |
*** annashen has joined #openstack-nova | 14:46 | |
*** annegentle has quit IRC | 14:47 | |
mriedem | rlrossit: the recursion in the test wasn't necessary, it was redundant | 14:47 |
mriedem | so was just a latent bug that wasn't exposed until your change | 14:47 |
*** Marga_ has quit IRC | 14:47 | |
*** nkrinner has quit IRC | 14:47 | |
*** rpodolyaka has joined #openstack-nova | 14:47 | |
rlrossit | yeah agreed but it (intermittently) showed a circular dependency, which if we are stuck with the circular dependency, then yeah that solves everything | 14:48 |
*** nelsnels_ has quit IRC | 14:49 | |
rlrossit | my limited software experience says circular dependencies are bad :) | 14:49 |
*** flaper87 has joined #openstack-nova | 14:49 | |
*** flaper87 has quit IRC | 14:49 | |
*** flaper87 has joined #openstack-nova | 14:49 | |
mriedem | i for one have always appreciated the joy that circular dependencies bring to my life | 14:49 |
*** nelsnelson has joined #openstack-nova | 14:49 | |
mriedem | particularly when my previous project was related to delivering software updates | 14:49 |
*** heyongli has quit IRC | 14:49 | |
*** _diana_ has joined #openstack-nova | 14:50 | |
dansmith | it's really only a circular dependency if you assume the theoretical case, | 14:50 |
*** sb has quit IRC | 14:51 | |
dansmith | which we don't have in production, which is why this isn't a problem | 14:51 |
*** kiran-r has joined #openstack-nova | 14:51 | |
dansmith | but the test was very academic, of course | 14:51 |
*** yassine__ has quit IRC | 14:51 | |
*** annashen has quit IRC | 14:51 | |
dansmith | I'd prefer we didn't have the loop we have, but it was added for a reason and that reason is performance, so.. | 14:51 |
* mriedem writes that down for when it is a problem in production | 14:51 | |
*** strictlyb has joined #openstack-nova | 14:51 | |
dansmith | all statements apply to git hash e4e16e9077b5e78f809c6c634153fa62a5facb16 only :P | 14:52 |
dansmith | so, write that down too :P | 14:52 |
jaypipes | bauzas: https://review.openstack.org/#/c/179224/ reviewed. I have a suggestion to make the wording and proposed REST API changes simpler. | 14:52 |
mriedem | sorry, my buffer is full | 14:52 |
*** aysyd has joined #openstack-nova | 14:52 | |
*** aweeks has joined #openstack-nova | 14:52 | |
*** heyongli has joined #openstack-nova | 14:52 | |
bauzas | jaypipes: oh great | 14:53 |
*** matrohon has quit IRC | 14:53 | |
*** matrohon has joined #openstack-nova | 14:53 | |
bauzas | jaypipes: evacuate is no longer accepted ? I missed the convo | 14:53 |
*** pkholkin has joined #openstack-nova | 14:53 | |
*** lxsli has joined #openstack-nova | 14:53 | |
bauzas | jaypipes: I mean, do we plan to change the API resource name ? | 14:53 |
jaypipes | bauzas: hmm? no, I mean the actual method call is called rebuild_instance() in the conductor :) | 14:53 |
bauzas | jaypipes: oh, correctr | 14:54 |
bauzas | jaypipes: I was lazy | 14:54 |
bauzas | jaypipes: agreed with your REST API comment, just one clarification | 14:55 |
bauzas | jaypipes: 1/ no host provided => call the sched, ack | 14:56 |
bauzas | jaypipes: 2/ host provided, if --force, no calling the sched, ack | 14:56 |
bauzas | jaypipes: 3/ host provided, if not --force then serve a HTTP 409 ? | 14:56 |
bauzas | right? | 14:56 |
*** danpb has quit IRC | 14:56 | |
jaypipes | bauzas: zactly. | 14:56 |
bauzas | ack | 14:56 |
bauzas | ok, will change | 14:57 |
jaypipes | sahid: see my request on https://review.openstack.org/#/c/190962/... | 14:57 |
*** danpb has joined #openstack-nova | 14:57 | |
*** irenab has joined #openstack-nova | 14:57 | |
*** subscope has joined #openstack-nova | 14:57 | |
*** heyongli has quit IRC | 14:57 | |
*** heyongli has joined #openstack-nova | 14:59 | |
*** kun_huang has joined #openstack-nova | 14:59 | |
*** angular_mike__ is now known as angular_mike_ | 15:00 | |
*** devanand1 is now known as devananda | 15:01 | |
*** xyang1 has joined #openstack-nova | 15:02 | |
*** Marga_ has joined #openstack-nova | 15:02 | |
*** derekh has joined #openstack-nova | 15:03 | |
*** yingjun has quit IRC | 15:04 | |
*** rex_lee has joined #openstack-nova | 15:05 | |
*** otter768 has joined #openstack-nova | 15:05 | |
*** ajayaa_ has quit IRC | 15:07 | |
*** Longgeek has joined #openstack-nova | 15:07 | |
*** Jeffrey4l has joined #openstack-nova | 15:07 | |
*** lucas__ has quit IRC | 15:07 | |
*** Longgeek has quit IRC | 15:07 | |
*** mmedvede has quit IRC | 15:08 | |
*** Longgeek has joined #openstack-nova | 15:08 | |
*** jlanoux_ has joined #openstack-nova | 15:08 | |
*** jlanoux has quit IRC | 15:09 | |
*** otter768 has quit IRC | 15:10 | |
*** belmoreira has quit IRC | 15:10 | |
*** yingjun has joined #openstack-nova | 15:10 | |
*** Longgeek has quit IRC | 15:12 | |
mriedem | dansmith: i'm hitting something in the test_relationships test that i'm not seeing the issue, http://paste.openstack.org/show/332379/ for change https://review.openstack.org/#/c/197208/1/nova/objects/block_device.py | 15:12 |
mriedem | i have the bdm and bdmlist versions bumped | 15:12 |
mriedem | i'm not sure why fixedip/instance are listed there | 15:13 |
*** agireud has joined #openstack-nova | 15:13 | |
mriedem | bdm is the parent of instance, but i don't need to bump the version on instance b/c bdm changes, right? | 15:13 |
mriedem | oh sec, probably b/c i rebased and picked up https://review.openstack.org/#/c/197176/2/nova/tests/unit/objects/test_objects.py but didn't change that value | 15:14 |
dansmith | they're not telling you to change them right? | 15:14 |
*** Longgeek has joined #openstack-nova | 15:14 | |
mriedem | got it, i didn't bump the version in the object_relationships map after rebased in https://review.openstack.org/#/c/197176/2/nova/tests/unit/objects/test_objects.py | 15:15 |
*** piyanai has joined #openstack-nova | 15:15 | |
mriedem | well it says, "Some objects have changed dependencies. Please make sure to bump the versions of parent objects and provide a rule in their obj_make_compatible() routines to backlevel the child object. " | 15:15 |
dansmith | right, and it is trying to show you just the changes | 15:16 |
mriedem | it should probably also say, make sure you update the versions in the object_relationships map too | 15:16 |
dansmith | I just don't see the changes | 15:16 |
*** piyanai has quit IRC | 15:16 | |
dansmith | but I'm distracted | 15:16 |
mriedem | the object_relationships map in the test had this due to rlrossit's change yesterday: 'BlockDeviceMappingList': {'BlockDeviceMapping': '1.9'}, | 15:16 |
mriedem | that 1.9 needs to be a 1.10 from my change | 15:16 |
mriedem | the error message in the test misled me | 15:16 |
mriedem | so, i'll push a change to add some extra wording in that message | 15:17 |
dansmith | okay | 15:17 |
mriedem | you can review when the price is right is over | 15:17 |
dansmith | heh | 15:17 |
openstackgerrit | Dan Smith proposed openstack/nova: Make evacuate update the migration object along the way https://review.openstack.org/194373 | 15:18 |
openstackgerrit | Dan Smith proposed openstack/nova: Add some notifications to the evacuate path https://review.openstack.org/194372 | 15:18 |
openstackgerrit | Dan Smith proposed openstack/nova: Make evacuate leave a record for the source compute host to process https://review.openstack.org/183354 | 15:18 |
*** kodoku has joined #openstack-nova | 15:19 | |
*** lucas__ has joined #openstack-nova | 15:22 | |
*** armax has joined #openstack-nova | 15:22 | |
ndipanov | dansmith, you might like this one https://review.openstack.org/#/c/197526/ (and the one before) | 15:22 |
*** unicell has joined #openstack-nova | 15:23 | |
dansmith | ndipanov: ah, yep, I actually have a change just like that queued up | 15:24 |
* dansmith deletes | 15:24 | |
*** Sukhdev has joined #openstack-nova | 15:24 | |
*** afazekas has quit IRC | 15:26 | |
*** scheuran has quit IRC | 15:26 | |
*** Jeffrey4l has quit IRC | 15:26 | |
*** piyanai has joined #openstack-nova | 15:26 | |
*** lucas__ has quit IRC | 15:27 | |
*** rajesht_ has quit IRC | 15:28 | |
*** Jeffrey4l has joined #openstack-nova | 15:28 | |
dansmith | mriedem: so how come jenkins didn't fail that test? | 15:28 |
mriedem | dansmith: in the gate? | 15:29 |
mriedem | no idea | 15:29 |
dansmith | yeah | 15:29 |
dansmith | kinda concerning.. | 15:29 |
mriedem | yeah | 15:29 |
mriedem | i'd ask sdague if he was around | 15:29 |
*** CaerbannogRabbit is now known as morganfainberg | 15:30 | |
*** gszasz has joined #openstack-nova | 15:30 | |
*** root has joined #openstack-nova | 15:30 | |
*** root is now known as Guest50553 | 15:31 | |
*** Guest50553 has left #openstack-nova | 15:31 | |
*** Jeffrey4l has quit IRC | 15:31 | |
*** lyarwood has quit IRC | 15:32 | |
*** marun has joined #openstack-nova | 15:32 | |
mriedem | kanboard is pretty full of itself: http://kanboard.net/ | 15:32 |
mriedem | i mean sure, if you don't want to do things the right way, go ahead | 15:32 |
*** lyarwood has joined #openstack-nova | 15:33 | |
*** coolsvap|away is now known as coolsvap | 15:33 | |
dansmith | ...random... | 15:33 |
mriedem | i'm getting kanboard from every directio nthis week | 15:33 |
mriedem | and i thought "Kanboard is not for everybody, it's made for people who want to manage their projects efficiently and simply." was funny | 15:34 |
dansmith | heh | 15:34 |
*** mmedvede has joined #openstack-nova | 15:34 | |
dansmith | he puts "improve docs" on the backlog, so you could certainly fire back something for that | 15:34 |
dims | big mistake if you don't use it :) | 15:34 |
*** kfox1111_away is now known as kfox1111 | 15:35 | |
*** tsekiyama has joined #openstack-nova | 15:36 | |
*** jaypipes has quit IRC | 15:37 | |
*** kodoku has quit IRC | 15:37 | |
*** unicell has quit IRC | 15:39 | |
*** root____ has joined #openstack-nova | 15:40 | |
*** root____ is now known as Jeffrey4l | 15:40 | |
mriedem | dims: i think i'll survive | 15:41 |
*** Marga_ has quit IRC | 15:41 | |
*** yingjun has quit IRC | 15:42 | |
*** ddaskal has joined #openstack-nova | 15:42 | |
*** lucas__ has joined #openstack-nova | 15:44 | |
*** coolsvap is now known as coolsvap|away | 15:44 | |
*** piyanai has quit IRC | 15:45 | |
openstackgerrit | Victor Stinner proposed openstack/nova: Close temporary files in virt/disk/test_api.py https://review.openstack.org/197547 | 15:45 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add BlockDeviceType enum field https://review.openstack.org/197237 | 15:46 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add BlockDeviceDestinationType enum field https://review.openstack.org/197223 | 15:46 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add BlockDeviceSourceType enum field https://review.openstack.org/197208 | 15:46 |
*** annashen has joined #openstack-nova | 15:47 | |
*** lucas__ has quit IRC | 15:48 | |
*** ajayaa_ has joined #openstack-nova | 15:48 | |
*** lucas__ has joined #openstack-nova | 15:48 | |
*** kiran-r has quit IRC | 15:48 | |
*** piyanai has joined #openstack-nova | 15:49 | |
*** annashen has quit IRC | 15:52 | |
*** Jeffrey4l has quit IRC | 15:53 | |
*** Jeffrey4l has joined #openstack-nova | 15:53 | |
*** tojuvone has quit IRC | 15:53 | |
*** Jeffrey4l has quit IRC | 15:54 | |
*** hemnafk is now known as hemna | 15:55 | |
*** patrickeast has joined #openstack-nova | 15:55 | |
*** irenab has quit IRC | 15:57 | |
*** flip214 has joined #openstack-nova | 15:57 | |
*** erlon has joined #openstack-nova | 15:57 | |
*** busterswt has joined #openstack-nova | 15:58 | |
*** irenab has joined #openstack-nova | 15:59 | |
*** sudipto has joined #openstack-nova | 16:00 | |
*** armax has quit IRC | 16:00 | |
*** Jeffrey4l has joined #openstack-nova | 16:01 | |
*** lpetrut has quit IRC | 16:04 | |
*** lpetrut has joined #openstack-nova | 16:05 | |
*** lpetrut has quit IRC | 16:05 | |
*** _diana_ has quit IRC | 16:06 | |
*** Longgeek has quit IRC | 16:06 | |
*** _diana_ has joined #openstack-nova | 16:07 | |
*** tjones1 has joined #openstack-nova | 16:07 | |
*** _diana_ has quit IRC | 16:07 | |
*** Longgeek has joined #openstack-nova | 16:08 | |
*** jistr has quit IRC | 16:08 | |
rlrossit | mriedem: possibly stupid question... but why are (some of) my unit tests running twice in debug mode? They pass on the first and fail on the second... | 16:08 |
*** jcoufal has quit IRC | 16:08 | |
mriedem | rlrossit: i'm told this should be an easy fix https://bugs.launchpad.net/nova/+bug/1470142 | 16:08 |
openstack | Launchpad bug 1470142 in OpenStack Compute (nova) "Nova volume encryptors attach volume fails for NFS and FC (rootwrap)" [Medium,Triaged] | 16:08 |
rlrossit | blargh | 16:08 |
dansmith | rlrossit: object tests? | 16:09 |
mriedem | rlrossit: running twice in debug mode? | 16:09 |
*** andreykurilin__ has joined #openstack-nova | 16:09 | |
rlrossit | yes | 16:09 |
*** lyarwood has quit IRC | 16:09 | |
rlrossit | to both | 16:09 |
*** lyarwood has joined #openstack-nova | 16:09 | |
mriedem | hemna: will check it out outside the cinder meeting | 16:09 |
hemna | ok thanks | 16:09 |
*** unicell has joined #openstack-nova | 16:12 | |
hemna | mriedem, any idea why my os-brick patch is marked as -1 from Jenkins and yet every voting CI is marked as Success ? | 16:12 |
hemna | https://review.openstack.org/#/c/175569/ | 16:12 |
hemna | I don't get that | 16:12 |
*** Longgeek has quit IRC | 16:12 | |
mriedem | hemna: gate-nova-requirements http://logs.openstack.org/69/175569/20/check/gate-nova-requirements/3119838/ : Incompatible requirement found; see https://wiki.openstack.org/wiki/Requirements in 59s | 16:12 |
hemna | I don't see that being reported on the patch ? | 16:14 |
dims | mriedem: note that the log does not say what's wrong :( | 16:15 |
mriedem | hemna: it's in the jenkins results when you toggle ci at the bottom | 16:15 |
*** irenab has quit IRC | 16:16 | |
hemna | oh! | 16:17 |
hemna | hah, I had that toggled off. | 16:17 |
hemna | trying to find the issue in the log.... | 16:18 |
dims | hemna: i just commented above, the log does not say what the issue was/is | 16:18 |
dims | i have the same problem with another review in oslo.messaging | 16:18 |
hemna | :( | 16:19 |
dims | will have to talk to lifeless later in the day | 16:19 |
*** kiran-r has joined #openstack-nova | 16:19 | |
*** _kiran_ has joined #openstack-nova | 16:19 | |
*** _kiran_ has quit IRC | 16:19 | |
hemna | dims, maybe a rebase might fix it | 16:20 |
*** danpb1 has joined #openstack-nova | 16:20 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick https://review.openstack.org/175569 | 16:20 |
*** danpb has quit IRC | 16:20 | |
dims | hemna: https://review.openstack.org/#/c/192382/ multiple rechecks and rebases - no dice | 16:21 |
hemna | dang ok. well, I'm guessing the rebase I just did will puke as well then. | 16:21 |
*** jlanoux_ has quit IRC | 16:21 | |
*** ajayaa_ has quit IRC | 16:22 | |
*** ajayaa has joined #openstack-nova | 16:22 | |
*** whenry_ has joined #openstack-nova | 16:24 | |
*** sdake has joined #openstack-nova | 16:24 | |
openstackgerrit | Qin Zhao proposed openstack/nova: Refuse to delete compute service if host is in host aggregate https://review.openstack.org/197648 | 16:25 |
*** irenab has joined #openstack-nova | 16:25 | |
*** flwang1 has quit IRC | 16:25 | |
*** rushiagr_away has joined #openstack-nova | 16:26 | |
*** matrohon has quit IRC | 16:27 | |
*** Marga_ has joined #openstack-nova | 16:28 | |
*** _diana_ has joined #openstack-nova | 16:29 | |
dansmith | rlrossit: object tests run twice, once in "local" and once in "remote" mode | 16:29 |
dansmith | rlrossit: to make sure whatever you did works in both cases | 16:29 |
dansmith | rlrossit: the kindof "point" of objects is that they behave the same regardless of if we're local to the db or not | 16:29 |
*** Piet has joined #openstack-nova | 16:30 | |
rlrossit | dansmith: gotcha... so changing over the list objects causes one, but not both, of them to fail then | 16:30 |
*** karimb has quit IRC | 16:31 | |
*** tsbot_ has joined #openstack-nova | 16:31 | |
*** irenab has quit IRC | 16:32 | |
dansmith | rlrossit: okay, I'm on a call.. ping me again in 30-45 minutes | 16:33 |
rlrossit | alrighty. thanks in advance dansmith! | 16:34 |
*** _diana_ has quit IRC | 16:34 | |
*** vilobhmm has joined #openstack-nova | 16:35 | |
*** jwcroppe_ has joined #openstack-nova | 16:38 | |
*** ociuhandu has quit IRC | 16:38 | |
*** derekh has quit IRC | 16:39 | |
*** jwcroppe has quit IRC | 16:40 | |
*** piyanai has quit IRC | 16:43 | |
*** rotbeard has quit IRC | 16:43 | |
*** piyanai has joined #openstack-nova | 16:43 | |
*** piyanai has quit IRC | 16:44 | |
*** Marga_ has quit IRC | 16:44 | |
*** Longgeek has joined #openstack-nova | 16:45 | |
*** marun has left #openstack-nova | 16:47 | |
*** annashen has joined #openstack-nova | 16:48 | |
*** piyanai has joined #openstack-nova | 16:48 | |
*** Jeffrey4l has quit IRC | 16:52 | |
*** armax has joined #openstack-nova | 16:52 | |
*** annashen has quit IRC | 16:53 | |
*** Jeffrey4l has joined #openstack-nova | 16:54 | |
*** aix has quit IRC | 16:55 | |
*** belmoreira has joined #openstack-nova | 16:55 | |
johnthetubaguy | melwitt_: this one has the blueprint approved now, in case you don't see the mail: https://review.openstack.org/#/c/179059/ | 16:55 |
*** melwitt_ is now known as melwitt | 16:55 | |
melwitt | johnthetubaguy: cool, thank you | 16:56 |
*** baoli has quit IRC | 16:58 | |
*** ferest has joined #openstack-nova | 16:59 | |
*** piyanai has quit IRC | 16:59 | |
*** davideagnello has joined #openstack-nova | 17:01 | |
*** browne has quit IRC | 17:02 | |
*** Longgeek has quit IRC | 17:02 | |
*** lyarwood has quit IRC | 17:02 | |
*** lyarwood has joined #openstack-nova | 17:02 | |
*** piyanai has joined #openstack-nova | 17:03 | |
*** patrickeast has quit IRC | 17:03 | |
*** baoli has joined #openstack-nova | 17:03 | |
*** ijw has joined #openstack-nova | 17:04 | |
*** hemna is now known as hemnafk | 17:04 | |
*** sudipto has quit IRC | 17:04 | |
*** lpetrut has joined #openstack-nova | 17:04 | |
*** ijw_ has joined #openstack-nova | 17:04 | |
*** Marga_ has joined #openstack-nova | 17:05 | |
*** otter768 has joined #openstack-nova | 17:06 | |
*** romainh has quit IRC | 17:06 | |
*** kiran-r has quit IRC | 17:07 | |
*** yamahata has quit IRC | 17:07 | |
*** dboik has quit IRC | 17:09 | |
*** vilobhmm has quit IRC | 17:10 | |
*** annashen has joined #openstack-nova | 17:10 | |
*** vilobhmm has joined #openstack-nova | 17:10 | |
*** otter768 has quit IRC | 17:11 | |
*** lucasagomes is now known as lucas-dinner | 17:14 | |
*** Piet has quit IRC | 17:17 | |
*** piyanai has quit IRC | 17:18 | |
openstackgerrit | Qin Zhao proposed openstack/nova: Make compute rpc api to send instance object https://review.openstack.org/194791 | 17:18 |
*** moshele has quit IRC | 17:18 | |
*** sdake_ has joined #openstack-nova | 17:18 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Introduce a simple state machine module https://review.openstack.org/197668 | 17:19 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: WIP: Define migration states and transitions and use when changing status https://review.openstack.org/197669 | 17:19 |
ndipanov | dansmith, mriedem ^^ | 17:19 |
ndipanov | you like this kind of stuff | 17:19 |
ndipanov | some food for thought | 17:19 |
ndipanov | dansmith, if we like it - might be good to get this in before the evacuate changes | 17:19 |
dansmith | ndipanov: you're going to have a hard time proving to me that you cover all the possibilities for all virt drivers | 17:20 |
dansmith | surely agree that we need to do that, but it's going to be rough I think | 17:21 |
ndipanov | what possibilities | 17:21 |
dansmith | maybe make the new model advisory, log a warning any time we violate it, and watch it for a while | 17:21 |
ndipanov | I mean | 17:21 |
*** lpetrut has quit IRC | 17:21 | |
*** dboik has joined #openstack-nova | 17:21 | |
ndipanov | yes that was what I was gonna do actually | 17:21 |
ndipanov | and turn exceptions on in tests | 17:21 |
*** sdake has quit IRC | 17:21 | |
*** patrickeast has joined #openstack-nova | 17:21 | |
ndipanov | but this should not be related to driver logic dansmith | 17:22 |
dansmith | you're talking about things like vm_state, yes? | 17:22 |
ndipanov | well for now just migration state | 17:22 |
ndipanov | but eventually maybe | 17:22 |
ndipanov | VM state is also Nova wide should not be specific to drivers | 17:22 |
*** jaypipes has joined #openstack-nova | 17:22 | |
dansmith | riiiiight | 17:22 |
ndipanov | lol | 17:23 |
ndipanov | :) | 17:23 |
*** dboik_ has joined #openstack-nova | 17:23 | |
ndipanov | well even if we make it as loose as possible it's still better than not defined whatever | 17:23 |
*** achanda has joined #openstack-nova | 17:23 | |
ndipanov | and for migrations it should be more straightforward | 17:23 |
ndipanov | I mean - if we want to eliminate guessing - which is the point of some of this work | 17:24 |
ndipanov | this is one place to do it | 17:24 |
*** Sukhdev has quit IRC | 17:24 | |
dansmith | yeah | 17:24 |
dansmith | my evacuate stuff has been sitting for a while and I'm kind of sick of rebasing it, but... | 17:25 |
*** Sukhdev has joined #openstack-nova | 17:25 | |
*** irenab has joined #openstack-nova | 17:25 | |
dansmith | lemme finish the other intolerable task I'm doing now and I'll look/think about it | 17:25 |
ndipanov | awesome | 17:25 |
ndipanov | I'll log off soon so leave comments pls - thanks!!! | 17:26 |
*** dboik has quit IRC | 17:26 | |
*** gokrokve_ has joined #openstack-nova | 17:26 | |
bauzas | oh a Nova state machine ! | 17:27 |
bauzas | is it Christmas ? | 17:27 |
*** gokrokve has quit IRC | 17:27 | |
*** nic has joined #openstack-nova | 17:28 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: WIP: Define migration states and transitions and use when changing status https://review.openstack.org/197669 | 17:29 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Introduce a simple state machine module https://review.openstack.org/197668 | 17:29 |
*** piyanai has joined #openstack-nova | 17:33 | |
*** lyarwood has quit IRC | 17:33 | |
*** lyarwood has joined #openstack-nova | 17:33 | |
*** doude_ has quit IRC | 17:36 | |
*** ijw has quit IRC | 17:37 | |
*** armax has quit IRC | 17:37 | |
*** belmoreira has quit IRC | 17:38 | |
*** ildikov has quit IRC | 17:39 | |
*** sdake_ is now known as sdake | 17:39 | |
*** ndipanov has quit IRC | 17:41 | |
*** armax has joined #openstack-nova | 17:43 | |
*** lyarwood has quit IRC | 17:44 | |
*** lyarwood has joined #openstack-nova | 17:44 | |
*** piyanai has quit IRC | 17:44 | |
*** sdake has quit IRC | 17:44 | |
*** thangp is now known as thangp_afk | 17:45 | |
*** browne has joined #openstack-nova | 17:45 | |
*** mestery_ has joined #openstack-nova | 17:46 | |
*** sdake has joined #openstack-nova | 17:46 | |
*** dane-fichter has quit IRC | 17:46 | |
*** piyanai has joined #openstack-nova | 17:46 | |
*** exploreshaifali has joined #openstack-nova | 17:46 | |
*** vilobhmm has quit IRC | 17:47 | |
*** sdake has quit IRC | 17:48 | |
*** mestery has quit IRC | 17:49 | |
*** sdake has joined #openstack-nova | 17:49 | |
*** rwsu has quit IRC | 17:50 | |
*** lyarwood has quit IRC | 17:50 | |
*** Piet has joined #openstack-nova | 17:51 | |
*** lyarwood has joined #openstack-nova | 17:52 | |
*** penick has joined #openstack-nova | 17:52 | |
*** piyanai has quit IRC | 17:52 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add wording to error message in TestObjectVersions.test_relationships https://review.openstack.org/197684 | 17:52 |
*** hemnafk is now known as hemna | 17:53 | |
*** penick_ has joined #openstack-nova | 17:54 | |
*** rwsu has joined #openstack-nova | 17:54 | |
*** Marga_ has quit IRC | 17:55 | |
*** lpetrut has joined #openstack-nova | 17:56 | |
*** sudipto has joined #openstack-nova | 17:56 | |
*** thorst has quit IRC | 17:57 | |
*** penick has quit IRC | 17:57 | |
*** penick_ is now known as penick | 17:57 | |
*** jogo has quit IRC | 17:58 | |
*** sudipto has quit IRC | 17:59 | |
*** browne has quit IRC | 18:01 | |
*** browne has joined #openstack-nova | 18:02 | |
*** lpetrut has quit IRC | 18:03 | |
*** tjones1 has quit IRC | 18:03 | |
*** mestery_ is now known as mestery | 18:04 | |
*** Kennan has quit IRC | 18:04 | |
hemna | mriedem, whoa. my os-brick patch just puked on that TestObjectVersions.test_relationships error. infinite recursion looks like | 18:04 |
*** tjones1 has joined #openstack-nova | 18:04 | |
mriedem | hemna: there should be a fix for that merged by now | 18:05 |
*** Kennan has joined #openstack-nova | 18:05 | |
hemna | mriedem, ok I'll recheck thanks. | 18:05 |
mriedem | hemna: https://review.openstack.org/#/c/197611/ | 18:05 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick https://review.openstack.org/175569 | 18:05 |
mriedem | hemna: it's been one of those weeks | 18:05 |
hemna | heh yah it has. | 18:06 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 18:06 |
*** thorst has joined #openstack-nova | 18:06 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Add os-brick based LibvirtVolumeDriver for ScaleIO https://review.openstack.org/194454 | 18:07 |
*** danpb1 has quit IRC | 18:07 | |
*** igordcard_ has joined #openstack-nova | 18:10 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs: Proposes to check destination on migrations https://review.openstack.org/179224 | 18:11 |
rlrossit | dansmith: I think we have a problem... | 18:11 |
rlrossit | http://git.openstack.org/cgit/openstack/oslo.versionedobjects/tree/oslo_versionedobjects/base.py#n772 makes everything blow up | 18:11 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/194325 | 18:11 |
dansmith | rlrossit: ah, nice | 18:12 |
*** ZZelle_ has joined #openstack-nova | 18:12 | |
*** romainh has joined #openstack-nova | 18:12 | |
rlrossit | dansmith: are we going to have to work some magic in nova's object list base to work around this? | 18:12 |
*** Marga_ has joined #openstack-nova | 18:12 | |
dansmith | yeah, so, here's what I'd do: | 18:12 |
dansmith | 1. Override this method in nova's list base, make it look first in obj_relationships, and fall back to child_versions | 18:13 |
dansmith | 2. Port that change over to oslo.versionedobjects | 18:13 |
dansmith | 3. Convert all the nova objects to use obj_relationships | 18:13 |
*** sudipto has joined #openstack-nova | 18:13 | |
dansmith | 4. When we get a new o.vo, we can drop nova's override | 18:14 |
openstackgerrit | Marian Horban proposed openstack/nova: libvirt:Rsync remote FS driver was added https://review.openstack.org/146887 | 18:14 |
dansmith | that will decouple the change from having to modify all the list objects at once too | 18:14 |
dansmith | which is kinda nice to prove that we work in both ways | 18:14 |
dansmith | the library will have to keep the either/or behavior for some time, but that's fine | 18:14 |
dansmith | rlrossit: make sense? | 18:14 |
*** thangp_afk is now known as thangp | 18:14 | |
rlrossit | dansmith: yes, but I'm not sure how I should orchestrate this | 18:15 |
*** jogo has joined #openstack-nova | 18:15 | |
mriedem | rlrossit: steps 1-4? | 18:15 |
dansmith | rlrossit: those steps ^ | 18:15 |
mriedem | ha | 18:15 |
dansmith | heh | 18:15 |
rlrossit | do #1 totally separate from the obj_relationships change that I'm making right now? | 18:15 |
dansmith | rlrossit: #1 and #3 will be in place of what you're doing now | 18:16 |
mriedem | 2 is a copy of 1 but in the oslo.versionedobjects repo | 18:16 |
dansmith | well, #3 above is basically what you're doing now | 18:16 |
mriedem | which should eventually replace all of the nova object base stuff | 18:16 |
rlrossit | yeah so for #2 should I open a bug to oslo? | 18:16 |
dansmith | rlrossit: you can if you want, sure | 18:16 |
dansmith | rlrossit: I'll give you a tip though.. the owner of oslo.versionedobjects is a real dick, so be careful when you go propose that.. have all your ducks in a row | 18:17 |
*** kiran-r has joined #openstack-nova | 18:18 | |
dims | LOL! | 18:19 |
*** Sukhdev has quit IRC | 18:19 | |
dansmith | dims: amirite? | 18:19 |
rlrossit | wait I'm not sure now... is the owner dims or dansmith? | 18:20 |
dansmith | haha | 18:20 |
dansmith | rlrossit: second hint: dims is not a dick | 18:20 |
mriedem | rlrossit: https://review.openstack.org/#/admin/groups/600,members | 18:20 |
mriedem | jaypipes: is the dick in that list for sure | 18:20 |
dims | dansmith: totally wrong :) | 18:20 |
dansmith | heh | 18:20 |
dims | rlrossit: hahaha | 18:21 |
bauzas | lol | 18:21 |
rlrossit | a can of worms was not the best thing to open on my last day before taking off until Tuesday... | 18:21 |
* bauzas is sorry about saying the word 'lol' here | 18:21 | |
dansmith | rlrossit: you mean the who-is-a-dick can of worms, or this object stuff? | 18:21 |
rlrossit | the object stuff | 18:22 |
dansmith | nah, it's all good | 18:22 |
dims | rlrossit: we are not that bad :) go forth and submit ur reviews! | 18:22 |
dansmith | I'm super happy you landed the first one to fix the test | 18:22 |
rlrossit | I'll make sure to leave myself a big steaming pile of code to come back to on Tuesday | 18:22 |
*** nihilifer has quit IRC | 18:22 | |
dansmith | that prevents more breakage.. the cleanup bits can wait until next week | 18:22 |
jaypipes | mriedem: :( | 18:22 |
jaypipes | mriedem: you are more than welcome to replace me, sir. | 18:22 |
mriedem | jaypipes: you know i'm joking | 18:22 |
rlrossit | mriedem: you never joke | 18:22 |
mriedem | jaypipes: b/c it can't be dan, since that'd be self incriminating, and i know it's not doug | 18:22 |
dansmith | jaypipes: you and me on the same list, it's pretty obvious who the larger dick is | 18:22 |
rlrossit | you're the most serious guy I know | 18:23 |
jaypipes | dansmith: s/the larger/has the larger/ | 18:23 |
dansmith | er, maybe I should change those words | 18:23 |
*** thangp has quit IRC | 18:23 | |
dansmith | haha | 18:23 |
mriedem | i knew that was coing | 18:23 |
jaypipes | :) | 18:23 |
*** piyanai has joined #openstack-nova | 18:23 | |
*** Marga_ has quit IRC | 18:25 | |
* dims tags channel as NSFW | 18:26 | |
jaypipes | hehe | 18:26 |
jaypipes | dansmith started it. | 18:26 |
dansmith | um, my comment was G-rated | 18:26 |
rlrossit | not sure what tv you watch dansmith, but I don't think calling people dicks is G rated :) | 18:27 |
dansmith | jaypipes: you should commend jaypipes for not having structured parameters to his tag | 18:27 |
mriedem | rlrossit: he's thinking G-rated for the 80s | 18:27 |
dansmith | hah | 18:27 |
mriedem | ratings in the 80s were much more lax | 18:27 |
* bauzas thanks UrbanDictionary | 18:27 | |
rlrossit | mriedem: well.... I wasn't alive in the 80's so I wouldn't know! | 18:28 |
*** thangp has joined #openstack-nova | 18:28 | |
mriedem | i know | 18:28 |
* jaypipes feels quite old now. | 18:28 | |
rlrossit | I'm one of those kids that needs to get off people's lawns | 18:28 |
mriedem | classic example: http://www.imdb.com/title/tt0080339/ | 18:28 |
*** romainh has left #openstack-nova | 18:28 | |
mriedem | that's PG | 18:28 |
mriedem | and has swearing and a full bare boob shot | 18:28 |
mriedem | plus probably your standard early 80s racism | 18:29 |
rlrossit | really? I'm pretty sure I watched that movie when I was like 8 | 18:29 |
*** packet has joined #openstack-nova | 18:29 | |
mriedem | watch it again | 18:29 |
mriedem | it's amazing | 18:29 |
bauzas | ++ | 18:29 |
rlrossit | oh I've seen it a bunch | 18:29 |
*** ildikov has joined #openstack-nova | 18:29 | |
rlrossit | give me ham on 1, hold the mayo | 18:29 |
rlrossit | smoking or non-smoking? | 18:29 |
dansmith | in my house, | 18:29 |
mriedem | i meant, amazing that it's pg | 18:29 |
dansmith | saying "roger" implies followup with ", roger, what's your vector victor?" | 18:30 |
*** vishwanathj has joined #openstack-nova | 18:30 | |
rlrossit | you ever been to a turkish prison? | 18:30 |
mriedem | how often do you say 'roger' in your house? | 18:30 |
* dims threatens to start asking for reviews now to change conversation! | 18:30 | |
jaypipes | Do you like gladiator movies, Johnny? | 18:30 |
dansmith | mriedem: pretty soon the only thing G-rated will be animated | 18:30 |
dansmith | mriedem: quite a bit actually | 18:30 |
dansmith | mriedem: the smith household is run paramilitary style | 18:31 |
jaypipes | dims: :) | 18:31 |
dansmith | always on at least defcon 2 | 18:31 |
jaypipes | dims: what reviews do you need done, fine sir? | 18:31 |
* bauzas threatens to show "Y a t'il un pilote dans l'avion" with French dubbed jokes | 18:31 | |
mriedem | dansmith: so like the NRA | 18:31 |
dansmith | ...and rifles standing by the door | 18:31 |
*** nihilifer has joined #openstack-nova | 18:31 | |
*** Nikolay_St has quit IRC | 18:31 | |
dims | jaypipes: nothing urgent jay :) | 18:31 |
jaypipes | dims: roger that. | 18:32 |
dims | thanks for asking :) | 18:32 |
jaypipes | :) | 18:32 |
*** READ10 has quit IRC | 18:32 | |
dansmith | roger roger. | 18:33 |
*** Nikolay_St has joined #openstack-nova | 18:33 | |
mriedem | so i have an actual real question about a real thing | 18:34 |
*** piyanai has quit IRC | 18:34 | |
mriedem | for rootwrap filters, when a command is listed in the wrong module, but it shows up in multiple places, do we list the other multiple places (there are only 2), or just leave the wrong module path in the comment? | 18:34 |
mriedem | https://github.com/openstack/nova/blob/master/etc/nova/rootwrap.d/compute.filters#L215 | 18:35 |
mriedem | that doesn't actually happen in volume.py, it happens in the cryptsetup and luks modules for encryptors | 18:35 |
*** tongli has joined #openstack-nova | 18:35 | |
*** piyanai has joined #openstack-nova | 18:35 | |
mriedem | i guess mkfs lists the modules it's called from, so nvm: https://github.com/openstack/nova/blob/master/etc/nova/rootwrap.d/compute.filters#L168 | 18:35 |
sudipto | dims given that your review https://review.openstack.org/195578 has merged, is it correct to assume that if i make changes based on these and submit the patchset in nova - jenkins would be happy? | 18:36 |
sudipto | dims, or does it have a time period - after which it starts to work? | 18:36 |
*** andreykurilin__ has quit IRC | 18:37 | |
*** kiran-r has quit IRC | 18:38 | |
*** irenab has quit IRC | 18:38 | |
*** sdake has quit IRC | 18:38 | |
*** dprince has quit IRC | 18:38 | |
*** sdake has joined #openstack-nova | 18:38 | |
*** kiran-r has joined #openstack-nova | 18:39 | |
*** dprince has joined #openstack-nova | 18:39 | |
jaypipes | bauzas: https://review.openstack.org/#/c/145528/ needs a rebase please sir. | 18:39 |
jaypipes | bauzas: I'd like to get that patch series reviewed and merged within next week. | 18:39 |
bauzas | jaypipes: yup, I'm on it, but I discovered something really really bad | 18:39 |
*** piyanai has quit IRC | 18:39 | |
jaypipes | bauzas: what's that? | 18:40 |
*** Marga_ has joined #openstack-nova | 18:40 | |
bauzas | jaypipes: so, the thing is, the ImageMeta object is missing a property | 18:40 |
jaypipes | bauzas: so add one :) | 18:40 |
bauzas | jaypipes: at the moment, I'm also changing all the filters in one row to use the object - that's pretty time consuming :-) | 18:40 |
bauzas | jaypipes: so I expect to send the updated series by tomorrow | 18:41 |
*** sdake_ has joined #openstack-nova | 18:41 | |
*** doude has joined #openstack-nova | 18:41 | |
bauzas | I know that you US guys are going on vacation while our proud French boys will still be working, but that's fair | 18:41 |
*** Marga__ has joined #openstack-nova | 18:42 | |
mriedem | bauzas: doesn't france have like mandatory 3 month vacation for everyone or something? | 18:42 |
*** Marga__ has quit IRC | 18:42 | |
dansmith | yeah, no complaints | 18:42 |
bauzas | mriedem: don't leave me explain what some people here are asking for | 18:42 |
bauzas | that's kind of a joke | 18:43 |
*** Marga__ has joined #openstack-nova | 18:43 | |
mriedem | this weekend we celebrate our independence from johnthetubaguy by blowing things up and eating many grilled meats | 18:43 |
bauzas | mriedem: at least you have a movie which explains that to us | 18:44 |
mriedem | ha | 18:44 |
mriedem | with the aliens? | 18:44 |
bauzas | mriedem: yup | 18:44 |
mriedem | terrible | 18:44 |
bauzas | mriedem: I'm sincerely sorry about that one | 18:44 |
mriedem | nothing says 'merica like will smith punching an alien in the face | 18:44 |
*** sdake has quit IRC | 18:44 | |
*** Marga_ has quit IRC | 18:44 | |
*** Sukhdev has joined #openstack-nova | 18:44 | |
*** kiran-r has quit IRC | 18:44 | |
dansmith | lol | 18:44 |
dansmith | yes, Independence Day (tm) is exactly what happens every fourth | 18:45 |
mriedem | don't forget that randy quaid has a starring role | 18:45 |
*** lucas__ has quit IRC | 18:45 | |
mriedem | before he was living in a trash can | 18:45 |
*** mutoulbj has quit IRC | 18:46 | |
bauzas | :) | 18:46 |
*** ctrath1 has joined #openstack-nova | 18:47 | |
*** Mike_D_laptop has joined #openstack-nova | 18:47 | |
mriedem | sudipto: what is your nova change? | 18:47 |
mriedem | sudipto: nova changes won't pick up oslo.db changes until a release of oslo.db with the change is out | 18:47 |
sudipto | mriedem, oh k. Here's the nova patchset. | 18:48 |
sudipto | mriedem, a UT was fails due to a dependency in the oslo.db project...the oslo patchset has got merged a few hours back...and i have a patchset built on top of that. | 18:49 |
sudipto | *a UT was failing. | 18:49 |
*** lucas__ has joined #openstack-nova | 18:50 | |
*** gokrokve_ has quit IRC | 18:50 | |
*** ctrath has quit IRC | 18:50 | |
*** bradjones has quit IRC | 18:51 | |
rlrossit | mriedem: how *dare* you insult will smith's greatest adult role | 18:52 |
*** bradjones has joined #openstack-nova | 18:52 | |
*** bradjones has quit IRC | 18:52 | |
*** bradjones has joined #openstack-nova | 18:52 | |
mriedem | brb | 18:53 |
*** sudipto has quit IRC | 18:53 | |
rlrossit | dansmith: with this ovo bug, does that mean I'm supposed to start harassing you on the oslo channel too now? | 18:53 |
dansmith | rlrossit: it doesn't really matter for this, and I'll be less grumpy if I have to keep switching channels :) | 18:54 |
rlrossit | well, since I'm already here... https://bugs.launchpad.net/oslo.versionedobjects/+bug/1470617 is up for your scrutiny | 18:56 |
openstack | Launchpad bug 1470617 in oslo.versionedobjects "ObjectListBase only checks child_versions in obj_make_compatible()" [Undecided,New] | 18:56 |
*** Marga__ has quit IRC | 18:56 | |
*** Marga_ has joined #openstack-nova | 18:57 | |
dansmith | rlrossit: looks good, thanks | 18:57 |
rlrossit | dansmith: which change would you prefer to get first, the oslo one or the nova one? | 18:57 |
rlrossit | I'll spend my dwindling work hours on whichever you choose | 18:58 |
dansmith | rlrossit: I think it'll be easier to show that it works in nova, so I'd do that first | 18:58 |
dansmith | rlrossit: it's a little backwards, but o.vo spawned to absorb nova's object code, so we're still kindof in backslide mode at the moment | 18:58 |
rlrossit | isn't that how every project starts? it gets incubated in nova :P | 18:59 |
*** irenab has joined #openstack-nova | 19:01 | |
*** LukeHinds has quit IRC | 19:02 | |
dansmith | rlrossit: you catch on fast | 19:02 |
*** unicell has quit IRC | 19:03 | |
*** otter768 has joined #openstack-nova | 19:07 | |
*** tongli has quit IRC | 19:07 | |
*** Marga_ has quit IRC | 19:09 | |
*** erlon has quit IRC | 19:10 | |
*** nihilifer has quit IRC | 19:10 | |
*** gokrokve has joined #openstack-nova | 19:10 | |
*** otter768 has quit IRC | 19:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: rootwrap: update ln --symbolic filter for FS and FC type volume drivers https://review.openstack.org/197713 | 19:12 |
*** boris-42 has joined #openstack-nova | 19:13 | |
*** gszasz has quit IRC | 19:21 | |
*** sdake has joined #openstack-nova | 19:21 | |
*** sdake has quit IRC | 19:23 | |
*** sdake has joined #openstack-nova | 19:23 | |
*** zhenguo has quit IRC | 19:23 | |
*** aysyd has quit IRC | 19:23 | |
*** apuimedo has quit IRC | 19:24 | |
*** piyanai has joined #openstack-nova | 19:25 | |
*** sdake_ has quit IRC | 19:25 | |
*** aysyd has joined #openstack-nova | 19:25 | |
*** thangp has quit IRC | 19:26 | |
*** kiran-r has joined #openstack-nova | 19:26 | |
nagyz_ | mriedem, nice fix on the rootwrap issue. I was looking at it but it looked much more complicated to me :) | 19:28 |
mriedem | nagyz_: thanks, looking at https://bugs.launchpad.net/nova/+bug/1470562 now | 19:29 |
openstack | Launchpad bug 1470562 in OpenStack Compute (nova) "'in use' error when Nova volume encryptors format cinder volumes" [Medium,Confirmed] | 19:29 |
mriedem | not sure if a simple retry will help in there or not | 19:29 |
mriedem | docs on cryptsetup kind of suck | 19:29 |
*** Marga_ has joined #openstack-nova | 19:29 | |
*** annashen has quit IRC | 19:29 | |
nagyz_ | cryptseutp sucks. | 19:30 |
*** dansmith has quit IRC | 19:30 | |
nagyz_ | I'm still not sure why there is a separate luks and cryptsetup encryptor? | 19:30 |
*** annashen has joined #openstack-nova | 19:30 | |
*** dansmith has joined #openstack-nova | 19:30 | |
nagyz_ | would you mind taking a quick look at one of my 2 line fixes? I think it's a very simple fix. :) | 19:31 |
*** lyarwood has quit IRC | 19:31 | |
mriedem | link | 19:32 |
*** lyarwood has joined #openstack-nova | 19:33 | |
*** nihilifer has joined #openstack-nova | 19:33 | |
nagyz_ | https://review.openstack.org/#/c/196647/ | 19:33 |
*** lpetrut has joined #openstack-nova | 19:34 | |
*** armax has quit IRC | 19:34 | |
nagyz_ | not sure about the underlying issue, tho, so this might just be a cosmetic fix - I've applied the same fix that seems to be used for this kind of issues | 19:34 |
*** piyanai has quit IRC | 19:34 | |
*** annashen has quit IRC | 19:34 | |
*** gokrokve has quit IRC | 19:36 | |
*** ociuhandu has joined #openstack-nova | 19:36 | |
*** aysyd has quit IRC | 19:37 | |
*** Mike_D_laptop has quit IRC | 19:38 | |
*** lyarwood has quit IRC | 19:38 | |
*** lyarwood_ has joined #openstack-nova | 19:38 | |
*** aysyd has joined #openstack-nova | 19:39 | |
lifeless | dims: about ? | 19:39 |
*** nkrinner has joined #openstack-nova | 19:40 | |
lifeless | dims: mriedem: That looks like my I1d254c42e0bc2550ceeb768532448b5797d87caf isn't live yet | 19:41 |
*** agireud has quit IRC | 19:41 | |
*** kiran-r has quit IRC | 19:42 | |
*** nadirvardar has joined #openstack-nova | 19:42 | |
*** armax has joined #openstack-nova | 19:42 | |
*** emagana has joined #openstack-nova | 19:43 | |
emagana | Hi Nova Devs! | 19:43 |
emagana | In Icehouse when I fire up a VM with a 4096 MB or higher, it's stuck forever on "Spawning". Smaller flavors works fine. Any idea why this is happening? I have plenty of memory in my compute nodes! | 19:44 |
*** vishwana_ has joined #openstack-nova | 19:45 | |
*** mutoulbj has joined #openstack-nova | 19:47 | |
*** vishwanathj has quit IRC | 19:47 | |
*** unicell has joined #openstack-nova | 19:53 | |
*** piyanai has joined #openstack-nova | 19:53 | |
dansmith | mriedem: oh my god | 19:54 |
dansmith | mriedem: the horrific test_servers tests are mirrored for v3 in plugins/v3/test_servers | 19:54 |
mriedem | nagyz_: the change seems OK but could you add a simple unit test? | 19:54 |
mriedem | dansmith: you might also like to look at this given the instance event callback stuff happening https://review.openstack.org/#/c/196647/ | 19:54 |
*** mutoulbj has quit IRC | 19:54 | |
mriedem | dansmith: double the tests, double your fun | 19:54 |
*** agireud has joined #openstack-nova | 19:55 | |
*** yamahata has joined #openstack-nova | 19:55 | |
dansmith | okay, opened the tab | 19:55 |
*** lpetrut has quit IRC | 19:56 | |
lifeless | garyk: hi if you have time - https://review.openstack.org/#/c/189934/ | 19:57 |
lifeless | garyk: (we're -two- patches away from having constraints live) | 19:57 |
*** tjones1 has quit IRC | 19:58 | |
mriedem | lifeless: are you going to rebase this? https://review.openstack.org/#/c/196934/ | 19:59 |
mriedem | lifeless: i think you're missing some g-r updates since that first patch | 19:59 |
*** ajayaa has quit IRC | 19:59 | |
*** flwang has joined #openstack-nova | 20:00 | |
*** tjones1 has joined #openstack-nova | 20:00 | |
*** penick has quit IRC | 20:01 | |
*** achanda has quit IRC | 20:03 | |
lifeless | mriedem: I can sure | 20:03 |
*** achanda has joined #openstack-nova | 20:07 | |
*** achanda has quit IRC | 20:09 | |
lifeless | mriedem: http://logs.openstack.org/34/196934/1/check/gate-nova-python27/d3fa8c5/ | 20:09 |
mriedem | lifeless: needs a rebase | 20:10 |
lifeless | mriedem: is that why? ok. | 20:10 |
mriedem | yeah, that test was fixed | 20:10 |
lifeless | mriedem: if the test was fixed in trunk a simple recheck will do | 20:10 |
mriedem | yeah it was | 20:10 |
mriedem | recheck away | 20:10 |
lifeless | mriedem: but I can resync with requirements too anyhow | 20:10 |
lifeless | so let me do that | 20:10 |
*** belmoreira has joined #openstack-nova | 20:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Try luksFormat up to 3 times in case the device is in use https://review.openstack.org/197721 | 20:11 |
mriedem | emagana: first, see channel topic, second, turn on debug logging and tail the logs to see where the instance is stuck | 20:12 |
*** nic has quit IRC | 20:13 | |
emagana | mriedem: sorry about that.. not sure which channel to use | 20:14 |
mriedem | emagana: see topic :) | 20:14 |
mriedem | it holds the secrets | 20:14 |
emagana | mriedem: logs do not show much but I will stop this thread in this channel.. thanks! | 20:14 |
openstackgerrit | lifeless proposed openstack/nova: Remove python3 specific test-requirements file. https://review.openstack.org/196934 | 20:14 |
lifeless | mriedem: ^ | 20:15 |
mriedem | emagana: otherwise try getting a guru meditation report | 20:15 |
mriedem | emagana: http://docs.openstack.org/developer/nova/devref/gmr.html | 20:15 |
*** belmoreira has quit IRC | 20:15 | |
emagana | mriedem: thanks for the pointer! | 20:15 |
* dims peeks at scrollback | 20:16 | |
mriedem | dansmith: do you know how we get the hudson-openstack lp user in the nova bug team again? | 20:17 |
mriedem | https://launchpad.net/~nova-bugs/+members#active | 20:17 |
mriedem | that's why we're not seeing patches linked to nova bug reports | 20:17 |
*** lucas-dinner has quit IRC | 20:19 | |
mriedem | nvm | 20:19 |
*** cburgess_ has quit IRC | 20:23 | |
*** cburgess has joined #openstack-nova | 20:23 | |
openstackgerrit | jichenjc proposed openstack/nova: Soft delete system_metadata when destroy instance https://review.openstack.org/110875 | 20:24 |
*** ivasev has quit IRC | 20:26 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 20:27 |
*** packet has quit IRC | 20:28 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Enable python34 tests for nova/tests/unit/objects/test*.py https://review.openstack.org/187785 | 20:29 |
*** jgrimm is now known as zz_jgrimm | 20:29 | |
dansmith | mriedem: weird | 20:31 |
mriedem | dansmith: fungi has a fix up https://review.openstack.org/#/c/197725/ | 20:31 |
*** lucas-dinner has joined #openstack-nova | 20:31 | |
dansmith | ah, cool | 20:31 |
*** romainh has joined #openstack-nova | 20:32 | |
*** earlephilhower has joined #openstack-nova | 20:36 | |
*** ijw_ has quit IRC | 20:36 | |
*** openstackgerrit has quit IRC | 20:37 | |
*** Marga_ has quit IRC | 20:37 | |
*** openstackgerrit has joined #openstack-nova | 20:37 | |
*** romainh has left #openstack-nova | 20:37 | |
*** sahid has quit IRC | 20:41 | |
*** nkrinner has quit IRC | 20:44 | |
*** Sukhdev has quit IRC | 20:44 | |
*** unicell1 has joined #openstack-nova | 20:45 | |
*** unicell has quit IRC | 20:45 | |
*** Sukhdev has joined #openstack-nova | 20:45 | |
*** neiljerram_bb has joined #openstack-nova | 20:45 | |
*** annashen has joined #openstack-nova | 20:46 | |
*** neiljerram_bb has quit IRC | 20:46 | |
htruta | hi guys! Is there a reason for nova does not consider ram overcommit when live migrating an instance? | 20:47 |
htruta | or is it a bug? | 20:47 |
*** mriedem has quit IRC | 20:49 | |
bauzas | htruta: look at https://review.openstack.org/#/c/179224/ | 20:50 |
*** thumpba has joined #openstack-nova | 20:51 | |
bauzas | htruta: also https://review.openstack.org/#/c/180151/ | 20:51 |
htruta | bauzas: nice. I kind of liked the patch :) but will take a deeper look at the spec tonight | 20:53 |
htruta | thanks | 20:53 |
bauzas | np | 20:54 |
*** jasondotstar has joined #openstack-nova | 21:01 | |
*** varunarya has joined #openstack-nova | 21:01 | |
*** thorst has quit IRC | 21:05 | |
*** sdake_ has joined #openstack-nova | 21:07 | |
*** otter768 has joined #openstack-nova | 21:08 | |
*** lucas__ has quit IRC | 21:09 | |
*** sdake has quit IRC | 21:09 | |
*** lucas__ has joined #openstack-nova | 21:10 | |
*** aysyd has quit IRC | 21:11 | |
*** otter768 has quit IRC | 21:12 | |
*** mnestratov has joined #openstack-nova | 21:15 | |
*** tjones1 has quit IRC | 21:16 | |
*** mnestratov|2 has quit IRC | 21:18 | |
*** tjones1 has joined #openstack-nova | 21:18 | |
*** exploreshaifali has quit IRC | 21:21 | |
*** rlrossit has left #openstack-nova | 21:21 | |
*** heyongli has quit IRC | 21:23 | |
*** karimb has joined #openstack-nova | 21:23 | |
*** lucas__ has quit IRC | 21:24 | |
*** heyongli has joined #openstack-nova | 21:24 | |
*** edmondsw has quit IRC | 21:28 | |
*** thumpba has quit IRC | 21:28 | |
*** heyongli has quit IRC | 21:29 | |
*** lucas__ has joined #openstack-nova | 21:29 | |
*** lucas__ has quit IRC | 21:30 | |
*** jasondotstar has quit IRC | 21:30 | |
*** busterswt has quit IRC | 21:30 | |
*** lucas__ has joined #openstack-nova | 21:30 | |
*** heyongli has joined #openstack-nova | 21:31 | |
*** ddaskal has quit IRC | 21:31 | |
*** lucas__ has quit IRC | 21:35 | |
*** tjones2 has joined #openstack-nova | 21:36 | |
*** tjones1 has quit IRC | 21:37 | |
*** doude has quit IRC | 21:38 | |
*** doude has joined #openstack-nova | 21:38 | |
*** dprince has quit IRC | 21:39 | |
*** varunarya has quit IRC | 21:40 | |
*** Jeffrey4l has quit IRC | 21:41 | |
*** doude has quit IRC | 21:42 | |
*** doude has joined #openstack-nova | 21:43 | |
*** Jeffrey4l has joined #openstack-nova | 21:43 | |
*** READ10 has joined #openstack-nova | 21:45 | |
*** doude has quit IRC | 21:47 | |
*** lucas__ has joined #openstack-nova | 21:47 | |
*** mmedvede has quit IRC | 21:48 | |
*** doude has joined #openstack-nova | 21:48 | |
openstackgerrit | Victor Stinner proposed openstack/nova: Port crypto to Python 3 https://review.openstack.org/197748 | 21:50 |
*** lucas__ has quit IRC | 21:52 | |
*** varunarya has joined #openstack-nova | 21:52 | |
*** _diana_ has joined #openstack-nova | 21:53 | |
*** _diana_ has quit IRC | 21:54 | |
*** _diana_ has joined #openstack-nova | 21:54 | |
*** ianbrown has joined #openstack-nova | 21:55 | |
*** burt has quit IRC | 22:00 | |
*** annegentle has joined #openstack-nova | 22:02 | |
*** nihilifer_ has joined #openstack-nova | 22:04 | |
*** nihilifer has quit IRC | 22:04 | |
*** nihilifer_ is now known as nihilifer | 22:04 | |
openstackgerrit | Zoltan Arnold Nagy proposed openstack/nova: Handle unexpected clear events call https://review.openstack.org/196647 | 22:06 |
*** ZZelle_ has quit IRC | 22:08 | |
*** xyhuang has quit IRC | 22:10 | |
*** _cerberus_ has quit IRC | 22:12 | |
*** ijw has joined #openstack-nova | 22:14 | |
*** mmedvede has joined #openstack-nova | 22:16 | |
*** sdake_ is now known as sdake | 22:17 | |
*** doude has quit IRC | 22:17 | |
*** dims_ has joined #openstack-nova | 22:17 | |
*** annashen has quit IRC | 22:20 | |
*** dims has quit IRC | 22:21 | |
*** annashen has joined #openstack-nova | 22:21 | |
*** nadirvardar has quit IRC | 22:23 | |
*** annashen has quit IRC | 22:25 | |
*** sambol has quit IRC | 22:26 | |
tonyb | mriedem: I tried to reproduce it with a few different systems/changes and I couldn't | 22:27 |
tonyb | mriedem: so my grand plan became "leave it for 24 hours and see if it still happens" | 22:28 |
tonyb | mriedem: I only see the 2 hits from yesterday | 22:29 |
*** sdake is now known as sdake_ | 22:29 | |
*** _cerberus_ has joined #openstack-nova | 22:30 | |
*** ctrath1 has quit IRC | 22:32 | |
*** agireud has quit IRC | 22:33 | |
*** _cerberus_ has quit IRC | 22:34 | |
*** _diana_ has quit IRC | 22:34 | |
dansmith | tonyb: I fixed it | 22:35 |
tonyb | dansmith: Oh! | 22:35 |
* tonyb goes looking for the review | 22:36 | |
dansmith | tonyb: the reason for the bug was long and complex | 22:36 |
dansmith | tonyb: but the tl;dr is: I'm a dolt | 22:37 |
dansmith | https://review.openstack.org/#/c/197611/ | 22:37 |
*** emagana has quit IRC | 22:37 | |
openstackgerrit | Zoltan Arnold Nagy proposed openstack/nova: Handle unexpected clear events call https://review.openstack.org/196647 | 22:37 |
tonyb | dansmith: Thanks. I look forward to reading about how you're a dolt :) | 22:37 |
dansmith | heh | 22:37 |
*** _cerberus_ has joined #openstack-nova | 22:38 | |
*** ijuwang has quit IRC | 22:38 | |
tonyb | dansmith: So the change makes sense but why didn't it hit everytime? | 22:40 |
dansmith | tonyb: because we didn't put the thing into the tree until the setdefault() call, which we did after the recurision | 22:40 |
dansmith | if it's in there, then the check at the top prevents us from recursing | 22:41 |
dansmith | so we had to arrive at the classes in just the right order to disappear down the rabbit hole :) | 22:41 |
*** browne has quit IRC | 22:43 | |
*** Sukhdev has quit IRC | 22:45 | |
*** Sukhdev has joined #openstack-nova | 22:45 | |
melwitt | dansmith: looks like we can use the proposed patch after all (latest comment) for https://bugs.launchpad.net/nova/+bug/1404795 because evacuate can't be retried if instance.host isn't a down host | 22:45 |
openstack | Launchpad bug 1404795 in OpenStack Compute (nova) "instance's host and node are target host's while evacuate failed" [Critical,In progress] - Assigned to ChangBo Guo(gcb) (glongwave) | 22:45 |
dansmith | melwitt: hmm | 22:46 |
*** nihilifer has quit IRC | 22:46 | |
melwitt | dansmith: let me know what you think | 22:47 |
openstackgerrit | Victor Stinner proposed openstack/nova: Enable oslo.vmware dependency on Python 3 https://review.openstack.org/197762 | 22:47 |
tonyb | dansmith: Ahh I see. Thanks for the education. | 22:48 |
tonyb | dansmith: lets hope I remember it :) | 22:48 |
dansmith | heh | 22:49 |
*** nihilifer has joined #openstack-nova | 22:52 | |
dansmith | melwitt: I can tell you one thing I think and that is that the bug shouldn't be critical :) | 22:53 |
*** sdake_ has quit IRC | 22:54 | |
melwitt | dansmith: heh. yeah, I should change it | 22:54 |
*** nihilifer has quit IRC | 22:56 | |
dansmith | melwitt: you should do two things | 22:57 |
*** lucas-dinner has quit IRC | 22:57 | |
dansmith | melwitt: (1) prepare for the tongue-in-cheek rubber stamp +2 requests that befit a core | 22:57 |
dansmith | melwitt: (2) You should approve this and the patch below it because I need them: https://review.openstack.org/#/c/197526/2 | 22:57 |
dansmith | :) | 22:57 |
melwitt | lol | 22:57 |
*** jecarey has quit IRC | 22:57 | |
dansmith | although I just noticed a typo in the commit message | 22:58 |
openstackgerrit | Dan Smith proposed openstack/nova: tests: Move test_resource_tracker to Instance objects https://review.openstack.org/197526 | 22:58 |
dansmith | approve _that_ ^ :) | 22:59 |
* melwitt looks | 23:01 | |
dansmith | pretty boring dict-to-object test conversions | 23:02 |
*** tonytan4ever has quit IRC | 23:02 | |
*** radek_ has quit IRC | 23:05 | |
*** tjones2 has quit IRC | 23:05 | |
*** nelsnelson has quit IRC | 23:07 | |
*** otter768 has joined #openstack-nova | 23:08 | |
*** lucas-dinner has joined #openstack-nova | 23:09 | |
*** jasondotstar has joined #openstack-nova | 23:09 | |
*** annegentle has quit IRC | 23:10 | |
*** READ10 has quit IRC | 23:11 | |
melwitt | dansmith: +Warthog'd | 23:12 |
dansmith | melwitt: thanks! | 23:13 |
*** otter768 has quit IRC | 23:13 | |
*** zhenguo has joined #openstack-nova | 23:14 | |
*** lucas-dinner has quit IRC | 23:14 | |
dansmith | melwitt: you saw I commented on that evac patch I assume | 23:16 |
melwitt | dansmith: I did | 23:17 |
melwitt | thanks. what you said makes sense, I wasn't sure which direction to go about it, whether to "roll back to source" vs change evacuate's criteria a bit | 23:18 |
dansmith | yeah, I think rolling back to source is potentially problematic if you race with the node coming back up | 23:18 |
dansmith | I *think* a rebuild of that instance would work, but it might only try to rebuild on the new destination | 23:18 |
dansmith | which if it broke because that host is broken, might not be very useful | 23:18 |
*** piyanai has quit IRC | 23:19 | |
*** Nakato_ is now known as Nakato | 23:19 | |
melwitt | ah, yeah | 23:20 |
openstackgerrit | Dan Smith proposed openstack/nova: Convert test_compute_utils to use Instance object https://review.openstack.org/196912 | 23:20 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove compat_instance() https://review.openstack.org/192708 | 23:20 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove flavor migration from db_api and nova-manage https://review.openstack.org/196911 | 23:20 |
openstackgerrit | Dan Smith proposed openstack/nova: Decouple instance object tests from the api fakes module https://review.openstack.org/197769 | 23:20 |
openstackgerrit | Dan Smith proposed openstack/nova: Refactor test_servers to use instance objects https://review.openstack.org/197770 | 23:20 |
openstackgerrit | Dan Smith proposed openstack/nova: WIP: Remove legacy flavor compatibility code from Instance https://review.openstack.org/197771 | 23:20 |
*** mutoulbj has joined #openstack-nova | 23:22 | |
alex_xu | bauzas: jaypipes I think we should return 400, not 409 for both host and force provided https://review.openstack.org/#/c/179224/ | 23:26 |
alex_xu | API-WG guideline isn't very clear for this case. Looks like it's time to be liaison | 23:27 |
*** IanGovett has quit IRC | 23:30 | |
*** otter768 has joined #openstack-nova | 23:30 | |
*** tjones1 has joined #openstack-nova | 23:31 | |
*** annegentle has joined #openstack-nova | 23:34 | |
*** browne has joined #openstack-nova | 23:39 | |
*** baoli has quit IRC | 23:41 | |
*** mutoulbj has quit IRC | 23:46 | |
*** tjones1 has quit IRC | 23:48 | |
*** tjones1 has joined #openstack-nova | 23:50 | |
*** annashen has joined #openstack-nova | 23:51 | |
*** jasondotstar has quit IRC | 23:52 | |
jaypipes | alex_xu: :) | 23:53 |
*** ijw has quit IRC | 23:54 | |
*** annashen has quit IRC | 23:56 | |
*** ijw_ has joined #openstack-nova | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!