*** openstack has joined #openstack-nova | 15:45 | |
BobBall | notmorgan: But when you make changes to the plugin, you also need to increment the XenAPI plugin version number (see https://git.openstack.org/cgit/openstack/nova/tree/plugins/xenserver/xenapi/etc/xapi.d/plugins/nova_plugin_version and https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/client/session.py#n84) - as long as you give a default for glance_path in download_vhd then it's backwards compatable and you can just d | 15:45 |
---|---|---|
*** FL1SK has joined #openstack-nova | 15:45 | |
*** akshai has joined #openstack-nova | 15:46 | |
*** Sukhdev_ has joined #openstack-nova | 15:46 | |
*** flaper87 has joined #openstack-nova | 15:46 | |
*** lpetrut has joined #openstack-nova | 15:47 | |
*** rfolco has joined #openstack-nova | 15:47 | |
notmorgan | BobBall: ok | 15:48 |
*** e0ne has joined #openstack-nova | 15:48 | |
notmorgan | BobBall: yeah thats is the plan, the default will be "" | 15:48 |
notmorgan | BobBall: so no change in behavior | 15:48 |
BobBall | awesome | 15:48 |
notmorgan | BobBall: now, i *do* want to look into backporting this change for the genral case, but thats is a convo to have once this lands | 15:49 |
*** salv-orlando has joined #openstack-nova | 15:49 | |
*** cfarquhar has joined #openstack-nova | 15:49 | |
*** cfarquhar has quit IRC | 15:49 | |
*** cfarquhar has joined #openstack-nova | 15:49 | |
*** lpetrut has quit IRC | 15:49 | |
notmorgan | BobBall: not sure how will that will work for the plugin w/ versioning | 15:49 |
BobBall | backporting for the general case? What do you mean there? | 15:49 |
*** scheuran has quit IRC | 15:49 | |
*** dims has joined #openstack-nova | 15:49 | |
notmorgan | BobBall: general case = not with a plugin | 15:50 |
openstackgerrit | Andrew Bogott proposed openstack/nova: Prevent scheduling of instances on full hosts. https://review.openstack.org/242251 | 15:50 |
*** shaohe_feng has joined #openstack-nova | 15:50 | |
notmorgan | BobBall: the other codepath that i already have an easy fix for. | 15:50 |
notmorgan | BobBall: but let me land this / finish the code then we will discuss backports if possible | 15:50 |
notmorgan | and how that is handled :) | 15:50 |
BobBall | ok | 15:50 |
notmorgan | because can't backport till this lands anyway | 15:50 |
*** burt has joined #openstack-nova | 15:51 | |
*** rlrossit has quit IRC | 15:51 | |
*** corvus is now known as jeblair | 15:52 | |
*** garyk has quit IRC | 15:52 | |
*** amotoki has quit IRC | 15:53 | |
*** rlrossit has joined #openstack-nova | 15:53 | |
*** agireud has joined #openstack-nova | 15:53 | |
*** garyk has joined #openstack-nova | 15:54 | |
johnthetubaguy | pkholkin: rpodolyaka: I would like to see what others think about that, still seems a bit odd to me. Added a comment around some more tests and a link to some utils we have to help with the decorator | 15:54 |
*** rook has quit IRC | 15:55 | |
*** Kevin_Zheng has quit IRC | 15:56 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova-specs: Attach/detach SR-IOV interface https://review.openstack.org/139910 | 15:56 |
*** Kevin_Zheng has joined #openstack-nova | 15:56 | |
*** jistr has quit IRC | 15:57 | |
*** lucas-afk is now known as lucasagomes | 15:58 | |
*** jasondotstar has joined #openstack-nova | 15:58 | |
*** sdague has joined #openstack-nova | 15:59 | |
*** mriedem has joined #openstack-nova | 16:00 | |
openstackgerrit | Dan Smith proposed openstack/nova: Actually pass the migration data object down to the virt drivers https://review.openstack.org/248211 | 16:00 |
*** artom has joined #openstack-nova | 16:00 | |
*** bkopilov has quit IRC | 16:00 | |
*** e0ne has quit IRC | 16:02 | |
openstackgerrit | Ryan McNair proposed openstack/nova: Add retry logic for detaching device using LibVirt https://review.openstack.org/227851 | 16:02 |
*** rook has joined #openstack-nova | 16:03 | |
*** zhangjn has quit IRC | 16:05 | |
*** kevinbenton_ has quit IRC | 16:07 | |
*** ccarmack has joined #openstack-nova | 16:07 | |
*** kevinbenton has joined #openstack-nova | 16:07 | |
*** Marga_ has joined #openstack-nova | 16:11 | |
*** irenab has joined #openstack-nova | 16:12 | |
*** Marga_ has quit IRC | 16:13 | |
*** EinstCrazy has quit IRC | 16:13 | |
*** Marga_ has joined #openstack-nova | 16:14 | |
*** rook has quit IRC | 16:14 | |
openstackgerrit | Chuck Carmack proposed openstack/python-novaclient: Remove python 2.6 support from python-novaclient https://review.openstack.org/248874 | 16:14 |
*** tjones has joined #openstack-nova | 16:14 | |
*** rook has joined #openstack-nova | 16:15 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Add better help text to scheduler options https://review.openstack.org/247181 | 16:15 |
*** arif-ali_ has joined #openstack-nova | 16:15 | |
*** arif-ali has quit IRC | 16:15 | |
*** arif-ali_ is now known as arif-ali | 16:15 | |
*** openstackstatus has joined #openstack-nova | 16:16 | |
*** ChanServ sets mode: +v openstackstatus | 16:16 | |
*** pm90__ has joined #openstack-nova | 16:16 | |
*** pm90_ has quit IRC | 16:17 | |
*** pm90_ has joined #openstack-nova | 16:17 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: api: add soft-affinity policies for server groups https://review.openstack.org/147520 | 16:18 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: scheduler: fill RequestSpec.instance_group.members https://review.openstack.org/148277 | 16:18 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: scheduler: add soft-(anti-)affinity weighers https://review.openstack.org/147516 | 16:18 |
bauzas | mriedem: johnthetubaguy: all the reno files have been written for M1 | 16:18 |
bauzas | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:reno_nova-m1,n,z | 16:18 |
*** atuvenie has joined #openstack-nova | 16:19 | |
*** zenoway has quit IRC | 16:19 | |
*** zenoway has joined #openstack-nova | 16:20 | |
*** pm90__ has quit IRC | 16:20 | |
*** hemnafk is now known as hemna | 16:20 | |
mriedem | ok | 16:20 |
*** alexschm_ has quit IRC | 16:20 | |
*** jlanoux has joined #openstack-nova | 16:20 | |
openstackgerrit | Morgan Fainberg proposed openstack/nova: Don't drop uri path when selecting glance api https://review.openstack.org/251138 | 16:21 |
notmorgan | BobBall: ^ there is my stab at it, still need to chase tests down to be 100% sure we don't regress. comments welcome. | 16:21 |
BobBall | Looks good to me - but let's wait to see what the XenServer CI says ;) | 16:24 |
notmorgan | BobBall: sure! and then i might poke at you again re testing if i can't chase some of this stuff down to ensure we don't start dropping the URI again. | 16:24 |
notmorgan | BobBall: :) | 16:24 |
*** zenoway has quit IRC | 16:24 | |
notmorgan | BobBall: and seriously thnx for the help. | 16:24 |
*** mdrabe has joined #openstack-nova | 16:25 | |
BobBall | Awesome. H2H and yeah, let's not drop it in future :) Can we configure devstack to set up a path? If so, it'd be easy to either add it just to the XenServer CI or the generic CI to prove everything works? | 16:26 |
bauzas | mriedem: I'd also love to get reviews for the novaclient reno change https://review.openstack.org/#/c/248895/ | 16:27 |
bauzas | mriedem: because we need to have reno in place the next time we cut a release | 16:28 |
bauzas | (which is 3.0 IIUC) | 16:28 |
*** shaohe_feng has quit IRC | 16:29 | |
mriedem | bauzas: ok | 16:29 |
mriedem | wrapping up some havana psirt backport reviews on this fine morning :) | 16:29 |
*** baoli has quit IRC | 16:29 | |
notmorgan | BobBall: i'm working on a strategy to have all services sub-url mounted - see https://gist.github.com/morganfainberg/c9b73fcd2b76d3a95b14 | 16:30 |
*** vladnikityuk has quit IRC | 16:30 | |
notmorgan | BobBall: so i expect we can do something to this effect for a "real" test long term. but shorter term just having a unit test that ensures the right value is there would be a big step forward :) | 16:30 |
*** baoli has joined #openstack-nova | 16:31 | |
BobBall | unit testing the xapi plugins is an interesting question indeed... I've got a meeting scheduled to talk about that one in February I think - the 30th if I remember rightly. | 16:32 |
*** mjura has quit IRC | 16:33 | |
*** haypo_ has joined #openstack-nova | 16:34 | |
*** mwagner_lap has quit IRC | 16:35 | |
*** mwagner_lap has joined #openstack-nova | 16:35 | |
*** vladnikityuk has joined #openstack-nova | 16:35 | |
*** rook has quit IRC | 16:37 | |
*** tjones has left #openstack-nova | 16:37 | |
*** mjura_ has joined #openstack-nova | 16:38 | |
*** mjura has joined #openstack-nova | 16:38 | |
*** achanda_ has quit IRC | 16:41 | |
*** paul-carlton1 has quit IRC | 16:43 | |
*** mjura has quit IRC | 16:44 | |
*** mgoddard_ has joined #openstack-nova | 16:44 | |
*** xyang1 has joined #openstack-nova | 16:45 | |
*** pm90__ has joined #openstack-nova | 16:45 | |
*** pm90_ has quit IRC | 16:45 | |
*** LukeHinds has quit IRC | 16:46 | |
*** pm90_ has joined #openstack-nova | 16:46 | |
*** haypo_ has quit IRC | 16:48 | |
*** baoli has quit IRC | 16:48 | |
*** mgoddard__ has quit IRC | 16:48 | |
*** pm90__ has quit IRC | 16:49 | |
*** baoli has joined #openstack-nova | 16:50 | |
notmorgan | sdague: responded to your -1/comment on the glance uri patch. | 16:50 |
notmorgan | sdague: i think a quick land it and then solve the bigger shift to catalog is the better approach - mostly because this feels like something we can potentially backport, where moving to the catlog is potentially a lot more effort | 16:51 |
*** sacharya has joined #openstack-nova | 16:52 | |
*** kmartin has joined #openstack-nova | 16:53 | |
mriedem | bauzas: some wording issues in https://review.openstack.org/#/c/250849/ | 16:53 |
*** armax has joined #openstack-nova | 16:54 | |
bauzas | mriedem: ack, respinning | 16:54 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: centralize libvirt options https://review.openstack.org/250907 | 16:54 |
*** atuvenie has quit IRC | 16:54 | |
sdague | notmorgan: that's how we end up with cruft that never leaves the code base | 16:54 |
sdague | and the url parsing ends up with all kinds of weird edge case and bugs, because you've now encoded all these assumptions in | 16:56 |
*** sacharya has quit IRC | 16:56 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for HyperV 2008 drop of support https://review.openstack.org/251408 | 16:57 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for force_config_drive opt change https://review.openstack.org/250852 | 16:57 |
notmorgan | sdague: well, like i said, I'm def. working on this cleanup and will continue on it. *shrug* i still view small fixes as a win especially in this case. | 16:57 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for deprecating local conductor https://review.openstack.org/250849 | 16:57 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for removing conductor RPC API v2 https://review.openstack.org/250865 | 16:57 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for automatic determination of compute_rpc version by service https://review.openstack.org/251432 | 16:57 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for dropping InstanceV1 objects https://review.openstack.org/250859 | 16:57 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for Virtuozzo supporting snapshots https://review.openstack.org/251420 | 16:57 |
*** sacharya has joined #openstack-nova | 16:58 | |
notmorgan | sdague: but i have a specific goal that will be incorporating these cleanup items, just the work to do catalog work is a bit further down the road | 16:58 |
*** achanda has joined #openstack-nova | 16:59 | |
sdague | notmorgan: I don't really see this as a small fix, because it also means that the user application needs to basically embed the same logic | 16:59 |
sdague | so it's creating an anti pattern | 16:59 |
sdague | where as referencing glance like we do cinder in the code would actually start converging us in the right direction, and support a pattern we want people to use | 17:00 |
*** coolsvap has quit IRC | 17:01 | |
*** ildikov has quit IRC | 17:01 | |
mriedem | dansmith: are you happy with this release note for deprecation of local conductor? https://review.openstack.org/#/c/250849/ | 17:01 |
mriedem | it's pretty straight forward | 17:01 |
openstackgerrit | dane-fichter proposed openstack/nova: Functional test for ephemeral storage encryption https://review.openstack.org/240075 | 17:01 |
*** mgoddard_ has quit IRC | 17:02 | |
*** otter768 has joined #openstack-nova | 17:02 | |
*** mgoddard has joined #openstack-nova | 17:02 | |
*** rook has joined #openstack-nova | 17:03 | |
*** jaosorior has quit IRC | 17:03 | |
*** rdo_ has quit IRC | 17:03 | |
*** gcb has quit IRC | 17:05 | |
*** coolsvap has joined #openstack-nova | 17:05 | |
*** derekh has joined #openstack-nova | 17:05 | |
*** Sukhdev_ has quit IRC | 17:06 | |
*** krtaylor has joined #openstack-nova | 17:06 | |
*** otter768 has quit IRC | 17:07 | |
mriedem | bauzas: some issues with https://review.openstack.org/#/c/250852/ and https://review.openstack.org/#/c/251408/ - the rest i'm +W on | 17:07 |
notmorgan | sdague: well then i am going to have to defer a bit on the fix here. which i'm fine with, but just not to the point where i'm digging into how services communitcate to other services and the fixes i will be proposing along those lines. | 17:08 |
*** salv-orl_ has joined #openstack-nova | 17:08 | |
*** sahid has quit IRC | 17:09 | |
openstackgerrit | Tang Chen proposed openstack/nova: Trivial: Fix a typo in power_state.py https://review.openstack.org/251474 | 17:10 |
*** paul-carlton1 has joined #openstack-nova | 17:11 | |
*** salv-orlando has quit IRC | 17:11 | |
bauzas | mriedem: ack, will respin later | 17:11 |
*** Sukhdev_ has joined #openstack-nova | 17:12 | |
openstackgerrit | Tracy Jones proposed openstack/nova: Cleanup of compute api reboot method https://review.openstack.org/127427 | 17:13 |
sdague | notmorgan: yeh, the problem is that api_servers is a minority configuration approach, so in the majority approach you won't support this at all because people are still configuring host & port as separate vars in config | 17:13 |
*** ccarmack has quit IRC | 17:13 | |
notmorgan | sdague: that is a valid point. and i'm happier with that answer. | 17:13 |
notmorgan | sdague: :) | 17:13 |
sdague | notmorgan: sorry, I've been in this code a ton | 17:14 |
*** eharney has joined #openstack-nova | 17:14 | |
notmorgan | sdague: no worries :) | 17:14 |
mriedem | bauzas: do we need reno on stable/liberty novaclient? https://review.openstack.org/#/c/248895/ | 17:14 |
*** EinstCrazy has joined #openstack-nova | 17:14 | |
sdague | and the mess of it means I want no more "just one more fix" | 17:14 |
mriedem | bauzas: the email said that was optional | 17:14 |
notmorgan | sdague: i really only ran across this cause i'm working on a suburl mounted PoC | 17:14 |
sdague | notmorgan: yep, I 100% support us getting there | 17:14 |
notmorgan | sdague: there is a lot of changes i'm catalogging to make this work, and this was the only showstopper of a bug btw i've really hiy | 17:14 |
notmorgan | hit* | 17:14 |
notmorgan | sdague: everything else pretyt much just works | 17:15 |
notmorgan | now, i have to L7 route traffic, but that is fine. it shows we can do it | 17:15 |
sdague | but introducing https://github.com/openstack/nova/blob/1734ce7101982dd95f8fab1ab4815bd258a33744/nova/volume/cinder.py#L42 to glance isn't a huge amount of work | 17:15 |
notmorgan | fixing services to run in wsgi containers is orthogonal to just "does this all work" :) | 17:15 |
sdague | and should solve this as well | 17:15 |
sdague | plus moves the whole ball forward | 17:15 |
*** boris-42_ has quit IRC | 17:15 | |
mriedem | bauzas: nvm, i guess we need to since it's in the master toc tree | 17:16 |
notmorgan | sdague: nod. i'll poke at that in a bit, i just need to get to the point where i'm digging into that step before i take it on | 17:16 |
sdague | notmorgan: sure | 17:16 |
notmorgan | sdague: because it's not the only change i need to roll in that kind of space. | 17:16 |
markus_z | bauzas: If you have time, there is advice necessary in: https://review.openstack.org/#/c/246476/ | 17:16 |
sdague | notmorgan: ok, sure, I'm just saying the reason you hit this as the only big show stopper, is because glance was left off the list when jamielennox converted the services to use the catalog | 17:16 |
sdague | for unknown reasons | 17:16 |
notmorgan | sdague: because glanceclient is special. | 17:17 |
notmorgan | sdague: or was waaaay more special until recently | 17:17 |
sdague | hmmm, ok | 17:17 |
paul-carlton1 | sdague, do you have time to look at https://review.openstack.org/#/c/228828/ please? | 17:21 |
*** EinstCrazy has quit IRC | 17:21 | |
*** signed8bit is now known as signed8bit_ZZZzz | 17:21 | |
*** ccarmack has joined #openstack-nova | 17:22 | |
*** Piet has joined #openstack-nova | 17:22 | |
*** vladnikityuk has quit IRC | 17:24 | |
*** signed8bit_ZZZzz is now known as signed8bit | 17:27 | |
*** rdo has joined #openstack-nova | 17:29 | |
*** ccarmack has quit IRC | 17:30 | |
*** vladnikityuk has joined #openstack-nova | 17:30 | |
*** nic has joined #openstack-nova | 17:31 | |
*** vladnikityuk has quit IRC | 17:31 | |
*** vladnikityuk has joined #openstack-nova | 17:31 | |
*** sacharya has quit IRC | 17:31 | |
*** ccarmack has joined #openstack-nova | 17:33 | |
*** diogogmt has joined #openstack-nova | 17:33 | |
*** jlanoux has quit IRC | 17:36 | |
sdague | paul-carlton1: yeh, that interace looks like what I think we should do | 17:36 |
paul-carlton1 | alex_xu, and others seemed to want the original approach? | 17:38 |
*** nkrinner has quit IRC | 17:38 | |
paul-carlton1 | I'm happy either way, but we need a consensus | 17:38 |
*** rook has quit IRC | 17:38 | |
*** rook has joined #openstack-nova | 17:39 | |
*** unicell has quit IRC | 17:39 | |
*** mjura_ has quit IRC | 17:40 | |
*** rdopiera has quit IRC | 17:41 | |
*** ildikov has joined #openstack-nova | 17:42 | |
*** smurke has joined #openstack-nova | 17:43 | |
markus_z | Any core here who has interest in this libvirt spec? https://review.openstack.org/#/c/234291/ | 17:44 |
*** edmondsw has joined #openstack-nova | 17:44 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [microversions] Increase max version to 2.7 https://review.openstack.org/251483 | 17:45 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [microversions] Add support for 2.8 https://review.openstack.org/251484 | 17:45 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [microversions] Increase max version to 2.9 https://review.openstack.org/251485 | 17:45 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [microversions] WIP: Add support for 2.10 https://review.openstack.org/251486 | 17:45 |
*** Marga_ has quit IRC | 17:45 | |
*** klkumar has quit IRC | 17:50 | |
*** markus_z has quit IRC | 17:50 | |
*** penick has joined #openstack-nova | 17:51 | |
*** hblixt has joined #openstack-nova | 17:53 | |
openstackgerrit | dane-fichter proposed openstack/nova: Functional test for ephemeral storage encryption https://review.openstack.org/240075 | 17:53 |
*** achanda has quit IRC | 17:54 | |
openstackgerrit | Roman Podoliaka proposed openstack/nova: novnc: move config options into [novnc] group https://review.openstack.org/222113 | 17:56 |
*** salv-orl_ has quit IRC | 17:56 | |
*** salv-orlando has joined #openstack-nova | 17:57 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Modify VM's updated_at field on volume actions https://review.openstack.org/247176 | 17:57 |
*** bkopilov has joined #openstack-nova | 17:57 | |
*** paul-carlton1 has quit IRC | 18:00 | |
*** salv-orlando has quit IRC | 18:01 | |
*** derekh has quit IRC | 18:02 | |
*** penick_ has joined #openstack-nova | 18:02 | |
*** ctrath1 has joined #openstack-nova | 18:03 | |
*** penick has quit IRC | 18:04 | |
*** penick_ is now known as penick | 18:04 | |
*** jwang_ has quit IRC | 18:04 | |
*** ctrath has quit IRC | 18:04 | |
Lyncos1 | Hi, I'm I at the right place to get help with kilo and hugepages ? | 18:04 |
*** Kevin_Zheng has quit IRC | 18:06 | |
ndipanov | Lyncos1, yeah | 18:06 |
Lyncos1 | I'm struggling setting 1GB hugepages... I always get : Returning exception Page size 1048576 is not supported by the host. to caller | 18:07 |
Lyncos1 | when my numa for that host seems ok: | 18:07 |
Lyncos1 | http://pastebin.com/QxVBHThB | 18:08 |
Lyncos1 | from the mysql db ... I see 50x 1GB hugepages right ? | 18:08 |
*** jwang has joined #openstack-nova | 18:08 | |
Lyncos1 | this is the full log: http://pastebin.com/byTJhSXg | 18:09 |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Modify VM's updated_at field on volume actions https://review.openstack.org/247176 | 18:09 |
Lyncos1 | it dosen't seems to go into the NUMA filter... not sure ? in that aggregate I(with numa pinning and hugepages) I only have 1 host | 18:09 |
ndipanov | Lyncos1, how's your flavor set? | 18:10 |
*** harlowja has joined #openstack-nova | 18:10 | |
*** mikeit has joined #openstack-nova | 18:10 | |
ndipanov | Lyncos1, it's best not to specify the exact page size unless necessary and just go with large | 18:10 |
Lyncos1 | hw:cpu_policy = dedicated , hw:mem_page_size = 1048576 | 18:10 |
*** baoli_ has joined #openstack-nova | 18:10 | |
Lyncos1 | Ok so In flavor I just set Large and it will use the largest possible ? | 18:11 |
*** edmondsw has quit IRC | 18:11 | |
*** changbl has quit IRC | 18:12 | |
ndipanov | yeah | 18:12 |
ndipanov | large | 18:12 |
ndipanov | not Large | 18:12 |
Lyncos1 | damn | 18:12 |
Lyncos1 | seems better | 18:12 |
*** paul-carlton1 has joined #openstack-nova | 18:12 | |
Lyncos1 | now I get: unable to create backing store for hugepages: Permission denied | 18:12 |
Lyncos1 | :-0 | 18:12 |
ndipanov | Lyncos1, cool | 18:12 |
Lyncos1 | I guess it is permission on mount point | 18:13 |
*** baoli has quit IRC | 18:14 | |
*** changbl has joined #openstack-nova | 18:14 | |
*** adam_g has quit IRC | 18:14 | |
*** adam_g has joined #openstack-nova | 18:14 | |
*** adam_g has quit IRC | 18:15 | |
*** adam_g has joined #openstack-nova | 18:15 | |
*** unicell has joined #openstack-nova | 18:16 | |
Lyncos1 | ndipanov: I changed perms to 775 and group kvm .. still not working .. any idea ? | 18:17 |
*** ndipanov has quit IRC | 18:17 | |
*** anshprat has quit IRC | 18:17 | |
*** baoli_ has quit IRC | 18:18 | |
*** ctrath1 has quit IRC | 18:20 | |
*** artom has quit IRC | 18:20 | |
*** nic has quit IRC | 18:20 | |
*** EinstCrazy has joined #openstack-nova | 18:21 | |
*** davidlenwell has quit IRC | 18:21 | |
*** ctrath has joined #openstack-nova | 18:21 | |
*** davideagnello has joined #openstack-nova | 18:22 | |
*** Guest44042 has quit IRC | 18:22 | |
*** nikhil|afk has joined #openstack-nova | 18:22 | |
*** nic has joined #openstack-nova | 18:22 | |
*** swamireddy has quit IRC | 18:22 | |
*** davidlenwell has joined #openstack-nova | 18:23 | |
*** Guest83268 has quit IRC | 18:23 | |
*** rods has quit IRC | 18:23 | |
*** krtaylor has quit IRC | 18:23 | |
*** renatoarmani has joined #openstack-nova | 18:23 | |
*** renatoarmani has quit IRC | 18:24 | |
*** brad[] has quit IRC | 18:25 | |
*** EinstCrazy has quit IRC | 18:25 | |
*** ctrath has quit IRC | 18:26 | |
*** crinkle has quit IRC | 18:27 | |
*** rods has joined #openstack-nova | 18:27 | |
*** mgagne has joined #openstack-nova | 18:28 | |
*** mgagne is now known as Guest63453 | 18:28 | |
*** doug-fish has quit IRC | 18:28 | |
*** ctrath has joined #openstack-nova | 18:28 | |
*** ssurana has joined #openstack-nova | 18:28 | |
Piet | Hi folks, we wanted to let you know about a results presentation for the Nova Networks to Neutron Migration Study this Tuesday, December 1st at 10AM MST / 12PM EST / 5:00PM UTC. A link to the virtual room for the presentation can be found at https://wiki.openstack.org/wiki/HorizonUsability_Testing#December_2015_Nova_Networks_to_Neutron_Migration_Study | 18:29 |
*** artom has joined #openstack-nova | 18:29 | |
*** crinkle has joined #openstack-nova | 18:29 | |
*** penick has quit IRC | 18:29 | |
*** aginwala has joined #openstack-nova | 18:31 | |
*** penick has joined #openstack-nova | 18:32 | |
*** pm90__ has joined #openstack-nova | 18:32 | |
*** aweeks has quit IRC | 18:33 | |
*** ndipanov has joined #openstack-nova | 18:33 | |
*** paul-carlton1 has quit IRC | 18:33 | |
*** claudiub has quit IRC | 18:34 | |
*** pm90_ has quit IRC | 18:35 | |
*** pm90___ has joined #openstack-nova | 18:35 | |
*** cfriesen has joined #openstack-nova | 18:36 | |
*** brad[] has joined #openstack-nova | 18:36 | |
*** hogepodge has joined #openstack-nova | 18:37 | |
*** jistr has joined #openstack-nova | 18:37 | |
*** pm90__ has quit IRC | 18:38 | |
*** Guest63453 has quit IRC | 18:38 | |
*** Guest63453 has joined #openstack-nova | 18:38 | |
*** Guest63453 is now known as mgagne | 18:39 | |
openstackgerrit | Surojit Pathak proposed openstack/nova: Fix wrong CPU metric value in metrics_filter https://review.openstack.org/243825 | 18:40 |
*** krtaylor has joined #openstack-nova | 18:41 | |
*** paul-carlton_ has quit IRC | 18:42 | |
*** gszasz has quit IRC | 18:43 | |
*** rook has quit IRC | 18:43 | |
*** swamireddy has joined #openstack-nova | 18:46 | |
*** hparekh has quit IRC | 18:47 | |
*** jichen has joined #openstack-nova | 18:47 | |
*** Marga_ has joined #openstack-nova | 18:48 | |
*** mikeit has quit IRC | 18:51 | |
*** sripriya has joined #openstack-nova | 18:51 | |
*** vilobhmm11 has joined #openstack-nova | 18:52 | |
*** achanda has joined #openstack-nova | 18:52 | |
*** suro-patz has joined #openstack-nova | 18:54 | |
*** hparekh has joined #openstack-nova | 18:55 | |
*** PaulMurray is now known as ptm_away | 18:55 | |
*** vilobhmm111 has joined #openstack-nova | 18:55 | |
*** penick has quit IRC | 18:56 | |
*** salv-orlando has joined #openstack-nova | 18:57 | |
*** markmcclain has joined #openstack-nova | 18:57 | |
*** vilobhmm11 has quit IRC | 18:58 | |
openstackgerrit | aginwala proposed openstack/nova: fix free_gb value when scheduler receives None from compute https://review.openstack.org/250767 | 18:59 |
*** anshprat has joined #openstack-nova | 19:01 | |
*** rotbeard has quit IRC | 19:02 | |
*** aginwala has quit IRC | 19:02 | |
*** otter768 has joined #openstack-nova | 19:03 | |
*** sileht has quit IRC | 19:05 | |
*** sulo has quit IRC | 19:06 | |
*** aginwala has joined #openstack-nova | 19:07 | |
*** sulo has joined #openstack-nova | 19:07 | |
*** FL1SK has quit IRC | 19:07 | |
*** penick has joined #openstack-nova | 19:08 | |
*** otter768 has quit IRC | 19:08 | |
*** jaosorior has joined #openstack-nova | 19:08 | |
*** changbl has quit IRC | 19:09 | |
*** rook has joined #openstack-nova | 19:09 | |
*** unicell1 has joined #openstack-nova | 19:12 | |
mriedem | has anyone seen this before? http://logs.openstack.org/94/242594/2/check/gate-tempest-dsvm-nova-v20-api/085f243/logs/screen-n-cpu.txt.gz?level=TRACE#_2015-11-30_18_03_48_003 | 19:14 |
mriedem | looks like a race while deleting an instance that's still building | 19:14 |
*** unicell has quit IRC | 19:14 | |
dansmith | mriedem: yep, acked that relnote | 19:14 |
*** tjones has joined #openstack-nova | 19:14 | |
*** jaosorior has quit IRC | 19:15 | |
*** salv-orlando has quit IRC | 19:19 | |
*** markmc has quit IRC | 19:19 | |
*** salv-orlando has joined #openstack-nova | 19:20 | |
*** markmc has joined #openstack-nova | 19:20 | |
*** thangp has joined #openstack-nova | 19:20 | |
*** Lyncos1 has left #openstack-nova | 19:21 | |
*** xek has quit IRC | 19:21 | |
*** zenoway has joined #openstack-nova | 19:23 | |
*** aginwala is now known as aginwala87 | 19:24 | |
*** aginwala87 is now known as aginwala | 19:24 | |
*** mkoderer has quit IRC | 19:26 | |
*** aginwala has quit IRC | 19:27 | |
*** mkoderer has joined #openstack-nova | 19:28 | |
*** zhenq has joined #openstack-nova | 19:34 | |
cfriesen | hypothetically speaking...supposing I wanted to add some additional debug logs to scheduler filters (so that we would see exactly why a scheduling operation failed), would that require a blueprint or spec? And would it make sense to make those messages available to end-users or would that be exposing too much data about the cloud internals? | 19:35 |
cfriesen | I'm assuming that if we did expose it to end-users that'd require a spec. | 19:36 |
*** sacharya has joined #openstack-nova | 19:36 | |
*** markmcclain has quit IRC | 19:41 | |
*** markmcclain has joined #openstack-nova | 19:41 | |
*** ssurana has quit IRC | 19:42 | |
*** lucasagomes is now known as lucas-dinner | 19:42 | |
*** ssurana has joined #openstack-nova | 19:42 | |
*** aginwala has joined #openstack-nova | 19:43 | |
*** penick has quit IRC | 19:48 | |
mriedem | exposing why you hit NoValidHost is going to require a spec because of security impacts | 19:50 |
*** penick has joined #openstack-nova | 19:50 | |
mriedem | adding debug logs does not require a blueprint or spec | 19:50 |
*** whenry_ has joined #openstack-nova | 19:51 | |
mriedem | cfriesen: ^ | 19:51 |
cfriesen | mriedem: cool. What do you think about the idea of exposing why someone hit NoValidHost? We're doing it internally, but our use-case is a bit different from the large-scale public cloud scenario. | 19:52 |
mriedem | cfriesen: i'd suggest talking to edleafe since he looked at that in kilo | 19:54 |
edleafe | cfriesen: you mean give them the filters that rejected all the hosts? | 19:55 |
cfriesen | edleafe: basically, yes. The intent is to avoid the end-user having to go to the cloud admin to figure out why they couldn't schedule an instance | 19:56 |
cfriesen | some of the more tricky ones are numa topology stuff, or pci passthrough | 19:56 |
edleafe | cfriesen: Ah, so like a summary of sorts? | 19:56 |
edleafe | cfriesen: IOW, "you asked for too much RAM" | 19:56 |
edleafe | cfriesen: without revealing details about the provider's physical hosts? | 19:57 |
ccarmack | mriedem: I saw that build - delete race today also http://logs.openstack.org/43/226043/11/check/gate-tempest-dsvm-postgres-full/a9e02da/logs/screen-n-cpu.txt.gz?level=ERROR | 19:57 |
cfriesen | edleafe: that'd be most likely to get in, I suspect. | 19:58 |
edleafe | cfriesen: but that's the point of keeping it accessible to admins only | 19:58 |
*** edtubill has joined #openstack-nova | 19:59 | |
cfriesen | edleafe: right, but if the admin is going to tell them "you asked for too much RAM", anyways, it seems like we might be able to just tell them that directly | 19:59 |
edleafe | cfriesen: well, it's complicated :) | 20:00 |
cfriesen | edleafe: or maybe we just want to keep a person in the loop? Either way, I think some of the more complicated filters could use better error logs | 20:00 |
cfriesen | numatopologyfilter in particular has many different things that can fail | 20:00 |
edleafe | cfriesen: like they might have hosts with enough RAM, but those were rejected for some other reason | 20:00 |
*** penick has quit IRC | 20:03 | |
cfriesen | edleafe: fair enough. It's probably not worth trying to get people to agree to a spec. :) But I'm planning on trying to improve the error messages to make the admin's job easier at least, and it sounds like I can do that without a blueprint. (Which simplifies things.) | 20:03 |
*** busterswt has joined #openstack-nova | 20:03 | |
edleafe | cfriesen: agreed. But remember that better almost always means 'more info', which means bigger logs, which some admins will fight, which means... | 20:05 |
*** sacharya has quit IRC | 20:05 | |
*** penick has joined #openstack-nova | 20:08 | |
*** mpryc has joined #openstack-nova | 20:08 | |
cfriesen | edleafe: at a minimum, I think we could make it only log on a scheduler failure | 20:08 |
cfriesen | try to cut down on the logs as much as possible. maybe even have a config option of people really don't like it | 20:09 |
edleafe | cfriesen: right now the filtering info is only logged when no host is found | 20:11 |
edleafe | cfriesen: I don't think that yeat another config option is going to go over well :) | 20:11 |
*** doug-fish has joined #openstack-nova | 20:14 | |
*** Marga_ has quit IRC | 20:19 | |
cfriesen | edleafe: yeah, was going to start without it and see if someone asks for it. :) | 20:19 |
*** tongli has joined #openstack-nova | 20:21 | |
*** eharney has quit IRC | 20:22 | |
*** rfolco has quit IRC | 20:24 | |
sdague | cfriesen: honestly, if you first solve the problem of a plain english answer as a LOG.warn() for ops to easily see, that would be the first step | 20:24 |
sdague | then a separate conversation about optionally exposing that all the way back to users | 20:25 |
sdague | and all the ops would love you if you got that LOG.warn in there | 20:25 |
mriedem | this bdm not found thing is everywhere http://logs.openstack.org/13/194413/7/check/gate-tempest-dsvm-neutron-full/9f99f8e/logs/screen-n-cpu.txt.gz?level=TRACE#_2015-11-30_15_51_27_618 | 20:26 |
mriedem | we must have merged a race | 20:27 |
*** jistr has quit IRC | 20:27 | |
mriedem | w/o logstash we don't know when it was introduced really, but maybe not hard to find | 20:27 |
*** omnipresent has joined #openstack-nova | 20:29 | |
*** ssurana has quit IRC | 20:29 | |
mriedem | sdague: see when this was merged? https://review.openstack.org/#/c/241179/ | 20:29 |
mriedem | https://review.openstack.org/#/c/241179/9/nova/context.py | 20:29 |
mriedem | different timestamp formats screwing up logstash and blowing things to hell? | 20:30 |
mriedem | jeblair: ^ | 20:30 |
*** ssurana has joined #openstack-nova | 20:30 | |
*** achanda has quit IRC | 20:31 | |
*** wznoinsk has joined #openstack-nova | 20:31 | |
*** pm90___ has quit IRC | 20:31 | |
*** pm90_ has joined #openstack-nova | 20:31 | |
*** zenoway has quit IRC | 20:32 | |
*** pm90__ has joined #openstack-nova | 20:32 | |
*** apoorvad has quit IRC | 20:32 | |
*** pm90___ has joined #openstack-nova | 20:33 | |
*** pm90__ has quit IRC | 20:33 | |
*** RichardRaseley has joined #openstack-nova | 20:34 | |
*** pm90__ has joined #openstack-nova | 20:35 | |
*** salv-orlando has quit IRC | 20:35 | |
*** salv-orlando has joined #openstack-nova | 20:35 | |
*** pm90_ has quit IRC | 20:37 | |
*** eharney has joined #openstack-nova | 20:37 | |
*** pm90___ has quit IRC | 20:38 | |
*** aginwala has quit IRC | 20:39 | |
wznoinsk | hi all | 20:40 |
wznoinsk | johnthetubaguy: are you around? | 20:40 |
*** aginwala has joined #openstack-nova | 20:42 | |
*** EinstCrazy has joined #openstack-nova | 20:42 | |
*** matrohon has joined #openstack-nova | 20:44 | |
bauzas | :r | 20:44 |
bauzas | mriedem: lemme try to pair your bluetooth brain for understanding why you -1'd https://review.openstack.org/#/c/251408/3 :D | 20:45 |
mriedem | bauzas: heh, it'd help if i posted the comments in ps2 | 20:45 |
mriedem | you had rev'ed ps3 while i was reviewing | 20:46 |
mriedem | so i lost the comment | 20:46 |
*** EinstCrazy has quit IRC | 20:47 | |
bauzas | ah ah | 20:47 |
*** rook has quit IRC | 20:48 | |
*** Marga_ has joined #openstack-nova | 20:50 | |
*** pm90__ has quit IRC | 20:51 | |
*** doug-fish has quit IRC | 20:51 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for HyperV 2008 drop of support https://review.openstack.org/251408 | 20:53 |
*** belmoreira has joined #openstack-nova | 20:53 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for force_config_drive opt change https://review.openstack.org/250852 | 20:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for removing conductor RPC API v2 https://review.openstack.org/250865 | 20:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for automatic determination of compute_rpc version by service https://review.openstack.org/251432 | 20:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for dropping InstanceV1 objects https://review.openstack.org/250859 | 20:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add note for Virtuozzo supporting snapshots https://review.openstack.org/251420 | 20:53 |
*** raildo is now known as raildo-afk | 20:53 | |
*** dims_ has joined #openstack-nova | 20:53 | |
*** pm90_ has joined #openstack-nova | 20:53 | |
*** doug-fish has joined #openstack-nova | 20:54 | |
*** pm90__ has joined #openstack-nova | 20:54 | |
*** doug-fis_ has joined #openstack-nova | 20:55 | |
*** dims has quit IRC | 20:56 | |
*** mfisch` has quit IRC | 20:56 | |
*** mfisch has joined #openstack-nova | 20:57 | |
*** busterswt has quit IRC | 20:57 | |
*** mfisch is now known as Guest7150 | 20:57 | |
*** doug-fi__ has joined #openstack-nova | 20:57 | |
*** pm90_ has quit IRC | 20:58 | |
*** doug-fish has quit IRC | 20:58 | |
*** sfinucan has joined #openstack-nova | 20:59 | |
*** doug-fis_ has quit IRC | 21:00 | |
*** tongli has quit IRC | 21:00 | |
bauzas | sdague: I know this one has been +W'd but I'd love to get your insights https://review.openstack.org/#/c/247552/ | 21:00 |
bauzas | sdague: in case something looks bad, we can just try to modify that in a later change | 21:01 |
*** Guest7150 has quit IRC | 21:01 | |
*** doug-fi__ has quit IRC | 21:02 | |
*** aginwala has quit IRC | 21:02 | |
*** dims_ has quit IRC | 21:03 | |
openstackgerrit | melanie witt proposed openstack/nova: Add methods for RequestContext to switch db connection https://review.openstack.org/161906 | 21:03 |
*** otter768 has joined #openstack-nova | 21:04 | |
*** Piet has quit IRC | 21:04 | |
*** changbl has joined #openstack-nova | 21:04 | |
*** doug-fish has joined #openstack-nova | 21:04 | |
*** Marga_ has quit IRC | 21:05 | |
bauzas | melwitt: dansmith: alaski: you could be interested in https://review.openstack.org/#/c/211753/ | 21:05 |
*** Marga_ has joined #openstack-nova | 21:06 | |
sdague | mriedem: where are you seeing that impacting log timestamps? | 21:06 |
sdague | bauzas: ok, I'd not yet seen that patch | 21:07 |
mriedem | sdague: it changed the timestamp in the request context, but looking closer it looks like it correctly copied the isotime and strtime methods from oslo.utils' timeutils module | 21:07 |
mriedem | *changed the method called to set the timestamp in the request context | 21:07 |
mriedem | and merged on 11/24 which is when logstash went haywire | 21:08 |
sdague | yeh, so honestly, I think the timestamp parsing thing is a bit of a red herring as well | 21:08 |
sdague | we had unparsable stuff before | 21:08 |
sdague | and it was fine | 21:08 |
*** otter768 has quit IRC | 21:08 | |
*** doug-fish has quit IRC | 21:09 | |
sdague | bauzas: so, the thing I don't like about that patch is that it logs once, and goes silent forever | 21:09 |
bauzas | sdague: if for each check, it goes an exception, right? | 21:10 |
*** Marga_ has quit IRC | 21:10 | |
sdague | yeh | 21:10 |
sdague | honestly, I kind of feel like it would be better to store the timestamp of the disconnected time | 21:10 |
mriedem | sdague: heh, i think this is the cause for the bdm not found race https://review.openstack.org/#/c/194063/ | 21:10 |
sdague | and if we're past some threshold, warn again | 21:10 |
mriedem | again, which was a rehash of a previous revert | 21:10 |
bauzas | tbh, I was rather thinking of passing the exception up, so the service would be killed | 21:11 |
bauzas | sdague: ^ | 21:11 |
sdague | bauzas: wait, killing the service under what circumstance? | 21:11 |
bauzas | because if something goes unexpected, the operator has to understand why | 21:11 |
sdague | bauzas: how would you do a rolling upgrade? | 21:11 |
bauzas | sdague: not thinking of the MessagingTimeout exception, just the catch-all exception | 21:12 |
mriedem | yup http://logstash.openstack.org/#dashboard/file/logstash.json?query=message:%5C%22BDMNotFound:%20No%20Block%20Device%20Mapping%20with%20id%5C%22%20AND%20message:%5C%22_default_block_device_names%5C%22%20AND%20tags:%5C%22screen-n-cpu.txt%5C%22 | 21:12 |
bauzas | we're only expecting something getting wrong with the communication to the controller | 21:12 |
mriedem | started spiking on 11/27 | 21:12 |
bauzas | sdague: the other exceptions are related to a situation where the compute is running, ie. when not upgradingi t | 21:13 |
*** aginwala has joined #openstack-nova | 21:13 | |
sdague | crashing the compute seems bad | 21:13 |
sdague | yeh, I'm ok with the catchall there honestly | 21:13 |
*** rook has joined #openstack-nova | 21:14 | |
sdague | I'd just like to not go entirely silent on messaging timeouts | 21:14 |
bauzas | okay, then that's me who overthought that | 21:14 |
*** dims has joined #openstack-nova | 21:14 | |
sdague | yeh, we should always try to keep the compute up, because if it crashes then we lose the ability to know it's state in the rest of openstack | 21:15 |
sdague | the only time we should have the compute exit is if it's going to corrupt data horribly | 21:16 |
*** READ10 has joined #openstack-nova | 21:16 | |
bauzas | good point | 21:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Revert "Detach volume after deleting instance with no host" https://review.openstack.org/251543 | 21:18 |
*** rdo has quit IRC | 21:18 | |
dansmith | and crashing the compute because of something you can send it over the network is, like, about the worst thing ever | 21:19 |
*** raildo-afk is now known as raildo | 21:19 | |
*** FL1SK has joined #openstack-nova | 21:19 | |
*** aginwala has quit IRC | 21:19 | |
*** Marga_ has joined #openstack-nova | 21:19 | |
bauzas | okay, it seems I provided a brilliant idea... :) | 21:20 |
* bauzas jk | 21:20 | |
bauzas | I just usually don't like hiding stuff below the carpet | 21:21 |
bauzas | that said, I totally get the point where a compute has to be resilient | 21:21 |
mriedem | stevemar: i'm not sure what i'm looking at in https://review.openstack.org/#/c/251538/1/openstackclient/compute/v2/server.py | 21:21 |
mriedem | there is no shared flag for the live migration api | 21:21 |
stevemar | bah, no dtroyer | 21:22 |
stevemar | mriedem: so how does someone perform a shared-migration? | 21:22 |
mriedem | stevemar: they have shared storage setup with the compute | 21:22 |
mriedem | it's automagic | 21:22 |
stevemar | mriedem: is that something new? | 21:23 |
mriedem | no | 21:23 |
stevemar | mriedem: i think there is a misunderstanding about how this command should look like :( | 21:24 |
mriedem | can you just add an --easy-button option? | 21:24 |
stevemar | mriedem: it sounds like there should only be one option, --migrate | 21:24 |
stevemar | mriedem: file a bug and i'll mark it as wishlist | 21:24 |
*** vladikr has quit IRC | 21:25 | |
mriedem | so we have a big bag of dicts here in the libvirt driver https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6224 | 21:25 |
mriedem | dansmith has a series up to objectify that mess | 21:25 |
*** rdo has joined #openstack-nova | 21:26 | |
dansmith | and what a mess it is | 21:26 |
dansmith | holy crap. | 21:26 |
mriedem | stevemar: from the api docs: | 21:26 |
mriedem | "block_migrationplainxsd:booleanSet to True to migrate local disks by using block migration. If the source or destination host uses shared storage and you set this value to True, the live migration fails." | 21:26 |
mriedem | screw you user if you don't know if the backing storage is shared or not | 21:26 |
*** mpryc has quit IRC | 21:26 | |
mriedem | great UX ^ | 21:27 |
mriedem | stevemar: you're probably best served at looking at the tempest tests for live migration | 21:27 |
mriedem | https://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_live_migration.py | 21:28 |
notmorgan | sdague: so... with the conversion to use the catalog... do we need to support the old options at all (old_opts set > new way?) or can we just cut it over | 21:32 |
notmorgan | sdague: i ask becasue it's much easier to do the "ignore the old options" method | 21:32 |
sdague | notmorgan: we need to deprecate the old options | 21:32 |
notmorgan | hm. ok trying to figure out how to make this fall through. | 21:32 |
notmorgan | then. | 21:32 |
*** doug-fish has joined #openstack-nova | 21:32 | |
sdague | if the old options are set, they win, but we throw a deprecation warning | 21:33 |
notmorgan | yah | 21:33 |
notmorgan | hm | 21:33 |
sdague | if they aren't we use this new thing | 21:33 |
notmorgan | like i said, trying to make this fall through... this is really awfully tacked together from waaaaaay outside the code | 21:33 |
notmorgan | it's going to be a pretty sizable change to convert over because it's passing the host and what not down like 5+ layers | 21:34 |
*** zenoway has joined #openstack-nova | 21:34 | |
*** doug-fis_ has joined #openstack-nova | 21:35 | |
*** doug-fis_ has quit IRC | 21:35 | |
*** doug-fis_ has joined #openstack-nova | 21:35 | |
sdague | yeh, though it looks like honestly a bunch of this code collapses in the process | 21:35 |
sdague | because eventually we assemble all to this - https://github.com/openstack/nova/blob/1734ce7101982dd95f8fab1ab4815bd258a33744/nova/image/glance.py#L154 | 21:36 |
*** doug-fish has quit IRC | 21:37 | |
notmorgan | sdague: it sortof does. | 21:37 |
notmorgan | sdague: part of the issue is that it also allows for direct parsing of the image location | 21:37 |
wznoinsk | johnthetubaguy: whenever you have a free moment, could you have a look at https://blueprints.launchpad.net/nova/+spec/nova-hot-add-vcpus-support, feedback much appreciated (I'm trying to make before m1) | 21:37 |
*** aginwala has joined #openstack-nova | 21:37 | |
notmorgan | so you can say "image is <<<here>>>" or so it looks | 21:38 |
mriedem | dansmith: is there even a good reason we have the block migration option with live migrate? seems that the compute and virt drivers already figure that all out anyway and validate based on it https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5205 | 21:38 |
sdague | notmorgan: where do you see that? | 21:38 |
notmorgan | which isn't really a "use glance from catalog" | 21:38 |
*** omnipresent has quit IRC | 21:38 | |
notmorgan | sec, looking for it again | 21:38 |
notmorgan | was a few sections back from where i am staring now | 21:38 |
sdague | so, there is a lot of gorp in here for sure | 21:38 |
dansmith | mriedem: well, I think it's one of those things that an operator may want to avoid.. like "do this migration if you can without block migration" | 21:39 |
mriedem | i guess i forgot that it's an admin-only api by default | 21:40 |
mriedem | and the admin should know if it's using shared storage or not | 21:40 |
*** READ10 has quit IRC | 21:40 | |
notmorgan | sdague: https://github.com/openstack/nova/blob/1734ce7101982dd95f8fab1ab4815bd258a33744/nova/image/glance.py#L659 | 21:40 |
notmorgan | sdague: or am i mis-reading this? | 21:40 |
*** Piet has joined #openstack-nova | 21:41 | |
notmorgan | this is def. hard to follow (and i'm ignoreing the XEN plugin atm) | 21:41 |
mriedem | BobBall: is the xenserver ci in the toilet? | 21:41 |
sdague | give me a few, this is a function I don't think I've been in before | 21:41 |
mriedem | seems to be failing all day | 21:41 |
notmorgan | sdague: np. thnx for looking | 21:41 |
*** dims_ has joined #openstack-nova | 21:42 | |
*** baoli has joined #openstack-nova | 21:43 | |
*** smurke has quit IRC | 21:43 | |
*** baoli has quit IRC | 21:43 | |
*** dims has quit IRC | 21:43 | |
cfriesen | mriedem: there's a spec open for making nova live migration automatically figure out whether it's shared or not | 21:43 |
*** smurke has joined #openstack-nova | 21:44 | |
dansmith | cfriesen: this is not shared or not | 21:44 |
sdague | notmorgan: the only place this seems to be used is in a xen conversion function | 21:44 |
dansmith | AIUI, block migration can generate a crapton of network traffic | 21:44 |
dansmith | which is the case where storage is *not* shared, and thus may want to be avoided | 21:44 |
notmorgan | sdague: ok | 21:45 |
sdague | notmorgan: yeh, and the whole href path I think is never used | 21:45 |
sdague | https://github.com/openstack/nova/blob/1734ce7101982dd95f8fab1ab4815bd258a33744/nova/virt/xenapi/image/vdi_through_dev.py#L64 | 21:45 |
sdague | so I think you are always returning from here - https://github.com/openstack/nova/blob/1734ce7101982dd95f8fab1ab4815bd258a33744/nova/image/glance.py#L675 | 21:46 |
notmorgan | sdague: i see a ref in hyperv snapshotops | 21:46 |
notmorgan | that does pass in the image_id... so might be safe. looking | 21:46 |
cfriesen | dansmith: right, it's separate from the shared instance storage. but nova can figure out both cases. this is what I was thinking of: https://review.openstack.org/#/c/245543 | 21:46 |
notmorgan | yeah i think it is *just* the ID in that case too | 21:47 |
cfriesen | mriedem: ^ feel free to review. :) Personally I think we should just remove the block_migration flag entirely rather than making it optional, but Alex wants to be able to use it as a hint to the scheduler eventually. | 21:47 |
sdague | notmorgan: so, this does show up a few other places, enough so that I'm not fully confident that no one uses the href version without more looking | 21:48 |
sdague | however, it seems unlikely | 21:48 |
notmorgan | sdague: yeah. | 21:48 |
notmorgan | sdague: if i could collapse all of that magic down just down into the glanceclientwrapper i'd be happy. | 21:48 |
*** mfisch has joined #openstack-nova | 21:48 | |
notmorgan | because then it's easy to detect "old opts, new opts" | 21:48 |
*** mfisch has quit IRC | 21:48 | |
*** mfisch has joined #openstack-nova | 21:48 | |
dansmith | cfriesen: right, but I'm not sure ops always want it to figure it out | 21:48 |
sdague | notmorgan: yeh, I think that's definitely doable | 21:48 |
dansmith | cfriesen: because if you have two nodes that might be on the same NFS, you want to live migrate if you can, else not go and do block migration or something | 21:49 |
*** aginwala has quit IRC | 21:49 | |
dansmith | cfriesen: the shared/not-shared flag seemed superfluous, but the block migration one is not the same, IIRC | 21:49 |
notmorgan | i can *probably* just pass down image_id and then do the same splitout if needed. | 21:49 |
notmorgan | sdague: have i mentioned i don't like rabbitholes like this :P | 21:50 |
notmorgan | at least this one isn't insane | 21:50 |
cfriesen | dansmith: then it should probably be renamed. as it stands, it's misleading since it appears to be asking for information that nova already knows (ie do we need to do a block migration or not) | 21:50 |
sdague | right, well this is one of the reasons I -1ed fast, because it would just paper over some of this, and I think it's actually fixable not with a huge amount of effort | 21:50 |
cfriesen | dansmith: and if you want to limit the live migration to nodes that share storage, isn't that something that host aggregates could be used for? | 21:51 |
dansmith | cfriesen: I interpret is "I am willing (or not) to do a block migration" and thus I think it's fine | 21:51 |
notmorgan | sdague: maybe. | 21:51 |
notmorgan | sdague: for what it's worth this has taken ~3x the time to dig through as the previous stuff. :P | 21:51 |
notmorgan | at least. | 21:51 |
dansmith | cfriesen: regardless, I'm not the expert here, so you should talk to some of the live migration people about it | 21:51 |
cburgess | cfriesen dansmith I just left feedback. I like the overall idea but I think the existing block migrate flag should be kept as is and a new auto-magic flag added. | 21:51 |
*** rook has quit IRC | 21:51 | |
notmorgan | but i admit i'm not a nova expert | 21:51 |
sdague | notmorgan: sure, but the end result is going to pay it forward in debt reduction | 21:51 |
cfriesen | dansmith: so would you support Alex's suggestion of making it optional (which would mean "do whatever is needed to migrate this instance")? | 21:52 |
*** rook has joined #openstack-nova | 21:52 | |
notmorgan | sdague: maybe depends on how frustrated i get :P [so far not too bad] | 21:52 |
*** baoli has joined #openstack-nova | 21:52 | |
dansmith | cfriesen: I haven't read the spec and I'd need to see how that affects the API | 21:52 |
cfriesen | cburgess: you don't think the microversion bump is sufficient? | 21:53 |
dansmith | cfriesen: microversion bump to change a default-if-not-specified thing is kinda sucky | 21:54 |
cburgess | The short answer is no. The reason I say that is because as you stated you can't figure out if something is a block migrate before hand via the nova API. I suspect some sites use the combination of the command and flag to accomplish this. | 21:54 |
cburgess | As in... "I want to live migrate this but *only* if its *not* block. | 21:54 |
*** jichen has quit IRC | 21:55 | |
cburgess | Thats what some people want to do today. | 21:55 |
*** matrohon has quit IRC | 21:55 | |
dansmith | cburgess: right, exactly | 21:55 |
cburgess | I like having a "figure it out and make it work" flag. I absolutely want that. | 21:55 |
cburgess | But I think you need to have the ability to do the former. | 21:55 |
cfriesen | cburgess: okay, I can see it. | 21:55 |
cburgess | If you want to change the flags around and add more and make it possible to still do that great. But your current spec doesn't seem to support that type of use case. | 21:55 |
*** penick has quit IRC | 21:56 | |
*** andrewbogott has quit IRC | 21:56 | |
*** andrewbogott has joined #openstack-nova | 21:56 | |
cburgess | So to be clear.. its not that I think the flag needs to not change. As long as you do a microversion change away, but you need to support the other use case. I'll update my comment on the spec to more properly reflect that. | 21:56 |
*** mwagner_lap has quit IRC | 21:57 | |
notmorgan | sdague: oooh i think i can do this in one spot already. it'll mean later patches to do cleanup | 21:57 |
*** rook has quit IRC | 21:57 | |
notmorgan | sdague: i think i found the magic place to do the heavy lifting to start. | 21:57 |
sdague | notmorgan: ok, cool | 21:58 |
notmorgan | sdague: if i just do the work in get_api_servers() that preserves the same functionality everywhere else. | 21:58 |
sdague | I need to start the dinner routine, but I'm happy to help review to get this into landable state laster this week | 21:58 |
sdague | notmorgan: yep | 21:58 |
sdague | that sounds reasonable | 21:58 |
notmorgan | sdague: then we can do surgical cleanup on the rest after | 21:58 |
sdague | sure | 21:58 |
notmorgan | sdague: cool will ping you (maybe tomorrow) on this change then | 21:58 |
sdague | sounds good | 21:58 |
*** penick has joined #openstack-nova | 21:59 | |
*** aginwala has joined #openstack-nova | 21:59 | |
*** pm90__ has quit IRC | 21:59 | |
*** mriedem is now known as mriedem_away | 22:00 | |
*** Guest87643 has joined #openstack-nova | 22:03 | |
cfriesen | does anyone know why we convert from COW to a pure image when doing a cold migration with qcow2 backend? This is unintuitive, since if the backing store file is already present on the destination we should be able to copy only the delta file. | 22:05 |
*** Marga__ has joined #openstack-nova | 22:05 | |
*** thorst_ has quit IRC | 22:05 | |
*** Marga_ has quit IRC | 22:06 | |
*** thorst_ has joined #openstack-nova | 22:06 | |
*** markvoelker has joined #openstack-nova | 22:07 | |
*** Marga__ has quit IRC | 22:09 | |
*** thorst_ has quit IRC | 22:10 | |
*** pm90_ has joined #openstack-nova | 22:14 | |
*** rlrossit has left #openstack-nova | 22:17 | |
*** vilobhmm111 has quit IRC | 22:18 | |
*** mpryc has joined #openstack-nova | 22:18 | |
*** vilobhmm11 has joined #openstack-nova | 22:19 | |
*** eharney has quit IRC | 22:20 | |
*** thangp has quit IRC | 22:22 | |
*** ZZelle has joined #openstack-nova | 22:23 | |
*** omnipresent has joined #openstack-nova | 22:28 | |
*** zenoway has quit IRC | 22:32 | |
*** lykinsbd has quit IRC | 22:35 | |
*** ccarmack has left #openstack-nova | 22:42 | |
*** doug-fis_ has quit IRC | 22:44 | |
*** mpryc has left #openstack-nova | 22:44 | |
*** doug-fish has joined #openstack-nova | 22:44 | |
belmoreira | Hi, I need your help to recover from an issue related with flavor migration in Kilo | 22:47 |
belmoreira | We use cells and the flavor migration is not updating instance_extra in the api cell DB when the stop api is called from the compute node | 22:47 |
belmoreira | This happens when a user shutdown an instance for example... | 22:47 |
belmoreira | In cell DB everything seems updated correctly | 22:47 |
belmoreira | Then the user can't list VMs anymore | 22:48 |
*** loquacities has left #openstack-nova | 22:48 | |
dansmith | belmoreira: running all kilo code at the top and bottom? | 22:48 |
*** doug-fish has quit IRC | 22:49 | |
belmoreira | @dansmith I still have some nodes in Juno. But all are "juno compat" | 22:49 |
*** tjones has quit IRC | 22:49 | |
*** doug-fish has joined #openstack-nova | 22:49 | |
dansmith | belmoreira: which kind of nodes? | 22:50 |
dansmith | belmoreira: either way, running a kilo api cell and a juno child cell is probably not going to work | 22:50 |
melwitt | belmoreira: are the failures to update with only juno computes or any compute? | 22:50 |
belmoreira | @dansmith: only compute nodes | 22:50 |
*** doug-fis_ has joined #openstack-nova | 22:50 | |
belmoreira | dansmith: If I run "nova stop <uuid>" everything is updated correctly. The problem that I see is when an instance is shutdown and is the compute node that detects it and calls stop api | 22:52 |
dansmith | belmoreira: well, given the lack of any care we give to live upgrade scenarios on cells, I'm not at all surprised that being in that arrangement results in pain | 22:52 |
dansmith | belmoreira: yeah, which is wonky in cells, I think | 22:52 |
*** penick has quit IRC | 22:52 | |
*** kylek3h has quit IRC | 22:53 | |
belmoreira | in the case that I described the cell DB is updated correctly but not the api cell DB. Misses the instance_extra | 22:53 |
dansmith | right | 22:54 |
*** doug-fish has quit IRC | 22:54 | |
*** pm90_ has quit IRC | 22:54 | |
belmoreira | I'm starting to have a lot of projects in this state... not sure how can recover | 22:54 |
*** doug-fis_ has quit IRC | 22:55 | |
belmoreira | melwitt: all compute nodes (juno or kilo) | 22:55 |
* dansmith got a phone call | 22:55 | |
*** Marga_ has joined #openstack-nova | 22:56 | |
*** Marga_ has quit IRC | 22:57 | |
*** Marga_ has joined #openstack-nova | 22:57 | |
*** mwagner_lap has joined #openstack-nova | 22:57 | |
*** yamahata has joined #openstack-nova | 22:58 | |
melwitt | belmoreira: it's a known problem that a mix of kilo and juno cells won't work. if kilo -> kilo instance update isn't propagating to the api, that would be a new problem | 22:58 |
belmoreira | melwitt: is kilo->kilo but still using juno compat | 22:59 |
*** tjones has joined #openstack-nova | 23:00 | |
melwitt | belmoreira: what do you mean by "using juno compat"? | 23:00 |
dansmith | melwitt: rpc api | 23:01 |
dansmith | but still, | 23:01 |
dansmith | none of that stuff is done properly in cells | 23:01 |
dansmith | which is why the mix of versions doesn't work | 23:01 |
*** Marga_ has quit IRC | 23:01 | |
*** omnipresent has quit IRC | 23:02 | |
belmoreira | melwitt: upgrade_levels: compute=juno | 23:02 |
*** dims has joined #openstack-nova | 23:02 | |
dansmith | belmoreira: that's only in-cell communication | 23:02 |
*** doug-fish has joined #openstack-nova | 23:03 | |
*** dims_ has quit IRC | 23:03 | |
melwitt | okay. yeah. I expect the kilo computes to succeed in updating api, but the juno computes won't | 23:03 |
dansmith | yeah | 23:03 |
dansmith | and I'm sure there are some compat gotchas in the flavor stuff when getting an older update over the cells link | 23:03 |
vilobhmm11 | melwitt, dansmith : if you can have a look at https://review.openstack.org/#/c/222423/ it would be helpful. | 23:03 |
vilobhmm11 | servicegroup spec | 23:03 |
*** changbl has quit IRC | 23:04 | |
*** Marga_ has joined #openstack-nova | 23:04 | |
*** otter768 has joined #openstack-nova | 23:05 | |
belmoreira | I'm not running upgrade_levels in the api cell... should I? I'm only running upgrade levels in child cell controllers and compute nodes | 23:05 |
*** mdrabe has quit IRC | 23:05 | |
*** changbl has joined #openstack-nova | 23:05 | |
dansmith | belmoreira: it won't matter :) | 23:05 |
belmoreira | yeah, is what I thought | 23:06 |
*** aginwala_ has joined #openstack-nova | 23:06 | |
melwitt | belmoreira: this explains more if you haven't seen it yet https://bugs.launchpad.net/nova/+bug/1479181 | 23:06 |
openstack | Launchpad bug 1479181 in OpenStack Compute (nova) "Cells: Build instance doesn't work with kilo api, juno compute " [Low,Invalid] | 23:06 |
*** doug-fish has quit IRC | 23:07 | |
*** ctrath has quit IRC | 23:07 | |
*** edtubill has quit IRC | 23:09 | |
*** otter768 has quit IRC | 23:09 | |
*** aginwala has quit IRC | 23:10 | |
belmoreira | melwitt: thanks | 23:11 |
belmoreira | dansmith, melwitt: do you know how people recovered from https://review.openstack.org/#/c/186505/ | 23:12 |
belmoreira | because the consequence is more or less the same | 23:13 |
*** smurke_ has joined #openstack-nova | 23:13 | |
*** smurke has quit IRC | 23:13 | |
dansmith | belmoreira: ran flavor migrations again I expect | 23:13 |
belmoreira | I was waiting to have everything in kilo and remove the upgrade_levels before doing it... | 23:14 |
*** breitz has quit IRC | 23:15 | |
*** breitz has joined #openstack-nova | 23:15 | |
dansmith | well, it's already happening in the background any time one of your kilo nodes saves an instance | 23:16 |
*** zenoway has joined #openstack-nova | 23:16 | |
*** burt has quit IRC | 23:17 | |
belmoreira | dansmith: fair enough | 23:18 |
*** smurke_ has quit IRC | 23:19 | |
*** zenoway has quit IRC | 23:20 | |
*** ijuwang has quit IRC | 23:21 | |
*** suro-patz1 has joined #openstack-nova | 23:23 | |
*** suro-patz has quit IRC | 23:24 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Docs: update the concept guide for Host topics https://review.openstack.org/249943 | 23:25 |
belmoreira | dansmith, melwitt: thank you | 23:27 |
*** ZZelle has quit IRC | 23:33 | |
*** pm90_ has joined #openstack-nova | 23:34 | |
*** suro-patz1 has quit IRC | 23:36 | |
*** barra204 has quit IRC | 23:38 | |
*** shakamunyi has joined #openstack-nova | 23:38 | |
*** jerrygb has quit IRC | 23:39 | |
*** jerrygb has joined #openstack-nova | 23:39 | |
*** xyang1 has quit IRC | 23:41 | |
*** suro-patz has joined #openstack-nova | 23:43 | |
*** signed8bit is now known as signed8bit_ZZZzz | 23:48 | |
*** hemna is now known as hemnafk | 23:48 | |
*** penick has joined #openstack-nova | 23:54 | |
*** zenoway has joined #openstack-nova | 23:54 | |
*** RichardRaseley has quit IRC | 23:54 | |
*** RichardRaseley has joined #openstack-nova | 23:56 | |
*** zenoway has quit IRC | 23:58 | |
*** suro-patz has quit IRC | 23:59 | |
*** suro-patz has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!