Wednesday, 2016-01-06

*** haomaiwang has quit IRC00:01
*** haomaiwang has joined #openstack-nova00:01
melwittdims: is there any other context about that, like a bug or logstash query? I'm not familiar with the py3 test flakiness00:02
*** Jeffrey4l has joined #openstack-nova00:04
*** sacharya has joined #openstack-nova00:05
*** _diana_1 has joined #openstack-nova00:06
*** gyee has quit IRC00:07
*** unicell1 has joined #openstack-nova00:07
openstackgerritIldiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments  https://review.openstack.org/19313500:08
openstackgerritIldiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments  https://review.openstack.org/19313400:08
openstackgerritIldiko Vancsa proposed openstack/nova: db and obj: Allow multiple volume attachments  https://review.openstack.org/19313300:08
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach  https://review.openstack.org/15303800:08
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: virt: Pass host when call attach to Cinder  https://review.openstack.org/25627300:08
*** ducttape_ has quit IRC00:09
*** annegentle has quit IRC00:09
*** penick has joined #openstack-nova00:09
*** unicell has quit IRC00:09
*** smatzek has quit IRC00:09
dimsmelwitt : if you check the gate-nova-python34 uncategorized rechecks page - you will see these tests - http://status.openstack.org//elastic-recheck/data/uncategorized.html00:09
openstackgerritIldiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments  https://review.openstack.org/19313500:10
openstackgerritIldiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments  https://review.openstack.org/19313400:10
openstackgerritIldiko Vancsa proposed openstack/nova: db and obj: Allow multiple volume attachments  https://review.openstack.org/19313300:10
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach  https://review.openstack.org/15303800:10
*** sacharya has quit IRC00:10
dimsmelwitt : example http://logs.openstack.org/78/258878/3/gate/gate-nova-python34/2c43415/testr_results.html.gz00:11
melwittdims: ah, thanks00:11
dimsmelwitt : i actually encountered some of those when i was fixing the py34 tests in https://review.openstack.org/#/c/262083/ and https://review.openstack.org/#/c/261045/00:12
*** mdrabe has joined #openstack-nova00:12
openstackgerritIldiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments  https://review.openstack.org/19313500:13
openstackgerritIldiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments  https://review.openstack.org/19313400:13
openstackgerritIldiko Vancsa proposed openstack/nova: db and obj: Allow multiple volume attachments  https://review.openstack.org/19313300:13
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach  https://review.openstack.org/15303800:13
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: virt: Pass host when call attach to Cinder  https://review.openstack.org/25627300:13
*** gyee has joined #openstack-nova00:14
*** _diana_1 has quit IRC00:15
melwittdims: looks like all of the others are AbstractDriverTestCase00:15
dimsmelwitt : ah. let me add that one as well00:16
*** ljxiash has joined #openstack-nova00:16
*** pratikmallya has joined #openstack-nova00:18
melwittdims: cool, I'll +2 after the update00:18
*** _diana_1 has joined #openstack-nova00:19
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Blacklist flaky tests and add warning  https://review.openstack.org/26378900:19
dimsthanks melwitt! done00:20
*** ljxiash has quit IRC00:21
*** Sukhdev has joined #openstack-nova00:22
*** egarbade-- has quit IRC00:24
*** gyee has quit IRC00:24
*** harlowja_ has joined #openstack-nova00:27
*** _diana_1 has quit IRC00:28
*** harlowja has quit IRC00:30
*** lihg has quit IRC00:31
*** lihg_ has quit IRC00:31
*** penick has quit IRC00:32
*** penick has joined #openstack-nova00:35
dimsoomichi : i did some ec2-api/objectstore cleanup (chop 10k lines off nova) - https://review.openstack.org/#/c/263368/ if you get a chance00:41
oomichidims: hi, happy new year. ok, now checking :)00:42
*** Jeffrey4l has quit IRC00:43
*** otter768 has joined #openstack-nova00:43
dimsthanks oomichi00:44
dimswish you a very happy new year as well oomichi00:44
oomichidims: one question. do we need to remove ec2 impl/tests with ObjectStore together?00:44
oomichidims: the patch becomes huge, and it is nice to separate them if possible00:45
dimsoomichi : y they are tied together. will generate more work to split them apart00:45
*** egarbade-- has joined #openstack-nova00:45
oomichidims: ok, I see00:46
*** smoriya_ has joined #openstack-nova00:46
*** blaisebool has quit IRC00:47
*** egarbade-- has quit IRC00:48
*** egarbade-- has joined #openstack-nova00:48
*** egarbade-- has quit IRC00:51
*** egarbade-- has joined #openstack-nova00:51
*** ljxiash has joined #openstack-nova00:53
*** ssurana1 has quit IRC00:53
oomichidims: one more question: how about s3 code(nova/image/s3.py, etc.)? The patch seems to keep the code intentionally00:54
*** egarbade-- has quit IRC00:54
*** egarbade-- has joined #openstack-nova00:55
*** zhangjn has joined #openstack-nova00:57
*** haomaiwang has quit IRC01:01
*** haomaiwang has joined #openstack-nova01:01
*** pratikmallya has quit IRC01:03
*** Sukhdev has quit IRC01:08
*** suro-patz has quit IRC01:08
*** eharney has quit IRC01:08
*** penick has quit IRC01:14
*** ljxiash has quit IRC01:17
*** EinstCrazy has joined #openstack-nova01:17
dimsoomichi : yes, there's a dependency on the data stored, you will see ec2_ids etc in Instance object. this review does not deal with those. some of that data is needed/used for example when generating the data for the config drive. i am deliberately avoiding touching any changes to data01:18
dimsand removing up just the REST API01:19
dimsthanks for the review oomichi - will reply there01:20
oomichidims: I see. I also prefer to avoid to see object changes in REST API patches ;)01:20
dims:) i tried cutting it several ways, this seemed the best01:21
*** mdrabe has quit IRC01:22
*** zhangjn has quit IRC01:28
*** zhangjn has joined #openstack-nova01:29
*** Sukhdev has joined #openstack-nova01:29
*** gyee has joined #openstack-nova01:31
*** haomaiwang has quit IRC01:32
*** zhangyufei has joined #openstack-nova01:33
*** ljxiash has joined #openstack-nova01:38
*** zenoway has quit IRC01:40
*** gongysh has joined #openstack-nova01:44
openstackgerritJohn Hua proposed openstack/nova: xenapi: Image cache cannot be disabled  https://review.openstack.org/26266101:44
*** gongysh has quit IRC01:47
*** andreykurilin__ has quit IRC02:02
*** zhangyufei has quit IRC02:05
*** mtanino has quit IRC02:07
*** zhangyufei has joined #openstack-nova02:08
*** annegentle has joined #openstack-nova02:10
*** lyanchih has joined #openstack-nova02:10
*** ducttape_ has joined #openstack-nova02:10
*** ducttape_ has quit IRC02:14
*** annegentle has quit IRC02:14
*** zhangjn has quit IRC02:17
*** zhangjn has joined #openstack-nova02:18
*** lihg has joined #openstack-nova02:20
*** lihg_ has joined #openstack-nova02:20
*** zhangyufei has quit IRC02:20
*** 14WAALZU3 has joined #openstack-nova02:20
*** lihg has quit IRC02:21
*** lihg_ has quit IRC02:21
*** houming has joined #openstack-nova02:21
*** ssurana has joined #openstack-nova02:22
*** _diana_1 has joined #openstack-nova02:24
*** zhangyufei has joined #openstack-nova02:26
*** Sukhdev has quit IRC02:39
*** vilobhmm11 has quit IRC02:39
*** zhangjn has quit IRC02:39
*** sacharya has joined #openstack-nova02:42
*** zhangjn has joined #openstack-nova02:42
*** lihg has joined #openstack-nova02:46
*** lihg_ has joined #openstack-nova02:46
*** sacharya has quit IRC02:46
*** _diana_1 has quit IRC02:47
*** _diana_1 has joined #openstack-nova02:48
*** _diana_1 has quit IRC02:50
*** sacharya has joined #openstack-nova02:51
*** egarbade-- has quit IRC02:52
*** _diana_1 has joined #openstack-nova02:54
*** zhangjn has quit IRC02:54
*** thorst has quit IRC02:56
*** thorst has joined #openstack-nova02:57
*** rushiagr_away is now known as rushiagr02:57
*** ssurana has quit IRC02:57
*** zhangjn has joined #openstack-nova02:58
*** dims has quit IRC02:59
*** 14WAALZU3 has quit IRC03:01
*** haomaiwang has joined #openstack-nova03:01
*** thorst has quit IRC03:02
*** browne has quit IRC03:02
*** browne has joined #openstack-nova03:02
*** suro-patz has joined #openstack-nova03:03
*** _diana_1 has quit IRC03:07
*** niusmallnan has joined #openstack-nova03:07
*** vilobhmm11 has joined #openstack-nova03:08
*** niusmallnan has left #openstack-nova03:09
*** _diana_1 has joined #openstack-nova03:10
*** lihg has quit IRC03:10
*** lihg_ has quit IRC03:10
*** unicell1 has quit IRC03:10
*** ducttape_ has joined #openstack-nova03:11
*** gjayavelu has joined #openstack-nova03:13
*** gjayavelu has quit IRC03:13
*** ducttape_ has quit IRC03:16
*** thorst has joined #openstack-nova03:17
*** sacharya has quit IRC03:17
*** sacharya has joined #openstack-nova03:18
*** lyanchih has quit IRC03:25
*** armax has joined #openstack-nova03:26
*** vilobhmm11 has quit IRC03:28
*** gyee has quit IRC03:30
*** lyanchih has joined #openstack-nova03:35
openstackgerritZhenyu Zheng proposed openstack/nova: config options: Centralise floating ip options  https://review.openstack.org/25708703:36
*** annegentle has joined #openstack-nova03:37
*** unicell has joined #openstack-nova03:37
*** ljxiash has quit IRC03:38
*** ljxiash has joined #openstack-nova03:38
*** zhangjn has quit IRC03:38
*** annegentle has quit IRC03:39
*** ljxiash has quit IRC03:43
*** annegentle has joined #openstack-nova03:44
openstackgerritVladik Romanovsky proposed openstack/nova: pci: do not filter out any SRIOV Physical Functions  https://review.openstack.org/24901603:45
openstackgerritVladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment  https://review.openstack.org/24901803:45
openstackgerritVladik Romanovsky proposed openstack/nova: pci: adding support to specify a device_type in pci requests  https://review.openstack.org/25925403:45
openstackgerritVladik Romanovsky proposed openstack/nova: objects: adding a parent_addr field to the PciDevice object  https://review.openstack.org/24901503:45
*** suro-patz has quit IRC03:45
*** links has joined #openstack-nova03:51
*** yamahata has quit IRC03:52
*** sacharya has quit IRC03:52
*** zhangyufei has quit IRC03:53
*** unicell has quit IRC03:54
*** zhangyufei has joined #openstack-nova03:54
openstackgerritZhenyu Zheng proposed openstack/nova: Expose quiesce/unquiesce API  https://review.openstack.org/24898903:54
*** sacharya has joined #openstack-nova03:54
*** Kevin_Zheng has joined #openstack-nova03:57
*** _diana_1 has quit IRC04:00
*** haomaiwang has quit IRC04:01
openstackgerritEli Qiao proposed openstack/nova: Calculate block_migration in virt drivers if it's None  https://review.openstack.org/25410104:01
openstackgerritEli Qiao proposed openstack/nova: Return host and block_migration in task_api._execute()  https://review.openstack.org/25410204:01
openstackgerritEli Qiao proposed openstack/nova: API: Improve os-migrateLive input and output values  https://review.openstack.org/25931904:01
*** haomaiwang has joined #openstack-nova04:01
*** thorst has quit IRC04:04
*** thorst has joined #openstack-nova04:04
*** davideagnello has quit IRC04:05
*** coolsvap|away is now known as coolsvap04:06
*** otter768 has quit IRC04:07
*** browne has quit IRC04:08
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: virtual interface tags DB table  https://review.openstack.org/26401404:09
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: metadata objects  https://review.openstack.org/26401504:09
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: libvirt driver implementation  https://review.openstack.org/26401604:09
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: compute manager nic tagging support  https://review.openstack.org/26401704:09
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: user visible changes  https://review.openstack.org/26401804:09
*** kotra03 has joined #openstack-nova04:09
*** ducttape_ has joined #openstack-nova04:12
*** PsionTheory has quit IRC04:13
*** thorst has quit IRC04:13
*** rushiagr is now known as rushiagr_away04:14
*** shyama has joined #openstack-nova04:16
*** ducttape_ has quit IRC04:17
*** shyama has quit IRC04:18
*** suro-patz has joined #openstack-nova04:26
*** coolsvap is now known as coolsvap|away04:29
openstackgerritAugustina Ragwitz proposed openstack/nova: Make project_id optional in v2.1 urls  https://review.openstack.org/23307604:31
*** annegentle has quit IRC04:49
*** oomichi has quit IRC04:49
*** zhangyufei has quit IRC04:50
*** gongysh has joined #openstack-nova04:51
*** annegentle has joined #openstack-nova04:51
*** ljxiash has joined #openstack-nova04:54
*** rushiagr_away is now known as rushiagr04:57
*** sudipto has joined #openstack-nova04:58
*** lyanchih has quit IRC05:00
*** haomaiwang has quit IRC05:01
*** haomaiwang has joined #openstack-nova05:01
*** Jeffrey4l has joined #openstack-nova05:02
*** gongysh has quit IRC05:06
*** davideagnello has joined #openstack-nova05:06
*** gongysh has joined #openstack-nova05:10
*** thorst has joined #openstack-nova05:10
*** davideagnello has quit IRC05:11
*** aagrawal has quit IRC05:13
*** vilobhmm11 has joined #openstack-nova05:13
*** _diana_1 has joined #openstack-nova05:13
*** ducttape_ has joined #openstack-nova05:13
*** suro-patz has quit IRC05:15
*** fawadkhaliq has joined #openstack-nova05:17
*** chhavi has joined #openstack-nova05:17
*** thorst has quit IRC05:18
*** ijw_ has quit IRC05:18
*** gjayavelu has joined #openstack-nova05:18
*** ducttape_ has quit IRC05:18
*** cfriesen__ has joined #openstack-nova05:20
*** _diana_1 has quit IRC05:21
*** chhavi has quit IRC05:26
*** zhangjn has joined #openstack-nova05:26
*** chhavi has joined #openstack-nova05:26
*** unicell has joined #openstack-nova05:34
*** zhangjn has quit IRC05:35
*** coolsvap|away is now known as coolsvap05:35
*** annegentle has quit IRC05:36
*** zhangjn has joined #openstack-nova05:36
*** annegentle has joined #openstack-nova05:36
*** ssurana has joined #openstack-nova05:42
openstackgerritAlex Xu proposed openstack/nova: doc: completes microversion use-cases in api concept doc  https://review.openstack.org/26322005:43
eliqiaohi alex_xu, there?05:45
alex_xueliqiao: yup, here05:45
eliqiaoI am trying to understand https://review.openstack.org/#/c/245921/18/nova/api/openstack/compute/extension_info.py05:45
eliqiaoalex_xu: can you help to understand what does v2_extension_suppress_list mean?05:45
alex_xueliqiao: it means hide some extension name in the list of extensions05:46
alex_xueliqiao: that is used to keep the extension api looks like freeze05:47
alex_xuas we didn't have extension in the future any more, we said we just keep the extension api looks like freeze05:48
eliqiaoalex_xu: thanks, I will try to read the code more detail.05:49
alex_xueliqiao: np05:49
*** irenab has joined #openstack-nova05:55
*** coolsvap is now known as coolsvap|away05:55
*** moshele has joined #openstack-nova05:55
*** gcb has joined #openstack-nova05:56
tonybGah no Ken'ichi :(  I'll look for him later ....05:57
*** lyanchih has joined #openstack-nova05:59
*** annegentle has quit IRC06:00
*** zhangjn_ has joined #openstack-nova06:00
*** annegentle has joined #openstack-nova06:00
*** haomaiwang has quit IRC06:01
*** achinm has joined #openstack-nova06:01
*** zhangjn has quit IRC06:02
*** haomaiwa_ has joined #openstack-nova06:03
*** annegentle has quit IRC06:04
*** zhangjn_ has quit IRC06:05
*** unicell1 has joined #openstack-nova06:06
*** unicell has quit IRC06:07
*** zhangjn has joined #openstack-nova06:08
*** otter768 has joined #openstack-nova06:08
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata  https://review.openstack.org/25219706:10
*** sacharya has quit IRC06:11
*** cfriesen__ has quit IRC06:11
*** otter768 has quit IRC06:13
*** ducttape_ has joined #openstack-nova06:14
*** lyanchih has quit IRC06:15
*** zhangjn has quit IRC06:15
*** thorst has joined #openstack-nova06:16
*** zhangjn has joined #openstack-nova06:16
*** coolsvap|away is now known as coolsvap06:18
*** ducttape_ has quit IRC06:19
*** ijw has joined #openstack-nova06:20
*** dslevin has quit IRC06:20
*** ijw has quit IRC06:20
*** vilobhmm111 has joined #openstack-nova06:22
*** ijw has joined #openstack-nova06:22
*** ijw has quit IRC06:22
*** ijw has joined #openstack-nova06:23
*** thorst has quit IRC06:23
*** vilobhmm11 has quit IRC06:24
*** zhangyufei has joined #openstack-nova06:29
*** gwei3 has joined #openstack-nova06:34
*** gongysh has quit IRC06:36
*** Sukhdev has joined #openstack-nova06:37
*** jwcroppe has quit IRC06:38
*** suro-patz has joined #openstack-nova06:40
openstackgerritAlex Xu proposed openstack/nova: doc: add version discovery guideline in api concept doc  https://review.openstack.org/26404406:41
openstackgerritAlex Xu proposed openstack/nova: doc: add client interactive guideline for microversions  https://review.openstack.org/26404506:41
*** nelsnels_ has quit IRC06:42
*** paul-carlton2 has joined #openstack-nova06:43
*** cfriesen__ has joined #openstack-nova06:47
*** shuquan has joined #openstack-nova06:49
*** nelsnelson has joined #openstack-nova06:49
*** paul-carlton2 has quit IRC06:50
*** paul-carlton2 has joined #openstack-nova06:52
*** dslevin has joined #openstack-nova06:54
*** belmoreira has joined #openstack-nova06:59
openstackgerritYingxin Cheng proposed openstack/nova: Refactor claim code to eliminate duplication  https://review.openstack.org/26293906:59
openstackgerritYingxin Cheng proposed openstack/nova: Scheduler use Claim to check resource consumption  https://review.openstack.org/26293806:59
*** gwei31 has joined #openstack-nova07:00
*** haomaiwa_ has quit IRC07:01
*** gwei31 has quit IRC07:01
*** sahid has joined #openstack-nova07:01
*** gwei3 has quit IRC07:01
*** haomaiwang has joined #openstack-nova07:01
*** armax has quit IRC07:07
*** davideagnello has joined #openstack-nova07:07
*** xianghui has quit IRC07:10
*** zhangjn has quit IRC07:11
*** sacharya has joined #openstack-nova07:12
*** davideagnello has quit IRC07:13
*** ljxiash has quit IRC07:14
*** ljxiash has joined #openstack-nova07:15
*** ducttape_ has joined #openstack-nova07:15
*** zhangjn has joined #openstack-nova07:15
*** sacharya has quit IRC07:16
*** xianghui has joined #openstack-nova07:16
*** suro-patz has quit IRC07:18
*** ljxiash_ has joined #openstack-nova07:18
*** yangyapeng has joined #openstack-nova07:19
*** klkumar has joined #openstack-nova07:19
*** ljxiash has quit IRC07:19
*** ducttape_ has quit IRC07:20
*** ljxiash_ has quit IRC07:21
*** ljxiash has joined #openstack-nova07:21
*** thorst has joined #openstack-nova07:21
*** ljxiash has quit IRC07:21
*** ljxiash has joined #openstack-nova07:22
*** e0ne has joined #openstack-nova07:25
*** ljxiash has quit IRC07:26
*** artom has quit IRC07:28
*** thorst has quit IRC07:28
*** ljxiash has joined #openstack-nova07:29
*** ijw has quit IRC07:31
*** sahid has quit IRC07:31
*** yangyapeng has quit IRC07:33
*** ljxiash has quit IRC07:34
*** fawadkhaliq has quit IRC07:37
*** ljxiash has joined #openstack-nova07:39
*** fawadkhaliq has joined #openstack-nova07:40
*** zhangjn has quit IRC07:45
*** Sukhdev has quit IRC07:46
*** wuhg has joined #openstack-nova07:47
*** fawadkhaliq has quit IRC07:48
*** fawadkhaliq has joined #openstack-nova07:49
*** Sukhdev has joined #openstack-nova07:49
*** shuquan has quit IRC07:52
*** ljxiash has quit IRC07:53
*** shuquan has joined #openstack-nova07:53
*** yarkot has quit IRC07:55
*** lpetrut has joined #openstack-nova07:56
openstackgerritEli Qiao proposed openstack/nova: API: Improve os-migrateLive input and output values  https://review.openstack.org/25931907:56
*** Sukhdev has quit IRC07:57
*** ijw has joined #openstack-nova07:58
openstackgerritIldiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments  https://review.openstack.org/19313507:58
openstackgerritIldiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments  https://review.openstack.org/19313407:58
openstackgerritIldiko Vancsa proposed openstack/nova: db and obj: Allow multiple volume attachments  https://review.openstack.org/19313307:58
*** ljxiash has joined #openstack-nova07:58
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach  https://review.openstack.org/15303807:58
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: virt: Pass host when call attach to Cinder  https://review.openstack.org/25627307:58
*** coolsvap is now known as coolsvap|away08:00
*** ljxiash has quit IRC08:00
*** yamahata has joined #openstack-nova08:00
*** haomaiwang has quit IRC08:01
*** rushiagr is now known as rushiagr_away08:01
*** haomaiwang has joined #openstack-nova08:01
*** ljxiash has joined #openstack-nova08:01
*** lyanchih has joined #openstack-nova08:02
*** ljxiash_ has joined #openstack-nova08:02
*** ljxiash__ has joined #openstack-nova08:04
*** ljxiash has quit IRC08:05
*** coolsvap|away is now known as coolsvap08:06
*** ljxiash_ has quit IRC08:07
*** otter768 has joined #openstack-nova08:09
*** zakora has joined #openstack-nova08:10
*** rdopiera has joined #openstack-nova08:10
*** otter768 has quit IRC08:14
*** ducttape_ has joined #openstack-nova08:16
*** vilobhmm11 has joined #openstack-nova08:17
*** vilobhmm112 has joined #openstack-nova08:19
*** vilobhmm111 has quit IRC08:19
*** apoorvad has joined #openstack-nova08:20
*** ducttape_ has quit IRC08:21
*** vilobhmm11 has quit IRC08:21
*** shuquan has quit IRC08:21
openstackgerritChaozhe Chen proposed openstack/python-novaclient: Suppress 'get_client_class' deprecated warnings in test_client  https://review.openstack.org/25940108:21
*** rushiagr_away is now known as rushiagr08:22
*** jichen has joined #openstack-nova08:25
*** lyanchih has quit IRC08:25
*** thorst has joined #openstack-nova08:26
*** rushiagr is now known as rushiagr_away08:27
*** gjayavelu has quit IRC08:28
*** rushiagr_away is now known as rushiagr08:28
*** gongysh has joined #openstack-nova08:30
*** sahid has joined #openstack-nova08:31
*** EinstCra_ has joined #openstack-nova08:32
*** matrohon has joined #openstack-nova08:33
*** thorst has quit IRC08:33
bauzasmorning Nova08:33
openstackgerritJason proposed openstack/nova: Correct the code description  https://review.openstack.org/26407108:33
*** rushiagr is now known as rushiagr_away08:34
*** EinstCrazy has quit IRC08:35
*** rushiagr_away is now known as rushiagr08:35
*** rushiagr is now known as rushiagr_away08:41
*** gongysh has quit IRC08:41
*** rushiagr_away is now known as rushiagr08:42
*** rushiagr is now known as rushiagr_away08:43
*** jlanoux has joined #openstack-nova08:43
*** fawadkhaliq has quit IRC08:46
openstackgerritTang Chen proposed openstack/nova: Add a REST API to trigger crash dump in an instance.  https://review.openstack.org/20261708:47
*** rushiagr_away is now known as rushiagr08:49
*** shyama has joined #openstack-nova08:53
*** rotbeard has joined #openstack-nova08:53
*** rushiagr is now known as rushiagr_away08:54
*** sacharya has joined #openstack-nova08:56
*** fawadkhaliq has joined #openstack-nova08:56
*** lpetrut has quit IRC08:56
*** rushiagr_away is now known as rushiagr08:57
*** lyanchih has joined #openstack-nova09:00
*** sacharya has quit IRC09:00
*** haomaiwang has quit IRC09:01
*** haomaiwang has joined #openstack-nova09:01
*** rushiagr is now known as rushiagr_away09:02
*** rushiagr_away is now known as rushiagr09:04
*** shyama has quit IRC09:04
*** shyama has joined #openstack-nova09:04
*** fawadkhaliq has quit IRC09:07
*** davideagnello has joined #openstack-nova09:09
openstackgerritStephen Finucane proposed openstack/nova: Add 'CPUThreadAllocationPolicy' enum field  https://review.openstack.org/20264709:09
openstackgerritStephen Finucane proposed openstack/nova: trivial: Add additional logs for NUMA scheduling  https://review.openstack.org/25478309:09
openstackgerritStephen Finucane proposed openstack/nova: Make use of 'InstanceNUMACell.cpu_policy' field  https://review.openstack.org/20265309:10
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling  https://review.openstack.org/20265509:10
openstackgerritStephen Finucane proposed openstack/nova: Add 'cpu_policy' and 'cpu_thread_policy' fields  https://review.openstack.org/20264809:10
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_thread_policy=require' scheduling  https://review.openstack.org/20265109:10
*** ijw has quit IRC09:10
*** zhangjn has joined #openstack-nova09:12
*** sfinucan has joined #openstack-nova09:12
*** rushiagr is now known as rushiagr_away09:13
*** rushiagr_away is now known as rushiagr09:13
*** shyama_ has joined #openstack-nova09:14
openstackgerritChaozhe Chen proposed openstack/python-novaclient: Suppress 'get_client_class' deprecated warnings in test_client  https://review.openstack.org/25940109:14
*** davideagnello has quit IRC09:14
*** derekh has joined #openstack-nova09:16
sfinucanalaski: Could I get a workflow +1 again for a trivial rebase? https://review.openstack.org/#/c/202647/2609:16
openstackgerritJason proposed openstack/nova: Correct the manager.py code description  https://review.openstack.org/26408409:16
chaochinalex_xu: hi09:16
*** ducttape_ has joined #openstack-nova09:16
*** ankit_ag has joined #openstack-nova09:17
chaochinalex_xu: do you have time to have a look at my https://review.openstack.org/#/c/262165/09:17
*** shyama has quit IRC09:17
sfinucan(Gerrit/Jenkins appeared to have broken for said change and refused to merge...)09:17
*** shyama_ is now known as shyama09:17
*** jistr has joined #openstack-nova09:17
alex_xuchaochin: yea, will check now09:17
chaochinalex_xu: you request me to create a spec for the bug. Not sure if that spec statisfy your request09:17
chaochinalex_xu: thank you very much09:17
*** ccard has joined #openstack-nova09:18
*** ssurana has quit IRC09:19
*** yassine has joined #openstack-nova09:19
alex_xuchaochin: np, thanks for the spec09:19
*** ssurana has joined #openstack-nova09:19
ankit_agHi all, Can someone help reviewing https://review.openstack.org/#/c/247519/09:21
*** ducttape_ has quit IRC09:21
*** jlanoux has quit IRC09:22
*** aix has joined #openstack-nova09:23
*** jlanoux has joined #openstack-nova09:24
*** ssurana has quit IRC09:24
*** apoorvad has quit IRC09:24
*** qianli has joined #openstack-nova09:25
openstackgerritStephen Finucane proposed openstack/nova: Forcing a configdrive in cfg should populate DB  https://review.openstack.org/9289909:26
*** thorst has joined #openstack-nova09:31
*** ociuhandu has quit IRC09:34
*** fawadkhaliq has joined #openstack-nova09:35
*** ociuhandu has joined #openstack-nova09:35
*** zhangjn has quit IRC09:35
*** fawadkhaliq has quit IRC09:36
*** thorst has quit IRC09:38
*** jwcroppe has joined #openstack-nova09:39
*** vilobhmm112 has quit IRC09:40
*** EinstCra_ has quit IRC09:40
*** EinstCrazy has joined #openstack-nova09:42
*** fawadkhaliq has joined #openstack-nova09:43
*** jwcroppe has quit IRC09:43
*** ociuhandu has quit IRC09:44
*** ptm_away is now known as PaulMurray09:44
*** ijw has joined #openstack-nova09:46
*** dedery has joined #openstack-nova09:50
*** zhangjn has joined #openstack-nova09:51
*** shyama has quit IRC09:54
*** shyama has joined #openstack-nova09:54
openstackgerritsahid proposed openstack/nova: libvirt: add policy check to avoid using qga in realtime context  https://review.openstack.org/24758509:57
openstackgerritsahid proposed openstack/nova: conductor: initialize request_spec to handle expected exception  https://review.openstack.org/25801109:57
openstackgerritsahid proposed openstack/nova: libvirt: add realtime support  https://review.openstack.org/19756909:58
openstackgerritThomas Bechtold proposed openstack/nova: xen: Allow custom libvirt kernel in PV mode  https://review.openstack.org/26410109:58
*** dedery_ has joined #openstack-nova10:00
*** haomaiwang has quit IRC10:01
*** dedery__ has joined #openstack-nova10:01
*** haomaiwang has joined #openstack-nova10:01
*** dedery__ has quit IRC10:02
*** zhangyufei has quit IRC10:02
*** EinstCrazy has quit IRC10:04
*** dedery has quit IRC10:04
*** dedery__ has joined #openstack-nova10:04
*** dedery_ has quit IRC10:04
*** ndipanov has joined #openstack-nova10:05
*** chhavi has quit IRC10:08
ildikovjohnthetubaguy: good morning10:09
johnthetubaguyildikov: hi10:09
ildikovjohnthetubaguy: I changed the rpcapi to pass attachment_id, when we can10:09
*** fawadkhaliq has quit IRC10:09
*** achinm has quit IRC10:09
ildikovjohnthetubaguy: https://review.openstack.org/#/c/193134/5710:10
*** otter768 has joined #openstack-nova10:10
*** ijw has quit IRC10:10
ildikovjohnthetubaguy: is this what you have in mind earlier?10:10
johnthetubaguyildikov: that sounds correct, to try and avoid the extra call to cinder, where possible.10:11
ildikovjohnthetubaguy: yeah, this is what I tried to do, it calls out only in that case if the attachment_id is missing10:12
*** ndipanov has quit IRC10:12
ildikovjohnthetubaguy: the check is right before the call to Cinder so it's kinda centralized10:12
*** otter768 has quit IRC10:14
johnthetubaguyildikov: I added a quick comment around leaving the compat code in the compute manger, so its eaiser to remove at the point where we always pass the attachement_id (when we next bump the major version)10:15
*** slunkad has quit IRC10:15
*** zhangjn has quit IRC10:17
*** chhavi has joined #openstack-nova10:17
*** ducttape_ has joined #openstack-nova10:17
ildikovjohnthetubaguy: we will need to call out to Cinder anyway, I mean in case of removing an instance etc you usually don't get the volume from the API10:18
*** zhangjn has joined #openstack-nova10:18
*** ijw has joined #openstack-nova10:18
*** lpetrut has joined #openstack-nova10:19
ildikovjohnthetubaguy: the volume_api.detach call happens in multiple places and it looks messier to me to retrieve the attachment_id in each and every place we don't have it10:19
johnthetubaguyildikov: ah, true, that makes sense10:20
johnthetubaguynot read the full patch, trying to work on some testing stuff this morning10:20
*** andreykurilin__ has joined #openstack-nova10:20
ildikovjohnthetubaguy: I also wonder whether to pass the multiattach flag too10:20
ildikovand if it's true AND we don't have attachment_id then call out to Cinder10:20
ildikovjohnthetubaguy: sorry to disturb10:20
johnthetubaguyildikov: no worries, PTL is a life of interruptions :)10:21
ildikovI just wanted to double check the direction before doing further changes10:21
johnthetubaguytotally10:21
ildikov:)10:21
*** ducttape_ has quit IRC10:22
johnthetubaguyildikov: I am just wondering if we should really store the attachment id in the BDM? not its not so clear how to detach with just the information in the BDM10:22
*** zhangjn has quit IRC10:22
johnthetubaguyildikov: also maybe worth storing multi-attach in the BDM too, given how much we need that info10:23
ildikovjohnthetubaguy: I don't know about live migration and other cases where Cinder should be the ultimate source of truth10:23
*** ijw_ has joined #openstack-nova10:23
johnthetubaguymulti-attach is the less clear one for sure, but the attachment id feels like something cinder tells us, that we are meant to remember so we perform the correct detach10:24
ildikovmulti-attach should not change, I don't know what's the case with the attachment_id10:24
johnthetubaguyI am not sure about these, just thinking out loud really10:24
ildikovI can pass these two args now to detach and especially in the early phase I think it will keep the round trips low10:25
*** dguitarbite has joined #openstack-nova10:25
ildikovI mean I don't think many users would create volumes with the multiattach flag set to true nowadays for instance10:25
*** ijw has quit IRC10:26
*** slunkad has joined #openstack-nova10:27
*** cdent has joined #openstack-nova10:28
ildikovjohnthetubaguy: later we can still add this info to the BDM as an optimization step, it can be included in the API spec for multiattach10:28
ildikovanyway, I go back and deal with the cases we discussed yesterday10:28
ildikovthanks for the quick check10:28
johnthetubaguyildikov: OK, its more the API level checks later on that worry me. The API shouldn't have to call out to cinder before it can return its response to the user10:31
*** ociuhandu has joined #openstack-nova10:31
johnthetubaguyildikov: but for now, we can always fail at the compute layer anyways, so its not a massive issues, just I don't feel I can see the whole picture yet10:31
johnthetubaguyno seeing the whole picture is my issue here, not anyone elses10:32
*** gjayavelu has joined #openstack-nova10:32
*** gjayavelu has quit IRC10:32
*** gjayavelu has joined #openstack-nova10:32
ildikovjohnthetubaguy: I don't really see how the API is affected here10:33
johnthetubaguyildikov: we were talking about disabling certain actions if the volume is multi-attach, but actually it doesn't need the BDMs in those cases, I got it back to front10:34
ildikovjohnthetubaguy: a-ha, ok, you meant the not supported things with multi-attach10:34
johnthetubaguyyeah10:34
*** ndipanov has joined #openstack-nova10:34
*** gjayavelu has quit IRC10:35
ildikovthe multiattach info is needed either from the volume info or from the BDM if we will store it there10:36
*** thorst has joined #openstack-nova10:36
*** dedery has joined #openstack-nova10:36
openstackgerritlyanchih proposed openstack/nova-specs: Spec to add resources-links in resource list API Response  https://review.openstack.org/26411410:37
ildikovbut for the actions we block that should be the only call10:37
*** dedery__ has quit IRC10:40
*** thorst has quit IRC10:43
*** fawadkhaliq has joined #openstack-nova10:44
*** gjayavelu has joined #openstack-nova10:45
*** fawadkhaliq has quit IRC10:45
*** femnad has joined #openstack-nova10:45
*** ljxiash__ has quit IRC10:47
*** dims has joined #openstack-nova10:47
*** sudipto has quit IRC10:47
openstackgerritAndrea Rosa proposed openstack/nova: Wrong URL reported by the run_tests.sh message  https://review.openstack.org/26411910:48
*** lyanchih has quit IRC10:48
dimssdague : easy one from yesterday (flaky tests in py34) - https://review.openstack.org/#/c/263789/ - please peek when you get a chance10:49
*** BobBall has quit IRC10:50
*** gcb has quit IRC10:52
*** zhangyufei has joined #openstack-nova10:52
*** houming_ has joined #openstack-nova10:52
*** houming has quit IRC10:52
*** houming_ is now known as houming10:52
dimsthanks johnthetubaguy !10:53
*** gcb has joined #openstack-nova10:54
johnthetubaguydims: no worries, good to identify the broken ones like that, a nice middle ground10:54
*** fawadkhaliq has joined #openstack-nova10:54
johnthetubaguydims: I kinda hope we track down a bug in mox3 if we find out whats common between those tests10:55
*** yassine has quit IRC10:55
*** BobBall has joined #openstack-nova10:56
openstackgerritAlex Xu proposed openstack/nova: doc: add version discovery guideline in api concept doc  https://review.openstack.org/26404410:56
openstackgerritAlex Xu proposed openstack/nova: doc: add client interactive guideline for microversions  https://review.openstack.org/26404510:56
openstackgerritAlex Xu proposed openstack/nova: doc: completes microversion use-cases in api concept doc  https://review.openstack.org/26322010:56
*** fawadkhaliq has quit IRC10:56
*** klkumar has quit IRC10:59
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/nova: Keep py3.X compatibility for urllib  https://review.openstack.org/26103411:00
*** haomaiwang has quit IRC11:01
*** sudipto has joined #openstack-nova11:01
*** haomaiwang has joined #openstack-nova11:01
*** gcb has quit IRC11:01
*** ljxiash has joined #openstack-nova11:03
shyamaildikov: please look at https://review.openstack.org/#/c/264059/ when you have time11:03
ildikovshyama: hi, tnx, just answered with further questions11:04
shyamaildikov: yes. we need a check similar to what hemna is doing for remove export in terminate connection as well11:06
*** lucas-dinner is now known as lucasagomes11:06
shyamathe problem is not all cinder drivers treat remove export and terminate_connection same way. since we pass the attached_host to the attachement table I think the same check in terminate_connection should be good enough11:07
ildikovshyama: but you mean in Cinder or on Nova side?11:07
ildikovshyama: yeah, I'm learning it on the way that all the drivers are slightly different... :S11:08
shyamaildikov: if it goes into cinder it will be good. or we might need to think of a solution in the nova side which would not be the nicest thing to do11:08
lxslindipanov, bauzas: either of you feel like +A https://review.openstack.org/#/c/206070/ please?11:08
ildikovshyama: nah, I would like to keep everything in Cinder that belongs there if possible11:08
bauzaslxsli: sure, lemme look11:09
shyamawe would need to discuss with hemna on this one11:09
ildikovshyama: there's a topic for that one for the Cinder meeting today11:09
*** rfolco has joined #openstack-nova11:09
ildikovI think we can bring this up there too11:10
*** fawadkhaliq has joined #openstack-nova11:10
ildikovshyama: will you attend the meeting?11:10
shyamaildikov: ok when is the meeting. I usually cannot make it due to time zone differences I will make it to the one today11:10
*** davideagnello has joined #openstack-nova11:10
*** gjayavelu has quit IRC11:11
*** klkumar has joined #openstack-nova11:12
ildikovshyama: 16:00 UTC11:15
*** davideagnello has quit IRC11:15
*** smoriya_ has quit IRC11:15
ildikovshyama: which time zone are you in?11:15
shyamaildikov: thanks! I work from India11:15
dimsjohnthetubaguy : yep, figuring out mox is the right thing to do11:16
*** zhangjn has joined #openstack-nova11:16
*** haomaiwang has quit IRC11:17
ildikovshyama: yeah, it's kinda late there at the time of the meeting11:17
ildikovthanks for joining today!11:17
*** ducttape_ has joined #openstack-nova11:18
shyamaildikov: one other thing my colleague put up this blueprint proposal to edit the multiattach property of a volume after it is created. https://review.openstack.org/#/c/264059/11:19
shyamado take a look.11:19
*** gcb has joined #openstack-nova11:21
dimsjohnthetubaguy : for dropping the ec2/objectstore REST API review, i steered clear of any data model changes and still able to nuke about 10k worth of code - https://review.openstack.org/#/c/263368/11:21
*** ducttape_ has quit IRC11:22
ildikovshyama: well, from Nova perspective it's not that good in the sense of there will be actions we cannot support with multiattach at least not in the first round11:23
dimsjohnthetubaguy : filed a mox3 bug - https://bugs.launchpad.net/python-mox3/+bug/153146411:23
openstackLaunchpad bug 1531464 in python-mox3 "Fix flaky Nova tests" [Undecided,New]11:23
johnthetubaguydims: cool stuff11:24
johnthetubaguydims: did we hear back from the CERN folks about EC2 at all?11:24
shyamaildikov: any specifc actions?11:24
ildikovshyama: so if this makes it then we need to be sure in every case that we have the latest and greatest info about the volume from Cinder11:24
*** jwcroppe has joined #openstack-nova11:24
ildikovshyama: boot_from_volume, volume_snapshot_create11:24
*** fawadkhaliq has quit IRC11:24
ildikovand I'm sure there'll be more11:25
shyamaildikov: do you have code check in the manager layer for multiattach volumes here?11:25
ildikovI also don't know how live migration will work, especially with the Cinder bug with detach11:25
ildikovthat's what I will start working on today to add checks11:26
kashyapmarkmc: When you're around, did you set any explicit flags in nova.conf in your testing (from comment#3 here)? - https://bugs.launchpad.net/nova/+bug/144105411:26
openstackLaunchpad bug 1441054 in OpenStack Compute (nova) "live-migration --block-migrate fails with default libvirt flags" [Medium,In progress] - Assigned to Mathieu Rohon (mathieu-rohon)11:26
dimsjohnthetubaguy : searching email archives, no news from them for 10+ months11:26
ildikovshyama: what's possible to check on the API layer that should happen there otherwise where possible11:27
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/nova: Replace deprecated LOG.warn with LOG.warning  https://review.openstack.org/26413311:27
*** mriedem has joined #openstack-nova11:28
shyamaildikov: ok so when a volume is multiattach then you would not allow boot from volume etc., may be i missed this discussion in the review. can you brief me what would be the reason11:28
kashyapmarkmc: I ask because, from my previous testing (a couple of months ago), I see something simliar to what you see, migration falling back to old implementation (QMP "inc":true approach), tested on Fedora-22 -- https://kashyapc.fedorapeople.org/virt/openstack/successful-logs-nova-live-block-migration/src-libv-log-of-nova-live-block-mig.txt11:28
*** cdent has quit IRC11:28
ildikovshyama: we discussed it yesterday here, could not get there yet to capture it in the review11:29
shyamaildikov: ok let me go though the irc logs11:29
kashyapmarkmc: (You'd see the same "Falling back to previous implementation" string, if you grep for it.) Anyhow - I'm testing afresh on Fedora-23 with latest git, and will add a comment on the bug from what I find.11:29
*** chhavi has quit IRC11:30
*** dguitarbite has quit IRC11:31
*** vladikr has quit IRC11:31
ildikovshyama: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2016-01-05.log.html11:32
ildikovshyama: it's around 15:00 when we get to those cases11:33
ildikovshyama: like delete_on_termination, etc.11:33
*** sahid has quit IRC11:34
shyamaildikov: i do not think delete_on_termination should be a concern because the volume will not be deleted but the instance should be.11:35
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] byte/string conversions and enable more tests  https://review.openstack.org/26104511:35
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] Port more code to python3 and enable tests  https://review.openstack.org/26208311:35
*** ljxiash has quit IRC11:35
ildikovildikov: I don't know how that works with Cinder today11:35
ildikovshyama:11:35
*** ljxiash has joined #openstack-nova11:36
ildikovso basically the concept is to block everything we're not sure will work11:36
shyamaildikov: from some testing we have done i think the instance delete will proceed. let me confirm which part of the code11:36
openstackgerritStephen Finucane proposed openstack/nova: Config options: centralize "configdrive" options  https://review.openstack.org/25409211:37
shyamaildikov: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L240811:39
*** ljxiash has quit IRC11:40
*** zhangyufei has quit IRC11:40
*** thorst has joined #openstack-nova11:41
*** jwcroppe has quit IRC11:42
ildikovshyama: do you mean that this will not delete the volume on Cinder side in case of multiattach: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1770 ?11:44
ildikovshyama: I mean this: https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L42511:45
shyamaildikov: cinder will throw an exception because the volume is still attached but nova ignores that and moves on as the instance is already deleted11:45
*** chhavi has joined #openstack-nova11:46
shyamaildikov: i am pretty sure that all cinder drivers do the same in this case :)11:46
ildikovshyama: are you sure there never be a case which moves the instance to error state?11:46
ildikovshyama: at least one consistent case :)11:47
*** klkumar has quit IRC11:47
*** coolsvap is now known as coolsvap|away11:47
shyamaildikov: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2353-L2365 if delete volume fails we do not throw an exception in the delete instance flow11:48
*** thorst has quit IRC11:48
openstackgerritsandeep nandal proposed openstack/nova: Replacing range() n xrange() by six.moves.range()  https://review.openstack.org/26100611:50
openstackgerritsandeep nandal proposed openstack/nova: Replacing range() n xrange() by six.moves.range()  https://review.openstack.org/26414311:50
ildikovshyama: yeah, it looks the case11:51
ildikovshyama: I will also need to check that IRC log further for what and why to block first11:52
shyamaildikov: I see boot from volume discussed not sure about others11:52
ildikovunfortunately the spec does not cover all the cases and the deadline here is Jan 21 to get the code landed11:52
*** klkumar has joined #openstack-nova11:53
ildikovshyama: create_snapshot allso seemed to be problematic11:53
ildikovso it would be good to have a sane first version landed before that pretty close deadline and then evolve it further11:53
*** renatoarmani has joined #openstack-nova11:54
openstackgerritMarian Horban proposed openstack/nova: Stop Libvirt event threads  https://review.openstack.org/25906611:55
*** apoorvad has joined #openstack-nova11:57
shyamaildikov: I agree with create snapshot one, but boot from volume is not needed11:58
*** yassine has joined #openstack-nova11:59
*** doug-fish has joined #openstack-nova11:59
ildikovshyama: you mean to be blocked?11:59
shyamaildikov: yes12:01
ildikovshyama: ok, I will re-open the discussion on that one, when I get there, tnx for the pointers12:01
shyamaildikov: thank you!12:02
*** klkumar has quit IRC12:02
*** klkumar has joined #openstack-nova12:02
*** apoorvad has quit IRC12:06
*** atuvenie has joined #openstack-nova12:06
*** klkumar has quit IRC12:08
openstackgerritAlexis Lee proposed openstack/nova: Catch errors while creating veth pair  https://review.openstack.org/26414612:09
*** cdent has joined #openstack-nova12:09
*** jlanoux has quit IRC12:10
*** otter768 has joined #openstack-nova12:11
*** klkumar has joined #openstack-nova12:13
*** pkholkin has quit IRC12:15
*** otter768 has quit IRC12:15
*** smatzek has joined #openstack-nova12:17
*** obondarev_ has quit IRC12:17
*** wuhg has quit IRC12:18
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] byte/string conversions and enable more tests  https://review.openstack.org/26104512:19
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] Port more code to python3 and enable tests  https://review.openstack.org/26208312:20
*** dstepanenko_ has quit IRC12:20
*** zhangjn has quit IRC12:26
openstackgerritBalazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications  https://review.openstack.org/26378812:27
openstackgerritBalazs Gibizer proposed openstack/nova: Add service status notification  https://review.openstack.org/24567812:27
openstackgerritBalazs Gibizer proposed openstack/nova: Add infra for versioned notifications  https://review.openstack.org/24702412:27
openstackgerritBalazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications  https://review.openstack.org/24816712:27
openstackgerritBalazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable  https://review.openstack.org/24756412:27
openstackgerritChangBo Guo(gcb) proposed openstack/nova: virt: refactor method compute_driver_matches  https://review.openstack.org/26324312:36
*** fawadkhaliq has joined #openstack-nova12:38
*** fawadkhaliq has quit IRC12:39
*** fawadkhaliq has joined #openstack-nova12:39
*** jaypipes has joined #openstack-nova12:42
*** claudiub has joined #openstack-nova12:42
openstackgerritjichenjc proposed openstack/nova: Remove mox usage of test_quota  https://review.openstack.org/26415412:42
openstackgerritBalazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications  https://review.openstack.org/26378812:44
openstackgerritBalazs Gibizer proposed openstack/nova: Add service status notification  https://review.openstack.org/24567812:44
openstackgerritBalazs Gibizer proposed openstack/nova: Add infra for versioned notifications  https://review.openstack.org/24702412:44
openstackgerritBalazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications  https://review.openstack.org/24816712:44
openstackgerritBalazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable  https://review.openstack.org/24756412:44
*** pradk has quit IRC12:45
*** zhangjn has joined #openstack-nova12:45
*** zhangjn has quit IRC12:45
*** moshele has quit IRC12:45
*** zhangjn has joined #openstack-nova12:46
*** zhangjn has quit IRC12:46
sdaguejohnthetubaguy / alex_xu / et al: can we get this landed - https://review.openstack.org/#/c/263798/ because it will stop throwing a bunch of gorp into logstash12:46
*** zhangjn has joined #openstack-nova12:47
*** w_verdugo has joined #openstack-nova12:47
*** moshele has joined #openstack-nova12:49
openstackgerritJialiang proposed openstack/nova: Update the file for IPv4-only or IPv6-only network  https://review.openstack.org/26415712:52
*** cdelatte has joined #openstack-nova12:53
*** EinstCrazy has joined #openstack-nova12:53
*** sahid has joined #openstack-nova12:54
*** houming has quit IRC12:54
*** haomaiwang has joined #openstack-nova12:56
*** sacharya has joined #openstack-nova12:57
bauzaslxsli: johnthetubaguy: made a few comments on https://review.openstack.org/#/c/206070/1112:58
*** klkumar has quit IRC12:59
bauzasunless I'm blind, we are mising some hypertext plus I have a problem when we give an etherpad link w/ a line number12:59
bauzasthat said, we can merge that very soon12:59
alex_xusdague: just +w for it13:00
sdaguealex_xu: thanks13:00
alex_xusdague: np13:00
*** haomaiwang has quit IRC13:01
*** sacharya has quit IRC13:02
*** thorst has joined #openstack-nova13:02
markmckashyap, right, I just tested with TUNNELLED and NON_SHARED_INC13:05
markmckashyap, you're saying you did see this work fine too, then?13:05
*** baoli has joined #openstack-nova13:05
kashyapmarkmc: 1 moment13:05
*** zz_dimtruck is now known as dimtruck13:06
*** baoli has quit IRC13:06
kashyapmarkmc: When I tested, I had these flags explicitly set in nova.conf:13:07
kashyap   live_migration_flag = VIR_MIGRATE_UNDEFINE_SOURCE,13:07
kashyap   VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_LIVE13:07
kashyap   block_migration_flag = VIR_MIGRATE_UNDEFINE_SOURCE,13:07
kashyap   VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_LIVE, VIR_MIGRATE_NON_SHARED_INC13:07
*** baoli has joined #openstack-nova13:07
kashyapThus, overriding the default (which _does_ have TUNNELLED, as you know).13:07
kashyapmarkmc: I'm about to setup a fresh env. on F23 with default flags and re-test, but just shaving a bunch of yaks with DevStack.13:08
dimsmarkmc : nice to see you again!13:08
*** EinstCrazy has quit IRC13:09
*** EinstCrazy has joined #openstack-nova13:11
markmcdims, thanks :)13:11
*** baoli has quit IRC13:11
*** EinstCrazy has quit IRC13:12
markmckashyap, right, that bug is specifically about whether NON_SHARED_INC works with TUNNELLED13:12
johnthetubaguybauzas: honestly, with etherpads, the line number is always wrong, I am really just thinking about getting this in ASAP, and evolving it fast13:12
markmckashyap, which it does :)13:12
bauzasjohnthetubaguy: sure, hence me saying we should just give the section name, not the line number13:12
johnthetubaguybauzas: ah, totally makes sense13:13
bauzasthe other comments are mostly nits and rendering problems, we can quickly move forward, honestly13:14
*** gjayavelu has joined #openstack-nova13:14
kashyapmarkmc: Yeah.  ETOOMANYFLAGS, sorry if I confused you :-)13:14
*** baoli has joined #openstack-nova13:16
openstackgerritsahid proposed openstack/nova: libvirt: add policy check to avoid using qga in realtime context  https://review.openstack.org/24758513:16
openstackgerritsahid proposed openstack/nova: conductor: initialize request_spec to handle expected exception  https://review.openstack.org/25801113:16
openstackgerritsahid proposed openstack/nova: libvirt: add realtime support  https://review.openstack.org/19756913:16
openstackgerritsahid proposed openstack/nova: hardware: check whether realtime capable in API  https://review.openstack.org/26416513:16
*** kotra03 has quit IRC13:17
*** baoli_ has joined #openstack-nova13:17
johnthetubaguybauzas: the links are working I think, that is a reference to the __ above and named href below, I think13:17
*** ducttape_ has joined #openstack-nova13:18
bauzasjohnthetubaguy: okay, that's probably me who is not reading correctly13:18
openstackgerritAdelina Tuvenie proposed openstack/nova: Moves OVS related code to a common location  https://review.openstack.org/17972713:18
openstackgerritAdelina Tuvenie proposed openstack/nova: Adds Hyper-V OVS ViF driver  https://review.openstack.org/14004513:18
bauzasjohnthetubaguy: but IIRC, the "nova people" tag references the wikipage link at the end of the doc, right?13:18
bauzasjohnthetubaguy: if so, it should show the URL nope?13:19
*** ducttape_ has quit IRC13:19
*** gjayavelu has quit IRC13:19
*** ducttape_ has joined #openstack-nova13:19
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: deprecate live/block_migration_flag opts  https://review.openstack.org/26343613:19
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: remove the live/block_migration_flag opts  https://review.openstack.org/26343713:19
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: add a new live_migration_tunneled config  https://review.openstack.org/26343413:19
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: add live_migration_extra_flags config option  https://review.openstack.org/26343513:19
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: force use of direct vs p2p migration  https://review.openstack.org/26343213:19
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: force config related migration flags  https://review.openstack.org/26343313:19
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: parse live migration flags at startup  https://review.openstack.org/26343013:19
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: force use/non-use of NON_SHARED_INC flag  https://review.openstack.org/26343113:19
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: better error for bad live migration flag  https://review.openstack.org/26416713:19
*** baoli has quit IRC13:20
*** dslev has joined #openstack-nova13:22
*** lyanchih has joined #openstack-nova13:23
eliqiaohi markmc, there ?one question about your patch https://review.openstack.org/#/c/263430/2/nova/virt/libvirt/driver.py13:24
openstackgerritHarshada Mangesh Kakad proposed openstack/nova: Replace deprecated library function os.popen() with subprocess  https://review.openstack.org/26257013:24
*** mdrabe has joined #openstack-nova13:26
johnthetubaguybauzas: it does I think, look at the mentoring czar, it correctly links to the wiki13:27
*** dane-fichter has joined #openstack-nova13:28
dane-fichterIf I'm incrementing the the version number of ImageMetaProps from 1.9, does it go to 1.10 or to 2.0 ?13:29
*** dimtruck is now known as zz_dimtruck13:31
bauzasjohnthetubaguy: indeed, but the `Nova People` doesn't if you see my comments13:32
bauzasthat said, it's a nit13:32
johnthetubaguybauzas: let me re-read them, I must be missing something13:32
*** links has quit IRC13:32
*** jlanoux has joined #openstack-nova13:33
*** zhangjn has quit IRC13:33
johnthetubaguybauzas: that __`Nova People`_ bit is to link  `Mentoring Czar`__. to .. _`Nova people`: https://wiki.openstack.org/wiki/Nova#People I belive13:33
bauzasjohnthetubaguy: if lxsli changes the etherpad line number to a section name, we can just land it and discuss later13:33
*** edmondsw has joined #openstack-nova13:34
bauzasI don't want to cut hair :)13:34
markmceliqiao, yes?13:34
*** mdrabe has quit IRC13:37
eliqiaomarkmc: just comments in lines.13:37
eliqiaomarkmc: https://review.openstack.org/#/c/263430/2/nova/virt/libvirt/driver.py13:38
*** jwcroppe has joined #openstack-nova13:38
*** zhangjn has joined #openstack-nova13:38
*** dslev has quit IRC13:38
*** zhangjn has quit IRC13:39
*** ducttape_ has quit IRC13:40
*** rushiagr is now known as rushiagr_away13:40
*** eharney has joined #openstack-nova13:43
*** dave-mccowan has joined #openstack-nova13:45
lxslibauzas: thanks for the review, responded13:45
*** ankit_ag has quit IRC13:48
johnthetubaguylxsli: are we good to fix that line number, then we can try get it in I think?13:49
lxsliI'd rather not, as the point of the patch is to be a forklift13:49
openstackgerritBalazs Gibizer proposed openstack/nova: Handle race in allocate_for_instance  https://review.openstack.org/22180313:50
bauzaslxsli: sure, but I also took the opportunity to just modify that13:50
*** jwcroppe has quit IRC13:50
lxsliI'd put up a followup but I'm unsure it's good advice, for something to make it onto the trivial bug list it must have a +113:50
bauzaslxsli: tbh, I just saw that and I can modify the wiki now13:50
lxslithat doesn't help >.<13:50
lxsliAfterwards someone else will come along and point out another content error and the patch never lands13:51
bauzasmeh13:51
lxsliwe should land it as a forklift, THEN tinker with content13:51
*** vladikr has joined #openstack-nova13:51
lxsliI do totally agree it needs to be fixed, but how to fix it is up for debate right now, it's not a 20 second fix13:51
bauzasit's not a 20 sec fix ? orly?13:52
bauzaslemme try to play with the Gerrit UI13:52
lxsliWell you want to put a section name there and I want to remove the advice13:52
lxsliand when have our convos ever taken 20sec? :D13:52
bauzasmeh, you're good anyway :)13:52
lxsliahh sdague appears out of left field :)13:53
sdaguejohnthetubaguy: do you want to give https://review.openstack.org/#/c/199205/42 a glance again, I just went through it and it seems fine to me13:53
openstackgerritdane-fichter proposed openstack/nova: Add image signature verification  https://review.openstack.org/18984313:54
lxsliso johnthetubaguy - do you agree asking new contributors to +1 trivial patches (which already have +1) is a bad use of their time?13:54
johnthetubaguysdague: ah, yes, looking now13:54
lxslithey're unlikely to learn all that much from trivial patches either imo13:54
openstackgerritBalazs Gibizer proposed openstack/nova: api: add soft-affinity policies for server groups  https://review.openstack.org/14752013:55
johnthetubaguylxsli: whats this in reference too, that doc?13:55
openstackgerritBalazs Gibizer proposed openstack/nova: scheduler: fill RequestSpec.instance_group.members  https://review.openstack.org/14827713:55
openstackgerritBalazs Gibizer proposed openstack/nova: scheduler: add soft-(anti-)affinity weighers  https://review.openstack.org/14751613:55
*** zhangjn has joined #openstack-nova13:56
lxsliyep, the line # issue13:56
lxslibauzas suggested changing the line # to a section name, but on reading it, the advice seems just bad13:56
bauzasso that's all the problem about having a persistent link for an etherpad13:57
bauzasI'm not really sold either13:57
sdaguelxsli / bauzas on docs patches I prefer we merge improvements more quickly. English is never perfect. And random walking towards better is better than the docs being really bad until we have a perfect replacement.13:57
bauzasI just feel it's less errorprone13:57
lxslisdague: +113:57
bauzassdague: I certainly share your views on that, hence me not -1ing13:58
lxslibauzas: section name or line # is irrelevant if we're going to delete the paragraph13:58
*** mgoddard_ has joined #openstack-nova13:58
lxslialthough I do prefer section name13:58
bauzaslxsli: agreed, that just sucks less than providing a line number, that's it :(13:58
sdaguejohnthetubaguy: did we agree we're dropping the ec2 stack right now? - https://review.openstack.org/#/c/263368/ ?13:59
bauzasbut my goal wasn't to split hairs, just to mention something I was feeling wrong :)13:59
*** jwcroppe has joined #openstack-nova13:59
lxsliyes thank you, I'm working on a followup now13:59
sdagueyeh, follow up seems fine13:59
johnthetubaguysdague: I don't remember us deciding, I thought we were waiting for CERN to say it worked for them, if possible14:00
sdaguejohnthetubaguy: ok, well dropping the tests isn't really an option if we aren't going to drop the code14:00
sdagueI'm going to -2 that patch for now14:00
*** annegentle has joined #openstack-nova14:01
*** haomaiwang has joined #openstack-nova14:01
*** klkumar has joined #openstack-nova14:01
*** mgoddard has quit IRC14:01
johnthetubaguysdague: yeah, I think we said remove before the end of the release if there is no news, but it seems a touch early, good call14:02
sdaguedocs are also one of those places where we don't get enough contributions, so I'd rather say "thanks" and merge them fast unless they are definitively wrong14:02
*** zenoway has joined #openstack-nova14:02
bauzassdague: see https://review.openstack.org/#/c/229250/6/doc/source/filter_scheduler.rst then :)14:03
johnthetubaguylxsli: yeah, I see what you mean on that now, I suspect the other things on that etherpad would be more interesting, find an sub team you are interested in, and help them out14:03
*** rlrossit has joined #openstack-nova14:03
johnthetubaguylxsli: the trivial ones have got a bit trivial to be useful, in many ways14:03
bauzasI'm not totally sold on that14:04
sdaguebauzas: done14:04
bauzasfor newcomers, it can be interesting to review a very easy patch if they take the opportunity to expand the code and read the other bits14:05
lxslijohnthetubaguy: part of that is that markus_z + I have been a bit too busy to spend much time looking for fixes14:05
lxsliThe new Gerrit will help, I need to put some time aside to fill the list back up14:05
bauzasof course, +1ing for the sake of gamifying doesn't really help yourself, but you can have good pointers for learning code14:05
*** atuvenie has quit IRC14:05
ndipanovbauzas, I disagree - we should make it possible to do actual work in Nova even if you don't spend years on it14:05
ndipanovfsck typos14:05
*** zenoway has quit IRC14:06
lxsliI was going to suggest looking for -1 and -2d reviews and reading the problems14:06
lxslithat should give some idea of the traps not to fall into and things to question while reviewing14:06
*** zenoway has joined #openstack-nova14:06
bauzasndipanov: I don't see where we disagree, my point is that people can come to Nova by reviewing easy tiny changes and leave their vote14:06
bauzasthat would help them to read some code sections14:07
dimssdague : only tests that were removed were testing the REST API that we removed (https://review.openstack.org/#/c/263368/)14:07
bauzasif the change itself isn't trivial, that's extra overhead in mind to understand14:07
sdaguedims: we didn't remove the REST API14:07
kashyapndipanov: Sorry for randomly jumping in, while at it, look at this response from Greg Kroah Hartman about new contributors and spelling fixes - https://lkml.org/lkml/2015/9/18/9414:07
*** pkholkin has joined #openstack-nova14:07
sdaguewe disabled it by default14:07
sdaguethere is a difference14:08
sdaguehmmm... wait, we did remove it?14:08
bauzaskashyap: here, I'm talking about the Trivial Bug list14:08
bauzaskashyap: not about cosmetic changes14:08
*** femnad has quit IRC14:09
bauzaskashyap: ie. there is a real bug behind the patch14:09
bauzasthat can be easily solved14:09
kashyapndipanov: But I don't disagree with your subtext of your comment though.14:09
sdaguedims: ok, so I didn't realize that ec2 was full on deleted from the tree14:09
dimssdague : https://review.openstack.org/#/c/232325/14:09
sdagueyep, I'm looking now14:09
sdagueI guess I had assumed we had just removed the paste.ini entries14:10
ndipanovwell apart from "your full of crap" I don't see how that guy disagrees with the mail he's responding to14:10
dimssdague : y we did that in liberty14:10
kashyapbauzas: Yeah, I agree that those who just go only for pimping stats ought to be ignored like the plague14:10
*** sudipto has quit IRC14:10
*** zenoway has quit IRC14:11
bauzashonestly, I don't really feel it's a problem14:11
ndipanovkashyap, my point is that we should not make typos a thing more than it should be eventually you should move on, and that's where we should focus our effort on making it easy to do meaningful work14:12
*** otter768 has joined #openstack-nova14:12
ndipanovshould be _comma_ eventually *14:12
*** dslevin_ has joined #openstack-nova14:12
bauzashere, I'm talking about the opportunity to review an easy change, not to implement it14:12
bauzasfor a newcomer14:12
*** mdrabe has joined #openstack-nova14:12
johnthetubaguysdague: I guess we did decide then14:12
kashyapndipanov: Sure, I'm with you on that, maybe I didn't fully digest your response and made a knee-jerk comment.14:13
sdaguejohnthetubaguy: ok, is nova meeting tomorrow early or late?14:13
sdagueI kind of feel like we should at least huddle up there and acknowledge this is what we are doing14:13
johnthetubaguysdague: outlook tells me early, I guess14:13
sdaguedims: mind if I wait until post nova meeting to remove my -2?14:14
sdaguejust so we're all sure on this14:14
dimssdague : no worries at all14:14
johnthetubaguysdague: lets just make sure we are all on board, thats a good plan14:14
bauzasthe ICS cal has been fixed14:14
*** kotra03 has joined #openstack-nova14:14
bauzasthat's an odd week14:14
johnthetubaguybauzas: hmm, I guess I have just been doing alternating, rather than odd vs even14:15
bauzasjohnthetubaguy: ttx told about that in -dev14:15
bauzaslemme find it14:15
johnthetubaguybauzas: yeah, I remember someone mentioning that also14:15
*** zz_dimtruck is now known as dimtruck14:15
bauzashttp://lists.openstack.org/pipermail/openstack-dev/2016-January/083216.html14:15
bauzasjohnthetubaguy: ^14:16
*** otter768 has quit IRC14:16
bauzasso it's a late nova meeting for us14:16
johnthetubaguybauzas: oh, my, OK14:18
*** dstepanenko_ has joined #openstack-nova14:18
bauzasjohnthetubaguy: we should probably publicize that, nope?14:19
*** changbl has quit IRC14:19
johnthetubaguybauzas: yeah, was just updating the wiki and sending an ML note, unless you fancy sorting that out for me?14:19
*** ducttape_ has joined #openstack-nova14:20
*** zhangjn has quit IRC14:20
bauzasyour call14:21
bauzasI mean, it's okay14:21
bauzasdoing that now14:21
*** chhavi has quit IRC14:21
*** ljxiash has joined #openstack-nova14:22
*** links has joined #openstack-nova14:22
johnthetubaguybauzas: sweet, appreciate a hand with that, I updated the wiki, but not sent the email yet14:22
bauzasack14:23
johnthetubaguybauzas: digging on the feature classification stuff right now, trying to get something more for that14:23
*** whenry has joined #openstack-nova14:23
bauzasyep14:23
*** chhavi has joined #openstack-nova14:23
*** cdlhh has joined #openstack-nova14:26
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: deprecate live/block_migration_flag opts  https://review.openstack.org/26343614:26
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: remove the live/block_migration_flag opts  https://review.openstack.org/26343714:26
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: add a new live_migration_tunneled config  https://review.openstack.org/26343414:26
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: add live_migration_extra_flags config option  https://review.openstack.org/26343514:26
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: force use of direct vs p2p migration  https://review.openstack.org/26343214:26
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: force config related migration flags  https://review.openstack.org/26343314:26
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: parse live migration flags at startup  https://review.openstack.org/26343014:26
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: force use/non-use of NON_SHARED_INC flag  https://review.openstack.org/26343114:26
cdlhhhello14:26
cdlhh我是一个新人14:27
openstackgerritAlexis Lee proposed openstack/nova: Fix advice for new contribs  https://review.openstack.org/26419514:27
*** jichen has quit IRC14:27
cdlhhhello everyone!14:27
*** ducttape_ has quit IRC14:28
*** links has quit IRC14:28
*** cdent has quit IRC14:29
*** dimtruck is now known as zz_dimtruck14:29
*** lucasagomes is now known as lucas-hungry14:30
lxslihi cdlhh14:32
cdlhhhi lxsli14:32
cdlhhwhere is from?14:32
cdlhhlxsli14:33
lxsliEngland14:33
cdlhhoh,I'm from china14:34
lxslisomething gave it away :)14:34
cdlhhcan you speak chinesse?14:35
cdlhhhaha14:35
cdlhhchinese?14:36
eliqiao你好新人 cdlhh :)14:39
*** rk4n has joined #openstack-nova14:39
cdlhh哈哈 eliqiao14:40
cdlhh你是哪里?14:40
*** mgoddard has joined #openstack-nova14:41
*** mgoddard_ has quit IRC14:41
*** smatzek has quit IRC14:42
openstackgerritAlexis Lee proposed openstack/nova: Catch errors while creating veth pair  https://review.openstack.org/26414614:42
*** pradk has joined #openstack-nova14:42
*** zenoway has joined #openstack-nova14:42
eliqiaocdlhh: am from BJ, but please talk with English for other openstacker who can not understand Chinese :)14:43
cdlhhyes thank you tip14:43
dansmithmriedem: sdague: These are rebased, feedback addressed, passing jenkins: https://review.openstack.org/#/c/247853/1814:44
dansmithjust three more to go :)14:44
mriedemok14:44
*** rushiagr_away is now known as rushiagr14:44
*** burt has joined #openstack-nova14:48
*** zenoway has quit IRC14:49
*** kotra03 has quit IRC14:50
*** ducttape_ has joined #openstack-nova14:50
*** bklei has joined #openstack-nova14:51
*** annegentle has quit IRC14:55
*** annegentle has joined #openstack-nova14:55
*** ccarmack has joined #openstack-nova14:56
*** lmtaylor has joined #openstack-nova14:58
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/nova: Replace deprecated LOG.warn with LOG.warning  https://review.openstack.org/26413314:59
*** haomaiwang has quit IRC15:01
*** 77CAAHDEK has joined #openstack-nova15:02
*** ctrath has joined #openstack-nova15:04
*** smatzek has joined #openstack-nova15:04
*** cdent has joined #openstack-nova15:07
openstackgerritNikola Dipanov proposed openstack/nova: pci: do not filter out any SRIOV Physical Functions  https://review.openstack.org/24901615:08
openstackgerritNikola Dipanov proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment  https://review.openstack.org/24901815:08
openstackgerritNikola Dipanov proposed openstack/nova: pci: adding support to specify a device_type in pci requests  https://review.openstack.org/25925415:08
openstackgerritNikola Dipanov proposed openstack/nova: objects: adding a parent_addr field to the PciDevice object  https://review.openstack.org/24901515:08
ndipanovdansmith, ^ objects data mig15:08
ndipanovwould be awesome if you could take a look pls15:08
dansmithokay15:08
openstackgerritdane-fichter proposed openstack/nova: Replaces xrange() with six.moves.range() to provide py3 compatibility  https://review.openstack.org/20530715:08
*** zenoway has joined #openstack-nova15:10
*** zz_dimtruck is now known as dimtruck15:10
edleafebauzas: I have a question from another project that wants to be able to call the scheduler's select_destinations()15:11
edleafebauzas: is RPC from an external project acceptable?15:11
dansmithedleafe: no15:11
edleafedansmith: yeah, I didn't think so either15:11
bauzaswhat dansmith said15:11
*** davideagnello has joined #openstack-nova15:12
*** annegentle has quit IRC15:12
edleafebauzas: what they really need is more like check_desination()15:12
ndipanovwhich is almost ironic seeing that our rpc versioning is far superior to our API versioning...15:12
edleafehow can an external project access the nova scheduler for stuff like that?15:12
edleafendipanov: :)15:12
ndipanovedleafe, :)15:13
bauzasedleafe: heh, you know there is a BP about that ?15:13
*** mrkz has joined #openstack-nova15:14
edleafebauzas: I know there was *talk* about that, but have no idea if it was decided15:14
bauzasedleafe: http://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/check-destination-on-migrations.html15:14
bauzaswhich is basically, get the Spec object when the migration is called, and ask the scheduler anywat15:15
bauzasanyway15:15
edleafebauzas: that doesn't add any external interface, though, right?15:15
bauzasbut for many cloudy reasons, just queying the scheduler is not good15:15
edleafebauzas: IOW, it's all internal to noca15:15
edleafenova even15:15
*** shyama has quit IRC15:15
bauzasyup15:16
alaskiedleafe: there's been talk of eventually having an HTTP interface for the scheduler, but as far as I know there's no movement on that15:16
bauzasright15:16
cdentthe boundaries between projects seems rather artificial or arbitrary15:16
edleafealaski: yeah, I haven't heard anything about that since Gantt died15:16
cdenthashtag we are all openstack, or some such15:16
*** davideagnello has quit IRC15:16
bauzasit was discussed to have a separate endpoint for calling the scheduler, but that needs a lot of discussion15:16
edleafecdent: hashtag we are all running the same queue15:17
cdenthashtag totes15:17
bauzasjust because giving a response doesn't mean you'll be able to have your instance being created on that destination15:17
*** zenoway has quit IRC15:17
edleafebauzas: sure, that's always the case15:17
bauzasit's more a capacity problem IMHO15:17
ndipanovbauzas, that logic should be part of the client lib15:17
alaskiedleafe: I still hear the idea tossed around, but not often anymore given the pressing work that's already in progress15:17
edleafebauzas: but it's more for ruling out hosts that could not accept an instance15:17
edleafebauzas: capacity??15:18
bauzasindeed15:18
bauzasI mean15:18
bauzasyou want to get a destination15:18
*** Raji_ has joined #openstack-nova15:19
bauzasit's asynchronous, which means that this destination could be fine at *this* moment, not later15:19
*** xyang2 has joined #openstack-nova15:19
openstackgerritNikola Dipanov proposed openstack/nova: neutron: pci_request logic considers 'direct-physical' vnic type  https://review.openstack.org/26258415:20
openstackgerritNikola Dipanov proposed openstack/nova: pci: Add utility method for getting the MAC addr  https://review.openstack.org/26258515:20
openstackgerritNikola Dipanov proposed openstack/nova: neutron: Update the port with a MAC address for PFs  https://review.openstack.org/26258615:20
openstackgerritNikola Dipanov proposed openstack/nova: Add a vnic type for PF passthrough and a new libvirt vif driver  https://review.openstack.org/26258315:20
edleafebauzas: oh, the optimistic stuff. I thought you were talking about the capacity of the scheduler15:20
*** kotra03 has joined #openstack-nova15:20
bauzasno, about the cloud capacity15:20
openstackgerritRyan Moore proposed openstack/nova: Add better help to rdp options  https://review.openstack.org/25355615:20
bauzasso, having a client calling the scheduler for getting a destination is exactly like the conductor doing that15:21
bauzasbut the retry logic isn't there15:21
ndipanovbauzas, it could be15:21
edleafebauzas: understood15:21
bauzasrather in the compute manager15:21
ndipanovretry logic is 2 lines of python15:21
bauzaswhich calls again the conductor is something is excepted15:21
bauzasso the conductor is dumb of the retry logic15:22
bauzasalthough it's the scheduler client15:22
edleafebauzas: so what is that status on the migration's checking the destination?15:22
edleafes/that/the15:22
*** thangp has joined #openstack-nova15:22
bauzasthere are lots of things to implement15:22
bauzasI feel it's as big as implementing the RequestSpec objectification itself15:23
bauzassome bits can also be mutualized for other reasons, mostly cells v215:23
bauzasaltough we don't care about migrating a running instance in the cells v2 world15:24
edleafebauzas: because of the persisting of the ReqSpec?15:24
bauzascorrect15:24
*** ccarmack has left #openstack-nova15:24
*** Raji_ has quit IRC15:24
*** ccarmack has joined #openstack-nova15:24
edleafebauzas: what is the status of that?15:24
bauzasthe object now has a save method15:25
bauzasthanks to alaski15:25
bauzas(and a getter)15:25
*** ssurana has joined #openstack-nova15:25
bauzasnow, we need to use those crud operators in the conductor15:25
alaskiedleafe: WIP https://review.openstack.org/#/c/258628/15:25
*** rajalakshmig has joined #openstack-nova15:25
edleafeso for new instances, the reqspec is persisted? The problem is with the existing instances?15:25
bauzaswell, C and R of course15:25
bauzasfor the moment, it isn't15:26
*** yarkot has joined #openstack-nova15:26
bauzasbut it will be15:26
edleafealaski: thanks for the link15:26
*** ccarmack has quit IRC15:26
bauzascells v2 shares the same concern15:26
*** yamahata has quit IRC15:26
*** mtanino has joined #openstack-nova15:26
bauzasbecause we need to somehow persist the request information between the cells15:26
*** ccarmack has joined #openstack-nova15:26
*** yamahata has joined #openstack-nova15:26
bauzashow we use that persisted information is where we diverge w/ cells v215:26
doffmalaski: Are we persisting the request information so that if a cell cannot handle the request it can be rescehduled to another?15:27
bauzasedleafe: but back to your original question, I know that carl_baldwin was keen to discuss on that for neutron15:28
edleafebauzas: ok, that's good info. So if an external project wants to call a migration, they can pick a host, and (eventually) the scheduler will be called to veto it if it isn't valid per the original reqspec?15:28
*** yarkot has quit IRC15:28
edleafebut for now, they have no insight into the scheduler?15:28
bauzasedleafe: I wasn't there at the last scheduler meeting because $holidays but I know that's something he wanted to discuss during the midcycle and johnthetubaguy told about a backlog spec15:29
* carl_baldwin reading back...15:29
alaskidoffm: not exactly.  cells doesn't specifically need the request spec persisted, what it needs is enough of the instance info persisted to be able to hydrate an instance object before data has been written to the instance table15:29
bauzasedleafe: that workflow hasn't yet been agreed15:29
bauzasneither discssed :)15:29
edleafebauzas: ack15:29
*** breitz has quit IRC15:30
alaskidoffm: because the instance won't be written to an instance table until it has been scheduled to a cell.  but the API needs to return a response before that, so we shove the data into the request spec15:30
*** breitz has joined #openstack-nova15:30
bauzasand that's why we have a purgatory cell :p15:30
alaskidoffm: and a list/show will hydrate an instance from the req spec, and another object/table called buildrequest15:30
mriedemdansmith: in https://review.openstack.org/#/c/247853/18/nova/virt/xenapi/vmops.py - i didn't think x in obj worked if obj didn't have the dict compat mixin15:30
dansmithmriedem: we moved it in nova to our base, right?15:31
mriedemdik15:32
mriedem*idk15:32
mriedemlooking15:32
dansmithI thought we did to bridge the gap to o.vo having it15:32
dansmithit's not in there anymore,15:32
dansmithand your __contains__ merged to o.vo 3 months ago,15:32
dansmithso I think we have it now15:33
mriedemnope https://github.com/openstack/nova/blob/master/nova/objects/base.py#L6115:33
*** lucas-hungry is now known as lucasagomes15:33
dansmithright ^15:33
dansmithmriedem: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L31615:34
*** whenry has quit IRC15:34
dansmithmriedem: and in 0.13: https://github.com/openstack/oslo.versionedobjects/blob/0.13.0/oslo_versionedobjects/base.py15:34
dansmithwhich is in our requirements15:34
doffmalaski: Got it. Thanks.15:34
mriedemdansmith: ahhhh15:34
* mriedem thanks past version of myself for doing that15:34
doffmUsing the request spec like a 'pre instance' table.15:35
*** dougs has quit IRC15:35
*** cfriesen__ has quit IRC15:35
alaskidoffm: exactly15:35
*** annegentle has joined #openstack-nova15:36
ndipanovdansmith, is there an easy way to access service version data15:38
ndipanovdansmith, it's a single db call right?15:39
mriedemdansmith: ok, +2 now15:39
dansmithndipanov: it is.. I have a method for getting the computes15:39
ndipanovbut I need others15:39
dansmithI know, turns out I'm smarter than I remember:15:39
dansmithndipanov: https://github.com/openstack/nova/blob/master/nova/objects/service.py#L28315:40
*** Sukhdev has joined #openstack-nova15:40
*** dougs has joined #openstack-nova15:40
*** tonytan4ever has joined #openstack-nova15:40
ndipanovdansmith, nice - how do I know which version of the object this relates to?15:40
mriedemhttps://github.com/openstack/nova/blob/master/nova/objects/service.py#L8715:43
*** _diana_1 has joined #openstack-nova15:43
dansmithit's not the object version, but that global counter15:43
dansmithso you can just define the version in the history and then check to see that we're >= that15:43
ndipanovdansmith, but that means nothing to me when deciding whether to migrate data or not15:43
ndipanovdansmith, ok that makes sens15:43
ndipanove15:43
ndipanovI think...15:44
dansmithyou can either add the pci device version to the things that are considered, or not15:45
dansmitheven just adding another entry to that list with the same compute rpc version will give you the sentinel you need15:45
dansmithi.e.:15:45
dansmith# Version 5: Online migration of parent_addr in PciDevice15:46
dansmith{'compute_rpc': $same_as_before}15:46
openstackgerritAndrew Laski proposed openstack/nova: Clean up filter_properties/availability_zone in boot  https://review.openstack.org/25443415:46
dansmiththen only do your migration if the minimum service version for conductor and api is >= 515:47
ndipanovdansmith, got it15:47
wznoinskclaudiub, are you around?15:47
claudiubwznoinsk: hello15:48
dansmithndipanov: and I already have a patch up that claims version 4, so hopefully that can get in the queue soon so we're not competing for it15:48
*** zenoway has joined #openstack-nova15:48
*** _diana_1 has quit IRC15:48
*** devananda has quit IRC15:48
*** mragupat has joined #openstack-nova15:48
dansmithi.e. this one: https://review.openstack.org/#/c/251588/1915:48
wznoinskclaudiub, wanted to check what's the story with instance live resize, I'm trying to get the gerrit code working at the moment to do some libvirt virt driver tests but I wanted to check is it under RFE or N?15:49
*** klkumar has quit IRC15:50
openstackgerritdane-fichter proposed openstack/nova: Add image signature verification  https://review.openstack.org/18984315:51
* wznoinsk hopes it's still on the table15:51
*** klkumar has joined #openstack-nova15:51
mriedemvponomaryov: i don't see anything in the cinder change history around 1/3 that looks related to the volume attach/detach issues you're seeing15:52
claudiubwznoinsk: eehh... it is unfortunate, even if it has 2x +2s and 11x +1, it wasn't approved. :( johnthetubaguy said that it's going to get approved for N though.15:52
vponomaryovmriedem: right, code and packages are the same15:52
vponomaryovmriedem: python and system packages are completely the same15:52
*** zenoway has quit IRC15:53
claudiubwznoinsk: as for the code, pretty much all of it should be there. ofc, it needs rebase, as the microversion version has changed since then, but last time I did nova live-resize <server> <new-flavor-id>, it was working, up to the driver's live_resize call.15:54
claudiubwznoinsk: do you have any issues?15:54
vponomaryovmriedem: I think would be useful to send commit with creation of only one Vm and attach of one volume and see its timings15:55
wznoinskclaudiub, I didn't see libvirt implementation, checking again15:55
claudiubwznoinsk: libvirt implementation wasn't added, afaik.15:55
vponomaryovmriedem: to get to know weak point15:55
wznoinskclaudiub, getting endpoint not supporthing the method but it maybe my merging of the code15:55
wznoinskclaudiub, ok so for libvirt there's still some work I suppose15:55
mriedemvponomaryov: there are several tempest tests that attach a single volume to an instance in the normal tempest full job, we should be able to figure that out15:55
*** cdlhh has quit IRC15:56
mriedemvponomaryov: like http://logs.openstack.org/85/263385/1/check/gate-tempest-dsvm-full/e2f519a/console.html#_2016-01-04_22_08_21_522 here15:56
claudiubwznoinsk: makes sense, IMO, the python-novaclient microversion version is behind. it is still 2.13, it should be 2.1515:57
vponomaryovmriedem: 1.5 sec? ))15:57
claudiubwznoinsk: in this patch: https://review.openstack.org/#/c/248611/415:57
*** shyama has joined #openstack-nova15:57
vponomaryovmriedem: looks like main time were spent in "setup_resource" method15:57
*** mragupat has quit IRC15:58
*** krtaylor has quit IRC15:58
*** mragupat has joined #openstack-nova15:58
wznoinskclaudiub, I went away with curl POST and it was fine: curl -i -X POST -H "Content-Type: application/json" -H "X-OpenStack-Nova-API-Version: 2.15" -H "X-Auth-Token:fc323d6cb2d040fbb845273d9a5ff3b1" -d '{"live-resize": {"flavorRef": "3"}}'  http://127.0.0.1:8774/v2.1/0bf245bfd4da437d92ba2b58fb9a7d8f/servers/9093e818-5a41-4e1a-a9d6-71e883990bb2/action15:59
wznoinskneeded to incloude the header for the proper api version15:59
vponomaryovmriedem: and big difference, this test uses explciit device path15:59
*** _diana_1 has joined #openstack-nova15:59
vponomaryovmriedem: that could be the reason15:59
wznoinskclaudiub, I'm not sure whether not using the pythonclient is maybe the cause of my further problems (but unlikely)15:59
mriedemvponomaryov: yeah most of the tempest tests pass in a device name on attach/boot from volume16:00
cdentrlrossit: thanks for the review, I've responded, hoping you've got an example for the right way to do versioned objects backed by the api database, I was just following what I could find16:00
mriedemvponomaryov: however, with the libvirt driver in nova, the device name passed in is ignored anyway16:00
claudiubwznoinsk: yeah. you need the python-novaclient patch, which itself is out of date, and it sends 2.13 as the nova-api version. :)16:00
vponomaryovmriedem: then, problem is in other things, not "attach/detach"16:00
*** 77CAAHDEK has quit IRC16:01
*** devananda has joined #openstack-nova16:01
*** haomaiwang has joined #openstack-nova16:01
*** rushiagr is now known as rushiagr_away16:01
claudiubwznoinsk: anyways, I'll have to rebase everything once the spec is approved. Until then, the microversion version will keep changing, so rebasing over and over again is pointless. :)16:01
*** bklei has quit IRC16:03
wznoinskclaudiub, sure, understood16:03
*** artom has joined #openstack-nova16:03
*** unicell has joined #openstack-nova16:06
*** haomaiwang has quit IRC16:07
*** unicell1 has quit IRC16:08
*** zenoway has joined #openstack-nova16:08
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/nova: Keep py3.X compatibility for urllib  https://review.openstack.org/26103416:08
*** sahid has quit IRC16:09
*** krtaylor has joined #openstack-nova16:10
*** salv-orlando has joined #openstack-nova16:12
*** davideagnello has joined #openstack-nova16:12
*** otter768 has joined #openstack-nova16:12
openstackgerritStephen Finucane proposed openstack/nova: test_fields: Remove all 'Enum' subclass tests  https://review.openstack.org/24437216:13
*** zenoway has quit IRC16:13
*** zenoway has joined #openstack-nova16:14
*** davideagnello has quit IRC16:14
*** davideagnello has joined #openstack-nova16:14
openstackgerritStephen Finucane proposed openstack/nova: tests_fields: Remove most enum-type field tests  https://review.openstack.org/24437016:15
openstackgerritArtom Lifshitz proposed openstack/nova: Move config options from nova/api directory  https://review.openstack.org/25818016:15
openstackgerritArtom Lifshitz proposed openstack/nova: Better document the osapi_max_limit config option  https://review.openstack.org/23321216:15
artomAh crap, that didn't do what I wanted :(16:15
*** lyanchih has quit IRC16:16
artomI mean, sort of, but I just barged into edleafe's work - while all I wanted to do was depend on it.16:17
*** otter768 has quit IRC16:17
*** belmoreira has quit IRC16:18
artomedleafe, I accidentally uploaded a patch to your move config options review here: https://review.openstack.org/#/c/258180/16:19
edleafeartom: no worries - I've done that myself16:20
artomedleafe, so how do we fix this? You just re-submit a new (unchanged) patchset yourself?16:20
edleafeartom: let me look over the changes.16:21
edleafeartom: did you modify https://review.openstack.org/#/c/258180 at all?16:21
artomedleafe, I think I did - but I had no intention to16:21
artomMy purpose was to rebase by patch on top of yours and submit.16:21
openstackgerritStephen Finucane proposed openstack/nova: config options: Make xvp proxy into vnc group  https://review.openstack.org/23539816:22
artomI think I failed the rebase and introduced changes to your patch.16:22
edleafeartom: ah, you probably rebased and then modified the branch16:22
edleafeartom: yep16:22
edleafelet me push a refresh16:22
artomSo we should pretend patchset 6 never existed ;)16:22
*** ctrath has quit IRC16:23
edleafeartom: sweep it under the rug, so to speak :)16:24
artomedleafe, you missed the chance to make a 'turn a new leaf' pun :)16:24
*** zenoway has quit IRC16:25
*** zenoway has joined #openstack-nova16:25
edleafeartom: I've made a ton of those in my life. Now leaf me alone.16:25
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory  https://review.openstack.org/25818016:26
*** yarkot has joined #openstack-nova16:26
edleafeartom: ok, should be reverted now16:27
artomedleafe, awesome. Sorry for the trouble.16:27
*** blaisebool has joined #openstack-nova16:28
edleafeartom: heh, it happens16:28
*** zenoway has quit IRC16:30
*** wznoinsk has quit IRC16:31
*** wznoinsk has joined #openstack-nova16:32
*** mdrabe has quit IRC16:32
*** matrohon has quit IRC16:33
*** cgascoig has quit IRC16:33
*** cgascoig_ has joined #openstack-nova16:34
*** cgascoig_ is now known as cgascoig16:34
*** dslevin_ has quit IRC16:34
*** kylek3h_ has joined #openstack-nova16:37
*** kylek3h has quit IRC16:37
*** davideagnello has quit IRC16:39
*** sacharya has joined #openstack-nova16:41
*** kotra03 has quit IRC16:41
*** vishwanathj has quit IRC16:42
*** armax has joined #openstack-nova16:42
*** dslevin_ has joined #openstack-nova16:44
*** mgoddard_ has joined #openstack-nova16:45
mriedemvponomaryov: does it seem odd that the failure only happens on 2 manila changes in the check queue?16:45
*** rfolco has quit IRC16:45
vponomaryovmriedem: tempest broke us too16:45
vponomaryovmriedem: ))16:45
vponomaryovmriedem: https://bugs.launchpad.net/designate/+bug/153104916:46
openstackLaunchpad bug 1531049 in Manila "Devstack stop supporting Tempest deprecated cred options" [Critical,In progress] - Assigned to Valeriy Ponomaryov (vponomaryov)16:46
*** gjayavelu has joined #openstack-nova16:46
vponomaryovmriedem: so, those two have workaround16:46
mriedemoh right https://review.openstack.org/#/c/263664/16:46
mriedemand those fail b/c of the timeout16:46
vponomaryovmriedem: right16:47
*** gjayavel_ has joined #openstack-nova16:47
*** chhavi has quit IRC16:47
*** zakora has quit IRC16:48
*** mgoddard has quit IRC16:48
*** jwcroppe has quit IRC16:48
mriedemvponomaryov: so, i'm wondering if the tempest creds thing is the cause - are the tests all running under the same tenant?16:48
*** dslevin_ has quit IRC16:49
*** rfolco has joined #openstack-nova16:49
vponomaryovmriedem: manila requires preconfigured tenant/user16:49
vponomaryovmriedem: because creates VM in Nova for shares16:49
vponomaryovmriedem: and if start use new creds16:50
vponomaryovmriedem: we will create huge amount of redundant resources16:50
*** mdrabe has joined #openstack-nova16:50
vponomaryovmriedem: we without it excceed job timeouts on OVH nodes16:50
*** ctrath has joined #openstack-nova16:50
*** _diana_1 has quit IRC16:50
vponomaryovmriedem: in 50 % cases16:50
openstackgerritPawel Koniszewski proposed openstack/nova: Add way to pause VM during live migration  https://review.openstack.org/24592116:50
openstackgerritPawel Koniszewski proposed openstack/nova: Add new DB API method to retrieve migration for instance  https://review.openstack.org/25727016:50
mriedemw/o preconfigured credentials you timeout on the ovh nodes?16:51
*** gjayavelu has quit IRC16:51
*** _diana_1 has joined #openstack-nova16:51
vponomaryovmriedem: I suspect, we will on all16:51
vponomaryovmriedem: with preconfigured only on OVH16:51
vponomaryovmriedem: sometimes on HP nodes16:51
*** erlon has joined #openstack-nova16:51
*** whenry has joined #openstack-nova16:51
vponomaryovmriedem: on those nodes, where devstack installation takes more than 40 minutes16:52
vponomaryovmriedem: RAX nodes take about 2516:52
*** ijw_ has quit IRC16:52
bauzasshould we call pilgrimstack ?16:54
mriedemmtreinish: so if https://bugs.launchpad.net/bugs/1524717 is a critical bug that's not fixed and is breaking a bunch of gate jobs per https://bugs.launchpad.net/designate/+bug/1531049 shouldn't we temporarily revert https://review.openstack.org/#/c/256164/ ?16:54
openstackLaunchpad bug 1524717 in tempest "ObjectACL tempest tests are flaky with preprov creds" [Critical,Confirmed] - Assigned to Andrea Frittoli (andrea-frittoli)16:54
openstackLaunchpad bug 1531049 in Manila "Devstack stop supporting Tempest deprecated cred options" [Critical,In progress] - Assigned to Valeriy Ponomaryov (vponomaryov)16:54
vponomaryovmriedem: according to bug https://bugs.launchpad.net/bugs/1524717 all devstack plugin for manila backends are affected too - all third-party CIs16:55
vponomaryovmriedem: in summary, more than 10 repos require urgent fix16:55
mtreinishmriedem: I don't think it's critical, and it shouldn't block anyone for that second bug16:56
mtreinishit's only a scheduling issue when running in parallel16:56
mtreinishif projects were only working using hard coded config credentials then they should only be running serially anyway16:56
openstackgerritChuck Carmack proposed openstack/nova: config options: centralize 'spice' options  https://review.openstack.org/26427116:56
mtreinishand they couldn't have specified specific roles which is where that's coming up16:57
*** garyk has quit IRC16:57
mriedemvponomaryov: are the manila tests run in serial or parallel?16:57
vponomaryovmtreinish: now it is impossible to use preconfigured creds in latest tempest and devstack16:57
vponomaryovmriedem: parallel16:57
*** salv-orlando has quit IRC16:57
mriedemvponomaryov: that's dangerous16:58
mriedemthat's why we have tenant isolation in the gate16:58
mriedemfor running in parallel16:58
mtreinishvponomaryov: umm, it always was. Using the legacy credential options from the config file precludes running in parallel16:58
mriedemotherwise you can hit over quota type issues16:58
mtreinishlike mriedem said16:58
*** salv-orlando has joined #openstack-nova16:58
mtreinishthe test accounts file enables running in parallel with multiple prevprovisioned accounts16:58
mtreinishbut you don't have to run in parallel with it16:59
vponomaryovmriedem, mtreinish: we handle quotas not excceed them16:59
vponomaryovs/excceed/exceeding/16:59
vponomaryovmriedem, mtreinish: so, quotas is out of issues16:59
mriedemwell quotas is only one thing17:00
mriedemthere are also physical resources on the test node17:00
mriedemi'm not sure how you're handling quotas17:00
vponomaryovthin provisioned LVM volumes17:00
vponomaryov4mb each17:00
mtreinishmriedem: the issue here is there were a number of projects that didn't understand how the plugins where using credential information and were relying on something they shouldnt have been17:00
*** chhavi has joined #openstack-nova17:00
*** dslevin_ has joined #openstack-nova17:00
mtreinishthey either need to migrate to the abstract credential provider that tempest is using17:00
*** whenry has quit IRC17:00
mtreinishor in the case of projects that have weird requirements (which don't make sense to me) they should assert control over their own configuration17:01
*** zenoway has joined #openstack-nova17:01
alaskinova cells meeting in #openstack-meeting-317:01
*** moshele has quit IRC17:01
*** Sukhdev has quit IRC17:01
mtreinishmriedem: what I'd really like to see is for someone to step up and help andreaf migrate the credential providers to tempest-lib which has been moving very slowly17:02
mriedemok, i'm in the cells meeting now,17:02
vponomaryovmtreinish: we are ok with any approach for having "single" set of tenant/user17:02
mriedemi guess i don't understand the manila requirements or the tempest config issues,17:02
mriedembut i'm trying to figure out how much i need to investigate the actual nova failures that manila is hitting, or if their config is invalid somehow17:02
mriedembut the only thing i can think that caused their failures since 1/3 is removing those deprecation options17:03
vponomaryovmriedem: options removed 24 hours after it17:03
vponomaryovmriedem:no relation17:03
vponomaryovmriedem:100% for sure17:03
vponomaryovmriedem: tempest and nova problems are not related17:04
mriedemvponomaryov: there were no changes in nova on 1/3 that i can see that would be related to what you're seeing17:04
*** rajalakshmig has quit IRC17:04
vponomaryovmriedem: tempest/devstack change was merged on 1/4 4PM17:04
*** shyama has quit IRC17:04
mtreinishvponomaryov: for executing serially you should be fine with 1 set of credentials17:04
*** mgoddard_ has quit IRC17:05
*** mgoddard has joined #openstack-nova17:05
mtreinishbut running parallely with a single set of creds breaks underlying assumptions in the provider mechanisms17:05
vponomaryovmtreinish: serially not suitable because of time reasons17:05
mriedemyeah i guess historically when we ran tempest internally with a hard-coded set of tenant creds, we couldn't run concurrently17:05
*** zenoway has quit IRC17:05
*** jlanoux has quit IRC17:05
vponomaryovmtreinish: if so, then I can say that creds provider is not flexible enough17:06
mtreinishvponomaryov: well the internal assumption of tempest is one set of creds for each test class17:06
mtreinishthat's always been the case because tempest needs to provide isolation between each class17:06
mtreinishit's not a matter of flexibility17:06
*** yassine has quit IRC17:06
vponomaryovmtreinish: we separate tests by classes not because of creds, but functionality17:07
vponomaryovmtreinish: so, should be mechanism to use same creds for several classes then17:07
vponomaryovmtreinish: and completely no problems about usage of same creds17:08
vponomaryovmtreinish: in our case17:08
mtreinishvponomaryov: there isn't and can't be for tempest proper, because it doesn't work in parallel17:08
mtreinishvponomaryov: there's nothing stopping you from just owning your own configuration for whatever weird use case you think you need17:08
*** tongli has joined #openstack-nova17:09
vponomaryovmtreinish: it does not work in parallel because it is done so or fails?17:10
mtreinishtempest will not work if you try to run the tests in parallel with the same credentials17:11
openstackgerritdane-fichter proposed openstack/nova: Add image signature verification  https://review.openstack.org/18984317:11
mtreinishthe tests would walk all over each other and things will fail randomly17:11
vponomaryovmtreinish: manila runs tests in parallel for long time and tests designed to be aware about concurrent things17:12
vponomaryovmtreinish: so, it is strange to me to hear that it does nor work17:12
vponomaryovmtreinish: then, maybe, tests designed worse than it could be if that happens17:13
mtreinishvponomaryov: that's not how tempest is designed. The assumption provided by tempest is each class will be provided an isolated set of credentials17:13
mtreinishit's a design point going back a long time17:13
vponomaryovmtreinish: and reason is in "potential interfere by tests"?17:14
*** ctrath1 has joined #openstack-nova17:14
*** gjayavel_ has quit IRC17:15
*** jgriffith is now known as jgriffith_away17:15
vponomaryovI mean "mutual interference"17:15
*** ctrath has quit IRC17:17
openstackgerritRushi Agrawal proposed openstack/nova: Remove mox and Stubs from tests/unit/pci/test_manager.py  https://review.openstack.org/26336217:18
rlrossitcdent: you have uncovered a rabbit hole I never knew existed with this api database stuff...17:19
cdentimpressive isn't it?17:19
*** salv-orlando has quit IRC17:19
*** rk4n has quit IRC17:20
*** salv-orlando has joined #openstack-nova17:20
rlrossitcdent: so now I understand that you're doing things the same way as everyone else, but now I don't get why everyone else is doing it this way17:20
rlrossitall of those sqlalchemy queries could very easily live in nova.db.sqlalchemy instead of nova.objects17:21
cdentthe stuff in nova/db/api is configured for only one database17:21
cdentso I guess people are working around that17:21
cdentI agree that it is a strange way to go17:21
* rlrossit hates databases, but is glad ORMs exist at least17:22
artomSo... how *do* I submit a patch for review that depends on someone else's patch in review?17:22
* edleafe feels exactly the opposit of rlrossit 17:22
artomWithout submitting a new patchset in their review as wlel?17:22
*** ljxiash has quit IRC17:22
rlrossitedleafe: let's agree to disagree ;)17:22
*** ljxiash has joined #openstack-nova17:23
*** renatoarmani has quit IRC17:23
edleaferlrossit: too many years of being a DBA to ever like working with ORMs :)17:23
edleafeartom: 1) grab the ps from gerrit with git review -d NNNNNN17:23
edleafe2) run 'git co -b my_dependent_branch'17:23
*** acabot has joined #openstack-nova17:24
dansmithrlrossit: we said that for the api database stuff, we were going to do the DB bits in the objects directly and avoid the multiple levels of indirection to a single implementation17:24
edleafe3) do all your changes in that branch17:24
ndipanovartom, rebase on the patch you want17:24
*** nic has joined #openstack-nova17:24
ndipanovand then instead of doing git review17:24
ndipanovdo: git push gerrit HEAD:refs/for/master17:24
edleafe4) push changes with 'git review -y'. Unless you changed anything in the original patch, it should be good.17:24
*** sfinucan has quit IRC17:24
edleafeartom: or you could follow ndipanov's method17:25
dansmithedleafe: it'll still try to rebase the whole set on master unless you use -R I think17:25
artomedleafe, ndipanov's way makes more sense to my brain, sorry :)17:25
rlrossitdansmith: totally devil's advocate but... isn't all of nova already doing that anyways with only having sqlalchemy?17:25
edleafedansmith: oops, forgot the rebase step17:26
ndipanovedleafe, no I think it will still create a new PS in that casae...17:26
dansmithndipanov: it won't if it doesn't rebase17:26
edleafe2a) git rebase -i original_branch17:26
dansmithrlrossit: yes, but we have two layers of indirection required for any new call for no real abstraction reason17:26
*** garyk has joined #openstack-nova17:27
rlrossitdansmith: wait maybe I was not saying things right then... I was thinking it live in nova.db.sqlalchemy.api (not nova.db.api) to at least put all of the queries in one place17:29
artomndipanov, wait, when you write refs/for/master...?17:30
dansmithrlrossit: yeah, and we could (continue to) do that17:30
dansmithrlrossit: it's just that when we set off down the api database path, we didn't see the reason for it, and decided that we'd start putting things directly in the object layer to avoid all the extra hoops17:30
*** jgriffith_away is now known as jgriffith17:30
dansmithrlrossit: I'm not sure that having all the queries in one place really helps anything, and definitely makes it harder to optimize some things17:30
*** e0ne has quit IRC17:32
rlrossitdansmith: well, at least I understand the reasoning for it now. Initially I was super confused to see this stuff living in the objects17:32
cdentrlrossit, dansmith: I rather like having it in the object itself17:32
dansmithI have to run to a meeting, back in a bit17:32
cdentIt makes the objects...uh... feel more real17:33
rlrossithey17:33
rlrossitobjects are real :(17:33
rlrossitat least I think they are...17:33
cdentI just mean in the sense of the the VersionedObjects managing their own persistence17:34
rlrossiteh, I wonder if they should actually handle their persistence, or just let the DB handle those operations17:35
*** renatoarmani has joined #openstack-nova17:35
rlrossiteither way, it's just a "where do I want the code to live" decision17:36
* cdent nods17:36
*** unicell has quit IRC17:36
cdentI think if there wasn't already a precedent I'd put the query code elsewhere17:36
cdentbut it doesn't bother me too much17:36
rlrossitand I suppose if everyone else has it live in the object, might as well leave it consistent with what's there17:36
rlrossitif I want it to change, making you do it in your patch is the wrong place to make that request17:37
* cdent nods17:37
cdentI think it is definitely worth discussion. You going to the mid-cycle?17:37
rlrossitcdent: no :(. mriedem and doffm already took our spots17:37
* cdent shakes his tiny fist17:38
*** ctrath1 has quit IRC17:40
vponomaryovmtreinish, mriedem: "The assumption provided by tempest is each class will be provided an isolated set of credentials" - my answer is "The assumption provided by Manila is each class should not be dependent on creds at all.". About "serial/parallel" thing, even if we run tests serially, we can not use same creds for each class anymore. But exactly this is the USE CASE of Manila project. So, Manila is doomed to workaround tempest design, becau17:41
*** yamahata has quit IRC17:42
rlrossitdansmith: I'm curious what "makes it harder to optimize things" means though. From how I see things it's either the code is in nova.objects or the code is in nova.db.sqlalchemy.api. Unless there's some dynamic mumbo jumbo going on in the nova.db.sqlalchemy package17:42
*** blaisebool has quit IRC17:42
rlrossit(but I'm about to run off to lunch, so we probably can't continue this discussion until I'm back)17:43
*** rotbeard has quit IRC17:44
*** jistr has quit IRC17:45
dansmithrlrossit: just things like we end up re-using some query because it's there when really we could have tweaked one thing about it if we had access to the sqlalchemy query object17:45
openstackgerritHarshada Mangesh Kakad proposed openstack/nova: Replace deprecated library function os.popen() with subprocess  https://review.openstack.org/26257017:45
dansmithrlrossit: for extreme cases, we add a new flag parameter or something to control that behavior17:45
*** ctrath has joined #openstack-nova17:45
*** chhavi has quit IRC17:46
dansmithrlrossit: but it just expands the number of things we have to do in order to effect that optimization so I expect it doesn't happen as often as possible17:46
*** jwcroppe has joined #openstack-nova17:48
rlrossitdansmith: oh so you were talking about optimizations within sqlalchemy?17:48
dansmithrlrossit: not within, but with how we call it17:48
*** gjayavelu has joined #openstack-nova17:48
*** Jeffrey4l has quit IRC17:49
*** RichardRaseley has joined #openstack-nova17:50
*** klkumar has quit IRC17:51
*** renatoarmani has quit IRC17:51
*** renatoarmani has joined #openstack-nova17:53
*** BobBall is now known as BobBall_AWOL17:55
*** nic1 has joined #openstack-nova17:55
*** nic has quit IRC17:56
*** cfriesen__ has joined #openstack-nova17:58
*** derekh has quit IRC17:59
*** suro-patz has joined #openstack-nova18:03
*** hemna is now known as hemnafk18:04
*** yamahata has joined #openstack-nova18:05
*** moshele has joined #openstack-nova18:05
openstackgerritNikola Dipanov proposed openstack/nova: pci: do not filter out any SRIOV Physical Functions  https://review.openstack.org/24901618:07
openstackgerritNikola Dipanov proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment  https://review.openstack.org/24901818:07
openstackgerritNikola Dipanov proposed openstack/nova: pci: adding support to specify a device_type in pci requests  https://review.openstack.org/25925418:07
openstackgerritNikola Dipanov proposed openstack/nova: objects: adding a parent_addr field to the PciDevice object  https://review.openstack.org/24901518:07
*** xyang2 has quit IRC18:07
*** lihg has joined #openstack-nova18:08
*** salv-orlando has quit IRC18:08
*** salv-orlando has joined #openstack-nova18:09
openstackgerritRushi Agrawal proposed openstack/nova: [WIP]Remove mox completely from nova/tests/unit/objects/test_instance.py  https://review.openstack.org/26429218:09
*** ctrath has quit IRC18:10
*** unicell has joined #openstack-nova18:10
ndipanovdansmith, I updated that patch18:12
ndipanovsee if you like it18:12
*** gjayavelu has quit IRC18:13
*** lihg_ has joined #openstack-nova18:13
*** otter768 has joined #openstack-nova18:13
*** dslevin_ has quit IRC18:14
dansmithndipanov: yeah, looking18:17
*** otter768 has quit IRC18:18
*** zenoway has joined #openstack-nova18:19
*** ctrath has joined #openstack-nova18:20
dansmithndipanov: I think you still have an issue18:20
dansmithndipanov: it bit me hard with the flavor stuff, probably not technically an issue for pci stuff because I think that addr probably can't change (or doesn't in practice)18:20
dansmithbut ignoring that case because we don't think it'll happen is likely to be a bad move I think18:21
*** abhishekk has joined #openstack-nova18:21
ndipanovdansmith, let me re-read that18:21
ndipanovdansmith, it could change...18:22
abhishekkjohnthetubaguy: hi john, could you please reply your opinion about comment in review https://review.openstack.org/#/c/163798/?18:22
*** dslevin_ has joined #openstack-nova18:22
ndipanovfrom None to something18:22
dansmithah, then... we better handle it18:22
abhishekkjohnthetubaguy: thank you18:23
*** PsionTheory has joined #openstack-nova18:24
*** nelsnelson has quit IRC18:24
*** nelsnels_ has joined #openstack-nova18:24
johnthetubaguyabhishekk: looking18:25
abhishekkjohnthetubaguy: thank you18:26
*** rdo has quit IRC18:26
openstackgerritDiana Clarke proposed openstack/nova: Replace stubs.Set with stub_out  https://review.openstack.org/26429718:26
*** pratikmallya has joined #openstack-nova18:26
johnthetubaguyabhishekk: sorry, I don't really understand your comment/question in the review18:27
*** rdo has joined #openstack-nova18:28
*** renatoarmani has quit IRC18:28
johnthetubaguyabhishekk: which of my comments were you asking about?18:28
abhishekkcomment on ps 10 asked by rajesh18:29
abhishekkallow force delete only when the task state is in "deleting" status?18:29
*** _diana_1 has quit IRC18:31
johnthetubaguyabhishekk: the code in there makes sure if a user calls delete multiple times, we quickly reject the request, so its not a Denial of service vector, my comments on that patchset were basically saying, the current force-delete idea seems to re-introduce that. We should probably only allow one force delete call, after the initial delete, maybe? although that seems a bit odd.18:31
*** _diana_1 has joined #openstack-nova18:32
lihghello! Can anybody help me? I have a question about virtual box18:32
lihghow to use virtual box as hypervisor in nova?18:32
abhishekkjohnthetubaguy: right18:32
*** zenoway has quit IRC18:33
*** ctrath has quit IRC18:34
abhishekkbut as per Oct 6 2:18 PM comment, one scenario is still not handled18:34
abhishekkjohnthetubaguy: "When user sends force-delete request for first time for instance deletion, its task_state gets changed to 'force-deleting'. Now since the instance task_state is already in 'force-deleting' state and if at that moment rabbitmq-server get crashed by some reasons, then the instance task_state remain 'force-deleting' forever and instance will not be deleted."18:35
*** _diana_1 has quit IRC18:35
*** nelsnels_ has quit IRC18:35
*** nelsnelson has joined #openstack-nova18:35
*** READ10 has joined #openstack-nova18:35
johnthetubaguyabhishekk: its a trade off, yes18:35
abhishekkto overcome this only way is allow force delete only when the task state is in "deleting" status18:36
abhishekkwhat do you suggest18:36
*** _diana_1 has joined #openstack-nova18:39
johnthetubaguyabhishekk: You could maybe allow admins to do unlimited force deletes, but its not something you want want to give to all users. But I feel like its getting very complicated at that point.18:41
abhishekkjohnthetubaguy18:41
abhishekkyes, you are right,should I abondened this patch as it is not satsisfying the need?18:42
*** e0ne has joined #openstack-nova18:44
johnthetubaguyabhishekk: so I think there is a need, but its very much an edge case. Reset-state for the admin can help in many of the real world cases.18:44
*** vilobhmm11 has joined #openstack-nova18:44
*** READ10 has quit IRC18:45
*** zenoway has joined #openstack-nova18:45
openstackgerritTracy Jones proposed openstack/nova: config options: centralize section "volume"  https://review.openstack.org/25374718:45
*** armax has quit IRC18:46
*** jichen has joined #openstack-nova18:46
abhishekkjohnthetubaguy: ok, you mean to say admin can reset the state in this case, right?18:47
johnthetubaguyabhishekk: yes, I know that means the end user can't fix it themselves, but thats kinda on purpose to prevent denial of service attacks, if my memory is correct18:47
abhishekkjohnthetubaguy: ok, I will have internal discussion on your suggestion and will ping you back on this18:49
*** zenoway has quit IRC18:49
*** paul-carlton2 has quit IRC18:50
abhishekkjohnthetubaguy: thank you for your time18:50
*** fawadkhaliq has quit IRC18:50
*** ctrath has joined #openstack-nova18:51
*** hemnafk is now known as hemna18:51
*** ijw has joined #openstack-nova18:51
johnthetubaguyabhishekk: happy to help18:51
*** krtaylor has quit IRC18:53
*** gjayavelu has joined #openstack-nova18:54
*** alejandrito has joined #openstack-nova18:56
*** browne has joined #openstack-nova18:57
openstackgerritLiuNanke proposed openstack/python-novaclient: Replace assertTrue(isinstance()) by optimal assert  https://review.openstack.org/26430818:58
*** abhishekk has quit IRC19:00
*** rlrossit has quit IRC19:01
*** andreykurilin__ has quit IRC19:02
*** paul-carlton2 has joined #openstack-nova19:03
*** tonytan4ever has quit IRC19:04
*** fawadkhaliq has joined #openstack-nova19:06
*** krtaylor has joined #openstack-nova19:07
*** whenry has joined #openstack-nova19:07
*** xyang2 has joined #openstack-nova19:08
*** rlrossit has joined #openstack-nova19:08
*** cfriesen__ has quit IRC19:12
*** fawadkhaliq has quit IRC19:13
*** edmondsw has quit IRC19:14
*** tonytan4ever has joined #openstack-nova19:15
ccarmackalaski: I had a question related to https://review.openstack.org/#/c/225199/ ... in cells v1, are neutron provided security groups *not supported, same as n-net provided security groups?19:15
dansmithccarmack: I think so19:16
*** renatoarmani has joined #openstack-nova19:17
dansmithccarmack: nova/compute/cells_api.py doesn't have a SecurityGroupAPI19:17
*** edmondsw has joined #openstack-nova19:17
*** paul-carlton2 has quit IRC19:17
dansmithccarmack: and if you used the one from api.py it wouldn't know how to contact the hosts, AFAIK19:17
*** harlowja_ has quit IRC19:18
*** cfriesen__ has joined #openstack-nova19:18
*** harlowja has joined #openstack-nova19:19
ccarmackdansmith: ok, thanks, I'll answer the comments that way19:19
*** zenoway has joined #openstack-nova19:21
*** lpetrut has quit IRC19:25
*** zenoway has quit IRC19:25
alaskiccarmack: dansmith that's correct.  the issue with cells and security groups is the security group api only operates at the parent cell level19:26
*** pece has joined #openstack-nova19:26
mriedemvponomaryov: in this log http://logs.openstack.org/64/263664/5/check/gate-manila-tempest-dsvm-neutron/835bf51/logs/screen-n-cpu.txt.gz i was tracing the volume attach and detach for instance 17d72364-a54e-4ea7-9ff2-4ff3821ab022 - the attach takes ~15 seconds and the detach takes ~3 seconds19:26
dansmithyeah, that's what I figured19:26
dansmithccarmack: let it be known that I was right once19:26
ccarmackdansmith:  duly noted19:27
alaskiheh.  now that you've answered something about cells correctly you are close to as knowledgeable as the rest of us on it19:27
*** dedery_ has joined #openstack-nova19:28
mriedemvponomaryov: looks like iscsiadm sesssions are piling up http://logs.openstack.org/64/263664/5/check/gate-manila-tempest-dsvm-neutron/835bf51/logs/screen-n-cpu.txt.gz#_2016-01-06_14_05_11_97619:28
*** moshele has quit IRC19:29
*** alraddarla has joined #openstack-nova19:29
*** jidar has joined #openstack-nova19:29
*** moshele has joined #openstack-nova19:30
*** gjayavelu has quit IRC19:30
jidaranybody know why my nova hosts would flap state=up -> state=down over and over again?19:30
*** dedery has quit IRC19:31
*** dedery_ has quit IRC19:32
*** eil397 has joined #openstack-nova19:33
*** alraddarla has quit IRC19:34
*** changbl has joined #openstack-nova19:35
*** ociuhandu has quit IRC19:35
*** READ10 has joined #openstack-nova19:35
*** rlrossit has left #openstack-nova19:35
*** rlrossit has joined #openstack-nova19:36
*** smatzek has quit IRC19:38
mriedemvponomaryov: i thought you said the manila job used thinly provisioned targets? http://logs.openstack.org/64/263664/5/check/gate-manila-tempest-dsvm-neutron/835bf51/logs/screen-c-vol.txt.gz#_2016-01-06_14_05_01_72319:39
mriedemthose all say they aren't thin provisioned19:39
*** READ10 has quit IRC19:40
*** moshele has quit IRC19:42
rlrossitdansmith: is there any plan to axe NovaObjectDictCompat?19:43
*** smatzek has joined #openstack-nova19:43
dansmithrlrossit: you fix all the places we still use it and we can axe it like a mofo19:43
rlrossitdansmith: do we want to classify it under a bp and do it in N? Or should I just go crazy?19:44
*** gjayavelu has joined #openstack-nova19:45
*** gjayavelu has quit IRC19:45
dansmithI think it's legit cleanup suitable for doing until the last phase19:45
rlrossitdansmith: totally unlinked to anything? it scares me because it's a py3-like change but won't have any sort of tracking19:46
*** ljxiash has quit IRC19:46
dansmithrlrossit: no, you can create a specless bp for it if you want, or slam it under the general objects one we have19:46
*** Sukhdev has joined #openstack-nova19:46
dansmithmriedem: agree?19:46
*** dslevin_ has quit IRC19:47
* mriedem is deep in the bowels of libvirtd logs19:47
*** e0ne has quit IRC19:47
*** andreykurilin__ has joined #openstack-nova19:47
mriedemi'd be fine with the existing mitaka-objects bp or a new cleanup on19:47
mriedemdansmith: what was that other person using for cleaning up the fake uuid stuff?19:47
rlrossitI'll get a bp started. I don't want to put it in the general one because it'll spam the heck out of it19:47
dansmithmriedem: I don't think he was using one19:48
dansmithmriedem: and that person would be migi19:48
* rlrossit feels like he should be given the title nova-janitor19:48
mriedemrm-obj-dict-compat19:48
mriedemsure19:48
mriedemno, make the title make sense19:49
mriedemunlike calling a new project 'jacket'19:49
mriedemor 'nova'19:49
* mriedem gets coffee19:49
rlrossitmriedem: no, *I* want that title19:49
mriedemoh in that case,19:49
mriedemi have some vomit and urine in my office that needs cleaning19:49
mriedemvponomaryov: i think i'm closer to your issue19:49
mriedemhttp://logs.openstack.org/64/263664/5/check/gate-manila-tempest-dsvm-neutron/835bf51/logs/libvirt/libvirtd.txt.gz19:50
mriedemvponomaryov: there is a call to virDomainAttachDeviceFlags for each attach19:50
mriedembut there are only 2 calls to virDomainDetachDeviceFlags19:50
mriedemfor vdb19:50
mriedemso it looks like libvirt is not detaching the devices19:50
*** pece has quit IRC19:50
*** dslevin_ has joined #openstack-nova19:52
*** penick has joined #openstack-nova19:52
*** tjones has joined #openstack-nova19:54
openstackgerritTracy Jones proposed openstack/nova: config options: centralize section "service"  https://review.openstack.org/25656919:55
*** baoli_ has quit IRC19:57
*** smatzek_ has joined #openstack-nova19:59
mriedemoh and another difference in the manila jobs is they don't specify a device name on attach to the compute api20:00
mriedemthe integrated gate jobs with tempest always specify a device name20:01
mriedemi'm not entirely sure why that would make a difference though b/c the libvirt driver ignores the device name on the request20:01
*** lpetrut has joined #openstack-nova20:02
*** smatzek has quit IRC20:02
*** lucasagomes is now known as lucas-dinner20:03
suro-patzRequest for review - https://review.openstack.org/#/c/257596/ https://review.openstack.org/#/c/254423/ melwitt jaypipes jwcroppe20:05
rlrossitdansmith: https://blueprints.launchpad.net/nova/+spec/rm-object-dict-compat if you want a look20:07
*** ndipanov has quit IRC20:09
*** zenoway has joined #openstack-nova20:09
mriedemvponomaryov: there are only 2 calls to detach in the n-cpu logs20:10
mriedemso manila keeps attaching volumes but doesn't detach them20:10
mriedemand that's why we run out of devices20:10
*** baoli has joined #openstack-nova20:10
*** ociuhandu has joined #openstack-nova20:11
dansmithrlrossit: we normally approve those during the meetings, but I'd just start cranking away if I were you and we'll hit it tomorrow20:11
rlrossit+1 sounds good20:12
rlrossitdansmith: should I add it to the agenda?20:12
dansmithrlrossit: yeah20:12
*** unicell has quit IRC20:12
*** unicell1 has joined #openstack-nova20:12
*** krtaylor has quit IRC20:13
*** artom has quit IRC20:13
rlrossitdansmith: really stupid question... I just edit the nova meetings wiki page right?20:14
dansmithyeah20:14
*** otter768 has joined #openstack-nova20:14
*** dedery has joined #openstack-nova20:17
*** gtt116_ has quit IRC20:17
*** gtt116_ has joined #openstack-nova20:18
*** otter768 has quit IRC20:19
*** penick_ has joined #openstack-nova20:20
*** ctrath has quit IRC20:21
*** pkarikh has quit IRC20:21
*** belmoreira has joined #openstack-nova20:22
*** hemna is now known as hemnafk20:22
*** penick has quit IRC20:23
*** penick_ is now known as penick20:23
*** pkarikh has joined #openstack-nova20:25
*** zenoway has quit IRC20:25
cdentrlrossit: can you point me at a good example of a nondictcompat that is iterating its fields?20:27
*** ctrath has joined #openstack-nova20:28
*** e0ne has joined #openstack-nova20:28
rlrossitcdent: I'm not sure if any classes have been changed to not use NovaObjectDictCompat yet... I'll take a look, and at worst I'll send you the first one that I'm getting ready for the bp I made for cleaning it up20:29
*** rfolco has quit IRC20:29
*** e0ne has quit IRC20:29
cdentcool thanks20:29
rlrossitcdent: actually I think this does it the desirable way: https://github.com/openstack/nova/blob/master/nova/objects/agent.py#L37-L4220:30
*** e0ne has joined #openstack-nova20:30
cdentah, okay, I was hoping for something with *attr() ...20:31
smatzek_sdague: Thanks for the review on "glance: secure https when getting client version".  This method will be called at https://github.com/openstack/nova/blob/master/nova/image/glance.py#L142 when we start making actions use Glance V2.  The parameters that need to be passed downstream are already in params which is why I'm doing what I'm doing.  Would you prefer me to move the code that builds the params dict to a separate method and20:31
smatzek_call it inside _determine_curr_major_version?20:31
cdentrlrossit: whoops, s/with/without/20:32
openstackgerritAndrew Laski proposed openstack/nova: Clean up filter_properties/availability_zone in boot  https://review.openstack.org/25443420:32
openstackgerritAndrew Laski proposed openstack/nova: Persist the request spec during an instance boot  https://review.openstack.org/25862820:32
rlrossitcdent: was there something else were you thinking to use?20:33
rlrossitlike dot syntax?20:33
cdentSpecialMagic!20:33
cdent;)20:33
*** e0ne has quit IRC20:33
sdaguesmatzek_: I would rather all the params be explicit in the function call20:33
rlrossitSpecialMagic is reserved for dansmith's use only20:34
cdent:)20:34
cdentI'll fix it either tonight or tomorrow, thanks for the review.20:35
smatzek_sdague:  Since the method will simply pass them down to http.HttpClient, the defaults of the parameters on _determine_cur_major_version would need to match the defaults in http.HttpClient.  That would be a management issue downstream if/when they change on http.HttpClient.20:36
sdaguesmatzek_: that's fine, we want to know that, if it's just **foo then it's all magic random and we have no idea what's going on.20:37
smatzek_sdague:  OK, I was just trying to avoid tying the method's parameters and defaults to http.HttpClient and getting bit in the future when a mismatch comes along.  I can do it that way.20:38
*** ctrath has quit IRC20:39
*** armax has joined #openstack-nova20:40
*** zhenq has joined #openstack-nova20:41
*** krtaylor has joined #openstack-nova20:43
*** rk4n has joined #openstack-nova20:44
*** rfolco has joined #openstack-nova20:45
*** ctrath has joined #openstack-nova20:47
*** matrohon has joined #openstack-nova20:47
*** baoli has quit IRC20:48
ildikovmriedem: hi. are you around?20:51
mriedemin a meeting20:52
ildikovmriedem: will you be available soonish today?20:52
mriedemmight be awhile20:52
mriedempost your thing and i can try to catch up later20:52
ildikovok, thanks20:53
ildikovbasically I added multiattach_support to the capabilities dict for the virt drivers20:54
ildikovand now I'm searching for the right place in bdm.attach to fail if the volume would be attached to a second instance and the virt_driver does not support multiattach20:55
*** annegentle has quit IRC20:55
*** vishwanathj has joined #openstack-nova20:56
*** annegentle has joined #openstack-nova20:56
*** haomaiwang has joined #openstack-nova20:56
ildikovand I got confused regarding where we do check_attach and why the volume['attach_status'] == 'detached' check is here: https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L296 ? in the sense of if the volume is already attached that should be catched by check_attach at an earlier phase20:57
mriedemildikov: you'd have to look to see where do_check_attach=False is passed in there20:59
*** FL1SK has quit IRC21:00
*** baoli has joined #openstack-nova21:00
ildikovbut check_attach is called fro other functions too, so I don't really get the "rules" here21:00
*** haomaiwang has quit IRC21:01
ildikovmriedem: although the question on top of my head is that if the status is not detached then we just silently skip the Cinder part as everywhere else we raise an error21:01
ildikovI mean in the case when the volume cannot be attached21:03
*** Sukhdev has quit IRC21:05
*** raildo is now known as raildo-afk21:05
openstackgerritChris Dent proposed openstack/nova: Propagate qemu-img errors to compute manager  https://review.openstack.org/26434921:05
cdentbauzas, n0ano: that's a fix for https://bugs.launchpad.net/nova/+bug/143616621:05
openstackLaunchpad bug 1436166 in OpenStack Compute (nova) "Problems with images bubble up as a simple "There are not enough hosts available"" [High,In progress] - Assigned to Chris Dent (cdent)21:05
bauzasack21:06
ildikovmriedem: I assume if the virt driver does not support multi attach and the volume is already attached to another instance then I should raise an error on the top of bdm.attach, right? I wanted to do it in manager.py, but the volume is only available in bdm.attach21:07
* cdent waves goodnight21:08
*** cdent has quit IRC21:08
*** zenoway has joined #openstack-nova21:08
*** baoli has quit IRC21:12
*** baoli has joined #openstack-nova21:13
*** mragupat has quit IRC21:16
openstackgerritjichenjc proposed openstack/nova: Remove mox usage of versions, utils, wsgi  https://review.openstack.org/26435321:16
*** mragupat has joined #openstack-nova21:16
*** smatzek_ has quit IRC21:16
*** kragniz is now known as {^-^}21:17
*** thangp has quit IRC21:18
*** {^-^} is now known as Guest4635321:18
openstackgerritTracy Jones proposed openstack/nova: config options: centralize section "guestfs"  https://review.openstack.org/24896321:18
*** Guest46353 is now known as kragniz21:18
*** alejandrito has quit IRC21:20
*** vipul has quit IRC21:21
*** ssurana has quit IRC21:23
*** lmtaylor has left #openstack-nova21:23
*** ssurana has joined #openstack-nova21:23
*** jichen has quit IRC21:23
*** baoli has quit IRC21:24
*** baoli has joined #openstack-nova21:25
*** vladikr has quit IRC21:25
*** hemnafk is now known as hemna21:26
mriedemildikov: sorry i haven't read through the things on the driver capabilities part of the multiattach spec21:28
mriedemi know john was bringing that up in one of the changes21:28
mriedemin general it seems like what you're saying is correct21:28
ildikovyeah, mainly the point is to not allow multiattach if the virt driver is not safe21:29
mriedemcheck_attach assumes a single volume attach21:29
ildikovI modified check_attach, so it knows about multiattach now21:29
*** belmoreira has quit IRC21:29
ildikovbut it does not have the virt_driver info21:29
*** yarkot has quit IRC21:30
ildikovand also called from many places so I don't really know how it worth it to shoehorn this there21:30
*** rk4n has quit IRC21:31
mriedemlike in compute api21:32
mriedemwhere we don't have the virt driver21:32
ildikovthe other question is that would I need to add anything to the volume['attach_status'] == 'detached' check? I mean is it there to triple sure we don't try to attach the volume twice or is it there as the 'attaching' state should be checked twice?21:32
mriedemso yeah i agree we probably don't want it in volume_api.check_attach21:32
mriedemi'm not sure21:32
*** xyang2 has quit IRC21:34
ildikovok, never mind, will ask around more21:34
ildikovthanks for the help!21:35
*** baoli has quit IRC21:36
*** artom has joined #openstack-nova21:36
*** baoli has joined #openstack-nova21:37
*** moshele has joined #openstack-nova21:38
*** rk4n has joined #openstack-nova21:40
*** ctrath has quit IRC21:42
*** ctrath has joined #openstack-nova21:42
*** whenry has quit IRC21:46
*** dave-mccowan has quit IRC21:47
*** rdopiera has quit IRC21:48
*** baoli has quit IRC21:51
*** rfolco has quit IRC21:52
*** baoli has joined #openstack-nova21:53
*** armax has quit IRC21:53
*** matrohon has quit IRC21:53
*** baoli has quit IRC21:55
*** rk4n has quit IRC21:55
openstackgerritChuck Carmack proposed openstack/nova: config options: centralize 'spice' options  https://review.openstack.org/26427121:55
*** baoli has joined #openstack-nova21:55
*** RichardRaseley has quit IRC21:55
*** erlon has quit IRC21:56
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Block more flaky py34 tests  https://review.openstack.org/26436821:58
*** _diana_1 has joined #openstack-nova21:59
*** renatoarmani has quit IRC22:00
*** baoli has quit IRC22:01
*** baoli has joined #openstack-nova22:02
*** mgoddard_ has joined #openstack-nova22:02
*** tjones1 has joined #openstack-nova22:02
*** gjayavelu has joined #openstack-nova22:02
*** moshele has quit IRC22:03
*** vishwana_ has joined #openstack-nova22:03
*** ociuhandu_ has joined #openstack-nova22:04
*** baoli has quit IRC22:04
*** Kevin_Zheng_ has joined #openstack-nova22:04
*** tjones has quit IRC22:04
*** mrsoul` has joined #openstack-nova22:04
*** DuncanT has quit IRC22:04
*** Kevin_Zheng has quit IRC22:04
*** bradjones has quit IRC22:04
*** mrsoul has quit IRC22:04
*** Kevin_Zheng_ is now known as Kevin_Zheng22:04
*** ociuhandu has quit IRC22:04
*** dougs has quit IRC22:04
*** doffm has quit IRC22:04
*** dimtruck has quit IRC22:04
*** swamireddy has quit IRC22:04
*** ociuhandu_ is now known as ociuhandu22:04
*** aorourke_ has joined #openstack-nova22:04
*** doffm has joined #openstack-nova22:04
*** bradjones has joined #openstack-nova22:04
*** bradjones has quit IRC22:04
*** bradjones has joined #openstack-nova22:04
*** baoli has joined #openstack-nova22:04
*** omnipresent has joined #openstack-nova22:04
*** vishwanathj has quit IRC22:05
*** mgoddard has quit IRC22:05
*** aorourke has quit IRC22:05
*** sdague has quit IRC22:05
*** junjie has quit IRC22:05
*** dougwig has quit IRC22:05
*** dougs has joined #openstack-nova22:05
*** junjie has joined #openstack-nova22:07
*** angdraug has joined #openstack-nova22:07
*** zenoway has quit IRC22:07
mriedempy34 job is sad, which i think people know already22:07
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22b'%20%20%20%20raise%20exception.ImageNotFound(image_id%3Dimage_id)'%5C%22%20AND%20tags%3A%5C%22console%5C%22%20AND%20build_name%3A%5C%22gate-nova-python34%5C%2222:07
*** salv-orl_ has joined #openstack-nova22:09
*** baoli has quit IRC22:10
*** sdague has joined #openstack-nova22:11
*** dimtruck has joined #openstack-nova22:11
*** salv-orlando has quit IRC22:12
alaskigood to know.  I was just trying to repro locally but I'm not having much luck running the py34 tests here22:13
mriedemlooks like those are all vmware api tests22:13
mriedemhttp://logs.openstack.org/26/224726/16/gate/gate-nova-python34/cfa8b45/console.html22:13
*** mdrabe has quit IRC22:13
*** swamireddy has joined #openstack-nova22:15
dimsmriedem : i pushed out https://review.openstack.org/#/c/264368/22:15
*** otter768 has joined #openstack-nova22:15
dimsmriedem : for that problem after looking through all the uncategorized runs for the last days22:15
dimss/days/24 hours/22:16
alaskioh, there's a helpful note from mriedem in tox.ini that describes my issue exactly22:16
mriedemalaski: \o/22:16
mriedemdims:+2 at least for the vmware api test part of that22:16
*** zenoway has joined #openstack-nova22:16
*** dougwig has joined #openstack-nova22:17
*** DuncanT has joined #openstack-nova22:17
mriedemwe need to fix the stubs.Set usage here https://github.com/openstack/nova/blob/master/nova/tests/unit/image/fake.py#L25222:18
*** omnipresent has quit IRC22:19
*** otter768 has quit IRC22:20
*** fmccrthy has quit IRC22:22
*** baoli has joined #openstack-nova22:22
mriedembut doing that with self.stub_out or even fixtures isn't going to happen w/o a reference to the test that is doing the stubbing, nice22:22
*** dims has quit IRC22:22
*** fmccrthy has joined #openstack-nova22:24
*** dedery has quit IRC22:24
*** Sukhdev has joined #openstack-nova22:24
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: virtual interface tags DB table  https://review.openstack.org/26401422:25
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: metadata objects  https://review.openstack.org/26401522:25
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: user visible changes  https://review.openstack.org/26401822:25
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: compute manager nic tagging support  https://review.openstack.org/26401722:25
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: libvirt driver implementation  https://review.openstack.org/26401622:25
*** tonytan4ever has quit IRC22:26
*** mrkz has quit IRC22:26
*** omnipresent has joined #openstack-nova22:28
*** baoli has quit IRC22:28
openstackgerritAndrew Laski proposed openstack/nova: Persist the request spec during an instance boot  https://review.openstack.org/25862822:29
*** mrkz has joined #openstack-nova22:30
*** FL1SK has joined #openstack-nova22:30
*** pratikmallya has quit IRC22:30
*** dane-fichter has quit IRC22:31
*** zenoway has quit IRC22:32
*** _diana_1 has quit IRC22:33
*** lihg has quit IRC22:34
*** lihg_ has quit IRC22:34
*** sacharya_ has joined #openstack-nova22:35
*** cfriesen__ has quit IRC22:35
*** _diana_1 has joined #openstack-nova22:36
*** dedery has joined #openstack-nova22:38
*** sacharya has quit IRC22:38
*** sacharya_ has quit IRC22:39
openstackgerritMatt Riedemann proposed openstack/nova: WIP: Convert nova.tests.unit.image.fake.stub_out_image_service to use stub_out  https://review.openstack.org/26439322:44
*** tonytan4ever has joined #openstack-nova22:45
*** haomaiwang has joined #openstack-nova22:45
*** mriedem has quit IRC22:46
*** mrkz has quit IRC22:48
*** gjayavelu has quit IRC22:49
*** haomaiwang has quit IRC22:49
*** mrkz has joined #openstack-nova22:50
*** krtaylor has quit IRC22:51
*** baoli has joined #openstack-nova22:52
*** dims has joined #openstack-nova22:53
*** thorst has quit IRC22:54
*** pratikmallya has joined #openstack-nova22:54
*** bklei has joined #openstack-nova22:54
*** lpetrut has quit IRC22:55
openstackgerritRyan Rossiter proposed openstack/nova: Remove NovaObjectDictCompat from Aggregate  https://review.openstack.org/26439722:56
*** rlrossit has quit IRC22:56
*** baoli has quit IRC22:56
*** baoli has joined #openstack-nova22:57
*** mragupat has quit IRC22:57
*** davideagnello has joined #openstack-nova22:57
*** pratikmallya has quit IRC22:59
*** mrkz has quit IRC22:59
*** mrkz has joined #openstack-nova23:00
*** zenoway has joined #openstack-nova23:02
*** ctrath has quit IRC23:04
*** dims has quit IRC23:04
*** omnipresent has quit IRC23:04
*** tjones1 has quit IRC23:04
*** tjones has joined #openstack-nova23:06
*** tonytan4ever has quit IRC23:07
*** bklei has quit IRC23:07
*** baoli has quit IRC23:09
*** dimtruck is now known as zz_dimtruck23:11
openstackgerritOpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements  https://review.openstack.org/26440523:11
*** burt has quit IRC23:13
*** penick_ has joined #openstack-nova23:17
*** rfolco has joined #openstack-nova23:17
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/26444123:18
*** penick__ has joined #openstack-nova23:18
*** pradk has quit IRC23:18
*** penick has quit IRC23:19
*** penick__ is now known as penick23:19
*** davideagnello has quit IRC23:20
*** davideagnello has joined #openstack-nova23:21
*** penick_ has quit IRC23:22
*** pratikmallya has joined #openstack-nova23:22
openstackgerritDiana Clarke proposed openstack/nova: Replace stubs.Set with stub_out  https://review.openstack.org/26429723:23
*** davideagnello has quit IRC23:25
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/26444123:26
*** zenoway has quit IRC23:27
*** dims_ has joined #openstack-nova23:29
*** dave-mccowan has joined #openstack-nova23:31
*** davideagnello has joined #openstack-nova23:34
*** dims_ has quit IRC23:34
*** annegentle has quit IRC23:36
*** dims_ has joined #openstack-nova23:36
*** baoli has joined #openstack-nova23:38
*** zenoway has joined #openstack-nova23:39
*** mrkz has quit IRC23:39
*** thorst has joined #openstack-nova23:40
*** rfolco has quit IRC23:41
*** baoli has quit IRC23:43
*** zenoway has quit IRC23:43
openstackgerritmelanie witt proposed openstack/nova: Add methods for RequestContext to switch db connection  https://review.openstack.org/16190623:44
*** mriedem has joined #openstack-nova23:44
*** thorst has quit IRC23:45
*** krtaylor has joined #openstack-nova23:45
*** baoli has joined #openstack-nova23:49
*** s-moriya has joined #openstack-nova23:54
*** Sukhdev has quit IRC23:58
jrollwould y'all mind doing a novaclient release somewhat soon to pick up https://review.openstack.org/#/c/262632/ ?23:59
jrollmriedem: ^23:59
*** oomichi has joined #openstack-nova23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!