*** carey has joined #openstack-nova | 00:00 | |
*** zz_dimtruck is now known as dimtruck | 00:00 | |
*** jmccrory has quit IRC | 00:04 | |
*** diogogmt has quit IRC | 00:04 | |
*** carey has quit IRC | 00:05 | |
*** baoli has quit IRC | 00:07 | |
*** vilobhmm11 has quit IRC | 00:08 | |
*** dims has joined #openstack-nova | 00:09 | |
*** gjayavelu has quit IRC | 00:09 | |
*** nic1 has quit IRC | 00:10 | |
*** pratikma_ has quit IRC | 00:11 | |
*** mhorban_ has quit IRC | 00:11 | |
*** aginwala has quit IRC | 00:13 | |
*** zenoway has joined #openstack-nova | 00:15 | |
*** salv-orl_ has quit IRC | 00:16 | |
*** salv-orlando has joined #openstack-nova | 00:17 | |
*** aginwala has joined #openstack-nova | 00:18 | |
*** zenoway has quit IRC | 00:20 | |
*** eliqiao has quit IRC | 00:22 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add wrapper classes for return-request-id-to-caller https://review.openstack.org/258802 | 00:22 |
---|---|---|
*** eliqiao has joined #openstack-nova | 00:23 | |
*** ZZelle_ has quit IRC | 00:28 | |
*** irenab_ has joined #openstack-nova | 00:30 | |
*** tongli has joined #openstack-nova | 00:30 | |
*** irenab has quit IRC | 00:33 | |
*** irenab_ is now known as irenab | 00:33 | |
*** ducttape_ has joined #openstack-nova | 00:33 | |
*** otter768 has joined #openstack-nova | 00:35 | |
*** rk4n has joined #openstack-nova | 00:36 | |
*** tongli has quit IRC | 00:40 | |
*** otter768 has quit IRC | 00:40 | |
*** tongli has joined #openstack-nova | 00:40 | |
*** dimtruck is now known as zz_dimtruck | 00:44 | |
*** carey has joined #openstack-nova | 00:50 | |
*** SourabhP has joined #openstack-nova | 00:50 | |
*** hemna is now known as hemnafk | 00:50 | |
*** zhangjn has joined #openstack-nova | 00:51 | |
openstackgerrit | melanie witt proposed openstack/nova: Add a functional test for instance fault message with retry https://review.openstack.org/244046 | 00:53 |
*** markmcclain has quit IRC | 00:53 | |
*** SourabhP has quit IRC | 00:54 | |
*** zz_dimtruck is now known as dimtruck | 00:55 | |
*** Sukhdev has quit IRC | 00:55 | |
*** markmcclain has joined #openstack-nova | 00:55 | |
*** ctrath has quit IRC | 00:56 | |
*** aginwala has quit IRC | 01:00 | |
*** eil397 has quit IRC | 01:02 | |
*** Jeffrey4l has joined #openstack-nova | 01:03 | |
*** zenoway has joined #openstack-nova | 01:03 | |
*** aginwala has joined #openstack-nova | 01:05 | |
*** rk4n has quit IRC | 01:06 | |
*** zenoway has quit IRC | 01:08 | |
*** tongli has quit IRC | 01:10 | |
*** ekarlso has quit IRC | 01:10 | |
*** tongli has joined #openstack-nova | 01:11 | |
*** tongli has quit IRC | 01:11 | |
*** annegent_ has joined #openstack-nova | 01:11 | |
*** tongli has joined #openstack-nova | 01:11 | |
*** annegentle has quit IRC | 01:13 | |
*** gongysh has joined #openstack-nova | 01:15 | |
*** mriedem has joined #openstack-nova | 01:16 | |
*** Marga_ has quit IRC | 01:17 | |
*** doug-fish has quit IRC | 01:18 | |
*** doug-fish has joined #openstack-nova | 01:19 | |
*** zenoway has joined #openstack-nova | 01:20 | |
*** ducttape_ has quit IRC | 01:22 | |
*** aginwala has quit IRC | 01:23 | |
*** eil397 has joined #openstack-nova | 01:24 | |
*** zenoway has quit IRC | 01:24 | |
*** eliqiao has quit IRC | 01:24 | |
*** aginwala has joined #openstack-nova | 01:25 | |
*** mtanino has quit IRC | 01:28 | |
*** haomaiwang has joined #openstack-nova | 01:29 | |
*** rk4n has joined #openstack-nova | 01:29 | |
*** ducttape_ has joined #openstack-nova | 01:29 | |
*** ducttape_ has quit IRC | 01:30 | |
*** EinstCrazy has joined #openstack-nova | 01:30 | |
*** suro-patz has quit IRC | 01:33 | |
*** smatzek has joined #openstack-nova | 01:33 | |
*** doug-fish has quit IRC | 01:33 | |
*** aloga has quit IRC | 01:34 | |
*** rk4n has quit IRC | 01:34 | |
openstackgerrit | Ren Qiaowei proposed openstack/nova: xenapi: simplify swap_xapi_host() https://review.openstack.org/266258 | 01:35 |
*** zenoway has joined #openstack-nova | 01:35 | |
*** dims has quit IRC | 01:38 | |
*** zenoway has quit IRC | 01:40 | |
*** eliqiao has joined #openstack-nova | 01:42 | |
*** ducttape_ has joined #openstack-nova | 01:44 | |
*** smatzek has quit IRC | 01:47 | |
*** haomaiwang has quit IRC | 01:48 | |
*** 7JTABI1K9 has joined #openstack-nova | 01:49 | |
*** smatzek has joined #openstack-nova | 01:50 | |
*** vilobhmm11 has joined #openstack-nova | 01:51 | |
*** gongysh has quit IRC | 01:54 | |
*** ducttape_ has quit IRC | 01:54 | |
*** thumpba has joined #openstack-nova | 01:55 | |
*** ljxiash has joined #openstack-nova | 01:55 | |
*** smatzek has quit IRC | 01:56 | |
*** thumpba_ has joined #openstack-nova | 01:58 | |
*** thumpba has quit IRC | 01:58 | |
*** eil397 has quit IRC | 01:59 | |
*** zenoway has joined #openstack-nova | 01:59 | |
*** thumpba_ has quit IRC | 02:01 | |
*** thumpba has joined #openstack-nova | 02:01 | |
*** vladikr has joined #openstack-nova | 02:02 | |
*** diogogmt has joined #openstack-nova | 02:02 | |
*** aloga has joined #openstack-nova | 02:02 | |
*** thumpba has quit IRC | 02:03 | |
*** thorst_ has quit IRC | 02:03 | |
*** zenoway has quit IRC | 02:04 | |
*** thorst has joined #openstack-nova | 02:04 | |
*** thumpba has joined #openstack-nova | 02:07 | |
*** tongli has quit IRC | 02:09 | |
*** vilobhmm111 has joined #openstack-nova | 02:10 | |
*** tongli has joined #openstack-nova | 02:10 | |
*** aginwala has quit IRC | 02:10 | |
*** lyanchih has joined #openstack-nova | 02:11 | |
*** ducttape_ has joined #openstack-nova | 02:12 | |
*** ducttape_ has quit IRC | 02:13 | |
*** vilobhmm11 has quit IRC | 02:13 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: update the old location parent_addr only if it has value https://review.openstack.org/266560 | 02:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: pci_request logic considers 'direct-physical' vnic type https://review.openstack.org/262584 | 02:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: Add utility method for getting the MAC addr https://review.openstack.org/262585 | 02:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: do not filter out any SRIOV Physical Functions https://review.openstack.org/249016 | 02:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: Update the port with a MAC address for PFs https://review.openstack.org/262586 | 02:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment https://review.openstack.org/249018 | 02:14 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: adding support to specify a device_type in pci requests https://review.openstack.org/259254 | 02:14 |
*** thorst has quit IRC | 02:14 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Add a vnic type for PF passthrough and a new libvirt vif driver https://review.openstack.org/262583 | 02:14 |
*** tongli has quit IRC | 02:15 | |
*** zhangjn has quit IRC | 02:15 | |
*** lyanchih has quit IRC | 02:16 | |
*** aginwala has joined #openstack-nova | 02:17 | |
*** lyanchih has joined #openstack-nova | 02:17 | |
*** aginwala has quit IRC | 02:19 | |
*** armax has joined #openstack-nova | 02:21 | |
*** zenoway has joined #openstack-nova | 02:24 | |
*** zenoway has quit IRC | 02:28 | |
*** dave-mccowan has joined #openstack-nova | 02:30 | |
*** thumpba has quit IRC | 02:31 | |
*** thumpba has joined #openstack-nova | 02:31 | |
*** thumpba has quit IRC | 02:32 | |
*** EinstCrazy has quit IRC | 02:32 | |
*** EinstCrazy has joined #openstack-nova | 02:32 | |
*** Marga_ has joined #openstack-nova | 02:35 | |
*** otter768 has joined #openstack-nova | 02:37 | |
*** houming has joined #openstack-nova | 02:37 | |
*** dimtruck is now known as zz_dimtruck | 02:38 | |
*** thumpba has joined #openstack-nova | 02:38 | |
*** markmcclain has quit IRC | 02:39 | |
*** zhangjn has joined #openstack-nova | 02:39 | |
*** markmcclain has joined #openstack-nova | 02:40 | |
*** thumpba has quit IRC | 02:40 | |
*** otter768 has quit IRC | 02:41 | |
*** Marga_ has quit IRC | 02:41 | |
*** Marga_ has joined #openstack-nova | 02:42 | |
*** Marga_ has quit IRC | 02:42 | |
*** thumpba has joined #openstack-nova | 02:42 | |
*** Marga_ has joined #openstack-nova | 02:43 | |
*** zenoway has joined #openstack-nova | 02:48 | |
*** aginwala has joined #openstack-nova | 02:50 | |
*** aginwala has quit IRC | 02:50 | |
*** aginwala has joined #openstack-nova | 02:51 | |
*** zenoway has quit IRC | 02:52 | |
*** aginwala has quit IRC | 02:53 | |
*** aginwala has joined #openstack-nova | 02:53 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add reviewing point related to REST API https://review.openstack.org/266645 | 02:58 |
*** aginwala_ has joined #openstack-nova | 02:59 | |
*** aginwala has quit IRC | 03:00 | |
*** zz_dimtruck is now known as dimtruck | 03:01 | |
*** _diana_1 has joined #openstack-nova | 03:07 | |
*** thumpba has quit IRC | 03:08 | |
*** mtanino has joined #openstack-nova | 03:08 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/266160 | 03:11 |
*** thorst has joined #openstack-nova | 03:12 | |
*** markmcclain has quit IRC | 03:12 | |
*** zenoway has joined #openstack-nova | 03:13 | |
*** markmcclain has joined #openstack-nova | 03:15 | |
*** apoorvad has quit IRC | 03:16 | |
*** thumpba has joined #openstack-nova | 03:16 | |
*** otter768 has joined #openstack-nova | 03:17 | |
*** yamahata has quit IRC | 03:17 | |
*** dims has joined #openstack-nova | 03:17 | |
*** zenoway has quit IRC | 03:18 | |
*** thorst has quit IRC | 03:19 | |
*** ekarlso has joined #openstack-nova | 03:19 | |
*** mriedem has quit IRC | 03:20 | |
openstackgerrit | Eli Qiao proposed openstack/nova: Calculate block_migration in virt drivers if it's None https://review.openstack.org/254101 | 03:20 |
openstackgerrit | Eli Qiao proposed openstack/nova: Return host and block_migration in task_api._execute() https://review.openstack.org/254102 | 03:20 |
*** unicell has quit IRC | 03:21 | |
*** _diana_1 has quit IRC | 03:21 | |
*** links has joined #openstack-nova | 03:23 | |
*** claudiub has quit IRC | 03:24 | |
*** edmondsw has quit IRC | 03:27 | |
*** lyanchih has quit IRC | 03:32 | |
*** dims has quit IRC | 03:33 | |
*** gyee has quit IRC | 03:34 | |
*** gongysh has joined #openstack-nova | 03:36 | |
*** vivekd has joined #openstack-nova | 03:36 | |
*** coolsvap|away is now known as coolsvap | 03:37 | |
openstackgerrit | sandeep nandal proposed openstack/nova: Replaced range() and xrange() by six.moves.range() https://review.openstack.org/264652 | 03:37 |
*** markmcclain has quit IRC | 03:37 | |
*** zenoway has joined #openstack-nova | 03:38 | |
*** markmcclain has joined #openstack-nova | 03:38 | |
*** Jeffrey4l has quit IRC | 03:40 | |
*** annegent_ has quit IRC | 03:40 | |
*** zenoway has quit IRC | 03:42 | |
oomichi | alex_xu: hi, can you take a look at https://review.openstack.org/#/c/266645/? just one line ;) | 03:43 |
alex_xu | oomichi: reading | 03:44 |
*** thumpba has quit IRC | 03:44 | |
alex_xu | oomichi: is there anywhere we use 'compute'? 'compute' node? | 03:45 |
*** thumpba has joined #openstack-nova | 03:45 | |
alex_xu | oomichi: but good to see https://review.openstack.org/#/c/196918/8 merged :) | 03:46 |
*** zhangjn has quit IRC | 03:46 | |
oomichi | alex_xu: not yet. current microversion header name is against the rule as you know | 03:46 |
alex_xu | oomichi: yea | 03:46 |
*** unicell has joined #openstack-nova | 03:46 | |
oomichi | alex_xu: "nova's development experience" means that ;) | 03:46 |
alex_xu | oomichi: :) | 03:47 |
*** carey has quit IRC | 03:47 | |
oomichi | alex_xu: thanks for reviewing anyways :) | 03:48 |
*** lyanchih has joined #openstack-nova | 03:49 | |
*** thumpba has quit IRC | 03:50 | |
*** unicell1 has joined #openstack-nova | 03:50 | |
*** unicell has quit IRC | 03:50 | |
*** markmcclain has quit IRC | 03:52 | |
*** Jeffrey4l has joined #openstack-nova | 03:53 | |
*** ljxiash has quit IRC | 03:56 | |
*** ljxiash has joined #openstack-nova | 03:56 | |
*** annegentle has joined #openstack-nova | 04:00 | |
*** ljxiash has quit IRC | 04:00 | |
*** zenoway has joined #openstack-nova | 04:03 | |
openstackgerrit | Eli Qiao proposed openstack/nova: Object: Fix wrong usage migrate_data_obj in libvirt driver https://review.openstack.org/266668 | 04:03 |
*** gangil has quit IRC | 04:04 | |
*** otter768 has quit IRC | 04:04 | |
*** NightKhaos has quit IRC | 04:05 | |
*** zenoway has quit IRC | 04:07 | |
*** lyanchih has quit IRC | 04:08 | |
*** vks has joined #openstack-nova | 04:08 | |
*** tongli has joined #openstack-nova | 04:10 | |
*** salv-orl_ has joined #openstack-nova | 04:10 | |
*** Marga_ has quit IRC | 04:10 | |
*** Jeffrey4l has quit IRC | 04:11 | |
*** salv-orlando has quit IRC | 04:13 | |
*** zhangjn has joined #openstack-nova | 04:16 | |
*** vilobhmm111 has quit IRC | 04:17 | |
*** thorst has joined #openstack-nova | 04:17 | |
*** tongli has quit IRC | 04:23 | |
*** Jeffrey4l has joined #openstack-nova | 04:23 | |
*** markmcclain has joined #openstack-nova | 04:24 | |
*** tongli has joined #openstack-nova | 04:24 | |
*** thorst has quit IRC | 04:25 | |
*** vivekd_ has joined #openstack-nova | 04:25 | |
*** tongli has quit IRC | 04:26 | |
*** tongli has joined #openstack-nova | 04:26 | |
*** zenoway has joined #openstack-nova | 04:27 | |
*** vivekd has quit IRC | 04:27 | |
*** vivekd_ is now known as vivekd | 04:27 | |
*** zhangjn has quit IRC | 04:29 | |
*** markmcclain has quit IRC | 04:29 | |
oomichi | johnthetubaguy: sdague: one more reviewing point comes from api-wg: https://review.openstack.org/#/c/266645/ | 04:29 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/nova: Add mm-ctl to compute.filters https://review.openstack.org/266670 | 04:30 |
*** tongli has quit IRC | 04:30 | |
*** tongli has joined #openstack-nova | 04:31 | |
*** zenoway has quit IRC | 04:31 | |
*** gangil has joined #openstack-nova | 04:34 | |
*** gangil has joined #openstack-nova | 04:34 | |
*** tongli has quit IRC | 04:35 | |
*** tongli has joined #openstack-nova | 04:36 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/nova: Remove mm-ctl from network.filters https://review.openstack.org/266673 | 04:38 |
*** EinstCra_ has joined #openstack-nova | 04:39 | |
*** EinstCrazy has quit IRC | 04:39 | |
*** vivekd_ has joined #openstack-nova | 04:39 | |
*** tongli has quit IRC | 04:40 | |
*** dimtruck is now known as zz_dimtruck | 04:40 | |
*** vivekd has quit IRC | 04:41 | |
*** dave-mccowan has quit IRC | 04:41 | |
*** vivekd_ is now known as vivekd | 04:41 | |
alex_xu | oomichi: np | 04:45 |
*** zenoway has joined #openstack-nova | 04:47 | |
*** dave-mccowan has joined #openstack-nova | 04:47 | |
openstackgerrit | Anand Shanmugam proposed openstack/nova: Handle Instance Exceptions in add_fixed_ip and remove_fixed_ip https://review.openstack.org/266675 | 04:48 |
*** ljxiash has joined #openstack-nova | 04:51 | |
*** EinstCra_ has quit IRC | 04:51 | |
*** EinstCrazy has joined #openstack-nova | 04:51 | |
*** ferest has joined #openstack-nova | 04:53 | |
*** thumpba has joined #openstack-nova | 04:55 | |
*** ferest_ has joined #openstack-nova | 04:56 | |
*** ferest has quit IRC | 04:57 | |
*** thumpba has quit IRC | 05:01 | |
*** EinstCrazy has quit IRC | 05:01 | |
*** EinstCrazy has joined #openstack-nova | 05:02 | |
*** Sukhdev has joined #openstack-nova | 05:03 | |
*** boris-42 has quit IRC | 05:03 | |
*** EinstCrazy has quit IRC | 05:05 | |
*** EinstCrazy has joined #openstack-nova | 05:05 | |
*** EinstCrazy has quit IRC | 05:06 | |
*** EinstCrazy has joined #openstack-nova | 05:06 | |
*** markmcclain has joined #openstack-nova | 05:12 | |
*** EinstCra_ has joined #openstack-nova | 05:15 | |
*** EinstCrazy has quit IRC | 05:15 | |
*** vks has quit IRC | 05:15 | |
*** zhangjn has joined #openstack-nova | 05:15 | |
*** vks has joined #openstack-nova | 05:16 | |
*** EinstCra_ has quit IRC | 05:16 | |
*** carey has joined #openstack-nova | 05:17 | |
*** EinstCrazy has joined #openstack-nova | 05:17 | |
*** ccarmack has joined #openstack-nova | 05:18 | |
*** NightKhaos has joined #openstack-nova | 05:20 | |
ccarmack | alex_xu: are you there? | 05:20 |
alex_xu | ccarmack: I'm here | 05:21 |
ccarmack | Could you take a look at https://review.openstack.org/#/c/254950/ ? The merge conflict is due to the microversion changing. | 05:21 |
*** markmcclain has quit IRC | 05:21 | |
*** thorst has joined #openstack-nova | 05:21 | |
*** lyanchih has joined #openstack-nova | 05:22 | |
alex_xu | ccarmack: ok, let me check | 05:22 |
ccarmack | Great, I'll look at the comments tomorrow, thanks | 05:22 |
alex_xu | ccarmack: np :) | 05:22 |
*** ccarmack has left #openstack-nova | 05:23 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli https://review.openstack.org/266687 | 05:24 |
*** NightKhaos has quit IRC | 05:24 | |
*** NightKhaos has joined #openstack-nova | 05:25 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266687 | 05:26 |
*** EinstCra_ has joined #openstack-nova | 05:26 | |
*** EinstCrazy has quit IRC | 05:26 | |
*** EinstCra_ has quit IRC | 05:27 | |
*** gcb has quit IRC | 05:27 | |
*** EinstCrazy has joined #openstack-nova | 05:28 | |
*** thorst has quit IRC | 05:29 | |
*** annegentle has quit IRC | 05:29 | |
*** NightKhaos has quit IRC | 05:31 | |
*** EinstCrazy has quit IRC | 05:31 | |
*** EinstCrazy has joined #openstack-nova | 05:32 | |
*** ferest_ has quit IRC | 05:33 | |
*** aginwala_ has quit IRC | 05:36 | |
*** dave-mccowan has quit IRC | 05:36 | |
*** EinstCrazy has quit IRC | 05:37 | |
*** EinstCra_ has joined #openstack-nova | 05:37 | |
*** NightKhaos has joined #openstack-nova | 05:37 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266687 | 05:38 |
*** gcb has joined #openstack-nova | 05:39 | |
*** jwcroppe has quit IRC | 05:40 | |
*** jaosorior has joined #openstack-nova | 05:41 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266690 | 05:41 |
*** EinstCra_ has quit IRC | 05:41 | |
openstackgerrit | Moshe Levi proposed openstack/nova: Enhance PCI passthrough whitelist to support regex https://review.openstack.org/199488 | 05:41 |
*** artom has quit IRC | 05:41 | |
*** EinstCra_ has joined #openstack-nova | 05:43 | |
*** mtanino has quit IRC | 05:43 | |
*** NightKhaos has quit IRC | 05:43 | |
*** NightKhaos has joined #openstack-nova | 05:44 | |
*** zhangjn has quit IRC | 05:46 | |
*** NightKhaos_ has joined #openstack-nova | 05:49 | |
*** markmcclain has joined #openstack-nova | 05:50 | |
*** NightKhaos has quit IRC | 05:51 | |
*** NightKhaos_ is now known as NightKhaos | 05:51 | |
*** markmcclain has quit IRC | 05:56 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix Exception message consistency with input protocol https://review.openstack.org/266698 | 06:00 |
*** edtubill has joined #openstack-nova | 06:01 | |
*** zenoway has quit IRC | 06:01 | |
*** zhangjn has joined #openstack-nova | 06:07 | |
*** zhangjn has quit IRC | 06:07 | |
*** zhangjn has joined #openstack-nova | 06:08 | |
openstackgerrit | Ren Qiaowei proposed openstack/nova: enable uefi boot for x86_64 https://review.openstack.org/262930 | 06:12 |
*** zenoway has joined #openstack-nova | 06:13 | |
openstackgerrit | Wang Bo proposed openstack/nova: Replaces __builtin__ with six.moves.builtins https://review.openstack.org/266708 | 06:13 |
*** SourabhP has joined #openstack-nova | 06:14 | |
*** zenoway has quit IRC | 06:18 | |
*** aginwala has joined #openstack-nova | 06:19 | |
*** aginwala_ has joined #openstack-nova | 06:20 | |
*** ParsectiX has quit IRC | 06:22 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli https://review.openstack.org/266687 | 06:22 |
*** vivekd has quit IRC | 06:23 | |
*** zhangjn has quit IRC | 06:23 | |
*** aginwala has quit IRC | 06:24 | |
*** gongysh has quit IRC | 06:24 | |
*** zhangjn has joined #openstack-nova | 06:25 | |
*** SourabhP_ has joined #openstack-nova | 06:26 | |
*** thorst has joined #openstack-nova | 06:26 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(1/5) https://review.openstack.org/261399 | 06:27 |
*** aginwala has joined #openstack-nova | 06:27 | |
*** markvoelker has quit IRC | 06:27 | |
*** SourabhP has quit IRC | 06:28 | |
*** SourabhP_ is now known as SourabhP | 06:28 | |
*** aginwala_ has quit IRC | 06:29 | |
openstackgerrit | esracelik proposed openstack/nova: Config options: centralize section "hyperv" https://review.openstack.org/255124 | 06:32 |
*** thorst has quit IRC | 06:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/265601 | 06:37 |
*** shyama has joined #openstack-nova | 06:39 | |
*** lyanchih has quit IRC | 06:39 | |
*** zhangjn has quit IRC | 06:40 | |
*** EinstCra_ has quit IRC | 06:40 | |
*** vivekd has joined #openstack-nova | 06:40 | |
*** EinstCrazy has joined #openstack-nova | 06:40 | |
*** ferest has joined #openstack-nova | 06:41 | |
openstackgerrit | Eli Qiao proposed openstack/nova: Object: Fix wrong usage migrate_data_obj in libvirt driver https://review.openstack.org/266668 | 06:44 |
*** moshele has joined #openstack-nova | 06:44 | |
*** SourabhP has quit IRC | 06:45 | |
*** lyanchih has joined #openstack-nova | 06:45 | |
openstackgerrit | esracelik proposed openstack/nova: Config options: centralize "configdrive" options https://review.openstack.org/254092 | 06:46 |
*** yamahata has joined #openstack-nova | 06:47 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266690 | 06:47 |
*** ferest has quit IRC | 06:48 | |
openstackgerrit | Qin Zhao proposed openstack/nova: VMware: Handle image size correctly for OVA and streamOptimized images https://review.openstack.org/168024 | 06:48 |
*** zenoway has joined #openstack-nova | 06:49 | |
*** zhangjn has joined #openstack-nova | 06:50 | |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments https://review.openstack.org/193135 | 06:51 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments https://review.openstack.org/193134 | 06:51 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: db and obj: Allow multiple volume attachments https://review.openstack.org/193133 | 06:51 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 06:51 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: virt: Pass host when call attach to Cinder https://review.openstack.org/256273 | 06:51 |
*** Sukhdev has quit IRC | 06:52 | |
*** cfriesen has quit IRC | 06:53 | |
*** jaosorior has quit IRC | 06:57 | |
*** garyk has joined #openstack-nova | 06:57 | |
*** josecastroleon has joined #openstack-nova | 07:02 | |
*** esracelik has joined #openstack-nova | 07:08 | |
*** mjura has joined #openstack-nova | 07:09 | |
*** esracelik has quit IRC | 07:11 | |
*** esracelik has joined #openstack-nova | 07:11 | |
*** med_ has quit IRC | 07:12 | |
*** esracelik has quit IRC | 07:14 | |
*** med_ has joined #openstack-nova | 07:14 | |
*** esracelik has joined #openstack-nova | 07:14 | |
*** med_ is now known as Guest77121 | 07:14 | |
*** vivekd has quit IRC | 07:15 | |
*** lpetrut has joined #openstack-nova | 07:22 | |
*** paul-carlton2 has joined #openstack-nova | 07:24 | |
*** aginwala has quit IRC | 07:25 | |
*** markvoelker has joined #openstack-nova | 07:28 | |
*** sahid has joined #openstack-nova | 07:28 | |
*** sakthi has joined #openstack-nova | 07:29 | |
*** edtubill has quit IRC | 07:30 | |
sakthi | required to find instance reboot time? any suggestion | 07:31 |
*** thorst has joined #openstack-nova | 07:31 | |
*** markvoelker has quit IRC | 07:33 | |
*** paul-carlton2 has quit IRC | 07:34 | |
*** jichen has joined #openstack-nova | 07:34 | |
*** gwei3 has joined #openstack-nova | 07:35 | |
*** shyama has quit IRC | 07:36 | |
*** shyama has joined #openstack-nova | 07:36 | |
*** rotbeard has quit IRC | 07:37 | |
*** thorst has quit IRC | 07:39 | |
*** e0ne has joined #openstack-nova | 07:41 | |
*** rk4n has joined #openstack-nova | 07:41 | |
*** nkrinner has joined #openstack-nova | 07:44 | |
*** paul-carlton2 has joined #openstack-nova | 07:47 | |
openstackgerrit | linbing proposed openstack/nova: VMware: Fix bug of TypeError when getting reference of VCenter cluster is None. https://review.openstack.org/257674 | 07:48 |
*** mpavone has joined #openstack-nova | 07:57 | |
openstackgerrit | Tomi Juvonen proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id} https://review.openstack.org/241562 | 07:57 |
*** otter768 has joined #openstack-nova | 08:00 | |
*** ildikov has quit IRC | 08:00 | |
*** otter768 has quit IRC | 08:02 | |
*** otter768 has joined #openstack-nova | 08:02 | |
bauzas | good morning Nova | 08:04 |
*** salv-orl_ has quit IRC | 08:04 | |
*** otter768 has quit IRC | 08:04 | |
*** salv-orlando has joined #openstack-nova | 08:04 | |
*** otter768_ has joined #openstack-nova | 08:04 | |
*** otter768_ has quit IRC | 08:06 | |
*** otter768 has joined #openstack-nova | 08:06 | |
*** jistr has joined #openstack-nova | 08:07 | |
*** 7JTABI1K9 has quit IRC | 08:07 | |
*** jistr is now known as jistr|doc | 08:07 | |
*** 21WAARZWA has joined #openstack-nova | 08:07 | |
*** otter768 has quit IRC | 08:08 | |
*** otter768_ has joined #openstack-nova | 08:08 | |
*** otter768 has joined #openstack-nova | 08:10 | |
*** otter768_ has quit IRC | 08:10 | |
*** zhangjn has quit IRC | 08:11 | |
*** otter768_ has joined #openstack-nova | 08:12 | |
*** Jeffrey4l has quit IRC | 08:12 | |
*** paul-carlton2 has quit IRC | 08:12 | |
*** otter768_ has quit IRC | 08:13 | |
*** markus_z has joined #openstack-nova | 08:13 | |
*** otter768_ has joined #openstack-nova | 08:13 | |
*** otter768 has quit IRC | 08:15 | |
oomichi | bauzas: o/ | 08:15 |
*** otter768 has joined #openstack-nova | 08:15 | |
*** otter768_ has quit IRC | 08:16 | |
bauzas | :-) | 08:17 |
*** otter768_ has joined #openstack-nova | 08:17 | |
*** otter768 has quit IRC | 08:17 | |
*** e0ne has quit IRC | 08:18 | |
*** zakora has joined #openstack-nova | 08:19 | |
*** otter768 has joined #openstack-nova | 08:19 | |
*** otter768_ has quit IRC | 08:19 | |
*** otter768_ has joined #openstack-nova | 08:21 | |
*** otter768 has quit IRC | 08:21 | |
openstackgerrit | sahid proposed openstack/os-vif: introduce vif.Config https://review.openstack.org/266768 | 08:23 |
*** otter768_ has quit IRC | 08:23 | |
*** zhangjn has joined #openstack-nova | 08:23 | |
*** otter768 has joined #openstack-nova | 08:23 | |
openstackgerrit | esracelik proposed openstack/nova: Config options: centralize section "cells" https://review.openstack.org/260181 | 08:24 |
*** otter768 has quit IRC | 08:25 | |
*** paul-carlton2 has joined #openstack-nova | 08:25 | |
*** otter768 has joined #openstack-nova | 08:25 | |
*** sudipto has joined #openstack-nova | 08:25 | |
*** otter768_ has joined #openstack-nova | 08:27 | |
*** otter76__ has joined #openstack-nova | 08:29 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 08:29 |
*** otter768 has quit IRC | 08:29 | |
*** otter768_ has quit IRC | 08:29 | |
*** matrohon has joined #openstack-nova | 08:29 | |
*** Jeffrey4l has joined #openstack-nova | 08:29 | |
*** ildikov has joined #openstack-nova | 08:29 | |
*** otter768 has joined #openstack-nova | 08:31 | |
*** otter76__ has quit IRC | 08:31 | |
*** yamahata has quit IRC | 08:32 | |
*** otter768 has quit IRC | 08:32 | |
*** smoriya_ has quit IRC | 08:32 | |
*** otter768 has joined #openstack-nova | 08:33 | |
*** lpetrut has quit IRC | 08:33 | |
*** otter768_ has joined #openstack-nova | 08:34 | |
*** liusheng has quit IRC | 08:35 | |
*** liusheng has joined #openstack-nova | 08:35 | |
*** moshele has quit IRC | 08:36 | |
*** otter768_ has quit IRC | 08:36 | |
*** otter76__ has joined #openstack-nova | 08:36 | |
*** thorst has joined #openstack-nova | 08:37 | |
*** otter768 has quit IRC | 08:37 | |
*** moshele has joined #openstack-nova | 08:37 | |
*** otter768 has joined #openstack-nova | 08:38 | |
*** otter76__ has quit IRC | 08:38 | |
*** otter768 has quit IRC | 08:40 | |
*** otter768_ has joined #openstack-nova | 08:40 | |
*** rdopiera has joined #openstack-nova | 08:40 | |
*** vks has quit IRC | 08:40 | |
*** daemontool has joined #openstack-nova | 08:40 | |
*** otter768_ has quit IRC | 08:42 | |
*** otter768 has joined #openstack-nova | 08:42 | |
*** thorst has quit IRC | 08:43 | |
*** ihrachys has joined #openstack-nova | 08:43 | |
*** daemontool_ has joined #openstack-nova | 08:43 | |
*** daemontool has quit IRC | 08:43 | |
*** otter768_ has joined #openstack-nova | 08:44 | |
*** daemontool_ is now known as daemontool | 08:44 | |
*** otter768 has quit IRC | 08:44 | |
*** jlanoux has joined #openstack-nova | 08:45 | |
*** paul-carlton2 has quit IRC | 08:46 | |
*** otter768 has joined #openstack-nova | 08:46 | |
*** otter768_ has quit IRC | 08:46 | |
*** otter768 has quit IRC | 08:48 | |
*** otter768_ has joined #openstack-nova | 08:48 | |
*** otter768_ has quit IRC | 08:50 | |
*** otter768 has joined #openstack-nova | 08:50 | |
garyk | mdbooth: danpb: any idea what may cause http://paste.openstack.org/show/483708/ | 08:50 |
*** otter768_ has joined #openstack-nova | 08:52 | |
*** otter768 has quit IRC | 08:52 | |
openstackgerrit | Tang Chen proposed openstack/nova: Add a REST API to trigger crash dump in an instance. https://review.openstack.org/202617 | 08:52 |
*** otter768 has joined #openstack-nova | 08:54 | |
*** rk4n has quit IRC | 08:54 | |
*** markvoelker has joined #openstack-nova | 08:54 | |
*** otter768 has quit IRC | 08:55 | |
*** otter76__ has joined #openstack-nova | 08:55 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 08:55 |
*** otter768_ has quit IRC | 08:56 | |
*** MVenesio has quit IRC | 08:56 | |
*** otter768 has joined #openstack-nova | 08:57 | |
*** markvoelker has quit IRC | 08:59 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli https://review.openstack.org/266687 | 08:59 |
*** otter768_ has joined #openstack-nova | 08:59 | |
*** otter768 has quit IRC | 08:59 | |
*** otter76__ has quit IRC | 09:00 | |
*** 21WAARZWA has quit IRC | 09:01 | |
*** 17WABJGSS has joined #openstack-nova | 09:01 | |
*** otter768_ has quit IRC | 09:01 | |
*** salv-orlando has quit IRC | 09:02 | |
*** MCoLo has joined #openstack-nova | 09:02 | |
*** sfinucan has joined #openstack-nova | 09:02 | |
*** salv-orlando has joined #openstack-nova | 09:03 | |
*** zhangjn has quit IRC | 09:03 | |
*** gongysh has joined #openstack-nova | 09:03 | |
*** otter768 has joined #openstack-nova | 09:03 | |
*** rk4n has joined #openstack-nova | 09:04 | |
*** slunkad has quit IRC | 09:04 | |
*** otter768 has quit IRC | 09:05 | |
*** otter768_ has joined #openstack-nova | 09:05 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 09:05 |
openstackgerrit | Jacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266690 | 09:06 |
*** otter768 has joined #openstack-nova | 09:07 | |
*** ndipanov has quit IRC | 09:08 | |
*** otter768 has quit IRC | 09:08 | |
*** mhorban_ has joined #openstack-nova | 09:08 | |
*** otter768 has joined #openstack-nova | 09:09 | |
*** amotoki has joined #openstack-nova | 09:10 | |
*** shz has quit IRC | 09:10 | |
*** otter768_ has quit IRC | 09:10 | |
*** otter768_ has joined #openstack-nova | 09:11 | |
*** otter768 has quit IRC | 09:11 | |
*** MCoLo has quit IRC | 09:12 | |
*** MCoLo has joined #openstack-nova | 09:12 | |
*** otter768_ has quit IRC | 09:13 | |
*** otter768 has joined #openstack-nova | 09:13 | |
*** vivekd has joined #openstack-nova | 09:15 | |
*** otter768_ has joined #openstack-nova | 09:15 | |
*** otter768 has quit IRC | 09:15 | |
*** ndipanov has joined #openstack-nova | 09:16 | |
*** slunkad has joined #openstack-nova | 09:16 | |
*** otter768 has joined #openstack-nova | 09:17 | |
*** jaosorior has joined #openstack-nova | 09:18 | |
*** otter768 has quit IRC | 09:19 | |
*** otter76__ has joined #openstack-nova | 09:19 | |
*** jlanoux has quit IRC | 09:19 | |
*** otter768_ has quit IRC | 09:20 | |
*** otter76__ has quit IRC | 09:20 | |
*** jlanoux has joined #openstack-nova | 09:20 | |
*** otter768 has joined #openstack-nova | 09:20 | |
*** rmart04 has joined #openstack-nova | 09:21 | |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments https://review.openstack.org/193135 | 09:21 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments https://review.openstack.org/193134 | 09:21 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 09:21 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: virt: Pass host when call attach to Cinder https://review.openstack.org/256273 | 09:21 |
*** zhangjn has joined #openstack-nova | 09:21 | |
*** otter768 has quit IRC | 09:22 | |
*** otter768 has joined #openstack-nova | 09:22 | |
*** yassine has joined #openstack-nova | 09:23 | |
*** rk4n has quit IRC | 09:23 | |
*** otter768_ has joined #openstack-nova | 09:24 | |
*** otter768 has quit IRC | 09:24 | |
openstackgerrit | Ren Qiaowei proposed openstack/nova: enable uefi boot for x86_64 https://review.openstack.org/262930 | 09:25 |
*** otter768_ has quit IRC | 09:26 | |
*** otter768 has joined #openstack-nova | 09:26 | |
openstackgerrit | javeme proposed openstack/nova: Use timedelta.total_second instead of calculating https://review.openstack.org/265079 | 09:27 |
*** otter768 has quit IRC | 09:28 | |
*** salv-orlando has quit IRC | 09:28 | |
*** otter768 has joined #openstack-nova | 09:28 | |
*** salv-orlando has joined #openstack-nova | 09:28 | |
*** paul-carlton2 has joined #openstack-nova | 09:28 | |
*** PaulMurray has joined #openstack-nova | 09:29 | |
*** otter768 has quit IRC | 09:30 | |
*** otter768_ has joined #openstack-nova | 09:30 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix Exception message consistency with input protocol https://review.openstack.org/266698 | 09:31 |
*** otter768_ has quit IRC | 09:32 | |
*** otter768 has joined #openstack-nova | 09:32 | |
*** ferest has joined #openstack-nova | 09:33 | |
*** e0ne has joined #openstack-nova | 09:33 | |
*** otter768_ has joined #openstack-nova | 09:34 | |
*** otter768 has quit IRC | 09:34 | |
*** derekh has joined #openstack-nova | 09:35 | |
openstackgerrit | Eli Qiao proposed openstack/nova: Libvirt: Move graphics checking and console verify early when LM https://review.openstack.org/265042 | 09:35 |
openstackgerrit | Eli Qiao proposed openstack/nova: Libvirt: cleanup when getting block device mapping https://review.openstack.org/266809 | 09:35 |
*** otter768_ has quit IRC | 09:36 | |
*** otter768 has joined #openstack-nova | 09:36 | |
*** zhangjn has quit IRC | 09:36 | |
sfinucan | Is there any reason why releasenotes with reno can't be wrapped at 79 characters? | 09:36 |
*** otter768_ has joined #openstack-nova | 09:38 | |
sfinucan | I notice most of the code reviews containing a 'releasenotes' file seem to be wrapped at < ~65 characters, presumably because this is what the generated file is wrapped at | 09:38 |
*** gongysh has quit IRC | 09:38 | |
*** moshele has quit IRC | 09:39 | |
*** ferest_ has joined #openstack-nova | 09:39 | |
*** otter76__ has joined #openstack-nova | 09:39 | |
*** otter768_ has quit IRC | 09:40 | |
*** otter768 has quit IRC | 09:40 | |
bauzas | sfinucan: what do you mean ? some relnotes are having more than 79 chars | 09:40 |
*** moshele has joined #openstack-nova | 09:40 | |
*** danpb has joined #openstack-nova | 09:40 | |
*** thorst has joined #openstack-nova | 09:41 | |
*** otter76__ has quit IRC | 09:41 | |
*** otter768 has joined #openstack-nova | 09:41 | |
sfinucan | bauzas: Not the ones I've seen (going on this: https://review.openstack.org/#/q/project:openstack/nova+file:releasenotes) | 09:41 |
*** ferest has quit IRC | 09:42 | |
eliqiao | hi johnthetubaguy, there? | 09:43 |
*** otter768 has quit IRC | 09:43 | |
*** otter768_ has joined #openstack-nova | 09:44 | |
*** slunkad has quit IRC | 09:45 | |
bauzas | sfinucan: I'm possibly wrong, all the merged notes are <=79 | 09:45 |
*** otter768_ has quit IRC | 09:45 | |
*** otter768 has joined #openstack-nova | 09:45 | |
*** slunkad has joined #openstack-nova | 09:45 | |
sfinucan | bauzas: Ah - a misunderstanding :) My question is can they be wrapped at 79 characters instead of something less (the trend seems to be ~65) | 09:46 |
bauzas | sfinucan: yes they can | 09:47 |
sfinucan | bauzas: OK, sweet. Didn't want to break any unwritten rules | 09:47 |
*** otter768 has quit IRC | 09:47 | |
bauzas | sfinucan: eg. https://github.com/openstack/nova/blob/master/releasenotes/notes/compute_upgrade_levels_auto-97acebc7b45b76df.yaml | 09:47 |
*** otter768 has joined #openstack-nova | 09:47 | |
*** oomichi is now known as oomichi_away | 09:47 | |
bauzas | sfinucan: if you wonder, you can still check it locally | 09:47 |
bauzas | sfinucan: just make sure that you commit your patch and then run tox -e releasenotes | 09:48 |
bauzas | (because reno looks at the git repo, not at the local files) | 09:48 |
*** thorst has quit IRC | 09:48 | |
*** rk4n has joined #openstack-nova | 09:49 | |
*** otter768_ has joined #openstack-nova | 09:49 | |
sfinucan | bauzas: and that's what I'll do. Cheers :) | 09:50 |
PaulMurray | danpb, do you have a moment to talk about the midcycle? | 09:50 |
*** gwei3 has quit IRC | 09:50 | |
openstackgerrit | Moshe Levi proposed openstack/nova: ironic driver: Adding Infiniband support https://review.openstack.org/266540 | 09:51 |
*** otter76__ has joined #openstack-nova | 09:51 | |
*** otter768_ has quit IRC | 09:51 | |
*** otter768 has quit IRC | 09:52 | |
*** otter768 has joined #openstack-nova | 09:53 | |
*** otter76__ has quit IRC | 09:53 | |
johnthetubaguy | eliqiao: I am here now | 09:54 |
eliqiao | johnthetubaguy: oh, hi. can you please take a look at this patch(you voted -1 for long time and I replied) #link https://review.openstack.org/#/c/131026/ | 09:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova: trivial: Add additional logs for NUMA scheduling https://review.openstack.org/254783 | 09:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling https://review.openstack.org/202655 | 09:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova: releasenotes: Note on CPU thread pinning support https://review.openstack.org/264693 | 09:54 |
johnthetubaguy | eliqiao: afraid its hard for me to spot those replies in my review email soup, I can take a peak | 09:55 |
*** otter768_ has joined #openstack-nova | 09:55 | |
*** rk4n has quit IRC | 09:55 | |
*** rk4n has joined #openstack-nova | 09:56 | |
eliqiao | johnthetubaguy: okay, thx, not in a hurry, I will abandon it if we don't want that one, it's leaves there for long time ... | 09:56 |
*** coolsvap is now known as coolsvap|away | 09:56 | |
*** otter768_ has quit IRC | 09:57 | |
*** otter76__ has joined #openstack-nova | 09:57 | |
*** otter768 has quit IRC | 09:58 | |
*** otter768 has joined #openstack-nova | 09:59 | |
*** rk4n has quit IRC | 10:00 | |
johnthetubaguy | eliqiao: do you have a link to where the check is in the allocate_for_instance code, I can't find it | 10:00 |
*** 17WABJGSS has quit IRC | 10:01 | |
*** otter768_ has joined #openstack-nova | 10:01 | |
*** haomaiwang has joined #openstack-nova | 10:01 | |
*** rk4n has joined #openstack-nova | 10:01 | |
oomichi_away | johnthetubaguy: review request list you are receiving is over 300 now.. | 10:02 |
oomichi_away | too long | 10:02 |
johnthetubaguy | yeah | 10:02 |
*** otter76__ has quit IRC | 10:02 | |
*** otter768_ has quit IRC | 10:02 | |
*** carey has quit IRC | 10:02 | |
* oomichi_away am afraid of pushing mine | 10:02 | |
eliqiao | https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L574 | 10:02 |
*** otter768_ has joined #openstack-nova | 10:03 | |
eliqiao | johnthetubaguy: ^^ neutronv2 api will raise exception. | 10:03 |
johnthetubaguy | eliqiao: what about nova-network? | 10:03 |
PaulMurray | johnthetubaguy, for mid cycle live migration topics - would you prefer we sort them out first and then add to midcycle etherpad or | 10:03 |
danpb | PaulMurray: hi | 10:03 |
PaulMurray | johnthetubaguy, just ask people to sort it out on the etherpad | 10:03 |
PaulMurray | danpb, hi | 10:03 |
*** otter768 has quit IRC | 10:04 | |
*** otter768_ has quit IRC | 10:04 | |
johnthetubaguy | PaulMurray: yeah, at the moment just been asking for folks to sort out things on the etherpad, whatever works for you folks really | 10:04 |
PaulMurray | danpb, we have several libvirt/qemu people going to the mid cycle | 10:04 |
danpb | ok | 10:04 |
*** otter768 has joined #openstack-nova | 10:05 | |
*** rk4n has quit IRC | 10:05 | |
eliqiao | johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/network/api.py#L299 | 10:05 |
PaulMurray | danpb, I wondered if it would be an idea to go through work being done in those areas | 10:05 |
eliqiao | johnthetubaguy: nova network doesn't has that method. | 10:05 |
PaulMurray | danpb, whats planned, what could do with help, etc. | 10:05 |
*** rk4n has joined #openstack-nova | 10:05 | |
PaulMurray | and understand a rough timeline for things we depend on | 10:05 |
danpb | are there particular items you're thinking about ? | 10:06 |
johnthetubaguy | eliqiao: as I understand it, this is the nova-network code: https://github.com/openstack/nova/blob/master/nova/network/manager.py#L514 | 10:06 |
*** EinstCrazy has quit IRC | 10:06 | |
danpb | the migration stuff is the main feature in libvirt/qemu area | 10:06 |
PaulMurray | I've been focused on migration related stuff | 10:06 |
*** otter768_ has joined #openstack-nova | 10:06 | |
*** otter768 has quit IRC | 10:06 | |
PaulMurray | I'm not involved in those communities so I rely on others to tell me what is coming | 10:08 |
*** otter768 has joined #openstack-nova | 10:08 | |
PaulMurray | I have a couple of HP guys coming who will be interested in what they can help with | 10:08 |
*** rk4n has quit IRC | 10:08 | |
*** rk4n has joined #openstack-nova | 10:09 | |
danpb | well ther's a bunch of other specs, but they're not partiularly large things and seem in control | 10:09 |
*** salv-orl_ has joined #openstack-nova | 10:09 | |
*** otter76__ has joined #openstack-nova | 10:10 | |
*** otter768 has quit IRC | 10:10 | |
*** otter768_ has quit IRC | 10:11 | |
eliqiao | johnthetubaguy: hmm... I am kinds of not understand how attach_interface work if configur nova-network as network_api, I will try to understand it... | 10:11 |
eliqiao | johnthetubaguy: Thanks for your time. :) | 10:11 |
johnthetubaguy | eliqiao: the network_api gets swapped out, for nova-network it sends an rpc messages to the network manager to execute the code, in neutron, the network_api sends REST API calls to neutron, roughly, hope that helps | 10:12 |
PaulMurray | danpb, ok, I'll add a note along with live migration progress and we can get a summary of where we are | 10:12 |
*** otter768 has joined #openstack-nova | 10:12 | |
*** otter76__ has quit IRC | 10:12 | |
johnthetubaguy | eliqiao: its the edge cases that worry me, like when subnets run out of IPs, etc | 10:12 |
*** salv-orlando has quit IRC | 10:13 | |
*** rk4n has quit IRC | 10:13 | |
eliqiao | johnthetubaguy: Thanks, it's really helps. okay, I am agree that keep that checking code there (for nova-network case) | 10:13 |
eliqiao | johnthetubaguy: Thanks again. | 10:13 |
*** otter768_ has joined #openstack-nova | 10:14 | |
johnthetubaguy | eliqiao: no worries, thanks for reaching out | 10:14 |
* eliqiao ops. should `am` with agree | 10:14 | |
*** atuvenie has joined #openstack-nova | 10:15 | |
*** cdent has joined #openstack-nova | 10:15 | |
*** ndipanov has quit IRC | 10:16 | |
*** otter76__ has joined #openstack-nova | 10:16 | |
*** otter768_ has quit IRC | 10:16 | |
*** salv-orl_ has quit IRC | 10:16 | |
*** otter768 has quit IRC | 10:17 | |
*** rk4n has joined #openstack-nova | 10:17 | |
*** salv-orlando has joined #openstack-nova | 10:17 | |
*** otter768 has joined #openstack-nova | 10:18 | |
mdbooth | Does anybody happen to know how to make cirros not default to a serial console? | 10:19 |
*** otter768 has quit IRC | 10:19 | |
*** jistr|doc is now known as jistr | 10:19 | |
*** otter768 has joined #openstack-nova | 10:20 | |
*** otter76__ has quit IRC | 10:21 | |
*** otter768_ has joined #openstack-nova | 10:22 | |
*** vivekd_ has joined #openstack-nova | 10:22 | |
*** otter768 has quit IRC | 10:22 | |
kashyap | mdbooth: If crude way works fo you: probably remove the console=ttyS0 option from the Kernel commandline? | 10:23 |
*** vivekd has quit IRC | 10:23 | |
*** vivekd_ is now known as vivekd | 10:23 | |
*** ljxiash has quit IRC | 10:23 | |
mdbooth | kashyap: Does that involve editing the image itself? | 10:23 |
*** paul-carlton1 has quit IRC | 10:23 | |
mdbooth | Or is there some magic I can give to openstack? | 10:23 |
*** ljxiash has joined #openstack-nova | 10:23 | |
*** otter768 has joined #openstack-nova | 10:23 | |
mdbooth | (but crude is fine) | 10:24 |
kashyap | mdbooth: Afraid yeah - editing the image with `guestfish`. | 10:24 |
mdbooth | Ok, thanks. | 10:24 |
*** otter768_ has quit IRC | 10:24 | |
*** lpetrut has joined #openstack-nova | 10:24 | |
*** otter768 has quit IRC | 10:25 | |
*** otter768 has joined #openstack-nova | 10:25 | |
*** jistr has quit IRC | 10:26 | |
kashyap | mdbooth: It's in an unusual location: $ cat /boot/grub/menu.lst | 10:26 |
mdbooth | That's normal for debian iirc | 10:27 |
gibi | johnthetubaguy: hi! Could you please check the versioned notification patches again? | 10:27 |
kashyap | And, I'd elide that - 'console=tty1 console=ttyS0' | 10:27 |
kashyap | mdbooth: Ah, I see | 10:27 |
*** otter768_ has joined #openstack-nova | 10:27 | |
johnthetubaguy | gibi: I do hope to get to them, had to take yesterday off in the end, so I am behind were I want to be | 10:27 |
*** otter768 has quit IRC | 10:27 | |
*** klkumar has joined #openstack-nova | 10:28 | |
*** ljxiash has quit IRC | 10:28 | |
gibi | johnthetubaguy: thanks a lot! | 10:28 |
*** otter768 has joined #openstack-nova | 10:29 | |
*** otter768_ has quit IRC | 10:29 | |
*** vivekd_ has joined #openstack-nova | 10:33 | |
*** vivekd has quit IRC | 10:33 | |
*** vivekd_ is now known as vivekd | 10:33 | |
*** otter768 has quit IRC | 10:34 | |
*** rfolco has joined #openstack-nova | 10:40 | |
*** tyagiprince has joined #openstack-nova | 10:40 | |
tyagiprince | Hey people.. need some help.. I am facing trouble in listing down just the user's vms by changing the policy files.. | 10:41 |
tyagiprince | I changed the compute:get_all rule to display just the instances where the user_id matches.. But it does not work | 10:41 |
*** rk4n has quit IRC | 10:42 | |
tyagiprince | anyone? | 10:44 |
tyagiprince | familiar with policy rules? | 10:45 |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add FC attached volumes support https://review.openstack.org/258617 | 10:46 |
*** thorst has joined #openstack-nova | 10:46 | |
*** ndipanov has joined #openstack-nova | 10:47 | |
*** ljxiash has joined #openstack-nova | 10:48 | |
*** jistr has joined #openstack-nova | 10:51 | |
*** thorst has quit IRC | 10:53 | |
*** mleroy has joined #openstack-nova | 10:54 | |
*** lpetrut1 has joined #openstack-nova | 10:55 | |
*** markvoelker has joined #openstack-nova | 10:55 | |
openstackgerrit | jichenjc proposed openstack/nova: Stop using mox stubs in nova.tests.unit.console https://review.openstack.org/266837 | 10:56 |
*** lpetrut has quit IRC | 10:56 | |
*** lpetrut1 is now known as lpetrut | 10:56 | |
*** markvoelker has quit IRC | 11:00 | |
*** haomaiwang has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-nova | 11:01 | |
*** daemontool_ has joined #openstack-nova | 11:01 | |
sakthi | fraid yeah - editing the image with `guestfish`. | 11:03 |
sakthi | sorry | 11:03 |
sakthi | required to find instance reboot time? any suggestion | 11:03 |
*** aysyd has joined #openstack-nova | 11:03 | |
sakthi | if vm has restarted from inside, its hard to record the downtime from virsh components | 11:04 |
sakthi | how to find vm has restarted inside the vm | 11:04 |
*** daemontool has quit IRC | 11:05 | |
*** jaosorior has quit IRC | 11:05 | |
*** jaosorior has joined #openstack-nova | 11:05 | |
*** jaosorior has quit IRC | 11:06 | |
*** jaosorior has joined #openstack-nova | 11:07 | |
johnthetubaguy | tyagiprince: there are two sets of rules, api and compute rules | 11:09 |
*** gibi has quit IRC | 11:09 | |
johnthetubaguy | tyagiprince: but I would try on #openstack for usage information | 11:09 |
*** gcb has quit IRC | 11:09 | |
*** rdopiera has quit IRC | 11:10 | |
*** s1rp_ has quit IRC | 11:10 | |
*** s1rp has joined #openstack-nova | 11:11 | |
*** gibi has joined #openstack-nova | 11:11 | |
*** gcb has joined #openstack-nova | 11:14 | |
*** rdopiera has joined #openstack-nova | 11:17 | |
*** lucas-dinner is now known as lucasagomes | 11:18 | |
*** aarefiev has quit IRC | 11:20 | |
*** aarefiev has joined #openstack-nova | 11:21 | |
garyk | danpb: have hit a very odd bug with libvirt and maybe you can point me in a direction here. try and spin up an instance with 4 nics attached. the libvirt xml file is created with 5 nics (and one is a dupe) => this leads to libvirtError: Unable to create tap device tapccfd7edd-74: Device or resource busy | 11:21 |
danpb | hehe that's fun | 11:23 |
danpb | i guess you'll want to look at nova-compute.log to seeat what point the extra nic appears | 11:23 |
danpb | i expect something will be mangling the network info before it even gets to the libvirt driver | 11:24 |
garyk | i did that and it appear that there are 4 entries passed to the libvirt driver. | 11:24 |
garyk | danpb: fyi https://bugs.launchpad.net/nova/+bug/1533572 | 11:26 |
openstack | Launchpad bug 1533572 in OpenStack Compute (nova) "Failed to create vm on kvm while boot with multiple nics" [Undecided,New] | 11:26 |
danpb | that bug shows 7 nics in the xml | 11:27 |
danpb | 3 pairs have identical mac | 11:27 |
*** aix has joined #openstack-nova | 11:28 | |
danpb | garyk: can you attach the full nova-compute.log file showing it | 11:30 |
garyk | sure will do | 11:31 |
danpb | the code generating the xml just iterates over 'network_info' - so that must get mangled somewhere to include 7 entries | 11:32 |
*** Marga_ has joined #openstack-nova | 11:33 | |
openstackgerrit | Dina Belova proposed openstack/python-novaclient: Add profiling support to novaclient https://review.openstack.org/254699 | 11:34 |
danpb | garyk: could be related to scrambled network info cache https://review.openstack.org/#/c/260462/ https://review.openstack.org/#/c/265363/ | 11:34 |
*** ferest has joined #openstack-nova | 11:34 | |
*** rk4n has joined #openstack-nova | 11:34 | |
*** gszasz has joined #openstack-nova | 11:35 | |
openstackgerrit | xiexs proposed openstack/nova: Add sriov info for live migration https://review.openstack.org/255193 | 11:36 |
openstackgerrit | xiexs proposed openstack/nova: Add checking logic for sriov migration https://review.openstack.org/266853 | 11:36 |
*** mdbooth has quit IRC | 11:36 | |
*** gongysh_ has quit IRC | 11:37 | |
ndipanov | danpb, garyk yeah there are several patches for it up | 11:37 |
danpb | ndipanov: can you comment on that bug garyk shows above | 11:37 |
ndipanov | yeah will do | 11:37 |
*** ferest_ has quit IRC | 11:37 | |
*** rk4n has quit IRC | 11:38 | |
*** mdbooth has joined #openstack-nova | 11:38 | |
*** lyanchih has quit IRC | 11:41 | |
*** gszasz has quit IRC | 11:42 | |
*** gszasz has joined #openstack-nova | 11:42 | |
*** houming has quit IRC | 11:42 | |
*** smatzek has joined #openstack-nova | 11:42 | |
openstackgerrit | esracelik proposed openstack/nova: Config options: centralize section "cells" https://review.openstack.org/260181 | 11:43 |
*** aix has quit IRC | 11:43 | |
pkoniszewski | danpb: hey, there? I have one question according to your comment in https://review.openstack.org/#/c/227278/26/nova/virt/libvirt/driver.py | 11:44 |
*** zenoway has quit IRC | 11:44 | |
*** haomaiwang has quit IRC | 11:44 | |
*** zenoway has joined #openstack-nova | 11:44 | |
*** kmartin has quit IRC | 11:45 | |
danpb | pkoniszewski: hi | 11:45 |
*** ndipanov has quit IRC | 11:45 | |
pkoniszewski | danpb: hi, so, you suggested to ignore BDM entirely, but I'm not sure how can I know from instance's XML which block/file disks are shared | 11:46 |
pkoniszewski | danpb: I've checked what libvirt knows about cinder volumes attached through nova and it says that such devices are not shareable, so it will try to block live migrate volumes (in existing logic without my patches) | 11:48 |
*** ndipanov has joined #openstack-nova | 11:48 | |
openstackgerrit | Moshe Levi proposed openstack/nova: ironic driver: Adding InfiniBand support https://review.openstack.org/266540 | 11:48 |
*** haomaiwang has joined #openstack-nova | 11:48 | |
garyk | danpb: ndipanov: yes, it may be related to thioe | 11:48 |
pkoniszewski | danpb: so at least I would need to get block devices from BDM and skip them when parsing XML | 11:48 |
pkoniszewski | danpb: nova knows that these are cinder devices and are shared so I wouldn't need to do anything hacky | 11:49 |
danpb | pkoniszewski: hmm, yes, that would work | 11:49 |
ndipanov | garyk, yeah let me dig up 3 patches that try to fix this | 11:49 |
*** zenoway has quit IRC | 11:49 | |
danpb | get a list of all devices from the XML, and then use the BDM to filter out ones we don't want to copy | 11:49 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments https://review.openstack.org/193135 | 11:49 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments https://review.openstack.org/193134 | 11:49 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: db and obj: Allow multiple volume attachments https://review.openstack.org/193133 | 11:49 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 11:49 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: virt: Pass host when call attach to Cinder https://review.openstack.org/256273 | 11:50 |
pkoniszewski | danpb: okay, thanks for the confirmation, i'll give it a shot and we will see how it behaves | 11:50 |
openstackgerrit | esracelik proposed openstack/nova: Config options: centralize "configdrive" options https://review.openstack.org/254092 | 11:50 |
*** thorst has joined #openstack-nova | 11:51 | |
*** pkholkin has quit IRC | 11:51 | |
*** gongysh has joined #openstack-nova | 11:51 | |
johnthetubaguy | gibi: just added some comments on here: https://review.openstack.org/#/c/245678/30 | 11:51 |
ndipanov | garyk, https://review.openstack.org/#/c/252565/ | 11:52 |
*** Marga_ has quit IRC | 11:52 | |
ndipanov | garyk, that in is the closest to an acceptable solution | 11:52 |
*** Marga_ has joined #openstack-nova | 11:52 | |
ndipanov | sadly really fixing this is not quite so easy :( | 11:52 |
*** tdurakov has quit IRC | 11:53 | |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add FC attached volumes support https://review.openstack.org/258617 | 11:54 |
*** daemontool_ has quit IRC | 11:54 | |
garyk | ndipanov: that whole layer or unndecesary caching is so problematic and i cannot let you know how much time i have spent dealing with broken stuff here. | 11:55 |
ndipanov | yeah it's not great | 11:55 |
garyk | we should really throw away the neutron integration and write it from scratch. and then we can party like its 1984 | 11:55 |
ndipanov | garyk, yeah but that thing is even in a layer above | 11:56 |
*** MVenesio has joined #openstack-nova | 11:56 | |
ndipanov | imho the network_api is a broken abstraction | 11:56 |
*** markvoelker has joined #openstack-nova | 11:56 | |
garyk | :) | 11:56 |
ndipanov | though neutron integration is more broken | 11:56 |
ndipanov | no idea | 11:56 |
ndipanov | I am actually a bit sad about that bug | 11:57 |
*** EinstCrazy has joined #openstack-nova | 11:57 | |
ndipanov | it's embarrassing | 11:57 |
*** daemontool has joined #openstack-nova | 11:57 | |
garyk | :) | 11:57 |
*** pkholkin has joined #openstack-nova | 11:57 | |
garyk | we all have perfect vision in hindsight | 11:58 |
ndipanov | right | 11:58 |
openstackgerrit | esracelik proposed openstack/nova: Config options: centralize section "hyperv" https://review.openstack.org/255124 | 11:58 |
*** carey has joined #openstack-nova | 11:58 | |
ndipanov | so would you mind grabbing the patch I pointed to and seeing if it does it for you if you have a sec | 11:58 |
ndipanov | garyk, ^ | 11:58 |
*** thorst has quit IRC | 11:59 | |
garyk | will check. stepping out for a bite and will let you know a littler later | 11:59 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 11:59 |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli https://review.openstack.org/266687 | 11:59 |
johnthetubaguy | ndipanov: totally agreed about the abstraction being broken, I remember discussions of making it better match the neutron API, then change nova-network's interface to match that, so its easier to drop. I know few folks have looked at the issue, but they all mostly ran away (screaming) | 12:00 |
ndipanov | johnthetubaguy, I don't blame them - I remember the discussion from paris summit | 12:00 |
johnthetubaguy | yeah, its a thorny issue | 12:00 |
*** markvoelker has quit IRC | 12:00 | |
*** haomaiwang has quit IRC | 12:01 | |
*** tdurakov has joined #openstack-nova | 12:01 | |
*** aix has joined #openstack-nova | 12:01 | |
*** haomaiwang has joined #openstack-nova | 12:01 | |
*** doug-fish has joined #openstack-nova | 12:01 | |
ndipanov | johnthetubaguy, one thing that I missed in that data migration patch btw: https://review.openstack.org/#/c/266560/ | 12:01 |
*** tyagiprince has quit IRC | 12:01 | |
ndipanov | and these two may be interesting for you as well https://review.openstack.org/#/c/262938/ | 12:02 |
ndipanov | IMHO this is quite good work | 12:02 |
*** carey has quit IRC | 12:03 | |
*** wasmum- has quit IRC | 12:03 | |
johnthetubaguy | ndipanov: ah, I see that eliminate duplication patch now, I didn't see that one before, good stuff | 12:03 |
ndipanov | I have ot look at that one more closely yes | 12:04 |
*** salv-orlando has quit IRC | 12:05 | |
*** baoli has joined #openstack-nova | 12:05 | |
*** salv-orlando has joined #openstack-nova | 12:05 | |
*** vladikr has quit IRC | 12:06 | |
*** baoli has quit IRC | 12:08 | |
*** devananda has quit IRC | 12:08 | |
*** sudipto has quit IRC | 12:08 | |
*** xianghui has quit IRC | 12:09 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266690 | 12:10 |
*** xianghui has joined #openstack-nova | 12:11 | |
*** devananda has joined #openstack-nova | 12:12 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Handle SetAdminPasswdNotSupported raised by libvirt driver https://review.openstack.org/252850 | 12:13 |
tdurakov | pkoniszewski, hi, are you around? | 12:16 |
*** baoli has joined #openstack-nova | 12:16 | |
pkoniszewski | tdurakov: hi, im there | 12:16 |
tdurakov | so, about ps-25 | 12:17 |
tdurakov | have you tested it locally? | 12:17 |
pkoniszewski | i had whole series applied | 12:17 |
tdurakov | pkoniszewski, so, it worked locally, right? | 12:18 |
*** baoli has quit IRC | 12:18 | |
pkoniszewski | locally whole series worked | 12:18 |
tdurakov | on nfs? | 12:18 |
pkoniszewski | without nfs | 12:18 |
openstackgerrit | esracelik proposed openstack/nova: Improve the help text for configdrive options https://review.openstack.org/266875 | 12:18 |
tdurakov | block-migration? | 12:19 |
pkoniszewski | yes | 12:19 |
tdurakov | ok, deployed env for to check things, will apply your patches and test with nfs | 12:19 |
*** paul-carlton1 has joined #openstack-nova | 12:19 | |
pkoniszewski | I need to reimplement this patch anyway | 12:19 |
*** zenoway has joined #openstack-nova | 12:20 | |
tdurakov | yep, need to check job too anyway | 12:20 |
tdurakov | btw, noticed multionode job in check pipeline fails from time-to-time with similar symptoms | 12:21 |
tdurakov | pkoniszewski, will ping you as have some results, thank you | 12:21 |
pkoniszewski | tdurakov: you are welcome | 12:22 |
*** omnipresent has joined #openstack-nova | 12:24 | |
*** zenoway has quit IRC | 12:24 | |
*** takedakn has joined #openstack-nova | 12:25 | |
tobasco | johnthetubaguy: bauzas alaski can we have some input on a good way to move forward in resolving this https://bugs.launchpad.net/nova/+bug/1469179 | 12:25 |
openstack | tobasco: Error: Could not gather data from Launchpad for bug #1469179 (https://launchpad.net/bugs/1469179). The error has been logged | 12:25 |
*** vivekd has quit IRC | 12:28 | |
*** atuvenie has quit IRC | 12:28 | |
*** dims has joined #openstack-nova | 12:28 | |
*** otter768 has joined #openstack-nova | 12:30 | |
*** vivekd has joined #openstack-nova | 12:32 | |
*** atuvenie has joined #openstack-nova | 12:33 | |
*** ociuhandu has quit IRC | 12:33 | |
*** otter768 has quit IRC | 12:35 | |
*** salv-orlando has quit IRC | 12:37 | |
*** salv-orlando has joined #openstack-nova | 12:37 | |
*** rk4n has joined #openstack-nova | 12:38 | |
*** Marga_ has quit IRC | 12:38 | |
*** rk4n has quit IRC | 12:39 | |
*** PaulMurray has quit IRC | 12:40 | |
*** rk4n has joined #openstack-nova | 12:40 | |
*** shaohe_feng has quit IRC | 12:42 | |
*** kaisers1 has joined #openstack-nova | 12:43 | |
*** rk4n has quit IRC | 12:43 | |
*** rk4n has joined #openstack-nova | 12:43 | |
*** thorst has joined #openstack-nova | 12:43 | |
*** rk4n has quit IRC | 12:46 | |
*** kaisers1 has quit IRC | 12:47 | |
*** rk4n has joined #openstack-nova | 12:47 | |
*** rk4n has quit IRC | 12:48 | |
*** mhorban_ has quit IRC | 12:49 | |
*** lyanchih has joined #openstack-nova | 12:50 | |
*** claudiub has joined #openstack-nova | 12:50 | |
*** atuvenie has quit IRC | 12:52 | |
*** atuvenie_ has joined #openstack-nova | 12:52 | |
*** EinstCrazy has quit IRC | 12:52 | |
*** EinstCrazy has joined #openstack-nova | 12:52 | |
*** rk4n has joined #openstack-nova | 12:52 | |
*** raildo-afk is now known as raildo | 12:55 | |
*** lyanchih has quit IRC | 12:55 | |
*** mhorban_ has joined #openstack-nova | 12:56 | |
*** rk4n has quit IRC | 12:56 | |
*** markvoelker has joined #openstack-nova | 12:57 | |
*** burgerk has joined #openstack-nova | 12:57 | |
*** takedakn has quit IRC | 12:58 | |
*** xyang1 has joined #openstack-nova | 12:58 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Add functional tests launcher for py3 env https://review.openstack.org/266895 | 12:58 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: DO NOTE MERGE: check that functional tests works on py34 env https://review.openstack.org/266896 | 12:58 |
*** rk4n has joined #openstack-nova | 12:59 | |
*** dane-fichter has joined #openstack-nova | 12:59 | |
*** haomaiwang has quit IRC | 13:01 | |
dane-fichter | dims: Do you have any idea what the source for that 'wmi is not defined' error is? Your port to python3 patch and my image signature patch are both failing the py34 gate because of it. | 13:01 |
*** 16WAAJ6X5 has joined #openstack-nova | 13:01 | |
*** markvoelker has quit IRC | 13:02 | |
*** links has quit IRC | 13:04 | |
*** ociuhandu has joined #openstack-nova | 13:04 | |
*** akshai has joined #openstack-nova | 13:04 | |
*** vivekd has quit IRC | 13:05 | |
openstackgerrit | Moshe Levi proposed openstack/nova: Sets binding:profile to empty dic when unbinding port https://review.openstack.org/261369 | 13:05 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: fixed log warning in sqlalchemy/api.py https://review.openstack.org/246901 | 13:06 |
*** browne has joined #openstack-nova | 13:07 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: fixed log warning in sqlalchemy/api.py https://review.openstack.org/246901 | 13:07 |
*** akshai has quit IRC | 13:08 | |
*** rcernin has joined #openstack-nova | 13:09 | |
tobasco | johnthetubaguy: seems like the bug we were talking about before has been up since mid 2014 | 13:10 |
tobasco | johnthetubaguy: see my latest comment in https://bugs.launchpad.net/nova/+bug/1469179, there is also atleast two other approaches that has been tried, once was to modify the DiskFilter for the nova scheduler which we have come up to is not an ideal solution | 13:11 |
openstack | Launchpad bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,In progress] - Assigned to Feodor Tersin (ftersin) | 13:11 |
*** svenno has joined #openstack-nova | 13:11 | |
*** akshai has joined #openstack-nova | 13:11 | |
*** mgoddard has quit IRC | 13:12 | |
*** mgoddard has joined #openstack-nova | 13:13 | |
bauzas | tobasco: johnthetubaguy: sorry in the middle of booking for the summit | 13:14 |
*** dslevin has quit IRC | 13:15 | |
*** ducttape_ has joined #openstack-nova | 13:15 | |
*** browne has quit IRC | 13:16 | |
openstackgerrit | jichenjc proposed openstack/nova: Not using mox stubs in nova.tests.unit.consoleauth https://review.openstack.org/266903 | 13:17 |
johnthetubaguy | tobasco: yes, we should not modify the diskfilter, thats for sure | 13:18 |
johnthetubaguy | well, at least, I don't think that makes sense given how it currently looks | 13:18 |
*** pradk has joined #openstack-nova | 13:19 | |
openstackgerrit | jichenjc proposed openstack/nova: Stop using mox stubs in nova.tests.unit.console https://review.openstack.org/266837 | 13:19 |
*** ccarmack has joined #openstack-nova | 13:20 | |
*** pradk has quit IRC | 13:23 | |
tobasco | johnthetubaguy: i think the solution på Feodor (see my last comment in on launchpad) is valid, it just needs some refreshing. This bug has been on launchpad atleast since August 2014, and as I said earlier I really wanna push for a fix for this. We are already running this fix in our staging environment for more testing | 13:23 |
*** vivekd has joined #openstack-nova | 13:23 | |
*** dustins has joined #openstack-nova | 13:23 | |
*** baoli has joined #openstack-nova | 13:25 | |
*** dims has quit IRC | 13:25 | |
*** dims has joined #openstack-nova | 13:26 | |
*** dslev has joined #openstack-nova | 13:27 | |
*** Daisy has joined #openstack-nova | 13:30 | |
*** markvoelker has joined #openstack-nova | 13:31 | |
*** browne has joined #openstack-nova | 13:31 | |
*** ferest has quit IRC | 13:34 | |
BobBall | johnthetubaguy: Reminder - could you comment on the fix at https://review.openstack.org/#/c/254022/ pls? :) | 13:34 |
*** ducttape_ has quit IRC | 13:35 | |
*** MCoLo has left #openstack-nova | 13:37 | |
*** baoli_ has joined #openstack-nova | 13:37 | |
*** edmondsw has joined #openstack-nova | 13:39 | |
*** burgerk has quit IRC | 13:40 | |
*** baoli has quit IRC | 13:40 | |
*** venkat_ has joined #openstack-nova | 13:40 | |
*** Daisy has quit IRC | 13:41 | |
*** MCoLo has joined #openstack-nova | 13:41 | |
*** Daisy has joined #openstack-nova | 13:42 | |
*** venkat_ has left #openstack-nova | 13:43 | |
*** 16WAAJ6X5 has quit IRC | 13:44 | |
*** rlrossit has joined #openstack-nova | 13:45 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 13:47 |
*** Daisy has quit IRC | 13:47 | |
*** cfriesen has joined #openstack-nova | 13:47 | |
*** jistr has quit IRC | 13:48 | |
*** jistr has joined #openstack-nova | 13:49 | |
*** unicell has joined #openstack-nova | 13:49 | |
rlrossit | johnthetubaguy: I talked with dims yesterday, and I would like to get oslo.messaging's separation of the rpc and notification queues into nova. It doesn't look to be that big, but would this still require a blueprint? | 13:49 |
*** unicell1 has quit IRC | 13:50 | |
*** browne has quit IRC | 13:50 | |
johnthetubaguy | rlrossit: we can add it into that generic oslo blueprint that is already approved, I think. | 13:50 |
rlrossit | johnthetubaguy: would that be https://blueprints.launchpad.net/nova/+spec/oslo-for-mitaka ? | 13:51 |
*** rook-desktio has quit IRC | 13:52 | |
*** vivekd has quit IRC | 13:53 | |
johnthetubaguy | rlrossit: thats the one | 13:53 |
tojuvone | jaypipes: Applied your comments: https://review.openstack.org/241562/ | 13:53 |
ildikov | johnthetubaguy: hi | 13:54 |
rlrossit | coolio I'll get to work on that then | 13:54 |
*** akshai has quit IRC | 13:54 | |
johnthetubaguy | ildikov: hi | 13:54 |
ildikov | johnthetubaguy: I know it's on your list, but may I ask haw far the multiattach series in the queue? | 13:54 |
*** MCoLo has quit IRC | 13:55 | |
ildikov | johnthetubaguy: I just would like to be sure I'll have time to fix additional comments if any | 13:55 |
*** dslev has quit IRC | 13:55 | |
johnthetubaguy | ildikov: had to take yesterday off work, so running behind right now | 13:55 |
jaypipes | tojuvone: coolio. will look again shiortly. | 13:55 |
ildikov | johnthetubaguy: also mriedem helps me out with tempest testing | 13:55 |
*** mtanino has joined #openstack-nova | 13:55 | |
*** gjayavelu has joined #openstack-nova | 13:55 | |
openstackgerrit | John Garbutt proposed openstack/nova: Fix sphinx warnings from signature_utils https://review.openstack.org/264745 | 13:56 |
*** eharney has joined #openstack-nova | 13:56 | |
ildikov | johnthetubaguy: ok, I got that, but if there's a chance to get to the series a bit sooner than later I would very much appreciate that | 13:56 |
*** Daisy has joined #openstack-nova | 13:57 | |
ildikov | johnthetubaguy: if there's anything that would be faster to discuss here, please ping me any time | 13:58 |
openstackgerrit | John Garbutt proposed openstack/nova: Get support matrix notes from the ini file https://review.openstack.org/264763 | 13:58 |
*** carey has joined #openstack-nova | 13:59 | |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add FC attached volumes support https://review.openstack.org/258617 | 14:00 |
*** vladikr has joined #openstack-nova | 14:00 | |
*** akshai has joined #openstack-nova | 14:00 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'ec2_instance' and 'instance_fault' https://review.openstack.org/261979 | 14:01 |
*** jichen has quit IRC | 14:01 | |
*** PaulMurray has joined #openstack-nova | 14:02 | |
*** dane-fichter has quit IRC | 14:02 | |
*** rmart04_ has joined #openstack-nova | 14:03 | |
*** rmart04 has quit IRC | 14:04 | |
*** rmart04_ is now known as rmart04 | 14:04 | |
*** carey has quit IRC | 14:04 | |
*** links has joined #openstack-nova | 14:04 | |
*** drankis has joined #openstack-nova | 14:05 | |
*** rk4n has quit IRC | 14:06 | |
tojuvone | jaypipes: Thanks :) | 14:06 |
*** drankis has quit IRC | 14:06 | |
*** rk4n has joined #openstack-nova | 14:06 | |
*** lyanchih has joined #openstack-nova | 14:07 | |
*** zz_dimtruck is now known as dimtruck | 14:07 | |
sdague | johnthetubaguy: I just sent an email about the project_id matching problem. If you could take a look, that would be great. I'm kind of stuck until we figure out a path forward here. | 14:07 |
*** ctrath has joined #openstack-nova | 14:08 | |
*** links has quit IRC | 14:09 | |
*** links has joined #openstack-nova | 14:09 | |
*** dslev has joined #openstack-nova | 14:10 | |
*** mdrabe has joined #openstack-nova | 14:10 | |
*** sudipto has joined #openstack-nova | 14:12 | |
*** annegentle has joined #openstack-nova | 14:14 | |
*** thumpba has joined #openstack-nova | 14:15 | |
*** pratikmallya has joined #openstack-nova | 14:15 | |
*** ildikov has quit IRC | 14:15 | |
openstackgerrit | Mike Fedosin proposed openstack/nova: [WIP] Make Xenplugin to work with glance v2 api https://review.openstack.org/266933 | 14:17 |
*** salv-orlando has quit IRC | 14:18 | |
*** ferest has joined #openstack-nova | 14:18 | |
*** salv-orlando has joined #openstack-nova | 14:18 | |
*** ljxiash_ has joined #openstack-nova | 14:19 | |
*** lyanchih has quit IRC | 14:20 | |
*** ljxiash has quit IRC | 14:20 | |
*** artom has joined #openstack-nova | 14:21 | |
johnthetubaguy | sdague: so that only works because the targets use letters other than a-f and keystone uuids doesn't include "-"? | 14:21 |
*** tojuvone is now known as tojuvone_away | 14:22 | |
*** baoli_ has quit IRC | 14:22 | |
*** haomaiwang has joined #openstack-nova | 14:22 | |
johnthetubaguy | sdague: if we wanted v2.1/extensions/abc and v2.1/{project-id}/abc would we would be screwed? or did I miss-read it? | 14:23 |
rlrossit | alright, this is probably a stupid question, but where are the tests for the rpc module? | 14:23 |
*** baoli has joined #openstack-nova | 14:23 | |
rlrossit | dansmith: I think I've become test blind | 14:23 |
*** haomaiwang has quit IRC | 14:24 | |
*** 21WAAR2TX has joined #openstack-nova | 14:24 | |
*** links has quit IRC | 14:25 | |
bauzas | tobasco: johnthetubaguy: so I'm back | 14:25 |
bauzas | tobasco: what do you want to do ? | 14:25 |
*** lyanchih has joined #openstack-nova | 14:25 | |
*** Daisy has quit IRC | 14:25 | |
*** w_verdugo has joined #openstack-nova | 14:25 | |
*** links has joined #openstack-nova | 14:25 | |
*** Daisy has joined #openstack-nova | 14:26 | |
*** diogogmt has quit IRC | 14:26 | |
*** mriedem has joined #openstack-nova | 14:26 | |
mriedem | ahoy | 14:26 |
bauzas | aloha | 14:27 |
*** dimtruck is now known as zz_dimtruck | 14:27 | |
*** baoli_ has joined #openstack-nova | 14:27 | |
*** READ10 has joined #openstack-nova | 14:28 | |
*** dslev has quit IRC | 14:29 | |
*** erlon has joined #openstack-nova | 14:29 | |
*** links has quit IRC | 14:29 | |
mriedem | if anyone is looking for something to do, we've had at least one CVE fix go into stable/liberty which will be in the upcoming 12.0.1 release, | 14:30 |
*** links has joined #openstack-nova | 14:30 | |
mriedem | and we need a release note for the CVE(s) that have gone in since 12.0.0 | 14:30 |
*** baoli has quit IRC | 14:30 | |
*** Daisy has quit IRC | 14:30 | |
*** otter768 has joined #openstack-nova | 14:31 | |
dansmith | rlrossit: okay, link me again and I can try to look after I get coffee | 14:31 |
mriedem | mdbooth: https://review.openstack.org/#/c/264814/ is almost to the gate | 14:32 |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli https://review.openstack.org/266687 | 14:32 |
mriedem | mdbooth: looks like you were going to redo https://review.openstack.org/#/c/264817/ ? | 14:32 |
mdbooth | mriedem: Again :) Yeah, I'll redo the stable backport when it lands. | 14:33 |
mdbooth | Might as well. | 14:33 |
*** thumpba has quit IRC | 14:33 | |
mriedem | mdbooth: i guess i don't understand the issue with the stable/liberty one that tonyb updated, | 14:34 |
mriedem | the commit id looks fine | 14:34 |
mriedem | https://review.openstack.org/#/c/264814/ | 14:34 |
mriedem | oops | 14:34 |
mriedem | 6ce0bb1fb017ee4094bb11500c2a418db3d6ec21 | 14:34 |
*** browne has joined #openstack-nova | 14:34 | |
*** lucasagomes is now known as lucas-hungry | 14:35 | |
mdbooth | Yeah, not sure what the rebase issue was. Perhaps gerrit was having an off day. | 14:35 |
mdbooth | Didn't see it myself. | 14:35 |
mriedem | i see the changes underneath failed jenkins, i'm looking into those | 14:35 |
mriedem | looks like large ops on stable/liberty is busted | 14:35 |
mdbooth | I've seen a ton of failures in that job over the last few days. | 14:36 |
*** otter768 has quit IRC | 14:36 | |
mriedem | hmm, ovh nodes | 14:36 |
mriedem | they are slower | 14:36 |
sdague | johnthetubaguy: no, that's fine still | 14:36 |
*** smatzek has quit IRC | 14:36 | |
rlrossit | dansmith: this isn't the fixed IP stuff, I haven't looked at that yet today. Now my problem is that I don't see any tests for nova.rpc that I can add to for my oslo.messaging change. I think I'm just bad at looking for tests | 14:36 |
sdague | we only get screwed if we have a top level resource which is only hex | 14:36 |
sdague | /v2.1/badcafe/foo | 14:36 |
mriedem | time to run sdague's failopotomus or whatever it's called | 14:36 |
mdbooth | Random thought, btw, would it be feasible for 'recheck' of something that failed in the gate to skip the 'check' queue next time round? | 14:37 |
tobasco | bauzas: would like to have your opinion in reviving this review https://review.openstack.org/#/c/200870/ | 14:37 |
mriedem | nope | 14:37 |
*** lyanchih has quit IRC | 14:37 | |
mdbooth | What's the thinking there? | 14:37 |
tobasco | mriedem: would appreciate if you could give a quick look aswell https://review.openstack.org/#/c/200870/ ty | 14:37 |
mdbooth | (or rtfm) | 14:37 |
*** lyanchih has joined #openstack-nova | 14:37 | |
mriedem | mdbooth: i think b/c something could have merged before it in the gate which makes it require a rebase for check | 14:38 |
mriedem | so putting it back into gate again is just a waste of time | 14:38 |
*** dslevin has joined #openstack-nova | 14:38 | |
dansmith | rlrossit: ah, well the tests for that are usually per service like compute/test_rpcapi if that's what you're looking for | 14:39 |
*** thumpba has joined #openstack-nova | 14:39 | |
mriedem | http://tinyurl.com/peuhlyp | 14:39 |
mriedem | it's not spiking... | 14:39 |
sdague | mdbooth / mriedem - or people recheck grind even though their patch is an issue, but it got a +A, so anyone can push it back to the gate queue and dos us. | 14:40 |
mriedem | http://tinyurl.com/j5u4nf5 | 14:40 |
mriedem | so large ops isn't spiking | 14:40 |
mdbooth | Maybe I've had a string of bad luck | 14:41 |
sdague | mriedem: that's all branches though | 14:41 |
mdbooth | Or more likely some kind of perception bias | 14:41 |
bauzas | tobasco: I feel the commit msg is good | 14:41 |
bauzas | tobasco: you got my blessing for resurrecting it | 14:41 |
sdague | I don't know if there is a good way to get a specific branch other than elastic recheck queries | 14:41 |
mriedem | sdague: yeah doing that now | 14:41 |
*** cdent has quit IRC | 14:42 | |
openstackgerrit | Andrey Pavlov proposed openstack/nova: remove EC2 legacy code https://review.openstack.org/266425 | 14:42 |
rlrossit | dansmith: but are those testing just the API, and indirectly testing that nova.rpc? I'm wondering because I can do some pretty nasty things to the nova.rpc module and none of the unit tests are stopping me | 14:42 |
mdbooth | sdague: Do check and gate share resources, btw? | 14:43 |
dansmith | rlrossit: ah, well a lot of it is inherited from oslo, so we might've removed (long ago) some coverage on that basis | 14:43 |
mriedem | sdague: interesting http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22failed%20to%20reach%20ACTIVE%20status%20and%20task%20state%20%5C%5C%5C%22None%5C%5C%5C%22%20within%20the%20required%20time%20(196%20s).%20Current%20status:%20BUILD.%20Current%20task%20state:%20scheduling.%5C%22%20AND%20tags:%5C%22console%5C%22%20AND%20build_name:*-large-ops&from=7d | 14:43 |
dansmith | rlrossit: what kind of things go undetected? | 14:43 |
mriedem | sdague: it's all branches, and it is spiking in failures since yesterday | 14:44 |
rlrossit | dansmith: not cleaning things up passed all tests | 14:44 |
mriedem | on all nodes | 14:44 |
*** mrkz has joined #openstack-nova | 14:44 | |
dansmith | rlrossit: use more words | 14:44 |
dansmith | rlrossit: like, I'm not sure why any dict cleanup would be needed in that code | 14:45 |
rlrossit | dansmith: commented out TRANSPORT.cleanup() in cleanup() let everything pass | 14:45 |
mriedem | there isn't even an n-net log here? http://logs.openstack.org/15/264815/2/check/gate-tempest-dsvm-large-ops/bdb7af7/logs/ | 14:45 |
*** EinstCrazy has quit IRC | 14:45 | |
rlrossit | dansmith: and, I changed over to make the notifier use oslo.messaging's new notification transport, and no that passed everything without changing any unit tests | 14:46 |
dansmith | rlrossit: well, I guess I'd have to look to see if that's surprising to me, but okay | 14:46 |
rlrossit | wow words are hard today | 14:46 |
dansmith | I mean, in general, what you're saying seems right(ly scary) but.. if it's from the really early days, we have a lot of stuff like that with super minimal coverage | 14:47 |
dansmith | good that you're uncovering it and fixing it though :) | 14:47 |
openstackgerrit | Daniel Berrange proposed openstack/nova: objects: add virtual 'image_meta' property to Instance object https://review.openstack.org/190145 | 14:47 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert to use instance.image_meta property https://review.openstack.org/190146 | 14:47 |
openstackgerrit | Daniel Berrange proposed openstack/nova: compute: convert manager to use nova.objects.ImageMeta https://review.openstack.org/189685 | 14:47 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Add functional tests launcher for py3 env https://review.openstack.org/266895 | 14:47 |
*** rk4n has quit IRC | 14:48 | |
rlrossit | dansmith: I'd be more than happy to uncover it and *not* fix it, but then I'd feel guilty | 14:48 |
dansmith | rlrossit: yep | 14:48 |
*** pradk has joined #openstack-nova | 14:49 | |
dims | mriedem : only 2 of those 22 on that logstash query is on build_branch master | 14:51 |
mriedem | yeah | 14:51 |
mriedem | well, | 14:51 |
mriedem | http://logs.openstack.org/15/264815/2/check/gate-tempest-dsvm-large-ops/bdb7af7/logs/ - there is no nova-network in dstat | 14:52 |
mriedem | kind of hard to boot an instance with networking when there is no networking service | 14:52 |
mriedem | i don't see any failures in devstack | 14:52 |
*** burt has joined #openstack-nova | 14:53 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: nova conf single point of entry: fix error message https://review.openstack.org/266959 | 14:55 |
*** davidlenwell has quit IRC | 14:57 | |
*** bklei has joined #openstack-nova | 14:58 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Use get_notification_transport() for notifications https://review.openstack.org/266960 | 14:58 |
rlrossit | dansmith: ^ is what originally caused my fear of unit tests not failing | 14:58 |
*** davidlenwell has joined #openstack-nova | 14:59 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [python3] byte/string conversions and enable more tests https://review.openstack.org/261045 | 15:00 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [python3] Port more code to python3 and enable tests https://review.openstack.org/262083 | 15:00 |
*** 21WAAR2TX has quit IRC | 15:01 | |
*** haomaiwang has joined #openstack-nova | 15:01 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications https://review.openstack.org/263788 | 15:01 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add service status notification https://review.openstack.org/245678 | 15:01 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Generate doc for versioned notifications https://review.openstack.org/265151 | 15:01 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add infra for versioned notifications https://review.openstack.org/247024 | 15:01 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications https://review.openstack.org/248167 | 15:02 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable https://review.openstack.org/247564 | 15:02 |
*** w_verdugo has quit IRC | 15:03 | |
johnthetubaguy | sdague: ah, yeah, thats what I was thinking. But it seems like the best compromise | 15:03 |
*** w_verdugo has joined #openstack-nova | 15:03 | |
mriedem | i have no idea what is causing this http://logs.openstack.org/15/264815/2/check/gate-tempest-dsvm-neutron-large-ops/1cdb7d6/logs/devstacklog.txt.gz#_2016-01-13_10_17_32_149 | 15:04 |
*** ducttape_ has joined #openstack-nova | 15:05 | |
*** artom has quit IRC | 15:05 | |
*** links has quit IRC | 15:07 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor https://review.openstack.org/266773 | 15:08 |
*** dave-mccowan has joined #openstack-nova | 15:09 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: DO NOTE MERGE: check that functional tests works on py34 env https://review.openstack.org/266896 | 15:09 |
*** burgerk has joined #openstack-nova | 15:10 | |
gibi | johnthetubaguy: I've respin the versioned notification chain based on your suggestions. I feel we are close. | 15:11 |
johnthetubaguy | gibi: it does feel close | 15:11 |
*** w_verdugo has quit IRC | 15:13 | |
mriedem | garyk: i noticed that vmware nsx ci failed on this https://review.openstack.org/#/c/231468/ | 15:13 |
mriedem | garyk: it's pretty trivial looking, but there is a backport proposed | 15:13 |
*** dave-mccowan has quit IRC | 15:13 | |
mriedem | so i'm hoping it's not a problem | 15:13 |
johnthetubaguy | gibi: we want to add the register_if(false) in the main code? | 15:14 |
johnthetubaguy | I mean, do we | 15:14 |
gibi | johnthetubaguy: I tried, everything works without that. What can go wrong? | 15:15 |
*** zz_dimtruck is now known as dimtruck | 15:15 | |
rlrossit | gibi: johnthetubaguy: which change had that in it? | 15:15 |
johnthetubaguy | gibi: heh, yeah, I think its just so its explicitly not registered, but its a nit for | 15:15 |
johnthetubaguy | rlrossit: https://review.openstack.org/#/c/247024/28/nova/objects/notification.py | 15:16 |
gibi | johnthetubaguy: ahh, so explicitness, good ideas, so others will not ask why it is not registered. | 15:16 |
*** cdent has joined #openstack-nova | 15:17 | |
*** sudipto has quit IRC | 15:17 | |
gibi | I'm editing right now... | 15:17 |
openstackgerrit | Moshe Levi proposed openstack/nova: Enhance PCI passthrough whitelist to support regex https://review.openstack.org/199488 | 15:17 |
rlrossit | wait those weren't registered before? huh good catch johnthetubaguy | 15:18 |
johnthetubaguy | rlrossit: yeah, they don't want to be registered, as they shouldn't really get used, they are just base objects | 15:18 |
moshele | mriedem: can you approve this https://review.openstack.org/#/c/261369/ again ? I had to rebase it | 15:18 |
openstackgerrit | Dan Smith proposed openstack/nova: Actually pass the migration data object down to the virt drivers https://review.openstack.org/248211 | 15:19 |
rlrossit | johnthetubaguy: but we still want to have them checked in the hashes right? | 15:19 |
openstackgerrit | Dan Smith proposed openstack/nova: Allow sending the migrate data objects over the wire https://review.openstack.org/251588 | 15:19 |
*** breitz has quit IRC | 15:19 | |
rlrossit | so it should still be a regular register | 15:19 |
mriedem | moshele: looking | 15:19 |
*** edtubill has joined #openstack-nova | 15:20 | |
rlrossit | but I guess since all the inheriting classes pick up on all of the fields, if we add a field in the base classes, it will enforce a version bump on all the subclasses, so I guess register_if(False) can work | 15:20 |
*** boris-42 has joined #openstack-nova | 15:20 | |
*** omnipresent has quit IRC | 15:20 | |
*** zenoway has joined #openstack-nova | 15:21 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Block flaky python34 test : vmwareapi.test_configdrive.ConfigDriveTestCase https://review.openstack.org/266976 | 15:21 |
dims | mriedem : one more bad test | 15:21 |
gibi | rlrossit: yeh the idea is that subclasses will be registered and the base class shall never be used directly | 15:22 |
johnthetubaguy | rlrossit: so, I am not sure how that works, thinking about it, I hope a change to the base would trigger all the subclasses hashes anyways? | 15:22 |
mriedem | moshele: done | 15:23 |
*** rk4n has joined #openstack-nova | 15:23 | |
moshele | mriedem: thanks | 15:23 |
rlrossit | johnthetubaguy: might have to check with dansmith, but as far as I understand, if we add a field, that's brought down through the magical inheritance of the register_if(False), so yeah, the subclasses should have a fingerprint change if something is added to the base classes | 15:24 |
dansmith | yep | 15:25 |
rlrossit | the register_if(False) bit is important though because that is what applies the class properties (putting fields as attributes on the object) | 15:25 |
dansmith | also yep | 15:25 |
*** READ10 has quit IRC | 15:25 | |
gibi | rlrossit, johnthetubaguy: OK, then I will put the register_if there | 15:25 |
johnthetubaguy | cool | 15:25 |
*** shyama has quit IRC | 15:25 | |
*** zenoway has quit IRC | 15:25 | |
*** shyama has joined #openstack-nova | 15:26 | |
*** READ10 has joined #openstack-nova | 15:27 | |
*** rk4n has quit IRC | 15:28 | |
*** armax has quit IRC | 15:28 | |
garyk | mriedem: will look into that | 15:28 |
*** liusheng has quit IRC | 15:28 | |
*** szhsong has quit IRC | 15:28 | |
*** szhsong has joined #openstack-nova | 15:29 | |
*** w_verdugo has joined #openstack-nova | 15:29 | |
*** ctrath has quit IRC | 15:30 | |
*** yamahata has joined #openstack-nova | 15:30 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications https://review.openstack.org/263788 | 15:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add service status notification https://review.openstack.org/245678 | 15:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Generate doc for versioned notifications https://review.openstack.org/265151 | 15:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add infra for versioned notifications https://review.openstack.org/247024 | 15:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications https://review.openstack.org/248167 | 15:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable https://review.openstack.org/247564 | 15:31 |
gibi | johnthetubaguy, rlrossit: fix is up ^^ | 15:31 |
*** dave-mcc_ has joined #openstack-nova | 15:32 | |
lxsli | PaulMurray: ping | 15:33 |
pkoniszewski | dansmith: hi, there? | 15:33 |
dansmith | pkoniszewski: yes | 15:33 |
*** shyama has quit IRC | 15:33 | |
PaulMurray | thanks lxsli | 15:34 |
*** tonytan4ever has joined #openstack-nova | 15:34 | |
*** ctrath has joined #openstack-nova | 15:34 | |
*** gjayavelu has quit IRC | 15:34 | |
*** mdrabe has quit IRC | 15:35 | |
*** lucas-hungry is now known as lucasagomes | 15:36 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 15:36 |
*** acabot_ has joined #openstack-nova | 15:36 | |
dave-mcc_ | https://review.openstack.org/#/c/254358 needs another workflow, please. the merge failed when a couple gate jobs timed out before they finished. | 15:36 |
mriedem | dave-mcc_: you just recheck that then | 15:37 |
mriedem | it doesn't require another +W | 15:37 |
mriedem | dave-mcc_: the elastic-recheck bot even commented on the change as to what known bug it failed with | 15:37 |
mriedem | and gives instructions | 15:37 |
gibi | johnthetubaguy: thanks! | 15:38 |
*** szhsong has quit IRC | 15:39 | |
*** acabot_ has quit IRC | 15:39 | |
dave-mcc_ | mriedem. thanks. i had thought that recheck wouldn't restart the merge. | 15:39 |
*** szhsong has joined #openstack-nova | 15:39 | |
mriedem | dave-mcc_: it will put it back in the check queue | 15:39 |
mriedem | if it passes there it goes to gate queue as normal | 15:39 |
mriedem | you can monitor it here http://status.openstack.org/zuul/ | 15:39 |
*** thangp has joined #openstack-nova | 15:40 | |
*** Sukhdev has joined #openstack-nova | 15:40 | |
mriedem | filer by 254358 | 15:40 |
mriedem | *filter | 15:40 |
*** fawadkhaliq has joined #openstack-nova | 15:40 | |
*** thangp has left #openstack-nova | 15:41 | |
*** acabot_ has joined #openstack-nova | 15:41 | |
johnthetubaguy | dansmith: have you got a sec to help remove my confusion around this change: https://review.openstack.org/#/c/193133/46 I am trying to think about the best way to make this backwards compatible | 15:41 |
dansmith | johnthetubaguy: yeah, I've looked at this a couple times | 15:41 |
dansmith | johnthetubaguy: to be honest, it concerns me | 15:41 |
johnthetubaguy | dansmith:yeah, me too | 15:42 |
mriedem | me 3! | 15:42 |
dansmith | johnthetubaguy: I kinda feel like the safest thing is to retool everything in nova to understand multiple attachments, then wait a cycle and then actually allow it to be used | 15:42 |
johnthetubaguy | actually just realised the bit I was missing, getting it back for a different instance | 15:42 |
dansmith | which I know is not a very popular position to take | 15:42 |
dansmith | right | 15:42 |
alaski | dansmith: +1 | 15:42 |
johnthetubaguy | I think thats the only safe way forward | 15:42 |
mriedem | so i think the point made was, | 15:43 |
mriedem | in what case(s) is db.block_device_mapping_get_by_volume_id( called | 15:43 |
johnthetubaguy | I mean we could check the service version, I suppose, but that seems too messy | 15:43 |
mriedem | and i think it's just the assisted snapshot case, which should be blocked in the multiattach series anyway | 15:43 |
dansmith | johnthetubaguy: well, that was my suggestion if we have to merge this, but it does get a little hairy doing it that way, because we'd be denying the second attach based on that in the api, | 15:44 |
mriedem | see volume_snapshot_create here: https://review.openstack.org/#/c/193134/69/nova/compute/api.py | 15:44 |
dansmith | johnthetubaguy: plus we have to have some way to atomically make sure we don't allow more than one until the version lifts | 15:44 |
*** sudipto has joined #openstack-nova | 15:44 | |
*** mgoddard_ has joined #openstack-nova | 15:45 | |
*** gongysh_ has joined #openstack-nova | 15:45 | |
johnthetubaguy | dansmith: true, APIs behind the LB doing different things again | 15:45 |
*** thangp has joined #openstack-nova | 15:45 | |
*** zenoway has joined #openstack-nova | 15:45 | |
dansmith | FWIW, you have four cores here pretty concerned about it :/ | 15:45 |
dansmith | three important ones and ... me | 15:46 |
mriedem | i'm just trying to understand the scenario where it falls down | 15:46 |
johnthetubaguy | alaski: dansmith: mriedem: seems like we are largely agreeing the safest approach is to add new tooling, move to it, then move the API across | 15:46 |
mriedem | let me comment in the review | 15:46 |
johnthetubaguy | I was missing that extra case, till just now, but yeah, this seems fairly tricky | 15:47 |
*** armax has joined #openstack-nova | 15:48 | |
tdurakov | sdague, hi, are you around? | 15:48 |
*** mgoddard has quit IRC | 15:48 | |
alaski | mriedem: it falls down for remove_volume_connection and _detach_volume and swap_volume in compute/manager | 15:49 |
alaski | on an older compute | 15:49 |
*** zenoway has quit IRC | 15:49 | |
mriedem | ah https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L4879 | 15:50 |
johnthetubaguy | mriedem: alaski: +1 | 15:50 |
mriedem | ah for detach we even have the instance https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L4700 | 15:50 |
mriedem | but didn't use it | 15:50 |
mriedem | same with swap | 15:50 |
johnthetubaguy | yep | 15:50 |
*** mragupat has joined #openstack-nova | 15:50 | |
dansmith | right, because all these assume the singular case | 15:50 |
mriedem | and that's where people were talking about doing a hack in stable/liberty to update those, but that's assuming people would update their liberty computes before deploying mitaka api | 15:51 |
mriedem | which we can't assume | 15:51 |
johnthetubaguy | seems like add the new method, this release, move this release to start using the new method, bump major version, add the support next release? | 15:51 |
johnthetubaguy | mriedem: yeah, I don't want to rely on that every release | 15:51 |
*** tojuvone_away is now known as tojuvone | 15:52 | |
johnthetubaguy | particular since we claim to support continuous deployment | 15:52 |
*** mdrabe has joined #openstack-nova | 15:52 | |
*** matrohon has quit IRC | 15:54 | |
dansmith | yeah, backporting something only to liberty to allow for this feature to land is pretty uncool | 15:55 |
dansmith | do it when we have to for a bug, but.. | 15:55 |
mriedem | i think i've doc'ed the case now https://review.openstack.org/#/c/193133/46/nova/db/sqlalchemy/api.py | 15:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/266160 | 15:55 |
*** diogogmt has joined #openstack-nova | 15:55 | |
mriedem | so it sounds like the only other possible solution is to check the compute service version before sending any multiattach requests | 15:55 |
mriedem | but i'm not clear on how that is done or where | 15:55 |
mriedem | btw, cinder meeting in 4 minutes where this will probably come up | 15:56 |
dansmith | mriedem: it's done by calling Service.get_minimum_version() | 15:56 |
mriedem | and if you have at least one liberty compute that will return the liberty compute version? | 15:56 |
dansmith | mriedem: but we have to be able to do that in a place/scenario where we can ensure that we're denying the second attach and not allow a race between first and second attach to allow both to continue | 15:56 |
dansmith | mriedem: yes | 15:57 |
*** kfarr has joined #openstack-nova | 15:57 | |
openstackgerrit | Rushi Agrawal proposed openstack/nova: Remove almost all mox from tests/unit/objects/test_instance.py https://review.openstack.org/264292 | 15:57 |
mriedem | well i'd guess we'd do it in the compute APIs attach method | 15:58 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 15:58 |
mriedem | we could check to see if the volume is a multiattach volume and if it already has at least one attachment (it's status would be in-use) | 15:58 |
dansmith | mriedem: where? in db_api? | 15:58 |
mriedem | could actually maybe be in the volume_api.check_attach method where the status checking is already happening on the volume | 15:58 |
mriedem | no i wasn't thinking db api | 15:59 |
dansmith | I don't think we can there | 15:59 |
mriedem | b/c concurrency? | 15:59 |
*** hemnafk is now known as hemna | 15:59 | |
*** garyk has quit IRC | 15:59 | |
*** devananda has quit IRC | 15:59 | |
* mriedem jumps to cinder meeting | 16:00 | |
dansmith | hmm, I guess if you check the service version first, then try to attach it.. | 16:00 |
*** carey has joined #openstack-nova | 16:00 | |
dansmith | there might be some ordering that lets cinder serialize for you , I dunno | 16:00 |
*** kmartin has joined #openstack-nova | 16:00 | |
dansmith | still seems worrisome | 16:00 |
johnthetubaguy | oh, using the in-use to serialize, basically | 16:00 |
johnthetubaguy | eek, possibly | 16:00 |
dansmith | well, | 16:00 |
dansmith | I don't know the semantics of the cinder call | 16:00 |
*** haomaiwang has quit IRC | 16:01 | |
dansmith | we'd depend heavily on those being right and not changing | 16:01 |
johnthetubaguy | oh, so there is an issue, I think... | 16:01 |
johnthetubaguy | another use could be attached to the volume, outside of nova | 16:01 |
mriedem | the compute api calls off to cinder to 'reserve' the volume before casting off to compute to actually attach | 16:01 |
mriedem | the reserve call puts the volume in-use | 16:01 |
mriedem | *sorry | 16:01 |
*** haomaiwang has joined #openstack-nova | 16:01 | |
mriedem | puts it in 'attaching' status | 16:01 |
mriedem | the compute call to cinder os-attach actually changes the volume status to in-use | 16:01 |
dansmith | and can we tell if multiples have done that atomically? | 16:01 |
*** devananda has joined #openstack-nova | 16:01 | |
mriedem | johnthetubaguy: well we don't support 'outside of nova' cases right? | 16:02 |
johnthetubaguy | yeah, I can't remember if multiples go to attaching? or just stay in-use? | 16:02 |
mriedem | we need hemna for that | 16:02 |
johnthetubaguy | mriedem: I was thinking cinder was adding that soon | 16:02 |
mriedem | johnthetubaguy: they have to go to attaching if already attached to one and you're attaching another | 16:02 |
mriedem | else the caller never knows when it can start hitting the mountpoint on that instance | 16:02 |
mriedem | i was talking to smcginnis about that last night b/c i'm writing the tempest test for this | 16:03 |
johnthetubaguy | I guess | 16:03 |
hemna | hey | 16:03 |
hemna | in cinder meeting at the moment | 16:03 |
mriedem | hemna: we can circle back after the cinder meeting | 16:03 |
*** bklei has quit IRC | 16:03 | |
hemna | ok | 16:03 |
mriedem | johnthetubaguy: L105 here: https://review.openstack.org/#/c/266605/2/tempest/api/compute/volumes/test_attach_volume.py | 16:04 |
*** carey has quit IRC | 16:05 | |
*** mjura has quit IRC | 16:06 | |
*** moshele has quit IRC | 16:09 | |
*** zenoway has joined #openstack-nova | 16:09 | |
*** rmart04 has quit IRC | 16:10 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 16:10 |
*** salv-orl_ has joined #openstack-nova | 16:10 | |
*** ljxiash_ has quit IRC | 16:11 | |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: deprecate live/block_migration_flag opts https://review.openstack.org/263436 | 16:12 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: remove the live/block_migration_flag opts https://review.openstack.org/263437 | 16:12 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: add a new live_migration_tunnelled config https://review.openstack.org/263434 | 16:12 |
*** artom has joined #openstack-nova | 16:12 | |
*** zhihaisong has joined #openstack-nova | 16:12 | |
*** ctrath has quit IRC | 16:12 | |
*** szhsong has quit IRC | 16:12 | |
*** ljxiash has joined #openstack-nova | 16:13 | |
*** salv-orlando has quit IRC | 16:13 | |
rlrossit | dansmith: alright, I'm confused. https://review.openstack.org/#/c/265444/ has basically identical logs to my FixedIP change (https://review.openstack.org/#/c/265951/) | 16:13 |
dansmith | both of those probably interact in instance.save() right? | 16:14 |
dansmith | have you checked to make sure those logs don't happen on other people's changes? | 16:14 |
*** zenoway has quit IRC | 16:14 | |
*** atuvenie_ has quit IRC | 16:14 | |
rlrossit | well, https://review.openstack.org/#/c/231689/ doesn't have it | 16:16 |
rlrossit | so did I introduce a bug in 265444? | 16:16 |
*** lyanchih has quit IRC | 16:16 | |
*** ctrath has joined #openstack-nova | 16:17 | |
*** klkumar has quit IRC | 16:17 | |
*** acabot_ has quit IRC | 16:18 | |
*** dims_ has joined #openstack-nova | 16:18 | |
*** lyanchih has joined #openstack-nova | 16:19 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Cleanup NovaObjectDictCompat from BandwidthUsage https://review.openstack.org/263638 | 16:20 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Cleanup NovaObjectDictCompat from NumaTopology https://review.openstack.org/260016 | 16:20 |
*** Marga_ has joined #openstack-nova | 16:20 | |
rlrossit | well wait https://review.openstack.org/#/c/247024/ has it so something in master must've started those up | 16:21 |
*** dims has quit IRC | 16:21 | |
*** acabot_ has joined #openstack-nova | 16:21 | |
dansmith | rlrossit: when did it start? | 16:22 |
*** ihrachys has quit IRC | 16:22 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Persist the request spec during an instance boot https://review.openstack.org/258628 | 16:22 |
*** smatzek has joined #openstack-nova | 16:23 | |
*** angdraug has joined #openstack-nova | 16:23 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: hacking: check for common double word typos https://review.openstack.org/249193 | 16:23 |
* rlrossit doesn't know logstash wizardry like mriedem | 16:23 | |
*** ferest has quit IRC | 16:24 | |
*** lyanchih has quit IRC | 16:24 | |
mriedem | link? | 16:24 |
*** tonytan4ever has quit IRC | 16:24 | |
rlrossit | mriedem: trying to find when these error messages started popping up http://logs.openstack.org/44/265444/1/check/gate-tempest-dsvm-full/eb4cac5/logs/screen-n-api.txt.gz?level=ERROR | 16:25 |
mriedem | known issue | 16:25 |
mriedem | https://review.openstack.org/#/c/265950/ | 16:25 |
mriedem | get that approved and released | 16:25 |
rlrossit | so those errors aren't being caused by me... | 16:26 |
rlrossit | dang | 16:26 |
dansmith | hah | 16:26 |
*** zenoway has joined #openstack-nova | 16:26 | |
mriedem | sdague: i answered your -1 here https://review.openstack.org/#/c/265950/ | 16:26 |
mriedem | would be nice to move on that | 16:26 |
mriedem | ftr, i don't know what a-hole introduced those... | 16:27 |
*** jdurgin1 has joined #openstack-nova | 16:27 | |
*** acabot_ has quit IRC | 16:28 | |
openstackgerrit | Russell Bryant proposed openstack/os-vif: Import of code from https://github.com/jaypipes/os_vif https://review.openstack.org/266377 | 16:28 |
pkoniszewski | dansmith: hi again, sorry for the delay | 16:30 |
*** ildikov has joined #openstack-nova | 16:30 | |
dansmith | pkoniszewski: you missed me, I'm not here anymore | 16:30 |
* dansmith jokes | 16:31 | |
danpb | does anyone know who the helpful people on the infra team are ? | 16:31 |
mriedem | danpb: all of them? | 16:31 |
* danpb is trying to get someone to deal with gerrit group membership for os-vif but just getting ignored on #openstack-infra | 16:31 | |
mriedem | danpb: fungi, clarkb, jeblair, anteaya | 16:31 |
danpb | mriedem: any specific people worthing pinging | 16:31 |
pkoniszewski | dansmith: I just ran an issue introduced by https://review.openstack.org/#/c/247720/ | 16:31 |
danpb | ah thanks | 16:31 |
pkoniszewski | into an issue * | 16:31 |
*** gcb has quit IRC | 16:31 | |
anteaya | danpb: what is up? | 16:32 |
*** otter768 has joined #openstack-nova | 16:32 | |
*** gcb has joined #openstack-nova | 16:32 | |
dansmith | pkoniszewski: what issue? | 16:32 |
pkoniszewski | dansmith: basically my patches to allow block live migration of an instance with attached volumes are failing, because there is missing "True" when converting migrate data object to legacy dict | 16:32 |
*** zhihaisong has quit IRC | 16:32 | |
*** szaher_ has joined #openstack-nova | 16:33 | |
*** gjayavelu has joined #openstack-nova | 16:33 | |
danpb | anteaya: we had the os-vif project added to infra just before xmas | 16:33 |
dansmith | pkoniszewski: link? | 16:33 |
danpb | anteaya: bt the os-vif-core group on gerrit is empty so i can't approve any patches or add any other reviews | 16:33 |
danpb | anteaya: are you able to add me to https://review.openstack.org/#/admin/groups/1175,members | 16:33 |
anteaya | danpb: right I saw you ask a few times the other day | 16:33 |
danpb | (my acct is with email addr berrange@redhat.com) | 16:33 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova-specs: spec update: centralize-config-options https://review.openstack.org/267014 | 16:33 |
anteaya | I don't have gerrit admin permissions so can't add you | 16:34 |
*** zakora has quit IRC | 16:34 | |
anteaya | danpb: let me time the request and I'll try to help | 16:34 |
*** zhihaisong has joined #openstack-nova | 16:34 | |
danpb | anteaya: do you know who would be a good person to ask | 16:34 |
anteaya | danpb: stand by | 16:34 |
danpb | thanks | 16:34 |
anteaya | danpb: just be in -infra and hang on | 16:34 |
danpb | ok | 16:34 |
anteaya | finishing one conversation and I have another on hold will try to get you in throught the gap | 16:34 |
pkoniszewski | dansmith: https://review.openstack.org/#/c/247719/10/nova/compute/manager.py line 5083 is missing pre_live_migrate_data=True parameter | 16:34 |
*** mpavone has quit IRC | 16:35 | |
pkoniszewski | dansmith: I see that you are adding it in https://review.openstack.org/#/c/248211/28/nova/compute/manager.py | 16:35 |
dansmith | pkoniszewski: I think if you allow my bottom patch to merge you can do away with that whole check | 16:35 |
*** nic has joined #openstack-nova | 16:36 | |
ildikov | johnthetubaguy: mriedem: dansmith: hi, sorry, I'm back, just read the logs | 16:36 |
*** mhorban_ has quit IRC | 16:37 | |
sdague | mriedem: it's still failing jenkins | 16:37 |
*** otter768 has quit IRC | 16:37 | |
pkoniszewski | dansmith: if you are sure that your bottom patch is "nearly" merged then it's fine... | 16:38 |
mriedem | sdague: ah, looking, doen't look like my issue though | 16:38 |
mdbooth | mriedem: Does the gate job literally just merge commits, then? I was under the impression that commits are somehow rebased in the process of being merged. | 16:38 |
mriedem | mdbooth: http://docs.openstack.org/infra/zuul/gating.html | 16:38 |
mdbooth | i.e. I was expecting my commit id to be different when it lands to what it is now. | 16:38 |
ildikov | johnthetubaguy: mriedem: dansmith: what if having an experimental flag for multiattach, which can be enabled ig the env is safe, so basically people can "play" with it in labs, etc. on top of that if that's possible we can also check the compute version | 16:39 |
mriedem | ildikov: let's wait to talk about multiattach until after the cinder meeting is over | 16:39 |
dansmith | pkoniszewski: sdague and danpb and mriedem would love to hit the merge button on that to help you out :P | 16:39 |
*** zhihais has joined #openstack-nova | 16:39 | |
ildikov | mriedem: yeah, thanks, sorry I just got to that part in the log | 16:40 |
*** Marga_ has quit IRC | 16:40 | |
mriedem | dansmith: https://review.openstack.org/#/c/248211/ is bottom now right? | 16:40 |
mriedem | i haven't looked at that yet | 16:40 |
*** Marga_ has joined #openstack-nova | 16:41 | |
dansmith | mriedem: aye | 16:41 |
*** zhihaisong has quit IRC | 16:41 | |
dansmith | mriedem: alex_xu has ripped it to hell and back, so I think it's good :D | 16:41 |
openstackgerrit | Brianna Poulos proposed openstack/nova: Catch UnsupportedAlgorithm exceptions https://review.openstack.org/267021 | 16:42 |
mriedem | there is always more flesh that can be sullied | 16:42 |
dansmith | I have no more to give | 16:42 |
*** mdrabe has quit IRC | 16:42 | |
mriedem | WRONG! | 16:42 |
dansmith | heh | 16:42 |
nic | mriedem: I am available if you have questions about https://review.openstack.org/205282 | 16:42 |
*** lyanchih has joined #openstack-nova | 16:43 | |
mriedem | dansmith: btw, watch this if you haven't yet http://www.imdb.com/title/tt2582802/ | 16:43 |
nic | I think I squashed all of your concerns in the review as of yesterday | 16:43 |
mriedem | nic: it's on the todo list | 16:43 |
sdague | mriedem: ok, so here is my issue https://review.openstack.org/#/c/265950/2/oslo_db/api.py is exactly the same functional change | 16:43 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: cleanup: Don't call import_opt for 'vcpu_pin_set' https://review.openstack.org/267022 | 16:43 |
nic | mriedem: I know; just trying to help you plan your day ;-) | 16:43 |
sdague | but was masked because of the nesting | 16:43 |
sdague | and that behavior is kind of nuts | 16:43 |
dansmith | mriedem: queueed | 16:44 |
pkoniszewski | dansmith: but... there is one piece missing in your change anyway, you fixed the issue, but there's no test coverage to make sure that we won't fall into this again | 16:44 |
sdague | mriedem: right? | 16:44 |
pkoniszewski | dansmith: from driver perspective it is needed because we do .get on all dicts so it might fail silently again | 16:44 |
dansmith | pkoniszewski: after this patch everything will break if you treat the thing as a dict in the driver | 16:45 |
dansmith | pkoniszewski: there is no .get() handler on the object | 16:45 |
mriedem | sdague: let me look at this again with fresh eyes when i'm not doing 3 things at once, | 16:45 |
mriedem | sdague: because yeah i agree this looks like i'm smoking crack (again) | 16:45 |
openstackgerrit | dane-fichter proposed openstack/nova: Add image signature verification https://review.openstack.org/189843 | 16:46 |
mriedem | sdague: oh wait you uploaded PS2 | 16:46 |
sdague | mriedem: yes | 16:46 |
mriedem | yeah then it is the same | 16:47 |
sdague | I reflowed the logic | 16:47 |
*** cdelatte has joined #openstack-nova | 16:47 | |
*** ptm__ has joined #openstack-nova | 16:47 | |
*** paul-carlton2 has quit IRC | 16:47 | |
mriedem | oh i see | 16:47 |
mriedem | that threw me | 16:47 |
*** gjayavelu has quit IRC | 16:47 | |
*** gangil has quit IRC | 16:47 | |
*** suro-patz has joined #openstack-nova | 16:48 | |
sdague | I was finding it hard to explain why I thought the logic was weird, so I redid it to make it more clear why I thought it was weird | 16:48 |
*** whenry has joined #openstack-nova | 16:48 | |
sdague | to the best of my understanding that's exactly the same resultant branch structure | 16:48 |
*** zhihais has quit IRC | 16:48 | |
mriedem | there is a problem in your change | 16:49 |
sdague | ectxt.reraise value is irrelevant for the exception block, because all db errors will be true for that | 16:49 |
*** bradjones has quit IRC | 16:49 | |
mriedem | it will re-introduce the original bug i was trying to fix | 16:49 |
mriedem | which is don't trace on expected db errors | 16:49 |
*** ipbabble has quit IRC | 16:49 | |
mriedem | at least until the last iteration | 16:50 |
sdague | mriedem: it's the same logic as you had though | 16:50 |
sdague | mriedem: what do you mean until the last iteration? | 16:50 |
mriedem | mine took ectxt.reraise into account | 16:50 |
pkoniszewski | dansmith: got it, i will give it a shot with my patches on top of these changes | 16:50 |
pkoniszewski | dansmith: thanks | 16:50 |
mriedem | sdague: i commented in the review | 16:50 |
*** bradjones has joined #openstack-nova | 16:50 | |
*** bradjones has quit IRC | 16:50 | |
*** bradjones has joined #openstack-nova | 16:50 | |
*** PaulMurray has quit IRC | 16:50 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Add functional tests launcher for py3 env https://review.openstack.org/266895 | 16:50 |
dansmith | pkoniszewski: cool | 16:51 |
sdague | mriedem: oh, because there is a not | 16:51 |
mriedem | yar | 16:51 |
*** zhihais has joined #openstack-nova | 16:51 | |
mriedem | so maybe we just remove the LOG.exception in the retry block | 16:51 |
mriedem | b/c it will trace before reraising when it's run out of retries anyway | 16:51 |
*** rcernin has quit IRC | 16:51 | |
sdague | ok so | 16:51 |
sdague | self._is_exception_expected(e) is always true if e is a db.error | 16:52 |
sdague | per L175 | 16:52 |
sdague | which means that if e is a db_error | 16:52 |
sdague | ectxt is always false | 16:52 |
sdague | which means if ectxt.reraise and isinstance(e, self.db_error): | 16:52 |
sdague | is "if False and isinstance(e, self.db_error):" | 16:52 |
*** gszasz has quit IRC | 16:53 | |
mriedem | yeah, got that | 16:53 |
sdague | which means you should actually just delete that code | 16:53 |
sdague | because it will always evaluate to False | 16:53 |
mriedem | which you do in ps2 | 16:53 |
mriedem | i don't have a problem with that | 16:53 |
*** mtanino has quit IRC | 16:54 | |
sdague | which means your change is actually https://review.openstack.org/#/c/265950/3/oslo_db/api.py | 16:55 |
sdague | right? | 16:55 |
mriedem | i think so | 16:56 |
sdague | which, if that's your change, that's fine. But it should be that change, so it's clear. | 16:56 |
mriedem | the only thing with that is if e is like OverQuota from nova (not a db_error in this code), we don't log it here at all, | 16:57 |
mriedem | but maybe that's ok | 16:57 |
*** ccarmack has left #openstack-nova | 16:57 | |
sdague | mriedem: right, but you wouldn't in ps1 | 16:57 |
*** mgoddard_ has quit IRC | 16:57 | |
*** mgoddard has joined #openstack-nova | 16:57 | |
sdague | sorry, that was the crux of my -1. This seemed a really round about way to express what's happening. | 16:57 |
mriedem | true | 16:57 |
mriedem | which is also what my test was added for | 16:58 |
*** suro-patz has quit IRC | 16:58 | |
mriedem | ok, let me clean up the commit message and then we'll be good i think | 16:59 |
mriedem | and add you as co-author | 16:59 |
sdague | right, sure, though there was no test to make sure you got into that block in the first place | 16:59 |
mriedem | yeah | 16:59 |
sdague | yeh, I'm ok with the result here, I just didn't like the indirection | 16:59 |
*** dustins has quit IRC | 16:59 | |
mriedem | i don't like when we fight sean :/ | 16:59 |
*** atuvenie has joined #openstack-nova | 16:59 | |
mriedem | i like making up | 16:59 |
dansmith | .... | 17:00 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/nova: Ironic: Lightweight fetching of nodes https://review.openstack.org/221848 | 17:00 |
*** jlanoux has quit IRC | 17:00 | |
mriedem | i took it there | 17:00 |
mriedem | deal with it | 17:00 |
dansmith | hah | 17:00 |
*** haomaiwang has quit IRC | 17:01 | |
*** haomaiwang has joined #openstack-nova | 17:01 | |
*** salv-orl_ has quit IRC | 17:03 | |
*** lyanchih has quit IRC | 17:03 | |
*** nkrinner has quit IRC | 17:03 | |
*** salv-orlando has joined #openstack-nova | 17:03 | |
*** gangil has joined #openstack-nova | 17:05 | |
*** gangil has joined #openstack-nova | 17:05 | |
*** nic has quit IRC | 17:06 | |
*** drankis has joined #openstack-nova | 17:07 | |
*** gjayavelu has joined #openstack-nova | 17:08 | |
*** jistr has quit IRC | 17:08 | |
scottda | Does anyone know if the OpenStack Client has support for microversions/ | 17:08 |
scottda | ? | 17:08 |
*** nic has joined #openstack-nova | 17:08 | |
*** mdrabe has joined #openstack-nova | 17:09 | |
*** _diana_1 has joined #openstack-nova | 17:09 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.firewall' options https://review.openstack.org/257995 | 17:10 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.netutils' options https://review.openstack.org/258009 | 17:10 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'virt.images' conf options documentation https://review.openstack.org/259553 | 17:10 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.imagecache' options https://review.openstack.org/258984 | 17:10 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.images' options https://review.openstack.org/258004 | 17:10 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.disk' options https://review.openstack.org/258912 | 17:10 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.driver' options https://review.openstack.org/257956 | 17:10 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'virt.driver' conf options documentation https://review.openstack.org/266364 | 17:10 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'virt.firewall' conf options documentation https://review.openstack.org/266365 | 17:10 |
sdague | scottda: it does not | 17:10 |
*** annegentle has quit IRC | 17:10 | |
*** sfinucan has quit IRC | 17:10 | |
sdague | mriedem: do I need to send your flowers? | 17:11 |
scottda | sdague: ok, thanks | 17:11 |
*** amotoki has quit IRC | 17:11 | |
mriedem | sdague: nah | 17:11 |
mriedem | chances are they'd be poisonous to our cats who would eat them and then die | 17:11 |
mriedem | and then you'd have to just send more flowers for the funeral | 17:11 |
mriedem | now, if there is a plant that is poisonous to 12 year old smelly noisy basset hounds, i'm on board with that | 17:12 |
*** apoorvad has joined #openstack-nova | 17:12 | |
mriedem | just don't let jaypipes know | 17:12 |
jaypipes | lol | 17:12 |
*** moshele has joined #openstack-nova | 17:13 | |
*** gjayavelu has quit IRC | 17:13 | |
*** pratikmallya has quit IRC | 17:13 | |
*** pratikmallya has joined #openstack-nova | 17:13 | |
sdague | heh | 17:14 |
sdague | ok, someone that knows python3 more, what is the value of a change like this - https://review.openstack.org/#/c/264652/3 ? | 17:14 |
mriedem | i'd ask haypo | 17:15 |
jroll | sdague: so the difference is that it will use xrange on python 2, which returns a generator rather than a list | 17:16 |
sdague | because as far as I can tell the end result is the same for our uses | 17:16 |
jroll | which is great for giant lists | 17:16 |
jroll | but looks like no value in this case | 17:16 |
sdague | right, for giant lists | 17:17 |
sdague | that you aren't going to expand | 17:17 |
dansmith | probably why it says "to improve consistency" and not "to make any real difference" | 17:17 |
*** pratikmallya has quit IRC | 17:18 | |
sdague | ok, except I thought we were going to avoid six when we didn't really need to care about the differences | 17:18 |
dansmith | not disagreeing :) | 17:19 |
dansmith | just point out out that the author seems to agree it's pointless :) | 17:19 |
mriedem | haypo said the same, said it seems useless | 17:19 |
sdague | ok, -2 | 17:19 |
cdent | sdague++ | 17:19 |
cdent | there seems to be a lot of this kind of thing going round lately | 17:19 |
*** _diana_1 is now known as diana_clarke | 17:19 | |
*** sahid has quit IRC | 17:19 | |
mriedem | see the rant thread on the ML | 17:20 |
*** paul-carlton2 has joined #openstack-nova | 17:20 | |
sdague | well, honestly, there is a lot in general | 17:20 |
hemna | hey | 17:20 |
sdague | I though the rant was about fixing gramar issues | 17:20 |
sdague | which I'm actually fine with | 17:20 |
*** mragupat has quit IRC | 17:20 | |
hemna | -2 missing .!!! | 17:20 |
hemna | :P | 17:20 |
ctrath | alaski: is there a known limit on the number of cells in a single cloud? | 17:20 |
mriedem | the rant was about if len(x) > 0 vs if x | 17:20 |
*** mragupat has joined #openstack-nova | 17:20 | |
mriedem | someone opened a bug and targeted it against like 20 projects | 17:21 |
mriedem | and started pushing global change patches on them | 17:21 |
alaski | ctrath: v1? | 17:21 |
ctrath | alaski: sure, given that v2 would only be theoretical at this point | 17:21 |
mriedem | cells v1 would be limited by rabbitmq talking between parent and child cells wouldn't it? | 17:22 |
*** thumpba has quit IRC | 17:22 | |
mriedem | which is kind of the same problem that cells in general is trying to solve | 17:22 |
alaski | ctrath: there's no known limit, but I'm not sure anyone has gotten past tens of cells | 17:22 |
diana_clarke | Speaking of trying to be useful, but perhaps just being a nuisance... | 17:22 |
*** thumpba has joined #openstack-nova | 17:22 | |
diana_clarke | I'm on maternity leave, but I'd still like to contribute when baby lets me. I have a couple of stubs.Set -> stub_out patches up for review. I figure I could try to remove the dependency on mox during my leave, unless these patches are more of nuisance for the core reviewers than help. Is there a sub-team for this, or anyone I should be coordinating with? Anything else I should know on this front? Thanks! | 17:22 |
mriedem | ctrath: ask the cern guys | 17:22 |
*** mragupat_ has joined #openstack-nova | 17:23 | |
mriedem | diana_clarke: there isn't a sub-team, just random people pushing random fixes for the same thing | 17:23 |
ctrath | mriedem: ok.. do they hang out on a specific channel? | 17:23 |
mriedem | ctrath: #openstack-operators | 17:23 |
ctrath | thx | 17:23 |
mriedem | ctrath: at some point i'm going to sound like a broken record | 17:23 |
openstackgerrit | Alexis Lee proposed openstack/nova: Catch errors while creating veth pair https://review.openstack.org/264146 | 17:24 |
*** krtaylor has quit IRC | 17:25 | |
sdague | diana_clarke: there is a blueprint for it | 17:25 |
sdague | so if the commit message matches that, they are easy to process | 17:26 |
mriedem | gerrit should also tell you if your change is conflicting with someone elses | 17:26 |
*** krtaylor has joined #openstack-nova | 17:26 | |
sdague | https://review.openstack.org/#/q/message:%22bp:remove-mox%22 | 17:26 |
mriedem | diana_clarke: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/remove-mox | 17:26 |
*** mragupat has quit IRC | 17:26 | |
sdague | I'll try to stay on top of +2ing these | 17:26 |
sdague | diana_clarke: also, congrats! | 17:26 |
diana_clarke | sdague: thanks! | 17:27 |
*** cdent has quit IRC | 17:27 | |
mdbooth | mriedem: It failed again :) Different test, though. Ah, well, maybe tomorrow's the lucky day. Recheck when it times out. | 17:27 |
*** ccarmack has joined #openstack-nova | 17:27 | |
mriedem | mdbooth: i'll be babysitting those b/c they are hodling up teh 12.0.1 release | 17:28 |
mriedem | so don't worry about it | 17:28 |
mdbooth | mriedem: Thanks! | 17:28 |
*** markus_z has quit IRC | 17:28 | |
mriedem | you can pay me in english candy when we're in bristol | 17:28 |
dansmith | tojuvone: around? | 17:28 |
mdbooth | hehe | 17:28 |
sdague | diana_clarke: looked at and +2ed your 2 patches here | 17:29 |
tojuvone | dansmith: Yes, here | 17:30 |
*** xyang1 has quit IRC | 17:31 | |
dansmith | tojuvone: how mad are you going to be at me if I ask you to split up your patch? | 17:31 |
*** tiagogomes_ has joined #openstack-nova | 17:31 | |
mriedem | i'm not sure if anyone knew this, but der kommissar is in town | 17:31 |
dansmith | tojuvone: touching api versions, db api, objects, etc all in one patch is pretty thick | 17:31 |
nic | mriedem: don't turn around, then | 17:31 |
tiagogomes_ | Hello, does nova already support multi-attach for volumes? If no, will Mitaka support it? | 17:31 |
dansmith | lol | 17:32 |
rlrossit | dansmith: grep -r "fixed.*\[.*\]" nova/ | more, add a liberal portion of patience, bake at 350 for about 30 minutes, and https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L47-L54 pops out | 17:32 |
*** mtanino has joined #openstack-nova | 17:32 | |
tojuvone | dansmith: ok, sure there is not much time left, but can do. | 17:32 |
rlrossit | that's why my exception was getting eaten by n-api | 17:32 |
dansmith | tojuvone: what if I do it for you/ | 17:32 |
*** fesp has joined #openstack-nova | 17:32 | |
dansmith | rlrossit: hah | 17:32 |
rlrossit | DictCompat: not even once | 17:33 |
dansmith | jaypipes: thoughts on that? | 17:33 |
tojuvone | dansmith: Thanks, that would be good :) | 17:33 |
*** annegentle has joined #openstack-nova | 17:33 | |
*** xyang1 has joined #openstack-nova | 17:33 | |
tojuvone | dansmith: then there was also that formal spec change | 17:34 |
dansmith | tojuvone: yeah, that's not so pressing | 17:34 |
diana_clarke | sdague: Thanks a ton! I'll try to keep them coming & remove the dependency before I return to work. | 17:34 |
mriedem | tiagogomes_: there is a series under review | 17:34 |
*** fesp has quit IRC | 17:34 | |
mriedem | tiagogomes_: https://review.openstack.org/#/q/topic:bp/volume-multi-attach | 17:34 |
mriedem | tiagogomes_: there are some issues | 17:34 |
sdague | diana_clarke: thanks much | 17:34 |
tojuvone | dansmith: yes | 17:34 |
jaypipes | dansmith: thoughts on what precisely? | 17:35 |
dansmith | jaypipes: splitting tojuvone's patch into the api bits and the db/objects bits | 17:35 |
dansmith | jaypipes: i think it will be pretty easy, I'm going to take a crack at it | 17:35 |
jaypipes | dansmith: oh... yeah, cool by me. | 17:36 |
tojuvone | dansmith, jaypipes: and if still some comments, I'll work them by tomorrow | 17:38 |
*** MVenesio has quit IRC | 17:38 | |
dansmith | tojuvone: I think jaypipes' comments were addressed, and I was just trying to wrap my head around the whole thing which made me think it needs splitting | 17:38 |
ndipanov | jaypipes, you may like this https://review.openstack.org/#/c/262939/ | 17:38 |
dansmith | tojuvone: after I split this I'll hopefully review and +2 the objects bits | 17:39 |
tojuvone | dansmith: yes, I think so too | 17:39 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Remove DictCompat from FixedIP https://review.openstack.org/265951 | 17:39 |
dansmith | tojuvone: so, I was able to split the patch without touching code.. that's a real good indication that it needed to be split :D | 17:40 |
jaypipes | ndipanov: thx for the heads up. added to my queue. | 17:40 |
mriedem | mdbooth: want to drop your -1 on this? https://review.openstack.org/#/c/264817/ | 17:41 |
mdbooth | mriedem: Sure. I'm assuming that my assumption about the changing commit id is incorrect? | 17:41 |
tojuvone | dansmith: Great :) Btw is the 21st also deadline for novaclient as it needs nova side to land first (and other microversions) | 17:41 |
mdbooth | i.e. it'll literally be a git merge, and therefore preserve it. | 17:41 |
mriedem | mdbooth: it is | 17:42 |
openstackgerrit | Dan Smith proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id} https://review.openstack.org/241562 | 17:42 |
openstackgerrit | Dan Smith proposed openstack/nova: Add object and database support for host_status API https://review.openstack.org/267062 | 17:42 |
mdbooth | mriedem: Cool, that was the only thing. | 17:42 |
dansmith | tojuvone: ^ | 17:42 |
mriedem | tojuvone: novaclient is more or less on it's own release schedule | 17:42 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add helper shim for getting items https://review.openstack.org/265995 | 17:43 |
mdbooth | mriedem: Done. | 17:43 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Remove DictCompat from ComputeNode https://review.openstack.org/265521 | 17:43 |
*** rmart04 has joined #openstack-nova | 17:43 | |
tojuvone | mriedem: I thought so, thanks | 17:43 |
*** Sukhdev has quit IRC | 17:47 | |
*** suro-patz has joined #openstack-nova | 17:47 | |
*** unicell has quit IRC | 17:47 | |
dansmith | tojuvone: a couple things on the first patch. I can do them for you but then I kinda lose the ability to +2 it ... | 17:48 |
*** paul-carlton2 has quit IRC | 17:50 | |
*** shyama has joined #openstack-nova | 17:50 | |
*** paul-carlton2 has joined #openstack-nova | 17:51 | |
*** sudipto has quit IRC | 17:52 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Allow block live migration of an instance with attached volumes https://review.openstack.org/227278 | 17:53 |
*** moshele has quit IRC | 17:54 | |
tojuvone | dansmith: Well if I can work out by the comments, let's see. | 17:55 |
*** rmart04 has left #openstack-nova | 17:56 | |
openstackgerrit | Russell Bryant proposed openstack/os-vif: Import of code from https://github.com/jaypipes/os_vif https://review.openstack.org/266377 | 17:56 |
*** raildo is now known as raildo-afk | 17:57 | |
*** cdent has joined #openstack-nova | 17:58 | |
openstackgerrit | Andrea Rosa proposed openstack/nova: Adding volume operations for shelved instances https://review.openstack.org/259528 | 17:58 |
dansmith | tojuvone: here is an example of the compat thing from another object: https://github.com/openstack/nova/blob/master/nova/objects/service.py#L135-L136 | 17:58 |
*** gangil has quit IRC | 17:59 | |
*** gangil has joined #openstack-nova | 17:59 | |
*** gangil has joined #openstack-nova | 17:59 | |
*** haomaiwang has quit IRC | 18:01 | |
*** carey has joined #openstack-nova | 18:01 | |
*** derekh has quit IRC | 18:01 | |
*** haomaiwang has joined #openstack-nova | 18:01 | |
tojuvone | dansmith: thanks, have to take a look. | 18:01 |
dansmith | tojuvone: actually, if you'll do the obj_make_compatible change, I'll do the test | 18:02 |
dansmith | tojuvone: probably not too bad for me to +2 when I just wrote a test :0 | 18:02 |
mriedem | mdbooth: well we figured out why n-net isn't starting on stable.. | 18:03 |
tojuvone | dansmith: Cool! | 18:03 |
mriedem | https://bugs.launchpad.net/devstack/+bug/1533777 | 18:03 |
openstack | Launchpad bug 1533777 in devstack "n-net doesn't start in gate-tempest-dsvm-large-ops job on stable/liberty but devstack doesn't fail" [Undecided,New] | 18:03 |
*** e0ne has quit IRC | 18:04 | |
*** ptm__ has quit IRC | 18:04 | |
*** carey has quit IRC | 18:05 | |
*** raildo-afk is now known as raildo | 18:06 | |
openstackgerrit | Anand Shanmugam proposed openstack/nova: Handle Instance Exceptions in add_fixed_ip and remove_fixed_ip https://review.openstack.org/266675 | 18:08 |
*** svenno has quit IRC | 18:08 | |
*** boris-42 has quit IRC | 18:08 | |
*** erlon has quit IRC | 18:08 | |
*** jed56 has quit IRC | 18:08 | |
*** yonglihe has quit IRC | 18:08 | |
*** wanghao has quit IRC | 18:08 | |
*** kgalanov has quit IRC | 18:08 | |
*** junjie has quit IRC | 18:08 | |
*** briancurtin has quit IRC | 18:08 | |
*** dougwig has quit IRC | 18:08 | |
*** zhenguo has quit IRC | 18:08 | |
*** auggy has quit IRC | 18:08 | |
*** carl_baldwin has quit IRC | 18:08 | |
*** patrickeast has quit IRC | 18:08 | |
*** sballe has quit IRC | 18:08 | |
*** ramishra_ has quit IRC | 18:08 | |
*** tpeoples has quit IRC | 18:08 | |
*** ameade has quit IRC | 18:08 | |
*** fmccrthy has quit IRC | 18:08 | |
*** DuncanT has quit IRC | 18:08 | |
*** serverascode has quit IRC | 18:08 | |
*** betherly has quit IRC | 18:08 | |
*** zhiyan has quit IRC | 18:08 | |
*** scottda has quit IRC | 18:08 | |
*** andrewbogott has quit IRC | 18:08 | |
*** angular_mike__ has quit IRC | 18:08 | |
dansmith | heh | 18:08 |
dansmith | guess we know who all is using irccloud | 18:08 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Add tag column to vifs and bdm https://review.openstack.org/264014 | 18:10 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Add metadata objects for device tagging https://review.openstack.org/264015 | 18:10 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging user visible changes https://review.openstack.org/264018 | 18:10 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Add compute manager device tagging support https://review.openstack.org/264017 | 18:10 |
ildikov | dansmith: :) | 18:10 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: vNIC tagging: libvirt driver implementation https://review.openstack.org/264016 | 18:10 |
*** tonytan4ever has joined #openstack-nova | 18:10 | |
*** Marga_ has quit IRC | 18:11 | |
*** gcb has quit IRC | 18:11 | |
*** gcb has joined #openstack-nova | 18:12 | |
*** lpetrut has quit IRC | 18:12 | |
mgagne | pkoniszewski I'm working on making live migration work again on our side and we found QEMU 2.0 to be broken in some way. Can you help? the destination target is getting fully provisioned instead of thin provisioned. | 18:12 |
*** zhihais has quit IRC | 18:12 | |
*** zhihais has joined #openstack-nova | 18:13 | |
*** serverascode has joined #openstack-nova | 18:14 | |
openstackgerrit | Tracy Jones proposed openstack/nova: Stop using mox stubs in test_configdrive https://review.openstack.org/265476 | 18:14 |
*** tjones has joined #openstack-nova | 18:14 | |
*** DuncanT has joined #openstack-nova | 18:14 | |
*** scottda has joined #openstack-nova | 18:14 | |
tjones | mriedem: https://review.openstack.org/#/c/265476/ i've addressed your comments. i have another patch that i am working on for set_stubs if that is ok | 18:15 |
ildikov | dansmith: johnthetubaguy: mriedem: can we continue the multiattach chat to figure out a kind of roadmap and a way to get most of the code in? | 18:15 |
*** rmart04 has joined #openstack-nova | 18:16 | |
mriedem | ildikov: so we were talking earlier about putting a compute service check in volume_api.check_attach such that if we were going to attach a multiattach volume, | 18:17 |
mriedem | we wouldn't do it if there were any liberty computes | 18:17 |
*** unicell has joined #openstack-nova | 18:17 | |
mriedem | *attach a multiattach volume that is already attached to 1 instance | 18:18 |
ildikov | mriedem: are we good if that's done? | 18:18 |
sdague | mriedem: ok, so right now Nova is using 27 test nodes for every change | 18:18 |
mriedem | the concern was around locking in case you get 2 concurrent attach requests on the same volume but different instanes | 18:18 |
*** andrewbogott has joined #openstack-nova | 18:18 | |
sdague | 5 of which are because of the duplicate constraints / non-constraints jobs | 18:18 |
ildikov | mriedem: my experimental flag idea was for the same purpose only let the user turn multiattach on | 18:18 |
*** ramishra_ has joined #openstack-nova | 18:18 | |
*** svenno has joined #openstack-nova | 18:19 | |
ildikov | mriedem: but that should be an issue in normal case too I would assume | 18:19 |
mriedem | ildikov: the compute service checking is at least a bit more dynamic, i.e. once all of your computes are at mitaka then it would be enabled | 18:19 |
*** rmart04 has quit IRC | 18:20 | |
mriedem | but the potential issue is any kind of race | 18:20 |
ildikov | I mean you need to check the volume in either case, if the service check is false, then you check a different status on the volume, but the check is still there | 18:20 |
mriedem | what happens if 2 concurrent requests come into cinder to reserve the same volume? | 18:20 |
*** SourabhP has joined #openstack-nova | 18:20 | |
ildikov | mriedem: but is this extra race? | 18:20 |
mriedem | the reserve call changes the volume status to 'attaching' | 18:20 |
dansmith | ildikov: we try not to have experimental features behind flags like that | 18:20 |
*** carl_baldwin has joined #openstack-nova | 18:21 | |
*** ameade has joined #openstack-nova | 18:21 | |
ildikov | dansmith: if we can figure out without that I'm supportive on that | 18:21 |
*** sballe has joined #openstack-nova | 18:21 | |
*** dustins has joined #openstack-nova | 18:21 | |
dansmith | well, we know how to do it without that | 18:21 |
dansmith | but it means N :/ | 18:21 |
mriedem | unless the compute version filtering could work right? | 18:21 |
*** erlon has joined #openstack-nova | 18:22 | |
ildikov | mriedem: if you check it here: https://review.openstack.org/#/c/193135/78/nova/virt/block_device.py multiattach is allowed if the volume is 'attached' | 18:22 |
ildikov | mriedem: so attaching is still not ok | 18:22 |
*** yonglihe has joined #openstack-nova | 18:22 | |
ildikov | dansmith: I don't think we need a new function in the BDM object | 18:22 |
*** wanghao has joined #openstack-nova | 18:23 | |
mriedem | my system is apparently garbage collecting on itself atm.... | 18:23 |
*** betherly has joined #openstack-nova | 18:23 | |
ildikov | although I know we need to ensure that we don't have multiple BDMs per instance until we have a mixed env | 18:23 |
*** patrickeast has joined #openstack-nova | 18:23 | |
mriedem | until we *dont* have a mixed env | 18:23 |
ildikov | dansmith: what about the compute version check? | 18:23 |
*** zhiyan has joined #openstack-nova | 18:24 | |
ildikov | mriedem: yes, sorry, so I meant that we need a full upgraded env with new computes to get it enabled | 18:24 |
*** tpeoples has joined #openstack-nova | 18:24 | |
dansmith | ildikov: well, that'd be the only way, but it also means gating an api feature dynamically, which is potentially confusing, as well as hard to get right | 18:24 |
*** Jeffrey4l has quit IRC | 18:25 | |
*** ericksonsantos has quit IRC | 18:25 | |
ildikov | dansmith: do you mean the tempest tests? | 18:25 |
mriedem | no | 18:25 |
*** dougwig has joined #openstack-nova | 18:25 | |
*** briancurtin has joined #openstack-nova | 18:25 | |
dansmith | no, I mean getting the api to actually behave properly, without races, and without surprising-to-the-client behavior | 18:26 |
*** patrickeast_ has joined #openstack-nova | 18:26 | |
*** patrickeast_ has quit IRC | 18:26 | |
ildikov | ok, sorry you wrote 'gating' so I got confused | 18:26 |
mriedem | feature toggling | 18:26 |
dansmith | yeah, ^ better word | 18:27 |
dansmith | s | 18:27 |
ildikov | a config option can solve this if the dynamical aspect is an issue | 18:27 |
ildikov | we can have the service check oadditionally | 18:27 |
ildikov | so if someone turns it on, but the env is still not good then it will not work | 18:28 |
dansmith | no | 18:28 |
*** ociuhandu has quit IRC | 18:28 | |
*** paul-carlton2 has quit IRC | 18:28 | |
dansmith | it means we're toggling the api-visible feature via config instead of dynamically, which isn't really better | 18:28 |
*** auggy has joined #openstack-nova | 18:29 | |
*** junjie has joined #openstack-nova | 18:29 | |
mriedem | i guess from a client perspective you'd get a 400 back on the 2nd attach call to the same volume | 18:29 |
mriedem | which is the same | 18:29 |
*** jed56 has joined #openstack-nova | 18:29 | |
*** SourabhP has quit IRC | 18:30 | |
*** dims_ has quit IRC | 18:30 | |
ildikov | yeah, the config would be false by default so it should not be different behaviour by default | 18:30 |
*** mgagne has quit IRC | 18:30 | |
dansmith | default is not the concern | 18:30 |
*** rcernin has joined #openstack-nova | 18:30 | |
openstackgerrit | Rafael Folco proposed openstack/nova: libvirt: check min required qemu/kvm versions on ppc64/ppc64le https://review.openstack.org/226555 | 18:30 |
*** diana_clarke has quit IRC | 18:31 | |
*** mgagne has joined #openstack-nova | 18:31 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: pci_request logic considers 'direct-physical' vnic type https://review.openstack.org/262584 | 18:31 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: Add utility method for getting the MAC addr https://review.openstack.org/262585 | 18:31 |
mriedem | ildikov: also, https://review.openstack.org/#/c/193135/78/nova/virt/block_device.py isn't a good place really to break things | 18:31 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: Update the port with a MAC address for PFs https://review.openstack.org/262586 | 18:31 |
*** kgalanov has joined #openstack-nova | 18:31 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment https://review.openstack.org/249018 | 18:31 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: adding support to specify a device_type in pci requests https://review.openstack.org/259254 | 18:31 |
*** mgagne is now known as Guest82803 | 18:31 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Add a vnic type for PF passthrough and a new libvirt vif driver https://review.openstack.org/262583 | 18:31 |
mriedem | ildikov: b/c by the time you get to https://review.openstack.org/#/c/193135/78/nova/virt/block_device.py the request has already cast off to the compute and the response was a 202 | 18:31 |
mriedem | ildikov: i was really talking about doing the validation in volume_api.check_attach | 18:31 |
*** dims has joined #openstack-nova | 18:32 | |
*** fmccrthy has joined #openstack-nova | 18:32 | |
*** Guest82803 is now known as mgagne | 18:32 | |
ildikov | mriedem: if that's called higher than compute it's good, I just saw that there's a check_attach call in block_device | 18:33 |
*** mgagne has quit IRC | 18:33 | |
*** mgagne has joined #openstack-nova | 18:33 | |
ildikov | I mean the file you linked | 18:33 |
mriedem | if do_check_attach is true | 18:33 |
*** otter768 has joined #openstack-nova | 18:33 | |
mriedem | which the compute manager passes false | 18:33 |
mriedem | sec | 18:33 |
mriedem | here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4675 | 18:34 |
*** _diana_1 has joined #openstack-nova | 18:34 | |
mriedem | it passes do_check_attach=False from the compute manager b/c it assumes we've already done that in the compute api | 18:34 |
mriedem | here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2988 | 18:34 |
ildikov | oh, that's perfect, we have the volume info | 18:35 |
mriedem | so volume_api.check_attach is really where you'd need to check (1) is the volume multiattach and (2) is it already attached to something and (3) are there any liberty computes, and if so, fail the request | 18:35 |
mriedem | which gives back the 400 to the client | 18:35 |
ildikov | I mean we have everything there we need and the API has to be upgraded first | 18:35 |
*** yamahata has quit IRC | 18:35 | |
dansmith | okay, so another wrinkle here | 18:35 |
dansmith | lets say you start up 32 API workers, | 18:36 |
ildikov | shoot | 18:36 |
dansmith | while you still have some liberty computes | 18:36 |
*** zhenguo has joined #openstack-nova | 18:36 | |
*** atuvenie has quit IRC | 18:36 | |
dansmith | you do one attach, which works because liberty is present, and caches that service version | 18:36 |
hemna | I'm back | 18:37 |
hemna | sorry, been a crazy morning. | 18:37 |
dansmith | then you do another, which fails because liberty and no multiattach allowed | 18:37 |
dansmith | then you upgrade your last liberty, | 18:37 |
dansmith | do an attach, that succeeds | 18:37 |
dansmith | then you do another attach, which goes to an older api worker, which still thinks liberty is around, and it fails | 18:37 |
dansmith | then another, hits a new worker, succeeds | 18:37 |
mriedem | b/c the compute version is cached | 18:37 |
*** otter768 has quit IRC | 18:38 | |
dansmith | mriedem: and because we _can't_ always check it from the db on every api request | 18:38 |
ildikov | but I assume the cahce is refreshed time to time | 18:38 |
dansmith | yes, ops should kill off all their api workers when they upgrade their last liberty node, but.. | 18:38 |
dansmith | ildikov: it's not, but that would make it worse | 18:38 |
ildikov | and it's still the better use case | 18:38 |
*** e0ne has joined #openstack-nova | 18:38 | |
*** aginwala has joined #openstack-nova | 18:38 | |
*** angular_mike__ has joined #openstack-nova | 18:38 | |
dansmith | ildikov: because as some of them refresh and not others, you get very inconsistent behavior within the caching interval (if there was one, which there is not) | 18:39 |
*** raildo is now known as raildo-afk | 18:39 | |
*** gjayavelu has joined #openstack-nova | 18:39 | |
ildikov | so it's still better to not allow it when you can use than the opposite case | 18:39 |
ildikov | dansmith: so the cache is populated once at start time? | 18:39 |
mriedem | hypothetically speaking, once your first api worker finds that the min version has changed, couldn't it set a flag that the other workers could check and then refresh themselves? | 18:39 |
dansmith | tojuvone: one more super nit on the first patch if you can include that when you resubmit.. literally one character change :) | 18:40 |
dansmith | mriedem: set a flag where? | 18:40 |
mriedem | and when to unset it | 18:40 |
dansmith | mriedem: if we query the db every time to check a flag, we might as well check the actual version. the point is it's just extra db traffic on every request | 18:40 |
mriedem | right, it couldn't be in the db | 18:40 |
*** jaypipes has quit IRC | 18:41 | |
tojuvone | dansmith: ok | 18:41 |
dansmith | yeah, so thinking about this more, using service version to enable api visible features is kinda scary | 18:41 |
dansmith | and really not what it was intended for | 18:41 |
ildikov | but restarting the workers is a recommendation, right? | 18:42 |
mriedem | how do we cache the service version today? | 18:42 |
dansmith | ildikov: there's no real need to restart them today, certainly not an urgent one like this would be | 18:42 |
dansmith | mriedem: how? it's somewhat of a singleton like behavior.. if we've ever fetched it, we return that version instead of making the call | 18:42 |
mriedem | dansmith: going back to your scenario, when you said, "then you upgrade your last liberty, do an attach, that succeeds" - if the compute version is cached, how would that succeed? or is it the first time that api worker checks the version? | 18:43 |
*** ig0r_ has joined #openstack-nova | 18:43 | |
ildikov | dansmith: in your scenario how the first multiattach succeeds, when you cached the old version? | 18:43 |
*** tonytan4ever has quit IRC | 18:43 | |
ildikov | mriedem: just asked the same question :) ^ | 18:43 |
dansmith | mriedem: it would only succeed after the last liberty was removed if that api worker hadn't cached it yet (either ever, or because it was just recycled) | 18:43 |
mriedem | rihgt | 18:44 |
mriedem | *right | 18:44 |
mriedem | so in-memory cache per worker | 18:44 |
dansmith | yes | 18:44 |
dansmith | this is literally two days old | 18:44 |
*** jaypipes has joined #openstack-nova | 18:44 | |
dansmith | two days ago, this would have been a hit for every check and not even a consideration | 18:44 |
dansmith | mriedem: anyway, sure seems like we're getting to the point of forcing this peg into the hole | 18:45 |
mriedem | well, i was thinking about a more centralized cache that isn't the actual db | 18:45 |
mriedem | and the api workers go there | 18:45 |
mriedem | but still, how do you reset the cache | 18:45 |
dansmith | well, if we had that then we could easily do something to manually invalidate | 18:46 |
dansmith | but that's infrastructure we don't have today, AFAIK | 18:46 |
mriedem | nova-manage to the rescue :) | 18:46 |
ildikov | dansmith: but then it's inconsistent now too, I mean reflecting to your comment about refreshing the cache | 18:46 |
dansmith | we also tried to think of how this would work with zk, remember and it wasn't straightforward | 18:46 |
dansmith | so yes, in theory and in the future we should do that thing | 18:46 |
mriedem | yeah, i was thinking about something like zk | 18:47 |
*** _diana_1 is now known as diana_clarke | 18:47 | |
dansmith | ildikov: yeah, remember this service version is used/intended for internal stuff, not to be visible like this, which is why these issues are popping up now | 18:47 |
ildikov | but still the scenario for upgrade is to restart the workers IIUC | 18:47 |
dansmith | ildikov: yes, but it doesn't give inconsistent api behavior if you don't, while you're doing it, etc | 18:48 |
ildikov | so if because of not doing it you don't have the latest operations working that's kind of according to the scenario | 18:48 |
*** anish has quit IRC | 18:49 | |
ildikov | and it's the best version of a corner case, I mean getting the full support later, but actually not ruining anything | 18:49 |
dansmith | I don't think I understood any of that | 18:50 |
ildikov | *not* getting | 18:50 |
ildikov | so if the cache for the workers is messed up then the worst case is that some of the valid multiattach calls will fail because of missing a required step for the upgrade | 18:51 |
openstackgerrit | Sean Dague proposed openstack/nova: update min tox version to 2.0 https://review.openstack.org/267095 | 18:51 |
openstackgerrit | Sean Dague proposed openstack/nova: always use pip constraints https://review.openstack.org/267096 | 18:51 |
openstackgerrit | Sean Dague proposed openstack/nova: reduce pep8 requirements to just hacking https://review.openstack.org/267097 | 18:51 |
dansmith | ildikov: yes, agreed with that | 18:51 |
*** READ10 has quit IRC | 18:51 | |
dansmith | ildikov: I just don't think that's a good thing to knowingly do | 18:51 |
ildikov | dansmith: but you will no end up with messed up BDMs | 18:51 |
sdague | mriedem: so, that's the alternative route on the testing that you and danpb suggested yesterday | 18:51 |
mriedem | sdague: sorry, haven't gotten back to that yet | 18:52 |
mriedem | was looking at oslo.cache | 18:52 |
sdague | mriedem: yeh, no prob | 18:52 |
sdague | https://review.openstack.org/267095 is needed regardless, our tox min version is wrong | 18:52 |
ildikov | dansmith: I'm not saying it's ideal, but I still wonder how often this would happen | 18:52 |
*** aginwala has quit IRC | 18:52 | |
sdague | we should pick one of https://review.openstack.org/267096 or the project-config change | 18:52 |
mriedem | seems rather than in-memory caches per api worker for the service versions, we should using something like oslo.cache which just wraps dogpile.cache, | 18:52 |
mriedem | which allows expiring the cached entries | 18:53 |
mriedem | and it looks like a generator function for when the value needs to be refreshed, which would be our db lookup call on the version | 18:53 |
ildikov | dansmith: considering the fact that only a very few Cinder drivers support multiattach, which means that for all drivers it's not supported you will have multiattach=false in the volume info | 18:53 |
mriedem | ildikov: i don't think that matters, | 18:53 |
mriedem | lvm supports it, and is the reference implementation i ncinder | 18:53 |
danpb | sdague: that does look nicer to me | 18:54 |
danpb | btw, what's the functional difference between the -constraints and old style tests ? | 18:54 |
*** daemontool has quit IRC | 18:54 | |
hemna | correct, not all cinder drivers even enable it | 18:54 |
*** daemontool has joined #openstack-nova | 18:54 | |
hemna | mostly because we haven't had a full end to end (cinder + nova) ability to test it all. | 18:55 |
sdague | danpb: constraints uses the upper-constraints.txt from upstream git repo | 18:55 |
sdague | to install exact versions of all dependencies | 18:55 |
dansmith | mriedem: well, other uses of the version don't depend on multiple workers like this knowing the same value, | 18:55 |
dansmith | mriedem: so if we are going to use this for this feature and future ones, then sure | 18:55 |
mriedem | dansmith: just thinking out loud, | 18:56 |
mriedem | since it seems like this could be useful | 18:56 |
dansmith | mriedem: the current caching is in the service object itself and is usable by all the services, most of which wouldn't participate in that cache cluster | 18:56 |
mriedem | i agree it's getting late in mitaka to be thiking about this | 18:56 |
dansmith | yeah | 18:56 |
sdague | danpb: https://github.com/openstack/nova/blob/1005478e03b7da8cedc163ea4de5ffa5b4d6dbac/tox.ini#L12 | 18:56 |
*** andrewbogott has quit IRC | 18:56 | |
*** andrewbogott has joined #openstack-nova | 18:56 | |
mriedem | i'm sure the yahoo! team would love to add fancy caching tools to nova | 18:56 |
ildikov | :) | 18:56 |
*** tonytan4ever has joined #openstack-nova | 18:57 | |
* dansmith runs | 18:57 | |
*** aginwala has joined #openstack-nova | 18:57 | |
*** nic1 has joined #openstack-nova | 18:58 | |
*** lpetrut has joined #openstack-nova | 18:58 | |
mriedem | sdague: is passenv the thing we need from tox 2.0? | 18:58 |
danpb | sdague: does that mean the local test-requirements.txt is no longer needed or is it still involved ? | 18:58 |
sdague | danpb: it's needed, but exact versions come from upper-constraints.txt | 18:58 |
sdague | that's basically preresolved a set of versions that are coinstallable | 18:59 |
ildikov | dansmith: you can run, if you give your blessing to the service version check approach :) | 18:59 |
sdague | and that pass some set of tests upstream | 18:59 |
mriedem | sdague: +2 since we use passenv | 18:59 |
* dansmith looks over his shoulder at ildikov and keeps running | 18:59 | |
dansmith | :) | 18:59 |
*** nic has quit IRC | 18:59 | |
danpb | sdague: ah, i see what you mean | 18:59 |
sdague | mriedem: yeh, I don't know exactly why the other thing breaks. I know it does on 1.9.2 but not on 2.0 | 19:00 |
mriedem | so the version check approach doens't work b/c of the stale api worker issue dan pointed out | 19:00 |
ildikov | dansmith: hemna just asked me yesterday whether I became a vampire :) | 19:00 |
dansmith | ildikov: heh | 19:00 |
ildikov | dansmith: so be careful ;) | 19:00 |
hemna | hehe | 19:00 |
* ildikov finished joking :) | 19:00 | |
mriedem | no one is actually scared of these kinds of vampires http://cdn02.cdn.justjared.com/wp-content/uploads/headlines/2012/12/twilight-breaking-dawn-tops-box-office-killing-them-softly-comes-up-short.jpg | 19:00 |
*** haomaiwang has quit IRC | 19:01 | |
*** yamahata has joined #openstack-nova | 19:01 | |
mriedem | i get it, you're a sensitive teenage virgin boy | 19:01 |
mriedem | move on | 19:01 |
*** 5EXAAP39W has joined #openstack-nova | 19:01 | |
*** mgoddard_ has joined #openstack-nova | 19:01 | |
ildikov | mriedem: believe me, if I ever turn into a vammpire, I will not be a toy-like one as those... :) | 19:01 |
dansmith | how do the get her hair to stay like that for the picture? | 19:01 |
dansmith | s/the/they/ | 19:01 |
mriedem | fan | 19:01 |
mriedem | industrial fan | 19:01 |
*** ericksonsantos has joined #openstack-nova | 19:01 | |
dansmith | heh | 19:02 |
*** mriedem is now known as mriedem_meeting | 19:02 | |
sdague | mriedem_meeting: commented back on https://review.openstack.org/#/c/267095 | 19:02 |
*** nic1 has quit IRC | 19:02 | |
ildikov | dansmith: wig, CGI or I don't want to know... | 19:02 |
dansmith | heh | 19:02 |
openstackgerrit | Andrey Kurilin proposed openstack/nova-specs: Update novaclient-api-microversions spec https://review.openstack.org/211206 | 19:02 |
ildikov | dansmith: how big this wrinkle is with the workers? | 19:03 |
*** raildo-afk is now known as raildo | 19:03 | |
dansmith | ildikov: [11:00:04] <mriedem>so the version check approach doens't work b/c of the stale api worker issue dan pointed out | 19:03 |
*** dave-mcc_ has quit IRC | 19:04 | |
dansmith | ildikov: I'm just one person, but I have a hard time feeling like it's a good idea at this point | 19:04 |
*** vilobhmm11 has joined #openstack-nova | 19:04 | |
*** danpb has quit IRC | 19:04 | |
ildikov | dansmith: ok, missed that | 19:04 |
*** mgoddard has quit IRC | 19:04 | |
*** jaosorior has quit IRC | 19:05 | |
ildikov | dansmith: I still feel that among any issues that can happen, this scenario is the smallest issue, also can happen if the upgrade did not happen properly | 19:05 |
*** nic has joined #openstack-nova | 19:05 | |
*** Marga_ has joined #openstack-nova | 19:05 | |
*** jaosorior has joined #openstack-nova | 19:05 | |
*** shyama has quit IRC | 19:07 | |
*** vilobhmm11 has quit IRC | 19:07 | |
ildikov | dansmith: I still think the config option is also a possibility, I know you don't like it | 19:08 |
*** vilobhmm11 has joined #openstack-nova | 19:08 | |
*** vilobhmm11 has quit IRC | 19:08 | |
dansmith | yeah, I don't :/ | 19:08 |
*** vilobhmm11 has joined #openstack-nova | 19:08 | |
*** dedery_ has joined #openstack-nova | 19:08 | |
ildikov | dansmith: that would give us the upgrade path or any options like this | 19:09 |
*** ccarmack has quit IRC | 19:09 | |
dansmith | ildikov: well, TBH, I think disabling behavior the api claims to support based on config is something we've clearly said we're not going to do any more | 19:10 |
ildikov | I mean these options would | 19:10 |
dansmith | ildikov: so if you think that's the right path forward, you'll need to convince more than just me | 19:10 |
ildikov | I'm just looking for a possibility here | 19:11 |
ildikov | I would like to see as much of the code in as possible, obviously preferably all | 19:12 |
*** dedery has quit IRC | 19:12 | |
*** dedery_ has quit IRC | 19:13 | |
*** vivekd has joined #openstack-nova | 19:13 | |
ildikov | dansmith: what do you see as a way forward here? | 19:13 |
dansmith | ildikov: I really think you're better served by trying to convince other people, but: | 19:14 |
dansmith | 1. Merge code in mitaka to tolerate multiple attachments safely | 19:14 |
dansmith | 2. Merge api code to enable it for nova users in N | 19:14 |
*** kfarr has quit IRC | 19:15 | |
ildikov | by api code I guess you mean the check_attach and compute changes | 19:15 |
dansmith | yes, for check_attach, not sure about the compute bits | 19:15 |
dansmith | I'd have to go back and look | 19:16 |
dansmith | but basically, anything that lets the user actually do a multiattach is under #2 | 19:16 |
*** jichen has joined #openstack-nova | 19:16 | |
ildikov | that's check_attach and one more call in block_device.py if the request would get through check_attach somehow | 19:17 |
*** atuvenie has joined #openstack-nova | 19:17 | |
ildikov | but teorethically it should not | 19:17 |
ildikov | I can move the addition of the instance_uuid to the get_by_volume_id() calls and then the first patch can be merged regardles of the final verdict | 19:18 |
*** smatzek has quit IRC | 19:19 | |
dansmith | that seems like a good move regardless | 19:19 |
*** smatzek has joined #openstack-nova | 19:19 | |
dansmith | I'm still not sure about the internal consistency of the object method change returning something surprising | 19:19 |
ildikov | I still don't see how a new function in the object would help here neither the changes in the db function | 19:19 |
ildikov | dansmith: it will not | 19:20 |
dansmith | feels like you need to convert all uses of that method to a new one that requires instance_uuid in order to set the stage for consuming this right? | 19:20 |
ildikov | the get_by_volume_id function already has instance_uuid as a param | 19:20 |
dansmith | ildikov: well, four nova cores feel like it will | 19:20 |
dansmith | ildikov: if you convert all callers of that object method to pass the instance uuid then you're covered | 19:21 |
dansmith | or create a new one just for cleanliness | 19:21 |
ildikov | without multiattach enabled, if you add the instance_uuid to the call, you will either get back the right BDM or nothing | 19:21 |
ildikov | if you don't have instance_uuid it will return what it returns today a we're still talking about non-multiattach case | 19:22 |
ildikov | dansmith: the volume_snapshot_create retrieves the instance_uuid from the BDM, this is why it is disabled for multiattach volumes in my second patch | 19:22 |
*** ccarmack has joined #openstack-nova | 19:23 | |
ildikov | all the other calls can be updated, the information is there it just wasn't passed | 19:23 |
dansmith | ildikov: to be honest, I'm getting rather frustrated with this conversation and I really need to get on to working on some other things | 19:24 |
ildikov | and even with multiattach enabled the volume_snapshot is disabled in compute_api, so it is safe from upgrade perspective as the API should go first | 19:24 |
ildikov | dansmith: ok, got it | 19:25 |
dansmith | there are three other people involved in looking at this, so it'd be good to let one of them take over for a while | 19:25 |
dansmith | sorry, no offense | 19:25 |
ildikov | none taken | 19:25 |
*** kfarr has joined #openstack-nova | 19:25 | |
*** ccarmack has quit IRC | 19:27 | |
*** Sukhdev has joined #openstack-nova | 19:27 | |
*** artom has quit IRC | 19:30 | |
*** unicell1 has joined #openstack-nova | 19:30 | |
*** fawadkhaliq has quit IRC | 19:30 | |
*** ccarmack has joined #openstack-nova | 19:30 | |
*** rdopiera has quit IRC | 19:32 | |
*** unicell has quit IRC | 19:33 | |
*** dave-mccowan has joined #openstack-nova | 19:33 | |
openstackgerrit | Ukesh Kumar proposed openstack/python-novaclient: make the ERRORs consistent with each others https://review.openstack.org/267128 | 19:34 |
*** tjones has quit IRC | 19:34 | |
*** tjones has joined #openstack-nova | 19:34 | |
*** aginwala has quit IRC | 19:38 | |
*** thangp has left #openstack-nova | 19:39 | |
*** boris-42 has joined #openstack-nova | 19:40 | |
*** ccarmack1 has joined #openstack-nova | 19:42 | |
*** ccarmack1 has left #openstack-nova | 19:43 | |
*** ccarmack has quit IRC | 19:44 | |
*** ccarmack has joined #openstack-nova | 19:45 | |
*** mriedem_meeting is now known as mriedem | 19:52 | |
*** ctrath has quit IRC | 19:52 | |
*** tjones has quit IRC | 19:54 | |
*** mpavone has joined #openstack-nova | 19:55 | |
tonyb | mdbooth, mriedem: it needs a rebase as it was based on ps1 of the previous review. but ps2 was tagged +W so when it merged ps1 (that I rebaseed) would become unmergeable. I was trying to streamline things so we didn't have that issue. | 19:57 |
*** davidlenwell has quit IRC | 19:57 | |
*** cdent has quit IRC | 19:57 | |
*** pratikmallya has joined #openstack-nova | 19:57 | |
mriedem | tonyb: ah | 19:57 |
mriedem | so, who wants to talk about multiattach some more?! | 19:57 |
*** aginwala has joined #openstack-nova | 19:58 | |
*** davidlenwell has joined #openstack-nova | 19:58 | |
mriedem | ildikov: so one issue with this, | 19:58 |
mriedem | there is no microversion, so as a user, who do i ever know when the cloud i'm talking to supports multiattach? | 19:58 |
mriedem | besides the attach call just failing with a 400? | 19:58 |
*** ctrath has joined #openstack-nova | 19:59 | |
mriedem | consider you have a config option in check_attach to enable multiattach support | 19:59 |
*** mpavone has quit IRC | 19:59 | |
mriedem | that is not advertised in the API in anyway | 19:59 |
mriedem | so if i make a request to attach a multiattach volume to a 2nd instance, if that flag is False, i get a 400, | 19:59 |
ildikov | sorry, here | 19:59 |
mriedem | and if i'm talking to a liberty API (no multiattach code at all), i get a 400 | 19:59 |
mriedem | so as a client, i have no way of knowing at what versoin of the nova api multiattach actually is supported | 20:00 |
*** baoli_ has quit IRC | 20:00 | |
*** lpetrut has quit IRC | 20:00 | |
*** lpetrut has joined #openstack-nova | 20:00 | |
mriedem | it almost seems like at the end of the series, there should be a microversion in the rest api that checks if you're trying to attach a multiattach volume to a 2nd instance, but you're below the microversio nthat says that's ok to do, then it fails | 20:00 |
*** 5EXAAP39W has quit IRC | 20:01 | |
openstackgerrit | Tomi Juvonen proposed openstack/nova: Add object and database support for host_status API https://review.openstack.org/267062 | 20:01 |
mriedem | jaypipes ^ weren't you working on something like that? | 20:01 |
*** whenry has quit IRC | 20:01 | |
*** haomaiwang has joined #openstack-nova | 20:01 | |
*** carey has joined #openstack-nova | 20:02 | |
*** pratikma_ has joined #openstack-nova | 20:02 | |
jaypipes | mriedem: all I did was rebase a patch from an ericsson contributor. | 20:02 |
edleafe | mriedem: are these 'NoValidHost' failures related to the bugs you and sdague were working on? https://review.openstack.org/#/c/258180/ | 20:02 |
*** aginwala has quit IRC | 20:02 | |
mriedem | you own it now | 20:02 |
*** ijw has joined #openstack-nova | 20:03 | |
mriedem | no valid host failures? | 20:03 |
*** aginwala has joined #openstack-nova | 20:03 | |
*** tonytan4ever has quit IRC | 20:03 | |
mriedem | jaypipes: ok, but do you have an opinion on how nova adveritises multiattach support? | 20:03 |
mriedem | hemna: ^ | 20:03 |
mriedem | edleafe: http://logs.openstack.org/80/258180/10/check/gate-tempest-dsvm-full/5cc12a2/logs/screen-n-cpu.txt.gz?level=TRACE | 20:04 |
mriedem | that looks like a problem with your change | 20:04 |
edleafe | mriedem: the logs are full of stuff like this: http://paste.openstack.org/show/483812/ | 20:04 |
mriedem | yeah | 20:04 |
mriedem | you're moving config options around right? | 20:04 |
edleafe | mriedem: yeah | 20:04 |
mriedem | edleafe: see the n-cpu log | 20:04 |
mriedem | NoSuchOptError: no such option in group DEFAULT: dhcp_domain | 20:04 |
*** pratikmallya has quit IRC | 20:04 | |
edleafe | of course, they work great locally :) | 20:05 |
mriedem | unit tests always work great locally | 20:05 |
edleafe | heh | 20:05 |
* mriedem cues wah wah horn sound | 20:05 | |
ildikov | mriedem: lol :) | 20:05 |
edleafe | mriedem: ok, thanks - let me dig deeper | 20:05 |
ildikov | mriedem: so the API question is tricky, but I got your concern | 20:05 |
*** mgoddard_ has quit IRC | 20:06 | |
mriedem | ildikov: so i think the thing we can all agree on for mitaka is the places in the compute manager that call bdm.get_by_volume that have an instance (remove_volume_connector, detach and swap), need to be updated to pass the instance uuid in | 20:06 |
*** eharney has quit IRC | 20:06 | |
hemna | hey | 20:06 |
mriedem | it's not really clear to me if a new bdm method needs to be added for that (bdm object method) | 20:06 |
ildikov | in my opinion no | 20:06 |
*** carey has quit IRC | 20:06 | |
ildikov | that would not solve anything | 20:06 |
mriedem | hemna: read back from (1:58:25 PM) mriedem: ildikov: so one issue with this, | 20:06 |
hemna | mriedem, does nova need to advertise multiattach for a vol ? | 20:07 |
mriedem | hemna: well, if it's not discoverable from the api, how does a user know they can use it? | 20:07 |
ildikov | so there will be one API request that will not fail in cases, when the volume allows multiattach | 20:07 |
mriedem | having said that, even with a microversion, if you're not using libvirt, multiattach won't work anyway | 20:07 |
ildikov | all the rest of the calls behaves the same | 20:07 |
hemna | mriedem, I dunno, it's new territory | 20:08 |
mriedem | hemna: well normally this is how we advertise features in the api, via microversions | 20:08 |
hemna | from cinder's perspective we advertise it from the cinder create --allow-multiattach | 20:08 |
hemna | it's a grey area | 20:08 |
mriedem | yeah, i can create a multiattach volume in cinder since juno | 20:08 |
hemna | nova can already attach | 20:08 |
hemna | so... | 20:08 |
mriedem | that doesn't mean i can do anything with it | 20:08 |
hemna | it's just allowing the same one to be attached again...maybe. | 20:08 |
mriedem | heh | 20:09 |
hemna | hehe | 20:09 |
mriedem | yeah, the maybe part is the question | 20:09 |
hemna | yah | 20:09 |
ildikov | currently the API layer in Nova is not changed, only the behaviour of that one call | 20:09 |
mriedem | ildikov: well, it's an api behaviour change | 20:10 |
mriedem | *behavior, i'm not british | 20:10 |
ildikov | and if it makes it for Mitaka then prolly it's better not advertise it immediatelly ;) | 20:10 |
hemna | I'm not sure what the right answer here is | 20:10 |
ildikov | me neither I just got used to that my MS Products are... | 20:10 |
*** claudiub has quit IRC | 20:10 | |
mriedem | maybe i need to start a ML thread | 20:11 |
hemna | mriedem, can't hurt at this point....well...maybe | 20:12 |
hemna | hehe | 20:12 |
mriedem | well, this really needs more than just like me and dan | 20:12 |
hemna | yah agreed | 20:12 |
ildikov | mriedem: quick question. are you also against of having a config option for enable/disable multiattach or maybe add it to the policy file? | 20:12 |
hemna | it's best to have more discussion | 20:12 |
hemna | I just hope it doesn't derail this effort for the 5th time. | 20:12 |
hemna | :( | 20:12 |
mriedem | ildikov: the config option still doesn't solve the ability to discover that multiattach is supported by nova from the api | 20:12 |
mriedem | you still just get a 400 | 20:12 |
mriedem | which you'd get from liberty nova for different reasons | 20:13 |
hemna | I think ildikov makes the 6th attempt at this. | 20:13 |
mriedem | i will blame all of the previous cinder/nova PTLs | 20:13 |
mriedem | and jaypipes | 20:13 |
ildikov | the reason is the same in the sense that multiattach is not supported | 20:13 |
ildikov | mriedem: +1 :) | 20:13 |
ildikov | if the volume/cinder driver or the virt driver does not support it the response is the same | 20:14 |
mriedem | in that case it's actually worse | 20:14 |
mriedem | b/c you don't know that's the reason it fails until you cast to the compute node and find out the virt driver on that node doesn't support multiattach | 20:15 |
hemna | only the volume itself knows if it's supported | 20:15 |
ildikov | ok I added new errors, but the outcome is the same | 20:15 |
hemna | cinder's API supports it, but the volume itself is the source of truth | 20:15 |
openstackgerrit | James E. Blair proposed openstack/nova: Change the default set of tox jobs to run https://review.openstack.org/267140 | 20:15 |
hemna | 2 volumes from the same cinder backend may have different settings | 20:15 |
mriedem | hemna: so if i try to create a volume with multiattach but using a cinder backend that doesn't support multiattach, i'm assuming that fails? | 20:15 |
hemna | correct | 20:15 |
mriedem | ok | 20:15 |
mriedem | which is the same if i try to boot from volume with a libvirt/lxc nova compute | 20:16 |
hemna | you call cinder create --allow-multiattach | 20:16 |
hemna | one backend works, the other doesn't | 20:16 |
mriedem | you get a 202 for the boot, but the instance errors out with NoValidHost | 20:16 |
*** annegentle has quit IRC | 20:17 | |
*** whenry has joined #openstack-nova | 20:17 | |
*** annegentle has joined #openstack-nova | 20:17 | |
*** eliqiao has quit IRC | 20:17 | |
*** dims has quit IRC | 20:18 | |
ildikov | mriedem: back to the config option question, do you see a way to enable this for Mitaka? | 20:18 |
*** dims has joined #openstack-nova | 20:18 | |
*** diana_clarke has quit IRC | 20:19 | |
*** eliqiao has joined #openstack-nova | 20:20 | |
mriedem | that would probably be the only option, but it's still not something we really want to do i don't think | 20:20 |
*** rcernin has quit IRC | 20:20 | |
*** albertom has quit IRC | 20:20 | |
mriedem | ildikov: let me finish up some other work i already started today and then i'm going to try and summarize the issues in a ML thread | 20:20 |
*** lucasagomes is now known as lucas-dinner | 20:20 | |
mriedem | so others can weigh in, b/c we're just going in circles | 20:21 |
ildikov | mriedem: ok | 20:21 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 20:21 |
ildikov | mriedem: in the meantime I will reorganize the patches | 20:21 |
mriedem | or, you know, sleep | 20:21 |
ildikov | that will be fine after next Thursday :) | 20:21 |
*** tjones has joined #openstack-nova | 20:22 | |
*** tdurakov_ has joined #openstack-nova | 20:22 | |
tdurakov_ | sdague, hi | 20:22 |
ildikov | mriedem: so we need almost all the code in except the check_attach changes and the block_device.py change where we enable multiattach | 20:22 |
ildikov | I wonder about the virt drivers, that would not do any harm in | 20:23 |
ildikov | so I need to move those snippets at the end of the chain so if it will finaly not make it for Mitaka fully we still have all the pieces to enable it preferably very early Newton | 20:24 |
ildikov | mriedem: so plan B is to get all the necessary code in until next Thursday or we loose N too | 20:25 |
*** e0ne has quit IRC | 20:25 | |
mriedem | ildikov: arguablly passing the instance uuid to bdm.get_by_volume from those 3 places in the compute manager is a bug fix | 20:26 |
mriedem | so the FF doesn't matter for that | 20:26 |
hemna | it's a bug! | 20:26 |
hemna | :P | 20:26 |
mriedem | you could do that separately today | 20:26 |
dansmith | I want it to be a new object call, FWIW | 20:26 |
*** Sukhdev has quit IRC | 20:26 | |
dansmith | because I think we should deprecate the one that currently makes it optional | 20:26 |
dansmith | and have a new one that makes instance required | 20:26 |
ildikov | mriedem: we need to pass the attachment_id in detach | 20:26 |
dansmith | otherwise people will wrongly use the old method | 20:26 |
ildikov | dansmith: the create_volume_snapshot will still need the old one | 20:27 |
mriedem | there is the one place that doesn't have an instance | 20:27 |
mriedem | but.... | 20:27 |
mriedem | we could still deprecate the bdm method | 20:27 |
*** gangil has quit IRC | 20:27 | |
*** ericksonsantos has quit IRC | 20:27 | |
mriedem | which also basically deprecates the assisted snapshot API when you don't pass an instance id | 20:27 |
mriedem | we can always update that api later with a microversion and compute rpcapi change | 20:28 |
*** lpetrut has quit IRC | 20:28 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/api directory https://review.openstack.org/258180 | 20:28 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (2) https://review.openstack.org/260587 | 20:28 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (1) https://review.openstack.org/260586 | 20:28 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (3) https://review.openstack.org/260588 | 20:28 |
mriedem | i don't know how you drop the deprecated bdm method though | 20:28 |
mriedem | w/o breaking that api | 20:28 |
ildikov | mriedem: if it means I don't have to bump a version now that sounds good to me | 20:28 |
mriedem | dansmith: i think that's the issue on that one | 20:28 |
ildikov | mriedem: you can't | 20:28 |
dansmith | well, we have to figure out something, but regardless we can handle an exceptional case | 20:28 |
ildikov | it retrieves the instance_uuid from the BDM it gets back | 20:29 |
mriedem | and we can't remove the instance uuid from the get_by_volume method b/c old compute | 20:29 |
ildikov | yeah we had this round in the reviews earlier | 20:29 |
hemna | have to run to lunch.... | 20:29 |
*** hemna is now known as hemnafk | 20:29 | |
ildikov | hemnafk: enjoy! | 20:29 |
dansmith | mriedem: how do you call the assisted snapshot api without an instance? | 20:30 |
mriedem | you pass a volume id | 20:30 |
ildikov | but as mriedem said that patch with adding the instance_uuids to the calls is a bugfix | 20:30 |
mriedem | compute api then looks up the bdm by that volume id | 20:30 |
*** nagyz_ has quit IRC | 20:30 | |
mriedem | and then gets the instance from that bdm | 20:30 |
ildikov | yeap, exactly what I meant in my above comment | 20:30 |
*** jaosorior has quit IRC | 20:30 | |
*** eharney has joined #openstack-nova | 20:30 | |
*** jaosorior has joined #openstack-nova | 20:30 | |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3261 | 20:31 |
dansmith | mriedem: so we can check that the volume is not multiattach, then look up all the bdms for that volume, fail if there is more than one, extract the one instance_uuid | 20:31 |
dansmith | right? | 20:31 |
mriedem | https://review.openstack.org/#/c/193134/69/nova/compute/api.py | 20:31 |
mriedem | see L3265 | 20:31 |
ildikov | old compute i sstill issue, easier to just simply block it for multiattach volumes | 20:31 |
ildikov | mriedem: tnx | 20:32 |
*** zhihais has quit IRC | 20:32 | |
dansmith | mriedem: yeah, for just that that works. was there still a case where we had to end up calling this bdm method without instance? | 20:32 |
mriedem | that is also a thing that is only supported by the libvirt driver | 20:32 |
dansmith | mriedem: you said we can't deprecate it | 20:32 |
ildikov | mriedem: saw your comment about the exception name, will fix it later when I get there | 20:32 |
mriedem | dansmith: that's the only place where we don't have an instance | 20:32 |
*** zhihais has joined #openstack-nova | 20:33 | |
ildikov | yeah, it's a pity we've never passed it where we had the info :( | 20:33 |
*** otter768 has joined #openstack-nova | 20:34 | |
*** jaosorior has quit IRC | 20:34 | |
dansmith | mriedem: I guess I was thinking we'd deprecate the current method, add a new one that requires instance, and a new one that doesn't take instance, but selects out all the BDMs matching the volume, asserting that there is only one, and then returning that one | 20:34 |
mriedem | well, also volume_snapshot_delete | 20:34 |
dansmith | that fixes potential abuse I think | 20:35 |
*** tonytan4ever has joined #openstack-nova | 20:35 | |
*** raildo is now known as raildo-afk | 20:35 | |
mriedem | dansmith: which with the .first() in the db api today, is basically the same | 20:36 |
mriedem | behavior-wise | 20:36 |
dansmith | it's not | 20:36 |
ildikov | volume_snapshot_delete should be fine if we don't have volume snapshot | 20:36 |
dansmith | because if we end up with two BDMs in for a volume we're not expecting it will just pick and go | 20:36 |
mriedem | dansmith: so by "asserting that there is only one" you mean raise an error if there is more than one? | 20:36 |
ildikov | it's not failing, but frankly speaking I don't think that one case worth the effort | 20:36 |
dansmith | and I'm saying we should say that if you want to call the with-no-instance version, we ensure we never return you a bdm that is attached for a multiattach volume, just because we expect you checked it first | 20:36 |
dansmith | mriedem: yeah | 20:37 |
*** ctrath has quit IRC | 20:37 | |
dansmith | otherwise someone that doesn't have this in their head, | 20:37 |
mriedem | i'm ok with that | 20:37 |
*** daemontool has quit IRC | 20:37 | |
dansmith | will look and say "hey, check out that one doesn't require instance, I'll use that one" | 20:37 |
dansmith | for some thing in the future | 20:37 |
*** Marga_ has quit IRC | 20:37 | |
mriedem | yeah | 20:37 |
mriedem | so i think that's a decent plan | 20:37 |
ildikov | we have the info in the volume | 20:37 |
ildikov | it has the attachment list | 20:37 |
dansmith | we still have to defend our database | 20:38 |
ildikov | if that's more than one then we can fail without BDM change | 20:38 |
*** daemontool has joined #openstack-nova | 20:38 | |
*** otter768 has quit IRC | 20:38 | |
ildikov | but with multiattach we will have multiple BDMs for one volume | 20:38 |
*** markmcclain has joined #openstack-nova | 20:38 | |
openstackgerrit | Eric Brown proposed openstack/nova: Use of six.PY3 should be forward compatible https://review.openstack.org/267152 | 20:38 |
*** Marga_ has joined #openstack-nova | 20:39 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Doc: Add rough plan for cellsv2 upgrade scenarios https://review.openstack.org/267153 | 20:39 |
ildikov | dansmith: I don't get the db protection comment, could you clarify it a bit what did you mean? | 20:39 |
*** rlrossit has quit IRC | 20:39 | |
mriedem | we have no unique constraints on the bdm table | 20:39 |
dansmith | ildikov: I'm saying we should not make our object depend on the attachment list on the volume to determine if it's doing something sane. It needs to operate based on what is in our database | 20:40 |
ildikov | but this check has nothing to do with it, neither multiattach | 20:40 |
*** rlrossit has joined #openstack-nova | 20:40 | |
dansmith | which means pull out all matching BDMs, and fail if there is more than one | 20:40 |
*** ctrath has joined #openstack-nova | 20:40 | |
mriedem | agree with dan | 20:40 |
dansmith | so that means that in mitaka, we must: | 20:41 |
ildikov | but that's a bugfix for a generic race issue if I understand it correctly | 20:41 |
mriedem | relying on the volume attachment list in that case also relies on the cinder db being 100% every time we need it to be | 20:41 |
dansmith | 1. Deprecate the current method | 20:41 |
ildikov | it has nothing to do with this change | 20:41 |
dansmith | 2. Add a new one that requires instance | 20:41 |
dansmith | 3. Add a new one that does not take instance, and only returns if there is exactly one BDM in the database for that volume | 20:41 |
dansmith | else we can't even do this in N | 20:41 |
*** ctrath1 has joined #openstack-nova | 20:41 | |
ildikov | mriedem: in the sense of Cinder owns the volume, it should be the source of truth | 20:41 |
dansmith | ildikov: it does because you're effectively corrupting our database | 20:41 |
mriedem | and then adjust what's calling #1 to use 2 or 3 | 20:41 |
dansmith | with this change, without handling the change | 20:41 |
dansmith | mriedem: yes | 20:41 |
mriedem | i think we can get that into mitaka as a bug fix | 20:42 |
dansmith | yes | 20:42 |
mriedem | just b/c it's already a potential race given no unique constraint | 20:42 |
mriedem | god, it's like, if we had a uuid on the bdm table or something... | 20:43 |
dansmith | heh | 20:43 |
*** apoorvad has quit IRC | 20:43 | |
ildikov | as mriedem said we don't have unique BDMs today, so I'm not corrupting the DB any further than how much it currently is | 20:43 |
*** Marga_ has quit IRC | 20:43 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: live-migration hook ansible 2.0 compaitability https://review.openstack.org/267154 | 20:43 |
dansmith | you totally are | 20:43 |
dansmith | right now we have to race to corrupt the database | 20:43 |
dansmith | after your change, we merely have to use a feature as it was intended to corrupt the database | 20:44 |
ildikov | but you can identify the bdm with the instance and volume id | 20:44 |
*** rlrossit_ has joined #openstack-nova | 20:44 | |
*** rlrossit_ has quit IRC | 20:44 | |
*** rlrossit_ has joined #openstack-nova | 20:44 | |
*** rlrossit has quit IRC | 20:44 | |
*** ctrath has quit IRC | 20:45 | |
dansmith | mriedem: I'll just do this on my own as the bug fix and we can -2 the multiattach work until it merges | 20:45 |
dansmith | it'll take me less time than arguing | 20:45 |
mriedem | i was going to say, i could do the bdm/db api stuff too, but it's yours if you want | 20:45 |
dansmith | mriedem: open me a bug and we'll call it square :) | 20:46 |
mriedem | alrighty | 20:46 |
*** aginwala has quit IRC | 20:46 | |
ildikov | thanks guys, sorry I haven't slept for a while so if you think it's the best this way then tnx for helping out | 20:46 |
*** dimtruck is now known as zz_dimtruck | 20:47 | |
dansmith | ildikov: I'm going to steal your db/api bit into my patch, FYI | 20:48 |
ildikov | dansmith: my pleasure to give it to you :) | 20:49 |
*** rcernin has joined #openstack-nova | 20:49 | |
dansmith | heh, I'm sure | 20:49 |
*** tdurakov_ has quit IRC | 20:50 | |
*** aginwala has joined #openstack-nova | 20:50 | |
ildikov | dansmith: well, if this keeps this work rolling as I said I can only say thank you | 20:51 |
mriedem | dansmith: https://bugs.launchpad.net/nova/+bug/1533834 | 20:52 |
openstack | Launchpad bug 1533834 in OpenStack Compute (nova) "nova.objects.BlockDeviceMapping.get_by_volume_id can be racy and should be deprecated" [Medium,Triaged] | 20:52 |
ildikov | mriedem: thanks! | 20:52 |
dansmith | mriedem: thanks | 20:52 |
*** tdurakov_ has joined #openstack-nova | 20:53 | |
*** gangil has joined #openstack-nova | 20:53 | |
*** gangil has joined #openstack-nova | 20:53 | |
ildikov | mriedem: I will reorganize the rest of the patches then and add it on top of dansmith's one | 20:54 |
dims | sdague : should nova-dhcpbridge be generating log files? | 20:55 |
*** belmoreira has joined #openstack-nova | 20:56 | |
*** tdurakov_ has quit IRC | 20:56 | |
*** armax has quit IRC | 20:56 | |
*** aix has quit IRC | 20:56 | |
*** atuvenie has quit IRC | 20:58 | |
dims | sdague : we seem to be hitting the dhcp lease problem a lot http://status.openstack.org//elastic-recheck/ | 20:58 |
*** baoli has joined #openstack-nova | 20:59 | |
openstackgerrit | Dan Smith proposed openstack/nova: WIP: Fix stupid https://review.openstack.org/267169 | 20:59 |
dansmith | mriedem: that's my plan | 20:59 |
dansmith | ^ | 20:59 |
openstackgerrit | dane-fichter proposed openstack/nova: Add image signature verification https://review.openstack.org/189843 | 20:59 |
mriedem | but you can't fix stupid | 20:59 |
*** haomaiwang has quit IRC | 21:01 | |
*** aginwala has quit IRC | 21:01 | |
*** haomaiwang has joined #openstack-nova | 21:01 | |
dansmith | guess I'll have to change it then | 21:01 |
*** ekarlso has quit IRC | 21:01 | |
*** ekarlso has joined #openstack-nova | 21:01 | |
*** tdurakov_ has joined #openstack-nova | 21:03 | |
*** aginwala has joined #openstack-nova | 21:03 | |
*** dustins has quit IRC | 21:03 | |
*** raildo-afk is now known as raildo | 21:03 | |
*** raildo is now known as raildo-afk | 21:03 | |
*** rcernin has quit IRC | 21:04 | |
*** tdurakov_ has quit IRC | 21:05 | |
*** tdurakov_ has joined #openstack-nova | 21:05 | |
*** smatzek has quit IRC | 21:07 | |
*** akshai has quit IRC | 21:08 | |
*** zz_dimtruck is now known as dimtruck | 21:08 | |
*** baoli has quit IRC | 21:09 | |
*** baoli has joined #openstack-nova | 21:10 | |
*** yonglihe has quit IRC | 21:11 | |
*** akshai has joined #openstack-nova | 21:12 | |
*** ig0r_ has quit IRC | 21:14 | |
*** akshai has quit IRC | 21:19 | |
*** vladikr has quit IRC | 21:21 | |
*** baoli has quit IRC | 21:21 | |
*** baoli has joined #openstack-nova | 21:22 | |
*** ig0r_ has joined #openstack-nova | 21:22 | |
*** tjones has left #openstack-nova | 21:23 | |
mriedem | patrickeast: congrats https://blueprints.launchpad.net/nova/+spec/cinder-backend-report-discard | 21:26 |
* patrickeast cheers | 21:27 | |
patrickeast | mriedem: thanks for pushing it through | 21:28 |
*** angdraug has quit IRC | 21:28 | |
*** armax has joined #openstack-nova | 21:30 | |
*** ig0r_ has quit IRC | 21:31 | |
*** aysyd has quit IRC | 21:31 | |
openstackgerrit | Dan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id https://review.openstack.org/267169 | 21:33 |
dansmith | mriedem: ildikov ^ | 21:33 |
dansmith | created at top speed.. exercise caution | 21:33 |
*** baoli has quit IRC | 21:33 | |
mriedem | just like maverick | 21:33 |
*** baoli has joined #openstack-nova | 21:34 | |
dansmith | negative ghost writer | 21:34 |
*** RichardRaseley has joined #openstack-nova | 21:34 | |
mriedem | rider | 21:34 |
mriedem | ha | 21:34 |
dansmith | I've seen it both ways | 21:34 |
*** salv-orlando has quit IRC | 21:34 | |
dansmith | find me a paramount script and I'll concede :) | 21:34 |
mriedem | dude | 21:34 |
dansmith | I just saw you commented | 21:34 |
* dansmith reads | 21:34 | |
mriedem | http://www.urbandictionary.com/define.php?term=That%27s+a+negative+Ghost+Rider | 21:34 |
*** salv-orlando has joined #openstack-nova | 21:35 | |
mriedem | even google tried correcting me when i tried 'negative ghost writer' | 21:35 |
dansmith | yeah, that guy knows | 21:35 |
*** apoorvad has joined #openstack-nova | 21:35 | |
ildikov | dansmith: thanks, checking | 21:35 |
dansmith | pfft | 21:35 |
dansmith | shocking, mriedem has naming concerns :) | 21:36 |
sdague | dims: it's a call script from dnsmasq | 21:37 |
sdague | I don't know if there is a log anywhere else | 21:37 |
mriedem | ccarmack: if you're looking for something to work on https://bugs.launchpad.net/nova/+bug/1533859 | 21:38 |
openstack | Launchpad bug 1533859 in OpenStack Compute (nova) "There should be a DB API test that ensures no new tables have soft-delete columns" [Undecided,New] | 21:38 |
*** hemnafk is now known as hemna | 21:40 | |
hemna | mriedem, nova doesn't do soft deletes now ? | 21:40 |
*** Marga_ has joined #openstack-nova | 21:40 | |
mriedem | hemna: it does | 21:40 |
mriedem | 'no new tables' | 21:40 |
mriedem | like no new taxes | 21:40 |
hemna | :) | 21:40 |
dansmith | damn | 21:40 |
dansmith | beat me to it | 21:40 |
*** rfolco has quit IRC | 21:42 | |
openstackgerrit | Sean Dague proposed openstack/nova: always use pip constraints https://review.openstack.org/267096 | 21:42 |
openstackgerrit | Dan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id https://review.openstack.org/267169 | 21:43 |
dansmith | mriedem: just for you ^ | 21:44 |
*** ig0r_ has joined #openstack-nova | 21:44 | |
*** akshai has joined #openstack-nova | 21:44 | |
*** thumpba has quit IRC | 21:44 | |
*** ig0r_ has quit IRC | 21:45 | |
*** baoli has quit IRC | 21:45 | |
*** Marga_ has quit IRC | 21:45 | |
ildikov | dansmith: I added a question, the patch looks good, tnx | 21:45 |
*** baoli has joined #openstack-nova | 21:45 | |
ccarmack | mriedem: I assigned that bug to myself | 21:46 |
*** jichen has quit IRC | 21:48 | |
*** Sukhdev has joined #openstack-nova | 21:49 | |
*** dimtruck is now known as zz_dimtruck | 21:49 | |
*** pratikmallya has joined #openstack-nova | 21:51 | |
*** FL1SK has quit IRC | 21:51 | |
openstackgerrit | Tomi Juvonen proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id} https://review.openstack.org/241562 | 21:53 |
*** whenry has quit IRC | 21:53 | |
*** pratikma_ has quit IRC | 21:54 | |
*** rcernin has joined #openstack-nova | 21:55 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id} https://review.openstack.org/241562 | 21:56 |
openstackgerrit | Dan Smith proposed openstack/nova: Add object and database support for host_status API https://review.openstack.org/267062 | 21:56 |
dansmith | tojuvone: rebased ^ | 21:56 |
*** rotbeard has joined #openstack-nova | 21:57 | |
*** ssurana has joined #openstack-nova | 21:57 | |
mriedem | dansmith: comment about the warning log fixme in https://review.openstack.org/#/c/267169/3/nova/objects/block_device.py | 21:57 |
*** baoli has quit IRC | 21:57 | |
*** baoli has joined #openstack-nova | 21:58 | |
*** smatzek has joined #openstack-nova | 21:58 | |
dansmith | mriedem: we can't filter in that legacy one because it changes the behavior for liberty clients in the case of the race | 21:59 |
dansmith | there's no real point either | 21:59 |
dansmith | just convert everything to call one of the two new methods, | 21:59 |
dansmith | warn in the old one -- warning goes away when you fully migrate to mitaka | 21:59 |
dansmith | then we drop that method and don't look back | 21:59 |
tojuvone | dansmith: Thanks a lot. It's midnight, so I continue tomorrow. I'll be catching oomichi in the morning I guess. | 21:59 |
mriedem | yeah, do the warning then | 21:59 |
mriedem | and at some point, | 22:00 |
mriedem | we should remove 'or reserved' here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4638 | 22:00 |
dansmith | tojuvone: cool thanks | 22:00 |
dansmith | mriedem: okay I'll add a log | 22:00 |
*** haomaiwang has quit IRC | 22:01 | |
mriedem | i assume you're going to do the method call changes on a follow up change? | 22:01 |
*** ccarmack has left #openstack-nova | 22:01 | |
*** haomaiwang has joined #openstack-nova | 22:01 | |
*** ZZelle_ has joined #openstack-nova | 22:01 | |
*** Marga_ has joined #openstack-nova | 22:01 | |
*** carey has joined #openstack-nova | 22:02 | |
dansmith | mriedem: or make ildikov do them :) | 22:03 |
dansmith | but definitely not in here, preferably | 22:03 |
mriedem | yeah i just wasn't sure if you were signing up to do it | 22:03 |
ildikov | mriedem: dansmith: I will do the change | 22:03 |
dansmith | ildikov: cool, thanks | 22:04 |
ildikov | preferably tomorrow in my time zone though, I hope that's acceptable, only a few hours from now :) | 22:04 |
dansmith | ildikov: not only acceptable, but preferred | 22:04 |
ildikov | dansmith: thanks :) | 22:05 |
openstackgerrit | Dan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id https://review.openstack.org/267169 | 22:05 |
*** belmoreira has quit IRC | 22:05 | |
mriedem | so with https://github.com/openstack/nova/commit/91b35b22e753a4eb0c22c004bb12586970a95e11 we've dropped support for compute rpc 3.x | 22:06 |
*** Marga_ has quit IRC | 22:07 | |
mriedem | way back in grizzly, that volume_id or 'reserved' condition was added to fix a regression in compute rpc 2.x https://github.com/openstack/nova/commit/66f1a34cabc26930db2a1afed5a0f5ced4d1c015 | 22:07 |
*** carey has quit IRC | 22:07 | |
mriedem | b/c volume_id needed to be optional on that call to the compute manager | 22:07 |
*** RichardRaseley has quit IRC | 22:09 | |
*** salv-orl_ has joined #openstack-nova | 22:09 | |
*** kfarr has quit IRC | 22:09 | |
*** baoli has quit IRC | 22:09 | |
mriedem | in v2.1, volume_id is required in the rest api | 22:09 |
mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/volumes.py#L79 | 22:09 |
*** baoli has joined #openstack-nova | 22:10 | |
*** burgerk has quit IRC | 22:10 | |
*** zz_dimtruck is now known as dimtruck | 22:10 | |
mriedem | and v2 https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/volumes.py#L293 | 22:10 |
mriedem | therefore, there is no way you can get from the rest api to the compute manager w/o a volume_id now | 22:10 |
mriedem | so we can drop that 'reserved' thing | 22:10 |
mriedem | yay! | 22:10 |
*** rcernin has quit IRC | 22:10 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: config options: centralize 'spice' options https://review.openstack.org/264271 | 22:10 |
*** salv-orlando has quit IRC | 22:12 | |
*** ccarmack has joined #openstack-nova | 22:12 | |
openstackgerrit | Brianna Poulos proposed openstack/nova: Catch UnsupportedAlgorithm exceptions https://review.openstack.org/267021 | 22:12 |
*** ndipanov has quit IRC | 22:12 | |
openstackgerrit | dane-fichter proposed openstack/nova: Add image signature verification https://review.openstack.org/189843 | 22:12 |
*** pratikma_ has joined #openstack-nova | 22:13 | |
*** yamahata has quit IRC | 22:14 | |
*** pratikmallya has quit IRC | 22:16 | |
ildikov | dansmith: mriedem: I call it a day now, thanks for the discussions and help with the BDM object stuff | 22:16 |
mriedem | ttyl | 22:16 |
ildikov | laters | 22:16 |
dansmith | ildikov: thanks | 22:17 |
bauzas | mriedem: given ttx's email, do you want to have a stable point release ? | 22:19 |
mriedem | holy crap, am i 1 hour and 19 minutes late for the cells v2 meeting? | 22:19 |
* bauzas is a bit off those days due to a local conference | 22:19 | |
mriedem | bauzas: yeah, have to get mdbooth's security fixes in first | 22:19 |
bauzas | alaski: mriedem: meh, did I missed the cells v2 meeting ? | 22:20 |
*** dimtruck is now known as zz_dimtruck | 22:20 | |
bauzas | sad | 22:20 |
bauzas | http://snowcamp.io is just leaving me out :( | 22:20 |
*** baoli_ has joined #openstack-nova | 22:21 | |
alaski | bauzas: yep, you can catch the transcript if you're interested | 22:21 |
bauzas | alaski: aaaaarh, sorry :( | 22:21 |
dansmith | wat? | 22:22 |
*** daemontool has quit IRC | 22:22 | |
dansmith | it was later today/ | 22:22 |
dansmith | I guess it flipped after the new year | 22:22 |
* dansmith scolds his calendar | 22:22 | |
* bauzas needs to fix his calendar too | 22:22 | |
*** Sukhdev has quit IRC | 22:22 | |
alaski | dansmith: yep, really messed things up | 22:22 |
dansmith | doh | 22:23 |
bauzas | alaski: could you please ping me next time for the meeting ? | 22:23 |
*** daemontool has joined #openstack-nova | 22:23 | |
alaski | I don't even have a calendar that can deal with even/odd rather than alternating weeks | 22:23 |
bauzas | like we do for nova :) | 22:23 |
*** boris-42 has quit IRC | 22:23 | |
*** baoli__ has joined #openstack-nova | 22:24 | |
alaski | I'll add a ping list to the meeting page, but if it gets ridiculous like the Nova one I'm dropping it | 22:24 |
*** baoli has quit IRC | 22:24 | |
bauzas | meh | 22:24 |
*** armax has quit IRC | 22:25 | |
bauzas | mriedem: for mdbooth's patches, I missed the convo, could you please point me out the links ? | 22:25 |
dansmith | alaski: stay strong against silly ping lists :) | 22:26 |
*** baoli_ has quit IRC | 22:26 | |
*** tdurakov_ has quit IRC | 22:27 | |
*** baoli__ has quit IRC | 22:27 | |
alaski | heh. Maybe I'll compromise and ping only for the first meetings of the year, in case this happens again | 22:27 |
*** baoli has joined #openstack-nova | 22:28 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Remove "or 'reserved'" condition from reserve_block_device_name https://review.openstack.org/267206 | 22:28 |
mriedem | i actually had a reminder popup | 22:29 |
mriedem | but because of too many tabs and blinking windows and crap, i missed it | 22:29 |
alaski | for shame | 22:29 |
mriedem | :( | 22:29 |
*** zz_dimtruck is now known as dimtruck | 22:29 | |
mriedem | i need an intern to remind me | 22:29 |
alaski | also, https://review.openstack.org/#/c/267153/ is for you | 22:29 |
mriedem | i did see that scroll by | 22:29 |
mriedem | you may also enjoy https://review.openstack.org/#/c/267206/ | 22:30 |
*** baoli has quit IRC | 22:30 | |
mriedem | bauzas: look! cve release notes http://docs-draft.openstack.org/78/267178/1/check/gate-nova-releasenotes/e7bdcb0//releasenotes/build/html/unreleased.html | 22:30 |
*** baoli has joined #openstack-nova | 22:30 | |
mriedem | bauzas: also https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/liberty+topic:bug/1524274 | 22:31 |
bauzas | coolness | 22:32 |
alaski | I love that the commit message is about 50x larger than the actual change | 22:32 |
mriedem | history | 22:32 |
mriedem | i had to look up those commits, so i figured i'd doc them | 22:32 |
bauzas | mriedem: I like your commit msg | 22:33 |
alaski | it's excellent, just amusing | 22:33 |
*** Sukhdev has joined #openstack-nova | 22:33 | |
bauzas | because it helps me to understand the problem | 22:33 |
bauzas | mriedem: for the stable patches, do you want to wait for the still opens ? | 22:33 |
mriedem | bauzas: for those that aren't approved yet? | 22:33 |
*** pratikma_ has quit IRC | 22:33 | |
bauzas | yup | 22:33 |
mriedem | there was only 1 i kind of thouht should get in | 22:34 |
mriedem | sec | 22:34 |
mriedem | https://review.openstack.org/#/c/266096/ | 22:34 |
mriedem | but i was waiting for garyk to vouch for it | 22:34 |
*** Sukhdev has quit IRC | 22:34 | |
bauzas | okay, I'll look at those tomorrow | 22:34 |
*** otter768 has joined #openstack-nova | 22:35 | |
bauzas | but I'll just +1 those | 22:35 |
mriedem | heh | 22:35 |
mriedem | if you can think of anything missing from release notes given the change log, let me know | 22:35 |
mriedem | i at least wanted the cve's doc'ed | 22:35 |
bauzas | fair enough | 22:35 |
bauzas | yup | 22:35 |
bauzas | and I like that | 22:35 |
*** edtubill has quit IRC | 22:37 | |
*** pratikmallya has joined #openstack-nova | 22:37 | |
*** ccarmack has left #openstack-nova | 22:39 | |
*** xyang1 has quit IRC | 22:39 | |
*** otter768 has quit IRC | 22:40 | |
*** baoli has quit IRC | 22:42 | |
*** baoli has joined #openstack-nova | 22:43 | |
*** smatzek has quit IRC | 22:43 | |
*** Marga_ has joined #openstack-nova | 22:43 | |
*** thorst has quit IRC | 22:43 | |
*** thorst has joined #openstack-nova | 22:44 | |
*** vivekd has quit IRC | 22:46 | |
*** Marga_ has quit IRC | 22:47 | |
*** thorst has quit IRC | 22:48 | |
*** dave-mccowan has quit IRC | 22:49 | |
*** tdurakov_ has joined #openstack-nova | 22:50 | |
*** Marga_ has joined #openstack-nova | 22:52 | |
mriedem | alright, multiattach quandry ML thread sent | 22:52 |
mriedem | it's not fun | 22:52 |
mriedem | http://lists.openstack.org/pipermail/openstack-dev/2016-January/084031.html | 22:53 |
*** ccarmack has joined #openstack-nova | 22:53 | |
*** browne has quit IRC | 22:54 | |
*** armax has joined #openstack-nova | 22:54 | |
*** baoli has quit IRC | 22:54 | |
*** baoli has joined #openstack-nova | 22:55 | |
*** aginwala has quit IRC | 22:58 | |
*** mriedem is now known as mriedem_away | 23:00 | |
*** haomaiwang has quit IRC | 23:01 | |
*** haomaiwang has joined #openstack-nova | 23:01 | |
*** armax has quit IRC | 23:01 | |
*** mdrabe has quit IRC | 23:01 | |
*** tdurakov_ has quit IRC | 23:01 | |
vilobhmm11 | bauzas : ping | 23:02 |
*** ctrath1 has quit IRC | 23:02 | |
*** rlrossit_ has quit IRC | 23:02 | |
*** burt has quit IRC | 23:02 | |
*** tdurakov_ has joined #openstack-nova | 23:03 | |
vilobhmm11 | dansmith : ping need some help | 23:03 |
*** thorst has joined #openstack-nova | 23:04 | |
*** _diana_1 has joined #openstack-nova | 23:06 | |
*** baoli has quit IRC | 23:06 | |
*** aginwala has joined #openstack-nova | 23:06 | |
*** baoli has joined #openstack-nova | 23:07 | |
*** aginwala has quit IRC | 23:07 | |
*** aginwala has joined #openstack-nova | 23:07 | |
*** artom has joined #openstack-nova | 23:08 | |
*** thorst has quit IRC | 23:08 | |
*** zenoway has quit IRC | 23:09 | |
*** ccarmack has quit IRC | 23:09 | |
*** _diana_1 has quit IRC | 23:10 | |
*** _diana_1 has joined #openstack-nova | 23:10 | |
*** ctrath has joined #openstack-nova | 23:10 | |
*** tdurakov_ has quit IRC | 23:11 | |
vilobhmm11 | mriedem : are you around ? | 23:15 |
*** thorst has joined #openstack-nova | 23:17 | |
*** baoli_ has joined #openstack-nova | 23:18 | |
*** annegentle has quit IRC | 23:18 | |
*** baoli__ has joined #openstack-nova | 23:20 | |
*** baoli has quit IRC | 23:21 | |
*** ociuhandu has joined #openstack-nova | 23:23 | |
*** baoli_ has quit IRC | 23:23 | |
*** amotoki has joined #openstack-nova | 23:28 | |
*** _diana_1 has quit IRC | 23:28 | |
*** pratikmallya has quit IRC | 23:28 | |
*** baoli__ has quit IRC | 23:29 | |
*** pratikmallya has joined #openstack-nova | 23:29 | |
*** ZZelle_ has quit IRC | 23:30 | |
*** _diana_1 has joined #openstack-nova | 23:31 | |
*** pratikmallya has quit IRC | 23:33 | |
*** armax has joined #openstack-nova | 23:37 | |
*** moshele has joined #openstack-nova | 23:40 | |
*** mrkz has quit IRC | 23:40 | |
*** mragupat_ has quit IRC | 23:41 | |
*** ctrath has quit IRC | 23:41 | |
*** yassine has quit IRC | 23:43 | |
*** Daisy has joined #openstack-nova | 23:43 | |
*** pratikmallya has joined #openstack-nova | 23:43 | |
*** dimtruck is now known as zz_dimtruck | 23:46 | |
*** akshai has quit IRC | 23:47 | |
*** FL1SK has joined #openstack-nova | 23:49 | |
*** diogogmt has quit IRC | 23:49 | |
*** ducttape_ has quit IRC | 23:50 | |
*** smoriya_ has joined #openstack-nova | 23:51 | |
*** armax has quit IRC | 23:51 | |
*** amotoki has quit IRC | 23:52 | |
*** amotoki has joined #openstack-nova | 23:52 | |
*** pradk has quit IRC | 23:53 | |
*** amotoki has quit IRC | 23:53 | |
*** Daisy has quit IRC | 23:54 | |
*** akshai has joined #openstack-nova | 23:54 | |
*** Daisy has joined #openstack-nova | 23:55 | |
*** aginwala has quit IRC | 23:56 | |
*** armax has joined #openstack-nova | 23:58 | |
*** browne has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!