*** Daisy has quit IRC | 00:00 | |
*** _diana_1 has quit IRC | 00:00 | |
*** haomaiwang has quit IRC | 00:01 | |
*** haomaiwang has joined #openstack-nova | 00:01 | |
*** zhangjn has joined #openstack-nova | 00:03 | |
*** aginwala has joined #openstack-nova | 00:03 | |
*** pratikmallya has quit IRC | 00:03 | |
*** carey has joined #openstack-nova | 00:03 | |
*** ssurana has quit IRC | 00:05 | |
*** armax has quit IRC | 00:05 | |
*** dougs1 has quit IRC | 00:06 | |
*** dougs has joined #openstack-nova | 00:06 | |
*** nic has quit IRC | 00:08 | |
*** carey has quit IRC | 00:08 | |
*** nic has joined #openstack-nova | 00:09 | |
*** akshai has quit IRC | 00:09 | |
*** moshele has quit IRC | 00:12 | |
*** zhangjn has quit IRC | 00:14 | |
*** mnestratov has quit IRC | 00:15 | |
*** _diana_1 has joined #openstack-nova | 00:18 | |
*** _diana_1 is now known as diana_clarke | 00:18 | |
*** akshai has joined #openstack-nova | 00:20 | |
openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available https://review.openstack.org/205282 | 00:20 |
---|---|---|
*** akshai has quit IRC | 00:25 | |
*** irenab_ has joined #openstack-nova | 00:30 | |
*** salv-orl_ has quit IRC | 00:31 | |
*** irenab has quit IRC | 00:33 | |
*** irenab_ is now known as irenab | 00:33 | |
*** salv-orlando has joined #openstack-nova | 00:34 | |
*** carey has joined #openstack-nova | 00:35 | |
*** otter768 has joined #openstack-nova | 00:36 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add maximum microversions for each releases https://review.openstack.org/267247 | 00:36 |
*** Sukhdev has joined #openstack-nova | 00:38 | |
*** armax has joined #openstack-nova | 00:39 | |
*** otter768 has quit IRC | 00:41 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Use get_notification_transport() for notifications https://review.openstack.org/266960 | 00:42 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add tests for nova.rpc module https://review.openstack.org/267248 | 00:42 |
*** ssurana has joined #openstack-nova | 00:44 | |
*** salv-orlando has quit IRC | 00:45 | |
*** dims has quit IRC | 00:45 | |
*** Sukhdev has quit IRC | 00:46 | |
*** salv-orlando has joined #openstack-nova | 00:46 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add helper shim for getting items https://review.openstack.org/265995 | 00:53 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Remove DictCompat from ComputeNode https://review.openstack.org/265521 | 00:53 |
*** edmondsw has quit IRC | 00:55 | |
*** zhangjn has joined #openstack-nova | 00:57 | |
*** gtt116__ has quit IRC | 00:58 | |
*** haomaiwang has quit IRC | 01:01 | |
*** haomaiwang has joined #openstack-nova | 01:01 | |
*** tonytan4ever has quit IRC | 01:04 | |
*** rk4n has joined #openstack-nova | 01:04 | |
*** thorst has quit IRC | 01:04 | |
*** thorst has joined #openstack-nova | 01:05 | |
*** zhangjn_ has joined #openstack-nova | 01:05 | |
*** zhangjn_ has quit IRC | 01:06 | |
*** zhangjn has quit IRC | 01:07 | |
*** zhangjn has joined #openstack-nova | 01:08 | |
*** nic has quit IRC | 01:09 | |
*** tonytan4ever has joined #openstack-nova | 01:10 | |
*** zhangjn has quit IRC | 01:11 | |
*** aginwala has quit IRC | 01:12 | |
*** thorst has quit IRC | 01:13 | |
*** browne has quit IRC | 01:13 | |
*** EinstCrazy has joined #openstack-nova | 01:14 | |
tangchen__ | Hi oomichi, alex_xu, I have made this patch pass the CI tests. Please help to review when you are free. Thanks a lot. https://review.openstack.org/#/c/202617 | 01:15 |
*** wasmum has joined #openstack-nova | 01:15 | |
*** rk4n has quit IRC | 01:16 | |
*** liusheng has joined #openstack-nova | 01:18 | |
*** rk4n has joined #openstack-nova | 01:19 | |
*** gongysh_ has quit IRC | 01:20 | |
*** zhangjn has joined #openstack-nova | 01:20 | |
*** zhangjn has quit IRC | 01:22 | |
*** zhangjn has joined #openstack-nova | 01:23 | |
*** rk4n has quit IRC | 01:23 | |
*** jasondotstar has quit IRC | 01:24 | |
*** dims has joined #openstack-nova | 01:24 | |
*** ssurana has quit IRC | 01:25 | |
*** zhangjn has quit IRC | 01:27 | |
*** oomichi_away has quit IRC | 01:28 | |
*** jasondotstar has joined #openstack-nova | 01:29 | |
*** rfolco has joined #openstack-nova | 01:30 | |
*** aginwala has joined #openstack-nova | 01:30 | |
*** Sukhdev has joined #openstack-nova | 01:32 | |
*** haomaiwang has quit IRC | 01:32 | |
*** 14WAAOU1P has joined #openstack-nova | 01:33 | |
*** zhangjn has joined #openstack-nova | 01:35 | |
*** shuquan has joined #openstack-nova | 01:36 | |
*** rfolco has quit IRC | 01:43 | |
*** aginwala has quit IRC | 01:44 | |
*** aginwala has joined #openstack-nova | 01:47 | |
*** suro-patz has quit IRC | 01:47 | |
*** Jeffrey4l has joined #openstack-nova | 01:48 | |
*** yonglihe has joined #openstack-nova | 01:48 | |
*** doug-fish has quit IRC | 01:48 | |
*** mtanino has quit IRC | 01:49 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266690 | 01:52 |
*** ljxiash has quit IRC | 01:52 | |
*** jdurgin1 has quit IRC | 01:53 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(1/5) https://review.openstack.org/261399 | 01:53 |
*** gjayavelu has quit IRC | 01:54 | |
*** zhangjn has quit IRC | 01:54 | |
*** EinstCrazy has quit IRC | 01:57 | |
*** smoriya__ has joined #openstack-nova | 01:57 | |
*** shuquan has quit IRC | 01:57 | |
*** ljxiash has joined #openstack-nova | 01:57 | |
*** yamahata has joined #openstack-nova | 01:58 | |
*** Sukhdev has quit IRC | 01:58 | |
*** smoriya_ has quit IRC | 01:59 | |
*** EinstCrazy has joined #openstack-nova | 01:59 | |
*** 14WAAOU1P has quit IRC | 02:01 | |
*** haomaiwang has joined #openstack-nova | 02:01 | |
*** shuquan has joined #openstack-nova | 02:01 | |
*** vilobhmm11 has quit IRC | 02:05 | |
*** thumpba has joined #openstack-nova | 02:10 | |
*** lyanchih has joined #openstack-nova | 02:10 | |
*** thorst has joined #openstack-nova | 02:11 | |
*** gongysh has quit IRC | 02:12 | |
*** ijw has quit IRC | 02:12 | |
*** gongysh has joined #openstack-nova | 02:12 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266690 | 02:13 |
*** EinstCra_ has joined #openstack-nova | 02:13 | |
*** zhangjn has joined #openstack-nova | 02:16 | |
*** browne has joined #openstack-nova | 02:16 | |
*** EinstCrazy has quit IRC | 02:16 | |
*** takashin has joined #openstack-nova | 02:16 | |
*** thorst has quit IRC | 02:18 | |
*** boris-42 has joined #openstack-nova | 02:18 | |
*** tonytan4ever has quit IRC | 02:20 | |
*** zhangjn has quit IRC | 02:20 | |
*** aginwala has quit IRC | 02:22 | |
*** zhangjn has joined #openstack-nova | 02:26 | |
*** aginwala has joined #openstack-nova | 02:27 | |
*** dims has quit IRC | 02:29 | |
*** armax has quit IRC | 02:29 | |
*** SourabhP has joined #openstack-nova | 02:30 | |
*** ljxiash has quit IRC | 02:30 | |
*** ljxiash has joined #openstack-nova | 02:31 | |
*** thumpba has quit IRC | 02:32 | |
*** thorst has joined #openstack-nova | 02:32 | |
*** thorst has quit IRC | 02:34 | |
*** ljxiash has quit IRC | 02:35 | |
*** houming has joined #openstack-nova | 02:35 | |
*** shyama has joined #openstack-nova | 02:36 | |
*** otter768 has joined #openstack-nova | 02:36 | |
*** ducttape_ has joined #openstack-nova | 02:37 | |
*** zhangjn has quit IRC | 02:37 | |
*** Jeffrey4l has quit IRC | 02:38 | |
tangchen__ | Hi alex_xu, about the sample_dir = 'servers' thing, if I don't add this line, the CI won't pass because it won't search the files under servers dir. | 02:38 |
*** Jeffrey4l has joined #openstack-nova | 02:38 | |
alex_xu | tangchen__: emm...let me check the code | 02:38 |
tangchen__ | alex_xu: I'm not sure if I made any mistake somewhere else. | 02:39 |
tangchen__ | alex_xu: I'll try again, and if I met the error, I will show you. Thx. :) | 02:39 |
alex_xu | tangchen__: cool, thanks :) | 02:39 |
*** apoorvad has quit IRC | 02:40 | |
alex_xu | tangchen__: just note, you can test that locally with `tox -e functional` | 02:40 |
*** josecastroleon has quit IRC | 02:41 | |
*** otter768 has quit IRC | 02:41 | |
*** thumpba has joined #openstack-nova | 02:42 | |
*** ducttape_ has quit IRC | 02:42 | |
*** josecastroleon has joined #openstack-nova | 02:42 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli https://review.openstack.org/266687 | 02:43 |
*** zhangjn has joined #openstack-nova | 02:43 | |
*** ducttape_ has joined #openstack-nova | 02:43 | |
*** zhangjn has quit IRC | 02:44 | |
*** erlon has quit IRC | 02:46 | |
*** shuquan has quit IRC | 02:48 | |
*** gtt116 has joined #openstack-nova | 02:49 | |
*** gongysh_ has joined #openstack-nova | 02:50 | |
*** artom_ has joined #openstack-nova | 02:50 | |
*** shuquan has joined #openstack-nova | 02:51 | |
*** davideag_ has joined #openstack-nova | 02:51 | |
*** andrearo1 has joined #openstack-nova | 02:51 | |
*** szaher__ has joined #openstack-nova | 02:52 | |
*** crinkle_ has joined #openstack-nova | 02:52 | |
*** tziarko_ has joined #openstack-nova | 02:52 | |
*** masayukig has quit IRC | 02:52 | |
*** _fortis has quit IRC | 02:52 | |
*** mkoderer has quit IRC | 02:52 | |
*** dulek has quit IRC | 02:52 | |
openstackgerrit | Eli Qiao proposed openstack/nova: Calculate block_migration in virt drivers if it's None https://review.openstack.org/254101 | 02:52 |
openstackgerrit | Eli Qiao proposed openstack/nova: Return host and block_migration in task_api._execute() https://review.openstack.org/254102 | 02:52 |
*** ekarlso has quit IRC | 02:52 | |
*** davideagnello has quit IRC | 02:52 | |
*** maurosr has quit IRC | 02:52 | |
*** tziarko has quit IRC | 02:52 | |
*** mikal has quit IRC | 02:52 | |
*** egarbade- has quit IRC | 02:52 | |
*** andrearosa has quit IRC | 02:52 | |
*** ccard_ has quit IRC | 02:52 | |
*** crinkle has quit IRC | 02:52 | |
*** artom has quit IRC | 02:53 | |
*** aarefiev has quit IRC | 02:53 | |
*** szaher_ has quit IRC | 02:53 | |
*** mikal has joined #openstack-nova | 02:53 | |
*** aarefiev has joined #openstack-nova | 02:53 | |
*** egarbade- has joined #openstack-nova | 02:53 | |
*** masayukig has joined #openstack-nova | 02:53 | |
*** maurosr has joined #openstack-nova | 02:53 | |
*** dulek has joined #openstack-nova | 02:54 | |
*** mkoderer has joined #openstack-nova | 02:54 | |
*** shuquan has quit IRC | 02:55 | |
*** ccard_ has joined #openstack-nova | 02:55 | |
*** _fortis has joined #openstack-nova | 02:56 | |
tangchen__ | alex_xu: Yes, I have done that successfully yesterday. | 02:56 |
*** shuquan has joined #openstack-nova | 02:58 | |
*** dims has joined #openstack-nova | 02:58 | |
*** ducttape_ has quit IRC | 02:59 | |
*** haomaiwang has quit IRC | 03:01 | |
alex_xu | tangchen__: cool :) | 03:01 |
*** dims_ has joined #openstack-nova | 03:01 | |
*** haomaiwa_ has joined #openstack-nova | 03:01 | |
*** baoli has joined #openstack-nova | 03:02 | |
*** unicell1 has quit IRC | 03:03 | |
*** zhangjn has joined #openstack-nova | 03:03 | |
*** dims has quit IRC | 03:03 | |
*** haomaiwa_ has quit IRC | 03:04 | |
*** diogogmt has joined #openstack-nova | 03:04 | |
*** ekarlso has joined #openstack-nova | 03:05 | |
*** crinkle_ is now known as crinkle | 03:08 | |
*** aginwala has quit IRC | 03:09 | |
*** zhangjn has quit IRC | 03:12 | |
*** suro-patz has joined #openstack-nova | 03:13 | |
*** thumpba has quit IRC | 03:13 | |
*** aginwala has joined #openstack-nova | 03:14 | |
*** thumpba has joined #openstack-nova | 03:16 | |
*** aginwala has quit IRC | 03:16 | |
*** zhangjn has joined #openstack-nova | 03:17 | |
*** thumpba has quit IRC | 03:17 | |
*** links has joined #openstack-nova | 03:17 | |
*** ljxiash has joined #openstack-nova | 03:20 | |
*** shuquan has quit IRC | 03:22 | |
openstackgerrit | Diana Clarke proposed openstack/nova: Replace stubs.Set with stub_out (fakes) https://review.openstack.org/265082 | 03:23 |
*** shuquan has joined #openstack-nova | 03:25 | |
*** thumpba has joined #openstack-nova | 03:26 | |
*** thumpba has quit IRC | 03:28 | |
*** thumpba has joined #openstack-nova | 03:28 | |
*** daemontool has quit IRC | 03:30 | |
*** oomichi has joined #openstack-nova | 03:30 | |
*** zhangjn has quit IRC | 03:31 | |
*** coolsvap|away is now known as coolsvap | 03:36 | |
*** shuquan has quit IRC | 03:39 | |
*** zhihais has quit IRC | 03:41 | |
*** zhihais has joined #openstack-nova | 03:42 | |
*** shuquan has joined #openstack-nova | 03:42 | |
*** yamahata has quit IRC | 03:43 | |
*** ljxiash has quit IRC | 03:45 | |
*** ljxiash has joined #openstack-nova | 03:45 | |
*** ljxiash has quit IRC | 03:49 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add swap volume notifications https://review.openstack.org/250283 | 03:53 |
*** browne1 has joined #openstack-nova | 03:57 | |
*** browne has quit IRC | 04:00 | |
*** vilobhmm11 has joined #openstack-nova | 04:02 | |
*** lyanchih has quit IRC | 04:08 | |
*** ducttape_ has joined #openstack-nova | 04:09 | |
*** salv-orl_ has joined #openstack-nova | 04:10 | |
*** salv-orlando has quit IRC | 04:12 | |
*** EinstCra_ has quit IRC | 04:13 | |
*** EinstCrazy has joined #openstack-nova | 04:13 | |
*** ducttape_ has quit IRC | 04:14 | |
*** thumpba has quit IRC | 04:15 | |
*** suro-patz has quit IRC | 04:20 | |
*** zz_dimtruck is now known as dimtruck | 04:21 | |
*** liusheng has quit IRC | 04:24 | |
*** thumpba has joined #openstack-nova | 04:28 | |
*** Marga_ has quit IRC | 04:28 | |
*** dims_ has quit IRC | 04:30 | |
*** Sukhdev has joined #openstack-nova | 04:33 | |
*** zenoway has joined #openstack-nova | 04:35 | |
*** mragupat has joined #openstack-nova | 04:35 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266687 | 04:36 |
*** otter768 has joined #openstack-nova | 04:37 | |
*** zenoway has quit IRC | 04:39 | |
*** dimtruck is now known as zz_dimtruck | 04:40 | |
*** otter768 has quit IRC | 04:42 | |
*** Marga_ has joined #openstack-nova | 04:44 | |
*** thumpba has quit IRC | 04:44 | |
*** RA_ has joined #openstack-nova | 04:46 | |
*** Marga_ has quit IRC | 04:48 | |
openstackgerrit | Rushi Agrawal proposed openstack/nova: Remove almost all mox from tests/unit/objects/test_instance.py https://review.openstack.org/264292 | 04:50 |
*** vilobhmm11 has quit IRC | 04:53 | |
*** vilobhmm11 has joined #openstack-nova | 04:54 | |
*** vilobhmm11 has quit IRC | 04:54 | |
*** thumpba has joined #openstack-nova | 04:54 | |
*** EinstCrazy has quit IRC | 04:57 | |
*** shuquan has quit IRC | 04:58 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(2/5) https://review.openstack.org/261401 | 04:58 |
*** oomichi is now known as oomichi_away | 04:58 | |
*** vilobhmm11 has joined #openstack-nova | 05:00 | |
*** EinstCrazy has joined #openstack-nova | 05:01 | |
*** armax has joined #openstack-nova | 05:06 | |
*** unicell has joined #openstack-nova | 05:06 | |
*** vivekd has joined #openstack-nova | 05:08 | |
*** lyanchih has joined #openstack-nova | 05:09 | |
*** oomichi_away has quit IRC | 05:10 | |
*** zenoway has joined #openstack-nova | 05:10 | |
*** ljxiash has joined #openstack-nova | 05:11 | |
*** zenoway has quit IRC | 05:14 | |
*** haomaiwang has joined #openstack-nova | 05:16 | |
*** pradipta has joined #openstack-nova | 05:17 | |
*** zhangjn has joined #openstack-nova | 05:22 | |
*** baoli has quit IRC | 05:22 | |
*** SourabhP has quit IRC | 05:22 | |
*** lyanchih has quit IRC | 05:24 | |
*** zhangjn has quit IRC | 05:27 | |
*** zhangjn has joined #openstack-nova | 05:28 | |
*** jwcroppe has joined #openstack-nova | 05:29 | |
*** thumpba has quit IRC | 05:30 | |
*** zhangjn has quit IRC | 05:32 | |
*** zhangjn has joined #openstack-nova | 05:41 | |
*** thumpba has joined #openstack-nova | 05:41 | |
*** SourabhP has joined #openstack-nova | 05:42 | |
*** zhangjn has quit IRC | 05:45 | |
*** artom_ has quit IRC | 05:47 | |
*** artom_ has joined #openstack-nova | 05:47 | |
*** moshele has joined #openstack-nova | 05:50 | |
*** zhangjn has joined #openstack-nova | 05:50 | |
*** zhangjn has quit IRC | 05:53 | |
*** jaosorior has joined #openstack-nova | 05:54 | |
*** SourabhP_ has joined #openstack-nova | 05:54 | |
*** vilobhmm11 has quit IRC | 05:54 | |
*** SourabhP has quit IRC | 05:54 | |
*** SourabhP_ is now known as SourabhP | 05:54 | |
*** vilobhmm11 has joined #openstack-nova | 05:55 | |
*** shuquan has joined #openstack-nova | 05:56 | |
*** haomaiwa_ has joined #openstack-nova | 05:56 | |
*** haomaiwang has quit IRC | 05:56 | |
*** brad[] has quit IRC | 05:57 | |
*** zhangjn has joined #openstack-nova | 05:59 | |
*** zhangjn has quit IRC | 06:00 | |
*** haomaiwa_ has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-nova | 06:01 | |
*** suro-patz has joined #openstack-nova | 06:01 | |
*** lyanchih has joined #openstack-nova | 06:02 | |
*** vivekd has quit IRC | 06:03 | |
*** RA_ has quit IRC | 06:04 | |
*** unicell1 has joined #openstack-nova | 06:05 | |
*** unicell has quit IRC | 06:06 | |
*** shuquan has quit IRC | 06:08 | |
*** shuquan has joined #openstack-nova | 06:10 | |
*** zhangjn has joined #openstack-nova | 06:12 | |
*** thumpba has quit IRC | 06:14 | |
*** aginwala has joined #openstack-nova | 06:14 | |
*** zhangjn has quit IRC | 06:15 | |
*** brad[] has joined #openstack-nova | 06:15 | |
*** zhangjn has joined #openstack-nova | 06:16 | |
*** zhangjn has quit IRC | 06:18 | |
*** yamahata has joined #openstack-nova | 06:19 | |
*** zhangjn has joined #openstack-nova | 06:19 | |
*** zhangjn has quit IRC | 06:20 | |
*** aginwala_ has joined #openstack-nova | 06:23 | |
*** zhangjn has joined #openstack-nova | 06:25 | |
*** thumpba has joined #openstack-nova | 06:25 | |
*** aginwala has quit IRC | 06:26 | |
*** aginwala has joined #openstack-nova | 06:27 | |
*** aginwala_ has quit IRC | 06:30 | |
*** gangil has quit IRC | 06:31 | |
*** SourabhP has quit IRC | 06:33 | |
*** rotbeard has quit IRC | 06:33 | |
*** vivekd has joined #openstack-nova | 06:37 | |
*** otter768 has joined #openstack-nova | 06:38 | |
*** nkrinner has joined #openstack-nova | 06:38 | |
openstackgerrit | esracelik proposed openstack/nova: Config options: centralize "configdrive" options https://review.openstack.org/254092 | 06:39 |
*** zhangjn has quit IRC | 06:42 | |
*** markvoelker has quit IRC | 06:42 | |
*** jaosorior has quit IRC | 06:42 | |
*** otter768 has quit IRC | 06:43 | |
*** jaosorior has joined #openstack-nova | 06:43 | |
*** aginwala has quit IRC | 06:43 | |
*** yamahata has quit IRC | 06:43 | |
*** aginwala has joined #openstack-nova | 06:43 | |
*** jaosorior has quit IRC | 06:45 | |
*** jaosorior has joined #openstack-nova | 06:46 | |
*** sahid has joined #openstack-nova | 06:48 | |
*** armax has quit IRC | 06:48 | |
*** sahid has quit IRC | 06:49 | |
*** armax has joined #openstack-nova | 06:49 | |
*** sahid has joined #openstack-nova | 06:49 | |
*** gsilvis has quit IRC | 06:50 | |
*** edtubill has joined #openstack-nova | 06:51 | |
*** zenoway has joined #openstack-nova | 06:51 | |
openstackgerrit | Eric Brown proposed openstack/nova: Fix config option types https://review.openstack.org/168481 | 06:51 |
*** edtubill has quit IRC | 06:52 | |
*** browne1 has quit IRC | 06:52 | |
*** amotoki_ has joined #openstack-nova | 06:52 | |
*** amotoki_ has quit IRC | 06:52 | |
*** gongysh_ has quit IRC | 06:53 | |
*** jwcroppe has quit IRC | 06:56 | |
*** shuquan has quit IRC | 06:57 | |
*** vishwana_ is now known as vishwanathj | 07:00 | |
*** haomaiwang has quit IRC | 07:01 | |
*** vishwanathj is now known as vishwanathj_good | 07:01 | |
*** vishwanathj_good is now known as vishwanathj_slee | 07:01 | |
*** vishwanathj_slee is now known as vishwanathj_nap | 07:01 | |
*** haomaiwang has joined #openstack-nova | 07:01 | |
*** vishwanathj_nap is now known as vishwanathj_away | 07:01 | |
openstackgerrit | esracelik proposed openstack/nova: Improve the help text for configdrive options https://review.openstack.org/266875 | 07:06 |
*** liusheng has joined #openstack-nova | 07:06 | |
*** gjayavelu has joined #openstack-nova | 07:07 | |
*** dedery has joined #openstack-nova | 07:08 | |
*** mjura has joined #openstack-nova | 07:09 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(3/5) https://review.openstack.org/261405 | 07:09 |
*** dedery_ has joined #openstack-nova | 07:10 | |
*** gjayavelu has quit IRC | 07:11 | |
*** gjayavelu has joined #openstack-nova | 07:11 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/265601 | 07:11 |
*** oomichi has joined #openstack-nova | 07:12 | |
*** dedery has quit IRC | 07:12 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: enginefacade: 'quota' and 'reservation' https://review.openstack.org/260549 | 07:14 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: enginefacade: 'instance_group' https://review.openstack.org/261316 | 07:14 |
tojuvone | oomichi: Hi, there. | 07:14 |
*** daemontool has joined #openstack-nova | 07:14 | |
oomichi | tojuvone: hey | 07:14 |
tojuvone | oomichi: Do you have some time to look at this once more: https://review.openstack.org/241562/ | 07:15 |
*** diana_clarke has quit IRC | 07:15 | |
*** thumpba has quit IRC | 07:16 | |
oomichi | tojuvone: ok, will review it later :) | 07:16 |
tojuvone | oomichi: Thanks. No major changes, it should be ready now :) | 07:17 |
*** gsilvis has joined #openstack-nova | 07:18 | |
*** shuquan has joined #openstack-nova | 07:18 | |
*** gjayavelu has quit IRC | 07:19 | |
*** daemontool has quit IRC | 07:22 | |
*** paul-carlton2 has joined #openstack-nova | 07:22 | |
*** cfriesen has quit IRC | 07:26 | |
*** thumpba has joined #openstack-nova | 07:26 | |
*** gtt116 has quit IRC | 07:26 | |
*** gtt116 has joined #openstack-nova | 07:27 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: enginefacade: 'fixed_ip' https://review.openstack.org/240811 | 07:27 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: enginefacade: 'instance' https://review.openstack.org/244146 | 07:27 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: enginefacade: 'security_group' https://review.openstack.org/246302 | 07:27 |
*** lpetrut has joined #openstack-nova | 07:27 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(4/5) https://review.openstack.org/261407 | 07:29 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: enginefacade: 'floating_ip' https://review.openstack.org/240513 | 07:30 |
*** ijw has joined #openstack-nova | 07:33 | |
*** aginwala has quit IRC | 07:34 | |
*** gongysh_ has joined #openstack-nova | 07:37 | |
*** suro-patz has quit IRC | 07:38 | |
openstackgerrit | Ren Qiaowei proposed openstack/nova: enable uefi boot for x86_64 https://review.openstack.org/262930 | 07:38 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(5/5) https://review.openstack.org/261410 | 07:41 |
*** mragupat has quit IRC | 07:42 | |
openstackgerrit | esracelik proposed openstack/nova: Config options: centralize section "hyperv" https://review.openstack.org/255124 | 07:48 |
*** Sukhdev has quit IRC | 07:49 | |
*** markus_z has joined #openstack-nova | 07:49 | |
*** salv-orl_ has quit IRC | 07:53 | |
*** salv-orlando has joined #openstack-nova | 07:53 | |
*** szhsong has joined #openstack-nova | 07:54 | |
*** belmoreira has joined #openstack-nova | 07:55 | |
openstackgerrit | Wen Zhi Yu proposed openstack/nova: Clean up network resources when reschedule fails https://review.openstack.org/243477 | 07:55 |
*** zhihais has quit IRC | 07:57 | |
openstackgerrit | Alex Xu proposed openstack/nova: doc: remove the detail about extensions and point to microversions https://review.openstack.org/267370 | 07:57 |
*** szhsong has quit IRC | 08:00 | |
*** otter768 has joined #openstack-nova | 08:00 | |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-nova | 08:01 | |
*** otter768 has quit IRC | 08:02 | |
*** otter768_ has joined #openstack-nova | 08:02 | |
*** shuquan has quit IRC | 08:03 | |
*** otter768_ has quit IRC | 08:04 | |
*** otter768 has joined #openstack-nova | 08:04 | |
*** jaosorior has quit IRC | 08:05 | |
*** otter768 has quit IRC | 08:05 | |
*** otter768 has joined #openstack-nova | 08:06 | |
*** shuquan has joined #openstack-nova | 08:06 | |
*** shuquan has quit IRC | 08:06 | |
openstackgerrit | Dao Cong Tien proposed openstack/nova-specs: Ironic serial console support https://review.openstack.org/267371 | 08:08 |
*** otter768_ has joined #openstack-nova | 08:08 | |
*** matrohon has joined #openstack-nova | 08:08 | |
*** otter768_ has quit IRC | 08:09 | |
*** shuquan has joined #openstack-nova | 08:09 | |
*** otter768_ has joined #openstack-nova | 08:10 | |
*** otter768 has quit IRC | 08:10 | |
*** otter768_ has quit IRC | 08:11 | |
*** otter768 has joined #openstack-nova | 08:12 | |
*** otter768_ has joined #openstack-nova | 08:13 | |
*** otter768 has quit IRC | 08:13 | |
*** RA_ has joined #openstack-nova | 08:14 | |
*** otter768_ has quit IRC | 08:15 | |
*** otter768 has joined #openstack-nova | 08:15 | |
*** paul-carlton2 has quit IRC | 08:17 | |
*** otter768_ has joined #openstack-nova | 08:17 | |
*** otter768 has quit IRC | 08:17 | |
*** zakora has joined #openstack-nova | 08:18 | |
*** otter768_ has quit IRC | 08:19 | |
*** otter768 has joined #openstack-nova | 08:19 | |
*** otter768_ has joined #openstack-nova | 08:21 | |
*** shuquan has quit IRC | 08:22 | |
*** oomichi is now known as oomich_away | 08:22 | |
*** otter76__ has joined #openstack-nova | 08:23 | |
*** otter768_ has quit IRC | 08:23 | |
*** rdopiera has joined #openstack-nova | 08:23 | |
*** jaosorior has joined #openstack-nova | 08:24 | |
*** otter768 has quit IRC | 08:24 | |
openstackgerrit | Dao Cong Tien proposed openstack/nova: [WIP] Ironic serial console support https://review.openstack.org/267384 | 08:25 |
*** shuquan has joined #openstack-nova | 08:25 | |
*** otter768 has joined #openstack-nova | 08:25 | |
*** otter76__ has quit IRC | 08:25 | |
*** rdopiera has quit IRC | 08:27 | |
*** otter768_ has joined #openstack-nova | 08:27 | |
*** rdopiera has joined #openstack-nova | 08:27 | |
*** shuquan has quit IRC | 08:27 | |
*** andrearo1 is now known as andrearosa | 08:28 | |
*** zhangjn has joined #openstack-nova | 08:28 | |
openstackgerrit | Marian Horban proposed openstack/nova: Restart of nova-compute service fixed https://review.openstack.org/258441 | 08:28 |
*** otter768 has quit IRC | 08:29 | |
*** otter76__ has joined #openstack-nova | 08:29 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Finish post live migration even when exception occurs https://review.openstack.org/235994 | 08:29 |
*** thumpba has quit IRC | 08:30 | |
*** otter768 has joined #openstack-nova | 08:31 | |
*** otter768_ has quit IRC | 08:32 | |
*** paul-carlton2 has joined #openstack-nova | 08:32 | |
*** shuquan has joined #openstack-nova | 08:32 | |
*** otter768_ has joined #openstack-nova | 08:32 | |
*** otter76__ has quit IRC | 08:33 | |
*** lpetrut has quit IRC | 08:33 | |
openstackgerrit | esracelik proposed openstack/nova: Config options: centralize section "cells" https://review.openstack.org/260181 | 08:33 |
*** otter76__ has joined #openstack-nova | 08:34 | |
*** otter768_ has quit IRC | 08:34 | |
*** otter768 has quit IRC | 08:35 | |
*** shuquan has quit IRC | 08:35 | |
*** shuquan has joined #openstack-nova | 08:36 | |
*** otter768 has joined #openstack-nova | 08:36 | |
*** MCoLo has joined #openstack-nova | 08:36 | |
*** otter76__ has quit IRC | 08:36 | |
*** zhangjn has quit IRC | 08:37 | |
*** otter768 has quit IRC | 08:38 | |
*** otter768 has joined #openstack-nova | 08:38 | |
*** jichen has joined #openstack-nova | 08:40 | |
*** ijw has quit IRC | 08:40 | |
*** jlanoux has joined #openstack-nova | 08:40 | |
*** jlanoux has quit IRC | 08:40 | |
*** otter768 has quit IRC | 08:40 | |
*** otter768_ has joined #openstack-nova | 08:40 | |
*** vilobhmm11 has quit IRC | 08:41 | |
*** jlanoux has joined #openstack-nova | 08:41 | |
openstackgerrit | Andrey Pavlov proposed openstack/nova: remove EC2 legacy code https://review.openstack.org/266425 | 08:42 |
*** otter768 has joined #openstack-nova | 08:42 | |
*** otter768_ has quit IRC | 08:42 | |
*** markvoelker has joined #openstack-nova | 08:43 | |
*** otter768 has quit IRC | 08:44 | |
*** otter768 has joined #openstack-nova | 08:44 | |
*** coolsvap is now known as coolsvap|away | 08:44 | |
*** otter768 has quit IRC | 08:45 | |
*** otter768 has joined #openstack-nova | 08:46 | |
*** otter768 has quit IRC | 08:47 | |
*** markvoelker has quit IRC | 08:48 | |
*** otter768 has joined #openstack-nova | 08:48 | |
*** e0ne has joined #openstack-nova | 08:48 | |
*** scheuran has joined #openstack-nova | 08:49 | |
*** otter768_ has joined #openstack-nova | 08:50 | |
*** RA_ has quit IRC | 08:51 | |
*** otter768_ has quit IRC | 08:52 | |
*** otter76__ has joined #openstack-nova | 08:52 | |
*** otter768 has quit IRC | 08:52 | |
*** otter76__ has quit IRC | 08:54 | |
*** otter768 has joined #openstack-nova | 08:54 | |
*** otter768 has quit IRC | 08:56 | |
*** otter768_ has joined #openstack-nova | 08:56 | |
*** derekh has joined #openstack-nova | 08:57 | |
*** salv-orlando has quit IRC | 08:57 | |
*** otter768 has joined #openstack-nova | 08:57 | |
*** otter768_ has quit IRC | 08:58 | |
*** salv-orlando has joined #openstack-nova | 08:58 | |
*** paul-carlton2 has quit IRC | 08:59 | |
*** otter768 has quit IRC | 08:59 | |
*** otter768 has joined #openstack-nova | 08:59 | |
*** tpatzig has joined #openstack-nova | 09:00 | |
*** haomaiwang has quit IRC | 09:01 | |
*** otter768 has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-nova | 09:01 | |
*** jistr has joined #openstack-nova | 09:03 | |
*** otter768 has joined #openstack-nova | 09:03 | |
*** otter768 has quit IRC | 09:05 | |
*** otter768 has joined #openstack-nova | 09:05 | |
*** salv-orlando has quit IRC | 09:05 | |
*** salv-orlando has joined #openstack-nova | 09:05 | |
*** otter768_ has joined #openstack-nova | 09:07 | |
*** zenoway has quit IRC | 09:09 | |
*** otter768_ has quit IRC | 09:09 | |
*** otter76__ has joined #openstack-nova | 09:09 | |
*** klkumar has joined #openstack-nova | 09:09 | |
*** zenoway has joined #openstack-nova | 09:09 | |
*** otter768 has quit IRC | 09:10 | |
tdurakov | hi everyone | 09:10 |
*** otter76__ has quit IRC | 09:10 | |
*** otter768 has joined #openstack-nova | 09:11 | |
*** scheuran has quit IRC | 09:11 | |
*** ndipanov has joined #openstack-nova | 09:12 | |
*** otter768_ has joined #openstack-nova | 09:13 | |
*** otter768 has quit IRC | 09:13 | |
*** zhangjn has joined #openstack-nova | 09:13 | |
*** zenoway has quit IRC | 09:14 | |
*** otter768 has joined #openstack-nova | 09:15 | |
*** yassine_ has joined #openstack-nova | 09:15 | |
*** dank_ has quit IRC | 09:15 | |
*** otter768_ has quit IRC | 09:15 | |
*** yamahata has joined #openstack-nova | 09:15 | |
*** shuquan has quit IRC | 09:15 | |
*** zhangjn has quit IRC | 09:16 | |
*** otter768 has quit IRC | 09:17 | |
*** otter768_ has joined #openstack-nova | 09:17 | |
*** shuquan has joined #openstack-nova | 09:17 | |
*** ig0r_ has joined #openstack-nova | 09:17 | |
*** atuvenie has joined #openstack-nova | 09:17 | |
*** shuquan has quit IRC | 09:17 | |
*** otter768_ has quit IRC | 09:18 | |
*** jamielennox is now known as jamielennox|away | 09:18 | |
*** otter768 has joined #openstack-nova | 09:19 | |
*** shuquan has joined #openstack-nova | 09:19 | |
openstackgerrit | Tobias Urdin proposed openstack/nova: Fix evaluation of host disk usage by volume-backed instances https://review.openstack.org/200870 | 09:19 |
*** zenoway has joined #openstack-nova | 09:20 | |
*** otter768 has quit IRC | 09:20 | |
*** otter768_ has joined #openstack-nova | 09:20 | |
*** daemontool has joined #openstack-nova | 09:23 | |
*** mgoddard has joined #openstack-nova | 09:24 | |
*** otter768 has joined #openstack-nova | 09:24 | |
*** otter768_ has quit IRC | 09:25 | |
openstackgerrit | sahid proposed openstack/os-vif: introduce vif.Config https://review.openstack.org/266768 | 09:25 |
*** otter768 has quit IRC | 09:26 | |
*** otter768 has joined #openstack-nova | 09:26 | |
*** ihrachys has joined #openstack-nova | 09:27 | |
*** otter768_ has joined #openstack-nova | 09:28 | |
*** paul-carlton2 has joined #openstack-nova | 09:29 | |
*** otter768_ has quit IRC | 09:30 | |
*** otter768_ has joined #openstack-nova | 09:30 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications https://review.openstack.org/263788 | 09:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add service status notification https://review.openstack.org/245678 | 09:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Generate doc for versioned notifications https://review.openstack.org/265151 | 09:31 |
*** otter768 has quit IRC | 09:31 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add infra for versioned notifications https://review.openstack.org/247024 | 09:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications https://review.openstack.org/248167 | 09:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable https://review.openstack.org/247564 | 09:31 |
*** otter768_ has quit IRC | 09:32 | |
*** otter768 has joined #openstack-nova | 09:32 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 09:32 |
*** otter768 has quit IRC | 09:34 | |
*** otter768_ has joined #openstack-nova | 09:34 | |
*** femnad has joined #openstack-nova | 09:35 | |
*** otter768_ has quit IRC | 09:35 | |
*** gcb has quit IRC | 09:35 | |
openstackgerrit | Sayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name https://review.openstack.org/263353 | 09:36 |
*** otter768 has joined #openstack-nova | 09:36 | |
*** otter768 has quit IRC | 09:37 | |
*** otter768_ has joined #openstack-nova | 09:38 | |
*** thumpba has joined #openstack-nova | 09:38 | |
*** oomich_away is now known as oomich | 09:39 | |
*** otter768 has joined #openstack-nova | 09:39 | |
*** otter768_ has quit IRC | 09:40 | |
*** sfinucan has joined #openstack-nova | 09:40 | |
*** lpetrut has joined #openstack-nova | 09:40 | |
*** ijw has joined #openstack-nova | 09:40 | |
*** danpb has joined #openstack-nova | 09:41 | |
*** ig0r_ has quit IRC | 09:41 | |
*** otter768 has quit IRC | 09:41 | |
*** otter768 has joined #openstack-nova | 09:42 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: fixed log warning in sqlalchemy/api.py https://review.openstack.org/246901 | 09:43 |
*** otter768 has quit IRC | 09:43 | |
*** otter768 has joined #openstack-nova | 09:43 | |
openstackgerrit | Dina Belova proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 09:44 |
*** markvoelker has joined #openstack-nova | 09:44 | |
*** RA_ has joined #openstack-nova | 09:45 | |
*** otter768_ has joined #openstack-nova | 09:45 | |
*** ijw has quit IRC | 09:45 | |
*** otter76__ has joined #openstack-nova | 09:47 | |
*** otter768_ has quit IRC | 09:47 | |
*** shuquan_ has joined #openstack-nova | 09:47 | |
*** otter768 has quit IRC | 09:48 | |
sfinucan | Morning, markus_z | 09:48 |
markus_z | sfinucan: hey hey, how's it going? | 09:48 |
*** shuquan has quit IRC | 09:48 | |
*** shuquan_ is now known as shuquan | 09:48 | |
*** thumpba has quit IRC | 09:48 | |
sfinucan | markus_z: Good :) | 09:48 |
sfinucan | I was hoping you might have some ideas on this issue I'm having | 09:49 |
*** markvoelker has quit IRC | 09:49 | |
markus_z | sure, which one? | 09:49 |
sfinucan | The docs test is failing for this review, but I can't figure out why. Would you have any ideas? https://review.openstack.org/#/c/257956/16 | 09:49 |
*** otter76__ has quit IRC | 09:49 | |
*** otter768 has joined #openstack-nova | 09:49 | |
markus_z | I know the error, I'm checking the code | 09:50 |
*** garyk has joined #openstack-nova | 09:50 | |
*** ajayaa has joined #openstack-nova | 09:50 | |
garyk | danpb: ndipanov: the patch https://review.openstack.org/#/c/252565/ addresses the issue with the additinal interfaces on the instance. | 09:50 |
*** otter768_ has joined #openstack-nova | 09:51 | |
sfinucan | markus_z: So I _think_ it's something to do with the default case | 09:51 |
sfinucan | or maybe appending to existing cases | 09:51 |
sfinucan | check this out | 09:51 |
markus_z | sfinucan: The code looks fine though. I check it out and test locally. | 09:52 |
*** otter768_ has quit IRC | 09:53 | |
*** otter768_ has joined #openstack-nova | 09:53 | |
*** otter768 has quit IRC | 09:53 | |
sfinucan | markus_z: http://paste.openstack.org/show/483857/ | 09:54 |
ndipanov | garyk, right | 09:54 |
sfinucan | the contents of that list doesn't look right, IMO | 09:54 |
*** otter768 has joined #openstack-nova | 09:55 | |
markus_z | sfinucan: jepp, I see it, but I don't understand right now why that is the case | 09:56 |
sfinucan | markus_z: That makes two of us | 09:56 |
*** otter768 has quit IRC | 09:57 | |
sfinucan | I'll add that changing it back to a tuple "fixes" the issue | 09:57 |
*** otter768 has joined #openstack-nova | 09:57 | |
*** otter768_ has quit IRC | 09:57 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Live migration fails when the instance has a config_drive_format=iso9660 https://review.openstack.org/234659 | 09:57 |
markus_z | sfinucan: give me a few minutes to dig deeper | 09:58 |
sfinucan | markus_z: no panic at all :) I've a meeting now but I'll look myself when I'm back | 09:59 |
sfinucan | assuming you haven't it long sussed by then, heh | 09:59 |
* sfinucan scarpers off | 09:59 | |
ndipanov | garyk, yeah I'll go back to that patch after the one I'm looking at now | 10:00 |
*** ijw has joined #openstack-nova | 10:00 | |
ndipanov | it's the best we can do without major refactor | 10:00 |
*** ajayaa has quit IRC | 10:00 | |
ndipanov | I'll also comment on the bug | 10:00 |
openstackgerrit | Sayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name https://review.openstack.org/263353 | 10:00 |
*** haomaiwang has quit IRC | 10:01 | |
*** otter768_ has joined #openstack-nova | 10:01 | |
*** ajayaa has joined #openstack-nova | 10:01 | |
garyk | ndipanov: ok, thanks | 10:01 |
*** otter768 has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-nova | 10:01 | |
ndipanov | to explain why is that the least bad solution | 10:01 |
*** oomich is now known as oomich_away | 10:01 | |
*** pradipta has quit IRC | 10:03 | |
*** otter768 has joined #openstack-nova | 10:03 | |
*** otter768_ has quit IRC | 10:03 | |
*** tiagogomes_ has left #openstack-nova | 10:04 | |
*** otter768 has quit IRC | 10:05 | |
*** otter768_ has joined #openstack-nova | 10:05 | |
*** ijw has quit IRC | 10:05 | |
*** otter768 has joined #openstack-nova | 10:06 | |
*** shuquan has quit IRC | 10:07 | |
*** otter768 has quit IRC | 10:08 | |
*** otter768 has joined #openstack-nova | 10:08 | |
*** otter768_ has quit IRC | 10:09 | |
*** EinstCrazy has quit IRC | 10:10 | |
*** salv-orl_ has joined #openstack-nova | 10:10 | |
*** otter768_ has joined #openstack-nova | 10:10 | |
*** otter768 has quit IRC | 10:10 | |
*** cdent has joined #openstack-nova | 10:11 | |
*** ajayaa has quit IRC | 10:12 | |
*** ajayaa has joined #openstack-nova | 10:12 | |
*** otter768 has joined #openstack-nova | 10:12 | |
*** otter768_ has quit IRC | 10:12 | |
*** salv-orlando has quit IRC | 10:12 | |
*** otter768 has quit IRC | 10:14 | |
*** otter768 has joined #openstack-nova | 10:14 | |
*** ptm_away is now known as PaulMurray | 10:15 | |
*** otter768_ has joined #openstack-nova | 10:16 | |
*** otter768 has quit IRC | 10:16 | |
openstackgerrit | Sayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name https://review.openstack.org/263353 | 10:18 |
*** otter768 has joined #openstack-nova | 10:18 | |
*** otter768_ has quit IRC | 10:18 | |
openstackgerrit | Andrey Pavlov proposed openstack/nova: remove EC2 legacy code https://review.openstack.org/266425 | 10:18 |
*** ljxiash has quit IRC | 10:19 | |
*** ljxiash has joined #openstack-nova | 10:20 | |
*** otter768_ has joined #openstack-nova | 10:20 | |
*** otter768 has quit IRC | 10:20 | |
*** yamahata has quit IRC | 10:21 | |
*** otter768 has joined #openstack-nova | 10:21 | |
*** otter768_ has quit IRC | 10:22 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova: Added new scheduler filter: AggregateTypeExtraSpecsAffinityFilter https://review.openstack.org/189279 | 10:22 |
*** yamahata has joined #openstack-nova | 10:23 | |
*** otter768 has quit IRC | 10:24 | |
*** otter768_ has joined #openstack-nova | 10:24 | |
*** ljxiash has quit IRC | 10:24 | |
*** lyanchih has quit IRC | 10:25 | |
*** otter768_ has quit IRC | 10:26 | |
*** otter768 has joined #openstack-nova | 10:26 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: hacking: check for common double word typos https://review.openstack.org/249193 | 10:27 |
*** lyanchih has joined #openstack-nova | 10:27 | |
*** otter768 has quit IRC | 10:27 | |
*** otter768 has joined #openstack-nova | 10:27 | |
*** yamahata has quit IRC | 10:28 | |
*** otter768 has quit IRC | 10:29 | |
*** otter768_ has joined #openstack-nova | 10:29 | |
*** atuvenie_ has joined #openstack-nova | 10:30 | |
*** lpetrut has quit IRC | 10:31 | |
*** aix has joined #openstack-nova | 10:32 | |
*** atuvenie has quit IRC | 10:33 | |
*** otter768_ has quit IRC | 10:34 | |
*** sudipto has joined #openstack-nova | 10:34 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.firewall' options https://review.openstack.org/257995 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.netutils' options https://review.openstack.org/258009 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'virt.images' conf options documentation https://review.openstack.org/259553 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.imagecache' options https://review.openstack.org/258984 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.images' options https://review.openstack.org/258004 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.disk' options https://review.openstack.org/258912 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.driver' options https://review.openstack.org/257956 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'virt.driver' conf options documentation https://review.openstack.org/266364 | 10:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'virt.firewall' conf options documentation https://review.openstack.org/266365 | 10:35 |
*** lyanchih has quit IRC | 10:37 | |
*** lpetrut has joined #openstack-nova | 10:39 | |
ndipanov | sfinucan, I think I found a bug in the isolate patch | 10:39 |
ndipanov | sfinucan, commenting now | 10:39 |
ndipanov | sfinucan, there | 10:41 |
openstackgerrit | Mike Fedosin proposed openstack/nova: [WIP] Make Xenplugin to work with glance v2 api https://review.openstack.org/266933 | 10:41 |
*** gongysh_ has quit IRC | 10:41 | |
*** baoli has joined #openstack-nova | 10:42 | |
openstackgerrit | Mike Fedosin proposed openstack/nova: [WIP] Make Xenplugin to work with glance v2 api https://review.openstack.org/266933 | 10:45 |
sfinucan | ndipanov: Good spot - I'll address it now | 10:45 |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: libvirt: make live_migration_uri flag dependent on virt_type https://review.openstack.org/175780 | 10:45 |
ndipanov | sfinucan, awesome! | 10:45 |
*** rfolco has joined #openstack-nova | 10:46 | |
openstackgerrit | jichenjc proposed openstack/nova: Use stub_out and mock to remove mox:part 3 https://review.openstack.org/264753 | 10:48 |
*** aix has quit IRC | 10:52 | |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: Adapt the code to the new get_by_volume BDM functions https://review.openstack.org/267464 | 10:55 |
*** shinobu_ has joined #openstack-nova | 10:57 | |
*** shinobu-compute has joined #openstack-nova | 10:58 | |
*** haomaiwang has quit IRC | 11:01 | |
ildikov | johnthetubaguy: hi. if you're around please abandon this patch for me: https://review.openstack.org/#/c/193133/ | 11:01 |
*** haomaiwang has joined #openstack-nova | 11:01 | |
*** ijw has joined #openstack-nova | 11:02 | |
*** Jeffrey4l has quit IRC | 11:04 | |
*** dims has joined #openstack-nova | 11:04 | |
*** ociuhandu has quit IRC | 11:05 | |
*** ociuhandu has joined #openstack-nova | 11:05 | |
*** ociuhandu has quit IRC | 11:06 | |
*** ijw has quit IRC | 11:07 | |
*** RA_ has quit IRC | 11:07 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: trivial: Add additional logs for NUMA scheduling https://review.openstack.org/254783 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling https://review.openstack.org/202655 | 11:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova: releasenotes: Note on CPU thread pinning support https://review.openstack.org/264693 | 11:08 |
*** amotoki_ has joined #openstack-nova | 11:09 | |
*** ljxiash has joined #openstack-nova | 11:11 | |
*** shyama has quit IRC | 11:11 | |
*** shyama has joined #openstack-nova | 11:12 | |
*** alexpilotti has joined #openstack-nova | 11:12 | |
*** kolesovdv has joined #openstack-nova | 11:12 | |
*** kmartin has quit IRC | 11:17 | |
*** lucas-dinner is now known as lucasagomes | 11:18 | |
*** aysyd has joined #openstack-nova | 11:21 | |
*** shyama has quit IRC | 11:21 | |
*** shyama has joined #openstack-nova | 11:22 | |
*** carey has quit IRC | 11:23 | |
*** fawadkhaliq has joined #openstack-nova | 11:25 | |
*** Marga_ has joined #openstack-nova | 11:29 | |
dedery_ | garyk: thanks for the validation and review | 11:30 |
*** shyama has quit IRC | 11:31 | |
*** shyama has joined #openstack-nova | 11:31 | |
*** zhangjn has joined #openstack-nova | 11:32 | |
*** EinstCrazy has joined #openstack-nova | 11:33 | |
*** Marga_ has quit IRC | 11:34 | |
tdurakov | sdague, hi, are you around? | 11:34 |
tdurakov | johnthetubaguy, got time to discuss ci for live-migration? | 11:35 |
johnthetubaguy | tdurakov: hows it going, with the ci? | 11:35 |
tdurakov | johnthetubaguy, ceph is done, now refactoring code to make it more readable, also there is a patch for current hook version: https://review.openstack.org/#/c/267154/ it would be great to merge it asap | 11:37 |
*** smatzek has joined #openstack-nova | 11:37 | |
*** ericksonsantos has joined #openstack-nova | 11:38 | |
tdurakov | btw, found out that live-migration fails on ci from time to time, http://logs.openstack.org/83/252283/79/experimental/gate-tempest-dsvm-multinode-live-migration/070dcc0/ from logs it looks like that there is some qemu bug, so need assistance with this | 11:38 |
*** rotbeard has joined #openstack-nova | 11:38 | |
tdurakov | johnthetubaguy, as a first step i think we need more logs for qemu, http://logs.openstack.org/83/252283/79/experimental/gate-tempest-dsvm-multinode-live-migration/070dcc0/logs/libvirt/qemu/instance-00000004.txt.gz - is not enough to find out reson imo | 11:39 |
*** ociuhandu has joined #openstack-nova | 11:39 | |
johnthetubaguy | tdurakov: so this is the kind of thing I expected us to find, thats really good info | 11:40 |
johnthetubaguy | tdurakov: heh "local of migration failed" | 11:41 |
johnthetubaguy | load | 11:41 |
tdurakov | johnthetubaguy, libvirt layer: http://xsnippet.org/361328/ | 11:41 |
tdurakov | yep, it totally poor info to figure out what is going on | 11:41 |
garyk | dedery_: np. thanks for fixing this! | 11:42 |
johnthetubaguy | tdurakov: got any ideas on how to add more? | 11:42 |
openstackgerrit | Matthew Booth proposed openstack/nova: Fix backing file detection in libvirt live snapshot https://review.openstack.org/264814 | 11:42 |
*** shyama_ has joined #openstack-nova | 11:42 | |
johnthetubaguy | tdurakov: oh, I see the snippet has way more info, gotcha | 11:42 |
johnthetubaguy | tdurakov: it says domain is not active, was the VM not running? | 11:42 |
*** shyama has quit IRC | 11:43 | |
*** shyama_ is now known as shyama | 11:43 | |
johnthetubaguy | tdurakov: I wonder if there is another failure causing the live-migrate failure? although its very likely a live-migrate problem | 11:43 |
*** zhangjn has quit IRC | 11:44 | |
johnthetubaguy | tdurakov: whats your plan for fixing the job then? adding in the extra debug info as a start? | 11:45 |
*** markvoelker has joined #openstack-nova | 11:45 | |
tdurakov | johnthetubaguy, snippet above from target node, there is strange info about interface | 11:45 |
johnthetubaguy | BobBall: was a bit worried about that vif patch, seems to ignore errors on vif.unplug? | 11:45 |
johnthetubaguy | tdurakov: you mean that top line? | 11:45 |
tdurakov | yep | 11:45 |
dedery_ | garyk: my pleasure (+it was super critical for our customers so I had to chase this one) | 11:45 |
johnthetubaguy | tdurakov: I wonder if that errors is because the VM was not started? I am not sure | 11:47 |
tdurakov | johnthetubaguy, i think no | 11:48 |
*** markvoelker has quit IRC | 11:49 | |
johnthetubaguy | tdurakov: I was just looking at the domain not started line in that log at the end, but maybe thats the destination domain? | 11:49 |
*** baoli has quit IRC | 11:50 | |
tdurakov | johnthetubaguy, yes, domain not started on dest | 11:50 |
tdurakov | because of error above | 11:50 |
johnthetubaguy | ah, OK, that fits | 11:50 |
*** amotoki_ has quit IRC | 11:50 | |
johnthetubaguy | tdurakov: I wonder if this is a neutron race to get the port setup during a live-migrate? | 11:51 |
tdurakov | johnthetubaguy, it's on nova-net | 11:51 |
BobBall | johnthetubaguy: Hmmm. Yes, fair enough. Thanks for the review. We'll update the change ASAP (tomorrow, Nanjing time) | 11:51 |
johnthetubaguy | tdurakov: cool, so its totally our fault | 11:51 |
johnthetubaguy | BobBall: no worries | 11:52 |
*** lpetrut has quit IRC | 11:52 | |
tdurakov | johnthetubaguy, looks so, this is floating error, I'm going to add more logging in hook, and maybe qemu | 11:52 |
garyk | dedery_: it alos covers a ton of other issues that were tried to be addressed in neutron but turned out to be rabbit holes | 11:52 |
*** lpetrut has joined #openstack-nova | 11:53 | |
*** ociuhandu has quit IRC | 11:53 | |
dedery_ | garyk: great! can you point me to some/all of them? I'd be happy to deep dive there. | 11:53 |
*** ociuhandu has joined #openstack-nova | 11:53 | |
BobBall | johnthetubaguy: Regarding the vif being removed, there are many many cases where we don't have that defensive code. Some where we do (e.g. vm_utils' cleanup_attached_vdis) but XAPI will actually raise a HANDLE_INVALID exception here. | 11:54 |
johnthetubaguy | tdurakov: a good plan, its just a case of keeping digging | 11:54 |
*** carey has joined #openstack-nova | 11:54 | |
tdurakov | johnthetubaguy, yep, but it about job stability, so we need to find out root cause | 11:54 |
*** gszasz has joined #openstack-nova | 11:54 | |
BobBall | johnthetubaguy: Since this is a VM operation it's already blocked on the VM mutex so I think it can't really happen though | 11:55 |
tdurakov | kashyap, hi, are you around? | 11:55 |
johnthetubaguy | BobBall: there is a case where we try to unplug and its already unplugged, thats cool, its the case the unplug failed that should be raised I think, since it used to be raised | 11:55 |
johnthetubaguy | BobBall: oh, you mean the VIFs thing, yeah, it *should* be safe, with only nova talking to xapi | 11:55 |
BobBall | johnthetubaguy: I agree with that one - I was meaning the VIF.get_record defensiveness you suggested of checking that vif_ref is not None | 11:55 |
johnthetubaguy | tdurakov: sounds like you are doing the right things | 11:56 |
BobBall | I think that if there's a concern that this generally _isn't_ safe then we need to do a lot of work to protect against that issue everywhere | 11:56 |
johnthetubaguy | BobBall: yeah, its only a Nit, just the None type can't do thingy, is an odd error to fail with | 11:56 |
tdurakov | johnthetubaguy, can I ask you to help with merging patch for ansible 2.0 folks use my job for live-migration testing, and it totally broken right now:( | 11:57 |
BobBall | johnthetubaguy: It won't return None, it'll raise a HANDLE_INVALID exception so we'd need a try/cathc | 11:57 |
BobBall | johnthetubaguy: I'm tempted to catch HANDLE_INVALID in client/session.py and convert it to a None though... | 11:57 |
johnthetubaguy | BobBall: oh right, I see, thats fine then | 11:57 |
johnthetubaguy | BobBall: hmm, not sure. can't remember what we do for VM now | 11:58 |
johnthetubaguy | BobBall: its an edge case, lets just keep it simple | 11:58 |
johnthetubaguy | tdurakov: whats the patch? | 11:58 |
tdurakov | johnthetubaguy, https://review.openstack.org/#/c/267154/ | 11:58 |
johnthetubaguy | I am about to run for lunch, but lets take a peak | 11:58 |
BobBall | johnthetubaguy: Will do. | 11:59 |
johnthetubaguy | tdurakov: does that work with both 1.x and 2.x? | 12:00 |
*** haomaiwang has quit IRC | 12:01 | |
*** haomaiwang has joined #openstack-nova | 12:01 | |
* johnthetubaguy bravely runs away, for food | 12:03 | |
*** ijw has joined #openstack-nova | 12:04 | |
openstackgerrit | Sayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name https://review.openstack.org/263353 | 12:04 |
*** alexpilotti has quit IRC | 12:04 | |
mdbooth | ndipanov: Could you shovel this back into the gate for me: https://review.openstack.org/#/c/264814/ | 12:04 |
mdbooth | Had to update it for a merge conflict | 12:04 |
mdbooth | And it's holding up the liberty release, as I understand it | 12:05 |
ndipanov | mdbooth, no +2 on stable sorry | 12:05 |
mdbooth | ndipanov: This is the master commit | 12:05 |
tdurakov | johnthetubaguy, works for both versions | 12:05 |
mdbooth | The liberty backport is held up on the master patch merging | 12:05 |
mdbooth | If I can get this merged, we'll be 1 step closer :) | 12:05 |
*** sakthi has quit IRC | 12:06 | |
mdbooth | It has been into the gate twice, now :/ | 12:07 |
ildikov | johnthetubaguy: thanks | 12:07 |
mdbooth | Hit spurious failures both times, then bounced by a merge conflict | 12:07 |
*** ijw has quit IRC | 12:09 | |
*** burgerk has joined #openstack-nova | 12:10 | |
*** lyanchih has joined #openstack-nova | 12:12 | |
*** smatzek has quit IRC | 12:12 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Expose quiesce/unquiesce API https://review.openstack.org/248989 | 12:12 |
*** ajayaa has quit IRC | 12:16 | |
*** ajayaa has joined #openstack-nova | 12:16 | |
*** takashin has quit IRC | 12:17 | |
*** sudipto has quit IRC | 12:17 | |
*** rqw has joined #openstack-nova | 12:18 | |
*** gongysh_ has joined #openstack-nova | 12:18 | |
*** sudipto has joined #openstack-nova | 12:19 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: objects: add virtual 'image_meta' property to Instance object https://review.openstack.org/190145 | 12:19 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert to use instance.image_meta property https://review.openstack.org/190146 | 12:20 |
openstackgerrit | Daniel Berrange proposed openstack/nova: compute: convert manager to use nova.objects.ImageMeta https://review.openstack.org/189685 | 12:20 |
*** shuquan has joined #openstack-nova | 12:21 | |
*** aix has joined #openstack-nova | 12:22 | |
*** raildo-afk is now known as raildo | 12:22 | |
openstackgerrit | Rui Chen proposed openstack/nova: Only return latest fault of each instance in db api https://review.openstack.org/223392 | 12:23 |
openstackgerrit | Rui Chen proposed openstack/nova: Create image for suspended instance booted from volume https://review.openstack.org/223382 | 12:24 |
openstackgerrit | Daniel Berrange proposed openstack/nova: hacking: check for common double word typos https://review.openstack.org/249193 | 12:24 |
openstackgerrit | Rui Chen proposed openstack/nova-specs: Task states improvement https://review.openstack.org/216578 | 12:24 |
*** sudipto has quit IRC | 12:25 | |
*** burgerk has quit IRC | 12:25 | |
*** smatzek has joined #openstack-nova | 12:26 | |
openstackgerrit | Rui Chen proposed openstack/python-novaclient: Fix Resource.__eq__ mismatch semantics of object equal https://review.openstack.org/251020 | 12:28 |
*** shuquan has quit IRC | 12:28 | |
*** lyanchih has quit IRC | 12:28 | |
ndipanov | dedery_, hey - commented on your patch and here: https://review.openstack.org/#/c/230919/2 | 12:30 |
ndipanov | would love to hear your thoughts | 12:30 |
*** otter768 has joined #openstack-nova | 12:30 | |
*** rqw has quit IRC | 12:31 | |
*** irenab_ has joined #openstack-nova | 12:32 | |
*** erlon has joined #openstack-nova | 12:32 | |
*** irenab_ has quit IRC | 12:33 | |
*** rqw has joined #openstack-nova | 12:33 | |
*** irenab has quit IRC | 12:33 | |
openstackgerrit | jichenjc proposed openstack/nova: WIP:remove OS-EXT-IPS and OS-EXT-IPS-MAC extension https://review.openstack.org/266533 | 12:33 |
*** irenab has joined #openstack-nova | 12:35 | |
*** otter768 has quit IRC | 12:35 | |
*** irenab_ has joined #openstack-nova | 12:38 | |
*** cdent has quit IRC | 12:39 | |
*** rqw has quit IRC | 12:39 | |
*** rqw has joined #openstack-nova | 12:40 | |
*** irenab has quit IRC | 12:40 | |
*** irenab_ is now known as irenab | 12:40 | |
dedery_ | ndipanov: thank you. replied in the comments. | 12:41 |
*** thorst has joined #openstack-nova | 12:41 | |
*** baoli has joined #openstack-nova | 12:41 | |
*** markvoelker has joined #openstack-nova | 12:45 | |
*** houming has quit IRC | 12:46 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Split-network-plane-for-live-migration https://review.openstack.org/245005 | 12:46 |
*** thumpba has joined #openstack-nova | 12:47 | |
openstackgerrit | garyk proposed openstack/nova: Objects: correctly update the ImageMeta version https://review.openstack.org/267524 | 12:48 |
*** scheuran has joined #openstack-nova | 12:48 | |
garyk | danpb: sahid: ^ | 12:48 |
*** smoriya__ has quit IRC | 12:48 | |
markus_z | edleafe: I'm doint a review day today with the config options patches. Your scheduler help text patches have merge problems. Need help there? | 12:48 |
garyk | ndipanov: ^^ | 12:48 |
*** markvoelker has quit IRC | 12:50 | |
danpb | garyk: no, that's wrong - we don't tie versions together anymore | 12:51 |
*** tiagogomes has joined #openstack-nova | 12:51 | |
tiagogomes | Hello, can a host be in multiple availability zones? | 12:51 |
garyk | danpb: ok, thanks! | 12:51 |
openstackgerrit | Sean Dague proposed openstack/nova-specs: add spec for instance flavor API https://review.openstack.org/265282 | 12:51 |
*** thumpba has quit IRC | 12:53 | |
*** kaisers has quit IRC | 12:53 | |
mdbooth | Does any core have a second to push this back into the gate for me: https://review.openstack.org/#/c/264814/ | 12:55 |
mdbooth | It was merge conflicted out of the gate. | 12:55 |
mdbooth | Has now re-passed check. | 12:55 |
mdbooth | I understand that it's holding up a liberty release. | 12:56 |
openstackgerrit | garyk proposed openstack/nova: Objects: add limits, reservations and shares to ImageMetaProps object https://review.openstack.org/188321 | 12:57 |
*** ccarmack has joined #openstack-nova | 12:57 | |
*** ccarmack has left #openstack-nova | 12:57 | |
openstackgerrit | garyk proposed openstack/nova: VMware: support limits via image meta data https://review.openstack.org/180942 | 12:58 |
*** haomaiwang has quit IRC | 12:59 | |
openstackgerrit | Sayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name https://review.openstack.org/263353 | 13:00 |
*** doug-fish has joined #openstack-nova | 13:01 | |
mdbooth | johnthetubaguy: ^^^ Just looking for a procedural +2, +W on that patch | 13:02 |
*** gcb has joined #openstack-nova | 13:04 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Add Console and ConsolePool objects https://review.openstack.org/267539 | 13:04 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Make use of new Console and ConsolePool objects https://review.openstack.org/267540 | 13:04 |
*** ijw has joined #openstack-nova | 13:05 | |
*** shinobu-compute has quit IRC | 13:06 | |
openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266687 | 13:06 |
*** doug-fish has quit IRC | 13:07 | |
*** fawadkhaliq has quit IRC | 13:07 | |
*** doug-fish has joined #openstack-nova | 13:08 | |
*** zenoway has quit IRC | 13:08 | |
*** garyk has quit IRC | 13:08 | |
*** ijw has quit IRC | 13:09 | |
sfinucan | ndipanov: Done and done https://review.openstack.org/#/c/202655/ | 13:09 |
*** dedery has joined #openstack-nova | 13:12 | |
*** doug-fish has quit IRC | 13:12 | |
*** diogogmt has quit IRC | 13:14 | |
ndipanov | sfinucan, nice - alaski will hopefully +2 it too and then we can bikeshed on debug vs info :) | 13:15 |
*** dedery_ has quit IRC | 13:15 | |
*** akshai has joined #openstack-nova | 13:15 | |
sfinucan | ndipanov: Can't wait :) | 13:16 |
alaski | I say warning, perhaps audit | 13:16 |
ndipanov | I'm firmly in the info camp | 13:16 |
*** diogogmt has joined #openstack-nova | 13:17 | |
alaski | I haven't actually gone through that patch yet, will look after going through this one again | 13:17 |
ndipanov | tbh I am not sure about logging there | 13:17 |
ndipanov | my gut feeling is debug because normally you don't need that much info from that filter | 13:18 |
*** ducttape_ has joined #openstack-nova | 13:18 | |
*** cdent has joined #openstack-nova | 13:19 | |
*** mtanino has joined #openstack-nova | 13:19 | |
sfinucan | ndipanov: alaski: I'm also unsure. I found it helpful during debugging, but I got requests saying it added little extra | 13:19 |
sfinucan | hence why it was a different patch | 13:19 |
sfinucan | I'd like to be a little more verbose if I could, and say exactly _why_ it failed for all cases | 13:19 |
johnthetubaguy | mdbooth: sorry was eating lunch, taking a peak now | 13:19 |
mdbooth | johnthetubaguy: Thanks. ndipanov might possibly beat you to it, though :) | 13:20 |
johnthetubaguy | even better | 13:20 |
ndipanov | johnthetubaguy, don't give up though - you can still win this :) | 13:20 |
*** shyama has quit IRC | 13:21 | |
*** smatzek has quit IRC | 13:21 | |
PaulMurray | mdbooth, I added storage pools on the midcycle etherpad as a "suggested feature discussion" | 13:21 |
*** shyama has joined #openstack-nova | 13:21 | |
mdbooth | PaulMurray: Cool, thanks. | 13:21 |
PaulMurray | mdbooth, would you check what I put is right please | 13:22 |
mdbooth | Sure, do you have the link to hand? | 13:22 |
PaulMurray | https://etherpad.openstack.org/p/mitaka-nova-midcycle | 13:22 |
PaulMurray | L37 | 13:22 |
mdbooth | Seen | 13:23 |
johnthetubaguy | tdurakov: did you seem my note on that patch, I wonder if we should check the ansible version? | 13:23 |
*** nithyag_ has quit IRC | 13:24 | |
tdurakov | johnthetubaguy, well, we could, but what we should do if it doensn't fit our expectations? | 13:24 |
alaski | ndipanov: sfinucan looking at this my first thought is that the current debugs are good at that level, but the logging at the call site of that method should perhaps be info | 13:24 |
tdurakov | as i wrote above this change works for both 1.x and 2.x either | 13:25 |
*** shyama has quit IRC | 13:25 | |
*** markvoelker has joined #openstack-nova | 13:25 | |
johnthetubaguy | tdurakov: sorry, missed your note, I am cool if it works for both versions | 13:25 |
*** shyama has joined #openstack-nova | 13:25 | |
*** browne has joined #openstack-nova | 13:26 | |
johnthetubaguy | tdurakov: FWIW, I was thinking we just error out and fail the script if it doesn't match, but works on both is way better than that option | 13:26 |
*** _diana_1 has joined #openstack-nova | 13:26 | |
tdurakov | johnthetubaguy, acked, will save some amount of time | 13:27 |
*** lyanchih has joined #openstack-nova | 13:28 | |
*** carey has quit IRC | 13:28 | |
*** haomaiwang has joined #openstack-nova | 13:30 | |
mdbooth | PaulMurray: I've added some more in there. Having not attended a midcycle before, I'm not sure how it runs. Is the timing of this discussion likely to be predictable? I think I mentioned that I'm only planning a daytrip. | 13:31 |
*** doug-fish has joined #openstack-nova | 13:31 | |
sfinucan | alaski: Yeah, I might try focus on that | 13:31 |
mdbooth | ndipanov: johnthetubaguy beat you :) | 13:32 |
sfinucan | Issue was that I didn't have information like instance available in the function, so logs were missing important info | 13:32 |
PaulMurray | mdbooth, I think we can arrange that | 13:32 |
PaulMurray | johnthetubaguy, ^^^ | 13:32 |
sfinucan | I'll figure something out | 13:33 |
PaulMurray | mdbooth, do you have any restriction on which day? | 13:33 |
johnthetubaguy | mdbooth: happy to tie down some times if you need that | 13:33 |
mdbooth | PaulMurray: The day before is plenty notice, btw. | 13:33 |
*** ccarmack has joined #openstack-nova | 13:33 | |
mdbooth | No restrictions. | 13:33 |
mdbooth | johnthetubaguy: Any time is fine as long as I know at least the day before. | 13:34 |
*** smatzek has joined #openstack-nova | 13:34 | |
*** ducttape_ has quit IRC | 13:35 | |
alaski | sfinucan: yeah, the log additions are nice. but I agree with mikal that an info level log would be nice for operators who aren't at debug. however your additional logs fit at debug | 13:35 |
*** dedery_ has joined #openstack-nova | 13:35 | |
PaulMurray | johnthetubaguy, talking about the midcycle, what times do you think are good for start and end of day? | 13:35 |
*** cdent has quit IRC | 13:35 | |
mdbooth | For those of us with a 2 hour drive: 8am is not cool :) | 13:35 |
PaulMurray | 8:30 :) | 13:36 |
mdbooth | :P | 13:36 |
PaulMurray | mdbooth, next year we could do it at your castle | 13:37 |
*** ferest has joined #openstack-nova | 13:37 | |
mdbooth | You'd have to fight off the tourists. | 13:37 |
*** dedery has quit IRC | 13:37 | |
mdbooth | It'd probably be a really good venue for it apart from that, though. | 13:38 |
*** dslevin has quit IRC | 13:39 | |
*** edmondsw has joined #openstack-nova | 13:39 | |
johnthetubaguy | PaulMurray: I was thinking we start at 9am, but that more because its what we normally do | 13:40 |
*** diogogmt has quit IRC | 13:41 | |
johnthetubaguy | mdbooth: which bit are you wanting to attend, the live-migrate stuff? | 13:41 |
mdbooth | johnthetubaguy: Yeah. | 13:41 |
PaulMurray | johnthetubaguy, that's ok - its hard to predict what traffic will be like if anyone is driving from in town | 13:42 |
PaulMurray | 9:30 would be easy to get to - but 9:00 should be ok | 13:42 |
* mdbooth used to do Cheltenham daily on a motorcycle in 50 mins. | 13:42 | |
*** dedery_ has quit IRC | 13:42 | |
mdbooth | Bristol's another 30/40 mins? | 13:42 |
danpb | for those of us who like to sleep, 8am is not cool either :-) | 13:43 |
danpb | working from home, i'm used to waking up at 8:50 to start working at 9:00 :-) | 13:44 |
mdbooth | danpb: Is midcycle going to be an opportunity to sleep it :) | 13:44 |
mdbooth | in | 13:44 |
lxsli | I'd recommend 9:30 for traffic reasons | 13:44 |
danpb | mdbooth: you didn't fancy staying at the holiday inn then ? | 13:44 |
* mdbooth tries to start work at 9:30, and wake up by lunchtime | 13:44 | |
_diana_1 | I don't suppose the unit tests are segfaulting for anyone else? Locally, that is. In particular these: test_signature_utils (openssl/cryptography). | 13:45 |
* PaulMurray starts to understand why the code is the way it is | 13:45 | |
danpb | _diana_1: not noticed that for me on Fedora 23 hosts | 13:45 |
mdbooth | _diana_1: There was a Fedora snafu a while back with a crypo library | 13:45 |
mdbooth | _diana_1: If you aren't fully updated, you might be hitting that | 13:45 |
mdbooth | You'll also need to ensure you rebuild the python cryptography library after fully updating | 13:46 |
mdbooth | Noting that a compiled version can be cached in a bunch of places | 13:46 |
_diana_1 | I've spent hours on this… I can't for the life of me fix it. But it helps knowing others have seen it. I'll try again. Thanks! | 13:46 |
mdbooth | If you're hitting the same issue, you'll be getting a dynamic link error. | 13:47 |
mdbooth | Some EC stuff was removed from the library, but not from the headers. | 13:47 |
*** dslev has joined #openstack-nova | 13:48 | |
*** browne has quit IRC | 13:48 | |
bauzas | nova meeting in 10 mins, amirite? | 13:48 |
johnthetubaguy | mikal tjones cburgess jgrimm adrian_otto funzo mjturek jcookekhugen irina_pov krtaylor danpb alexpilotti flip214 jaypipes garyk edleafe dims moshele anteaya Nisha sileht claudiub lxsli neiljerram markus_z swamireddy alevine tonyb andreykurilin ndipanov sc68cal akuriata artom jlvillal mnestratov kashyap aloga rgeragnov bauzas xyang tpatil med_ nic scottda nagyz belliott dguitarbite sdague jroll diana_clarke | 13:49 |
johnthetubaguy | _diana_ raildo jichen gjayavelu mdorman klindgren sorrison belmoreira mrda auggy PaulMurray gcb thorst duncant macsz thomasem tpatzig | 13:49 |
edleafe | markus_z: just getting to my desk. Looks like the base move patch still has issues. | 13:49 |
johnthetubaguy | ^ Nova meeting in a few moments in #openstack meeting | 13:49 |
thomasem | hey | 13:49 |
sdague | johnthetubaguy: ack | 13:49 |
edleafe | markus_z: let me dig into that first | 13:49 |
thomasem | cool, thanks! | 13:49 |
johnthetubaguy | bauzas: heh, thats a +1 from me | 13:50 |
gcb | cool | 13:50 |
bauzas | :) | 13:50 |
sdague | _diana_1: did you try deleting your .tox dir? | 13:50 |
*** dedery has joined #openstack-nova | 13:50 | |
sdague | in case it's stale and there was something with an abi bump | 13:50 |
*** jenie has joined #openstack-nova | 13:51 | |
jenie | hello | 13:51 |
jenie | I am trying to spin an instance and I get a weird nova error | 13:51 |
jenie | "RESP BODY: {"computeFault": {"message": "Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.\n<type 'exceptions.ValueError'>", "code": 500}}" | 13:51 |
jenie | what is the meaning of this error ? | 13:51 |
jenie | I am using liberty | 13:52 |
*** dslev_ has joined #openstack-nova | 13:54 | |
johnthetubaguy | jenie: I would try on #openstack for usage issues, this is the development channel | 13:55 |
johnthetubaguy | jenie: I suspect you will need to look at the logs to get a more detailed error about what is going wrong, folks in #openstack should be able to help with that | 13:56 |
jenie | johnthetubaguy: Since it said bug, I thought it is worthwhile to ask devs | 13:56 |
tiagogomes | Hi, is it safe to have a host in multiple availability zones, assuming that each availability zone will only have a single aggregate? | 13:56 |
*** dslev has quit IRC | 13:57 | |
jenie | johnthetubaguy: the log has got the nothing and I am running nova using --debug option | 13:57 |
johnthetubaguy | tiagogomes: it breaks the idea of availability zones of being distinct groups of hosts that fail independently | 13:57 |
*** lyanchih has quit IRC | 13:58 | |
johnthetubaguy | jenie: I would ask the folks in #openstack who can help you find the debug info you need, could be in syslog, those folks will be able to help more with that | 13:58 |
jenie | johnthetubaguy: okay but here atleast you responded , their no one seems to be responding | 13:59 |
*** rlrossit has joined #openstack-nova | 13:59 | |
tiagogomes | yes, but if you have a blade server, you want each blade to be an AZ. But if in the future you connect that blade server to another blade server to extend power and storage, you want an AZ by blade server | 13:59 |
jenie | I just created a pastebin, if it is worthwhile for any developers to look it could be nice of you | 14:00 |
jenie | http://pastebin.com/C69DcUwm | 14:00 |
johnthetubaguy | tiagogomes: there is a spec about hierarchical zones that can be used for server groups, it sounds similar to what you are wanting | 14:00 |
*** dslev_ has quit IRC | 14:00 | |
*** haomaiwang has quit IRC | 14:01 | |
*** rgerganov has joined #openstack-nova | 14:01 | |
_diana_1 | sdague: Yup, I tried that. Even just importing that test class causes a segfault for me now (which is why test discovery fails). Things were fine yesterday… I suspect I messed my openssl install up somehow. Off to try again. Thanks. | 14:01 |
*** haomaiwa_ has joined #openstack-nova | 14:01 | |
tiagogomes | johnthetubaguy any change of that spec being implemented for Mitaka? | 14:02 |
*** ijw has joined #openstack-nova | 14:05 | |
*** vivekd has quit IRC | 14:06 | |
*** ashishjain has joined #openstack-nova | 14:06 | |
*** zz_dimtruck is now known as dimtruck | 14:08 | |
*** ctrath has joined #openstack-nova | 14:08 | |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments https://review.openstack.org/193135 | 14:08 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: comp: Prep Nova to allow multiple volume attachments https://review.openstack.org/193134 | 14:08 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 14:08 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: virt: Pass host when call attach to Cinder https://review.openstack.org/256273 | 14:08 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: comp: Allow volume multiattach https://review.openstack.org/267587 | 14:08 |
*** jenie has quit IRC | 14:10 | |
*** ijw has quit IRC | 14:10 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 14:10 |
ildikov | johnthetubaguy: hi | 14:11 |
ildikov | johnthetubaguy: I reorganized the multiattach code ^^ | 14:11 |
ildikov | johnthetubaguy: the first two patches need to make it into Mitaka in order to be able to enable the feature for Newton | 14:12 |
ildikov | johnthetubaguy: if we find a way to get all in that would be the best of course, but I thought to do this reorg just in case | 14:13 |
*** mdrabe has joined #openstack-nova | 14:14 | |
*** ducttape_ has joined #openstack-nova | 14:16 | |
*** dslev has joined #openstack-nova | 14:16 | |
*** wanghao has quit IRC | 14:17 | |
ndipanov | johnthetubaguy, so here's an interesting potentially very useful https://review.openstack.org/#/c/230919/2 | 14:19 |
ndipanov | bugfix | 14:19 |
ndipanov | johnthetubaguy, addresses the same issue as this one https://review.openstack.org/#/c/252565/ | 14:20 |
*** lucasagomes is now known as lucas-hungry | 14:20 | |
ndipanov | (we should probably have both, but we should definitely have the first one...) | 14:20 |
*** thumpba has joined #openstack-nova | 14:21 | |
*** zakora has quit IRC | 14:21 | |
ndipanov | I would really like the fix to land on master at least but I guess seeing that this is easy to change/backout it's ok | 14:21 |
*** jichen has quit IRC | 14:23 | |
*** jenie has joined #openstack-nova | 14:23 | |
jenie | unable to get help in #openstack channel | 14:24 |
jenie | what shall I fo | 14:24 |
jenie | http://pastebin.com/pyamYRem | 14:24 |
*** vladikr has joined #openstack-nova | 14:24 | |
*** zakora has joined #openstack-nova | 14:24 | |
openstackgerrit | Ren Qiaowei proposed openstack/nova: enable uefi boot for x86_64 https://review.openstack.org/262930 | 14:25 |
*** dims has quit IRC | 14:26 | |
dedery | ndipanov: thank you for the review and comments | 14:29 |
*** dims has joined #openstack-nova | 14:30 | |
*** cdent has joined #openstack-nova | 14:30 | |
*** zakora has quit IRC | 14:30 | |
*** jenie has quit IRC | 14:30 | |
*** otter768 has joined #openstack-nova | 14:31 | |
*** annegentle has joined #openstack-nova | 14:32 | |
*** zakora has joined #openstack-nova | 14:33 | |
*** changbl has quit IRC | 14:34 | |
*** otter768 has quit IRC | 14:35 | |
*** smatzek has quit IRC | 14:35 | |
*** dedery_ has joined #openstack-nova | 14:37 | |
*** dedery_ has quit IRC | 14:37 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add helper shim for getting items https://review.openstack.org/265995 | 14:37 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Remove DictCompat from ComputeNode https://review.openstack.org/265521 | 14:37 |
*** dedery_ has joined #openstack-nova | 14:37 | |
*** mrkz has joined #openstack-nova | 14:38 | |
*** xyang1 has joined #openstack-nova | 14:39 | |
*** browne has joined #openstack-nova | 14:39 | |
*** jistr has quit IRC | 14:40 | |
*** haomaiwa_ has quit IRC | 14:40 | |
*** dedery has quit IRC | 14:40 | |
*** jistr has joined #openstack-nova | 14:41 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [python3] byte/string conversions and enable more tests https://review.openstack.org/261045 | 14:41 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [python3] Port more code to python3 and enable tests https://review.openstack.org/262083 | 14:41 |
*** mriedem_away is now known as mriedem | 14:42 | |
*** jaosorior has quit IRC | 14:42 | |
*** jaosorior has joined #openstack-nova | 14:43 | |
*** dimtruck is now known as zz_dimtruck | 14:44 | |
*** mmedvede has quit IRC | 14:44 | |
*** jaosorior has quit IRC | 14:44 | |
*** cfriesen has joined #openstack-nova | 14:44 | |
*** jaosorior has joined #openstack-nova | 14:45 | |
*** rgerganov has quit IRC | 14:45 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'aggregate' https://review.openstack.org/262248 | 14:46 |
*** ducttape_ has quit IRC | 14:47 | |
openstackgerrit | Ren Qiaowei proposed openstack/nova: enable uefi boot for x86_64 https://review.openstack.org/262930 | 14:48 |
*** garyk has joined #openstack-nova | 14:48 | |
*** cfriesen has quit IRC | 14:48 | |
*** cfriesen has joined #openstack-nova | 14:49 | |
mriedem | missed it by that much | 14:49 |
*** shyama has quit IRC | 14:49 | |
*** shyama has joined #openstack-nova | 14:49 | |
johnthetubaguy | ndipanov: thats the one gary hit the other day? | 14:50 |
*** gcb has quit IRC | 14:50 | |
mriedem | garyk: do you want to see this get into the 12.0.1 liberty release? https://review.openstack.org/#/c/266096/ | 14:50 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'instance_group' https://review.openstack.org/261316 | 14:51 |
ndipanov | johnthetubaguy, yeah - several people keep hitting it | 14:51 |
ildikov | dansmith: mriedem: hi, I uploaded the get_by_volume_* changes on top of Dan's patch | 14:51 |
ndipanov | as you can see from the bug count and attempts at fixing it | 14:51 |
ildikov | dansmith: mriedem: I also reorganized the multiattach series | 14:51 |
garyk | mriedem: yes. do we have time? | 14:51 |
*** artom_ has quit IRC | 14:52 | |
*** chhavi has joined #openstack-nova | 14:52 | |
mriedem | garyk: yeah | 14:52 |
garyk | ok, thanks! | 14:52 |
*** links has quit IRC | 14:52 | |
ndipanov | johnthetubaguy, the patch I linked is small and correct in the general case - I hope my explanation helps | 14:52 |
*** ashishjain has quit IRC | 14:54 | |
mriedem | ndipanov: ewww | 14:54 |
mriedem | https://review.openstack.org/#/c/186315/ was backported back to all of the stable branches too | 14:54 |
ndipanov | mriedem, that's fine | 14:54 |
ndipanov | there's a fix that makes it irrelevant | 14:54 |
ndipanov | mriedem, which actually adds locking | 14:54 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'instance_group' https://review.openstack.org/261316 | 14:55 |
*** Sukhdev has joined #openstack-nova | 14:55 | |
ndipanov | mriedem, https://review.openstack.org/#/c/194597/ | 14:55 |
ndipanov | so if a stable branch does not have this | 14:55 |
ndipanov | than the fix above you mention is "fine" | 14:55 |
ndipanov | if it does however - it should also have the fix I linked | 14:55 |
ndipanov | mriedem, makes sense?? | 14:56 |
mriedem | not really, i don't have them all in my head, or haven't looked at them all either | 14:57 |
mriedem | plus just got online and no coffee | 14:57 |
*** ashishjain has joined #openstack-nova | 14:57 | |
mriedem | ndipanov: so it sounds like we want the locking change in the stable branches? https://review.openstack.org/#/q/I6ea2eda8a61f418b0c32f13a7ed6904352712857,n,z | 14:58 |
mriedem | which would just be stable/kilo for the locking one | 14:58 |
*** dave-mccowan has joined #openstack-nova | 14:58 | |
mriedem | dansmith: has a -2 on https://review.openstack.org/#/c/233611/ because sahid had a -1 | 14:58 |
mriedem | but it sounds like that's been sorted out now | 14:58 |
ndipanov | mriedem, in that case you want to also grab the revert of the fix | 14:59 |
ndipanov | so if a stable doesn't have it | 14:59 |
ndipanov | I'd leave it at that | 14:59 |
mriedem | what is 'it' in this case? the locking one? | 14:59 |
ndipanov | or backport locking + https://review.openstack.org/#/c/230919/ | 14:59 |
ndipanov | so either have locking + https://review.openstack.org/#/c/230919/ | 14:59 |
_diana_1 | alaski, sdague: May I please have the +2s & workflow added back on this review (https://review.openstack.org/#/c/265082/)? I had to rebase. Thanks! | 14:59 |
ndipanov | mriedem, or don't touch it | 14:59 |
sdague | _diana_1: looking | 15:00 |
*** Daisy has joined #openstack-nova | 15:00 | |
mriedem | ndipanov: ok, so it sounds like we should just abandon https://review.openstack.org/#/c/233611/ | 15:00 |
sdague | I'll look after this next meeting | 15:00 |
mriedem | since kilo doesn't have the locking change | 15:00 |
ndipanov | mriedem, yes | 15:00 |
*** haomaiwa_ has joined #openstack-nova | 15:00 | |
*** dave-mcc_ has joined #openstack-nova | 15:00 | |
*** haomaiwa_ has quit IRC | 15:01 | |
ndipanov | mriedem, that is correct | 15:01 |
mriedem | ndipanov: and since locking is in stable/liberty (https://review.openstack.org/#/c/194597/), we'll want to backport https://review.openstack.org/#/c/230919/ to stable/liberty | 15:01 |
ndipanov | mriedem, right | 15:01 |
ndipanov | as soon as we land it on master | 15:01 |
ndipanov | ideally we'd want both on stable/kilo too but not sure we care enough | 15:01 |
mriedem | kilo doesn't have the locking thing, as noted | 15:02 |
mriedem | i just abandoned https://review.openstack.org/#/c/233611/ for kilo | 15:02 |
mriedem | kilo is security / critical fix mode anyway, and with the amount of confusion on this, i don't think it's a candidate | 15:02 |
ndipanov | mriedem, agreed | 15:04 |
*** dave-mccowan has quit IRC | 15:04 | |
*** ijw has joined #openstack-nova | 15:05 | |
gibi | hi cores! the versioned notification reviews need a second +2. The chain starts here: https://review.openstack.org/#/c/247024 | 15:05 |
openstackgerrit | Ren Qiaowei proposed openstack/nova: enable uefi boot for x86_64 https://review.openstack.org/262930 | 15:06 |
openstackgerrit | Dan Smith proposed openstack/nova: Allow sending the migrate data objects over the wire https://review.openstack.org/251588 | 15:08 |
mriedem | mdbooth: i see you hit a merge conflict | 15:09 |
mdbooth | mriedem: Yup. Updated the stable backport to reflect that. | 15:10 |
*** smatzek has joined #openstack-nova | 15:10 | |
mriedem | i'm kind of wondering if we should backport https://review.openstack.org/#/c/264349/ | 15:10 |
mriedem | but that's getting messy | 15:10 |
*** takedakn has joined #openstack-nova | 15:10 | |
*** pradk has joined #openstack-nova | 15:11 | |
bauzas | mriedem: not sure it's super urgent for that one | 15:12 |
mriedem | it's not urgent, no | 15:12 |
bauzas | we could wait for a .2 | 15:12 |
bauzas | but the backport is acceptable yes | 15:12 |
mriedem | but if we did backport it at some point, it would probably have merge conflicts with https://review.openstack.org/#/c/264817/ | 15:12 |
*** atuvenie_ has quit IRC | 15:12 | |
mriedem | b/c https://review.openstack.org/#/c/264817/ on master has conflicts with https://review.openstack.org/#/c/264349/ | 15:13 |
*** Jeffrey4l has joined #openstack-nova | 15:13 | |
mriedem | but, yeah, we could play this dance forever and never get 12.0.1 out, which is my priority | 15:13 |
*** zz_dimtruck is now known as dimtruck | 15:13 | |
bauzas | mriedem: but the master one has been rebased on top of the latter 264349 right?N | 15:13 |
bauzas | yeah, I'm taking lot of time to review the ones you gave me yesterday | 15:14 |
mriedem | that's true | 15:14 |
mriedem | so nvm | 15:14 |
openstackgerrit | Ren Qiaowei proposed openstack/nova: enable uefi boot for x86_64 https://review.openstack.org/262930 | 15:15 |
mriedem | gdi, i'm distracted by the guy snoring in the office behind me at 9am | 15:15 |
rlrossit | mriedem: sorry, I'll wake up | 15:16 |
rlrossit | that or just start coughing loudly | 15:16 |
rlrossit | dansmith: opinion time. If I want to replicate the behavior of things in https://review.openstack.org/#/c/265951/3/nova/api/openstack/compute/floating_ips.py L48-54, I need to add NotImplementedError to the except in order to maintain the 'if it isn't set' check... is that cool or not cool? | 15:17 |
johnthetubaguy | mriedem: coffee machine broken or something? | 15:18 |
*** mmedvede has joined #openstack-nova | 15:18 | |
dansmith | rlrossit: you mean because it ends up trying to lazy-load a thing? | 15:18 |
mriedem | johnthetubaguy: he usually only snores around 1pm | 15:18 |
rlrossit | dansmith: yeah | 15:18 |
mriedem | johnthetubaguy: must be narcoleptic | 15:18 |
johnthetubaguy | ah, post lunch snooze | 15:18 |
mriedem | or just near retirement and doesn't give an f | 15:18 |
dansmith | rlrossit: I dunno, that seems kinda wrong, but I don't know why.. I guess it's replicating the behavior there | 15:19 |
rlrossit | dansmith: agreed... it seems very very wrong. I'm just not sure what they were trying to catch in that situation. Not having a fixed ip on the floating ip? or the fixed ip not having an address? | 15:20 |
dansmith | well, yeah, but I meant.. It feels wrong to catch notimplemented there | 15:20 |
dansmith | rlrossit: you can of course just do: | 15:20 |
rlrossit | obj_attr_is_set? | 15:20 |
dansmith | if 'address' in fixedip: ... else: .. = None | 15:20 |
mriedem | use in, it's much nicer looking | 15:21 |
rlrossit | yup | 15:21 |
rlrossit | dansmith: but keep the try still right? | 15:21 |
*** pratikmallya has joined #openstack-nova | 15:22 | |
dansmith | rlrossit: would we ever hit it? | 15:22 |
*** edtubill has joined #openstack-nova | 15:22 | |
*** doug-fish has quit IRC | 15:22 | |
* rlrossit shrugs | 15:22 | |
rlrossit | this isn't tested, so I dunno | 15:22 |
*** doug-fish has joined #openstack-nova | 15:22 | |
dansmith | heh | 15:23 |
*** lucas-hungry is now known as lucasagomes | 15:24 | |
rlrossit | let me try testing again without the try/except and let me see what happens | 15:24 |
*** carey has joined #openstack-nova | 15:24 | |
*** mragupat has joined #openstack-nova | 15:25 | |
*** takedakn1 has joined #openstack-nova | 15:25 | |
rlrossit | dansmith: ohh I think I get it. I think that's how they find out if the floating ip is allocated or not, maybe? | 15:26 |
dansmith | sounds right | 15:26 |
rlrossit | because I think most of the time it's getting key error on fixed_ip | 15:26 |
*** doug-fish has quit IRC | 15:27 | |
*** takedakn has quit IRC | 15:27 | |
*** takedakn1 is now known as takedakn | 15:27 | |
mriedem | rlrossit: floating ip or fixed ip? | 15:28 |
mriedem | because https://github.com/openstack/nova/blob/master/nova/objects/fixed_ip.py#L57 | 15:28 |
rlrossit | this is in the floating ip api, it's checking if floating ip has a fixed ip | 15:28 |
ndipanov | mriedem, are you looking into this? | 15:29 |
mriedem | ndipanov: the master branch changes? | 15:29 |
*** carey has quit IRC | 15:29 | |
ndipanov | yes | 15:29 |
*** mdrabe has quit IRC | 15:29 | |
mriedem | i haven't dug in, was going to read the nova meeting minutes first and catch up on some things | 15:29 |
mriedem | i can add to the queue | 15:29 |
*** doug-fish has joined #openstack-nova | 15:29 | |
mriedem | ndipanov: i read your big comment on the race and locking thing, and i just got scared | 15:29 |
ndipanov | mriedem, yeah it's messed up | 15:30 |
*** mgoddard has quit IRC | 15:30 | |
*** angdraug has joined #openstack-nova | 15:30 | |
ndipanov | but it comes down to - when is that method supposed to mutate the info-cache | 15:30 |
*** mgoddard has joined #openstack-nova | 15:30 | |
ndipanov | and the answer is - only when there is actual data passed in | 15:31 |
mriedem | ndipanov: i wasn't really clear on your comments in https://review.openstack.org/#/c/230919/ about whether or not we even needed that if we had https://review.openstack.org/#/c/252565/ | 15:31 |
*** pratikma_ has joined #openstack-nova | 15:31 | |
ndipanov | mriedem, so imho we should have both | 15:31 |
mriedem | "This patch does one harmful thing though, which is making a call to get_instance_nw_info potentially destructive even if there are no ports/networks passed in." | 15:31 |
ndipanov | the second one is not going to do anything if we land the first one | 15:31 |
*** jang has quit IRC | 15:32 | |
mriedem | why would we land the 2nd one then? | 15:32 |
ndipanov | mriedem, so I am refering to the patch beint reverted | 15:32 |
markus_z | hm, I forgot the meeting today... | 15:32 |
ndipanov | mriedem, well | 15:32 |
ndipanov | we don't need to really | 15:32 |
ndipanov | I'd prefer that we land https://review.openstack.org/#/c/230919/ | 15:33 |
*** takedakn has quit IRC | 15:33 | |
ndipanov | the second one is more of a sanity check | 15:33 |
*** jang has joined #openstack-nova | 15:33 | |
mriedem | :) | 15:34 |
ndipanov | it would make sure that - should we mess this up again in the future - we don't keep corrupting the nwinfo | 15:34 |
*** pratikmallya has quit IRC | 15:34 | |
*** doug-fish has quit IRC | 15:34 | |
ndipanov | so I am in favor of it | 15:34 |
mriedem | i'd probably have to dig into the bugs and locking change to get an idea for what the failure is, | 15:34 |
ndipanov | basically | 15:34 |
mriedem | i just know we've struggled over this nw info cache code in neutron several times, | 15:34 |
mriedem | it's like whack a mole | 15:34 |
mriedem | and the mole always wins | 15:34 |
ndipanov | if the event comes from neutron first | 15:35 |
ndipanov | before there was a race | 15:35 |
ndipanov | but now there isn't | 15:35 |
ndipanov | to mitigate the race | 15:35 |
*** jwcroppe has joined #openstack-nova | 15:35 | |
mriedem | there isn't a race b/c of the locking added in liberty? | 15:35 |
ndipanov | yes | 15:35 |
ndipanov | so if the event makes it in first | 15:35 |
ndipanov | it sees no ports | 15:35 |
ndipanov | asks neutron - do we have some ports | 15:36 |
ndipanov | and saves them to infocache | 15:36 |
ndipanov | then the boot thread goes in | 15:36 |
*** omnipresent has joined #openstack-nova | 15:36 | |
ndipanov | checks the info cache | 15:36 |
mriedem | which event? | 15:36 |
ndipanov | and just adds the same ports | 15:36 |
mriedem | vif-plugged? | 15:36 |
ndipanov | port update | 15:36 |
johnthetubaguy | does the port uuid not help us spot the existing items? | 15:37 |
ndipanov | johnthetubaguy, well we didn't check for it | 15:37 |
ndipanov | that's what the second patch does | 15:37 |
johnthetubaguy | oh right | 15:37 |
ndipanov | but that should never really happen because | 15:37 |
ndipanov | the event shoulc never add stuff to info-cache | 15:37 |
ndipanov | actually I wonder if it needs to refresh it at ll | 15:37 |
johnthetubaguy | I think its floating ips | 15:38 |
*** EinstCrazy has quit IRC | 15:38 | |
ndipanov | since the assumption is that it came from nova so it wil get refreshed eventually | 15:38 |
johnthetubaguy | and the metadata service | 15:38 |
ndipanov | johnthetubaguy, but that won't work | 15:38 |
ndipanov | since we don't pass anything in to that call | 15:38 |
*** akshai has quit IRC | 15:38 | |
ndipanov | meaning it will just look at what's in the cache | 15:38 |
johnthetubaguy | floating ips just an update to an existing port, usually, I think | 15:39 |
ndipanov | but that update should come from the thread adding the floating -ip | 15:40 |
*** Sukhdev has quit IRC | 15:40 | |
ndipanov | in case it doesn't though then yeah | 15:40 |
johnthetubaguy | add floating ip is a neturon API call, not a nova one, but anyways, I should stop distracting | 15:40 |
*** Sukhdev has joined #openstack-nova | 15:40 | |
ndipanov | johnthetubaguy, yeah makes sense then | 15:40 |
johnthetubaguy | ndipanov: which one is the port uuid patch? | 15:41 |
ndipanov | johnthetubaguy, https://review.openstack.org/#/c/252565/ | 15:41 |
johnthetubaguy | ah, ack, thanks | 15:41 |
*** rushiagr_away is now known as rushiagr | 15:42 | |
*** artom_ has joined #openstack-nova | 15:42 | |
ndipanov | johnthetubaguy, in that case yes refreshing should never really add ports unless they were passed in | 15:43 |
ndipanov | which is what merging this gives us https://review.openstack.org/#/c/230919/ | 15:44 |
*** rqw has quit IRC | 15:44 | |
*** Sukhdev has quit IRC | 15:46 | |
*** akshai has joined #openstack-nova | 15:46 | |
*** armax has quit IRC | 15:47 | |
*** doug-fish has joined #openstack-nova | 15:47 | |
*** claudiub has joined #openstack-nova | 15:48 | |
johnthetubaguy | ndipanov: I wonder about edge cases around failed unplugs, but yeah, this feels a lot like how mriedem described it... | 15:48 |
johnthetubaguy | ndipanov: I like the port uuid and network thing though, that seems very safe | 15:49 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: add index/show API for server migrations https://review.openstack.org/258771 | 15:49 |
*** mdrabe has joined #openstack-nova | 15:49 | |
mriedem | i want him to remove the bug refs from the code | 15:49 |
mriedem | so -1 on that | 15:49 |
*** doug-fis_ has joined #openstack-nova | 15:49 | |
mriedem | all of the list comprehension and negative logic definitely makes this not fun to read | 15:49 |
mriedem | it's not not easy to read | 15:50 |
mriedem | wait :) | 15:50 |
*** femnad has quit IRC | 15:51 | |
mriedem | ndipanov: i see now what you mean by https://review.openstack.org/#/c/252565/ being a safeguard though, | 15:51 |
mriedem | it's just adding the filtering should it happen, and then logging the warning that we've missed something | 15:51 |
*** ducttape_ has joined #openstack-nova | 15:52 | |
*** doug-fish has quit IRC | 15:52 | |
dedery_ | mriedem: hi, +1 for the negative logic. will fix. I was wondering about it myself | 15:52 |
*** armax has joined #openstack-nova | 15:52 | |
*** armax has quit IRC | 15:52 | |
mriedem | negative logic is one thing, but wrapped in a block of list comprehension and my head starts to hurt | 15:53 |
*** kolesovdv has quit IRC | 15:53 | |
dedery_ | mriedem: I was wondering about how to do it neatly on one hand and how to log the issues on another | 15:53 |
mriedem | otherwise i'm ok with this once that's cleaned up | 15:53 |
dedery_ | I'm totally open for suggestions | 15:53 |
*** annegentle has quit IRC | 15:54 | |
mriedem | i made some suggestions in the _logged_is_not_in method | 15:54 |
dedery_ | i saw it but i wonder if there's another way to wrap the logging with the list creation | 15:54 |
mriedem | https://docs.python.org/2/library/functions.html#filter | 15:55 |
*** femnad has joined #openstack-nova | 15:55 | |
mriedem | pass your logging funtion into filter with the ifaces list | 15:55 |
*** Sukhdev has joined #openstack-nova | 15:55 | |
dedery_ | great! will work on it and submit another patchset | 15:55 |
mriedem | and call the logging function 'filter_duplicates' or something | 15:56 |
*** kylek3h has quit IRC | 15:56 | |
openstackgerrit | Matthew Booth proposed openstack/nova: Remove fake_imagebackend.Raw and cleanup dependent tests https://review.openstack.org/267661 | 15:56 |
openstackgerrit | Matthew Booth proposed openstack/nova: Update import_file to provide a general-purpose interface https://review.openstack.org/267662 | 15:56 |
dedery_ | + will mv the bug ref comments to the commit message | 15:56 |
*** vishwanathj_away is now known as vishwanathj | 15:57 | |
mriedem | k | 15:58 |
*** Daisy has quit IRC | 16:00 | |
*** Jeffrey4l has quit IRC | 16:00 | |
johnthetubaguy | mriedem: +1 your comments, I quite like the match up on port uuid and network uuid though, that makes good sense to me | 16:00 |
johnthetubaguy | the general case at least | 16:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.firewall' options https://review.openstack.org/257995 | 16:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.netutils' options https://review.openstack.org/258009 | 16:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'virt.images' conf options documentation https://review.openstack.org/259553 | 16:00 |
*** Daisy has joined #openstack-nova | 16:00 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.imagecache' options https://review.openstack.org/258984 | 16:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.images' options https://review.openstack.org/258004 | 16:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.disk' options https://review.openstack.org/258912 | 16:01 |
*** doug-fis_ has quit IRC | 16:01 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise 'virt.driver' options https://review.openstack.org/257956 | 16:01 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'virt.driver' conf options documentation https://review.openstack.org/266364 | 16:01 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'virt.firewall' conf options documentation https://review.openstack.org/266365 | 16:01 |
*** doug-fish has joined #openstack-nova | 16:01 | |
*** mjura has quit IRC | 16:01 | |
*** doug-fish has quit IRC | 16:01 | |
*** doug-fish has joined #openstack-nova | 16:02 | |
*** gongysh_ has quit IRC | 16:02 | |
*** unicell has joined #openstack-nova | 16:04 | |
*** Daisy has quit IRC | 16:05 | |
*** belmoreira has quit IRC | 16:06 | |
*** unicell1 has quit IRC | 16:06 | |
*** armax has joined #openstack-nova | 16:06 | |
*** yamahata has joined #openstack-nova | 16:06 | |
*** doug-fish has quit IRC | 16:07 | |
*** ihrachys has quit IRC | 16:07 | |
*** jlanoux has quit IRC | 16:08 | |
*** rotbeard has quit IRC | 16:09 | |
*** salv-orlando has joined #openstack-nova | 16:09 | |
mriedem | dansmith: alaski: i just replied to the thread on multiattach, there is no policy in cinder against creating a multiattach volume, | 16:11 |
*** fawadkhaliq has joined #openstack-nova | 16:11 | |
*** fawadkhaliq has quit IRC | 16:11 | |
mriedem | their capabilities filter will check for a host that supports multiattach based on the volume driver backends per host | 16:12 |
*** vivekd has joined #openstack-nova | 16:12 | |
*** fawadkhaliq has joined #openstack-nova | 16:12 | |
dansmith | ah | 16:12 |
mriedem | so if you try to create a volume with multiattach and there are no hosts that support that, it'll fail with NoValidHost | 16:12 |
mriedem | lvm supports it though | 16:12 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: deprecate live/block_migration_flag opts https://review.openstack.org/263436 | 16:12 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: remove the live/block_migration_flag opts https://review.openstack.org/263437 | 16:12 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: add a new live_migration_tunnelled config https://review.openstack.org/263434 | 16:12 |
mriedem | so by default, the reference impl in cinder allows you to create a multiattach volume, but if you're using only xen virt drivers, you'll get NoValidHost at BFV or attach volume | 16:13 |
openstackgerrit | Tom Patzig proposed openstack/nova-specs: Add volume option to flavors https://review.openstack.org/267673 | 16:13 |
alaski | so it fails in the same way that Nova will | 16:13 |
ildikov | mriedem: 3PAR supports it too AFAIK | 16:13 |
ildikov | but the scenario is correct | 16:13 |
mriedem | ildikov: sure, some of the 50 cinder backends might support it | 16:13 |
*** salv-orl_ has quit IRC | 16:13 | |
mriedem | alaski: yeah i suppose so | 16:14 |
*** tonytan4ever has joined #openstack-nova | 16:14 | |
mriedem | cinder fails in the scheduler, nova fails on the compute | 16:14 |
mriedem | which is picked based on where the instance is | 16:14 |
alaski | ahh | 16:14 |
mriedem | in the attach case i mean | 16:14 |
alaski | but compute failures end up looking like scheduler failures | 16:15 |
mriedem | BFV is a crapshoot, unless you're using AZs or something | 16:15 |
mriedem | sure | 16:15 |
markmc | _diana_1, the signature utils unit tests on Fedora - does https://review.openstack.org/#/c/260277/ help? | 16:15 |
*** ashishjain has quit IRC | 16:16 | |
alaski | mriedem: dansmith at rax they would add a policy to disable it to move the error to the api. not saying it's the right way, but it does provide immediate feedback | 16:16 |
*** ctrath has quit IRC | 16:16 | |
mriedem | yeah... | 16:17 |
dansmith | alaski: we did say disabling features via policy sucks though right? | 16:17 |
alaski | yep | 16:17 |
mriedem | i was going to say, that's the same as a config option in volume_api.check_attach | 16:17 |
*** yamahata has quit IRC | 16:18 | |
markus_z | auggy: Thanks for taking the bug skimming duty for the next 7 days. Just as a heads-up, I'm out of office tomorrow. | 16:18 |
*** yamahata has joined #openstack-nova | 16:18 | |
alaski | I would like to use flavors, or flavor addons, as a way to provide some feedback about compute capabilities within a deployment | 16:18 |
*** paul-carlton2 has quit IRC | 16:19 | |
mriedem | alaski: dansmith: so even if we have a microversion on the attach/bfv api, you can still land on a compute that doesn't support it and blow up, which is i guess why a microversion is not required for this? | 16:19 |
mriedem | but a microversion still signals, | 16:19 |
mriedem | you at least have a chance at this working, assuming hte cloud supports it | 16:19 |
dansmith | right, I still like the signaling, even if it's not a guarantee | 16:20 |
alaski | agreed, it is useful | 16:20 |
dansmith | but I was expecting sdague to tell me I was abusing the infra with that suggestion :) | 16:20 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix instance not destroyed after successful evacuation https://review.openstack.org/250101 | 16:20 |
*** edtubill has quit IRC | 16:20 | |
bauzas | dansmith: mriedem: found some corner case ^ | 16:20 |
alaski | dansmith: when you only have a hammer... | 16:20 |
*** edtubill has joined #openstack-nova | 16:20 | |
*** diogogmt has joined #openstack-nova | 16:21 | |
mriedem | dansmith: well, it is an api behavior change, so it seems a microversion is warranted | 16:21 |
bauzas | when an instance is evacuated successfully, the source host (when back up) is not able to delete it so it prevents a new migration to get back the instance to the source | 16:21 |
bauzas | mriedem: dansmith: https://bugs.launchpad.net/nova/+bug/1518200 | 16:21 |
openstack | Launchpad bug 1518200 in OpenStack Compute (nova) "instance is not destroyed on source host after a successful evacuate" [Medium,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 16:21 |
auggy | markus_z: np, I am doing my best! | 16:22 |
dansmith | bauzas: okay I'll look in a sec | 16:22 |
bauzas | dansmith: no worries, I just thought you could be interested in because of robustify-evacuate | 16:22 |
*** tpatzig has left #openstack-nova | 16:22 | |
bauzas | that's a bug, we can wait for it | 16:22 |
*** doug-fish has joined #openstack-nova | 16:23 | |
bauzas | but it could be also a good candidate for liberty | 16:23 |
* bauzas goes back reviewing, yay | 16:23 | |
mriedem | bauzas: i like that it's a list of possible values | 16:23 |
mriedem | as i was reading the bug | 16:23 |
*** doug-fis_ has joined #openstack-nova | 16:24 | |
bauzas | mriedem: yeah I preferred to modify the DB API to accept a list rather than just doing a list comprehension like the owner did in the previous PS | 16:24 |
*** edtubill has quit IRC | 16:24 | |
dedery_ | mriedem: going back to https://review.openstack.org/#/c/252565/8/nova/network/neutronv2/api.py and trying to apply the filter(function, items) logic to it I think that it'll become more of a mess in a way. I might be missing something here though | 16:24 |
ildikov | mriedem: I assume that the microversion discussion has not much to do with when the feature can get in besides the time I would need to implement it, is this assumption correct? | 16:24 |
*** vivekd has quit IRC | 16:26 | |
markus_z | sfinucan: I'm reviewing your pci config change, do you have a minute for a question? | 16:26 |
johnthetubaguy | alaski: dansmith: mriedem: FWIW, I like the micro version just to advertise its possible, even if we let all folks attach to multi-attach volumes | 16:26 |
sfinucan | markus_z: Hit me | 16:26 |
*** rook-desktio has joined #openstack-nova | 16:27 | |
markus_z | sfinucan: I don't get the sentence "This field can be specified multiple times" for the whitelist. | 16:27 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: deprecate live/block_migration_flag opts https://review.openstack.org/263436 | 16:27 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: remove the live/block_migration_flag opts https://review.openstack.org/263437 | 16:27 |
*** doug-fish has quit IRC | 16:27 | |
johnthetubaguy | mriedem: you made a point about only certain cinder backends supporting multi-attach, I guess thats covered by checks in cinder? | 16:27 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: add a new live_migration_tunnelled config https://review.openstack.org/263434 | 16:27 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: force use of direct vs p2p migration https://review.openstack.org/263432 | 16:27 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: force config related migration flags https://review.openstack.org/263433 | 16:27 |
*** ducttape_ has quit IRC | 16:27 | |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: parse live migration flags at startup https://review.openstack.org/263430 | 16:27 |
openstackgerrit | Mark McLoughlin proposed openstack/nova: libvirt: force use/non-use of NON_SHARED_INC flag https://review.openstack.org/263431 | 16:27 |
*** whenry has joined #openstack-nova | 16:27 | |
ildikov | johnthetubaguy: if a back end does not support it you cannot create a multiattach volume | 16:27 |
alaski | johnthetubaguy: it's checked by a cinder scheduler filter | 16:27 |
*** edtubill has joined #openstack-nova | 16:27 | |
*** suro-patz has joined #openstack-nova | 16:27 | |
ildikov | johnthetubaguy: it will fail with an error | 16:28 |
*** Guest77121 is now known as med_ | 16:28 | |
*** med_ has quit IRC | 16:28 | |
*** med_ has joined #openstack-nova | 16:28 | |
_diana_1 | markmc: The signature util tests are failing for me on my mac (not fedora), but they worked fine yesterday, so I suspect I've just done something wrong upgrading openssl, but I'll give that patch a shot in a bit. Thanks! | 16:28 |
mriedem | dedery_: i think i'm seeing what you mean | 16:28 |
johnthetubaguy | ildikov: alaski: cool, I hope that was the case | 16:28 |
*** doug-fis_ has quit IRC | 16:28 | |
sfinucan | markus_z: I took that from the spec https://github.com/openstack/nova-specs/blob/master/specs/juno/implemented/pci-passthrough-sriov.rst | 16:29 |
*** ducttape_ has joined #openstack-nova | 16:29 | |
*** rook-desktio is now known as rook-desktop | 16:29 | |
sfinucan | Having tested it, you can indeed specify the 'pci_passthrough_whitelist' option multiple times in your nova.conf file | 16:29 |
dedery_ | mriedem: and above all logic, if i want the logging to have reference to the instance i'd need to send another parameter to the filtering function - which is not possible (unless i send a tuple) | 16:29 |
sfinucan | I don't know if that's "out of character" for a configuration option - the spec made me think it was hence why I brought it up | 16:30 |
markus_z | sfinucan: seriously? that works? | 16:30 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused db parameter from scheduler.utils.set_vm_state_and_notify() https://review.openstack.org/267682 | 16:30 |
sfinucan | markus_z: Sure does. Don't ask me how :) | 16:30 |
*** ctrath has joined #openstack-nova | 16:30 | |
*** doug-fish has joined #openstack-nova | 16:30 | |
markus_z | sfinucan: I'm not sure if this is a feature or a bug... | 16:31 |
*** _diana_1 has quit IRC | 16:31 | |
mriedem | dedery_: yeah, maybe the filter idea doesn't work here | 16:31 |
sfinucan | markus_z: Heh - like I said I took the spec to be the source of truth | 16:32 |
*** otter768 has joined #openstack-nova | 16:32 | |
sfinucan | I can remove if you don't agree with it though | 16:32 |
mriedem | dedery_: so i'm ok with not using filter(), but can you cleanup the negative logic, remove the bug references, and for extra credit the test you added with the duplicate network ids - it'd be good if that validated that you logged the warning | 16:32 |
*** Daisy has joined #openstack-nova | 16:33 | |
ildikov | johnthetubaguy: can somehow the multiattach be handled as a some kind of extension to the simple attach? | 16:33 |
mriedem | johnthetubaguy: re: multiattach, yeah, the cinder scheduler will filter out hosts/backends that don't support a volume create request with multiattach | 16:33 |
dedery_ | mriedem: np | 16:33 |
markus_z | sfinucan: wuah, I need a minute to digest that. OK, I understand it now. Thanks | 16:33 |
*** omnipresent has quit IRC | 16:34 | |
*** otter768 has quit IRC | 16:36 | |
*** vivekd has joined #openstack-nova | 16:37 | |
*** paul-carlton1 has quit IRC | 16:37 | |
ildikov | johnthetubaguy: I mean basically the feature we have here is the attach, which is on the other hand a cross-project feature | 16:38 |
markus_z | sfinucan: ok, wait, I think I got it. You *can* have "pci_passthrough_whitelist" multiple times in the nova.conf but only the last read value is used. | 16:38 |
ildikov | johnthetubaguy: with multiattach we kind of enable the extra function that Cinder provides | 16:38 |
markus_z | sfinucan: Having it "multiple_times" means you can add the dict multiple times like in the unit test: https://github.com/openstack/nova/blob/master/nova/tests/unit/pci/test_stats.py#L206 | 16:38 |
markus_z | sfinucan: The examples in the spec have an *OR* relationship and a misleading description above | 16:39 |
sfinucan | markus_z: Ah, so the spec is wrong. I'll go back and fix that, assuming I'm allowed fix something so old | 16:40 |
sfinucan | as for that change, I can update the change saying as much | 16:40 |
markus_z | sfinucan: let me add a few nits, takes 5 min | 16:41 |
sfinucan | markus_z: sure :) | 16:41 |
markus_z | Then push a change and I +1 it | 16:41 |
mriedem | bauzas: i have some concerns with the tests here https://review.openstack.org/#/c/250101/ | 16:41 |
bauzas | mriedem: yeah the compute test is silly, I had doubts on it | 16:42 |
mriedem | ildikov: re: the microversion for multiattach, that's an API change and i think it would come in N when we enable the API support | 16:42 |
bauzas | since we're mocking the output, we don't really care | 16:42 |
mriedem | bauzas: yeah, and it's functionally equivalent to the test it's copied rom | 16:42 |
mriedem | *from | 16:42 |
bauzas | yeah I know | 16:42 |
*** dedery has joined #openstack-nova | 16:43 | |
bauzas | like I said, I was not super overwhelmed by that | 16:43 |
bauzas | one single test is enough IMHO, thanks for reviewing, will modify that | 16:43 |
mriedem | bauzas: or update the existing test in test_compute_mgr to set the migration status to 'done' like the new test does, | 16:44 |
mriedem | that test is a bit hokey anyway since it doesn't set the migration status | 16:44 |
mriedem | but at least we could make an attempt at reality :) | 16:45 |
*** nkrinner has quit IRC | 16:45 | |
*** mgoddard_ has joined #openstack-nova | 16:45 | |
bauzas | mriedem: yeah, I was thinking of that when saying "one single test" | 16:45 |
ildikov | mriedem: ok, got it | 16:45 |
mriedem | johnthetubaguy: i saw in the nova meeting "so this afternoon, I am thinking of kicking out all blueprints that don't yet have any code up for review" | 16:45 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [python3] byte/string conversions and enable more tests https://review.openstack.org/261045 | 16:46 |
mriedem | johnthetubaguy: you don't think we can get code up for a bp in the next week and have it merged? :P | 16:46 |
*** zenoway has joined #openstack-nova | 16:46 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [python3] Port more code to python3 and enable tests https://review.openstack.org/262083 | 16:46 |
*** kylek3h has joined #openstack-nova | 16:46 | |
*** kylek3h has quit IRC | 16:46 | |
*** kylek3h has joined #openstack-nova | 16:46 | |
openstackgerrit | dane-fichter proposed openstack/nova: Add image signature verification https://review.openstack.org/189843 | 16:46 |
*** jlanoux has joined #openstack-nova | 16:46 | |
mriedem | ildikov: so with a microversion, we'd have something like the volume_api.check_attach validation in the REST API | 16:46 |
johnthetubaguy | mriedem: depends, what you wanting to do :) | 16:47 |
*** dedery_ has quit IRC | 16:47 | |
*** dedery has quit IRC | 16:47 | |
mriedem | johnthetubaguy: oh i just had a thing that i haven't gotten around to starting, but agree it's probably too late - it was a spec i revived from an operator from liberty that never posted any code | 16:47 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Auto converge as a default LM parameter https://review.openstack.org/266001 | 16:47 |
mriedem | my time is probably better spent reviewing non-priority bp's before 1/21 | 16:47 |
johnthetubaguy | mriedem: its more a statement that we have more code up for review right now than we can get merged before the deadline, so lets start focusing are efforts | 16:47 |
mriedem | yeah, +1 for blocking bp's with no code yet then | 16:48 |
mriedem | some people might be surprised by that, but they really shouldn't be | 16:48 |
johnthetubaguy | mriedem: honestly it sometimes makes code appear, and I just re-approve it for mitaka, but I didn't say that | 16:48 |
*** mgoddard has quit IRC | 16:48 | |
mriedem | #undo | 16:48 |
johnthetubaguy | yeah, depends if it sounds really useful and looks sane | 16:49 |
johnthetubaguy | its what we usually do, anyways | 16:49 |
markus_z | sfinucan: I'm out of office tomorrow, If you push it in the next 15 minutes I +1 it :) | 16:49 |
*** zenoway has quit IRC | 16:51 | |
ildikov | mriedem: I assume it will be fine in case we enable the feature in N as the prerequisites will be in Mitaka | 16:51 |
*** kmartin has joined #openstack-nova | 16:51 | |
mriedem | ildikov: yes, the prereqs being the bdm method calls that dansmith was working on | 16:51 |
ildikov | mriedem: we need the detach code and I think we would need to figure out passing the host_name to Cinder somehow | 16:52 |
ildikov | mriedem: the detach changes have to go in | 16:52 |
ildikov | mriedem: we need to pass the attachment_id to Cinder | 16:52 |
mriedem | in case newton api is multiattaching to mitaka computes i guess | 16:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'pci' conf options documentation https://review.openstack.org/243335 | 16:53 |
sfinucan | markus_z: Done, I think | 16:53 |
ildikov | mriedem: it's the same mixed environment problem | 16:53 |
markus_z | checking | 16:53 |
*** suro-patz has quit IRC | 16:53 | |
ildikov | mriedem: it's the prep patch: https://review.openstack.org/#/c/193134/70 | 16:53 |
mriedem | thomasem: you know we have an rc file in nova's tree that can be used to skip tests in the lxc job right? | 16:53 |
ildikov | mriedem: only the no harm changes | 16:54 |
*** vivekd has quit IRC | 16:54 | |
ildikov | mriedem: it would also be needed for Cinder backends as much as I know from hemna: https://review.openstack.org/#/c/256273/ | 16:55 |
thomasem | mriedem: I do. | 16:55 |
thomasem | mriedem: that's the one dimtruck is patching :) | 16:55 |
dimtruck | mriedem: 10 mins ... i'll have it up there | 16:55 |
ildikov | mriedem: not all but there is, I know that the migration is a question there | 16:55 |
dimtruck | sorry for the delay.. | 16:55 |
hemna | yough | 16:55 |
hemna | ildikov, https://review.openstack.org/#/c/266006/ that guy landed | 16:56 |
ildikov | hemna: I'm listing the patches to mriedem that need to go in for Mitaka to enable multiattach in Newton | 16:56 |
hemna | cinder can now accept both instance_uuid and hostname | 16:56 |
ildikov | hemna: I saw thanks, tests are fine now | 16:56 |
hemna | ok great :) | 16:56 |
ildikov | but I think it would be good to backport that change | 16:57 |
*** pumaranikar has joined #openstack-nova | 16:57 | |
*** salv-orlando has quit IRC | 16:58 | |
*** ihrachys has joined #openstack-nova | 16:58 | |
*** zakora has quit IRC | 16:58 | |
*** salv-orlando has joined #openstack-nova | 16:58 | |
*** chhavi has quit IRC | 16:58 | |
*** dslev has quit IRC | 16:58 | |
mriedem | backport which change? | 16:58 |
ildikov | the one that hemna linked above in Cinder | 16:59 |
markus_z | sfinucan: a last tiny nit, then it should be done | 16:59 |
mriedem | ildikov: why does cinder liberty need that? | 16:59 |
mriedem | if it's only to enable a thing for mitaka computes? | 16:59 |
*** mgoddard_ has quit IRC | 16:59 | |
mriedem | it's also an api change which makes backporting not fun | 17:00 |
markus_z | sfinucan: In that one I mean: https://review.openstack.org/#/c/253732/8 | 17:00 |
*** mgoddard has joined #openstack-nova | 17:00 | |
pkoniszewski | hi, someone who can help me with the API? Is extension name related to policy rule name or is there a way to use different name for policy? | 17:00 |
*** chhavi has joined #openstack-nova | 17:00 | |
ildikov | mriedem: Nova didn't pass the host_name before | 17:00 |
ildikov | mriedem: but for certain Cinder drivers that would be needed to track multiple attachments | 17:00 |
*** Sukhdev has quit IRC | 17:00 | |
mriedem | ildikov: sure, but nova in liberty doesn't support multiattach | 17:01 |
mriedem | so why does it matter? | 17:01 |
ildikov | as I understand we want to prepare Mitaka computes to be able to deal with multiattach | 17:01 |
*** gszasz has quit IRC | 17:01 | |
*** jlanoux has quit IRC | 17:01 | |
mriedem | yeah | 17:01 |
ildikov | I mean in a mixed env when we will have the support in Newton | 17:01 |
mriedem | and the cinder change is in mitaka | 17:01 |
*** ihrachys has quit IRC | 17:02 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise PCI options https://review.openstack.org/253732 | 17:02 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'pci' conf options documentation https://review.openstack.org/243335 | 17:02 |
sfinucan | markus_z: And done :) 1 other change also (dicts) | 17:02 |
ildikov | but if we merge now the Nova side of the change then the Liberty Cinder will have issues with Mitaka Nova AFAIU | 17:02 |
*** claudiub has quit IRC | 17:02 | |
*** matrohon has quit IRC | 17:02 | |
ildikov | mriedem: ^ | 17:02 |
mriedem | hmm | 17:03 |
*** ihrachys has joined #openstack-nova | 17:03 | |
markus_z | sfinucan: will fail. dict needs a colon | 17:03 |
markus_z | ;) | 17:03 |
mriedem | ildikov: i guess i assumed both cinder and nova would be mitaka | 17:03 |
mriedem | but they don't have to be | 17:03 |
mriedem | this is what's not fun about cross-project features.... | 17:03 |
hemna | mriedem, +1 | 17:03 |
*** salv-orlando has quit IRC | 17:03 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise PCI options https://review.openstack.org/253732 | 17:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'pci' conf options documentation https://review.openstack.org/243335 | 17:03 |
sfinucan | markus_z: grrrr | 17:04 |
*** salv-orlando has joined #openstack-nova | 17:04 | |
ildikov | mriedem: well, our discussions during the past week is all about that this is an ideal case that we will not have :( | 17:04 |
sfinucan | done v3 :) | 17:04 |
*** _diana_1 has joined #openstack-nova | 17:04 | |
mriedem | i think i'd be ok with saying nova doesn't support multiattach in the api until newton, and only with cinder>=mitaka | 17:04 |
ildikov | mriedem: but that backport in Cinder should not hurt I think from cross-project perspective | 17:04 |
mriedem | no.....but it's also unnecessary in my mind, and it's an api change | 17:04 |
mriedem | you could argue it's needed in cinder kilo too | 17:04 |
ildikov | yeah, but we have to prepare the Mitaka computes for proper detach and attach | 17:05 |
ildikov | to send all the info to Cinder that it needs | 17:05 |
ildikov | otherwise we will not have this feature in Newton either | 17:05 |
*** jwcroppe has quit IRC | 17:05 | |
mriedem | yes, and i'm saying, i think it's ok to say, in docs, that you need to have cinder>=mitaka for multiattach to work, | 17:05 |
mriedem | because that's when nova started supporting it in computes | 17:05 |
*** dslev has joined #openstack-nova | 17:06 | |
ildikov | but passing the host_name has nothing to do with multiattach on the first place | 17:06 |
mriedem | if the cinder team wants to backport that change to support newton nova talking to mitaka nova-compute talking to liberty cinder, then i guess that's up to the cinder team | 17:06 |
ildikov | that backport note was for the Cinder change | 17:06 |
mriedem | i know | 17:07 |
ildikov | my point here is only that i need the first patch in my chain to land for Mitaka and AFAIK the second would be needed too | 17:07 |
mriedem | but the cinder change is so https://review.openstack.org/#/c/256273/ in nova works, right? | 17:07 |
openstackgerrit | Wang Bo proposed openstack/nova: Fix indexing of dict.keys() in python3 https://review.openstack.org/267708 | 17:07 |
mriedem | and if https://review.openstack.org/#/c/256273/ is only in nova mitaka, then we're covered i think | 17:07 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Use TimeFixture from oslo_utils in functional tests https://review.openstack.org/267709 | 17:07 |
ildikov | mriedem: yeah, it works, the tests are pretty green now, the red ones are not my fault this time :) | 17:08 |
markus_z | sfinucan: FYI, I'm out of office tomorrow. I'll do a review day on Monday. | 17:08 |
markus_z | <= bottleneck | 17:08 |
mriedem | to summarize, i guess i really only care about nova here. if someone tries multiattach with a liberty cinder and things are not working and https://review.openstack.org/#/c/266006/ is the fix, then i guess they can pick that up | 17:08 |
*** jwcroppe has joined #openstack-nova | 17:09 | |
*** dslev has quit IRC | 17:09 | |
*** jwcroppe has quit IRC | 17:09 | |
mriedem | anyway, i have a lunch date so have to run for awhile | 17:09 |
*** mriedem is now known as mriedem_lunch | 17:09 | |
ildikov | mriedem: sure, I just answered to your question, but it's on hemna what will happen with that patch, no question about that | 17:09 |
ildikov | mriedem_lunch: I have to run too, be back later | 17:10 |
*** raildo is now known as raildo-afk | 17:12 | |
*** ctrath has quit IRC | 17:13 | |
*** paul-carlton2 has joined #openstack-nova | 17:13 | |
_diana_1 | markmc: Silly me. I already have that patch. Tests are failing for me on an up-to-date master which includes that merged patch. Thanks though. | 17:13 |
*** markus_z has quit IRC | 17:14 | |
hemna | well, if we want to backport it to liberty we can try | 17:16 |
hemna | that has to go through the backport process, approval | 17:16 |
hemna | and would need a bug associated with it | 17:17 |
hemna | which there isn't now | 17:17 |
ildikov | hemna: yeah, we have only the lvm driver bug | 17:17 |
hemna | which is only associated with the multiattach code that hasn't landed..... | 17:17 |
hemna | so.... | 17:17 |
hemna | chicken....egg.... | 17:17 |
*** Daisy has quit IRC | 17:18 | |
ildikov | hemna: we could call it proactivity too ;) | 17:19 |
ildikov | hemna: I need to run now, I'll be back later | 17:19 |
*** ildikov is now known as ildikov_afk | 17:19 | |
*** raildo-afk is now known as raildo | 17:20 | |
*** jlanoux has joined #openstack-nova | 17:20 | |
*** zenoway has joined #openstack-nova | 17:22 | |
openstackgerrit | Dan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id https://review.openstack.org/267169 | 17:23 |
*** tjones has joined #openstack-nova | 17:23 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/api directory https://review.openstack.org/258180 | 17:23 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (2) https://review.openstack.org/260587 | 17:23 |
*** dslevin has joined #openstack-nova | 17:23 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (1) https://review.openstack.org/260586 | 17:23 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (3) https://review.openstack.org/260588 | 17:23 |
*** garyk has quit IRC | 17:23 | |
*** klkumar has quit IRC | 17:24 | |
*** carey has joined #openstack-nova | 17:25 | |
*** garyk has joined #openstack-nova | 17:26 | |
*** apoorvad has joined #openstack-nova | 17:26 | |
*** zenoway has quit IRC | 17:26 | |
*** ctrath has joined #openstack-nova | 17:26 | |
openstackgerrit | Dimitry Ushakov proposed openstack/nova: (lxc) Updated regex to ignore failing tests https://review.openstack.org/267724 | 17:27 |
*** scheuran has quit IRC | 17:27 | |
*** nikhil_k has joined #openstack-nova | 17:27 | |
*** jistr has quit IRC | 17:29 | |
*** salv-orlando has quit IRC | 17:29 | |
*** nikhil has quit IRC | 17:29 | |
*** salv-orlando has joined #openstack-nova | 17:29 | |
*** carey has quit IRC | 17:30 | |
*** smatzek has quit IRC | 17:33 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused db parameter from scheduler.utils.set_vm_state_and_notify() https://review.openstack.org/267682 | 17:33 |
*** unicell has quit IRC | 17:34 | |
*** lpetrut1 has joined #openstack-nova | 17:35 | |
*** lpetrut has quit IRC | 17:36 | |
*** nic has joined #openstack-nova | 17:38 | |
*** lpetrut1 has quit IRC | 17:39 | |
*** tjones has quit IRC | 17:40 | |
*** ihrachys has quit IRC | 17:40 | |
*** sahid has quit IRC | 17:40 | |
*** sfinucan has quit IRC | 17:40 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix instance not destroyed after successful evacuation https://review.openstack.org/250101 | 17:40 |
*** e0ne has quit IRC | 17:40 | |
*** haomaiwang has joined #openstack-nova | 17:41 | |
*** tjones has joined #openstack-nova | 17:42 | |
*** tjones has quit IRC | 17:42 | |
*** haomaiwang has quit IRC | 17:44 | |
*** moshele has quit IRC | 17:44 | |
*** ihrachys has joined #openstack-nova | 17:45 | |
*** eil397 has joined #openstack-nova | 17:45 | |
*** chhavi has quit IRC | 17:47 | |
*** paul-carlton2 has quit IRC | 17:48 | |
*** cdent has quit IRC | 17:49 | |
*** tjones has joined #openstack-nova | 17:50 | |
*** burt has joined #openstack-nova | 17:54 | |
*** edtubill has quit IRC | 17:56 | |
*** edtubill has joined #openstack-nova | 17:57 | |
*** tonytan4ever has quit IRC | 17:57 | |
*** zenoway has joined #openstack-nova | 17:57 | |
openstackgerrit | Dina Belova proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 17:57 |
*** suro-patz has joined #openstack-nova | 17:58 | |
*** mriedem_lunch has quit IRC | 17:58 | |
*** paul-carlton2 has joined #openstack-nova | 18:00 | |
*** ndipanov has quit IRC | 18:00 | |
*** zenoway has quit IRC | 18:01 | |
*** unicell has joined #openstack-nova | 18:01 | |
*** daemontool has quit IRC | 18:01 | |
*** unicell has quit IRC | 18:01 | |
*** unicell has joined #openstack-nova | 18:01 | |
*** mriedem has joined #openstack-nova | 18:02 | |
mriedem | dansmith: let's bring it on home https://review.openstack.org/#/c/264817/ | 18:03 |
*** ssurana has joined #openstack-nova | 18:03 | |
*** ociuhandu has quit IRC | 18:03 | |
dansmith | got it | 18:03 |
*** derekh has quit IRC | 18:05 | |
*** ihrachys has quit IRC | 18:06 | |
*** fesp has joined #openstack-nova | 18:09 | |
*** fesp has quit IRC | 18:09 | |
*** ihrachys has joined #openstack-nova | 18:10 | |
*** nikhil_k is now known as nikhil | 18:11 | |
mriedem | dansmith: last comment on this one https://review.openstack.org/#/c/267169/5/nova/objects/block_device.py | 18:12 |
mriedem | which is a redo comment from the last ps | 18:12 |
*** changbl has joined #openstack-nova | 18:13 | |
mriedem | nic: you have a merge conflict on this now https://review.openstack.org/#/c/205282/ | 18:13 |
mriedem | nic: let me go through your replies to my last review first | 18:13 |
mriedem | i see notmorgan has input on liking 166 LOC untestable methods :) | 18:14 |
notmorgan | mriedem: i dislike splitting a method out into something crazy complex too | 18:16 |
nic | mriedem: yes, I saw that and have them resolved | 18:16 |
notmorgan | mriedem: i am also not nova core so... | 18:16 |
notmorgan | mriedem: ;) | 18:16 |
nic | I'm just verifying that the base unit tests still work before bugging Gerrit with it | 18:16 |
mriedem | crazy complex? | 18:17 |
mriedem | notmorgan: there are just several several-hundred+ LOC methods in the libvirt driver, and i kind of hate seeing those get bigger and gorpier | 18:17 |
mriedem | hell we kicked the vmware driver in the nuts for 2 milestones for that reason | 18:17 |
mriedem | nic: to be clear, i'm not saying you have to split that code out into a separate function, i'm just explaining why i was raising it | 18:18 |
nic | It's only long because of PEP8 line-wrapping constraints; it really only does like 5 things | 18:18 |
*** vishwanathj is now known as vishwanathj_ | 18:18 | |
* notmorgan kindof wishes we'd increate line-length to 120char | 18:18 | |
mriedem | still, to test that case, you have to mock out the 100+ LOC above it | 18:18 |
mriedem | which blows and is not really unity testing | 18:18 |
mriedem | which is to say, it's hard to tell when we actually have test coverage on something | 18:19 |
mriedem | like has always been an issue in the vmware driver code, which is why we kicked them in said nuts to break it up | 18:19 |
mriedem | </rant> | 18:19 |
*** tonytan4ever has joined #openstack-nova | 18:20 | |
*** edtubill has quit IRC | 18:21 | |
*** ihrachys has quit IRC | 18:23 | |
*** whenry has quit IRC | 18:24 | |
dansmith | mriedem: oh sorry I forgot to commit my comment | 18:25 |
dansmith | mriedem: I said: I don't normally write (or ask for) tests that verify that some log statement was run | 18:25 |
dansmith | mriedem: we have a couple examples | 18:25 |
dansmith | mriedem: if you think it's important I can do it, but I don't really think it is | 18:25 |
mriedem | dansmith: not really so much for the log statement, but just the case that you get back more than 1 bdm | 18:27 |
mriedem | right now the tests for that method all return a list with 1 entry | 18:27 |
*** danpb has quit IRC | 18:27 | |
dansmith | mriedem: you mean just a test that verifies it gives you back your first item? | 18:28 |
mriedem | yeah | 18:28 |
dansmith | mriedem: you commented on the if statement, which only controls the log... so I was confused | 18:28 |
dansmith | sure I can do that | 18:28 |
mriedem | i assume you can read my thoughts by now | 18:28 |
*** atuvenie has joined #openstack-nova | 18:28 | |
dansmith | mriedem: I didn't mean to hit you baby | 18:30 |
dansmith | mriedem: if I put something bogus as a second item in a returned set that would explode if we tried to process it, it'll ensure we're only pulling the first | 18:30 |
dansmith | so I'll do that | 18:30 |
dansmith | thusly: | 18:31 |
*** annegentle has joined #openstack-nova | 18:31 | |
openstackgerrit | Dan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id https://review.openstack.org/267169 | 18:31 |
mriedem | slick | 18:31 |
*** irenab has quit IRC | 18:32 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Adapt the code to the new get_by_volume BDM functions https://review.openstack.org/267464 | 18:32 |
*** jaosorior has quit IRC | 18:33 | |
*** otter768 has joined #openstack-nova | 18:33 | |
*** irenab has joined #openstack-nova | 18:33 | |
*** ssurana has quit IRC | 18:34 | |
openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: Fix/implement revert-resize for RBD-backed images https://review.openstack.org/187395 | 18:35 |
openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available https://review.openstack.org/205282 | 18:35 |
*** changbl has quit IRC | 18:35 | |
nic | mriedem: ta-da! | 18:35 |
*** paul-carlton2 has quit IRC | 18:35 | |
mriedem | still reviewing replies to ps24 | 18:35 |
*** irenab has quit IRC | 18:35 | |
mriedem | oh there is a dependent change isn't there... | 18:36 |
nic | There is now | 18:36 |
*** moshele has joined #openstack-nova | 18:36 | |
nic | I was hoping it would have merged on its own long before now, because there is overlapping functionality | 18:37 |
*** femnad has quit IRC | 18:37 | |
*** irenab has joined #openstack-nova | 18:37 | |
nic | And the bit-rot over the past 1+ years made them diverge a bit | 18:37 |
*** otter768 has quit IRC | 18:37 | |
nic | So now they're explicitly dependent, and harmonized | 18:38 |
*** jichen has joined #openstack-nova | 18:38 | |
*** jlanoux has quit IRC | 18:38 | |
*** rdopiera has quit IRC | 18:38 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Remove DictCompat from FixedIP https://review.openstack.org/265951 | 18:40 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add tests for floating_ip private functions https://review.openstack.org/267768 | 18:40 |
*** tjones has quit IRC | 18:40 | |
openstackgerrit | dane-fichter proposed openstack/nova: Add image signature verification https://review.openstack.org/189843 | 18:41 |
*** harlowja_at_home has joined #openstack-nova | 18:42 | |
*** yassine_ has quit IRC | 18:42 | |
*** ajayaa has quit IRC | 18:42 | |
mriedem | nic: my replies are posted in ps24 now https://review.openstack.org/#/c/205282/24 | 18:42 |
mriedem | i'll have to see what's changed since then | 18:42 |
*** rlrossit has quit IRC | 18:43 | |
*** tjones has joined #openstack-nova | 18:43 | |
*** rlrossit has joined #openstack-nova | 18:43 | |
*** rlrossit_ has joined #openstack-nova | 18:46 | |
*** rlrossit has quit IRC | 18:47 | |
*** rlrossit has joined #openstack-nova | 18:47 | |
*** e0ne has joined #openstack-nova | 18:48 | |
*** aix has quit IRC | 18:49 | |
rlrossit | doffm: https://xkcd.com/1172/ | 18:49 |
*** zenoway has joined #openstack-nova | 18:50 | |
dansmith | tojuvone: I think that cinder failure means it's not your problem | 18:50 |
*** vilobhmm11 has joined #openstack-nova | 18:50 | |
tojuvone | dansmith: Yes, I also do not understand why it would be. Also do not see relation to change after which is coming | 18:51 |
*** rlrossit_ has quit IRC | 18:51 | |
dansmith | yeah, I'm not sure where to dig in, | 18:51 |
dansmith | because I don't see any actual fails | 18:51 |
tojuvone | dansmith: still I looked 24h back the failed gate-grenade-dsvm-multinode and no similar | 18:52 |
*** Marga_ has joined #openstack-nova | 18:52 | |
dansmith | sdague: where do I look to see why this failed? http://logs.openstack.org/62/267062/3/check/gate-grenade-dsvm-multinode/27b0239/logs/grenade.sh.txt.gz#_2016-01-14_07_46_55_346 | 18:52 |
*** SourabhP has joined #openstack-nova | 18:52 | |
tojuvone | dansmith: but there is now 5 times the same failure reproduced on 241562 or 267062 | 18:52 |
dansmith | tojuvone: well, hmm, that's a bad sign | 18:53 |
tojuvone | dansmith: so that makes me wonder and also as it has the jenkins -1 | 18:53 |
nic | mriedem: thanks, expect another revision soon | 18:53 |
openstackgerrit | Andrey Pavlov proposed openstack/nova: remove EC2 legacy code https://review.openstack.org/266425 | 18:55 |
rlrossit | dims: if you have a chance, could you take a look at https://review.openstack.org/#/c/266960/2 ? If I'm on the right track, I'll make the same changes in neutron and cinder (at least) for it. | 18:55 |
tojuvone | dansmith: The fact it comes in both would indicate it could be because 267062 | 18:55 |
*** smatzek has joined #openstack-nova | 18:55 | |
dims | rlrossit : on it | 18:55 |
dansmith | tojuvone: yeah, but I would expect to see some fails in the n-api log or something | 18:55 |
mriedem | nic: hold up | 18:55 |
mriedem | nic: i'm going through your latest | 18:55 |
tojuvone | dansmith: Yes, still makes no sense | 18:55 |
dansmith | tojuvone: mriedem might know if this is known | 18:56 |
tojuvone | mdiedem: here would be one: http://logs.openstack.org/62/241562/17/check/gate-grenade-dsvm-multinode/c4304a6/ | 18:57 |
dims | rlrossit : i'd recommend cutting a fake ceilometer review with a Depends-On to this Nova review to see if it works | 18:57 |
mriedem | nic: ok, comments posted on latest change | 18:57 |
dims | rlrossit : looks good! | 18:57 |
tojuvone | mriedem: :) now got right | 18:57 |
rlrossit | dims: cool! I'll get that ceilometer review up as soon as I can | 18:58 |
dims | rlrossit : ceilometer is the only one that has tests that use the actual notifications generated | 18:58 |
* rlrossit wonders if nova should have functional tests for that | 18:58 | |
*** ctrath has quit IRC | 18:58 | |
mriedem | tojuvone: this? http://logs.openstack.org/62/241562/17/check/gate-grenade-dsvm-multinode/c4304a6/logs/grenade.sh.txt.gz#_2016-01-13_22_57_38_661 | 18:58 |
mriedem | rlrossit: probably | 18:58 |
rlrossit | I think some of gibi's changes for versioned notifications added some? Or maybe I'm just imagining it | 18:59 |
mriedem | there are unit tests that use the fake_notifier and asserts those | 18:59 |
*** PaulMurray is now known as ptm_away | 18:59 | |
mriedem | see fake_notifier usage in nova.tests.unit.compute.test_compute | 18:59 |
tojuvone | mriedem: Yes, it points there and have not seen same in other console.logs as error code | 18:59 |
*** ihrachys has joined #openstack-nova | 18:59 | |
tojuvone | mdiedem: I mean from other grenade failed cases in 24h. | 18:59 |
mriedem | tojuvone: so the actual timeout for the server delete is here http://logs.openstack.org/62/241562/17/check/gate-grenade-dsvm-multinode/c4304a6/logs/grenade.sh.txt.gz#_2016-01-13_22_57_06_508 | 19:00 |
rlrossit | dims: is there documentation in oslo.messaging for how to config the notification transport vs. the regular transport? | 19:00 |
tojuvone | mriedem: yes | 19:00 |
mriedem | tojuvone: have you checked the n-cpu logs for that? | 19:00 |
mriedem | tojuvone: this looks not good http://logs.openstack.org/62/241562/17/check/gate-grenade-dsvm-multinode/c4304a6/logs/subnode-2/old/screen-n-cpu.txt.gz#_2016-01-13_22_57_08_453 | 19:02 |
mriedem | rlrossit: dansmith: ^ remind you of something? | 19:02 |
dansmith | oh dangit | 19:02 |
dansmith | I always forget about the subnode directory | 19:02 |
*** angdraug has quit IRC | 19:02 | |
rlrossit | mriedem: wow throwing back to my first days in nova | 19:02 |
dims | rlrossit : first thing to check is if new config options are not set if it still works. it should fall back to the same config option used for rpc. | 19:03 |
rlrossit | dims: agreed. I was hoping it would do that | 19:03 |
rlrossit | or else we have ourselves an UpgradeImpact :( | 19:03 |
*** ihrachys has quit IRC | 19:03 | |
dims | rlrossit : once we get past that then we can add a "[oslo_messaging_notifications]" section with transport_url in say a devstack patch | 19:04 |
dims | rlrossit : yep! | 19:04 |
dansmith | tojuvone: you forgot to call super in obj_make_compatible() :) | 19:04 |
dansmith | tojuvone: I missed it | 19:04 |
tojuvone | mriedem: yes | 19:04 |
mriedem | jdurgin: jbernard: have you guys reviewed this in awhile? https://review.openstack.org/#/c/187395/ | 19:04 |
jbernard | mriedem: no, it's on my list though | 19:05 |
tojuvone | dansmith: ok, might that cause problem. | 19:05 |
dansmith | tojuvone: yeah it means the version never gets set, which means it keeps kicking it back for backporting :) | 19:06 |
*** annegentle has quit IRC | 19:06 | |
*** annegentle has joined #openstack-nova | 19:06 | |
*** jaypipes has quit IRC | 19:07 | |
tojuvone | dansmith: Actually figured if something in code would cause this, it would be that function as only real change | 19:07 |
*** tjones has quit IRC | 19:08 | |
*** jwcroppe has joined #openstack-nova | 19:08 | |
dansmith | yeah | 19:10 |
*** tonytan4ever has quit IRC | 19:11 | |
*** omnipresent has joined #openstack-nova | 19:12 | |
tojuvone | dansmith, mriedem: Thanks :) | 19:12 |
*** tonytan4ever has joined #openstack-nova | 19:12 | |
dansmith | yep | 19:12 |
*** jwcroppe has quit IRC | 19:13 | |
*** ZZelle_ has joined #openstack-nova | 19:14 | |
*** zenoway has quit IRC | 19:15 | |
*** ihrachys has joined #openstack-nova | 19:16 | |
*** tjones has joined #openstack-nova | 19:16 | |
*** ssurana has joined #openstack-nova | 19:17 | |
*** fawadkhaliq has quit IRC | 19:17 | |
*** fawadkhaliq has joined #openstack-nova | 19:17 | |
*** Daisy has joined #openstack-nova | 19:18 | |
*** fawadkhaliq has quit IRC | 19:19 | |
tojuvone | and yet the light year with my machine for testing that I do not break anything (else). | 19:20 |
*** yamahata has quit IRC | 19:21 | |
sdague | dansmith: probably n-cpu new | 19:22 |
*** claudiub has joined #openstack-nova | 19:23 | |
*** mvensky has joined #openstack-nova | 19:23 | |
dansmith | sdague: n-cpu old actually.. I always forget to look for that nested directory | 19:23 |
*** ihrachys has quit IRC | 19:23 | |
sdague | it's the destroy, that should be on the new side | 19:23 |
sdague | I mean, a failed create would probably explain why the destroy fails | 19:24 |
sdague | although, that doesn't actually make sense. We've sshed into that guest by that time | 19:25 |
*** carey has joined #openstack-nova | 19:26 | |
*** dedery has joined #openstack-nova | 19:28 | |
*** dedery has quit IRC | 19:28 | |
*** dedery_ has joined #openstack-nova | 19:28 | |
*** ssurana has quit IRC | 19:28 | |
*** suro-patz has quit IRC | 19:30 | |
*** haomaiwang has joined #openstack-nova | 19:30 | |
*** carey has quit IRC | 19:31 | |
*** gangil has joined #openstack-nova | 19:31 | |
*** gangil has quit IRC | 19:31 | |
*** gangil has joined #openstack-nova | 19:31 | |
*** cdent has joined #openstack-nova | 19:33 | |
*** vilobhmm11 has quit IRC | 19:33 | |
*** ociuhandu has joined #openstack-nova | 19:33 | |
*** vilobhmm11 has joined #openstack-nova | 19:33 | |
dedery_ | mriedem: ping | 19:34 |
*** vilobhmm11 has quit IRC | 19:34 | |
mriedem | pong | 19:34 |
*** suro-patz has joined #openstack-nova | 19:34 | |
*** vilobhmm11 has joined #openstack-nova | 19:34 | |
*** haomaiwang has quit IRC | 19:34 | |
*** vilobhmm11 has quit IRC | 19:35 | |
*** vilobhmm11 has joined #openstack-nova | 19:35 | |
dedery_ | mriedem: hi :), looking at https://review.openstack.org/#/c/252565/8/nova/tests/unit/network/test_neutronv2.py and trying to add the mock for the log it seems that it's going to add some bad code on bad code. | 19:35 |
*** ihrachys has joined #openstack-nova | 19:36 | |
*** lpetrut has joined #openstack-nova | 19:36 | |
dedery_ | If you open the full code you'd see that _fake_get_instance_nw_info_helper is mimicking the _gather_port_ids_and_networks logic (see the comment by john about the cut and paste of the real logic) | 19:36 |
mriedem | dedery_: i'd recommend that the new test is not put in TestNeutronV2 | 19:37 |
mriedem | b/c that uses all of that crazy crap moxed setup stuff in the base class | 19:37 |
mriedem | put the new test in TestNeutronv2WithMock | 19:38 |
mriedem | everything in TestNeutronV2 is kind of aweful b/c of the mega setup | 19:38 |
mriedem | *awful | 19:39 |
*** ctrath has joined #openstack-nova | 19:39 | |
*** pratikma_ has quit IRC | 19:39 | |
dedery_ | agree. ok. mv to *WithMock. 10x | 19:39 |
*** annegent_ has joined #openstack-nova | 19:40 | |
*** ccarmack has quit IRC | 19:42 | |
dedery_ | mriedem: do you think that I should leave the copied logic in L.800-809? | 19:42 |
openstackgerrit | Tomi Juvonen proposed openstack/nova: Add object and database support for host_status API https://review.openstack.org/267062 | 19:43 |
*** tonytan4ever has quit IRC | 19:43 | |
*** annegentle has quit IRC | 19:43 | |
*** diogogmt has quit IRC | 19:43 | |
mriedem | dedery_: does it need to be in there for the test to pass? | 19:43 |
mriedem | or only for your new test? | 19:43 |
*** SourabhP has quit IRC | 19:44 | |
dedery_ | no, only for my new test. | 19:44 |
mriedem | remove it | 19:44 |
mriedem | """Helper function to test get_instance_nw_info. | 19:44 |
*** Daisy has quit IRC | 19:44 | |
mriedem | """Helper function to rewrite the actual code and not test it, you're welcome""" | 19:44 |
dedery_ | yeh, it's bad... | 19:45 |
mriedem | dedery_: just write a new test with mock in TestNeutronV2WithMock | 19:45 |
dedery_ | k | 19:45 |
*** Sukhdev has joined #openstack-nova | 19:45 | |
mriedem | the other stuff should be burned | 19:45 |
mriedem | but for some reason dansmith refuses to let it go | 19:45 |
openstackgerrit | sean mooney proposed openstack/os-vif: reorder tox envlist to run python 3.4 before 2.7 https://review.openstack.org/267791 | 19:45 |
*** pratikmallya has joined #openstack-nova | 19:46 | |
*** SourabhP has joined #openstack-nova | 19:49 | |
*** atuvenie has quit IRC | 19:50 | |
*** ihrachys has quit IRC | 19:50 | |
*** ihrachys has joined #openstack-nova | 19:50 | |
*** yamahata has joined #openstack-nova | 19:50 | |
*** nelsnelson has quit IRC | 19:51 | |
*** rlrossit has quit IRC | 19:51 | |
*** nelsnelson has joined #openstack-nova | 19:51 | |
openstackgerrit | sean mooney proposed openstack/os-vif: remove python 2.6 trove classifier https://review.openstack.org/267792 | 19:52 |
*** diogogmt has joined #openstack-nova | 19:53 | |
*** ijw has quit IRC | 19:54 | |
*** tjones has quit IRC | 19:54 | |
*** lucasagomes is now known as lucas-dinner | 19:55 | |
*** tjones has joined #openstack-nova | 19:55 | |
*** tjones has quit IRC | 19:55 | |
openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available https://review.openstack.org/205282 | 19:55 |
*** tjones has joined #openstack-nova | 19:55 | |
*** rlrossit has joined #openstack-nova | 19:56 | |
*** rfolco has quit IRC | 19:56 | |
*** eil397 has quit IRC | 19:58 | |
*** yamahata has quit IRC | 19:58 | |
*** yamahata has joined #openstack-nova | 19:59 | |
*** gangil has quit IRC | 19:59 | |
*** vilobhmm11 has quit IRC | 20:00 | |
*** vilobhmm11 has joined #openstack-nova | 20:00 | |
*** ctrath has quit IRC | 20:02 | |
*** ctrath has joined #openstack-nova | 20:03 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 20:03 |
mriedem | BobBall: citrix xenserver ci is having some mirror issues http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/69/267169/6/2878/run_tests.log | 20:03 |
openstackgerrit | jichenjc proposed openstack/nova: WIP:remove OS-EXT-IPS and OS-EXT-IPS-MAC extension https://review.openstack.org/266533 | 20:03 |
*** ccarmack has joined #openstack-nova | 20:04 | |
*** tjones has quit IRC | 20:05 | |
*** gangil has joined #openstack-nova | 20:05 | |
*** gangil has joined #openstack-nova | 20:05 | |
*** pratikmallya has quit IRC | 20:05 | |
*** artom_ has quit IRC | 20:06 | |
openstackgerrit | Andrey Pavlov proposed openstack/nova: remove EC2 legacy code https://review.openstack.org/266425 | 20:07 |
*** ihrachys has quit IRC | 20:08 | |
*** ihrachys has joined #openstack-nova | 20:08 | |
*** armax has quit IRC | 20:09 | |
*** armax has joined #openstack-nova | 20:09 | |
*** jwcroppe has joined #openstack-nova | 20:09 | |
*** josecastroleon has quit IRC | 20:10 | |
*** josecastroleon has joined #openstack-nova | 20:12 | |
*** ctrath has quit IRC | 20:16 | |
*** eil397 has joined #openstack-nova | 20:17 | |
*** ctrath has joined #openstack-nova | 20:17 | |
*** ctrath has quit IRC | 20:17 | |
*** penick has joined #openstack-nova | 20:18 | |
*** Marga_ has quit IRC | 20:18 | |
*** Marga_ has joined #openstack-nova | 20:18 | |
*** eil397 has quit IRC | 20:19 | |
*** irenab has quit IRC | 20:19 | |
*** eil397 has joined #openstack-nova | 20:19 | |
*** jwcroppe has quit IRC | 20:20 | |
*** suro-patz has quit IRC | 20:22 | |
*** irenab has joined #openstack-nova | 20:22 | |
*** penick has quit IRC | 20:22 | |
*** vilobhmm11 has quit IRC | 20:23 | |
*** vilobhmm11 has joined #openstack-nova | 20:23 | |
*** vilobhmm11 has quit IRC | 20:23 | |
*** vilobhmm11 has joined #openstack-nova | 20:24 | |
*** vilobhmm11 has quit IRC | 20:24 | |
mriedem | stable cores, need this in before we cut the 12.0.1 release | 20:24 |
mriedem | https://review.openstack.org/#/c/267178/ | 20:24 |
mriedem | the dependent change is in the gate | 20:24 |
mriedem | dansmith: sdague: mikal: claudiub: ^ | 20:24 |
mriedem | mtreinish: ^ | 20:24 |
bauzas | mriedem: we're all good with the other changes, right? | 20:25 |
sdague | mriedem: +@ | 20:25 |
sdague | +2 | 20:25 |
mriedem | bauzas: yeah | 20:25 |
mriedem | just waiting to merge | 20:25 |
* bauzas litterally had no time to look thru | 20:25 | |
bauzas | okay | 20:25 |
mriedem | i went through the git log today | 20:25 |
*** vilobhmm11 has joined #openstack-nova | 20:25 | |
*** vilobhmm11 has quit IRC | 20:26 | |
*** vilobhmm11 has joined #openstack-nova | 20:26 | |
dansmith | +W | 20:26 |
bauzas | mriedem: just FYI, I prefer to update preludes separately given that http://docs-draft.openstack.org/78/267178/1/check/gate-nova-releasenotes/e7bdcb0//releasenotes/build/html/unreleased.html | 20:28 |
bauzas | mriedem: but it's okay for that one | 20:28 |
mriedem | update preludes separately? | 20:28 |
mriedem | you mean 1 release note per bug? | 20:28 |
bauzas | the main problem with preludes is that all the phrases are mixed in the same section, why it's good to provide the prelude by like the last patch as a summary | 20:29 |
mriedem | to avoid the duplication | 20:29 |
mriedem | yeah, that's why i phrased it that way | 20:29 |
bauzas | mriedem: here we're fine because it's for a point release | 20:29 |
bauzas | and it will be very probably the last change before tagging it | 20:29 |
mriedem | at the end of mitaka, i think we'd be hard pressed to come up with a prelude summary that doesn't miss something | 20:30 |
bauzas | exactly | 20:30 |
bauzas | hence me not okay if anyone providing a prelude section in a relnote | 20:30 |
mriedem | well, i think it depends on what it is | 20:30 |
bauzas | again, here it's okay | 20:30 |
bauzas | http://docs.openstack.org/developer/nova/code-review.html#when-a-release-note-is-needed | 20:31 |
bauzas | "Don’t use them unless you know exactly what you are doing." | 20:31 |
bauzas | :p | 20:31 |
mriedem | yeah i know | 20:31 |
mriedem | we're on the same team here bauzas! | 20:31 |
*** unicell1 has joined #openstack-nova | 20:31 | |
bauzas | even with a bad english phrasing :p | 20:31 |
*** vilobhmm11 has quit IRC | 20:32 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: OREST API changes for user settable server description https://review.openstack.org/254950 | 20:32 |
bauzas | mriedem: yeah totally in the same line, just trying to explain why I provided a gerrit comment ( just to make sure other people understand why *not* providing preludes) | 20:32 |
*** unicell has quit IRC | 20:32 | |
*** svenno has quit IRC | 20:32 | |
mriedem | bauzas: btw, unrelated, i've started reading an 860 page book on napolean | 20:33 |
bauzas | meh | 20:33 |
mriedem | wah! | 20:33 |
bauzas | I'm probably not a good French guy because I dislike him :) | 20:34 |
mriedem | i'll let you know how it turns out in a year when i finish it | 20:34 |
*** otter768 has joined #openstack-nova | 20:34 | |
bauzas | but sure, you'll see | 20:34 |
openstackgerrit | Chuck Carmack proposed openstack/nova: REST API changes for user settable server description https://review.openstack.org/254950 | 20:34 |
*** vilobhmm11 has joined #openstack-nova | 20:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/266160 | 20:35 |
*** annegent_ has quit IRC | 20:36 | |
*** matrohon has joined #openstack-nova | 20:37 | |
*** ihrachys has quit IRC | 20:37 | |
*** toure has quit IRC | 20:38 | |
*** penick has joined #openstack-nova | 20:38 | |
*** otter768 has quit IRC | 20:39 | |
*** rlrossit has quit IRC | 20:41 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Adapt the code to the new get_by_volume BDM functions https://review.openstack.org/267464 | 20:41 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Fix undetected races when getting BDMs by volume id https://review.openstack.org/267169 | 20:41 |
*** cdent has quit IRC | 20:42 | |
*** Daisy has joined #openstack-nova | 20:42 | |
*** mvensky has quit IRC | 20:42 | |
*** mvensky_ has joined #openstack-nova | 20:42 | |
openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add test coverage to functional api tests _compare_result method https://review.openstack.org/263440 | 20:43 |
*** tonytan4ever has joined #openstack-nova | 20:44 | |
openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available https://review.openstack.org/205282 | 20:45 |
*** dkliban has joined #openstack-nova | 20:45 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: REST API changes for user settable server description https://review.openstack.org/254950 | 20:46 |
mriedem | interesting re: multiattach https://review.openstack.org/#/c/110319/ | 20:46 |
*** rlrossit_ has joined #openstack-nova | 20:47 | |
*** ctrath has joined #openstack-nova | 20:47 | |
sdague | ctrl-s fake ... rinse... repeat | 20:48 |
*** ihrachys has joined #openstack-nova | 20:52 | |
*** Sukhdev has quit IRC | 20:55 | |
*** rlrossit_ has quit IRC | 21:00 | |
hemna | nice | 21:01 |
*** rlrossit has joined #openstack-nova | 21:03 | |
*** ssurana has joined #openstack-nova | 21:03 | |
*** Daisy has quit IRC | 21:03 | |
*** pratikmallya has joined #openstack-nova | 21:06 | |
*** pratikmallya has quit IRC | 21:07 | |
*** pratikmallya has joined #openstack-nova | 21:08 | |
*** ssurana has quit IRC | 21:08 | |
*** jwang_ has quit IRC | 21:08 | |
openstackgerrit | Dimitry Ushakov proposed openstack/nova: (lxc) Updated regex to ignore failing tests https://review.openstack.org/267724 | 21:08 |
*** raildo is now known as raildo-afk | 21:09 | |
sdague | oh, neat, there are actually a bunch of 404 tests that are 404ing for the wrong reason.... | 21:09 |
*** pratikma_ has joined #openstack-nova | 21:09 | |
*** ankita has joined #openstack-nova | 21:11 | |
ankita | Hi, Are scheduler.run_instance.* events sent in nova kilo ? Has the queue changed ? | 21:11 |
*** jwang has joined #openstack-nova | 21:12 | |
*** smatzek has quit IRC | 21:12 | |
*** gangil has quit IRC | 21:12 | |
*** pratikmallya has quit IRC | 21:13 | |
*** annegentle has joined #openstack-nova | 21:15 | |
*** apoorvad has quit IRC | 21:17 | |
*** jwcroppe has joined #openstack-nova | 21:17 | |
openstackgerrit | Mark Doffman proposed openstack/nova: Make os-instance-action read deleted instances. https://review.openstack.org/253087 | 21:20 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Remove dead code from reserve_block_device_name rpcapi https://review.openstack.org/267822 | 21:25 |
*** ihrachys has quit IRC | 21:25 | |
*** ihrachys has joined #openstack-nova | 21:26 | |
*** changbl has joined #openstack-nova | 21:27 | |
*** carey has joined #openstack-nova | 21:27 | |
*** gangil has joined #openstack-nova | 21:27 | |
*** gangil has joined #openstack-nova | 21:27 | |
*** diogogmt has quit IRC | 21:27 | |
*** harlowja has quit IRC | 21:27 | |
*** aix has joined #openstack-nova | 21:28 | |
openstackgerrit | dane-fichter proposed openstack/nova: Add image signature verification https://review.openstack.org/189843 | 21:28 |
*** StevenK has quit IRC | 21:30 | |
*** ssurana has joined #openstack-nova | 21:30 | |
*** jwcroppe has quit IRC | 21:31 | |
*** StevenK has joined #openstack-nova | 21:31 | |
*** vilobhmm11 has quit IRC | 21:31 | |
*** carey has quit IRC | 21:32 | |
*** vilobhmm11 has joined #openstack-nova | 21:32 | |
*** aysyd has quit IRC | 21:32 | |
*** vilobhmm11 has quit IRC | 21:32 | |
*** akshai has quit IRC | 21:32 | |
*** vilobhmm11 has joined #openstack-nova | 21:32 | |
*** gjayavelu has joined #openstack-nova | 21:33 | |
*** irenab has quit IRC | 21:33 | |
*** irenab has joined #openstack-nova | 21:34 | |
*** ssurana has quit IRC | 21:35 | |
*** jichen has quit IRC | 21:35 | |
*** irenab has quit IRC | 21:36 | |
nic | mriedem: I *think* the current patch set for the RBD stuffs addresses everything you were concerned about | 21:36 |
*** ankita_w_ has joined #openstack-nova | 21:36 | |
*** akshai has joined #openstack-nova | 21:37 | |
mriedem | nic: yeah, will probably get back to that tomorrow. i haven't reviewed the tests or test coverage yet either. | 21:37 |
mriedem | nic: and i'll probably put more time into the dependent change first | 21:37 |
*** pratikma_ has quit IRC | 21:37 | |
*** irenab has joined #openstack-nova | 21:38 | |
nic | Careful with it; it's an antique… :-P | 21:38 |
mriedem | sdague: user_id and project_id should be uuid right? | 21:39 |
openstackgerrit | Mark Doffman proposed openstack/nova: Move logging outside of LibvirtConfigObject.to_xml https://review.openstack.org/224216 | 21:39 |
mriedem | dansmith: was someone working on converting the instance action object fields for user_id and project_id to be uuid fields rather than strings? | 21:40 |
*** irenab has quit IRC | 21:40 | |
mriedem | i think the only issue there is all of the test cleanup that is required | 21:40 |
*** shakamunyi has quit IRC | 21:40 | |
*** mdrabe_ has joined #openstack-nova | 21:40 | |
dansmith | mriedem: well, migi is working on fixing a bunch of tests so we can do some uuid cleanups yeah | 21:40 |
*** dkliban has left #openstack-nova | 21:40 | |
*** suro-patz has joined #openstack-nova | 21:41 | |
alaski | I don't think project_id can be converted to uuid | 21:41 |
alaski | for the same reason that the api can't assume a uuid | 21:41 |
*** diogogmt has joined #openstack-nova | 21:42 | |
openstackgerrit | Andrew Laski proposed openstack/nova: WIP Populate instance_mappings during boot. https://review.openstack.org/263925 | 21:42 |
openstackgerrit | Andrew Laski proposed openstack/nova: WIP Map instances to cell0 on failed schedule https://review.openstack.org/267827 | 21:42 |
openstackgerrit | Andrew Laski proposed openstack/nova: WIP Create instance mapping when instance is scheduled https://review.openstack.org/267828 | 21:42 |
*** eil397 has quit IRC | 21:42 | |
*** irenab has joined #openstack-nova | 21:42 | |
*** dims has quit IRC | 21:42 | |
*** dims_ has joined #openstack-nova | 21:42 | |
alaski | doffm: https://review.openstack.org/267827 shows the usage of cell0 I was thinking, just needs to be built out :) | 21:42 |
alaski | melwitt: https://review.openstack.org/267828 is what I was thinking for using the first created cell | 21:43 |
*** apoorvad has joined #openstack-nova | 21:43 | |
*** mdrabe has quit IRC | 21:44 | |
*** thumpba has quit IRC | 21:44 | |
*** thumpba has joined #openstack-nova | 21:45 | |
doffm | alaski: Thanks. Will take a look. | 21:46 |
*** harlowja_at_home has quit IRC | 21:47 | |
dansmith | man, jenkins is busy these days | 21:47 |
*** vilobhmm11 has quit IRC | 21:48 | |
*** thumpba has quit IRC | 21:49 | |
*** jamielennox|away is now known as jamielennox | 21:49 | |
*** vilobhmm11 has joined #openstack-nova | 21:50 | |
*** vilobhmm11 has quit IRC | 21:51 | |
*** vilobhmm11 has joined #openstack-nova | 21:51 | |
*** mdrabe__ has joined #openstack-nova | 21:51 | |
*** cdelatte has quit IRC | 21:52 | |
*** mdrabe_ has quit IRC | 21:55 | |
*** armax has quit IRC | 21:55 | |
*** Sukhdev has joined #openstack-nova | 21:55 | |
doffm | alaski: Thanks, looks good. I suppose that if we were to do what was discussed the other day and make cell0 just a normal cell used for dumping purposes then the cell0 id would be configurable. I'll leave it for now though as a special 000000 id. | 22:00 |
*** thorst has quit IRC | 22:01 | |
*** thumpba has joined #openstack-nova | 22:01 | |
*** Daisy has joined #openstack-nova | 22:01 | |
alaski | doffm: yeah. I'm still in favor of it being a special cell, which means just a db and a cell_mapping. but if we co-opted another cell we would just need some way to know which one | 22:02 |
*** thumpba has quit IRC | 22:02 | |
*** vilobhmm11 has quit IRC | 22:03 | |
melwitt | alaski: cool, thanks | 22:05 |
*** vilobhmm11 has joined #openstack-nova | 22:05 | |
*** vilobhmm11 has quit IRC | 22:05 | |
mriedem | alaski: ok, i was noting in https://review.openstack.org/#/c/253087/ for the api samples that project_id and user_id should be uuids, but i guess they don't need to be and we don't have to assume they are | 22:06 |
tonyb | mdbooth: ping? | 22:06 |
*** vilobhmm11 has joined #openstack-nova | 22:06 | |
mriedem | sdague: i had some questions about using testscenarios in this functional test for a microversion add - might need your clarification https://review.openstack.org/#/c/253087/5/nova/tests/functional/api_sample_tests/test_instance_actions.py | 22:07 |
alaski | mriedem: gotcha. it would be good to have them as uuids in the api samples, just not enforced in the object itself | 22:07 |
mriedem | sdague: since testscenarios and how everything is setup by magic in the api samples tests always baffles me | 22:07 |
mriedem | doffm: ^ reviewed your bp change if you have questions | 22:07 |
*** mdrabe__ has quit IRC | 22:08 | |
*** mdrabe__ has joined #openstack-nova | 22:09 | |
*** salv-orl_ has joined #openstack-nova | 22:09 | |
*** salv-orlando has quit IRC | 22:12 | |
openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add test coverage to functional api tests _compare_result method https://review.openstack.org/263440 | 22:14 |
*** vilobhmm11 has quit IRC | 22:15 | |
mriedem | sdague: gmann: shouldn't https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_server_groups.py#L84 be scenarios = [('v2_13', {'api_major_version': 'v2.1'})] ? | 22:15 |
*** vilobhmm11 has joined #openstack-nova | 22:15 | |
*** e0ne has quit IRC | 22:15 | |
melwitt | alaski: so we'll want something like a nova-manage command that takes what's in an existing cells v1 deployment and generates the cell mappings? I see how the mq info is in the cells table, but how do we know what the cell dbs are? | 22:16 |
*** pratikmallya has joined #openstack-nova | 22:17 | |
*** ildikov_afk is now known as ildikov | 22:17 | |
*** vilobhmm11 has quit IRC | 22:18 | |
*** vilobhmm11 has joined #openstack-nova | 22:19 | |
*** ihrachys has quit IRC | 22:19 | |
*** Daisy has quit IRC | 22:19 | |
alaski | melwitt: I think we can leave it up to deployers to generate the cell mappings themselves, not try to pull them from existing cells | 22:20 |
*** ihrachys has joined #openstack-nova | 22:20 | |
alaski | and for the non-cells case that will be necessary | 22:20 |
ildikov | mriedem: thanks for taking care of the get_by_volume patch! | 22:20 |
mriedem | np | 22:20 |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/cert directory https://review.openstack.org/267841 | 22:23 |
*** dave-mcc_ has quit IRC | 22:25 | |
*** eil397 has joined #openstack-nova | 22:26 | |
melwitt | alaski: okay, so the transport url and database connection will be args to the nova-manage command. and the host list can be pulled automatically using the provided database connection | 22:26 |
*** jwcroppe has joined #openstack-nova | 22:27 | |
alaski | melwitt: yeah, I think that would be a good way to do it | 22:28 |
melwitt | alaski: thanks, that makes sense. I'll start working on it :) | 22:31 |
*** tjones has joined #openstack-nova | 22:31 | |
*** matrohon has quit IRC | 22:31 | |
*** suro-patz has quit IRC | 22:31 | |
alaski | melwitt: awesome, thanks | 22:32 |
*** suro-patz has joined #openstack-nova | 22:32 | |
*** matrohon has joined #openstack-nova | 22:33 | |
* mriedem is comforted by the fact that api samples tests are still as confusing as they always were | 22:33 | |
alaski | s/comforted by/depressed by/ | 22:33 |
alaski | I haven't looked in a while, but I always hated the recursive method in there that did the comparison | 22:34 |
alaski | not sure if it's still there | 22:34 |
melwitt | I remember when I first learned how to work on the api samples. that was rough | 22:34 |
*** otter768 has joined #openstack-nova | 22:35 | |
*** ihrachys has quit IRC | 22:35 | |
*** jwcroppe has quit IRC | 22:36 | |
ildikov | mriedem: in Mitaka we need these two patches to land for multiattach: https://review.openstack.org/#/c/193134 , https://review.openstack.org/#/c/256273 | 22:36 |
*** ihrachys has joined #openstack-nova | 22:36 | |
*** ijw has joined #openstack-nova | 22:36 | |
ildikov | mriedem: and then we can figure out the API for Newton and allow attaching the second volume | 22:37 |
*** otter768 has quit IRC | 22:39 | |
rlrossit | dims_: things are looking pretty red in that ceilometer change in zuul, but it looks like they're having issues because everything is failing for them. Sooo... the rpc change is good? | 22:41 |
*** ccarmack has quit IRC | 22:43 | |
*** ZZelle__ has joined #openstack-nova | 22:44 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Ceph for live-migration job https://review.openstack.org/252283 | 22:44 |
*** matrohon has quit IRC | 22:45 | |
rlrossit | dims_: all of their functional tests are currently failing, but at least tempest was good. Take a look if you want (https://review.openstack.org/#/c/267779/), I'll probably leave it sit until tomorrow, it's time to go home | 22:45 |
*** rlrossit has quit IRC | 22:46 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: ServerGroupsV213SampleJsonTest should actually test v2.13 https://review.openstack.org/267853 | 22:49 |
mriedem | talk about confusing ^ | 22:49 |
*** harlowja has joined #openstack-nova | 22:50 | |
ildikov | mriedem: I just saw someone working with these tests, but even that got me confused | 22:51 |
mriedem | it's super confusing | 22:51 |
mriedem | and it doesn't fail when it's wrong | 22:51 |
mriedem | it's testscenarios magic | 22:51 |
*** lpetrut has quit IRC | 22:52 | |
ildikov | I remember that we had an issue that we had to modify the doc file and another file, but the only info was a regexp failure | 22:52 |
ildikov | not to mention what you've just said | 22:52 |
*** ihrachys_ has joined #openstack-nova | 22:52 | |
*** claudiub has quit IRC | 22:52 | |
*** dims_ has quit IRC | 22:54 | |
*** ihrachys has quit IRC | 22:54 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Trace original exception before converting exception https://review.openstack.org/265239 | 22:54 |
*** ijw has quit IRC | 22:54 | |
*** _diana_1 has quit IRC | 22:55 | |
*** ctrath has quit IRC | 22:55 | |
*** claudiub has joined #openstack-nova | 22:55 | |
*** ankita has quit IRC | 22:56 | |
*** _diana_1 has joined #openstack-nova | 22:57 | |
*** kylek3h has quit IRC | 22:58 | |
*** browne has quit IRC | 22:59 | |
*** mriedem has quit IRC | 23:00 | |
openstackgerrit | David Edery proposed openstack/nova: ports & networks gather should validate existance https://review.openstack.org/252565 | 23:02 |
*** mdrabe__ has quit IRC | 23:02 | |
*** doug-fish has quit IRC | 23:02 | |
*** burt has quit IRC | 23:03 | |
*** pradk has quit IRC | 23:04 | |
auggy | mriedem: omg i've just spend the past several weeks diving into those with sdague | 23:05 |
*** e0ne has joined #openstack-nova | 23:06 | |
*** pumaranikar has quit IRC | 23:06 | |
*** ihrachys has joined #openstack-nova | 23:06 | |
*** pumaranikar has joined #openstack-nova | 23:06 | |
auggy | my first real dive into Nova code and it was that!! | 23:06 |
auggy | trial by fire!! | 23:06 |
*** haomaiwang has joined #openstack-nova | 23:07 | |
*** pumaranikar has quit IRC | 23:07 | |
*** mmedvede has quit IRC | 23:07 | |
*** pumaranikar has joined #openstack-nova | 23:07 | |
*** gongysh_ has joined #openstack-nova | 23:08 | |
*** haomaiwang has quit IRC | 23:08 | |
*** ihrachys_ has quit IRC | 23:09 | |
*** pumaranikar has quit IRC | 23:12 | |
*** omnipresent has quit IRC | 23:13 | |
*** pradk_ has joined #openstack-nova | 23:15 | |
*** ZZelle__ has quit IRC | 23:16 | |
*** erlon has quit IRC | 23:16 | |
*** dimtruck is now known as zz_dimtruck | 23:17 | |
*** Daisy has joined #openstack-nova | 23:19 | |
*** gyee has joined #openstack-nova | 23:21 | |
*** diogogmt has quit IRC | 23:23 | |
*** pratikmallya has quit IRC | 23:25 | |
*** zenoway has joined #openstack-nova | 23:25 | |
*** apoorvad has quit IRC | 23:26 | |
*** carey has joined #openstack-nova | 23:27 | |
*** dims has joined #openstack-nova | 23:27 | |
*** mrkz has quit IRC | 23:29 | |
*** xyang1 has quit IRC | 23:29 | |
*** zenoway has quit IRC | 23:30 | |
*** carey has quit IRC | 23:32 | |
*** tjones has quit IRC | 23:33 | |
*** jwcroppe has joined #openstack-nova | 23:33 | |
*** mragupat has quit IRC | 23:39 | |
*** jwcroppe has quit IRC | 23:39 | |
*** pradk_ has quit IRC | 23:40 | |
*** ducttape_ has quit IRC | 23:43 | |
*** ducttape_ has joined #openstack-nova | 23:43 | |
*** ihrachys has quit IRC | 23:46 | |
gmann | mriedem: yea it needs to be with 2.1. currently its hitting v2 and verify nothing about 2.13 version | 23:46 |
*** lihg has joined #openstack-nova | 23:47 | |
*** smoriya_ has joined #openstack-nova | 23:47 | |
*** ducttape_ has quit IRC | 23:48 | |
*** e0ne has quit IRC | 23:49 | |
*** zenoway has joined #openstack-nova | 23:50 | |
*** zenoway has quit IRC | 23:54 | |
*** zz_dimtruck is now known as dimtruck | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!