*** rhagarty__ has quit IRC | 00:00 | |
*** rhagarty__ has joined #openstack-nova | 00:00 | |
*** rhagarty__ has quit IRC | 00:00 | |
*** rhagarty__ has joined #openstack-nova | 00:00 | |
*** haomaiwang has quit IRC | 00:01 | |
*** rhagarty__ has quit IRC | 00:01 | |
*** rhagarty__ has joined #openstack-nova | 00:01 | |
*** rhagarty__ has quit IRC | 00:01 | |
*** haomaiwang has joined #openstack-nova | 00:01 | |
*** rhagarty__ has joined #openstack-nova | 00:01 | |
*** rhagarty__ has quit IRC | 00:02 | |
*** rhagarty_ has joined #openstack-nova | 00:02 | |
*** thorst_ has joined #openstack-nova | 00:02 | |
*** rhagarty_ has quit IRC | 00:02 | |
*** rhagarty_ has joined #openstack-nova | 00:02 | |
*** rhagarty_ has quit IRC | 00:03 | |
*** rhagarty_ has joined #openstack-nova | 00:03 | |
*** rhagarty_ has quit IRC | 00:03 | |
*** rhagarty_ has joined #openstack-nova | 00:03 | |
*** rhagarty_ has quit IRC | 00:04 | |
*** rhagarty_ has joined #openstack-nova | 00:04 | |
*** rhagarty_ has quit IRC | 00:04 | |
*** rhagarty_ has joined #openstack-nova | 00:04 | |
*** alex_xu has quit IRC | 00:05 | |
*** rhagarty_ has quit IRC | 00:05 | |
*** rhagarty_ has joined #openstack-nova | 00:05 | |
*** akshai has quit IRC | 00:05 | |
*** rhagarty_ has quit IRC | 00:05 | |
*** rhagarty_ has joined #openstack-nova | 00:05 | |
*** edmondsw has quit IRC | 00:06 | |
*** rhagarty_ has quit IRC | 00:06 | |
*** rhagarty_ has joined #openstack-nova | 00:06 | |
*** rhagarty_ has quit IRC | 00:06 | |
*** rhagarty_ has joined #openstack-nova | 00:06 | |
*** rhagarty__ has joined #openstack-nova | 00:07 | |
*** rhagarty_ has quit IRC | 00:07 | |
*** alex_xu has joined #openstack-nova | 00:07 | |
*** rhagarty__ has quit IRC | 00:07 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Stop raising 404 when no mountpoint for volume attachment https://review.openstack.org/290196 | 00:07 |
---|---|---|
*** rhagarty__ has joined #openstack-nova | 00:07 | |
*** davechen_afk has quit IRC | 00:07 | |
*** rhagarty__ has quit IRC | 00:08 | |
*** gongysh_ has joined #openstack-nova | 00:09 | |
*** gyee has joined #openstack-nova | 00:10 | |
*** gyee has quit IRC | 00:11 | |
*** doug-fish has joined #openstack-nova | 00:11 | |
*** gyee has joined #openstack-nova | 00:15 | |
*** zenoway has joined #openstack-nova | 00:15 | |
*** tbachman has joined #openstack-nova | 00:15 | |
*** zenoway has quit IRC | 00:20 | |
*** hemna is now known as hemnafk | 00:20 | |
*** gjayavelu has joined #openstack-nova | 00:21 | |
*** irenab_ has joined #openstack-nova | 00:23 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Fix sample version of service-update https://review.openstack.org/290198 | 00:23 |
*** fawadkhaliq has joined #openstack-nova | 00:23 | |
*** irenab has quit IRC | 00:25 | |
*** irenab_ is now known as irenab | 00:25 | |
*** salv-orlando has joined #openstack-nova | 00:30 | |
*** browne has quit IRC | 00:33 | |
*** fawadkhaliq has quit IRC | 00:35 | |
*** bapalm has quit IRC | 00:37 | |
*** sheel has joined #openstack-nova | 00:39 | |
*** yuntongjin has joined #openstack-nova | 00:40 | |
*** salv-orlando has quit IRC | 00:40 | |
*** apoorvad has quit IRC | 00:43 | |
*** mriedem has joined #openstack-nova | 00:44 | |
*** pwnall has quit IRC | 00:46 | |
*** yuntongjin has quit IRC | 00:46 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Dont-merge: Kick function tests https://review.openstack.org/290208 | 00:48 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Dont-merge: Kick function tests without patch https://review.openstack.org/290210 | 00:49 |
*** zenoway has joined #openstack-nova | 00:51 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: virt: refactor method compute_driver_matches https://review.openstack.org/263243 | 00:52 |
*** Jeffrey4l has joined #openstack-nova | 00:52 | |
*** Kevin_Zheng has joined #openstack-nova | 00:53 | |
oomichi | gmann: about https://bugs.launchpad.net/nova/+bug/1554440 | 00:53 |
openstack | Launchpad bug 1554440 in OpenStack Compute (nova) "Show volume attachment exception does not looks good if server is in shelved_offloaded state" [High,In progress] - Assigned to Ghanshyam Mann (ghanshyammann) | 00:53 |
gmann | oomichi: hi | 00:54 |
oomichi | gmann: the problem has happened since v2.20, right? | 00:54 |
*** bapalm has joined #openstack-nova | 00:54 | |
gmann | oomichi: yea but even in previous version (v2.1) too it does not seems good as list and show behaves differently for no mountpoint | 00:55 |
oomichi | gmann: https://review.openstack.org/#/c/290196/ changes the API behavior of old versions also. | 00:55 |
gmann | oomichi: we discussed in yesterday api meeting and patch up and get more feedback if it is ok to fix in all version or only for v2.20 | 00:55 |
*** zenoway has quit IRC | 00:55 | |
*** harlowja has quit IRC | 00:55 | |
gmann | oomichi: yea it change but it is 404 -> 200 | 00:55 |
gmann | oomichi: because list API is 200 if no mountoint | 00:56 |
oomichi | gmann: that is gray area | 00:56 |
gmann | and Show is 404 | 00:56 |
*** ankita_wagh has quit IRC | 00:56 | |
oomichi | gmann: v2 comp API is very inconsistent as you said. and that is a reason why we need microversions | 00:57 |
oomichi | for fixing them | 00:57 |
*** gongysh_ has quit IRC | 00:57 | |
gmann | oomichi: in that patch am changing v2 also so that no issue with v2 comp API | 00:57 |
gmann | oomichi: but yea we do microversion in those cases but this case seems just bug fix without version for me | 00:58 |
gmann | but yea need more feedback | 00:58 |
*** haomaiwang has quit IRC | 01:01 | |
*** haomaiwang has joined #openstack-nova | 01:01 | |
*** mtanino has quit IRC | 01:02 | |
*** vilobhmm11 has quit IRC | 01:02 | |
*** vilobhmm11 has joined #openstack-nova | 01:03 | |
*** phuongnh has joined #openstack-nova | 01:03 | |
*** vilobhmm11 has quit IRC | 01:04 | |
*** jwcroppe has quit IRC | 01:04 | |
*** vilobhmm11 has joined #openstack-nova | 01:04 | |
*** sdague has joined #openstack-nova | 01:06 | |
*** browne has joined #openstack-nova | 01:08 | |
*** gcb has joined #openstack-nova | 01:10 | |
*** apoorvad has joined #openstack-nova | 01:10 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for driver attach_interfaces capability https://review.openstack.org/272471 | 01:12 |
*** ZZelle_ has quit IRC | 01:16 | |
*** tbachman has quit IRC | 01:16 | |
*** ducttape_ has joined #openstack-nova | 01:24 | |
*** zz_dimtruck is now known as dimtruck | 01:25 | |
*** tbachman has joined #openstack-nova | 01:31 | |
*** haomaiwang has quit IRC | 01:32 | |
*** daemontool has joined #openstack-nova | 01:37 | |
*** sdague has quit IRC | 01:38 | |
*** gongysh has joined #openstack-nova | 01:44 | |
*** sdague has joined #openstack-nova | 01:46 | |
*** gongysh_ has joined #openstack-nova | 01:46 | |
*** gongysh_ has quit IRC | 01:50 | |
*** ducttape_ has quit IRC | 01:52 | |
*** zenoway has joined #openstack-nova | 01:53 | |
*** mtanino has joined #openstack-nova | 01:53 | |
*** mdrabe has joined #openstack-nova | 01:56 | |
*** ducttape_ has joined #openstack-nova | 01:57 | |
*** salv-orlando has joined #openstack-nova | 01:57 | |
*** zenoway has quit IRC | 01:58 | |
*** vilobhmm11 has quit IRC | 01:59 | |
mriedem | mikal: are my eyes going crazy? https://review.openstack.org/#/c/284025/5/nova/tests/unit/virt/ironic/test_driver.py | 02:03 |
*** vilobhmm11 has joined #openstack-nova | 02:03 | |
*** vilobhmm11 has quit IRC | 02:03 | |
*** vilobhmm11 has joined #openstack-nova | 02:03 | |
*** salv-orlando has quit IRC | 02:04 | |
*** gongysh_ has joined #openstack-nova | 02:04 | |
*** sdague has quit IRC | 02:05 | |
*** baoli has joined #openstack-nova | 02:06 | |
openstackgerrit | Eli Qiao proposed openstack/nova: API: Raise up HTTPNotFound when no availabe while get_console_output https://review.openstack.org/270695 | 02:07 |
*** allen_gao has quit IRC | 02:08 | |
eliqiao | alex_xu: hi, can you help to take a look at https://review.openstack.org/#/c/285931/ , I replied in line. | 02:08 |
alex_xu | eliqiao: sure, will try to reach that asap | 02:09 |
*** ivase has joined #openstack-nova | 02:12 | |
*** Allen_Gao has joined #openstack-nova | 02:13 | |
*** mingyu has joined #openstack-nova | 02:14 | |
*** pushkaru has quit IRC | 02:14 | |
*** ducttape_ has quit IRC | 02:15 | |
*** ivase has quit IRC | 02:16 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 02:17 |
*** doug-fish has quit IRC | 02:19 | |
*** doug-fish has joined #openstack-nova | 02:19 | |
*** haomaiwang has joined #openstack-nova | 02:20 | |
*** Allen_Gao has quit IRC | 02:21 | |
*** Allen_Gao has joined #openstack-nova | 02:22 | |
openstackgerrit | Rong Han proposed openstack/nova: libvirt: Fix the content of "disk.config" lost after migrate/resize https://review.openstack.org/288334 | 02:22 |
*** vilobhmm11 has quit IRC | 02:22 | |
*** doug-fis_ has joined #openstack-nova | 02:23 | |
*** Allen_Gao has quit IRC | 02:23 | |
*** doug-fish has quit IRC | 02:24 | |
*** haomaiwang has quit IRC | 02:24 | |
*** haomaiwa_ has joined #openstack-nova | 02:25 | |
mriedem | alaski: i'm +0'ing in your honor https://review.openstack.org/#/c/289967/2/nova/tests/unit/db/test_db_api.py | 02:26 |
*** haomaiwa_ has quit IRC | 02:26 | |
*** haomaiwa_ has joined #openstack-nova | 02:26 | |
*** haomaiwa_ has quit IRC | 02:27 | |
mriedem | nevermind, -1 :) | 02:27 |
*** 20WAAIE7U has joined #openstack-nova | 02:27 | |
*** doug-fis_ has quit IRC | 02:27 | |
*** 20WAAIE7U has quit IRC | 02:28 | |
*** haomaiwa_ has joined #openstack-nova | 02:28 | |
*** haomaiwa_ has quit IRC | 02:29 | |
*** doug-fish has joined #openstack-nova | 02:29 | |
*** zenoway has joined #openstack-nova | 02:29 | |
*** haomaiwang has joined #openstack-nova | 02:29 | |
*** haomaiwang has quit IRC | 02:30 | |
*** haomaiwang has joined #openstack-nova | 02:30 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: WIP: Fix NoMoreNetworks functional test traces https://review.openstack.org/290240 | 02:30 |
*** liusheng has quit IRC | 02:30 | |
*** gjayavel_ has joined #openstack-nova | 02:30 | |
*** haomaiwang has quit IRC | 02:31 | |
*** haomaiwang has joined #openstack-nova | 02:31 | |
*** john51 has quit IRC | 02:31 | |
*** haomaiwang has quit IRC | 02:32 | |
*** liusheng has joined #openstack-nova | 02:32 | |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 02:32 |
*** haomaiwang has joined #openstack-nova | 02:32 | |
*** baoli has quit IRC | 02:32 | |
*** haomaiwang has quit IRC | 02:33 | |
*** john51 has joined #openstack-nova | 02:33 | |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 02:33 |
*** haomaiwang has joined #openstack-nova | 02:33 | |
*** zenoway has quit IRC | 02:33 | |
*** haomaiwang has quit IRC | 02:34 | |
*** gjayavelu has quit IRC | 02:34 | |
*** baoli has joined #openstack-nova | 02:34 | |
*** doug-fish has quit IRC | 02:35 | |
*** armax has joined #openstack-nova | 02:35 | |
*** mdrabe has quit IRC | 02:36 | |
*** nic has quit IRC | 02:37 | |
*** doug-fish has joined #openstack-nova | 02:40 | |
*** haukebruno has joined #openstack-nova | 02:44 | |
*** doug-fish has quit IRC | 02:45 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for driver attach_interfaces capability https://review.openstack.org/272471 | 02:45 |
*** doug-fish has joined #openstack-nova | 02:50 | |
*** gcb has quit IRC | 02:52 | |
*** yamahata has quit IRC | 02:53 | |
*** jwcroppe has joined #openstack-nova | 02:53 | |
*** mriedem has quit IRC | 02:54 | |
*** Allen_Gao has joined #openstack-nova | 02:54 | |
*** vilobhmm11 has joined #openstack-nova | 02:55 | |
*** Allen_Gao has quit IRC | 02:55 | |
*** doug-fish has quit IRC | 02:55 | |
*** Allen_Gao has joined #openstack-nova | 02:56 | |
*** vilobhmm111 has joined #openstack-nova | 02:57 | |
*** vilobhmm11 has quit IRC | 03:00 | |
openstackgerrit | Rong Han proposed openstack/nova: Modify instance_group_member record is not deleted when instance is deleted https://review.openstack.org/289392 | 03:01 |
*** yonglihe has quit IRC | 03:02 | |
*** gyee has quit IRC | 03:02 | |
*** zenoway has joined #openstack-nova | 03:04 | |
*** thorst_ has quit IRC | 03:05 | |
*** thorst_ has joined #openstack-nova | 03:06 | |
*** Marga__ has joined #openstack-nova | 03:06 | |
*** Allen_Gao has quit IRC | 03:07 | |
*** allen_gao has joined #openstack-nova | 03:08 | |
*** zenoway has quit IRC | 03:09 | |
*** Marga_ has quit IRC | 03:10 | |
*** allen_gao has quit IRC | 03:12 | |
*** allen_gao has joined #openstack-nova | 03:12 | |
*** gcb has joined #openstack-nova | 03:13 | |
*** thorst_ has quit IRC | 03:14 | |
*** haomaiwang has joined #openstack-nova | 03:14 | |
openstackgerrit | Li Yingjun proposed openstack/nova: Make versioned notifications topic configurable https://review.openstack.org/290254 | 03:15 |
*** Marga__ has quit IRC | 03:20 | |
*** Marga_ has joined #openstack-nova | 03:20 | |
*** ankita_wagh has joined #openstack-nova | 03:25 | |
*** dims has quit IRC | 03:25 | |
*** ducttape_ has joined #openstack-nova | 03:25 | |
*** mingyu has quit IRC | 03:27 | |
*** apoorvad has quit IRC | 03:27 | |
*** dimtruck is now known as zz_dimtruck | 03:29 | |
*** zz_dimtruck is now known as dimtruck | 03:29 | |
*** markvoelker has joined #openstack-nova | 03:30 | |
*** salv-orlando has joined #openstack-nova | 03:32 | |
eliqiao | Yingxin: https://bugs.launchpad.net/nova/+bug/1517442 | 03:34 |
openstack | Launchpad bug 1517442 in OpenStack Compute (nova) "libvirt/xenapi: disk_available_least reported by the driver does not take into account instances being migrated to/from the host" [High,Confirmed] - Assigned to Wenzhi Yu (yuywz) | 03:34 |
*** salv-orlando has quit IRC | 03:35 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 03:36 |
*** gongysh has quit IRC | 03:36 | |
*** mingyu has joined #openstack-nova | 03:38 | |
*** dimtruck is now known as zz_dimtruck | 03:39 | |
*** zenoway has joined #openstack-nova | 03:40 | |
*** haomaiwang has quit IRC | 03:40 | |
*** haomaiw__ has joined #openstack-nova | 03:40 | |
*** allen_gao has quit IRC | 03:42 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for driver attach_interfaces capability https://review.openstack.org/272471 | 03:44 |
*** zenoway has quit IRC | 03:44 | |
*** zhangkepi has joined #openstack-nova | 03:45 | |
*** yamahata has joined #openstack-nova | 03:47 | |
zhangkepi | hello | 03:48 |
zhangkepi | anybody online | 03:48 |
zhangkepi | hello | 03:50 |
*** mingyu has quit IRC | 03:50 | |
*** vilobhmm111 has quit IRC | 03:51 | |
*** jwcroppe has quit IRC | 03:51 | |
* eliqiao is lurking | 03:52 | |
*** allen_gao has joined #openstack-nova | 03:53 | |
*** jamielennox is now known as jamielennox|away | 03:54 | |
*** ducttape_ has quit IRC | 03:55 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova-specs: Attach/detach SR-IOV interface https://review.openstack.org/139910 | 03:55 |
openstackgerrit | Eli Qiao proposed openstack/nova: API: Raise up HTTPNotFound when no availabe while get_console_output https://review.openstack.org/270695 | 03:59 |
openstackgerrit | Rong Han proposed openstack/nova: libvirt: Fix the content of "disk.config" lost after migrate/resize https://review.openstack.org/288334 | 04:02 |
*** links has joined #openstack-nova | 04:03 | |
*** baoli has quit IRC | 04:04 | |
*** ducttape_ has joined #openstack-nova | 04:10 | |
*** thorst_ has joined #openstack-nova | 04:12 | |
*** vilobhmm11 has joined #openstack-nova | 04:12 | |
*** thorst_ has quit IRC | 04:19 | |
*** sayalilunkad has quit IRC | 04:22 | |
*** armax has quit IRC | 04:23 | |
*** Marga_ has quit IRC | 04:23 | |
*** mingyu has joined #openstack-nova | 04:28 | |
*** zz_dimtruck is now known as dimtruck | 04:33 | |
*** sayalilunkad has joined #openstack-nova | 04:34 | |
*** Marga_ has joined #openstack-nova | 04:35 | |
*** baoli has joined #openstack-nova | 04:37 | |
*** yamahata has quit IRC | 04:37 | |
*** yamahata has joined #openstack-nova | 04:38 | |
*** ducttape_ has quit IRC | 04:40 | |
*** Marga_ has quit IRC | 04:40 | |
*** allen_gao has quit IRC | 04:42 | |
*** baoli has quit IRC | 04:43 | |
*** sridharg has joined #openstack-nova | 04:45 | |
*** fifieldt has joined #openstack-nova | 04:47 | |
*** baoli has joined #openstack-nova | 04:47 | |
*** sayalilunkad has quit IRC | 04:50 | |
*** phuongnh has quit IRC | 04:51 | |
*** sayalilunkad has joined #openstack-nova | 04:51 | |
*** allen_gao has joined #openstack-nova | 04:51 | |
*** Marga_ has joined #openstack-nova | 04:53 | |
*** Marga_ has quit IRC | 04:54 | |
*** Marga_ has joined #openstack-nova | 04:54 | |
*** dimtruck is now known as zz_dimtruck | 04:54 | |
*** Marga_ has quit IRC | 04:54 | |
*** Marga_ has joined #openstack-nova | 04:54 | |
*** Marga_ has quit IRC | 04:55 | |
*** Marga_ has joined #openstack-nova | 04:55 | |
*** EinstCrazy has joined #openstack-nova | 04:57 | |
*** baoli has quit IRC | 05:00 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID https://review.openstack.org/287702 | 05:02 |
*** eliqiao has quit IRC | 05:04 | |
*** eliqiao has joined #openstack-nova | 05:04 | |
*** deepakcs has joined #openstack-nova | 05:06 | |
*** salv-orlando has joined #openstack-nova | 05:07 | |
*** salv-orlando has quit IRC | 05:13 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: nova quota-update shouldn't work with tenant-name https://review.openstack.org/284042 | 05:15 |
*** claudiub has quit IRC | 05:15 | |
*** liusheng has quit IRC | 05:16 | |
*** thorst_ has joined #openstack-nova | 05:17 | |
*** liusheng has joined #openstack-nova | 05:18 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: nova quota-update shouldn't work with tenant-name https://review.openstack.org/284042 | 05:18 |
*** yuntongjin has joined #openstack-nova | 05:23 | |
*** thorst_ has quit IRC | 05:23 | |
*** EinstCrazy has quit IRC | 05:28 | |
*** mingyu has quit IRC | 05:28 | |
*** harlowja_at_home has joined #openstack-nova | 05:29 | |
*** vilobhmm11 has quit IRC | 05:31 | |
openstackgerrit | Rong Han proposed openstack/nova: Modify instance_group_member record is not deleted when instance is deleted https://review.openstack.org/289392 | 05:33 |
*** vilobhmm11 has joined #openstack-nova | 05:33 | |
*** baoli has joined #openstack-nova | 05:36 | |
*** zenoway has joined #openstack-nova | 05:39 | |
*** baoli has quit IRC | 05:40 | |
*** gcb has quit IRC | 05:41 | |
*** mingyu has joined #openstack-nova | 05:43 | |
*** zenoway has quit IRC | 05:44 | |
*** hoangcx has joined #openstack-nova | 05:45 | |
*** yuntongjin1 has joined #openstack-nova | 05:46 | |
*** fawadkhaliq has joined #openstack-nova | 05:47 | |
*** yuntongjin has quit IRC | 05:48 | |
*** jwcroppe has joined #openstack-nova | 05:52 | |
*** hanrong has joined #openstack-nova | 05:52 | |
*** nkrinner has joined #openstack-nova | 05:54 | |
*** sudipto has joined #openstack-nova | 05:56 | |
*** yuntongjin has joined #openstack-nova | 05:57 | |
*** yuntongjin1 has quit IRC | 05:59 | |
*** gcb has joined #openstack-nova | 05:59 | |
*** dedery has joined #openstack-nova | 06:00 | |
*** dedery has joined #openstack-nova | 06:01 | |
openstackgerrit | javeme proposed openstack/nova: raise exception ComputeHostNotFound if host is not found https://review.openstack.org/243105 | 06:02 |
*** zhangkepi has quit IRC | 06:07 | |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 06:07 |
*** ekuris_ has joined #openstack-nova | 06:08 | |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 06:08 |
*** liusheng has quit IRC | 06:08 | |
*** rcernin has joined #openstack-nova | 06:09 | |
*** liusheng has joined #openstack-nova | 06:09 | |
*** gcb has quit IRC | 06:10 | |
*** bnemec has quit IRC | 06:11 | |
*** zenoway has joined #openstack-nova | 06:14 | |
openstackgerrit | Alex Xu proposed openstack/nova: Report instance-actions for live migration force complete API https://review.openstack.org/290289 | 06:15 |
openstackgerrit | javeme proposed openstack/nova: Missing to update task state for confirm_resize https://review.openstack.org/244433 | 06:17 |
openstackgerrit | jinquanni proposed openstack/nova: modify code for resize failure can rollback to exact vm_state https://review.openstack.org/287774 | 06:19 |
*** allen_gao has quit IRC | 06:19 | |
*** hanrong has quit IRC | 06:19 | |
*** zenoway has quit IRC | 06:19 | |
*** thorst_ has joined #openstack-nova | 06:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/288845 | 06:21 |
openstackgerrit | javeme proposed openstack/nova: Remove sizelimit.py in favor of oslo_middleware.sizelimit https://review.openstack.org/282181 | 06:22 |
*** mingyu has quit IRC | 06:24 | |
*** amotoki has joined #openstack-nova | 06:25 | |
*** thorst_ has quit IRC | 06:28 | |
*** esracelik has joined #openstack-nova | 06:29 | |
openstackgerrit | Alex Xu proposed openstack/nova: modify code for resize failure can rollback to exact vm_state https://review.openstack.org/287774 | 06:29 |
*** allen_gao has joined #openstack-nova | 06:30 | |
*** salv-orlando has joined #openstack-nova | 06:31 | |
*** shaohe_feng has quit IRC | 06:32 | |
*** mingyu has joined #openstack-nova | 06:34 | |
openstackgerrit | javeme proposed openstack/nova: VMware: Refactor the formatting instance metadata https://review.openstack.org/268994 | 06:35 |
*** salv-orlando has quit IRC | 06:36 | |
*** mingyu has quit IRC | 06:36 | |
*** PaulMurray has joined #openstack-nova | 06:38 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova: split host_state.least_disk_mb out of free_disk_mb https://review.openstack.org/290302 | 06:40 |
openstackgerrit | javeme proposed openstack/nova: VMware: Prefer ShutdownGuest to PowerOffVM_Task https://review.openstack.org/181634 | 06:44 |
*** vishwanathj has quit IRC | 06:49 | |
*** omnipresent has joined #openstack-nova | 06:50 | |
*** vishwanathj has joined #openstack-nova | 06:51 | |
*** mingyu has joined #openstack-nova | 06:52 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: Missing info_cache.save() in db sqlalchemy api https://review.openstack.org/289967 | 06:53 |
*** omnipresent has quit IRC | 06:55 | |
*** dave-mccowan has quit IRC | 07:02 | |
*** harlowja_at_home has quit IRC | 07:03 | |
*** sudipto has quit IRC | 07:04 | |
*** zenoway has joined #openstack-nova | 07:05 | |
*** claudiub has joined #openstack-nova | 07:07 | |
*** lpetrut has joined #openstack-nova | 07:09 | |
*** vishwana_ has joined #openstack-nova | 07:10 | |
*** mjura has joined #openstack-nova | 07:12 | |
*** vishwanathj has quit IRC | 07:13 | |
*** sudipto has joined #openstack-nova | 07:17 | |
*** paul-carlton2 has joined #openstack-nova | 07:20 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID https://review.openstack.org/287702 | 07:21 |
*** omnipresent has joined #openstack-nova | 07:22 | |
*** zenoway has quit IRC | 07:25 | |
*** thorst_ has joined #openstack-nova | 07:26 | |
*** mingyu has quit IRC | 07:27 | |
*** nkrinner has quit IRC | 07:27 | |
*** fawadkhaliq has quit IRC | 07:28 | |
*** ildikov has quit IRC | 07:28 | |
*** mingyu has joined #openstack-nova | 07:29 | |
*** allen_gao has quit IRC | 07:29 | |
*** paul-carlton2 has quit IRC | 07:30 | |
*** nkrinner has joined #openstack-nova | 07:31 | |
*** hanrong has joined #openstack-nova | 07:33 | |
*** thorst_ has quit IRC | 07:33 | |
*** zenoway has joined #openstack-nova | 07:34 | |
hanrong | eliqiao: hi | 07:34 |
eliqiao | hanrong: hi :) | 07:35 |
*** rdopiera has joined #openstack-nova | 07:35 | |
*** omnipresent has quit IRC | 07:35 | |
*** d34dh0r53 has quit IRC | 07:36 | |
*** cloudnull has quit IRC | 07:38 | |
*** paul-carlton2 has joined #openstack-nova | 07:38 | |
*** allen_gao has joined #openstack-nova | 07:38 | |
*** omnipresent has joined #openstack-nova | 07:38 | |
*** hanrong has quit IRC | 07:39 | |
*** zenoway has quit IRC | 07:40 | |
openstackgerrit | Eli Qiao proposed openstack/nova: Query procceeding status migration in confirm/revert_resize() https://review.openstack.org/285931 | 07:43 |
*** liverpooler has joined #openstack-nova | 07:46 | |
*** cfriesen_ has quit IRC | 07:47 | |
*** shaohe_robot has quit IRC | 07:56 | |
*** belmoreira has joined #openstack-nova | 07:56 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: set service status based on vc connection https://review.openstack.org/290315 | 07:57 |
*** RuiChen has quit IRC | 07:59 | |
*** scheuran has joined #openstack-nova | 08:00 | |
*** RuiChen has joined #openstack-nova | 08:01 | |
*** RuiChen has quit IRC | 08:05 | |
*** RuiChen has joined #openstack-nova | 08:06 | |
*** RuiChen has quit IRC | 08:06 | |
*** RuiChen has joined #openstack-nova | 08:07 | |
*** RuiChen has quit IRC | 08:07 | |
openstackgerrit | Rong Han proposed openstack/nova: Soft delete instance group member when delete instance https://review.openstack.org/289392 | 08:07 |
*** RuiChen has joined #openstack-nova | 08:07 | |
*** dguitarbite has joined #openstack-nova | 08:10 | |
*** hanrong has joined #openstack-nova | 08:10 | |
*** e0ne has joined #openstack-nova | 08:10 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Use migrate_data.block_migration instead of block_migration https://review.openstack.org/287363 | 08:11 |
*** RuiChen has quit IRC | 08:11 | |
*** ankita_wagh has quit IRC | 08:11 | |
*** RuiChen has joined #openstack-nova | 08:11 | |
*** browne has quit IRC | 08:11 | |
*** ankita_wagh has joined #openstack-nova | 08:12 | |
*** paul-carlton2 has quit IRC | 08:12 | |
*** mpavone has joined #openstack-nova | 08:13 | |
*** mjura has quit IRC | 08:13 | |
*** lpetrut has quit IRC | 08:14 | |
*** moshele has joined #openstack-nova | 08:16 | |
*** ankita_wagh has quit IRC | 08:16 | |
*** paul-carlton2 has joined #openstack-nova | 08:17 | |
*** lpetrut has joined #openstack-nova | 08:18 | |
*** e0ne has quit IRC | 08:19 | |
*** erno has joined #openstack-nova | 08:21 | |
*** gjayavel_ has quit IRC | 08:22 | |
*** rk4n has joined #openstack-nova | 08:22 | |
*** matrohon has joined #openstack-nova | 08:23 | |
*** jichen has joined #openstack-nova | 08:23 | |
*** vilobhmm11 has quit IRC | 08:25 | |
*** jlanoux has joined #openstack-nova | 08:27 | |
*** mjura has joined #openstack-nova | 08:28 | |
*** macsz1 has joined #openstack-nova | 08:28 | |
*** macsz1 has quit IRC | 08:29 | |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 08:30 |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 08:30 |
*** pece has joined #openstack-nova | 08:31 | |
*** thorst_ has joined #openstack-nova | 08:31 | |
*** josecastroleon has quit IRC | 08:32 | |
*** jwcroppe has quit IRC | 08:32 | |
*** macsz has joined #openstack-nova | 08:32 | |
*** jwcroppe has joined #openstack-nova | 08:32 | |
*** josecastroleon has joined #openstack-nova | 08:33 | |
*** ndipanov has quit IRC | 08:35 | |
*** rk4n has quit IRC | 08:36 | |
*** yuntongjin has quit IRC | 08:38 | |
*** thorst_ has quit IRC | 08:39 | |
*** lpetrut has quit IRC | 08:39 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary https://review.openstack.org/288373 | 08:42 |
*** daemontool_ has joined #openstack-nova | 08:47 | |
bauzas | good morning nova | 08:47 |
*** openstackgerrit has quit IRC | 08:47 | |
*** ihrachys has joined #openstack-nova | 08:48 | |
*** openstackgerrit has joined #openstack-nova | 08:48 | |
*** whenry_ has quit IRC | 08:49 | |
*** mkasprzy has joined #openstack-nova | 08:49 | |
*** whenry_ has joined #openstack-nova | 08:49 | |
*** daemontool has quit IRC | 08:49 | |
*** mgoddard has joined #openstack-nova | 08:51 | |
paul-carlton2 | bauzas, good morning, can you take a look at https://review.openstack.org/288373 pls | 08:51 |
*** RuiChen has quit IRC | 08:52 | |
paul-carlton2 | Paul Murray and I re worded the release note slightly, hope it meets with your approval | 08:52 |
*** doug-fish has joined #openstack-nova | 08:52 | |
*** huanxie has joined #openstack-nova | 08:53 | |
*** hanrong has quit IRC | 08:53 | |
*** whenry_ has quit IRC | 08:54 | |
*** ndipanov has joined #openstack-nova | 08:55 | |
*** links has quit IRC | 08:55 | |
lyarwood | johnthetubaguy and any other cores that are online, can I ask for reviews on https://review.openstack.org/#/q/topic:bug/1548450 (OSSA 2016-007 (CVE-2016-2140)) | 08:57 |
*** doug-fish has quit IRC | 08:57 | |
*** yuntongjin has joined #openstack-nova | 08:58 | |
*** paul-carlton2 has quit IRC | 08:58 | |
*** efried has quit IRC | 09:00 | |
*** macsz has quit IRC | 09:01 | |
*** huanxie has quit IRC | 09:01 | |
openstackgerrit | Lee Yarwood proposed openstack/nova-specs: Virtual instance rescue with stable disk devices https://review.openstack.org/273122 | 09:02 |
*** whenry_ has joined #openstack-nova | 09:03 | |
*** jaosorior has joined #openstack-nova | 09:06 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Use migrate_data.block_migration instead of block_migration https://review.openstack.org/287363 | 09:07 |
*** mingyu has quit IRC | 09:08 | |
*** efoley has joined #openstack-nova | 09:08 | |
openstackgerrit | jinquanni proposed openstack/nova: manager:mark a vm that resume failed https://review.openstack.org/289745 | 09:09 |
*** andreykurilin__ has joined #openstack-nova | 09:10 | |
*** amotoki has quit IRC | 09:10 | |
*** efoley_ has joined #openstack-nova | 09:10 | |
*** shaohe_feng has joined #openstack-nova | 09:10 | |
bauzas | paul-carlton1: will do, sure | 09:11 |
bauzas | paul-carlton1: maybe just a quick nit, include_disabled is maybe a too long argument name | 09:12 |
*** mingyu has joined #openstack-nova | 09:12 | |
bauzas | I was thinking of 'disabled' only | 09:12 |
bauzas | but I'm terrible at naming | 09:12 |
*** sridhargaddam has joined #openstack-nova | 09:13 | |
*** efoley has quit IRC | 09:13 | |
*** shaohe_feng has quit IRC | 09:13 | |
*** bapalm has quit IRC | 09:14 | |
*** shaohe_feng has joined #openstack-nova | 09:14 | |
*** efried has joined #openstack-nova | 09:14 | |
*** sridhargaddam has quit IRC | 09:15 | |
*** sridharg has quit IRC | 09:15 | |
*** sridharg has joined #openstack-nova | 09:15 | |
*** lucas-dinner is now known as lucasagomes | 09:16 | |
*** palexster has joined #openstack-nova | 09:16 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID https://review.openstack.org/287702 | 09:18 |
*** jistr has joined #openstack-nova | 09:19 | |
*** ildikov has joined #openstack-nova | 09:19 | |
johnthetubaguy | lyarwood: I thought we normally get the cores on the bug that approved the change to quickly re-aprove in gerrit, not sure why that hasn't happened here, I will try dig into that | 09:21 |
*** slunkad has joined #openstack-nova | 09:21 | |
*** salv-orlando has joined #openstack-nova | 09:21 | |
paul-carlton1 | bauzas, 'disabled' was my first thought but that didn't describe the meaning of the parameter correctly, suggesting that you'd only get disabled hosts if you set it to True! | 09:23 |
*** yamahata has quit IRC | 09:23 | |
*** d34dh0r53 has joined #openstack-nova | 09:23 | |
bauzas | paul-carlton1: well, you're right | 09:23 |
openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: nova add-secgroup help updated with secgroup id https://review.openstack.org/290345 | 09:23 |
*** roeyc has joined #openstack-nova | 09:23 | |
*** palexster has quit IRC | 09:24 | |
bauzas | paul-carlton1: but I'm also leaving a comment asking to amend the docstring of nova.db.api :) | 09:24 |
*** paul-carlton2 has joined #openstack-nova | 09:24 | |
*** shaohe_feng has quit IRC | 09:24 | |
*** palexster has joined #openstack-nova | 09:24 | |
*** shaohe_feng has joined #openstack-nova | 09:24 | |
markus_z | BobBall: I have a XenProject CI build error due to low memory, not sure if this is interesting for you | 09:25 |
*** amotoki has joined #openstack-nova | 09:25 | |
markus_z | BobBall: JFYI, http://logs.openstack.xenproject.org/01/275801/8/check/dsvm-tempest-xen/e51b77d/logs/libvirt/libxl/libxl-driver.txt.gz | 09:26 |
*** cloudnull has joined #openstack-nova | 09:27 | |
*** liusheng has quit IRC | 09:27 | |
*** yassine has joined #openstack-nova | 09:27 | |
*** bapalm has joined #openstack-nova | 09:27 | |
paul-carlton1 | good catch, not seeing your comments in gerrit yet, guess you are still reviewing? | 09:28 |
*** salv-orlando has quit IRC | 09:29 | |
johnthetubaguy | lyarwood: got a slight concern on the master patch, adding a comment. | 09:29 |
markus_z | BobBall: And I can't access the zuul UI at http://zuul.openstack.xenproject.org/ | 09:29 |
*** yuntongjin has quit IRC | 09:30 | |
*** gszasz has joined #openstack-nova | 09:31 | |
markus_z | BobBall: The Xen-CI didn't respond with a voting for this recheck: https://review.openstack.org/#/c/236051/7 That's why I wanted to look in zuul. | 09:31 |
*** Jeffrey4l has quit IRC | 09:31 | |
markus_z | BobBall: only bad news from me, sorry | 09:31 |
*** gongysh has joined #openstack-nova | 09:33 | |
*** hoangcx has quit IRC | 09:33 | |
*** amotoki has quit IRC | 09:34 | |
*** shaohe_feng has quit IRC | 09:34 | |
*** slunkad has quit IRC | 09:34 | |
*** sayalilunkad_lap has joined #openstack-nova | 09:35 | |
*** shaohe_feng has joined #openstack-nova | 09:35 | |
*** thorst_ has joined #openstack-nova | 09:36 | |
*** sridharg has quit IRC | 09:39 | |
*** sridharg has joined #openstack-nova | 09:40 | |
*** amotoki has joined #openstack-nova | 09:43 | |
*** thorst_ has quit IRC | 09:44 | |
*** shaohe_feng has quit IRC | 09:44 | |
*** huanxie has joined #openstack-nova | 09:45 | |
*** shaohe_feng has joined #openstack-nova | 09:45 | |
*** derekh has joined #openstack-nova | 09:46 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Wrap interface_list by proper resource class https://review.openstack.org/290359 | 09:47 |
* johnthetubaguy has bad headache this morning, moving away from compute to try and help it | 09:48 | |
*** amotoki has quit IRC | 09:51 | |
*** e0ne has joined #openstack-nova | 09:51 | |
*** shaohe_feng has quit IRC | 09:54 | |
*** amotoki has joined #openstack-nova | 09:55 | |
*** shaohe_feng has joined #openstack-nova | 09:55 | |
*** amotoki has quit IRC | 09:56 | |
*** sfinucan has joined #openstack-nova | 09:57 | |
*** danpb has joined #openstack-nova | 09:58 | |
*** e0ne has quit IRC | 10:01 | |
*** claudiub|2 has joined #openstack-nova | 10:03 | |
*** e0ne has joined #openstack-nova | 10:04 | |
*** shaohe_feng has quit IRC | 10:05 | |
*** shaohe_feng has joined #openstack-nova | 10:06 | |
*** claudiub has quit IRC | 10:06 | |
*** amotoki has joined #openstack-nova | 10:06 | |
*** gongysh has quit IRC | 10:06 | |
gmann | johnthetubaguy: alex_xu have look this one for attachment API consistency - https://review.openstack.org/#/c/290196/1 | 10:07 |
gmann | as discussed in meeting | 10:08 |
*** lpetrut has joined #openstack-nova | 10:08 | |
*** rk4n has joined #openstack-nova | 10:11 | |
*** lpetrut has quit IRC | 10:13 | |
lyarwood | johnthetubaguy: sorry was on the train, looking now | 10:15 |
*** shaohe_feng has quit IRC | 10:15 | |
*** shaohe_feng has joined #openstack-nova | 10:15 | |
lyarwood | johnthetubaguy: added a comment, thankfully disk.info only applies to imagebackend disks. brb. | 10:17 |
*** daemontool_ is now known as daemontool | 10:19 | |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Improve line continuation https://review.openstack.org/290378 | 10:20 |
*** lpetrut has joined #openstack-nova | 10:20 | |
*** mvk has joined #openstack-nova | 10:21 | |
*** shaohe_feng has quit IRC | 10:25 | |
*** shaohe_feng has joined #openstack-nova | 10:26 | |
openstackgerrit | Moshe Levi proposed openstack/nova: ironic driver: Adding InfiniBand support https://review.openstack.org/266540 | 10:28 |
*** efried has quit IRC | 10:29 | |
*** claudiub|2 has quit IRC | 10:32 | |
*** ekuris_ has quit IRC | 10:33 | |
*** gongysh_ has quit IRC | 10:34 | |
openstackgerrit | Matthew Booth proposed openstack/nova: Don't convert raw disks to qcow2 during resize/migrate https://review.openstack.org/283702 | 10:34 |
*** rk4n has quit IRC | 10:34 | |
*** shaohe_feng has quit IRC | 10:35 | |
*** shaohe_feng has joined #openstack-nova | 10:36 | |
*** mgoddard has quit IRC | 10:37 | |
*** rk4n has joined #openstack-nova | 10:37 | |
bauzas | markus_z: are you planning to monitor every day new bugs coming in the pipe ? | 10:38 |
bauzas | markus_z: I'm beginning to care of regressions noted by ops | 10:38 |
bauzas | and those could possibly miss the RC tag | 10:38 |
*** rk4n has quit IRC | 10:40 | |
*** rk4n has joined #openstack-nova | 10:40 | |
*** mingyu has quit IRC | 10:41 | |
*** roeyc has quit IRC | 10:41 | |
lyarwood | mdbooth: can you take a look at https://review.openstack.org/#/c/281913/ if you have time this morning | 10:41 |
mdbooth | lyarwood: For you, sir, I will look immediately | 10:41 |
*** thorst_ has joined #openstack-nova | 10:42 | |
*** efried has joined #openstack-nova | 10:42 | |
lyarwood | mdbooth: tip of the hat to you sir | 10:43 |
mdbooth | Indubitably | 10:43 |
*** haomaiw__ has quit IRC | 10:45 | |
bauzas | pkoniszewski: just a comment as I'm reviewing https://bugs.launchpad.net/nova/+bug/1552303, please make sure to provide permalinks (using existing SHAs) when giving an URL like https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5554 | 10:45 |
openstack | Launchpad bug 1552303 in OpenStack Compute (nova) "Block live migrations are broken when nova calculates live migration type by itself" [Critical,In progress] - Assigned to Pawel Koniszewski (pawel-koniszewski) | 10:45 |
*** shaohe_feng has quit IRC | 10:46 | |
*** shaohe_feng has joined #openstack-nova | 10:46 | |
markus_z | bauzas: That's what I want to establish with the bug skimming duty but getting volunteers is cumbersome | 10:47 |
*** thorst_ has quit IRC | 10:49 | |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Remove unused variable and redundant code path https://review.openstack.org/290389 | 10:49 |
*** salv-orlando has joined #openstack-nova | 10:51 | |
*** RuiChen has joined #openstack-nova | 10:53 | |
*** cdent has joined #openstack-nova | 10:54 | |
cdent | p!spy | 10:55 |
cdent | p!hist | 10:55 |
*** salv-orlando has quit IRC | 10:56 | |
*** shaohe_feng has quit IRC | 10:56 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary https://review.openstack.org/288373 | 10:56 |
*** shaohe_feng has joined #openstack-nova | 10:57 | |
*** mgoddard has joined #openstack-nova | 10:59 | |
*** purplerbot has quit IRC | 11:00 | |
*** purplerbot has joined #openstack-nova | 11:00 | |
*** CustosLimen has quit IRC | 11:03 | |
*** dedery_ has joined #openstack-nova | 11:04 | |
*** dedery has quit IRC | 11:05 | |
*** efoley_ has quit IRC | 11:06 | |
*** sdague has joined #openstack-nova | 11:06 | |
*** shaohe_feng has quit IRC | 11:06 | |
*** dims has joined #openstack-nova | 11:07 | |
*** shaohe_feng has joined #openstack-nova | 11:07 | |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Line indentation improvements https://review.openstack.org/290395 | 11:07 |
*** ildikov has quit IRC | 11:08 | |
*** CustosLimen has joined #openstack-nova | 11:08 | |
*** dedery_ has quit IRC | 11:08 | |
*** huanxie has quit IRC | 11:09 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Address nits in I83a5f06ad https://review.openstack.org/289342 | 11:12 |
*** shaohe_feng has quit IRC | 11:16 | |
*** doug-fish has joined #openstack-nova | 11:17 | |
*** shaohe_feng has joined #openstack-nova | 11:17 | |
*** danpb has quit IRC | 11:18 | |
*** takedakn has joined #openstack-nova | 11:19 | |
*** danpb has joined #openstack-nova | 11:19 | |
*** efoley_ has joined #openstack-nova | 11:21 | |
*** doug-fish has quit IRC | 11:22 | |
*** PaulMurray has joined #openstack-nova | 11:22 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Wrap interface_list by proper resource class https://review.openstack.org/290359 | 11:24 |
*** Daisy has joined #openstack-nova | 11:25 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: plugins/xenserver: Resolve PEP8 issues https://review.openstack.org/289490 | 11:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova: plugins/xenserver: Add '.py' extension https://review.openstack.org/289431 | 11:25 |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Redundant parentheses removed https://review.openstack.org/290410 | 11:25 |
*** shaohe_feng has quit IRC | 11:27 | |
*** shaohe_feng has joined #openstack-nova | 11:29 | |
*** Daisy has quit IRC | 11:29 | |
*** Daisy has joined #openstack-nova | 11:30 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Rework 'limited' and 'get_limit_and_marker' https://review.openstack.org/241361 | 11:31 |
*** sahid has joined #openstack-nova | 11:31 | |
*** kmartin has quit IRC | 11:33 | |
*** Daisy has quit IRC | 11:34 | |
*** Daisy has joined #openstack-nova | 11:34 | |
*** ociuhandu has quit IRC | 11:35 | |
*** roeyc has joined #openstack-nova | 11:37 | |
*** shaohe_feng has quit IRC | 11:37 | |
*** shaohe_feng has joined #openstack-nova | 11:38 | |
*** omnipresent has quit IRC | 11:39 | |
*** dedery has joined #openstack-nova | 11:39 | |
*** zenoway has joined #openstack-nova | 11:40 | |
*** Daisy has quit IRC | 11:41 | |
*** Daisy has joined #openstack-nova | 11:41 | |
openstackgerrit | Feng Xi Yan proposed openstack/nova: <VMWare> Attach/detach more than one SCSI LUN https://review.openstack.org/287055 | 11:43 |
*** zenoway has quit IRC | 11:44 | |
*** dedery has quit IRC | 11:44 | |
mdbooth | lyarwood: Eesh, that libvirt driver cleanup code is horrendously fragile | 11:44 |
mdbooth | It's a nat's whisker away from deleting disks which are in use | 11:45 |
mdbooth | Unfortunately, I think your patch might just push it over | 11:45 |
*** delatte has quit IRC | 11:45 | |
*** Daisy has quit IRC | 11:46 | |
*** thorst_ has joined #openstack-nova | 11:47 | |
*** shaohe_feng has quit IRC | 11:47 | |
openstackgerrit | Chris Dent proposed openstack/nova: Remove an unused method in FakeResourceTracker https://review.openstack.org/290076 | 11:48 |
*** shaohe_feng has joined #openstack-nova | 11:48 | |
*** links has joined #openstack-nova | 11:48 | |
openstackgerrit | Feng Xi Yan proposed openstack/nova: <VMWare> Allocate free bus for new SCSI controller. https://review.openstack.org/272414 | 11:49 |
lyarwood | mdbooth: hmmm, care to comment on the change and I'll follow up after lunch? | 11:50 |
*** mpavone has quit IRC | 11:50 | |
*** mpavone has joined #openstack-nova | 11:51 | |
mdbooth | lyarwood: Reviewed | 11:51 |
pkoniszewski | bauzas: sure, thanks, will use that next time | 11:51 |
lyarwood | mdbooth: thanks | 11:52 |
*** zenoway has joined #openstack-nova | 11:52 | |
*** takedakn has quit IRC | 11:53 | |
*** takedakn has joined #openstack-nova | 11:53 | |
*** thorst_ has quit IRC | 11:53 | |
*** efoley__ has joined #openstack-nova | 11:53 | |
*** efried has quit IRC | 11:54 | |
openstackgerrit | Feng Xi Yan proposed openstack/nova: <VMWARE> Add power state cache in compute manager https://review.openstack.org/242006 | 11:55 |
*** RuiChen has quit IRC | 11:57 | |
*** efried has joined #openstack-nova | 11:57 | |
openstackgerrit | Feng Xi Yan proposed openstack/nova: <VMWare> Allocate free bus for new SCSI controller https://review.openstack.org/272414 | 11:57 |
*** RuiChen has joined #openstack-nova | 11:57 | |
*** efoley_ has quit IRC | 11:57 | |
*** shaohe_feng has quit IRC | 11:57 | |
*** shaohe_feng has joined #openstack-nova | 11:59 | |
*** jaosorior has quit IRC | 12:02 | |
*** jaosorior has joined #openstack-nova | 12:02 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Wrap interface_list by proper resource class https://review.openstack.org/290359 | 12:03 |
*** smatzek has joined #openstack-nova | 12:04 | |
*** ildikov has joined #openstack-nova | 12:04 | |
*** rfolco has joined #openstack-nova | 12:04 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/nova: Fix config generation for Neutron auth options https://review.openstack.org/288513 | 12:05 |
cdent | why are deprecation warnings being spewed in the gate by the python34 tests but not python27? | 12:06 |
*** salv-orlando has joined #openstack-nova | 12:06 | |
*** aysyd has joined #openstack-nova | 12:06 | |
*** moshele has quit IRC | 12:07 | |
*** shaohe_feng has quit IRC | 12:08 | |
*** shaohe_feng has joined #openstack-nova | 12:09 | |
*** dedery has joined #openstack-nova | 12:10 | |
*** ekuris_ has joined #openstack-nova | 12:10 | |
*** amotoki has quit IRC | 12:10 | |
sdague | cdent: example? | 12:10 |
openstackgerrit | Sean Dague proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods https://review.openstack.org/290134 | 12:10 |
mdbooth | lyarwood: If you'd care to return the favour: https://review.openstack.org/#/c/283702/ :) | 12:12 |
*** atuvenie_ has joined #openstack-nova | 12:15 | |
*** atuvenie has joined #openstack-nova | 12:15 | |
*** EinstCrazy has joined #openstack-nova | 12:15 | |
*** atuvenie has quit IRC | 12:15 | |
*** claudiub has joined #openstack-nova | 12:16 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: Missing info_cache.save() in db sqlalchemy api https://review.openstack.org/289967 | 12:17 |
cdent | sdague: https://jenkins03.openstack.org/job/gate-nova-python34/5099/console | 12:17 |
*** shaohe_feng has quit IRC | 12:18 | |
cdent | sdague: I don't thinik that pkg_resource problem is showing up in 2.7 either | 12:18 |
*** shaohe_feng has joined #openstack-nova | 12:19 | |
cdent | bauzas, johnthetubaguy: I think I found a reasonable way to test https://review.openstack.org/#/c/289544/ so that's good to go now. | 12:20 |
*** mvk has quit IRC | 12:20 | |
*** ociuhandu has joined #openstack-nova | 12:20 | |
*** lucasagomes is now known as lucas-hungry | 12:21 | |
*** baoli has joined #openstack-nova | 12:22 | |
*** daemontool_ has joined #openstack-nova | 12:23 | |
*** amotoki has joined #openstack-nova | 12:24 | |
*** nelsnels_ has joined #openstack-nova | 12:24 | |
*** omnipresent has joined #openstack-nova | 12:24 | |
*** diana_clarke2 has joined #openstack-nova | 12:24 | |
*** Marga__ has joined #openstack-nova | 12:24 | |
openstackgerrit | Chris Dent proposed openstack/nova: Insure resource tracker updated for deleted instances https://review.openstack.org/289544 | 12:25 |
*** Kevin_Zheng_ has joined #openstack-nova | 12:25 | |
*** irenab_ has joined #openstack-nova | 12:25 | |
*** MCoLo__ has joined #openstack-nova | 12:26 | |
*** irenab has quit IRC | 12:26 | |
*** irenab_ is now known as irenab | 12:26 | |
*** lpetrut1 has joined #openstack-nova | 12:26 | |
*** baoli has quit IRC | 12:26 | |
*** Kevin_Zheng has quit IRC | 12:27 | |
*** Kevin_Zheng_ is now known as Kevin_Zheng | 12:27 | |
*** diana_clarke1 has quit IRC | 12:27 | |
*** lpetrut has quit IRC | 12:27 | |
*** greghaynes has quit IRC | 12:27 | |
*** zenoway has quit IRC | 12:27 | |
*** dguitarbite has quit IRC | 12:27 | |
*** nkrinner has quit IRC | 12:27 | |
*** Marga_ has quit IRC | 12:27 | |
*** nelsnelson has quit IRC | 12:27 | |
*** pkholkin_ has quit IRC | 12:27 | |
*** MCoLo___ has quit IRC | 12:27 | |
*** lpetrut1 is now known as lpetrut | 12:27 | |
*** pkholkin__ has joined #openstack-nova | 12:27 | |
*** jaosorior has quit IRC | 12:27 | |
*** bapalm has quit IRC | 12:27 | |
*** daemontool has quit IRC | 12:27 | |
*** alaski has quit IRC | 12:27 | |
*** jaosorior has joined #openstack-nova | 12:27 | |
*** takedakn has quit IRC | 12:27 | |
*** bapalm has joined #openstack-nova | 12:27 | |
*** shaohe_feng has quit IRC | 12:28 | |
sdague | cdent: no, it's in the py27 stuff as well | 12:28 |
*** shaohe_feng has joined #openstack-nova | 12:29 | |
cdent | sdague: that's what I get for trying to do 20 things at once | 12:29 |
*** mjura has quit IRC | 12:29 | |
sdague | it's been there forever | 12:29 |
*** daemontool_ is now known as daemontool | 12:29 | |
sdague | I think it's a deep pbr thing | 12:29 |
*** amotoki has quit IRC | 12:29 | |
*** doug-fish has joined #openstack-nova | 12:31 | |
*** alaski has joined #openstack-nova | 12:31 | |
*** Daisy has joined #openstack-nova | 12:31 | |
*** cdelatte has joined #openstack-nova | 12:32 | |
cdent | oh pbr, that thing which does lots of magic that we can't see? | 12:32 |
* cdent grinds teeth and axe | 12:32 | |
* cdent relaxes | 12:33 | |
cdent | I read a headline earlier today that said that venting doesn't make anything better, in fact often makes it worse. | 12:33 |
cdent | Probably should have read the article. | 12:33 |
sdague | heh | 12:36 |
openstackgerrit | jichenjc proposed openstack/python-novaclient: Prepare to move extension into core plugin https://review.openstack.org/290448 | 12:36 |
sdague | or burn it | 12:36 |
*** rodrigods has quit IRC | 12:37 | |
*** rodrigods has joined #openstack-nova | 12:37 | |
sdague | cdent: also, why the heck is that osapifixture taking 16 minutes? | 12:38 |
*** Jeffrey4l has joined #openstack-nova | 12:38 | |
*** shaohe_feng has quit IRC | 12:38 | |
*** Daisy has quit IRC | 12:39 | |
cdent | sdague: you talking about on py34 or both? I've noticed the py34 job is taking a good deal more time. | 12:39 |
*** Daisy has joined #openstack-nova | 12:39 | |
*** shaohe_feng has joined #openstack-nova | 12:39 | |
*** thorst_ has joined #openstack-nova | 12:39 | |
sdague | on py27 | 12:39 |
sdague | sorry | 12:39 |
sdague | py34 | 12:39 |
sdague | muscle memory | 12:40 |
sdague | that test run | 12:40 |
sdague | I noticed the slow test list at the end | 12:40 |
*** nkrinner has joined #openstack-nova | 12:40 | |
sdague | oh, so I blamed pbr incorrectly | 12:40 |
sdague | it's oslo.versionutils | 12:40 |
*** greghaynes has joined #openstack-nova | 12:40 | |
*** Daisy has quit IRC | 12:41 | |
*** Daisy has joined #openstack-nova | 12:41 | |
*** dguitarbite has joined #openstack-nova | 12:41 | |
sdague | or, maybe it's both, pkg_resource defines it's warnings so badly it's hard to figure out | 12:42 |
*** mjura has joined #openstack-nova | 12:44 | |
cdent | edleafe: Is the bug still live? https://bugs.launchpad.net/nova/+bug/1369818 It looks like the latest patch on it was from you and it merged but things are still up in the air. What's still missing? | 12:44 |
openstack | Launchpad bug 1369818 in OpenStack Compute (nova) "Nova show will not display NoValidHost with right exception traces" [Medium,Confirmed] | 12:44 |
*** baoli has joined #openstack-nova | 12:46 | |
*** Daisy has quit IRC | 12:47 | |
*** Daisy has joined #openstack-nova | 12:48 | |
*** doug-fish has quit IRC | 12:48 | |
*** shaohe_feng has quit IRC | 12:49 | |
*** shaohe_feng has joined #openstack-nova | 12:49 | |
*** thumpba has joined #openstack-nova | 12:50 | |
*** deepakcs has quit IRC | 12:51 | |
*** mvk has joined #openstack-nova | 12:51 | |
*** Daisy has quit IRC | 12:53 | |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Improve line continuation https://review.openstack.org/290378 | 12:53 |
*** baoli_ has joined #openstack-nova | 12:53 | |
*** ekuris_ has quit IRC | 12:54 | |
lyarwood | mdbooth: yup, I'll take a look now | 12:56 |
*** baoli has quit IRC | 12:56 | |
jaypipes | *yawns* | 12:57 |
jaypipes | morooning folks | 12:57 |
ndipanov | sdague, wanna enlighten me on "all kinds of things" we're talking about here? https://review.openstack.org/#/c/289477/ | 12:59 |
*** shaohe_feng has quit IRC | 12:59 | |
sdague | ndipanov: tox -e docs | 12:59 |
ndipanov | sdague, yeah that's one | 13:00 |
sdague | tox -r -e docs | 13:00 |
*** shaohe_feng has joined #openstack-nova | 13:00 | |
sdague | and, the point is, the docs tree is stack | 13:00 |
sdague | that's the actual point of the samples framework, there are templates that are dynamic, which are cross checked with static files that publish to the documentation | 13:00 |
ndipanov | sdague, sure but this is a super straightforward substitution that is surely a net win | 13:01 |
sdague | if it's a huge burden that this value keeps incrementing on the documentation, perhaps it shouldn't be in the payload then. | 13:02 |
ndipanov | sdague, well desinging payloads around documentation is not something we wanna do I think | 13:02 |
*** krtaylor has quit IRC | 13:02 | |
ndipanov | I don't know | 13:02 |
ndipanov | but seems silly to have to do this by hand every time... | 13:03 |
sdague | ndipanov: we usually want to design payloads around documentation, because the point of them is they are consumed by humans, via docs | 13:03 |
johnthetubaguy | so the service version is interesting during an upgrade, notification wise | 13:04 |
ndipanov | johnthetubaguy, it's generally useful I guess, and ultimately I don't think it's a massive burden for now to flip it | 13:04 |
johnthetubaguy | is there a different way here, like mocking the service version in that test? | 13:05 |
ndipanov | although rebases can get annoying during certain times of year | 13:05 |
*** dims has quit IRC | 13:05 | |
*** dims_ has joined #openstack-nova | 13:05 | |
ndipanov | johnthetubaguy, that could work maybe... | 13:05 |
sdague | johnthetubaguy: you could not do the samples model | 13:05 |
sdague | the issue here is that this is the samples model which is there is dynamic / template / and the published documentation (static) | 13:06 |
sdague | and you cross check all 3 so that you know you have valid code, and valid docs you are giving to the user | 13:06 |
ndipanov | sdague, so how do we break that if we generate docs from code? | 13:06 |
*** atuvenie_ has quit IRC | 13:07 | |
ndipanov | it seems like the doc here is used to test the code which is backwards I think | 13:07 |
ndipanov | anyway I don't think it's worth arguing about | 13:07 |
sdague | ndipanov: if you come up with another path to provide docs to the end user, that's cool. But using this model you kind of want that safety check | 13:08 |
sdague | otherwise you can basically overmock yourself and not be testing anything | 13:08 |
*** markvoelker_ has joined #openstack-nova | 13:08 | |
*** shaohe_feng has quit IRC | 13:09 | |
*** shaohe_feng has joined #openstack-nova | 13:10 | |
ndipanov | sdague, so how come it didn't fail on the original patch? | 13:10 |
*** edmondsw has joined #openstack-nova | 13:10 | |
*** dims_ has quit IRC | 13:10 | |
sdague | ndipanov: I don't know, I didn't do the full postmortem. | 13:10 |
sdague | but the root cause was pretty clear from the bug at hand | 13:11 |
openstackgerrit | Feng Xi Yan proposed openstack/nova: <VMWare> Attach/detach more than one SCSI LUN https://review.openstack.org/287055 | 13:11 |
*** markvoelker has quit IRC | 13:11 | |
ndipanov | sdague, so we would want to run the same code that generates temporary samples for docs and for func tests from common templates I think - would that make sense to you sdague ? | 13:12 |
*** ducttape_ has joined #openstack-nova | 13:12 | |
sdague | ndipanov: we specifically talked that through in Bristol and said no, lets build this as parallel, because of the complexity in differences here. | 13:13 |
*** dims has joined #openstack-nova | 13:14 | |
*** jaosorior has quit IRC | 13:15 | |
*** jaosorior has joined #openstack-nova | 13:15 | |
sdague | like I said, if you want a different model here not using the docs/ tree that's cool. But stuff in docs/ really needs to be static. | 13:16 |
ndipanov | sdague, ok - I don't think it's a huge overhead for now so let's leave it at that | 13:17 |
*** shaohe_feng has quit IRC | 13:19 | |
*** shaohe_feng has joined #openstack-nova | 13:20 | |
*** markvoelker_ has quit IRC | 13:20 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Address nits in I83a5f06ad https://review.openstack.org/289342 | 13:21 |
*** efried has quit IRC | 13:22 | |
*** dave-mccowan has joined #openstack-nova | 13:22 | |
*** ducttape_ has quit IRC | 13:27 | |
*** scheuran has quit IRC | 13:28 | |
*** lucas-hungry is now known as lucasagomes | 13:28 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: trivial: remove unused argument from a method https://review.openstack.org/286743 | 13:29 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: libvirt: Refactor _update_xml https://review.openstack.org/286742 | 13:29 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: live-mig: Add claims and proper resource tracking https://review.openstack.org/244489 | 13:29 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: libvirt: live-migrate updates NUMA and cpus in the XML https://review.openstack.org/286744 | 13:29 |
*** doug-fish has joined #openstack-nova | 13:29 | |
*** shaohe_feng has quit IRC | 13:30 | |
*** shaohe_feng has joined #openstack-nova | 13:31 | |
*** doug-fish has quit IRC | 13:31 | |
*** doug-fish has joined #openstack-nova | 13:32 | |
ndipanov | johnthetubaguy, https://review.openstack.org/#/c/281803/ is it too late for this? | 13:32 |
ndipanov | I would assume no... | 13:32 |
cdent | sorry ndipanov totally disagree with you on the bug thing, so left another coment on https://bugs.launchpad.net/nova/+bug/1427772 | 13:32 |
openstack | Launchpad bug 1427772 in OpenStack Compute (nova) "Instance that uses force-host still needs to run some filters" [Low,Confirmed] - Assigned to Anant Kaushik (anantkaushik-nsit) | 13:32 |
johnthetubaguy | ndipanov: reno stuff is cool, I think bauzas is tracking a bunch of them that got missed one way or the other | 13:33 |
bauzas | yeah I'm on it | 13:33 |
johnthetubaguy | ndipanov: frankly I want to block the tag on getting all release notes in | 13:33 |
bauzas | currently doing reviews but also checking some notes we missed | 13:34 |
ndipanov | bauzas, ok that one we missed as well | 13:34 |
johnthetubaguy | bauzas: ack, appreciate you digging into those | 13:34 |
bauzas | ndipanov: I +1d the above because I thought of a prelude section, but lemme +W it | 13:35 |
ndipanov | cdent, well I agree with the sentiment - but this is not an opinion that does not have replication strategy - it's known to be broken | 13:35 |
*** links has quit IRC | 13:35 | |
*** efried has joined #openstack-nova | 13:36 | |
cdent | but the bug isn't really a bug. if someone wants to make it into a bug, then fine it can live and then people can do something with it. but right now it's just noise | 13:36 |
ndipanov | this shouldn't discourage you - I mean - it's down to what we want to use the bugtracker for | 13:36 |
ndipanov | if we want it as a gamified get s*it done list - then yeah this is a backlog spec | 13:37 |
ndipanov | or something | 13:37 |
ndipanov | no it is totally a bug | 13:37 |
ndipanov | it breaks all sorts of things | 13:37 |
cdent | I don't dispute that it breaks all sorts of things. | 13:38 |
cdent | I guess I just really take issue with things living so long in the tracker | 13:38 |
ndipanov | cdent, I don't think there's a clear rule - it's up to us what we do with the bug tracker | 13:38 |
*** rtheis has joined #openstack-nova | 13:39 | |
*** markvoelker has joined #openstack-nova | 13:39 | |
ndipanov | so if you don't want this to live on as a bug - close it. There's an email thread so ppl can dig through the archives... there;s definitely artifacts to be found | 13:39 |
*** shaohe_feng has quit IRC | 13:40 | |
*** shaohe_feng has joined #openstack-nova | 13:41 | |
sdague | I cleaned up mriedem's VirtNotImplemented patch to pass nearly all the test. But there is one real issue that got exposed with objects when that happened (which is a win) - http://logs.openstack.org/34/290134/2/check/gate-nova-python27/77c9d8e/console.html | 13:41 |
*** pkarikh has quit IRC | 13:41 | |
*** rk4n has quit IRC | 13:41 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Fix outdated parameter network_info description in virt/driver https://review.openstack.org/263166 | 13:41 |
sdague | anyone more familiar with objects want to take a look | 13:41 |
sdague | it's failure to load a disk_format attr | 13:42 |
sdague | http://logs.openstack.org/34/290134/2/check/gate-nova-python27/77c9d8e/console.html#_2016-03-09_12_24_48_102 | 13:42 |
ndipanov | sdague, it's highly likely just a bad mock | 13:42 |
sdague | ndipanov: it might be | 13:42 |
sdague | but I didn't want to just flip mocks around to make things pass and mask something else | 13:43 |
sdague | so would rather have someone be sure about the right way to address this | 13:43 |
openstackgerrit | Gábor Antal proposed openstack/nova: Added appender methods to remove clones from config.py https://review.openstack.org/232145 | 13:43 |
mdbooth | lyarwood: Did my comments on the shared instance storage patch make sense, btw? | 13:47 |
*** rlrossit has joined #openstack-nova | 13:48 | |
lyarwood | mdbooth: just about to switch to that now | 13:48 |
mdbooth | lyarwood: It's a bit convoluted, but in essence I think you changed it from broken but fail safe, to broken but fail <delete all user's stuff> | 13:49 |
lyarwood | mdbooth: well that obviously not what I wanted to do ;) | 13:50 |
lyarwood | that's* | 13:50 |
*** shaohe_feng has quit IRC | 13:50 | |
*** shaohe_feng has joined #openstack-nova | 13:51 | |
*** amotoki has joined #openstack-nova | 13:54 | |
ndipanov | sdague, well those tests only use the unit/image/fake.py stuff so if they fail now it's due to that - the patch does not seem to be touching any of the stuff involved | 13:54 |
*** akshai has joined #openstack-nova | 13:55 | |
*** claudiub has quit IRC | 13:55 | |
*** salv-orlando has quit IRC | 13:55 | |
*** pwnall has joined #openstack-nova | 13:55 | |
openstackgerrit | Zhengguang Ou proposed openstack/nova: libvirt: fix detach volume race condition https://review.openstack.org/290510 | 13:56 |
ndipanov | sdague,disk_format is always set afaict since we make sure of that so I think it's safe to fix the mocks | 13:57 |
openstackgerrit | Paul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary https://review.openstack.org/288373 | 13:57 |
sdague | ndipanov: so the issue is just that we do this - https://github.com/openstack/nova/blob/3d7e403cc7a5d9ebcd9a011d6c2055bfbf56cb05/nova/tests/unit/virt/test_virt_drivers.py#L301 and don't specify the required elements? | 13:58 |
*** huanxie has joined #openstack-nova | 13:58 | |
*** markvoelker has quit IRC | 13:58 | |
johnthetubaguy | sdague: hmm, that smells like a smoking gun, I will can take a quick look | 13:59 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add a functional test for instance fault message with retry https://review.openstack.org/244046 | 14:00 |
edleafe | cdent: not sure about that bug. I added several things to improve visibility into host selection failures, but never heard back if that sufficed. | 14:00 |
*** shaohe_feng has quit IRC | 14:00 | |
cdent | edleafe: that seems to be the problem with many of the bugs: people looking to somewhere/someone/something for "is this right?" | 14:01 |
ndipanov | sdague, well it's either mocks or we are not guarding against it properly when creating ImageMeta objects | 14:01 |
*** shaohe_feng has joined #openstack-nova | 14:01 | |
ndipanov | sdague, and it seems to me that we are doing that | 14:01 |
ndipanov | according to the glance schema | 14:02 |
ndipanov | so it's really just mocks left | 14:02 |
edleafe | cdent: yeah, I would mark that as fix released, as it went out in liberty | 14:02 |
edleafe | cdent: they can always file another with more specifics | 14:02 |
*** vladikr has joined #openstack-nova | 14:03 | |
sdague | well, it's our image create, it only adds the attributes we tell it to | 14:03 |
sdague | then when that attempts to get objectified some point later, it's super partial | 14:03 |
sdague | and explodes | 14:03 |
*** daemontool_ has joined #openstack-nova | 14:03 | |
johnthetubaguy | sdague: feels like partially filled out object causing issues | 14:03 |
sdague | unfortunately the explode was similar to a kind we were catching, so we never noticed it wasn't testing what we thought | 14:04 |
johnthetubaguy | yeah, seems like a good catch in the change | 14:04 |
ndipanov | sdague, right - but that never happens in the real glance interaction afaict so this is really a case of just fixing the mocks | 14:04 |
ndipanov | yeah that change is quite good | 14:04 |
johnthetubaguy | certainly the test was passing for the wrong reason before | 14:04 |
sdague | right | 14:04 |
johnthetubaguy | like you say, adding disk_format into https://github.com/openstack/nova/blob/3d7e403cc7a5d9ebcd9a011d6c2055bfbf56cb05/nova/tests/unit/virt/test_virt_drivers.py#L301 might help | 14:05 |
ndipanov | sdague, johnthetubaguy well the fake image has plenty of images | 14:05 |
ndipanov | why not just use those or add a snapshot there (we might be missing some more attrs) | 14:06 |
johnthetubaguy | sure, using a correct image would fit it, seems to be whats needed here | 14:06 |
ndipanov | instead of doing that create() - just reuse one of the existing ones in nova/unit/image/fake.py | 14:06 |
johnthetubaguy | like sdague was sayings, looks like https://github.com/openstack/nova/blob/3d7e403cc7a5d9ebcd9a011d6c2055bfbf56cb05/nova/tests/unit/virt/test_virt_drivers.py#L301 is not enough to make the test pass | 14:06 |
*** daemontool has quit IRC | 14:07 | |
*** salv-orlando has joined #openstack-nova | 14:07 | |
johnthetubaguy | it feels like the objects could do with a better exception for this case for "field not defined" or something like that | 14:07 |
johnthetubaguy | but thats probably a distraction | 14:08 |
*** gjayavelu has joined #openstack-nova | 14:08 | |
*** jaugustine has joined #openstack-nova | 14:09 | |
ndipanov | johnthetubaguy, that's a api breaking change in ovo I would think | 14:09 |
sdague | ok, I'll look at making create be a bit more of a thing | 14:09 |
ndipanov | sdague, that was what I was thinking too | 14:10 |
*** jwcroppe has quit IRC | 14:10 | |
*** shaohe_feng has quit IRC | 14:11 | |
johnthetubaguy | ndipanov: it could be yes, I would settle for a better named subclass | 14:11 |
*** shaohe_feng has joined #openstack-nova | 14:12 | |
openstackgerrit | Zhengguang Ou proposed openstack/nova: libvirt: fix detach volume race condition https://review.openstack.org/290510 | 14:12 |
*** dstepanenko has joined #openstack-nova | 14:12 | |
*** ducttape_ has joined #openstack-nova | 14:12 | |
*** gjayavelu has quit IRC | 14:12 | |
sdague | ok, fix local, just rerunning all the tests | 14:12 |
*** rk4n has joined #openstack-nova | 14:13 | |
sdague | fake image is used so many places behavior change might have fallout | 14:13 |
*** ekuris_ has joined #openstack-nova | 14:13 | |
*** mdrabe has joined #openstack-nova | 14:13 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Remove block_migration from virt drivers https://review.openstack.org/290519 | 14:14 |
*** salv-orlando has quit IRC | 14:14 | |
*** gongysh has joined #openstack-nova | 14:14 | |
*** pkarikh has joined #openstack-nova | 14:16 | |
*** fifieldt has quit IRC | 14:16 | |
*** nelsnelson has joined #openstack-nova | 14:17 | |
*** nelsnels_ has quit IRC | 14:18 | |
*** mriedem has joined #openstack-nova | 14:19 | |
*** mtanino has quit IRC | 14:19 | |
*** gongysh has quit IRC | 14:20 | |
*** Drankis has joined #openstack-nova | 14:20 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add Forbidden to caught cinder exceptions https://review.openstack.org/290523 | 14:20 |
*** shaohe_feng has quit IRC | 14:21 | |
*** xyang1 has joined #openstack-nova | 14:21 | |
*** jichen has quit IRC | 14:22 | |
*** shaohe_feng has joined #openstack-nova | 14:22 | |
openstackgerrit | Sean Dague proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods https://review.openstack.org/290134 | 14:22 |
sdague | mriedem: I think ^^^ is right now | 14:23 |
sdague | I pounded through the unit tests this morning | 14:23 |
mriedem | sdague: geez i guess | 14:23 |
sdague | mriedem: well, it seems like a good change, so I wanted to help move it forward | 14:23 |
mriedem | i see an issue | 14:25 |
*** rfolco has quit IRC | 14:25 | |
*** gongysh has joined #openstack-nova | 14:25 | |
bauzas | pkoniszewski: trying to load more context of https://review.openstack.org/#/c/287363/ , the RCA is that block_migration is set to None by the API in case it's 'auto', right ? | 14:25 |
bauzas | pkoniszewski: so since we then calculate correctly the migrate_data object in the driver, you propose to use it instead of that *after* the source and dest calls are done, right? | 14:26 |
bauzas | and then abandon block_migration | 14:27 |
mriedem | sdague: what's with the fake image stuff in https://review.openstack.org/#/c/290134/3/nova/tests/unit/image/fake.py ? | 14:27 |
*** rfolco has joined #openstack-nova | 14:28 | |
sdague | mriedem: see the test results for PS2 | 14:28 |
sdague | http://logs.openstack.org/34/290134/2/check/gate-nova-python27/77c9d8e/ | 14:28 |
pkoniszewski | bauzas: exactly, having block_migration value under two different variables is not the good way to go | 14:29 |
pkoniszewski | bauzas: since migrate data is objectifyed we can cleanup this mess | 14:29 |
mriedem | sdague: oh it found a bug? | 14:29 |
sdague | we were hitting a NotImplemented because of disk_format check on objs | 14:29 |
mriedem | nice | 14:29 |
sdague | well, we definitely caught an issue with us passing a test for the wrong reasons | 14:29 |
sdague | mriedem: also, interesting, that 0 tests caught the issue you found in review | 14:30 |
mriedem | sdague: yeah, because the compute manager and rest api tests stub each other out | 14:30 |
mriedem | so, not surprising | 14:30 |
bauzas | pkoniszewski: I'm just not super happy with https://review.openstack.org/#/c/287363/6/nova/compute/manager.py@5367 | 14:31 |
*** shaohe_feng has quit IRC | 14:31 | |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Fix wrong watermark state during live migration https://review.openstack.org/279616 | 14:31 |
bauzas | pkoniszewski: how can you infer that other drivers are using shared_storage and consequently *not* needing to do clean-ups ? | 14:31 |
openstackgerrit | Chris Dent proposed openstack/nova: Make force_ and ignore_hosts comparisons case insensitive https://review.openstack.org/290532 | 14:32 |
sdague | we should probably just ban the use of NotImplementedError in the code overall, given that we can't distinguish who didn't implement what | 14:32 |
sdague | it could be a freaking db driver throwing it for all we know | 14:32 |
*** shaohe_feng has joined #openstack-nova | 14:32 | |
sdague | mriedem: ok, I'll fix that up | 14:32 |
pkoniszewski | bauzas: only libvirt and xenapi support block live migrations, we never call cleanups for other drivers | 14:32 |
*** jwcroppe has joined #openstack-nova | 14:32 | |
bauzas | that, I know | 14:32 |
pkoniszewski | bauzas: even that hyperv implements rollback_at_destination, we never used it yet | 14:32 |
bauzas | pkoniszewski: I'm just saying | 14:33 |
pkoniszewski | bauzas: tbh im not happy with that too, it should go to driver layer and be maintained per driver over there | 14:33 |
mriedem | sdague: ok, there are some other comments in there, mostly minor | 14:33 |
ndipanov | jaypipes, you will love this patch that I have that did not break any tests lol :) | 14:33 |
mriedem | sdague: like there are 2 layers of vmware api stuff just to raise what the base Compute Driver does | 14:33 |
jaypipes | ndipanov: :) | 14:33 |
mriedem | we could just remove the redundancy | 14:33 |
sdague | mriedem: ok, I'll try to polish this off | 14:34 |
bauzas | pkoniszewski: see the original stuff, we're still using the block_migration flag to know whether it's a block migration and consequently do the cleanup or not | 14:34 |
bauzas | pkoniszewski: if we don't have the 'auto' value, it's understandable that it should work for other drivers too | 14:34 |
*** ducttape_ has quit IRC | 14:34 | |
pkoniszewski | yeah, but by default block_migration is False, so it gives the same result | 14:34 |
bauzas | I agree | 14:34 |
bauzas | so | 14:34 |
sdague | mriedem: if we are removing - https://review.openstack.org/#/c/290134/3/nova/virt/vmwareapi/driver.py | 14:34 |
sdague | are we also going to remove the vmops of those? | 14:35 |
bauzas | pkoniszewski: oh I see your point | 14:35 |
*** haukebruno has quit IRC | 14:35 | |
*** gongysh has quit IRC | 14:35 | |
pkoniszewski | (None and False will give the same result there) | 14:35 |
*** artom has joined #openstack-nova | 14:35 | |
mriedem | sdague: i think we should | 14:35 |
bauzas | pkoniszewski: if it wasn't a block migration, it was so set to False, so it was always True for other drivers | 14:35 |
mriedem | sdague: er, i don't see any reason in keeping both | 14:36 |
mriedem | the driver and vmops raising NotImplementedError | 14:36 |
bauzas | pkoniszewski: so that's necessarly a shared storage | 14:36 |
bauzas | I see | 14:36 |
pkoniszewski | bauzas: that's right | 14:36 |
sdague | mriedem: sure, that's fine | 14:37 |
lyarwood | mriedem: morning, not sure if you've seen https://review.openstack.org/#/q/topic:bug/1548450 in the stable/{liberty,kilo} queue this morning for OSSA 2016-007, hopefully a trivial ack if you have time to check. | 14:37 |
sdague | lets see how many other unit tests to fix now :) | 14:37 |
*** cleong has joined #openstack-nova | 14:37 | |
markus_z | sfinucan: FYI: https://etherpad.openstack.org/p/libvirt-latest-test-job If I remember correctly you wanted to see how this works, right? | 14:37 |
sfinucan | markus_z: Ooh, yes please | 14:37 |
markus_z | sfinucan: The gerrit patch has the needed changes. | 14:38 |
sfinucan | markus_z: Sweet. I'll get on it | 14:38 |
markus_z | sfinucan: There is also this blog entry which gives a bit background: http://abregman.com/2016/03/05/openstack-infra-jenkins-jobs/ | 14:39 |
*** jwcroppe has quit IRC | 14:40 | |
*** erno has quit IRC | 14:41 | |
markus_z | Hopefully I can get it merged and running until the summit, then we can chat about it. | 14:41 |
*** shaohe_feng has quit IRC | 14:41 | |
*** cfriesen_ has joined #openstack-nova | 14:42 | |
*** ducttape_ has joined #openstack-nova | 14:42 | |
sfinucan | markus_z: Yes, hopefully | 14:42 |
sfinucan | and thanks for the blog link. I know a few folks who'll enjoy that | 14:42 |
*** shaohe_feng has joined #openstack-nova | 14:42 | |
*** Daisy has joined #openstack-nova | 14:43 | |
lpetrut | pkoniszewski bauzas : for the record, Hyper-V supports live block migration as well :) | 14:44 |
*** gongysh has joined #openstack-nova | 14:44 | |
pkoniszewski | lpetrut: is this supported by openstack? | 14:44 |
lpetrut | yep, since Grizzly, I think | 14:44 |
*** smatzek has quit IRC | 14:44 | |
pkoniszewski | lpetrut: i went through drivers and block_migration argument is not used anywhere | 14:44 |
pkoniszewski | lpetrut: is that something that is decided by hypervisor? | 14:45 |
pkoniszewski | i mean, it isn't used in hyperv drivers | 14:45 |
*** burt has joined #openstack-nova | 14:45 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: Live migration failure in API leaves VM in MIGRATING state https://review.openstack.org/168916 | 14:45 |
lpetrut | we just did not use that argument, Hyper-V will always move the instance local disks when an instance is migrated. I guess that's what you use the 'block migration' flag, right? | 14:46 |
pkoniszewski | lpetrut: for xen and libvirt, yes | 14:46 |
pkoniszewski | lpetrut: so still we don't have to care about value of block_migration argument when hyperv is used under-the-hood, do we ? | 14:47 |
sdague | hmmm... it's not just a create fix | 14:47 |
lpetrut | nope, while I think that we had issues because the rollback was not performed because of this flag | 14:47 |
*** knikolla has joined #openstack-nova | 14:47 | |
*** markvoelker has joined #openstack-nova | 14:48 | |
*** igornsa_ has joined #openstack-nova | 14:48 | |
*** haomaiwang has joined #openstack-nova | 14:49 | |
*** ivase has joined #openstack-nova | 14:49 | |
lpetrut | but as far as I remember, there was a patch that was moving this logic to the driver side (deciding if a block migration is performed) | 14:49 |
pkoniszewski | lpetrut: it was confusing to me when i found that we never performed rollback for hyperv, and all because of block_migration flag | 14:49 |
pkoniszewski | lpetrut: yes, it is up for review | 14:50 |
pkoniszewski | lpetrut: but it also might be worth to add 'block_migration' to hyperv object | 14:50 |
*** Daisy has quit IRC | 14:51 | |
*** shaohe_feng has quit IRC | 14:52 | |
*** mriedem is now known as mriedem_meeting | 14:52 | |
*** shaohe_feng has joined #openstack-nova | 14:52 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Translate OverLimit exceptions in Cinder calls https://review.openstack.org/290550 | 14:52 |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova: Set personality/injected_files to empty list if not specified https://review.openstack.org/248662 | 14:53 |
*** bnemec has joined #openstack-nova | 14:53 | |
*** haukebruno has joined #openstack-nova | 14:53 | |
*** igornsa_ has quit IRC | 14:55 | |
bauzas | pkoniszewski: lpetrut: I agree, we should expose the same way for all drivers about what's supported | 14:55 |
bauzas | and not leave the driver code magically calculate whether it's okay or not | 14:55 |
*** Daisy has joined #openstack-nova | 14:55 | |
bauzas | in particular given block_migration is an user request query | 14:56 |
*** atuvenie_ has joined #openstack-nova | 14:56 | |
*** atuvenie_ has quit IRC | 14:56 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Make quotas commands more user-friendly https://review.openstack.org/290556 | 14:57 |
*** esracelik has quit IRC | 14:59 | |
pkoniszewski | well I want to completely remove block_migration flag from drivers, so we will avoid any problems in the future where block_migration != migrate_data.block_migration | 14:59 |
*** danpb1 has joined #openstack-nova | 15:00 | |
*** danpb has quit IRC | 15:00 | |
pkoniszewski | this would force all drivers to use migrate_data as a canonical source of what is really supported | 15:00 |
*** mrkz has joined #openstack-nova | 15:00 | |
pkoniszewski | bauzas: lpetrut: ^^ | 15:00 |
dansmith | ndipanov: there's a catch with your online data migration for pci_devices: http://logs.openstack.org/77/290077/1/check/gate-grenade-dsvm/f005ce8/logs/grenade.sh.txt.gz#_2016-03-08_19_38_01_736 | 15:01 |
*** haomaiwang has quit IRC | 15:01 | |
*** gongysh has quit IRC | 15:01 | |
dansmith | ndipanov: if we did a full shutdown, upgraded the code, then ran that command, none of the services are upgraded | 15:01 |
*** haomaiwa_ has joined #openstack-nova | 15:01 | |
*** shaohe_feng has quit IRC | 15:01 | |
pkoniszewski | bauzas: thanks for reviewing this patch, i need to drop in few minutes, in case u have more concerns please leave them in review | 15:01 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: No direct XML parsing in libvirt driver https://review.openstack.org/290562 | 15:02 |
bauzas | dansmith: given https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L318-L322 are we planning to keep that container-ish style supported for a while or should we ask callers to use obj_attr_is_set() explicitly? | 15:02 |
dansmith | ndipanov: so I think that we're going to either need to make that a warning and continue on, or have a --i-know-what-i-am-doing flag | 15:02 |
dansmith | bauzas: we just added it into the base recently | 15:03 |
bauzas | I saw | 15:03 |
bauzas | I saw mriedem_meeting's doing that | 15:03 |
ndipanov | dansmith, hmmm | 15:03 |
dansmith | bauzas: yeah | 15:03 |
bauzas | it was a DictCompat thing that was ported up | 15:03 |
bauzas | so, hence my question | 15:03 |
ndipanov | so that thing is supposed to check the actual service version | 15:03 |
dansmith | ndipanov: right, and it's working well :) | 15:03 |
bauzas | if it was kept in a mixin, I would have thrown the axe | 15:03 |
ndipanov | dansmith, oh ok | 15:03 |
*** shaohe_feng has joined #openstack-nova | 15:03 | |
bauzas | but I always try to have things explicit, in particular with o.vo | 15:03 |
*** zz_dimtruck is now known as dimtruck | 15:03 | |
*** Daisy has quit IRC | 15:04 | |
bauzas | dansmith: context is https://review.openstack.org/#/c/287363/6/nova/compute/manager.py@5236 and could be confusing | 15:04 |
*** danpb1 has quit IRC | 15:04 | |
dansmith | bauzas: what about it is confusing? | 15:04 |
bauzas | dansmith: fortunately, the right above call is turning a possibly legacy dict into an object | 15:04 |
bauzas | dansmith: people could think it's a dict | 15:05 |
dansmith | oh confusing because you don't know if it is a dict? | 15:05 |
dansmith | well, it can't be a dict because the same statement uses attribute syntax | 15:05 |
bauzas | dansmith: this can't be a dict because of the above call | 15:05 |
bauzas | I agre | 15:05 |
dansmith | and that | 15:05 |
bauzas | agree | 15:05 |
*** xek_ is now known as xek | 15:05 | |
bauzas | so, it's something we keep supporting, objects will be containers for a long period of time ? woah, nice | 15:05 |
*** pushkaru has joined #openstack-nova | 15:06 | |
ndipanov | dansmith, I still don't get the problem you try to point out | 15:06 |
* bauzas just remembers all the times he litterally had to obj_attr_is_set() | 15:06 | |
dansmith | bauzas: the point of doing that was just because obj_attr_is_set() is annoying | 15:06 |
bauzas | fair enough | 15:06 |
*** rk4n has quit IRC | 15:06 | |
bauzas | so I should kiss mriedem_meeting ? | 15:06 |
*** mtanino has joined #openstack-nova | 15:06 | |
*** smatzek has joined #openstack-nova | 15:06 | |
dansmith | ndipanov: in grenade, we start up a liberty set, run it, shut it down, then we try to do these online migrations after out db sync so that we are fully migrated, offline, before we start up | 15:07 |
dansmith | ndipanov: none of the services have run at mitaka level yet, which means this command refuses to run | 15:07 |
ndipanov | I see | 15:07 |
dansmith | which also means things like puppet/chef/ansible won't be able to do a full offline upgrade for you | 15:07 |
dansmith | if you wanted such a thing (and that's how they do it today) | 15:07 |
ndipanov | we do need a --i-know-what-im-doing-shutup | 15:07 |
dansmith | yeah | 15:07 |
dansmith | or, | 15:08 |
dansmith | we just assume that command is that and just warn the user "okay, now you can't have any older services, kthx" | 15:08 |
ndipanov | hmmm | 15:08 |
*** sc68cal has joined #openstack-nova | 15:08 | |
dansmith | but the question is also: do we need to bump all the service versions? otherwise code that uses that to signal things might be confused about newer format stuff *and* older services | 15:08 |
sdague | hmmmm... dansmith I think I need to understand some objects magic in the tests, that change of mriedem_meeting's tripped over a non trivial issue where our tests passed for the wrong reasons | 15:09 |
*** pradk has joined #openstack-nova | 15:09 | |
ndipanov | dansmith, so I think we should have 2 commands | 15:10 |
* cdent waves at pradk | 15:10 | |
dansmith | sdague: okay | 15:10 |
ndipanov | the other one called 'offline data migration and my newborn that I will never run an old version of the service ever' | 15:11 |
pradk | cdent, howdy :) | 15:11 |
ndipanov | first-born* | 15:11 |
sdague | dansmith: http://logs.openstack.org/34/290134/2/check/gate-nova-python27/77c9d8e/console.html#_2016-03-09_12_24_48_102 is the root error | 15:11 |
dansmith | ndipanov: instead of a --flag? | 15:11 |
sdague | I thought it was related to our FakeImage service building incomplete images, but once I get that sorted, the error is still there | 15:11 |
ndipanov | well yeah because you really should not run that unless you know what you are doing right | 15:11 |
dansmith | sdague: right, this is what I was saying yesterday.. if you don't implement lazy-loading for your object (or for one attribute of your object) you get (and always have gotten) a notimplementederror if you trigger a lazy load | 15:12 |
ndipanov | it's not an online data migration anymore | 15:12 |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/utils.py#L41 seems to be returning empty image objects | 15:12 |
openstackgerrit | Tim Pownall proposed openstack/nova: xenapi: fix when tar exits early during download https://review.openstack.org/287426 | 15:12 |
*** shaohe_feng has quit IRC | 15:12 | |
dansmith | ndipanov: you mean to denote the offline-ness? I'm just concerned people will think that the "online migrations" and "offline migrations" are different things, two different steps, run the offline ones while offline, then the online ones later | 15:13 |
*** huanxie has quit IRC | 15:13 | |
*** shaohe_feng has joined #openstack-nova | 15:13 | |
ndipanov | dansmith, how bad is it if we don't have offline ones | 15:13 |
*** edtubill has joined #openstack-nova | 15:14 | |
sdague | dansmith: if I print instrument the code I the image_service.show returns line 1, and the image_obj is line 2 - http://paste.openstack.org/show/489858/ | 15:14 |
*** Daisy has joined #openstack-nova | 15:14 | |
*** pushkaru has quit IRC | 15:14 | |
ndipanov | it seems we are opening ourselves up to pain if we allow it | 15:14 |
dansmith | ndipanov: I think we break puppet (et al) users that would rather a longer offline but more pushbuttony upgrade | 15:14 |
ndipanov | dansmith, we don't break them at all | 15:14 |
*** ekuris_ has quit IRC | 15:15 | |
*** rk4n has joined #openstack-nova | 15:15 | |
*** READ10 has joined #openstack-nova | 15:15 | |
dansmith | sdague: sorry, like six conversations in parallel right now, just a sec | 15:17 |
sdague | dansmith: yep, no worries, let me go get more coffee | 15:17 |
*** zengine has joined #openstack-nova | 15:18 | |
*** Daisy has quit IRC | 15:19 | |
*** pushkaru has joined #openstack-nova | 15:19 | |
*** danpb has joined #openstack-nova | 15:20 | |
dansmith | sdague: so you're trying to figure out *why* you're getting a lazy-load right? | 15:22 |
sdague | dansmith: yeh | 15:22 |
sdague | given that it's objects.ImageMeta.from_dict(image) | 15:22 |
*** zengine has quit IRC | 15:22 | |
*** shaohe_feng has quit IRC | 15:22 | |
dansmith | sdague: so the reason is that in the object (line 2) it's unset, which is what <?> means in the repr | 15:23 |
dansmith | why that's not set is another question | 15:23 |
sdague | right | 15:23 |
sdague | it's getting fed a dict that has that attribute | 15:23 |
*** shaohe_feng has joined #openstack-nova | 15:23 | |
sdague | let me poke a bit more, I'm noticing some other oddities in this trace | 15:25 |
dansmith | sdague: oh | 15:27 |
*** zengine has joined #openstack-nova | 15:27 | |
dansmith | sdague: should disk+format be inside the properties blob in the dict? | 15:28 |
dansmith | maybe the mock is giving you back something wrong? | 15:28 |
sdague | it's in the dict | 15:28 |
sdague | I actually fixed that part | 15:28 |
dansmith | right, but the dict is two dicts nested | 15:28 |
dansmith | {'properties': {'disk_format': 'raw'}} | 15:29 |
sdague | disk_format is top level I'm pretty sure | 15:29 |
dansmith | okay | 15:29 |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/image/fake.py#L126 | 15:29 |
sdague | we treat it as top level everywhere else | 15:29 |
*** edtubill has quit IRC | 15:29 | |
sdague | so, maybe this is a lazy load thing, because it's coming around through instances.image_meta | 15:30 |
sdague | instance.image_meta | 15:30 |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/virt/libvirt/driver.py#L1623 - that thing is "empty" | 15:30 |
sdague | sorry, one line up | 15:30 |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/virt/libvirt/driver.py#L1622 | 15:30 |
sdague | even though I've definitely got that image in the fake service, and it will return on a show | 15:31 |
dansmith | hmm | 15:31 |
dansmith | not even sure what that is | 15:31 |
dansmith | ah, | 15:31 |
dansmith | right | 15:31 |
dansmith | this is a non-objects @property that runs ImageMeta.from_instance(self) | 15:31 |
sdague | ok | 15:31 |
openstackgerrit | Tim Pownall proposed openstack/nova: xenapi: fix when tar exits early during download https://review.openstack.org/287426 | 15:32 |
sdague | so how do we get that to not be empty | 15:33 |
*** shaohe_feng has quit IRC | 15:33 | |
*** mgoddard has quit IRC | 15:33 | |
*** shaohe_feng has joined #openstack-nova | 15:33 | |
*** mgoddard has joined #openstack-nova | 15:34 | |
*** edtubill has joined #openstack-nova | 15:35 | |
dansmith | sdague: comes from here: https://github.com/openstack/nova/blob/master/nova/utils.py#L1242-L1268 | 15:37 |
dansmith | I'm guessing we just don't store all the things for an instance so some of that will never be set when we're just pulling from an instance | 15:37 |
dansmith | we should ask danpb as I think this is all his | 15:37 |
*** krtaylor has joined #openstack-nova | 15:37 | |
danpb | dansmith: what/when/where | 15:38 |
*** ildikov has quit IRC | 15:40 | |
*** mriedem_meeting is now known as mriedem | 15:40 | |
*** palexster has quit IRC | 15:42 | |
*** shaohe_feng has quit IRC | 15:43 | |
*** shaohe_feng has joined #openstack-nova | 15:44 | |
mriedem | rlrossit: http://docs.openstack.org/releasenotes/nova/unreleased.html | 15:44 |
rlrossit | mriedem: ah unreleased that's how it's divided up | 15:45 |
*** Swami has joined #openstack-nova | 15:45 | |
dansmith | danpb: well, I expected sdague to jump in there | 15:45 |
sdague | dansmith: I'm not convinced we're running that code in this test | 15:45 |
dansmith | sdague: oh? | 15:45 |
*** browne has joined #openstack-nova | 15:45 | |
dansmith | sdague: if it's doing instance.image_meta then it is | 15:46 |
dansmith | unless it's mocked | 15:46 |
*** nkrinner has quit IRC | 15:46 | |
sdague | oh, wait, wrong method, everything is named so close | 15:46 |
*** palexster has joined #openstack-nova | 15:46 | |
sdague | yeh, we are in that method, figuring out what our inputs look like | 15:47 |
sdague | system_meta = {} | 15:48 |
sdague | so that's not great | 15:48 |
*** sayalilunkad_lap has quit IRC | 15:48 | |
danpb | is this in unit tests ? | 15:48 |
sdague | yeh | 15:48 |
*** sayalilunkad_lap has joined #openstack-nova | 15:49 | |
*** zengine has quit IRC | 15:49 | |
danpb | our unit tests are sooooo awful at providing real world ImageMeta leaving out attributes that glance would always supply a value for | 15:49 |
sdague | danpb: this is trying to get to the bottom of 1 test that doesn't work when we change to explicit exceptions for virt features | 15:49 |
sdague | https://review.openstack.org/#/c/290134/ | 15:49 |
*** zengine has joined #openstack-nova | 15:49 | |
*** efried has quit IRC | 15:50 | |
sdague | and it turns out that nova.tests.unit.virt.test_virt_drivers.LibvirtConnTestCase.test_snapshot_running fails for the wrong reasons | 15:50 |
sdague | but was masked because of exception overlap | 15:50 |
danpb | oh i see, that's nice | 15:51 |
danpb | yeah that message looks very like problems i hit when converting libvirt tests to ImageMeta Objects | 15:52 |
*** efried has joined #openstack-nova | 15:52 | |
*** shaohe_feng has quit IRC | 15:53 | |
sdague | ok, it looks like system_meta is actually {} from further back | 15:53 |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/utils.py#L94 | 15:54 |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/utils.py#L89 | 15:54 |
*** shaohe_feng has joined #openstack-nova | 15:54 | |
sdague | my local lines are a little shifted with some debug code | 15:54 |
*** zengine has quit IRC | 15:54 | |
*** kmartin has joined #openstack-nova | 15:55 | |
*** EinstCrazy has quit IRC | 15:56 | |
*** liverpooler has quit IRC | 15:56 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary https://review.openstack.org/288373 | 15:56 |
jaosorior | mriedem: Hello, regarding the nova hooks issue (the personality/injected files thing), is this better as means for testing? https://review.openstack.org/#/c/248662/8/nova/tests/unit/api/openstack/compute/test_serversV21.py | 15:57 |
mriedem | jaosorior: i'll look in a bit | 15:57 |
*** ssurana has joined #openstack-nova | 15:59 | |
*** Sukhdev has joined #openstack-nova | 15:59 | |
danpb | sdague: yeah, i'd say that was the cause | 16:00 |
sdague | ok, in a real world, what is system_metadata supposed to be here to get that image back? | 16:00 |
*** haomaiwa_ has quit IRC | 16:01 | |
*** haomaiwang has joined #openstack-nova | 16:01 | |
danpb | sdague: in libvirt test_driver.py we just have | 16:01 |
danpb | 'system_metadata': { | 16:01 |
danpb | 'image_disk_format': 'raw', | 16:01 |
danpb | }, | 16:01 |
sdague | ok, but we actually have this image in our image store | 16:02 |
danpb | i don't think it actually matters in this test case afaict | 16:02 |
*** zzzeek has quit IRC | 16:03 | |
danpb | i don't see code accessing the image store | 16:03 |
sdague | it would be kind of nice to actually populate it to be consistent instead of have another mock path | 16:03 |
*** mjura has quit IRC | 16:03 | |
sdague | we're definitely accessing the image store | 16:03 |
*** thorst_ is now known as thorst_afk | 16:03 | |
*** shaohe_feng has quit IRC | 16:03 | |
*** zzzeek has joined #openstack-nova | 16:04 | |
*** Drankis has quit IRC | 16:04 | |
*** shaohe_feng has joined #openstack-nova | 16:05 | |
*** gcb has joined #openstack-nova | 16:05 | |
*** roeyc has quit IRC | 16:05 | |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/virt/test_virt_drivers.py#L260-L268 | 16:06 |
sdague | I guess we can just link it there | 16:08 |
sdague | dansmith: is there a to_dict? | 16:10 |
sdague | on objects | 16:10 |
*** yamahata has joined #openstack-nova | 16:10 | |
johnthetubaguy | is that to_primitive or something like that? | 16:10 |
cdent | sdague: did you get any insight on to why the py34 job is slow or is that still pending? | 16:10 |
dansmith | sdague: you can do base.obj_to_primitive() which tries to make an object into a dict, but it's usually a bad idea | 16:11 |
sdague | dansmith: well, many things assume images are dicts | 16:12 |
sdague | at least in this stack it seems | 16:12 |
dansmith | sdague: it can bring in more stuff than you want, and if the object differs at all it will hide other problems | 16:12 |
ansiwen | dansmith: if I add external=True to utils.synchronized, what would be the right lock_path? other places in the code use `os.path.join(CONF.instances_path, 'locks')`, but I'm not sure this is true in this case. | 16:12 |
sdague | get_system_metadata_from_image for instance | 16:13 |
ansiwen | dansmith: if I don't set the lock_path, the tests bail out because of a missing option | 16:13 |
dansmith | sdague: spawn expects a dict instead of an ImageMeta object? that doesn't seem right | 16:13 |
openstackgerrit | Chris Dent proposed openstack/nova: Make force_ and ignore_hosts comparisons case insensitive https://review.openstack.org/290532 | 16:13 |
sdague | dansmith: no, it expects an object | 16:14 |
*** shaohe_feng has quit IRC | 16:14 | |
dansmith | sdague: what are you trying to convert to a dict then? | 16:14 |
dansmith | sdague: image_from_sysmeta expects a dict of sysmeta, of course, but... | 16:14 |
sdague | I'm trying to populate system_metadata correctly | 16:14 |
sdague | from the image we have | 16:14 |
*** shaohe_feng has joined #openstack-nova | 16:15 | |
*** hemnafk is now known as hemna | 16:15 | |
sdague | because we have all the parts right next to each other in this test, we just don't link them | 16:15 |
dansmith | sdague: and that happens in compute manager before this connection to spawn in reality? | 16:15 |
*** jwcroppe has joined #openstack-nova | 16:15 | |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/virt/test_virt_drivers.py#L260-L268 | 16:16 |
danpb | sdague: if you have a dict of image meta from the image store, then call nova.utils.get_system_metadata_from_image | 16:16 |
sdague | danpb: right | 16:17 |
sdague | except the image we have is an object | 16:17 |
*** gcb has quit IRC | 16:17 | |
dansmith | it should be fine, no? | 16:17 |
sdague | nope | 16:17 |
dansmith | why do you think that method won't take an object? | 16:17 |
danpb | get_system_metadata_from_image assumes dict accessors | 16:17 |
sdague | because of that ^^^ | 16:18 |
dansmith | but we have those on imagemeta right? | 16:18 |
sdague | we do not have .get | 16:18 |
danpb | no, i explicitly never added DictCompat interface to these objets | 16:18 |
dansmith | we do have get | 16:18 |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/utils.py#L1219 | 16:18 |
dansmith | on properties | 16:18 |
sdague | https://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/utils.py#L1218 | 16:18 |
sdague | that fails | 16:18 |
dansmith | okay, well, you can try base.obj_to_primitive() | 16:19 |
sdague | dansmith: right, trying that :) | 16:19 |
dansmith | danpb: is there some reason that shouldn't handle an object? | 16:19 |
danpb | dansmith: ultimately it should take only an object | 16:19 |
dansmith | sdague: https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L529-L529 | 16:19 |
danpb | dansmith: but i never went as far as converting the bits of code involved in this area | 16:19 |
dansmith | sdague: get on properties, but not on the base object I guess | 16:20 |
dansmith | danpb: okay | 16:20 |
danpb | i stopped once i have the compute manager passing objects into the virt driver | 16:20 |
danpb | one day, we can finish the rest of the bits inside compute manager & before it | 16:20 |
danpb | but it wasn't a big priority for me once I had the virt drivers converted | 16:20 |
danpb | i'd probably add to_system_metadata() /from_system_metadata() methods on nova.objects.ImageMeta() and then delete the utils methods ultimately | 16:21 |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova: Set personality/injected_files to empty list if not specified https://review.openstack.org/248662 | 16:22 |
*** jwcroppe has quit IRC | 16:23 | |
*** shaohe_feng has quit IRC | 16:24 | |
*** shaohe_feng has joined #openstack-nova | 16:25 | |
sdague | dansmith: seems like I actually need - image_meta.obj_to_primitive()['nova_object.data'] | 16:25 |
dansmith | sdague: no, you're using the wrong one | 16:25 |
dansmith | definitely don't use that | 16:25 |
dansmith | nova.objects.base.obj_to_primitive | 16:25 |
sdague | ok, that's 100% what I need in this test | 16:25 |
dansmith | it's not I promise :) | 16:25 |
sdague | nova.objects.base.obj_to_primitive(image_meta) ? | 16:25 |
dansmith | yes | 16:25 |
mriedem | who's on first? | 16:26 |
sdague | ok, there is no method on objects for this? | 16:26 |
sdague | the static method also works | 16:27 |
sdague | ok, time to get rid of all my debug and submit | 16:27 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: virt: refactor method compute_driver_matches https://review.openstack.org/263243 | 16:27 |
dansmith | sdague: no, there is no method on the actual object | 16:28 |
dansmith | turning them into dicts is not really something we want to make easy :) | 16:28 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Clean up networks with SR-IOV binding on reschedule https://review.openstack.org/283198 | 16:29 |
*** armax has joined #openstack-nova | 16:30 | |
*** mpavone has quit IRC | 16:30 | |
*** edtubill has quit IRC | 16:30 | |
*** gcb_ has joined #openstack-nova | 16:30 | |
*** edtubill has joined #openstack-nova | 16:31 | |
openstackgerrit | Sean Dague proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods https://review.openstack.org/290134 | 16:33 |
*** dims has quit IRC | 16:33 | |
sdague | mriedem: hopefully that's right now | 16:34 |
*** shaohe_feng has quit IRC | 16:34 | |
*** Jeffrey4l has quit IRC | 16:34 | |
*** harlowja_at_home has joined #openstack-nova | 16:34 | |
*** Jeffrey4l has joined #openstack-nova | 16:35 | |
*** shaohe_feng has joined #openstack-nova | 16:35 | |
mriedem | i learned something today | 16:35 |
*** sridharg has quit IRC | 16:36 | |
mriedem | https://gist.github.com/mriedem/4f6ea2e61ea82d6ade6f | 16:36 |
mriedem | which is fine i guess | 16:36 |
mriedem | i thought NovaException message formatting was a bit more ruthless for kwargs, | 16:36 |
mriedem | but it's only if there are subs in the message | 16:37 |
mriedem | rlrossit: ^ which is why your test didn't fail | 16:37 |
johnthetubaguy | oh... I always assumed that would fail too | 16:37 |
mriedem | yeah i was trying to figure out why exception.Forbidden(reason=six.text_type(exc_value)) wasn't exploding | 16:38 |
openstackgerrit | Samuel Matzek proposed openstack/nova: Detach volume after deleting instance with no host https://review.openstack.org/256059 | 16:38 |
mriedem | and it's because the Forbidden.msg_fmt doesn't have subs | 16:38 |
dedery | hi all. https://review.openstack.org/#/c/287515 (Fix failed snapshot on VMs with SRIOV ports) is ready for review. I have a couple of open points there that i'd be happy to hear some thoughts about them. thanks :) | 16:39 |
mriedem | dedery: ndipanov is probably your guy for that one | 16:39 |
dansmith | sdague: so FYI, our new ceph failure alerting protocol noted that the ceph plugin job is spiking this morning and several of us looked into it. Turns out the patch from lyarwood that johnthetubaguy and alaski merged yesterday for a CVE broke the libvirt driver for non-file-image disk | 16:41 |
*** gcb_ has quit IRC | 16:41 | |
dansmith | specifically https://review.openstack.org/#/c/289957/1/nova/virt/libvirt/driver.py | 16:41 |
mriedem | dansmith: hmm, probably the same one that lyarwood was asking me to review on stable this morning | 16:42 |
dansmith | mriedem: indeed | 16:42 |
dedery | mriedem: thanks. will catch him | 16:42 |
mriedem | dansmith: ouch http://logs.openstack.org/57/289957/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/bf4a658/logs/screen-n-cpu.txt.gz?level=TRACE | 16:42 |
*** gcb_ has joined #openstack-nova | 16:43 | |
dansmith | mriedem: sdague: note that if the ceph job was gating, we wouldn't have merged this | 16:43 |
bauzas | mriedem: yeah we're investigating on that | 16:43 |
lyarwood | yeah here sorry | 16:43 |
dansmith | mriedem: right | 16:43 |
dedery | mriedem: there's an open issue there on PCI passthrough, is this also ndipanov's domain? | 16:43 |
mriedem | dedery: i generally see ndipanov, baoli_ and moshelle reviewing pci/sriov stuff | 16:44 |
bauzas | dansmith: lyarwood: that only means that UTs are not catching that case too | 16:44 |
*** dims has joined #openstack-nova | 16:44 | |
bauzas | not only the ceph thing | 16:44 |
dansmith | lyarwood: you wanna look at a quick fix or should we revert? | 16:44 |
bauzas | ceph job is just the canary | 16:44 |
dedery | mriedem: great. thanks again | 16:44 |
*** shaohe_feng has quit IRC | 16:44 | |
mriedem | dansmith: lyarwood: should be a simple fix | 16:45 |
lyarwood | dansmith: there's a quick fix | 16:45 |
mriedem | just an order of calls problem | 16:45 |
dansmith | cool | 16:45 |
mriedem | i've -2ed the backports | 16:45 |
*** shaohe_feng has joined #openstack-nova | 16:46 | |
dansmith | as mikal would say: THE SYSTEM WORKS! | 16:46 |
*** jschlueter has quit IRC | 16:46 | |
*** akshai has quit IRC | 16:46 | |
johnthetubaguy | dansmith: OK, so I did question that on the patch, but went with the +2s in the bug report.... arg. | 16:47 |
*** paul-carlton2 has quit IRC | 16:47 | |
dansmith | johnthetubaguy: yeah... it would have been caught if we were gating on those tests.. it's subtle | 16:47 |
johnthetubaguy | dansmith: true | 16:48 |
openstackgerrit | Paul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary https://review.openstack.org/288373 | 16:48 |
bauzas | so, the problem is that on_execute is only set on a conditional, what should be the default value if we want to keep it pass ? | 16:48 |
*** vishwana_ is now known as vishwanathj | 16:48 | |
lbeliveau | mriedem: ndipanov already +2 my bug fix, I need another core to look at it and +w, seems like you know the area so can you please look at it ? https://review.openstack.org/#/c/242573 | 16:49 |
*** akshai has joined #openstack-nova | 16:49 | |
mriedem | lbeliveau: i do not know sriov stuff :) | 16:49 |
paul-carlton1 | dansmith, added the comment to service.py that you suggested. | 16:49 |
openstackgerrit | David Edery proposed openstack/nova: Fix failed snapshot on VMs with SRIOV ports https://review.openstack.org/287515 | 16:49 |
*** e0ne has quit IRC | 16:50 | |
*** tbachman has quit IRC | 16:50 | |
lbeliveau | mriedem: no problem, I know you reviewed some stuff in neutronv2, taught you could review it | 16:50 |
*** yamahata has quit IRC | 16:50 | |
*** tristanC has joined #openstack-nova | 16:50 | |
mriedem | lbeliveau: do any of the sriov/pci 3rd party ci's run a cold migration or resize test? | 16:51 |
*** paul-carlton_ has joined #openstack-nova | 16:51 | |
*** belmoreira has quit IRC | 16:52 | |
lbeliveau | mriedem: I don't think so since it's broken (afaik since kilo or even earlier) | 16:52 |
*** wolsen has quit IRC | 16:52 | |
mriedem | it being cold migration? | 16:52 |
lyarwood | johnthetubaguy: apologies I should've asked you to clarify your comment on the change this morning, I obviously missunderstood what you were trying to get at. | 16:52 |
lbeliveau | ye | 16:52 |
*** wolsen has joined #openstack-nova | 16:52 | |
mriedem | lbeliveau: could we get an sriov 3rd party ci to post results on your patch though running a resize/migrate test? | 16:52 |
mriedem | probably just resize since cold migrate would require multihost | 16:52 |
*** browne has quit IRC | 16:53 | |
*** haomaiwang has quit IRC | 16:53 | |
lbeliveau | mriedem: how can I do that ? the patch is not run through all the gates ? | 16:54 |
mriedem | lbeliveau: i guess you'd get in contact with who runs an sriov 3rd party ci on nova changes and see if they can run their ci on your patch with a resize test unskipped | 16:54 |
*** jdurgin1 has joined #openstack-nova | 16:55 | |
mriedem | i'm not sure what the sriov 3rd party ci is, if that's mellanox or other? | 16:55 |
mriedem | maybe intel? | 16:55 |
*** shaohe_feng has quit IRC | 16:55 | |
*** jaosorior has quit IRC | 16:55 | |
lbeliveau | got it, will do | 16:55 |
mriedem | lbeliveau: i'd just have more warm fuzzies knowing that there is a test system in place for NFV stuff | 16:55 |
*** shaohe_feng has joined #openstack-nova | 16:56 | |
*** EinstCrazy has joined #openstack-nova | 16:56 | |
lbeliveau | mriedem: agreed, I'll look into putting such a test out there | 16:56 |
mriedem | thanks | 16:56 |
*** matrohon has quit IRC | 16:56 | |
mriedem | lbeliveau: fyi https://wiki.openstack.org/wiki/ThirdPartySystems/Intel-SRIOV-CI | 16:57 |
sdague | dansmith: cool that the new alerting stuff caught that | 16:57 |
dansmith | sdague: \o/ | 16:57 |
mriedem | shaohe_feng: ^ is the intel sriov ci running on nova changes? | 16:57 |
mriedem | lbeliveau: also https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI | 16:58 |
lbeliveau | mriedem: thanks for the tips ! | 16:58 |
*** mgoddard_ has joined #openstack-nova | 16:58 | |
mriedem | i don't see the mellanox ci reporting on the latest patch set, and i'm not sure how to recheck it | 16:59 |
*** gcb_ has quit IRC | 16:59 | |
*** haomaiwang has joined #openstack-nova | 17:00 | |
lbeliveau | mriedem: right, seems like it's not executed, have to figure why :) | 17:00 |
*** haomaiwang has quit IRC | 17:01 | |
mriedem | i've emailed the maintainer to ask if there is a way to recheck their ci | 17:01 |
lbeliveau | awesome | 17:01 |
mriedem | n0ano: shaohe_feng: is there a way to recheck this? https://wiki.openstack.org/wiki/ThirdPartySystems/Intel-SRIOV-CI | 17:01 |
*** mgoddard has quit IRC | 17:02 | |
*** rk4n has quit IRC | 17:02 | |
lbeliveau | mriedem: I need to figure out how we can test cold migration in long term, will hook up with those guys | 17:02 |
mriedem | n0ano: shaohe_feng: or how can we get the intel sriov ci to run on https://review.openstack.org/#/c/242573 ? | 17:02 |
lbeliveau | well I do in my lab ... but need gate validation | 17:02 |
mriedem | lbeliveau: resize should at least cover part of it | 17:02 |
mriedem | resize to same host | 17:02 |
lbeliveau | agreed | 17:03 |
*** jlanoux has quit IRC | 17:03 | |
alaski | lyarwood: just catching up, when you get a fix up for the ceph breakage ping me if you need a core to look at tit | 17:03 |
alaski | *it | 17:03 |
*** fawadkhaliq has joined #openstack-nova | 17:03 | |
*** EinstCrazy has quit IRC | 17:03 | |
*** fawadkhaliq has quit IRC | 17:03 | |
dansmith | alaski: to look at what now? | 17:04 |
*** shaohe_feng has quit IRC | 17:05 | |
*** daemontool has joined #openstack-nova | 17:05 | |
alaski | I will happily look at whatever is presented and leave it at that | 17:06 |
dansmith | lol | 17:06 |
*** shaohe_feng has joined #openstack-nova | 17:06 | |
*** jistr has quit IRC | 17:06 | |
*** daemontool_ has quit IRC | 17:07 | |
*** aghadge has joined #openstack-nova | 17:07 | |
*** haomaiwa_ has joined #openstack-nova | 17:08 | |
*** rk4n has joined #openstack-nova | 17:08 | |
*** apoorvad has joined #openstack-nova | 17:09 | |
*** thorst_afk is now known as thorst_ | 17:09 | |
*** rcernin has quit IRC | 17:09 | |
n0ano | mriedem, not sure, I'll ping the owners of the CI and see what's happening | 17:09 |
*** roeyc has joined #openstack-nova | 17:09 | |
*** fawadkhaliq has joined #openstack-nova | 17:10 | |
*** yamahata has joined #openstack-nova | 17:10 | |
*** aghadge has quit IRC | 17:11 | |
mdbooth | dansmith: Hey | 17:11 |
*** rk4n has quit IRC | 17:11 | |
rlrossit | mriedem: so how come when a Forbidden is raised, it explicitly needs to be caught by the API in order to return a 403? Shouldn't that kinda be "automatic"? | 17:11 |
dansmith | mdbooth: ohai | 17:11 |
danpb | alaski: lyarwood is just running for a train... said he might be back online once he catches it... | 17:11 |
mdbooth | So I can see what the problem is here | 17:12 |
* rlrossit runs away to play ping pong | 17:12 | |
*** rk4n has joined #openstack-nova | 17:12 | |
mdbooth | It looks pretty simple to fix | 17:12 |
mdbooth | Is the patch already reverted? | 17:13 |
mriedem | mdbooth: it's not | 17:13 |
mdbooth | I can either post a very quick fix | 17:13 |
dansmith | mdbooth: nope, not reverted | 17:13 |
mriedem | post a fix | 17:13 |
*** paul-carlton2 has joined #openstack-nova | 17:13 | |
mdbooth | Ok | 17:13 |
mriedem | the backports will have to be squashed with that fix | 17:13 |
mdbooth | kk | 17:13 |
dansmith | mdbooth: thanks for jumping on it | 17:13 |
alaski | danpb: good to know, thanks | 17:13 |
openstackgerrit | Sven Anderson proposed openstack/nova: Avoid parallel DB queries of identical metadata https://review.openstack.org/285562 | 17:14 |
*** shaohe_feng has quit IRC | 17:15 | |
mriedem | rlrossit: there is this https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi.py#L1067 but i think that's only if the rest api raises a specific webob.exc.Forbidden | 17:16 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: tests: Add some basic compute_api tests for attaching volumes https://review.openstack.org/290705 | 17:16 |
*** omnipresent has quit IRC | 17:16 | |
ndipanov | alaski, mriedem dansmith ^^ | 17:16 |
*** shaohe_feng has joined #openstack-nova | 17:16 | |
ndipanov | easy testing fix | 17:16 |
ndipanov | sdague, too | 17:16 |
mriedem | ndipanov: we don't have volume attach tests in test_compute.py? | 17:17 |
ndipanov | mriedem, none that test this logic I think | 17:17 |
n0ano | mriedem, just to be clear, that's the Intel NFV CI you want to recheck, the PCI CI has already given a +1 | 17:17 |
mriedem | n0ano: yeah i know | 17:18 |
openstackgerrit | Stephen Finucane proposed openstack/nova: libvirt: Don't misuse InstanceNotFound exception https://review.openstack.org/290706 | 17:18 |
*** browne has joined #openstack-nova | 17:18 | |
n0ano | OK, I'll look into it | 17:18 |
ndipanov | mriedem, hmmm | 17:18 |
ndipanov | it seems we do | 17:19 |
ndipanov | how did I miss those... | 17:19 |
*** tbachman has joined #openstack-nova | 17:19 | |
mriedem | ndipanov: yeah, look for compute_api.attach_volume in https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute.py | 17:19 |
ndipanov | mriedem, but funnily enough they don't test the case I tested here with raising | 17:20 |
mriedem | hmm, it's entirely possible some of the test_compute tests are busted, or just mocking over things that you care about | 17:21 |
ndipanov | plus I have a follow up fix with more failure cases | 17:21 |
*** rwmjones is now known as rwmjones_hols | 17:21 | |
*** Sukhdev has quit IRC | 17:21 | |
*** Sukhdev has joined #openstack-nova | 17:22 | |
*** daemontool_ has joined #openstack-nova | 17:22 | |
*** daemontool has quit IRC | 17:23 | |
ndipanov | mriedem, there is actually no test that tests for failure of the attach RPC | 17:23 |
ndipanov | hmm but that is a cast so maybe not so interesting... | 17:23 |
openstackgerrit | John Garbutt proposed openstack/nova: Add prototype feature classification matrix https://review.openstack.org/264719 | 17:25 |
openstackgerrit | John Garbutt proposed openstack/nova: Get support matrix notes from the ini file https://review.openstack.org/264763 | 17:25 |
*** shaohe_feng has quit IRC | 17:25 | |
mdbooth | dansmith: I have to run for the hills in just a second. I have a patch. Unit tests pass and I think it's good. If I throw it over the wall would you mind taking it? | 17:26 |
dansmith | mdbooth: yep sure | 17:26 |
*** shaohe_feng has joined #openstack-nova | 17:26 | |
openstackgerrit | Matthew Booth proposed openstack/nova: Fixup that CVE thing https://review.openstack.org/290715 | 17:27 |
mdbooth | dansmith: ^^^ | 17:27 |
*** sayalilunkad_lap has quit IRC | 17:27 | |
mdbooth | You might want to look at the commit message :) | 17:27 |
* mdbooth runs for the hills | 17:27 | |
dansmith | mdbooth: hhe, okay | 17:28 |
*** dimtruck is now known as zz_dimtruck | 17:30 | |
*** zz_dimtruck is now known as dimtruck | 17:30 | |
*** sfinucan has quit IRC | 17:30 | |
*** gjayavelu has joined #openstack-nova | 17:31 | |
*** mrkz has quit IRC | 17:32 | |
*** rdopiera has quit IRC | 17:34 | |
*** shaohe_feng has quit IRC | 17:36 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: tests: Add some basic compute_api tests for attaching volumes https://review.openstack.org/290705 | 17:36 |
*** mrkz has joined #openstack-nova | 17:36 | |
ndipanov | mriedem, ^^ | 17:36 |
*** shaohe_feng has joined #openstack-nova | 17:37 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: set service status based on vc connection https://review.openstack.org/290315 | 17:37 |
*** whenry_ has quit IRC | 17:39 | |
openstackgerrit | Aysy Anne A. Duarte proposed openstack/nova: Add mock for some libvirt unit tests work on ppc64le architecture https://review.openstack.org/290061 | 17:40 |
*** sudipto has quit IRC | 17:44 | |
*** shaohe_feng has quit IRC | 17:46 | |
dedery | sahid: thank you for the review. I'll address the comments later and continue the conversation over the comments | 17:46 |
*** vilobhmm11 has joined #openstack-nova | 17:47 | |
*** shaohe_feng has joined #openstack-nova | 17:47 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: Missing info_cache.save() in db sqlalchemy api https://review.openstack.org/289967 | 17:48 |
*** vilobhmm111 has joined #openstack-nova | 17:48 | |
*** lpetrut has quit IRC | 17:49 | |
*** Marga__ has quit IRC | 17:49 | |
*** lpetrut has joined #openstack-nova | 17:49 | |
*** thumpba has quit IRC | 17:50 | |
sahid | dedery: cool thanks | 17:50 |
*** thumpba has joined #openstack-nova | 17:51 | |
*** vilobhmm11 has quit IRC | 17:51 | |
*** dedery has quit IRC | 17:53 | |
*** haukebruno has quit IRC | 17:53 | |
*** rk4n has quit IRC | 17:53 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: Live migration failure in API leaves VM in MIGRATING state https://review.openstack.org/168916 | 17:55 |
*** shaohe_feng has quit IRC | 17:56 | |
*** lpetrut has quit IRC | 17:57 | |
*** amotoki has quit IRC | 17:57 | |
*** shaohe_feng has joined #openstack-nova | 17:57 | |
cfriesen_ | is anyone aware of a way to make the kvm virtual watchdog start ticking on guest creation (ie in the virtual BIOS) rather than only starting on guest boot? I'd like to protect against a hung boot. | 17:58 |
*** sahid has quit IRC | 18:00 | |
*** haomaiwa_ has quit IRC | 18:01 | |
*** 20WAAIK4T has joined #openstack-nova | 18:01 | |
*** gjayavelu has quit IRC | 18:05 | |
*** Jeffrey4l has quit IRC | 18:05 | |
*** derekh is now known as derekh_afk | 18:06 | |
*** akshai has quit IRC | 18:06 | |
*** shaohe_feng has quit IRC | 18:06 | |
*** shaohe_feng has joined #openstack-nova | 18:07 | |
*** vilobhmm111 has quit IRC | 18:08 | |
*** Marga_ has joined #openstack-nova | 18:08 | |
*** nic has joined #openstack-nova | 18:09 | |
*** ankita_wagh has joined #openstack-nova | 18:09 | |
*** Marga_ has quit IRC | 18:09 | |
*** ihrachys has quit IRC | 18:10 | |
*** daemontool__ has joined #openstack-nova | 18:10 | |
*** renatoarmani has joined #openstack-nova | 18:10 | |
*** Marga_ has joined #openstack-nova | 18:11 | |
*** daemontool_ has quit IRC | 18:13 | |
*** akshai has joined #openstack-nova | 18:14 | |
*** mgoddard_ has quit IRC | 18:15 | |
*** ankita_wagh has quit IRC | 18:16 | |
*** daemontool__ has quit IRC | 18:16 | |
*** PaulMurray has quit IRC | 18:16 | |
*** shaohe_feng has quit IRC | 18:17 | |
*** danpb has quit IRC | 18:17 | |
*** Marga_ has quit IRC | 18:17 | |
*** shaohe_feng has joined #openstack-nova | 18:18 | |
*** lucasagomes is now known as lucas-dinner | 18:18 | |
*** tbachman_ has joined #openstack-nova | 18:19 | |
*** jaosorior has joined #openstack-nova | 18:21 | |
*** tbachman has quit IRC | 18:21 | |
*** tbachman_ is now known as tbachman | 18:21 | |
*** Marga_ has joined #openstack-nova | 18:22 | |
mriedem | jaosorior: one little issue in your personality test | 18:22 |
mriedem | otherwise looks good | 18:22 |
ndipanov | mriedem, check this out now https://review.openstack.org/#/c/290705/2 - or do you think I should rework those in test_compute.py | 18:24 |
ndipanov | ? | 18:24 |
mriedem | ndipanov: i think we want to not add anything more to test_compute that's new if we can help it | 18:25 |
mriedem | new things should go in test_compute_api and test_compute_mgr | 18:25 |
mriedem | b/c test_compute is a mess | 18:25 |
ndipanov | mriedem, agreed | 18:25 |
*** shaohe_feng has quit IRC | 18:27 | |
ndipanov | mriedem, also I fixed that service version thing https://review.openstack.org/#/c/286743/ | 18:27 |
*** mvk has quit IRC | 18:27 | |
ndipanov | so would be good to drop the -1 if possible | 18:28 |
*** roeyc has quit IRC | 18:28 | |
mriedem | +2! | 18:29 |
*** e0ne has joined #openstack-nova | 18:29 | |
mriedem | not that it mattered really, but yeah | 18:29 |
*** shaohe_feng has joined #openstack-nova | 18:29 | |
*** takedakn has joined #openstack-nova | 18:29 | |
*** palexster has quit IRC | 18:29 | |
*** takedakn has quit IRC | 18:30 | |
mriedem | bbiab | 18:31 |
*** ildikov has joined #openstack-nova | 18:33 | |
*** jdurgin1 has quit IRC | 18:34 | |
*** renatoarmani has quit IRC | 18:34 | |
*** mriedem has quit IRC | 18:36 | |
*** mriedem has joined #openstack-nova | 18:36 | |
*** shaohe_feng has quit IRC | 18:37 | |
*** shaohe_feng has joined #openstack-nova | 18:38 | |
*** renatoarmani has joined #openstack-nova | 18:39 | |
*** RuiChen has quit IRC | 18:39 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Translate OverLimit exceptions in Cinder calls https://review.openstack.org/290550 | 18:40 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add Forbidden to caught cinder exceptions https://review.openstack.org/290523 | 18:40 |
dansmith | jbernard_: mriedem: FYI that patch from mdbooth looks like it does fix it, so I'll get it cleaned up | 18:42 |
dansmith | sdague: ^ | 18:42 |
*** pece has quit IRC | 18:42 | |
*** paul-carlton2 has quit IRC | 18:42 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports https://review.openstack.org/242573 | 18:43 |
lbeliveau | ndipanov, mriedem: ^ fixed minor comment | 18:43 |
*** dims has quit IRC | 18:44 | |
*** claudiub has joined #openstack-nova | 18:45 | |
*** dims has joined #openstack-nova | 18:46 | |
mriedem | dansmith: link? i lost irc | 18:46 |
dansmith | mriedem: hang on I'm about to push it again | 18:47 |
mriedem | push it real good? | 18:47 |
pwnall | :P | 18:47 |
dansmith | mriedem: you know it | 18:47 |
*** shaohe_feng has quit IRC | 18:47 | |
*** shaohe_feng has joined #openstack-nova | 18:48 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: pci: avoid parsing whitelist repeatedly https://review.openstack.org/264510 | 18:49 |
lyarwood | dansmith: back online finally btw | 18:49 |
*** tbachman has quit IRC | 18:49 | |
lyarwood | dansmith: looking at Matt's patch now | 18:49 |
dansmith | lyarwood: okay | 18:50 |
*** tbachman has joined #openstack-nova | 18:50 | |
*** Marga_ has quit IRC | 18:53 | |
*** Marga_ has joined #openstack-nova | 18:54 | |
lyarwood | dansmith: looks good, are you still pushing a cleaned up version? :) | 18:56 |
dansmith | lyarwood: yeah, making a test tweak | 18:56 |
dansmith | lyarwood: we could do another test for this case specifically which might be nice if you want to work on that, | 18:56 |
dansmith | and then maybe we could land this ASAP to fix the actual problem | 18:56 |
openstackgerrit | Dan Smith proposed openstack/nova: Fix processing of libvirt disk.info in non-disk-image cases https://review.openstack.org/290715 | 18:57 |
*** shaohe_feng has quit IRC | 18:58 | |
*** mgoddard has joined #openstack-nova | 18:58 | |
*** rlrossit has quit IRC | 18:58 | |
*** lpetrut has joined #openstack-nova | 18:58 | |
*** shaohe_feng has joined #openstack-nova | 18:58 | |
*** jwcroppe has joined #openstack-nova | 18:59 | |
*** READ10 has quit IRC | 19:00 | |
*** rlrossit has joined #openstack-nova | 19:00 | |
lyarwood | dansmith: I can look into that now but my connection is going to get pretty bad on this train ride. If we need this fixed ASAP feel free to push on without it, I can always add it later. | 19:00 |
dansmith | lyarwood: I mean later, no worries | 19:00 |
dansmith | just don't forget :) | 19:00 |
*** 20WAAIK4T has quit IRC | 19:01 | |
dansmith | mriedem: ^ | 19:01 |
*** markvoelker has quit IRC | 19:01 | |
*** haomaiwa_ has joined #openstack-nova | 19:01 | |
*** cdent has quit IRC | 19:01 | |
*** Sukhdev has quit IRC | 19:02 | |
*** ducttape_ has quit IRC | 19:02 | |
*** paul-carlton_ has quit IRC | 19:02 | |
*** markvoelker has joined #openstack-nova | 19:03 | |
mriedem | i have to remember what add_job and remove_job do in the tracker | 19:03 |
mriedem | kills the pid right? | 19:03 |
tristanC | it seems like kilo is not affected by the ceph breakage, so is https://review.openstack.org/#/c/289960/ good to be merged as-is ? | 19:04 |
dansmith | mriedem https://review.openstack.org/#/c/290715/2/nova/virt/libvirt/driver.py | 19:05 |
dansmith | it was there before, just got moved inside the loop | 19:05 |
tristanC | and then, for liberty, is the follow-up going to be squashed with the backport, or both be merged using depends-on ? | 19:05 |
dansmith | tristanC: I'm sure kilo is impacted as well | 19:05 |
tristanC | dansmith: but the gate-tempest-dsvm-full-devstack-plugin-ceph-nv return success | 19:06 |
mriedem | yeah it's odd that the ceph job isn't failing kilo | 19:06 |
dansmith | tristanC: I'm guessing that's because we run fewer tests or something | 19:06 |
*** vilobhmm11 has joined #openstack-nova | 19:06 | |
*** liverpooler has joined #openstack-nova | 19:06 | |
dansmith | or unless the patch applied differently there and we got lucky, | 19:06 |
dansmith | but mriedem would have noticed I think | 19:07 |
*** ducttape_ has joined #openstack-nova | 19:07 | |
lyarwood | it didn't, it must be due to missing tests in kilo | 19:08 |
*** shaohe_feng has quit IRC | 19:08 | |
*** pwnall has quit IRC | 19:09 | |
*** shaohe_feng has joined #openstack-nova | 19:09 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Change SpawnIsSynchronous fixture return https://review.openstack.org/290780 | 19:10 |
alaski | mriedem: ^ | 19:10 |
mriedem | nice | 19:10 |
mriedem | dansmith: mdbooth: why is that compression kwarg removed? | 19:11 |
*** zenoway has joined #openstack-nova | 19:12 | |
*** andreykurilin__ has quit IRC | 19:13 | |
dansmith | mriedem: hmm, I dunno | 19:13 |
dansmith | lyarwood: any idea? | 19:13 |
mriedem | tristanC: lyarwood: dansmith: btw, kilo is running the same tests | 19:13 |
*** haomaiwa_ has quit IRC | 19:13 | |
mriedem | but passing | 19:13 |
mriedem | master: http://logs.openstack.org/67/289967/5/check/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/86e0aa4/console.html#_2016-03-09_18_10_57_481 | 19:13 |
mriedem | kilo: http://logs.openstack.org/60/289960/1/check/gate-tempest-dsvm-full-ceph/90d5a22/console.html#_2016-03-08_15_35_17_738 | 19:13 |
dansmith | mriedem: well, it's a pretty mechanical problem, not sure how it's not broken there | 19:13 |
*** boris-42 has quit IRC | 19:14 | |
*** haomaiwa_ has joined #openstack-nova | 19:14 | |
mriedem | yeah, there is some differences in the method between master and kilo wrt handling swaps | 19:16 |
mriedem | and on master it's the swap block that was setting those vars | 19:17 |
mriedem | but not in kilo | 19:17 |
mriedem | so that's probably why it's not failing, | 19:17 |
mriedem | but it's still wrong | 19:17 |
*** markvoelker has quit IRC | 19:17 | |
*** markvoelker has joined #openstack-nova | 19:18 | |
*** shaohe_feng has quit IRC | 19:18 | |
*** shaohe_feng has joined #openstack-nova | 19:19 | |
*** jschlueter has joined #openstack-nova | 19:19 | |
*** doug-fis_ has joined #openstack-nova | 19:19 | |
*** doug-fis_ is now known as doug-fish_ | 19:20 | |
*** doug-fish has quit IRC | 19:21 | |
*** ociuhandu has quit IRC | 19:23 | |
dansmith | mriedem: that compression arg won't be available if we don't run the swap clause | 19:23 |
*** lpetrut has quit IRC | 19:25 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Do not reserve device before reserving the volum https://review.openstack.org/290793 | 19:25 |
ndipanov | mriedem, here's a nice one for you I know you love volumes ^^ | 19:25 |
*** lpetrut has joined #openstack-nova | 19:25 | |
dansmith | mriedem: and it wasn't originally on this call because that call didn't exist | 19:25 |
dansmith | mriedem: and was only for swap | 19:25 |
mriedem | yeah | 19:25 |
mriedem | dansmith: so just another copy/paste fail i guess | 19:25 |
dansmith | mriedem: so I want to say that this was just copy/paste | 19:25 |
dansmith | yeah | 19:25 |
*** lpetrut has quit IRC | 19:25 | |
*** renatoarmani has quit IRC | 19:26 | |
mriedem | +2 but we should wait for the ceph job results | 19:26 |
*** lpetrut has joined #openstack-nova | 19:26 | |
dansmith | it passed ceph before I updated the commit message | 19:26 |
dansmith | but yeah | 19:26 |
dansmith | no argument | 19:26 |
dansmith | since that's how we got here in the first place :) | 19:26 |
mriedem | ndipanov: added myself, a bit distracted | 19:27 |
*** baoli_ has quit IRC | 19:27 | |
mriedem | dansmith: it's already passed the resize tests in the ceph jobs | 19:28 |
mriedem | https://jenkins07.openstack.org/job/gate-tempest-dsvm-full-ceph/8100/console | 19:28 |
mriedem | https://jenkins04.openstack.org/job/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/1921/console | 19:28 |
*** shaohe_feng has quit IRC | 19:29 | |
dansmith | cool | 19:29 |
*** shaohe_feng has joined #openstack-nova | 19:29 | |
*** jschlueter has quit IRC | 19:30 | |
*** jed56 has quit IRC | 19:33 | |
*** thorst__ has joined #openstack-nova | 19:36 | |
*** jwcroppe has quit IRC | 19:37 | |
*** shaohe_feng has quit IRC | 19:39 | |
*** mvk has joined #openstack-nova | 19:39 | |
*** shaohe_feng has joined #openstack-nova | 19:39 | |
*** yassine has quit IRC | 19:40 | |
*** thorst_ has quit IRC | 19:40 | |
*** efoley__ has quit IRC | 19:42 | |
*** yamahata has quit IRC | 19:44 | |
*** ociuhandu has joined #openstack-nova | 19:44 | |
*** sdague has quit IRC | 19:45 | |
*** jichen has joined #openstack-nova | 19:45 | |
*** pushkaru has quit IRC | 19:48 | |
*** pushkaru has joined #openstack-nova | 19:48 | |
*** edtubill has quit IRC | 19:48 | |
*** shaohe_feng has quit IRC | 19:49 | |
*** edtubill has joined #openstack-nova | 19:50 | |
*** shaohe_feng has joined #openstack-nova | 19:50 | |
*** salv-orlando has joined #openstack-nova | 19:51 | |
*** salv-orl_ has joined #openstack-nova | 19:53 | |
*** sdague has joined #openstack-nova | 19:54 | |
*** doug-fish has joined #openstack-nova | 19:55 | |
*** doug-fish_ has quit IRC | 19:55 | |
tristanC | can I cherry-pick 290715 on top of current backport ? I worry the advisory needs an errata asap | 19:56 |
*** salv-orlando has quit IRC | 19:56 | |
sdague | mriedem / dansmith on the fix for ceph we're sure the 2 multinode fails aren't related - http://logs.openstack.org/15/290715/1/check/gate-tempest-dsvm-multinode-full/03f92ff/console.html | 19:57 |
*** rlrossit has quit IRC | 19:58 | |
sdague | one is the volumes backed live migration, which IIRC is completely hosed anyway | 19:58 |
dansmith | sdague: did you see what the actual bug was? | 19:58 |
sdague | shelve offload looks like it's not getting the dhcp lease | 19:58 |
mriedem | i've never seen this before http://logs.openstack.org/15/290715/1/check/gate-tempest-dsvm-multinode-full/03f92ff/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-03-09_18_09_01_748 | 19:58 |
dansmith | just moved setting a variable inside an if statement that only runs on things like ceph | 19:59 |
dansmith | *unlike | 19:59 |
sdague | dansmith: ok | 19:59 |
dansmith | mriedem: I have | 19:59 |
mriedem | sdague: live block migration suddently aborted http://logs.openstack.org/15/290715/1/check/gate-tempest-dsvm-multinode-full/03f92ff/logs/subnode-2/screen-n-cpu.txt.gz?level=TRACE#_2016-03-09_18_08_33_510 | 19:59 |
mriedem | which is known | 19:59 |
dansmith | mriedem: when we had name clashes in multinode | 19:59 |
mriedem | *unexpectedly failed | 19:59 |
*** shaohe_feng has quit IRC | 19:59 | |
*** drankis has joined #openstack-nova | 19:59 | |
*** renatoarmani has joined #openstack-nova | 20:00 | |
*** shaohe_feng has joined #openstack-nova | 20:00 | |
mriedem | dansmith: checking the 2 n-cpu logs they have different hostnames it looks like | 20:00 |
*** haomaiwa_ has quit IRC | 20:01 | |
mriedem | shelve instance failed on an ssh thing | 20:01 |
*** haomaiwang has joined #openstack-nova | 20:01 | |
*** rhagarty has joined #openstack-nova | 20:01 | |
sdague | the name clashes were addressed a long time ago ... but I agree, that looks kind of suspect | 20:01 |
sdague | anyway, this fix, is fine | 20:02 |
dansmith | yeah, definitely weird | 20:02 |
*** rlrossi__ has joined #openstack-nova | 20:02 | |
dansmith | mriedem: did you look in logstash for that one? | 20:02 |
*** jaosorior has quit IRC | 20:02 | |
mriedem | not yet | 20:02 |
*** jaosorior has joined #openstack-nova | 20:03 | |
dansmith | if this is reasonable: message:"another host's instance" | 20:03 |
mriedem | http://goo.gl/cjoCAk | 20:03 |
dansmith | it's got lots of hits | 20:03 |
dansmith | yeah, cool | 20:03 |
mriedem | 2500+ | 20:04 |
*** jichen has quit IRC | 20:04 | |
mriedem | 68% successful runs when it shows up, | 20:04 |
mriedem | but that's not really saying much since the multinode jobs fail anywhere between 25 and 75% of the time | 20:04 |
dansmith | heh | 20:04 |
*** renatoarmani has quit IRC | 20:04 | |
*** jichen has joined #openstack-nova | 20:05 | |
*** Sukhdev has joined #openstack-nova | 20:05 | |
sdague | mriedem: it looks like the records of the migrations are getting left in a state that the resource track hits on it's periodic and gets mad about | 20:07 |
sdague | http://logs.openstack.org/15/290715/1/check/gate-tempest-dsvm-multinode-full/03f92ff/logs/screen-n-cpu.txt.gz?level=INFO#_2016-03-09_18_09_00_775 | 20:07 |
sdague | every time that runs after a live migration has run, it generates an error | 20:07 |
mriedem | sdague: ok, definitely shouldn't be an error level | 20:08 |
mriedem | i can open a bug | 20:08 |
sdague | referencing the live migration that completed | 20:08 |
dansmith | yeah, I thought that was debug level actually | 20:08 |
dansmith | maybe some recent change with live migration work? | 20:08 |
sdague | well, it seems like it shouldn't be either | 20:08 |
*** gjayavelu has joined #openstack-nova | 20:08 | |
sdague | right? | 20:08 |
*** renatoarmani has joined #openstack-nova | 20:08 | |
dansmith | either? | 20:08 |
dansmith | meaning not debug either? | 20:08 |
sdague | we should have left things in a sane state for the resource tracker | 20:08 |
sdague | the fact that after every live migration there is crud the resource tracker needs to clean up separately seems weird | 20:09 |
dansmith | sure, I'm just saying I thought this specific one was a debug | 20:09 |
dansmith | does it actually clean it up or ignore it? | 20:09 |
*** renatoarmani has quit IRC | 20:09 | |
*** pushkaru has quit IRC | 20:09 | |
*** pumarani__ has joined #openstack-nova | 20:09 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1555320 | 20:09 |
openstack | Launchpad bug 1555320 in OpenStack Compute (nova) ""Migration for instance 0763227e-e192-4e0b-a49d-0ea0b181fca6 refers to another host's instance!" should not be an error" [Medium,Confirmed] | 20:09 |
*** shaohe_feng has quit IRC | 20:10 | |
sdague | well, it only happens once | 20:10 |
dansmith | hmm okay | 20:10 |
sdague | per live migration | 20:10 |
sdague | which means something is cleaning it up | 20:10 |
sdague | and it's probably it | 20:10 |
dansmith | I would expect the RT to not dick with other hosts' stuff | 20:10 |
dansmith | that's usually not a good thing | 20:10 |
mriedem | dansmith: it's not new at least in the last week | 20:10 |
dansmith | mriedem: yeah, I meant like this cycle | 20:10 |
*** shaohe_feng has joined #openstack-nova | 20:10 | |
mriedem | well, there have been some people hacking on migration and resouce tracker | 20:11 |
mriedem | under the loving care of jaypipes | 20:11 |
*** mgoddard has quit IRC | 20:12 | |
*** daemontool has joined #openstack-nova | 20:14 | |
jaypipes | I'm still teasing apart these damn pci unit tests :( | 20:14 |
*** efried has quit IRC | 20:14 | |
sdague | I kind of feel like we need a version of Yakety Sax called mockety mocks that you have to play any time you try to unwind our unit tests :) | 20:17 |
dansmith | sdague: did you look at the grenade fail? | 20:17 |
dansmith | looks like everyone lost the mq | 20:17 |
sdague | dansmith: which fail? | 20:17 |
dansmith | sdague: on that ceph fix: http://logs.openstack.org/15/290715/2/check/gate-grenade-dsvm/056bc19/logs/grenade.sh.txt.gz#_2016-03-09_19_21_22_820 | 20:18 |
dansmith | looks like maybe just during cleanup? but there are mq timeout errors in all the logs | 20:18 |
*** jwcroppe has joined #openstack-nova | 20:19 | |
sdague | so that looks like the oslo.messaging issue which showed up in 4.1.0 that I thought was addressed | 20:20 |
*** shaohe_feng has quit IRC | 20:20 | |
dansmith | okay | 20:20 |
dansmith | so recheck? | 20:20 |
*** acabot has quit IRC | 20:20 | |
*** shaohe_feng has joined #openstack-nova | 20:20 | |
sdague | can you update this bug with links to it first - https://bugs.launchpad.net/oslo.messaging/+bug/1545002 | 20:21 |
openstack | Launchpad bug 1545002 in oslo.messaging "Grenade Failure - MessagingTimeout on floating IP remove" [High,New] | 20:21 |
*** jwcroppe has quit IRC | 20:21 | |
dansmith | yep | 20:21 |
openstackgerrit | Sean Dague proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods https://review.openstack.org/290134 | 20:24 |
sdague | mriedem: once more into the breech | 20:25 |
*** pumarani__ has quit IRC | 20:25 | |
sdague | I missed one test | 20:25 |
*** pumarani__ has joined #openstack-nova | 20:25 | |
*** ihrachys has joined #openstack-nova | 20:25 | |
*** whenry has joined #openstack-nova | 20:28 | |
mriedem | sdague: i saw that, was going to update this afternoon but got sidetracked | 20:28 |
mriedem | with ceph and ES health and trove | 20:28 |
*** Sukhdev has quit IRC | 20:29 | |
*** shaohe_feng has quit IRC | 20:30 | |
sdague | yep, no worries | 20:30 |
*** shaohe_feng has joined #openstack-nova | 20:31 | |
*** whenry has quit IRC | 20:33 | |
*** efried has joined #openstack-nova | 20:35 | |
*** ircuser-1 has quit IRC | 20:36 | |
mriedem | sdague: you should add a co-author to https://review.openstack.org/#/c/290134/ | 20:40 |
*** shaohe_feng has quit IRC | 20:40 | |
*** shaohe_feng has joined #openstack-nova | 20:41 | |
*** salv-orl_ has quit IRC | 20:43 | |
*** burgerk has joined #openstack-nova | 20:45 | |
dims | dansmith : sdague : i see 5 hits on that grenade timeout problem - http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22cinder_grenade%5C%22%20AND%20message:%5C%22_disassociate_floating_ip%5C%22%20AND%20message:%5C%22MessagingTimeout%5C%22%20AND%20tags:%5C%22screen-n-api.txt%5C%22&from=30d | 20:46 |
dims | dansmith : sdague : only thing common between them is they are on build_node devstack-trusty-osic-cloud1-XYZ | 20:46 |
dims | dansmith : sdague : seem to have started again on the 7th. and we have not had any oslo.messaging releases for a couple of weeks now | 20:47 |
dims | dansmith : are you able to recreate it locally? (so i can go try that) | 20:48 |
dansmith | dims: I just saw it that once, sdague asked me to paste linkages | 20:48 |
dims | dansmith : locally or in the CI? | 20:49 |
*** edtubill has quit IRC | 20:49 | |
*** doug-fish has quit IRC | 20:49 | |
dansmith | dims: in that one job | 20:50 |
dims | dansmith : thanks! i am all caught up now :) | 20:50 |
mriedem | sdague: i'll add it, i have to restack this series on top of alaski's | 20:50 |
*** shaohe_feng has quit IRC | 20:51 | |
*** ircuser-1 has joined #openstack-nova | 20:51 | |
*** ihrachys has quit IRC | 20:51 | |
*** shaohe_feng has joined #openstack-nova | 20:52 | |
*** armax has quit IRC | 20:53 | |
*** e0ne has quit IRC | 20:53 | |
bauzas | alaski: is my mind correct or we have some cells meeting in a few mins ? | 20:54 |
alaski | bauzas: we're skipping this week | 20:54 |
*** armax has joined #openstack-nova | 20:54 | |
bauzas | oh, correct, that's not like if you sent an email | 20:54 |
bauzas | I was for once thinking I was masterizing my agenda :' | 20:54 |
bauzas | too bad | 20:54 |
alaski | we've got to keep you on your toes | 20:55 |
*** pwnall has joined #openstack-nova | 20:55 | |
*** pumarani__ has quit IRC | 20:57 | |
*** pushkaru has joined #openstack-nova | 20:57 | |
tristanC | since I02f8a5f0e29816336e500a8fe8dcc9ece15968e9 has been +workflowed, I proposed backports to stable branch on top of the original fix | 20:57 |
*** whenry has joined #openstack-nova | 20:57 | |
*** haomaiwang has quit IRC | 21:01 | |
*** shaohe_feng has quit IRC | 21:01 | |
*** haomaiwang has joined #openstack-nova | 21:01 | |
openstackgerrit | jichenjc proposed openstack/python-novaclient: Prepare to move extension into core plugin https://review.openstack.org/290448 | 21:01 |
*** shaohe_feng has joined #openstack-nova | 21:02 | |
*** pushkaru has quit IRC | 21:02 | |
*** pushkaru has joined #openstack-nova | 21:02 | |
mriedem | tristanC: did you squash those or not? | 21:04 |
*** dims has quit IRC | 21:05 | |
tristanC | mriedem: just cherry-pick, mostly to get test result | 21:05 |
tristanC | and it's also much easier advisories wise since the original patch is likely already merged in downstream branches | 21:09 |
*** roeyc has joined #openstack-nova | 21:11 | |
*** shaohe_feng has quit IRC | 21:11 | |
*** shaohe_feng has joined #openstack-nova | 21:12 | |
*** thumpba has quit IRC | 21:13 | |
*** thumpba has joined #openstack-nova | 21:14 | |
*** smatzek has quit IRC | 21:15 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: check for optional LibvirtLiveMigrateData attrs before loading https://review.openstack.org/286828 | 21:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods https://review.openstack.org/290134 | 21:17 |
*** artom has quit IRC | 21:17 | |
*** thumpba has quit IRC | 21:18 | |
*** vladikr has quit IRC | 21:19 | |
*** markvoelker has quit IRC | 21:20 | |
*** shaohe_feng has quit IRC | 21:21 | |
*** shaohe_feng has joined #openstack-nova | 21:22 | |
*** sdague_ has joined #openstack-nova | 21:23 | |
*** doug-fish has joined #openstack-nova | 21:25 | |
*** sheel has quit IRC | 21:27 | |
mriedem | oomichi: rlrossi__ has a question about handling a 403 in basically all of the volume related APIs | 21:27 |
mriedem | oomichi: as in, is there a way to generically handle a 403 from volume_api in all of the volume REST APIs | 21:27 |
*** derekh_afk is now known as derekh | 21:29 | |
*** thorst__ is now known as thorst_ | 21:30 | |
cfriesen_ | is there a way to rebuild the volume for a boot-from-volume instance? I don't think a general "rebuild" would do it. | 21:30 |
cfriesen_ | instance rebuild, I mean | 21:30 |
*** gszasz has quit IRC | 21:31 | |
*** shaohe_feng has quit IRC | 21:32 | |
*** shaohe_feng has joined #openstack-nova | 21:32 | |
*** macsz has joined #openstack-nova | 21:34 | |
*** baoli has joined #openstack-nova | 21:37 | |
*** dims has joined #openstack-nova | 21:37 | |
*** tbachman_ has joined #openstack-nova | 21:42 | |
*** shaohe_feng has quit IRC | 21:42 | |
*** shaohe_feng has joined #openstack-nova | 21:43 | |
*** roeyc has quit IRC | 21:43 | |
*** roeyc1 has joined #openstack-nova | 21:43 | |
*** tbachman has quit IRC | 21:45 | |
*** tbachman_ is now known as tbachman | 21:45 | |
*** yamahata has joined #openstack-nova | 21:47 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Do not reserve device before reserving the volum https://review.openstack.org/290793 | 21:48 |
*** cleong has quit IRC | 21:49 | |
*** macsz has quit IRC | 21:49 | |
mriedem | cfriesen_: there might be some bugs open for that i think | 21:51 |
mriedem | cfriesen_: rpodolyaka might have been working around that | 21:51 |
mriedem | cfriesen_: https://bugs.launchpad.net/nova?field.searchtext=volume+rebuild&search=Search&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=FIXCOMMITTED&field.assignee=&field.bug_reporter=&field.omit_dupes=on&field.has_patch=&field.has_no_package= | 21:51 |
*** rk4n has joined #openstack-nova | 21:52 | |
*** rtheis has quit IRC | 21:52 | |
*** shaohe_feng has quit IRC | 21:52 | |
*** shaohe_feng has joined #openstack-nova | 21:53 | |
mriedem | see bug 1378689 | 21:53 |
openstack | bug 1378689 in OpenStack Compute (nova) "error when rebuilding a instance booted from volume" [Undecided,Confirmed] https://launchpad.net/bugs/1378689 | 21:53 |
*** smatzek has joined #openstack-nova | 21:53 | |
*** tbachman has quit IRC | 21:54 | |
*** dims has quit IRC | 21:56 | |
*** burt has quit IRC | 21:57 | |
*** ndipanov has quit IRC | 21:57 | |
*** tbachman has joined #openstack-nova | 21:57 | |
*** dims has joined #openstack-nova | 21:58 | |
*** ducttape_ has quit IRC | 21:59 | |
*** Sukhdev has joined #openstack-nova | 21:59 | |
*** haomaiwang has quit IRC | 22:01 | |
*** shaohe_feng has quit IRC | 22:01 | |
*** ducttape_ has joined #openstack-nova | 22:01 | |
*** haomaiwang has joined #openstack-nova | 22:01 | |
*** thorst_ has quit IRC | 22:02 | |
*** eharney has quit IRC | 22:04 | |
*** shaohe_feng has joined #openstack-nova | 22:04 | |
*** thorst_ has joined #openstack-nova | 22:05 | |
*** dimtruck is now known as zz_dimtruck | 22:07 | |
*** thorst_ has quit IRC | 22:09 | |
*** knikolla has quit IRC | 22:10 | |
*** eharney has joined #openstack-nova | 22:11 | |
*** shaohe_feng has quit IRC | 22:13 | |
*** shaohe_feng has joined #openstack-nova | 22:13 | |
*** Sukhdev has quit IRC | 22:14 | |
*** sdague_ has quit IRC | 22:17 | |
*** sdague has quit IRC | 22:17 | |
*** burgerk_ has joined #openstack-nova | 22:18 | |
*** jaugustine has quit IRC | 22:19 | |
*** derekh has quit IRC | 22:19 | |
*** roeyc1 has quit IRC | 22:19 | |
*** david-lyle has quit IRC | 22:19 | |
mriedem | rlrossi__: fyi https://review.openstack.org/#/c/288966/ | 22:19 |
rlrossi__ | i no | 22:20 |
*** dave-mccowan has quit IRC | 22:20 | |
*** david-lyle has joined #openstack-nova | 22:20 | |
rlrossi__ | stop pasting it at me | 22:20 |
*** burgerk has quit IRC | 22:21 | |
*** drankis has quit IRC | 22:21 | |
*** krtaylor has quit IRC | 22:23 | |
*** shaohe_feng has quit IRC | 22:23 | |
*** shaohe_feng has joined #openstack-nova | 22:24 | |
*** thorst_ has joined #openstack-nova | 22:24 | |
*** angdraug has joined #openstack-nova | 22:28 | |
*** dims has quit IRC | 22:29 | |
*** burgerk_ has quit IRC | 22:29 | |
*** smatzek has quit IRC | 22:29 | |
*** mriedem has quit IRC | 22:31 | |
*** shaohe_feng has quit IRC | 22:33 | |
*** shaohe_feng has joined #openstack-nova | 22:34 | |
*** pushkaru has quit IRC | 22:34 | |
*** dave-mccowan has joined #openstack-nova | 22:34 | |
*** drankis has joined #openstack-nova | 22:35 | |
*** yamahata has quit IRC | 22:35 | |
*** krtaylor has joined #openstack-nova | 22:36 | |
*** zz_dimtruck is now known as dimtruck | 22:38 | |
*** zenoway has quit IRC | 22:38 | |
*** drankis has quit IRC | 22:39 | |
tristanC | dansmith: lyarwood: mdbooth: so, backports of I02f8a5f0e29816336e500a8fe8dcc9ece15968e9 seems ok. could we please merge them after Idfc16f54049aaeab31ac1c1d8d79a129acc9fb87 on stable branch ? for the record, this is the advisory errata: https://review.openstack.org/290872 | 22:39 |
dansmith | tristanC: it hasn't even landed on master yet, but regardless, it's up to mriedem | 22:40 |
*** shaohe_feng has quit IRC | 22:43 | |
*** shaohe_feng has joined #openstack-nova | 22:44 | |
*** Sukhdev has joined #openstack-nova | 22:44 | |
*** dims has joined #openstack-nova | 22:44 | |
*** Sukhdev has quit IRC | 22:46 | |
*** rlrossi__ has quit IRC | 22:46 | |
*** thorst_ has quit IRC | 22:51 | |
*** thorst_ has joined #openstack-nova | 22:52 | |
*** RuiChen has joined #openstack-nova | 22:52 | |
*** shaohe_feng has quit IRC | 22:54 | |
*** zenoway has joined #openstack-nova | 22:54 | |
*** shaohe_feng has joined #openstack-nova | 22:54 | |
*** browne has quit IRC | 22:55 | |
*** Sukhdev has joined #openstack-nova | 22:55 | |
*** baoli has quit IRC | 22:57 | |
*** Sukhdev has quit IRC | 23:01 | |
*** zenoway has quit IRC | 23:01 | |
*** pwnall has quit IRC | 23:01 | |
*** jichen has quit IRC | 23:01 | |
*** baoli has joined #openstack-nova | 23:01 | |
*** mariusv has quit IRC | 23:01 | |
*** lunarlamp is now known as mariusv | 23:01 | |
*** thorst_ has quit IRC | 23:01 | |
*** haomaiwang has quit IRC | 23:01 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!