*** openstack has joined #openstack-nova | 00:10 | |
*** ducttape_ has quit IRC | 00:12 | |
*** davideag_ has quit IRC | 00:14 | |
*** davideagnello has joined #openstack-nova | 00:14 | |
*** shaohe_feng has quit IRC | 00:16 | |
*** shaohe_feng has joined #openstack-nova | 00:16 | |
*** openstackgerrit has quit IRC | 00:17 | |
*** dimtruck is now known as zz_dimtruck | 00:17 | |
*** openstackgerrit has joined #openstack-nova | 00:18 | |
*** dave-mccowan has joined #openstack-nova | 00:20 | |
*** vilobhmm11 has joined #openstack-nova | 00:20 | |
*** haukebruno has joined #openstack-nova | 00:22 | |
*** shaohe_feng has quit IRC | 00:26 | |
*** irenab has quit IRC | 00:26 | |
*** shaohe_feng has joined #openstack-nova | 00:26 | |
*** irenab has joined #openstack-nova | 00:29 | |
*** yamahata has joined #openstack-nova | 00:29 | |
*** dims has quit IRC | 00:35 | |
*** shaohe_feng has quit IRC | 00:36 | |
*** rk4n has quit IRC | 00:37 | |
*** shaohe_feng has joined #openstack-nova | 00:38 | |
*** BobBall_ has joined #openstack-nova | 00:43 | |
*** BobBall_ is now known as Guest3102 | 00:44 | |
*** vilobhmm11 has quit IRC | 00:44 | |
*** isq_ has joined #openstack-nova | 00:46 | |
*** shaohe_feng has quit IRC | 00:46 | |
*** shaohe_feng has joined #openstack-nova | 00:46 | |
*** aysyd has quit IRC | 00:47 | |
*** cfriesen__ has joined #openstack-nova | 00:47 | |
*** Nakato_ has joined #openstack-nova | 00:48 | |
*** clduser_ has joined #openstack-nova | 00:48 | |
*** allen_gao has quit IRC | 00:49 | |
*** efried has quit IRC | 00:49 | |
*** cfriesen_ has quit IRC | 00:49 | |
*** mkoderer__ has quit IRC | 00:49 | |
*** harlowja_at_home has quit IRC | 00:49 | |
*** zzzeek has quit IRC | 00:49 | |
*** gmann has quit IRC | 00:49 | |
*** clduser has quit IRC | 00:49 | |
*** edleafe has quit IRC | 00:49 | |
*** BobBall has quit IRC | 00:49 | |
*** jbernard_ has quit IRC | 00:49 | |
*** ccesario has quit IRC | 00:49 | |
*** isq has quit IRC | 00:49 | |
*** jdillaman has quit IRC | 00:49 | |
*** Nakato has quit IRC | 00:49 | |
*** gmann has joined #openstack-nova | 00:49 | |
*** ccesario has joined #openstack-nova | 00:49 | |
*** harlowja_at_home has joined #openstack-nova | 00:50 | |
*** allen_gao has joined #openstack-nova | 00:50 | |
*** mkoderer___ has joined #openstack-nova | 00:50 | |
*** jbernard_ has joined #openstack-nova | 00:50 | |
*** zzzeek has joined #openstack-nova | 00:50 | |
*** efried has joined #openstack-nova | 00:51 | |
*** edleafe has joined #openstack-nova | 00:52 | |
*** jdillaman has joined #openstack-nova | 00:52 | |
*** ssurana has quit IRC | 00:55 | |
*** shaohe_feng has quit IRC | 00:57 | |
*** jschlueter has joined #openstack-nova | 00:57 | |
*** shaohe_feng has joined #openstack-nova | 00:57 | |
*** Jeffrey4l has joined #openstack-nova | 00:59 | |
*** haomaiwang has quit IRC | 01:01 | |
*** haomaiwang has joined #openstack-nova | 01:01 | |
*** markus_z has quit IRC | 01:04 | |
*** Jeffrey4l has quit IRC | 01:04 | |
*** shaohe_feng has quit IRC | 01:07 | |
*** shaohe_feng has joined #openstack-nova | 01:08 | |
*** markusz has joined #openstack-nova | 01:08 | |
*** ducttape_ has joined #openstack-nova | 01:08 | |
*** angdraug has quit IRC | 01:09 | |
*** Daisy has joined #openstack-nova | 01:11 | |
*** ducttape_ has quit IRC | 01:14 | |
*** wasmum has quit IRC | 01:15 | |
*** ducttape_ has joined #openstack-nova | 01:15 | |
*** yonglihe has joined #openstack-nova | 01:15 | |
*** thorst_ has quit IRC | 01:15 | |
*** Daisy has quit IRC | 01:16 | |
*** shaohe_feng has quit IRC | 01:17 | |
*** thorst_ has joined #openstack-nova | 01:17 | |
*** shaohe_feng has joined #openstack-nova | 01:17 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: tests: fix false positive in test_set_host_enabled* https://review.openstack.org/290919 | 01:18 |
---|---|---|
*** Sukhdev has joined #openstack-nova | 01:20 | |
*** wasmum has joined #openstack-nova | 01:20 | |
*** RuiChen has quit IRC | 01:20 | |
*** RuiChen has joined #openstack-nova | 01:21 | |
*** Sukhdev has quit IRC | 01:22 | |
*** RuiChen has quit IRC | 01:23 | |
*** RuiChen has joined #openstack-nova | 01:24 | |
*** thorst_ has quit IRC | 01:24 | |
*** RuiChen has quit IRC | 01:24 | |
*** Sukhdev has joined #openstack-nova | 01:24 | |
*** mriedem has joined #openstack-nova | 01:25 | |
*** RuiChen has joined #openstack-nova | 01:25 | |
*** RuiChen has quit IRC | 01:25 | |
*** RuiChen has joined #openstack-nova | 01:26 | |
*** RuiChen has quit IRC | 01:27 | |
*** allen_gao has quit IRC | 01:27 | |
*** shaohe_feng has quit IRC | 01:27 | |
*** Sukhdev has quit IRC | 01:27 | |
*** RuiChen has joined #openstack-nova | 01:28 | |
*** Sukhdev has joined #openstack-nova | 01:28 | |
*** aorourke is now known as aorourke-afk | 01:28 | |
*** RuiChen has quit IRC | 01:28 | |
*** RuiChen has joined #openstack-nova | 01:29 | |
*** shaohe_feng has joined #openstack-nova | 01:30 | |
*** dims has joined #openstack-nova | 01:31 | |
mriedem | i wonder if we can enable live snapshots in the ceph job, or if the issues with libvirt 1.2.2 would also happen in the ceph job | 01:32 |
*** RuiChen has quit IRC | 01:32 | |
*** RuiChen has joined #openstack-nova | 01:33 | |
*** shaohe_feng has quit IRC | 01:38 | |
*** rk4n has joined #openstack-nova | 01:38 | |
*** allen_gao has joined #openstack-nova | 01:38 | |
*** shaohe_feng has joined #openstack-nova | 01:39 | |
*** Sukhdev has quit IRC | 01:39 | |
*** Sukhdev has joined #openstack-nova | 01:39 | |
*** zenoway has joined #openstack-nova | 01:39 | |
*** Sukhdev has quit IRC | 01:41 | |
*** Sukhdev has joined #openstack-nova | 01:42 | |
*** mtanino has quit IRC | 01:43 | |
*** zenoway has quit IRC | 01:43 | |
*** edmondsw has quit IRC | 01:44 | |
*** rk4n has quit IRC | 01:45 | |
*** ducttape_ has quit IRC | 01:45 | |
*** armax has quit IRC | 01:46 | |
*** Sukhdev has quit IRC | 01:46 | |
*** Sukhdev_ has joined #openstack-nova | 01:46 | |
auggy | i'm trying to start up my devstack and i keep getting this error from the nova api startup "ImportError: cannot import name secretutils" | 01:47 |
auggy | i tried doing a pip upgrade on oslo.utils but it says it's up to date?? yargh i'm so confused | 01:47 |
*** shaohe_feng has quit IRC | 01:48 | |
*** shaohe_feng has joined #openstack-nova | 01:49 | |
*** Sukhdev has joined #openstack-nova | 01:49 | |
dims | auggy : i typically go to my /opt/stack/nova and run "pip install -U -r requirements.txt -r test-requirements.txt" to update to latest of everything | 01:49 |
*** Sukhdev_ has quit IRC | 01:49 | |
auggy | dims: oh right, thanks, i usually do that too ;D | 01:49 |
* auggy is on pain meds for a back issue so a little spacy | 01:49 | |
*** fawadk has quit IRC | 01:49 | |
auggy | i'll see if that gets me the right thing | 01:49 |
*** Sukhdev has quit IRC | 01:51 | |
*** Sukhdev has joined #openstack-nova | 01:52 | |
*** mingyu has joined #openstack-nova | 01:52 | |
*** thorst_ has joined #openstack-nova | 01:52 | |
auggy | dims: thanks that totally works | 01:53 |
*** Sukhdev has quit IRC | 01:53 | |
* auggy slaps forehead | 01:53 | |
dims | auggy : been there done that :) | 01:53 |
*** Sukhdev has joined #openstack-nova | 01:54 | |
auggy | :) | 01:54 |
*** gongysh has joined #openstack-nova | 01:55 | |
*** Sukhdev has quit IRC | 01:56 | |
*** Sukhdev has joined #openstack-nova | 01:56 | |
*** Jeffrey4l has joined #openstack-nova | 01:57 | |
*** Sukhdev has quit IRC | 01:58 | |
*** shaohe_feng has quit IRC | 01:58 | |
*** haomaiwang has quit IRC | 01:58 | |
*** Sukhdev has joined #openstack-nova | 01:59 | |
*** shaohe_feng has joined #openstack-nova | 01:59 | |
*** Sukhdev has quit IRC | 02:01 | |
*** Sukhdev has joined #openstack-nova | 02:01 | |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 02:04 |
*** fawadkhaliq has joined #openstack-nova | 02:05 | |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 02:05 |
*** diana_clarke2 has quit IRC | 02:06 | |
*** shaohe_feng has quit IRC | 02:08 | |
*** shaohe_feng has joined #openstack-nova | 02:09 | |
dansmith | mriedem: do you want to go ahead and land those ceph fixes on stable or what? | 02:16 |
dansmith | mriedem: ah, nevermind | 02:17 |
*** hoangcx has joined #openstack-nova | 02:18 | |
*** thorst_ has quit IRC | 02:18 | |
*** shaohe_feng has quit IRC | 02:19 | |
*** thorst_ has joined #openstack-nova | 02:19 | |
*** shaohe_feng has joined #openstack-nova | 02:20 | |
mriedem | dansmith: wayyyy ahead of you | 02:20 |
mriedem | dansmith: also, you might get the itch to -2 this https://review.openstack.org/#/c/289813/ | 02:20 |
dansmith | o.my | 02:21 |
*** Sukhdev_ has joined #openstack-nova | 02:24 | |
*** Sukhdev has quit IRC | 02:24 | |
*** baoli has joined #openstack-nova | 02:27 | |
*** thorst_ has quit IRC | 02:28 | |
*** shaohe_feng has quit IRC | 02:29 | |
*** shaohe_feng has joined #openstack-nova | 02:30 | |
*** Sukhdev_ has quit IRC | 02:30 | |
*** Sukhdev has joined #openstack-nova | 02:31 | |
*** Sukhdev has quit IRC | 02:35 | |
*** Sukhdev has joined #openstack-nova | 02:35 | |
*** zenoway has joined #openstack-nova | 02:38 | |
*** ociuhandu has quit IRC | 02:38 | |
*** Sukhdev has quit IRC | 02:38 | |
*** ociuhandu has joined #openstack-nova | 02:39 | |
*** Sukhdev has joined #openstack-nova | 02:39 | |
*** shaohe_feng has quit IRC | 02:39 | |
*** baoli has quit IRC | 02:40 | |
*** shaohe_feng has joined #openstack-nova | 02:40 | |
*** eharney has quit IRC | 02:40 | |
*** Jeffrey4l has quit IRC | 02:41 | |
*** tbachman has quit IRC | 02:41 | |
*** zenoway has quit IRC | 02:42 | |
*** Sukhdev has quit IRC | 02:42 | |
*** Sukhdev has joined #openstack-nova | 02:42 | |
*** Jeffrey4l has joined #openstack-nova | 02:44 | |
*** Sukhdev has quit IRC | 02:45 | |
*** Sukhdev has joined #openstack-nova | 02:46 | |
*** houming has joined #openstack-nova | 02:47 | |
*** efried has quit IRC | 02:47 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Set personality/injected_files to empty list if not specified https://review.openstack.org/248662 | 02:48 |
*** Sukhdev has quit IRC | 02:48 | |
*** Sukhdev has joined #openstack-nova | 02:49 | |
*** shaohe_feng has quit IRC | 02:49 | |
*** shaohe_feng has joined #openstack-nova | 02:50 | |
*** Sukhdev has quit IRC | 02:52 | |
*** Sukhdev has joined #openstack-nova | 02:52 | |
*** fawadkhaliq has quit IRC | 02:53 | |
*** Marga_ has quit IRC | 02:54 | |
*** Sukhdev has quit IRC | 02:55 | |
*** Sukhdev_ has joined #openstack-nova | 02:55 | |
mriedem | tonyb: normally i wouldn't do https://review.openstack.org/#/c/289428/ but it's needed to get the tempest change to land https://review.openstack.org/#/c/288966/ | 02:55 |
*** Marga_ has joined #openstack-nova | 02:56 | |
*** Sukhdev_ has quit IRC | 02:58 | |
*** Sukhdev has joined #openstack-nova | 02:59 | |
*** shaohe_feng has quit IRC | 03:00 | |
*** dansmith has quit IRC | 03:01 | |
*** shaohe_feng has joined #openstack-nova | 03:01 | |
*** Marga_ has quit IRC | 03:01 | |
*** dansmith has joined #openstack-nova | 03:01 | |
*** Sukhdev has quit IRC | 03:01 | |
*** RuiChen has quit IRC | 03:02 | |
*** Sukhdev has joined #openstack-nova | 03:02 | |
*** RuiChen has joined #openstack-nova | 03:03 | |
*** Sukhdev has quit IRC | 03:05 | |
*** Sukhdev_ has joined #openstack-nova | 03:05 | |
mriedem | holy crap maybe we should fix this in newton https://blueprints.launchpad.net/nova/+spec/validate-project-with-keystone | 03:05 |
mriedem | check the ever expanding list of bugs for that | 03:06 |
mriedem | auggy: maybe something you want to tackle in newton? ^ | 03:06 |
mriedem | there was POC code at one point, would just have to be revived and polished | 03:06 |
auggy | mriedem: sure i'll take a look | 03:07 |
auggy | wow lots of bugs against that one | 03:08 |
*** Sukhdev_ has quit IRC | 03:08 | |
*** Sukhdev has joined #openstack-nova | 03:08 | |
* auggy has been wrasslin with dev environments today | 03:08 | |
mriedem | basically, | 03:08 |
mriedem | our quota-update API allows you to pass garbage for a tenant | 03:09 |
mriedem | if the quotas don't exist for the tenant, it creates new defaults for it | 03:09 |
mriedem | even if the tenant doesn't actually exist in keystone | 03:09 |
auggy | oh lovely | 03:09 |
mriedem | so it's just a change to add a validation of the tenant in keystone | 03:09 |
mriedem | but it was awhile ago when i dug into that one, and there might be more to it | 03:09 |
*** shaohe_feng has quit IRC | 03:10 | |
auggy | oh there always is | 03:10 |
* auggy has come to expect it ;D | 03:10 | |
*** thorst_ has joined #openstack-nova | 03:10 | |
auggy | should i try to contact the spec owner or just take over the spec? | 03:10 |
*** ducttape_ has joined #openstack-nova | 03:11 | |
*** shaohe_feng has joined #openstack-nova | 03:11 | |
*** ducttape_ has quit IRC | 03:11 | |
*** Sukhdev_ has joined #openstack-nova | 03:11 | |
*** Sukhdev has quit IRC | 03:11 | |
openstackgerrit | Jiajun Liu proposed openstack/nova: Replace deprecated LOG.warn with LOG.warning https://review.openstack.org/290958 | 03:12 |
*** tbachman has joined #openstack-nova | 03:12 | |
*** zenoway has joined #openstack-nova | 03:13 | |
*** Sukhdev_ has quit IRC | 03:14 | |
*** thorst_ has quit IRC | 03:14 | |
*** dims has quit IRC | 03:14 | |
*** Sukhdev has joined #openstack-nova | 03:14 | |
mriedem | auggy: you could try contacting them first | 03:14 |
*** baoli has joined #openstack-nova | 03:14 | |
mriedem | but if no dice, just take it over | 03:14 |
*** thorst_ has joined #openstack-nova | 03:15 | |
auggy | mriedem: sure thing | 03:15 |
*** Sukhdev has quit IRC | 03:15 | |
* auggy adds it to her todo list | 03:15 | |
auggy | mriedem: thanks for thinking of me! | 03:15 |
mriedem | np | 03:16 |
mriedem | maybe you can justify working on it with sdague because it remotely has something to do with project IDs | 03:16 |
mriedem | and he hates all of that stuff | 03:17 |
*** zz_dimtruck is now known as dimtruck | 03:17 | |
* mriedem sneaks off for the night, ttyl | 03:17 | |
*** mriedem has quit IRC | 03:17 | |
*** zenoway has quit IRC | 03:17 | |
*** apoorvad has quit IRC | 03:18 | |
*** shaohe_feng has quit IRC | 03:20 | |
*** shaohe_feng has joined #openstack-nova | 03:21 | |
tonyb | mriedem: That's basically what I thought. I'm just a little worried about setting a "we'll do this for tempest" precedent | 03:21 |
*** thorst_ has quit IRC | 03:23 | |
*** bapalm has quit IRC | 03:24 | |
*** baoli has quit IRC | 03:24 | |
*** fawadkhaliq has joined #openstack-nova | 03:24 | |
*** RuiChen has quit IRC | 03:24 | |
*** RuiChen has joined #openstack-nova | 03:26 | |
*** markvoelker has joined #openstack-nova | 03:29 | |
*** shaohe_feng has quit IRC | 03:30 | |
*** shaohe_feng has joined #openstack-nova | 03:31 | |
*** fawadkhaliq has quit IRC | 03:34 | |
*** houming has quit IRC | 03:39 | |
*** shaohe_feng has quit IRC | 03:41 | |
*** shaohe_feng has joined #openstack-nova | 03:41 | |
*** bapalm has joined #openstack-nova | 03:43 | |
*** rk4n has joined #openstack-nova | 03:43 | |
*** markvoelker has quit IRC | 03:43 | |
*** RuiChen has quit IRC | 03:45 | |
*** houming has joined #openstack-nova | 03:45 | |
*** rk4n has quit IRC | 03:47 | |
*** rk4n has joined #openstack-nova | 03:47 | |
*** yamahata has quit IRC | 03:49 | |
*** zenoway has joined #openstack-nova | 03:49 | |
*** Marga_ has joined #openstack-nova | 03:50 | |
*** links has joined #openstack-nova | 03:50 | |
*** shaohe_feng has quit IRC | 03:51 | |
*** Marga_ has quit IRC | 03:51 | |
*** shaohe_feng has joined #openstack-nova | 03:51 | |
*** Marga_ has joined #openstack-nova | 03:51 | |
*** zenoway has quit IRC | 03:53 | |
*** diana_clarke1 has joined #openstack-nova | 03:54 | |
*** vilobhmm11 has joined #openstack-nova | 03:58 | |
*** shaohe_feng has quit IRC | 04:01 | |
*** dims has joined #openstack-nova | 04:01 | |
*** shaohe_feng has joined #openstack-nova | 04:02 | |
*** jwcroppe has joined #openstack-nova | 04:02 | |
*** jaosorior has quit IRC | 04:02 | |
*** jaosorior has joined #openstack-nova | 04:03 | |
*** mingyu has quit IRC | 04:03 | |
*** gjayavel_ has joined #openstack-nova | 04:05 | |
*** vilobhmm11 has quit IRC | 04:10 | |
*** gongysh has quit IRC | 04:11 | |
*** shaohe_feng has quit IRC | 04:11 | |
*** shaohe_feng has joined #openstack-nova | 04:12 | |
*** dims has quit IRC | 04:13 | |
*** nikhil has joined #openstack-nova | 04:15 | |
*** vilobhmm11 has joined #openstack-nova | 04:16 | |
*** thorst_ has joined #openstack-nova | 04:21 | |
*** shaohe_feng has quit IRC | 04:22 | |
*** shaohe_feng has joined #openstack-nova | 04:23 | |
*** zenoway has joined #openstack-nova | 04:25 | |
*** mingyu has joined #openstack-nova | 04:26 | |
*** shaohe_feng has quit IRC | 04:28 | |
*** thorst_ has quit IRC | 04:28 | |
*** zenoway has quit IRC | 04:29 | |
*** shaohe_feng_ has joined #openstack-nova | 04:30 | |
*** mingyu has quit IRC | 04:30 | |
*** shaohe_feng has joined #openstack-nova | 04:33 | |
*** shaohe_feng_ has quit IRC | 04:36 | |
*** amotoki has joined #openstack-nova | 04:38 | |
*** harlowja_at_home has quit IRC | 04:39 | |
*** harlowja_at_home has joined #openstack-nova | 04:39 | |
*** sudipto has joined #openstack-nova | 04:41 | |
*** jamielennox is now known as jamielennox|away | 04:41 | |
*** shaohe_feng has quit IRC | 04:42 | |
*** shaohe_feng has joined #openstack-nova | 04:43 | |
yonglihe | mriedem, ping | 04:47 |
*** DinaBelova has quit IRC | 04:51 | |
*** kragniz has quit IRC | 04:52 | |
*** shaohe_feng has quit IRC | 04:52 | |
*** shaohe_feng has joined #openstack-nova | 04:53 | |
*** DinaBelova has joined #openstack-nova | 04:53 | |
yonglihe | mriedem: it's seems late for you, will try to find you next day. i leave the summary message here: about SRIOV testing for Nova, for our CI, SRIOV now just post on Neutron, and is different configurations/setup/machines. To get it work for nova, it's like a new CI internally perspective. let's discuss this when you back. | 04:53 |
*** kragniz has joined #openstack-nova | 04:54 | |
yonglihe | mriedem: in case you did not catch me, send me email also work. | 04:54 |
*** heyongli has joined #openstack-nova | 04:57 | |
*** heyongli has quit IRC | 05:00 | |
*** heyongli has joined #openstack-nova | 05:00 | |
*** zenoway has joined #openstack-nova | 05:00 | |
*** shaohe_feng has quit IRC | 05:03 | |
*** shaohe_feng has joined #openstack-nova | 05:03 | |
*** zenoway has quit IRC | 05:04 | |
*** kragniz has quit IRC | 05:05 | |
*** kragniz has joined #openstack-nova | 05:05 | |
*** heyongli has quit IRC | 05:10 | |
*** heyongli has joined #openstack-nova | 05:10 | |
*** houming has quit IRC | 05:11 | |
*** shaohe_feng has quit IRC | 05:13 | |
*** shaohe_feng has joined #openstack-nova | 05:13 | |
*** Jeffrey4l has quit IRC | 05:15 | |
*** heyongli has quit IRC | 05:20 | |
*** heyongli has joined #openstack-nova | 05:20 | |
*** EinstCrazy has joined #openstack-nova | 05:21 | |
*** shaohe_feng has quit IRC | 05:23 | |
*** shaohe_feng has joined #openstack-nova | 05:24 | |
*** dimtruck is now known as zz_dimtruck | 05:25 | |
*** mdrabe has quit IRC | 05:25 | |
*** jwcroppe has quit IRC | 05:25 | |
*** zz_dimtruck is now known as dimtruck | 05:25 | |
*** jwcroppe has joined #openstack-nova | 05:25 | |
*** thorst_ has joined #openstack-nova | 05:26 | |
*** jwcroppe has quit IRC | 05:30 | |
*** heyongli has quit IRC | 05:30 | |
*** hieulq has joined #openstack-nova | 05:31 | |
*** hieulq has quit IRC | 05:31 | |
*** FL1SK has quit IRC | 05:32 | |
*** thorst_ has quit IRC | 05:33 | |
*** sridharg has joined #openstack-nova | 05:33 | |
*** shaohe_feng has quit IRC | 05:33 | |
*** shaohe_feng has joined #openstack-nova | 05:34 | |
*** baoli has joined #openstack-nova | 05:36 | |
*** zenoway has joined #openstack-nova | 05:36 | |
*** y_sawai has joined #openstack-nova | 05:36 | |
*** harlowja_at_home has quit IRC | 05:36 | |
*** jaosorior has quit IRC | 05:40 | |
*** dansmith has quit IRC | 05:40 | |
*** yonglihe has quit IRC | 05:40 | |
*** cfriesen__ has quit IRC | 05:40 | |
*** whenry has quit IRC | 05:40 | |
*** cfarquhar has quit IRC | 05:40 | |
*** baoli has quit IRC | 05:40 | |
*** zenoway has quit IRC | 05:40 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID https://review.openstack.org/287702 | 05:40 |
*** shaohe_feng has quit IRC | 05:44 | |
*** shaohe_feng has joined #openstack-nova | 05:45 | |
*** dansmith has joined #openstack-nova | 05:46 | |
*** yonglihe has joined #openstack-nova | 05:46 | |
*** cfriesen__ has joined #openstack-nova | 05:46 | |
*** whenry has joined #openstack-nova | 05:46 | |
*** cfarquhar has joined #openstack-nova | 05:46 | |
*** jaosorior has joined #openstack-nova | 05:46 | |
*** jaosorior has quit IRC | 05:46 | |
*** 16WAADQPV has joined #openstack-nova | 05:49 | |
*** armax has joined #openstack-nova | 05:50 | |
*** irenab has quit IRC | 05:51 | |
*** shaohe_feng has quit IRC | 05:54 | |
*** melwitt has quit IRC | 05:54 | |
*** shaohe_feng has joined #openstack-nova | 05:55 | |
*** brad[] has quit IRC | 05:56 | |
*** med_ has quit IRC | 05:56 | |
*** mfisch has quit IRC | 05:56 | |
*** med_ has joined #openstack-nova | 05:56 | |
*** brad[] has joined #openstack-nova | 05:56 | |
*** med_ is now known as Guest93664 | 05:56 | |
*** mingyu has joined #openstack-nova | 05:57 | |
*** melwitt has joined #openstack-nova | 05:58 | |
*** mingyu has quit IRC | 05:59 | |
*** 16WAADQPV has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-nova | 06:01 | |
*** rk4n has quit IRC | 06:02 | |
*** shaohe_feng has quit IRC | 06:02 | |
*** dansmith has quit IRC | 06:02 | |
*** yonglihe has quit IRC | 06:02 | |
*** cfriesen__ has quit IRC | 06:02 | |
*** whenry has quit IRC | 06:02 | |
*** cfarquhar has quit IRC | 06:02 | |
*** dimtruck is now known as zz_dimtruck | 06:03 | |
*** EinstCrazy has quit IRC | 06:05 | |
*** shaohe_feng has joined #openstack-nova | 06:05 | |
*** fawadkhaliq has joined #openstack-nova | 06:07 | |
*** dansmith has joined #openstack-nova | 06:08 | |
*** yonglihe has joined #openstack-nova | 06:08 | |
*** cfriesen__ has joined #openstack-nova | 06:08 | |
*** whenry has joined #openstack-nova | 06:08 | |
*** cfarquhar has joined #openstack-nova | 06:08 | |
openstackgerrit | ZhiQiang Fan proposed openstack/nova: Use oslo_config new type PortOpt for port options https://review.openstack.org/238347 | 06:09 |
*** zenoway has joined #openstack-nova | 06:11 | |
*** mingyu has joined #openstack-nova | 06:13 | |
*** gjayave__ has joined #openstack-nova | 06:14 | |
*** shaohe_feng has quit IRC | 06:14 | |
*** zenoway has quit IRC | 06:17 | |
*** gjayavel_ has quit IRC | 06:17 | |
*** shaohe_feng has joined #openstack-nova | 06:17 | |
*** ivase_ has joined #openstack-nova | 06:17 | |
*** rk4n has joined #openstack-nova | 06:19 | |
*** ivase has quit IRC | 06:20 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/288845 | 06:21 |
*** bapalm has quit IRC | 06:23 | |
*** shaohe_feng has quit IRC | 06:25 | |
*** shaohe_feng has joined #openstack-nova | 06:26 | |
*** mfisch has joined #openstack-nova | 06:27 | |
*** mfisch is now known as Guest38484 | 06:27 | |
*** fawadkhaliq has quit IRC | 06:30 | |
*** diana_clarke1 has quit IRC | 06:30 | |
*** thorst_ has joined #openstack-nova | 06:31 | |
*** shaohe_feng has quit IRC | 06:35 | |
*** shaohe_feng has joined #openstack-nova | 06:36 | |
*** thorst_ has quit IRC | 06:38 | |
*** sridharg has quit IRC | 06:40 | |
*** bapalm has joined #openstack-nova | 06:42 | |
*** melwitt has quit IRC | 06:45 | |
*** shaohe_feng has quit IRC | 06:45 | |
*** shaohe_feng has joined #openstack-nova | 06:46 | |
*** zenoway has joined #openstack-nova | 06:47 | |
*** irenab has joined #openstack-nova | 06:47 | |
*** melwitt has joined #openstack-nova | 06:50 | |
*** esracelik has joined #openstack-nova | 06:50 | |
*** melwitt is now known as Guest98534 | 06:50 | |
*** mjura has joined #openstack-nova | 06:51 | |
*** gongysh has joined #openstack-nova | 06:51 | |
*** nkrinner has joined #openstack-nova | 06:53 | |
*** dave-mccowan has quit IRC | 06:55 | |
*** shaohe_feng has quit IRC | 06:55 | |
*** Guest98534 is now known as melwitt | 06:55 | |
*** shaohe_feng has joined #openstack-nova | 06:56 | |
*** melwitt has quit IRC | 06:58 | |
*** mingyu has quit IRC | 06:59 | |
*** melwitt has joined #openstack-nova | 06:59 | |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-nova | 07:01 | |
*** melwitt has quit IRC | 07:03 | |
*** haomaiwang has quit IRC | 07:04 | |
*** melwitt has joined #openstack-nova | 07:04 | |
*** haomaiwang has joined #openstack-nova | 07:04 | |
*** melwitt is now known as Guest37020 | 07:05 | |
*** obondarev has quit IRC | 07:05 | |
*** shaohe_feng has quit IRC | 07:06 | |
*** shaohe_feng has joined #openstack-nova | 07:07 | |
*** obondarev has joined #openstack-nova | 07:07 | |
*** yamahata has joined #openstack-nova | 07:07 | |
*** shaohe_feng has quit IRC | 07:09 | |
*** paul-carlton2 has joined #openstack-nova | 07:10 | |
*** mingyu has joined #openstack-nova | 07:12 | |
*** moshele has joined #openstack-nova | 07:13 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID https://review.openstack.org/287702 | 07:14 |
*** vishwanathj is now known as vishwanathj_zzz | 07:15 | |
*** Kennan has quit IRC | 07:18 | |
*** sc68cal has quit IRC | 07:22 | |
*** sridharg has joined #openstack-nova | 07:22 | |
*** ildikov has quit IRC | 07:22 | |
*** Kennan has joined #openstack-nova | 07:23 | |
*** hoangcx has quit IRC | 07:23 | |
*** liverpooler has quit IRC | 07:23 | |
*** lpetrut has joined #openstack-nova | 07:25 | |
*** Jeffrey4l has joined #openstack-nova | 07:26 | |
*** andreykurilin__ has joined #openstack-nova | 07:29 | |
*** melwitt_ has joined #openstack-nova | 07:30 | |
*** melwitt_ has quit IRC | 07:32 | |
*** hoangcx has joined #openstack-nova | 07:33 | |
*** scheuran has joined #openstack-nova | 07:33 | |
*** rcernin has joined #openstack-nova | 07:33 | |
*** ildikov has joined #openstack-nova | 07:34 | |
*** thorst_ has joined #openstack-nova | 07:36 | |
*** browne has quit IRC | 07:37 | |
*** melwitt_ has joined #openstack-nova | 07:39 | |
*** melwitt_ is now known as melwitt | 07:40 | |
*** melwitt has quit IRC | 07:40 | |
*** belmoreira has joined #openstack-nova | 07:41 | |
*** melwitt has joined #openstack-nova | 07:41 | |
*** rk4n has quit IRC | 07:41 | |
*** pece has joined #openstack-nova | 07:42 | |
*** pbrooko has joined #openstack-nova | 07:42 | |
*** thorst_ has quit IRC | 07:43 | |
*** nikhil has quit IRC | 07:45 | |
*** nikhil has joined #openstack-nova | 07:47 | |
*** rdopiera has joined #openstack-nova | 07:48 | |
*** baoli has joined #openstack-nova | 07:48 | |
*** palexster has joined #openstack-nova | 07:49 | |
*** mpavone has joined #openstack-nova | 07:52 | |
*** baoli has quit IRC | 07:53 | |
*** rk4n has joined #openstack-nova | 07:53 | |
*** e0ne has joined #openstack-nova | 07:53 | |
*** allen_gao has quit IRC | 07:54 | |
*** jlanoux has joined #openstack-nova | 07:55 | |
*** atuvenie has joined #openstack-nova | 07:57 | |
openstackgerrit | Jiajun Liu proposed openstack/nova: Replace deprecated LOG.warn with LOG.warning https://review.openstack.org/290958 | 07:58 |
*** erno has joined #openstack-nova | 07:59 | |
*** FL1SK has joined #openstack-nova | 08:00 | |
openstackgerrit | Moshe Levi proposed openstack/nova-specs: Add spec to enhance PCI passthrough whitelist to support regex https://review.openstack.org/291046 | 08:00 |
*** mpavone has quit IRC | 08:00 | |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-nova | 08:01 | |
*** mpavone has joined #openstack-nova | 08:01 | |
*** tbachman has quit IRC | 08:03 | |
*** allen_gao has joined #openstack-nova | 08:05 | |
*** tbachman has joined #openstack-nova | 08:07 | |
*** ihrachys has joined #openstack-nova | 08:07 | |
*** ihrachys has quit IRC | 08:08 | |
*** gjayave__ has quit IRC | 08:10 | |
*** rk4n has quit IRC | 08:11 | |
*** daemontool_ has joined #openstack-nova | 08:11 | |
*** hoangcx has quit IRC | 08:12 | |
*** ihrachys has joined #openstack-nova | 08:13 | |
*** paul-carlton2 has quit IRC | 08:14 | |
*** daemontool has quit IRC | 08:14 | |
*** armax has quit IRC | 08:17 | |
*** hoangcx has joined #openstack-nova | 08:17 | |
*** dedery has joined #openstack-nova | 08:20 | |
*** e0ne has quit IRC | 08:21 | |
*** e0ne has joined #openstack-nova | 08:25 | |
*** matrohon has joined #openstack-nova | 08:25 | |
*** jichen has joined #openstack-nova | 08:26 | |
*** lpetrut has quit IRC | 08:27 | |
*** gcb has joined #openstack-nova | 08:28 | |
*** pbrooko has quit IRC | 08:30 | |
*** rk4n has joined #openstack-nova | 08:31 | |
*** rk4n has quit IRC | 08:32 | |
*** rk4n has joined #openstack-nova | 08:32 | |
*** dguitarbite has quit IRC | 08:32 | |
*** paul-carlton2 has joined #openstack-nova | 08:32 | |
*** pbrooko has joined #openstack-nova | 08:32 | |
*** davideagnello has quit IRC | 08:32 | |
*** atuvenie has quit IRC | 08:33 | |
*** y_sawai has quit IRC | 08:33 | |
*** pcaruana has joined #openstack-nova | 08:34 | |
*** liverpooler has joined #openstack-nova | 08:34 | |
*** vishwanathj_zzz has quit IRC | 08:34 | |
*** vishwanathj_zzz has joined #openstack-nova | 08:35 | |
*** davideagnello has joined #openstack-nova | 08:35 | |
*** liverpooler has quit IRC | 08:35 | |
*** permalac has joined #openstack-nova | 08:35 | |
*** permalac has quit IRC | 08:35 | |
*** liverpooler has joined #openstack-nova | 08:35 | |
*** andreykurilin__ has quit IRC | 08:36 | |
*** betherly has quit IRC | 08:36 | |
*** angular_mike___ has quit IRC | 08:36 | |
*** zhiyan has quit IRC | 08:36 | |
*** zhenguo_ has quit IRC | 08:36 | |
*** fmccrthy has quit IRC | 08:36 | |
*** kgalanov has quit IRC | 08:36 | |
*** zzzeek has quit IRC | 08:36 | |
*** andrewbogott has quit IRC | 08:36 | |
*** ameade has quit IRC | 08:36 | |
*** scottda has quit IRC | 08:36 | |
*** junjie has quit IRC | 08:36 | |
*** zzzeek has joined #openstack-nova | 08:38 | |
*** zhiyan has joined #openstack-nova | 08:39 | |
*** scottda has joined #openstack-nova | 08:39 | |
*** ameade has joined #openstack-nova | 08:39 | |
*** betherly has joined #openstack-nova | 08:40 | |
*** permalac has joined #openstack-nova | 08:41 | |
*** permalac has quit IRC | 08:41 | |
*** thorst_ has joined #openstack-nova | 08:41 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary https://review.openstack.org/288373 | 08:41 |
*** kgalanov has joined #openstack-nova | 08:42 | |
*** fmccrthy has joined #openstack-nova | 08:42 | |
*** e0ne has quit IRC | 08:42 | |
*** permalac has joined #openstack-nova | 08:43 | |
permalac | hello guys. | 08:43 |
bauzas | good morning Nova | 08:43 |
*** josecastroleon has quit IRC | 08:44 | |
*** zhenguo_ has joined #openstack-nova | 08:44 | |
permalac | I have an issue with qemu-virsh and I can not migrate machines from one node to another. I looking at shared storage to do this for the future situations. Can I use swift as /var/lib/instances mountpoint ? Or how Should I do it? | 08:44 |
*** andrewbogott has joined #openstack-nova | 08:44 | |
*** andreykurilin__ has joined #openstack-nova | 08:44 | |
*** josecastroleon has joined #openstack-nova | 08:45 | |
*** gszasz has joined #openstack-nova | 08:46 | |
*** lpetrut has joined #openstack-nova | 08:46 | |
paul-carlton2 | bauzas, good morning, see my update of the release note on https://review.openstack.org/#/c/288373, hope this meets with everyones approval | 08:46 |
*** thorst_ has quit IRC | 08:48 | |
*** gjayavel_ has joined #openstack-nova | 08:48 | |
*** wuhao has quit IRC | 08:49 | |
*** wuhao has joined #openstack-nova | 08:49 | |
*** zhangjn has quit IRC | 08:49 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary https://review.openstack.org/288373 | 08:49 |
*** mingyu has quit IRC | 08:50 | |
*** junjie has joined #openstack-nova | 08:50 | |
*** angular_mike___ has joined #openstack-nova | 08:50 | |
*** mingyu has joined #openstack-nova | 08:50 | |
*** Jeffrey4l has quit IRC | 08:50 | |
*** pbrooko has quit IRC | 08:51 | |
*** Jeffrey4l has joined #openstack-nova | 08:51 | |
bauzas | paul-carlton2: sure, will do | 08:51 |
*** jaosorior has joined #openstack-nova | 08:52 | |
*** zhangjn has joined #openstack-nova | 08:55 | |
*** salv-orlando has joined #openstack-nova | 08:55 | |
*** pbrooko has joined #openstack-nova | 08:56 | |
*** paul-carlton2 has quit IRC | 08:57 | |
*** ishant has joined #openstack-nova | 08:58 | |
*** permalac_ has joined #openstack-nova | 09:00 | |
*** permalac_ has quit IRC | 09:00 | |
*** haomaiwang has quit IRC | 09:01 | |
*** permalac has quit IRC | 09:01 | |
*** haomaiwa_ has joined #openstack-nova | 09:01 | |
*** ndipanov has joined #openstack-nova | 09:03 | |
*** lpetrut has quit IRC | 09:03 | |
*** zz_dimtruck is now known as dimtruck | 09:03 | |
*** Jeffrey4l has quit IRC | 09:05 | |
*** mgoddard has joined #openstack-nova | 09:06 | |
*** pbrooko has quit IRC | 09:09 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: removed db_exc.DBDuplicateEntry in bw_usage_update https://review.openstack.org/250807 | 09:09 |
*** jaosorior has quit IRC | 09:09 | |
*** jaosorior has joined #openstack-nova | 09:09 | |
*** jistr has joined #openstack-nova | 09:09 | |
*** mvk has joined #openstack-nova | 09:10 | |
*** gcb has quit IRC | 09:11 | |
*** dimtruck is now known as zz_dimtruck | 09:12 | |
*** lucas-dinner is now known as lucasagomes | 09:14 | |
*** amotoki has quit IRC | 09:15 | |
*** danpb has joined #openstack-nova | 09:16 | |
*** salv-orlando has quit IRC | 09:20 | |
*** pbrooko has joined #openstack-nova | 09:21 | |
*** paul-carlton2 has joined #openstack-nova | 09:23 | |
*** gcb_ has joined #openstack-nova | 09:24 | |
*** pbrooko has quit IRC | 09:25 | |
*** efoley has joined #openstack-nova | 09:26 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: fixed log warning in sqlalchemy/api.py https://review.openstack.org/246901 | 09:29 |
*** openstackgerrit has quit IRC | 09:30 | |
*** openstackgerrit_ has joined #openstack-nova | 09:30 | |
*** openstackgerrit_ is now known as openstackgerrit | 09:31 | |
*** openstackgerrit has quit IRC | 09:31 | |
*** openstackgerrit_ has joined #openstack-nova | 09:31 | |
*** openstackgerrit_ is now known as openstackgerrit | 09:32 | |
*** openstackgerrit has quit IRC | 09:32 | |
*** openstackgerrit_ has joined #openstack-nova | 09:33 | |
*** openstackgerrit_ is now known as openstackgerrit | 09:33 | |
*** openstackgerrit has quit IRC | 09:33 | |
*** e0ne has joined #openstack-nova | 09:33 | |
*** openstackgerrit_ has joined #openstack-nova | 09:34 | |
*** yassine__ has joined #openstack-nova | 09:34 | |
*** sfinucan has joined #openstack-nova | 09:34 | |
openstackgerrit_ | Sergey Nikitin proposed openstack/nova: Added db API layer to add instance tag-list filtering support https://review.openstack.org/248805 | 09:34 |
openstackgerrit_ | Sergey Nikitin proposed openstack/nova: Added server tags controller https://review.openstack.org/128940 | 09:34 |
openstackgerrit_ | Sergey Nikitin proposed openstack/nova: Added server tags support in nova-api https://review.openstack.org/268932 | 09:34 |
*** openstackgerrit_ is now known as openstackgerrit | 09:34 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Moved tags filtering tests to TestInstanceTagsFiltering test case https://review.openstack.org/258515 | 09:39 |
*** gjayavel_ has quit IRC | 09:40 | |
*** zenoway has quit IRC | 09:40 | |
*** zenoway has joined #openstack-nova | 09:40 | |
*** ekuris_ has joined #openstack-nova | 09:41 | |
*** dguitarbite has joined #openstack-nova | 09:44 | |
*** dguitarbite has quit IRC | 09:44 | |
*** pkarikh has left #openstack-nova | 09:44 | |
*** zenoway has quit IRC | 09:45 | |
*** roeyc has joined #openstack-nova | 09:45 | |
*** daemontool__ has joined #openstack-nova | 09:45 | |
*** thorst_ has joined #openstack-nova | 09:45 | |
*** daemontool_ has quit IRC | 09:49 | |
*** amotoki has joined #openstack-nova | 09:50 | |
*** acabot has joined #openstack-nova | 09:51 | |
*** PaulMurray has joined #openstack-nova | 09:51 | |
*** thorst_ has quit IRC | 09:53 | |
PaulMurray | good morning | 09:53 |
*** rk4n has quit IRC | 09:53 | |
* johnthetubaguy waves good morning | 09:53 | |
gmann | good morning | 09:55 |
gmann | PaulMurray: johnthetubaguy need your feedback on https://review.openstack.org/290196 | 09:55 |
ndipanov | PaulMurray, hello | 09:55 |
gmann | added patch as discussed in API meeting- for GET volume attachment APIs | 09:55 |
ndipanov | PaulMurray, if you get a chance go back to the live mig claims patch - I've updated it\ | 09:56 |
ndipanov | johnthetubaguy, would be interested in your thoughts on this https://review.openstack.org/#/c/290705/ | 09:56 |
PaulMurray | ndipanov, yep, had a brief look yesterday but doing it this morning | 09:56 |
ndipanov | in light of RC1 even if you don't think it's too risky | 09:57 |
PaulMurray | gmann, I'll look at that to | 09:57 |
gmann | PaulMurray: Thanks | 09:57 |
johnthetubaguy | ndipanov: it has a +2, I should hit that stuff on my morning rounds | 09:57 |
*** mingyu has quit IRC | 09:57 | |
johnthetubaguy | ndipanov: that device reservation, I think that stopped being useful when we stopped trying to honor the device people specify, I guess? | 09:59 |
johnthetubaguy | anyways, will try get back to that in a bit | 09:59 |
*** markusz is now known as markus_z | 10:00 | |
*** haomaiwa_ has quit IRC | 10:01 | |
ndipanov | johnthetubaguy, weeeel | 10:01 |
*** haomaiwang has joined #openstack-nova | 10:01 | |
ndipanov | this thing just moves stuff around a bit | 10:01 |
openstackgerrit | Stephen Finucane proposed openstack/nova: libvirt: Don't misuse InstanceNotFound exception https://review.openstack.org/290706 | 10:01 |
ndipanov | I would not remove it for RC 1 | 10:01 |
ndipanov | (the reservation I mean) | 10:01 |
ndipanov | but do a volume reservation before it would prevent a class of bugs we keep hitting for years | 10:02 |
ndipanov | and that's what the patch does | 10:02 |
*** efoley_ has joined #openstack-nova | 10:02 | |
*** Marga_ has quit IRC | 10:03 | |
*** rk4n has joined #openstack-nova | 10:03 | |
*** efoley has quit IRC | 10:04 | |
johnthetubaguy | ndipanov: OK, like I say, will try read through that more later | 10:04 |
ndipanov | johnthetubaguy, awesome - I also left comments on the bug to clarify | 10:04 |
*** Guest3102 is now known as BobBall | 10:04 | |
johnthetubaguy | cools | 10:04 |
*** liverpooler has quit IRC | 10:05 | |
*** sayalilunkad_lap has joined #openstack-nova | 10:06 | |
*** atuvenie has joined #openstack-nova | 10:07 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID https://review.openstack.org/287702 | 10:08 |
*** eglynn has joined #openstack-nova | 10:09 | |
*** zenoway has joined #openstack-nova | 10:09 | |
*** liverpooler has joined #openstack-nova | 10:10 | |
*** derekh has joined #openstack-nova | 10:13 | |
*** vilobhmm11 has quit IRC | 10:13 | |
*** paul-carlton2 has quit IRC | 10:14 | |
*** liverpooler has quit IRC | 10:17 | |
*** paul-carlton2 has joined #openstack-nova | 10:17 | |
*** atuvenie has quit IRC | 10:19 | |
openstackgerrit | Cao ShuFeng proposed openstack/nova: Update the doc of notification https://review.openstack.org/291084 | 10:20 |
*** lpetrut has joined #openstack-nova | 10:28 | |
*** liverpooler has joined #openstack-nova | 10:29 | |
*** hoangcx has quit IRC | 10:32 | |
*** paul-carlton2 has quit IRC | 10:33 | |
johnthetubaguy | andreykurilin__ did you see any python-novaclient issues pop up that mean we should wait on creating our stable branch for mitaka? (thats a general question, too!) | 10:37 |
*** josecastroleon has quit IRC | 10:38 | |
openstackgerrit | Gábor Antal proposed openstack/nova: Extract duplicated code from compute manager https://review.openstack.org/281326 | 10:38 |
*** josecastroleon has joined #openstack-nova | 10:39 | |
*** atuvenie has joined #openstack-nova | 10:41 | |
andreykurilin__ | johnthetubaguy: hi! I know only one issue, but it is not critical(maybe low priority) and we have it for a long time:) I suppose it is not blocking and relates not only to novaclient, but to api-side too. So we are ready to create new stable branch | 10:41 |
johnthetubaguy | cool, thats what I am seeing from where I am sat, so thats good to know, thanks andreykurilin__ | 10:41 |
*** mvk has quit IRC | 10:42 | |
andreykurilin__ | johnthetubaguy: btw, do you have a bit of time to talk about one issue? or lets talk a bit later(after release)? | 10:43 |
johnthetubaguy | andreykurilin__: depends if its quick ;) whats up? | 10:44 |
*** rk4n has quit IRC | 10:44 | |
*** dims has joined #openstack-nova | 10:47 | |
*** Marga_ has joined #openstack-nova | 10:47 | |
andreykurilin__ | johnthetubaguy: it is about `nova quota-show` command. Nova stores only "no-default" quotas in database. quota-show command accepts tenant-id to show quotas for. In this case nova does not validate tenant and just do the query. The results are empty and Nova assumes that there are no-default quotas and returns dict with default quotas. | 10:47 |
andreykurilin__ | johnthetubaguy: users try to put tenant_name instead of tenant_id to `quota show` and nova displays wrong quotas | 10:50 |
johnthetubaguy | andreykurilin__: oh, thats an old tricky issue. We don't validate the tenant when we set quotas either, because its really an arbitrary external id to Nova. The problem is having a new plugin point of "authenticators" to validate tenant ids. There might be some old history on this conversation somewhere | 10:50 |
*** thorst_ has joined #openstack-nova | 10:50 | |
andreykurilin__ | johnthetubaguy: got it, i'll llok at mailing list history | 10:51 |
*** bapalm has quit IRC | 10:51 | |
*** dims has quit IRC | 10:52 | |
*** yassine__ has quit IRC | 10:54 | |
andreykurilin__ | johnthetubaguy: I had a talk with keystone folks and they said that there is no way to validate tenant via keystoneauth(it used on both novaclient and api sides) :( | 10:54 |
*** cdent has joined #openstack-nova | 10:55 | |
*** dims has joined #openstack-nova | 10:56 | |
*** omnipresent has joined #openstack-nova | 10:56 | |
*** ociuhandu has quit IRC | 10:56 | |
*** salv-orlando has joined #openstack-nova | 10:57 | |
*** zenoway has quit IRC | 10:57 | |
*** thorst_ has quit IRC | 10:58 | |
johnthetubaguy | andreykurilin__: oh, thats a good point, we could look at finding a way to validate that inside python-novaclient | 10:58 |
johnthetubaguy | andreykurilin__: its a shame its not possible, but thats an angle I don't remember us fully thinking through yet | 10:59 |
*** sdague has joined #openstack-nova | 11:00 | |
*** haomaiwang has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-nova | 11:01 | |
*** roeyc has quit IRC | 11:03 | |
*** atuvenie has quit IRC | 11:06 | |
*** cristicalin has joined #openstack-nova | 11:06 | |
*** bapalm has joined #openstack-nova | 11:08 | |
*** gongysh has quit IRC | 11:09 | |
*** josecastroleon has quit IRC | 11:09 | |
*** efoley_ has quit IRC | 11:09 | |
*** mvk has joined #openstack-nova | 11:10 | |
*** josecastroleon has joined #openstack-nova | 11:10 | |
*** efoley_ has joined #openstack-nova | 11:11 | |
*** rk4n has joined #openstack-nova | 11:12 | |
*** dguitarbite has joined #openstack-nova | 11:14 | |
*** rk4n has quit IRC | 11:16 | |
*** dims has quit IRC | 11:19 | |
openstackgerrit | Alexis Lee proposed openstack/nova: Wait for device to be mapped https://review.openstack.org/215613 | 11:19 |
openstackgerrit | Alexis Lee proposed openstack/nova: Wait for device to be mapped https://review.openstack.org/215613 | 11:21 |
*** dims has joined #openstack-nova | 11:21 | |
*** bapalm has quit IRC | 11:24 | |
*** ishant has quit IRC | 11:25 | |
*** kmartin has quit IRC | 11:29 | |
*** salv-orlando has quit IRC | 11:30 | |
*** cristicalin has quit IRC | 11:35 | |
*** rk4n has joined #openstack-nova | 11:39 | |
*** josecastroleon has quit IRC | 11:40 | |
*** EinstCrazy has joined #openstack-nova | 11:40 | |
*** josecastroleon has joined #openstack-nova | 11:41 | |
*** smatzek has joined #openstack-nova | 11:42 | |
*** ivase_ has quit IRC | 11:42 | |
*** bapalm has joined #openstack-nova | 11:44 | |
*** sayalilunkad_lap has quit IRC | 11:45 | |
*** roeyc has joined #openstack-nova | 11:46 | |
*** atuvenie has joined #openstack-nova | 11:48 | |
*** tbachman_ has joined #openstack-nova | 11:50 | |
*** rfolco has joined #openstack-nova | 11:50 | |
*** rk4n has quit IRC | 11:50 | |
*** gjayavel_ has joined #openstack-nova | 11:52 | |
*** rk4n has joined #openstack-nova | 11:52 | |
*** tbachman has quit IRC | 11:53 | |
*** tbachman_ is now known as tbachman | 11:53 | |
johnthetubaguy | lyarwood: any chance you could review this bug for me, it feels related: https://review.openstack.org/#/c/288334/4 | 11:54 |
paul-carlton1 | johnthetubaguy, two questions on https://review.openstack.org/#/c/288373/ | 11:55 |
*** thorst_ has joined #openstack-nova | 11:56 | |
*** dims has quit IRC | 11:56 | |
*** gjayavel_ has quit IRC | 11:56 | |
paul-carlton1 | firstly HyperV CI has failed do I need to recheck that or is that irrelevant now you've +1 workflow'ed it? | 11:56 |
*** sfinucan has quit IRC | 11:56 | |
*** efoley__ has joined #openstack-nova | 11:57 | |
paul-carlton1 | Secondly, just to clarify you are thinking that we should change CellsStateManager usage of objects.ServiceList.get_by_binary to set the include_disabled parameter to True? | 11:58 |
*** moshele has quit IRC | 11:58 | |
*** aysyd has joined #openstack-nova | 11:59 | |
cdent | p!spy | 11:59 |
paul-carlton1 | I think I've answer the first question, since it is now in gate in zuul HyperV CI check is irrelevant | 12:00 |
*** efoley_ has quit IRC | 12:00 | |
openstackgerrit | sahid proposed openstack/nova: network: make nova to handle port_security_enabled=False https://review.openstack.org/284095 | 12:00 |
*** haomaiwang has quit IRC | 12:01 | |
*** haomaiwang has joined #openstack-nova | 12:01 | |
*** rk4n has quit IRC | 12:01 | |
*** jaosorior has quit IRC | 12:02 | |
*** thorst_ has quit IRC | 12:03 | |
*** jaosorior has joined #openstack-nova | 12:03 | |
johnthetubaguy | paul-carlton1: yeah, only jenkins will block it in the gate, didn't seem specific to hyper-v, so I ignored that | 12:03 |
*** rk4n has joined #openstack-nova | 12:04 | |
paul-carlton1 | johnthetubaguy, discussed with PaulMurray and now understand the Cells change is to optimize | 12:04 |
*** dims has joined #openstack-nova | 12:04 | |
johnthetubaguy | paul-carlton1: hmm, I suppose it is an optimisation there, slightly | 12:05 |
*** vladikr has joined #openstack-nova | 12:05 | |
*** erlon has joined #openstack-nova | 12:05 | |
*** rk4n has quit IRC | 12:05 | |
johnthetubaguy | paul-carlton1: although if we are keeping that in cells, maybe best to explicitly pass False, and drop the extra if, and your comment about removing that arg in the next version | 12:05 |
paul-carlton1 | very slightly, select will not filter on disabled but the CellsStateManager strips out disabled hosts after doing select anyway | 12:06 |
*** rk4n has joined #openstack-nova | 12:07 | |
sdague | hmmm... I guess we have no unit tests for this - https://github.com/openstack/nova/blob/3d7e403cc7a5d9ebcd9a011d6c2055bfbf56cb05/nova/compute/resource_tracker.py#L977 | 12:08 |
sdague | because that's not going to do what anyone thinks | 12:08 |
paul-carlton1 | don't think we can drop the ... | 12:08 |
paul-carlton1 | if not include_disabled: | 12:08 |
paul-carlton1 | query = query.filter_by(disabled=False) | 12:08 |
paul-carlton1 | until v2.0 of object, per dansmith wanting the existing object behaviour to remain unchanged | 12:09 |
*** josecastroleon has quit IRC | 12:11 | |
*** rk4n has quit IRC | 12:12 | |
*** josecastroleon has joined #openstack-nova | 12:13 | |
bauzas | johnthetubaguy: correct me if I'm wrong, but configdrives are r/o, right? | 12:16 |
*** moshele has joined #openstack-nova | 12:18 | |
openstackgerrit | Thomas Bachman proposed openstack/nova: VMware: Use Port Group and Key in binding details https://review.openstack.org/288076 | 12:18 |
*** eglynn has quit IRC | 12:20 | |
sdague | bauzas: yes | 12:21 |
openstackgerrit | Sean Dague proposed openstack/nova: Make tuple actually a tuple https://review.openstack.org/291138 | 12:21 |
bauzas | sdague: okay, thanks | 12:22 |
sdague | bauzas / ndipanov - https://review.openstack.org/291138 saw that when I was looking at an unrelated review. There are definitely no tests in that area, but I don't know the resource tracker enough to know what those should be. | 12:23 |
bauzas | sdague: so, we had a legacy test_resource_tracker | 12:24 |
bauzas | sdague: which was doing kind of DB tests | 12:24 |
sdague | oh, the initial review even has comments about that, it works by accident | 12:24 |
bauzas | sdague: and each time we were modifying some RT stuff, there were like 20 impacted tests litterally needing to change a mocked signature | 12:24 |
bauzas | sdague: so jaypipes worked on moving those tests to another testcase in test_tracker | 12:25 |
bauzas | well, another testcases even | 12:25 |
openstackgerrit | javeme proposed openstack/nova: Don't-merge: test for can_send_version https://review.openstack.org/291141 | 12:25 |
sdague | bauzas: yeh, no, this is one of those things where python bits are weird | 12:25 |
bauzas | (with an 's') | 12:25 |
*** eglynn has joined #openstack-nova | 12:25 | |
sdague | 'resize' in 'resize' == True | 12:25 |
bauzas | sdague: so, if you want to add a test for RT, then test_tracker is the right thing | 12:25 |
sdague | 'resize' in ('resize',) == True | 12:25 |
sdague | 'resiz' in 'resize' == True | 12:26 |
openstackgerrit | sean mooney proposed openstack/nova: stop setting mtu when pluging vhostuser port https://review.openstack.org/271444 | 12:26 |
sdague | 'resiz' in ('resize',) == False | 12:26 |
bauzas | yeah :) | 12:26 |
bauzas | because strings are containers :) | 12:26 |
sdague | so it's accidentally working, for the wrong reasons | 12:26 |
bauzas | I'm all good with your change, just thinking of whether we need a test | 12:27 |
*** tbachman_ has joined #openstack-nova | 12:27 | |
bauzas | migration.migration_type is an object field AFAIR | 12:27 |
bauzas | which is Enum | 12:27 |
bauzas | sdague: so there would litterally be no way to provide like a substring | 12:28 |
*** Daisy has joined #openstack-nova | 12:28 | |
bauzas | (and the field isn't nullable) | 12:28 |
*** tbachman has quit IRC | 12:29 | |
*** tbachman_ is now known as tbachman | 12:29 | |
*** rodrigods has quit IRC | 12:33 | |
*** rodrigods has joined #openstack-nova | 12:33 | |
sdague | bauzas: sure, it does make things confusing though. Because it's not the intent. | 12:33 |
*** Daisy has quit IRC | 12:33 | |
bauzas | sdague: I agree, so I +2d the patch but downgrade the bug to Low | 12:34 |
bauzas | downgraded | 12:34 |
*** jwcroppe has joined #openstack-nova | 12:34 | |
bauzas | that's not impactful | 12:34 |
*** Daisy has joined #openstack-nova | 12:34 | |
*** lucasagomes is now known as lucas-hungry | 12:34 | |
*** hamzy has quit IRC | 12:35 | |
*** thorst_ has joined #openstack-nova | 12:35 | |
bauzas | sdague: non-related, http://lists.openstack.org/pipermail/openstack-dev/2016-March/088931.html | 12:35 |
bauzas | sdague: I don't know where we could discuss that, in -dev chan ? | 12:36 |
*** rtheis has joined #openstack-nova | 12:37 | |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 12:38 |
openstackgerrit | Bin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed https://review.openstack.org/289813 | 12:38 |
*** Daisy has quit IRC | 12:38 | |
*** doug-fish has quit IRC | 12:38 | |
jaypipes | OMG I want to slap the face of these PCI unit tests. how many levels of hell must I go through in order to unwind these :( | 12:39 |
johnthetubaguy | bauzas: they should be, although I think the ext ones are not quite read only | 12:39 |
* johnthetubaguy gets some lunch | 12:39 | |
sdague | bauzas: that we should keep on the mailing list probably | 12:39 |
*** doug-fish has joined #openstack-nova | 12:39 | |
bauzas | johnthetubaguy: ack | 12:40 |
*** rk4n has joined #openstack-nova | 12:40 | |
bauzas | sdague: np, just wanted to get your opinion on that | 12:40 |
*** rk4n has quit IRC | 12:40 | |
* bauzas goes eating as well | 12:41 | |
*** fesp has joined #openstack-nova | 12:43 | |
sdague | bauzas: sure | 12:43 |
*** doug-fish has quit IRC | 12:44 | |
*** rk4n has joined #openstack-nova | 12:44 | |
*** moshele has quit IRC | 12:45 | |
*** pcaruana has quit IRC | 12:45 | |
*** gongysh has joined #openstack-nova | 12:46 | |
*** ildikov has quit IRC | 12:48 | |
*** purplerbot has quit IRC | 12:49 | |
*** purplerbot has joined #openstack-nova | 12:49 | |
*** tdurakov_ has joined #openstack-nova | 12:49 | |
*** tbachman_ has joined #openstack-nova | 12:51 | |
sdague | cdent: you have a patch on top of - https://review.openstack.org/#/c/192878/ which is merge conflicted | 12:51 |
*** fesp has quit IRC | 12:51 | |
*** sayalilunkad has quit IRC | 12:51 | |
*** sayalilunkad has joined #openstack-nova | 12:52 | |
* cdent looks | 12:52 | |
*** efoley__ has quit IRC | 12:53 | |
cdent | thanks sdague, I meant to make that independent, will fix | 12:53 |
*** tbachman has quit IRC | 12:53 | |
*** tbachman_ is now known as tbachman | 12:53 | |
*** e0ne_ has joined #openstack-nova | 12:53 | |
*** e0ne has quit IRC | 12:54 | |
cdent | sdague: oh, I did | 12:54 |
cdent | my change should be independent, it's the same topic though | 12:54 |
*** baoli has joined #openstack-nova | 12:55 | |
tdurakov_ | pkoniszewski, johnthetubaguy, hey folks,do you have time to chat about this bug: https://bugs.launchpad.net/nova/+bug/1552303 | 12:56 |
openstack | Launchpad bug 1552303 in OpenStack Compute (nova) "Block live migrations are broken when nova calculates live migration type by itself" [Critical,In progress] - Assigned to Pawel Koniszewski (pawel-koniszewski) | 12:56 |
pkoniszewski | tdurakov: hi, sure | 12:57 |
*** cdelatte has quit IRC | 12:57 | |
sdague | cdent: ah, my bad | 12:57 |
cdent | sdague: I rewrote it indepdendently because the other version is doing too much to be just a bug fix. so I borrowed the tests and did my own implementation without the refactor | 12:58 |
sdague | gotcha, cool | 12:58 |
tdurakov_ | pkoniszewski, will your patch be merged prior to release? | 12:59 |
pkoniszewski | live migrations in 2.25 API are broken, so yes, i think it will be | 12:59 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Comment non-obvious security implications of migrate code https://review.openstack.org/291155 | 12:59 |
*** yamahata has quit IRC | 13:00 | |
pkoniszewski | it affects both, live migrations and block migrations | 13:00 |
*** pcaruana has joined #openstack-nova | 13:00 | |
pkoniszewski | only force block live migrations still work | 13:00 |
pkoniszewski | forced * | 13:01 |
*** haomaiwang has quit IRC | 13:01 | |
mdbooth | ^^^ The above patch simply adds a comment, btw. It describes why we shouldn't touch 2 lines of code which look wrong, because doing that would introduce (another) severe security bug in the libvirt driver. | 13:01 |
*** haomaiwang has joined #openstack-nova | 13:01 | |
tdurakov_ | pkoniszewski, ok, while i like your approach to get rid of block_migration param, we could go with alternative and much easier solution by setting block_migration in conductor, smth like: http://xsnippet.org/361517/ but i'd rather go with existing approach if we have enough time | 13:03 |
*** efried has joined #openstack-nova | 13:04 | |
pkoniszewski | tdurakov: this was my first proposition, but it is ugly and bad | 13:04 |
tdurakov_ | pkoniszewski, agree | 13:04 |
*** moshele has joined #openstack-nova | 13:04 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: Live migration failure in API leaves VM in MIGRATING state https://review.openstack.org/168916 | 13:04 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Remove block_migration from virt drivers https://review.openstack.org/290519 | 13:05 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Use migrate_data.block_migration instead of block_migration https://review.openstack.org/287363 | 13:05 |
tdurakov_ | pkoniszewski, imo all live migration methods should operate with instance and migrate_data params only | 13:05 |
pkoniszewski | correct | 13:05 |
*** thumpba has joined #openstack-nova | 13:06 | |
mdbooth | tdurakov_: Much the same as your cleanup patch, block migration should be firmly in the domain of the driver, imho | 13:07 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Cleanup for post/rollback of live-migrations https://review.openstack.org/280653 | 13:08 |
openstackgerrit | Timofey Durakov proposed openstack/nova: New field for LibvirtLiveMigrateData https://review.openstack.org/286745 | 13:08 |
openstackgerrit | Timofey Durakov proposed openstack/nova: move disk_info calc to check methods https://review.openstack.org/291160 | 13:08 |
openstackgerrit | Timofey Durakov proposed openstack/nova: implement async rpc for live-migration https://review.openstack.org/291161 | 13:08 |
mdbooth | Exposing it in the api is obviously really bad, but conductor isn't great either | 13:08 |
tdurakov_ | mdbooth, pkoniszewski check this^ | 13:08 |
tdurakov_ | it's part of PoC will submit last one in an hour | 13:09 |
*** Daisy has joined #openstack-nova | 13:09 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: Live migration failure in API leaves VM in MIGRATING state https://review.openstack.org/168916 | 13:10 |
*** atuvenie_ has joined #openstack-nova | 13:10 | |
*** Daisy has quit IRC | 13:11 | |
*** haomaiwang has quit IRC | 13:11 | |
pkoniszewski | tdurakov: i like one that moves cleanup flags to drivers | 13:11 |
*** erno has quit IRC | 13:11 | |
*** Daisy has joined #openstack-nova | 13:11 | |
tdurakov_ | pkoniszewski, which one? | 13:11 |
pkoniszewski | tdurakov: this one https://review.openstack.org/280653 | 13:12 |
mdbooth | pkoniszewski: Me too, btw. | 13:12 |
*** ducttape_ has joined #openstack-nova | 13:12 | |
mdbooth | However, I was -1 the details, and I still thought the patch could be broken up a bit. | 13:12 |
*** moshele has quit IRC | 13:12 | |
tdurakov_ | yes, got feedback, need to split more:-p | 13:12 |
pkoniszewski | tdurakov: i wonder why didn't u continue it here https://review.openstack.org/#/c/216329/ | 13:12 |
mdbooth | :) | 13:12 |
pkoniszewski | tdurakov: it's simple enough and just moves this one method | 13:13 |
*** atuvenie__ has joined #openstack-nova | 13:13 | |
*** pradk has joined #openstack-nova | 13:13 | |
*** atuvenie has quit IRC | 13:13 | |
*** dave-mccowan has joined #openstack-nova | 13:13 | |
tdurakov_ | pkoniszewski, we discussed it with johnthetubaguy, so this 2 are kind of alternatives, and we should pick one | 13:13 |
*** erno has joined #openstack-nova | 13:14 | |
*** roeyc has quit IRC | 13:14 | |
tdurakov_ | pkoniszewski, do you think it's worth to implement both? | 13:14 |
*** moshele has joined #openstack-nova | 13:14 | |
pkoniszewski | tdurakov: let me compare both, i will let you know what i think | 13:15 |
*** ekuris_ has quit IRC | 13:15 | |
*** Daisy has quit IRC | 13:15 | |
tdurakov_ | i mean, it seems like first one(that moves method to driver side) looks bit useless as we aiming to get rid of it at all | 13:15 |
*** ekuris_ has joined #openstack-nova | 13:16 | |
tdurakov_ | pkoniszewski, yes, please, left comment than | 13:16 |
*** atuvenie_ has quit IRC | 13:16 | |
pkoniszewski | tdurakov: well, this can be true | 13:16 |
*** atuvenie has joined #openstack-nova | 13:16 | |
*** lucas-hungry is now known as lucasagomes | 13:17 | |
*** jmhale has joined #openstack-nova | 13:17 | |
*** atuvenie__ has quit IRC | 13:18 | |
pkoniszewski | tdurakov: you are right, moving this method to driver side is a bit useless, drivers already have all the data so improving cleanup logic sounds better | 13:20 |
*** cdelatte has joined #openstack-nova | 13:20 | |
*** edmondsw has joined #openstack-nova | 13:21 | |
tdurakov_ | pkoniszewski, mdbooth, could you folks review this patch also: https://review.openstack.org/#/c/291161/ | 13:21 |
*** hamzy has joined #openstack-nova | 13:21 | |
tdurakov_ | interested in feedback, as now I'm describing this in spec | 13:21 |
tdurakov_ | mostly about new methods and rpc api | 13:21 |
tdurakov_ | p.s. last one adds state to compute to add safety to this | 13:22 |
mdbooth | tdurakov_: Yup, will do. | 13:24 |
tdurakov_ | mdbooth, thanks in advance | 13:24 |
pkoniszewski | tdurakov: cool, will do too | 13:26 |
*** doug-fish has joined #openstack-nova | 13:26 | |
tdurakov_ | pkoniszewski, thx:) | 13:26 |
johnthetubaguy | tdurakov_: by add state, do you mean put more data in the migrate_data blob that gets passed around? | 13:26 |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Redundant parentheses removed https://review.openstack.org/290410 | 13:26 |
pkoniszewski | tdurakov: i think i should reabse https://review.openstack.org/#/c/290519 somewhere in the middle of your patch series, so don't conflict much | 13:26 |
*** mtanino has joined #openstack-nova | 13:27 | |
*** doug-fish has quit IRC | 13:27 | |
tdurakov_ | johnthetubaguy, no, as we discussed it during mid-cycle, storing state of migration so l-m will survive after crash and continue async process | 13:27 |
tdurakov_ | on compute side i mean | 13:27 |
*** doug-fish has joined #openstack-nova | 13:27 | |
johnthetubaguy | tdurakov_: oh, that bit, yeah, gotcha | 13:28 |
*** ivase has joined #openstack-nova | 13:28 | |
*** lixiaoy1 has joined #openstack-nova | 13:28 | |
*** lefaiseur has joined #openstack-nova | 13:28 | |
*** ducttape_ has quit IRC | 13:29 | |
johnthetubaguy | tdurakov_: just error out and clean up would be good enough, but it might be just as easy to pick up where the sync monitoring process left off, which is cool | 13:29 |
tdurakov_ | pkoniszewski, in a middle I think will be good, as last 2 are mostly about bp implementation | 13:29 |
*** prateek has joined #openstack-nova | 13:29 | |
*** prateek is now known as Guest22464 | 13:29 | |
*** Guest22464 is now known as parora | 13:29 | |
tdurakov_ | johnthetubaguy, let me upload the last part, and then we could pick best solution | 13:30 |
*** roeyc has joined #openstack-nova | 13:30 | |
parora | do we have any locking mechanism for instances in api.py file in nova ? | 13:30 |
johnthetubaguy | parora: depends what you want to achieve, we do a best effort thing to stop conflicting API operations. | 13:31 |
*** ivase has quit IRC | 13:32 | |
parora | johnthetubaguy, i am trying to make sure that while i am taking snapshot, the instances are not deleted | 13:32 |
johnthetubaguy | parora: that breaks the API though, its intentional that we allow that | 13:32 |
*** sayalilunkad has quit IRC | 13:32 | |
*** tdurakov_ has quit IRC | 13:33 | |
johnthetubaguy | parora: basically delete is the one operation that is allowed at any time | 13:33 |
mdbooth | tdurakov_: Re the cleanup patch, did you see my comment about removing the last use of cleanup? | 13:33 |
*** tdurakov_ has joined #openstack-nova | 13:33 | |
parora | johnthetubaguy, intentional, why ? | 13:33 |
*** ivase has joined #openstack-nova | 13:33 | |
mdbooth | tdurakov_: Re the cleanup patch, did you see my comment about removing the last use of cleanup? | 13:33 |
johnthetubaguy | parora: it comes from thinking about when users get billed for instances, you want to always allow delete, if thats what they want to do. | 13:33 |
mdbooth | tdurakov_: It's weird, because you're making a bunch of changes in there, but I don't think anything's calling it any more | 13:33 |
sdague | parora: it's the universal cancel operation. It would be like blocking Ctrl-C to not allow it. | 13:34 |
johnthetubaguy | parora: now it does have a habit of triggering obscure bugs in the system, but they should be fixed to allow delete to happen at any time. | 13:34 |
johnthetubaguy | sdague: I like that comparison, +1 | 13:34 |
parora | sdague, well said | 13:34 |
parora | johnthetubaguy, sdague i agree but that sends the image into saving state for an eternity | 13:35 |
tdurakov_ | mdbooth, 5 mins | 13:35 |
johnthetubaguy | parora: so thats totally a bug that needs fixing, it should gracefully fail the snapshot, and clean up the half created image, like we do for other snapshot failure modes | 13:35 |
*** sayalilunkad has joined #openstack-nova | 13:35 | |
parora | johnthetubaguy, sounds good | 13:36 |
mdbooth | johnthetubaguy: Remind me, do we have Tasks (with a T, not a t) yet? | 13:36 |
johnthetubaguy | mdbooth: neither really, but we do have elements of what you might need, like instance actions, instance faults, task state detection to spot partial operations, etc | 13:37 |
mdbooth | johnthetubaguy: Thanks. | 13:38 |
*** acabot has quit IRC | 13:38 | |
*** dims has quit IRC | 13:38 | |
johnthetubaguy | mdbooth: totally want to see more structure there, and I know alaski is super interested in all that (expect for that cells v2 thing he has right now) | 13:39 |
*** dims has joined #openstack-nova | 13:39 | |
mdbooth | johnthetubaguy: Was just thinking in the context of live migration | 13:39 |
* mdbooth is reading tdurakov_ 's async live migration api | 13:40 | |
johnthetubaguy | the tricker bit now, is not breaking the several years of work on upgrades we have in place | 13:40 |
*** porunov has joined #openstack-nova | 13:40 | |
mdbooth | Yup | 13:40 |
johnthetubaguy | yeah, totally, the stuff we have for instance create and instance snapshot helps establishes a lot of the patterns there two | 13:41 |
johnthetubaguy | instance delete as well, I guess | 13:41 |
*** tbachman_ has joined #openstack-nova | 13:42 | |
*** thumpba has quit IRC | 13:42 | |
*** tbachman has quit IRC | 13:43 | |
*** tbachman_ is now known as tbachman | 13:43 | |
*** gongysh has quit IRC | 13:43 | |
*** burgerk has joined #openstack-nova | 13:43 | |
johnthetubaguy | pkoniszewski: bauzas: how are we feeling about this fix now? I am just taking a peak again myself: https://review.openstack.org/#/c/287363/ | 13:44 |
*** tdurakov_ has quit IRC | 13:44 | |
*** rmart04 has joined #openstack-nova | 13:44 | |
*** Daisy has joined #openstack-nova | 13:45 | |
alaski | mdbooth: as johnthetubaguy there are no Tasks yet, but tdurakov and I have discussed this in relation to his work and see what he's doing as a precursor to getting there | 13:47 |
pkoniszewski | johnthetubaguy: my feeling is that this is unwanted beginning of a live migration code cleanup | 13:48 |
mdbooth | alaski: Cool. Seemed like an obvious fit from what little I know of the details of Task. | 13:48 |
*** tdurakov_ has joined #openstack-nova | 13:48 | |
*** links has quit IRC | 13:48 | |
johnthetubaguy | pkoniszewski: are we not totally broken in the new API if we don't merge something like this one though: https://review.openstack.org/#/c/287363 | 13:48 |
*** delattec has joined #openstack-nova | 13:49 | |
pkoniszewski | johnthetubaguy: yeah, without this only forced block migrations will work, if we don't want to use block_migration anymore this is a good (and bad) start | 13:49 |
*** acabot has joined #openstack-nova | 13:50 | |
*** markvoelker has joined #openstack-nova | 13:50 | |
pkoniszewski | and we should focus on cleaning up all this stuff in Newton I think | 13:50 |
pkoniszewski | i mean, cleanup that tdurakov started in his series | 13:50 |
*** tdurakov has quit IRC | 13:51 | |
*** tdurakov_ is now known as tdurakov | 13:51 | |
* alex_xu back from bug smash | 13:51 | |
*** Guest32605 has joined #openstack-nova | 13:52 | |
*** rfolco_ has joined #openstack-nova | 13:52 | |
johnthetubaguy | pkoniszewski: so the API added block_migration=auto, for that to work, we need your change right? | 13:52 |
johnthetubaguy | pkoniszewski: agreed there is a wider cleanup needed | 13:52 |
pkoniszewski | johnthetubaguy: exactly | 13:52 |
johnthetubaguy | but the wider clean up is totally for newton | 13:52 |
pkoniszewski | agree | 13:52 |
*** cdelatte has quit IRC | 13:52 | |
johnthetubaguy | right, so we still need your patch in mitaka, I think | 13:53 |
tdurakov | johnthetubaguy, we totally need pkoniszewski fix before mitaka release | 13:53 |
*** rfolco has quit IRC | 13:53 | |
johnthetubaguy | cool, just making sure we are all on the same page here | 13:53 |
johnthetubaguy | its looking good now, for me, just grepping through things to double check a few things | 13:54 |
*** liusheng has joined #openstack-nova | 13:54 | |
*** rlrossit has joined #openstack-nova | 13:55 | |
*** rk4n has quit IRC | 13:55 | |
pkoniszewski | johnthetubaguy: yes, we need it to fix new API | 13:56 |
*** thumpba has joined #openstack-nova | 13:56 | |
johnthetubaguy | pkoniszewski: so, I think we have an issue in your patch, that fix you did for jaypipes I think is actually a bad fix, once I dug deeper, I think we should instead add a FIXME saying to remove that variable at a later date :( Now its possible it doesn't actually create a bug, but I think we should keep it all consistent. | 13:57 |
johnthetubaguy | pkoniszewski: its these bits: https://review.openstack.org/#/c/287363/7/nova/virt/libvirt/driver.py@6407 sorry, I didn't see those before | 13:58 |
pkoniszewski | johnthetubaguy: i have a meeting in few minutes, i will take a look on it right after | 13:59 |
*** mriedem has joined #openstack-nova | 13:59 | |
johnthetubaguy | so I have to go run the nova meeting now myself | 13:59 |
*** salv-orlando has joined #openstack-nova | 13:59 | |
*** jaosorior has quit IRC | 13:59 | |
johnthetubaguy | adrian_otto akuriata alevine alexpilotti aloga andreykurilin anteaya artom auggy | 13:59 |
johnthetubaguy | bauzas belliott belmoreira bobball cburgess claudiub danpb dguitarbite _diana_ | 13:59 |
johnthetubaguy | diana_clarke dims duncant edleafe efried flip214 funzo garyk gcb gjayavelu | 13:59 |
johnthetubaguy | irina_pov jaypipes jcookekhugen jgrimm jichen jlvillal jroll kashyap klindgren | 13:59 |
johnthetubaguy | krtaylor lbeliveau lxsli macsz markus_z mdorman med_ mikal mjturek mnestratov | 13:59 |
johnthetubaguy | moshele mrda nagyz ndipanov neiljerram nic Nisha PaulMurray raildo rgeragnov | 13:59 |
johnthetubaguy | sc68cal scottda sdague sileht sorrison swamireddy thomasem thorst tjones tonyb | 13:59 |
johnthetubaguy | tpatil tpatzig xyang rdopiera | 13:59 |
* johnthetubaguy make ping noise | 14:00 | |
kashyap | johnthetubaguy: Which IRC channel? | 14:00 |
johnthetubaguy | its time for the Nova meeting in #openstack-meeting | 14:00 |
kashyap | Thx | 14:00 |
*** tdurakov has quit IRC | 14:00 | |
*** eliqiao1 has joined #openstack-nova | 14:01 | |
* danpb wonders why we need shared meeting channels at all - each meeting could have its own meeting channel #openstack-meeting-$meeting-name avoiding the mess of finding free slots | 14:01 | |
*** tbachman has quit IRC | 14:02 | |
*** rk4n has joined #openstack-nova | 14:03 | |
*** burgerk has quit IRC | 14:03 | |
*** tdurakov_ has joined #openstack-nova | 14:03 | |
*** openstackgerrit has quit IRC | 14:03 | |
*** openstackgerrit_ has joined #openstack-nova | 14:04 | |
*** akshai has joined #openstack-nova | 14:04 | |
*** jwcroppe has quit IRC | 14:04 | |
*** haomaiwa_ has joined #openstack-nova | 14:04 | |
*** openstackgerrit_ is now known as openstackgerrit | 14:04 | |
*** openstackgerrit has quit IRC | 14:04 | |
*** jwcroppe has joined #openstack-nova | 14:04 | |
*** openstackgerrit_ has joined #openstack-nova | 14:05 | |
*** openstackgerrit_ is now known as openstackgerrit | 14:05 | |
*** openstackgerrit has quit IRC | 14:05 | |
*** openstackgerrit_ has joined #openstack-nova | 14:06 | |
*** openstackgerrit_ is now known as openstackgerrit | 14:06 | |
*** openstackgerrit has quit IRC | 14:07 | |
*** pwnall has joined #openstack-nova | 14:07 | |
*** openstackgerrit_ has joined #openstack-nova | 14:07 | |
*** gongysh has joined #openstack-nova | 14:07 | |
thomasem | hello | 14:07 |
*** openstackgerrit_ is now known as openstackgerrit | 14:08 | |
*** openstackgerrit has quit IRC | 14:08 | |
*** mdrabe has joined #openstack-nova | 14:08 | |
*** openstackgerrit_ has joined #openstack-nova | 14:08 | |
thomasem | danpb: +1 | 14:09 |
*** openstackgerrit_ is now known as openstackgerrit | 14:09 | |
*** gjayavel_ has joined #openstack-nova | 14:09 | |
*** jwcroppe has quit IRC | 14:09 | |
*** openstackgerrit has quit IRC | 14:09 | |
*** palexster has quit IRC | 14:09 | |
*** openstackgerrit_ has joined #openstack-nova | 14:09 | |
*** amotoki has quit IRC | 14:10 | |
*** openstackgerrit_ is now known as openstackgerrit | 14:10 | |
*** Guest41345 has joined #openstack-nova | 14:10 | |
*** palexster has joined #openstack-nova | 14:11 | |
openstackgerrit | Sean Dague proposed openstack/nova: API: Raise up HTTPNotFound when no availabe while get_console_output https://review.openstack.org/270695 | 14:11 |
mriedem | jichen: alex_xu: can we mark https://bugs.launchpad.net/nova/+bug/1552888 as fixed since https://review.openstack.org/#/c/288125/ is merged? | 14:11 |
openstack | Launchpad bug 1552888 in OpenStack Compute (nova) "ERROR (BadRequest): expected string or buffer" [High,In progress] - Assigned to Alex Xu (xuhj) | 14:11 |
sdague | mriedem: yeh, I think so | 14:12 |
*** burgerk has joined #openstack-nova | 14:12 | |
alex_xu | mriedem: yea | 14:12 |
sdague | there is a regression test up as well which can get approved | 14:12 |
alex_xu | I should create another bug for https://review.openstack.org/288268, and that looks like not very critical | 14:12 |
mriedem | done, thanks | 14:12 |
mriedem | sdague: i +Wed the regression test | 14:12 |
sdague | mriedem: ok, cool | 14:13 |
sdague | danpb: the conflict is intentional so there isn't every team meeting at 15:00 UTC and you can't participate in more than one | 14:13 |
openstackgerrit | Andrew Laski proposed openstack/nova: Change SpawnIsSynchronous fixture return https://review.openstack.org/290780 | 14:14 |
alaski | mriedem: fixed up ^. you'll need to rebase | 14:14 |
mriedem | alaski: ok | 14:15 |
*** cleong has joined #openstack-nova | 14:16 | |
*** claudiub has joined #openstack-nova | 14:16 | |
mriedem | bauzas: we just had that cve fix go through yesterday so i guess we need to doc that | 14:18 |
bauzas | mriedem: I agree | 14:18 |
mriedem | i can do one for that | 14:18 |
bauzas | mriedem: we also had 2 security fixes that I can't find as reno notes | 14:18 |
*** salv-orlando has quit IRC | 14:19 | |
mriedem | i'm pretty sure we did one for https://bugs.launchpad.net/nova/+bug/1516765 | 14:19 |
openstack | Launchpad bug 1516765 in OpenStack Compute (nova) liberty "[OSSA 2016-002] xenapi: volume_utils._parse_volume_info can leak connection password via StorageError (CVE-2015-8749)" [High,Fix committed] - Assigned to Matt Riedemann (mriedem) | 14:19 |
bauzas | mriedem: that'd be appreciated, I'm not that horizontally scalable :) | 14:19 |
bauzas | mriedem: yeah, that's ony of my duties this weeky | 14:19 |
bauzas | week | 14:19 |
mriedem | bauzas: hmm, we have a reno in liberty for CVE-2015-8749 but not mitaka, i'll forward port that | 14:20 |
openstackgerrit | Maciej Szankin proposed openstack/nova: Live migration failure in API leaves VM in MIGRATING state https://review.openstack.org/168916 | 14:20 |
bauzas | mriedem: ack | 14:20 |
johnthetubaguy | mriedem: alex_xu: awesome | 14:21 |
*** jichen has quit IRC | 14:21 | |
*** mtanino has quit IRC | 14:22 | |
markus_z | bauzas: What did you mean with the "automatic dash" in the meeting? | 14:22 |
bauzas | markus_z: https://github.com/sbauza/gerrit-dashboard-nfv | 14:23 |
openstackgerrit | Dongcan Ye proposed openstack/nova: VMware: Always update image size for sparse image https://review.openstack.org/291203 | 14:23 |
*** garyk2 has joined #openstack-nova | 14:23 | |
johnthetubaguy | bauzas: I can look into some of those notes, if we have a list of the ones we need (which I guess is in the etherpad), goes to look... | 14:23 |
bauzas | markus_z: that's basically looking at launchpad whiteboard for getting the list and providing the dash | 14:23 |
garyk2 | johnthetubaguy: is there anychance that someone can please look at https://review.openstack.org/284121 | 14:23 |
bauzas | markus_z: but what we could be doing is calling an bitly API for modifying the long URL | 14:24 |
bauzas | johnthetubaguy: for the moment, nothing really catched by me | 14:24 |
bauzas | except the security bugs that I need to take care | 14:25 |
markus_z | bauzas: nice, let me take a look at it | 14:25 |
bauzas | johnthetubaguy: the features and upgrades should be quite good now | 14:25 |
*** irenab has quit IRC | 14:25 | |
*** tbachman has joined #openstack-nova | 14:25 | |
*** Daisy has quit IRC | 14:25 | |
*** ildikov has joined #openstack-nova | 14:25 | |
*** Daisy has joined #openstack-nova | 14:26 | |
*** salv-orlando has joined #openstack-nova | 14:26 | |
johnthetubaguy | garyk2: I can try to hit that one, it would be good to clean up the subteam list on the etherpad, seems to be stale | 14:27 |
*** parora has quit IRC | 14:28 | |
mriedem | garyk2: can you update the commit message to explain what the issue is and how this fixes it? | 14:28 |
johnthetubaguy | bauzas: OK, thats cool | 14:28 |
*** artom has joined #openstack-nova | 14:28 | |
*** dims has quit IRC | 14:29 | |
*** salv-orlando has quit IRC | 14:29 | |
*** artom has quit IRC | 14:29 | |
*** artom has joined #openstack-nova | 14:29 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: Live migration failure in API leaves VM in MIGRATING state https://review.openstack.org/168916 | 14:30 |
*** Daisy has quit IRC | 14:30 | |
garyk2 | johnthetubaguy: mriedem: sure, will update and get the greater team to look at it. | 14:30 |
*** ociuhandu has joined #openstack-nova | 14:30 | |
mriedem | thanks | 14:30 |
mriedem | garyk2: and i'm assuming vmware nsx ci is not hitting that code path? | 14:31 |
*** bharath has joined #openstack-nova | 14:31 | |
mriedem | i wasn't sure if it was using opaque networks / nsxv3 | 14:31 |
garyk2 | mriedem: at the moment the NSX CI is just running the neutron API tests. We hit this issue when running the tempest tests with Nova. | 14:31 |
garyk2 | opaque networks == nsx_v3 | 14:31 |
mriedem | orly | 14:31 |
garyk2 | the CI running for the VCdriver is with the nova network | 14:32 |
*** gongysh has quit IRC | 14:32 | |
mriedem | oh... | 14:32 |
mriedem | any plans to change that to neutron at some point? | 14:32 |
garyk2 | we are working on getting it to post for neutron too. | 14:32 |
*** xyang1 has joined #openstack-nova | 14:34 | |
*** tdurakov_ has quit IRC | 14:35 | |
*** edtubill has joined #openstack-nova | 14:35 | |
*** dims has joined #openstack-nova | 14:35 | |
*** eliqiao1 has quit IRC | 14:36 | |
*** zz_dimtruck is now known as dimtruck | 14:36 | |
markus_z | bauzas: not sure if the dashboard is the right thing. How do I update it when the data in launchpad changes? | 14:36 |
bauzas | markus_z: using cron | 14:36 |
bauzas | markus_z: but I provided you this for seeing how to use launchpadlib | 14:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add release notes for security fixes in 13.0.0 mitaka GA https://review.openstack.org/291208 | 14:37 |
mriedem | bauzas: ^ | 14:37 |
sdague | alex_xu: +2 on https://review.openstack.org/#/c/288268/ | 14:37 |
markus_z | bauzas: ah, thanks. I already know how to work with launchpadlib: https://github.com/markuszoeller/openstack/tree/master/scripts/launchpad | 14:38 |
alex_xu | sdague: thanks! | 14:38 |
markus_z | bauzas: ^ that's how I build the stuff for the etherpad | 14:38 |
bauzas | mriedem: just a note for the prelude section | 14:38 |
*** erno has quit IRC | 14:38 | |
mriedem | will fix | 14:39 |
bauzas | markus_z: so probably using cron for calling launchpadlib and then modifying a short URL ? | 14:39 |
markus_z | bauzas: getting the shorturl is done in a few seconds | 14:40 |
johnthetubaguy | mriedem: FYI, is looking like the OSIC folks will put some real effort into that feature classification stuff, so we can ramp up the testing ASAP | 14:40 |
bauzas | markus_z: sure, but that's an human thing | 14:40 |
sdague | bauzas: honestly, I feel like it's going to be a losing battle | 14:40 |
*** edtubill has quit IRC | 14:40 | |
sdague | because short urls use redirects, so the thing in your webbrowser can't be bookmarked | 14:40 |
bauzas | sdague: tbh, I'm using the new Gerrit UI for my own dashes | 14:41 |
bauzas | sdague: I mean, the ones I use with your own project | 14:41 |
*** pcaruana has quit IRC | 14:41 | |
sdague | bauzas: ok, I just make them bookmarks | 14:41 |
bauzas | sdague: but since the URL is dynamic | 14:41 |
bauzas | sdague: it's difficult | 14:41 |
sdague | honestly, the thing I'd do, is make it a tool that you run, and it opens your browser | 14:41 |
bauzas | sdague: why not | 14:42 |
sdague | webbrowser.open(url) | 14:42 |
sdague | it's baked into python | 14:42 |
bauzas | sdague: I was thinking of a shortening service because everyone can use that without the tool | 14:42 |
*** haukebruno has quit IRC | 14:42 | |
sdague | right, but you get the persistent link issues | 14:42 |
*** haukebruno has joined #openstack-nova | 14:42 | |
bauzas | sdague: hence calling the shortening service API to modify the long URL | 14:43 |
*** mrkz has joined #openstack-nova | 14:43 | |
sdague | sure | 14:43 |
bauzas | unless I misunderstood your point | 14:43 |
markus_z | The tool I have prints the long url to the gerrit query. The short url in the etherpad was just for convenience. | 14:43 |
*** edtubill has joined #openstack-nova | 14:43 | |
*** ducttape_ has joined #openstack-nova | 14:43 | |
sdague | but if you actually follow that link, it will resolve in your browser | 14:43 |
bauzas | what I'd like to avoid is waiting markus_z or hassling it to update the query :p | 14:43 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add release notes for security fixes in 13.0.0 mitaka GA https://review.openstack.org/291208 | 14:43 |
bauzas | hassling him* | 14:44 |
markus_z | bauzas: You can clone my repo and execute it as you like. :) | 14:44 |
*** mgoddard_ has joined #openstack-nova | 14:44 | |
*** cdent has quit IRC | 14:44 | |
* markus_z doesn't want do be hasselhoffed | 14:44 | |
bauzas | markus_z: heh, okay | 14:44 |
bauzas | markus_z: sure, I can play scripts locally :p | 14:44 |
*** esracelik has quit IRC | 14:44 | |
alex_xu | pkoniszewski: hope you take a look at this https://review.openstack.org/290289 | 14:44 |
bauzas | I was just thinking of people wanting to contribute reviewing those and *not* running that script, but anyway :) | 14:45 |
*** masayukig has quit IRC | 14:45 | |
markus_z | bauzas: that's too easy :) I have to go early today, maybe in the evening I can put it on a server of mine. | 14:46 |
* tbachman wonders what it means to be hasselhoffed | 14:46 | |
tbachman | Night Driver? | 14:46 |
tbachman | Baywatch? | 14:46 |
bauzas | markus_z: heh | 14:46 |
tbachman | Night Rider? | 14:46 |
* tbachman has a bad memory | 14:46 | |
markus_z | tbachman: vodka soaked burgers will be thrown at you ;) | 14:46 |
tbachman | markus_z: if you can eat fast enough, is that a bad thing? | 14:46 |
tbachman | ;) | 14:47 |
*** masayukig has joined #openstack-nova | 14:47 | |
tbachman | entertaining, to be sure | 14:47 |
markus_z | tbachman: I'm not as young anymore as I used to be :) | 14:47 |
tbachman | lol | 14:47 |
*** mgoddard has quit IRC | 14:47 | |
tbachman | I must have missed the Baywatch episode with the vodka soaked burgers | 14:47 |
tbachman | actually, I missed every episode | 14:47 |
*** roeyc has quit IRC | 14:48 | |
markus_z | It's a classic, every episode is a classic, you should binge-watch it this evening. | 14:48 |
tbachman | lol | 14:48 |
*** roeyc has joined #openstack-nova | 14:48 | |
* markus_z leaves for today, see you | 14:48 | |
*** haukebruno has quit IRC | 14:48 | |
tbachman | internet: tool for…. progress? | 14:48 |
tbachman | markus_z: l8r | 14:48 |
*** salv-orlando has joined #openstack-nova | 14:50 | |
*** edtubill has quit IRC | 14:50 | |
*** eharney has joined #openstack-nova | 14:52 | |
cfriesen__ | is there a way to make "rebuild" overwrite the rootfs in the boot-from-volume case? | 14:53 |
*** shangxdy has joined #openstack-nova | 14:53 | |
*** pcaruana has joined #openstack-nova | 14:53 | |
*** lefaiseur has quit IRC | 14:54 | |
ansiwen | gate-nova-pep8 fails here, although locally `tox -e pep8` is successful. it complains "F821 undefined name 'utils'", although there is a `from nova import utils` in the beginning: https://review.openstack.org/#/c/285562 | 14:54 |
ansiwen | any idea? | 14:55 |
*** ekuris_ has quit IRC | 14:55 | |
*** lefaiseur has joined #openstack-nova | 14:55 | |
*** tdurakov_ has joined #openstack-nova | 14:55 | |
*** jaosorior has joined #openstack-nova | 14:56 | |
mriedem | ansiwen: huh, looks correct to me | 14:57 |
pkoniszewski | johnthetubaguy: just a question regarding your comment here https://review.openstack.org/#/c/287363/7/nova/virt/libvirt/driver.py@6407 | 14:57 |
johnthetubaguy | cfriesen__: no, but I know our product managers are requesting that feature actually, or something kinda like that, also relates to PaulMurray's work on detaching the root volume of a boot from volume instance | 14:57 |
pkoniszewski | johnthetubaguy: we don't allow new->old live migrations, i mean, mitaka->liberty | 14:57 |
pkoniszewski | do we? | 14:57 |
johnthetubaguy | pkoniszewski: in general, I thought we did allow that, but we actually stopped the new API working until the upgrade is completed | 14:58 |
*** edtubill has joined #openstack-nova | 14:58 | |
*** bharath has quit IRC | 14:58 | |
*** belmoreira has quit IRC | 14:59 | |
johnthetubaguy | pkoniszewski: this logic isn't quite what if first looks like: https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L152 | 14:59 |
ansiwen | mriedem: my code looks correct, you mean? | 14:59 |
mriedem | ansiwen: yeah | 14:59 |
ansiwen | mriedem: yes, that's why I'm wondering | 15:00 |
openstackgerrit | Gleb Stepanov proposed openstack/nova: Redundant argument removed https://review.openstack.org/291218 | 15:00 |
ansiwen | it's weird | 15:00 |
*** haomaiwa_ has quit IRC | 15:01 | |
*** haomaiwang has joined #openstack-nova | 15:01 | |
*** mtanino has joined #openstack-nova | 15:01 | |
pkoniszewski | johnthetubaguy: so, i think we won't break things there, because block_migration is not used anywhere during post operations in both, liberty and mitaka | 15:02 |
*** edtubill has quit IRC | 15:02 | |
openstackgerrit | Alex Xu proposed openstack/nova: Report instance-actions for live migration force complete API https://review.openstack.org/290289 | 15:02 |
*** mgoddard_ has quit IRC | 15:03 | |
*** mgoddard has joined #openstack-nova | 15:03 | |
*** dimtruck is now known as zz_dimtruck | 15:04 | |
*** Jeffrey4l has joined #openstack-nova | 15:04 | |
johnthetubaguy | pkoniszewski: so I thought that was probably true, but it feels risky to change that at this point, I am thinking of going back to a minimal fix, then revisiting with the bigger refactor. what do you think? | 15:04 |
alex_xu | oomichi: hope you can take look at this one when you have time https://review.openstack.org/288268, thanks! | 15:04 |
pkoniszewski | johnthetubaguy: this sounds good, let me change it | 15:05 |
tdurakov_ | pkoniszewski, you could pick code from snippet for that | 15:05 |
johnthetubaguy | pkoniszewski: well, the compute manager changes seem worthwhile, I am just thinking about keeping the driver changes minimal, maybe add some FIXMEs for later, so we don't forget when we revisit this | 15:05 |
*** cdent has joined #openstack-nova | 15:05 | |
pkoniszewski | johnthetubaguy: yes, thats what im thinking about too | 15:05 |
johnthetubaguy | pkoniszewski: cool | 15:06 |
*** burgerk has quit IRC | 15:06 | |
*** rdopiera has quit IRC | 15:06 | |
*** moshele has quit IRC | 15:07 | |
openstackgerrit | Jianghua Wang proposed openstack/nova: XenAPI: add unit test for plugin bandwidth https://review.openstack.org/286445 | 15:08 |
*** cdent has quit IRC | 15:09 | |
*** cdent has joined #openstack-nova | 15:09 | |
*** tdurakov_ has quit IRC | 15:11 | |
lennyb | mriedem: Hi, you were looking for me, how can I help? | 15:12 |
mriedem | lennyb: i was looking to run the mellanox ci on a patch, tried to figure out how to recheck for that, it wasn't on the wiki and the contact email on the wiki is blocked | 15:12 |
mriedem | here https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI | 15:13 |
bauzas | ansiwen: could you please make sure that your change is locally rebased on a master up-to-date ? | 15:13 |
openstackgerrit | Yingxin Cheng proposed openstack/nova: split host_state.least_disk_mb out of free_disk_mb https://review.openstack.org/290302 | 15:13 |
mriedem | lennyb: i see you've updated the contact info, to be lennyb@mellanox.com | 15:13 |
mriedem | thanks | 15:13 |
mriedem | lennyb: is there a way to recheck the mellanox ci on a patch? | 15:13 |
bauzas | ansiwen: chances are that you're getting a pep8 conflict because your change is rebased on a top master | 15:14 |
lennyb | mriedem: it's 'recheck nova-mlnx' as written in #link https://review.openstack.org/#/c/242573/ ( look for Mellanox CI comments) | 15:14 |
ansiwen | bauzas: ok, I will try | 15:14 |
bauzas | ansiwen: I can test that too, lemme verify | 15:14 |
mriedem | lennyb: ok, i looked at an older post from the ci and the recheck info wasn't in there | 15:14 |
mriedem | lennyb: can you also get that into the wiki? | 15:15 |
lennyb | mriedem: sure. | 15:15 |
mriedem | lennyb: and finally :) | 15:15 |
mriedem | lennyb: would it be possible to run a compute api resize test on that patch alone? | 15:15 |
*** efried has quit IRC | 15:15 | |
mriedem | since i'm told resize with sriov is busted and that patch fixes it, | 15:15 |
mriedem | but i'd like at least one of the sriov 3rd party CIs to verify that | 15:15 |
mriedem | *resize/migrate | 15:15 |
ansiwen | bauzas: right, that was the problem | 15:16 |
*** salv-orlando has quit IRC | 15:16 | |
lennyb | mriedem, I will check it and update you soon. | 15:16 |
mriedem | lennyb: thanks | 15:16 |
ansiwen | bauzas: so, gate is rebasing the change even for the first verify? | 15:16 |
bauzas | ansiwen: glad to hear | 15:16 |
bauzas | ansiwen: what you call 'gate' is the check pipeline and yes, indeed | 15:16 |
ansiwen | bauzas: well, I call it gate, because the job is called "gate-nova-pep8" ;-) | 15:17 |
dansmith | because it's the same job | 15:17 |
*** gjayavel_ has quit IRC | 15:18 | |
bauzas | ansiwen: http://logs.openstack.org/62/285562/5/check/gate-nova-pep8/17be69b/console.html#_2016-03-09_17_16_37_751 | 15:18 |
*** knikolla has joined #openstack-nova | 15:19 | |
bauzas | ansiwen: it's now hidden behind the zuul cloner script, but that's basically a rebase everytime | 15:19 |
bauzas | ansiwen: if you want to know more about zuul and infra, I can point you some summit session videos | 15:19 |
lennyb | mriedem: regarding posting how to recheck in wiki, I am not sure that this is a accepted format. None of the third parties CIs has it. I can verify this with anteaya, but as I've mentioned it is written in CI comment of the patch set | 15:19 |
*** lefaiseur has quit IRC | 15:19 | |
*** zz_dimtruck is now known as dimtruck | 15:19 | |
mriedem | lennyb: i've noticed that, but i'm not sure why, | 15:20 |
mriedem | because a lot of the time, 3rd party ci hasn't shown up on a change, and it's not marked as down in the wiki, | 15:20 |
mriedem | so i want to manually kick it | 15:20 |
bauzas | ansiwen: http://docs.openstack.org/infra/system-config/zuul.html#overview | 15:20 |
mriedem | so i can't use the recheck from the comment b/c hte comment hasn't come yet | 15:20 |
anteaya | lennyb: you can add anything you want to your wikipage | 15:20 |
lennyb | anteaya: thanks | 15:20 |
anteaya | lennyb: the template is just asking for minimal things, you can add any additional items to your page | 15:21 |
anteaya | either in the table or below it | 15:21 |
anteaya | and responding to dev's requests is always a great idea | 15:21 |
anteaya | so thank you | 15:21 |
*** jaosorior has quit IRC | 15:23 | |
BobBall | alaski: Not sure if you're receiving comments on https://bugs.launchpad.net/nova/+bug/1512955 but the XenAPI fix is https://review.openstack.org/#/c/241127/ - not sure why LaunchPad/Gerrit didn't add the link when it was first proposed (but clearly it didn't help ease confusion when a similar Xen fix was posted...) | 15:25 |
openstack | Launchpad bug 1512955 in OpenStack Compute (nova) "Race condition in nova/neutron when booting instance with XenAPI driver" [Medium,In progress] - Assigned to huan (huan-xie) | 15:25 |
mriedem | mikal: dansmith: sdague: johnthetubaguy: tonyb: garyk2: i'll probably request a liberty 12.0.3 release next week for that cve fix, we should get the release note in for that https://review.openstack.org/#/c/291221/ | 15:26 |
dansmith | cool | 15:27 |
sdague | mriedem: all the backport patches landed? | 15:27 |
sdague | sounds like it should trigger on kilo as well, no? | 15:27 |
mriedem | sdague: yeah | 15:28 |
sdague | +A on the reno | 15:28 |
mriedem | kilo is still a mass push at once | 15:28 |
mriedem | so i probably need to talk to Daviey about that | 15:28 |
pkoniszewski | one question - can nova-api write to DB by itself, or does it write everything through conductor? | 15:28 |
alaski | BobBall: I am not receiving comments, so thanks | 15:28 |
mriedem | pkoniszewski: you can enable local conductor, | 15:28 |
mriedem | but it's deprecated | 15:28 |
dansmith | pkoniszewski: api can always write to the db, yes | 15:29 |
johnthetubaguy | pkoniszewski: but it makes most DB calls directly | 15:29 |
johnthetubaguy | well, all DB calls, it does also use the conductor, but thats the task API | 15:29 |
*** Daisy has joined #openstack-nova | 15:29 | |
*** efried has joined #openstack-nova | 15:29 | |
*** aysyd has quit IRC | 15:30 | |
pkoniszewski | thanks! :) | 15:30 |
*** aysyd has joined #openstack-nova | 15:30 | |
bauzas | pkoniszewski: all our services are using the object facade, but only the computes are having an indirection set | 15:31 |
bauzas | pkoniszewski: https://github.com/openstack/nova/blob/master/nova/cmd/compute.py#L64-L67 | 15:31 |
dansmith | bauzas: and network | 15:31 |
mriedem | bauzas: and nova-net | 15:31 |
dansmith | bauzas: and metadata :) | 15:31 |
bauzas | oh right, dammit | 15:31 |
bauzas | those | 15:31 |
pkoniszewski | well, i think i need to dig through this, thanks bauzas | 15:31 |
mriedem | and cert! | 15:31 |
bauzas | okay okay | 15:32 |
*** liusheng has quit IRC | 15:32 | |
mriedem | pkoniszewski: you can see which services by looking at their commands under nova/cmd/ | 15:32 |
*** READ10 has joined #openstack-nova | 15:32 | |
bauzas | s/only computes/only services running on compute/ | 15:32 |
mriedem | http://codesearch.openstack.org/?q=block_db_access&i=nope&files=&repos= | 15:32 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Use migrate_data.block_migration instead of block_migration https://review.openstack.org/287363 | 15:32 |
bauzas | mriedem: I jinxed you, see above | 15:32 |
*** eharney has quit IRC | 15:32 | |
bauzas | nah/ | 15:32 |
mriedem | oh not cert i guess | 15:32 |
bauzas | anyway, /me runs | 15:33 |
*** garyk2 has quit IRC | 15:33 | |
*** sridharg has quit IRC | 15:34 | |
*** aorourke-afk is now known as aorourke | 15:34 | |
pkoniszewski | mriedem: thanks, that's the easy way :) | 15:34 |
*** burgerk has joined #openstack-nova | 15:35 | |
*** eharney has joined #openstack-nova | 15:35 | |
mdbooth | My change, which simply adds a comment to the libvirt driver, got a -1 from xenserver ci :) | 15:36 |
BobBall | we don't like comments mdbooth | 15:36 |
mriedem | dansmith: do we care about making a Certificate object? | 15:36 |
mriedem | BobBall: the xenlight failure is pretty bad in the xenproject ci | 15:36 |
mdbooth | BobBall: Neither does the libvirt driver, so you're in good company :) | 15:36 |
BobBall | The CI thinks that code should be self-commenting ;) | 15:37 |
dansmith | mriedem: I dunno, do we? | 15:38 |
lennyb | mriedem: which exact tempest tests are you interested in #link http://paste.openstack.org/show/490019/ ? | 15:38 |
BobBall | mriedem: I believe there's a fix pending for that (it's around networking) - https://review.openstack.org/#/c/199093/ (although clearly Anthony has work to do to get it working) | 15:38 |
sdague | do we remember where the glance bug is for this - https://bugs.launchpad.net/nova/+bug/1555638 ? | 15:38 |
openstack | Launchpad bug 1555638 in OpenStack Compute (nova) "nova image-list return HTTP500" [Undecided,New] | 15:38 |
mriedem | BobBall: hasn't been updated in 3 months | 15:39 |
BobBall | mriedem: I know. I will happily send him an email. Do you have an example failure to hand I can use to kick Anthony into reworking his patch? | 15:39 |
mriedem | BobBall: honestly i kind of feel like we should silence the xen project ci until that's fixed | 15:39 |
mriedem | BobBall: no, but i've rechecked several this week | 15:39 |
mriedem | BobBall: and it's gotten to the point that i hardly pay attention to that ci anymore | 15:39 |
*** jwcroppe has joined #openstack-nova | 15:39 | |
danpb | jaypipes:can you take another look at https://review.openstack.org/#/c/282436/ | 15:39 |
mriedem | dansmith: sure. in newton. | 15:40 |
mriedem | dansmith: i'm sure rlrossit would be happy to do that. | 15:40 |
rlrossit | do what now? | 15:40 |
mriedem | lennyb: i suppose at least tempest.api.compute.servers.test_server_actions.ServerActionsTestJSON.test_resize_server_confirm | 15:41 |
BobBall | mriedem: Indeed. I will make a note of it to Anthony and the rest of the Xen team. I hope they will fix it soon. | 15:41 |
mriedem | lennyb: and tempest.api.compute.servers.test_server_actions.ServerActionsTestJSON.test_resize_server_revert | 15:41 |
mriedem | lennyb: those are the 2 normal/happy path tests for resize | 15:41 |
mriedem | BobBall: thanks | 15:41 |
mriedem | rlrossit: create an object for the Certificate db model | 15:42 |
sdague | https://bugs.launchpad.net/nova/+bug/1527925 looks like it is it | 15:42 |
openstack | Launchpad bug 1527925 in Glance "glanceclient.exc.HTTPInternalServerError when running nova image-list" [High,Confirmed] | 15:42 |
rlrossit | ah I remember talking to doffm about it | 15:42 |
mriedem | sdague: there was a new bug for the same thing | 15:42 |
*** lefaiseur has joined #openstack-nova | 15:42 | |
mriedem | someone must have duped it | 15:42 |
*** Daisy has quit IRC | 15:42 | |
*** Daisy has joined #openstack-nova | 15:42 | |
sdague | mriedem: right, it gets reported a lot | 15:43 |
sdague | it's the issue of glanceclient exploding in v1 vs v2 attributes | 15:43 |
sdague | iirc | 15:43 |
jaypipes | danpb: trying my best. meeting hell today unfortunately. I asked dansmith to take a looksie as well from an o.vo perspecitve. | 15:44 |
danpb | jaypipes: i changed it to use ovo since your comment | 15:45 |
*** pece has quit IRC | 15:45 | |
*** gjayavel_ has joined #openstack-nova | 15:45 | |
jaypipes | danpb: cool, thank you. I will try my best to get to that later today. apologies for delay. | 15:45 |
dansmith | danpb: anything that flows from neutron to nova is in response to nova having done something and requested neutron to do a thing, right? | 15:46 |
danpb | dansmith: yes | 15:46 |
dansmith | danpb: so the way we handle this now from compute->conductor, is whenever we make a call, we pass a manifest of our object versions, which is small, to conductor and it then knows what needs to happen for us | 15:47 |
dansmith | not based on any package version, or parent object version with assumptions, etc | 15:47 |
dansmith | so can we pass that (or a similar) manifest to neutron on the initial call so that it already knows what we want back? that would avoid hard-coding, hard ordering requirements, | 15:48 |
dansmith | and let one neutron service multiple novas without having to clamp to the minimum version | 15:48 |
danpb | dansmith: that problems already dealt with | 15:48 |
mriedem | johnthetubaguy: there is no version bump on https://review.openstack.org/#/c/288927/ because a version bump means we need a compat handler, and there is no compat handling for this change | 15:48 |
mriedem | johnthetubaguy: it's not like adding a new attribute | 15:49 |
lennyb | mriedem: I've added those tests to Mellanox CI and asked for recheck. I will try to check the result later | 15:49 |
dansmith | danpb: it sounded like from your last comment (before your last rev) that it was a thing needing solving.. so what's the plan now? | 15:49 |
danpb | when nova tells neutron what VIFs are supported for a particular plugin,the plugin says what versions it is willing to accept | 15:49 |
mriedem | lennyb: awesome, thanks | 15:49 |
*** browne has joined #openstack-nova | 15:49 | |
*** dimtruck is now known as zz_dimtruck | 15:49 | |
dansmith | danpb: okay good | 15:49 |
*** EinstCrazy has quit IRC | 15:49 | |
danpb | the problem i'm having is actually about encoding this info that nova sends to neutron | 15:49 |
danpb | ie when we tell neutron what plugins we support, we have send this info to neutron | 15:49 |
danpb | previously i suggested just sending a json doc with it, but jaypipes thought it should also be a versioned object | 15:50 |
*** baoli has quit IRC | 15:50 | |
dansmith | danpb: okay, my reading of this back then was that you were concerned about the other way around | 15:50 |
danpb | so https://review.openstack.org/#/c/282436/2/os_vif/objects/compute_info.py introduces a ComputeInfo object that contains info about the plugins | 15:50 |
*** ildikov has quit IRC | 15:50 | |
dansmith | danpb: so you're concerned about us sending a newer version than it can handle? | 15:50 |
*** baoli has joined #openstack-nova | 15:51 | |
danpb | with the idea that we'll call obj_to_primitive on it, and sent the result to neutron | 15:51 |
danpb | yeah, this obviously means that neutron's version of os-vif, has to be at least as new as nova's | 15:51 |
danpb | i was concerned about that initially, but IIUC for live upgrades we already mandated that neutron is updated before nova | 15:51 |
danpb | so i'm now thinking this requirement is no big deal | 15:51 |
dansmith | danpb: so, we could ask the neutron api to deserialize the object syncrhonously, and if it fails, return a 400 with "max-version is $foo" and then we can try again (and cache that version) | 15:51 |
*** angdraug has joined #openstack-nova | 15:52 | |
*** yamahata has joined #openstack-nova | 15:52 | |
danpb | oh that's an interesting idea | 15:52 |
dansmith | should be an easy thing to do | 15:52 |
*** zz_dimtruck is now known as dimtruck | 15:53 | |
*** palexster has quit IRC | 15:53 | |
*** ssurana has joined #openstack-nova | 15:53 | |
danpb | ok, so using ovo is fine then | 15:54 |
*** palexster has joined #openstack-nova | 15:54 | |
jaypipes | that would pretty much match what we do now with the API and conductor services, right dansmith? | 15:54 |
dansmith | jaypipes: yar | 15:54 |
dansmith | jaypipes: and be more "just works" user experience which I think is good | 15:55 |
jaypipes | ++ | 15:55 |
*** rk4n has quit IRC | 15:57 | |
*** kfarr has joined #openstack-nova | 15:59 | |
*** jistr has quit IRC | 15:59 | |
*** vishwanathj_zzz is now known as vishwanathj | 16:00 | |
*** Jeffrey4l has quit IRC | 16:00 | |
*** armax has joined #openstack-nova | 16:00 | |
*** rk4n has joined #openstack-nova | 16:00 | |
*** haomaiwang has quit IRC | 16:01 | |
*** pwnall has quit IRC | 16:01 | |
*** haomaiwang has joined #openstack-nova | 16:01 | |
openstackgerrit | Sven Anderson proposed openstack/nova: Avoid parallel DB queries of identical metadata https://review.openstack.org/285562 | 16:01 |
*** READ10 is now known as READ10|away | 16:02 | |
ansiwen | bauzas: thanks for the hin | 16:04 |
ansiwen | hint | 16:04 |
*** pwnall has joined #openstack-nova | 16:05 | |
johnthetubaguy | mriedem: yeah, agreed its not needed | 16:05 |
*** pradk has quit IRC | 16:06 | |
*** oomichi_ has joined #openstack-nova | 16:06 | |
*** haomaiwang has quit IRC | 16:07 | |
*** nkrinner has quit IRC | 16:08 | |
*** gjayavelu has quit IRC | 16:08 | |
*** mjura has quit IRC | 16:09 | |
*** pushkaru has joined #openstack-nova | 16:09 | |
*** kmartin has joined #openstack-nova | 16:16 | |
*** tbachman has quit IRC | 16:16 | |
*** sayalilunkad has quit IRC | 16:16 | |
*** oomichi_ has quit IRC | 16:18 | |
*** sayalilunkad has joined #openstack-nova | 16:19 | |
*** oomichi_ has joined #openstack-nova | 16:19 | |
*** edtubill has joined #openstack-nova | 16:20 | |
mriedem | sdague: i think i'm going to remove these redundant not implemented checks in https://review.openstack.org/#/c/290134/6/nova/tests/unit/virt/vmwareapi/test_driver_api.py | 16:22 |
mriedem | those are tested in test_virt_drivers | 16:22 |
*** baoli has quit IRC | 16:23 | |
*** tbachman has joined #openstack-nova | 16:26 | |
*** ZZelle has quit IRC | 16:27 | |
*** bharath has joined #openstack-nova | 16:28 | |
*** ildikov has joined #openstack-nova | 16:29 | |
*** baoli has joined #openstack-nova | 16:29 | |
*** sc68cal has joined #openstack-nova | 16:30 | |
*** jdurgin1 has joined #openstack-nova | 16:31 | |
*** sc68cal_ has joined #openstack-nova | 16:31 | |
*** bharathk has joined #openstack-nova | 16:32 | |
*** bharath has quit IRC | 16:32 | |
*** kfarr has quit IRC | 16:33 | |
*** harlowja_at_home has joined #openstack-nova | 16:33 | |
*** shangxdy has quit IRC | 16:35 | |
*** jlanoux has quit IRC | 16:36 | |
*** irenab has joined #openstack-nova | 16:37 | |
*** ctrath has joined #openstack-nova | 16:38 | |
*** Daisy has quit IRC | 16:39 | |
*** Daisy has joined #openstack-nova | 16:40 | |
*** rfolco has joined #openstack-nova | 16:40 | |
*** ducttape_ has quit IRC | 16:42 | |
*** rfolco_ has quit IRC | 16:43 | |
*** Daisy has quit IRC | 16:44 | |
*** efried has quit IRC | 16:45 | |
*** e0ne_ has quit IRC | 16:46 | |
*** roeyc has quit IRC | 16:47 | |
*** pcaruana has quit IRC | 16:47 | |
*** tbachman has quit IRC | 16:48 | |
*** ihrachys has quit IRC | 16:48 | |
*** scheuran has quit IRC | 16:49 | |
*** burt has joined #openstack-nova | 16:49 | |
*** READ10|away is now known as READ10 | 16:53 | |
rlrossit | mriedem: for your comment in https://review.openstack.org/#/c/290550/2/nova/volume/cinder.py I think the reason they have translate_volume_exception is so they can catch NotFound on the volume_id | 16:54 |
*** tbachman has joined #openstack-nova | 16:54 | |
*** READ10 has quit IRC | 16:54 | |
rlrossit | wow this feels like it will be terrible to try to do the snapshot stuff | 16:54 |
*** ducttape_ has joined #openstack-nova | 16:55 | |
*** jwcroppe has quit IRC | 16:58 | |
*** jwcroppe has joined #openstack-nova | 16:59 | |
*** efried has joined #openstack-nova | 16:59 | |
*** ducttape_ has quit IRC | 16:59 | |
mriedem | rlrossit: damn, you're right https://github.com/openstack/cinder/blob/master/cinder/api/v2/snapshots.py#L168 | 17:00 |
*** ihrachys has joined #openstack-nova | 17:00 | |
mriedem | rlrossit: idk, maybe snapshot_create needs the snapshot decorator and has to handle NotFound explicitly | 17:01 |
rlrossit | mriedem: yeah I left a comment on that with an overview of what we need to do in that func | 17:01 |
mriedem | but i've already closed the tab! | 17:01 |
rlrossit | ctrl+shift+t | 17:02 |
rlrossit | use it | 17:02 |
*** EinstCrazy has joined #openstack-nova | 17:03 | |
*** jwcroppe has quit IRC | 17:03 | |
*** lucasagomes is now known as lucas-afk | 17:04 | |
mriedem | rlrossit: if you could use your volume exception decorator also a context manager... | 17:04 |
mriedem | you could use that in the snapshot_create method | 17:04 |
mriedem | and decorate the method with the snapshot decorator | 17:04 |
rlrossit | yeesh | 17:04 |
*** dims has quit IRC | 17:04 | |
*** ndipanov has quit IRC | 17:04 | |
mriedem | don't yeesh me | 17:04 |
*** mpavone has quit IRC | 17:05 | |
*** derekh has quit IRC | 17:05 | |
*** rk4n has quit IRC | 17:05 | |
rlrossit | mriedem: can't use the volume decorator as a context manager though | 17:05 |
rlrossit | it'll steal the OverLimit from the snapshot decorator them | 17:05 |
rlrossit | *then | 17:05 |
mriedem | oh, right | 17:05 |
*** rmart04 has quit IRC | 17:05 | |
mriedem | well, | 17:06 |
mriedem | f it | 17:06 |
*** dims has joined #openstack-nova | 17:06 | |
rlrossit | ha | 17:06 |
mriedem | just try/except like a mofo | 17:06 |
mriedem | that's how the neutronv2 wrapper code works | 17:06 |
mriedem | and if there is one thing i know, we want more of nova to look like nova.network.neutronv2.api | 17:06 |
rlrossit | I will make it as ugly as possible, just for you | 17:06 |
*** Bjoern_ has joined #openstack-nova | 17:07 | |
rlrossit | Is oomichi around to answer that question we had about the API yesterday? | 17:07 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: check for optional LibvirtLiveMigrateData attrs before loading https://review.openstack.org/286828 | 17:07 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods https://review.openstack.org/290134 | 17:07 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Change SpawnIsSynchronous fixture return https://review.openstack.org/290780 | 17:07 |
mriedem | rlrossit: i think you have to say his name 2 more times | 17:07 |
rlrossit | oomichi: | 17:07 |
rlrossit | beetlejuice | 17:07 |
rlrossit | ah crap | 17:07 |
oomichi_ | rlrossit: ? | 17:07 |
rlrossit | mriedem and I had a question yesterday about being able to toss 403 back for pretty much everything on the os-volumes | 17:08 |
* rlrossit goes back in the logs to dig out the question | 17:08 | |
*** EinstCrazy has quit IRC | 17:08 | |
mriedem | basically is there a simple way to handle 403 generically in the REST API code | 17:09 |
*** rk4n has joined #openstack-nova | 17:09 | |
mriedem | i.e. if nova.exception.Forbidden comes back | 17:09 |
* oomichi_ checking the code... | 17:09 | |
mriedem | can something translate that to a webob exception and raise it up | 17:09 |
mriedem | rather than having to add that try/except in every possible volume api method that could hit it | 17:09 |
rlrossit | and also having to put 403 in the possible returns on all of the functions too | 17:10 |
rlrossit | which, arguably, isn't all that terrible | 17:10 |
mriedem | rlrossit: well, i think jsonvalidator will require that anyway | 17:10 |
rlrossit | I have no idea what that means, but I'll nod in agreement | 17:10 |
mriedem | the schema validation stuff in the v2.1 api | 17:11 |
mriedem | where the rest api methods have those expected exception decorators | 17:11 |
rlrossit | wait aren't those 2 different things? | 17:11 |
*** paul-carlton2 has joined #openstack-nova | 17:12 | |
*** thumpba has quit IRC | 17:12 | |
*** atuvenie has quit IRC | 17:12 | |
*** thumpba has joined #openstack-nova | 17:13 | |
*** sc68cal_ has quit IRC | 17:14 | |
*** tbachman has quit IRC | 17:15 | |
*** rk4n has quit IRC | 17:15 | |
oomichi_ | mriedem: rlrossit: I cannot get the point yet, that means 403 is good exception for all os-volumes cases? | 17:16 |
mriedem | oomichi: well, it's possible for several of them, | 17:16 |
mriedem | and we're trying to avoid returning a 500 because we didn't handle the 403 in the RES TAPI | 17:17 |
mriedem | *REST API | 17:17 |
oomichi_ | mriedem: yeah, 500 is wrong. but the status code should depends on case by case | 17:17 |
mriedem | alaski: https://review.openstack.org/#/c/286828/ is rebased now, | 17:17 |
mriedem | alaski: i also replied to your comment in ps3, i didn't get quite get the question | 17:18 |
rlrossit | oomichi_: Isn't exceptions.Forbidden always going to be a 403? | 17:20 |
*** Sukhdev has joined #openstack-nova | 17:21 | |
mriedem | for example, https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1056 | 17:22 |
mriedem | i could be booting from volume with a volume snapshot | 17:22 |
mriedem | oh nvm, that would be a 404 i'm thinking of | 17:22 |
oomichi_ | rlrossit: yeah, I think so | 17:22 |
oomichi_ | rlrossit: it is nice to transpate Forbidden to 403 | 17:22 |
rlrossit | I mean I guess we could make a new decorator to stack on top of all of the other ones on the api functions that transforms exceptions.Forbidden into exc.HTTPForbidden... | 17:23 |
mriedem | here is the example i was looking for | 17:23 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2355 | 17:23 |
*** haomaiwang has joined #openstack-nova | 17:23 | |
oomichi_ | mriedem: rlrossit: sorry, I need to go out now for renting a house. I will see it 4 hours later | 17:24 |
mriedem | if we're doing a snapshot of a volume-backed instance, we could get a 403 from cinder for creating the snapshot (or an overlimit 409) | 17:24 |
rlrossit | so that's something outside of the volumes API that could still 500 because of a forbidden from cinder? | 17:24 |
mriedem | well, it's not handled here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1103 | 17:25 |
*** ducttape_ has joined #openstack-nova | 17:25 | |
rlrossit | holy decorators batman | 17:25 |
*** READ10 has joined #openstack-nova | 17:25 | |
*** sudipto has quit IRC | 17:25 | |
mriedem | so if we are trying to snapshot a volume-backed instance, and get a 403 from cinder, we don't handle that in the REST API and return a 500 | 17:25 |
rlrossit | that one's expecting 403 though | 17:25 |
mriedem | i need to dig into what that decorator is checking | 17:26 |
*** matrohon has quit IRC | 17:26 | |
mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/extensions.py#L467 | 17:26 |
mriedem | i think that's a 500 | 17:27 |
mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/extensions.py#L504 | 17:27 |
rlrossit | I'm guessing wsgi.action('createImage') can raise a 403? | 17:27 |
mriedem | sure | 17:27 |
mriedem | but for https://github.com/openstack/nova/blob/master/nova/api/openstack/extensions.py#L487 | 17:27 |
mriedem | i'd think | 17:27 |
mriedem | nova policy might say you can't | 17:27 |
mriedem | but if nova policy says you can, and cinder policy says you can't, | 17:27 |
rlrossit | oh I get it | 17:27 |
mriedem | then kablammo | 17:27 |
rlrossit | yup | 17:27 |
mriedem | so, | 17:28 |
mriedem | what you could *maybe* do in https://github.com/openstack/nova/blob/master/nova/api/openstack/extensions.py#L467 | 17:28 |
mriedem | is add a check for NovaException because NovaException is supposed to have a 'code' kwarg | 17:28 |
*** haomaiwang has quit IRC | 17:28 | |
mriedem | and you could translate the generic ones to webob exceptions | 17:28 |
rlrossit | we want to generalize it more outside of forbidden? | 17:28 |
*** oomichi_ has quit IRC | 17:29 | |
mriedem | 403 would be a POC | 17:29 |
rlrossit | ok | 17:29 |
mriedem | if isinstance(NovaException) and ex.code in errors, | 17:29 |
rlrossit | but would I check for types, or code? | 17:29 |
mriedem | i think code | 17:29 |
mriedem | not sure | 17:29 |
rlrossit | isn't that what L481-486 is already doing? | 17:30 |
mriedem | i don't know that it would matter since the nova exceptions are supposed to follow a hierarchy | 17:30 |
mriedem | not for nova exceptions | 17:30 |
mriedem | if isinstance(exc, webob.exc.WSGIHTTPException): | 17:30 |
rlrossit | oh nvm | 17:30 |
mriedem | but yeah, i think you'd follow that pattern | 17:30 |
rlrossit | we aren't in that category | 17:30 |
alaski | mriedem: I guess I'm not clear on how target_connect_addr would not be available. it seems that migration relies on there being a destination address in there | 17:30 |
mriedem | alaski: well, there is a dest parameter passed in | 17:30 |
mriedem | this overwrites it | 17:30 |
mriedem | and i don't know why | 17:30 |
mriedem | alaski: b/c that seems sneaky to me | 17:31 |
mriedem | alaski: the more i looked at that, the more i thought, if what's passed in is not None and is overwritten, we should probably log something there | 17:31 |
alaski | yeah. that alleviates my concern about not having dest, but does seem like something that should be called out | 17:32 |
mriedem | alaski: i can put up a patch to warn on that | 17:32 |
mriedem | if it's missing or different | 17:32 |
alaski | cool | 17:32 |
mriedem | alaski: but the field is nullable https://github.com/openstack/nova/blob/master/nova/objects/migrate_data.py#L126 | 17:33 |
mriedem | so that's why i wasn't trying to deal with it like it wasn't | 17:33 |
alaski | makes sense | 17:34 |
mriedem | rlrossit: i'm thinking you should write a test patch that raises nova.exception.Forbidden in a rest api that expects 403 but doesn't get a webob exception, like create_image for volume-backed snapshot | 17:34 |
*** apoorvad has joined #openstack-nova | 17:34 | |
mriedem | rlrossit: and then you could test out converting that nova exception to a webob exception in the decorator | 17:34 |
mriedem | rlrossit: and then have ken'ichi take a look | 17:34 |
*** tbachman has joined #openstack-nova | 17:35 | |
*** vilobhmm11 has joined #openstack-nova | 17:37 | |
*** liverpooler has quit IRC | 17:37 | |
*** n0ano has quit IRC | 17:38 | |
*** vilobhmm111 has joined #openstack-nova | 17:39 | |
*** mgarza has joined #openstack-nova | 17:40 | |
alaski | I'm not really up to speed on what y'all are discussing so feel free to ignore me, but exception.Forbidden is converted deep down in the wsgi layer with http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/wsgi.py#n421 | 17:40 |
*** vilobhmm11 has quit IRC | 17:41 | |
*** browne has quit IRC | 17:41 | |
mriedem | alaski: ooo | 17:42 |
mriedem | this is why i said we should just write a test | 17:42 |
mriedem | because i know there are layers to this | 17:42 |
*** gjayavel_ has quit IRC | 17:42 | |
*** ivase_ has joined #openstack-nova | 17:44 | |
*** nic has joined #openstack-nova | 17:46 | |
*** ivase has quit IRC | 17:46 | |
*** fawadkhaliq has joined #openstack-nova | 17:47 | |
*** edtubill has quit IRC | 17:47 | |
*** nikhil has quit IRC | 17:51 | |
*** jdurgin1 has quit IRC | 17:51 | |
*** Sukhdev has quit IRC | 17:52 | |
*** e0ne has joined #openstack-nova | 17:53 | |
*** dims has quit IRC | 17:54 | |
mriedem | alaski: unrelated, but since this is in the compute manager network alloc/reschedule flow, you might want to take a look https://review.openstack.org/#/c/283198/ | 17:56 |
alaski | looking | 17:58 |
*** baoli has quit IRC | 18:00 | |
*** baoli has joined #openstack-nova | 18:01 | |
* mriedem reboots | 18:01 | |
*** mriedem has quit IRC | 18:01 | |
openstackgerrit | Doug Hellmann proposed openstack/python-novaclient: Update reno for stable/mitaka https://review.openstack.org/291341 | 18:02 |
johnthetubaguy | dansmith: mriedem: does that wait for neutron events stuff still help at all if you don't pause the VM first? | 18:03 |
*** dims has joined #openstack-nova | 18:03 | |
*** vladikr has quit IRC | 18:05 | |
dansmith | johnthetubaguy: no | 18:06 |
dansmith | johnthetubaguy: but the libvirt driver starts paused | 18:06 |
johnthetubaguy | dansmith: I was just looking at this: https://review.openstack.org/#/c/85398/2 | 18:06 |
dansmith | johnthetubaguy: if other hypervisors could do the long neutron bit first and then start the guest, that would help them I guess | 18:06 |
johnthetubaguy | oops | 18:06 |
*** efoley__ has joined #openstack-nova | 18:06 | |
johnthetubaguy | https://review.openstack.org/#/c/268258/3 | 18:06 |
*** Swami has joined #openstack-nova | 18:07 | |
dansmith | johnthetubaguy: I'll comment | 18:07 |
johnthetubaguy | dansmith: thanks | 18:07 |
openstackgerrit | Augustina Ragwitz proposed openstack/nova: Double check aggregate metadata keys due to case insensitivity https://review.openstack.org/283868 | 18:08 |
*** moshele has joined #openstack-nova | 18:09 | |
*** Marga_ has quit IRC | 18:11 | |
*** Marga_ has joined #openstack-nova | 18:12 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports https://review.openstack.org/242573 | 18:12 |
*** mriedem has joined #openstack-nova | 18:13 | |
*** nic has quit IRC | 18:13 | |
*** nic has joined #openstack-nova | 18:14 | |
*** diana_clarke has quit IRC | 18:15 | |
*** lpetrut has quit IRC | 18:16 | |
auggy | sdague: so i may have actually fixed this, but the fix may need to go in higher up in the stack, i'm not sure https://review.openstack.org/283868 | 18:16 |
auggy | sdague: basically the novaclient gets the success status and then assumes that whatever the user submitted is what was actually written to the db | 18:17 |
auggy | sdague: but i'm lowercasing the aggregate metadata key before they submit it, so that's not actually true | 18:17 |
auggy | sdague: so anyways, i'm still poking around at this to see where the novaclient is getting that from and to make sure it's also not the case in the api | 18:18 |
openstackgerrit | Chris Dent proposed openstack/nova-specs: Declarative API Tests With Gabbi https://review.openstack.org/291352 | 18:18 |
*** moshele has quit IRC | 18:19 | |
sdague | ok, cool do we still have the db case on this? I feel like it's worth probably hitting this with some known data and make sure it acts the right way | 18:19 |
cdent | sdague ^^ I've come to kill your api samples tests | 18:19 |
cdent | because I'm all out of bubblegum | 18:20 |
auggy | sdague: yeah the functional test is still on it and it should run sometime in the next hour i hope, i am suspecting it will pass | 18:20 |
alaski | johnthetubaguy: dansmith thanks for pointing out https://review.openstack.org/#/c/268258, the context manager did not work as I expected | 18:21 |
*** dims has quit IRC | 18:21 | |
dansmith | alaski: np, it's not very obvious | 18:21 |
*** dims has joined #openstack-nova | 18:22 | |
auggy | cdent: those api samples tests are kerazy, hopefully the work you're doing will improve things :) | 18:22 |
dansmith | alaski: also, I pretty much cherish every rare instance where I know something you don't | 18:22 |
*** ihrachys has quit IRC | 18:23 | |
sdague | cdent: ok, though I'm not really sure that we can evaluate this just at a spec level. The API samples tests are basically a huge part of our API testing. So we've got to at least see what gabbi looks like for a couple of the more complicated instances there. | 18:23 |
cdent | sdague: yeah, there's going to poc concept code coming along side this | 18:23 |
cdent | s/to/to be/ | 18:23 |
cdent | already in the works | 18:24 |
*** vladikr has joined #openstack-nova | 18:24 | |
*** ctrath has quit IRC | 18:24 | |
alaski | dansmith: hah, it's not rare at all. I just keep quiet in that case, which explains why I'm always quiet | 18:24 |
dansmith | heh | 18:25 |
*** neophy has joined #openstack-nova | 18:25 | |
*** omnipresent has quit IRC | 18:25 | |
*** pece has joined #openstack-nova | 18:25 | |
*** zenoway has joined #openstack-nova | 18:26 | |
*** bharath has joined #openstack-nova | 18:26 | |
*** ducttape_ has quit IRC | 18:26 | |
*** diana_clarke has joined #openstack-nova | 18:26 | |
*** ducttape_ has joined #openstack-nova | 18:26 | |
*** bharathk has quit IRC | 18:26 | |
*** ctrath has joined #openstack-nova | 18:27 | |
*** jaosorior has joined #openstack-nova | 18:28 | |
*** browne has joined #openstack-nova | 18:29 | |
*** openstackgerrit_ has joined #openstack-nova | 18:30 | |
*** zenoway has quit IRC | 18:30 | |
*** kfarr has joined #openstack-nova | 18:34 | |
*** efoley__ has quit IRC | 18:36 | |
*** PaulMurray has quit IRC | 18:38 | |
*** angdraug has quit IRC | 18:43 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: check for optional LibvirtLiveMigrateData attrs before loading https://review.openstack.org/286828 | 18:45 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods https://review.openstack.org/290134 | 18:45 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Change SpawnIsSynchronous fixture return https://review.openstack.org/290780 | 18:45 |
dansmith | sdague: so I took a chance on this: https://review.openstack.org/#/c/290077/ | 18:45 |
dansmith | but it doesn't work | 18:45 |
dansmith | is there some within-master thing I can use or something? | 18:45 |
*** jichen has joined #openstack-nova | 18:46 | |
alaski | mriedem: you undid my updates with that rebase | 18:46 |
mriedem | wah?! | 18:47 |
dansmith | sdague: I know I'm kinda cheating, but I can't run those migration commands until after db schema has run, and from-liberty is too early | 18:47 |
mriedem | gdi | 18:47 |
dansmith | man, haven't had a good "gdi" in here in months | 18:47 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Change SpawnIsSynchronous fixture return https://review.openstack.org/290780 | 18:47 |
*** eharney has quit IRC | 18:48 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Change SpawnIsSynchronous fixture return https://review.openstack.org/290780 | 18:49 |
alaski | mriedem: rebased, but push over that if you need to | 18:49 |
mriedem | oy | 18:50 |
mriedem | here goes | 18:52 |
mriedem | of course i can't push it up | 18:52 |
cburgess | gdi? | 18:52 |
mriedem | no | 18:52 |
mriedem | sigh | 18:53 |
cburgess | No I mean what does that even mean? | 18:53 |
mriedem | god damn it | 18:53 |
cburgess | I feel stupid for not realizing that. | 18:53 |
cburgess | I'm going to crawl back under my rock now. | 18:53 |
*** paul-carlton2 has quit IRC | 18:53 | |
mriedem | adorable | 18:53 |
*** READ10 has quit IRC | 18:54 | |
edleafe | lol | 18:55 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: check for optional LibvirtLiveMigrateData attrs before loading https://review.openstack.org/286828 | 18:55 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods https://review.openstack.org/290134 | 18:55 |
*** ducttape_ has quit IRC | 18:56 | |
mriedem | HUZZAH! | 18:56 |
*** aginwala has joined #openstack-nova | 18:56 | |
* tbachman wonders if that’s the request to be hasselhoffed | 18:59 | |
*** vilobhmm111 has quit IRC | 19:00 | |
*** eharney has joined #openstack-nova | 19:03 | |
*** danpb has quit IRC | 19:04 | |
mriedem | alaski: so i guess that target_connect_addr would be set in pre live migration here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6708 | 19:04 |
mriedem | but, it defaults to None | 19:04 |
mriedem | and if not specified, defaults to the dest compute hostname | 19:04 |
mriedem | it actually seems like we shouldn't even have the target_connect_addr in the object | 19:05 |
mriedem | it's a config option, and it's only used to override the dest compute hostname | 19:05 |
mriedem | all of these https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6703-L6709 | 19:06 |
mriedem | dansmith: ^ does that seem weird to you? | 19:07 |
alaski | it must be there in case you have a seperate network interface that should be used | 19:07 |
mriedem | we're passing config options over the wire for live migration | 19:07 |
mriedem | alaski: sure, the config option itself is fine, | 19:07 |
mriedem | it just seems odd that we're storing this as migration data and passing it around | 19:07 |
dansmith | mriedem: you need to pass the addr the host is configured to use to the other side right? | 19:08 |
mriedem | yeah i suppose | 19:08 |
openstackgerrit | Ed Leafe proposed openstack/python-novaclient: Fixes TypeError on Client instantiation https://review.openstack.org/240277 | 19:08 |
openstackgerrit | Ed Leafe proposed openstack/python-novaclient: Change all test URLs to use example.com https://review.openstack.org/291370 | 19:08 |
alaski | mriedem: it would be better to not overwrite dest in that other method later, and just set migrate_data.target_connect_addr properly once and always use it | 19:10 |
*** paul_ has joined #openstack-nova | 19:11 | |
mriedem | alaski: we dont have dest in pre_live_migration where it's set though | 19:11 |
*** lpetrut has joined #openstack-nova | 19:13 | |
mriedem | hmm, when it's called we actually do have dest | 19:13 |
alaski | I thought it would just be the hostname, but I should just shut my mouth about the virt driver. Nothing is ever as it seems there | 19:13 |
*** dimtruck is now known as zz_dimtruck | 19:14 | |
*** andrewbogott has quit IRC | 19:14 | |
*** andrewbogott has joined #openstack-nova | 19:14 | |
mriedem | alaski: as in CONF.host? | 19:14 |
mriedem | i think that's right | 19:14 |
mriedem | pre_live_migration in the compute rpcapi just uses dest to prepare the call | 19:15 |
mriedem | it doesn't pass it over, because it'll be on that host, | 19:15 |
mriedem | so CONF.host | 19:15 |
mriedem | if that host has target_connect_addr set, it uses it, else it's None (and dest will be used during live migration later) | 19:15 |
*** jistr has joined #openstack-nova | 19:15 | |
*** zenoway has joined #openstack-nova | 19:16 | |
mriedem | anyway, i'm not sure i want to get within 10 miles of touching any of this code... | 19:16 |
*** ducttape_ has joined #openstack-nova | 19:17 | |
dansmith | mriedem: I can recommend not getting near it :) | 19:17 |
*** edtubill has joined #openstack-nova | 19:18 | |
alaski | after tracing this I have no clue. dest originates in the API from user input so it may or may not match CONF.host. | 19:19 |
*** kfarr has quit IRC | 19:20 | |
dansmith | dest has to be a hypervisor hostname I think | 19:20 |
dansmith | so we know which one we're talking to | 19:20 |
dansmith | i.e. the same as the topic | 19:20 |
*** moshele has joined #openstack-nova | 19:20 | |
dansmith | which may not be (at all) how the two communicate | 19:20 |
mriedem | i thought dest came from the live_migrate task in conductor | 19:24 |
mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L164 | 19:24 |
*** vilobhmm11 has joined #openstack-nova | 19:25 | |
mriedem | you can request a dest, which is then validated here https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L102 | 19:25 |
*** vilobhmm11 has quit IRC | 19:25 | |
*** zul has quit IRC | 19:25 | |
*** vilobhmm11 has joined #openstack-nova | 19:25 | |
*** zul has joined #openstack-nova | 19:26 | |
alaski | destination is passed in at https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L307 | 19:26 |
alaski | pulled from a scheduler hint set in compute/api | 19:26 |
*** dims_ has joined #openstack-nova | 19:28 | |
*** moshele has quit IRC | 19:28 | |
*** mvk has quit IRC | 19:28 | |
mriedem | but couldn't that be None? | 19:28 |
alaski | maybe it is possible to just say live-migrate to wherever, though that seems a bit crazy | 19:28 |
mriedem | why is that crazier than cold migrate to wherever? | 19:29 |
*** dims has quit IRC | 19:29 | |
*** Sukhdev has joined #openstack-nova | 19:29 | |
alaski | live migrate is usally done by admins trying to clear hosts for upgrade, in which case they want to carefully control where things go. I guess in the 'host is about to die' case an unspecified live-migrate could be useful | 19:30 |
alaski | the resource cost of it just seems like something that should be controlled | 19:31 |
*** bharath has quit IRC | 19:31 | |
*** gszasz has quit IRC | 19:31 | |
*** jaosorior has quit IRC | 19:31 | |
alaski | either way, it seems the api allows destination to be None | 19:32 |
openstackgerrit | Mark Doffman proposed openstack/nova-specs: Move networking tables to the API db. https://review.openstack.org/291382 | 19:32 |
mriedem | alaski: yeah, this is why i was asking the other day if it was possible to migrate from a compute service that is disabled | 19:32 |
mriedem | i.e. i want to upgrade compute A, so disable the service for compute A so nothing schedules to it | 19:32 |
*** andreykurilin__ has quit IRC | 19:33 | |
mriedem | the docs don't really talk about doing anything like that for maintenance | 19:33 |
alaski | I believe that works | 19:34 |
*** rlrossit has quit IRC | 19:34 | |
*** rlrossi__ has joined #openstack-nova | 19:37 | |
*** rlrossi__ has quit IRC | 19:37 | |
*** rlrossi__ has joined #openstack-nova | 19:38 | |
*** rlrossi__ has quit IRC | 19:38 | |
*** rcernin has quit IRC | 19:40 | |
*** cdent has quit IRC | 19:42 | |
*** e0ne has quit IRC | 19:43 | |
*** Sukhdev has quit IRC | 19:43 | |
*** armax has quit IRC | 19:46 | |
*** nelsnelson has quit IRC | 19:47 | |
*** baoli has quit IRC | 19:50 | |
doffm | alaski: Have you thought much about the quota system for cells? AFAICT they quota tables will have to go in the API db to work, but that will lead to a hammering of the api db. (Touched for any request across the deployment that affects quota) | 19:50 |
doffm | My current idea is to put quota tables in API db so that it 'works' (but might not scale very well) | 19:50 |
doffm | Then worry about alternative quota drivers later. | 19:51 |
alaski | doffm: just a little. I agree it needs to be in the api db | 19:51 |
alaski | the big question is whether there is anything that can happen to affect quotas which doesn't pass through the API | 19:51 |
alaski | because if not the cells never need to touch the api db for that | 19:52 |
doffm | I'm not sure about that. But right now quota is updated from the compute nodes right? | 19:52 |
doffm | We would have to change the way quota is recorded. | 19:52 |
alaski | quotas are a mess so I won't claim any real knowledge, but my understanding is that it's all/mostly handled in the api via reservations | 19:53 |
alaski | the computes just confirm/deny the reservation | 19:53 |
doffm | alaski: Ok. You're right its not easy to comprehend whats going on with quotas. | 19:53 |
alaski | in cellsv1 quotas are handled only in the top level cell, equivalent to api for this discussion, and take an optimistic view of just commiting things before sending to the cells | 19:54 |
openstackgerrit | Sylvain Bauza proposed openstack/python-novaclient: Update reno for stable/mitaka https://review.openstack.org/291341 | 19:55 |
bauzas | dhellmann: FYI, just pushed an edit on https://review.openstack.org/#/c/291341/ | 19:55 |
doffm | alaski: Well the fact that they were doing that in cellsv1 and didn't see any issues with it is encouraging. | 19:55 |
alaski | doffm: well, no more issues than anyone else I think :) | 19:55 |
dhellmann | bauzas : thanks! | 19:56 |
doffm | alaski: Heh, yeah. I'm not talking about all the *other* quota issue. | 19:56 |
bauzas | dhellmann: hopefully it should fix the job | 19:56 |
dhellmann | bauzas : +1 LGTM | 19:56 |
doffm | alaski: Thanks, I guess i'll propose moving all the quota tables to API. I'll mention possible scaling issues, but not worry about it for now. | 19:57 |
*** ildikov has quit IRC | 19:58 | |
bauzas | dhellmann: https://github.com/openstack/releases/blob/master/deliverables/mitaka/python-novaclient.yaml is not mentioning a stable branch, have you already cut the branch ? | 19:58 |
bauzas | nvm https://github.com/openstack/python-novaclient/tree/stable/mitaka | 20:00 |
*** ildikov has joined #openstack-nova | 20:00 | |
*** aginwala has quit IRC | 20:03 | |
*** lefaiseur has quit IRC | 20:04 | |
*** rlrossit has joined #openstack-nova | 20:07 | |
*** paul_ has quit IRC | 20:07 | |
*** aginwala has joined #openstack-nova | 20:08 | |
*** eglynn has quit IRC | 20:08 | |
*** irenab_ has joined #openstack-nova | 20:08 | |
*** irenab has quit IRC | 20:10 | |
*** irenab_ is now known as irenab | 20:10 | |
*** e0ne has joined #openstack-nova | 20:12 | |
*** diogogmt has joined #openstack-nova | 20:13 | |
*** Swami has quit IRC | 20:15 | |
*** ducttape_ has quit IRC | 20:18 | |
*** matrohon has joined #openstack-nova | 20:19 | |
*** armax has joined #openstack-nova | 20:20 | |
*** ducttape_ has joined #openstack-nova | 20:20 | |
*** irenab_ has joined #openstack-nova | 20:21 | |
*** vilobhmm11 has quit IRC | 20:22 | |
*** irenab has quit IRC | 20:23 | |
*** vilobhmm11 has joined #openstack-nova | 20:23 | |
*** zz_dimtruck is now known as dimtruck | 20:23 | |
*** e0ne has quit IRC | 20:23 | |
*** ociuhandu has quit IRC | 20:24 | |
*** irenab_ has quit IRC | 20:26 | |
*** cirros has joined #openstack-nova | 20:27 | |
*** pushkaru has quit IRC | 20:27 | |
*** irenab has joined #openstack-nova | 20:27 | |
*** cirros has quit IRC | 20:28 | |
*** vilobhmm11 has quit IRC | 20:29 | |
*** vilobhmm11 has joined #openstack-nova | 20:29 | |
*** Sukhdev has joined #openstack-nova | 20:30 | |
*** vilobhmm11 has quit IRC | 20:33 | |
*** erlon has quit IRC | 20:36 | |
*** pushkaru has joined #openstack-nova | 20:37 | |
*** sheel has quit IRC | 20:37 | |
*** angdraug has joined #openstack-nova | 20:38 | |
*** thumpba has quit IRC | 20:50 | |
*** thumpba has joined #openstack-nova | 20:51 | |
*** yamahata has quit IRC | 20:52 | |
*** thumpba has quit IRC | 20:55 | |
*** matrohon has quit IRC | 20:55 | |
*** smatzek has quit IRC | 20:56 | |
*** haomaiwang has joined #openstack-nova | 20:56 | |
*** rfolco has quit IRC | 21:00 | |
*** haomaiwang has quit IRC | 21:01 | |
mriedem | dhellmann: question in https://review.openstack.org/#/c/291341/ | 21:02 |
tonyb | mriedem: re 12.0.3, sounds good. | 21:05 |
*** toanster has quit IRC | 21:10 | |
dhellmann | bauzas : yes, the branches aren't listed in the deliverables files | 21:11 |
*** toan has joined #openstack-nova | 21:11 | |
dhellmann | mriedem: answered | 21:12 |
*** krtaylor has quit IRC | 21:13 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Update reno for stable/mitaka https://review.openstack.org/291341 | 21:13 |
mriedem | dhellmann: done, thanks | 21:13 |
mriedem | dhellmann: also, is it safe to merge that now or do we need to wait for stable/mitaka to be created? | 21:14 |
dhellmann | mriedem : when I looked at the update, I noticed that it was in the toctree but didn't pay attention to ordering | 21:14 |
dhellmann | mriedem : the stable branch for the client should already exist, that's where the patch came from (all one script) | 21:14 |
mriedem | oh it's the client | 21:14 |
mriedem | didn't notice | 21:14 |
dhellmann | mriedem : ETOOMANYPATCHES | 21:15 |
*** ctrath has quit IRC | 21:16 | |
openstackgerrit | Gage Hugo proposed openstack/nova: Added extra_resources field to ComputeNode https://review.openstack.org/291436 | 21:18 |
*** aginwala has quit IRC | 21:18 | |
*** ctrath has joined #openstack-nova | 21:18 | |
*** vilobhmm11 has joined #openstack-nova | 21:19 | |
*** vilobhmm11 has quit IRC | 21:19 | |
*** vilobhmm11 has joined #openstack-nova | 21:19 | |
*** Marga_ has quit IRC | 21:20 | |
*** penick has joined #openstack-nova | 21:21 | |
*** Sukhdev has quit IRC | 21:25 | |
*** burt has quit IRC | 21:27 | |
*** cristicalin has joined #openstack-nova | 21:28 | |
*** cristicalin has quit IRC | 21:28 | |
*** jichen has quit IRC | 21:29 | |
*** boris-42 has joined #openstack-nova | 21:30 | |
*** liverpooler has joined #openstack-nova | 21:32 | |
*** aginwala has joined #openstack-nova | 21:34 | |
*** haplo37 has joined #openstack-nova | 21:34 | |
*** aginwala has quit IRC | 21:34 | |
*** gjayavelu has joined #openstack-nova | 21:34 | |
*** Sukhdev has joined #openstack-nova | 21:40 | |
*** Sukhdev has quit IRC | 21:40 | |
*** jistr has quit IRC | 21:40 | |
*** hamzy has quit IRC | 21:40 | |
*** Sukhdev has joined #openstack-nova | 21:41 | |
*** openstackstatus has quit IRC | 21:42 | |
*** openstackstatus has joined #openstack-nova | 21:44 | |
*** ChanServ sets mode: +v openstackstatus | 21:44 | |
*** rk4n has joined #openstack-nova | 21:48 | |
*** ihrachys has joined #openstack-nova | 21:49 | |
*** edtubill has quit IRC | 21:49 | |
*** sdague has quit IRC | 21:52 | |
*** dims has joined #openstack-nova | 21:52 | |
*** jamielennox|away is now known as jamielennox | 21:52 | |
*** dims_ has quit IRC | 21:52 | |
*** pece has quit IRC | 21:53 | |
*** Marga_ has joined #openstack-nova | 21:54 | |
*** neophy has quit IRC | 21:54 | |
*** ociuhandu has joined #openstack-nova | 21:55 | |
*** mdrabe has quit IRC | 21:56 | |
*** thorst_ has quit IRC | 21:56 | |
*** ociuhandu has quit IRC | 21:56 | |
*** ociuhandu has joined #openstack-nova | 21:57 | |
rlrossit | mriedem: https://bugs.launchpad.net/nova/+bug/1555826 ur fave | 21:58 |
openstack | Launchpad bug 1555826 in OpenStack Compute (nova) "Functional API client has incorrect URL for volumes" [Undecided,New] | 21:58 |
*** doug-fish has quit IRC | 21:59 | |
*** melwitt has quit IRC | 22:00 | |
*** delattec has quit IRC | 22:02 | |
*** thorst_ has joined #openstack-nova | 22:02 | |
*** thorst__ has joined #openstack-nova | 22:04 | |
*** cleong has quit IRC | 22:06 | |
*** thorst_ has quit IRC | 22:06 | |
*** thorst__ has quit IRC | 22:08 | |
*** mrkz has quit IRC | 22:10 | |
*** mrkz has joined #openstack-nova | 22:10 | |
mriedem | dansmith: we should get a FutureWarning for this right? https://review.openstack.org/#/c/259813/7/nova/tests/unit/network/security_group/test_neutron_driver.py | 22:10 |
mriedem | b/c i don't see one http://logs.openstack.org/13/259813/7/check/gate-nova-python27/57b09b3/console.html#_2016-03-06_15_27_26_095 | 22:11 |
*** rcernin has joined #openstack-nova | 22:11 | |
dansmith | yeah, if we're using the new enough o.vo | 22:11 |
dansmith | I have no idea if we are, but regardless, you're right on the comment of course | 22:12 |
*** pushkaru has quit IRC | 22:12 | |
mriedem | we must be http://logs.openstack.org/13/259813/7/check/gate-nova-python27/57b09b3/console.html#_2016-03-06_15_27_26_179 | 22:12 |
mriedem | it warned on another one | 22:12 |
rlrossit | dansmith: mriedem: doesn't matter if we are, we will eventually | 22:12 |
dansmith | yeah | 22:12 |
rlrossit | drop the hammer | 22:12 |
mriedem | i dropped the hammer, | 22:13 |
mriedem | but it didn't warn, so i'm confused | 22:13 |
*** knikolla has quit IRC | 22:13 | |
*** aysyd has quit IRC | 22:13 | |
*** porunov has quit IRC | 22:14 | |
*** manjeets has joined #openstack-nova | 22:14 | |
manjeets | today i clonned nova repo and built a one node devstack | 22:15 |
manjeets | but when i spin instance scheduler keep on trying | 22:16 |
*** melwitt has joined #openstack-nova | 22:16 | |
*** melwitt has quit IRC | 22:16 | |
*** pushkaru has joined #openstack-nova | 22:17 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add regression test for Cinder 403 forwarding https://review.openstack.org/291464 | 22:17 |
rlrossit | mriedem: functional will blow up on that ^ | 22:17 |
rlrossit | mriedem: I realize I can do this too... http://paste.openstack.org/show/490075/ is what it's barfing out | 22:22 |
*** thorst_ has joined #openstack-nova | 22:22 | |
*** rcernin has quit IRC | 22:22 | |
*** rk4n has quit IRC | 22:24 | |
*** pushkaru has quit IRC | 22:24 | |
*** pushkaru has joined #openstack-nova | 22:24 | |
mriedem | rlrossit: alaski: aha | 22:25 |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/extensions.py#n501 | 22:25 |
mriedem | that's in the decorator in the v2.1 api | 22:25 |
mriedem | which translates to a 500 | 22:25 |
*** thorst__ has joined #openstack-nova | 22:26 | |
mriedem | so the thing wayyyyy down in the wsgi layer that alaski pointed out is busted | 22:26 |
mriedem | b/c it's not getting a NovaException, it's getting a webob 500 | 22:26 |
mriedem | well, it's not busted, but it's being short-circuited | 22:26 |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/wsgi.py#n421 | 22:28 |
mriedem | so you're hitting this http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/wsgi.py#n438 | 22:28 |
alaski | PolicyNotAuthorized is a subclass of Forbidden, so isinstance() isn't the right check there | 22:29 |
*** thorst_ has quit IRC | 22:29 | |
mriedem | b/c expected_errors barfed on nova.exception.Forbidden | 22:29 |
*** pushkaru has quit IRC | 22:29 | |
*** woodster_ has joined #openstack-nova | 22:29 | |
mriedem | alaski: yeah good point | 22:29 |
alaski | issubclass would be better there | 22:30 |
mriedem | change http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/extensions.py#n487 to Forbidden and the functional test should work | 22:30 |
alaski | I think you still want to allow PolicyNotAuthorized there | 22:30 |
mriedem | isn't PolicyNotAuthorized an instance of Forbidden? | 22:31 |
mriedem | like objects.Instance is an instance of nova.objects.base.NovaObject | 22:31 |
mriedem | if it's not, that's terrible | 22:31 |
mriedem | and we have to rewrite nova in java immediately | 22:31 |
alaski | no you're right | 22:31 |
rlrossit | mriedem: it is | 22:31 |
mriedem | whew | 22:31 |
alaski | I had the hierarchy backwards in my head | 22:32 |
*** diogogmt has quit IRC | 22:32 | |
* mriedem leaves | 22:34 | |
*** mriedem has quit IRC | 22:34 | |
*** ctrath has quit IRC | 22:35 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: use datacenter path to fetch image https://review.openstack.org/289613 | 22:37 |
manjeets | today when i stacked on devstack on able to schedule instances | 22:38 |
manjeets | http://paste.openstack.org/show/490076/ I am getting in n-cond logs | 22:39 |
*** melwitt has joined #openstack-nova | 22:39 | |
manjeets | but n-api and n-crt, n-cpu, n-sch i don't see any trace | 22:39 |
*** pushkaru has joined #openstack-nova | 22:39 | |
*** gyee has joined #openstack-nova | 22:40 | |
*** melwitt has quit IRC | 22:40 | |
*** zenoway has quit IRC | 22:40 | |
*** melwitt has joined #openstack-nova | 22:41 | |
*** melwitt has quit IRC | 22:41 | |
openstackgerrit | Sujitha proposed openstack/nova: Added new exception to handle CinderClientException https://review.openstack.org/290156 | 22:42 |
*** melwitt has joined #openstack-nova | 22:42 | |
*** cdelatte has joined #openstack-nova | 22:43 | |
*** pushkaru has quit IRC | 22:43 | |
*** pushkaru has joined #openstack-nova | 22:43 | |
*** rtheis has quit IRC | 22:44 | |
*** Bjoern_ has quit IRC | 22:44 | |
*** burgerk has quit IRC | 22:44 | |
*** vilobhmm11 has quit IRC | 22:45 | |
*** vilobhmm11 has joined #openstack-nova | 22:46 | |
*** melwitt has quit IRC | 22:46 | |
*** melwitt has joined #openstack-nova | 22:47 | |
*** aginwala has joined #openstack-nova | 22:47 | |
*** mgarza has quit IRC | 22:54 | |
*** zenoway has joined #openstack-nova | 22:54 | |
*** melwitt has quit IRC | 22:55 | |
*** melwitt has joined #openstack-nova | 22:55 | |
*** melwitt has quit IRC | 22:56 | |
*** melwitt has joined #openstack-nova | 22:56 | |
*** rlrossit has quit IRC | 22:58 | |
*** doug-fish has joined #openstack-nova | 22:59 | |
*** zenoway has quit IRC | 22:59 | |
*** melwitt has quit IRC | 23:00 | |
*** melwitt has joined #openstack-nova | 23:00 | |
*** doug-fish has quit IRC | 23:03 | |
*** doug-fish has joined #openstack-nova | 23:03 | |
*** melwitt has quit IRC | 23:04 | |
*** melwitt has joined #openstack-nova | 23:04 | |
*** diogogmt has joined #openstack-nova | 23:04 | |
*** krtaylor has joined #openstack-nova | 23:05 | |
*** doug-fish has quit IRC | 23:08 | |
*** derekh has joined #openstack-nova | 23:09 | |
*** haplo37 has quit IRC | 23:11 | |
*** krtaylor has quit IRC | 23:11 | |
*** doug-fish has joined #openstack-nova | 23:14 | |
*** ivase_ has quit IRC | 23:15 | |
*** ducttape_ has quit IRC | 23:15 | |
*** ihrachys has quit IRC | 23:16 | |
*** ivase has joined #openstack-nova | 23:18 | |
*** doug-fish has quit IRC | 23:19 | |
*** ivase has quit IRC | 23:23 | |
*** renatoarmani has joined #openstack-nova | 23:23 | |
*** jwcroppe has joined #openstack-nova | 23:24 | |
*** krtaylor has joined #openstack-nova | 23:25 | |
*** xyang1 has quit IRC | 23:26 | |
*** mrkz has quit IRC | 23:26 | |
*** mrkz has joined #openstack-nova | 23:27 | |
*** haomaiwang has joined #openstack-nova | 23:27 | |
*** zenoway has joined #openstack-nova | 23:30 | |
*** vladikr has quit IRC | 23:31 | |
*** haomaiwang has quit IRC | 23:32 | |
*** renatoarmani has quit IRC | 23:34 | |
*** zenoway has quit IRC | 23:35 | |
*** rk4n has joined #openstack-nova | 23:36 | |
openstackgerrit | Allen Gao proposed openstack/python-novaclient: replace six.iteritems() with dict.items() https://review.openstack.org/291194 | 23:37 |
*** derekh has quit IRC | 23:39 | |
*** Sukhdev has quit IRC | 23:44 | |
*** Sukhdev has joined #openstack-nova | 23:45 | |
*** yamahata has joined #openstack-nova | 23:46 | |
*** gongysh has joined #openstack-nova | 23:47 | |
*** penick has quit IRC | 23:51 | |
*** penick has joined #openstack-nova | 23:54 | |
*** mrkz has quit IRC | 23:55 | |
*** Swami has joined #openstack-nova | 23:56 | |
*** penick has quit IRC | 23:57 | |
*** jwcroppe has quit IRC | 23:57 | |
*** Sukhdev_ has joined #openstack-nova | 23:57 | |
*** Sukhdev has quit IRC | 23:57 | |
*** sheel has joined #openstack-nova | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!