*** shaohe_feng has quit IRC | 00:02 | |
*** shaohe_feng has joined #openstack-nova | 00:03 | |
*** darrenc is now known as darren_afk | 00:09 | |
*** shaohe_feng has quit IRC | 00:13 | |
*** tbachman has joined #openstack-nova | 00:13 | |
*** shaohe_feng has joined #openstack-nova | 00:13 | |
*** ircuser-1 has quit IRC | 00:14 | |
*** shaohe_feng has quit IRC | 00:23 | |
*** sacharya has joined #openstack-nova | 00:23 | |
*** shaohe_feng has joined #openstack-nova | 00:23 | |
*** darren_afk is now known as darrenc | 00:23 | |
*** sacharya has quit IRC | 00:29 | |
*** markvoelker has quit IRC | 00:30 | |
*** testUname has joined #openstack-nova | 00:30 | |
*** Guest460 is now known as mfisch | 00:32 | |
*** mfisch is now known as Guest81704 | 00:32 | |
*** shaohe_feng has quit IRC | 00:33 | |
*** shaohe_feng has joined #openstack-nova | 00:33 | |
*** baoli has joined #openstack-nova | 00:38 | |
*** testUname has quit IRC | 00:39 | |
*** jinxing has joined #openstack-nova | 00:39 | |
*** vilobhmm11 has joined #openstack-nova | 00:40 | |
*** jwcroppe has quit IRC | 00:42 | |
*** shaohe_feng has quit IRC | 00:43 | |
*** shaohe_feng has joined #openstack-nova | 00:44 | |
*** itlinux has joined #openstack-nova | 00:48 | |
*** ivase has quit IRC | 00:51 | |
*** ivase has joined #openstack-nova | 00:52 | |
*** shaohe_feng has quit IRC | 00:54 | |
*** shaohe_feng has joined #openstack-nova | 00:54 | |
*** catintheroof has joined #openstack-nova | 00:55 | |
*** cheneydc has joined #openstack-nova | 00:56 | |
*** itlinux has quit IRC | 00:57 | |
*** iceyao has joined #openstack-nova | 01:02 | |
*** iceyao_ has joined #openstack-nova | 01:03 | |
*** shaohe_feng has quit IRC | 01:04 | |
*** iceyao has quit IRC | 01:07 | |
*** shaohe_feng has joined #openstack-nova | 01:07 | |
*** EinstCra_ has joined #openstack-nova | 01:09 | |
*** shaohe_feng has quit IRC | 01:14 | |
*** shaohe_feng has joined #openstack-nova | 01:14 | |
*** ljxiash has joined #openstack-nova | 01:22 | |
*** fishcried has joined #openstack-nova | 01:23 | |
*** shaohe_feng has quit IRC | 01:24 | |
*** shaohe_feng has joined #openstack-nova | 01:25 | |
*** ducttape_ has joined #openstack-nova | 01:28 | |
*** ducttape_ has quit IRC | 01:33 | |
*** jwcroppe has joined #openstack-nova | 01:35 | |
*** shaohe_feng has quit IRC | 01:35 | |
*** shaohe_feng has joined #openstack-nova | 01:35 | |
*** kengo_sakai has joined #openstack-nova | 01:37 | |
*** ivase_ has joined #openstack-nova | 01:39 | |
*** jwcroppe has quit IRC | 01:40 | |
*** ivase has quit IRC | 01:42 | |
*** kengo_sakai has quit IRC | 01:42 | |
*** baoli has quit IRC | 01:43 | |
*** EinstCra_ is now known as EinstCrazy | 01:44 | |
*** shaohe_feng has quit IRC | 01:45 | |
*** shaohe_feng has joined #openstack-nova | 01:46 | |
*** shaohe_feng has quit IRC | 01:55 | |
openstackgerrit | byhan proposed openstack/nova: modify comment https://review.openstack.org/313956 | 01:55 |
---|---|---|
*** shaohe_feng has joined #openstack-nova | 01:56 | |
*** houming has joined #openstack-nova | 01:56 | |
*** Fdaisuke has joined #openstack-nova | 01:58 | |
*** kengo_sakai has joined #openstack-nova | 02:02 | |
*** ljxiash has quit IRC | 02:02 | |
*** ljxiash has joined #openstack-nova | 02:03 | |
*** shaohe_feng has quit IRC | 02:05 | |
*** ljxiash has quit IRC | 02:06 | |
*** ljxiash has joined #openstack-nova | 02:06 | |
*** dedery has quit IRC | 02:06 | |
*** shaohe_feng has joined #openstack-nova | 02:06 | |
*** hoangcx has joined #openstack-nova | 02:07 | |
*** ociuhandu has quit IRC | 02:15 | |
*** shaohe_feng has quit IRC | 02:16 | |
*** shaohe_feng has joined #openstack-nova | 02:16 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_pci_device https://review.openstack.org/307615 | 02:18 |
*** vilobhmm11 has quit IRC | 02:23 | |
*** shaohe_feng has quit IRC | 02:26 | |
*** shaohe_feng has joined #openstack-nova | 02:27 | |
*** sacharya has joined #openstack-nova | 02:27 | |
*** jwcroppe has joined #openstack-nova | 02:29 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_instance_faults https://review.openstack.org/307126 | 02:32 |
*** iceyao has joined #openstack-nova | 02:33 | |
*** itlinux has joined #openstack-nova | 02:33 | |
*** jwcroppe has quit IRC | 02:34 | |
*** iceyao_ has quit IRC | 02:35 | |
*** shaohe_feng has quit IRC | 02:36 | |
*** shaohe_feng has joined #openstack-nova | 02:37 | |
openstackgerrit | Alex Xu proposed openstack/nova: Add api-sample test for showing quota detail https://review.openstack.org/313959 | 02:37 |
openstackgerrit | Alex Xu proposed openstack/nova: Complete method verification of os-quotes https://review.openstack.org/313960 | 02:37 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs: Allow user to define the shutdown method through API when stop instances https://review.openstack.org/293790 | 02:40 |
*** salv-orlando has joined #openstack-nova | 02:42 | |
*** baoli has joined #openstack-nova | 02:44 | |
*** iceyao has quit IRC | 02:44 | |
*** shaohe_feng has quit IRC | 02:46 | |
*** salv-orlando has quit IRC | 02:47 | |
*** shaohe_feng has joined #openstack-nova | 02:47 | |
*** baoli has quit IRC | 02:49 | |
*** ljxiash has quit IRC | 02:50 | |
*** ljxiash has joined #openstack-nova | 02:50 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add check of capabilities for detach interface https://review.openstack.org/308115 | 02:51 |
openstackgerrit | Alex Xu proposed openstack/nova: Complete method verification of os-shevle https://review.openstack.org/313961 | 02:52 |
*** ljxiash has quit IRC | 02:54 | |
*** ljxiash has joined #openstack-nova | 02:54 | |
openstackgerrit | Alex Xu proposed openstack/nova: Complete method verification of os-shevle https://review.openstack.org/313961 | 02:55 |
*** shaohe_feng has quit IRC | 02:57 | |
*** shaohe_feng has joined #openstack-nova | 02:58 | |
*** Guest81704 is now known as mfisch | 03:03 | |
*** mfisch is now known as Guest30018 | 03:04 | |
*** sorrison_laptop has quit IRC | 03:05 | |
*** shaohe_feng has quit IRC | 03:07 | |
*** amotoki has joined #openstack-nova | 03:07 | |
*** shaohe_feng has joined #openstack-nova | 03:08 | |
openstackgerrit | Alex Xu proposed openstack/nova: Compelete method verification of os-servers-admin https://review.openstack.org/313966 | 03:09 |
*** Sukhdev has joined #openstack-nova | 03:09 | |
*** iceyao has joined #openstack-nova | 03:09 | |
*** ljxiash has quit IRC | 03:10 | |
*** ljxiash has joined #openstack-nova | 03:11 | |
*** sheel has joined #openstack-nova | 03:14 | |
*** ljxiash has quit IRC | 03:15 | |
*** shaohe_feng has quit IRC | 03:17 | |
*** amotoki has quit IRC | 03:18 | |
*** shaohe_feng has joined #openstack-nova | 03:18 | |
*** markvoelker has joined #openstack-nova | 03:26 | |
*** shaohe_feng has quit IRC | 03:27 | |
*** shaohe_feng has joined #openstack-nova | 03:28 | |
*** markvoel_ has joined #openstack-nova | 03:29 | |
*** zz_dimtruck is now known as dimtruck | 03:29 | |
*** ljxiash has joined #openstack-nova | 03:29 | |
*** ducttape_ has joined #openstack-nova | 03:29 | |
openstackgerrit | John Hua proposed openstack/nova: XenAPI: Remove ovs_integration_bridge default value https://review.openstack.org/299092 | 03:31 |
*** markvoelker has quit IRC | 03:32 | |
*** RuiChen has joined #openstack-nova | 03:32 | |
*** ducttape_ has quit IRC | 03:34 | |
*** roeyc has joined #openstack-nova | 03:37 | |
*** shaohe_feng has quit IRC | 03:38 | |
*** shaohe_feng has joined #openstack-nova | 03:39 | |
*** amotoki has joined #openstack-nova | 03:40 | |
*** ljxiash has quit IRC | 03:40 | |
*** ljxiash has joined #openstack-nova | 03:41 | |
*** claudiub has joined #openstack-nova | 03:42 | |
*** vilobhmm11 has joined #openstack-nova | 03:43 | |
*** links has joined #openstack-nova | 03:44 | |
*** ljxiash has quit IRC | 03:45 | |
*** salv-orlando has joined #openstack-nova | 03:46 | |
*** salv-orlando has quit IRC | 03:48 | |
*** shaohe_feng has quit IRC | 03:48 | |
*** shaohe_feng has joined #openstack-nova | 03:49 | |
*** roeyc has quit IRC | 03:55 | |
*** Sukhdev has quit IRC | 03:55 | |
*** catintheroof has quit IRC | 03:56 | |
*** fragatina has quit IRC | 03:58 | |
*** shaohe_feng has quit IRC | 03:58 | |
*** salv-orlando has joined #openstack-nova | 03:59 | |
*** shaohe_feng has joined #openstack-nova | 03:59 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove APIRouter of legacy v2 API code https://review.openstack.org/313902 | 04:00 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove legacy v2 tests which use APIRouter https://review.openstack.org/313185 | 04:00 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Switch api unit tests to use v2.1 API https://review.openstack.org/313901 | 04:00 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove legacy v2 API tests which use wsgi_app() https://review.openstack.org/313192 | 04:00 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove fping dependency on legacy v2 API code https://review.openstack.org/312910 | 04:00 |
*** sacharya has quit IRC | 04:02 | |
*** jwcroppe has joined #openstack-nova | 04:03 | |
*** salv-orlando has quit IRC | 04:03 | |
*** itamarl has quit IRC | 04:05 | |
*** shaohe_feng has quit IRC | 04:08 | |
*** dimtruck is now known as zz_dimtruck | 04:09 | |
*** zz_dimtruck is now known as dimtruck | 04:09 | |
*** shaohe_feng has joined #openstack-nova | 04:09 | |
*** jwcroppe has quit IRC | 04:11 | |
*** fragatina has joined #openstack-nova | 04:13 | |
*** fragatina has quit IRC | 04:18 | |
*** dimtruck is now known as zz_dimtruck | 04:19 | |
*** shaohe_feng has quit IRC | 04:19 | |
*** sree has joined #openstack-nova | 04:19 | |
*** shaohe_feng has joined #openstack-nova | 04:19 | |
*** browne has joined #openstack-nova | 04:21 | |
*** fragatina has joined #openstack-nova | 04:29 | |
*** shaohe_feng has quit IRC | 04:29 | |
*** fragatina has quit IRC | 04:29 | |
*** browne has quit IRC | 04:30 | |
*** fragatina has joined #openstack-nova | 04:30 | |
*** shaohe_feng has joined #openstack-nova | 04:30 | |
*** ljxiash has joined #openstack-nova | 04:38 | |
*** shaohe_feng has quit IRC | 04:39 | |
*** shaohe_feng has joined #openstack-nova | 04:39 | |
*** mdrabe has quit IRC | 04:41 | |
*** hoangcx has quit IRC | 04:45 | |
*** hoangcx has joined #openstack-nova | 04:45 | |
*** amotoki_ has joined #openstack-nova | 04:46 | |
*** amotoki has quit IRC | 04:49 | |
*** shaohe_feng has quit IRC | 04:49 | |
*** shaohe_feng has joined #openstack-nova | 04:50 | |
*** irenab has quit IRC | 04:52 | |
*** kengo_sa_ has joined #openstack-nova | 04:59 | |
*** shaohe_feng has quit IRC | 05:00 | |
*** shaohe_feng has joined #openstack-nova | 05:01 | |
*** thorst has quit IRC | 05:01 | |
*** fishcried has joined #openstack-nova | 05:02 | |
*** thorst has joined #openstack-nova | 05:02 | |
*** fishcried has quit IRC | 05:03 | |
*** yonglihe has joined #openstack-nova | 05:04 | |
*** shaohe_feng has quit IRC | 05:10 | |
*** thorst has quit IRC | 05:10 | |
*** shaohe_feng has joined #openstack-nova | 05:10 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove APIRouter of legacy v2 API code https://review.openstack.org/313902 | 05:15 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Switch api unit tests to use v2.1 API https://review.openstack.org/313901 | 05:15 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove legacy v2 API tests which use wsgi_app() https://review.openstack.org/313192 | 05:15 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove fping dependency on legacy v2 API code https://review.openstack.org/312910 | 05:15 |
*** roeyc has joined #openstack-nova | 05:16 | |
*** ljxiash has quit IRC | 05:18 | |
*** sridharg has joined #openstack-nova | 05:18 | |
*** ljxiash has joined #openstack-nova | 05:18 | |
*** prateek has joined #openstack-nova | 05:18 | |
*** sudipto has joined #openstack-nova | 05:18 | |
*** liverpooler has joined #openstack-nova | 05:18 | |
*** ljxiash has quit IRC | 05:19 | |
*** ljxiash has joined #openstack-nova | 05:19 | |
*** markvoel_ has quit IRC | 05:20 | |
*** shaohe_feng has quit IRC | 05:20 | |
*** shaohe_feng has joined #openstack-nova | 05:21 | |
*** salv-orlando has joined #openstack-nova | 05:23 | |
*** apoorv has joined #openstack-nova | 05:27 | |
*** salv-orlando has quit IRC | 05:30 | |
*** ducttape_ has joined #openstack-nova | 05:30 | |
*** shaohe_feng has quit IRC | 05:30 | |
*** itlinux has quit IRC | 05:31 | |
*** ljxiash has quit IRC | 05:34 | |
*** ducttape_ has quit IRC | 05:34 | |
*** irenab has joined #openstack-nova | 05:35 | |
*** amotoki_ has quit IRC | 05:35 | |
*** shaohe_feng has joined #openstack-nova | 05:35 | |
*** salv-orlando has joined #openstack-nova | 05:36 | |
*** salv-orlando has quit IRC | 05:36 | |
*** salv-orlando has joined #openstack-nova | 05:36 | |
*** liverpooler has quit IRC | 05:38 | |
*** klkumar has joined #openstack-nova | 05:38 | |
*** liverpooler has joined #openstack-nova | 05:39 | |
*** ljxiash has joined #openstack-nova | 05:39 | |
*** rcernin has joined #openstack-nova | 05:40 | |
*** shaohe_feng has quit IRC | 05:41 | |
*** shaohe_feng has joined #openstack-nova | 05:41 | |
*** salv-orl_ has joined #openstack-nova | 05:42 | |
*** salv-orlando has quit IRC | 05:45 | |
*** roeyc has quit IRC | 05:45 | |
*** esracelik has joined #openstack-nova | 05:46 | |
*** sl_ has joined #openstack-nova | 05:47 | |
*** dedery has joined #openstack-nova | 05:47 | |
*** sl_ has quit IRC | 05:48 | |
*** jinxing has quit IRC | 05:49 | |
*** jaypipes has joined #openstack-nova | 05:50 | |
openstackgerrit | bailin.zhang proposed openstack/nova: Create VM failed, unplug vifs https://review.openstack.org/306219 | 05:50 |
*** shaohe_feng has quit IRC | 05:51 | |
*** amotoki has joined #openstack-nova | 05:51 | |
*** kengo_sa_ has quit IRC | 05:52 | |
*** jwcroppe has joined #openstack-nova | 05:52 | |
*** shaohe_feng has joined #openstack-nova | 05:53 | |
openstackgerrit | Dinesh Bhor proposed openstack/nova: Fix flavor-create raises 500 error https://review.openstack.org/313234 | 05:54 |
*** adisky has joined #openstack-nova | 05:55 | |
*** jwcroppe has quit IRC | 05:57 | |
*** mjura has joined #openstack-nova | 05:57 | |
*** kengo_sa_ has joined #openstack-nova | 05:58 | |
*** shaohe_feng has quit IRC | 06:01 | |
*** shaohe_feng has joined #openstack-nova | 06:01 | |
*** sacharya has joined #openstack-nova | 06:03 | |
*** mjura has quit IRC | 06:04 | |
*** mjura has joined #openstack-nova | 06:04 | |
*** sacharya has quit IRC | 06:08 | |
*** Daisy has joined #openstack-nova | 06:08 | |
*** Daisy_ has joined #openstack-nova | 06:09 | |
*** thorst has joined #openstack-nova | 06:10 | |
*** afazekas_ is now known as afazekas | 06:10 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_security_group https://review.openstack.org/307135 | 06:10 |
*** gcb has joined #openstack-nova | 06:10 | |
*** shaohe_feng has quit IRC | 06:11 | |
*** Daisy has quit IRC | 06:12 | |
*** shaohe_feng has joined #openstack-nova | 06:12 | |
*** kengo_sa_ has quit IRC | 06:13 | |
*** markvoelker has joined #openstack-nova | 06:14 | |
*** thorst has quit IRC | 06:15 | |
*** dedery has quit IRC | 06:16 | |
*** Oku_OS-away is now known as Oku_OS | 06:17 | |
*** markvoelker has quit IRC | 06:19 | |
*** shaohe_feng has quit IRC | 06:22 | |
*** paul-carlton2 has joined #openstack-nova | 06:24 | |
*** shaohe_feng has joined #openstack-nova | 06:24 | |
*** klkumar has quit IRC | 06:25 | |
*** salv-orl_ has quit IRC | 06:29 | |
*** paul-carlton2 has quit IRC | 06:30 | |
*** sree has quit IRC | 06:32 | |
*** shaohe_feng has quit IRC | 06:32 | |
*** jwcroppe has joined #openstack-nova | 06:33 | |
*** shaohe_feng has joined #openstack-nova | 06:37 | |
*** paul-carlton2 has joined #openstack-nova | 06:41 | |
*** shaohe_feng has quit IRC | 06:42 | |
*** itamarl has joined #openstack-nova | 06:42 | |
*** shaohe_feng has joined #openstack-nova | 06:43 | |
*** xek__ is now known as xek | 06:43 | |
*** andymaier has joined #openstack-nova | 06:46 | |
*** openstackgerrit has quit IRC | 06:47 | |
*** openstackgerrit has joined #openstack-nova | 06:48 | |
*** lpetrut has joined #openstack-nova | 06:51 | |
*** shaohe_feng has quit IRC | 06:52 | |
*** shaohe_feng has joined #openstack-nova | 06:55 | |
*** jwcroppe has quit IRC | 06:56 | |
*** jwcroppe has joined #openstack-nova | 07:00 | |
*** tesseract has joined #openstack-nova | 07:01 | |
*** shaohe_feng has quit IRC | 07:03 | |
*** shaohe_feng has joined #openstack-nova | 07:04 | |
*** sacharya has joined #openstack-nova | 07:04 | |
*** fragatina has quit IRC | 07:04 | |
*** jlanoux has joined #openstack-nova | 07:06 | |
*** vtech has joined #openstack-nova | 07:08 | |
*** sacharya has quit IRC | 07:08 | |
*** markus_z has joined #openstack-nova | 07:12 | |
openstackgerrit | Ankit Agrawal proposed openstack/nova: Move is_volume_backed_instance to compute.utils https://review.openstack.org/270482 | 07:12 |
openstackgerrit | Ankit Agrawal proposed openstack/nova: Fix evaluation of host disk usage by volume-backed instances https://review.openstack.org/200870 | 07:12 |
*** laszloh has joined #openstack-nova | 07:12 | |
*** shaohe_feng has quit IRC | 07:13 | |
*** sfinucan has joined #openstack-nova | 07:16 | |
*** shaohe_feng has joined #openstack-nova | 07:18 | |
*** mpavone has joined #openstack-nova | 07:19 | |
*** esracelik has quit IRC | 07:20 | |
*** gokhan_ has quit IRC | 07:20 | |
openstackgerrit | Tom Patzig proposed openstack/nova-specs: Add "disable root_disk" option to flavors https://review.openstack.org/267673 | 07:21 |
*** dedery has joined #openstack-nova | 07:22 | |
*** hshiina has joined #openstack-nova | 07:22 | |
*** shaohe_feng has quit IRC | 07:23 | |
*** shaohe_feng has joined #openstack-nova | 07:24 | |
*** ljxiash has quit IRC | 07:25 | |
*** vtech_ has joined #openstack-nova | 07:26 | |
*** vtech has quit IRC | 07:26 | |
*** ducttape_ has joined #openstack-nova | 07:31 | |
*** jichen has joined #openstack-nova | 07:31 | |
*** gokhan_ has joined #openstack-nova | 07:33 | |
*** esracelik has joined #openstack-nova | 07:33 | |
*** shaohe_feng has quit IRC | 07:33 | |
*** shaohe_feng has joined #openstack-nova | 07:34 | |
*** ljxiash has joined #openstack-nova | 07:35 | |
*** ducttape_ has quit IRC | 07:36 | |
*** haukebruno has joined #openstack-nova | 07:36 | |
*** Daisy_ has quit IRC | 07:37 | |
*** Daisy has joined #openstack-nova | 07:37 | |
*** fishcried has joined #openstack-nova | 07:38 | |
*** voelzmo has joined #openstack-nova | 07:39 | |
*** lpetrut has quit IRC | 07:40 | |
*** shaohe_feng has quit IRC | 07:44 | |
*** shaohe_feng has joined #openstack-nova | 07:44 | |
*** daemontool has joined #openstack-nova | 07:45 | |
*** vtech_ has quit IRC | 07:45 | |
*** vtech has joined #openstack-nova | 07:45 | |
openstackgerrit | Tom Patzig proposed openstack/nova-specs: Add "disable root_disk" option to flavors https://review.openstack.org/267673 | 07:49 |
*** scheuran has joined #openstack-nova | 07:51 | |
*** shaohe_feng has quit IRC | 07:54 | |
bauzas_off | good morning Nova | 07:54 |
*** shaohe_feng has joined #openstack-nova | 07:55 | |
*** salv-orlando has joined #openstack-nova | 08:01 | |
*** paul-carlton2 has quit IRC | 08:02 | |
*** markvoelker has joined #openstack-nova | 08:03 | |
*** shaohe_feng has quit IRC | 08:04 | |
*** shaohe_feng has joined #openstack-nova | 08:05 | |
*** klkumar has joined #openstack-nova | 08:06 | |
*** derekh has joined #openstack-nova | 08:07 | |
*** markvoelker has quit IRC | 08:07 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
*** sridharg has quit IRC | 08:10 | |
*** shaohe_feng has quit IRC | 08:14 | |
*** PaulMurray has joined #openstack-nova | 08:15 | |
PaulMurray | Good morning | 08:16 |
*** thorst has joined #openstack-nova | 08:17 | |
*** openstackgerrit has quit IRC | 08:17 | |
*** openstackgerrit has joined #openstack-nova | 08:18 | |
*** jaosorior has joined #openstack-nova | 08:19 | |
*** lucas-afk has quit IRC | 08:19 | |
*** shaohe_feng has joined #openstack-nova | 08:20 | |
*** danpb has joined #openstack-nova | 08:21 | |
*** daemontool has quit IRC | 08:21 | |
*** houming has quit IRC | 08:22 | |
*** jed56 has joined #openstack-nova | 08:24 | |
*** lucasagomes has joined #openstack-nova | 08:24 | |
*** shaohe_feng has quit IRC | 08:25 | |
*** thorst has quit IRC | 08:25 | |
*** shaohe_feng has joined #openstack-nova | 08:26 | |
*** scheuran has quit IRC | 08:27 | |
*** andreas_s has joined #openstack-nova | 08:29 | |
*** adisky has quit IRC | 08:30 | |
*** jistr has joined #openstack-nova | 08:32 | |
*** paul-carlton2 has joined #openstack-nova | 08:33 | |
*** lpetrut has joined #openstack-nova | 08:34 | |
*** shaohe_feng has quit IRC | 08:35 | |
*** shaohe_feng has joined #openstack-nova | 08:36 | |
*** fragatina has joined #openstack-nova | 08:36 | |
*** yassine has joined #openstack-nova | 08:38 | |
*** yassine is now known as Guest28305 | 08:39 | |
*** Guest28305 is now known as yassou | 08:39 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add requested_destination field to RequestSpec https://review.openstack.org/312757 | 08:39 |
*** jamielennox is now known as jamielennox|away | 08:40 | |
*** Daisy has quit IRC | 08:41 | |
*** Daisy has joined #openstack-nova | 08:42 | |
*** shaohe_feng has quit IRC | 08:45 | |
*** shaohe_feng has joined #openstack-nova | 08:46 | |
*** Daisy has quit IRC | 08:46 | |
*** sridharg has joined #openstack-nova | 08:49 | |
*** lpetrut has quit IRC | 08:49 | |
*** belmoreira has joined #openstack-nova | 08:49 | |
*** shaohe_feng has quit IRC | 08:55 | |
*** shaohe_feng has joined #openstack-nova | 08:56 | |
*** lpetrut has joined #openstack-nova | 08:57 | |
*** cdent has joined #openstack-nova | 08:58 | |
*** zhongshengping has joined #openstack-nova | 08:58 | |
*** moshele has joined #openstack-nova | 09:01 | |
*** jlanoux has quit IRC | 09:03 | |
*** jlanoux has joined #openstack-nova | 09:03 | |
*** mkoderer__ has joined #openstack-nova | 09:03 | |
*** sacharya has joined #openstack-nova | 09:05 | |
*** dedery has quit IRC | 09:05 | |
*** vilobhmm11 has quit IRC | 09:06 | |
*** shaohe_feng has quit IRC | 09:06 | |
*** shaohe_feng has joined #openstack-nova | 09:06 | |
*** sacharya has quit IRC | 09:10 | |
*** ljxiash has quit IRC | 09:10 | |
*** Daisy has joined #openstack-nova | 09:12 | |
*** kolesovdv has joined #openstack-nova | 09:13 | |
*** ljxiash has joined #openstack-nova | 09:13 | |
*** vilobhmm11 has joined #openstack-nova | 09:14 | |
*** salv-orlando has quit IRC | 09:14 | |
*** vilobhmm11 has quit IRC | 09:14 | |
*** shaohe_feng has quit IRC | 09:16 | |
*** vilobhmm11 has joined #openstack-nova | 09:16 | |
*** Jeffrey4l_ has quit IRC | 09:16 | |
*** shaohe_feng has joined #openstack-nova | 09:17 | |
*** lpetrut has quit IRC | 09:17 | |
*** lpetrut has joined #openstack-nova | 09:17 | |
*** Daisy_ has joined #openstack-nova | 09:22 | |
*** lpetrut has quit IRC | 09:23 | |
*** Jeffrey4l_ has joined #openstack-nova | 09:23 | |
*** mvk has joined #openstack-nova | 09:23 | |
*** Daisy has quit IRC | 09:25 | |
*** shaohe_feng has quit IRC | 09:26 | |
*** shaohe_feng has joined #openstack-nova | 09:27 | |
*** hshiina has quit IRC | 09:29 | |
*** zhongshengping has quit IRC | 09:31 | |
*** ducttape_ has joined #openstack-nova | 09:32 | |
*** sfinucan has quit IRC | 09:32 | |
*** sfinucan has joined #openstack-nova | 09:32 | |
*** klkumar has quit IRC | 09:34 | |
*** ducttape_ has quit IRC | 09:36 | |
*** shaohe_feng has quit IRC | 09:36 | |
*** shaohe_feng has joined #openstack-nova | 09:38 | |
markus_z | alex_xu: Could you take a look at https://review.openstack.org/#/c/309196/5/nova/conf/api.py please? The config option "osapi_hide_server_address_states" looks like it should be deprecated. | 09:40 |
*** cheneydc has quit IRC | 09:41 | |
*** lpetrut has joined #openstack-nova | 09:44 | |
*** vtech_ has joined #openstack-nova | 09:44 | |
*** vtech has quit IRC | 09:44 | |
*** daemontool has joined #openstack-nova | 09:45 | |
*** shaohe_feng has quit IRC | 09:47 | |
*** shaohe_feng has joined #openstack-nova | 09:47 | |
*** baoli has joined #openstack-nova | 09:50 | |
*** nkrinner_afk has quit IRC | 09:50 | |
*** jwcroppe has quit IRC | 09:51 | |
*** markvoelker has joined #openstack-nova | 09:51 | |
*** baoli has quit IRC | 09:54 | |
*** Sharath_ has joined #openstack-nova | 09:55 | |
Sharath_ | Help | 09:55 |
*** markvoelker has quit IRC | 09:56 | |
*** gszasz has joined #openstack-nova | 09:56 | |
Sharath_ | may i know how NFS maintained in VM cold migration ? | 09:56 |
Sharath_ | in cold migration , vm shutdown and boots up , which folders will be copied to new VM and who will initiate that process ? | 09:56 |
*** shaohe_feng has quit IRC | 09:57 | |
*** yassou has quit IRC | 09:57 | |
*** sambetts|afk is now known as sambetts | 09:57 | |
Sharath_ | kindly help | 09:57 |
*** shaohe_feng has joined #openstack-nova | 09:58 | |
*** sdague has joined #openstack-nova | 10:01 | |
*** nkrinner_afk has joined #openstack-nova | 10:02 | |
*** hshiina has joined #openstack-nova | 10:02 | |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: method verification and fixes for servers.inc https://review.openstack.org/313514 | 10:05 |
openstackgerrit | Sean Dague proposed openstack/nova: WIP: api-ref: working on parameters validation for servers https://review.openstack.org/313532 | 10:05 |
*** shaohe_feng has quit IRC | 10:07 | |
*** ljxiash has quit IRC | 10:08 | |
*** klkumar has joined #openstack-nova | 10:09 | |
Sharath_ | Help | 10:09 |
openstackgerrit | Sean Dague proposed openstack/nova: Complete method verification of os-quotas https://review.openstack.org/313960 | 10:09 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 10:10 |
*** shaohe_feng has joined #openstack-nova | 10:10 | |
*** daemontool_ has joined #openstack-nova | 10:11 | |
*** Daisy_ has quit IRC | 10:13 | |
*** Daisy has joined #openstack-nova | 10:14 | |
*** daemontool has quit IRC | 10:14 | |
*** hoangcx has quit IRC | 10:15 | |
sdague | alex_xu: thanks for the catch on those return code issues | 10:15 |
*** rookie has quit IRC | 10:16 | |
*** rook-lap has joined #openstack-nova | 10:16 | |
*** ivase_ has quit IRC | 10:16 | |
danpb | ....we seem to have a never ending supply of patches moving config options | 10:16 |
* danpb wonders how many more until we are done with this | 10:16 | |
*** ivase has joined #openstack-nova | 10:16 | |
mdbooth | danpb: When they're all moved? | 10:17 |
* danpb considers just bulk approving them all | 10:17 | |
*** shaohe_feng has quit IRC | 10:17 | |
*** Daisy has quit IRC | 10:18 | |
*** shaohe_feng has joined #openstack-nova | 10:18 | |
*** dedery has joined #openstack-nova | 10:19 | |
*** apoorv has quit IRC | 10:20 | |
*** Sharath_ has left #openstack-nova | 10:20 | |
*** yamahata has quit IRC | 10:21 | |
mdbooth | danpb: Why not? For big mechanical cleanup like that we should do way more of that. | 10:22 |
mdbooth | They're merge conflict magnets. | 10:22 |
*** EinstCrazy has quit IRC | 10:22 | |
*** gcb has quit IRC | 10:23 | |
mdbooth | danpb: Unrelated, imagine I want to move a file currently in use by a domain. I can obviously just move it and trust that the kernel will keep it open for qemu, but say I want to ensure that anybody looking at the domain xml will also see the updated path. Is there a simple way to achieve that? | 10:24 |
openstackgerrit | Daniel Berrange proposed openstack/nova: config: remove deprecated ironic.client_log_level https://review.openstack.org/312006 | 10:26 |
openstackgerrit | Prateek Arora proposed openstack/nova: Separate out the conf entries for iSCSI and FC multipath drivers https://review.openstack.org/310679 | 10:26 |
*** rook-lap has quit IRC | 10:27 | |
openstackgerrit | Rajesh Tailor proposed openstack/nova: Trivial-Fix: Remove unreachable code https://review.openstack.org/314040 | 10:28 |
*** thorst has joined #openstack-nova | 10:28 | |
*** shaohe_feng has quit IRC | 10:28 | |
*** jwcroppe has joined #openstack-nova | 10:29 | |
danpb | mdbooth: i don't think there's any way to force update the xml in that scenario | 10:30 |
mdbooth | danpb: Ok, thanks. Might not be important. | 10:30 |
*** shaohe_feng has joined #openstack-nova | 10:30 | |
*** daemontool__ has joined #openstack-nova | 10:31 | |
*** vilobhmm11 has quit IRC | 10:31 | |
danpb | mdbooth: i'm trying to think if there's any scenario in which qemu would be unhappy with us renaming the file behind its back | 10:31 |
* mdbooth would hope not. | 10:32 | |
danpb | specifically what scenarios might cause qemu to try to close + reopen its existing file | 10:32 |
mdbooth | Ah, good point | 10:32 |
mdbooth | For a disk? | 10:32 |
*** jwcroppe has quit IRC | 10:33 | |
danpb | just asking the qemu folks for an opinion | 10:34 |
*** daemontool_ has quit IRC | 10:34 | |
mdbooth | danpb: How about a reboot initiated by the domain? | 10:34 |
danpb | a pure reboot is safe as qemu never stops running | 10:34 |
mdbooth | Ok | 10:34 |
*** kengo_sa_ has joined #openstack-nova | 10:35 | |
*** thorst has quit IRC | 10:35 | |
mdbooth | danpb: Can I do something like undefine the domain and redefine it with its new location, all without stopping it? | 10:36 |
danpb | sure, you can change the persistent config at any time | 10:36 |
danpb | its not reflected in the live config | 10:36 |
mdbooth | Ok | 10:36 |
*** daemontool has joined #openstack-nova | 10:36 | |
danpb | fwiw, kwolf says that qemu closes+opens when it needs to make a backing file writable in order to merge two cow layers | 10:37 |
danpb | openstack doesn't do that, so you should be safe with renaming | 10:37 |
mdbooth | danpb: Thanks | 10:37 |
*** daemontool__ has quit IRC | 10:37 | |
*** shaohe_feng has quit IRC | 10:38 | |
*** ivase has quit IRC | 10:39 | |
*** shaohe_feng has joined #openstack-nova | 10:39 | |
*** kengo_sa_ has quit IRC | 10:40 | |
*** rook-lap has joined #openstack-nova | 10:40 | |
*** daemontool_ has joined #openstack-nova | 10:40 | |
kashyap | mdbooth: On a related note, you might've noticed -- an example of undefine + redefine, libvirt blockcopy works only by an explicit undefine; perform blockcopy; redefine sequence. | 10:41 |
mdbooth | kashyap: Yeah, that's what made me think of it. I guess that doesn't update the running qemu process's config though, right? | 10:41 |
danpb | mdbooth: dman, there's another case - when doing live snapshot the original image is reopened to become a backing file | 10:42 |
danpb | s/dman/damn/ | 10:42 |
danpb | and that'll affect openstacak | 10:42 |
kashyap | And, blockcopy jobs last forever until canceled, which implies they last across domain restarts -- but QEMU doesn't yet provide a way to restart a copy operation on domain restart. | 10:42 |
mdbooth | danpb: Of course | 10:42 |
*** daemontool__ has joined #openstack-nova | 10:43 | |
mdbooth | danpb: We could hardlink it, but then we'd still have to manage the lifecycle of the hardlinks | 10:43 |
kashyap | mdbooth: (True, to answer your q., that doesn't update the runing config.) | 10:44 |
*** daemontool has quit IRC | 10:44 | |
danpb | mdbooth: what exactly are you renaming and why ? | 10:44 |
*** mariusv has joined #openstack-nova | 10:45 | |
*** mariusv has quit IRC | 10:45 | |
*** mariusv has joined #openstack-nova | 10:45 | |
mdbooth | I'm reviewing paul-carlton2 's libvirt storage pools spec and thinking through upgrade scenarios | 10:45 |
mdbooth | I'm trying to think of a way we could bulk update everything without disruption | 10:45 |
danpb | i was assuming we'd setup pools against the existing locations | 10:46 |
mdbooth | danpb: Right, but currently local file storage has many locations | 10:46 |
*** daemontool_ has quit IRC | 10:46 | |
mdbooth | Whereas ceph and lvm, for eg, have only 1 | 10:46 |
danpb | mdbooth: the per-instance directories ? | 10:47 |
mdbooth | Yes | 10:47 |
mdbooth | So using storage pools for local storage is an option, but it's ugly | 10:47 |
mdbooth | You need a pool per-instance | 10:47 |
* mdbooth wishes libvirt directory storage pools could handle subdirectories | 10:47 | |
danpb | yeah | 10:47 |
*** dmellado|off is now known as dmellado | 10:47 | |
*** shaohe_feng has quit IRC | 10:48 | |
*** shaohe_feng has joined #openstack-nova | 10:49 | |
mdbooth | danpb: Anyway, it would be cleaner to merge them, and also to have separate pools for separate backend types | 10:50 |
mdbooth | eg qcow2 vs 'raw' | 10:50 |
mdbooth | That be a common scenario as it happens, as the default storage type is qcow2, but config disks are always 'raw' | 10:50 |
*** daemontool_ has joined #openstack-nova | 10:51 | |
mdbooth | Except when using rbd | 10:51 |
*** baoli has joined #openstack-nova | 10:51 | |
markus_z | johnthetubaguy: I was thinking about https://review.openstack.org/#/c/309196/5 and the removal of the legacy_v2 code. | 10:55 |
*** baoli has quit IRC | 10:55 | |
*** daemontool__ has quit IRC | 10:55 | |
johnthetubaguy | markus_z: yep yep | 10:56 |
markus_z | johnthetubaguy: I think it would be better to get the move of the options merged before the removal deletes the legacy_v2 coe | 10:56 |
markus_z | *code | 10:56 |
markus_z | johnthetubaguy: This makes me believe that it would be the better approach: https://review.openstack.org/#/c/312910/9 | 10:56 |
sdague | markus_z: honestly, the legacy_v2 code removal is moving faster than configs | 10:57 |
sdague | I don't want to hold up that work | 10:57 |
markus_z | sdague: Hm. IMO the api config options could be merge today. | 10:58 |
sdague | markus_z: ok, it had a ton of -1s on it | 10:58 |
johnthetubaguy | but the removal could merge in a few mins | 10:58 |
*** cdent has left #openstack-nova | 10:58 | |
sdague | right, exactly | 10:58 |
johnthetubaguy | well, could get a +W soon | 10:58 |
*** shaohe_feng has quit IRC | 10:58 | |
markus_z | ah, well, OK. Than it would be done when edleafe comes online | 10:59 |
sdague | maybe, that patch goes back to apr 20th | 10:59 |
*** daemontool__ has joined #openstack-nova | 10:59 | |
johnthetubaguy | its seems fine to rebase on the removal | 11:00 |
*** apoorv has joined #openstack-nova | 11:00 | |
sdague | I get the concern of merge conflicts happening, but that's just kind of the cost of the conf work. It is both the giver and recipient of lots of merge conflicts | 11:00 |
openstackgerrit | John Hua proposed openstack/nova: XenAPI: Remove ovs_integration_bridge default value https://review.openstack.org/299092 | 11:00 |
markus_z | sdague: It is one of the last 2 big chunks and I wanted it to get merged soon, that was my concern. | 11:00 |
mdbooth | Chunking it is definitely a big help | 11:00 |
sdague | markus_z: right, but edleafe is going to need to fix that patch anyway, so now it will just need rebasing as well | 11:01 |
sdague | if that patch was clear to merge, I'd be fine rebasing on top of it | 11:01 |
markus_z | OK, then lets merge legacy_v2 first. I'm going to post an update of the config options work today on the ML. | 11:01 |
markus_z | brb, meeting | 11:01 |
*** shaohe_feng has joined #openstack-nova | 11:02 | |
sdague | but I'm really not ok, holding up mergable nearly approved patches on patches that need work in an unrelated area. | 11:02 |
*** iceyao has quit IRC | 11:02 | |
sdague | hmmm... anyone have the IRC nick for Sergey Nikitin ? | 11:03 |
*** daemontool_ has quit IRC | 11:03 | |
*** daemontool has joined #openstack-nova | 11:04 | |
johnthetubaguy | sniktin I thought, but I don't see him | 11:05 |
*** sacharya has joined #openstack-nova | 11:05 | |
*** daemontool_ has joined #openstack-nova | 11:06 | |
*** kengo_sa_ has joined #openstack-nova | 11:07 | |
*** rodrigods has quit IRC | 11:07 | |
*** rodrigods has joined #openstack-nova | 11:07 | |
*** daemontool__ has quit IRC | 11:07 | |
*** daemontool__ has joined #openstack-nova | 11:08 | |
*** shaohe_feng has quit IRC | 11:09 | |
*** shaohe_feng has joined #openstack-nova | 11:10 | |
*** yassine has joined #openstack-nova | 11:10 | |
*** daemontool has quit IRC | 11:10 | |
*** yassine is now known as Guest52874 | 11:10 | |
*** sacharya has quit IRC | 11:10 | |
sfinucan | johnthetubaguy: Should the NUMA/CPU pinning docs be tagged with the feature classification bp? https://review.openstack.org/#/c/312959/ | 11:11 |
*** daemontool has joined #openstack-nova | 11:11 | |
johnthetubaguy | sfinucan: not sure that makes sense, until they hit the ini file | 11:12 |
*** kengo_sa_ has quit IRC | 11:12 | |
*** daemontool_ has quit IRC | 11:12 | |
kashyap | bauzas_off (or anyone): When you're 'on', is this due to mixing Mock and Mox? Or something else? -- https://review.openstack.org/#/c/314012/2 | 11:12 |
johnthetubaguy | sfinucan: it might be worth a little spec less BP for tracking all the docs adds, but its not required for merge | 11:12 |
* kashyap will be afk for an hour-ish in a bit, will come back and check scroll | 11:12 | |
sfinucan | johnthetubaguy: OK, sounds fair | 11:12 |
sfinucan | I'll add to an appropriate ini (if possible) next | 11:13 |
*** Guest52874 is now known as yassou | 11:13 | |
*** daemontool_ has joined #openstack-nova | 11:14 | |
johnthetubaguy | sfinucan: I am reworking the ini stuff right now | 11:14 |
johnthetubaguy | sfinucan: worth holding off on that bit | 11:14 |
*** daemontool__ has quit IRC | 11:15 | |
*** jaosorior has quit IRC | 11:15 | |
*** jaosorior has joined #openstack-nova | 11:16 | |
*** klkumar has quit IRC | 11:17 | |
*** daemontool has quit IRC | 11:18 | |
paul-carlton2 | mdbooth, looking at your comments on libvirt storage pools spec. | 11:18 |
*** shaohe_feng has quit IRC | 11:19 | |
sdague | johnthetubaguy: ok, yeh, I was hoping for someone familiar with the server tags to actually write any user documentation for it, especially because things like the list behavior isn't super clear from the code | 11:19 |
*** shaohe_feng has joined #openstack-nova | 11:20 | |
johnthetubaguy | sdague: ah, good idea. jaypipes might be able to track them down. | 11:20 |
paul-carlton2 | I'm thinking we need a directory type pool to hold any disk files (data disks, config drive or swap) that are on the 'local' disk | 11:20 |
paul-carlton2 | Don't see how it matters what type of backend we are using, the pool is simply a directory that will contain these files be that raw (NoBacking) or Qcow2 | 11:22 |
*** jwcroppe has joined #openstack-nova | 11:23 | |
paul-carlton2 | If lvm, ploop or rbd backends are used then a separate pool, nova-lvm-pool, nova-ploop-pool or nova-rbd-pool will be created of the appropriate type to manage disk files stored there | 11:24 |
*** cdent has joined #openstack-nova | 11:25 | |
*** smatzek has joined #openstack-nova | 11:26 | |
*** jwcroppe has quit IRC | 11:28 | |
*** shaohe_feng has quit IRC | 11:29 | |
*** cdent has left #openstack-nova | 11:30 | |
*** shaohe_feng has joined #openstack-nova | 11:30 | |
*** danpb has quit IRC | 11:31 | |
*** ducttape_ has joined #openstack-nova | 11:32 | |
*** danpb has joined #openstack-nova | 11:33 | |
*** jaosorior has quit IRC | 11:33 | |
*** jaosorior has joined #openstack-nova | 11:33 | |
*** amotoki has quit IRC | 11:36 | |
*** ducttape_ has quit IRC | 11:37 | |
*** markvoelker has joined #openstack-nova | 11:39 | |
*** shaohe_feng has quit IRC | 11:39 | |
*** shaohe_feng has joined #openstack-nova | 11:40 | |
*** rtheis has joined #openstack-nova | 11:42 | |
*** lucasagomes is now known as lucas-hungry | 11:43 | |
*** markvoelker has quit IRC | 11:44 | |
openstackgerrit | Moshe Levi proposed openstack/nova: pci: Deprecate is_new from pci request https://review.openstack.org/310990 | 11:47 |
*** sudipto has quit IRC | 11:48 | |
*** shaohe_feng has quit IRC | 11:50 | |
*** shaohe_feng has joined #openstack-nova | 11:51 | |
*** Oku_OS is now known as Oku_OS-away | 11:51 | |
*** Oku_OS-away is now known as Oku_OS | 11:51 | |
*** fragatina has quit IRC | 11:54 | |
alex_xu | markus_z: i feel the whole hide-address-servers extension looks like strange, it should deprecated that whole thing... but that is another thing, not related to this patch. | 11:55 |
alex_xu | sdague: np | 11:55 |
markus_z | alex_xu: cool, thanks for double-checking. I noted it down as a todo. | 11:55 |
alex_xu | sdague: btw, i tested the servers tags, request to create tag [TAG, tag], i will got 500. | 11:56 |
alex_xu | markus_z: np | 11:56 |
*** baoli has joined #openstack-nova | 11:58 | |
openstackgerrit | Chris Dent proposed openstack/nova: WIP resource-pools/placement api https://review.openstack.org/293104 | 12:00 |
*** shaohe_feng has quit IRC | 12:00 | |
*** shaohe_feng has joined #openstack-nova | 12:00 | |
sdague | alex_xu: that's unfortunate | 12:00 |
sdague | alex_xu: I noticed the api samples tests only use a single tag, it's probably worth trying to update them to use multiple | 12:01 |
alex_xu | sdague: yes :( | 12:01 |
sdague | I was really wondering how that was all supposed to work in the case of multiple | 12:01 |
alex_xu | sdague: yea, agree | 12:02 |
alex_xu | i may cook a patch tomorrow | 12:02 |
openstackgerrit | Paul Carlton proposed openstack/nova-specs: Use libvirt storage pools https://review.openstack.org/310505 | 12:02 |
*** baoli has quit IRC | 12:03 | |
*** raildo-afk is now known as raildo | 12:04 | |
*** efried has joined #openstack-nova | 12:05 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: Adds HostCapabilities object model https://review.openstack.org/285856 | 12:06 |
*** thorst has joined #openstack-nova | 12:08 | |
*** aysyd has joined #openstack-nova | 12:09 | |
sdague | alex_xu: great, thanks | 12:09 |
*** ducttape_ has joined #openstack-nova | 12:10 | |
*** shaohe_feng has quit IRC | 12:10 | |
*** shaohe_feng has joined #openstack-nova | 12:13 | |
*** inara has quit IRC | 12:14 | |
*** baoli has joined #openstack-nova | 12:14 | |
*** cdent has joined #openstack-nova | 12:19 | |
claudiub | alex_xu: hello. when you have to time, can you take a look at this? https://review.openstack.org/#/c/285856/5 | 12:20 |
openstackgerrit | jichenjc proposed openstack/nova: Complete method Verification of os-hypervisors https://review.openstack.org/312024 | 12:20 |
*** shaohe_feng has quit IRC | 12:20 | |
claudiub | alex_xu: still WIP, but I'm curious about your opinion | 12:20 |
*** ducttape_ has quit IRC | 12:21 | |
*** shaohe_feng has joined #openstack-nova | 12:21 | |
*** paul-carlton has joined #openstack-nova | 12:21 | |
alex_xu | claudiub: cool, will check it asap | 12:21 |
*** efried has quit IRC | 12:22 | |
*** apoorv has quit IRC | 12:23 | |
openstackgerrit | jichenjc proposed openstack/nova: Complete Verification of server admin action https://review.openstack.org/311727 | 12:24 |
*** efried has joined #openstack-nova | 12:24 | |
*** ivase has joined #openstack-nova | 12:25 | |
*** thorst has quit IRC | 12:25 | |
*** thorst has joined #openstack-nova | 12:26 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Fix exception when vcpu_pin_set is set to "" https://review.openstack.org/314076 | 12:27 |
*** Oku_OS is now known as Oku_OS-away | 12:27 | |
*** sree has joined #openstack-nova | 12:30 | |
*** edmondsw has joined #openstack-nova | 12:30 | |
openstackgerrit | jichenjc proposed openstack/nova: Complete Verification of server-metadata https://review.openstack.org/311723 | 12:31 |
*** shaohe_feng has quit IRC | 12:31 | |
*** shaohe_feng has joined #openstack-nova | 12:31 | |
*** thorst has quit IRC | 12:31 | |
*** thorst has joined #openstack-nova | 12:32 | |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: update parameter validation on servers https://review.openstack.org/313532 | 12:33 |
*** markvoelker has joined #openstack-nova | 12:33 | |
*** sree__ has joined #openstack-nova | 12:35 | |
*** sree has quit IRC | 12:35 | |
*** thorst has quit IRC | 12:37 | |
*** rfolco has joined #openstack-nova | 12:37 | |
*** Oku_OS-away is now known as Oku_OS | 12:37 | |
*** markvoelker has quit IRC | 12:38 | |
*** agireud has quit IRC | 12:38 | |
*** thorst has joined #openstack-nova | 12:38 | |
*** lbeliveau has quit IRC | 12:39 | |
*** agireud has joined #openstack-nova | 12:40 | |
*** shaohe_feng has quit IRC | 12:41 | |
*** shaohe_feng has joined #openstack-nova | 12:41 | |
*** daemontool__ has joined #openstack-nova | 12:41 | |
*** lbeliveau has joined #openstack-nova | 12:41 | |
*** EinstCrazy has joined #openstack-nova | 12:42 | |
*** thorst has quit IRC | 12:43 | |
*** inara has joined #openstack-nova | 12:43 | |
*** rlrossit has joined #openstack-nova | 12:43 | |
*** cleong has joined #openstack-nova | 12:45 | |
*** daemontool_ has quit IRC | 12:45 | |
*** EinstCrazy has quit IRC | 12:46 | |
*** EinstCrazy has joined #openstack-nova | 12:47 | |
*** thorst has joined #openstack-nova | 12:49 | |
*** thorst has quit IRC | 12:49 | |
*** thorst has joined #openstack-nova | 12:50 | |
openstackgerrit | Peter Wang proposed openstack/nova: Detach volume when deleting shelved server https://review.openstack.org/314083 | 12:50 |
*** EinstCrazy has quit IRC | 12:50 | |
*** zul has quit IRC | 12:50 | |
*** chuck__ has joined #openstack-nova | 12:51 | |
*** chuck__ has quit IRC | 12:51 | |
*** shaohe_feng has quit IRC | 12:51 | |
*** pwnall has joined #openstack-nova | 12:52 | |
*** cleong has quit IRC | 12:52 | |
*** corey_ has joined #openstack-nova | 12:52 | |
*** chuck__ has joined #openstack-nova | 12:52 | |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc https://review.openstack.org/314085 | 12:52 |
*** thorst_ has joined #openstack-nova | 12:53 | |
*** sree has joined #openstack-nova | 12:53 | |
*** lucas-hungry is now known as lucasagomes | 12:54 | |
*** thorst has quit IRC | 12:54 | |
*** shaohe_feng has joined #openstack-nova | 12:54 | |
*** sree__ has quit IRC | 12:56 | |
*** mdrabe has joined #openstack-nova | 12:56 | |
*** sree__ has joined #openstack-nova | 12:57 | |
*** sree has quit IRC | 12:57 | |
*** irenab_ has joined #openstack-nova | 12:57 | |
*** zzzeek has joined #openstack-nova | 12:58 | |
*** irenab has quit IRC | 12:58 | |
*** pwnall has quit IRC | 12:59 | |
*** pwnall has joined #openstack-nova | 12:59 | |
*** vladikr has joined #openstack-nova | 12:59 | |
*** kengo_sakai has quit IRC | 13:01 | |
*** EinstCrazy has joined #openstack-nova | 13:01 | |
*** shaohe_feng has quit IRC | 13:01 | |
*** shaohe_feng has joined #openstack-nova | 13:02 | |
*** irenab_ has quit IRC | 13:02 | |
*** kengo_sakai has joined #openstack-nova | 13:02 | |
*** links has quit IRC | 13:02 | |
*** efried has quit IRC | 13:03 | |
*** ccarmack has joined #openstack-nova | 13:04 | |
*** claudiub has quit IRC | 13:05 | |
*** irenab has joined #openstack-nova | 13:06 | |
*** EinstCrazy has quit IRC | 13:06 | |
*** sacharya has joined #openstack-nova | 13:06 | |
*** kengo_sakai has quit IRC | 13:07 | |
*** ctrath has joined #openstack-nova | 13:10 | |
*** sacharya has quit IRC | 13:11 | |
openstackgerrit | jichenjc proposed openstack/nova: Complete Verification of os-floating-ip-pools https://review.openstack.org/311070 | 13:11 |
*** jwcroppe has joined #openstack-nova | 13:11 | |
*** shaohe_feng has quit IRC | 13:12 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: centralize exception options https://review.openstack.org/314091 | 13:12 |
*** eharney has joined #openstack-nova | 13:12 | |
*** krtaylor has quit IRC | 13:12 | |
*** shaohe_feng has joined #openstack-nova | 13:13 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: :Add nova-manage quota_usage_refresh command https://review.openstack.org/299621 | 13:13 |
*** markvoelker has joined #openstack-nova | 13:13 | |
*** burgerk has joined #openstack-nova | 13:14 | |
*** EinstCrazy has joined #openstack-nova | 13:14 | |
*** jwcroppe has quit IRC | 13:16 | |
*** zzzeek has quit IRC | 13:16 | |
*** thorst_ has quit IRC | 13:16 | |
*** kylek3h has joined #openstack-nova | 13:17 | |
*** amotoki has joined #openstack-nova | 13:17 | |
edleafe | markus_z: geez, more merge conflicts? Between those and xen rechecks, I don't think the api config stuff will ever merge. :( | 13:17 |
edleafe | markus_z: Working on the rebase now | 13:17 |
markus_z | edleafe: yeah, the removal of the legacy_v2 was faster | 13:18 |
*** zzzeek has joined #openstack-nova | 13:18 | |
markus_z | But we are very close to let the merge conflicts behind us | 13:19 |
*** krtaylor has joined #openstack-nova | 13:19 | |
markus_z | I'm writing changes for the last moves and then it's "only" writing proper help texts, which shouldn't be as prone to merge conflicts like the moves. | 13:20 |
*** edmondsw has quit IRC | 13:20 | |
mdbooth | paul-carlton2: I think the use case for libvirt.use_storage_pools has gone away | 13:20 |
*** jichen has quit IRC | 13:20 | |
mdbooth | I don't see any reason why it should ever be false | 13:21 |
mdbooth | We're basically replacing the legacy image backends with new ones which use libvirt storage pools | 13:21 |
mdbooth | And that migration process will be managed automatically | 13:21 |
mdbooth | I don't think we should involve the user | 13:21 |
*** iceyao has joined #openstack-nova | 13:21 | |
mdbooth | s/user/operator/ | 13:21 |
mdbooth | The ploop thing isn't even relevant here, because we aren't replacing that yet | 13:22 |
*** shaohe_feng has quit IRC | 13:22 | |
*** sree__ has quit IRC | 13:22 | |
*** shaohe_feng has joined #openstack-nova | 13:23 | |
*** ljxiash has joined #openstack-nova | 13:23 | |
johnthetubaguy | markus_z: +1 | 13:25 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs: New Nova Scheduler filter: AggregateInstanceTypeFilter https://review.openstack.org/314097 | 13:27 |
*** svenkat has joined #openstack-nova | 13:28 | |
*** ducttape_ has joined #openstack-nova | 13:28 | |
*** vishwanathj has joined #openstack-nova | 13:28 | |
openstackgerrit | John Garbutt proposed openstack/nova: Add prototype feature classification matrix https://review.openstack.org/264719 | 13:28 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: complete verification for extensions resource https://review.openstack.org/314101 | 13:30 |
*** sree has joined #openstack-nova | 13:31 | |
*** belmoreira has quit IRC | 13:31 | |
*** shaohe_feng has quit IRC | 13:32 | |
*** mtanino has joined #openstack-nova | 13:32 | |
*** sudipto has joined #openstack-nova | 13:32 | |
*** shaohe_feng has joined #openstack-nova | 13:33 | |
*** mrkz has joined #openstack-nova | 13:34 | |
*** wznoinsk has quit IRC | 13:34 | |
*** jwcroppe has joined #openstack-nova | 13:34 | |
*** wznoinsk has joined #openstack-nova | 13:35 | |
*** ljxiash has quit IRC | 13:35 | |
*** irenab has quit IRC | 13:36 | |
*** mageshgv has joined #openstack-nova | 13:36 | |
*** tonytan4ever has joined #openstack-nova | 13:37 | |
*** klkumar has joined #openstack-nova | 13:37 | |
*** thorst_ has joined #openstack-nova | 13:37 | |
johnthetubaguy | sdague: alex_xu: I was looking at all the unauthorized(401) notes for the error response codes, do we need to be explicit about those. I guess there is no other way to show APIs that are not protected? | 13:38 |
*** ljxiash has joined #openstack-nova | 13:39 | |
sdague | johnthetubaguy: you mean the "this is default admin only" comments? | 13:39 |
johnthetubaguy | sdague: I like the comments, I was meaning in the error response codes list | 13:39 |
sdague | johnthetubaguy: link? | 13:39 |
*** jaypipes has quit IRC | 13:40 | |
sdague | just so I can make sure we're talking about the same thing | 13:40 |
johnthetubaguy | https://review.openstack.org/#/c/313514/2/api-ref/source/servers.inc@426 | 13:40 |
johnthetubaguy | I mean the list is correct, I just wonder if we need to tell folks about those errors on (almost?) ever API call | 13:41 |
sdague | you mean the fast that we're listing 401 | 13:41 |
johnthetubaguy | yeah | 13:41 |
sdague | so, I think if we want to go through after and pull out common codes, that's fine | 13:41 |
sdague | but they all pretty much list it already, so I think for this round, it's fine | 13:41 |
johnthetubaguy | true, that makes sense | 13:42 |
alex_xu | yeah, i guess so, we should have some doc to describe common response code, like for request wrong content-type | 13:42 |
sdague | right | 13:42 |
*** shaohe_feng has quit IRC | 13:42 | |
sdague | I think an interesting part of this whole exercise is thinking through the things we might want to pull out more generically as we read all of this | 13:43 |
*** shaohe_feng has joined #openstack-nova | 13:43 | |
*** syjulian has joined #openstack-nova | 13:43 | |
johnthetubaguy | sdague: yeah, very true, this is just one of those things | 13:43 |
sdague | but I hesitate to do those things while we still have > 200 items in http://burndown.dague.org/ (even when we have > 50 items) | 13:43 |
*** efried has joined #openstack-nova | 13:43 | |
johnthetubaguy | sdague: yep, you are right, just thinking out loud | 13:44 |
*** smatzek has quit IRC | 13:44 | |
sdague | johnthetubaguy: yeh, it's a good point, we might want to build a dedicated place to take notes like that after | 13:45 |
*** david-lyle_ has joined #openstack-nova | 13:48 | |
*** mtanino has quit IRC | 13:49 | |
*** bauzas_off is now known as bauzas | 13:49 | |
*** sree__ has joined #openstack-nova | 13:49 | |
*** mriedem1 has joined #openstack-nova | 13:49 | |
*** david-lyle has quit IRC | 13:50 | |
*** gagehugo has joined #openstack-nova | 13:50 | |
paul-carlton2 | mdbooth? | 13:51 |
paul-carlton2 | why do you think we don't need flag? | 13:51 |
*** mriedem has joined #openstack-nova | 13:52 | |
*** cdelatte has joined #openstack-nova | 13:53 | |
*** shaohe_feng has quit IRC | 13:53 | |
*** ametts has joined #openstack-nova | 13:53 | |
*** sree has quit IRC | 13:53 | |
*** shaohe_feng has joined #openstack-nova | 13:53 | |
*** eharney has quit IRC | 13:54 | |
*** mriedem1 has quit IRC | 13:54 | |
*** pradk has joined #openstack-nova | 13:54 | |
*** markvoelker has quit IRC | 13:55 | |
edleafe | Nova scheduler subteam meeting in 5 minuts in #openstack-meeting-alt | 13:56 |
*** jaypipes has joined #openstack-nova | 13:56 | |
edleafe | minutes, even | 13:56 |
*** edmondsw has joined #openstack-nova | 13:57 | |
*** mdrabe has quit IRC | 13:57 | |
*** esracelik has quit IRC | 13:59 | |
*** mriedem1 has joined #openstack-nova | 13:59 | |
mriedem1 | am i the only person having irc issues? | 13:59 |
bauzas | mriedem1: I can see you :) | 14:00 |
johnthetubaguy | possibly | 14:00 |
*** ducttape_ has quit IRC | 14:00 | |
bauzas | but sometimes, some IRC servers are joking, try changing to another one | 14:00 |
*** mriedem has quit IRC | 14:00 | |
johnthetubaguy | ah, there is only one of you now | 14:00 |
*** sree__ has quit IRC | 14:01 | |
edleafe | jaypipes: are you around for the scheduler meeting? | 14:01 |
*** sahid has joined #openstack-nova | 14:02 | |
*** shaohe_feng has quit IRC | 14:03 | |
*** catintheroof has joined #openstack-nova | 14:03 | |
openstackgerrit | Paul Carlton proposed openstack/nova-specs: Use libvirt storage pools https://review.openstack.org/310505 | 14:03 |
*** shaohe_feng has joined #openstack-nova | 14:03 | |
*** liverpooler has quit IRC | 14:03 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs: New Nova Scheduler filter: AggregateInstanceAffinityFilter https://review.openstack.org/314097 | 14:03 |
*** gongysh has joined #openstack-nova | 14:04 | |
*** dedery_ has joined #openstack-nova | 14:05 | |
*** dedery__ has joined #openstack-nova | 14:06 | |
openstackgerrit | Julian proposed openstack/nova: WIP Add unit tests for nova.virt.firewall.IpTablesFirewallDriver https://review.openstack.org/311758 | 14:07 |
*** links has joined #openstack-nova | 14:08 | |
*** pwnall has quit IRC | 14:08 | |
*** dedery has quit IRC | 14:08 | |
jaypipes | edleafe: I am now, sorry got a phone call just as meeting was starting... | 14:08 |
*** dedery_ has quit IRC | 14:10 | |
*** mdrabe has joined #openstack-nova | 14:10 | |
*** jamesden_ has joined #openstack-nova | 14:10 | |
*** links has quit IRC | 14:11 | |
*** dedery__ has quit IRC | 14:11 | |
*** thorst_ has quit IRC | 14:11 | |
*** gongysh has quit IRC | 14:11 | |
*** sahid has quit IRC | 14:12 | |
*** thorst_ has joined #openstack-nova | 14:12 | |
*** eharney has joined #openstack-nova | 14:12 | |
openstackgerrit | Julian proposed openstack/nova: WIP Add unit tests for nova.virt.firewall.IpTablesFirewallDriver https://review.openstack.org/311758 | 14:12 |
*** fragatina has joined #openstack-nova | 14:13 | |
*** smatzek has joined #openstack-nova | 14:13 | |
*** shaohe_feng has quit IRC | 14:13 | |
*** shaohe_feng has joined #openstack-nova | 14:14 | |
*** gszasz has quit IRC | 14:16 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: centralize default flavor option https://review.openstack.org/314123 | 14:16 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: deprecate "default_flavor" config option https://review.openstack.org/314124 | 14:16 |
*** thorst_ has quit IRC | 14:17 | |
*** laszloh has quit IRC | 14:19 | |
*** zz_dimtruck is now known as dimtruck | 14:21 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs: New Nova Scheduler filter: AggregateInstanceAffinityFilter https://review.openstack.org/314097 | 14:21 |
openstackgerrit | Prateek Arora proposed openstack/nova: Separate out the conf entries for iSCSI and FC multipath drivers https://review.openstack.org/310679 | 14:22 |
*** andrewbogott has quit IRC | 14:22 | |
*** andrewbogott has joined #openstack-nova | 14:22 | |
*** shaohe_feng has quit IRC | 14:23 | |
*** thorst_ has joined #openstack-nova | 14:24 | |
*** shaohe_feng has joined #openstack-nova | 14:24 | |
*** itamarl_ has joined #openstack-nova | 14:27 | |
raj_singh | markus_z: What is "Trivial Patch Monkey"? | 14:28 |
*** thorst_ has quit IRC | 14:28 | |
markus_z | raj_singh: When you see a very small patch which is trivial and ready to merge, ping the cores for this. | 14:28 |
markus_z | raj_singh: In the past we had a lot of those changes and the people searching for those patches were the "monkeys" AFAIK :) | 14:29 |
*** itamarl has quit IRC | 14:29 | |
*** itamarl_ is now known as itamarl | 14:29 | |
markus_z | raj_singh: I'm not sure where the term has its origins | 14:29 |
raj_singh | markus_z: got it, thx. | 14:29 |
raj_singh | markus_z: better I don't ask :) | 14:30 |
*** thorst_ has joined #openstack-nova | 14:30 | |
*** smcginnis_ has quit IRC | 14:33 | |
*** shaohe_feng has quit IRC | 14:34 | |
*** amotoki has quit IRC | 14:34 | |
*** hshiina has quit IRC | 14:34 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: deprecate "default_flavor" config option https://review.openstack.org/314124 | 14:35 |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: centralize default flavor option https://review.openstack.org/314123 | 14:35 |
openstackgerrit | Sean Dague proposed openstack/nova: WIP: api-ref: flavors https://review.openstack.org/314133 | 14:36 |
*** sdake has joined #openstack-nova | 14:36 | |
*** syjulian has quit IRC | 14:36 | |
*** shaohe_feng has joined #openstack-nova | 14:36 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Add a lock() context manager to image backend https://review.openstack.org/279625 | 14:37 |
openstackgerrit | Paul Carlton proposed openstack/nova: Rename Raw backend to NoBacking https://review.openstack.org/279626 | 14:37 |
openstackgerrit | Paul Carlton proposed openstack/nova: Introduce ImageCacheLocalPool https://review.openstack.org/279669 | 14:37 |
openstackgerrit | Paul Carlton proposed openstack/nova: Remove fake_imagebackend.Raw and cleanup dependent tests https://review.openstack.org/267661 | 14:37 |
openstackgerrit | Paul Carlton proposed openstack/nova: Rename Image.check_image_exists to Image.exists() https://review.openstack.org/270998 | 14:37 |
openstackgerrit | Paul Carlton proposed openstack/nova: Remove deprecated option libvirt.remove_unused_kernels https://review.openstack.org/265886 | 14:37 |
openstackgerrit | Paul Carlton proposed openstack/nova: Only attempt to inject files if the injection disk exists https://review.openstack.org/250872 | 14:37 |
openstackgerrit | Paul Carlton proposed openstack/nova: Implementation of Libvirt Storage Pools https://review.openstack.org/314134 | 14:37 |
*** sahid has joined #openstack-nova | 14:38 | |
*** mtanino has joined #openstack-nova | 14:39 | |
*** jdurgin1 has joined #openstack-nova | 14:40 | |
*** ducttape_ has joined #openstack-nova | 14:41 | |
*** fragatina has quit IRC | 14:42 | |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: use os-brick for volume related operations https://review.openstack.org/273504 | 14:43 |
openstackgerrit | Sean Dague proposed openstack/nova: Complete Verification of server admin action https://review.openstack.org/311727 | 14:43 |
openstackgerrit | Mark Doffman proposed openstack/nova: Instance mapping save, properly load cell mapping https://review.openstack.org/313617 | 14:44 |
*** shaohe_feng has quit IRC | 14:44 | |
*** jdillaman has joined #openstack-nova | 14:44 | |
*** shaohe_feng has joined #openstack-nova | 14:44 | |
openstackgerrit | Sean Dague proposed openstack/nova: Complete Verification of server admin action https://review.openstack.org/311727 | 14:45 |
markus_z | sdague: I'm looking at https://github.com/openstack/nova/blob/master/nova/image/s3.py and wonder if that was overlooked in commit https://git.openstack.org/cgit/openstack/nova/commit/?id=4140eb4 | 14:45 |
sdague | markus_z: it probably was | 14:45 |
markus_z | sdague: If that's the case, I tend to remove it completely without any deprecation | 14:45 |
markus_z | sdague: thanks | 14:46 |
*** gszasz has joined #openstack-nova | 14:46 | |
*** gcb has joined #openstack-nova | 14:48 | |
openstackgerrit | Ronald Bradford proposed openstack/nova: Complete method verification of os-tenant-networks https://review.openstack.org/314139 | 14:48 |
mriedem1 | markus_z: there was another ec2 removal patch, let me find it | 14:48 |
mriedem1 | https://review.openstack.org/#/c/266425/ | 14:48 |
mriedem1 | abandoned now because it got tricky | 14:49 |
mriedem1 | i think it would be good to start in smaller chunks, like removing the s3 code | 14:49 |
*** dedery has joined #openstack-nova | 14:49 | |
*** woodster_ has joined #openstack-nova | 14:49 | |
markus_z | yeah, I would remove only this s3 module due to their config options are not needed anymore. | 14:51 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: libvirt: New configuration classes to parse device address element https://review.openstack.org/304147 | 14:51 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: libvirt: attach configdrive after instance XML https://review.openstack.org/303335 | 14:51 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: DB: add path, serial and address to block devices https://review.openstack.org/310615 | 14:51 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: DB: add bus and bus_address to virtual interfaces https://review.openstack.org/310616 | 14:51 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: objects: adding serial, path, bus_address fields to bdm object https://review.openstack.org/310617 | 14:52 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: objects: adding bus and bus_address to virtual interfaces object https://review.openstack.org/310618 | 14:52 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging metadata API support https://review.openstack.org/304511 | 14:52 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Device tagging API support https://review.openstack.org/304510 | 14:52 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Compute manager device tagging support https://review.openstack.org/264017 | 14:52 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Libvirt driver implementation of device tagging https://review.openstack.org/264016 | 14:52 |
*** prateek has quit IRC | 14:52 | |
*** dedery has quit IRC | 14:54 | |
mriedem1 | markus_z: cool. we also want to remove that because it uses nova-cert which we want to eventually also remove | 14:54 |
*** mriedem1 is now known as mriedem | 14:54 | |
*** shaohe_feng has quit IRC | 14:54 | |
*** shaohe_feng has joined #openstack-nova | 14:54 | |
* alex_xu forgets the power line at office again :( | 14:55 | |
*** mspreitz has joined #openstack-nova | 14:56 | |
*** ramki has joined #openstack-nova | 14:56 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Enable python34 tests for nova.tests.unit.pci.test_manager and test_stats https://review.openstack.org/310976 | 14:56 |
*** sacharya has joined #openstack-nova | 14:58 | |
*** ijw_ has quit IRC | 14:58 | |
openstackgerrit | Chris Dent proposed openstack/nova: WIP resource-pools/placement api https://review.openstack.org/293104 | 14:59 |
*** Guest30018 is now known as mfisch | 14:59 | |
*** dedery has joined #openstack-nova | 14:59 | |
*** mfisch is now known as Guest56459 | 14:59 | |
*** eharney has quit IRC | 15:02 | |
*** tonytan4ever has quit IRC | 15:03 | |
mriedem | sdague: on https://review.openstack.org/#/c/313514/2/api-ref/source/servers.inc for listing servers, i was looking at the 503 in the old docs. got me thinking that we currently have a bug where we fail to list servers if neutron is down (because we can't get security groups) | 15:03 |
mriedem | sdague: but i think that's not even a 503, it's a 500, so unexpected and doesn't belong in the docs | 15:04 |
*** haplo37 has joined #openstack-nova | 15:04 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1567655 | 15:04 |
openstack | Launchpad bug 1567655 in OpenStack Compute (nova) "500 error when trying to list instances and neutron-server is down" [Medium,Confirmed] - Assigned to Prateek Arora (parora) | 15:04 |
*** shaohe_feng has quit IRC | 15:04 | |
*** lpetrut has quit IRC | 15:05 | |
*** shaohe_feng has joined #openstack-nova | 15:05 | |
*** lpetrut has joined #openstack-nova | 15:06 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: resource-providers: generic resource pools https://review.openstack.org/300176 | 15:07 |
mriedem | alex_xu: on https://review.openstack.org/#/c/313514/ you can get a 404 when listing servers if you provided a marker that's not ofund | 15:07 |
mriedem | *found | 15:07 |
*** voelzmo has quit IRC | 15:07 | |
jaypipes | mriedem, cdent, Yingxin, edleafe, bauzas: please see updates to ^^ spec, especially around new REST API calls for setting inventory records on resource pools. | 15:07 |
mriedem | aye aye | 15:09 |
* mriedem need a break from his first api-ref review of the day :) | 15:09 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: config options: remove s3 related options https://review.openstack.org/314146 | 15:09 |
openstackgerrit | Ed Leafe proposed openstack/nova-specs: resource-providers: Move allocation fields https://review.openstack.org/300177 | 15:10 |
edleafe | jaypipes: ^^ | 15:10 |
*** thorst_ has quit IRC | 15:10 | |
edleafe | jaypipes: made some changes to mention the move to the API database. Please review to make sure I didn't bork anything | 15:10 |
edleafe | jaypipes: rebased it, too :) | 15:10 |
jaypipes | edleafe: danke. | 15:11 |
cdent | thanks jaypipes will digest that soon | 15:11 |
*** thorst_ has joined #openstack-nova | 15:11 | |
*** lpetrut has quit IRC | 15:12 | |
*** eharney has joined #openstack-nova | 15:13 | |
*** Daisy has joined #openstack-nova | 15:15 | |
mriedem | alaski: question came up in the generic-resource-pools spec about policy for the new placement api, do you envision we'd just ship a separate policy.json file for the placement api? | 15:15 |
*** shaohe_feng has quit IRC | 15:15 | |
*** mdrabe has quit IRC | 15:15 | |
alaski | mriedem: yeah. I think we should keep that completely split out | 15:15 |
*** thorst_ has quit IRC | 15:15 | |
*** shaohe_feng has joined #openstack-nova | 15:15 | |
*** ptm_away has joined #openstack-nova | 15:16 | |
*** rena9067 has joined #openstack-nova | 15:17 | |
*** PaulMurray has quit IRC | 15:17 | |
*** EinstCrazy has quit IRC | 15:18 | |
*** itamarl has quit IRC | 15:18 | |
mdbooth | paul-carlton2: Sorry, had to head out. Got a minute now? | 15:19 |
*** Daisy has quit IRC | 15:19 | |
alaski | mriedem: commented | 15:20 |
jaypipes | edleafe: reviewed. changes look fine, thank you sir. | 15:21 |
jaypipes | mriedem: a review on the resource-providers-allocations spec would be most appreciated. thanks in advance. | 15:21 |
raj_singh | sdague: For api-ref work are you guys following any pattern to avoid conflicts or should I just pick any file from api-ref/source/* and start working on it? | 15:22 |
openstackgerrit | Abhijeet Malawade proposed openstack/nova: Return HTTPBadRequest if incorrect params are provided to images api https://review.openstack.org/314153 | 15:23 |
*** davideagnello has joined #openstack-nova | 15:24 | |
*** mpavone has quit IRC | 15:24 | |
*** pwnall has joined #openstack-nova | 15:24 | |
*** shaohe_feng has quit IRC | 15:25 | |
*** shaohe_feng has joined #openstack-nova | 15:26 | |
jaypipes | mriedem: dansmith's https://review.openstack.org/#/c/312750/ should be an easy win if you | 15:27 |
jaypipes | 're up for it. | 15:27 |
*** mdrabe has joined #openstack-nova | 15:27 | |
*** nic has joined #openstack-nova | 15:28 | |
mriedem | jaypipes: easy -2 yeah | 15:28 |
mriedem | thanks :) | 15:28 |
*** ljxiash has quit IRC | 15:28 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Use assertGreater(A, X) instead of assertTrue(A > X) https://review.openstack.org/302734 | 15:29 |
*** Swami has joined #openstack-nova | 15:29 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Use assertLess(Equal) instead of assertTrue(A > X) https://review.openstack.org/308401 | 15:29 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Use assert(Not)Equal instead of assertTrue(A == X) https://review.openstack.org/308402 | 15:29 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Use assertNotIn instead of assertTrue(all(A != B)) https://review.openstack.org/314169 | 15:29 |
*** xenogear has joined #openstack-nova | 15:30 | |
*** tonytan4ever has joined #openstack-nova | 15:32 | |
*** jistr has quit IRC | 15:33 | |
openstackgerrit | Peter Wang proposed openstack/nova: Detach volume when deleting shelved server https://review.openstack.org/314083 | 15:33 |
*** Jeffrey4l_ has quit IRC | 15:34 | |
*** lpetrut has joined #openstack-nova | 15:34 | |
*** jed56 has quit IRC | 15:34 | |
*** thorst_ has joined #openstack-nova | 15:35 | |
*** shaohe_feng has quit IRC | 15:35 | |
*** shaohe_feng has joined #openstack-nova | 15:36 | |
*** andreas_s has quit IRC | 15:36 | |
*** irenab has joined #openstack-nova | 15:38 | |
paul-carlton2 | mdbooth, about to head out but have five mins can I call you? | 15:38 |
rbradfor | sdague, an api-ref style question. When there is a JSON response we include an example, when a POST has no response it's blank, The response head basically flows into the next API call. Would some text, such as "Check for valid HTTP response" help in legibility of documentation. | 15:38 |
mdbooth | paul-carlton2: Sorry, in another meeting now :/ 9:30am tomorrow? | 15:39 |
*** nic has quit IRC | 15:39 | |
paul-carlton2 | yep, talk to you then | 15:39 |
mriedem | jaypipes: some small things in the generic-resource-pools spec https://review.openstack.org/#/c/300176/ | 15:39 |
mriedem | mostly copy/paste errors i think | 15:40 |
*** nic has joined #openstack-nova | 15:40 | |
*** daemontool__ has quit IRC | 15:41 | |
jaypipes | mriedem: on it. | 15:41 |
*** kolesovdv has quit IRC | 15:43 | |
*** jogo has quit IRC | 15:43 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: tests: Adding functional tests to cover VM creation with sriov https://review.openstack.org/294780 | 15:43 |
*** cdent has quit IRC | 15:44 | |
*** jogo has joined #openstack-nova | 15:44 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Add newton spec for ordered filter scheduler https://review.openstack.org/256323 | 15:45 |
*** Oku_OS is now known as Oku_OS-away | 15:45 | |
*** shaohe_feng has quit IRC | 15:45 | |
*** irenab has quit IRC | 15:46 | |
*** shaohe_feng has joined #openstack-nova | 15:46 | |
*** Sukhdev has joined #openstack-nova | 15:47 | |
openstackgerrit | sahid proposed openstack/nova: network: handle unauthorized exception from neutron https://review.openstack.org/312014 | 15:47 |
*** klkumar has quit IRC | 15:48 | |
*** irenab has joined #openstack-nova | 15:48 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Implementation of Libvirt Storage Pools https://review.openstack.org/314134 | 15:49 |
*** fragatina has joined #openstack-nova | 15:50 | |
*** iceyao has quit IRC | 15:51 | |
*** ptm__ has joined #openstack-nova | 15:52 | |
kashyap | mriedem: When you get a moment, mind poking a look at this (you've ACKed the Mitaka one)? Is that due to mixing Mock/Mox? -- https://review.openstack.org/#/c/314012/ | 15:52 |
danpb | jaypipes: could you see the comments here about os-vif release version https://review.openstack.org/#/c/312426 | 15:53 |
danpb | jaypipes: and decide who's right :-) | 15:53 |
*** fragatina has quit IRC | 15:53 | |
*** fragatin_ has joined #openstack-nova | 15:53 | |
jaypipes | danpb: yep, will look at that shortly. | 15:54 |
mriedem | kashyap: i actually tried doing that cherry pick myself last week and ran into the same issue, i wasn't able to easily sort it out and gave up on it | 15:54 |
*** jistr has joined #openstack-nova | 15:54 | |
*** ircuser-1 has joined #openstack-nova | 15:54 | |
kashyap | mriedem: Okay, if _you_ are hitting a block, then I should wind up and look through the telescope near me at the Sun / Mercury :-) | 15:54 |
* kashyap is "working from the observatory" | 15:55 | |
mriedem | kashyap: no, i just didn't have the time to dig into it | 15:55 |
kashyap | mriedem: No worries, I'll spend some time and look at it. | 15:55 |
*** ptm_away has quit IRC | 15:55 | |
*** shaohe_feng has quit IRC | 15:56 | |
*** shaohe_feng has joined #openstack-nova | 15:56 | |
*** armax has joined #openstack-nova | 15:56 | |
*** ramki has quit IRC | 15:56 | |
*** mlavalle has joined #openstack-nova | 15:56 | |
mlavalle | johnthetubaguy: ping | 15:57 |
*** davideagnello has quit IRC | 15:58 | |
*** mrkz has quit IRC | 15:58 | |
*** hshiina has joined #openstack-nova | 15:58 | |
johnthetubaguy | mlavalle: hi | 15:58 |
*** mrkz has joined #openstack-nova | 15:58 | |
mlavalle | johnthetubaguy: I have a question. For the refactoring of allocate_for_instance into the conductor, is this spec the only pre-requisite: https://review.openstack.org/#/c/300176/? | 15:59 |
johnthetubaguy | mlavalle: so my spec doesn't depend on the scheduler work at all | 16:00 |
johnthetubaguy | mlavalle: its largely just refactoring | 16:00 |
mlavalle | johnthetubaguy: that's actually very good news :-) | 16:00 |
johnthetubaguy | mlavalle: now making the routed network stuff work will depend on the spec you mention, I don't remember if thats the only one, its certainly the key one | 16:01 |
Yingxin | jaypipes: will resource tracker update the "reserved" fields of its compute node inventories? | 16:01 |
*** sridharg has quit IRC | 16:01 | |
*** tesseract has quit IRC | 16:01 | |
*** fragatin_ has quit IRC | 16:02 | |
mlavalle | johnthetubaguy: so, the way you envision this is that the refactoring will be done and then, on top of it, we will add the pieces needed to make it work with routed networks? | 16:02 |
johnthetubaguy | mlavalle: yes, that it | 16:03 |
johnthetubaguy | mlavalle: I was planning on working on the refactoring, and I was thinking you could tackle the next bit | 16:04 |
*** dedery has quit IRC | 16:04 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 16:04 |
mlavalle | johnthetubaguy: that sounds like a plan :-) | 16:04 |
johnthetubaguy | mlavalle: currently a bit confused with how ironic works after the refactoring, I think it should be fine, but need to do some double checking | 16:05 |
mlavalle | johnthetubaguy: as soon as you have anything up for review, let me know, so I can help | 16:05 |
*** rcernin has quit IRC | 16:06 | |
*** shaohe_feng has quit IRC | 16:06 | |
jaypipes | Yingxin: for some resource classes that it knows the reserved amount for, yes. For instance, the reserved_host_memory_mb configuration option indicates the reserved value for the compute node's RAM_MB inventory record will be updated by the resource tracker based on that configuration value. | 16:07 |
*** shaohe_feng has joined #openstack-nova | 16:07 | |
*** fragatina has joined #openstack-nova | 16:07 | |
mlavalle | johnthetubaguy: also, tomorrow's routed networks meeting is at 1500 UTC. In case you want to participate. I'll ping you | 16:08 |
*** vtech_ has quit IRC | 16:10 | |
*** unicell has quit IRC | 16:11 | |
openstackgerrit | Ronald Bradford proposed openstack/nova: [WIP] Complete method verification of os-networks https://review.openstack.org/314198 | 16:12 |
Yingxin | jaypipes: so, if I shutdown the compute node and update the "reserved" configuration to the value that will violate the existing allocation records, what will happen to this node? | 16:14 |
Yingxin | jaypipes: will the compute node fail to start, or force to update the "reserved" field? | 16:14 |
*** lpetrut has quit IRC | 16:15 | |
belliott | dansmith: so, service update doesn't appear to change in db on service restart - i'm not sure the best way to fix it since there's some special handling in the Service object with it as an immutable value | 16:15 |
belliott | dansmith: shouldn't service version update in DB to the latest SERVICE_VERSION on restart? | 16:16 |
*** paul-carlton1 has joined #openstack-nova | 16:16 | |
*** shaohe_feng has quit IRC | 16:16 | |
belliott | dansmith: i can put in some hokey tests where if SERVICE_VERSION != db_service['version'] then it should get updated on next save() | 16:17 |
*** shaohe_feng has joined #openstack-nova | 16:17 | |
*** cdent has joined #openstack-nova | 16:17 | |
*** palexster has quit IRC | 16:17 | |
*** markus_z has quit IRC | 16:18 | |
jaypipes | Yingxin: shutting down the nova-compute daemon has no impact on whether a call to, say, `openstack compute-node set inventory $CN_UUID --resource-class=DISK_GB --reserved=$NEW_VA` would return a failure due to the inventory's new total - reserved exceeding the existing allocations. | 16:18 |
jaypipes | Yingxin: the nova-compute daemon is stateless. the state is in the DB. | 16:19 |
*** ihrachys has joined #openstack-nova | 16:21 | |
*** tonytan4ever has quit IRC | 16:22 | |
*** andymaier has quit IRC | 16:23 | |
*** apoorvad has joined #openstack-nova | 16:24 | |
*** tonytan4ever has joined #openstack-nova | 16:24 | |
*** shaohe_feng has quit IRC | 16:26 | |
*** shaohe_feng has joined #openstack-nova | 16:27 | |
jaypipes | Yingxin: when you would call something like `openstack compute-node update inventory` you would not be speaking to the nova-compute daemon at all. | 16:28 |
Yingxin | jaypipes: I mean to modify "reserved_host_memory_mb" in nova.conf and *restart* the nova-compute service again. | 16:28 |
doffm | jaypipes: Is it going totally stateless? There won't be any update to the in-memory 'host_state_map'? | 16:28 |
doffm | Just wondering. | 16:28 |
*** mjura has quit IRC | 16:29 | |
*** rbridgeman has joined #openstack-nova | 16:29 | |
Yingxin | jaypipes: so nova itself will update the reserved field according to the new configuration? | 16:29 |
sdague | rbradfor: if there is no Response body something like - http://developer.openstack.org/api-ref/compute/#id33 is appropriate (under the DELETE servers resource) | 16:29 |
jaypipes | doffm: nova-compute doesn't have an in-memory host_state_map. That's the scheduler.. | 16:30 |
rbradfor | sdague, cool, exactly what I was asking, makes it very clear to reader. | 16:30 |
sdague | raj_singh: also look for the current open patches - https://review.openstack.org/#/q/project:openstack/nova+file:api-ref+status:open | 16:30 |
jroll | mriedem: are you doing the writeup on the ironic/nova session or would you like me to? | 16:30 |
doffm | jaypipes: Sorry, misunderstood conversation. | 16:30 |
mriedem | jroll: it's on the todo list, but feel free to write that up, you'd probably know the details better | 16:31 |
sdague | mriedem: right, I don't think we ever document 500 in the returns, as that's not an expected error | 16:31 |
jroll | mriedem: okay, I'll ping you when I do and you can expand if I've missed anything. thanks | 16:31 |
jaypipes | Yingxin: these are all brand new interfaces we're creating... right now reserved_host_memory_mb is set by the resource tracker (on init_compute_node() I think?) and written into the compute_nodes.reserved_host_memory_mb field. The only thing that the resource-providers stuff changes is moving that into the inventories table as the reserved amount for the RAM_MB resource class. | 16:31 |
*** rbridgeman_ has joined #openstack-nova | 16:35 | |
*** haukebruno has quit IRC | 16:36 | |
*** shaohe_feng has quit IRC | 16:37 | |
*** ccarmack1 has joined #openstack-nova | 16:37 | |
*** rcernin has joined #openstack-nova | 16:37 | |
Yingxin | jaypipes: OK, I'll review the actual implementations, and will understand what you say^ finally. | 16:37 |
Yingxin | jaypipes: thanks | 16:37 |
*** tonytan4ever has quit IRC | 16:37 | |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc https://review.openstack.org/314085 | 16:37 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: method verification and fixes for servers.inc https://review.openstack.org/313514 | 16:37 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: update parameter validation on servers https://review.openstack.org/313532 | 16:37 |
mriedem | sdague: what allows you to filter instances by host in the api? | 16:38 |
*** shaohe_feng has joined #openstack-nova | 16:38 | |
*** diogogmt has joined #openstack-nova | 16:38 | |
sdague | mriedem: it's in the base servers controller | 16:38 |
sdague | iirc | 16:38 |
sdague | let me get the link | 16:38 |
*** rbridgeman has quit IRC | 16:38 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: resource-providers: generic resource pools https://review.openstack.org/300176 | 16:39 |
*** ccarmack has quit IRC | 16:40 | |
sneti | Hi johnthetubaguy...need some info in getting started with Nova-api ref. For method verification, what I understand is we need to make sure that the methods are in correct order as mentioned in the spec. And also | 16:40 |
sneti | correct the error status codes. How do I check the error response codes from the code. I see only few exceptions under @expected_exceptions for each method. | 16:40 |
jaypipes | mriedem, Yingxin, bauzas, cdent, edleafe: ^^ OK, next rev up... | 16:41 |
cdent | jaypipes: feh, I was just in the middle... | 16:41 |
sdague | mriedem: oh, you know what, that was vesitigial and I just assumed it was right | 16:41 |
cdent | will transfer them over if still relevant | 16:41 |
mriedem | sdague: yes! | 16:41 |
mriedem | sdague: i think i picked the very worst series to start reviewing for api-ref today | 16:41 |
mriedem | server request parameter validation | 16:42 |
mriedem | sdague: don't update https://review.openstack.org/#/c/313532 yet i'm still going through it | 16:42 |
sdague | yeh, servers is wonky | 16:42 |
sdague | mriedem: sure, it did get rebased because I fixed the one underneath | 16:43 |
*** unicell has joined #openstack-nova | 16:43 | |
sdague | mriedem: https://github.com/openstack/nova/blob/1801a48cc6b529272c81687f1ffd41753e5c3e9a/nova/api/openstack/compute/servers.py#L1137 is where I thought I saw it | 16:44 |
*** yamahata has joined #openstack-nova | 16:44 | |
sdague | but, again, un-spaghettifying servers.py in your head, is a thing | 16:44 |
*** palexster has joined #openstack-nova | 16:44 | |
*** irenab has quit IRC | 16:45 | |
*** moshele has quit IRC | 16:45 | |
*** david-lyle_ is now known as david-lyle | 16:45 | |
johnthetubaguy | sneti: sdague is a good person to ask about that, there are quite a few patches up to see what error codes they are generally including (the expected 4xx ones basically) | 16:46 |
mriedem | sneakiness, | 16:46 |
*** irenab has joined #openstack-nova | 16:46 | |
*** irenab has quit IRC | 16:46 | |
mriedem | i thought block_device_mapping_v2 in the request was wrong, but the bdm extension intercepts bdm_v2 and puts block_device_mapping in the server create request dict | 16:46 |
*** shaohe_feng has quit IRC | 16:47 | |
johnthetubaguy | sneti: this is the topic I was meaning: https://review.openstack.org/#/q/topic:bp/api-ref-in-rst+status:open | 16:47 |
sdague | sneti: this is typically expected_errors + 401 & 403 + 404 (if the resource supports limit / marker). That's probably about as close as we are going to get at this stage | 16:48 |
*** shaohe_feng has joined #openstack-nova | 16:48 | |
*** irenab has joined #openstack-nova | 16:49 | |
*** ijw has joined #openstack-nova | 16:49 | |
*** derekh has quit IRC | 16:50 | |
sneti | sdague, so 401&403 should be added for each method and 404 only if the resource supports limit | 16:51 |
*** zenoway has joined #openstack-nova | 16:51 | |
*** earlephilhower has joined #openstack-nova | 16:52 | |
*** vtech has joined #openstack-nova | 16:54 | |
*** ihrachys has quit IRC | 16:54 | |
*** unicell has quit IRC | 16:54 | |
johnthetubaguy | sdague: I was just digging into the floating-ip-pools stuff, I don't think we give a target, so I guess there is no "owner" concept for that API? https://review.openstack.org/#/c/311070/2/api-ref/source/os-floating-ip-pools.inc@19 or am I missing something here? | 16:55 |
*** salv-orlando has joined #openstack-nova | 16:55 | |
*** ijw has quit IRC | 16:56 | |
*** yassou has quit IRC | 16:56 | |
*** ihrachys has joined #openstack-nova | 16:56 | |
*** penick has joined #openstack-nova | 16:57 | |
sdague | johnthetubaguy: there is one implicitly in tenant_id the token | 16:57 |
*** shaohe_feng has quit IRC | 16:57 | |
sdague | that's what that is trying to express | 16:57 |
sdague | wordsmithing might be appropriate | 16:58 |
johnthetubaguy | sdague: but doesn't it need to compare that to something? | 16:58 |
*** shaohe_feng has joined #openstack-nova | 16:58 | |
*** jaosorior has quit IRC | 16:58 | |
*** unicell has joined #openstack-nova | 16:59 | |
*** sdake has quit IRC | 17:00 | |
*** zenoway has quit IRC | 17:00 | |
*** zenoway has joined #openstack-nova | 17:00 | |
sdague | johnthetubaguy: yep, you are right, it has really confusing policy | 17:01 |
sdague | https://github.com/openstack/nova/blob/1801a48cc6b529272c81687f1ffd41753e5c3e9a/etc/nova/policy.json#L221 | 17:01 |
*** sdake has joined #openstack-nova | 17:01 | |
johnthetubaguy | sdague: +1 its a bit missleading | 17:01 |
johnthetubaguy | sdague: I kinda guessed users want to list the pools so they can request a floating ip from the correct one | 17:02 |
sdague | rigt | 17:02 |
sdague | right | 17:02 |
*** jistr has quit IRC | 17:02 | |
*** gcb has quit IRC | 17:04 | |
*** ijw has joined #openstack-nova | 17:05 | |
*** sahid has quit IRC | 17:05 | |
*** shaohe_feng has quit IRC | 17:07 | |
*** omnipresent has joined #openstack-nova | 17:08 | |
*** omnipresent has quit IRC | 17:08 | |
*** daemontool__ has joined #openstack-nova | 17:09 | |
*** ijw has quit IRC | 17:10 | |
*** zenoway has quit IRC | 17:11 | |
cdent | there ya go jaypipes | 17:11 |
*** jdurgin1 has quit IRC | 17:11 | |
*** whenry has quit IRC | 17:11 | |
*** whenry_ has quit IRC | 17:11 | |
*** shaohe_feng has joined #openstack-nova | 17:12 | |
dansmith | belliott: sorry, monday morning bring hours of calls for me | 17:13 |
dansmith | belliott: what is it you're seeing exactly? | 17:13 |
*** thorst_ has quit IRC | 17:14 | |
*** thorst_ has joined #openstack-nova | 17:15 | |
*** paul-carlton1 has quit IRC | 17:15 | |
openstackgerrit | Ronald Bradford proposed openstack/nova: Complete method verification of os-tenant-networks https://review.openstack.org/314139 | 17:16 |
belliott | dansmith: so if you update a compute node to new code (with a new SERVICE_VERSION), it never updates the version column in the D B | 17:16 |
*** roeyc has joined #openstack-nova | 17:17 | |
dansmith | belliott: um, really? have you tracked down why? | 17:17 |
*** thorst__ has joined #openstack-nova | 17:17 | |
*** shaohe_feng has quit IRC | 17:18 | |
belliott | dansmith: i'll throw a patch up | 17:18 |
*** shaohe_feng has joined #openstack-nova | 17:18 | |
*** sdake_ has joined #openstack-nova | 17:18 | |
dansmith | okay | 17:19 |
belliott | dansmith: save it set to never update it anyway https://github.com/openstack/nova/blob/master/nova/objects/service.py#L294 | 17:19 |
*** thorst_ has quit IRC | 17:19 | |
*** zenoway has joined #openstack-nova | 17:20 | |
*** lpetrut has joined #openstack-nova | 17:21 | |
dansmith | belliott: right, but on service startup and every minute we update the service record, right? that was the goal there | 17:21 |
*** sdake has quit IRC | 17:21 | |
*** thorst__ has quit IRC | 17:22 | |
*** sfinucan has quit IRC | 17:22 | |
belliott | dansmith: when the record is loaded from DB it uses the DB value, not the current constant from the code | 17:22 |
dansmith | hrm, I was sure we validated all of this when we landed it, but it's been a while | 17:23 |
*** zenoway has quit IRC | 17:25 | |
*** roeyc has quit IRC | 17:25 | |
*** sdake_ has quit IRC | 17:25 | |
belliott | dansmith: what does this do https://github.com/openstack/nova/blob/master/nova/objects/service.py#L185 vs just saying self.version = db_service[key] | 17:26 |
*** paul-carlton1 has joined #openstack-nova | 17:26 | |
belliott | sorry, service.version = db_service[key] | 17:27 |
dansmith | belliott: bypasses the readonly-ness | 17:27 |
*** sdake has joined #openstack-nova | 17:27 | |
*** lpetrut has quit IRC | 17:27 | |
belliott | dansmith: i don't see a read-only flag on the field | 17:27 |
*** shaohe_feng has quit IRC | 17:28 | |
*** thorst_ has joined #openstack-nova | 17:28 | |
*** shaohe_feng has joined #openstack-nova | 17:28 | |
dansmith | belliott: heh, sure enough | 17:29 |
belliott | ok i thought i was short on coffee | 17:30 |
dansmith | belliott: yeah, wasn't in the landed patch either.. might have come out at some point and that bit remained | 17:30 |
*** gagehugo has quit IRC | 17:30 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Implementation of Libvirt Storage Pools https://review.openstack.org/314134 | 17:31 |
*** davideagnello has joined #openstack-nova | 17:32 | |
*** ijw has joined #openstack-nova | 17:32 | |
*** ijw has quit IRC | 17:33 | |
*** ijw has joined #openstack-nova | 17:34 | |
*** roeyc has joined #openstack-nova | 17:35 | |
*** paul-carlton1 has quit IRC | 17:35 | |
*** ptm__ has quit IRC | 17:36 | |
*** thorst_ has quit IRC | 17:36 | |
*** vilobhmm11 has joined #openstack-nova | 17:36 | |
openstackgerrit | Chris Friesen proposed openstack/nova-specs: Improve Scheduler Logging https://review.openstack.org/306647 | 17:37 |
rbradfor | sdague, I need a tenant_id that's in the body, not path. any suggestions for best name to add to in parameters.yaml? | 17:37 |
cfriesen | ^ updated as per bauzas' comments | 17:37 |
*** thorst_ has joined #openstack-nova | 17:37 | |
*** shaohe_feng has quit IRC | 17:38 | |
*** shaohe_feng has joined #openstack-nova | 17:39 | |
*** ijw has quit IRC | 17:39 | |
*** thorst_ has quit IRC | 17:42 | |
*** lakshmiS has joined #openstack-nova | 17:42 | |
*** davideagnello has quit IRC | 17:43 | |
*** thorst_ has joined #openstack-nova | 17:44 | |
*** avula has joined #openstack-nova | 17:45 | |
*** harlowja has joined #openstack-nova | 17:48 | |
*** thorst_ has quit IRC | 17:48 | |
*** shaohe_feng has quit IRC | 17:48 | |
*** syjulian has joined #openstack-nova | 17:49 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add online migration to move keypairs from main to API database https://review.openstack.org/313664 | 17:49 |
openstackgerrit | Dan Smith proposed openstack/nova: Add online migration to store keypairs with instances https://review.openstack.org/313060 | 17:49 |
*** shaohe_feng has joined #openstack-nova | 17:49 | |
dansmith | jaypipes: thanks for catching that thing in the second to last patch.. just got it fixed | 17:49 |
*** Sukhdev has quit IRC | 17:50 | |
*** thorst_ has joined #openstack-nova | 17:50 | |
jaypipes | dansmith: will re-review shortly after reviewing all of cdent's patches in progress. | 17:50 |
*** vilobhmm111 has joined #openstack-nova | 17:52 | |
*** vilobhmm11 has quit IRC | 17:53 | |
*** vilobhmm111 has quit IRC | 17:53 | |
*** vilobhmm11 has joined #openstack-nova | 17:54 | |
*** PaulMurray has joined #openstack-nova | 17:54 | |
*** thorst_ has quit IRC | 17:55 | |
*** zenoway has joined #openstack-nova | 17:56 | |
*** penick has quit IRC | 17:56 | |
*** Sukhdev has joined #openstack-nova | 17:57 | |
*** thorst_ has joined #openstack-nova | 17:57 | |
*** davideagnello has joined #openstack-nova | 17:58 | |
*** sdake_ has joined #openstack-nova | 17:58 | |
*** shaohe_feng has quit IRC | 17:59 | |
*** penick has joined #openstack-nova | 18:00 | |
*** zenoway has quit IRC | 18:00 | |
*** sdake has quit IRC | 18:01 | |
mriedem | sdague: i have to move on from https://review.openstack.org/#/c/313532/ | 18:01 |
mriedem | sdague: the various extensions and microversions make that one never ending | 18:01 |
jaypipes | cdent: in response to your comment about adding "more REST endpoints"... | 18:02 |
*** shaohe_feng has joined #openstack-nova | 18:02 | |
*** penick has quit IRC | 18:02 | |
jaypipes | cdent: I don't see a problem with the additional fine-grained endpoints in REST API. I took out the ability for PUT /resource-pools/{uuid} to be able to update inventory at all (only the name attribute of the resource pool may be updated with the PUT /resource-pools/{uuid} call now)' | 18:03 |
jaypipes | cdent: also, w.r.t the foreign key constraint addition, that's easy: we can do that when migrating the tables to the API database ;) | 18:03 |
mriedem | gmann: sdague: couldn't/shouldn't we add a microversion to call the more standardized version of diagnostics now? https://github.com/openstack/nova/blob/7529b94f4a0be17fb3988362619f83b404ccad86/nova/api/openstack/compute/server_diagnostics.py#L38-L44 | 18:03 |
*** zenoway has joined #openstack-nova | 18:03 | |
*** lucasagomes is now known as lucas-dinner | 18:04 | |
*** thorst_ has quit IRC | 18:04 | |
jaypipes | cdent: why do you say that "this asymmetry is weird"? | 18:06 |
*** shaohe_feng has quit IRC | 18:09 | |
*** hshiina has quit IRC | 18:10 | |
*** shaohe_feng has joined #openstack-nova | 18:10 | |
*** zenoway has quit IRC | 18:10 | |
*** danpb has quit IRC | 18:12 | |
*** mvk has quit IRC | 18:12 | |
*** jichen has joined #openstack-nova | 18:13 | |
*** ducttape_ has quit IRC | 18:13 | |
*** zenoway has joined #openstack-nova | 18:15 | |
cdent | jaypipes: sorry, was making dinner (now eaten, was tasty) | 18:15 |
cdent | it's pretty much what I said there: you post and inventories and return a resource_pool, that's asymmentrical | 18:15 |
*** sdake_ is now known as sdake | 18:15 | |
cdent | on the fk thing, yeah, nbd, was just confirming | 18:16 |
cdent | jaypipes: as we've discussed before, doing a partial update on a PUT ("only the name attribute of the resource pool may be updated with the PUT /resource-pools/{uuid} call now") is bad grammar | 18:16 |
*** penick has joined #openstack-nova | 18:17 | |
cdent | so yeah, my reaction to your changes it largely dependent on which hat I'm wearing. If it's pedantic http guy, I'm kinda meh. Various other hats, yeah, it's fine | 18:17 |
jaypipes | cdent: why is updating only the name attribute (which is the only attribute of the resource pool entity itself) bad grammar? | 18:18 |
openstackgerrit | dane-fichter proposed openstack/nova: Add image cache verification https://review.openstack.org/314222 | 18:19 |
*** rena9067 has quit IRC | 18:19 | |
cdent | because the representation your using elsewhere server->client is a bunch of other stuff | 18:19 |
cdent | damnit: you're | 18:19 |
*** shaohe_feng has quit IRC | 18:19 | |
*** shaohe_feng has joined #openstack-nova | 18:20 | |
cdent | so there's a lot of ambiguity about the state | 18:20 |
cdent | als you say "I took out the ability for PUT /resource-pools/{uuid} to be able to update inventory at all" but that doesn't appear to be the case in the spec | 18:21 |
edleafe | cdent: isn't a partial PUT supposed to be a PATCH instead? | 18:22 |
cdent | jaypipes: basically if the representation you have for the request at line 484 is correct, then strictly speaking a form of that is what should be PUT | 18:23 |
jaypipes | cdent: in the spec, for PUT /resource-pools/{uuid}, I messed up... | 18:24 |
jaypipes | cdent: fixing, sorry about this. | 18:24 |
cdent | edleafe: yes, but there's been a lot of controversy on that because the format of a PATCH is arguable | 18:24 |
jaypipes | ggVG | 18:24 |
jaypipes | oh ffs | 18:24 |
cdent | jaypipes: I don't think it's a problem: it's making us have this conversation, which is good | 18:24 |
edleafe | jaypipes: heh, I understood that instantly | 18:24 |
*** sudipto has quit IRC | 18:25 | |
*** ducttape_ has joined #openstack-nova | 18:26 | |
*** sdake has quit IRC | 18:27 | |
mriedem | alaski: policy question for you, i.e. https://github.com/openstack/nova/blob/7529b94f4a0be17fb3988362619f83b404ccad86/etc/nova/policy.json#L25 | 18:28 |
mriedem | the compute api has a policy check, which is admin or owner | 18:28 |
mriedem | but the rest api policy for diagnostics is admin only by default | 18:28 |
cdent | jaypipes: I'm going to go take a long walk and will come back to review again. In the interim if you can think about which hat you want me to wear in regard to this and tell me, I can do that. I can wear several if that's useful. | 18:28 |
cdent | biab | 18:28 |
mriedem | why do we even have the separate check in the compute api code if the rest api has already enforced the policy? | 18:28 |
alaski | mriedem: legacy v2 cruft | 18:29 |
alaski | for v2.1 all policy checks were moved into the rest api layer | 18:29 |
*** ijw has joined #openstack-nova | 18:29 | |
mriedem | thank god | 18:29 |
mriedem | ok | 18:29 |
alaski | with the removal of v2 code a lot of compute_api checks can probably go away | 18:29 |
*** salv-orlando has quit IRC | 18:29 | |
*** shaohe_feng has quit IRC | 18:29 | |
kashyap | diana_clarke: I'm on a train & the network is spotty, wonder if you have time today to take a look at this 'final nail in the coffin' of that bug we've been working on, this one is for Liberty -- https://review.openstack.org/#/c/314012/ | 18:30 |
*** shaohe_feng has joined #openstack-nova | 18:30 | |
kashyap | diana_clarke: If you're occupied with other stuff, feel free to disregard me, I'll look into it first thing in the morning. | 18:30 |
sdague | mriedem: yes, we should | 18:30 |
sdague | rbradfor: I put a tenant_id_body into one of my servers patches, that's probably reusable here | 18:31 |
alaski | mriedem: those policy checks are gated on http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n167, which supposedly is only False for v2 | 18:32 |
rbradfor | sdague, I guess it hasn't merged yet. | 18:32 |
rbradfor | I'll look around. | 18:32 |
kashyap | diana_clarke: I'm about to upload a new change with some tweaks, wait for the unit tests for this to pass before you consider spending your time on it. | 18:32 |
sdague | rbradfor: no it's https://review.openstack.org/#/c/313532 | 18:32 |
alaski | oomichi alex_xu something to consider, with the removal of v2 the compute/api.py policy checks can go away afaik | 18:32 |
sdague | maybe stack on top of that | 18:32 |
*** openstackgerrit has quit IRC | 18:33 | |
*** openstackgerrit has joined #openstack-nova | 18:33 | |
mriedem | alaski: yeah, for v2.1 the rest extension creates the compute api object as: self.compute_api = compute.API(skip_policy_check=True) | 18:34 |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: resource-providers: generic resource pools https://review.openstack.org/300176 | 18:34 |
mriedem | sdague: should maybe break this out of the dep chain so we can land it by itself https://review.openstack.org/#/c/314085/ | 18:36 |
rbradfor | sdague, thanks | 18:36 |
*** PaulMurray has quit IRC | 18:36 | |
openstackgerrit | Robert Ellis proposed openstack/nova: Changed 202 for lock/unlock return code to 200. This addresses bug 1449811. 409 was not addressed due to the compute node is already in that state so no corrective action is required. 404 is already covered. https://review.openstack.org/314228 | 18:37 |
openstack | bug 1449811 in OpenStack Compute (nova) "nova lock/unlock api return code is not accurate" [Wishlist,Confirmed] https://launchpad.net/bugs/1449811 - Assigned to Robert Ellis (bob-ellis42) | 18:37 |
*** zenoway has quit IRC | 18:37 | |
*** browne has joined #openstack-nova | 18:38 | |
*** thorst_ has joined #openstack-nova | 18:39 | |
sdague | mriedem: maybe, it's pretty minor though | 18:39 |
*** shaohe_feng has quit IRC | 18:40 | |
*** prateek has joined #openstack-nova | 18:40 | |
*** lpetrut has joined #openstack-nova | 18:40 | |
*** shaohe_feng has joined #openstack-nova | 18:41 | |
sdague | mriedem: thanks for the deep review on the servers parameters, let me go fix those up | 18:41 |
*** browne has quit IRC | 18:41 | |
*** ozialien10 has quit IRC | 18:43 | |
*** ozialien10 has joined #openstack-nova | 18:44 | |
*** ozialien10 has quit IRC | 18:44 | |
*** ozialien10 has joined #openstack-nova | 18:45 | |
*** markmc has quit IRC | 18:46 | |
*** ajo has quit IRC | 18:47 | |
*** migi has quit IRC | 18:47 | |
*** dmellado has quit IRC | 18:47 | |
*** rook-lap has quit IRC | 18:47 | |
*** mtanino has quit IRC | 18:47 | |
openstackgerrit | Brian Elliott proposed openstack/nova: Fix service version to update the DB https://review.openstack.org/314230 | 18:48 |
*** sdake has joined #openstack-nova | 18:49 | |
*** neophy has joined #openstack-nova | 18:49 | |
*** shaohe_feng has quit IRC | 18:50 | |
*** shaohe_feng has joined #openstack-nova | 18:51 | |
mriedem | sdague: jichen: hmm, note the body isn't even used here https://github.com/openstack/nova/blob/7529b94f4a0be17fb3988362619f83b404ccad86/nova/api/openstack/compute/admin_actions.py#L59 | 18:51 |
*** syjulian has quit IRC | 18:51 | |
belliott | dansmith: https://review.openstack.org/#/c/314230/ | 18:52 |
jichen | mriedem: yeah, indeed | 18:52 |
mriedem | what a great api | 18:52 |
mriedem | it takes the nw info cache from the instance and injects it back into itself | 18:53 |
sdague | mriedem: it's an action | 18:54 |
sdague | the body is used to just tell it what action happens | 18:54 |
sdague | I do kind of wonder why stuff like that was added | 18:55 |
dansmith | belliott: commented | 18:55 |
*** cloudnul- has joined #openstack-nova | 18:55 | |
mriedem | sdague: yeah, ok, sure. but agree, wtf is this used for? | 18:56 |
*** baoli has quit IRC | 18:56 | |
sdague | mriedem: right, that's a good question | 18:56 |
*** jlanoux has quit IRC | 18:56 | |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc https://review.openstack.org/314085 | 18:57 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: update parameter validation on servers https://review.openstack.org/313532 | 18:57 |
*** claudiub has joined #openstack-nova | 18:57 | |
sdague | mriedem: ok, I think I captured all your feedback in the base patch there | 18:57 |
*** cloudnul- has quit IRC | 18:57 | |
*** ijw has quit IRC | 18:58 | |
openstackgerrit | Robert Ellis proposed openstack/nova: Removed extra white spaces and rebased. https://review.openstack.org/314237 | 18:59 |
belliott | dansmith: thanks | 18:59 |
mriedem | sdague: is this the same thing? http://docs.openstack.org/developer/nova/support-matrix.html#guest_setup_inject_networking | 18:59 |
*** ijw has joined #openstack-nova | 18:59 | |
dansmith | belliott: I just went to make _sure_ we tag the bug for backports, but see you did already .. thanks :) | 18:59 |
belliott | dansmith: heh :) | 19:00 |
*** shaohe_feng has quit IRC | 19:00 | |
sdague | mriedem: https://review.openstack.org/#/c/3020/ is about as far as git log -S gets back to, it's a little harder to trace after taht | 19:01 |
*** shaohe_feng has joined #openstack-nova | 19:01 | |
mriedem | crazy ass rax | 19:02 |
*** pwnall has quit IRC | 19:03 | |
openstackgerrit | Brian Elliott proposed openstack/nova: Fix service version to update the DB https://review.openstack.org/314230 | 19:03 |
*** gszasz has quit IRC | 19:04 | |
sdague | mriedem: yeh, it's that the same thing | 19:06 |
*** sdake_ has joined #openstack-nova | 19:06 | |
*** sdake has quit IRC | 19:07 | |
*** Sukhdev has quit IRC | 19:08 | |
dansmith | belliott: I predict I will +2 patch set 3 :P | 19:09 |
*** lpetrut has quit IRC | 19:10 | |
*** shaohe_feng has quit IRC | 19:10 | |
openstackgerrit | Robert Ellis proposed openstack/nova: Rebasing again. https://review.openstack.org/314241 | 19:12 |
belliott | dansmith: hah | 19:13 |
*** mdrabe_ has joined #openstack-nova | 19:13 | |
*** mdrabe has quit IRC | 19:13 | |
*** shaohe_feng has joined #openstack-nova | 19:13 | |
mriedem | reset-network, another fun one that only the xen driver implements | 19:14 |
*** Sukhdev has joined #openstack-nova | 19:15 | |
*** kfarr has joined #openstack-nova | 19:15 | |
*** ihrachys has quit IRC | 19:15 | |
mriedem | sdague: what do you think about pointing out in rest api doc descriptions things that are only implemented by a single driver, like resetNetwork? | 19:18 |
sdague | mriedem: we should probably call out that it only works with xenserver backed hypervisors and should not be relied upon | 19:19 |
dansmith | mriedem: is that different from (should-be-)deprecated ? | 19:19 |
mriedem | dansmith: i think it means it's a candidate for deprecation | 19:20 |
mriedem | i don't see anything in the rackspace api reference for resetNetwork either | 19:20 |
sdague | yeh, I'd agree it's a candidate for deprecation | 19:20 |
dansmith | right, so I just wonder if it makes sense to categorize it as that and not specifically "single-virt" | 19:20 |
*** shaohe_feng has quit IRC | 19:21 | |
sdague | maybe, I think during this documentation exercise though it's ok to just call it out, then look at all the things we called out when we look at the deprecations | 19:21 |
mriedem | yeah maybe, i need to read sdague's spec on api deprecations again | 19:21 |
sdague | and make sure as a whole we drop them | 19:21 |
sdague | mriedem: I only did the proxies | 19:21 |
mriedem | ah right | 19:21 |
*** shaohe_feng has joined #openstack-nova | 19:21 | |
dansmith | we probably have other single-virt apis that are forward-looking instead of "things we really shouldn't have done" | 19:21 |
sdague | dansmith: right | 19:22 |
sdague | but I think we'll be in a better possition to evaluate all of those once we call them all out | 19:22 |
mriedem | also, | 19:23 |
mriedem | os-resetState shouldn't be a 202 | 19:23 |
*** prateek has quit IRC | 19:23 | |
mriedem | it updates the db from the rest api | 19:25 |
mriedem | and doesn't return anything, so 204 | 19:25 |
mriedem | cdent is rubbing off on me here | 19:25 |
*** corey_ has quit IRC | 19:25 | |
dansmith | belliott: if you want I can just fix in the online editor and then +2, I just don't want to race with anything you're doing | 19:28 |
belliott | dansmith: actually that's not enough - update_service_ref is only called from WSGIService.start(), not Service.start() | 19:29 |
dansmith | belliott: really? | 19:29 |
belliott | dansmith: that's what it looks like :) | 19:29 |
sdague | mriedem: yeh, the success codes are all over the place | 19:29 |
mriedem | sdague: i opened a bug for that one, but will need to batch those up into a single microversion, i feel like someone was already doing something like that at one point | 19:30 |
belliott | dansmith: i don't actually think update_service_ref works | 19:30 |
dansmith | belliott: ah, because we're expecting to run the periodic I think | 19:30 |
belliott | dansmith: hmmm | 19:31 |
*** shaohe_feng has quit IRC | 19:31 | |
dansmith | belliott: definitely works for the api server: http://logs.openstack.org/64/313664/3/check/gate-grenade-dsvm-multinode/d881986/logs/new/screen-n-api.txt.gz#_2016-05-09_18_30_13_669 | 19:32 |
dansmith | belliott: so I'd think we'd just need similar behavior either in the periodic or on startup of the base service | 19:32 |
*** shaohe_feng has joined #openstack-nova | 19:32 | |
belliott | dansmith: nvm it probably works i've got a hacked up local copy | 19:32 |
belliott | dansmith: yeah copy that | 19:33 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc https://review.openstack.org/314085 | 19:33 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: update parameter validation on servers https://review.openstack.org/313532 | 19:33 |
sdague | jichen: updated based on your comments, good catch on the name | 19:33 |
sdague | I messed that up when I remerged the updates around security group | 19:33 |
*** roeyc has quit IRC | 19:35 | |
*** mspreitz has quit IRC | 19:36 | |
belliott | dansmith: i like saving it explicitly so i added a call | 19:37 |
openstackgerrit | Brian Elliott proposed openstack/nova: Fix service version to update the DB https://review.openstack.org/314230 | 19:37 |
belliott | dansmith: instead of waiting on periodic | 19:37 |
belliott | dansmith: doesn't the periodic solution assume you use the db driver for servicegroup? | 19:37 |
dansmith | belliott: no | 19:38 |
jichen | sdague: ok, thanks, will take another look | 19:38 |
dansmith | belliott: but agreed, it's not going to change at runtime anyway, so no need to do it on periodic | 19:38 |
*** salv-orlando has joined #openstack-nova | 19:38 | |
belliott | dansmith: it is at least consistent with the api service now | 19:38 |
mriedem | rbradfor: looks like we need to update the policy descriptions for os-tenant-networks https://review.openstack.org/#/c/314139/ | 19:39 |
mriedem | that's probably just old copy/paste, but the resource is networks, not servers | 19:40 |
rbradfor | mriedem, will do, thanks. | 19:41 |
mriedem | after half a day of reviewing api-ref, i think we should just give up and delete it all :) the api is henceforth for the adventurous and strong of will | 19:41 |
*** shaohe_feng has quit IRC | 19:41 | |
rbradfor | mriedem, but I have a list of questions and improvements in testing nova, should we not put it to a vote!! | 19:41 |
*** lpetrut has joined #openstack-nova | 19:42 | |
*** shaohe_feng has joined #openstack-nova | 19:44 | |
*** baoli has joined #openstack-nova | 19:44 | |
*** zenoway has joined #openstack-nova | 19:46 | |
*** baoli has quit IRC | 19:47 | |
*** baoli has joined #openstack-nova | 19:47 | |
*** Sukhdev has quit IRC | 19:47 | |
dansmith | belliott: we're just hitting the database twice for no reason now, right? | 19:49 |
*** tonytan4ever has joined #openstack-nova | 19:49 | |
dansmith | belliott: I think a small change will collapse it back to one and still do the right thing | 19:49 |
openstackgerrit | Ronald Bradford proposed openstack/nova: [WIP] Complete method verification of os-security-groups https://review.openstack.org/314255 | 19:50 |
*** tonytan_brb has joined #openstack-nova | 19:51 | |
*** shaohe_feng has quit IRC | 19:51 | |
sdague | mriedem: that's good motivation to deprecate some big chuncks of it, to get it within working memory | 19:52 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: perform all 4 phases of verification for action console output https://review.openstack.org/314257 | 19:52 |
*** shaohe_feng has joined #openstack-nova | 19:52 | |
*** omnipresent has joined #openstack-nova | 19:53 | |
sdague | also, git worktree add is my new best friend for doing a number of active bits in parallel | 19:53 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: perform all 4 phases of verification for action console output https://review.openstack.org/314257 | 19:54 |
*** ctrath has quit IRC | 19:54 | |
*** tonytan4ever has quit IRC | 19:54 | |
*** zenoway has quit IRC | 19:55 | |
mriedem | so policy on os-tenant-networks:create doesn't exist, i guess that just means anyone can create a tenant network | 19:56 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc https://review.openstack.org/314085 | 19:56 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: update parameter validation on servers https://review.openstack.org/313532 | 19:56 |
sdague | I thought the fall back was admin_or_owner | 19:56 |
*** zenoway has joined #openstack-nova | 19:57 | |
mriedem | "network:create": "rule:admin_or_owner", | 19:58 |
mriedem | it is, jichen was just pointing out, how does owner work for a thing that doesn't exist yet | 19:58 |
sdague | https://github.com/openstack/nova/blob/1801a48cc6b529272c81687f1ffd41753e5c3e9a/etc/nova/policy.json#L4 | 19:58 |
sdague | mriedem: right, it means it's really just is_admin | 19:58 |
*** ijw has quit IRC | 20:00 | |
*** ijw has joined #openstack-nova | 20:00 | |
*** omnipresent has quit IRC | 20:01 | |
*** shaohe_feng has quit IRC | 20:02 | |
openstackgerrit | Ronald Bradford proposed openstack/nova: Complete method verification of os-security-groups https://review.openstack.org/314255 | 20:02 |
*** shaohe_feng has joined #openstack-nova | 20:02 | |
*** thorst_ has quit IRC | 20:03 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/api directory (1) https://review.openstack.org/309192 | 20:04 |
*** fragatina has quit IRC | 20:04 | |
*** thorst_ has joined #openstack-nova | 20:04 | |
*** d34dh0r53 is now known as th3r34ld0n4ld7ru | 20:05 | |
sdague | jichen: regarding one of your comments, there is a whole missing server-tags.inc file in the api-ref. There was never any api documentation included with that resource in the old site | 20:05 |
sdague | mriedem: hit the last items of yours from - https://review.openstack.org/#/c/313532/ | 20:05 |
sdague | hopefully that's mergable now | 20:05 |
*** th3r34ld0n4ld7ru is now known as therealmajorhayd | 20:05 | |
*** thorst_ has quit IRC | 20:06 | |
*** lucas-dinner has quit IRC | 20:06 | |
*** thorst_ has joined #openstack-nova | 20:06 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: trivial: removed unused networks var from os-tenant-networks:create https://review.openstack.org/314261 | 20:06 |
*** therealmajorhayd is now known as d34dh0r53 | 20:07 | |
jichen | sdague: ok, it's newly added API so guess not old api doc for it | 20:07 |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/api directory (2) https://review.openstack.org/309194 | 20:07 |
mriedem | sdague: what about the other missing create server parameters i pointed out? | 20:07 |
mriedem | adminPass and the multiple-create ones? | 20:07 |
*** mdrabe_ has quit IRC | 20:07 | |
mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L545 | 20:08 |
mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/multiple_create.py#L46 | 20:08 |
sdague | mriedem: multiple create is documented separately | 20:10 |
*** pwnall has joined #openstack-nova | 20:10 | |
mriedem | sigh | 20:10 |
*** Daisy has joined #openstack-nova | 20:10 | |
mriedem | ok, adminPass then :) | 20:10 |
sdague | admin pass I lost when I fixed one of the other issues | 20:10 |
sdague | adding it back now | 20:10 |
mriedem | some things being in the server create request docs and some in extension specific docs is like a kick in the balls | 20:10 |
*** Daisy_ has joined #openstack-nova | 20:11 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/api directory (3) https://review.openstack.org/309196 | 20:11 |
mriedem | funny when it happens to someone else, but not me | 20:11 |
sdague | yeh, multiple create is different enough it's documented separately, which makes some sense | 20:11 |
mriedem | sure | 20:11 |
mriedem | long-term, when we drop extensions, are we going to munge all of these together? | 20:11 |
*** shaohe_feng has quit IRC | 20:12 | |
*** shaohe_feng has joined #openstack-nova | 20:13 | |
*** baoli has quit IRC | 20:13 | |
sdague | multiple create... probably | 20:13 |
*** baoli has joined #openstack-nova | 20:14 | |
*** mdrabe has joined #openstack-nova | 20:14 | |
sdague | we'd merge the back end code for a lot of things, which should make stuff more clear | 20:14 |
*** vilobhmm111 has joined #openstack-nova | 20:14 | |
*** baoli has quit IRC | 20:14 | |
*** vilobhmm11 has quit IRC | 20:14 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/api directory (4) https://review.openstack.org/309198 | 20:15 |
*** Daisy has quit IRC | 20:15 | |
*** baoli has joined #openstack-nova | 20:15 | |
*** rcernin has quit IRC | 20:15 | |
*** Daisy_ has quit IRC | 20:16 | |
openstackgerrit | Ronald Bradford proposed openstack/nova: Complete method verification of os-security-group-rules https://review.openstack.org/314264 | 20:16 |
*** lucasagomes has joined #openstack-nova | 20:16 | |
*** lucasagomes is now known as lucas-dinner | 20:17 | |
*** pwnall has quit IRC | 20:18 | |
*** baoli has quit IRC | 20:21 | |
openstackgerrit | Robert Ellis proposed openstack/nova: Changed 202 for lock/unlock return code to 200. This addresses bug 1449811. 409 return code was not addressed as the compute node is already in that state so no corrective action is required. 404 is already covered by existing code. https://review.openstack.org/314267 | 20:21 |
openstack | bug 1449811 in OpenStack Compute (nova) "nova lock/unlock api return code is not accurate" [Wishlist,Confirmed] https://launchpad.net/bugs/1449811 - Assigned to Robert Ellis (bob-ellis42) | 20:21 |
*** tonytan4ever has joined #openstack-nova | 20:21 | |
*** shaohe_feng has quit IRC | 20:22 | |
openstackgerrit | Ronald Bradford proposed openstack/nova: Complete method verification of os-tenant-networks https://review.openstack.org/314139 | 20:23 |
*** shaohe_feng has joined #openstack-nova | 20:23 | |
*** fragatina has joined #openstack-nova | 20:23 | |
*** tonytan_brb has quit IRC | 20:25 | |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc https://review.openstack.org/314085 | 20:25 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: update parameter validation on servers https://review.openstack.org/313532 | 20:25 |
openstackgerrit | Sarafraj Singh proposed openstack/nova: [WIP] api-ref: Update method validation on images https://review.openstack.org/314268 | 20:26 |
*** zenoway has quit IRC | 20:26 | |
*** smatzek has quit IRC | 20:27 | |
*** ctrath has joined #openstack-nova | 20:28 | |
*** sambetts is now known as sambetts|afk | 20:29 | |
*** shaohe_feng has quit IRC | 20:32 | |
*** pwnall has joined #openstack-nova | 20:33 | |
*** jeblair has quit IRC | 20:33 | |
*** shaohe_feng has joined #openstack-nova | 20:33 | |
*** jeblair has joined #openstack-nova | 20:33 | |
belliott | dansmith: i had just followed the pattern in WSGIService earlier, but now I've corrected both to only hit the db once | 20:35 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: add url parameter to expand all sections https://review.openstack.org/314271 | 20:37 |
*** zenoway has joined #openstack-nova | 20:38 | |
*** baoli has joined #openstack-nova | 20:38 | |
mriedem | sdague: i was just going over the notes from the glance session at the summit, | 20:39 |
mriedem | there might be some confusing directions in here, | 20:39 |
mriedem | we said we were going to copy v1 for v2, fix the v2 code to work with glance v2 and then drop v1 eventually | 20:40 |
mriedem | but we also said that the code would use v2 for things that are implemented, and fallback to v1 for things that aren't yet, so it can go in a series | 20:40 |
sdague | mriedem: where eventually == as soon as v2 works for all drivers | 20:40 |
*** baoli has quit IRC | 20:40 | |
mriedem | yeah | 20:40 |
mriedem | thing is, if we want to test this in pieces it seems mfedosin is still going to have version discovery logic in there | 20:41 |
sdague | why | 20:41 |
sdague | https://review.openstack.org/#/c/306447/1/specs/newton/approved/use-glance-v2-api.rst | 20:41 |
sdague | we have a big top level switch | 20:41 |
*** baoli has joined #openstack-nova | 20:42 | |
dansmith | belliott: cool | 20:42 |
mriedem | so basically, he can have a patch per operation for v2, but none of it will work until the top change | 20:42 |
*** zenoway has quit IRC | 20:42 | |
sdague | mriedem: sure | 20:42 |
mriedem | and we'd run a job against that which disables glance v1 and configures nova to use_glancev2=True | 20:42 |
sdague | but that's actually way less confusing than a request flow bouncing back and forth between versions | 20:42 |
sdague | mriedem: correct | 20:43 |
*** shaohe_feng has quit IRC | 20:43 | |
sdague | mriedem: and at some point that starts passing | 20:43 |
*** xyang1 has joined #openstack-nova | 20:43 | |
*** pwnall1 has joined #openstack-nova | 20:43 | |
sdague | we're using the conf value as a feature flag to keep it off when it's not fully implemented. It can still be unit tested in parts | 20:43 |
openstackgerrit | Brian Elliott proposed openstack/nova: Fix service version to update the DB https://review.openstack.org/314230 | 20:43 |
*** shaohe_feng has joined #openstack-nova | 20:44 | |
*** fragatina has quit IRC | 20:44 | |
*** pwnall has quit IRC | 20:44 | |
*** pwnall has joined #openstack-nova | 20:44 | |
*** sdake has joined #openstack-nova | 20:44 | |
dansmith | belliott: do we have no test coverage for the code you're changing? | 20:45 |
mriedem | sdague: ok, it's clear in my head now, the notes in the etherpad were conflicting, and i think mfedosin wanted to keep doing version discovery/conditional logic in the code series, so it has to be clear to him we're not doing that | 20:45 |
sdague | mriedem: right, I think that version discovery inline is part of what makes things confusing, because you have to handle both cases all the time, and in common code | 20:46 |
dansmith | alaski: why do you think that metadata bit needs to be a different spec? | 20:46 |
*** pwnall has quit IRC | 20:46 | |
dansmith | alaski: moving keypairs out of the cell db necessitates us storing the full keypair with the instance, so I see them as one thing | 20:47 |
*** sdake_ has quit IRC | 20:47 | |
belliott | dansmith: seems not | 20:47 |
alaski | dansmith: just because I like to split things as much as possible. I think they're definitely dependent, but two separate efforts | 20:47 |
*** baoli has quit IRC | 20:47 | |
dansmith | belliott: well, feels like we should have something to validate that this behavior is (now) correct, right? | 20:48 |
alaski | dansmith: I'm not going to filibuster on that though if others are okay with them merged | 20:48 |
dansmith | alaski: but really needing another spec? | 20:48 |
*** pwnall1 has quit IRC | 20:48 | |
*** baoli has joined #openstack-nova | 20:48 | |
belliott | dansmith: i'll add something to confirm service records are actually updated, not just created. that seems to be the gap | 20:48 |
dansmith | alaski: I mean, the patches are all split up, but it seems like the boiler plate in another spec will be almost as large as the description of the change... | 20:48 |
dansmith | belliott: cool, thanks | 20:48 |
mriedem | sdague: nikhil: ok, summit session recap for nova/glance is sent out, let me know if i missed anything in htere | 20:49 |
mriedem | *three | 20:49 |
mriedem | damn | 20:49 |
mriedem | you know what i mean | 20:49 |
sdague | mriedem: cool, I'll check in the morning, time to get the grill running here. | 20:49 |
sdague | https://review.openstack.org/#/c/314271/ should be a much easier review on the api-ref side | 20:50 |
sdague | oh, sorry, not that one, though it is too | 20:50 |
mikal | Morning | 20:50 |
alaski | dansmith: agreed. but the changes have two purposes, though they are related. | 20:50 |
alaski | dansmith: I'm not going to -1 for it, but I would prefer it | 20:50 |
sdague | wow, gerrit has the slows for me | 20:50 |
*** BjoernT has joined #openstack-nova | 20:50 | |
dansmith | alaski: hmm, I'm not sure I get it.. if we weren't moving the keypairs out, then we wouldn't need to change the metadata code | 20:51 |
alaski | dansmith: we wouldn't need to, but it's still a beneficial change on its own | 20:51 |
dansmith | alaski: maybe you're reading too much into what he said about "reads the table directly" ? | 20:51 |
dansmith | alaski: it just uses the object like anything else | 20:51 |
alaski | yeah, I get that | 20:52 |
dansmith | and goes through conductor if you run metadata without use_local | 20:52 |
dansmith | hmm, okay | 20:52 |
*** vtech has quit IRC | 20:53 | |
alaski | I see migrating keypairs out of cells as one thing, like the other migrations. and I see attaching more data to the instance and passing it through as another thing, like flavors into instance_extra | 20:53 |
openstackgerrit | Sean Dague proposed openstack/nova: api-ref: perform all 4 phases of verification for action console output https://review.openstack.org/314257 | 20:53 |
*** shaohe_feng has quit IRC | 20:53 | |
*** neophy has quit IRC | 20:53 | |
sdague | mriedem: that should be a much easier reviewable one. Some times the actions interface makes it easier to explain things :) | 20:53 |
*** shaohe_feng has joined #openstack-nova | 20:54 | |
dansmith | alaski: especially in this case I don't agree at all | 20:54 |
dansmith | alaski: but anyway, I commented with my feelings | 20:55 |
*** smatzek has joined #openstack-nova | 20:55 | |
nikhil | mriedem: thanks for the heads-up | 20:56 |
*** mvk has joined #openstack-nova | 20:57 | |
alaski | dansmith: counter commented to clarify my vote | 20:57 |
dansmith | alaski: I counter-counter-commented to clarify my dissent | 20:57 |
dansmith | (not really, I just wanted to say counter-counter-commented0 | 20:57 |
alaski | :) | 20:57 |
*** salv-orlando has quit IRC | 20:58 | |
openstackgerrit | Tom Patzig proposed openstack/nova-specs: Add "disable root_disk" option to flavors https://review.openstack.org/267673 | 20:58 |
*** baoli has quit IRC | 20:59 | |
*** Sukhdev has joined #openstack-nova | 21:01 | |
mriedem | sdague: on https://review.openstack.org/#/c/313532/ i'm not seeing where you can update access IPs for diskConfig for a server | 21:01 |
mriedem | *or diskConfig | 21:01 |
cdent | jaypipes: I've just finished the second of two reviews on https://review.openstack.org/#/c/300176/ , two different hats | 21:02 |
*** pwnall has joined #openstack-nova | 21:02 | |
*** mageshgv has quit IRC | 21:03 | |
*** shaohe_feng has quit IRC | 21:03 | |
*** rlrossit has quit IRC | 21:04 | |
*** shaohe_feng has joined #openstack-nova | 21:04 | |
*** unicell has quit IRC | 21:05 | |
*** baoli has joined #openstack-nova | 21:06 | |
*** smatzek has quit IRC | 21:06 | |
bauzas | jaypipes: still around ? | 21:07 |
bauzas | jaypipes: I'm just reviewing the generic-resource-pools spec | 21:07 |
*** tjones has left #openstack-nova | 21:08 | |
bauzas | jaypipes: I have a question for you about resource classes and how an operator can know it | 21:09 |
*** avula has quit IRC | 21:09 | |
bauzas | (and if it's interop) | 21:09 |
*** unicell has joined #openstack-nova | 21:10 | |
cdent | bauzas: I _might_ be able to help, what's up? | 21:11 |
bauzas | cdent: lemme just upload my question | 21:11 |
cdent | ++ | 21:11 |
*** fragatina has joined #openstack-nova | 21:11 | |
cdent | bauzas: are you just innately a night person or is there some other reason you're usually around late? | 21:12 |
bauzas | cdent: done, my question is up | 21:12 |
*** mageshgv has joined #openstack-nova | 21:12 | |
bauzas | cdent: it's about using the --resource_class flag in the client, meaning that the operator knows it | 21:12 |
bauzas | cdent: I'm a night owl | 21:13 |
*** lpetrut has quit IRC | 21:13 | |
bauzas | (TBH, evenings are perfect for doing things you don't have time for it during workhours) | 21:13 |
*** jichen has quit IRC | 21:13 | |
*** shaohe_feng has quit IRC | 21:13 | |
bauzas | (like reviewing specs you promised) | 21:14 |
cdent | :) | 21:14 |
cdent | bauzas: It turns out I think I can answer that question, will answer it there | 21:14 |
bauzas | great | 21:14 |
*** shaohe_feng has joined #openstack-nova | 21:14 | |
bauzas | note that I haven't voted | 21:14 |
bauzas | cdent: short answer maybe here ? | 21:15 |
*** Guest56459 is now known as mfisch | 21:15 | |
cdent | if you prefer sure: | 21:15 |
*** sheel has quit IRC | 21:15 | |
*** mfisch is now known as Guest87085 | 21:15 | |
alaski | dansmith: on https://review.openstack.org/#/c/312751/5, is there a test that already covers the case of a keypair being set at boot time? | 21:15 |
bauzas | cdent: well, just in case I have a follow-up question | 21:15 |
cdent | basically in the current implementatation of resource classes there are only a small number of them and in the nova.objects universe they an indexed enum. that is when you used them as a human you use a string, but when the get stored into a database, an int is stored but that int is the same across all deployments | 21:16 |
cdent | so the deployer is supposed to know the names, via docs | 21:16 |
cdent | however | 21:17 |
cdent | there is a spec in progress for dynamic resource classes | 21:17 |
bauzas | oh right | 21:17 |
bauzas | I missed that | 21:17 |
cdent | for deployment specific resource classes | 21:17 |
cdent | when that's done (if it is) there will be an API for listing the names (both standard and dynamic) | 21:17 |
bauzas | yeah, for dynamic resource classes, that would be necessary, but not in that spec | 21:18 |
cdent | the dynamic ones will also be stored as ints, but they will started at some high number | 21:18 |
dansmith | alaski: in unit tests you mean? all the tempest ssh ones do, right? | 21:18 |
cdent | bauzas: that answer it well enough? | 21:18 |
alaski | dansmith: I was thinking unit test, but a tempest test works for me. just something to prove it doesn't go boom | 21:19 |
bauzas | cdent: yeah, just amending my comment | 21:19 |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Complete method verification of os-fping https://review.openstack.org/314287 | 21:19 |
bauzas | cdent: thnaks for answering | 21:19 |
*** Guest87085 is now known as mfisch | 21:19 | |
cdent | my pleasure | 21:19 |
*** mfisch has quit IRC | 21:20 | |
*** mfisch has joined #openstack-nova | 21:20 | |
*** burgerk has quit IRC | 21:20 | |
bauzas | cdent: my resource-* knowledge is currently on a 1.44MB virtual floppy disk, I should think of increasing that before asking questions :) | 21:21 |
*** xyang1 has quit IRC | 21:21 | |
cdent | I think you're going to need a TB | 21:21 |
*** aysyd has quit IRC | 21:22 | |
*** dkliban has joined #openstack-nova | 21:22 | |
*** lakshmiS has quit IRC | 21:22 | |
*** rtheis has quit IRC | 21:23 | |
*** NightKhaos has quit IRC | 21:23 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/api directory (4) https://review.openstack.org/309198 | 21:24 |
*** shaohe_feng has quit IRC | 21:24 | |
dansmith | alaski: https://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py#L136 | 21:24 |
*** unicell has quit IRC | 21:24 | |
*** shaohe_feng has joined #openstack-nova | 21:25 | |
alaski | dansmith: cool. There did seem to a few tests using it | 21:25 |
dansmith | yeah, in unit tests too | 21:25 |
dansmith | but the fact it works in tempest gives me higher confidence | 21:25 |
alaski | agreed | 21:26 |
*** svenkat has quit IRC | 21:27 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (3) https://review.openstack.org/309197 | 21:28 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (4) https://review.openstack.org/309199 | 21:28 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (1) https://review.openstack.org/309193 | 21:28 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (2) https://review.openstack.org/309195 | 21:28 |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/api directory (5) https://review.openstack.org/314290 | 21:28 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (5) https://review.openstack.org/314291 | 21:28 |
*** edmondsw has quit IRC | 21:29 | |
*** NightKhaos has joined #openstack-nova | 21:29 | |
*** ivase has quit IRC | 21:30 | |
nikhil | mriedem: hey, I updated https://etherpad.openstack.org/p/nova-glance-newton line 62 to help mike be aware of the decisions and clarified that mike's comments on line 44 are old | 21:30 |
mriedem | nikhil: thanks | 21:32 |
*** unicell has joined #openstack-nova | 21:33 | |
*** unicell has quit IRC | 21:33 | |
*** unicell has joined #openstack-nova | 21:33 | |
cdent | night all | 21:33 |
*** cdent has quit IRC | 21:33 | |
*** shaohe_feng has quit IRC | 21:34 | |
*** ivase has joined #openstack-nova | 21:34 | |
*** unicell1 has joined #openstack-nova | 21:35 | |
*** unicell has quit IRC | 21:35 | |
*** shaohe_feng has joined #openstack-nova | 21:37 | |
nikhil | mriedem: also, I wanted to explicitly point out the second last comment from my on https://review.openstack.org/#/c/301741/ . I'm not aware of the discussion on the image-list-details call. If there was none, we may need to re-discuss this bit :/ | 21:37 |
nikhil | s/my/me/g | 21:37 |
mriedem | nikhil: which line? | 21:38 |
nikhil | mriedem: https://review.openstack.org/#/c/301741/4/specs/newton/approved/use-glance-v2-api.rst@118 | 21:38 |
*** browne has joined #openstack-nova | 21:39 | |
nikhil | mriedem: last comment is most relevant | 21:39 |
*** ivase has quit IRC | 21:39 | |
jaypipes | bauzas: pls leave your question... will get to it in a bit. | 21:39 |
bauzas | jaypipes: nah, it's all good | 21:40 |
bauzas | jaypipes: cdent answered it before | 21:40 |
bauzas | jaypipes: I just left my happy mark as a pet | 21:40 |
*** roook has joined #openstack-nova | 21:41 | |
mriedem | nikhil: ok, i haven't read those yet, and won't have time to right now, but will go back over them | 21:41 |
nikhil | mriedem: np, I think if that's not agreed upon and most likely mike did not notice, we may need to discuss. | 21:42 |
bauzas | jaypipes: tbc, my comment was about https://www.youtube.com/watch?v=FPQlXNH36mI | 21:44 |
*** shaohe_feng has quit IRC | 21:44 | |
bauzas | s/about/related to | 21:45 |
*** shaohe_feng has joined #openstack-nova | 21:45 | |
*** roeyc has joined #openstack-nova | 21:47 | |
*** jamesden_ has quit IRC | 21:48 | |
*** mriedem is now known as mriedem_afk | 21:50 | |
*** Swami_ has joined #openstack-nova | 21:52 | |
*** yamahata has quit IRC | 21:52 | |
*** shaohe_feng has quit IRC | 21:54 | |
*** Swami has quit IRC | 21:55 | |
*** shaohe_feng has joined #openstack-nova | 21:55 | |
*** Swami_ has quit IRC | 21:58 | |
*** salv-orlando has joined #openstack-nova | 21:58 | |
*** nic has quit IRC | 21:59 | |
*** nic has joined #openstack-nova | 22:00 | |
*** Sukhdev has quit IRC | 22:00 | |
*** catintheroof has quit IRC | 22:01 | |
siva_krishnan | Had a question on centralizing config options. Should we delete opts.py in each module after moving all options to nova/conf ? your thoughts on this please | 22:01 |
*** sdake has quit IRC | 22:02 | |
*** salv-orlando has quit IRC | 22:03 | |
*** amotoki has joined #openstack-nova | 22:03 | |
edleafe | siva_krishnan: yes, you should | 22:04 |
siva_krishnan | edleafe gate-nova-docs are faling if i remove it | 22:05 |
*** shaohe_feng has quit IRC | 22:05 | |
*** tonytan4ever has quit IRC | 22:05 | |
edleafe | siva_krishnan: you also have to remove the reference in setup.cfg | 22:06 |
*** mageshgv has quit IRC | 22:06 | |
*** shaohe_feng has joined #openstack-nova | 22:07 | |
siva_krishnan | edleafe thanks for pointing that out :) | 22:09 |
*** ctrath has quit IRC | 22:09 | |
openstackgerrit | Augustina Ragwitz proposed openstack/nova: WIP: api-ref: Verify methods for metadata.inc https://review.openstack.org/314309 | 22:09 |
*** kfarr has quit IRC | 22:10 | |
*** browne has quit IRC | 22:10 | |
*** dimtruck is now known as zz_dimtruck | 22:10 | |
*** zz_dimtruck is now known as dimtruck | 22:10 | |
openstackgerrit | Sujitha proposed openstack/nova: Complete method verification of os-migrations https://review.openstack.org/314310 | 22:11 |
auggy | ok wow, it is really hard to tell what's being worked on for the api-ref stuff | 22:14 |
*** eharney has quit IRC | 22:14 | |
*** shaohe_feng has quit IRC | 22:15 | |
*** shaohe_feng has joined #openstack-nova | 22:16 | |
*** dimtruck is now known as zz_dimtruck | 22:20 | |
*** ducttape_ has quit IRC | 22:21 | |
*** haplo37 has quit IRC | 22:22 | |
*** dave-mccowan has quit IRC | 22:22 | |
*** shaohe_feng has quit IRC | 22:25 | |
*** shaohe_feng has joined #openstack-nova | 22:26 | |
*** pradk has quit IRC | 22:29 | |
*** salv-orlando has joined #openstack-nova | 22:29 | |
aunnam_ | sdague, for the api-ref work how do we handle the deprecated commands, like the file os-volumes.inc which has the deprecated options like nova volume-list, nova volume-create. Should i continue updating the file for such deprecated options too? | 22:29 |
*** mrkz has quit IRC | 22:30 | |
auggy | aunnam_: i think sdague is gone for the day, but my guess is if the code supports it then it should be updated | 22:32 |
*** mdrabe has quit IRC | 22:32 | |
*** pradk has joined #openstack-nova | 22:33 | |
*** pradk has quit IRC | 22:33 | |
*** rbridgeman_ has quit IRC | 22:33 | |
*** dkliban has quit IRC | 22:33 | |
*** mlavalle has quit IRC | 22:33 | |
*** dkliban has joined #openstack-nova | 22:34 | |
*** salv-orlando has quit IRC | 22:35 | |
*** jamielennox|away is now known as jamielennox | 22:35 | |
*** shaohe_feng has quit IRC | 22:35 | |
aunnam_ | auggy, thanks for the reply. Ya the code supports but it gives the deprecated warning so i should update it then | 22:36 |
auggy | aunnam_: i'd have to look at other docs but there should be something in the docs that say it's deprecated | 22:36 |
*** thorst_ has quit IRC | 22:36 | |
*** Swami has joined #openstack-nova | 22:37 | |
*** sacharya has quit IRC | 22:37 | |
*** ccarmack1 has quit IRC | 22:37 | |
*** ccarmack has joined #openstack-nova | 22:38 | |
*** shaohe_feng has joined #openstack-nova | 22:38 | |
*** vtech has joined #openstack-nova | 22:38 | |
aunnam_ | auggy, i don't see any deprecated warning in the docs | 22:39 |
auggy | aunnam_: I found this - https://github.com/openstack/nova/blob/master/api-ref/source/extensions.inc | 22:39 |
auggy | so maybe it should go in the method name title for the section | 22:39 |
auggy | maybe when alex_xu or oomichi are around they could provide some insight? | 22:40 |
*** BjoernT has quit IRC | 22:40 | |
auggy | to me, the logical thing would be to do Method Foo Bar (DEPRECATED) | 22:41 |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: centralized conf: nova/network/rpcapi.py https://review.openstack.org/274210 | 22:42 |
aunnam_ | auggy, that makes sense | 22:42 |
auggy | aunnam_: then i'd just put a comment on your review asking about how we should handle deprecated methods | 22:42 |
*** sambetts|afk has quit IRC | 22:43 | |
oomichi | auggy: https://github.com/openstack/nova/blob/master/api-ref/source/extensions.inc#L8 means the deprecation of extension mechanism itself | 22:45 |
oomichi | auggy: we can use microversions mechanism now instead of extension mechanism | 22:45 |
auggy | oomichi: should we indicate deprecated methods in the api-ref docs? | 22:46 |
*** shaohe_feng has quit IRC | 22:46 | |
auggy | like in the title or something? | 22:46 |
*** zenoway has joined #openstack-nova | 22:46 | |
*** tonytan4ever has joined #openstack-nova | 22:46 | |
*** shaohe_feng has joined #openstack-nova | 22:46 | |
oomichi | auggy: at line 80 of https://etherpad.openstack.org/p/newton-nova-api | 22:46 |
*** sambetts has joined #openstack-nova | 22:47 | |
oomichi | auggy: they will be deprecated with a new microversion | 22:47 |
oomichi | auggy: that means we still continue using these apis on original versions | 22:47 |
auggy | oomichi: right, but should we indicate something in the api docs that those methods are deprecated? | 22:47 |
*** cdelatte has quit IRC | 22:47 | |
auggy | if not that's fine, it just seems logical to me that as an api user i'd want to know if i shouldn't use a particular method | 22:48 |
*** cdelatte has joined #openstack-nova | 22:48 | |
oomichi | auggy: so it is nice to update these api docs also, but that should be low priority by comparing the other part | 22:48 |
oomichi | auggy: for the exsting users | 22:48 |
*** roeyc has quit IRC | 22:48 | |
auggy | aunnam_: oomichi: ok, so it looks like for now, don't do anything, just treat them as normal methods | 22:49 |
*** efried has quit IRC | 22:49 | |
auggy | aunnam_: oomichi: maybe if i manage to wake up in time for the next api meeting i can bring it up and ask how we want to deal with those in the docs, so we can discuss as a team :) | 22:49 |
*** cdelatte has quit IRC | 22:51 | |
oomichi | auggy: yeah, that will be nice discussion :-) maybe people have different opinions like "to enforce to use cinder api directly without proxy apis, we should not write them on api-ref" or something | 22:51 |
*** zenoway has quit IRC | 22:51 | |
*** cdelatte has joined #openstack-nova | 22:51 | |
auggy | hooray i finally found a .inc file no one else is working on from what i can tell ;) | 22:52 |
*** tonytan4ever has quit IRC | 22:52 | |
aunnam_ | auggy, you mean don't update such methods, just leave them? | 22:52 |
auggy | aunnam_: no, do the verification, treat them as normal methods | 22:52 |
aunnam_ | auggy, ok git it :) | 22:53 |
auggy | but feel free to put a comment in the review asking about how we should handle deprecated methods | 22:53 |
auggy | that's what i'd do :) | 22:53 |
*** hemna is now known as hemnafk | 22:53 | |
aunnam_ | auggy, sure thanks for the suggestions | 22:53 |
auggy | aunnam_: also, when you start working on one of those, be sure to push a WIP patch right away with what section of the verification you are doing so someone else doesn't start work on teh same file | 22:54 |
auggy | i didn't see your patch for the volumes stuff and almost started working on it | 22:54 |
auggy | if you hadn't said anything in irc, i would have also been working on it, whoops :) | 22:54 |
aunnam_ | ya thats a major problem., will submit a patch right away | 22:55 |
openstackgerrit | Augustina Ragwitz proposed openstack/nova: WIP: api-ref: ips.inc parameter verification https://review.openstack.org/314320 | 22:55 |
*** shaohe_feng has quit IRC | 22:56 | |
auggy | thx! i wish we had a better way to figure out what is being worked on:/ | 22:56 |
*** shaohe_feng has joined #openstack-nova | 22:57 | |
auggy | right now i'm just keeping a spreadsheet :/ | 22:57 |
aunnam_ | auggy, i wish there is an etherpad, where one can put their names on the files which they are working on | 22:58 |
*** sdague has quit IRC | 22:58 | |
auggy | yeah i think we decided not to do that because people were worried it would be out of date | 22:58 |
*** ccarmack has joined #openstack-nova | 22:58 | |
*** ametts has quit IRC | 22:58 | |
aunnam_ | ok | 22:59 |
auggy | aunnam_: i just posted a message to the ML asking if we could come up with a better way to track who is working on what, so maybe someone will have some ideas | 23:01 |
*** claudiub has quit IRC | 23:01 | |
*** gjayavelu has joined #openstack-nova | 23:02 | |
*** ccarmack has left #openstack-nova | 23:03 | |
aunnam_ | auggy, great lets see. Now it is taking more time to actually look for .inc file which is not taken and if it is taken, keeping track of what verification is left is also difficult | 23:05 |
auggy | aunnam_: yeah agreed, i think it's an obstacle for people diving in | 23:05 |
auggy | it would also be nice to mark ones that are good for people who are new to nova versus ones that are trickier | 23:05 |
*** shaohe_feng has quit IRC | 23:06 | |
*** diogogmt has quit IRC | 23:06 | |
*** shaohe_feng has joined #openstack-nova | 23:07 | |
*** ijw has quit IRC | 23:07 | |
*** ijw has joined #openstack-nova | 23:07 | |
aunnam_ | auggy, ya that really helps a lot to the people like me who just started with nova | 23:08 |
*** zz_dimtruck is now known as dimtruck | 23:11 | |
*** tjones has joined #openstack-nova | 23:12 | |
*** tjones has left #openstack-nova | 23:16 | |
*** shaohe_feng has quit IRC | 23:16 | |
*** cdelatte has quit IRC | 23:17 | |
*** shaohe_feng has joined #openstack-nova | 23:17 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (3) https://review.openstack.org/309197 | 23:18 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (4) https://review.openstack.org/309199 | 23:18 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (1) https://review.openstack.org/309193 | 23:18 |
openstackgerrit | Ed Leafe proposed openstack/nova: Move config options from nova/api directory (5) https://review.openstack.org/314290 | 23:18 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (5) https://review.openstack.org/314291 | 23:18 |
openstackgerrit | Ed Leafe proposed openstack/nova: Improve the help text for the API options (2) https://review.openstack.org/309195 | 23:18 |
* edleafe really messed up the rebase order of that stack ^^ | 23:19 | |
*** gongysh has joined #openstack-nova | 23:20 | |
openstackgerrit | Augustina Ragwitz proposed openstack/nova: api-ref: ips.inc parameter verification https://review.openstack.org/314320 | 23:22 |
*** zenoway has joined #openstack-nova | 23:22 | |
*** BjoernT has joined #openstack-nova | 23:24 | |
*** vilobhmm111 has quit IRC | 23:25 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: WIP: api-ref: os-volumes.inc method verification https://review.openstack.org/314325 | 23:25 |
*** zenoway has quit IRC | 23:27 | |
*** shaohe_feng has quit IRC | 23:27 | |
auggy | edleafe: hey i have a question on behalf of zeroDivisible | 23:27 |
*** shaohe_feng has joined #openstack-nova | 23:27 | |
auggy | they are interested in helping out with the config centralization stuff | 23:27 |
edleafe | auggy: shoot | 23:28 |
*** penick has quit IRC | 23:28 | |
auggy | zeroDivisible: why don't you go ahead and ask :) | 23:28 |
*** BjoernT is now known as Bjoern_zZzZzZzZ | 23:30 | |
zeroDivisible | auggy: hah, ok :) edleafe: basically, I've meant to look at doing one of the unmarked options (disable_rootwrap) as an easy way of introducing myself to the source code, but I think that it's in the correct place now - so I had been wondering if there's something in relation to this task with which I can help. I noticed that preallocate_images, once reevaluated maybe will need to be changed to | 23:30 |
zeroDivisible | BoolOpt, so was wondering if I can give it a go | 23:30 |
edleafe | zeroDivisible: so it's been moved into nova/conf already, right? | 23:32 |
zeroDivisible | edleafe: yeah, I think so | 23:32 |
zeroDivisible | it's in nova/conf/workarounds | 23:32 |
edleafe | zeroDivisible: yeah, looking at it now, it's moved, and the help text has been updated to be, well, more helpful :) | 23:33 |
*** Bjoern_zZzZzZzZ is now known as BjoernT | 23:33 | |
edleafe | zeroDivisible: so this process is twofold: move the options into nova/conf unchanged, and then enhance their help text | 23:34 |
zeroDivisible | edleafe: gotcha. | 23:34 |
edleafe | We use this etherpad to track who's working on what: https://etherpad.openstack.org/p/config-options | 23:35 |
*** ijw has quit IRC | 23:35 | |
*** ijw has joined #openstack-nova | 23:35 | |
edleafe | zeroDivisible: I see that most are already being worked on, but there are a bunch of libvirt options that seem to have been added recently | 23:35 |
edleafe | I'm not sure if 'hielq' is working on them or not | 23:36 |
*** shaohe_feng has quit IRC | 23:37 | |
*** salv-orlando has joined #openstack-nova | 23:37 | |
auggy | zeroDivisible: lol i forgot i put my name on one, destroy_after_evacuate | 23:37 |
*** sacharya has joined #openstack-nova | 23:37 | |
auggy | you can take that one | 23:37 |
zeroDivisible | edleafe: gotcha, I'll try to find out, if yes and other tasks are up to discussion, I may just pick something else which is simple | 23:37 |
edleafe | zeroDivisible: like this: https://review.openstack.org/#/c/301564/ - hasn't had any activity for 5 weeks | 23:37 |
*** BjoernT has quit IRC | 23:38 | |
auggy | looks like handle_virt_lifecycle_events and disable_libvirt_livesnapshot are free unless someone else has worked on them and not updated the etherpad | 23:38 |
*** shaohe_feng has joined #openstack-nova | 23:38 | |
zeroDivisible | edleafe: if I'm checking correctly, destroy_after_evacuate has a not in releasenotes/notes that it had been removed as it's no longer necessary, I may cross the line in etherpad | 23:39 |
edleafe | zeroDivisible: yes, that's correct | 23:39 |
edleafe | zeroDivisible: my API config options patchset has been around so long (since December) that several opts have already been removed. :) | 23:40 |
*** sacharya has quit IRC | 23:42 | |
*** salv-orlando has quit IRC | 23:42 | |
zeroDivisible | edleafe: can't cry after deleted code :) | 23:43 |
*** roook has quit IRC | 23:43 | |
openstackgerrit | Augustina Ragwitz proposed openstack/nova: WIP: api-ref: ips.inc example verification https://review.openstack.org/314328 | 23:44 |
*** rooooook has joined #openstack-nova | 23:46 | |
*** abitha has joined #openstack-nova | 23:46 | |
*** shaohe_feng has quit IRC | 23:47 | |
*** shaohe_feng has joined #openstack-nova | 23:47 | |
*** ijw_ has joined #openstack-nova | 23:56 | |
*** ijw has quit IRC | 23:56 | |
*** armax has quit IRC | 23:57 | |
*** shaohe_feng has quit IRC | 23:57 | |
*** Sukhdev has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!