Tuesday, 2016-05-10

openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/31374300:03
*** shaohe_feng has joined #openstack-nova00:04
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334500:05
*** rbridgeman_ has joined #openstack-nova00:07
*** shaohe_feng has quit IRC00:08
*** mriedem_afk has quit IRC00:08
*** mriedem has joined #openstack-nova00:08
*** armax has joined #openstack-nova00:08
*** shaohe_feng has joined #openstack-nova00:08
*** rbridgeman__ has joined #openstack-nova00:10
*** Jeffrey4l_ has joined #openstack-nova00:10
armaxmriedem: ping re https://review.openstack.org/#/c/299028/00:11
armaxmriedem: you got a sec?00:11
mriedemarmax: sure00:12
armaxkevinbenton and I were going over the two backports and we were considering the possibility to bring these into Kilo in a way that’s possible to disable the filters if things go awry00:13
*** rbridgeman_ has quit IRC00:13
* tbachman looks at his “to do” list, realizes that he had something on his calendar for nova :-o00:13
kevinbentonso it would be configurable with a cfg option essentially00:13
armaxbecause the fact that Kilo will be closed after this fix will prevent us from doing anything about it00:13
armaxthe cherry picks are not clean anyway00:14
armaxand especially the ovs change looks totally different from the master fix00:14
mriedemalthough the functional tests pass00:15
armaxso I see two approaches, one a) not allow the backport b) allow the backport with the ability to switch it off if things go bad00:15
*** rfolco has quit IRC00:15
armaxmriedem: true, but the extent of the coverage is limited (single node not at scale, etc)00:15
mriedemyeah00:15
mriedemwe've backported workaround bug fixes in nova before where they have a config option to enable/disable them00:15
armaxmriedem: I am a chicken, and backporting this as is makes me a bit unease00:16
armaxuneasy00:16
armaxmriedem: if there’s a precendent and since it’s a bw compact config change, perhaps that’s the way we allow it, and we can obviously have it on by default00:16
mriedemif we're uneasy about it, to the point that we want to add a config option to disable it, i'm also totally fine with just saying we're not going to do them and do kilo eol00:17
mriedemif people need them downstream, they could get them from what's proposed at their own risk00:17
kevinbentontrue, at least we know they will always patch cleanly since kilo is EOL00:17
armaxmriedem, kevinbenton: yes, the patch is there for consumption by anyone00:18
*** shaohe_feng has quit IRC00:18
kevinbentondo we have a pointer to it in the security advisory?00:18
*** gongysh has quit IRC00:19
*** shaohe_feng has joined #openstack-nova00:19
mriedemthere isn't a published ossa yet00:19
mriedemthere is a draft of the description in the bug report by tristanC00:20
mriedemi think i've seen OSSAs that say it impacts a certain release but it's not fixed in that release because EOL00:20
armaxso are ruling out option b)? if kevinbenton put effort in respinning the patches with that approach, I am in00:21
mriedemactually, e.g. https://bugs.launchpad.net/nova/+bug/1516765 we just marked juno as won't fix00:21
openstackLaunchpad bug 1516765 in OpenStack Compute (nova) liberty "[OSSA 2016-002] xenapi: volume_utils._parse_volume_info can leak connection password via StorageError (CVE-2015-8749)" [High,Fix committed] - Assigned to Matt Riedemann (mriedem)00:21
kevinbentonit wouldn't take too long to add the config option, i could finish it up within the hour00:21
mriedemand the ossa just didn't mention juno http://lists.openstack.org/pipermail/openstack-announce/2016-January/000916.html00:22
mriedemup to you guys, i'm fine either way00:22
armaxmriedem: thanks, it’s good to know we’d be not in breach of some code of conduct :)00:22
kevinbentonok, armax, do you want me to respin with the config option?00:23
armaxkevinbenton: if there’s a prior example and you have the cycles to respin that now, we’d have time until the end of today to put them in the merge queue00:23
kevinbentonarmax: ack00:25
armaxkevinbenton: otherwise we’ll just live with the documented issue and a pointer to a fix00:25
*** diogogmt has joined #openstack-nova00:25
*** shaohe_feng has quit IRC00:28
*** shaohe_feng has joined #openstack-nova00:29
*** Sukhdev has quit IRC00:30
*** Sukhdev has joined #openstack-nova00:31
*** abitha has quit IRC00:31
alex_xualaski: yeah, those policy check for legacy v2 api will be removed, it's on my todo.00:33
*** ducttape_ has joined #openstack-nova00:35
*** browne has joined #openstack-nova00:36
*** Sukhdev has quit IRC00:37
alex_xumriedem: just found we return 400 for marker not found https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L42100:37
mriedemalex_xu: :(00:38
mriedemsame for flavors00:38
*** shaohe_feng has quit IRC00:38
alex_xumriedem: just found that also00:39
mriedemi guess we need to update the servers inc then since i made sdague change that00:39
alex_xuyea, nvm, i can cook a patch for the doc later00:39
*** shaohe_feng has joined #openstack-nova00:40
*** salv-orlando has joined #openstack-nova00:42
*** nic has quit IRC00:42
*** ajo has joined #openstack-nova00:44
openstackgerritAlex Xu proposed openstack/nova: Remove 404 for list and details action servers  https://review.openstack.org/31435500:44
*** markmc has joined #openstack-nova00:45
alex_xumriedem: ^ done for this 1 mins, not later anymore...00:45
*** mriedem1 has joined #openstack-nova00:47
*** ducttape_ has quit IRC00:47
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/31374300:48
*** mriedem has quit IRC00:48
*** salv-orlando has quit IRC00:48
*** shaohe_feng has quit IRC00:49
*** dmellado has joined #openstack-nova00:49
*** shaohe_feng has joined #openstack-nova00:50
*** Swami has quit IRC00:53
*** cheneydc has joined #openstack-nova00:55
*** unicell1 has quit IRC00:55
*** unicell has joined #openstack-nova00:56
*** mriedem1 is now known as mriedem00:56
*** shaohe_feng has quit IRC00:59
*** hoangcx has joined #openstack-nova00:59
*** gongysh has joined #openstack-nova00:59
*** shaohe_feng has joined #openstack-nova01:00
*** iceyao has joined #openstack-nova01:01
*** sdake has joined #openstack-nova01:02
*** iceyao_ has joined #openstack-nova01:05
*** fishcried has joined #openstack-nova01:05
*** mriedem1 has joined #openstack-nova01:06
*** fishcried has quit IRC01:07
*** iceyao has quit IRC01:08
*** mriedem has quit IRC01:08
*** shaohe_feng has quit IRC01:09
*** ducttape_ has joined #openstack-nova01:10
*** shaohe_feng has joined #openstack-nova01:10
*** ljxiash has joined #openstack-nova01:14
*** baoli has quit IRC01:16
*** browne has quit IRC01:16
*** baoli has joined #openstack-nova01:16
*** apoorvad has quit IRC01:16
*** unicell1 has joined #openstack-nova01:17
*** unicell has quit IRC01:17
*** shaohe_feng has quit IRC01:19
*** shaohe_feng has joined #openstack-nova01:20
*** baoli has quit IRC01:22
*** kengo_sakai has joined #openstack-nova01:23
*** mriedem1 has quit IRC01:24
*** ljxiash has quit IRC01:25
*** ducttape_ has quit IRC01:25
*** zenoway has joined #openstack-nova01:26
*** jinxing has joined #openstack-nova01:28
*** thorst_ has joined #openstack-nova01:28
*** shaohe_feng has quit IRC01:30
*** zenoway has quit IRC01:30
*** EinstCrazy has joined #openstack-nova01:31
*** shaohe_feng has joined #openstack-nova01:33
*** baoli has joined #openstack-nova01:34
*** yuywz__ is now known as yuywz01:36
*** ctrath has joined #openstack-nova01:38
*** sacharya has joined #openstack-nova01:39
*** mdrabe has joined #openstack-nova01:40
*** shaohe_feng has quit IRC01:40
*** shaohe_feng has joined #openstack-nova01:41
*** roeyc has joined #openstack-nova01:41
*** sacharya has quit IRC01:44
*** diogogmt has quit IRC01:44
*** salv-orlando has joined #openstack-nova01:44
*** baoli has quit IRC01:48
*** baoli has joined #openstack-nova01:48
*** ducttape_ has joined #openstack-nova01:49
*** BjoernT has joined #openstack-nova01:49
*** gongysh has quit IRC01:50
*** pwnall has quit IRC01:50
*** shaohe_feng has quit IRC01:50
*** salv-orlando has quit IRC01:51
*** shaohe_feng has joined #openstack-nova01:51
*** Daisy has joined #openstack-nova01:53
*** unicell1 has quit IRC01:55
*** shaohe_feng has quit IRC02:01
*** shaohe_feng has joined #openstack-nova02:01
*** roeyc has quit IRC02:01
*** sacharya has joined #openstack-nova02:02
*** yamahata has joined #openstack-nova02:03
*** baoli has quit IRC02:03
*** EinstCrazy has quit IRC02:05
*** EinstCrazy has joined #openstack-nova02:08
*** fishcried has joined #openstack-nova02:09
*** shaohe_feng has quit IRC02:11
*** gjayavelu has quit IRC02:11
*** shaohe_feng has joined #openstack-nova02:12
*** ijw_ has quit IRC02:12
*** zenoway has joined #openstack-nova02:13
*** ayoung has quit IRC02:17
*** zenoway has quit IRC02:17
*** woodster_ has quit IRC02:18
*** houming has joined #openstack-nova02:18
*** ctrath has quit IRC02:19
*** shaohe_feng has quit IRC02:21
*** shaohe_feng has joined #openstack-nova02:22
*** gongysh has joined #openstack-nova02:23
*** amotoki has quit IRC02:25
*** hieulq_ has joined #openstack-nova02:25
*** vilobhmm11 has joined #openstack-nova02:27
*** shaohe_feng has quit IRC02:31
*** shaohe_feng has joined #openstack-nova02:32
*** armax_ has joined #openstack-nova02:34
*** ljxiash has joined #openstack-nova02:35
*** armax has quit IRC02:37
*** armax_ is now known as armax02:37
openstackgerritAlex Xu proposed openstack/nova: Remove 404 for list and details actions of servers  https://review.openstack.org/31435502:38
*** shaohe_feng has quit IRC02:42
*** ljxiash has quit IRC02:42
*** hieulq_ has quit IRC02:42
*** shaohe_feng has joined #openstack-nova02:42
*** allen_gao has quit IRC02:44
*** ducttape_ has quit IRC02:46
*** allen_gao has joined #openstack-nova02:48
*** zenoway has joined #openstack-nova02:49
*** vtech has quit IRC02:51
*** coreywright has quit IRC02:51
*** shaohe_feng has quit IRC02:52
*** amotoki has joined #openstack-nova02:52
*** coreywright has joined #openstack-nova02:52
*** shaohe_feng has joined #openstack-nova02:52
*** salv-orlando has joined #openstack-nova02:53
*** BjoernT has quit IRC02:53
*** tjones has joined #openstack-nova02:53
*** zenoway has quit IRC02:53
*** salv-orlando has quit IRC02:54
*** vtech has joined #openstack-nova02:56
*** vladikr has quit IRC02:57
*** allen_gao has quit IRC02:57
*** amotoki has quit IRC03:00
*** shaohe_feng has quit IRC03:02
*** shaohe_feng has joined #openstack-nova03:03
*** allen_gao has joined #openstack-nova03:04
*** Sukhdev has joined #openstack-nova03:05
*** rhagarty has quit IRC03:06
*** sdake has quit IRC03:07
*** amotoki has joined #openstack-nova03:10
*** shaohe_feng has quit IRC03:12
*** shaohe_feng has joined #openstack-nova03:13
*** rfolco has joined #openstack-nova03:17
*** akshai has joined #openstack-nova03:18
*** Jeffrey4l_ has quit IRC03:18
*** ljxiash has joined #openstack-nova03:18
*** Jeffrey4l_ has joined #openstack-nova03:19
*** gongysh has quit IRC03:20
*** gjayavelu has joined #openstack-nova03:22
*** gjayavelu has quit IRC03:22
*** gjayavelu has joined #openstack-nova03:22
*** shaohe_feng has quit IRC03:23
*** shaohe_feng has joined #openstack-nova03:23
*** zenoway has joined #openstack-nova03:24
*** rbridgeman__ has quit IRC03:25
*** moshele has joined #openstack-nova03:26
*** EinstCrazy has quit IRC03:28
*** EinstCrazy has joined #openstack-nova03:28
*** links has joined #openstack-nova03:29
*** zenoway has quit IRC03:29
*** dkliban has left #openstack-nova03:30
*** amotoki has quit IRC03:31
*** shaohe_feng has quit IRC03:33
*** thorst_ has quit IRC03:33
*** jinxing has quit IRC03:33
*** shaohe_feng has joined #openstack-nova03:33
*** thorst_ has joined #openstack-nova03:34
*** Vek has quit IRC03:37
*** thorst_ has quit IRC03:38
*** amotoki has joined #openstack-nova03:39
*** dimtruck is now known as zz_dimtruck03:40
*** zz_dimtruck is now known as dimtruck03:40
*** ayoung has joined #openstack-nova03:42
*** thorst_ has joined #openstack-nova03:42
*** shaohe_feng has quit IRC03:43
openstackgerritzhufl proposed openstack/nova: Correct some misspell words in nova  https://review.openstack.org/31440603:43
openstackgerritTakashi NATSUME proposed openstack/nova: WIP: Add versioned instance usage notifications  https://review.openstack.org/27941603:44
*** shaohe_feng has joined #openstack-nova03:46
*** EinstCra_ has joined #openstack-nova03:46
*** EinstCrazy has quit IRC03:48
*** zenoway has joined #openstack-nova03:49
*** shaohe_feng has quit IRC03:53
*** zenoway has quit IRC03:54
*** shaohe_feng has joined #openstack-nova03:54
*** dimtruck is now known as zz_dimtruck03:55
*** prateek has joined #openstack-nova03:56
*** salv-orlando has joined #openstack-nova03:58
*** salv-orlando has quit IRC04:02
*** shaohe_feng has quit IRC04:04
*** vilobhmm11 has quit IRC04:04
*** Daisy has quit IRC04:05
*** Daisy has joined #openstack-nova04:05
*** shaohe_feng has joined #openstack-nova04:08
*** oomichi_ has joined #openstack-nova04:08
*** Daisy_ has joined #openstack-nova04:09
*** xenogear has quit IRC04:10
*** Daisy has quit IRC04:10
*** vilobhmm11 has joined #openstack-nova04:10
*** zz_dimtruck is now known as dimtruck04:10
*** Daisy_ has quit IRC04:12
*** Daisy has joined #openstack-nova04:12
*** vilobhmm11 has quit IRC04:13
*** sdake has joined #openstack-nova04:13
*** shaohe_feng has quit IRC04:14
*** shaohe_feng has joined #openstack-nova04:14
*** Daisy has quit IRC04:17
*** dimtruck is now known as zz_dimtruck04:20
*** vilobhmm11 has joined #openstack-nova04:20
*** shaohe_feng has quit IRC04:24
*** shaohe_feng has joined #openstack-nova04:25
*** vilobhmm11 has quit IRC04:25
*** unicell has joined #openstack-nova04:26
*** shaohe_feng has quit IRC04:34
*** iceyao_ has quit IRC04:35
*** shaohe_feng has joined #openstack-nova04:35
*** iceyao has joined #openstack-nova04:35
*** irenab has quit IRC04:36
*** sheel has joined #openstack-nova04:44
*** shaohe_feng has quit IRC04:45
*** shaohe_feng has joined #openstack-nova04:45
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Change hashes for latest oslo.versionedobjects  https://review.openstack.org/31441304:52
*** mdrabe has quit IRC04:53
*** rfolco has quit IRC04:53
*** shaohe_feng has quit IRC04:55
*** shaohe_feng has joined #openstack-nova04:56
*** salv-orlando has joined #openstack-nova04:57
*** jwcroppe has quit IRC04:57
*** jwcroppe has joined #openstack-nova04:58
*** fragatina has quit IRC04:59
*** akshai has quit IRC05:00
*** Sukhdev has quit IRC05:01
*** jwcroppe has quit IRC05:02
*** shaohe_feng has quit IRC05:05
*** shaohe_feng has joined #openstack-nova05:06
*** sdake has quit IRC05:06
*** armax has quit IRC05:08
*** ljxiash has quit IRC05:08
oomichi_alex_xu: can you take a look at https://review.openstack.org/#/c/314413/ ?05:08
oomichi_alex_xu: the unit test is failing on the gate, and the patch fixes it.05:09
oomichi_as the passing the test05:09
*** ljxiash has joined #openstack-nova05:10
*** prateek has quit IRC05:10
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/31374305:12
*** ljxiash has quit IRC05:14
openstackgerritMoshe Levi proposed openstack/nova: pci: Deprecate is_new from pci request  https://review.openstack.org/31099005:14
*** Daisy has joined #openstack-nova05:15
*** shaohe_feng has quit IRC05:15
*** shaohe_feng has joined #openstack-nova05:16
*** fragatina has joined #openstack-nova05:17
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Change hashes for latest oslo.versionedobjects  https://review.openstack.org/31441305:18
oomichi_dansmith: johnthetubaguy: can you take a look at https://review.openstack.org/#/c/314413/ ?05:19
*** gcb has joined #openstack-nova05:19
oomichi_dansmith: johnthetubaguy: I am not a specialist about the area, and happy if you see it05:19
*** lpetrut has joined #openstack-nova05:20
*** fragatina has quit IRC05:22
*** shaohe_feng has quit IRC05:26
*** iceyao_ has joined #openstack-nova05:28
*** sudipto has joined #openstack-nova05:28
*** irenab has joined #openstack-nova05:28
*** shaohe_feng has joined #openstack-nova05:29
*** apoorv has joined #openstack-nova05:29
*** iceyao has quit IRC05:31
*** itamarl has joined #openstack-nova05:31
*** fragatina has joined #openstack-nova05:33
*** sudipto has quit IRC05:33
*** fragatina has quit IRC05:33
*** roeyc has joined #openstack-nova05:33
*** fragatina has joined #openstack-nova05:34
*** Vek has joined #openstack-nova05:34
*** jichen has joined #openstack-nova05:34
*** shaohe_feng has quit IRC05:36
*** shaohe_feng has joined #openstack-nova05:37
*** prateek has joined #openstack-nova05:37
*** moshele has quit IRC05:39
*** oomichi_ has quit IRC05:41
*** roeyc has quit IRC05:42
*** shaohe_feng has quit IRC05:46
*** shaohe_feng has joined #openstack-nova05:47
*** sudipto has joined #openstack-nova05:49
*** roeyc has joined #openstack-nova05:50
*** itamarl has quit IRC05:53
*** shaohe_feng has quit IRC05:56
*** shaohe_feng has joined #openstack-nova05:57
*** sridharg has joined #openstack-nova05:59
*** lpetrut has quit IRC05:59
*** mjura has joined #openstack-nova05:59
*** ljxiash has joined #openstack-nova06:02
*** esracelik has joined #openstack-nova06:02
*** sudipto has quit IRC06:03
*** dedery has joined #openstack-nova06:04
*** thorst_ has quit IRC06:06
*** itamarl has joined #openstack-nova06:06
openstackgerritSrushti Gadadare proposed openstack/nova: Fix invalid uuid warnings  https://review.openstack.org/30265806:06
*** thorst_ has joined #openstack-nova06:06
*** ljxiash has quit IRC06:06
*** shaohe_feng has quit IRC06:07
*** ljxiash has joined #openstack-nova06:07
*** shaohe_feng has joined #openstack-nova06:10
*** amotoki has quit IRC06:10
*** thorst_ has quit IRC06:11
*** Oku_OS-away is now known as Oku_OS06:13
*** paul-carlton1 has joined #openstack-nova06:15
*** gongysh has joined #openstack-nova06:16
*** shaohe_feng has quit IRC06:17
*** shaohe_feng has joined #openstack-nova06:18
*** sudipto has joined #openstack-nova06:21
*** Daisy has quit IRC06:24
*** Daisy has joined #openstack-nova06:24
*** gcb has quit IRC06:25
*** andreas_s has joined #openstack-nova06:26
*** itamarl has quit IRC06:26
*** rcernin has joined #openstack-nova06:26
*** shaohe_feng has quit IRC06:27
*** shaohe_feng has joined #openstack-nova06:28
*** Daisy has quit IRC06:28
*** gongysh has quit IRC06:31
*** vtech has quit IRC06:34
*** vilobhmm11 has joined #openstack-nova06:34
*** shaohe_feng has quit IRC06:37
*** roeyc has quit IRC06:38
*** jdurgin1 has joined #openstack-nova06:38
*** shaohe_feng has joined #openstack-nova06:40
*** moshele has joined #openstack-nova06:41
*** moshele has quit IRC06:42
*** moshele has joined #openstack-nova06:42
*** itamarl has joined #openstack-nova06:45
*** gongysh has joined #openstack-nova06:45
*** shaohe_feng has quit IRC06:48
*** shaohe_feng has joined #openstack-nova06:48
*** migi has joined #openstack-nova06:51
*** migi has joined #openstack-nova06:51
*** Daisy has joined #openstack-nova06:53
*** sacharya has quit IRC06:53
*** shaohe_feng has quit IRC06:58
*** lpetrut has joined #openstack-nova06:59
*** shaohe_feng has joined #openstack-nova06:59
*** amotoki has joined #openstack-nova06:59
openstackgerritzhufl proposed openstack/nova: Correct some misspell words in nova  https://review.openstack.org/31440607:00
*** jed56 has joined #openstack-nova07:00
*** markus_z has joined #openstack-nova07:00
*** mariusv has quit IRC07:00
*** mariusv has joined #openstack-nova07:01
*** sudipto has quit IRC07:03
*** tesseract has joined #openstack-nova07:03
*** mpavone has joined #openstack-nova07:03
*** laszloh has joined #openstack-nova07:03
*** salv-orlando has quit IRC07:05
*** gjayavelu has quit IRC07:06
*** iceyao_ has quit IRC07:07
*** iceyao has joined #openstack-nova07:07
*** jamielennox is now known as jamielennox|away07:08
*** zenoway has joined #openstack-nova07:08
*** shaohe_feng has quit IRC07:08
*** fishcried has quit IRC07:09
*** shaohe_feng has joined #openstack-nova07:09
*** vtech has joined #openstack-nova07:10
*** omnipresent has joined #openstack-nova07:15
*** zenoway has quit IRC07:16
*** nkrinner_afk is now known as nkrinner07:16
*** shaohe_feng has quit IRC07:18
*** jdurgin1 has quit IRC07:19
*** shaohe_feng has joined #openstack-nova07:19
*** zenoway has joined #openstack-nova07:23
tdurakovhi, folks, could we finally merge this patch?07:24
tdurakovhttps://review.openstack.org/#/c/287997/07:24
*** lennyb has quit IRC07:25
*** omnipresent has quit IRC07:25
*** lpetrut has quit IRC07:27
*** shaohe_feng has quit IRC07:29
*** shaohe_feng has joined #openstack-nova07:29
*** josecastroleon has joined #openstack-nova07:34
*** lennyb has joined #openstack-nova07:34
*** hieulq has quit IRC07:37
*** mnestratov has joined #openstack-nova07:37
*** markus_z has quit IRC07:38
*** shaohe_feng has quit IRC07:39
*** jlanoux has joined #openstack-nova07:39
bauzasgood morning Nova07:39
*** gongysh has quit IRC07:39
*** shaohe_feng has joined #openstack-nova07:39
*** matrohon has joined #openstack-nova07:45
*** cheneydc1 has joined #openstack-nova07:49
*** jamielennox|away is now known as jamielennox07:49
*** shaohe_feng has quit IRC07:49
*** vilobhmm11 has quit IRC07:49
*** shaohe_feng has joined #openstack-nova07:50
*** belmoreira has joined #openstack-nova07:51
*** cheneydc has quit IRC07:51
*** cheneydc1 is now known as cheneydc07:51
*** liverpooler has joined #openstack-nova07:52
*** hieulq has joined #openstack-nova07:52
*** sacharya has joined #openstack-nova07:54
*** PaulMurray has joined #openstack-nova07:55
*** palexster has quit IRC07:57
*** sacharya has quit IRC07:58
*** shaohe_feng has quit IRC07:59
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-nova08:00
*** shaohe_feng has joined #openstack-nova08:00
*** jaosorior has joined #openstack-nova08:01
*** dedery_ has joined #openstack-nova08:02
*** dedery__ has joined #openstack-nova08:03
*** haukebruno has joined #openstack-nova08:03
*** palexster has joined #openstack-nova08:04
*** voelzmo has joined #openstack-nova08:04
*** dedery__ has quit IRC08:04
*** dedery has quit IRC08:04
*** dedery__ has joined #openstack-nova08:04
*** dedery_ has quit IRC08:06
*** danpb has joined #openstack-nova08:06
mdboothWould the real paul-carlton paul-carlton1 paul-carlton2 please stand up?08:09
*** shaohe_feng has quit IRC08:10
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334508:10
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334508:10
*** tpepper has quit IRC08:10
andrearosamdbooth: he is not in the office yet, probably on a train08:11
*** pkoniszewski has quit IRC08:11
openstackgerritAndrea Rosa proposed openstack/nova: Adding device_present field to bdm table  https://review.openstack.org/26805308:12
openstackgerritWeiwei Gu proposed openstack/nova: migration volume failed for invalid type  https://review.openstack.org/31445508:13
*** tpepper1 has joined #openstack-nova08:14
*** shaohe_feng has joined #openstack-nova08:14
*** pkoniszewski has joined #openstack-nova08:15
*** mvk has quit IRC08:16
*** yamahata has quit IRC08:20
*** shaohe_feng has quit IRC08:20
*** shaohe_feng has joined #openstack-nova08:21
*** vipuls has quit IRC08:22
*** lucas-dinner is now known as lucasagomes08:22
*** tpepper1 has quit IRC08:22
*** tpepper1 has joined #openstack-nova08:23
*** iceyao has quit IRC08:23
*** lpetrut has joined #openstack-nova08:24
*** vipuls has joined #openstack-nova08:25
*** paul-carlton1 has quit IRC08:25
*** iceyao has joined #openstack-nova08:28
*** lpetrut has quit IRC08:28
*** lpetrut has joined #openstack-nova08:29
openstackgerritTakashi NATSUME proposed openstack/nova: Remove mox in test_block_device_mapping_v1.py  https://review.openstack.org/30874608:29
*** sfinucan has joined #openstack-nova08:29
openstackgerritTakashi NATSUME proposed openstack/nova: Stop using mox stubs in test_pipelib.py  https://review.openstack.org/30880608:30
*** shaohe_feng has quit IRC08:30
*** daemontool__ is now known as daemontool08:30
*** shaohe_feng has joined #openstack-nova08:31
johnthetubaguyoomichi: just going to take a look at that patch now08:34
johnthetubaguyoomichi: I guess the gate is totally broken right now then?08:34
*** jistr has joined #openstack-nova08:37
johnthetubaguyoomichi: oh, I see, it will break once the upper constraint is lifted08:39
*** jwcroppe has joined #openstack-nova08:39
mnestratovgood morning08:39
*** shaohe_feng has quit IRC08:40
*** yassine has joined #openstack-nova08:41
mnestratovjohnthetubaguy: please remove your -2 on https://review.openstack.org/#/c/190843/08:41
*** shaohe_feng has joined #openstack-nova08:41
*** yassine is now known as Guest5980908:41
mnestratovrelated bp has been reapproved https://blueprints.launchpad.net/nova/+spec/libvirt-vzstorage-volume-support08:42
johnthetubaguymnestratov: sure thing, the BP is approved08:42
*** amotoki has quit IRC08:42
mnestratovjohnthetubaguy: thanks a lot08:42
*** amotoki has joined #openstack-nova08:43
*** paul-carlton1 has joined #openstack-nova08:44
*** jwcroppe has quit IRC08:44
*** mvk has joined #openstack-nova08:45
*** derekh has joined #openstack-nova08:47
*** gcb has joined #openstack-nova08:50
*** shaohe_feng has quit IRC08:51
openstackgerritPetrut Lucian proposed openstack/nova: HyperV: use os-brick for volume related operations  https://review.openstack.org/27350408:52
*** vnogin has joined #openstack-nova08:55
*** shaohe_feng has joined #openstack-nova08:55
openstackgerritAlexis Lee proposed openstack/nova: Make 'debug' option reconfigurable in Nova  https://review.openstack.org/28085108:56
yuywzhi folks, I have a question about mox and mock: how to replace a class with another like 'mox.stubs.Set' does using mock?08:58
yuywzfor example we can replace 'oslo_messaging.Notifier' with 'fake_notifer.FakeNotifier' with self.mox.stubs.Set(oslo_messaging, 'Notifier', fake_notifier.FakeNotifier)08:59
yuywzbut how to do this using mock?09:00
*** sacharya has joined #openstack-nova09:00
*** sdake has joined #openstack-nova09:01
*** shaohe_feng has quit IRC09:01
*** shaohe_feng has joined #openstack-nova09:01
*** ljxiash has quit IRC09:03
*** ljxiash has joined #openstack-nova09:03
johnthetubaguyyuywz: take a look at: https://github.com/openstack/nova/blob/master/nova/test.py#L26909:03
*** Guest59809 is now known as yassou09:04
*** sacharya has quit IRC09:04
openstackgerritSrushti Gadadare proposed openstack/nova: Fix invalid uuid warnings  https://review.openstack.org/30265809:04
*** roeyc has joined #openstack-nova09:06
*** itamarl_ has joined #openstack-nova09:06
yuywzjohnthetubaguy: thx, but I've tried that and seems stub_out only works with single method like self.stub_out('nova.compute.api.API.rebuild', fake_rebuild)09:07
*** ljxiash has quit IRC09:07
*** itamarl has quit IRC09:08
*** itamarl_ is now known as itamarl09:09
*** mnestratov has quit IRC09:09
*** roeyc has quit IRC09:10
yuywzjohnthetubaguy: I tried this self.useFixture(fixtures.MonkeyPatch('oslo_messaging.Notifier', fake_notifier.FakeNotifier)), but it did not work as expected09:11
*** shaohe_feng has quit IRC09:11
yuywzand self.mox.stubs.Set(oslo_messaging, 'Notifier', fake_notifier.FakeNotifier) works09:11
*** tpepper1 has quit IRC09:13
*** vipul- has joined #openstack-nova09:13
*** vipuls has quit IRC09:13
*** pkoniszewski has quit IRC09:14
johnthetubaguyyuywz: hmm, thats odd, I was just taking a glance at the code we use underneath: https://github.com/testing-cabal/fixtures/blob/master/fixtures/_fixtures/monkeypatch.py09:14
*** jwcroppe has joined #openstack-nova09:15
*** tpepper has joined #openstack-nova09:17
*** shaohe_feng has joined #openstack-nova09:17
johnthetubaguyyuywz: where are you using that code, depends what self is at that point, I am just looking at here: https://github.com/openstack/nova/blob/master/nova/tests/unit/fake_notifier.py#L7809:18
*** pkoniszewski has joined #openstack-nova09:18
*** jwcroppe has quit IRC09:20
johnthetubaguyif you have a patch in gerrit, its easier to see the context and help, most of the time I would mock out only the method I care about, I guess, not sure if that helps here09:20
*** shaohe_feng has quit IRC09:21
yuywzjohnthetubaguy: thanks for your help, sorry I don't have a patch at hand, will upload one later09:22
johnthetubaguyyuywz: no worries09:22
*** shaohe_feng has joined #openstack-nova09:22
*** tpepper has quit IRC09:23
*** tpepper has joined #openstack-nova09:24
*** tbachman has quit IRC09:26
*** salv-orlando has joined #openstack-nova09:27
*** Daisy has quit IRC09:27
*** Daisy has joined #openstack-nova09:28
*** daemontool has quit IRC09:28
*** Drankis has joined #openstack-nova09:29
openstackgerritLaszlo Hegedus proposed openstack/nova: Add versioned exception notifications  https://review.openstack.org/31070009:30
*** tbachman has joined #openstack-nova09:30
*** shaohe_feng has quit IRC09:32
*** salv-orlando has quit IRC09:32
*** jlanoux has quit IRC09:32
*** palexster has quit IRC09:32
*** shaohe_feng has joined #openstack-nova09:33
*** Daisy_ has joined #openstack-nova09:33
*** jlanoux has joined #openstack-nova09:36
*** Daisy has quit IRC09:36
*** salv-orlando has joined #openstack-nova09:38
*** salv-orlando has quit IRC09:38
*** salv-orlando has joined #openstack-nova09:38
*** markus_z has joined #openstack-nova09:41
*** shaohe_feng has quit IRC09:42
*** shaohe_feng has joined #openstack-nova09:45
markus_znova-bugs team meeting in 10 min in #openstack-meeting-4. New contributors are welcome as well. https://wiki.openstack.org/wiki/Meetings/Nova/BugsTeam09:49
*** Daisy_ has quit IRC09:49
*** Daisy has joined #openstack-nova09:50
*** iceyao_ has joined #openstack-nova09:51
*** iceyao has quit IRC09:51
*** shaohe_feng has quit IRC09:52
*** shaohe_feng has joined #openstack-nova09:53
*** tbachman has quit IRC09:55
openstackgerritLaszlo Hegedus proposed openstack/nova: Add versioned exception notifications  https://review.openstack.org/31070009:59
*** cheneydc has quit IRC09:59
*** roeyc has joined #openstack-nova10:01
markus_znova-bugs meeting started in #openstack-meeting-410:01
*** shaohe_feng has quit IRC10:02
*** mvk has quit IRC10:03
*** shaohe_feng has joined #openstack-nova10:03
*** mvk has joined #openstack-nova10:04
*** houming_ has joined #openstack-nova10:05
*** roeyc has quit IRC10:05
*** houming has quit IRC10:06
*** houming_ is now known as houming10:06
*** gcb has quit IRC10:06
*** daemontool has joined #openstack-nova10:08
*** cdent has joined #openstack-nova10:09
*** jaosorior has quit IRC10:09
*** iceyao_ has quit IRC10:09
*** jaosorior has joined #openstack-nova10:09
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334510:10
*** jwcroppe has joined #openstack-nova10:10
*** sdague has joined #openstack-nova10:12
*** shaohe_feng has quit IRC10:13
openstackgerritSean Dague proposed openstack/nova: Complete method verification of os-security-group-rules  https://review.openstack.org/31426410:13
*** shaohe_feng has joined #openstack-nova10:13
*** jwcroppe has quit IRC10:15
openstackgerritClaudiu Belu proposed openstack/nova: objects: Removes base code that already exists in o.vo  https://review.openstack.org/30704110:17
*** eglynn has joined #openstack-nova10:17
*** tbachman has joined #openstack-nova10:17
johnthetubaguysdague: I was thinking about that change to remove the tenant_id from the URL, so we just talk about things in addition to the service catalog10:18
johnthetubaguysdague: I am assuming thats waiting till after this sprint?10:18
*** kolesovdv has joined #openstack-nova10:18
sdaguejohnthetubaguy: yeh10:18
sdagueotherwise it's just a giant merge conflict for everyone10:18
johnthetubaguyyeah, ack10:19
johnthetubaguysdague: this patch is blocking the merge of an approved docs patch: https://review.openstack.org/#/c/313959/10:19
*** gcb has joined #openstack-nova10:19
johnthetubaguysdague: the expected 404 on lists where the marker is currently outputting 400 instead, what do you think we should do in the docs for the moment? I think we have some folks adding 404, and some folks excluding it10:22
*** shaohe_feng has quit IRC10:23
*** shaohe_feng has joined #openstack-nova10:24
openstackgerritClaudiu Belu proposed openstack/nova: Compute: Adds driver disk_gb instance overhead estimation  https://review.openstack.org/23428310:25
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: Fixes disk overhead claim issue  https://review.openstack.org/24630710:25
*** claudiub has joined #openstack-nova10:25
*** smatzek has joined #openstack-nova10:25
*** liverpooler has quit IRC10:26
*** liverpooler has joined #openstack-nova10:26
*** jlanoux_ has joined #openstack-nova10:29
*** jlanoux has quit IRC10:30
*** EinstCra_ has quit IRC10:30
*** smatzek has quit IRC10:30
*** tbachman_ has joined #openstack-nova10:30
sdaguejohnthetubaguy: yeh, it's a good question. I hadn't really been thinking too hard on those error codes when we got started. I kind of felt like we need a separate error codes section to talk them through in detail.10:31
*** EinstCrazy has joined #openstack-nova10:31
openstackgerritClaudiu Belu proposed openstack/nova: Fixes python 3 unit tests  https://review.openstack.org/27881010:31
openstackgerritClaudiu Belu proposed openstack/nova: Fixes python 3 urllib quote / unquote usage  https://review.openstack.org/27880910:31
johnthetubaguysdague: I noticed your nice comments on the how errors happen in one section, I could see that being a thing10:31
openstackgerritClaudiu Belu proposed openstack/nova: compute: fixes python 3 related unit tests  https://review.openstack.org/30026210:32
sdagueyeh, servers was complicated enough I didn't want to loose what I'd discovered10:32
johnthetubaguy+110:32
*** smatzek has joined #openstack-nova10:33
*** shaohe_feng has quit IRC10:33
openstackgerritClaudiu Belu proposed openstack/nova: libvirt: fixes python 3 related unit tests  https://review.openstack.org/27883410:33
openstackgerritClaudiu Belu proposed openstack/nova: libvirt: fixes python 3 related unit tests  https://review.openstack.org/27883410:33
openstackgerritClaudiu Belu proposed openstack/nova: numa: Fixes NUMA topology related unit tests  https://review.openstack.org/27883510:34
*** shaohe_feng has joined #openstack-nova10:34
*** tbachman has quit IRC10:34
*** tbachman_ is now known as tbachman10:34
*** EinstCrazy has quit IRC10:35
*** hoangcx has quit IRC10:37
*** sdake has quit IRC10:42
*** Daisy_ has joined #openstack-nova10:42
*** shaohe_feng has quit IRC10:43
johnthetubaguysdague: I wasn't sure about this one: https://review.openstack.org/#/c/314287/1/api-ref/source/os-fping.inc@31 am I miss-reading something?10:44
*** shaohe_feng has joined #openstack-nova10:44
sdagueah, yeh, 404 probably shouldn't be in that list.10:44
*** Daisy has quit IRC10:46
*** rodrigods has quit IRC10:49
*** rodrigods has joined #openstack-nova10:49
openstackgerritJohn Garbutt proposed openstack/nova: Complete method verification of os-fping  https://review.openstack.org/31428710:49
sdaguehttps://review.openstack.org/#/c/313532 would be really good to get in, mriedem thought he found a thing, but the code is just confusing10:50
johnthetubaguysdague: talking a look10:50
*** Daisy_ has quit IRC10:50
*** Daisy has joined #openstack-nova10:51
*** abalutoiu has joined #openstack-nova10:51
openstackgerritjichenjc proposed openstack/nova: WIP: api-ref keypair update  https://review.openstack.org/31450210:52
*** shaohe_feng has quit IRC10:54
*** shaohe_feng has joined #openstack-nova10:54
*** Daisy has quit IRC10:56
*** laszloh has quit IRC10:58
*** gcb has quit IRC11:00
*** sacharya has joined #openstack-nova11:01
*** shaohe_feng has quit IRC11:04
*** shaohe_feng has joined #openstack-nova11:05
*** jwcroppe has joined #openstack-nova11:05
*** sacharya has quit IRC11:05
*** sdake has joined #openstack-nova11:07
openstackgerritJohn Garbutt proposed openstack/nova: api-ref: complete verification for extensions resource  https://review.openstack.org/31410111:09
*** mnestratov has joined #openstack-nova11:10
*** jwcroppe has quit IRC11:11
*** gcb has joined #openstack-nova11:12
*** shaohe_feng has quit IRC11:14
*** shaohe_feng has joined #openstack-nova11:15
openstackgerritSylvain Bauza proposed openstack/nova: Verify requested_destination in the scheduler  https://review.openstack.org/31450911:17
*** dims has quit IRC11:20
*** jaosorior has quit IRC11:20
*** jaosorior has joined #openstack-nova11:20
*** swamireddy has quit IRC11:23
*** palexster has joined #openstack-nova11:24
*** shaohe_feng has quit IRC11:24
*** dims has joined #openstack-nova11:25
*** kengo_sakai has quit IRC11:25
*** shaohe_feng has joined #openstack-nova11:25
*** rtheis has joined #openstack-nova11:29
openstackgerritjichenjc proposed openstack/nova: WIP: api-ref keypair update  https://review.openstack.org/31450211:30
*** gcb has quit IRC11:33
*** shaohe_feng has quit IRC11:35
*** shaohe_feng has joined #openstack-nova11:35
*** apoorv has quit IRC11:36
*** jaosorior has quit IRC11:42
*** jaypipes has quit IRC11:43
*** jaosorior has joined #openstack-nova11:43
*** allen_gao has quit IRC11:44
*** shaohe_feng has quit IRC11:45
*** jaypipes has joined #openstack-nova11:45
*** shaohe_feng has joined #openstack-nova11:45
sdaguejohnthetubaguy: https://review.openstack.org/#/c/314257/ is an easy one11:45
*** gcb has joined #openstack-nova11:47
*** baoli has joined #openstack-nova11:50
*** lucasagomes is now known as lucas-hungry11:52
openstackgerritTakashi NATSUME proposed openstack/nova: Pass BDM in swap_volume method of LibvirtDriver  https://review.openstack.org/25713511:52
*** baoli_ has joined #openstack-nova11:53
openstackgerritSean Dague proposed openstack/nova: Denormalize extensions for clarity  https://review.openstack.org/31452111:53
*** shaohe_feng has quit IRC11:55
*** baoli has quit IRC11:56
*** shaohe_feng has joined #openstack-nova11:56
*** sdake has quit IRC11:56
*** gcb has quit IRC11:58
sdaguejohnthetubaguy: https://review.openstack.org/314521 hopefully would have made the confusion mriedem ran into less confusing11:59
*** roeyc has joined #openstack-nova12:02
*** sdake has joined #openstack-nova12:02
*** shaohe_feng has quit IRC12:05
*** shaohe_feng has joined #openstack-nova12:06
*** houming has quit IRC12:06
*** roeyc has quit IRC12:07
openstackgerritTakashi NATSUME proposed openstack/nova: Set 'serial' to new volume ID in swap volumes  https://review.openstack.org/25713512:07
*** PaulMurray has quit IRC12:08
*** ozialien10 has quit IRC12:08
*** sdake_ has joined #openstack-nova12:08
*** ozialien10 has joined #openstack-nova12:09
*** sdake has quit IRC12:11
*** gcb has joined #openstack-nova12:11
*** haukebruno has quit IRC12:12
tdurakovwhere this folder is used in nova: https://github.com/openstack/nova/blob/master/api-ref/ ?12:12
johnthetubaguytdurakov: in the doc build system, see tox.ini12:13
tdurakovjohnthetubaguy: ok, and where is it available then?12:14
tdurakovhere http://developer.openstack.org/api-ref-compute-v2.1.html ?12:14
johnthetubaguytdurakov: was just getting that url, its here: http://developer.openstack.org/api-guide/compute/12:14
johnthetubaguytdurakov: the one you linked is in the api-site, be we are currently moving that12:14
johnthetubaguytdurakov: oh, wait, did I get mixed up there12:15
johnthetubaguyyeah, I did12:15
johnthetubaguytdurakov: it goes here: http://developer.openstack.org/api-ref/compute/12:15
*** rfolco has joined #openstack-nova12:15
*** shaohe_feng has quit IRC12:16
johnthetubaguytdurakov: its soon replacing the api-site stuff that is here: http://developer.openstack.org/api-ref-compute-v2.1.html12:16
*** pradk has joined #openstack-nova12:16
*** shaohe_feng has joined #openstack-nova12:16
sdaguetdurakov: we're doing a sprint this week to try to get through verifying the content before replacing the links12:17
tdurakovjohnthetubaguy: that makes sense, thank you for details, the original problem: couldn't find this line here: http://developer.openstack.org/api-ref-compute-v2.1.html12:17
tdurakovsdague: could be interesting^12:17
*** sree has joined #openstack-nova12:17
tdurakovthis line: https://github.com/openstack/nova/blob/master/api-ref/source/servers-admin-action.inc#L13012:17
sdaguetdurakov: right, that content has been split as of 3 weeks ago12:18
johnthetubaguytdurakov: for completeness, this is the old stuff we are soon to delete: https://github.com/openstack/api-site/tree/master/api-ref/src/wadls/compute-api/src/v2.1/wadl12:20
tdurakovsdague: acked, one more question, is it about latest api version only?12:20
sdaguetdurakov: no, there is some support for microversions, and more will be added12:21
tdurakovsdague: how is it possible to check api for prev microversion for example?12:22
*** svenkat has joined #openstack-nova12:22
tdurakovjohnthetubaguy: i believe you remember context of this change: https://review.openstack.org/#/c/287997/ could you please review it again?12:23
sdaguetdurakov: http://docs-draft.openstack.org/32/313532/9/check/gate-nova-api-ref/5ed64d6//api-ref/build/html/#create-server12:24
*** aysyd has joined #openstack-nova12:24
johnthetubaguytdurakov: deep in other topics right now, but will try get to that12:25
tdurakovjohnthetubaguy: that would be great, thanks in advance!12:26
*** shaohe_feng has quit IRC12:26
*** shaohe_feng has joined #openstack-nova12:26
tdurakovsdague: acked12:26
*** sree has quit IRC12:28
*** ivase has joined #openstack-nova12:33
ildikovjohnthetubaguy: hi12:33
johnthetubaguyildikov: hi12:33
openstackgerritjichenjc proposed openstack/nova: WIP: api-ref keypair update  https://review.openstack.org/31450212:35
ildikovjohnthetubaguy: I just wanted to check whether the Thursday 1700UTC slot work for you for the CInder-Nova follow up meetings12:35
ildikovjohnthetubaguy: that is planned to be IRC meeting only12:35
*** shaohe_feng has quit IRC12:36
ildikovjohnthetubaguy: I uploaded an updated version for the multiattach spec, if theres any issue with it we can discuss as well beyond the follow ups on each item12:36
johnthetubaguyildikov: its tricky for me on the thursday, I wasn't really sure I was needed to keep things moving along though?12:37
*** shaohe_feng has joined #openstack-nova12:37
*** liverpooler has quit IRC12:38
openstackgerritClaudiu Belu proposed openstack/nova: libvirt: fixes python 3 related unit tests  https://review.openstack.org/27883412:38
openstackgerritClaudiu Belu proposed openstack/nova: numa: Fixes NUMA topology related unit tests  https://review.openstack.org/27883512:39
ildikovjohnthetubaguy: I will not force you :)12:40
*** burgerk has joined #openstack-nova12:40
ildikovjohnthetubaguy: but if you would like to then I can try to find another slot12:40
ildikovjohnthetubaguy: also if you have concerns regarding the spec and cannot attend the meeting, can you add comments on the review please?12:41
openstackgerritMoshe Levi proposed openstack/nova: pci: Move PCI devices and PCI requests into migration context  https://review.openstack.org/30712412:42
johnthetubaguyildikov: will do, do you have the spec link handy?12:43
ildikovjohnthetubaguy: https://review.openstack.org/#/c/304681/12:44
ildikovjohnthetubaguy: thanks12:44
johnthetubaguyildikov: ah, good good, I will try get to that one today12:44
ildikovjohnthetubaguy: tnx much12:44
*** thorst_ has joined #openstack-nova12:45
*** dedery__ has quit IRC12:45
*** shaohe_feng has quit IRC12:46
*** shaohe_feng has joined #openstack-nova12:47
openstackgerritJohn Garbutt proposed openstack/nova: Get support matrix notes from the ini file  https://review.openstack.org/26476312:48
*** thorst_ has quit IRC12:49
*** salv-orlando has quit IRC12:49
*** palexster has quit IRC12:49
*** thorst_ has joined #openstack-nova12:49
*** palexster has joined #openstack-nova12:50
*** lucas-hungry is now known as lucasagomes12:51
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Allow user to define the shutdown method through API when stop instances  https://review.openstack.org/29379012:51
openstackgerritjichenjc proposed openstack/nova: WIP: api-ref keypair update  https://review.openstack.org/31450212:51
*** Daisy has joined #openstack-nova12:51
*** sree has joined #openstack-nova12:53
johnthetubaguymarkus_z: I am wondering if we should really have an official deprecation cycle on this one, we should be OK to drop that image service code though: https://review.openstack.org/#/c/31414612:53
*** jwcroppe has joined #openstack-nova12:53
markus_zjohnthetubaguy: Hm? I'm already removing them completely without deprecation.12:54
*** edmondsw has joined #openstack-nova12:55
markus_zOr are you concerned about the release note?12:56
*** shaohe_feng has quit IRC12:57
johnthetubaguymarkus_z: I was worried about the removing them, because we were talking about making the service fail to start if you have an "invalid" config12:57
*** shaohe_feng has joined #openstack-nova12:57
*** EinstCrazy has joined #openstack-nova12:57
*** Daisy has quit IRC12:57
*** jlanoux has joined #openstack-nova12:58
*** jwcroppe has quit IRC12:58
markus_zjohnthetubaguy: Ah, ok, got it. I've read your first sentence wrongly.12:59
*** psargent has joined #openstack-nova12:59
markus_zjohnthetubaguy: We don't lose anything if we chose to deprecate it first, I'm fine with that. Can you leave me a -1 with a short note on that?13:00
*** gjayavelu has joined #openstack-nova13:00
*** jlanoux_ has quit IRC13:00
*** amotoki has quit IRC13:01
*** sacharya has joined #openstack-nova13:02
johnthetubaguymarkus_z: totally, let a note13:02
johnthetubaguyleft^13:02
markus_zthanks, I'm going to update this today13:02
markus_zjaypipes: Do you have a minute?13:03
*** dave-mccowan has joined #openstack-nova13:03
jaypipesmarkus_z: yup!13:03
*** salv-orlando has joined #openstack-nova13:03
markus_zjaypipes: I'm looking at https://github.com/openstack/nova/blob/master/nova/image/download/file.py to move the options and it looks a little strange to me.13:04
markus_zjaypipes: IIUC one can introduce new nova.conf sections by another config option CONF.image_file_url.filesystems13:05
*** rlrossit has joined #openstack-nova13:05
markus_zjaypipes: And I'm wondering if this is really something which gets used in production13:05
*** andymaier_ has joined #openstack-nova13:05
markus_zjaypipes: Feels like "bring your own interface"13:06
markus_zand makes deprecation harder13:06
*** nkrinner is now known as nkrinner_afk13:06
markus_zlong story short, is this file download from glance really a thing?13:06
*** sacharya has quit IRC13:06
jaypipesmarkus_z: yes, it's awful.13:06
markus_zThe author of that is not active anymore, otherwise I would ping him13:07
jaypipesmarkus_z: RAX is the only one that was using it, AFAIK. perhaps johnthetubaguy could comment on that?13:07
*** shaohe_feng has quit IRC13:07
*** cdent has quit IRC13:07
*** shaohe_feng has joined #openstack-nova13:07
jaypipesmarkus_z: my preference would be for that code to DIAF, frankly.13:08
markus_zjaypipes: yeah, my preference too :)13:08
*** akshai has joined #openstack-nova13:08
johnthetubaguyjaypipes: I don't think we have ever used that, we use glance13:09
markus_zjaypipes: Funnily, those options never got mentioned in the nova.conf.sample nor in the config reference because of the obscure way the are offered.13:09
jaypipesjohnthetubaguy: that *is* Glance :)13:10
*** mdrabe has joined #openstack-nova13:10
jaypipesjohnthetubaguy: it's just an abomination of code...13:10
markus_zIt's glance through the backdoor IIUC13:10
jaypipesmarkus_z: correct. it relies on a Glance v2 API for multiple image location properties and a hard-coded string prefix in the URIs for those image locations.13:11
johnthetubaguyjaypipes: hmm, OK, so I should look closer, I thought that was the file backend stuff, we use the swift backend13:11
*** edmondsw has quit IRC13:11
voelzmoHey @sdague, any advice on how we could proceed with https://bugs.launchpad.net/nova/+bug/1483132 ?13:11
openstackLaunchpad bug 1483132 in OpenStack Compute (nova) "ssh-keygen-to-Paramiko change breaks third-party tools" [Undecided,Won't fix]13:11
*** ctrath has joined #openstack-nova13:11
johnthetubaguyjaypipes: is this the thing ceph subclasses?13:11
jaypipesmarkus_z: all of that functionality should be in glance_store now, but we (Nova) have never integrated with glance_store appropriately.13:11
jaypipesjohnthetubaguy: no. it's the "image download plugins" that John Bresnahan and Eddie Sheffield wrote.13:12
voelzmoparamiko has released 2.x with a fix moving back to DER encoding of keys, I guess we could update paramiko in nova to 2.x and make golang-based tooling happy again13:12
*** swamireddy has joined #openstack-nova13:12
*** swamireddy has quit IRC13:13
*** sree has quit IRC13:13
sdaguevoelzmo: yeh, I think we should bump to paramiko > 213:14
sdaguedoes that pass for projects?13:14
sdaguevoelzmo: I reopened the bug, thanks for getting it sorted upstream13:14
johnthetubaguyjaypipes: OK, looks funky, anyways, we generally use the XenServer plugins to do all the downloads and uploads to glance13:14
jaypipesmarkus_z: in any case, we can't get rid of it without a deprecation cycle anyway. in the meantime, some code can be pushed that pulls those conf options out of that file and into the common nova/conf/ directory.13:14
voelzmo@sdague: I've no idea on how to do this or how to test things, I'm just one of those guys suffering from that it is broken. Happy to submit a PR if I knew where to do that, though13:15
jaypipesjohnthetubaguy: yeah, that's why I always questioned whether that code was ever run anywhere..13:15
johnthetubaguyjaypipes: +1 on never run by us, AFAIK13:15
markus_zjaypipes: yep, was thinking the same, wasn't entirely sure how much effort to spent13:15
*** eharney has joined #openstack-nova13:15
markus_zjaypipes: Thanks! I'll make a patch for a move and another for the deprecation13:16
johnthetubaguymarkus_z: that sounds good, deprecate it13:16
jaypipescoolio.13:16
openstackgerritjichenjc proposed openstack/nova: WIP: api-ref keypair update  https://review.openstack.org/31450213:16
*** shaohe_feng has quit IRC13:17
*** kengo_sakai has joined #openstack-nova13:17
sdaguedims: you about?13:17
*** jamesden_ has joined #openstack-nova13:17
sdaguedims: why did you take paramiko out of https://review.openstack.org/#/c/314423/ ?13:17
*** kengo_sakai has quit IRC13:17
*** yamahata has joined #openstack-nova13:18
*** shaohe_feng has joined #openstack-nova13:18
*** kengo_sakai has joined #openstack-nova13:18
sdaguevoelzmo: ok, so in looking at the test results of https://review.openstack.org/#/c/314423/13:19
openstackgerritPaul Carlton proposed openstack/nova-specs: Use libvirt storage pools  https://review.openstack.org/31050513:19
sdaguethere will need to be a patch in nova that supports either 1.16 or 2.0 so that nova can roll forward gracefully here13:20
sdaguethen we can bring up the paramiko requirements13:20
*** thorst_ has quit IRC13:20
*** daemontool_ has joined #openstack-nova13:21
*** jichen has quit IRC13:21
voelzmo@sdague: I see 'paramiko' mentioned in the commit msg of the above change, but no paramiko related change seems to be done in there? What am I missing?13:22
voelzmoAh, first patchset tried to update paramiko to 2.013:22
sdagueright, and in the n-api logs you can see it failes13:22
*** vtech has quit IRC13:23
sdaguehttp://logs.openstack.org/23/314423/1/check/gate-tempest-dsvm-full/5b356ed/logs/screen-n-api.txt.gz?level=ERROR#_2016-05-10_06_49_00_54813:23
*** mriedem has joined #openstack-nova13:23
*** links has quit IRC13:23
*** daemontool has quit IRC13:24
voelzmosomething like @coreywright added to the original bug for nova? https://bugs.launchpad.net/nova/+bug/1483132/comments/1013:25
openstackLaunchpad bug 1483132 in OpenStack Compute (nova) "ssh-keygen-to-Paramiko change breaks third-party tools" [Low,Confirmed]13:25
openstackgerritLaszlo Hegedus proposed openstack/nova: Replace root volume during rebuild  https://review.openstack.org/30507913:25
sdaguevoelzmo: probably, though I'm not sure why it wasn't sumbitted via gerrit13:27
*** shaohe_feng has quit IRC13:27
*** gcb has quit IRC13:28
mriedemsdague: on https://review.openstack.org/#/c/314521/1/nova/api/openstack/compute/disk_config.py@148 shouldn't body_deprecated default to None?13:28
mriedemlike in access_ips and the way it was before the refactor13:28
sdaguemriedem: honestly, it's thrown away13:28
sdagueit was defaulting to None mostly so that different methods that don't have it could use it13:28
sdagueif we weren't going to be deleting extensions, I'd go and fix the unit tests to pass the 3rd parameter13:29
sdaguebecause, in real activity, that parameter isn't optional13:29
sdaguebut because it was made optional in common code, unit tests started expecting it13:29
*** shaohe_feng has joined #openstack-nova13:30
*** tongli has joined #openstack-nova13:30
openstackgerritSean Dague proposed openstack/nova: Denormalize extensions for clarity  https://review.openstack.org/31452113:31
*** hshiina has joined #openstack-nova13:31
sdaguemriedem: oh, I just fixed the typo comment13:31
sdagueif you want to reapprove13:31
mriedemdone13:32
mriedemnow i just have to come to terms with the bottom patch13:32
sdaguemriedem: yep13:32
*** thorst_ has joined #openstack-nova13:32
sdagueit's added stuff in parameters.yaml that other people want to use, so getting it in moves the ball forward.13:32
sdagueand we can continue to polish things in the future13:33
dansmithjohnthetubaguy: fwiw, we consider anything that changes the hashes unexpectedly in o.vo to be a breakage, unless we can't help it13:34
openstackgerritLudovic Beliveau proposed openstack/nova: Remove DictCompat from InstancePCIRequests object  https://review.openstack.org/31187013:34
dansmithjohnthetubaguy: just re: your comment about it not happening again.. I think this is the first time, and it was unintentional, a fix just hadn't merged13:34
*** takedakn has joined #openstack-nova13:34
openstackgerritLaszlo Hegedus proposed openstack/nova: Replace root volume during rebuild  https://review.openstack.org/30507913:34
*** gcb has joined #openstack-nova13:34
Kevin_Zhengmriedem: Hi, could you please review this one again? https://review.openstack.org/#/c/295595/13:35
mriedemKevin_Zheng: yeah13:35
johnthetubaguydansmith: no worries, I was curious, I certainly didn't remember that before13:35
openstackgerritSean Dague proposed openstack/nova: api-ref: complete verification of servers-action-crash-dump.inc  https://review.openstack.org/31456613:36
mriedemsdague: you could do the same denormalize in the personality extension13:36
*** efried has joined #openstack-nova13:36
sdaguemriedem: yeh, I can stack up that patch if you want13:36
claudiubmriedem: hello. since this is a feature parity feature, does it necessarely require a spec? https://blueprints.launchpad.net/nova/+spec/hyperv-vm-diagnostics13:36
mriedemclaudiub: i don't think so, however,13:37
mriedemclaudiub: we were just talked yesterday that we need a microversion in the diagnostics API to use the newer version of it which has the standardized values13:37
mriedems/talked/talking/13:37
mriedemand that would need a spec13:37
*** shaohe_feng has quit IRC13:38
mriedemclaudiub: so adding the support to the hyper-v driver should only be with the newer version (get_instance_diagnostics)13:38
mriedembut the rest api doesn't call that today, we need a microversion to add that13:38
*** shaohe_feng has joined #openstack-nova13:38
claudiubmriedem: i see. is there any work being done on the microversion?13:39
sdagueclaudiub: no, honestly, the gap was only really discovered in doing the api-ref sprint13:40
*** thorst__ has joined #openstack-nova13:40
*** burt has joined #openstack-nova13:40
sdaguethe infrastructure was all built for nova api v3, but rolled back when we went down the 2.1 path, and never got reproposed13:40
*** thorst__ has quit IRC13:40
*** edmondsw has joined #openstack-nova13:41
mriedemsdague: so i'm trying to sort out how these server_update extensions work, and it looks like in the servers api it loads the extensions from:13:41
mriedemEXTENSION_UPDATE_NAMESPACE = 'nova.api.v21.extensions.server.update'13:41
kashyapCells job seems to be failing, is it just me?13:41
mriedemkashyap: it's keystone13:41
* kashyap reads quickly greps the scrollback for any discussion on it13:41
sdaguemriedem: one sec13:41
claudiubjaypipes: hello. got a minute?13:41
mriedemsdague: nvm i see13:41
mriedemnova.api.v21.extensions.server.update =13:41
mriedem    access_ips = nova.api.openstack.compute.access_ips:AccessIPs13:41
mriedem    disk_config = nova.api.openstack.compute.disk_config:DiskConfig13:41
mriedemi was expecting server_update, not server.update13:41
*** thorst_ has quit IRC13:41
mriedemso those extensions register, servers.py loads them on init, and calls them when server_update is called13:42
kashyapmriedem: Oh, so it's a known issue?13:42
mriedempassing in the request13:42
sdaguemriedem: https://github.com/openstack/nova/blob/20e1d6c46446dba0e63b820afaa0660a24427afe/nova/api/openstack/compute/servers.py#L6913:42
sdaguemriedem: yep13:43
claudiubmriedem: also, should I add the "Previously-approved: Mitaka" line in the commit message? In PS2, you said that I should remove it. https://review.openstack.org/#/c/286520/313:43
openstackgerritPaul Carlton proposed openstack/nova-specs: Use libvirt storage pools  https://review.openstack.org/31050513:43
mriedempasses the request and mutable dict that we set values in which goes to instance.update13:43
mriedemok13:43
sdagueyeh13:43
*** PaulMurray has joined #openstack-nova13:43
*** zengine has joined #openstack-nova13:43
*** swamireddy has joined #openstack-nova13:44
*** cdelatte has joined #openstack-nova13:44
mriedemclaudiub: for host capabilities, the diff was not trivial, so i don't think previously-approved really applies here13:44
mriedemclaudiub: especially given all of the other specs around standardizing and exposing capabilities over the rest api13:45
claudiubmriedem: sure, but you said in PS3 that I should add it, which is why I'm asking this now. :)13:45
mriedemclaudiub: i'd like to see the scheduler subteam sort that out. i think edleafe said he's working on sorting out the various capabilities specs yesterday.13:45
mriedemclaudiub: ah, sorry for the confusion13:46
PaulMurraytdurakov, are you around ?13:46
tdurakovPaulMurray: hey13:46
*** thorst_ has joined #openstack-nova13:46
*** mdrabe_ has joined #openstack-nova13:46
kashyapThis is the test that seems to be failing consistently for me in the Cells job: tempest.api.compute.admin.test_migrations.MigrationsAdminTest.test_resize_server_revert_deleted_flavor13:47
kashyap"Server 35054938-f044-4230-b499-2043cd2a3e20 failed to reach VERIFY_RESIZE status and task state "None" within the required time (196 s)"13:47
*** gszasz has joined #openstack-nova13:47
mriedemkashyap: new test in tempest/13:47
mriedem?13:47
PaulMurraytdurakov, hi - I wanted to go over CI in LM meeting today - will you be able to do that ?13:47
tdurakovPaulMurray: there were spring holidays in Russia13:47
mriedemkashyap: actually i added that test13:47
kashyapmriedem: Fetching the Tempest Git locally to see13:47
*** mdrabe has quit IRC13:47
kashyapAh13:47
tdurakovPaulMurray: mostly working on the spec now13:48
*** shaohe_feng has quit IRC13:48
kashyapmriedem: It's for this change (you're familiar with): https://review.openstack.org/#/c/314012/13:48
mriedemkashyap: tempest.api.compute.admin.test_migrations.MigrationsAdminTest.test_resize_server_revert_deleted_flavor ... SKIPPED: Resize not available.13:48
tdurakovso, there will be little update13:48
tdurakovfor ci13:48
*** jwcroppe has joined #openstack-nova13:48
mriedemhmm, maybe the devstack change to skip those tests for cells isn't in stable/liberty13:48
*** kengo_sakai has quit IRC13:48
*** shaohe_feng has joined #openstack-nova13:48
PaulMurrayok - but worth catching up - we may need to do something related to storage pools13:49
kashyapmriedem: Ah, there's a check in DevStack to skip it13:49
kashyapLet me go look13:49
*** swamireddy has quit IRC13:49
PaulMurraycontinue in the meeting in a while13:49
mriedemkashyap: https://github.com/openstack-dev/devstack/blob/stable/mitaka/lib/tempest#L39013:49
* kashyap clicks13:50
*** thorst_ has quit IRC13:50
mriedemwe need this on stable/liberty https://review.openstack.org/#/c/242592/13:50
*** thorst_ has joined #openstack-nova13:50
mriedemthere could be a few of them that need backporting13:50
kashyapAh-ha13:51
*** thorst_ has quit IRC13:51
tdurakovPaulMurray: I'll be on weekly for live-migration, happy to help with storage pools13:51
mriedemkashyap: it's https://review.openstack.org/#/c/314576/ and https://review.openstack.org/#/c/242592/13:51
mriedemi'll stack those up13:52
*** esracelik has quit IRC13:52
kashyapmriedem: Ah, you already created the backports13:52
*** thorst_ has joined #openstack-nova13:52
mriedemkashyap: yeah, i broke it so i can fix it13:52
coreywrightsdague (voelzmo): i didn't submit that support-both-paramiko-1.x-and-2.x patch because i figured nova would just create a paramiko 2.x-only fix when the global constraints was upgraded rather than the ugly paramiko version testing and import within a function that my patch contains13:52
coreywrightbut i can submit it13:52
coreywrightby way of gerrit13:52
*** jwcroppe has quit IRC13:53
kashyapmriedem: Excellent.  It can get a straight-forward approval13:53
sdaguecoreywright: yeh, we need to because nova's tests are blocking the paramiko version bump13:53
coreywrightit's also ugly in that it will have a code path that's untested (as i doubt we are going to test in the gates with both paramiko 1.x and 2.x)13:53
*** sbelous_ has quit IRC13:53
sdagueso it's needed to roll past the issue13:53
coreywrightsdague: gotcha13:53
*** sbelous has joined #openstack-nova13:54
sdaguecoreywright: probably put in a comment that it's temporary until paramiko > 2 is required, then we'll make that change on global-requirements after13:54
sdagueonce landed, we can remove it13:54
coreywrightyes, i have comments in the commit message and the patch itself about what to do after the upgrade to paramiko 2.x13:55
mriedemkashyap: here is the backport https://review.openstack.org/#/c/314581/13:55
*** vladikr has joined #openstack-nova13:55
* kashyap clicks13:56
*** thorst_ has quit IRC13:56
*** takedakn has quit IRC13:56
PaulMurrayLive Migration meeting on #openstack-meeting-3 in a couple of minutes PaulMurray paul-carlton2 eliqiao shaohe_feng pkoniszewski jlanoux yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov andreas_s abhishekk diana_clarke13:56
*** yamahata has quit IRC13:57
kashyapsdague: Might want to fast-approve this DevStack change from mriedem?  Clean backport, fixes a real issue: https://review.openstack.org/#/c/314581/113:57
*** yamahata has joined #openstack-nova13:57
sdaguekashyap: yeh, I just did13:57
kashyapsdague: Damn, you already did it13:57
kashyap:-)13:57
kashyapThanks!13:57
*** prateek has quit IRC13:58
*** thorst_ has joined #openstack-nova13:58
*** shaohe_feng has quit IRC13:58
*** ametts has joined #openstack-nova13:58
*** shaohe_feng has joined #openstack-nova13:59
*** tonytan4ever has joined #openstack-nova13:59
*** hoangcx_ has joined #openstack-nova13:59
*** tbachman has quit IRC13:59
*** jwcroppe has joined #openstack-nova14:00
*** amotoki has joined #openstack-nova14:01
*** afazekas has quit IRC14:01
*** afazekas has joined #openstack-nova14:01
openstackgerritBrian Elliott proposed openstack/nova: Fix service version to update the DB  https://review.openstack.org/31423014:01
belliottdansmith: ^ test added for your viewing pleasure14:02
*** hoangcx_ is now known as hoangcx14:02
dansmithbelliott: cool, thanks14:03
*** roeyc has joined #openstack-nova14:03
dansmithmriedem: we need to backport that to mitaka ^14:03
*** tonytan4ever has quit IRC14:03
belliottlots of mox tests in there14:04
*** obondarev has quit IRC14:04
*** mtanino has joined #openstack-nova14:04
openstackgerritLudovic Beliveau proposed openstack/nova: Enable python34 tests for nova.tests.unit.pci.test_manager and test_stats  https://review.openstack.org/31097614:05
*** obondarev_ has joined #openstack-nova14:05
*** irenab has quit IRC14:05
jaypipesclaudiub: I do now :)14:06
*** ducttape_ has joined #openstack-nova14:06
mriedemdansmith: ok. was going to review https://review.openstack.org/#/c/302117/ after the live migration meeting and then i'll get to that.14:06
*** iceyao has joined #openstack-nova14:06
dansmithmriedem: oh sweet, I was going to annoy you about that too14:07
*** ducttape_ has quit IRC14:07
mriedemis there anything else?14:07
mriedem:P14:07
*** ducttape_ has joined #openstack-nova14:07
*** roeyc has quit IRC14:07
mriedemdansmith: maybe you want to review this in the meantime https://review.openstack.org/#/c/295595/14:07
claudiubjaypipes: cool. :) You said during the summit that you want a new table specifically for host_capabilities14:08
*** zz_dimtruck is now known as dimtruck14:08
dansmithmriedem: ugh14:08
*** hoangcx has quit IRC14:08
*** shaohe_feng has quit IRC14:08
*** ccarmack has joined #openstack-nova14:08
*** whenry has joined #openstack-nova14:08
*** shaohe_feng has joined #openstack-nova14:09
claudiubjaypipes: i have a question on how it will look. Since you probably want it to be fast, will it contain all the capabilities in a single table? Or have a table with id, capability_name and then a cross-table with compute_node_id, capability_id?14:09
jaypipesclaudiub: the latter. cross table with resource_provider_id, capability_id14:09
claudiubjaypipes: ok, cool. good to know.14:11
openstackgerritCorey Wright proposed openstack/nova: crypto: Add support for Paramiko 2.x  https://review.openstack.org/31459214:11
coreywrightsdague, voelzmo: paramiko 2.x support: https://review.openstack.org/31459214:12
jaypipesclaudiub: edleafe is working on a spec that cleans up the representation of much of that stuff.14:13
jaypipesclaudiub: in the DB/model layer14:13
jaypipesedleafe: feel free to link to spec :)14:14
mriedemclaudiub: i updated the whiteboard for https://blueprints.launchpad.net/nova/+spec/hyperv-vm-diagnostics on the direction14:14
mriedemclaudiub: a microversoin for the diagnostics api should be an easy add14:14
* edleafe is in never-ending meetings today14:14
markus_zmore meeting for all the people!14:16
markus_z*meetings14:16
markus_z;)14:16
claudiubjaypipes: edleafe: yeah, that could be useful, actually.14:17
kashyapmarkus_z: The other day Matt Booth pointed me to this excellent "Stop the bleeding of $$ from meetings" ticker https://tobytripp.github.io/meeting-ticker/14:18
markus_zkashyap: muahaha :D14:18
*** shaohe_feng has quit IRC14:19
*** lpetrut has quit IRC14:19
*** shaohe_feng has joined #openstack-nova14:19
*** lpetrut has joined #openstack-nova14:19
claudiubmriedem: cool, will let abalutoiu know. I don't think there's a blueprint for that yet, right?14:20
*** gjayavelu has quit IRC14:20
mriedemclaudiub: nope14:20
mriedemjust came up yesterday14:20
mriedemthe microversion will require a spec14:20
mriedembut it's pretty straight-forward14:20
claudiubindeed.14:20
openstackgerritSean Dague proposed openstack/nova: Denormalize personality extension  https://review.openstack.org/31460014:22
*** swamireddy has joined #openstack-nova14:23
sdaguecoreywright: https://review.openstack.org/#/c/314595/ should test your patch, and let us move forward14:23
markus_zhm, life's ironic sometimes... have to go to a meeting, back in ~ 1h14:23
*** markus_z has quit IRC14:23
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance rescue mode support  https://review.openstack.org/21767914:24
*** jaosorior has quit IRC14:24
openstackgerritClaudiu Belu proposed openstack/nova: Compute: Adds driver disk_gb instance overhead estimation  https://review.openstack.org/23428314:27
edleafeclaudiub: Here is the spec for passing qualitative requirements. https://review.openstack.org/#/c/313784/14:28
edleafeclaudiub: I don't have anything yet for changing how they are stored.14:28
*** shaohe_feng has quit IRC14:29
*** shaohe_feng has joined #openstack-nova14:29
dansmithalaski: good catch on that last patch, but unfortunately, the mistake was in the create-instance patch.. I never intended for it to be NULL if we create with no keypair14:29
mriedemmikal: you might want to review this https://review.openstack.org/#/c/313696/14:29
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: fix disk size calculation for VZ container instances  https://review.openstack.org/22256714:30
dansmithmriedem: I just tossed a supportive -1 on there14:33
mriedem<314:33
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance resize support  https://review.openstack.org/18225714:34
claudiubedleafe: thanks, will take a look.14:36
*** pushkaru has joined #openstack-nova14:37
alaskidansmith: a new patch shoved in before the migration would be fine, just as long as create starts populating before the migration14:38
doffmedleafe: About yout qualative requirements spec. Have you posted anything to the operators list to get feedback yet?14:38
dansmithalaski: I'm fixing it in place already14:38
*** burgerk has quit IRC14:38
dansmithalaski: still waiting on doffm to update the spec anyway14:38
doffmdansmith: Meeting soon. Will do so before lunch.14:39
dansmithdoffm: cool14:39
*** thorst_ has quit IRC14:39
edleafedoffm: no, but that's a good idea. Did anything jump out at you from that spec?14:39
*** shaohe_feng has quit IRC14:39
*** thorst_ has joined #openstack-nova14:39
*** shaohe_feng has joined #openstack-nova14:40
*** belmoreira has quit IRC14:40
doffmedleafe: I think users will like it, but i'm not sure about operators, as billing gets more complicated, and they will have more combinations of instances floating around.14:42
*** jamie_h has joined #openstack-nova14:42
doffmWould be good to see some operator feedback.14:42
*** thorst_ has quit IRC14:44
openstackgerritDan Smith proposed openstack/nova: Create Instances with keypairs  https://review.openstack.org/31275114:45
openstackgerritDan Smith proposed openstack/nova: Add Keypairs to the API database  https://review.openstack.org/31275514:45
openstackgerritDan Smith proposed openstack/nova: Make Keypair object favor the API database  https://review.openstack.org/31275614:45
openstackgerritDan Smith proposed openstack/nova: Add online migration to move keypairs from main to API database  https://review.openstack.org/31366414:45
openstackgerritDan Smith proposed openstack/nova: Add online migration to store keypairs with instances  https://review.openstack.org/31306014:45
*** pwnall has joined #openstack-nova14:46
edleafedoffm: yeah, that's along the lines of what I expected. Do you see any other way to get away from the kind of flavor explosion that adding qualitative requirements will result in?14:47
*** shaohe_feng has quit IRC14:49
*** shaohe_feng has joined #openstack-nova14:50
*** cdent has joined #openstack-nova14:52
doffmedleafe: I guess provide the tools to operators to state what options are available on what flavors.14:52
*** pcaruana has joined #openstack-nova14:53
*** mariojv has left #openstack-nova14:53
*** thorst_ has joined #openstack-nova14:54
*** mriedem is now known as mriedem_meeting14:55
*** ctrath has quit IRC14:56
*** voelzmo has quit IRC14:57
*** abalutoiu has quit IRC14:58
*** pwnall has quit IRC14:58
*** thorst_ has quit IRC14:58
*** pwnall has joined #openstack-nova14:58
*** shaohe_feng has quit IRC15:00
*** davidgiluk has joined #openstack-nova15:00
*** ctrath has joined #openstack-nova15:00
*** shaohe_feng has joined #openstack-nova15:00
PaulMurraymdbooth, paul-carlton pkoniszewski I think that discussion is a long and tangled one15:00
mdboothSo, I think these are all the same spec: https://review.openstack.org/#/c/248358/ https://review.openstack.org/#/c/306561/ https://review.openstack.org/#/c/301509/15:00
pkoniszewskiPaulMurray: yeah, it is15:00
*** zengine has quit IRC15:01
mdboothThey're all about causing a migration to complete. They should be designed together.15:01
mdboothThey all require each other as context.15:01
tdurakovtonyb: hi, are you around?15:01
davidgilukmdbooth: Yeh there's some subtelty - postcopy can force completion, auto-converge might not15:01
paul-carltonmaybe, happy to fold the other two into my spec if you like but I am concerned that will lead to nothing getting approved15:02
pkoniszewskiwell, post copy and auto converge specs are about adding a flag for admin to force these two things15:02
mdboothdavidgiluk: But it's just that: subtlety15:02
mdboothpkoniszewski: Right, and having the design of those 2 flags in 2 different specs is bad15:02
PaulMurraymdbooth, paul-carlton pkoniszewski I want to be in this discussion but I have to go get my daughter - go on without me, but I will catch up later15:02
davidgilukmdbooth: Yeh I agree they're related15:02
pkoniszewskipaul-carlton specs is about implementing some kind of an automated mechanism in nova to take care of migrations15:02
mdboothBecause they're both highly related15:02
paul-carltonbetter to approve post-copy, it is simple to do15:02
danpbdavidgiluk: well auto-converge will converge - as it eventually throttles to 99%15:02
pkoniszewskiwhats more is that auto converge might not force to complete15:02
danpbunless you have awful network bandwidth15:03
pkoniszewskieven if you throttle down by 99% it might still not end15:03
pkoniszewskiand 100% is pause15:03
davidgilukpkoniszewski: Yeh I'm OK with them being separate specs, as long as they turn into something that cooperates between them15:03
danpbi agree with mdbooth though, we should really just have one spec IMHO15:03
*** thorst_ has joined #openstack-nova15:03
danpbit doesn;t make sense to try to design use of each feature in isolation15:03
PaulMurraydanpb, mdbooth I agree - the question was about how long it will take15:04
PaulMurrayI can't see that being agreed in next couple of weeks15:04
pkoniszewskidanpb: do we want to put flags and all automated stuff in one spec? + all things requires for post-copt support in nova?15:04
danpbPaulMurray: imho it'll take longer to get approved with 3 specs than with 115:04
pkoniszewskidanpb: instead of doing it in small, and honestly doable, small pieces?15:04
PaulMurrayif it has to be agreed first then so be it, but just thinking practically15:04
paul-carltondanpb ok, happy to fold the auto-converge and post-copy into my spec if you would prefer15:04
danpbnot least because it makes it harder for the reviewer to see wtf the big picture is when you have to switch back & forth between reading 3 specs15:04
PaulMurraywe still need to work out how to expose15:04
*** Jeffrey4l_ has quit IRC15:05
danpbPaulMurray: what do you mean by that ?15:05
PaulMurraydanpb, which bit ?15:05
PaulMurrayhow to expose ?15:05
danpbPaulMurray: "we still need to work out how to expose"15:05
paul-carltonFollowing, danpb's comments on my spec I think we have a reasonable solution which could be approved and implemented15:06
*** mdrabe_ has quit IRC15:06
PaulMurrayI meant the discussion about how the options are presented through the API15:06
danpbthere's nothing to be exposed in the API at all15:06
mdboothdanpb: That's really my issue. I have difficulty getting the context, and I've been actively trying to follow it.15:06
*** xenogear has joined #openstack-nova15:06
danpbthis is exclusively something to be done inside the nova libvirt driver15:06
paul-carltonit pretty much requires the post-copy feature to be effective, auto-converge is not particularly useful from what I'm hearing15:07
danpbyes & no - auto-converge is good at convergance at the cost of high guest impact15:07
*** gagehugo has joined #openstack-nova15:07
danpbso if you have a choice between post-copy + auto-converge then pick post-copy15:07
mdboothdanpb: I think you showed that post-copy has lower impact than auto-converge, right?15:08
* PaulMurray I really do have to go15:08
danpbnb that post-copy requires a newer qemu version than auto-converge15:08
* PaulMurray will be back soon15:08
danpbso for some people auto-converge will be the only available option15:08
mdboothThe other thing is, I believe my understanding of the risk in post-copy was wrong.15:08
paul-carltonYes we already have live-migration-force-complete, we'd just change the implementation when post copy is available to do that instead of pause15:09
mdboothI'd been hearing talk of migrations 'failing' 90% of the time, which was used in the context of an argument against post-copy15:09
danpbmdbooth: there is a risk in post-copy, but I believe the severity of the risk is rather over-blown15:09
mdboothBut the 'failure' here is actually failure to converge15:09
luis5tbbut, besides forcing completion, why post-copy cannot be the default option (if the admin decides so)15:09
mdboothWhich wouldn't happen with post-copy15:09
*** sacharya has joined #openstack-nova15:09
*** shaohe_feng has quit IRC15:10
mdboothSo yes, to me the additional failure mode of post-copy actually seems pretty much irrelevant15:10
davidgilukmdbooth: Right, with postcopy you get no convergence failures, but if you lose network during the postcopy phase you're stuck15:10
mdboothdavidgiluk: Right. But if you lose network without postcopy you're also stuck.15:10
mdboothSo it's a failure case either way.15:10
danpbthat risk of network failure is pretty tiny if you have redundancy in your network too15:10
davidgilukmdbooth: No15:10
paul-carltonpost-copy exposes the instance to the risk of failure but a reboot will recover it15:10
davidgilukmdbooth: If you lose network on the migration network then the source can carry on running15:11
*** shaohe_feng has joined #openstack-nova15:11
*** rmart04 has joined #openstack-nova15:11
davidgilukmdbooth: That's no longer the case with postcopy (We do have a GSoC student looking at recovery from net failure)15:11
mdboothdavidgiluk: What are the chances of losing the migration network, but not all other networking, though?15:11
danpbmdbooth: its non-zero, but IMHO small enough that most people won't care15:12
*** sridharg has quit IRC15:12
danpbparticularly if they have network bonding failover15:12
*** sudipto has joined #openstack-nova15:12
mdboothRight. It's pretty much theoretical afaict.15:12
*** irenab has joined #openstack-nova15:12
davidgilukmdbooth: Yeh I mean it's just a risk, it's there but how paranoid depends on your workload/personality/etc15:12
mdboothIf you lose network, it's likely because the cleaner unplugged it (metaphorically)15:12
danpband in cloud we tell people their VMs can die unrecoverably at any time regardless15:12
mdboothIn which case you lose the lot15:12
paul-carltonluis5tb, I think the default should be the status quo, i.e. no post-copy, if the cloud operator wants to turn it on then they should do so15:12
mdboothAnd in that case your instance is useless anyway15:12
danpbpeople can call them "pets" but they have to accept there's a non-zero chance of their pet going away15:12
danpbpaul-carlton: i rather disagree - the default should be post-copy15:13
luis5tbpaul-carlton: I agree, but if the operator want to change it, we should provide a way (at nova.conf) to do it, right?15:13
danpbpaul-carlton we should not default to a config that is guaranteed to never complete for many workloads15:13
*** mageshgv has joined #openstack-nova15:13
danpbwe should default to post-copy because it "just works" and let people turn it off if they absolutely insist they don't want it15:13
*** jdurgin1 has joined #openstack-nova15:14
*** burgerk has joined #openstack-nova15:14
mdboothAlso, post-copy only needs to transfer the working set to be fast again15:14
paul-carltondanpb ok by me, release note can cover risks15:14
*** abalutoiu has joined #openstack-nova15:14
* davidgiluk would default to disabling it for now and then if people find they use it a lot and are happy then we can always flip to enable by default later?15:14
danpbwe generally try to avoid having config options that amount to telling the user to set   "make_it_work=yes"15:15
mdboothYou might have a workaround to turn it off15:15
luis5tband then, if post-copy is enabled by default, it should change migration to postcopy mode as soon as possible?15:16
danpbluis5tb: no, there should be active monitoring by nova to decide when its appropriate15:16
danpbluis5tb: if you switch to post-copy too soon you uneccessarily penalize performance15:16
dansmithIMHO, changing the default right now is probably not the best plan15:16
dansmithbased on the feedback in the room when we discussed it15:16
danpbyou want to run in pre-copy mode for some period of time and monitor progress - if it stops making progress then you should switch to post-copy15:17
mdboothdansmith: This was my point earlier, though. I think the feedback in the room was based on misinformation.15:17
dansmithmdbooth: it doesn't really matter I don't think15:17
danpbdansmith: i wasn't there to hear what was said, but i don't see a compelling reason not to enable it by default honestly15:17
dansmithmdbooth: changing defaults always has some impact and aspect of surprise15:17
mdboothdansmith: I think it's grown unnecessarily into a bogeyman, which very few people will ever care about in practise.15:18
dansmithdanpb: it immediately makes live migrations more risky15:18
danpbit is clearly better than the current situation in that it actually works reliably15:18
dansmithI hear you15:18
danpbdansmith: the risk is overblown really15:18
*** mdrabe has joined #openstack-nova15:19
paul-carltonper https://review.openstack.org/#/c/306561 the proposal is that unless the operator indicates that the migration should be completed at all costs post-copy will only be used if the live-migration-force-complete operation is used15:19
danpbyes, there's a theoretical risk, but in practice if you're trying to evacuate a machine which is dieing15:19
dansmithdanpb: one of you said default it to post-copy and then later allow going back to the original model, or a workaround, or whatever, and I don't think that's a reasonable change to make15:19
danpbyou have the actual real risk of loosing all vms because you can't get them off the dieing machine in time15:19
*** irenab has quit IRC15:19
dansmithdanpb: there are plenty of reasons to live migrate other than imminent death of the host15:19
openstackgerritKaren Bradshaw proposed openstack/nova: api-ref: server shelve action  https://review.openstack.org/31462915:20
*** shaohe_feng has quit IRC15:20
danpbdansmith: and there are plenty of other failures that can hit VMs at any time in nova when no migration is taking place15:20
*** tbachman has joined #openstack-nova15:20
dansmithdanpb: I know15:20
*** shaohe_feng has joined #openstack-nova15:20
paul-carltonwhich is why I'm proposing the live-migration 'importance' flag to allow the operator to say this is a vital migration rather than a best effort one15:20
danpbthat are more likely than the new failure mode of post-copy15:20
mdboothdansmith: Either way, I think all of these things can be discussed in no more than 1 spec :)15:21
mdboothThere are currently 315:21
*** whenry has quit IRC15:21
dansmithmdbooth: surely :)15:21
mdboothpaul-carlton: I personally favour moving the other specs into your spec15:22
*** kbyrne has quit IRC15:22
paul-carltondanpb, I think you suggested a one spec approach too?15:23
*** chuck__ is now known as zul15:24
paul-carltonif so and luis5tb agrees I'll update my spec to incorporate the other two?15:24
danpbi've just -2d the two supplementary specs15:25
paul-carltonok, I'll update mine15:25
danpbso we have paul-carlton's as the main point15:25
*** jlanoux has quit IRC15:25
*** hemnafk is now known as hemna15:27
*** armax has joined #openstack-nova15:27
luis5tbok15:28
*** iceyao has quit IRC15:28
*** sacharya_ has joined #openstack-nova15:29
*** shaohe_feng has quit IRC15:30
*** sacharya has quit IRC15:31
*** abalutoiu has quit IRC15:31
*** shaohe_feng has joined #openstack-nova15:31
tdurakovmriedem_meeting: with the help of #openstack-infra folks we could you multinode with xenial, so I'll change image for live-migration job and we could compare it's stability15:32
*** zenoway has quit IRC15:32
*** zenoway has joined #openstack-nova15:33
*** kbyrne has joined #openstack-nova15:36
*** irenab has joined #openstack-nova15:36
*** mjura has quit IRC15:37
*** andreas_s has quit IRC15:37
*** zenoway has quit IRC15:38
*** rena9067 has joined #openstack-nova15:38
*** andymaier_ has quit IRC15:39
*** aysyd has quit IRC15:39
*** flwang has quit IRC15:39
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Work with latest paramiko 2.0.0  https://review.openstack.org/31463715:40
*** kbyrne has quit IRC15:40
*** itamarl has quit IRC15:40
*** shaohe_feng has quit IRC15:41
*** amotoki has quit IRC15:41
openstackgerritSean Dague proposed openstack/nova: Drop paramiko < 2 compat code  https://review.openstack.org/31463915:41
*** shaohe_feng has joined #openstack-nova15:41
sdaguedims: that patch is already up tehre15:41
*** mpavone has quit IRC15:41
dimssdague : ah did not notice. give me a sec15:42
PaulMurraydanpb, so looks like I missed the whole discussion, but just to note, I think of config options and API the same way15:42
PaulMurraydanpb, looks like you propose we just start using post-copy15:43
sdaguedims: sure, I linked to it and -2ed yours. If you find issues, let's work on coreywright's patch15:43
sdagueI've got a global requirements change stacked in there as well so we can see it working, and then delete the compat code after upgrade15:43
*** moshele has quit IRC15:44
*** aysyd has joined #openstack-nova15:44
*** kolesovdv has quit IRC15:45
jaypipessdague: hey, in Austin, you showed a link to some nice API devref documents that we are working on... do you have that link handy?15:45
*** markus_z has joined #openstack-nova15:45
*** paul-carlton1 has quit IRC15:46
openstackgerritSarafraj Singh proposed openstack/nova: [WIP] api-ref: image.inc - Update method validation  https://review.openstack.org/31426815:46
*** woodster_ has joined #openstack-nova15:46
*** yamahata has quit IRC15:47
sdaguejaypipes: in tree it's nova/api-ref15:47
openstackgerritAnusha Unnam proposed openstack/nova: api-ref: os-volumes.inc method verification  https://review.openstack.org/31432515:47
sdagueit publishes to http://developer.openstack.org/api-ref/compute/15:47
*** sdake_ has quit IRC15:47
jaypipessdague: thanks Sean, appreciated.15:48
sdaguealso, see all the api-ref emails, as we're sprinting this week to try to get the content up to snuff15:48
*** Oku_OS is now known as Oku_OS-away15:49
*** lpetrut has quit IRC15:49
*** gjayavelu has joined #openstack-nova15:50
*** sdake has joined #openstack-nova15:50
*** zenoway has joined #openstack-nova15:51
*** shaohe_feng has quit IRC15:51
markus_zclaudiub: Wanna have that in stable/mitaka? https://git.openstack.org/cgit/openstack/nova/commit/?id=94b40cf43ca3ab7d85fd15c8fda9baf8ed07f8a115:52
*** shaohe_feng has joined #openstack-nova15:52
*** tesseract has quit IRC15:52
*** sdake_ has joined #openstack-nova15:54
*** Sukhdev has joined #openstack-nova15:55
*** zenoway has quit IRC15:55
claudiubmarkus_z: hey, sure. it will reduce the amount of random py27 gate failures and it's an extremely simple commit. i think it's worth it.15:56
openstackgerritJohn Garbutt proposed openstack/nova: Config options: centralize scality libvirt options (15)  https://review.openstack.org/30935715:56
*** abalutoiu has joined #openstack-nova15:56
markus_zclaudiub: okidoki, I finish another thing, then do a backport15:56
*** ccarmack has quit IRC15:56
openstackgerritJohn Garbutt proposed openstack/nova: Config options: centralize smbfs libvirt options (16)  https://review.openstack.org/30936015:57
claudiubmarkus_z: cool, let me know when you're done. :)15:57
openstackgerritJohn Garbutt proposed openstack/nova: Config options: centralize remotefs libvirt options (end)  https://review.openstack.org/30936315:57
*** sdake has quit IRC15:57
*** PaulMurray has quit IRC15:57
*** flwang has joined #openstack-nova15:58
*** erhudy has joined #openstack-nova15:58
tdurakovmarkus_z: hi15:59
*** thorst_ has quit IRC15:59
markus_ztdurakov: hey ho15:59
tdurakovmarkus_z: any updates on latest libvirt/qemu devstack plugin?15:59
*** davidgiluk has left #openstack-nova15:59
erhudycould i get somebody to consider the spec at https://review.openstack.org/#/c/311828/ and provide critical feedback16:00
markus_ztdurakov: unfortunately not, sorry :(16:00
tdurakovmarkus_z: np16:01
*** apoorvad has joined #openstack-nova16:01
*** shaohe_feng has quit IRC16:01
*** thorst_ has joined #openstack-nova16:01
*** shaohe_feng has joined #openstack-nova16:02
*** matrohon has quit IRC16:02
markus_ztdurakov: For the rest of the week I will only work a few hours per day, not sure if I can push it this week16:02
*** roeyc has joined #openstack-nova16:04
*** penick has joined #openstack-nova16:04
tdurakovmarkus_z: trying to switch to xenial instead.16:05
markus_ztdurakov: Should mitigate the issue for a while I guess, yeah16:06
*** ericksonsantos has joined #openstack-nova16:06
*** roeyc has quit IRC16:08
*** ctrath has quit IRC16:09
openstackgerritAnusha Unnam proposed openstack/nova: api-ref: os-volumes.inc method verification  https://review.openstack.org/31432516:10
*** thorst_ has quit IRC16:10
*** ctrath has joined #openstack-nova16:11
*** thorst_ has joined #openstack-nova16:11
*** thorst_ has quit IRC16:11
*** shaohe_feng has quit IRC16:11
*** ctrath has quit IRC16:12
*** sacharya_ has quit IRC16:12
*** jlanoux has joined #openstack-nova16:12
*** ccarmack has joined #openstack-nova16:13
*** daemontool_ has quit IRC16:13
*** shaohe_feng has joined #openstack-nova16:14
*** mriedem_meeting is now known as mriedem16:14
mriedemtdurakov: sounds good, thanks16:15
tdurakovmriedem: both patches already got 2 +2 and W16:15
tdurakovmriedem: hope to test them in a few hours16:15
*** ctrath has joined #openstack-nova16:16
*** thorst_ has joined #openstack-nova16:17
*** paul-carlton1 has joined #openstack-nova16:19
openstackgerritMark Doffman proposed openstack/nova-specs: Migrate keypair table to the API DB  https://review.openstack.org/31261916:20
dansmithjohnthetubaguy: I have literally never been able to auto-complete your username on gerrit, so can you see my question on this? https://review.openstack.org/#/c/313072/116:21
johnthetubaguydansmith: yeah, I think my move from citrix did something bad to my metadata16:21
jrolldansmith: oh god16:21
johnthetubaguyanyways, looking at your question16:21
doffmalaski: I left the keypair 'instance-extra' work in the keypair migration spec. I hope thats OK. Did you want a different name for the specifications because of that?16:21
*** winston-d_ has joined #openstack-nova16:21
dansmithjroll: "oh god" as in "oh god, tell me about it!" ?16:21
*** shaohe_feng has quit IRC16:22
johnthetubaguydansmith: I think "you just broke my billing" is another phrase, although I wish I knew for sure16:22
*** thorst_ has quit IRC16:22
*** shaohe_feng has joined #openstack-nova16:22
*** Drankis has quit IRC16:22
dansmithjohnthetubaguy: yeah, I don't know how people do that, so ..16:23
jrolldansmith: I just panic on our virt team's behalf when I see BandwidthUsage queries16:23
jrolljohnthetubaguy: off the top of my head, we emit a notification with the sum of those every 24h, so I agree it looks like a bit of lost revenue16:23
dansmithjroll: ah16:24
*** Raildo_ has joined #openstack-nova16:24
dansmithjohnthetubaguy: well, I'll let you coordinate with mriedem and lxsli on the way to fix the problem without losing money :)16:24
dansmithjroll: I thought you were sympathizing with my hatred of trying to find johnthetubaguy on gerrit16:25
mriedemdansmith: easy, start with john@16:25
mriedemand it fills in the rest16:25
mriedemfinding cburgess on gerrit, on the other hand, is nearly impossible16:25
openstackgerritChris Dent proposed openstack/nova-specs: resource-providers: generic resource pools  https://review.openstack.org/30017616:26
cburgessmriedem Do what now?16:26
dansmithmriedem: okay, well, I usually look for johng<...> which fails, I guess I need to remember john@..16:26
cdentjaypipes, bauzas, mriedem ^^ adjusted the api spec to reflect my novella16:26
dansmithjust "john" also returns nothing useful of course16:26
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: move image_file_url download options  https://review.openstack.org/31466816:26
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: deprecate "file transfer" feature for Glance images  https://review.openstack.org/31466916:26
jrolldansmith: no, though that used to be the case for me16:27
jrolljohnthetubaguy: infra can usually help fix the gerrit thing16:27
*** rena9067 has quit IRC16:28
dansmithwell, john@ seems to work fine16:28
jrolloh never mind, yours isn't broken16:28
lxslidansmith: it's case-sensitive16:28
jrollmine would just error16:28
dansmithI just wish gerrit search actually ... searched instead of just completed16:28
jrollright :P16:28
mriedemi find jroll via jim.16:28
mriedem@ and . are key16:28
*** zengine has joined #openstack-nova16:28
mriedemjames von rollenhagen esq IV16:28
mriedemyou'll never find him drinking with his pinky down16:29
*** Sukhdev has quit IRC16:29
dansmithjim. doesn't do it for me16:29
lxslijohnthetubaguy: I have to go, leave a comment and I'll look at it tomorrow16:29
johnthetubaguylxsli: ack16:29
jrollyeah, should be jim@ :P16:29
dansmithyeah16:29
*** Sukhdev has joined #openstack-nova16:30
mriedemoh i was using the rax email then16:30
johnthetubaguyjroll: yeah, I should ping them16:30
jrolloh wow16:30
jrolljohnthetubaguy: nah, my mistake, yours isn't broken to the point of infra intervention16:30
*** chuck__ has joined #openstack-nova16:30
*** abalutoiu has quit IRC16:31
*** zul has quit IRC16:31
*** chuck__ is now known as zul16:31
*** ijw has joined #openstack-nova16:32
*** shaohe_feng has quit IRC16:32
*** shaohe_feng has joined #openstack-nova16:32
markus_zclaudiub: https://review.openstack.org/#/c/314671/16:32
*** jlanoux has quit IRC16:34
jaypipescdent: thx16:35
cdentjaypipes: I _think_ I got everything but it's hard to be 100% sure16:35
cdentgah typo16:36
*** abitha has joined #openstack-nova16:36
*** yamahata has joined #openstack-nova16:36
openstackgerritChris Dent proposed openstack/nova-specs: resource-providers: generic resource pools  https://review.openstack.org/30017616:37
*** jdillaman has quit IRC16:37
*** sdake_ is now known as sdake16:38
*** thorst_ has joined #openstack-nova16:38
*** Swami has joined #openstack-nova16:38
*** hieulq_ has joined #openstack-nova16:39
*** sfinucan has quit IRC16:42
*** shaohe_feng has quit IRC16:42
*** thorst_ has quit IRC16:42
*** EinstCrazy has quit IRC16:42
*** shaohe_feng has joined #openstack-nova16:43
*** diogogmt has joined #openstack-nova16:43
*** rbridgeman has joined #openstack-nova16:43
*** thorst_ has joined #openstack-nova16:44
*** kengo_sakai has joined #openstack-nova16:45
*** jaypipes has quit IRC16:45
*** flaper87 has quit IRC16:46
*** flaper87 has joined #openstack-nova16:46
*** cdelatte has quit IRC16:46
*** cdelatte has joined #openstack-nova16:47
*** jaypipes has joined #openstack-nova16:47
*** sacharya has joined #openstack-nova16:47
*** jaypipes has quit IRC16:47
*** thorst_ has quit IRC16:49
*** kengo_sakai has quit IRC16:49
alaskidoffm: that's fine. my comment on the name was that you mispelled keypairs16:49
*** jaypipes has joined #openstack-nova16:50
mriedemdanpb: can you take a quick pass through mdbooth's libvirt image backend refactor spec before we approve? https://review.openstack.org/#/c/302117/16:50
*** danpb has quit IRC16:50
*** sacharya has quit IRC16:50
*** derekh has quit IRC16:50
*** sacharya has joined #openstack-nova16:50
*** shaohe_feng has quit IRC16:52
*** shaohe_feng has joined #openstack-nova16:53
sdagueanyone want to take a quick look at this - https://review.openstack.org/#/c/314592/ so we can roll forward to paramiko 2?16:53
*** abalutoiu has joined #openstack-nova16:54
*** rama_y has joined #openstack-nova16:54
*** rbridgeman has quit IRC16:54
*** unicell has quit IRC16:55
*** delattec has joined #openstack-nova16:56
*** mvk has quit IRC16:57
mriedemsdague: isn't there a cleaner way to get the version using pkg_resources?16:57
sdaguemriedem: possibly, but this code should only exist for about 4 days16:57
*** andymaier_ has joined #openstack-nova16:57
dansmithcdent: jaypipes: is the code up to migrate the existing inventory stuff to the api db?16:58
sdaguethere is already the g-r change + the full removal of the v1 code stacked up16:58
cdentdansmith: not that I'm aware of16:58
dansmithcdent: who is working on it?16:59
cdentdansmith: I don't know16:59
mriedemsdague: ok, +W16:59
*** penick has quit IRC16:59
*** cdelatte has quit IRC16:59
cdentit's only been discussd, as far as I know noone has "taken that action"16:59
dansmithcdent: okay, it's blocking everything else, so ... seems like someone should be doing it17:00
* cdent dies in a fire of business speak17:00
cdentyou want to do it dansmith ?17:00
dansmithno, I was just hoping it was up for review17:00
*** vilobhmm11 has joined #openstack-nova17:00
*** daemontool_ has joined #openstack-nova17:00
cdentI agree it needs to happen, but I'm not sure who has the cycles, _right now_17:00
*** roeyc has joined #openstack-nova17:01
dansmithsince it's blocking everything, I would think the set of people would be "anyone working on anything else resource-pools-related"17:01
mriedemdansmith: on https://review.openstack.org/#/c/295595/ i think i'll throw that in the nova meeting for thursday17:01
dansmithmriedem: okay17:02
cdentthat's great dansmith but I know at least I am carrying a huge amount of state that I can't set down this minute17:02
cdentso it's not going to be me17:02
cdentat least not in the next few days17:02
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: improve help text of database (related) options (1/3)  https://review.openstack.org/30123817:02
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: centralize section "database" + "api_database"  https://review.openstack.org/26380417:02
jaypipesdansmith: I will do it.17:02
*** shaohe_feng has quit IRC17:03
*** jaypipes has quit IRC17:03
*** shaohe_feng has joined #openstack-nova17:03
mriedemrlrossit might like to get in on some online data migration action17:03
mriedembut i think he's busy with internal things17:04
cdentreality is a such a pita17:04
rlrossitmriedem: oh you, voluntelling me for more things17:04
*** jaypipes has joined #openstack-nova17:04
*** lpetrut has joined #openstack-nova17:06
rlrossitmriedem: is this scheduler migrating, or cells migrating?17:06
*** roeyc has quit IRC17:06
openstackgerritCorey Wright proposed openstack/nova: Drop paramiko < 2 compat code  https://review.openstack.org/31463917:06
*** sacharya has quit IRC17:08
*** sacharya has joined #openstack-nova17:08
*** yassou has quit IRC17:10
*** thorst_ has joined #openstack-nova17:11
*** kfarr has joined #openstack-nova17:12
*** shaohe_feng has quit IRC17:13
doffmalaski: Ohh. Ok I guess I'll fix that now.17:13
*** shaohe_feng has joined #openstack-nova17:13
openstackgerritMark Doffman proposed openstack/nova-specs: Migrate keypair table to the API DB  https://review.openstack.org/31261917:14
cdentrlrossit: the things that was being discussed was migrating the inventory and allocations tables to api db17:14
dansmithdoffm: alaski: oops, I didn't notice that it wasn't fixed17:15
*** thorst_ has quit IRC17:15
*** rmart04 has quit IRC17:15
doffmdansmith: alaski: Sorry.17:16
*** thorst_ has joined #openstack-nova17:16
alaskino worries17:16
*** gagehugo has quit IRC17:18
*** nic has joined #openstack-nova17:18
*** gagehugo has joined #openstack-nova17:19
*** ccarmack has quit IRC17:20
*** jistr has quit IRC17:21
*** whenry has joined #openstack-nova17:21
*** shaohe_feng has quit IRC17:23
*** unicell has joined #openstack-nova17:23
*** thorst_ has quit IRC17:23
*** shaohe_feng has joined #openstack-nova17:24
cdentdansmith, jaypipes: is there an etherpad reference somewhere to what parts of the "inventories stuff" will need to be migrated? What's the status of the reosurce provider and resource provider aggregate tables? They are remaining in the cell db?17:24
*** daemontool_ has quit IRC17:25
*** ccarmack has joined #openstack-nova17:25
*** ccarmack has joined #openstack-nova17:26
mriedemresource provider aggregates moves to the api db because that's where aggregates are moving17:26
jaypipescdent: currently brainstorming this with dansmith in a /query window..17:26
jaypipescdent: gimme a few :)17:26
cdentit seems like quite a bit will need to move because we want the fk relationship across that resource_providers_aggregates table with both aggregates and resource_providers table17:28
cdentjaypipes: bon chance17:28
*** gjayavelu has quit IRC17:29
smcginnisJust looking at this: https://github.com/openstack/governance/blob/master/reference/projects.yaml#L251617:29
smcginnisAre stable releases done for python-novaclient?17:30
*** thorst_ has joined #openstack-nova17:30
smcginnismriedem: ^^17:30
*** penick has joined #openstack-nova17:30
mriedemsmcginnis: yeah, as needed17:30
mriedembut not often17:30
smcginnismriedem: So are newer release of the client not compatible with older ones?17:31
mriedemsmcginnis: we use semver for the client17:31
mriedemso if we make a backward incompatible change, it's a major version bump17:31
openstackgerritPaul Carlton proposed openstack/nova-specs: Automatic Live Migration Completion  https://review.openstack.org/30656117:32
mriedemthe stable branch is really just for bug fixes on n-117:32
smcginnismriedem: OK, so you've had to do that for past releases, therefore need stable releases of the client for older ones?17:32
mriedemyeah17:32
mriedemsmcginnis: e.g. https://github.com/openstack/python-novaclient/commit/bc213fd8347f20df3534f93e992e9325adaa2a6317:32
*** ctrath has quit IRC17:32
smcginnismriedem: OK, makes sense. We just always move forward with python-cinderclient, so trying to understand why it was different.17:32
*** paul-carlton1 has quit IRC17:33
*** sambetts is now known as sambetts|afk17:33
*** shaohe_feng has quit IRC17:33
*** rooooook has quit IRC17:34
*** shaohe_feng has joined #openstack-nova17:34
*** rooooook has joined #openstack-nova17:34
*** thorst_ has quit IRC17:34
*** sudipto has quit IRC17:35
*** ctrath has joined #openstack-nova17:35
*** hieulq_ has quit IRC17:36
*** hshiina has quit IRC17:36
*** sudipto has joined #openstack-nova17:41
*** thorst_ has joined #openstack-nova17:43
*** mriedem1 has joined #openstack-nova17:43
*** mriedem has quit IRC17:43
*** shaohe_feng has quit IRC17:44
*** shaohe_feng has joined #openstack-nova17:44
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: move s3 related options  https://review.openstack.org/31414617:45
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: deprecate s3 image service config options  https://review.openstack.org/31469717:45
*** neophy has joined #openstack-nova17:46
*** whenry has quit IRC17:46
*** mpavone has joined #openstack-nova17:46
*** mpavone has quit IRC17:47
*** thorst_ has quit IRC17:47
*** jichen has joined #openstack-nova17:48
*** ccarmack has quit IRC17:49
*** lucasagomes is now known as lucas-afk17:49
*** sudipto has quit IRC17:49
*** gjayavelu has joined #openstack-nova17:50
*** rlrossit has quit IRC17:50
*** gjayavelu has quit IRC17:51
*** markus_z has quit IRC17:52
*** shaohe_feng has quit IRC17:54
*** shaohe_feng has joined #openstack-nova17:54
*** andymaier_ has quit IRC17:55
*** lucas-afk is now known as lucasagomes17:55
*** rlrossit has joined #openstack-nova17:55
openstackgerritRobert Ellis proposed openstack/nova: Changed 202 for lock/unlock return code to 200. This addresses bug 1449811. 409 return code was not addressed as the compute node is already in that state so no corrective action is required. 404 is already covered by existing code.  https://review.openstack.org/31426717:56
openstackbug 1449811 in OpenStack Compute (nova) "nova lock/unlock api return code is not accurate" [Wishlist,Confirmed] https://launchpad.net/bugs/1449811 - Assigned to Robert Ellis (bob-ellis42)17:56
*** lucasagomes is now known as lucas-dinner17:57
*** Sukhdev_ has joined #openstack-nova17:57
*** vilobhmm11 has quit IRC17:59
*** rmart04 has joined #openstack-nova17:59
*** Sukhdev has quit IRC18:00
*** whenry has joined #openstack-nova18:01
*** Sukhdev_ has quit IRC18:02
*** thorst_ has joined #openstack-nova18:02
*** shaohe_feng has quit IRC18:04
*** shaohe_feng has joined #openstack-nova18:04
*** zengine has quit IRC18:06
*** chuck__ has joined #openstack-nova18:06
*** zul has quit IRC18:07
*** tonytan4ever has joined #openstack-nova18:07
*** chuck__ is now known as zul18:07
dansmithmriedem1: you can drop your -2 on this now: https://review.openstack.org/#/c/312750/18:08
dansmithI don't want to start on any more migrations until that merges and gets the migration number reserved18:08
*** mriedem1 is now known as mriedem18:09
mriedemdansmith: is the spec approved now?18:09
mriedemyes it is https://review.openstack.org/#/c/312619/18:09
mriedemwell hells bells18:10
mriedembp is approved, -2 removed18:11
mriedempeace be with you18:11
mriedemdansmith: what migration number?18:12
dansmithmriedem: the db migration number18:13
mriedemthat is either later in the series or doesn't exist yet18:13
dansmithit's in the series18:13
*** rcernin has quit IRC18:13
dansmithhttps://review.openstack.org/#/c/312755/818:14
*** shaohe_feng has quit IRC18:14
*** shaohe_feng has joined #openstack-nova18:15
*** whenry has quit IRC18:17
*** mvk has joined #openstack-nova18:17
*** pushkaru has quit IRC18:18
mriedemthe fernet test races must be extra bad in the cells v1 job18:21
* tbachman tries to parse that sentence18:22
tbachmanmriedem: btw, I haven’t forgotten that I have a tempest test obligation18:23
tbachmanhaven’t gotten to it yet, but hopefully mid-week18:23
mriedemfor shame18:23
*** shaohe_feng has quit IRC18:25
*** shaohe_feng has joined #openstack-nova18:25
*** thumpba has joined #openstack-nova18:25
*** haplo37 has joined #openstack-nova18:26
*** cdent has quit IRC18:28
openstackgerritjichenjc proposed openstack/nova: WIP: api-ref keypair update  https://review.openstack.org/31450218:30
auggysdague: jichen: I have a question about https://review.openstack.org/#/c/314320/2/api-ref/source/ips.inc18:30
*** lpetrut has quit IRC18:31
*** sacharya has quit IRC18:31
jichenauggy: yes18:31
auggysdague: jichen: i am not sure how to represent that "addr" field18:31
auggyshould I add a new parameter?18:31
auggyi realized the definition for "address" is "floating ip address"18:31
*** baoli_ has quit IRC18:32
*** Daisy has joined #openstack-nova18:32
auggyis that what we want that definition to be, should we always assume anything that uses "address" is always going to use a floating ip?18:32
jichenyes, I think so, at least ,the floating ip looks me is incorrect, my guess is to add a param in parameters.yaml18:32
jichenauggy: my understanding is we need to distinguish them ,for example . you have a lot of 'ids' but server_id , user_id is different, we need separated them18:33
auggyjichen: sdague: should we consider updating "address" somehow to distinguish between generic, static, and floating?18:33
auggyit just seems potentially ambiguous right now18:34
*** gyee has joined #openstack-nova18:34
auggyjichen: sdague: in the meantime, should I just add "ip_address" as a new parameter and use that instead?18:34
*** lpetrut has joined #openstack-nova18:35
*** shaohe_feng has quit IRC18:35
jichenauggy: um... I am not very sure, maybe sdague has more input, my guess is w probably need distinguish them , and I think ip_address works for me18:35
*** shaohe_feng has joined #openstack-nova18:36
*** voelzmo has joined #openstack-nova18:36
auggyjichen: ok cool, i'll just update the patch with that change and a comment18:36
voelzmoawesome, thanks @coreywright18:36
auggythanks ;)18:36
*** Daisy has quit IRC18:36
jichenauggy: thanks :)18:37
*** cdent has joined #openstack-nova18:38
auggyjichen: looks like there's already a param called "ip"!18:38
jichenauggy: then maybe you can reuse it , if the meaning is same , I think we reuse them sometime18:39
auggyjichen: do you know if you can have a parameter named the same for both body and path?18:39
*** haplo37 has quit IRC18:40
auggythe ip param i found is "in: path", so can i create a second one with "in: body"?18:40
jichenauggy: I don't know ,I think we need use in:path and in: body  both as sdague pointed out in the same patch18:41
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/31374318:41
*** kfarr has quit IRC18:41
*** kfarr has joined #openstack-nova18:41
*** gagehugo has quit IRC18:41
*** gagehugo has joined #openstack-nova18:41
*** penick has quit IRC18:41
*** penick has joined #openstack-nova18:41
*** ctrath has quit IRC18:41
*** ctrath has joined #openstack-nova18:41
*** mriedem has quit IRC18:42
*** mriedem has joined #openstack-nova18:42
*** rlrossit has quit IRC18:42
*** rlrossit has joined #openstack-nova18:42
*** shaohe_feng has quit IRC18:42
*** shaohe_feng has joined #openstack-nova18:42
auggyjichen: yeah, i am looking at parameters.yaml to see if there are any with the same name that have both in: body and in: path18:42
auggybut so far everything has a unique name18:42
*** rcernin has joined #openstack-nova18:43
jichenauggy: ok, If I need a name, I typical created it :)18:44
*** thumpba has quit IRC18:44
*** shaohe_feng has quit IRC18:45
auggyjichen: ah i see, i guess i would rather see if one exists i can use already :)18:45
*** thumpba has joined #openstack-nova18:46
*** shaohe_feng has joined #openstack-nova18:46
openstackgerritSujitha proposed openstack/nova: Added new exception to handle CinderClientException  https://review.openstack.org/29015618:46
*** thorst_ has quit IRC18:48
belliottdansmith: so some tests failed, i assumed this is what your keystone recheck was supposed to fix? -- https://review.openstack.org/#/c/314230/18:49
*** thorst_ has joined #openstack-nova18:49
openstackgerritsean mooney proposed openstack/os-vif: Add support for vhost-user  https://review.openstack.org/28561318:49
mriedembelliott: recheck again18:49
dansmithbelliott: aye18:49
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/31374318:50
belliottmriedem: wasn't sure what all the recheck commands are anymore18:51
mriedembelliott: just recheck18:51
belliottmriedem: :)18:51
*** zenoway has joined #openstack-nova18:51
openstackgerritAugustina Ragwitz proposed openstack/nova: api-ref: ips.inc parameter verification  https://review.openstack.org/31432018:51
*** zenoway has quit IRC18:52
*** zenoway has joined #openstack-nova18:52
*** sdake has quit IRC18:52
*** pushkaru has joined #openstack-nova18:53
*** shaohe_feng has quit IRC18:55
*** shaohe_feng has joined #openstack-nova18:56
openstackgerritDan Smith proposed openstack/nova: Create Instances with keypairs  https://review.openstack.org/31275118:57
openstackgerritDan Smith proposed openstack/nova: Add keypairs to Instance object  https://review.openstack.org/31275018:57
openstackgerritDan Smith proposed openstack/nova: Add Keypairs to the API database  https://review.openstack.org/31275518:57
openstackgerritDan Smith proposed openstack/nova: Make Keypair object favor the API database  https://review.openstack.org/31275618:57
openstackgerritDan Smith proposed openstack/nova: Add online migration to move keypairs from main to API database  https://review.openstack.org/31366418:57
openstackgerritDan Smith proposed openstack/nova: Add online migration to store keypairs with instances  https://review.openstack.org/31306018:57
*** thorst_ has quit IRC18:57
sdagueauggy: they all have to have unique names19:00
sdaguetypically I've been appending _path or _query where appropriate19:00
*** xenogear has quit IRC19:00
*** salv-orl_ has joined #openstack-nova19:02
*** xyang1 has joined #openstack-nova19:02
*** fragatina has quit IRC19:02
*** thorst_ has joined #openstack-nova19:03
*** eglynn has quit IRC19:03
melwitt mriedem: do you know if elastic-recheck is still working? I feel like I haven't seen it comment on reviews in a long time19:04
*** rmart04 has quit IRC19:04
mriedemmelwitt: i haven't seen comments either19:04
*** salv-orlando has quit IRC19:05
sdaguemriedem: failopotamus patch merged19:05
mriedemsdague: yes!19:05
mriedemdoffm: ^ is what i was giggling about19:05
*** shaohe_feng has quit IRC19:06
*** shaohe_feng has joined #openstack-nova19:07
mriedemdansmith: i'm blowing you away in commits here https://github.com/sdague/failopotamus/graphs/contributors19:07
mriedem:)19:07
dansmithmriedem: um, congrats?19:07
*** tbachman has quit IRC19:08
*** thorst_ has quit IRC19:08
*** dedery has joined #openstack-nova19:08
openstackgerritVilobh Meshram proposed openstack/nova-specs: Flavor Classes  https://review.openstack.org/31473119:09
*** thorst_ has joined #openstack-nova19:09
*** fragatina has joined #openstack-nova19:09
melwittso that's how you make the cool failure graph19:11
*** pcaruana has quit IRC19:12
*** thorst_ has quit IRC19:14
*** thorst_ has joined #openstack-nova19:15
*** shaohe_feng has quit IRC19:16
*** shaohe_feng has joined #openstack-nova19:19
*** thorst_ has quit IRC19:20
openstackgerritRobert Ellis proposed openstack/nova: Changed 202 for lock/unlock return code to 200. This addresses bug 1449811. 409 return code was not addressed as the compute node is already in that state so no corrective action is required. 404 is already covered by existing code.  https://review.openstack.org/31426719:21
openstackbug 1449811 in OpenStack Compute (nova) "nova lock/unlock api return code is not accurate" [Wishlist,Confirmed] https://launchpad.net/bugs/1449811 - Assigned to Robert Ellis (bob-ellis42)19:21
*** thorst_ has joined #openstack-nova19:22
*** sacharya has joined #openstack-nova19:22
*** thorst_ has quit IRC19:23
*** thorst_ has joined #openstack-nova19:23
mriedemdansmith: on https://review.openstack.org/#/c/314230/ so why weren't we doing this before? just didn't think of it?19:24
*** rmart04 has joined #openstack-nova19:24
*** neophy has quit IRC19:24
*** shaohe_feng has quit IRC19:26
*** shaohe_feng has joined #openstack-nova19:27
*** thorst_ has quit IRC19:30
*** neophy has joined #openstack-nova19:30
*** thorst_ has joined #openstack-nova19:30
*** rmart04 has quit IRC19:32
*** rmart04_ has joined #openstack-nova19:32
*** tbachman has joined #openstack-nova19:32
*** gszasz has quit IRC19:34
*** thorst_ has quit IRC19:36
*** voelzmo has quit IRC19:36
*** shaohe_feng has quit IRC19:36
*** dedery_ has joined #openstack-nova19:37
*** shaohe_feng has joined #openstack-nova19:37
*** thorst_ has joined #openstack-nova19:37
*** dedery__ has joined #openstack-nova19:38
cdentmriedem: you ate an 80 year old man's spirit? what kind of crazy witch dr are you?19:38
openstackgerritjichenjc proposed openstack/nova: WIP: api-ref keypair update  https://review.openstack.org/31450219:39
mriedemcdent: i wanted his life force, or what was left of it19:39
*** dedery has quit IRC19:39
openstackgerritSean Dague proposed openstack/nova: Denormalize personality extension  https://review.openstack.org/31460019:40
cdentI question your choices, sir.19:40
cdent"Denormalize personality extension" <- best commit summary ever19:40
*** rmart04 has joined #openstack-nova19:40
*** rmart04_ has quit IRC19:41
*** dedery_ has quit IRC19:42
*** thorst_ has quit IRC19:42
*** shaohe_feng has quit IRC19:47
sdague:)19:47
*** shaohe_feng has joined #openstack-nova19:47
*** rmart04_ has joined #openstack-nova19:48
*** rmart04 has quit IRC19:49
*** rmart04_ is now known as rmart0419:49
*** rcernin has quit IRC19:51
*** daemontool_ has joined #openstack-nova19:51
*** tongli has quit IRC19:53
*** rmart04 has quit IRC19:55
mriedemneutron + libvirt + lvm https://review.openstack.org/#/c/314744/19:56
mriedemwhat could go wrong?!19:56
*** shaohe_feng has quit IRC19:57
*** lpetrut has quit IRC19:57
*** shaohe_feng has joined #openstack-nova19:57
*** rcernin has joined #openstack-nova19:59
*** rmart04 has joined #openstack-nova19:59
kashyapmriedem: Looks fairly straight-forward, no? :-)20:00
kashyapThe earth continues to spin20:01
openstackgerritDan Smith proposed openstack/nova: Create Instances with keypairs  https://review.openstack.org/31275120:02
openstackgerritDan Smith proposed openstack/nova: Add Keypairs to the API database  https://review.openstack.org/31275520:02
openstackgerritDan Smith proposed openstack/nova: Make Keypair object favor the API database  https://review.openstack.org/31275620:02
openstackgerritDan Smith proposed openstack/nova: Add online migration to move keypairs from main to API database  https://review.openstack.org/31366420:02
openstackgerritDan Smith proposed openstack/nova: Add online migration to store keypairs with instances  https://review.openstack.org/31306020:02
dansmithmriedem: jaypipes: don't let those highly stubbed tests in test_compute_api fool you.. they're not testing any of this.. there's lots of coverage of this path, especially in functional (and in tempest), as evidenced by the test failures that just pointed out I made a mind-o in my tweak for alaski ^^ :)20:02
dansmithmriedem: jaypipes: i.e.: http://logs.openstack.org/51/312751/7/check/gate-nova-tox-db-functional/3f5230d/testr_results.html.gz20:03
scottdaDoes anyone know why adding a new keyword arg to cinderclient Client init would cause nova be so unhappy? https://bugs.launchpad.net/nova/+bug/158031920:03
openstackLaunchpad bug 1580319 in OpenStack Compute (nova) "unreleased cinderclient fails volume-attach due to new Client parameter" [Undecided,New]20:03
*** rmart04 has quit IRC20:04
auggysdague: cool thanks20:05
*** rmart04 has joined #openstack-nova20:05
mriedemscottda: well you have the stacktrace there20:05
auggysdague: cdent if we denormalize our personality extensions, does that mean we all become cybermen?20:05
*** daemontool_ has quit IRC20:06
scottdamriedem: Yes, I saw that. But I'm not sure where that decorator in /usr/local/lib/python2.7/dist-packages/positional/ is even coming from. Just wondering if anyone had seen this kind of thing before...20:06
cdentWE ARE DEVO20:06
*** rmart04_ has joined #openstack-nova20:07
jaypipesdansmith: k20:07
openstackgerritPushkar Umaranikar proposed openstack/nova: method verification for servers-action-fixed-ip  https://review.openstack.org/31474820:07
*** shaohe_feng has quit IRC20:07
mriedemscottda: sudo cp -rs /opt/stack/python-cinderclient/cinderclient /urr/local/lib/python2.7/dist-packages/20:07
mriedemyou have a typo in there20:07
mriedem/urr/local20:07
*** shaohe_feng has joined #openstack-nova20:08
*** akshai has quit IRC20:08
mriedemalso, i'd just pip install the cloned python-cinderclient20:08
mriedemrather than copy things around20:08
kashyapmriedem: dansmith:  When you get a moment, mind taking a look at this (you both have more than good context) liberty backport: https://review.openstack.org/#/c/314012/420:09
scottdamriedem: Thanks, I'll fix that in the bug  report. But I just typed that in. The bug still exists .20:09
*** rmart04 has quit IRC20:09
*** rmart04_ is now known as rmart0420:09
mriedemscottda: riddle me this, does python-cinderclient go through functional dsvm testing?20:09
*** dharinic has joined #openstack-nova20:10
mriedemscottda: http://logs.openstack.org/41/301941/15/check/gate-cinderclient-dsvm-functional/4b56a7f/logs/testr_results.html20:10
mriedemit just installs, it doesn't run tests20:10
mriedemlooks like http://logs.openstack.org/41/301941/15/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/5e5e21a/logs/testr_results.html.gz tests some tihngs20:10
scottdahmm20:11
scottdamriedem: This looks like functional is running: http://logs.openstack.org/27/303627/9/check/gate-cinderclient-dsvm-functional/8c6916c/console.html.gz20:11
mriedemscottda: is this bug report against a nova change you're working on to use api_version with cinderclient?20:12
*** haplo37 has joined #openstack-nova20:12
scottdamriedem: No, this is cinderclient changes to make the cinderclient aware of api_versions, and they are merged into master20:12
mriedemah yes http://logs.openstack.org/27/303627/9/check/gate-cinderclient-dsvm-functional/8c6916c/logs/testr_results.html.gz20:12
*** sacharya_ has joined #openstack-nova20:13
*** rmart04_ has joined #openstack-nova20:14
*** rmart04 has quit IRC20:14
*** rmart04_ is now known as rmart0420:14
*** winston-d_ has quit IRC20:15
*** sacharya has quit IRC20:16
scottdamriedem: So, there's obviously a testing gap. I don't think there's anything that tests Nova with latest cinderclient on master, just the latest released version.20:16
*** rama_y has quit IRC20:17
*** shaohe_feng has quit IRC20:17
mriedemscottda: well, http://logs.openstack.org/41/301941/15/check/gate-tempest-dsvm-neutron-src-python-cinderclient/b6f11fc/ would be running tempest against latest nova + this commit in cinderclient20:17
mriedemi see the commit is in pip freeze here http://logs.openstack.org/41/301941/15/check/gate-tempest-dsvm-neutron-src-python-cinderclient/b6f11fc/logs/pip-freeze.txt.gz20:18
mriedemscottda: stale pyc's in your local devstack version?20:18
*** shaohe_feng has joined #openstack-nova20:18
scottdamriedem: Maybe20:19
mriedemanyway, i wouldn't mess with copying files around, i'd pip install that bad mama jama locally20:19
scottdamriedem: I'll try that. In the meantime, I'm just a bit paranoid about this one.20:19
dansmithmriedem: um, isn't it "mamba jamba" ?20:19
mriedemmamba jamba?20:19
mriedemno20:19
mriedemhttps://www.youtube.com/watch?v=qop26t6j2BE20:19
dansmithhttp://www.urbandictionary.com/define.php?term=Mamba%20Jamba20:20
*** ccarmack has joined #openstack-nova20:20
mriedemi can't tell if this guy is serious or not20:20
*** rama_y has joined #openstack-nova20:21
mriedemhere we go https://www.youtube.com/watch?v=6QIw1BQIvT420:21
mriedemlbragstad: ^ i think you have a long lost brother20:21
openstackgerritjichenjc proposed openstack/nova: WIP: api-ref keypair update  https://review.openstack.org/31450220:21
raj_singhsdague: I am working on image.inc file and saw some discrepancies in "normal response code" for get methods mentioned in file and one in api doc. Api doc says 200,203 while inc file has just 200.20:22
raj_singhhttp://developer.openstack.org/api-ref-compute-v2.1.html20:22
sdagueraj_singh: 203 is never something we return20:22
sdagueI think it's something in the rax proxy layer20:22
raj_singhsdague: so need to fix this in docs?20:23
sdagueyes20:23
*** rmart04 has quit IRC20:23
raj_singhthx20:23
*** abitha has quit IRC20:26
openstackgerritDan Smith proposed openstack/nova: Add Keypairs to the API database  https://review.openstack.org/31275520:26
openstackgerritDan Smith proposed openstack/nova: Make Keypair object favor the API database  https://review.openstack.org/31275620:26
openstackgerritDan Smith proposed openstack/nova: Add online migration to move keypairs from main to API database  https://review.openstack.org/31366420:26
openstackgerritDan Smith proposed openstack/nova: Add online migration to store keypairs with instances  https://review.openstack.org/31306020:26
*** fragatina has quit IRC20:27
*** shaohe_feng has quit IRC20:28
*** ijw_ has joined #openstack-nova20:28
*** ijw has quit IRC20:28
*** shaohe_feng has joined #openstack-nova20:29
*** thorst_ has joined #openstack-nova20:32
*** baoli has joined #openstack-nova20:36
*** ccarmack has quit IRC20:38
*** shaohe_feng has quit IRC20:38
*** shaohe_feng has joined #openstack-nova20:39
lbragstadmriedem that link makes my ears burn20:40
mriedemlbragstad: you have an uncanny resemblance20:41
mriedemto carl carlton20:41
*** baoli has quit IRC20:41
*** baoli has joined #openstack-nova20:42
openstackgerritjichenjc proposed openstack/nova: api-ref keypair update (os-keypairs.inc)  https://review.openstack.org/31450220:43
openstackgerritBrian Elliott proposed openstack/nova: Fix service version to update the DB  https://review.openstack.org/31423020:43
*** ccarmack has joined #openstack-nova20:45
mikalmriedem: I'll take a look at that spec post coffee20:45
mikalAlso, good morning20:46
*** jichen has quit IRC20:47
mriedemmikal: hi20:47
*** eharney has quit IRC20:47
*** markstur has joined #openstack-nova20:48
mriedemmikal: i thought of you because of the vendor data thing20:48
*** shaohe_feng has quit IRC20:48
*** baoli has quit IRC20:48
mikalYep, makes sense to me20:49
*** baoli has joined #openstack-nova20:49
*** baoli has quit IRC20:50
marksturmriedem, Suggestions for "20:50
marksturAdd instance host to evacuate terminate connector" https://review.openstack.org/#/c/274318  ???20:50
*** shaohe_feng has joined #openstack-nova20:51
marksturmriedem, I know it is a hack that no one likes, but now should I abandon it or push for it as the only fix we have for attachments that existed before the other evacuate patch.20:51
*** lucas-dinner has quit IRC20:51
*** baoli has joined #openstack-nova20:52
marksturmriedem, Unfortunately this one would need to land and backport and also get more Cinder-side fixes, too.20:52
cdentjaypipes, dansmith: did you guys figure out the resource-related database changes or otherwise increase the degree of plan?20:53
*** baoli has quit IRC20:57
*** lucasagomes has joined #openstack-nova20:58
*** shaohe_feng has quit IRC20:58
*** shaohe_feng has joined #openstack-nova20:59
*** baoli has joined #openstack-nova21:00
mriedemmarkstur: i'm not crazy about adding random things to the connector dict that nova passes back to cinder, since that's really an api change, even though old cinder code won't know about it anyway so won't check for it, and new cinder code would have to know that it might not be there (if they don't have new enough nova to be sendingit)21:00
mriedemand it really requires a workaround in each cinder volume driver21:01
*** baoli_ has joined #openstack-nova21:01
mriedemmarkstur: hemna and scottda have been looking at new APIs in cinder to handle cinder storing connector state in it's db, maybe this could fall into that somewhere21:02
*** thumpba has quit IRC21:02
marksturmriedem, Agreed.  So I'm thinking abandon it.  Unfortunately there isn't any better proposal for backports.  It should be fixed in Newton with new API proposals.21:02
mriedemalthough a new api in cinder wouldn't be backported to stable21:02
marksturmriedem, Yep. That's my dilemma. So we can backport the hack and I can try to get Cinder folks to use it for backports... but moving forward everyone agrees there should be a better fix.21:03
*** aysyd has quit IRC21:03
*** baoli has quit IRC21:04
marksturmriedem,  or just abandon it and downstream can do the hacks instead of upstream21:05
*** rama_y has quit IRC21:05
*** rama_y has joined #openstack-nova21:06
jaypipescdent: yes. plan is this (copy/pasted from convo with dansmith):21:07
dansmithdude21:07
dansmithprivate logs man!21:07
*** abalutoiu has quit IRC21:07
*** thorst_ has quit IRC21:08
jaypipesdansmith: there's no private content in my paste :)21:08
*** abalutoiu has joined #openstack-nova21:08
jaypipes05-10 13:33:28 <dansmith> 1. Add the table to the api db21:08
jaypipes05-10 13:33:44 <dansmith> 2. make the inventory object write there instead21:08
jaypipes05-10 13:33:51 <dansmith> 3. make the compute node not update if they're zero,21:08
jaypipes05-10 13:34:22 <dansmith> then I think we don't need to do any major migration since we'll have a fresh api db set of inventories within a21:08
jaypipes                          minute or two of restart21:08
jaypipes05-10 13:34:38 <dansmith> and then I'll let you refactor the compute code to actually do the inventory management itself21:08
*** thorst_ has joined #openstack-nova21:09
*** shaohe_feng has quit IRC21:09
cdentjaypipes: is that EOP?21:09
jaypipescdent: yes. and I've been trying to unmess some of the resource tracker code this afternoon in prep for that.21:11
cdentjaypipes: is there a plan, or does there need to be a plan, for moving resource_providers table to api db?21:11
*** rama_y has quit IRC21:11
jaypipescdent: excellent question. dansmith?21:12
*** shaohe_feng has joined #openstack-nova21:12
*** xyang1 has quit IRC21:12
mriedemheh, oh boy http://logs.openstack.org/44/314744/3/check/gate-tempest-dsvm-postgres-full/2098f4b/logs/screen-n-cpu.txt.gz?level=TRACE21:12
cdentearlier mriedem and I thought "yes" because that's where aggregates be, and we have resource_provider_aggregates table21:12
jaypipescdent: right.21:12
jaypipescdent: there's just the small question of who gets to do that :)21:13
mikalWhat is people's feeling about copyright statements in the nova/conf directory? A lot of the refactorings have been stripping peoples copyright statements, which makes me very uncomfortable.21:13
dansmiththe only providers we have in there now are the compute nodes, right? so the assumption is that in the process above, the table goes at the same time and we just do the same auto-create migration step again, but there21:13
mikalThere's at least two patches held up on that.21:13
openstackgerritJulian proposed openstack/nova: Add unit tests for nova.virt.firewall.IpTablesFirewallDriver  https://review.openstack.org/31175821:13
openstackgerritClenimar Filemon proposed openstack/nova: Use Identity v3 params when connecting to Ironic  https://review.openstack.org/30015421:13
jaypipesmikal: I've bitched at folks who *add* their own copyright when just moving code around.21:13
*** unicell has quit IRC21:14
mikaljaypipes: you +2'ed the one I am looking at at the moment, which effectively does that21:14
mikaljaypipes: removes someone elses, and adds Copyright 2016 OpenStack Foundation21:14
mikaljaypipes: which makes me uncomfortable21:14
jaypipesmikal: I don't consider "Copyright 2016 OpenStack Foundation" to be their *own* copyright.21:15
mikaljaypipes: well, maybe. Its probably invalid too, you can't gift copyright like that.21:15
mikaljaypipes: either way, it removed the original author's copyright statement21:15
mikalI think its a nit, but its something which bothers me21:16
mikalI'm gonna upload a fix and then +W this thing21:16
jaypipesgo for ti.21:16
jaypipesit21:16
openstackgerritMichael Still proposed openstack/nova: config options: move s3 related options  https://review.openstack.org/31414621:16
mikalCause no one has shouted at me in the last two minutes and therefore no one else cares21:16
*** ametts has quit IRC21:17
*** thorst_ has quit IRC21:17
hemnamarkstur, mriedem if our work ends up getting in, it will solve the evacuate and forced detach issues21:18
hemnabecause Cinder will have the connector21:18
*** shaohe_feng has quit IRC21:19
openstackgerritKaren Bradshaw proposed openstack/nova: [WIP] api-ref, evacuate action  https://review.openstack.org/31477621:19
*** shaohe_feng has joined #openstack-nova21:20
*** rtheis has quit IRC21:20
*** unicell has joined #openstack-nova21:20
*** unicell has quit IRC21:20
*** unicell has joined #openstack-nova21:20
mriedemoh fun http://logs.openstack.org/44/314744/3/check/gate-tempest-dsvm-postgres-full/2098f4b/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-05-10_20_51_24_98221:23
*** yamahata has quit IRC21:23
mriedemso i have an expected exception for rpc, but oslo.messaging logs the error anyway21:23
*** smatzek has quit IRC21:23
marksturhemna, Yes for Newton that's the plan. Unfortunately that won't be backported.  So the hack for backports is still under consideration -- to backport or to abandon.21:23
hemna:(21:24
* hemna is not a fan of the hack at all21:24
mriedemdims: i'm having trouble finding how nova even gets here http://logs.openstack.org/44/314744/3/check/gate-tempest-dsvm-postgres-full/2098f4b/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-05-10_20_51_24_98221:26
mriedemdims: since it looks like that comes from https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/common.py#L174 which i don't see nova using21:27
mriedemor rabbit in oslo.messaging using21:27
* dims peeks21:27
*** ivase has quit IRC21:28
*** rlrossit has quit IRC21:28
mriedemerr i guess we're using oslo_messaging._drivers.amqpdriver now?21:29
*** yamahata has joined #openstack-nova21:29
*** shaohe_feng has quit IRC21:29
mriedemhttp://logs.openstack.org/44/314744/3/check/gate-tempest-dsvm-postgres-full/2098f4b/logs/screen-n-cpu.txt.gz#_2016-05-10_20_29_40_344'21:30
dimsmriedem : http://codesearch.openstack.org/?q=%5C.serialize_remote_exception&i=nope&files=&repos=oslo.messaging first hit line 5921:31
mriedemyeah but i'm wondering what is oslo_messaging/_drivers/amqpdriver.py being used for?21:32
*** ivase has joined #openstack-nova21:32
*** lpetrut has joined #openstack-nova21:33
dimshang on21:33
mriedemah class RabbitDriver(amqpdriver.AMQPDriverBase):21:34
*** jamesden_ has quit IRC21:34
dimsmriedem : if you see....yep21:34
*** shaohe_feng has joined #openstack-nova21:34
*** daemontool_ has joined #openstack-nova21:35
dimsmriedem : what's the concern, garbage in logs?21:35
mriedemyes21:35
mriedemnova has it as an expected exception but it's logged as an error21:35
*** ivase has quit IRC21:36
openstackgerritMark Doffman proposed openstack/nova: Make Aggregate metadata functions work with API db  https://review.openstack.org/29735021:37
openstackgerritMark Doffman proposed openstack/nova: Add aggregates tables to the API db.  https://review.openstack.org/29480621:37
openstackgerritMark Doffman proposed openstack/nova: Make Aggregate.save work with the API db  https://review.openstack.org/30546621:37
openstackgerritMark Doffman proposed openstack/nova: Make Aggregate host operations work against API db  https://review.openstack.org/29659721:37
openstackgerritMark Doffman proposed openstack/nova: Make AggregateList.get_ return API & cell db items  https://review.openstack.org/29606221:37
openstackgerritMark Doffman proposed openstack/nova: Make Aggregate.get operation favor the API db  https://review.openstack.org/29601421:37
openstackgerritMark Doffman proposed openstack/nova: Aggregate create and destroy work against API db  https://review.openstack.org/31478121:37
openstackgerritMark Doffman proposed openstack/nova: Add data migration methods for Aggregate.  https://review.openstack.org/31478221:37
*** thorst_ has joined #openstack-nova21:38
dimsmriedem : we'll need sileht to peel this one, oslo.messaging bug please in launchpad?21:39
mriedemsure21:39
*** shaohe_feng has quit IRC21:39
dimsmriedem : we have flags to control that all over the place.... :)21:39
*** ctrath has quit IRC21:39
*** shaohe_feng has joined #openstack-nova21:40
melwittdansmith: do you recall if ComputeNode.save ever used to update/save the associated Service record in the past? I know there used to be service_id in ComputeNode but it doesn't look like that would cause a save to result in a save of the Service record too21:40
dansmithmelwitt: no I wouldn't expect it would21:41
openstackgerritSujitha proposed openstack/nova: Complete method verification of os-cloudpipe.inc  https://review.openstack.org/31478321:41
*** ijw_ has quit IRC21:41
*** ducttape_ has quit IRC21:42
*** lpetrut has quit IRC21:42
*** lpetrut has joined #openstack-nova21:42
*** ducttape_ has joined #openstack-nova21:42
*** thorst_ has quit IRC21:42
mriedemdims: https://bugs.launchpad.net/oslo.messaging/+bug/158035221:44
openstackLaunchpad bug 1580352 in oslo.messaging "excepted exception is still logged as an error" [Undecided,New]21:44
*** ducttape_ has quit IRC21:44
dimsty mriedem21:44
*** ducttape_ has joined #openstack-nova21:44
melwittdansmith: thanks for the sanity check21:44
*** gagehugo has quit IRC21:45
*** neophy has quit IRC21:45
openstackgerritSarafraj Singh proposed openstack/nova: api-ref: image.inc - Update method validation  https://review.openstack.org/31426821:46
snetiHi oomichi...I have updated my patch as per your comments. Can you please review it: https://review.openstack.org/#/c/290156/21:46
*** _ducttape_ has joined #openstack-nova21:47
bauzasmelwitt: no21:48
bauzasmelwitt: we did cut the relationship between the Service object and the CN one21:49
*** ccarmack has quit IRC21:49
bauzasmelwitt: and then, the service_id field is deprecated21:49
*** edmondsw has quit IRC21:49
*** shaohe_feng has quit IRC21:50
* bauzas is back from a meetup where he heard "AWS is open"21:50
melwittbauzas: yeah, I remember that. I'm trying to figure out what's going on with this bug opened against Kilo https://bugs.launchpad.net/nova/+bug/157921321:50
openstackLaunchpad bug 1579213 in OpenStack Compute (nova) "ComputeFilter fails because compute node has not been heard from in a while" [Undecided,New]21:50
*** shaohe_feng has joined #openstack-nova21:50
*** ijw has joined #openstack-nova21:51
melwittbauzas: the reporter said he worked around by forcing a save of the compute node every time, but that's not connected to how service up/down is determined21:51
*** efried has quit IRC21:51
melwitteven in Kilo, IIUC21:51
*** sacharya has joined #openstack-nova21:52
*** mriedem has quit IRC21:52
*** ducttape_ has quit IRC21:52
bauzasmelwitt: mmmm21:52
bauzasmelwitt: so the cut was done in Kilo IIRC21:52
*** cdelatte has joined #openstack-nova21:52
melwittbauzas: yeah, I was looking at that. but even before the cut, it didn't look like any save of ComputeNode could cascade into a save of Service21:52
*** amotoki has joined #openstack-nova21:53
*** sacharya_ has quit IRC21:54
*** delattec has quit IRC21:54
*** cdelatte has quit IRC21:55
bauzasmelwitt: well, the ComputeFilter is checking the servicegroup AFAIR21:55
bauzasmelwitt: which means it depends on the backend21:55
*** daemontool_ has quit IRC21:55
melwittbauzas: yeah, it does. and the servicegroup uses the Service last_seen_up, updated_at, created_at to determine up/down in the db driver case21:55
bauzasmelwitt: right21:55
melwittbauzas: but I was thinking, while the scheduler is working on a set of compute nodes, would a save of any compute node cause it to get a freshened view of the associated service record?21:56
bauzasmelwitt: sec, verifying21:57
*** fragatina has joined #openstack-nova21:57
*** rama_y has joined #openstack-nova21:57
melwittbauzas: or would it see nothing different because it has already pulled the compute node list and is seeing a potentially outdated view depending on how long scheduling takes21:57
bauzasmelwitt: so the SG backend verifies the Service object, not the CN object21:57
melwittright21:57
bauzasmelwitt: but that object is updated elsewhere but the RT AFAIR21:58
bauzassec, verifying where21:58
melwittbauzas: it's a timer task in the servicegroup, it increments report_count and does a save21:58
melwittbauzas: I was just wondering how saving compute nodes could possibly have made anything better in this case. the only thing I can think is if saving a compute node somehow refreshes the object and service object that the scheduler is looking at as it iterates over the nods21:59
melwitt*nodes21:59
*** cdelatte has joined #openstack-nova21:59
*** shaohe_feng has quit IRC22:00
bauzasmelwitt: the problem is that you can have multiple RTs per compute service22:00
*** shaohe_feng has joined #openstack-nova22:00
bauzasmelwitt: which means that each RT (one per compute node) would then update the related service22:01
bauzasin a synchronous call22:01
melwittbauzas: this bug is using Ironic, which means there are many nodes to one compute service22:02
bauzasmelwitt: yeah, which means we have one RT per Ironic node22:02
melwittright22:02
bauzasI'm surprised to see that bug popping up now TBH22:03
bauzasI'll need to go to bed, but I'll try to look at that tomorrow22:05
bauzasmelwitt: ^22:05
bauzasFWIW, I'm pretty busy those days trying to finish some implementation for a non-priority BP22:05
melwittbauzas: okay. I'm going to comment on the bug with a question for the reporter22:05
melwittbauzas: no worries, thanks for letting me pick your scheduler brain22:06
bauzas(which makes me pretty off the API doc effort btw. :( )22:06
*** ccarmack has joined #openstack-nova22:06
bauzasthat makes me think of sprints being in first milestones as something difficult if we work on non-prio BPs22:07
*** salv-orl_ has quit IRC22:07
*** mageshgv has quit IRC22:07
bauzasanyway, \o22:08
*** cdelatte has quit IRC22:08
melwitto/22:08
*** burt has quit IRC22:09
*** markvoelker_ has joined #openstack-nova22:10
*** shaohe_feng has quit IRC22:10
oomichisneti: thanks, +222:11
*** ccarmack has quit IRC22:11
*** shaohe_feng has joined #openstack-nova22:11
snetioomichi, thank you!!22:11
*** cdelatte has joined #openstack-nova22:11
*** thorst_ has joined #openstack-nova22:12
*** kfarr has quit IRC22:12
*** _ducttape_ has quit IRC22:13
*** sheel has quit IRC22:15
*** thorst_ has quit IRC22:16
*** thorst_ has joined #openstack-nova22:17
openstackgerritPushkar Umaranikar proposed openstack/nova: api-ref: Method verification for os-floating-ips  https://review.openstack.org/31479422:18
*** thorst_ has quit IRC22:19
*** roeyc has joined #openstack-nova22:19
*** svenkat has quit IRC22:19
*** shaohe_feng has quit IRC22:20
*** shaohe_feng has joined #openstack-nova22:21
*** sdake has joined #openstack-nova22:22
*** roeyc has quit IRC22:23
*** haplo37 has quit IRC22:24
*** delattec has joined #openstack-nova22:24
*** cdelatte has quit IRC22:27
*** whenry has joined #openstack-nova22:27
*** dimtruck is now known as zz_dimtruck22:27
*** lpetrut has quit IRC22:28
*** thorst_ has joined #openstack-nova22:30
*** shaohe_feng has quit IRC22:31
*** thorst_ has quit IRC22:31
*** thorst_ has joined #openstack-nova22:31
*** roeyc has joined #openstack-nova22:31
*** shaohe_feng has joined #openstack-nova22:31
*** markvoelker_ has quit IRC22:32
*** dedery__ has quit IRC22:32
*** jdurgin has quit IRC22:33
*** dedery has joined #openstack-nova22:33
*** jdurgin has joined #openstack-nova22:34
mgagnemelwitt: tyvm for the follow up on bug #1579213. like I mentioned in the bug report, I will reverify my first assumption and see they still hold with the new knowledges you provided.22:34
openstackbug 1579213 in OpenStack Compute (nova) "ComputeFilter fails because compute node has not been heard from in a while" [Undecided,New] https://launchpad.net/bugs/157921322:34
*** mrkz has joined #openstack-nova22:35
melwittmgagne: great. I'm very interested in uncovering what's going on there22:37
*** cdent has quit IRC22:37
openstackgerritAnusha Unnam proposed openstack/nova: api-ref: os-certificates.inc method verification  https://review.openstack.org/31479622:37
*** raildo is now known as raildo-afk22:38
mgagnemelwitt: I think we are hitting a scalability issue with the scheduler where scheduling takes more than 60s22:38
*** claudiub has quit IRC22:40
melwittmgagne: I have seen that before in a 700+ node deployment. we "fixed it" by moving ComputeFilter to the front of the filters list. also, we were running Juno which had some db accesses in some filters, which were very slow once compute nodes got more numerous22:40
mgagnemelwitt: I found that our dev team added some custom filters to the scheduler which could explain why ComputeFilter (and servicegroup) thinks nova-compute is down.22:41
melwittmgagne: so I think we backported some changes from Liberty (?) that removed db access from filters22:41
*** shaohe_feng has quit IRC22:41
mgagnemelwitt: yes, that's the conclusion I come to by talking to my colleagues atm22:41
mgagnecame*22:41
openstackgerritPushkar Umaranikar proposed openstack/nova: api-ref: Method verification for floating-ip-pools  https://review.openstack.org/31479822:41
*** shaohe_feng has joined #openstack-nova22:41
mgagnemelwitt: yes, it makes perfect sense.22:42
*** vladikr has quit IRC22:42
mgagneI will update the bug report with those findings so people can at least look at the filter order if they think they have the same problem22:42
*** zenoway has quit IRC22:43
*** mdrabe has quit IRC22:44
melwittmgagne: sounds good. the only thing that remains unexplained is how forcing a ComputeNode save helped your case. from what I looked around in the Kilo code I don't find connections22:44
*** zenoway has joined #openstack-nova22:44
openstackgerritPushkar Umaranikar proposed openstack/nova: api-ref: Method verification for floating-ip-pools  https://review.openstack.org/31479822:44
mgagneyea, if service state is cached in scheduler once scheduling process begins, I don't see how sending scheduler updates from compute fixes things. Unless I'm missing some complex details about the resource tracker inner working22:45
*** jwcroppe_ has joined #openstack-nova22:45
*** jwcroppe has quit IRC22:47
melwittmgagne: yeah. the twist is you're using Ironic which means you have one resource tracker per Ironic node but only one nova-compute Service, which is much different than the usual vm case of one resource tracker per nova-compute22:47
mgagneyes. This further increases my interest toward all those nova-scheduler performance works people were talking about at the summit22:48
*** zenoway has quit IRC22:48
*** mriedem has joined #openstack-nova22:50
*** shaohe_feng has quit IRC22:51
*** shaohe_feng has joined #openstack-nova22:51
melwittmgagne: same here. you should check out the nova-specs for generic resource pools and dynamic resources classes if you haven't already. there's some stuff in there about allocating nova-compute processes to aggregates, which AFAICT would solve the bottleneck problem we have with Ironic22:51
mgagnemelwitt: this is definitely in my area of interests. I'm still trying to sell the idea to upper management that reviewing and contributing to those specs would be beneficial to us. mainly looking for time resources =)22:53
melwittmgagne: yeah, I know what you mean :)22:54
*** abalutoiu has quit IRC22:54
mgagnehttps://review.openstack.org/#/c/313519/ right?22:54
melwittmgagne: no, there's this one https://review.openstack.org/#/c/300176/ and I'm looking for the second one22:56
melwitthttps://review.openstack.org/#/c/312696/22:57
mgagnetyvm22:57
*** baoli_ has quit IRC23:01
*** shaohe_feng has quit IRC23:01
openstackgerritKaren Bradshaw proposed openstack/nova: [WIP] servers-action-evacuate.inc  https://review.openstack.org/31477623:03
*** tonytan4ever has quit IRC23:03
*** shaohe_feng has joined #openstack-nova23:04
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: method verification of os-assisted-volume-snapshots  https://review.openstack.org/31480223:05
mriedemjaypipes: have you and cdent come to some sort of understanding on the generic-resource-pools spec?23:06
mriedemi saw cdent was pushing changes23:06
*** zz_dimtruck is now known as dimtruck23:09
*** efried has joined #openstack-nova23:10
*** efried has quit IRC23:11
*** shaohe_feng has quit IRC23:12
*** shaohe_feng has joined #openstack-nova23:12
*** jamielennox is now known as jamielennox|away23:13
*** salv-orlando has joined #openstack-nova23:16
*** roeyc has quit IRC23:17
*** delatte has joined #openstack-nova23:18
*** zenoway has joined #openstack-nova23:19
*** hemna is now known as hemnafk23:20
*** svenkat has joined #openstack-nova23:21
*** delattec has quit IRC23:21
*** salv-orlando has quit IRC23:21
*** sdague has quit IRC23:21
*** jamielennox|away is now known as jamielennox23:21
*** shaohe_feng has quit IRC23:22
*** diogogmt has quit IRC23:23
mriedemdansmith: is my understanding here correct? https://review.openstack.org/#/c/312751/7/nova/compute/api.py@97823:23
mgagnemelwitt: it's strange because when comparing nova-scheduler log entries with updated_at field of the service, there is a different of 8 minutes :O (2016-05-06 17:43:51+00:00 vs 2016-05-06 17:51:40.002) that seems very strange. Could accessing some host_state field trigger an implicit database access?23:23
dansmithmriedem: indeed23:24
mriedemf yeah23:24
*** zenoway has quit IRC23:25
*** shaohe_feng has joined #openstack-nova23:25
*** rcernin has quit IRC23:28
*** nic has quit IRC23:29
*** sdake has quit IRC23:30
*** nic has joined #openstack-nova23:30
*** nic has quit IRC23:31
melwittmgagne: I don't think so. the thing I was thinking of was what this commit fixed https://github.com/openstack/nova/commit/3aff2d7bff7f6e9edb5fa8b688287265722c27fb23:31
*** shaohe_feng has quit IRC23:32
melwittmgagne: that commit is part of 2015.1.2 so I think you shouldn't have any db access in your filters. you'll also want to take a look at what you custom filters are doing23:32
mgagneyea, I guess I can post them somewhere23:32
melwittmgagne: for an easy check I would do something like grep for "db\." under nova/scheduler and see if anything comes up, assuming your custom filters are also in that dir23:34
*** sacharya has quit IRC23:34
*** shaohe_feng has joined #openstack-nova23:35
*** sacharya has joined #openstack-nova23:35
melwittmgagne: not that actually but maybe just "db" or "objects" as I notice the db accesses weren't using the db api directly in the commit I linked23:35
mgagnethere is no db module included in our filters nor objects usage. I guess I'll have to profile those filters and see where the time is spent23:36
melwittmgagne: you can find out how long each filter is taking if you turn on debug logging on the scheduler and compare timestamps. to zero in on the slow filter(s)23:36
melwittI turned it on briefly and did a few requests to collect something to look at23:38
*** sdake has joined #openstack-nova23:38
dansmithLOL https://wiki.openstack.org/wiki/ConfigureInstanceTypesDynamically23:38
dansmithglad we have that "proposal" on the wiki23:39
melwittmgagne: based on how long each filter takes and how many hosts are eliminated by each filter, you can reorder your filters to place the most restrictive ones earlier to get rid of more hosts sooner and speed up scheduling23:39
*** rooooook has quit IRC23:39
mgagnenot all filters are logging on our side. will have to add traces I guess23:40
mgagnemelwitt: yea, will have to do that work I guess now that it's a problem23:40
melwittmgagne: oh, on debug even not logging? there should be at least a message about how many hosts passed each filter after each one runs and you can tell how long they took by time deltas on those23:41
*** shaohe_feng has quit IRC23:42
mgagnemelwitt: I'll do my homework and double checks. Looks like DEBUG wasn't enabled in the end, only WARNING were showing from some filters :-/23:43
*** zenoway has joined #openstack-nova23:43
mgagnebut yes, you are right, profile, reorder and update code if needed23:43
melwittdansmith: wait, is that how instance_types went into a db migration?23:43
*** rooooook has joined #openstack-nova23:43
*** rooooook has quit IRC23:43
*** shaohe_feng has joined #openstack-nova23:44
dansmithmelwitt: well, I guess, but it's actually "don't just hard code 7 flavors in python and actually let people *create* flavors" :)23:44
melwittmgagne: yeah, you don't want to have DEBUG on in general, turn on temporarily to collect data and then turn off. it will slow things down23:44
mgagneyes23:44
dansmithmelwitt: if you look at the initial checkin, some file was like "flavors = {'m1.small': ..."23:44
*** rooooook has joined #openstack-nova23:44
melwittdansmith: whoa23:45
*** zenoway has quit IRC23:47
*** shaohe_feng has quit IRC23:53
*** shaohe_feng has joined #openstack-nova23:54
*** crinkle has quit IRC23:55
*** psargent has left #openstack-nova23:55
*** thorst_ has quit IRC23:57
*** pumarani__ has joined #openstack-nova23:57
*** thorst_ has joined #openstack-nova23:58
*** pushkaru has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!