melwitt | yeah, I'm sure he has actually | 00:00 |
---|---|---|
*** Swami_ has quit IRC | 00:00 | |
jaypipes | edleafe: each ironic node will be a separate resource provider in the placement API. and each of those providers will have a single inventory record with a resource class that matches the node.resource_class returned from the Ironic API for that node. | 00:00 |
edleafe | jaypipes: ah, so nested turtles all the way down. | 00:02 |
*** ducttape_ has joined #openstack-nova | 00:03 | |
*** WillUK2010 has quit IRC | 00:04 | |
*** kristian__ has quit IRC | 00:05 | |
*** ijw has quit IRC | 00:06 | |
*** sambetts|afk has quit IRC | 00:08 | |
*** annegentle has quit IRC | 00:10 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove mox in test_block_device_mapping_v1.py https://review.openstack.org/308746 | 00:14 |
*** penick_ has quit IRC | 00:16 | |
*** ijw has joined #openstack-nova | 00:20 | |
*** hongbin has quit IRC | 00:20 | |
*** thorst_ has joined #openstack-nova | 00:21 | |
*** hfu has joined #openstack-nova | 00:22 | |
*** thorst_ has quit IRC | 00:22 | |
*** thorst_ has joined #openstack-nova | 00:23 | |
*** diogogmt has joined #openstack-nova | 00:24 | |
*** ijw has quit IRC | 00:25 | |
*** annegentle has joined #openstack-nova | 00:26 | |
*** thorst_ has quit IRC | 00:31 | |
*** Swami has joined #openstack-nova | 00:32 | |
*** liverpooler has quit IRC | 00:32 | |
*** hfu has quit IRC | 00:35 | |
*** edleafe- has joined #openstack-nova | 00:36 | |
*** edleafe has quit IRC | 00:36 | |
melwitt | mriedem: on https://review.openstack.org/#/c/401375 I'm good with the change but based on my comment it seems like I should update the commit message to explain more. what do you think? | 00:37 |
*** hfu has joined #openstack-nova | 00:39 | |
*** diga has joined #openstack-nova | 00:40 | |
diga | Hi | 00:40 |
diga | I am getting errot in 2016-11-30 00:30:15.293 | output_file = etc/nova/policy.yaml | 00:41 |
diga | 2016-11-30 00:30:15.292 | error: expected '<document start>', but found '<scalar>' | 00:41 |
diga | while installing devstack | 00:41 |
diga | this error comes when devstakc try to run below command | 00:41 |
*** yuntongjin has joined #openstack-nova | 00:41 | |
diga | command /usr/local/bin/nova-manage --config-file /etc/nova/nova.conf db sync | 00:42 |
*** ijw has joined #openstack-nova | 00:42 | |
*** dimtruck is now known as zz_dimtruck | 00:43 | |
*** yingjun has joined #openstack-nova | 00:44 | |
*** nherciu has quit IRC | 00:44 | |
*** ijw has quit IRC | 00:47 | |
*** unicell has quit IRC | 00:48 | |
diga | edleafe-: Hi | 00:49 |
*** ducttape_ has quit IRC | 00:51 | |
*** hoangcx has joined #openstack-nova | 00:55 | |
*** jwcroppe has joined #openstack-nova | 00:55 | |
*** nic has quit IRC | 00:56 | |
*** jwcroppe has quit IRC | 00:56 | |
*** jwcroppe has joined #openstack-nova | 00:56 | |
openstackgerrit | liaonanhai proposed openstack/nova: Use uuidutils instead of uuid.uuid4() https://review.openstack.org/394775 | 00:57 |
*** mtanino has quit IRC | 00:59 | |
*** ducttape_ has joined #openstack-nova | 01:01 | |
*** gjayavelu has quit IRC | 01:01 | |
*** gjayavelu has joined #openstack-nova | 01:03 | |
*** gjayavelu has quit IRC | 01:04 | |
*** giri has joined #openstack-nova | 01:04 | |
openstackgerrit | STEW TY proposed openstack/nova: Transform instance.rescue notifications https://review.openstack.org/385644 | 01:04 |
*** rama_y has quit IRC | 01:05 | |
*** thorst_ has joined #openstack-nova | 01:06 | |
*** esberglu has joined #openstack-nova | 01:06 | |
*** dave-mccowan has joined #openstack-nova | 01:07 | |
*** yuntongjin has quit IRC | 01:07 | |
*** diga has quit IRC | 01:08 | |
mriedem | melwitt: i agree the commit message could be better, | 01:08 |
mriedem | melwitt: if you want, you could just tweak that yourself and then +W | 01:08 |
mriedem | or i can re-+2 | 01:08 |
mriedem | i'll be on for awhile | 01:08 |
melwitt | mriedem: cool, that's what I was thinking | 01:09 |
*** jamesdenton has joined #openstack-nova | 01:10 | |
*** thorst_ has quit IRC | 01:13 | |
*** tovin07_ has quit IRC | 01:16 | |
*** esberglu has quit IRC | 01:17 | |
*** baoli has joined #openstack-nova | 01:18 | |
*** baoli has quit IRC | 01:19 | |
*** baoli has joined #openstack-nova | 01:19 | |
*** jamesdenton has quit IRC | 01:21 | |
*** Swami_ has joined #openstack-nova | 01:22 | |
*** Swami has quit IRC | 01:22 | |
*** ijw has joined #openstack-nova | 01:24 | |
openstackgerrit | melanie witt proposed openstack/nova: Fix wait for detach code to handle 'disk not found error' https://review.openstack.org/401375 | 01:26 |
melwitt | mriedem: I updated the commit message and +2ed | 01:27 |
mriedem | +W, thanks | 01:28 |
mriedem | https://review.openstack.org/#/c/403988/ should also fix some of our ceph job woes | 01:28 |
melwitt | mriedem: a-ha, nice | 01:29 |
mriedem | turns out if you're testing and creating >= 8 1gb volumes at the same time, the host should probably have at least 8gb of storage capacity | 01:30 |
melwitt | I never knew that was related to the disk size | 01:30 |
melwitt | the NoValidHost | 01:30 |
melwitt | haha, really! | 01:30 |
*** ijw has quit IRC | 01:31 | |
*** annp has joined #openstack-nova | 01:32 | |
*** neilhuang has quit IRC | 01:34 | |
*** vearnx has joined #openstack-nova | 01:34 | |
*** Zer0Byte__ has quit IRC | 01:35 | |
*** Swami_ has quit IRC | 01:40 | |
mriedem | wznoinsk: looks like intel nfv ci hits some timeouts during test runs http://intel-openstack-ci-logs.ovh/25/403925/1/check/tempest-dsvm-full-nfv-xenial/c0d0c17/console.html | 01:40 |
mriedem | wznoinsk: how big are the vms that those jobs run on? | 01:42 |
mriedem | upstream is i think 8vcpu 8gb of ram | 01:42 |
*** kristian__ has joined #openstack-nova | 01:49 | |
*** gcb has joined #openstack-nova | 01:50 | |
*** kristian__ has quit IRC | 01:53 | |
*** thorst_ has joined #openstack-nova | 01:55 | |
*** kevinz has joined #openstack-nova | 02:00 | |
*** tbachman has quit IRC | 02:01 | |
*** thorst_ has quit IRC | 02:02 | |
*** tbachman has joined #openstack-nova | 02:05 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port xenapi test_vm_utils to Python 3 https://review.openstack.org/401827 | 02:07 |
*** kaisers_ has joined #openstack-nova | 02:07 | |
*** ijw has joined #openstack-nova | 02:08 | |
*** tlian has quit IRC | 02:09 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_security_group https://review.openstack.org/307135 | 02:09 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_instance_info_cache https://review.openstack.org/307155 | 02:09 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_compute_node https://review.openstack.org/307625 | 02:09 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port test_virt_drivers to Python 3 https://review.openstack.org/403417 | 02:10 |
*** kaisers has quit IRC | 02:10 | |
*** ijw has quit IRC | 02:13 | |
*** sam_nowitzki has joined #openstack-nova | 02:13 | |
*** liusheng has quit IRC | 02:14 | |
*** tovin07 has joined #openstack-nova | 02:16 | |
*** ijw has joined #openstack-nova | 02:18 | |
*** ijw has quit IRC | 02:18 | |
*** esberglu has joined #openstack-nova | 02:20 | |
*** esberglu has joined #openstack-nova | 02:20 | |
*** hongbin has joined #openstack-nova | 02:21 | |
*** liusheng has joined #openstack-nova | 02:22 | |
*** esberglu has quit IRC | 02:25 | |
*** annegentle has quit IRC | 02:26 | |
*** ijw has joined #openstack-nova | 02:29 | |
*** stevemar__ has joined #openstack-nova | 02:29 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: cleanup network volume driver auth config https://review.openstack.org/389389 | 02:29 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: prefer cinder rbd auth values over nova.conf https://review.openstack.org/389399 | 02:29 |
mriedem | mikal: i had to move ^ back to before your change, as it broke the unit tests | 02:30 |
mikal | mriedem: huh | 02:30 |
mikal | mriedem: I wonder why that tweak broke unit tests | 02:30 |
mriedem | see my reply in ps4 | 02:30 |
mikal | Okie | 02:30 |
mriedem | it's an if/elif, not an if/else | 02:31 |
*** diogogmt has quit IRC | 02:31 | |
mikal | Oh, poo | 02:31 |
mriedem | so it's valid to set no values on that conf thing | 02:31 |
mikal | Sorry, business like | 02:31 |
mikal | Bottom | 02:31 |
mikal | My apologies | 02:31 |
mriedem | poopy butt farts is fine in here | 02:31 |
mikal | Awesome | 02:31 |
*** tuanluong has joined #openstack-nova | 02:31 | |
*** hongbin has quit IRC | 02:32 | |
openstackgerrit | Huan Xie proposed openstack/nova: [DO NOT MERGE] Use os-xenapi repo https://review.openstack.org/393103 | 02:32 |
*** ijw has quit IRC | 02:33 | |
smcginnis | lol | 02:33 |
openstackgerrit | Huan Xie proposed openstack/nova: [DO NOT MERGE] Use os-xenapi for nova https://review.openstack.org/393103 | 02:34 |
*** kevinz has quit IRC | 02:35 | |
mriedem | smcginnis: welcome to nova: after dark | 02:35 |
*** kevinz has joined #openstack-nova | 02:35 | |
*** tlian has joined #openstack-nova | 02:37 | |
*** mlavalle has quit IRC | 02:37 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add 'disabled' to WatchdogAction field https://review.openstack.org/386221 | 02:38 |
*** yufei has joined #openstack-nova | 02:39 | |
*** thorst_ has joined #openstack-nova | 02:39 | |
*** ducttape_ has quit IRC | 02:40 | |
*** thorst_ has quit IRC | 02:40 | |
*** baoli has quit IRC | 02:41 | |
smcginnis | ;) | 02:41 |
mikal | Or: Nova, Sensible Timezone Edition | 02:43 |
smcginnis | mriedem: Since you're around - is status.openstack.org not showing anything, or is it a local issue for me? | 02:43 |
mriedem | smcginnis: works for me | 02:44 |
smcginnis | poopy fart butt then. | 02:44 |
mriedem | :) | 02:45 |
smcginnis | Derp, helps if I actually go to the /zuul page. | 02:46 |
*** kevinz has quit IRC | 02:50 | |
*** kevinz has joined #openstack-nova | 02:50 | |
*** browne has quit IRC | 02:52 | |
*** zz_dimtruck is now known as dimtruck | 02:53 | |
*** ayoung has joined #openstack-nova | 03:02 | |
*** giri has quit IRC | 03:07 | |
*** shihanzhang has quit IRC | 03:08 | |
*** ducttape_ has joined #openstack-nova | 03:08 | |
*** zhenq has quit IRC | 03:08 | |
*** yuntongjin has joined #openstack-nova | 03:09 | |
*** gjayavelu has joined #openstack-nova | 03:09 | |
*** gjayavelu has quit IRC | 03:14 | |
*** Apoorva has quit IRC | 03:16 | |
*** code-R has joined #openstack-nova | 03:20 | |
*** kevinz has quit IRC | 03:20 | |
*** code-R_ has joined #openstack-nova | 03:21 | |
*** code-R has quit IRC | 03:25 | |
*** code-R_ has quit IRC | 03:25 | |
*** code-R has joined #openstack-nova | 03:25 | |
*** links has joined #openstack-nova | 03:28 | |
openstackgerrit | Huan Xie proposed openstack/nova: [DO NOT MERGE] Use os-xenapi for nova https://review.openstack.org/393103 | 03:39 |
*** Cristina_ has joined #openstack-nova | 03:42 | |
*** tlbr has quit IRC | 03:44 | |
*** sreeram_v has joined #openstack-nova | 03:45 | |
*** CristinaPauna has quit IRC | 03:45 | |
*** thorst_ has joined #openstack-nova | 03:45 | |
*** tlbr has joined #openstack-nova | 03:45 | |
*** ducttape_ has quit IRC | 03:46 | |
*** yuntongjin has quit IRC | 03:47 | |
*** sreeram_v has quit IRC | 03:47 | |
*** zhangjl has joined #openstack-nova | 03:48 | |
*** sreeram_v has joined #openstack-nova | 03:48 | |
*** sreeram__ has joined #openstack-nova | 03:49 | |
*** bks has joined #openstack-nova | 03:52 | |
*** sreeram_v has quit IRC | 03:52 | |
*** thorst_ has quit IRC | 03:52 | |
*** zhangjl1 has joined #openstack-nova | 03:53 | |
*** sreeram__ has quit IRC | 03:53 | |
*** zhangjl has quit IRC | 03:55 | |
*** nicolasbock has quit IRC | 03:57 | |
*** sreeram_v has joined #openstack-nova | 03:57 | |
*** sreeram__ has joined #openstack-nova | 03:57 | |
*** psachin has joined #openstack-nova | 04:01 | |
*** sreeram_v has quit IRC | 04:02 | |
*** code-R_ has joined #openstack-nova | 04:04 | |
*** code-R has quit IRC | 04:07 | |
*** dave-mccowan has quit IRC | 04:14 | |
*** mdnadeem has joined #openstack-nova | 04:15 | |
*** hieulq_ has joined #openstack-nova | 04:17 | |
*** stevemar__ has quit IRC | 04:19 | |
*** stevemar__ has joined #openstack-nova | 04:19 | |
*** hieulq_ has quit IRC | 04:21 | |
*** stevemar__ has quit IRC | 04:24 | |
*** takashin has quit IRC | 04:26 | |
*** hongbin has joined #openstack-nova | 04:30 | |
*** hongbin has quit IRC | 04:30 | |
*** sudipto has joined #openstack-nova | 04:31 | |
*** sudipto_ has joined #openstack-nova | 04:31 | |
*** prateek has joined #openstack-nova | 04:31 | |
*** baoli has joined #openstack-nova | 04:32 | |
*** hoangcx has quit IRC | 04:35 | |
*** yamahata has quit IRC | 04:35 | |
*** hoangcx has joined #openstack-nova | 04:35 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port compute.test_extended_ip* to Python 3 https://review.openstack.org/403548 | 04:39 |
*** Jeffrey4l has quit IRC | 04:46 | |
*** dimtruck is now known as zz_dimtruck | 04:47 | |
*** zz_dimtruck is now known as dimtruck | 04:47 | |
*** unicell has joined #openstack-nova | 04:52 | |
*** kaisers_ has quit IRC | 04:53 | |
*** prateek has quit IRC | 04:53 | |
*** sudipto_ has quit IRC | 04:54 | |
*** sudipto has quit IRC | 04:54 | |
*** prateek has joined #openstack-nova | 04:54 | |
*** ayogi has joined #openstack-nova | 04:54 | |
*** jgriffith is now known as jgriffith_away | 04:54 | |
*** unicell1 has joined #openstack-nova | 04:56 | |
*** unicell has quit IRC | 04:57 | |
*** Jeffrey4l has joined #openstack-nova | 04:59 | |
*** dimtruck is now known as zz_dimtruck | 05:01 | |
openstackgerrit | Maho Koshiya proposed openstack/nova: Add metadata functional negative tests https://review.openstack.org/391744 | 05:01 |
*** ducttape_ has joined #openstack-nova | 05:10 | |
*** thorst_ has joined #openstack-nova | 05:11 | |
*** ducttape_ has quit IRC | 05:15 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Remove more tests from tests-py3.txt https://review.openstack.org/404543 | 05:17 |
openstackgerrit | Huan Xie proposed openstack/nova: [DO NOT MERGE] Use os-xenapi for nova https://review.openstack.org/393103 | 05:18 |
*** catinthe_ has quit IRC | 05:19 | |
*** sudipto has joined #openstack-nova | 05:19 | |
*** sudipto_ has joined #openstack-nova | 05:20 | |
*** thorst_ has quit IRC | 05:20 | |
*** catintheroof has joined #openstack-nova | 05:21 | |
*** code-R_ has quit IRC | 05:26 | |
*** catintheroof has quit IRC | 05:26 | |
*** mirrorbo1 has quit IRC | 05:35 | |
*** rha has quit IRC | 05:37 | |
*** rha has joined #openstack-nova | 05:38 | |
*** mirrorbo1 has joined #openstack-nova | 05:41 | |
*** markmc has quit IRC | 05:42 | |
*** markmc has joined #openstack-nova | 05:43 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Don't delete neutron port when attach failed https://review.openstack.org/403568 | 05:46 |
*** kaisers has joined #openstack-nova | 05:53 | |
*** gcb has quit IRC | 05:54 | |
*** kristian__ has joined #openstack-nova | 05:55 | |
*** kristian__ has quit IRC | 05:59 | |
*** kristian__ has joined #openstack-nova | 06:00 | |
*** kaisers has quit IRC | 06:02 | |
*** prometheanfire has joined #openstack-nova | 06:06 | |
prometheanfire | booo | 06:06 |
prometheanfire | nova-api: error: unrecognized arguments: -- | 06:06 |
*** gouthamr has joined #openstack-nova | 06:06 | |
prometheanfire | -- is a standard construct for starting options | 06:06 |
*** jaosorior has joined #openstack-nova | 06:06 | |
*** gcb has joined #openstack-nova | 06:07 | |
*** code-R has joined #openstack-nova | 06:08 | |
*** masuberu has quit IRC | 06:13 | |
*** esberglu has joined #openstack-nova | 06:15 | |
*** thorst_ has joined #openstack-nova | 06:18 | |
*** esberglu has quit IRC | 06:19 | |
*** gyx has joined #openstack-nova | 06:22 | |
*** masuberu has joined #openstack-nova | 06:24 | |
*** thorst_ has quit IRC | 06:25 | |
*** yamahata has joined #openstack-nova | 06:26 | |
*** code-R_ has joined #openstack-nova | 06:26 | |
*** masber has joined #openstack-nova | 06:27 | |
*** armax has quit IRC | 06:27 | |
*** stevemar__ has joined #openstack-nova | 06:29 | |
*** markus_z has joined #openstack-nova | 06:29 | |
*** masuberu has quit IRC | 06:29 | |
*** code-R has quit IRC | 06:30 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port compute unit tests to Python 3 https://review.openstack.org/402010 | 06:30 |
openstackgerrit | Yingxin Cheng proposed openstack/nova: Unexpected API error during server create https://review.openstack.org/404565 | 06:30 |
*** rha has quit IRC | 06:32 | |
*** stevemar__ has quit IRC | 06:33 | |
*** avolkov` has joined #openstack-nova | 06:34 | |
*** avolkov has quit IRC | 06:35 | |
*** ijw has joined #openstack-nova | 06:37 | |
*** ijw has quit IRC | 06:41 | |
*** sandanar has joined #openstack-nova | 06:42 | |
*** code-R_ has quit IRC | 06:42 | |
*** tuanluong has quit IRC | 06:42 | |
*** psachin_ has joined #openstack-nova | 06:42 | |
*** edand has joined #openstack-nova | 06:42 | |
*** psachin has quit IRC | 06:45 | |
*** kristian__ has joined #openstack-nova | 06:47 | |
*** kristian__ has quit IRC | 06:47 | |
*** kristia__ has joined #openstack-nova | 06:47 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova: split host_state.least_disk_mb out of free_disk_mb https://review.openstack.org/290302 | 06:50 |
*** kristia__ has quit IRC | 06:50 | |
openstackgerrit | zhaolihui proposed openstack/nova: Fix pci_alias that include white spaces https://review.openstack.org/392077 | 06:50 |
*** kristian__ has joined #openstack-nova | 06:51 | |
openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Check destination_type when booting with bdm provided https://review.openstack.org/402364 | 06:51 |
*** kristia__ has joined #openstack-nova | 06:53 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port virt.libvirt.test_imagebackend to Python 3 https://review.openstack.org/403431 | 06:54 |
openstackgerrit | huangtianhua proposed openstack/nova: Update hostname of server when updating its name https://review.openstack.org/404583 | 06:54 |
*** sridharg has joined #openstack-nova | 06:55 | |
*** sreeram__ has quit IRC | 06:56 | |
*** josecastroleon has joined #openstack-nova | 06:57 | |
*** kristian__ has quit IRC | 06:57 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Don't delete neutron port when attach failed https://review.openstack.org/403568 | 06:58 |
*** kaisers has joined #openstack-nova | 06:58 | |
*** zenoway has joined #openstack-nova | 07:00 | |
*** zenoway has quit IRC | 07:00 | |
*** zenoway has joined #openstack-nova | 07:00 | |
*** oanson has joined #openstack-nova | 07:01 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port xenapi test_vm_utils to Python 3 https://review.openstack.org/401827 | 07:02 |
*** mjura has joined #openstack-nova | 07:04 | |
*** kaisers has quit IRC | 07:06 | |
*** yuntongjin has joined #openstack-nova | 07:06 | |
*** jaosorior has quit IRC | 07:08 | |
*** jaosorior has joined #openstack-nova | 07:08 | |
*** gyx has quit IRC | 07:09 | |
*** esberglu has joined #openstack-nova | 07:09 | |
*** gongysh has joined #openstack-nova | 07:10 | |
openstackgerrit | YuYang proposed openstack/nova: VMware:fix get vm'root deivce conditional judgment https://review.openstack.org/402256 | 07:11 |
*** mjura has quit IRC | 07:11 | |
*** ducttape_ has joined #openstack-nova | 07:11 | |
*** mjura has joined #openstack-nova | 07:11 | |
*** esberglu has quit IRC | 07:14 | |
*** ducttape_ has quit IRC | 07:15 | |
*** yuntongjin has quit IRC | 07:16 | |
openstackgerrit | Jianghua Wang proposed openstack/nova: XenAPI: fix memory usage miscalculation https://review.openstack.org/394857 | 07:19 |
*** irenab has joined #openstack-nova | 07:20 | |
*** hoonetorg has quit IRC | 07:21 | |
*** hoonetorg has joined #openstack-nova | 07:21 | |
*** thorst_ has joined #openstack-nova | 07:24 | |
*** hoonetorg has quit IRC | 07:24 | |
*** hoonetorg has joined #openstack-nova | 07:24 | |
*** sreeram_v has joined #openstack-nova | 07:26 | |
*** moshele has joined #openstack-nova | 07:28 | |
*** rcernin has joined #openstack-nova | 07:28 | |
*** thorst_ has quit IRC | 07:29 | |
*** Cristina_ has quit IRC | 07:30 | |
*** mkoderer has joined #openstack-nova | 07:30 | |
*** sreeram_v has quit IRC | 07:31 | |
*** hieulq_ has joined #openstack-nova | 07:32 | |
*** andreas_s has joined #openstack-nova | 07:36 | |
*** gyx has joined #openstack-nova | 07:37 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova-specs: The ResourceProviderTraits API - Manage traits with ResourceProviders https://review.openstack.org/345138 | 07:38 |
*** sridharg has quit IRC | 07:40 | |
*** Cristina_ has joined #openstack-nova | 07:42 | |
*** sreeram_v has joined #openstack-nova | 07:42 | |
*** gyx has quit IRC | 07:43 | |
*** gjayavelu has joined #openstack-nova | 07:45 | |
*** ekuris has joined #openstack-nova | 07:45 | |
openstackgerrit | Hussain Chachuliya proposed openstack/nova: Refactor: Move post method to APIValidationTestCase base class https://review.openstack.org/364687 | 07:47 |
*** sreeram_v has quit IRC | 07:47 | |
*** sudipto has quit IRC | 07:50 | |
*** sudipto_ has quit IRC | 07:50 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: [WIP] Add version field to LibvirtLiveMigrateData https://review.openstack.org/404607 | 07:50 |
*** matrohon has joined #openstack-nova | 07:50 | |
*** gcb has quit IRC | 07:51 | |
*** gcb has joined #openstack-nova | 07:53 | |
*** avolkov` has quit IRC | 07:54 | |
*** gyx has joined #openstack-nova | 07:54 | |
*** avolkov` has joined #openstack-nova | 07:55 | |
*** gyx has quit IRC | 07:57 | |
openstackgerrit | int32bit proposed openstack/nova: Choose VMware datastore by the least provisioned space https://review.openstack.org/402632 | 07:59 |
*** sridharg has joined #openstack-nova | 08:00 | |
*** josecastroleon has quit IRC | 08:02 | |
*** kaisers has joined #openstack-nova | 08:03 | |
*** artom_ has joined #openstack-nova | 08:04 | |
*** artom_ has quit IRC | 08:05 | |
*** artom_ has joined #openstack-nova | 08:05 | |
*** links has quit IRC | 08:06 | |
*** artom has quit IRC | 08:07 | |
*** josecastroleon has joined #openstack-nova | 08:09 | |
*** aloga_ has joined #openstack-nova | 08:09 | |
*** sreeram_v has joined #openstack-nova | 08:11 | |
*** rha has joined #openstack-nova | 08:13 | |
*** kaisers has quit IRC | 08:13 | |
*** rmart04 has joined #openstack-nova | 08:13 | |
*** aloga_ has quit IRC | 08:15 | |
*** links has joined #openstack-nova | 08:18 | |
*** ralonsoh has joined #openstack-nova | 08:19 | |
*** Jeffrey4l has quit IRC | 08:22 | |
*** Jeffrey4l has joined #openstack-nova | 08:23 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Remove more tests from tests-py3.txt https://review.openstack.org/404543 | 08:23 |
*** amoralej|off is now known as amoralej | 08:25 | |
*** longlq_ has joined #openstack-nova | 08:26 | |
*** thorst_ has joined #openstack-nova | 08:26 | |
*** sam_nowitzki has quit IRC | 08:29 | |
*** stevemar__ has joined #openstack-nova | 08:30 | |
*** stevemar__ has quit IRC | 08:34 | |
*** thorst_ has quit IRC | 08:34 | |
*** sorrison_laptop has joined #openstack-nova | 08:36 | |
*** sorrison_laptop has left #openstack-nova | 08:36 | |
*** yuntongjin has joined #openstack-nova | 08:38 | |
*** gongysh has quit IRC | 08:39 | |
*** sudipto_ has joined #openstack-nova | 08:40 | |
*** sudipto has joined #openstack-nova | 08:40 | |
*** diogogmt has joined #openstack-nova | 08:49 | |
*** fandi has joined #openstack-nova | 08:51 | |
*** esberglu has joined #openstack-nova | 08:58 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-nova | 09:00 | |
*** esberglu has quit IRC | 09:03 | |
*** yuntongjin has quit IRC | 09:04 | |
*** paul-carlton2 has joined #openstack-nova | 09:06 | |
*** aloga_ has joined #openstack-nova | 09:08 | |
*** yamahata has quit IRC | 09:09 | |
*** kaisers has joined #openstack-nova | 09:10 | |
*** lpetrut has joined #openstack-nova | 09:10 | |
*** ducttape_ has joined #openstack-nova | 09:12 | |
*** jaosorior is now known as jaosorior_lunch | 09:13 | |
*** ducttape_ has quit IRC | 09:17 | |
tdurakov | bauzas: hi, could you review this one again https://review.openstack.org/#/c/398956/ | 09:17 |
bauzas | tdurakov: with pleasure | 09:17 |
*** kaisers has quit IRC | 09:17 | |
tdurakov | bauzas: thank you | 09:17 |
openstackgerrit | Teng Fei proposed openstack/nova: Pass the parameter of extra image properties to create_snapshot_force() https://review.openstack.org/404656 | 09:21 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Don't delete neutron port when attach failed https://review.openstack.org/403568 | 09:21 |
*** hieulq_ has quit IRC | 09:21 | |
*** zhangjl1 has quit IRC | 09:24 | |
*** hieulq_ has joined #openstack-nova | 09:24 | |
*** aloga_ has quit IRC | 09:24 | |
*** hieulq_ has quit IRC | 09:26 | |
*** hieulq_ has joined #openstack-nova | 09:28 | |
*** baoli_ has joined #openstack-nova | 09:31 | |
*** yassine has joined #openstack-nova | 09:32 | |
*** thorst_ has joined #openstack-nova | 09:33 | |
*** lucas-afk is now known as lucasagomes | 09:33 | |
*** yassine is now known as Guest62009 | 09:33 | |
*** baoli has quit IRC | 09:33 | |
*** gjayavelu has quit IRC | 09:35 | |
johnthetubaguy | BobBall: is there a meeting today? | 09:35 |
*** masuberu has joined #openstack-nova | 09:36 | |
tdurakov | bauzas: thank you | 09:37 |
*** jotr has quit IRC | 09:37 | |
*** thorst_ has quit IRC | 09:39 | |
*** masber has quit IRC | 09:39 | |
*** jotr has joined #openstack-nova | 09:46 | |
*** bkopilov_ has quit IRC | 09:49 | |
*** yingjun has quit IRC | 09:50 | |
*** yingjun has joined #openstack-nova | 09:51 | |
*** esberglu has joined #openstack-nova | 09:53 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Live migration of instances with encrypted volumes https://review.openstack.org/389608 | 09:54 |
*** hfu has quit IRC | 09:54 | |
*** zenoway has quit IRC | 09:54 | |
*** lpetrut has quit IRC | 09:55 | |
*** yingjun has quit IRC | 09:55 | |
*** esberglu has quit IRC | 09:57 | |
*** lpetrut has joined #openstack-nova | 10:03 | |
*** aloga_ has joined #openstack-nova | 10:03 | |
*** code-R has joined #openstack-nova | 10:04 | |
*** links has quit IRC | 10:05 | |
*** code-R_ has joined #openstack-nova | 10:07 | |
*** code-R has quit IRC | 10:10 | |
*** gjayavelu has joined #openstack-nova | 10:11 | |
*** kaisers has joined #openstack-nova | 10:14 | |
*** hoonetorg has quit IRC | 10:15 | |
*** eglynn has joined #openstack-nova | 10:15 | |
*** Cristina__ has joined #openstack-nova | 10:15 | |
*** hieulq_ has quit IRC | 10:16 | |
*** baoli has joined #openstack-nova | 10:16 | |
*** gjayavelu has quit IRC | 10:16 | |
*** eglynn has quit IRC | 10:16 | |
*** brault has joined #openstack-nova | 10:17 | |
*** andreaf has quit IRC | 10:17 | |
*** sapcc-bot has quit IRC | 10:17 | |
*** carthaca_1 has quit IRC | 10:17 | |
*** sapcc-bot has joined #openstack-nova | 10:17 | |
*** ihrachys has joined #openstack-nova | 10:17 | |
*** david_1 has joined #openstack-nova | 10:17 | |
*** tpatzig_ has joined #openstack-nova | 10:17 | |
*** databus23_ has joined #openstack-nova | 10:17 | |
*** carthaca_ has joined #openstack-nova | 10:17 | |
*** mkoderer_ has joined #openstack-nova | 10:17 | |
*** dgonzalez_ has joined #openstack-nova | 10:17 | |
*** tommy_ has joined #openstack-nova | 10:17 | |
*** kwathore_ has joined #openstack-nova | 10:18 | |
*** tommy_ is now known as Guest24556 | 10:18 | |
*** andreaf has joined #openstack-nova | 10:18 | |
*** pkholkin_ has joined #openstack-nova | 10:18 | |
*** lyarwood_ has joined #openstack-nova | 10:18 | |
*** mkoderer___ has joined #openstack-nova | 10:18 | |
*** mkoderer__ has quit IRC | 10:19 | |
*** logan- has quit IRC | 10:19 | |
*** pkholkin has quit IRC | 10:19 | |
*** pkholkin_ is now known as pkholkin | 10:19 | |
*** lyarwood has quit IRC | 10:19 | |
*** htruta has quit IRC | 10:19 | |
*** Gorian has quit IRC | 10:19 | |
*** anteaya has quit IRC | 10:19 | |
*** baoli_ has quit IRC | 10:19 | |
*** brault_ has quit IRC | 10:19 | |
*** betherly has quit IRC | 10:19 | |
*** rwmjones has quit IRC | 10:19 | |
*** zz_dimtruck has quit IRC | 10:19 | |
*** mrodden has quit IRC | 10:19 | |
*** Cristina_ has quit IRC | 10:19 | |
*** jaosorior_lunch has quit IRC | 10:19 | |
*** ayoung has quit IRC | 10:19 | |
*** bnemec has quit IRC | 10:19 | |
*** mrsoul has quit IRC | 10:19 | |
*** brad[] has quit IRC | 10:19 | |
*** rdo has quit IRC | 10:19 | |
*** briancurtin has quit IRC | 10:19 | |
*** esmiurium has quit IRC | 10:19 | |
*** DinaBelova has quit IRC | 10:19 | |
*** JayF has quit IRC | 10:19 | |
*** leifz has quit IRC | 10:19 | |
*** darrenc has quit IRC | 10:19 | |
*** jschwarz has quit IRC | 10:19 | |
*** carthaca_ has quit IRC | 10:19 | |
*** tpatzig_ has quit IRC | 10:19 | |
*** Guest24556 has quit IRC | 10:19 | |
*** dgonzalez_ has quit IRC | 10:19 | |
*** mkoderer_ has quit IRC | 10:19 | |
*** databus23_ has quit IRC | 10:19 | |
*** david_1 has quit IRC | 10:19 | |
*** kwathore has quit IRC | 10:19 | |
*** mfisch has quit IRC | 10:19 | |
*** bswartz has quit IRC | 10:19 | |
*** dhellmann has quit IRC | 10:19 | |
*** morgabra has quit IRC | 10:19 | |
*** hshiina has joined #openstack-nova | 10:20 | |
*** lpetrut has quit IRC | 10:20 | |
*** darrenc has joined #openstack-nova | 10:20 | |
*** logan- has joined #openstack-nova | 10:20 | |
*** JayF has joined #openstack-nova | 10:20 | |
*** carthaca_ has joined #openstack-nova | 10:20 | |
*** bnemec has joined #openstack-nova | 10:21 | |
*** DinaBelova has joined #openstack-nova | 10:21 | |
*** kaisers has quit IRC | 10:21 | |
*** inara` has joined #openstack-nova | 10:22 | |
*** links has joined #openstack-nova | 10:22 | |
*** tbachman_ has joined #openstack-nova | 10:22 | |
*** alineb- has joined #openstack-nova | 10:22 | |
*** mfisch has joined #openstack-nova | 10:23 | |
*** mfisch has quit IRC | 10:23 | |
*** mfisch has joined #openstack-nova | 10:23 | |
*** alineb- is now known as alineb | 10:23 | |
*** htruta has joined #openstack-nova | 10:23 | |
*** dhellmann has joined #openstack-nova | 10:23 | |
*** briancurtin has joined #openstack-nova | 10:24 | |
*** hoonetorg has joined #openstack-nova | 10:24 | |
*** mrsoul has joined #openstack-nova | 10:24 | |
*** rwmjones has joined #openstack-nova | 10:24 | |
*** Gorian has joined #openstack-nova | 10:24 | |
*** mrodden has joined #openstack-nova | 10:24 | |
*** brad[] has joined #openstack-nova | 10:24 | |
*** _gryf_ has joined #openstack-nova | 10:25 | |
*** leifz has joined #openstack-nova | 10:25 | |
*** zz_dimtruck has joined #openstack-nova | 10:25 | |
*** markmcclain has quit IRC | 10:25 | |
*** zeroDivisible has quit IRC | 10:25 | |
*** tbachman has quit IRC | 10:25 | |
*** Daviey has quit IRC | 10:25 | |
*** _gryf has quit IRC | 10:25 | |
*** sgordon has quit IRC | 10:25 | |
*** inara has quit IRC | 10:25 | |
*** alex_xu has quit IRC | 10:25 | |
*** boris-42 has quit IRC | 10:25 | |
*** code-R_ has quit IRC | 10:25 | |
*** tbachman_ is now known as tbachman | 10:25 | |
*** rdo has joined #openstack-nova | 10:25 | |
*** hoangcx has quit IRC | 10:25 | |
*** zz_dimtruck is now known as dimtruck | 10:25 | |
*** markmcclain has joined #openstack-nova | 10:26 | |
*** code-R has joined #openstack-nova | 10:26 | |
*** sgordon has joined #openstack-nova | 10:26 | |
*** jschwarz has joined #openstack-nova | 10:26 | |
*** alex_xu has joined #openstack-nova | 10:27 | |
*** zeroDivisible has joined #openstack-nova | 10:28 | |
*** boris-42 has joined #openstack-nova | 10:28 | |
*** esmiurium has joined #openstack-nova | 10:28 | |
*** morgabra has joined #openstack-nova | 10:28 | |
*** morgabra has quit IRC | 10:28 | |
*** morgabra has joined #openstack-nova | 10:28 | |
*** slunkad has joined #openstack-nova | 10:29 | |
*** anteaya has joined #openstack-nova | 10:31 | |
*** jaosorior_lunch has joined #openstack-nova | 10:31 | |
*** gjayavelu has joined #openstack-nova | 10:32 | |
*** annp has quit IRC | 10:34 | |
*** pcaruana has joined #openstack-nova | 10:35 | |
*** derekh has joined #openstack-nova | 10:36 | |
*** Daviey has joined #openstack-nova | 10:36 | |
*** betherly has joined #openstack-nova | 10:36 | |
*** betherly has quit IRC | 10:36 | |
*** betherly has joined #openstack-nova | 10:36 | |
*** gjayavelu has quit IRC | 10:36 | |
*** thorst_ has joined #openstack-nova | 10:36 | |
*** cdent has joined #openstack-nova | 10:37 | |
*** psachin_ has quit IRC | 10:40 | |
*** psachin has joined #openstack-nova | 10:40 | |
*** jaosorior_lunch is now known as jaosorior | 10:41 | |
*** longlq_ has quit IRC | 10:43 | |
*** thorst_ has quit IRC | 10:45 | |
*** psachin_ has joined #openstack-nova | 10:47 | |
*** esberglu has joined #openstack-nova | 10:47 | |
*** psachin has quit IRC | 10:48 | |
*** yufei has quit IRC | 10:48 | |
*** rfolco has joined #openstack-nova | 10:49 | |
*** mvk has quit IRC | 10:50 | |
*** kaisers has joined #openstack-nova | 10:51 | |
*** esberglu has quit IRC | 10:52 | |
*** gjayavelu has joined #openstack-nova | 10:52 | |
*** lpetrut has joined #openstack-nova | 10:55 | |
*** gjayavelu has quit IRC | 10:57 | |
*** irenab has quit IRC | 10:58 | |
*** kaisers has quit IRC | 10:59 | |
*** sreeram_v has quit IRC | 11:00 | |
openstackgerrit | Alex Szarka proposed openstack/nova: Transform instance.rebuild.error notification https://review.openstack.org/396621 | 11:00 |
*** lpetrut has quit IRC | 11:01 | |
*** links has quit IRC | 11:07 | |
*** links has joined #openstack-nova | 11:08 | |
*** kaisers1 has quit IRC | 11:10 | |
*** aloga_ has quit IRC | 11:10 | |
openstackgerrit | Hironori Shiina proposed openstack/nova: Ironic: Add soft reboot support to ironic driver https://review.openstack.org/403745 | 11:10 |
*** gabor_antal has quit IRC | 11:15 | |
johnthetubaguy | cdent: can I ask about https://review.openstack.org/#/c/392891/2/nova/api/openstack/placement/deploy.py@54 | 11:15 |
johnthetubaguy | cdent: I am not sure how that works, I am missing something I think | 11:16 |
cdent | hi johnthetubaguy, looking | 11:16 |
cdent | there was a previous version which used conf._get_group('cors'), instead of catching the exceptions, but use of the private message was disliked (understandably), so the exception catching was done | 11:17 |
johnthetubaguy | cdent: so a better question, in production, how does register_opts get called | 11:17 |
johnthetubaguy | who does, I mean | 11:17 |
cdent | oh yeah, that is a different question, one sec, let me remind myself | 11:18 |
cdent | johnthetubaguy: the middleware itself, when you __init__ it | 11:20 |
*** lyarwood_ is now known as lyarwood | 11:20 | |
cdent | does that make a chicken egg problem? | 11:20 |
*** jamespage has joined #openstack-nova | 11:20 | |
* cdent is constantly confused by oslo conf | 11:20 | |
johnthetubaguy | cdent: hmm, possibly | 11:20 |
cdent | one sec, I'll try a few things to see if I can figured it out (need to boot up my vm) | 11:21 |
johnthetubaguy | cdent: maybe we need a placement.enable_cors config? | 11:21 |
*** mvk has joined #openstack-nova | 11:21 | |
cdent | that would be _horrible_ | 11:21 |
jamespage | mriedem, how would you feel about stable backporting the fixes for bug 1639239 to newton? I'd be happy to work through the commits but wanted to checkin on general agreement that's an OK thing first | 11:21 |
openstack | bug 1639239 in python-os-brick (Ubuntu Yakkety) "ValueError for Invalid InitiatorConnector in s390" [Medium,Confirmed] https://launchpad.net/bugs/1639239 | 11:21 |
cdent | adding config in order to be able to use config? | 11:21 |
johnthetubaguy | cdent: agreed, but its better than paste.ini | 11:21 |
*** sudipto has quit IRC | 11:23 | |
*** sudipto_ has quit IRC | 11:23 | |
johnthetubaguy | cdent: oh, that shouldn't be needed | 11:23 |
*** mvk has quit IRC | 11:23 | |
* cdent is trying the tests without registering the opts | 11:23 | |
*** mvk has joined #openstack-nova | 11:24 | |
cdent | johnthetubaguy: ? | 11:24 |
*** kristia__ has quit IRC | 11:26 | |
*** kaisers has joined #openstack-nova | 11:26 | |
*** kristian__ has joined #openstack-nova | 11:26 | |
*** sdague has joined #openstack-nova | 11:27 | |
johnthetubaguy | cdent: I think its the conf.cors bit I don't get, does the comment I just added help? | 11:30 |
*** nherciu has joined #openstack-nova | 11:30 | |
*** jlk has quit IRC | 11:31 | |
cdent | johnthetubaguy: I've followed the link, and I know that stuff, but I'm not clear on what you're suggesting? | 11:31 |
*** jlk has joined #openstack-nova | 11:31 | |
*** jlk has quit IRC | 11:31 | |
*** jlk has joined #openstack-nova | 11:31 | |
cdent | the docs are if you always want to run the middleware | 11:31 |
cdent | i'm trying to make it so the middleware only runs if it has been configured | 11:32 |
johnthetubaguy | cdent: right, but what does "been configured" mean, there is there some enable/disable thing in the cors configuration already? | 11:32 |
johnthetubaguy | s/there is there/is there/ | 11:32 |
cdent | if there is a [cors] section in the conf file | 11:33 |
cdent | the middleware will then use that section, and validate it | 11:33 |
cdent | if it is no good, the service won't start | 11:33 |
*** gjayavelu has joined #openstack-nova | 11:33 | |
cdent | if it not there, the middleware won't be used | 11:33 |
johnthetubaguy | cdent: OK, so by default it can't do anything, but in that case do we just add the middleware every time, and it just doesn't do anything? | 11:35 |
cdent | "that case" is which case? | 11:35 |
johnthetubaguy | erm, I mean when there is no config added in nova.conf | 11:35 |
*** irenab has joined #openstack-nova | 11:35 | |
cdent | what the code in deploy.py is doing is saying "if there is no [cors] in nova.conf, do not include the middleware in the application's stack" | 11:36 |
*** dave-mccowan has joined #openstack-nova | 11:37 | |
*** josecastroleon has quit IRC | 11:37 | |
johnthetubaguy | right, I am asking, can't we just always added cors, and it just reads on the config to decide if it has to do anything | 11:37 |
johnthetubaguy | s/always added/always add/ | 11:37 |
*** gjayavelu has quit IRC | 11:37 | |
cdent | that's not the way the middleware works (as far as I can tell): if it gets passed a config that does not have an 'allowed_origin' value it raises a TypeError | 11:38 |
*** ftersin_ has joined #openstack-nova | 11:38 | |
*** psachin_ has quit IRC | 11:39 | |
johnthetubaguy | cdent: oh, sorry, I see, so you want to check the config to see if allowed_origin is set, ideally | 11:39 |
*** ijw has joined #openstack-nova | 11:39 | |
johnthetubaguy | yeah, I see that now: https://github.com/openstack/oslo.middleware/blob/36c35984a11667290e177e10c6fb67c6a50e1d9b/oslo_middleware/cors.py#L152 | 11:39 |
johnthetubaguy | grr.... | 11:39 |
cdent | your third comment is effectively what the call to factory() is doing | 11:40 |
cdent | all the oslo middlware's provide ways to use non global conf these days, which is a good thing, and the deploy.py is trying to stick to that within itself | 11:41 |
*** gszasz has joined #openstack-nova | 11:42 | |
*** thorst_ has joined #openstack-nova | 11:43 | |
*** tbachman has quit IRC | 11:43 | |
*** psachin has joined #openstack-nova | 11:43 | |
ftersin_ | mdbooth: hi. yesterday i missed your questions for me here by unknown reason. i removed -1 from https://review.openstack.org/#/c/337158 to do not block it | 11:45 |
mdbooth | ftersin_: Thanks! | 11:45 |
pkholkin | bauzas: hi Sylvain, are you here? I want to show you two patches related to scheduler | 11:46 |
ftersin_ | mdbooth: allthough i'm wondering what is a right way to handle such problems | 11:46 |
cdent | johnthetubaguy: I'm fairly certain you've identified a problem, though: without the options being registered, the code in deploy does not work correctly. I think. | 11:46 |
ftersin_ | mdbooth: i still think it requires a release note for the 1st problem, and a separate filed bug for the 2nd one | 11:47 |
*** bks has quit IRC | 11:47 | |
mdbooth | ftersin_: Yup, I'm intending to update that patch with a reno at the very least. | 11:47 |
*** thorst_ has quit IRC | 11:49 | |
*** rtheis has joined #openstack-nova | 11:49 | |
*** aloga_ has joined #openstack-nova | 11:50 | |
*** hfu has joined #openstack-nova | 11:50 | |
ftersin_ | mdbooth: ok. As for https://review.openstack.org/#/c/333244 and the next patch, i think it'd be better to improve them a bit | 11:50 |
*** ijw has quit IRC | 11:52 | |
bhagyashris | cdent: Hi, Can you guide me regarding the gabbi tests. I wrote gabbi test for the fix: https://review.openstack.org/#/c/398998/ and trying to test through the command $ gabbi-run -x [localhost:[port]]/resource_providers < /[file_path] but getting error: Failed to establish a new connection. so where exactly i am going wrong. | 11:53 |
*** gjayavelu has joined #openstack-nova | 11:54 | |
cdent | bhagyashris: yeah, I can help with that, but I'll need to get back with you after I'm done with the thing I'm doing right now. For the gabbi tests that are in nova, you don't use gabbi-run to run them: they are a part of the existing functional tests. If you made changes to the existing yaml files, you can run them with `tox -efunctional placement` | 11:55 |
johnthetubaguy | cdent: yeah, the registering the opts, does cors.set_defaults() work by the way to register the options with oslo? I just found this: https://github.com/openstack/nova/blob/4f91ed3a547965ed96a22520edcfb783e7936e95/nova/common/config.py#L23 | 11:55 |
*** kaisers_ has joined #openstack-nova | 11:56 | |
cdent | my understanding is that is no longer needed | 11:56 |
cdent | (that is, it sets reasonable defaults already) | 11:57 |
bhagyashris | cdent: ok. Thank you. sure will discuss latter once you will get free time. | 11:57 |
*** gjayavelu has quit IRC | 11:58 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Add 'preallocate_images' to 'virt' group https://review.openstack.org/392567 | 12:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Move virt options to a group https://review.openstack.org/392566 | 12:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Detail the 'injected_network_template' opt https://review.openstack.org/392565 | 12:00 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Standardize formatting of virt https://review.openstack.org/392564 | 12:00 |
johnthetubaguy | cdent: I was thinking that should register the options for us, indirectly | 12:01 |
openstackgerrit | Alex Szarka proposed openstack/nova: Transform instance.rebuild.error notification https://review.openstack.org/396621 | 12:03 |
*** ijw has joined #openstack-nova | 12:04 | |
*** kaisers_ has quit IRC | 12:04 | |
*** thorst_ has joined #openstack-nova | 12:07 | |
mdbooth | ftersin_: Thanks! I'm going to have to look into those in detail. | 12:08 |
*** lyarwood is now known as lyarwood_ | 12:08 | |
openstackgerrit | Chris Dent proposed openstack/nova: Add rudimentary CORS support to placement API https://review.openstack.org/392891 | 12:09 |
*** ijw has quit IRC | 12:09 | |
cdent | johnthetubaguy: the changes in that ^ may help to make sense of it. There's probably a bit more adjustments we can do but that actually allows it to work (in devstack) and shows the intent a bit more clearly (in the test fixture). | 12:10 |
*** kristian__ has quit IRC | 12:10 | |
cdent | bhagyashris: did `tox -efunctional placement` get you any further? I'm more free to answer questions now. | 12:11 |
*** kristian__ has joined #openstack-nova | 12:11 | |
*** nicolasbock has joined #openstack-nova | 12:11 | |
*** josecastroleon has joined #openstack-nova | 12:11 | |
*** thorst_ has quit IRC | 12:11 | |
*** gjayavelu has joined #openstack-nova | 12:14 | |
*** ijw has joined #openstack-nova | 12:15 | |
*** diogogmt has quit IRC | 12:15 | |
*** kristian__ has quit IRC | 12:15 | |
bhagyashris | cdent: I have started and it's running. waiting for the result. | 12:15 |
*** diogogmt has joined #openstack-nova | 12:15 | |
*** kristian__ has joined #openstack-nova | 12:15 | |
*** kristian__ has quit IRC | 12:16 | |
*** kristian__ has joined #openstack-nova | 12:16 | |
*** kristian__ has quit IRC | 12:17 | |
*** slagle has joined #openstack-nova | 12:17 | |
*** kristian__ has joined #openstack-nova | 12:17 | |
*** gjayavelu has quit IRC | 12:19 | |
*** aloga_ has quit IRC | 12:19 | |
*** baoli_ has joined #openstack-nova | 12:20 | |
*** baoli has quit IRC | 12:22 | |
*** ijw has quit IRC | 12:25 | |
*** prateek has quit IRC | 12:28 | |
jaypipes | *yawn* | 12:28 |
jaypipes | morning supernovas. | 12:28 |
pkholkin | hi Jay | 12:29 |
*** catintheroof has joined #openstack-nova | 12:29 | |
*** catinthe_ has joined #openstack-nova | 12:32 | |
jaypipes | pkholkin: mornings are never good ;) | 12:33 |
*** diogogmt has quit IRC | 12:33 | |
*** links has quit IRC | 12:34 | |
*** catintheroof has quit IRC | 12:34 | |
pkholkin | jaypipes: that's true) | 12:34 |
*** bvanhav_ has joined #openstack-nova | 12:34 | |
* cdent sings "oh what a beautiful morning oh what a beautiful day" | 12:37 | |
cdent | this morning the frost glittered in the shade of the hedgerows while the sheep frolicked in the fields | 12:37 |
*** _gryf_ is now known as _gryf | 12:41 | |
johnthetubaguy | cdent: it was a really beautiful frost this morning | 12:42 |
* johnthetubaguy goes for lunch | 12:43 | |
*** claudiub has joined #openstack-nova | 12:46 | |
alex_xu | nova api subteam meeting is in 14 mins at #openstack-meeting-4 | 12:47 |
jaypipes | cdent: what about the hedgehogs? were they frosty as well? | 12:48 |
cdent | sleepin' | 12:48 |
jaypipes | :) | 12:49 |
*** amoralej is now known as amoralej|lunch | 12:50 | |
*** aloga_ has joined #openstack-nova | 12:52 | |
*** hfu has quit IRC | 12:52 | |
*** claudiub|2 has joined #openstack-nova | 12:53 | |
*** thorst_ has joined #openstack-nova | 12:53 | |
*** yufei has joined #openstack-nova | 12:54 | |
*** lucasagomes is now known as lucas-hungry | 12:54 | |
*** kylek3h has quit IRC | 12:54 | |
*** claudiub has quit IRC | 12:54 | |
*** ociuhandu has quit IRC | 12:55 | |
*** yingjun has joined #openstack-nova | 12:56 | |
*** gcb has quit IRC | 12:58 | |
*** ociuhandu has joined #openstack-nova | 13:00 | |
cdent | johnthetubaguy: you've opened up a very useful can of worms on this CORS review. it's identified a very weird problem with the 405 handling | 13:00 |
*** claudiub|2 is now known as claudiub | 13:01 | |
*** kaisers_ has joined #openstack-nova | 13:01 | |
*** tbachman has joined #openstack-nova | 13:03 | |
*** lyarwood_ is now known as lyarwood | 13:03 | |
*** jamesdenton has joined #openstack-nova | 13:04 | |
lbeliveau | jaypipes: quick question for you regarding RT, why do we have this check in drop_move_claim() https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L363 | 13:04 |
lbeliveau | I’m observing a different behavior on confirm resize, depending on if the periodic audit has executed or not | 13:04 |
*** ociuhandu has quit IRC | 13:07 | |
jaypipes | lbeliveau: on a call.. gimme a few :) | 13:07 |
lbeliveau | jaypipes: sure, not urgent :) | 13:07 |
jaypipes | lbeliveau: but cfriesen_ can answer that question :) | 13:07 |
*** ducttape_ has joined #openstack-nova | 13:07 | |
*** lyarwood is now known as lyarwood_ | 13:08 | |
*** bkopilov has joined #openstack-nova | 13:08 | |
*** kaisers_ has quit IRC | 13:09 | |
*** jamesdenton has quit IRC | 13:09 | |
lbeliveau | jaypipes: some context for when you have some time ... | 13:10 |
lbeliveau | If the audit hasn’t been triggered and I do confirm, the resources won’t be dropped because the itype stored in the self.tracked_migrations correspond to new flavor | 13:10 |
lbeliveau | But if the audit got executed, it correspond to the old flavor, and resources gets dropped correctly | 13:10 |
_gryf | jaypipes, cdent, hi. i'm finally get back from vacation, takes care about company things that was waitngo for me, and started looking at cdents last email http://lists.openstack.org/pipermail/openstack-dev/2016-November/107982.html | 13:11 |
_gryf | is there any particular thing I can work on? | 13:12 |
*** tbachman has quit IRC | 13:12 | |
*** tbachman has joined #openstack-nova | 13:12 | |
*** catintheroof has joined #openstack-nova | 13:12 | |
*** sahid has joined #openstack-nova | 13:12 | |
_gryf | i mean - around custom resource classes or nested resource providers? | 13:13 |
*** sahid has quit IRC | 13:13 | |
*** sahid has joined #openstack-nova | 13:13 | |
jaypipes | _gryf: gimme a few, on phone | 13:13 |
_gryf | jaypipes, k | 13:14 |
*** sridharg has quit IRC | 13:14 | |
*** catinthe_ has quit IRC | 13:16 | |
*** ljxiash has joined #openstack-nova | 13:17 | |
*** gouthamr has quit IRC | 13:17 | |
*** sudipto_ has joined #openstack-nova | 13:18 | |
*** sudipto has joined #openstack-nova | 13:18 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: Add a releasenote for bug#1633518 https://review.openstack.org/396217 | 13:18 |
bhagyashris | cdent: is it ok to define the test data like 'name' paratmeter value as ('a' * 201) in nova.tests.functional.api.openstackplacemet.fixctures.py | 13:18 |
cdent | bhagyashris: and set it in an environment variable? yes, if you plan to use it multiple times, that would be fine. otherwise it is also okay to just use strings in the yaml files | 13:20 |
*** hfu has joined #openstack-nova | 13:20 | |
*** kristian__ has quit IRC | 13:20 | |
bhagyashris | cdent: ok. thank you. | 13:20 |
jaypipes | bhagyashris: prefer one-off things like that to be just injected into the gabbit file. | 13:21 |
*** kristian__ has joined #openstack-nova | 13:21 | |
jaypipes | bhagyashris: meaning, don't put that into the environment context. | 13:22 |
jaypipes | just hard-code it into the individual gabbit test | 13:22 |
*** code-R_ has joined #openstack-nova | 13:22 | |
*** kylek3h has joined #openstack-nova | 13:22 | |
*** jheroux has joined #openstack-nova | 13:23 | |
*** code-R has quit IRC | 13:24 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Ensure to_xml always returns an ASCII string https://review.openstack.org/402382 | 13:24 |
openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: utils.get_disk return the target dev of the root device https://review.openstack.org/402716 | 13:24 |
openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Use the mirror element to detect when to pivot https://review.openstack.org/399735 | 13:24 |
openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Make guest.BlockDevice only use the target dev of a disk https://review.openstack.org/402163 | 13:24 |
openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Wait for abort_job to complete when not resizing https://review.openstack.org/382449 | 13:24 |
*** sridharg has joined #openstack-nova | 13:25 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Move all extensions from contrib dir https://review.openstack.org/280726 | 13:26 |
*** karthiks has quit IRC | 13:29 | |
*** xyang1 has joined #openstack-nova | 13:30 | |
*** fandi has quit IRC | 13:31 | |
bhagyashris | jaypipes: ok. can you please give me some example how to hard code it in gabbit test? | 13:31 |
jaypipes | bhagyashris: just do: | 13:32 |
jaypipes | data: | 13:32 |
jaypipes | name: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX | 13:32 |
jaypipes | blah blah :) | 13:32 |
*** kaisers_ has joined #openstack-nova | 13:33 | |
mriedem | kashyap: can you jump in -qa re: "libguestfs installed but not usable (/usr/bin/supermin exited with error status 1."? | 13:34 |
kashyap | mriedem: Just going to grap some quick lunch | 13:34 |
kashyap | mriedem: Will join there | 13:34 |
* kashyap joined -qa; normally it's on auto-join | 13:35 | |
*** links has joined #openstack-nova | 13:36 | |
*** links has quit IRC | 13:36 | |
*** edmondsw has joined #openstack-nova | 13:36 | |
*** stevemar__ has joined #openstack-nova | 13:37 | |
bhagyashris | jaypipes: ohh. ok. thanks. :) | 13:37 |
*** ducttape_ has quit IRC | 13:37 | |
*** kaisers_ has quit IRC | 13:39 | |
*** sreeram_v has joined #openstack-nova | 13:39 | |
*** kylek3h has quit IRC | 13:39 | |
*** lamt has joined #openstack-nova | 13:41 | |
*** jwcroppe has quit IRC | 13:41 | |
*** sean-k-mooney has quit IRC | 13:43 | |
*** oanson has quit IRC | 13:43 | |
openstackgerrit | Chris Dent proposed openstack/nova: Add rudimentary CORS support to placement API https://review.openstack.org/392891 | 13:44 |
*** karthiks has joined #openstack-nova | 13:45 | |
cdent | johnthetubaguy: I think that ^ is much more correct now, thanks to you. | 13:45 |
cdent | jaypipes: you might wanna look at that too as it is somewhat different from what you +2d earlier. The handling of config wasn't good enough in the earlier versions. | 13:46 |
cdent | jaypipes: also I left a speculative comment on the start of the nested rps stack | 13:46 |
*** baoli has joined #openstack-nova | 13:48 | |
*** kylek3h has joined #openstack-nova | 13:50 | |
*** baoli_ has quit IRC | 13:50 | |
*** lucas-hungry is now known as lucasagomes | 13:51 | |
*** baoli_ has joined #openstack-nova | 13:54 | |
*** baoli has quit IRC | 13:56 | |
*** esberglu has joined #openstack-nova | 13:56 | |
*** rodrigods is now known as rodrigods_ | 13:58 | |
alex_xu | johnthetubaguy: so let me check more, and update the spec asap | 14:00 |
johnthetubaguy | alex_xu: so its handled here: https://github.com/openstack/nova/blob/3cd2005523dc83b1cadc956c4f86385766aaf679/nova/compute/api.py#L2460 | 14:01 |
johnthetubaguy | alex_xu: cool, thank you | 14:01 |
alex_xu | johnthetubaguy: np | 14:01 |
*** karthiks has quit IRC | 14:02 | |
*** esberglu has quit IRC | 14:03 | |
amrith | mriedem, dansmith ... trove's gate is now running on neutron. https://review.openstack.org/403855 and https://review.openstack.org/403853 are ok to merge. but they failed tests yesterday. | 14:03 |
*** esberglu has joined #openstack-nova | 14:03 | |
alex_xu | johnthetubaguy: that is bad, special for --all-tenant=1 | 14:03 |
johnthetubaguy | alex_xu: what bit is bad? | 14:04 |
*** jwcroppe has joined #openstack-nova | 14:04 | |
*** kaisers_ has joined #openstack-nova | 14:05 | |
*** code-R has joined #openstack-nova | 14:05 | |
alex_xu | johnthetubaguy: it dump all the instances from the db without pagination | 14:05 |
mriedem | amrith: hmm, gate-grenade-dsvm-ubuntu-xenial shouldn't be running on master | 14:05 |
alex_xu | johnthetubaguy: https://github.com/openstack/nova/blob/3cd2005523dc83b1cadc956c4f86385766aaf679/nova/compute/api.py#L2373 | 14:06 |
amrith | mriedem, sorry if I broke it but from the sounds of it, that isn't something I did :( breaking the trove CI, I do that everyday, thrice on Sundays. but not nova ... | 14:06 |
mriedem | no there is probably a regression in project-config | 14:07 |
*** tongli has joined #openstack-nova | 14:07 | |
*** esberglu has quit IRC | 14:07 | |
*** code-R_ has quit IRC | 14:08 | |
johnthetubaguy | alex_xu: true, at least its admin only for the worst of it | 14:08 |
johnthetubaguy | alex_xu: we should probably file a bug for that | 14:08 |
johnthetubaguy | alex_xu: I should just page through extra results if none are found, or something | 14:08 |
johnthetubaguy | s/I/It/ | 14:08 |
*** kaisers_ has quit IRC | 14:09 | |
mriedem | amrith: specifically this change https://review.openstack.org/#/c/398517/ | 14:09 |
mriedem | was meant to restrict gate-grenade-dsvm-ubuntu-xenial to mitaka and newton | 14:09 |
alex_xu | johnthetubaguy: sorry, I didn't get what is mean 'page through extra result' | 14:10 |
amrith | yup | 14:10 |
amrith | i see it | 14:10 |
*** nherciu has quit IRC | 14:10 | |
johnthetubaguy | alex_xu: sorry, I was meaning we could keep the limit param, and when we scan through code, if we run out of servers, we go get more from the DB until we run out, or we find our answer | 14:10 |
*** nherciu has joined #openstack-nova | 14:11 | |
* mriedem git blames layout.yaml | 14:11 | |
alex_xu | johnthetubaguy: ah, i got it, that is better | 14:11 |
lyarwood_ | mriedem: thats failing on stable/newton btw I assume someone just made gate-grenade-dsvm-neutron-multinode-live-migration-nv a xenial job? ./me checks buffer | 14:11 |
amrith | mriedem, in any event I'll try my best to be at your nova meeting tomorrow as dansmith suggested. but 9am is commute time and I may be either there at the very beginning, or at the very end. my update (if any) will only be that we're off nova networking so if it is ok, I'll skip it. | 14:11 |
*** amoralej|lunch is now known as amoralej | 14:11 | |
mriedem | amrith: skip it | 14:11 |
alex_xu | johnthetubaguy: i will file a bug for it | 14:11 |
amrith | thx mriedem will take you up on that. | 14:12 |
mriedem | lyarwood_: yeah someone changed the filters | 14:12 |
amrith | thx muchly | 14:12 |
mriedem | lyarwood_: btw, why did you rebase this twice? https://review.openstack.org/#/c/404508/ | 14:12 |
*** ducttape_ has joined #openstack-nova | 14:12 | |
lyarwood_ | mriedem: gertty-- thought it was a new change the first time and stripped the cherry-picked line | 14:12 |
lyarwood_ | mriedem: the second was just an edit adding that back in | 14:12 |
mriedem | ok | 14:13 |
lyarwood_ | mriedem: sorry about that, I'll wait until it syncs fully next time or just use the webui | 14:13 |
mriedem | i've never used gertty so no idea how that happens | 14:13 |
lyarwood_ | mriedem: it just syncs all reviews into a db locally, I just didn't wait until it had finished this morning before looking for things to cherry-pick | 14:14 |
*** hfu has quit IRC | 14:14 | |
*** esberglu has joined #openstack-nova | 14:16 | |
*** bvanhav_ has quit IRC | 14:16 | |
*** mdrabe has joined #openstack-nova | 14:17 | |
*** eharney has joined #openstack-nova | 14:17 | |
*** ducttape_ has quit IRC | 14:17 | |
kashyap | And the local DB crashes regularly (causing you to reconstruct it from scratch - which is trivial, though), unfortunately, preventing many from adopting it. But lately it's a bit more stable... | 14:18 |
*** karthiks has joined #openstack-nova | 14:19 | |
*** bswartz has joined #openstack-nova | 14:20 | |
*** jamesdenton has joined #openstack-nova | 14:20 | |
*** donnalezyty has joined #openstack-nova | 14:22 | |
*** shuquan has joined #openstack-nova | 14:24 | |
*** pradk has quit IRC | 14:24 | |
*** yingjun has quit IRC | 14:24 | |
*** yingjun has joined #openstack-nova | 14:24 | |
*** mriedem has quit IRC | 14:25 | |
dansmith | amrith: yeah, I wanted status _until_ it's fixed, so if it's fixed, no need | 14:26 |
*** ayoung has joined #openstack-nova | 14:29 | |
amrith | dansmith, g'morning. thx, yes now fixed'ish | 14:29 |
amrith | not out of woods yet | 14:29 |
dansmith | amrith: well, we can re-land our thing right? that's what I mean | 14:30 |
*** victorhe has joined #openstack-nova | 14:30 | |
*** victorhe has left #openstack-nova | 14:31 | |
*** rodrigods_ is now known as rodrigods | 14:31 | |
amrith | dansmith, yes please. I've pushed up those changes. mriedem found an issue with layout.yaml and once that is fixed they can land. | 14:32 |
amrith | the problems we have are now cluster/network related | 14:32 |
amrith | and we've disabled those tests fornow. | 14:32 |
amrith | sorry "disabled those tests for now (TM)" | 14:32 |
*** avolkov` has quit IRC | 14:33 | |
*** READ10 has joined #openstack-nova | 14:33 | |
*** gcb has joined #openstack-nova | 14:33 | |
*** donnalezyty_ has joined #openstack-nova | 14:34 | |
*** donnalezyty has quit IRC | 14:34 | |
*** sudipto_ has quit IRC | 14:35 | |
*** sudipto has quit IRC | 14:35 | |
dansmith | heh | 14:35 |
*** avolkov` has joined #openstack-nova | 14:35 | |
*** bvanhav_ has joined #openstack-nova | 14:35 | |
*** kaisers_ has joined #openstack-nova | 14:38 | |
*** ducttape_ has joined #openstack-nova | 14:39 | |
*** irenab has quit IRC | 14:40 | |
dansmith | alaski: you around by chance? | 14:41 |
*** mdnadeem has quit IRC | 14:42 | |
johnthetubaguy | jaypipes: do you think we need to skip calling save if there are no updates? its probably overkill I guess?: https://review.openstack.org/#/c/400448/3 | 14:43 |
*** mtanino has joined #openstack-nova | 14:43 | |
*** kaisers_ has quit IRC | 14:44 | |
*** tblakes_ has joined #openstack-nova | 14:45 | |
*** Swami has joined #openstack-nova | 14:46 | |
*** aloga_ has quit IRC | 14:47 | |
*** sreeram_v has quit IRC | 14:47 | |
*** tblakes_ is now known as tblakes | 14:49 | |
*** krtaylor has joined #openstack-nova | 14:51 | |
*** bvanhav_ is now known as bvanhav | 14:52 | |
*** tbachman has quit IRC | 14:52 | |
*** kristian__ has quit IRC | 14:52 | |
*** kristian__ has joined #openstack-nova | 14:52 | |
*** tbachman has joined #openstack-nova | 14:53 | |
*** kristia__ has joined #openstack-nova | 14:54 | |
*** unicell1 has quit IRC | 14:55 | |
*** unicell has joined #openstack-nova | 14:55 | |
*** burt has joined #openstack-nova | 14:56 | |
*** mriedem has joined #openstack-nova | 14:56 | |
*** kristian__ has quit IRC | 14:57 | |
*** jaosorior has quit IRC | 14:57 | |
*** tbachman has quit IRC | 14:57 | |
*** kristia__ has quit IRC | 14:58 | |
*** betherly has quit IRC | 14:59 | |
*** jbernard has joined #openstack-nova | 14:59 | |
*** prateek has joined #openstack-nova | 14:59 | |
*** jaosorior has joined #openstack-nova | 14:59 | |
*** anush has joined #openstack-nova | 15:00 | |
*** tbachman has joined #openstack-nova | 15:03 | |
*** eharney has quit IRC | 15:04 | |
jaypipes | johnthetubaguy: it doesn't save if there are no updates, since updates dict would be empty, right? | 15:05 |
*** nherciu has quit IRC | 15:05 | |
*** nherciu has joined #openstack-nova | 15:06 | |
dansmith | jaypipes: looks like id could be changed and attempted to save | 15:06 |
dansmith | but yeah, otherwise there are no other fields to dirty up an updates dict | 15:06 |
dansmith | oh no wait, I have that backwards | 15:07 |
dansmith | only name | 15:07 |
*** tlian has quit IRC | 15:07 | |
dansmith | so, yeah, it won't save unless name is touched, but having confused two of us in five minutes probably means that logic could be cleaner | 15:07 |
jaypipes | dansmith: id is a readonly field though. | 15:07 |
dansmith | right, and the logic here prevents it from being saved, only name | 15:08 |
dansmith | but it's super confusing | 15:08 |
jaypipes | dansmith: I mean, I'm happy to change things, but don't want to do it just for ResourceClass when pretty much no other objects do this AFAICT | 15:08 |
dansmith | no other objects do what? | 15:09 |
dansmith | this patch has logic to ensure that only name is mutable, but it's very confusing logic | 15:09 |
jaypipes | dansmith: do a manual check of whether updates dict is empty and raise some exception that nothing has changed. | 15:09 |
jaypipes | dansmith: what johnthetubaguy was asking for above. | 15:10 |
dansmith | jaypipes: this does do that | 15:10 |
jaypipes | unless I've misunderstood what johnthetubaguy was asking for? | 15:10 |
dansmith | it just does it super confusingly | 15:10 |
*** anush has quit IRC | 15:10 | |
*** prateek has quit IRC | 15:10 | |
jaypipes | dansmith: it's copy-paste code from elsewhere in that file, unfortunately. | 15:10 |
jaypipes | dansmith: one sec, lemme grab a link. | 15:10 |
pkholkin | who is good in scheduler? I want to discuss one issue | 15:11 |
dansmith | well, it's super confusing in that place too :) | 15:11 |
jaypipes | dansmith: no disagreement. bad on me for copy/pasting. | 15:11 |
mriedem | pkholkin: edleafe-, bauzas, johnthetubaguy | 15:11 |
jaypipes | pkholkin: I can help too. | 15:11 |
johnthetubaguy | jaypipes: I think instance does a skip for that one | 15:11 |
edleafe- | pkholkin: go ahead | 15:11 |
dansmith | jaypipes: that said, most objects (at least early ones I wrote) just quietly skip the db call if nothing has changed, which is probably what johnthetubaguy is really getting at | 15:12 |
dansmith | jaypipes: this does that by virtue of checking for the only other field being changed, which is not allowable | 15:12 |
johnthetubaguy | dansmith: oh, I miss read that I guess | 15:12 |
dansmith | johnthetubaguy: it's confusing | 15:12 |
dansmith | johnthetubaguy: if we added another field to this, it would stop doing the thing you want | 15:13 |
pkholkin | edleafe-: johnthetubaguy: jaypipes: I want to share two patches: 1) test fix (incorrect mock) https://review.openstack.org/#/c/402910/ 2) more interesting, I think aggregate_image_properties_isolation works incorrect and it is a bug https://review.openstack.org/#/c/403640/ | 15:13 |
dansmith | johnthetubaguy: regardless, it'd be nice to clean it up so it's less confusing | 15:13 |
*** oanson has joined #openstack-nova | 15:13 | |
pkholkin | I provided this fix to look at, it changes the behaviour of current filter, but I think old behaviour is incorrect | 15:14 |
pkholkin | please look at the commit message and tests there | 15:14 |
pkholkin | what's your opinion? | 15:14 |
mriedem | here it comes | 15:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make test_shelve work with CONF.use_neutron=True by default https://review.openstack.org/397365 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make nova.tests.unit.virt pass with CONF.use_neutron=True by default https://review.openstack.org/396945 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make test_serversV21 tests work with neutron by default https://review.openstack.org/396824 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make test_compute_mgr work with CONF.use_neutron=True by default https://review.openstack.org/396965 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make libvirt unit tests work with CONF.use_neutron=True by default https://review.openstack.org/396904 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make xenapi tests work with CONF.use_neutron=True by default https://review.openstack.org/396905 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make vmware unit tests work with CONF.use_neutron=True https://review.openstack.org/396900 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: neutron: handle no_allocate in create_pci_requests_for_sriov_ports https://review.openstack.org/396359 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Restrict test_compute_cells to nova-network https://review.openstack.org/397336 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Explicitly use nova-network in nova-network network tests https://review.openstack.org/396864 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make test_compute pass with CONF.use_neutron=True by default https://review.openstack.org/399978 | 15:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make test_compute_api work with CONF.use_neutron=True by default https://review.openstack.org/396957 | 15:15 |
jaypipes | dansmith: please point me at the example object you want me to use. I'm having trouble finding one that doesn't look like the ones in resource_provider.py | 15:16 |
openstackgerrit | Leehom Li proposed openstack/nova: Support detach interface with same MAC from instance https://review.openstack.org/372243 | 15:16 |
*** flip214 has joined #openstack-nova | 15:16 | |
*** flip214 has joined #openstack-nova | 15:16 | |
jaypipes | dansmith: for instance... https://github.com/openstack/nova/blob/master/nova/objects/block_device.py#L184 | 15:16 |
edleafe- | pkholkin: I see your point on the defaultdict have sets as values | 15:17 |
jaypipes | dansmith: is virtually the same as what we're doing there. | 15:17 |
*** tlian has joined #openstack-nova | 15:17 | |
*** sudipto has joined #openstack-nova | 15:17 | |
*** sudipto_ has joined #openstack-nova | 15:17 | |
dansmith | jaypipes: but totally not confusing :) | 15:17 |
*** flip214 has left #openstack-nova | 15:17 | |
*** edleafe- is now known as edleafe | 15:17 | |
*** armax has joined #openstack-nova | 15:17 | |
*** sandanar has quit IRC | 15:18 | |
*** stevemar__ has quit IRC | 15:18 | |
jaypipes | dansmith: what am I missing here... how is this confusing? https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L340 | 15:18 |
wznoinsk | mriedem, highlighted the problem with timeouts, thanks, we've increased them last week but it looks like needs extending again, flavor is 14-35-16 | 15:19 |
*** stevemar__ has joined #openstack-nova | 15:19 | |
dansmith | jaypipes: just nevermind, I should never have butted in | 15:19 |
jaypipes | dansmith: no, I want to address this, I'm not being picky or anything. honestly trying to understand what changes to make. | 15:19 |
jaypipes | dansmith: are you and johnthetubaguy asking to change the above to just pop 'uuid' off updates and ignore any changes to that "immutable" field? | 15:20 |
jaypipes | is that what you're asking? | 15:20 |
jaypipes | is it the raising of the ObjectActionError that is confusing? | 15:20 |
jaypipes | or something else? | 15:20 |
johnthetubaguy | jaypipes: I was thinking if you call save(), it would be nice if it was a noop if the name wasn't changed | 15:21 |
*** tbachman has quit IRC | 15:21 | |
johnthetubaguy | jaypipes: but thats more like a polish thing than a requirement thing, really | 15:22 |
jaypipes | johnthetubaguy: not sure why you have to bring Poland into this. | 15:22 |
jaypipes | what did they do? | 15:22 |
jaypipes | :P | 15:22 |
bauzas | sorry folks, had a private emergency issue | 15:22 |
pkholkin | edleafe: yes, first patch is simple, I am more interested in the second | 15:22 |
johnthetubaguy | jaypipes: heh | 15:22 |
jaypipes | johnthetubaguy: AFAIU, this would essentially be a no-op: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L434 | 15:22 |
bauzas | mriedem: what do you want me to look ? | 15:22 |
jaypipes | johnthetubaguy: if nothing was updated on the model. | 15:22 |
mriedem | bauzas: pkholkin had some questions above | 15:23 |
jaypipes | dansmith: does that match your understanding of SQLAlchemy model saving? | 15:23 |
pkholkin | bauzas: hey, I need your opinion on two patches | 15:23 |
pkholkin | yes | 15:23 |
johnthetubaguy | jaypipes: yeah, when updates is empty | 15:23 |
bauzas | pkholkin: sure, lemme know | 15:23 |
*** anush has joined #openstack-nova | 15:23 | |
openstackgerrit | Danil Akhmetov proposed openstack/nova: Use proper user and tenant in the owner section of libvirt.xml. https://review.openstack.org/399679 | 15:23 |
johnthetubaguy | jaypipes: yeah, its possible SQLAlchemy might just no op it anyways | 15:23 |
edleafe | pkholkin: looking at the second patch now | 15:23 |
*** ayogi has quit IRC | 15:23 | |
pkholkin | bauzas: the first patch related to tests https://review.openstack.org/#/c/402910/ (this is simple I think), the second more important https://review.openstack.org/#/c/403640/, I think this filter works incorrect and it is a bug | 15:24 |
pkholkin | I made this patch to have smth to look at | 15:24 |
*** edand has quit IRC | 15:25 | |
dansmith | jaypipes: no idea, and I'm not talking about the no-op part | 15:26 |
bauzas | pkholkin: the first one seems okay to me | 15:26 |
dansmith | jaypipes: I'm talking about the "if updates and updates.keys() != ['name']" thing which is actually just trying to say "if 'id' in updates", but in a very confusing way | 15:27 |
bauzas | pkholkin: about the second, I remember some discussion I had with some other people | 15:27 |
*** pradk has joined #openstack-nova | 15:27 | |
*** eharney has joined #openstack-nova | 15:28 | |
bauzas | pkholkin: looking at https://review.openstack.org/#/c/403640/2/nova/scheduler/filters/aggregate_image_properties_isolation.py | 15:28 |
*** tbachman has joined #openstack-nova | 15:29 | |
*** sridharg has quit IRC | 15:30 | |
*** liverpooler has joined #openstack-nova | 15:30 | |
*** yingjun has quit IRC | 15:30 | |
pkholkin | bauzas: ok, so what about the second? I understand that I change the behaviour of the filter, but I think it is incorrect. I found it working on spec that I wanted to be merged (about strict isolation) | 15:30 |
*** yingjun has joined #openstack-nova | 15:30 | |
bauzas | pkholkin: that's the problem I discussed previously with others | 15:30 |
jaypipes | dansmith: got it. that is clear. will update shortly. | 15:30 |
*** ayoung has quit IRC | 15:30 | |
*** kristian__ has joined #openstack-nova | 15:30 | |
*** annegentle has joined #openstack-nova | 15:31 | |
bauzas | pkholkin: if we check by image properties instead of aggregate metadata keys, I want to make sure we're not modifying the behaviour | 15:31 |
bauzas | pkholkin: because if not, that's terrible for operators | 15:31 |
pkholkin | bauzas: unfortunately I changed it and I think this is correct | 15:32 |
pkholkin | understand that it is not so good | 15:32 |
pkholkin | for existing clouds | 15:32 |
bauzas | pkholkin: the real problem is that changing how a filter works means really a new situation | 15:33 |
pkholkin | but now docs and implementation differs( | 15:33 |
*** kristian__ has quit IRC | 15:34 | |
*** kristian__ has joined #openstack-nova | 15:34 | |
pkholkin | bauzas: what we can do with it? | 15:34 |
bauzas | pkholkin: honestly, while I can review your first change quickly, I need more time to think about the latter | 15:34 |
*** gouthamr has joined #openstack-nova | 15:35 | |
*** yingjun has quit IRC | 15:35 | |
bauzas | pkholkin: what I need to consider is what could happen if we are not testing all aggregate keys like we did | 15:35 |
pkholkin | bauzas: I think we should discuss it with other folks | 15:35 |
bauzas | if we're sure that we're testing each of the possible image/agg keys, then okay | 15:35 |
pkholkin | my understanding is that this filter should works as AggregateInstanceExtraSpecsFilter | 15:36 |
bauzas | pkholkin: probably, but I need to think again about this filter | 15:36 |
pkholkin | but now they differs | 15:36 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Add 'preallocate_images' to 'virt' group https://review.openstack.org/392567 | 15:36 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Move virt options to a group https://review.openstack.org/392566 | 15:36 |
bauzas | pkholkin: well, that's not necessary | 15:36 |
pkholkin | edleafe: jaypipes: please participate in this, please ^ | 15:36 |
pkholkin | bauzas: yes, but ideally they should imho | 15:37 |
bauzas | pkholkin: I mean, your opinion that the both filters should work the same way is possibly understood, but that's not what's here now | 15:37 |
bauzas | pkholkin: yeah, agreed, but changing an existing filter behaviour is not something we should change smoothly | 15:37 |
pkholkin | bauzas: agree with it, but | 15:37 |
pkholkin | bauzas: these docs http://docs.openstack.org/mitaka/config-reference/compute/scheduler.html and http://docs.openstack.org/developer/nova/filter_scheduler.html said that we should iterate over query I think | 15:38 |
pkholkin | so, I think we have a mistake ( | 15:38 |
bauzas | pkholkin: to make it clear, my main concern is that if we modify this filter, I want to have it a backwards compatibilty | 15:38 |
pkholkin | bauzas: that's true, do you have ideas how we can do this? | 15:39 |
*** ekuris has quit IRC | 15:40 | |
*** gcb has quit IRC | 15:40 | |
*** kaisers_ has joined #openstack-nova | 15:41 | |
*** darrenc has quit IRC | 15:41 | |
*** darrenc has joined #openstack-nova | 15:42 | |
edleafe | pkholkin: it certainly does seem to change the existing behavior of the filter. | 15:42 |
*** hongbin has joined #openstack-nova | 15:42 | |
pkholkin | yes | 15:42 |
edleafe | pkholkin: my question is: are there bug reports about this? Are others complaining about its behavior? | 15:43 |
pkholkin | edleafe: not sure, I found it during working on https://review.openstack.org/#/c/381912/ | 15:43 |
edleafe | pkholkin: I don't know enough about the use of this filter in the field to have an opinion, other than don't break things | 15:43 |
pkholkin | I supposed that those filters should work in the same way | 15:44 |
*** moshele has quit IRC | 15:45 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate all nova-net related opts https://review.openstack.org/395683 | 15:48 |
*** hieulq_ has joined #openstack-nova | 15:48 | |
*** yufei has quit IRC | 15:48 | |
*** jdurgin1 has joined #openstack-nova | 15:48 | |
bauzas | pkholkin: like I said, I need time to think of that | 15:50 |
bauzas | but first, I need to code back :) | 15:50 |
*** TravT has quit IRC | 15:50 | |
*** mlavalle has joined #openstack-nova | 15:53 | |
*** shuquan has quit IRC | 15:58 | |
*** jaosorior has quit IRC | 15:58 | |
*** Sukhdev_ has joined #openstack-nova | 15:58 | |
*** psachin has quit IRC | 15:59 | |
*** hshiina has quit IRC | 15:59 | |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: REST API for resource classes https://review.openstack.org/391959 | 15:59 |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: adds ResourceClass.save() https://review.openstack.org/400448 | 15:59 |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: adds ResourceClass.destroy() https://review.openstack.org/391918 | 15:59 |
sfinucan | sahid: Could I get you to take a look at this when you have a chance. Having trouble understanding how libvirt "cap(abilitie)s" get translated into something the filters can see/parse https://review.openstack.org/#/c/399653 | 16:00 |
sfinucan | vladikr - likewise ^ | 16:00 |
*** _ducttape_ has joined #openstack-nova | 16:00 | |
vladikr | sfinucan, sure | 16:01 |
sfinucan | vladikr: Cheers :) | 16:01 |
*** thorst_ has quit IRC | 16:01 | |
*** edmondsw_ has joined #openstack-nova | 16:02 | |
*** rcernin has quit IRC | 16:02 | |
*** gouthamr has quit IRC | 16:02 | |
*** code-R has quit IRC | 16:02 | |
*** edmondsw has quit IRC | 16:02 | |
*** edmondsw_ has quit IRC | 16:02 | |
*** edmondsw has joined #openstack-nova | 16:03 | |
*** ducttape_ has quit IRC | 16:03 | |
cdent | jaypipes: another thing worth mentioning, should we do this at some point: https://review.openstack.org/#/c/404279/ | 16:04 |
cdent | (get rid of remotable in rp stuff) | 16:04 |
*** andreas_s has quit IRC | 16:04 | |
*** Sukhdev_ has quit IRC | 16:09 | |
*** tbachman has quit IRC | 16:09 | |
*** jgriffith_away is now known as jgriffith | 16:09 | |
jaypipes | cdent: ya. | 16:10 |
jaypipes | dansmith, johnthetubaguy: addressed your concerns in above ResourceClass patches. | 16:10 |
edleafe | cdent: Yeah, I can't see this going over conductor at any point | 16:11 |
cdent | Do we need to time the change with anything, or can we just do it? | 16:11 |
*** kaisers_ has quit IRC | 16:11 | |
* cdent wants to be able to read * comprehensions as well as edleafe | 16:12 | |
bauzas | cdent: wait, why removing the possibility to have those objects remotable ? | 16:13 |
cdent | edleafe: "unhelpful unit tests can be" s/unit tests/mocks/ | 16:13 |
bauzas | cdent: because you definitely want to cut the line ? | 16:13 |
*** jdillaman has quit IRC | 16:13 | |
cdent | bauzas: because we don't _want_ them to be remotable, we want the data only accessed over the api | 16:13 |
*** ihrachys has quit IRC | 16:14 | |
cdent | and if we aren't going to use remotability, then having it in there is useless expense | 16:14 |
bauzas | cdent: well, if we don't have the indirection API equals to None, why it's a problem ? | 16:15 |
bauzas | by default, objects are not indirecting to the conductor | 16:15 |
cdent | you still have to pass through the decorator code | 16:15 |
bauzas | and what if sometimes later we could want to have those methods be remotable ? | 16:15 |
cdent | does it make a big difference, no not at all, but if it is not required, may as well not be there | 16:15 |
bauzas | like if we were having another engine as a service ? | 16:16 |
cdent | then we could put it back when we actually need it | 16:16 |
*** mjura has quit IRC | 16:16 | |
*** Bofu2U has joined #openstack-nova | 16:16 | |
pkholkin | edleafe: thanks for review | 16:16 |
cdent | but ideally the resources in the http api are the main interface | 16:16 |
bauzas | I'm not sure I like removing that design pattern, because that means that those methods *could* be remotable | 16:16 |
*** mjura has joined #openstack-nova | 16:16 | |
cdent | bauzas: I'm not sure I'm following you, can you elaborate? | 16:17 |
bauzas | cdent: having those methods marked as remotable means they *could* be remotable | 16:17 |
cdent | yes, that's what we want to prevent | 16:18 |
bauzas | why should it be a problem to have those remotable ? | 16:18 |
pkholkin | mriedem: do we have some features to help about API/DB areas? maybe smth else | 16:18 |
cdent | bauzas: why should it be a problem to have them not remotable? If we make them remotable but don't need them to be, then we have a classic case of YAGNI | 16:19 |
pkholkin | I think I will not write email about that my spec, so I can help to implement smth | 16:19 |
*** danpawlik has quit IRC | 16:21 | |
cfriesen_ | so I've been poking around the "suspend" code, and it seems to be pretty fragile...there are no checks for whether there's enough space, and no resources get updated either on suspend or resume | 16:22 |
cfriesen_ | this seems odd when it could easily take many GB for the managed-save file. | 16:22 |
*** _ducttape_ has quit IRC | 16:23 | |
*** ducttape_ has joined #openstack-nova | 16:24 | |
sahid | sfinucan: i will do it, thanks for those tests | 16:24 |
*** ducttape_ has quit IRC | 16:25 | |
*** ducttape_ has joined #openstack-nova | 16:25 | |
pkholkin | cfriesen_: hello Chris, I'm sorry, are you an operator? | 16:25 |
pkholkin | do you see this my spec? https://review.openstack.org/#/c/381912/ | 16:25 |
*** yamahata has joined #openstack-nova | 16:26 | |
cfriesen_ | pkholkin: nope, I'm a dev | 16:26 |
jaypipes | johnthetubaguy: hopefully I did the whole oslo.concurrency.lockutils like you wanted. | 16:26 |
*** jdillaman has joined #openstack-nova | 16:27 | |
*** code-R has joined #openstack-nova | 16:27 | |
pkholkin | cfriesen_: ok, sorry) | 16:27 |
pkholkin | saw your some changes in scheduler, you are welcome to the spec if you are interested in) | 16:28 |
*** paw has quit IRC | 16:28 | |
mriedem | pkholkin: api/db areas? i don't understand the question. | 16:29 |
*** jamesdenton has quit IRC | 16:29 | |
*** ducttape_ has quit IRC | 16:29 | |
*** ducttape_ has joined #openstack-nova | 16:30 | |
pkholkin | mriedem: these are areas that I like) just looking for some thing to implement | 16:30 |
pkholkin | will look approved blueprint list | 16:31 |
mriedem | pkholkin: yeah on a call, just a min | 16:31 |
*** hieulq_ has quit IRC | 16:31 | |
mriedem | pkholkin: this hasn't started yet https://blueprints.launchpad.net/nova/+spec/deprecate-image-meta-proxy-api | 16:32 |
mriedem | alex_xu: might be cool with you taking that | 16:32 |
*** jamesdenton has joined #openstack-nova | 16:32 | |
cardeois | Hello there ! If somebody has time to review this CORS fix that would really help me if it gets merged ! https://review.openstack.org/#/c/400785/ | 16:33 |
pkholkin | np, will look | 16:34 |
*** code-R has quit IRC | 16:35 | |
*** gjayavelu has joined #openstack-nova | 16:35 | |
*** hieulq_ has joined #openstack-nova | 16:38 | |
*** gjayavelu has quit IRC | 16:40 | |
*** tbachman has joined #openstack-nova | 16:44 | |
*** tbachman_ has joined #openstack-nova | 16:46 | |
*** ljxiash has quit IRC | 16:47 | |
*** ljxiash has joined #openstack-nova | 16:47 | |
cardeois | thanks pkholkin ! | 16:48 |
*** tbachman has quit IRC | 16:49 | |
*** tbachman_ is now known as tbachman | 16:49 | |
*** jamesdenton has quit IRC | 16:49 | |
*** hieulq_ has quit IRC | 16:52 | |
*** ljxiash has quit IRC | 16:52 | |
*** mdrabe has quit IRC | 16:52 | |
*** hieulq_ has joined #openstack-nova | 16:55 | |
*** Zer0Byte__ has joined #openstack-nova | 16:55 | |
*** thorst_ has joined #openstack-nova | 16:56 | |
cdent | edleafe, jaypipes is this still active? https://review.openstack.org/#/c/382000/ | 16:57 |
*** rama_y has joined #openstack-nova | 16:59 | |
jaypipes | cdent: no. | 17:00 |
jaypipes | cdent: shouldn't be. | 17:00 |
jaypipes | cdent: edleafe I think can abandon that one. he was listed on a similar patch that merged called "genericize on resource provider" (or somehting like that) | 17:00 |
*** dimtruck is now known as zz_dimtruck | 17:01 | |
*** mdrabe has joined #openstack-nova | 17:01 | |
*** mjura has quit IRC | 17:03 | |
cdent | ✔ | 17:03 |
edleafe | cdent: yeah, I think it's redundant. | 17:05 |
cdent | kill it with fire! | 17:05 |
cdent | scatter the ashes | 17:05 |
cdent | etc | 17:05 |
edleafe | cdent: well, I was going to double-check first, but if you're in a rush... | 17:06 |
edleafe | cdent: :) | 17:06 |
cdent | heh | 17:06 |
*** code-R has joined #openstack-nova | 17:06 | |
*** matrohon has quit IRC | 17:07 | |
openstackgerrit | Sujitha proposed openstack/nova: Improve help text for network options. https://review.openstack.org/341203 | 17:07 |
*** kaisers_ has joined #openstack-nova | 17:08 | |
edleafe | cdent: done | 17:10 |
cdent | You are a credit to the universe. The less-noise league salutes you. | 17:10 |
*** zz_dimtruck is now known as dimtruck | 17:10 | |
*** catintheroof has quit IRC | 17:11 | |
*** slaweq_ has joined #openstack-nova | 17:11 | |
*** catintheroof has joined #openstack-nova | 17:12 | |
*** paw has joined #openstack-nova | 17:13 | |
*** nic has joined #openstack-nova | 17:13 | |
kashyap | [OT] Hey folks, since we use QEMU, maybe I thought it's appropriate to 'spam' this announcement here: | 17:15 |
*** Kevin_Zheng has quit IRC | 17:15 | |
kashyap | Tomorrow starts QEMU Advent Calendar -- https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg03990.html | 17:15 |
*** kfarr has joined #openstack-nova | 17:15 | |
*** kaisers_ has quit IRC | 17:15 | |
kashyap | If you have any fun ideas for a disk image, feel free to contact on the email address mentioned there :-) | 17:16 |
kashyap | </EOM> | 17:16 |
*** Kevin_Zheng has joined #openstack-nova | 17:17 | |
*** code-R has quit IRC | 17:17 | |
*** jgriffith is now known as jgriffith_away | 17:19 | |
*** hieulq_ has quit IRC | 17:21 | |
*** pcaruana has quit IRC | 17:23 | |
*** slaweq_ has quit IRC | 17:23 | |
*** slaweq_ has joined #openstack-nova | 17:24 | |
*** code-R has joined #openstack-nova | 17:25 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Extend get_all_by_filters to support resource criteria https://review.openstack.org/386242 | 17:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: Expose a REST API method for a specific list of RPs https://review.openstack.org/392569 | 17:25 |
*** rmart04 has quit IRC | 17:29 | |
*** tongli has quit IRC | 17:30 | |
*** rodrigods is now known as rodrigods_ | 17:31 | |
*** woodster_ has joined #openstack-nova | 17:33 | |
*** penick has joined #openstack-nova | 17:36 | |
*** slaweq_ has quit IRC | 17:36 | |
*** mvk has quit IRC | 17:40 | |
*** kristian__ has quit IRC | 17:43 | |
*** kristian__ has joined #openstack-nova | 17:44 | |
pkholkin | mriedem: question about https://blueprints.launchpad.net/nova/+spec/deprecate-image-meta-proxy-api, do we want to add new microversion and deprecate 'image-metadata' in it? | 17:45 |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: REST API for resource classes https://review.openstack.org/391959 | 17:45 |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: adds ResourceClass.save() https://review.openstack.org/400448 | 17:45 |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: adds ResourceClass.destroy() https://review.openstack.org/391918 | 17:45 |
*** edand has joined #openstack-nova | 17:46 | |
mriedem | pkholkin: did you read the spec? | 17:46 |
mriedem | https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/deprecate-image-meta-proxy-api.html | 17:47 |
pkholkin | very very fast) | 17:47 |
*** derekh has quit IRC | 17:47 | |
mriedem | pkholkin: so basically it's the same pattern as 2.36 http://docs.openstack.org/developer/nova/api_microversion_history.html#id33 | 17:48 |
*** lucasagomes is now known as lucas-afk | 17:48 | |
openstackgerrit | Chris Dent proposed openstack/nova: Add rudimentary CORS support to placement API https://review.openstack.org/392891 | 17:48 |
*** kristian__ has quit IRC | 17:48 | |
pkholkin | yes, I looked it | 17:48 |
mriedem | pkholkin: but for this extension https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/image_metadata.py | 17:48 |
*** nherciu has quit IRC | 17:48 | |
pkholkin | looks not so complicated | 17:48 |
mriedem | so after a new microversion, all of the control methods in there will 404 | 17:49 |
mriedem | nope | 17:49 |
mriedem | pretty straight forward | 17:49 |
mriedem | and then the similar changes in novaclient | 17:49 |
mriedem | as we did for 2.36 | 17:49 |
pkholkin | I think I will work on this | 17:49 |
mriedem | amrith: https://review.openstack.org/#/c/404895/ should get us going | 17:49 |
mriedem | pkholkin: cool, thanks | 17:49 |
mriedem | pkholkin: i really appreciate you stepping up to help out with an already approved but not yet started bp | 17:50 |
*** unicell has quit IRC | 17:50 | |
*** dimtruck is now known as zz_dimtruck | 17:51 | |
pkholkin | mriedem: no problem, this often happens) I will look on 2.36 changes and will prepare some wip patch to look at | 17:51 |
*** yamahata has quit IRC | 17:51 | |
amrith | thx mriedem | 17:52 |
*** Apoorva has joined #openstack-nova | 17:52 | |
pkholkin | almost everything seems clear to me | 17:52 |
*** matrohon has joined #openstack-nova | 17:52 | |
*** mriedem1 has joined #openstack-nova | 17:54 | |
*** mriedem has quit IRC | 17:56 | |
mriedem1 | jroll: have you seen this? https://wiki.openstack.org/wiki/Nimble | 17:59 |
*** mriedem1 is now known as mriedem | 17:59 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Move all extensions from contrib dir https://review.openstack.org/280726 | 18:00 |
*** jgriffith_away is now known as jgriffith | 18:00 | |
*** markus_z has quit IRC | 18:02 | |
*** ralonsoh has quit IRC | 18:04 | |
*** penick has quit IRC | 18:05 | |
*** gjayavelu has joined #openstack-nova | 18:06 | |
*** sudipto_ has quit IRC | 18:06 | |
*** sudipto has quit IRC | 18:06 | |
*** gjayavelu has quit IRC | 18:07 | |
paul-carlton2 | mriedem, can you take a look at https://review.openstack.org/#/q/status:open+topic:bp/detach-boot-volume please | 18:07 |
*** zz_dimtruck is now known as dimtruck | 18:10 | |
*** penick has joined #openstack-nova | 18:11 | |
*** mbirru has joined #openstack-nova | 18:11 | |
*** sahid has quit IRC | 18:12 | |
*** kaisers_ has joined #openstack-nova | 18:12 | |
*** ihrachys has joined #openstack-nova | 18:15 | |
*** ayoung has joined #openstack-nova | 18:16 | |
*** kaisers_ has quit IRC | 18:19 | |
*** ftersin_ has quit IRC | 18:20 | |
*** edand has quit IRC | 18:20 | |
*** dave-mcc_ has joined #openstack-nova | 18:23 | |
*** unicell has joined #openstack-nova | 18:24 | |
*** dave-mccowan has quit IRC | 18:26 | |
*** mriedem has quit IRC | 18:27 | |
*** kylek3h has quit IRC | 18:28 | |
*** lyarwood_ is now known as lyarwood | 18:30 | |
*** mriedem has joined #openstack-nova | 18:30 | |
*** ihrachys has quit IRC | 18:31 | |
*** tjones has joined #openstack-nova | 18:33 | |
*** tjones has left #openstack-nova | 18:33 | |
*** colby_ has joined #openstack-nova | 18:33 | |
colby_ | Hey we just upgrade to Mitaka. We are having issues with the nova api for some of our projects. We have projects that the ids are the same as the name. This was to not break legacy swift swuath users. Does the new version of the api not work if the tenant/project id is not uuid? | 18:34 |
*** yamahata has joined #openstack-nova | 18:34 | |
mriedem | colby_: see http://docs.openstack.org/releasenotes/nova/mitaka.html | 18:35 |
mriedem | In order to make project_id optional in urls, we must constrain the set of allowed values for project_id in our urls. This defaults to a regex of [0-9a-f\-]+, which will match hex uuids (with / without dashes), and integers. This covers all known project_id formats in the wild. If your site uses other values for project_id, you can set a site specific validation with project_id_regex config variable. | 18:35 |
*** paul-carlton2 has quit IRC | 18:35 | |
*** ljxiash has joined #openstack-nova | 18:35 | |
colby_ | should that regex not match an id like "cinergi"? | 18:35 |
*** Swami has quit IRC | 18:36 | |
*** oanson has quit IRC | 18:36 | |
mriedem | regexpal.com is telling me it doesn't | 18:36 |
*** Swami has joined #openstack-nova | 18:37 | |
mriedem | oh a-f | 18:37 |
mriedem | for hex uuids | 18:37 |
mriedem | so no that won't work | 18:37 |
mriedem | you'll need to set the project_id_regex config option | 18:37 |
colby_ | oh duh a-f not a-z | 18:37 |
colby_ | sorry for the confusion | 18:37 |
mriedem | np, i was confused too :) | 18:38 |
colby_ | I saw notes that the config was going to be deprecated. Will this be a breaking point in the future? | 18:38 |
mriedem | looks like yes, | 18:39 |
mriedem | i imagine that option was added as an immediately deprecated backdoor option for people upgrading to mitaka, such as yourself | 18:39 |
mriedem | sdague made those changes so he might remember better | 18:39 |
*** ljxiash has quit IRC | 18:39 | |
mriedem | colby_: but as noted, we're working on making project_ids optional in the urls | 18:40 |
mriedem | so not sure why you'd need the project name encoded in the project id | 18:40 |
mriedem | except maybe convenience | 18:40 |
*** kylek3h has joined #openstack-nova | 18:41 | |
colby_ | well horizon seems to do it along with the command line client. Thats how we found it it didn't work. | 18:42 |
colby_ | so hopefully they drop that in the future release too :) | 18:43 |
* robcresswell reading scrollback | 18:44 | |
robcresswell | What's Horizon need to change? Not entirely sure I follow | 18:44 |
colby_ | when you view instances it makes a call to /v2/cinergi/serers and gets a 404 becuase it puts the project id in the url | 18:45 |
*** dharinic is now known as dharinic|lunch | 18:47 | |
robcresswell | Ah | 18:47 |
*** amoralej is now known as amoralej|off | 18:47 | |
robcresswell | colby_: Could you open a bug against Horizon with more info? | 18:47 |
*** Bofu2U has quit IRC | 18:47 | |
mriedem | hmm, that's a v2 route, the project_id being optional is in v2.18 http://docs.openstack.org/developer/nova/api_microversion_history.html#id16 | 18:48 |
jroll | mriedem: choosing to ignore nimble as much as possible, honestly | 18:48 |
colby_ | the command line client does the same thing too | 18:48 |
*** rodrigods_ is now known as rodrigods | 18:49 | |
mriedem | colby_: this was the change btw https://review.openstack.org/#/c/233076/ | 18:49 |
mriedem | 2.18 doesn't help you if you're on v2 still | 18:50 |
mriedem | this is unrelated fun - tempest failed this patch during a shelve/unshelve test where in the process of unshelving, libvirt's lifecycle event callback stuff stops the server http://logs.openstack.org/08/404508/3/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/f2ef8c2/logs/screen-n-cpu.txt.gz#_2016-11-30_09_51_58_921 | 18:52 |
mriedem | so the unshelved server never goes active | 18:52 |
mriedem | if the task_state is set though we shouldn't process that request | 18:52 |
*** jdurgin1 has quit IRC | 18:55 | |
*** penick has quit IRC | 18:57 | |
*** penick has joined #openstack-nova | 19:01 | |
*** stewie925 has joined #openstack-nova | 19:03 | |
mriedem | figured it out, nice.... | 19:04 |
mriedem | nic: cburgess: so do you guys support shelve? | 19:05 |
mriedem | a customer would probably never hit this | 19:05 |
nic | In theory, we do, but nobody seems to know what it is ;) | 19:06 |
mriedem | ok, | 19:06 |
mriedem | so there is a fun little race bug in the ceph job because of the fast snapshot stuff you guys added | 19:06 |
nic | Go on… | 19:06 |
mriedem | so snapshot taken during shelve offload is so fast, that between the time that shelve stops the instance, and we unshelve the instance, it falls within this 15 second window for https://github.com/openstack/nova/blob/14.0.0/nova/virt/libvirt/host.py#L104 | 19:06 |
mriedem | which calls back to the compute manager to stop the instance | 19:07 |
mriedem | even though it was just unshelved and is now active | 19:07 |
mriedem | and hilarity ensues | 19:07 |
nic | So we should disable shelve/unshelve on Ceph deployments. Got it. | 19:08 |
nic | ;) | 19:08 |
mriedem | wel... | 19:08 |
mriedem | well, | 19:08 |
mriedem | only if your customer is tempest | 19:08 |
mriedem | and you have fast rbd snapshots | 19:08 |
stewie925 | hello guys, after successfully doing a resize_confirm, how do we change the server state back to 'active'? | 19:10 |
stewie925 | I assumed it was revertResize, but I think that's only for unsuccessful resize | 19:11 |
mriedem | stewie925: it should go back automatically unless it fails | 19:11 |
mriedem | revert resize will also make it go back to active | 19:11 |
mriedem | if it started out as active | 19:11 |
*** Swami has quit IRC | 19:11 | |
mriedem | you can resize a stopped server too | 19:11 |
mriedem | confirm/revert are for kicking the tires while the vm is resized | 19:11 |
mriedem | if there was some issue with it after the resize, you can revert the resize to go back | 19:12 |
stewie925 | oh I see, I am getting some weird errors, let me share the link to my log.... | 19:12 |
mriedem | jbernard: you asked for it https://bugs.launchpad.net/nova/+bug/1646212 | 19:12 |
openstack | Launchpad bug 1646212 in OpenStack Compute (nova) "unshelved offloaded instance is unexpectedly stopped" [Low,Triaged] | 19:12 |
*** mnestratov has quit IRC | 19:13 | |
*** unicell has quit IRC | 19:14 | |
jbernard | mriedem: so what you're saying is that we're /too/ good | 19:14 |
mriedem | :) | 19:15 |
jbernard | im okay with that ;) | 19:15 |
mriedem | i'm not too worried about this bug unless it has a high failure rate | 19:15 |
mriedem | checking logstash now | 19:16 |
jbernard | mriedem: who normally works on nova rbd issues? | 19:16 |
jbernard | mriedem: should i put this in my queue? | 19:16 |
mriedem | it's not really an rbd issue per se, so no | 19:16 |
jbernard | true | 19:16 |
mriedem | just tickled by the ceph job | 19:16 |
*** kaisers_ has joined #openstack-nova | 19:16 | |
stewie925 | here is the result of my local testing (attempt to change server to 'active' status after successful confirmResize, but it failed): http://paste.openstack.org/show/591004/ | 19:17 |
*** unicell has joined #openstack-nova | 19:17 | |
mriedem | stewie925: does the api client in the functional tests not handle a 202? | 19:17 |
mriedem | i think yo'uve hit this type of issue before | 19:17 |
stewie925 | ohhh | 19:17 |
*** gszasz has quit IRC | 19:18 | |
stewie925 | yes I remember that one, i'll check, thanks for the guidance | 19:18 |
nic | mriedem: are you thinking this merits a giant refactor of the workflow, or would papering over the problem with an adjustable timeout suffice? | 19:18 |
mriedem | nic: no config options for sure | 19:18 |
stewie925 | but I remember the last time, my scenario showed the status code (204), this time no status code is shown? | 19:18 |
nic | (e.g., if your backend is RBD, set the lifecycle timeout to, say, 5 seonds) | 19:19 |
mriedem | nic: but then you could fail with the reboot thing | 19:19 |
mriedem | as noted in that code that sets the delay to 15 sec | 19:19 |
nic | *sigh* | 19:19 |
nic | I hate computers. | 19:20 |
mriedem | you and me both | 19:20 |
mriedem | stewie925: yeah i guess it's a 204 https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L808 | 19:20 |
mriedem | stewie925: that's not the issue though | 19:20 |
mriedem | your test is busted | 19:20 |
mriedem | stewie925: it fails here: self.api.post_server_action(server['id'], {'revertResize': None}) | 19:21 |
stewie925 | yeah - it failed at revertResize | 19:21 |
stewie925 | yes | 19:21 |
mriedem | at that point you've already confirmed the resize on L522 | 19:21 |
mriedem | you can't revert a resize of an active server | 19:21 |
mriedem | as there is no resize pending | 19:21 |
stewie925 | ohhh | 19:21 |
mriedem | so..you got a 400 | 19:21 |
*** unicell has quit IRC | 19:22 | |
stewie925 | should I do a verifyResize then? but i dont think that would be a valid request | 19:22 |
mriedem | stewie925: no, L539 and below should be deleted | 19:23 |
stewie925 | oh just leave it out | 19:23 |
mriedem | yes | 19:23 |
mriedem | the test is just, resize a server, confirm the resize, check notifications, fin. | 19:23 |
mriedem | _test_resize_revert_server would be a separate test | 19:23 |
*** unicell has joined #openstack-nova | 19:24 | |
*** Sukhdev has joined #openstack-nova | 19:24 | |
stewie925 | mriedem: thank you so much, so after confirmResize, the server status should automatically set to active | 19:24 |
*** kaisers_ has quit IRC | 19:25 | |
mriedem | yes | 19:25 |
mriedem | you have to wait for active, but yes | 19:25 |
stewie925 | thank you so much, again :) | 19:26 |
*** dharinic|lunch is now known as dharinic | 19:28 | |
jaypipes | cores looking for a bug patch to review... I've gone through this one from leehom li a few times and I think it's probably good enough at this point and fixes a relatively important (IMHO) bug: https://review.openstack.org/#/c/372243/ | 19:29 |
mriedem | wish danpb was back on that one, i see he was +2 one point | 19:31 |
mriedem | i've had it starred so i need to get back on it | 19:31 |
mriedem | i'd like sahid to look at that too | 19:32 |
openstackgerrit | STEW TY proposed openstack/nova: Transform instance.resize_confirm notification https://review.openstack.org/390654 | 19:33 |
*** mkoderer has quit IRC | 19:33 | |
*** betherly has joined #openstack-nova | 19:36 | |
*** fandi has joined #openstack-nova | 19:38 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: fix formatting in base https://review.openstack.org/404939 | 19:38 |
*** lunarlamp has joined #openstack-nova | 19:40 | |
*** claudiub has quit IRC | 19:43 | |
*** jeblair is now known as inserted_human | 19:45 | |
*** inserted_human is now known as jeblair | 19:45 | |
*** rajathagasthya has joined #openstack-nova | 19:46 | |
mriedem | jaypipes: found a problem | 19:47 |
mriedem | so -1 | 19:47 |
mriedem | the number of random unrelated cleanups makes it hard to focus on that guy | 19:48 |
*** kylek3h_ has joined #openstack-nova | 19:51 | |
jaypipes | mriedem: yes, did you see my comment about that? | 19:53 |
mriedem | yes, that wasn't my -1 | 19:53 |
*** kylek3h has quit IRC | 19:54 | |
jaypipes | mriedem: yeah, nice catch on the _LW thing. | 19:54 |
mriedem | copy/paste ftw | 19:54 |
*** catintheroof has quit IRC | 19:54 | |
mriedem | i also don't see why LibvirtConfigGuestDeviceAddressDrive needed to change | 19:55 |
jaypipes | mriedem: the format_dom() thing is being tested in the test that verifies the assertXML() crap. | 19:55 |
mriedem | i don't see that class used in here | 19:55 |
jaypipes | mriedem: I think due to adding of the format_dom() change which actually is unrelated to the patch and I had said that in a previous patch. :( | 19:55 |
jaypipes | le sigh | 19:55 |
mriedem | yeah LibvirtConfigGuestDeviceAddressDrive.format_dom() isn't covered at all in tests | 19:56 |
mriedem | just ran coverage locally | 19:56 |
mriedem | so it's not needed at all | 19:56 |
mriedem | jaypipes: but heh, you asked for reviews :) | 19:57 |
mriedem | these are pretty simple things to fix | 19:57 |
mriedem | oh i think i see what you're saying, the format_doms() aren't needed at all | 19:58 |
mriedem | for the actual bug fix | 19:58 |
mriedem | https://review.openstack.org/#/c/372243/24/nova/virt/libvirt/guest.py@246 is the actual fix | 19:58 |
*** rajathagasthya has quit IRC | 20:00 | |
jaypipes | mriedem: right, I think that format-doms() stuff was in a separate patch at one point.. :( | 20:02 |
mriedem | dansmith: https://review.openstack.org/#/c/403855/ is passing jobs again | 20:03 |
mriedem | just finishing up the placement job now | 20:03 |
jaypipes | mriedem: honestly, I've kind of gotten worn out with this but it fixes the issue and don't see any issue fixing certain things in followup patches at this point. | 20:03 |
jaypipes | mriedem: sorry | 20:03 |
mriedem | jaypipes: well, LOG.debug(_LW()) isn't cool | 20:04 |
dansmith | mriedem: kthx | 20:04 |
jaypipes | mriedem: yes, I didn't catch that. | 20:04 |
jaypipes | mriedem: I'm referring to the format_dom() and style concerns. | 20:04 |
mriedem | dansmith: don't forget https://review.openstack.org/#/c/403853/1 under it | 20:04 |
mriedem | amrith: i hope you're ready | 20:05 |
dansmith | mriedem: is that one failed for another reason? | 20:05 |
mriedem | yeah | 20:05 |
mriedem | if it weren't the top patch wouldn't pass either | 20:06 |
mriedem | tls timeout ftw http://logs.openstack.org/53/403853/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/45a4413/logs/screen-n-api.txt.gz?level=TRACE#_2016-11-28_19_36_12_750 | 20:06 |
dansmith | mriedem: um, this removes the warning, but should be putting back the exit right? | 20:06 |
mriedem | the exit is on top | 20:06 |
mriedem | i know it's a bit weird | 20:06 |
mriedem | they should have probably been done in a single change | 20:07 |
dansmith | yeah, okay | 20:07 |
mriedem | i assume amrith reverted in order to avoid conflict | 20:07 |
*** gouthamr has joined #openstack-nova | 20:09 | |
*** ijw has joined #openstack-nova | 20:12 | |
*** lpetrut has joined #openstack-nova | 20:14 | |
lbeliveau | jaypipes: the bug/inconsistency in RT I told you about this morning, does it worth it to fix in your opinion ? | 20:15 |
*** ihrachys has joined #openstack-nova | 20:15 | |
*** gjayavelu has joined #openstack-nova | 20:15 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add schedule_and_build_instances conductor method https://review.openstack.org/367557 | 20:17 |
openstackgerrit | Dan Smith proposed openstack/nova: Make RPCFixture support multiple connections https://review.openstack.org/396417 | 20:17 |
openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | 20:17 |
openstackgerrit | Dan Smith proposed openstack/nova: Add a CellDatabases test fixture https://review.openstack.org/399710 | 20:17 |
openstackgerrit | Dan Smith proposed openstack/nova: Reset indirection_api for each test https://review.openstack.org/404950 | 20:17 |
*** paw has quit IRC | 20:17 | |
*** ijw has quit IRC | 20:17 | |
*** smatzek has joined #openstack-nova | 20:17 | |
*** rfolco has quit IRC | 20:19 | |
jaypipes | lbeliveau: sorry can you repeat the point you made? | 20:19 |
*** lyarwood is now known as lyarwood_ | 20:19 | |
*** matrohon has quit IRC | 20:19 | |
*** lyarwood_ is now known as lyarwood | 20:19 | |
lbeliveau | jaypipes: I’m observing a different behavior on confirm resize, depending on if the periodic audit has executed or not | 20:20 |
lbeliveau | If the audit hasn’t been triggered and I do confirm, the resources won’t be dropped because the itype stored in the self.tracked_migrations correspond to new flavor | 20:20 |
lbeliveau | But if the audit got executed, it correspond to the old flavor, and resources gets dropped correctly | 20:20 |
*** ijw has joined #openstack-nova | 20:20 | |
*** kaisers_ has joined #openstack-nova | 20:22 | |
*** Guest62009 has quit IRC | 20:22 | |
openstackgerrit | Sean Dague proposed openstack/nova: guestfs: Don't report exception if there's read access to kernel https://review.openstack.org/401366 | 20:25 |
*** matrohon has joined #openstack-nova | 20:25 | |
sdague | mriedem / kashyap ^^^ | 20:28 |
sdague | that at least gets us to a more sane error message, then we can paper over the ubuntu issue with devstack. Though, I wonder if there is an upstream ubuntu bug that should be filed for it | 20:29 |
*** jamesdenton has joined #openstack-nova | 20:29 | |
*** kaisers_ has quit IRC | 20:29 | |
amrith | mriedem, I did it as two changes so that I could get two ATC passes :) no, I wanted to git revert and if I did it as one it seemed to generate a conflict. | 20:30 |
mriedem | sdague: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725 | 20:30 |
openstack | Launchpad bug 759725 in linux (Ubuntu) "The kernel is no longer readable by non-root users" [Medium,Won't fix] | 20:30 |
*** ijw has quit IRC | 20:30 | |
sdague | mriedem: ok, well so it is | 20:30 |
sdague | mriedem: well the new error message at least tells you what you need to do there | 20:31 |
mriedem | jaypipes: i'm going to cleanup that change | 20:31 |
*** browne has joined #openstack-nova | 20:31 | |
jaypipes | mriedem: k, ty | 20:32 |
jaypipes | lbeliveau: sec | 20:32 |
mriedem | and remove the config format_dom stuff in the process | 20:32 |
*** ijw has joined #openstack-nova | 20:32 | |
jaypipes | lbeliveau: is this something you see in mitaka or newton vs. master? in other words, is this something you have noticed recently pop up? | 20:33 |
*** Zer0Byte__ has quit IRC | 20:34 | |
lbeliveau | jaypipes: on master, I ran into it when trying to fix something else | 20:34 |
lbeliveau | when the claim is created, this is executed: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L755 | 20:35 |
lbeliveau | but on audit, the tracked migrations are cleared and re-created, and this is executed: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L764 | 20:35 |
lbeliveau | (on resize on the same host) | 20:36 |
*** rcernin has joined #openstack-nova | 20:37 | |
*** kaisers_ has joined #openstack-nova | 20:38 | |
*** Zer0Byte__ has joined #openstack-nova | 20:39 | |
openstackgerrit | Sujitha proposed openstack/nova: Allow finding instance with invalid regex name https://review.openstack.org/392305 | 20:40 |
*** jamesdenton has quit IRC | 20:40 | |
*** rodrigods is now known as rodrigods_ | 20:41 | |
*** READ10 has quit IRC | 20:41 | |
jaypipes | lbeliveau: hmm. seems indeed that is a bug. any chance you can push a test that demonstrates that issue? | 20:44 |
*** kristian__ has joined #openstack-nova | 20:44 | |
*** kristian__ has quit IRC | 20:45 | |
*** kristian__ has joined #openstack-nova | 20:45 | |
*** ljxiash has joined #openstack-nova | 20:45 | |
*** dtp has joined #openstack-nova | 20:45 | |
lbeliveau | jaypipes: I'll work on it, hopefully I'll get something tomorrow, bug is not trivial to unit test, took me a while to understand what was really happening | 20:45 |
lbeliveau | I'll ping you when I have something | 20:46 |
lbeliveau | (will need your help on how to fix it, not sure on some of the RT details) | 20:46 |
openstackgerrit | Diana Clarke proposed openstack/python-novaclient: Microversion 2.39 - Simple tenant usage pagination https://review.openstack.org/394653 | 20:47 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Support detach interface with same MAC from instance https://review.openstack.org/372243 | 20:48 |
*** Swami has joined #openstack-nova | 20:48 | |
mriedem | jaypipes: ^ dropped all of the unrelated style stuff and config changes | 20:48 |
jaypipes | lbeliveau: ty sir. looking forward to helping on your patch. | 20:49 |
dansmith | PSA: cellsv2 meeting in ten minutes | 20:50 |
kristian__ | Hi, does someone have some experience with gaming on nvidia gpus on openstack? | 20:50 |
jaypipes | mriedem: reviewed and approved. thanks again. | 20:50 |
*** ljxiash has quit IRC | 20:51 | |
*** mnestratov has joined #openstack-nova | 20:51 | |
openstackgerrit | Sean Dague proposed openstack/nova: guestfs: Don't report exception if there's read access to kernel https://review.openstack.org/401366 | 20:53 |
sdague | mriedem: fixed the nit | 20:53 |
mriedem | thanks | 20:54 |
*** catintheroof has joined #openstack-nova | 20:54 | |
mriedem | sdague: also https://review.openstack.org/#/c/336927/3 | 20:54 |
*** liverpooler has quit IRC | 20:54 | |
mriedem | that was previously approved but was stuck on the depends-on | 20:54 |
mriedem | which i've since dropped | 20:54 |
*** WillUK2010 has joined #openstack-nova | 20:58 | |
*** annegentle has quit IRC | 21:00 | |
*** annegentle has joined #openstack-nova | 21:01 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Release PCI devices on drop_move_claim() https://review.openstack.org/370374 | 21:02 |
*** bvanhav has quit IRC | 21:02 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Release PCI devices on drop_move_claim() https://review.openstack.org/370374 | 21:03 |
sdague | mriedem: +A | 21:04 |
*** larainema has quit IRC | 21:05 | |
*** Apoorva has quit IRC | 21:05 | |
mriedem | thanks | 21:05 |
*** Zer0Byte__ has quit IRC | 21:05 | |
*** Apoorva has joined #openstack-nova | 21:05 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: [WIP] Add service_token for nova-cinder interaction https://review.openstack.org/397399 | 21:06 |
openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | 21:06 |
*** anush has quit IRC | 21:06 | |
*** Zer0Byte__ has joined #openstack-nova | 21:07 | |
openstackgerrit | Diana Clarke proposed openstack/python-novaclient: Microversion 2.39 - Simple tenant usage pagination https://review.openstack.org/394653 | 21:07 |
*** dimtruck is now known as zz_dimtruck | 21:09 | |
*** rtheis has quit IRC | 21:10 | |
*** ijw has quit IRC | 21:14 | |
*** zz_dimtruck is now known as dimtruck | 21:14 | |
*** ihrachys has quit IRC | 21:16 | |
*** amoralej|off is now known as amoralej | 21:21 | |
*** claudiub has joined #openstack-nova | 21:22 | |
openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | 21:24 |
*** Zer0Byte__ has quit IRC | 21:24 | |
*** mvk has joined #openstack-nova | 21:25 | |
*** Zer0Byte__ has joined #openstack-nova | 21:25 | |
*** whenry has quit IRC | 21:27 | |
*** owalsh has quit IRC | 21:32 | |
*** owalsh_ has joined #openstack-nova | 21:33 | |
*** smatzek has quit IRC | 21:34 | |
*** Jeffrey4l_ has joined #openstack-nova | 21:34 | |
*** Jeffrey4l has quit IRC | 21:35 | |
*** owalsh__ has joined #openstack-nova | 21:37 | |
*** ijw has joined #openstack-nova | 21:39 | |
kashyap | sdague: Thanks. Obviously, please add yourself as the Co-Author to that | 21:39 |
*** owalsh__ is now known as owalsh | 21:39 | |
* kashyap hits the hay | 21:39 | |
*** owalsh_ has quit IRC | 21:39 | |
openstackgerrit | Sujitha proposed openstack/nova: Change os-server-tags default policy https://review.openstack.org/396420 | 21:40 |
*** Zer0Byte__ has quit IRC | 21:43 | |
*** Zer0Byte__ has joined #openstack-nova | 21:48 | |
*** gouthamr has quit IRC | 21:49 | |
*** edmondsw has quit IRC | 21:50 | |
*** annegentle has quit IRC | 21:51 | |
*** matrohon has quit IRC | 21:51 | |
*** annegentle has joined #openstack-nova | 21:52 | |
*** kaisers_ has quit IRC | 21:52 | |
*** kaisers_ has joined #openstack-nova | 21:54 | |
*** hongbin has quit IRC | 22:01 | |
*** Zer0Byte__ has quit IRC | 22:01 | |
*** lpetrut has quit IRC | 22:01 | |
*** ijw has quit IRC | 22:03 | |
*** tbachman has quit IRC | 22:04 | |
*** ijw has joined #openstack-nova | 22:08 | |
*** ijw has quit IRC | 22:08 | |
*** ijw has joined #openstack-nova | 22:08 | |
*** WillUK2010 has quit IRC | 22:09 | |
*** claudiub|2 has joined #openstack-nova | 22:09 | |
*** dimtruck is now known as zz_dimtruck | 22:11 | |
*** slaweq_ has joined #openstack-nova | 22:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs: Amend proposal to count resources to check quota in API for cells https://review.openstack.org/399750 | 22:11 |
*** ijw has quit IRC | 22:12 | |
*** ijw has joined #openstack-nova | 22:12 | |
*** penick has quit IRC | 22:12 | |
*** claudiub has quit IRC | 22:13 | |
*** ijw has quit IRC | 22:15 | |
*** ijw has joined #openstack-nova | 22:16 | |
*** ijw has quit IRC | 22:16 | |
*** ijw has joined #openstack-nova | 22:16 | |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 22:17 |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: report client handle InventoryInUse https://review.openstack.org/404990 | 22:17 |
*** kylek3h_ has quit IRC | 22:17 | |
openstackgerrit | Chris Dent proposed openstack/nova: Some improvement to the process doc https://review.openstack.org/404991 | 22:19 |
cdent | mriedem: ^ that's sort of a followup to the "when is a blueprint needed" stuff done a while ago | 22:19 |
*** tbachman has joined #openstack-nova | 22:20 | |
mriedem | cdent: cool, i know that most of that was all old and like kilo or liberty specific, | 22:20 |
mriedem | it was literally a brain dump from a wiki put into docs | 22:20 |
cdent | yeah, I addressed some but not all of that | 22:20 |
cdent | there's _loads_ more that could be done, but it'll take a few goes | 22:21 |
*** amoralej is now known as amoralej|off | 22:22 | |
mriedem | i thought about updating it once but it's exhausting | 22:23 |
cdent | yeah, I think I need to go to bed | 22:24 |
melwitt | mriedem: should I mark this as superseded? https://blueprints.launchpad.net/nova/+spec/cells-quota-api-db I can't remember if the partial data move to API DB is okay to go under the counting resources bp | 22:25 |
openstackgerrit | Andrew Bogott proposed openstack/nova: Add disk_minimum_physical_free_space_ratio option to disk filter. https://review.openstack.org/341198 | 22:25 |
*** larainema has joined #openstack-nova | 22:25 | |
*** ijw has quit IRC | 22:30 | |
*** tbachman has quit IRC | 22:31 | |
mriedem | melwitt: let me re-read the spec for that quick to see if i'm missing anything | 22:32 |
*** code-R_ has joined #openstack-nova | 22:33 | |
*** code-R has quit IRC | 22:33 | |
*** ijw has joined #openstack-nova | 22:33 | |
melwitt | mriedem: okay. it's not urgent. I had been thinking the "move tables" has historically included object code that does the data migration | 22:34 |
melwitt | but because of the second spec, we're not going to migrate everything, just part of it | 22:35 |
mriedem | melwitt: i didn't think we were doing migrations for quotas | 22:35 |
mriedem | because you can just refresh them | 22:35 |
melwitt | mriedem: I thought we would have to migrate any quota limits that are there | 22:35 |
*** ijw has quit IRC | 22:35 | |
mriedem | yeah probably | 22:35 |
mriedem | just not usages | 22:36 |
melwitt | if you use the API to update quota, it makes a limit entry in the DB that it uses from then on | 22:36 |
melwitt | right | 22:36 |
melwitt | there won't be any more usages table | 22:36 |
melwitt | i.e. we won't put any data in there | 22:36 |
mriedem | melwitt: ok i think it makes sense to do the object code and limits migrations in that bp then | 22:38 |
mriedem | and do the counting stuff in the counting spec | 22:38 |
melwitt | mriedem: k, thanks | 22:38 |
mriedem | and now i'm off to make a turkey pot pie from all of the leftovers | 22:38 |
*** ijw has joined #openstack-nova | 22:38 | |
melwitt | sounds good | 22:39 |
dansmith | <-- jealous | 22:39 |
mriedem | don't be, first time, i'll likely ruin it | 22:39 |
* mriedem leaves | 22:39 | |
*** mriedem has quit IRC | 22:39 | |
dansmith | I'm jealous you have leftovers | 22:39 |
*** ijw has quit IRC | 22:40 | |
*** jheroux has quit IRC | 22:40 | |
*** mnaser has quit IRC | 22:41 | |
*** tblakes has quit IRC | 22:41 | |
*** paw has joined #openstack-nova | 22:43 | |
*** annegentle has quit IRC | 22:44 | |
openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | 22:44 |
*** slaweq_ has quit IRC | 22:44 | |
*** ijw has joined #openstack-nova | 22:45 | |
*** esberglu has quit IRC | 22:46 | |
*** esberglu has joined #openstack-nova | 22:46 | |
*** slaweq_ has joined #openstack-nova | 22:46 | |
*** kylek3h has joined #openstack-nova | 22:47 | |
*** ijw has quit IRC | 22:48 | |
*** mnaser has joined #openstack-nova | 22:50 | |
*** kristian__ has quit IRC | 22:51 | |
*** ijw has joined #openstack-nova | 22:51 | |
*** kristian__ has joined #openstack-nova | 22:51 | |
*** esberglu has quit IRC | 22:51 | |
*** dave-mcc_ has quit IRC | 22:53 | |
*** masuberu has quit IRC | 22:54 | |
*** masber has joined #openstack-nova | 22:54 | |
*** ijw has quit IRC | 22:54 | |
*** tbachman has joined #openstack-nova | 22:56 | |
*** esberglu has joined #openstack-nova | 23:00 | |
*** esberglu has quit IRC | 23:01 | |
*** esberglu_ has joined #openstack-nova | 23:01 | |
*** browne has quit IRC | 23:04 | |
*** ljxiash has joined #openstack-nova | 23:05 | |
*** _ducttape_ has joined #openstack-nova | 23:06 | |
*** mdrabe has quit IRC | 23:07 | |
*** thorst_ is now known as thorst_afk | 23:08 | |
*** ljxiash has quit IRC | 23:09 | |
*** ducttape_ has quit IRC | 23:10 | |
*** ljxiash has joined #openstack-nova | 23:10 | |
*** _ducttape_ has quit IRC | 23:11 | |
*** Sukhdev has quit IRC | 23:12 | |
*** catintheroof has quit IRC | 23:12 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif: Updated from global requirements https://review.openstack.org/395347 | 23:13 |
*** ljxiash has quit IRC | 23:14 | |
*** unicell has quit IRC | 23:15 | |
*** burt has quit IRC | 23:15 | |
*** unicell has joined #openstack-nova | 23:20 | |
*** TravT has joined #openstack-nova | 23:22 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Race condition between audit and migrate/resize revert https://review.openstack.org/400995 | 23:24 |
dansmith | melwitt: so I hadn't looked that closely at your cell db fixture, | 23:24 |
*** jamesdenton has joined #openstack-nova | 23:24 | |
dansmith | but it looks like you end up mocking the same thing a bunch of times | 23:24 |
dansmith | get_context_manager for example | 23:24 |
dansmith | maybe just that one | 23:24 |
dansmith | is that intentional? | 23:24 |
melwitt | dansmith: what do you mean by a bunch of times? | 23:24 |
dansmith | melwitt: you mock it in setup, and then again on each call to add_cell_db | 23:25 |
dansmith | oh | 23:25 |
dansmith | I see, maybe nevermind | 23:25 |
*** eharney has quit IRC | 23:25 | |
dansmith | add_cell_db mocks temporarily, | 23:25 |
dansmith | then setup mocks for the test run | 23:25 |
melwitt | oh, that. yeah | 23:25 |
dansmith | yeah I see now | 23:26 |
melwitt | I hope I put a note there. looking ... | 23:26 |
*** rcernin has quit IRC | 23:26 | |
melwitt | trying to get that thing to work was just weird, so there are likely better ways to do it too | 23:26 |
*** ducnc has quit IRC | 23:27 | |
dansmith | I'm trying to get it to work with functional now, | 23:27 |
*** ducnc has joined #openstack-nova | 23:27 | |
dansmith | and the services we start up are failing to do service record things | 23:27 |
dansmith | I've been putting the "main cell" as the first add_cell_database() call, | 23:28 |
dansmith | but I'm wondering if that should be the last one, so that _last_ctxt_mgr will be "cell1" right off the bat.. | 23:28 |
melwitt | yeah I think it should be last because of that hackiness | 23:28 |
dansmith | hey, that makes it fail better | 23:29 |
dansmith | a better wrong | 23:30 |
melwitt | dansmith: this is how I did it last time https://review.openstack.org/#/c/398645/2/nova/tests/functional/integrated_helpers.py | 23:30 |
melwitt | when I had tested it on top of your patch | 23:30 |
dansmith | melwitt: ah yeah, I read the comments and thought cell1 should be first | 23:30 |
dansmith | # NOTE(melwitt): The first DB access through service start is | 23:31 |
dansmith | # local so this initializes _last_ctxt_mgr for that and needs | 23:31 |
dansmith | # to be a compute cell. | 23:31 |
dansmith | that | 23:31 |
dansmith | but my interpretation of that doesn't make sense for the code of course | 23:31 |
melwitt | oh, yeah. I guess my comment wasn't too good there | 23:32 |
melwitt | I'll improve it and also need to add a note about the temporary monkey patch thing too, assuming this ends up working | 23:32 |
*** jwcroppe has quit IRC | 23:34 | |
dansmith | well, don't do it now or it'll mess up my linkage | 23:34 |
dansmith | I'll try to remember to do that | 23:34 |
*** jwcroppe has joined #openstack-nova | 23:35 | |
melwitt | no, I mean, later I'll make that stuff better if we can get all the tests working with it | 23:35 |
*** ijw has joined #openstack-nova | 23:36 | |
melwitt | unless I missed something, the tests that derived from integrated_helpers were all passing in parallel and the remaining failures were tests that didn't, and needed CellDatabasesFixture set up for them | 23:36 |
*** claudiub|2 has quit IRC | 23:37 | |
*** sdague has quit IRC | 23:38 | |
*** penick has joined #openstack-nova | 23:38 | |
dansmith | melwitt: my patch was never updated for the new fixture | 23:39 |
dansmith | and just making the change in your patch above doesn't make them work | 23:39 |
*** ljxiash has joined #openstack-nova | 23:39 | |
melwitt | dansmith: I know, in my experiment patch I modified what you did to use the new fixture and tried to run the tests in parallel | 23:39 |
*** jwcroppe has quit IRC | 23:39 | |
melwitt | okay, I'll pull it down and see what it's doing | 23:40 |
dansmith | well | 23:40 |
dansmith | lemme push up what I just did, which should be equivalent to what you had | 23:40 |
*** ijw has quit IRC | 23:41 | |
melwitt | sure, that would be better | 23:41 |
dansmith | because I took out the multicell listing patch | 23:41 |
openstackgerrit | Dan Smith proposed openstack/nova: WIP Multicell support for instance listing https://review.openstack.org/396775 | 23:41 |
openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | 23:41 |
dansmith | with that, I'm getting no talky to conductor | 23:41 |
dansmith | reversing the ordering of the add_db got me past the service create thing | 23:42 |
melwitt | k | 23:42 |
*** penick_ has joined #openstack-nova | 23:42 | |
dansmith | oh nm | 23:43 |
dansmith | that's compute | 23:43 |
*** pradk has quit IRC | 23:43 | |
dansmith | that's the cascaded fail I hit last time | 23:43 |
*** penick has quit IRC | 23:43 | |
*** penick_ is now known as penick | 23:43 | |
*** lamt has quit IRC | 23:44 | |
dansmith | hmm | 23:45 |
*** ijw has joined #openstack-nova | 23:46 | |
*** dtp has quit IRC | 23:46 | |
dansmith | yeaah | 23:47 |
dansmith | I forgot | 23:47 |
dansmith | I had a hack in there that I removed when I moved the rpc fixture out to another patch | 23:47 |
dansmith | which is to default everything to a single bus | 23:47 |
melwitt | I hope you're about to tell me you already figured it out so I don't have to | 23:47 |
melwitt | oh, yeah | 23:47 |
dansmith | because the things we start end up with the original config | 23:47 |
dansmith | so yeah, I'm good | 23:47 |
melwitt | yeah you are | 23:47 |
dansmith | not sure what to do about that, but at least I have a thing | 23:47 |
dansmith | I mean "good" as in "sorted" | 23:48 |
melwitt | oh. heh. well, I'm happy I didn't have to figure out how it wasn't talking to compute | 23:49 |
*** xyang1 has quit IRC | 23:50 | |
melwitt | I've been confused about the same bus thing and how we could even do anything else since we can't give each service separate configs really | 23:50 |
dansmith | holy frijoles, .*test_servers.* is working in parallel | 23:51 |
dansmith | melwitt: yeah I know, but I want to figure out a way | 23:51 |
*** ijw has quit IRC | 23:51 | |
melwitt | dansmith: best I could think right now is something similar to the CellDatabasesFixture that intercepts and routes the calls somehow | 23:52 |
dansmith | melwitt: ah, and I got the connect string failure again | 23:52 |
dansmith | maybve | 23:52 |
dansmith | damn, such progress. I should take a week off to celebrate | 23:52 |
melwitt | heh. me too, that fixture was ... challenging to make work. I really hope it can handle all the functional tests | 23:53 |
*** Zer0Byte__ has joined #openstack-nova | 23:53 | |
*** mriedem has joined #openstack-nova | 23:54 | |
melwitt | dansmith: what's the connect string failure? | 23:54 |
dansmith | melwitt: remember the thing I commented on about having seen? | 23:54 |
dansmith | because you weren't using url-ish urls for the connection string | 23:54 |
dansmith | but I dun' fixed that now | 23:54 |
dansmith | fake://%(uuid)s | 23:55 |
melwitt | for the database connection string? I didn't think that had to be formatted any way | 23:57 |
dansmith | yeah something cares | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!