melwitt | that's different | 00:00 |
---|---|---|
melwitt | must be something else that changed in between I guess | 00:00 |
mriedem | might have changed from stropt to uriopt | 00:01 |
mriedem | which is pickier | 00:01 |
mriedem | btw, the pie is in the oven, i repeat, the pie is in the oven | 00:01 |
dansmith | no, it's some place we hit sqlalchemy I think | 00:01 |
dansmith | heh | 00:01 |
* melwitt hovers around oven | 00:01 | |
dansmith | melwitt: see my comment on here https://review.openstack.org/#/c/399710/2 | 00:02 |
melwitt | dansmith: oh, that one! and just changing the format fixed it? | 00:03 |
dansmith | yeah | 00:03 |
melwitt | I was way off on thinking that was about something else | 00:03 |
melwitt | this is much better | 00:04 |
dansmith | that fixes it for several tests, but some end up here: | 00:08 |
dansmith | NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:fake | 00:08 |
dansmith | so there must be somewhere that we're leaking the connection url to something | 00:08 |
dansmith | but, progress | 00:08 |
melwitt | first I'd check if those are derived from integrated_helpers or if they don't have the fixture yet | 00:09 |
melwitt | not all the func tests derive from it | 00:09 |
*** jwcroppe has joined #openstack-nova | 00:09 | |
*** jwcroppe has quit IRC | 00:09 | |
dansmith | orly | 00:10 |
*** jwcroppe has joined #openstack-nova | 00:10 | |
dansmith | that kinda sounds like a tomorrow thing | 00:10 |
*** Zer0Byte__ has quit IRC | 00:10 | |
* dansmith listens closer | 00:10 | |
dansmith | yep, yep, definitely sounds like tomorrow | 00:10 |
melwitt | hah | 00:10 |
*** cdent has quit IRC | 00:10 | |
*** Swami has quit IRC | 00:12 | |
*** hieulq_ has joined #openstack-nova | 00:12 | |
*** mnestratov has quit IRC | 00:13 | |
*** Zer0Byte__ has joined #openstack-nova | 00:14 | |
*** browne has joined #openstack-nova | 00:14 | |
*** nic has quit IRC | 00:15 | |
*** rdo has quit IRC | 00:16 | |
*** Zer0Byte__ has quit IRC | 00:17 | |
*** rwmjones has quit IRC | 00:17 | |
mriedem | jaypipes: a few nits in https://review.openstack.org/#/c/391918/ but i think i'm fine with just going forward, but will let you reply | 00:21 |
mriedem | actually i'll just +2 and we can follow up in another patch, or you can touch up some of the easy ones, like using ResourceClassNotFound instead of NotFound, and then i'll +2 again quick | 00:23 |
*** rdo has joined #openstack-nova | 00:24 | |
mriedem | wznoinsk: fyi, if a change only contains changes to docs or things under nova/tests, you don't need to run the intel nfv ci on it, like this https://review.openstack.org/#/c/394585/ | 00:26 |
*** rwmjones has joined #openstack-nova | 00:27 | |
mriedem | browne: i'm seeing a bunch of vmware n-net ci failures | 00:28 |
mriedem | voting errors | 00:28 |
mriedem | we basically killed n-net on master in non-cellsv1 jobs today | 00:28 |
browne | mriedem: ok, i'll inform our CI guy | 00:28 |
*** hoangcx has joined #openstack-nova | 00:28 | |
mriedem | browne: thanks. in this case it actually looks like cinder blew up | 00:29 |
mriedem | http://207.189.188.190/logs/ext-nova-dsvm/396359/4/2723/c-sch.log.gz | 00:29 |
mriedem | novalidhost | 00:29 |
mriedem | u'free_capacity_gb': u'unknown' | 00:29 |
mriedem | that's odd, but i guess is a vcenter-ism | 00:29 |
browne | hmm ok | 00:29 |
*** yingjun has joined #openstack-nova | 00:30 | |
*** yingjun has quit IRC | 00:30 | |
*** yingjun has joined #openstack-nova | 00:30 | |
mriedem | caps filter failed http://207.189.188.190/logs/ext-nova-dsvm/396359/4/2723/c-sch.log.gz#_2016-11-30_15_10_20_999 | 00:30 |
*** gjayavelu has quit IRC | 00:31 | |
*** gjayavelu has joined #openstack-nova | 00:32 | |
*** jamesdenton has quit IRC | 00:34 | |
*** tbachman has quit IRC | 00:34 | |
*** gjayavelu has quit IRC | 00:36 | |
*** hieulq_ has quit IRC | 00:43 | |
*** tbachman has joined #openstack-nova | 00:43 | |
*** ducttape_ has joined #openstack-nova | 00:47 | |
jaypipes | mriedem: responded. can address those in a followup for sure. | 00:48 |
*** rama_y has quit IRC | 00:49 | |
*** hfu has joined #openstack-nova | 00:50 | |
alex_xu | pkholkin: mriedem: yea, I didn't start it. welcome to help on it. let me know if you are interesting and need any help. | 00:52 |
*** tjones has joined #openstack-nova | 00:53 | |
*** jamesdenton has joined #openstack-nova | 00:54 | |
*** jaypipes has quit IRC | 00:55 | |
*** hieulq_ has joined #openstack-nova | 00:55 | |
openstackgerrit | Huan Xie proposed openstack/nova: xenapi: support the hotplug of a neutron port https://review.openstack.org/365505 | 00:57 |
*** stewie925 has quit IRC | 00:58 | |
*** baoli_ has quit IRC | 01:01 | |
*** jamesdenton has quit IRC | 01:03 | |
*** ducttape_ has quit IRC | 01:03 | |
*** ducttape_ has joined #openstack-nova | 01:04 | |
*** catintheroof has joined #openstack-nova | 01:05 | |
*** hieulq_ has quit IRC | 01:05 | |
*** baoli has joined #openstack-nova | 01:05 | |
*** gjayavelu has joined #openstack-nova | 01:06 | |
*** gjayavelu has quit IRC | 01:06 | |
*** gjayavelu has joined #openstack-nova | 01:06 | |
*** catintheroof has quit IRC | 01:08 | |
*** ducttape_ has quit IRC | 01:08 | |
*** hieulq_ has joined #openstack-nova | 01:09 | |
*** mtanino has quit IRC | 01:10 | |
openstackgerrit | int32bit proposed openstack/python-novaclient: Fix can't process the resource with name 'help' https://review.openstack.org/403382 | 01:11 |
*** gjayavelu has quit IRC | 01:11 | |
*** gjayavelu has joined #openstack-nova | 01:11 | |
*** hieulq_ has quit IRC | 01:11 | |
*** tjones has quit IRC | 01:11 | |
*** hieulq_ has joined #openstack-nova | 01:16 | |
*** donnalezyty_ has quit IRC | 01:21 | |
*** thorst_afk has quit IRC | 01:21 | |
*** thorst_afk has joined #openstack-nova | 01:22 | |
*** mlavalle has quit IRC | 01:27 | |
*** penick has quit IRC | 01:29 | |
*** thorst_afk has quit IRC | 01:30 | |
*** kaisers1 has joined #openstack-nova | 01:34 | |
*** hieulq_ has quit IRC | 01:34 | |
*** kristian__ has quit IRC | 01:34 | |
*** jamielennox is now known as jamielennox|away | 01:34 | |
*** kristian__ has joined #openstack-nova | 01:35 | |
*** kaisers has quit IRC | 01:35 | |
*** browne has quit IRC | 01:35 | |
*** thorst_afk has joined #openstack-nova | 01:38 | |
*** ducttape_ has joined #openstack-nova | 01:38 | |
*** kristian__ has quit IRC | 01:39 | |
*** hongbin has joined #openstack-nova | 01:42 | |
*** thorst_afk has quit IRC | 01:43 | |
*** yuntongjin has joined #openstack-nova | 01:50 | |
*** zhangjl has joined #openstack-nova | 01:51 | |
*** liangy has quit IRC | 01:54 | |
*** Apoorva has quit IRC | 02:00 | |
openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Check source_type and destination_type when booting with bdm provided https://review.openstack.org/402364 | 02:01 |
mriedem | tdurakov: something seems messed up with the live migration job | 02:05 |
mriedem | when setting up for ceph | 02:05 |
*** kaisers has joined #openstack-nova | 02:06 | |
mriedem | http://logs.openstack.org/55/403855/1/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/18126e0/console.html#_2016-12-01_02_01_22_338501 | 02:06 |
mriedem | 2016-12-01 02:01:22.338501 | 2016-12-01 02:01:22.338 | truncate: Invalid number: ‘var/lib/ceph/drives/images/ceph.img’ | 02:06 |
*** mlakat has quit IRC | 02:06 | |
*** kaisers_ has quit IRC | 02:09 | |
mriedem | i assume it's failing here: http://git.openstack.org/cgit/openstack/devstack-plugin-ceph/tree/devstack/lib/ceph#n349 | 02:09 |
mriedem | so far it's only hit 2 changes in the check queue i guess so maybe not something i need to worry too much about right now...but they are unrelated changes | 02:10 |
openstackgerrit | int32bit proposed openstack/nova: Choose VMware datastore by the least provisioned space https://review.openstack.org/402632 | 02:11 |
cburgess | mriedem Just saw that bug.. love it. We are soo fast and soo good.. its a bug. | 02:12 |
mriedem | cburgess: yeah solutions to that aren't great | 02:12 |
mriedem | could disable the fast snapshot stuff in the gate job....but that sucks | 02:12 |
cburgess | mriedem Yeah I mean in general clients *love* the fast snapshot stuff. | 02:13 |
cburgess | Thats why we wrote it. | 02:13 |
*** stevemar__ has quit IRC | 02:13 | |
mriedem | it's just clients don't shelve offload and then unshelve the same instance within a 15 second window | 02:13 |
cburgess | mriedem Right | 02:13 |
cburgess | mriedem Because.. um.. what? | 02:13 |
*** stevemar__ has joined #openstack-nova | 02:13 | |
mriedem | that's the trigger of the bug in the gate | 02:13 |
cburgess | mriedem Yeah I know it was more a what why would do that. | 02:14 |
cburgess | But I get the gate causes it. | 02:14 |
mriedem | oh | 02:14 |
mriedem | yeah | 02:14 |
cburgess | We need a sarcasm font.. | 02:14 |
cburgess | OK so... | 02:14 |
cburgess | Here is the question.. | 02:14 |
cburgess | The issue is that when do we the shelve we take the snapshot. That happens so fast tempest sees its shelved and issues the unselve which also happen so fast that all that happens in the intiail 15 second window? | 02:15 |
openstackgerrit | Li Yingjun proposed openstack/nova: Notifications on flavor operations https://review.openstack.org/398171 | 02:15 |
mriedem | yes | 02:15 |
cburgess | So the compute manager sees the even at the end of the 15 seconds and goes "oh I should do this thing now" when in reality the compute manager is behind the times so to speak? | 02:15 |
mriedem | normal jobs don't hit this because the snapshot takes longer | 02:15 |
mriedem | well, it's the libvirt driver getting a stopped event from libvirt | 02:15 |
mriedem | as part of the original shelve | 02:15 |
cburgess | Which was the original stop from the shelve. | 02:16 |
cburgess | Right ok. | 02:16 |
cburgess | So.. | 02:16 |
mriedem | yes | 02:16 |
cburgess | At the time we do the shelve, can we detect if you are fast clone some how and just auto-adjust our delay to like 1 second in that condition? | 02:16 |
mriedem | the delay in the libvirt driver is created on init, it has no concept of what tasks you're performing on the instance in the compute manager, | 02:16 |
cburgess | And I wonder if this is causing other issues around snapshot. | 02:16 |
mriedem | or the backing store | 02:16 |
cburgess | mriedem Oh its for the whole driver... | 02:17 |
mriedem | yes | 02:17 |
cburgess | mriedem Thats... bummer | 02:17 |
mriedem | the 15 seconds is to handle a race with reboot, | 02:17 |
cburgess | and this isn't configurable because....? | 02:17 |
mriedem | where we get the stopped event, then the start event, and then we'd process those and stop the instance right after rebooting it | 02:17 |
*** stevemar__ has quit IRC | 02:17 | |
mriedem | well, you could configure it but then you risk stopping active instances right after they were rebooted | 02:18 |
cburgess | I hate to say it but... this fix is a hack. We need to go fix the actual reboot issue. | 02:18 |
mriedem | you can disable the lifecycle handler stuff altogether | 02:18 |
cburgess | What I mean is.. we know that a VM is rebooting. So why can't we compare the state of the VM when we get the livecycle events? | 02:18 |
mriedem | handle_virt_lifecycle_events = true | 02:18 |
cburgess | Yeah I don't want to do that either. | 02:19 |
cburgess | Seems like we need to fix the handler to understand VM state as well so when it sees the stop during a reboot it knows to ignore it. | 02:19 |
mriedem | it's been a long time since i dug into the bowels of that code, | 02:19 |
cburgess | mriedem same | 02:20 |
mriedem | i think you have a race either way, because the event could come in after we're done rebooting the instance so it's no longer got a task_state set | 02:20 |
cburgess | Well I would think we shouldn't change the state until after we get the start event. | 02:20 |
cburgess | Or at least it should. | 02:20 |
mriedem | the libvirt driver could wait on it's own events in that case | 02:21 |
cburgess | Because its not done rebooting until libvirt says its started. | 02:21 |
mriedem | and block the reboot until the start event comes back in.. | 02:21 |
mriedem | i think today it just polls the guest power state until it's running | 02:21 |
*** tbachman has quit IRC | 02:21 | |
cburgess | Oh this runs in a native thread... | 02:21 |
mriedem | yeah | 02:21 |
mriedem | more fun | 02:21 |
cburgess | Oh yeah... | 02:22 |
mriedem | we could do other things, like when rebooting a guest, queue it's id up somewhere and when we get the stop event for that guest, we ignore it | 02:22 |
mriedem | in the actual libvirt event handling code that calls back to the compute manager | 02:22 |
cburgess | Well.. | 02:22 |
cburgess | All the handler does is enqueue an event for the manager. | 02:22 |
cburgess | So we need to make the manager smarter. | 02:22 |
mriedem | well.... | 02:22 |
cburgess | The handler is just saying "This thing happened". | 02:23 |
mriedem | the manager checks if the task_state is not None and if so, it ignores the callback | 02:23 |
mriedem | that's about as smart as it gets | 02:23 |
mriedem | plus, | 02:24 |
cburgess | Hmm I'm not understanding why we have this delay then. | 02:24 |
mriedem | not all virt drivers have this callback code, | 02:24 |
mriedem | i think it's just libvirt and xen | 02:24 |
*** catintheroof has joined #openstack-nova | 02:24 | |
mriedem | s/xen/hyperv/ | 02:24 |
*** gjayavelu has quit IRC | 02:24 | |
mriedem | so, you can't bake logic into the compute manager based on the impl in the virt driver | 02:24 |
cburgess | Sure but this is only an issue with the delayed call back code and probably only on libvirt anyways because of how it uses ceph. | 02:24 |
mriedem | you could maybe do something generic around reboot | 02:24 |
mriedem | if we didn't have the delay, the shelve/unshelve thing wouldn't be a problem | 02:25 |
mriedem | b/c when we'd get the event, we're still doing a task operation and we'd ignore the event | 02:25 |
cburgess | Right | 02:25 |
mriedem | or the guest would already be gone (shelved offloaded) | 02:25 |
cburgess | So it feels to me like we "fixed" reboot wrong. | 02:25 |
mriedem | yeah maybe | 02:25 |
cburgess | As in why aren't we still "rebooting" when we get the stop? | 02:25 |
cburgess | Feel like some how we moved onto a task state of NONE before we actually finished. | 02:26 |
cburgess | I need to go look at manager code for that. | 02:26 |
mriedem | again, would have to dig into the weirdo edge cases around this when those fixes were made | 02:26 |
cburgess | Also... isn't it late for you? | 02:26 |
mriedem | alternatively, we just delete shelve/unshelve | 02:26 |
mriedem | yes it is | 02:26 |
mriedem | well, sort of | 02:26 |
cburgess | mriedem +1? | 02:26 |
mriedem | ? | 02:27 |
mriedem | CST | 02:27 |
mriedem | 8:39 | 02:27 |
mriedem | oops | 02:27 |
mriedem | 8:27 | 02:27 |
cburgess | I never quite understood the purpose of it so thats why its a +1? not a firm +1 | 02:27 |
mriedem | i don't know what you're +1ing? | 02:27 |
mriedem | hours from PST? | 02:27 |
mriedem | oh, | 02:28 |
cburgess | Oh no sorry.. removing shelve/unshelve | 02:28 |
cburgess | My bad | 02:28 |
mriedem | +1 to delete shelve? | 02:28 |
mriedem | ha | 02:28 |
mriedem | i would, but jaypipes loves shelve/unshelve | 02:28 |
mriedem | so, elasticsearch was backed up when i hit that ceph failure today, so don't have good numbers on how often we hit it | 02:29 |
mriedem | if it's not often, i'll probably just ignore for awhile | 02:29 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Remove more tests from tests-py3.txt https://review.openstack.org/404543 | 02:30 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port compute.test_extended_ip* to Python 3 https://review.openstack.org/403548 | 02:30 |
cburgess | Oh this is cute.. | 02:30 |
cburgess | As far as I can tell we just call driver.reboot and then once it returns we are "done". | 02:30 |
cburgess | mriedem This feels wrong to me https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3032 | 02:32 |
mriedem | well, does reboot block in the driver? | 02:33 |
*** yuntongjin has quit IRC | 02:33 | |
mriedem | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2363 | 02:33 |
cburgess | mriedem Yeah thats where the race is. | 02:34 |
cburgess | mriedem What I don't understand is how delaying the event fixes this. | 02:34 |
*** gcb has joined #openstack-nova | 02:34 | |
cburgess | If we delay the stop event I would think we would *always* trigger this. | 02:35 |
cburgess | mriedem oh you wrote this fix... | 02:35 |
mriedem | nope | 02:35 |
mriedem | i've touched the code | 02:35 |
mriedem | but you have to dig deeper chet | 02:35 |
mriedem | deeper | 02:35 |
cburgess | https://github.com/openstack/nova/commit/1d4d00ec1c6d59fd6df5be776c781c38a4de8e28 | 02:35 |
cburgess | Pretty sure that has your name all over it. | 02:36 |
mriedem | did you read the commit message? | 02:36 |
cburgess | Oh you are right.. | 02:36 |
cburgess | That was just a fix to a fix.. | 02:36 |
cburgess | sigh | 02:36 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Don't delete neutron port when attach failed https://review.openstack.org/403568 | 02:36 |
mriedem | ha | 02:36 |
mriedem | i think https://github.com/openstack/nova/commit/bd8329b34098436d18441a8129f3f20af53c2b91 was actually trying to handle an issue where the guest is rebooted outside of nova | 02:37 |
mriedem | but then nova would stop it after it was rebooted | 02:37 |
*** yamahata has quit IRC | 02:37 | |
*** bkopilov has quit IRC | 02:38 | |
mriedem | when i wrote https://github.com/openstack/nova/commit/1d4d00ec1c6d59fd6df5be776c781c38a4de8e28 i was coming at it from the nova reboot api side of things | 02:38 |
*** bjolo_ has joined #openstack-nova | 02:39 | |
cburgess | mriedem OK this is the original fix https://review.openstack.org/#/c/112946/ | 02:40 |
mriedem | yup | 02:40 |
*** thorst_afk has joined #openstack-nova | 02:41 | |
*** thorst_afk has quit IRC | 02:41 | |
*** thorst_afk has joined #openstack-nova | 02:41 | |
openstackgerrit | zhaolihui proposed openstack/nova: Fix pci_alias that include white spaces https://review.openstack.org/392077 | 02:42 |
mriedem | some really really wonderful debugging from me in https://bugs.launchpad.net/nova/+bug/1293480 | 02:42 |
openstack | Launchpad bug 1293480 in OpenStack Compute (nova) "Reboot host didn't restart instances due to libvirt lifecycle event change instance's power_stat as shutdown" [Medium,Fix released] - Assigned to Thomas Bechtold (toabctl) | 02:42 |
cburgess | mriedem OK I see what they are doing. They are hoping the reboot is 15 seconds or less so they don't pop the stopped event. They just kill the stopped event from the queue before sending it back up. | 02:42 |
mriedem | yup | 02:42 |
mriedem | god that was only a year and a half ago | 02:43 |
mriedem | i thought that was like 3 years ago | 02:43 |
cburgess | Yeah time warps funny the longer you work on OpenStack. | 02:43 |
*** ljxiash has quit IRC | 02:44 | |
cburgess | mriedem Whats the bug id for this current one with shelve/unshelve? | 02:44 |
cburgess | mriedem nm found it | 02:44 |
cburgess | mriedem OK here is the problem... the lifecycle queueing has a bug. The fact that we issued a specific action that will cause the VM to go into a divergent state from "STOPPED" means that the queued "STOP' action needs to be purged. | 02:46 |
*** thorst_afk has quit IRC | 02:46 | |
cburgess | So we fix this by updating the driver such that any time an action is taking that will diverge from STOP we have to clear all pending STOP events. | 02:47 |
*** ljxiash has joined #openstack-nova | 02:48 | |
*** zz_dimtruck is now known as dimtruck | 02:48 | |
cburgess | mriedem Specifically in this case.. the spawn action needs to clear the queue. | 02:48 |
cburgess | Because we know spawn is going to change the state so previously queued state changes are no longer valid. | 02:49 |
mriedem | yeah that's a pretty straight-forward fix | 02:49 |
cburgess | There are probably other times we should do that but feels like this is a clear cut case for we should at least do it at spawn. | 02:50 |
cburgess | Or at the start of spawn. | 02:50 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port virt.disk.mount.test_nbd to Python 3 https://review.openstack.org/403508 | 02:50 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port libvirt.storage.test_rbd to Python 3 https://review.openstack.org/403425 | 02:50 |
mriedem | i think we can do it whenever we're in the spawn method, | 02:51 |
mriedem | because the task_state isn't set to None until after we come back from that | 02:51 |
mriedem | as long as the task_state is not None, we ignore lifecycle events | 02:51 |
mriedem | but yeah i like your thinking on this | 02:51 |
cburgess | mriedem I added a comment to the bug. | 02:54 |
mriedem | cool, thanks | 02:54 |
*** jamielennox|away is now known as jamielennox | 02:54 | |
cburgess | I haven't looked into the code to see how/if thats possible. I suspect the issue here is that the queue is hidden from us because its locked away from us in that damn native thread. | 02:54 |
cburgess | Which makes be think the queue needs to move to the manager and the sleep needs to happen there because at least then we can take action on its contents. | 02:54 |
mriedem | no the queue is in the libvirt.Host object | 02:54 |
cburgess | and that object/queue is persisted outside of the native thread? | 02:55 |
mriedem | we can just add a hook to dequeue based on some key, probably the domain id | 02:55 |
mriedem | yeah | 02:55 |
mriedem | well....would have to check | 02:55 |
*** hieulq_ has joined #openstack-nova | 02:55 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port virt.libvirt.test_imagebackend to Python 3 https://review.openstack.org/403431 | 02:56 |
cburgess | mriedem Yeah the existing code that clear a delayed event happens inside the libvirt driver code. | 02:58 |
cburgess | Looks like the event as a uuid attribue that is presently used to find the previous stop. | 02:59 |
*** rkrum has joined #openstack-nova | 02:59 | |
cburgess | mriedem Or not.. that code got moved some place... | 03:00 |
openstackgerrit | int32bit proposed openstack/nova: Add lock record to instance action list https://review.openstack.org/396510 | 03:00 |
*** takashin has joined #openstack-nova | 03:01 | |
cburgess | mriedem Yeah its all inside libvirt.host now. So not sure what that means as far as accessing that. | 03:02 |
mriedem | the driver has self.host | 03:02 |
mriedem | so we can add like a cancel_pending_stopped_event method or something | 03:02 |
mriedem | and pass in the instance.uuid | 03:02 |
cburgess | mriedem Yeah that should work. | 03:02 |
cburgess | We do it already here when we get another event that should cancel... | 03:03 |
cburgess | https://github.com/openstack/nova/blob/14.0.0/nova/virt/libvirt/host.py#L278-L280 | 03:03 |
cburgess | So its the same logic only instead of for an event its just the function call you describe that takesa UUID and just purges all events for that UUID. | 03:03 |
cburgess | Interestingly none of this code for queing/dequiing/handling the event is actually locked. | 03:04 |
cburgess | I suspect there are a lot more races in here.. | 03:04 |
cburgess | mriedem Dinner time for me talk to later. | 03:05 |
*** jwcroppe has quit IRC | 03:05 | |
*** jwcroppe has joined #openstack-nova | 03:06 | |
*** stevemar__ has joined #openstack-nova | 03:11 | |
*** ducttape_ has quit IRC | 03:11 | |
*** yuntongjin has joined #openstack-nova | 03:13 | |
*** rodrigods_ is now known as rodrigods | 03:15 | |
*** unicell has quit IRC | 03:17 | |
*** jamielennox is now known as jamielennox|away | 03:17 | |
*** tjones has joined #openstack-nova | 03:20 | |
*** tjones has quit IRC | 03:21 | |
*** jamielennox|away is now known as jamielennox | 03:26 | |
*** catintheroof has quit IRC | 03:28 | |
*** catintheroof has joined #openstack-nova | 03:28 | |
*** catintheroof has quit IRC | 03:28 | |
*** catintheroof has joined #openstack-nova | 03:30 | |
*** catintheroof has quit IRC | 03:30 | |
*** tovin07 has quit IRC | 03:31 | |
*** catintheroof has joined #openstack-nova | 03:31 | |
*** tbachman has joined #openstack-nova | 03:31 | |
*** catintheroof has quit IRC | 03:31 | |
*** tovin07 has joined #openstack-nova | 03:35 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova: Unexpected API error during server create https://review.openstack.org/404565 | 03:39 |
*** tojuvone has quit IRC | 03:39 | |
*** mriedem has quit IRC | 03:41 | |
*** thorst_afk has joined #openstack-nova | 03:45 | |
*** nicolasbock has quit IRC | 03:45 | |
*** yuntongjin has quit IRC | 03:45 | |
*** jamielennox is now known as jamielennox|away | 03:47 | |
*** psachin has joined #openstack-nova | 03:47 | |
*** thorst_afk has quit IRC | 03:52 | |
*** prateek has joined #openstack-nova | 03:55 | |
*** mriedem has joined #openstack-nova | 03:59 | |
*** hieulq_ has quit IRC | 04:01 | |
*** bkopilov has joined #openstack-nova | 04:02 | |
*** mlakat has joined #openstack-nova | 04:06 | |
*** tuanluong has joined #openstack-nova | 04:06 | |
openstackgerrit | Diana Clarke proposed openstack/python-novaclient: Microversion 2.39 - Simple tenant usage pagination https://review.openstack.org/394653 | 04:08 |
*** hieulq_ has joined #openstack-nova | 04:10 | |
*** mdnadeem has joined #openstack-nova | 04:11 | |
*** sreeram_v has joined #openstack-nova | 04:12 | |
*** sreeram_v has joined #openstack-nova | 04:13 | |
*** PsionTheory has joined #openstack-nova | 04:14 | |
*** hieulq_ has quit IRC | 04:17 | |
*** dimtruck is now known as zz_dimtruck | 04:19 | |
*** hieulq_ has joined #openstack-nova | 04:19 | |
*** armax has quit IRC | 04:21 | |
*** hongbin has quit IRC | 04:21 | |
*** sam_nowitzki has joined #openstack-nova | 04:21 | |
*** armax has joined #openstack-nova | 04:24 | |
*** stevemar__ has quit IRC | 04:25 | |
*** stevemar__ has joined #openstack-nova | 04:25 | |
*** jgriffith is now known as jgriffith_away | 04:28 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/os-vif: Changed the home-page link https://review.openstack.org/405100 | 04:29 |
*** stevemar__ has quit IRC | 04:30 | |
*** jamielennox|away is now known as jamielennox | 04:33 | |
*** rkrum has quit IRC | 04:35 | |
*** sudipto_ has joined #openstack-nova | 04:35 | |
*** sudipto has joined #openstack-nova | 04:35 | |
*** ducttape_ has joined #openstack-nova | 04:41 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host https://review.openstack.org/357105 | 04:48 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration with target https://review.openstack.org/368557 | 04:49 |
*** browne has joined #openstack-nova | 04:49 | |
*** PsionTheory has quit IRC | 04:49 | |
*** thorst_afk has joined #openstack-nova | 04:50 | |
*** sam_nowitzki has quit IRC | 04:53 | |
*** sam_nowitzki has joined #openstack-nova | 04:54 | |
*** thorst_afk has quit IRC | 04:57 | |
*** browne has quit IRC | 04:58 | |
*** tjones has joined #openstack-nova | 05:00 | |
*** links has joined #openstack-nova | 05:00 | |
*** jamespage has quit IRC | 05:00 | |
*** jamespag` has joined #openstack-nova | 05:00 | |
*** bjolo_ has quit IRC | 05:03 | |
*** ayogi has joined #openstack-nova | 05:04 | |
*** kaisers has quit IRC | 05:07 | |
*** prateek_ has joined #openstack-nova | 05:11 | |
*** prateek has quit IRC | 05:14 | |
*** yuntongjin has joined #openstack-nova | 05:14 | |
*** yamahata has joined #openstack-nova | 05:15 | |
*** parora has joined #openstack-nova | 05:15 | |
*** prateek_ has quit IRC | 05:17 | |
*** ducttape_ has quit IRC | 05:18 | |
*** armax has quit IRC | 05:22 | |
*** lpetrut has joined #openstack-nova | 05:30 | |
*** gouthamr has joined #openstack-nova | 05:33 | |
*** tbachman has quit IRC | 05:36 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix 'id' (attachment_id) parameters https://review.openstack.org/349863 | 05:38 |
*** qwertyco has joined #openstack-nova | 05:38 | |
*** qwertyco has quit IRC | 05:38 | |
*** qwertyco has joined #openstack-nova | 05:39 | |
*** tjones has left #openstack-nova | 05:43 | |
*** oomichi has quit IRC | 05:47 | |
*** liusheng has quit IRC | 05:47 | |
*** yuntongjin has quit IRC | 05:48 | |
*** oomichi has joined #openstack-nova | 05:48 | |
*** sandanar has joined #openstack-nova | 05:49 | |
*** ljxiash has quit IRC | 05:49 | |
*** ljxiash has joined #openstack-nova | 05:49 | |
*** ljxiash has quit IRC | 05:53 | |
*** liusheng has joined #openstack-nova | 05:53 | |
*** thorst_afk has joined #openstack-nova | 05:55 | |
*** ljxiash has joined #openstack-nova | 05:56 | |
*** ljxiash has quit IRC | 06:01 | |
*** lpetrut has quit IRC | 06:02 | |
*** thorst_afk has quit IRC | 06:02 | |
*** sudipto has quit IRC | 06:03 | |
*** sudipto has joined #openstack-nova | 06:03 | |
*** sudipto_ has quit IRC | 06:04 | |
*** sudipto_ has joined #openstack-nova | 06:05 | |
*** kaisers has joined #openstack-nova | 06:07 | |
*** kristian__ has joined #openstack-nova | 06:08 | |
*** lpetrut has joined #openstack-nova | 06:10 | |
*** baoli has quit IRC | 06:11 | |
*** kristian__ has quit IRC | 06:12 | |
openstackgerrit | Teng Fei proposed openstack/nova: Pass the parameter of extra image properties to create_snapshot_force() https://review.openstack.org/404656 | 06:12 |
*** parora has quit IRC | 06:13 | |
*** prateek has joined #openstack-nova | 06:13 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova: Unexpected API error during server create https://review.openstack.org/404565 | 06:14 |
*** diga has joined #openstack-nova | 06:15 | |
*** kaisers has quit IRC | 06:16 | |
*** lpetrut has quit IRC | 06:17 | |
*** jaosorior has joined #openstack-nova | 06:19 | |
*** jwcroppe has quit IRC | 06:20 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove the Microversion header when 406 returned https://review.openstack.org/405118 | 06:20 |
*** ljxiash has joined #openstack-nova | 06:28 | |
*** ljxiash has quit IRC | 06:30 | |
*** unicell has joined #openstack-nova | 06:30 | |
*** hieulq_ has quit IRC | 06:31 | |
*** hieulq_ has joined #openstack-nova | 06:31 | |
*** jwcroppe has joined #openstack-nova | 06:33 | |
*** unicell has quit IRC | 06:34 | |
*** moshele has joined #openstack-nova | 06:38 | |
*** acabot has quit IRC | 06:43 | |
*** kristian__ has joined #openstack-nova | 06:43 | |
*** tojuvone has joined #openstack-nova | 06:44 | |
*** kristian__ has quit IRC | 06:44 | |
*** kristian__ has joined #openstack-nova | 06:45 | |
*** mjura has joined #openstack-nova | 06:46 | |
openstackgerrit | Thomas Bechtold proposed openstack/nova: Handle deleted instances when refreshing the info_cache https://review.openstack.org/398308 | 06:46 |
*** kristia__ has joined #openstack-nova | 06:47 | |
*** avolkov` has quit IRC | 06:48 | |
*** kristian__ has quit IRC | 06:50 | |
openstackgerrit | zhaolihui proposed openstack/nova: Fix keypair quota error https://review.openstack.org/403529 | 06:53 |
*** mjura has quit IRC | 06:54 | |
*** mjura has joined #openstack-nova | 06:54 | |
*** ljxiash has joined #openstack-nova | 06:55 | |
*** stevemar__ has joined #openstack-nova | 06:56 | |
*** kristia__ has quit IRC | 06:56 | |
*** kristian__ has joined #openstack-nova | 06:57 | |
*** kristian__ has quit IRC | 07:00 | |
*** ljxiash has quit IRC | 07:00 | |
*** thorst_afk has joined #openstack-nova | 07:00 | |
*** stevemar__ has quit IRC | 07:01 | |
*** jwcroppe has quit IRC | 07:01 | |
openstackgerrit | Bhagyashri Shewale proposed openstack/nova: Handle maximum limit in schema for int and float type parameters https://review.openstack.org/399002 | 07:01 |
*** jwcroppe has joined #openstack-nova | 07:02 | |
openstackgerrit | YuYang proposed openstack/nova: VMware:fix get vm'root deivce conditional verify https://review.openstack.org/402256 | 07:03 |
*** thorst_afk has quit IRC | 07:06 | |
*** tuanluong_ has joined #openstack-nova | 07:08 | |
*** jaosorior has quit IRC | 07:09 | |
*** jaosorior has joined #openstack-nova | 07:09 | |
*** tuanluong has quit IRC | 07:11 | |
*** kaisers has joined #openstack-nova | 07:12 | |
*** hieulq_ has quit IRC | 07:13 | |
*** zhangjl1 has joined #openstack-nova | 07:13 | |
*** ihrachys has joined #openstack-nova | 07:14 | |
*** zhangjl has quit IRC | 07:15 | |
*** ducttape_ has joined #openstack-nova | 07:18 | |
*** kaisers has quit IRC | 07:20 | |
*** longlq_ has joined #openstack-nova | 07:20 | |
*** ihrachys has quit IRC | 07:20 | |
*** ekuris has joined #openstack-nova | 07:21 | |
*** sam_nowitzki has quit IRC | 07:23 | |
*** mnestratov has joined #openstack-nova | 07:24 | |
*** ducttape_ has quit IRC | 07:24 | |
*** oanson has joined #openstack-nova | 07:24 | |
pkholkin | alex_xu: ok, sure, thanks! | 07:26 |
*** masuberu has joined #openstack-nova | 07:28 | |
*** gmann has quit IRC | 07:29 | |
*** yuntongjin has joined #openstack-nova | 07:29 | |
alex_xu | pkholkin: np | 07:30 |
*** masber has quit IRC | 07:30 | |
*** kristian__ has joined #openstack-nova | 07:31 | |
*** sridharg has joined #openstack-nova | 07:32 | |
*** kristia__ has joined #openstack-nova | 07:32 | |
*** gmann has joined #openstack-nova | 07:33 | |
*** zhangjl1 has quit IRC | 07:33 | |
*** zhangjl has joined #openstack-nova | 07:33 | |
*** andreas_s has joined #openstack-nova | 07:33 | |
*** thorst_afk has joined #openstack-nova | 07:35 | |
*** mkoderer has joined #openstack-nova | 07:35 | |
*** kristian__ has quit IRC | 07:35 | |
*** hieulq_ has joined #openstack-nova | 07:36 | |
*** duonghq has joined #openstack-nova | 07:38 | |
*** markus_z has joined #openstack-nova | 07:39 | |
*** unicell has joined #openstack-nova | 07:42 | |
*** thorst_afk has quit IRC | 07:42 | |
*** kristia__ has quit IRC | 07:48 | |
*** kristian__ has joined #openstack-nova | 07:49 | |
*** josecastroleon has quit IRC | 07:50 | |
*** ihrachys has joined #openstack-nova | 07:51 | |
*** kristian__ has quit IRC | 07:53 | |
*** vearnx has quit IRC | 07:55 | |
*** liusheng has quit IRC | 07:55 | |
*** liusheng has joined #openstack-nova | 07:56 | |
*** yuntongjin has quit IRC | 07:57 | |
pkholkin | alex_xu: I have one question, I'm not sure in worl item about removing quotas check, does it mean that we should remove this https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L284 ? | 07:58 |
pkholkin | other things seems clear to me | 07:58 |
*** unicell has quit IRC | 07:59 | |
*** longlq_ has quit IRC | 07:59 | |
*** josecastroleon has joined #openstack-nova | 07:59 | |
alex_xu | pkholkin: sorry, I didn't get you. what is 'worl item'? | 07:59 |
*** sam_nowitzki has joined #openstack-nova | 08:00 | |
pkholkin | alex_xu: sorry, 'work item', I found this in the spec 'Remove the quota check for create image/backup actions.' | 08:00 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Don't delete neutron port when attach failed https://review.openstack.org/403568 | 08:01 |
*** sam_nowitzki has quit IRC | 08:03 | |
alex_xu | pkholkin: sorry, i'm in meeting, i will reply you asap after the meeting | 08:03 |
pkholkin | alex_xu: yes, no problem! | 08:04 |
*** slagle has quit IRC | 08:05 | |
*** matrohon has joined #openstack-nova | 08:07 | |
*** tuanluong has joined #openstack-nova | 08:08 | |
*** kristian__ has joined #openstack-nova | 08:09 | |
*** tuanluong_ has quit IRC | 08:10 | |
*** ralonsoh has joined #openstack-nova | 08:13 | |
*** kristian__ has quit IRC | 08:14 | |
*** rnoriega has quit IRC | 08:14 | |
*** ljxiash has joined #openstack-nova | 08:17 | |
*** kaisers has joined #openstack-nova | 08:17 | |
*** code-R_ has quit IRC | 08:17 | |
*** Prophidys has quit IRC | 08:19 | |
*** ljxiash has quit IRC | 08:21 | |
*** xiaoyang has joined #openstack-nova | 08:21 | |
*** josecastroleon1 has joined #openstack-nova | 08:24 | |
*** kaisers has quit IRC | 08:25 | |
*** josecastroleon has quit IRC | 08:26 | |
*** wznoinsk has quit IRC | 08:26 | |
*** yuntongjin has joined #openstack-nova | 08:26 | |
*** Jeffrey4l_ has quit IRC | 08:26 | |
*** jcook has quit IRC | 08:28 | |
*** takashin has left #openstack-nova | 08:29 | |
*** kristian__ has joined #openstack-nova | 08:30 | |
*** Jeffrey4l_ has joined #openstack-nova | 08:30 | |
*** wznoinsk has joined #openstack-nova | 08:30 | |
openstackgerrit | int32bit proposed openstack/nova: [WIP]Paging the db query when filter with ip https://review.openstack.org/405171 | 08:32 |
*** haukebruno has quit IRC | 08:33 | |
*** jcook has joined #openstack-nova | 08:34 | |
openstackgerrit | Yingxin Cheng proposed openstack/nova: Unexpected API error during server create https://review.openstack.org/404565 | 08:34 |
*** rcernin has joined #openstack-nova | 08:34 | |
*** haukebruno has joined #openstack-nova | 08:35 | |
*** andreas_s has quit IRC | 08:36 | |
*** mfisch has quit IRC | 08:36 | |
*** andreas_s has joined #openstack-nova | 08:36 | |
*** Guest66666 has quit IRC | 08:36 | |
*** rcernin has quit IRC | 08:37 | |
*** rcernin has joined #openstack-nova | 08:37 | |
*** Guest66666 has joined #openstack-nova | 08:38 | |
*** matrohon has quit IRC | 08:39 | |
*** mfisch has joined #openstack-nova | 08:40 | |
*** mfisch has quit IRC | 08:40 | |
*** mfisch has joined #openstack-nova | 08:40 | |
*** thorst_afk has joined #openstack-nova | 08:40 | |
alex_xu | pkholkin: we won't remove that method, it is still used by old microversion api | 08:41 |
*** yamahata has quit IRC | 08:41 | |
alex_xu | pkholkin: we will stop the quota check in the new microversion | 08:41 |
pkholkin | hm, yes | 08:41 |
pkholkin | alex_xu: so we should not use this function at all for all operation since new microversion? | 08:42 |
*** kristian__ has quit IRC | 08:43 | |
alex_xu | pkholkin: yes, probably just for create_image/create_backup | 08:43 |
*** amoralej|off is now known as amoralej | 08:44 | |
alex_xu | pkholkin: the image_metadata API just deprecate directly | 08:45 |
*** ljxiash has joined #openstack-nova | 08:45 | |
pkholkin | alex_xu: e.g. this will be changed https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1056 | 08:46 |
pkholkin | and create_backup | 08:46 |
*** thorst_afk has quit IRC | 08:46 | |
*** yamahata has joined #openstack-nova | 08:47 | |
alex_xu | pkholkin: yes | 08:47 |
pkholkin | alex_xu: ok | 08:48 |
pkholkin | alex_xu: one more thing, what do you think about these names? https://github.com/openstack/nova/blob/master/nova/api/openstack/api_version_request.py#L111-L112 | 08:48 |
*** ihrachys has quit IRC | 08:48 | |
openstackgerrit | int32bit proposed openstack/nova: [WIP]Page the db query when filter instances with IP https://review.openstack.org/405171 | 08:49 |
alex_xu | pkholkin: just limit those in a new microversion. | 08:49 |
*** ljxiash has quit IRC | 08:50 | |
alex_xu | pkholkin: we can have a constant at here also. and change the comment https://github.com/openstack/nova/blob/master/nova/api/openstack/api_version_request.py#L109 | 08:50 |
*** ihrachys has joined #openstack-nova | 08:50 | |
alex_xu | pkholkin: MAX_PROXY_API_SUPPORT_VERSION isn't about all proxy api | 08:50 |
*** hieulq_ has quit IRC | 08:51 | |
*** rmart04 has joined #openstack-nova | 08:52 | |
pkholkin | alex_xu: that's the problem, we can't just change these values (because we have 2.37 and 2.38), but the name is incorrect (ALL_PROXY) | 08:52 |
*** kristian__ has joined #openstack-nova | 08:52 | |
pkholkin | these constants are used in many places, I also don't want to change all of them (to strings e.g.) | 08:52 |
alex_xu | pkholkin: yea, we can just add a new constant after the line of MAX_PROXY_API_SUPPORT_VERSION, it can be called as IMAGE_METADTA_PROXY_API_SUPPORT_VERSION.... | 08:53 |
*** kristia__ has joined #openstack-nova | 08:53 | |
alex_xu | pkholkin: then the comment is right | 08:54 |
alex_xu | pkholkin: oops, we need to adjust the comment a little | 08:54 |
tdurakov | morning nova | 08:55 |
*** kristi___ has joined #openstack-nova | 08:55 | |
tdurakov | it looks like live-migration job starts failing | 08:55 |
tdurakov | working on fix | 08:55 |
*** kristian__ has quit IRC | 08:55 | |
*** kristian__ has joined #openstack-nova | 08:57 | |
*** stevemar__ has joined #openstack-nova | 08:57 | |
pkholkin | alex_xu: ok, so I what about this? http://xsnippet.org/362125/ | 08:57 |
pkholkin | I think I will need both new constants in different places | 08:58 |
*** kristia__ has quit IRC | 08:58 | |
*** sapcc-bot has quit IRC | 08:58 | |
*** carthaca_ has quit IRC | 08:58 | |
*** sapcc-bot has joined #openstack-nova | 08:58 | |
*** carthaca_ has joined #openstack-nova | 08:58 | |
*** tommy_ has joined #openstack-nova | 08:58 | |
*** databus23_ has joined #openstack-nova | 08:58 | |
*** mkoderer_ has joined #openstack-nova | 08:58 | |
*** dgonzalez_ has joined #openstack-nova | 08:58 | |
*** david_1 has joined #openstack-nova | 08:58 | |
*** tommy_ is now known as Guest77223 | 08:59 | |
*** zzzeek has quit IRC | 09:00 | |
*** kristi___ has quit IRC | 09:00 | |
pkholkin | the only thing that I don't like here is the old name about all_proxy :) but I think we shouldn't change (it will cause many useless changes in names) | 09:00 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Fix for live-migration job https://review.openstack.org/405196 | 09:00 |
*** Guest77223 has quit IRC | 09:00 | |
*** databus23_ has quit IRC | 09:00 | |
*** carthaca_ has quit IRC | 09:00 | |
*** mkoderer_ has quit IRC | 09:00 | |
*** dgonzalez_ has quit IRC | 09:00 | |
*** david_1 has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-nova | 09:00 | |
tdurakov | alex_xu, hi, fix for l-m job^ let's wait for gate, if it works need to merge it | 09:01 |
*** stevemar__ has quit IRC | 09:02 | |
*** ababich has joined #openstack-nova | 09:02 | |
alex_xu | tdurakov: cool job! | 09:04 |
pkholkin | alex_xu: one more variant http://xsnippet.org/362126/ | 09:05 |
pkholkin | with changing old code | 09:05 |
*** acabot has joined #openstack-nova | 09:05 | |
pkholkin | but with correct new name | 09:05 |
*** code-R has joined #openstack-nova | 09:05 | |
pkholkin | alex_xu: I like this I think http://xsnippet.org/362127/ | 09:06 |
pkholkin | so the name and value for ALL_PROXY will be correct as it was | 09:07 |
*** prateek has quit IRC | 09:07 | |
*** hogepodge has quit IRC | 09:11 | |
alex_xu | pkholkin: the network, images API are using MAX_PROXY_API_SUPPORT_VERSION | 09:11 |
*** hogepodge has joined #openstack-nova | 09:12 | |
alex_xu | tdurakov: sorry, that isn't the part i'm familiar | 09:12 |
*** matrohon has joined #openstack-nova | 09:12 | |
*** woodster_ has quit IRC | 09:16 | |
pkholkin | alex_xu: yes, but what about changing the old name AX_PROXY_API_SUPPORT_VERSION to MAX_PROXY_API_SUPPORT_VERSION_EXCEPT_IMAGE_METADATA everywhere in the code? | 09:16 |
pkholkin | and make this below MAX_PROXY_API_SUPPORT_VERSION = '2.38' as new one | 09:16 |
*** code-R_ has joined #openstack-nova | 09:17 | |
*** cdent has joined #openstack-nova | 09:17 | |
tdurakov | alex_xu: I understand, the reason I asked, is that l-m job is voting and it's broken right now, if this fix works(check queue tests this patch right now) - it will be cool you help merging it, but if you don't feel confident it's ok too. | 09:18 |
*** code-R has quit IRC | 09:20 | |
*** ducttape_ has joined #openstack-nova | 09:20 | |
*** hieulq_ has joined #openstack-nova | 09:21 | |
*** ababich has quit IRC | 09:21 | |
*** igordcard has quit IRC | 09:21 | |
*** egarbade- has quit IRC | 09:21 | |
*** ccard_ has quit IRC | 09:22 | |
*** kaisers has joined #openstack-nova | 09:22 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Don't delete neutron port when attach failed https://review.openstack.org/403568 | 09:23 |
*** igordcard has joined #openstack-nova | 09:23 | |
*** thorst_afk has joined #openstack-nova | 09:25 | |
*** sreeram_v has quit IRC | 09:25 | |
*** ducttape_ has quit IRC | 09:25 | |
*** swamireddy has quit IRC | 09:27 | |
*** egarbade- has joined #openstack-nova | 09:27 | |
*** kaisers has quit IRC | 09:29 | |
*** rcernin has quit IRC | 09:29 | |
*** yingjun has quit IRC | 09:29 | |
*** rcernin has joined #openstack-nova | 09:30 | |
*** sreeram_v has joined #openstack-nova | 09:30 | |
*** paul-carlton2 has joined #openstack-nova | 09:30 | |
*** hogepodge has quit IRC | 09:31 | |
*** danpawlik has joined #openstack-nova | 09:31 | |
*** hogepodge has joined #openstack-nova | 09:32 | |
*** ccard_ has joined #openstack-nova | 09:33 | |
*** thorst_afk has quit IRC | 09:33 | |
*** yassine has joined #openstack-nova | 09:33 | |
*** yassine is now known as Guest80606 | 09:34 | |
*** ababich has joined #openstack-nova | 09:34 | |
*** lucas-afk is now known as lucasagomes | 09:36 | |
*** derekh has joined #openstack-nova | 09:36 | |
*** ftersin has quit IRC | 09:41 | |
*** asettle has joined #openstack-nova | 09:42 | |
asettle | Hey - hoping someone around can answer my, hopefully obvious, question. Is nova-network completely phased out now? | 09:43 |
asettle | I can't seem to get a concrete answer from anyone... er... at all. | 09:43 |
BobBall | nova-network is deprecated, yes. Long live Neutron. | 09:43 |
asettle | BobBall: thanks :) do you have a blueprint/spec lying around I can go find to reference? | 09:43 |
BobBall | There are some cases where neutorn doesn't work (e.g. cells v1) and nova-network continues to be used for them. | 09:44 |
*** hfu has quit IRC | 09:44 | |
BobBall | but generally, don't use it. | 09:44 |
asettle | Good to know :) thank you! | 09:44 |
johnthetubaguy | asettle: I can find a log message in the code, if that helps? | 09:44 |
asettle | johnthetubaguy: that would work! | 09:45 |
asettle | THank you :) | 09:45 |
*** gabor_antal has joined #openstack-nova | 09:45 | |
johnthetubaguy | asettle: https://github.com/openstack/nova/blob/master/nova/cmd/network.py#L44 | 09:45 |
johnthetubaguy | asettle: its properly dead for everyone apart from cells v1 users at somepoint after ocata-2 | 09:46 |
asettle | Explains why I can't seem to get a conrete answer. And it's *all* through our docs still. We're going to have to make that a nice lifting exercise. SHouldn't be too bad. | 09:46 |
asettle | Thanks johnthetubaguy :) | 09:46 |
johnthetubaguy | asettle: cool, here is a little more context: http://lists.openstack.org/pipermail/openstack-dev/2016-November/106499.html | 09:47 |
johnthetubaguy | asettle: basically bunch of tests still rely on nova-network, so we need to fix that first :) | 09:47 |
johnthetubaguy | asettle: awesome, thanks for sorting that out :) | 09:48 |
asettle | Ahh.. good... hahaha I love it when there's a little trail :p | 09:48 |
*** swamireddy has joined #openstack-nova | 09:48 | |
johnthetubaguy | heh | 09:48 |
asettle | No problem... a contributor put up a patch without any references or anything and it was a bit like 'uhhh mannn is this even the right stuff?!" | 09:48 |
asettle | thanks everyone for helping :) | 09:48 |
johnthetubaguy | ah, cool, good call | 09:48 |
asettle | It's pretty small, I've noted teh stuff: https://review.openstack.org/#/c/404880/ | 09:50 |
asettle | Might be good for you to have a quick look too, if oyu have the time :) | 09:50 |
johnthetubaguy | cool, opened in in a tab, but its getting a little out of hand right now | 09:51 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Fix for live-migration job https://review.openstack.org/405196 | 09:54 |
tdurakov | johnthetubaguy: hi, could you review/merge that^ | 09:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Add 'preallocate_images' to 'virt' group https://review.openstack.org/392567 | 09:55 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Move virt options to a group https://review.openstack.org/392566 | 09:55 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Detail the 'injected_network_template' opt https://review.openstack.org/392565 | 09:55 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Standardize formatting of virt https://review.openstack.org/392564 | 09:55 |
*** openstack has joined #openstack-nova | 10:04 | |
bauzas | tdurakov: FWIW, looking at the job description | 10:04 |
*** yamahata has quit IRC | 10:06 | |
*** rcernin has quit IRC | 10:06 | |
tdurakov | bauzas: do you mean it's title? or wiki page for that job? | 10:06 |
*** rcernin has joined #openstack-nova | 10:07 | |
openstackgerrit | Huan Xie proposed openstack/nova: XenAPI: Remove ovs_integration_bridge default value https://review.openstack.org/299092 | 10:07 |
*** voelzmo has joined #openstack-nova | 10:08 | |
*** matrohon has quit IRC | 10:11 | |
*** hoangcx has quit IRC | 10:11 | |
bauzas | tdurakov: I'm looking at what is doing that job | 10:20 |
bauzas | project-config if you prefer | 10:20 |
tdurakov | bauzas: the thing is that all work is done in post-test hook | 10:21 |
*** sahid has joined #openstack-nova | 10:21 | |
tdurakov | bauzas: so project-config just could point you to post-test-hook location | 10:22 |
*** ljxiash has joined #openstack-nova | 10:22 | |
tdurakov | I'd prefer to document it in wiki maybe, what do you think? | 10:22 |
*** psachin has quit IRC | 10:22 | |
*** matrohon has joined #openstack-nova | 10:23 | |
bauzas | tdurakov: right, I see that https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml#L1427 | 10:24 |
bauzas | tdurakov: my question is, how can I see it's using ceph ? | 10:24 |
tdurakov | bauzas: the easiest for me(not sure for everyone ) is to check console logs | 10:25 |
*** ljxiash has quit IRC | 10:26 | |
tdurakov | bauzas: we might change the job name, but not sure that gate-tempest-dsvm-multinode-live-migration-no-shared-nfs-ceph-ubuntu-xenial is a good one | 10:26 |
*** kaisers has joined #openstack-nova | 10:26 | |
*** zhangjl1 has joined #openstack-nova | 10:27 | |
*** kristian__ has quit IRC | 10:27 | |
*** zhangjl has quit IRC | 10:29 | |
openstackgerrit | Alex Szarka proposed openstack/nova: Transform instance.rebuild.error notification https://review.openstack.org/396621 | 10:30 |
*** zhangjl1 has quit IRC | 10:31 | |
*** thorst_afk has joined #openstack-nova | 10:31 | |
*** _oanson has joined #openstack-nova | 10:31 | |
sfinucan | lbeliveau, moshele: I'm about to send out a request for ideas on NFV feature docs/tests that people would like to see to the mailing list. I think we have a pretty good handle on what's needed for SR-IOV/PCI passthrough, correct? | 10:32 |
*** mvk has quit IRC | 10:33 | |
*** kaisers has quit IRC | 10:33 | |
*** ircuser-1 has quit IRC | 10:34 | |
*** anish has quit IRC | 10:34 | |
*** sdague_ has joined #openstack-nova | 10:34 | |
*** ircuser-1 has joined #openstack-nova | 10:34 | |
*** rfolco has joined #openstack-nova | 10:34 | |
*** psachin has joined #openstack-nova | 10:36 | |
paul-carlton2 | I'm trying to get a new test working and getting oslo_versionedobjects.exception.ObjectActionError: Object action obj_make_compatible failed because: No rule for src_bdms | 10:36 |
*** kristian__ has joined #openstack-nova | 10:36 | |
*** sreeram_v has quit IRC | 10:36 | |
paul-carlton2 | Anyone seen this sort of error before and have any clues how to fix it | 10:36 |
*** thorst_afk has quit IRC | 10:37 | |
*** kristian__ has quit IRC | 10:38 | |
*** kristian__ has joined #openstack-nova | 10:38 | |
*** oanson has quit IRC | 10:39 | |
*** moshele has quit IRC | 10:39 | |
*** bswartz has quit IRC | 10:39 | |
*** s1rp has quit IRC | 10:39 | |
*** tonyb has quit IRC | 10:39 | |
*** toure has quit IRC | 10:39 | |
*** kashyap has quit IRC | 10:39 | |
*** dansmith has quit IRC | 10:39 | |
*** lbragstad has quit IRC | 10:39 | |
*** fnordahl has quit IRC | 10:39 | |
*** sreeram_v has joined #openstack-nova | 10:39 | |
*** kristian__ has quit IRC | 10:43 | |
*** moshele has joined #openstack-nova | 10:43 | |
*** bswartz has joined #openstack-nova | 10:43 | |
*** s1rp has joined #openstack-nova | 10:43 | |
*** tonyb has joined #openstack-nova | 10:43 | |
*** toure has joined #openstack-nova | 10:43 | |
*** kashyap has joined #openstack-nova | 10:43 | |
*** dansmith has joined #openstack-nova | 10:43 | |
*** lbragstad has joined #openstack-nova | 10:43 | |
*** fnordahl has joined #openstack-nova | 10:43 | |
tdurakov | bauzas, johnthetubaguy, what's about +W for https://review.openstack.org/#/c/405196/ ? :) | 10:43 |
*** sreeram_v has quit IRC | 10:44 | |
tdurakov | johnthetubaguy: thank you | 10:45 |
*** yingjun has joined #openstack-nova | 10:52 | |
openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_attach notification https://review.openstack.org/401992 | 10:53 |
sfinucan | paul-carlton2: Can't say I have, but looking at the sauce [1] it would appear you're possibly calling 'obj_make_compatible' on an older version of the version | 10:53 |
sfinucan | [1] https://github.com/openstack/oslo.versionedobjects/blob/39099b3/oslo_versionedobjects/base.py#L444-L454 | 10:53 |
*** matrohon has quit IRC | 10:54 | |
sfinucan | i.e. one without the aforementioned 'src_bdms' field | 10:54 |
*** diga has quit IRC | 10:54 | |
sfinucan | paul-carlton2: I've seen similar 'Object action failed' exception, but for other different reasons :/ | 10:54 |
*** tbachman has joined #openstack-nova | 10:54 | |
paul-carlton2 | sfinucan, fixed it, added obj.obj_make_compatible(primitive['nova_object.data'], '1.3') | 10:56 |
paul-carlton2 | ta | 10:56 |
openstackgerrit | Paul Carlton proposed openstack/nova: Live migration of instances with encrypted volumes https://review.openstack.org/389608 | 10:57 |
*** yingjun has quit IRC | 11:00 | |
*** yingjun has joined #openstack-nova | 11:00 | |
*** yingjun has quit IRC | 11:04 | |
*** ihrachys has quit IRC | 11:05 | |
*** matrohon has joined #openstack-nova | 11:05 | |
*** mvk has joined #openstack-nova | 11:09 | |
*** bapalm has quit IRC | 11:10 | |
*** bapalm has joined #openstack-nova | 11:15 | |
*** rwmjones has quit IRC | 11:15 | |
*** karthiks has quit IRC | 11:21 | |
*** ljxiash has joined #openstack-nova | 11:21 | |
*** ljxiash has quit IRC | 11:23 | |
*** rwmjones has joined #openstack-nova | 11:25 | |
*** jaosorior_lunch is now known as jaosorior | 11:25 | |
*** ljxiash has joined #openstack-nova | 11:27 | |
*** kristian__ has joined #openstack-nova | 11:29 | |
*** sean-k-mooney has joined #openstack-nova | 11:29 | |
*** kaisers has joined #openstack-nova | 11:31 | |
*** karthiks has joined #openstack-nova | 11:31 | |
*** ljxiash has quit IRC | 11:32 | |
*** ihrachys has joined #openstack-nova | 11:33 | |
*** gouthamr has quit IRC | 11:35 | |
*** cdent has quit IRC | 11:35 | |
*** thorst_afk has joined #openstack-nova | 11:36 | |
*** kaisers has quit IRC | 11:37 | |
*** tbachman has quit IRC | 11:42 | |
*** thorst_afk has quit IRC | 11:43 | |
*** claudiub|2 has joined #openstack-nova | 11:44 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Fix backwards compatibility for InstanceNUMACell https://review.openstack.org/396184 | 11:49 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Remove 'super' call in obj_make_compatible https://review.openstack.org/398264 | 11:50 |
*** yingjun has joined #openstack-nova | 11:51 | |
*** kristian__ has quit IRC | 11:51 | |
*** kristian__ has joined #openstack-nova | 11:52 | |
openstackgerrit | Hironori Shiina proposed openstack/nova: Ironic: Add soft reboot support to ironic driver https://review.openstack.org/403745 | 11:54 |
*** yingjun has quit IRC | 11:54 | |
*** yingjun has joined #openstack-nova | 11:54 | |
*** igordcard has quit IRC | 11:55 | |
*** ftersin has joined #openstack-nova | 11:57 | |
*** yingjun has quit IRC | 11:59 | |
*** nicolasbock has joined #openstack-nova | 11:59 | |
*** sreeram_v has joined #openstack-nova | 12:03 | |
alex_xu | johnthetubaguy: oomichi appreciate you can help on this two patches from bug smash https://review.openstack.org/392077 https://review.openstack.org/405118 | 12:07 |
alex_xu | and there is super easy one https://review.openstack.org/398970 | 12:07 |
*** sreeram_v has quit IRC | 12:07 | |
*** rodrigods is now known as rodrigods_ | 12:09 | |
*** bkopilov has quit IRC | 12:09 | |
*** karthiks has quit IRC | 12:10 | |
*** slagle has joined #openstack-nova | 12:10 | |
*** kristia__ has joined #openstack-nova | 12:12 | |
*** kristia__ has quit IRC | 12:14 | |
*** kristia__ has joined #openstack-nova | 12:14 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Live migration of instances with encrypted volumes https://review.openstack.org/389608 | 12:15 |
*** kristian__ has quit IRC | 12:16 | |
sfinucan | sahid: So I've been looking https://review.openstack.org/#/q/topic:bp/libvirt-emulator-threads-policy with fresh eyes | 12:17 |
sfinucan | specifically the first patch in that series https://review.openstack.org/#/c/385022/7/nova/objects/instance_numa_topology.py | 12:18 |
*** kristia__ has quit IRC | 12:18 | |
sfinucan | dansmith commented in the spec review for that that there probably wasn't much value in storing that on the InstanceNUMATopology object as we can easily extract it from the flavor where needed https://review.openstack.org/#/c/284094/8/specs/ocata/approved/libvirt-emulator-threads-policy.rst@141 | 12:19 |
*** sdague_ is now known as sdague | 12:20 | |
sfinucan | I'm in two minds about that. We do store CPUPolicy and CPUThreadPolicy against InstanceNUMACell, but I don't know if it's worth being consistent for the sake of consistency | 12:21 |
*** rtheis has joined #openstack-nova | 12:21 | |
sfinucan | sahid: Was there any conclusion on that or is it still being debated? | 12:21 |
*** hieulq_ has quit IRC | 12:22 | |
sfinucan | I've left a few additional comments in the reviews, in any case. Let me know | 12:22 |
*** karthiks has joined #openstack-nova | 12:25 | |
*** catintheroof has joined #openstack-nova | 12:25 | |
*** jmccarthy has joined #openstack-nova | 12:26 | |
*** jmccarthy has left #openstack-nova | 12:26 | |
sdague | mriedem / dansmith : when you get coffinated I just want to walk through the cells v2 grenade thing quick. I posted 2 questions in the review. My goal is we land it this week, just want to make sure I've got it in my head. | 12:27 |
ihrachys | kashyap: hello my friend | 12:30 |
*** sreeram_v has joined #openstack-nova | 12:30 | |
ihrachys | kashyap: we were looking at setting a centos job for neutron gate. and ofc the first iteration does not pass. | 12:31 |
ihrachys | kashyap: and I see permission denied errors for kvm in nova-conductor log: http://logs.openstack.org/62/404362/1/experimental/gate-tempest-dsvm-neutron-dvr-multinode-full-centos-7-nv/2aa529f/logs/screen-n-cond.txt.gz?level=TRACE#_2016-11-29_18_24_33_632 | 12:31 |
ihrachys | kashyap: any ideas what could go wrong? I thought, maybe the user is not in libvirtd group, or Selinux enabled, but for what I see in devstack log, both aspects are in order | 12:32 |
*** kaisers has joined #openstack-nova | 12:35 | |
*** ljxiash has joined #openstack-nova | 12:35 | |
*** lucasagomes is now known as lucas-hungry | 12:36 | |
*** bvanhav has joined #openstack-nova | 12:36 | |
*** sreeram__ has joined #openstack-nova | 12:37 | |
*** hieulq has joined #openstack-nova | 12:38 | |
sfinucan | cfriesen_: I'd like your thoughts on this, if/when you get a chance. You're up-to-speed on all things "pin'y" https://review.openstack.org/#/c/400874 | 12:39 |
*** sreeram_v has quit IRC | 12:40 | |
*** ljxiash has quit IRC | 12:40 | |
*** kaisers has quit IRC | 12:43 | |
kashyap | ihrachys: Just going to grab some lunch, can you please give me a few min? | 12:44 |
kashyap | ihrachys: Oh, from a quick look | 12:44 |
kashyap | ihrachys: Perhaps you're hitting these - https://review.openstack.org/#/c/404981/ & https://review.openstack.org/#/c/401366/ | 12:45 |
*** stevemar__ has joined #openstack-nova | 12:46 | |
*** catintheroof has quit IRC | 12:48 | |
*** kristian__ has joined #openstack-nova | 12:48 | |
kashyap | ihrachys: Especially the note there - ("Please change permissions on %s to 0x666") in guestfs.py | 12:48 |
kashyap | ihrachys: It's the permissions on the KVM character device: | 12:49 |
kashyap | $ ls -lsrt /dev/kvm | 12:49 |
kashyap | 0 crw-rw-rw-+ 1 root kvm 10, 232 Nov 21 18:58 /dev/kvm | 12:49 |
kashyap | I see the above on a _working_ env | 12:49 |
kashyap | Some distributions somehow seem to screw that up | 12:49 |
*** kristian__ has quit IRC | 12:50 | |
*** kristian__ has joined #openstack-nova | 12:50 | |
*** stevemar__ has quit IRC | 12:50 | |
*** kristian__ has quit IRC | 12:52 | |
*** kristian__ has joined #openstack-nova | 12:52 | |
*** hieulq has quit IRC | 12:53 | |
*** thorst_afk has joined #openstack-nova | 12:53 | |
*** kristian__ has quit IRC | 12:57 | |
*** rodrigods_ has quit IRC | 12:58 | |
*** unicell has joined #openstack-nova | 12:58 | |
*** rodrigods has joined #openstack-nova | 12:59 | |
ihrachys | kashyap: hm. the devstack patch is ubuntu only | 12:59 |
ihrachys | kashyap: another thing that puzzles me is -devstack has a centos job already | 12:59 |
ihrachys | so apparently it works somehow in some cases | 12:59 |
*** jamielennox is now known as jamielennox|away | 13:00 | |
*** kristian__ has joined #openstack-nova | 13:00 | |
*** ljxiash has joined #openstack-nova | 13:00 | |
*** xinliang has quit IRC | 13:01 | |
*** tbachman has joined #openstack-nova | 13:01 | |
*** unicell has quit IRC | 13:03 | |
*** ljxiash has quit IRC | 13:04 | |
lbeliveau | sfinucan: yeah, I'll have a look | 13:05 |
*** tbachman_ has joined #openstack-nova | 13:06 | |
*** tbachman has quit IRC | 13:07 | |
*** tbachman_ is now known as tbachman | 13:07 | |
*** ducttape_ has joined #openstack-nova | 13:08 | |
*** kristian__ has quit IRC | 13:08 | |
frickler | mriedem: looking at the logs, it seems to me that https://review.openstack.org/405363 might solve the current gate failures on gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial | 13:11 |
*** ljxiash has joined #openstack-nova | 13:11 | |
*** ljxiash has quit IRC | 13:13 | |
openstackgerrit | Jens Rosenboom proposed openstack/nova: DNM: Dummy change to test devstack-plugin-ceph fix https://review.openstack.org/405365 | 13:13 |
bauzas | frickler: we merged a change recently about that, sec | 13:13 |
*** xinliang has joined #openstack-nova | 13:13 | |
*** catintheroof has joined #openstack-nova | 13:13 | |
frickler | bauzas: https://review.openstack.org/403988 would be the bad commit | 13:14 |
bauzas | frickler: https://review.openstack.org/#/c/405196/ | 13:14 |
frickler | bauzas: ah, o.k., that kind of works around the fix I propose. I'm not immediately sure which one is cleaner, though | 13:15 |
bauzas | frickler: could you please recheck | 13:16 |
*** voelzmo has quit IRC | 13:16 | |
*** sreeram__ has quit IRC | 13:16 | |
*** voelzmo has joined #openstack-nova | 13:16 | |
*** catinthe_ has joined #openstack-nova | 13:18 | |
*** catintheroof has quit IRC | 13:19 | |
*** _oanson is now known as oanson | 13:20 | |
*** amoralej is now known as amoralej|lunch | 13:21 | |
*** thorst_a_ has joined #openstack-nova | 13:21 | |
*** thorst_afk has quit IRC | 13:23 | |
*** egarbade- has quit IRC | 13:24 | |
*** ekhugen_alt has quit IRC | 13:24 | |
kashyap | ihrachys: Back now | 13:24 |
*** Prophidys has joined #openstack-nova | 13:25 | |
*** edmondsw has joined #openstack-nova | 13:25 | |
*** egarbade- has joined #openstack-nova | 13:25 | |
*** mdnadeem has quit IRC | 13:26 | |
*** ljxiash has joined #openstack-nova | 13:26 | |
*** ekhugen has joined #openstack-nova | 13:26 | |
*** gszasz has joined #openstack-nova | 13:26 | |
mriedem | tdurakov: nice https://review.openstack.org/#/c/405196/ so it was my fault :) | 13:28 |
*** edmondsw_ has joined #openstack-nova | 13:28 | |
*** edmondsw_ has quit IRC | 13:28 | |
*** edmondsw_ has joined #openstack-nova | 13:29 | |
*** tuanluong has quit IRC | 13:29 | |
*** edmondsw_ has quit IRC | 13:29 | |
*** mdnadeem has joined #openstack-nova | 13:29 | |
tdurakov | mriedem: np, want to add live-migration job for plugins check and gate pipelines, but not sure how I should change post-hook to download plugin from the change, not master, what do you think? | 13:30 |
mriedem | frickler: +1 on that also | 13:30 |
mriedem | with comments inline | 13:30 |
*** voelzmo has quit IRC | 13:30 | |
mriedem | tdurakov: oh for https://review.openstack.org/#/c/405336/1 | 13:30 |
mriedem | hmm i'm not sure about that one | 13:30 |
*** ljxiash has quit IRC | 13:31 | |
*** nherciu has joined #openstack-nova | 13:31 | |
mriedem | tdurakov: we also need https://review.openstack.org/#/c/405196/ cherry picked to stable/newton | 13:31 |
tdurakov | mriedem: yes, if I just add that job it will run job against master, not the change on review, will try to figure out how to do it proprerly | 13:32 |
tdurakov | acked for stable/newton, will do | 13:32 |
*** thorst_a_ is now known as thorst_ | 13:32 | |
*** rfolco has quit IRC | 13:32 | |
mriedem | tdurakov: hmm, i'd think you'd have to check for the various ZUUL_* env vars then to pull the change down | 13:33 |
*** lucas-hungry is now known as lucasagomes | 13:34 | |
*** lamt has joined #openstack-nova | 13:34 | |
*** stevemar__ has joined #openstack-nova | 13:36 | |
openstackgerrit | Julian proposed openstack/nova: Transform instance.snapshot notifications https://review.openstack.org/330128 | 13:36 |
tdurakov | mriedem: checked stable/newton code, looks like I need to cherry/pick not only the fix, but all ceph changes that were done recently too | 13:36 |
*** ljxiash has joined #openstack-nova | 13:36 | |
mriedem | ewww | 13:37 |
mriedem | actually, | 13:37 |
mriedem | we didn't have the ceph stuff enabled in newton | 13:37 |
mriedem | so i think we're ok actually | 13:37 |
tdurakov | well, then everything is ok for stable/newton | 13:38 |
*** kaisers has joined #openstack-nova | 13:40 | |
*** ljxiash has quit IRC | 13:40 | |
*** kylek3h has quit IRC | 13:41 | |
*** yingjun has joined #openstack-nova | 13:43 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs: Add whitelist for filter and sort query parameters for server list API https://review.openstack.org/393205 | 13:44 |
mriedem | johnthetubaguy: bauzas: i've got to get my kid ready for school, would either of you be able to run the nova meeting in 15 minutes? | 13:45 |
*** tbachman has quit IRC | 13:45 | |
bauzas | mriedem: I could | 13:45 |
*** yingjun has quit IRC | 13:46 | |
bauzas | I just need caffeine for that | 13:46 |
mriedem | ok, i've already updated the agenda. | 13:46 |
*** yingjun has joined #openstack-nova | 13:46 | |
mriedem | should be straight forward | 13:46 |
bauzas | okay, looking | 13:46 |
mriedem | i can add the cells v2 meeting notes | 13:46 |
bauzas | FWIW, welcome to the club of fathers helping children | 13:46 |
bauzas | mriedem: please, I wasn't there | 13:47 |
*** kaisers has quit IRC | 13:47 | |
bauzas | (stuck in some Java UG :p ) | 13:47 |
*** qwertyco has quit IRC | 13:47 | |
*** takashin has joined #openstack-nova | 13:48 | |
*** tbachman has joined #openstack-nova | 13:48 | |
*** ducttape_ has quit IRC | 13:49 | |
mriedem | bauzas: just updated https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting with cellsv2 notes | 13:50 |
bauzas | mriedem: <3 | 13:51 |
*** yingjun has quit IRC | 13:52 | |
*** yingjun has joined #openstack-nova | 13:52 | |
*** bvanhav_ has joined #openstack-nova | 13:52 | |
*** bvanhav has quit IRC | 13:52 | |
*** bkopilov has joined #openstack-nova | 13:52 | |
mriedem | johnthetubaguy: dansmith: when you're around, https://review.openstack.org/#/c/399750/ could use a +W - it's just cleanups for the counting quotas spec | 13:53 |
johnthetubaguy | ah, cool | 13:54 |
*** yingjun has quit IRC | 13:56 | |
*** sreeram_v has joined #openstack-nova | 13:57 | |
*** mdnadeem has quit IRC | 13:58 | |
*** rnoriega has joined #openstack-nova | 13:59 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs: Add whitelist for filter and sort query parameters for server list API https://review.openstack.org/393205 | 14:01 |
*** lamt has quit IRC | 14:01 | |
*** tojuvone has quit IRC | 14:03 | |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: Objectify requests_and_created_ports https://review.openstack.org/405398 | 14:04 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: remove uses of network in _update_ports_for_instance https://review.openstack.org/405399 | 14:04 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: remove nets param from _update_ports_for_instance https://review.openstack.org/405400 | 14:04 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP extract _validate_req_and_create_ports https://review.openstack.org/405401 | 14:04 |
*** claudiub|2 has quit IRC | 14:05 | |
*** oanson has quit IRC | 14:06 | |
*** lamt has joined #openstack-nova | 14:07 | |
*** kylek3h has joined #openstack-nova | 14:08 | |
*** annegentle has joined #openstack-nova | 14:10 | |
*** rcernin has quit IRC | 14:10 | |
*** voelzmo has joined #openstack-nova | 14:11 | |
*** avolkov has joined #openstack-nova | 14:11 | |
*** rcernin has joined #openstack-nova | 14:11 | |
*** yingjun has joined #openstack-nova | 14:12 | |
*** tblakes has joined #openstack-nova | 14:13 | |
*** voelzmo has quit IRC | 14:13 | |
*** voelzmo has joined #openstack-nova | 14:13 | |
*** annegentle has quit IRC | 14:16 | |
*** kaisers has joined #openstack-nova | 14:17 | |
*** gouthamr has joined #openstack-nova | 14:17 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs: Create specs directory for Pike https://review.openstack.org/405407 | 14:18 |
*** eharney has joined #openstack-nova | 14:19 | |
*** mdrabe has joined #openstack-nova | 14:19 | |
*** amoralej|lunch is now known as amoralej | 14:21 | |
diana_clarke | So... I have a knowledge gap wrt microversions. Are they always & forever opt-in? That is, do we ever force a bump? Or do we say for a given release that a certain microversion is now the new minimum? | 14:21 |
*** gouthamr_ has joined #openstack-nova | 14:22 | |
*** gouthamr has quit IRC | 14:22 | |
*** yingjun_ has joined #openstack-nova | 14:23 | |
*** sdatko has quit IRC | 14:23 | |
*** ducttape_ has joined #openstack-nova | 14:23 | |
*** sdatko has joined #openstack-nova | 14:24 | |
*** kaisers has quit IRC | 14:24 | |
mriedem | bauzas: lots of details on the cells v1 issue from the cells v2 meeting log from yesterday | 14:25 |
bauzas | mriedem: I'll dig into the logs | 14:25 |
bauzas | mriedem: I was more or less hoping we couldn't get into trouble | 14:25 |
mriedem | diana_clarke: we don't have a mininum no | 14:25 |
diana_clarke | mriedem: so forever opt-in? | 14:26 |
*** yingjun has quit IRC | 14:26 | |
edleafe | diana_clarke: sort of... | 14:26 |
edleafe | diana_clarke: They are also being used as a signal that something changed. The main example is nova-net | 14:27 |
mriedem | diana_clarke: in some distant future we might start raising minimums | 14:27 |
mriedem | but nothing definitiv | 14:27 |
edleafe | diana_clarke: So after a particular microversion is released, nova-net will not work, no matter what MV you request | 14:27 |
edleafe | diana_clarke: the other earlier microversions are still available, assuming they don't interact with nova-net | 14:28 |
*** kaisers1 has quit IRC | 14:28 | |
*** ducttape_ has quit IRC | 14:28 | |
Dinesh_Bhor | edleafe: Hi, about your comment on this patch: https://review.openstack.org/#/c/401941/ should we discuss on #openstack-cinder or here is ok? | 14:28 |
diana_clarke | interesting... thanks folks, that helps clear up some of the confusion on my part | 14:28 |
mriedem | sfinucan: i'll take a look at your nova-specs ocata priorities patch later today, looks like it's mostly just copying what's in the summit recap email. i might request that we merge some of the more detailed stuff from mine, but then just go with the rest for yours. | 14:28 |
edleafe | Dinesh_Bhor: in the nova meeting now. | 14:29 |
edleafe | Dinesh_Bhor: maybe in a few minutes? | 14:29 |
Dinesh_Bhor | edleafe: yes | 14:29 |
*** kaisers has joined #openstack-nova | 14:30 | |
*** ljxiash has joined #openstack-nova | 14:30 | |
*** jamespag` is now known as jamespage | 14:31 | |
*** RuiChen has quit IRC | 14:32 | |
*** larainema has quit IRC | 14:32 | |
*** yingjun has joined #openstack-nova | 14:32 | |
*** Kevin_Zheng has quit IRC | 14:34 | |
*** gouthamr has joined #openstack-nova | 14:34 | |
*** ljxiash has quit IRC | 14:34 | |
*** RuiChen has joined #openstack-nova | 14:34 | |
*** psachin has quit IRC | 14:34 | |
*** larainema has joined #openstack-nova | 14:35 | |
*** yingjun_ has quit IRC | 14:35 | |
*** gouthamr_ has quit IRC | 14:36 | |
*** yingjun has quit IRC | 14:37 | |
*** ralonsoh_ has joined #openstack-nova | 14:37 | |
*** yingjun has joined #openstack-nova | 14:37 | |
*** ralonsoh has quit IRC | 14:37 | |
*** Kevin_Zheng has joined #openstack-nova | 14:37 | |
sfinucan | mriedem: Sounds good, though I'm also fine to abandon mine if it's easier. You might +2 this too, if you have a chance, so we can move all the Pike specs across https://review.openstack.org/#/c/405407/ | 14:38 |
*** ralonsoh_ has quit IRC | 14:39 | |
*** ralonsoh_ has joined #openstack-nova | 14:39 | |
*** yingjun_ has joined #openstack-nova | 14:40 | |
*** jed56 has joined #openstack-nova | 14:40 | |
*** yingjun has quit IRC | 14:41 | |
*** jamesdenton has joined #openstack-nova | 14:43 | |
*** mlavalle has joined #openstack-nova | 14:46 | |
bauzas | sfinucan: heh, you beated me up :) | 14:46 |
bauzas | I was about to write that change | 14:47 |
*** duonghq has quit IRC | 14:48 | |
*** duonghq has joined #openstack-nova | 14:49 | |
edleafe | Dinesh_Bhor: ok, what would you like to discuss about that comment? | 14:49 |
*** duonghq has quit IRC | 14:49 | |
moshele | mriedem, johnthetubaguy: can I get some core review the "Enhance PCI passthrough whitelist to support regex" https://review.openstack.org/#/c/199488/ | 14:49 |
sdague | easy +A - https://review.openstack.org/#/c/401366/ - clarifies the guestfs permissions error | 14:50 |
*** duonghq_ has joined #openstack-nova | 14:50 | |
Dinesh_Bhor | edleafe: I can see this in the guidelines: If a request contains a reference to a nonexistent resource in the body (not URI), the code should be 400 Bad Request. ......... | 14:50 |
*** jvgrant has quit IRC | 14:50 | |
*** jvgrant has joined #openstack-nova | 14:50 | |
moshele | mriedem: also I just send a mail to do bi-weekly SR-IOV meeting | 14:50 |
*** esberglu_ has quit IRC | 14:51 | |
sdague | mriedem / dansmith - for https://review.openstack.org/#/c/393441/2/projects/60_nova/from-newton/upgrade-nova is there a way know if we need to rebuild those dbs (because you could run with them already configured in newton in devstack) | 14:51 |
*** esberglu has joined #openstack-nova | 14:51 | |
sdague | or is that not until the new nova-manage ready-for-upgrade command shows up? | 14:51 |
mriedem | sdague: those commands are idempotent | 14:52 |
edleafe | Dinesh_Bhor: will you be available in a little over an hour for the API WG meeting? | 14:52 |
mriedem | if you setup cells v2 in newton, simple_cell_setup is a noop | 14:52 |
edleafe | Dinesh_Bhor: We could discuss this there | 14:53 |
*** code-R_ has quit IRC | 14:53 | |
edleafe | Dinesh_Bhor: I'll have to look over the individual code changes before then | 14:53 |
Dinesh_Bhor | edleafe: ok, yes sure | 14:53 |
*** code-R has joined #openstack-nova | 14:53 | |
sdague | mriedem: not the recreate_database - https://github.com/openstack-dev/devstack/blob/1c13be860ba3662bf6c633fc37668f7feacdd3e5/lib/databases/mysql#L55-L59 | 14:53 |
mriedem | sdague: yeah was just going to say that | 14:54 |
*** pabardina has joined #openstack-nova | 14:54 | |
dansmith | I'm not sure what that recreate step is | 14:55 |
dansmith | related to cells I mean | 14:55 |
mriedem | sdague: so, | 14:55 |
edleafe | Dinesh_Bhor: 1600 UTC in #openstack-meeting-3 | 14:55 |
mriedem | nova_api_cell0 would be recreated, yes, | 14:55 |
dansmith | oh it's just create | 14:55 |
mriedem | sdague: however, we don't actually populate it in newton | 14:55 |
*** esberglu has quit IRC | 14:55 | |
mriedem | so we're just dropping an empty db and creating a new empty db | 14:56 |
sdague | mriedem: ok | 14:56 |
dansmith | mriedem: wha? | 14:56 |
dansmith | no | 14:56 |
mriedem | dansmith: we don't send anything to cell0 in newton | 14:56 |
dansmith | oh that's just cell0' | 14:56 |
dansmith | I thought you meant api db | 14:56 |
mriedem | fudge naw | 14:56 |
dansmith | okay | 14:56 |
*** tblakes has quit IRC | 14:57 | |
pabardina | Hello, I'm trying to get custom metadata of an image with ImageMetaProps, but I can't get it, someone know how to get it ? | 14:57 |
*** takashin has left #openstack-nova | 14:57 | |
mriedem | pabardina: if it's not registered in the object it's not going to be stored | 14:58 |
sdague | ok, I'm good with it, +2 | 14:58 |
Dinesh_Bhor | edleafe: yes, I will be there | 14:58 |
sdague | I might throw some more detailed comments in a follow on commit for that | 14:58 |
sdague | dansmith: feel free to land that whenever you are ready | 14:58 |
edleafe | Dinesh_Bhor: ok, looking at the code examples, I'm already starting to change my mind | 14:58 |
pabardina | mriedem: so it's not possible to get custom metadata of a glance image with it ? | 14:59 |
edleafe | Dinesh_Bhor: as they all are related resources, and not the resource being acted upon | 14:59 |
*** ekuris has quit IRC | 14:59 | |
dansmith | sdague: cool thanks | 14:59 |
mriedem | pabardina: no | 14:59 |
mriedem | pabardina: because if it's not registered in there, nova doesn't know how to deal with it anyway | 14:59 |
edleafe | Dinesh_Bhor: But I'd like to hear what the others have to say. | 14:59 |
*** ducttape_ has joined #openstack-nova | 14:59 | |
mriedem | pabardina: unless of course you have out of tree code that handles your custom image meta, | 14:59 |
mriedem | but in that case you've already forked nova and would need to also fork that image meta object | 15:00 |
mriedem | to register your custom image meta property | 15:00 |
*** daemontool has joined #openstack-nova | 15:00 | |
*** ljxiash has joined #openstack-nova | 15:00 | |
*** unicell has joined #openstack-nova | 15:00 | |
*** anush has joined #openstack-nova | 15:00 | |
openstackgerrit | Sean Dague proposed openstack/nova: guestfs: Don't report exception if there's read access to kernel https://review.openstack.org/401366 | 15:00 |
pabardina | mriedem: oh... | 15:00 |
mriedem | pabardina: flavor extra specs is still an untamable wild west of garbage so you can throw whatever you want in there | 15:00 |
sdague | mriedem: quick update to ^^^, as I realized I suggested terible permissions there | 15:01 |
Dinesh_Bhor | edleafe: yah, sure. | 15:01 |
sdague | it should be 0x644, not 666 | 15:01 |
*** links has quit IRC | 15:01 | |
edleafe | Dinesh_Bhor: added it to the agenda | 15:01 |
mriedem | satan wants access to your kernel too | 15:01 |
*** baoli has joined #openstack-nova | 15:01 | |
pabardina | mriedem: that's weird, in Juno I am able to get my custom propriety (i'm working on a custom AggregateInstanceExtraSpecsFilter ) So since this patch, it's not possible anymore https://github.com/openstack/nova/commit/8dc10920728ba721304e46e914fa859ac816909c | 15:03 |
*** faizy has joined #openstack-nova | 15:03 | |
mriedem | pabardina: because that change changes from the dict to the request spec object, which has an image meta object, which restricts the known set of supported image meta properties | 15:04 |
*** ljxiash has quit IRC | 15:04 | |
*** unicell has quit IRC | 15:04 | |
pabardina | mriedem: so i'm fucked :D | 15:05 |
mriedem | well, | 15:06 |
mriedem | as i said, you can modify ImageMetaProps | 15:06 |
mriedem | and register your snowflake, | 15:06 |
mriedem | but then you have to adjust the version and deal with maintaining that | 15:06 |
mriedem | it's essentially making an rpc version change | 15:06 |
mriedem | sfinucan: something is up with the template link here http://docs-draft.openstack.org/07/405407/1/check/gate-nova-specs-docs-ubuntu-xenial/15b62af//doc/build/html/specs/pike/index.html | 15:07 |
pabardina | mriedem: ok... thanks :) | 15:07 |
sfinucan | mriedem: looking | 15:07 |
mriedem | dansmith: commented in https://review.openstack.org/#/c/404950/ - we're already doing what you added | 15:08 |
mriedem | which is maybe why you were surprised things weren't busted in the commit message? | 15:08 |
dansmith | lol | 15:08 |
*** jaosorior has quit IRC | 15:09 | |
dansmith | mriedem: I just threw that in my series because it seemed like it wasn't getting reset, slammed it to the front and forgot about it | 15:09 |
*** pradk has joined #openstack-nova | 15:09 | |
*** jaosorior has joined #openstack-nova | 15:09 | |
dansmith | then I just pushed my whole stack up before the cells meeting yesterday | 15:09 |
*** anush has quit IRC | 15:10 | |
*** rfolco has joined #openstack-nova | 15:10 | |
*** pabardina has quit IRC | 15:11 | |
dansmith | not sure that ordering should matter, but lemme check | 15:11 |
*** jaypipes has joined #openstack-nova | 15:11 | |
dansmith | there's so much going on in the last patch it's kinda hard to keep track of things | 15:11 |
*** code-R_ has joined #openstack-nova | 15:12 | |
*** zz_dimtruck is now known as dimtruck | 15:12 | |
*** stevemar__ has quit IRC | 15:12 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs: Create specs directory for Pike https://review.openstack.org/405407 | 15:13 |
sfinucan | mriedem: ^ misnamed symlink - should be good now | 15:14 |
*** esberglu has joined #openstack-nova | 15:15 | |
*** code-R has quit IRC | 15:15 | |
*** esberglu has quit IRC | 15:15 | |
*** esberglu has joined #openstack-nova | 15:16 | |
mriedem | wznoinsk: looks like intel nfv multinode ci is failing pretty hard http://intel-openstack-ci-logs.ovh/65/396965/4/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/bb418a0/console.html | 15:16 |
mriedem | on totally unrelated things | 15:16 |
mriedem | wznoinsk: can we make that non-voting until it's stable? | 15:16 |
*** jamesdenton has quit IRC | 15:16 | |
*** jamesdenton has joined #openstack-nova | 15:18 | |
openstackgerrit | Diana Clarke proposed openstack/nova: Simple tenant usage pagination https://review.openstack.org/386093 | 15:19 |
openstackgerrit | Diana Clarke proposed openstack/python-novaclient: Microversion 2.39 - Simple tenant usage pagination https://review.openstack.org/394653 | 15:19 |
*** sreeram_v has quit IRC | 15:19 | |
*** nicodemus_ has joined #openstack-nova | 15:19 | |
diana_clarke | ^ I think those are ready for real review now. | 15:20 |
nicodemus_ | hello | 15:20 |
*** liverpooler has joined #openstack-nova | 15:20 | |
diana_clarke | (and I'm going to do some more manual testing against devstack in the mean time) | 15:20 |
*** oanson has joined #openstack-nova | 15:21 | |
*** ljxiash has joined #openstack-nova | 15:21 | |
*** kaisers_ has joined #openstack-nova | 15:21 | |
nicodemus_ | is it possible to make nova-compute on a specific compute node to put its notifications on an exclusive notifications queue? I'm trying to have two compute nodes to write its notifications on different queues (using Kilo) | 15:21 |
*** stevemar has joined #openstack-nova | 15:21 | |
diana_clarke | mriedem: When you get a chance, can you please remove the -1 workflow from this: https://review.openstack.org/#/c/403928/ No rush. Thanks! | 15:22 |
jaypipes | dansmith, bauzas: your eyeballs on this series would be most appreciated :) https://review.openstack.org/#/c/391918/ | 15:23 |
*** gjayavelu has joined #openstack-nova | 15:23 | |
bauzas | jaypipes: yup, we discussed about that during the nova meeting today :) | 15:23 |
mriedem | diana_clarke: i'll raise you a +W | 15:24 |
diana_clarke | mriedem: Nice, you're best! | 15:24 |
mriedem | nicodemus_: that support was added after kilo | 15:25 |
mriedem | nicodemus_: it's an oslo.messaging feature, i think added in mitaka? | 15:25 |
jaypipes | mdbooth: so, can you go ahead and fix the _disk_resize mock thing that melwitt pointed out on https://review.openstack.org/#/c/337159/ | 15:25 |
*** dave-mccowan has joined #openstack-nova | 15:25 | |
jaypipes | mdbooth: fix that up, rebase it and me and another core will push through that whole series today. | 15:25 |
nicodemus_ | mriedem, crud... I tried changing the "rabbit_notification_topic" under [oslo_messaging_rabbit] to no avail :( | 15:25 |
*** tblakes has joined #openstack-nova | 15:26 | |
nicodemus_ | mriedem, thanks for you quick reply! | 15:26 |
jaypipes | mdbooth: I can work with sdague or mriedem if they're up to it. | 15:26 |
mriedem | nicodemus_: i'm not seeing the oslo spec for it, so you'll probably need to ask in #openstack-oslo, i know rlrossit worked on it | 15:27 |
*** ljxiash has quit IRC | 15:27 | |
nicodemus_ | mriedem, cool. Thanks again! | 15:27 |
*** moshele has quit IRC | 15:27 | |
*** liverpooler has quit IRC | 15:27 | |
*** kaisers_ has quit IRC | 15:29 | |
*** stevemar_znc has joined #openstack-nova | 15:29 | |
*** claudiub|2 has joined #openstack-nova | 15:29 | |
*** liverpooler has joined #openstack-nova | 15:29 | |
sahid | sfinucan: interesting review: https://review.openstack.org/#/c/400875/ you -1 a patch because you -1ed the previous one... :/ | 15:30 |
mriedem | sahid: the -1 was lost in a rebase | 15:30 |
bauzas | sahid: why is it a problem ? | 15:31 |
mriedem | so the -1 is just to not lose the comments from the previous -1 | 15:31 |
*** dimtruck is now known as zz_dimtruck | 15:31 | |
bauzas | sahid: it's totally fine to say that IMHO | 15:31 |
*** hoobaman has joined #openstack-nova | 15:31 | |
hoobaman | hi | 15:31 |
hoobaman | i am using keystone v3 and admin inheretance | 15:31 |
jaypipes | bauzas: yeah, sorry I missed the meeting :( | 15:31 |
*** gjayavelu has quit IRC | 15:31 | |
hoobaman | however this gives issues when using nova boot with OS_TENANT_NAME=$project | 15:31 |
sahid | sfinucan, mriedem yes sorry my mistake | 15:31 |
jaypipes | hoobaman: please see /topic :) for usage questions, please post to the openstack@ mailing list or ask on #openstack channel. | 15:32 |
bauzas | sahid: I don't see why it could be a problem, given it's understandable to miss some comments when rebasing | 15:32 |
hoobaman | ok my bad, sorry guys | 15:32 |
jaypipes | hoobaman: no worries :) | 15:32 |
mriedem | bauzas: i think it was just a misunderstanding | 15:32 |
*** jgriffith_away is now known as jgriffith | 15:32 | |
bauzas | exactly | 15:32 |
sahid | i thought you -1ed one for the previous patchset | 15:33 |
sahid | but yes it's me :) | 15:33 |
*** mtanino has joined #openstack-nova | 15:33 | |
kashyap | ihrachys: Also the nuisance of permissions for KVM character device for Debian is tracked here -- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640328 | 15:33 |
openstack | Debian bug 640328 in qemu-kvm "kvm: Please make /dev/kvm world-accessible in 60-qemu-kvm.rules" [Wishlist,Open] | 15:33 |
*** cmartin has joined #openstack-nova | 15:34 | |
ihrachys | kashyap: thanks a lot. I will redirect the links to the person looking into setting the job | 15:35 |
ihrachys | I think it's enough of a clue to dig | 15:35 |
*** READ10 has joined #openstack-nova | 15:35 | |
kashyap | It's just the whole security theatre that annoying as hell | 15:35 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: make _filter_hypervisor_macs use objects https://review.openstack.org/405451 | 15:35 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: create fake ordered_nets for get_instance_nw_info https://review.openstack.org/405452 | 15:35 |
mdbooth | jaypipes: okie dokey. Thanks. | 15:35 |
*** mdnadeem has joined #openstack-nova | 15:35 | |
kashyap | ihrachys: "Oh letting users have access to /dev/kvm will cause 'security bugs' because...it's kernel". There's no evidence of that nonsense | 15:36 |
*** anush has joined #openstack-nova | 15:36 | |
mriedem | time for my quarterly haircut, back in an hour or so | 15:39 |
*** mriedem is now known as mriedem_beauty | 15:39 | |
*** jheroux has joined #openstack-nova | 15:40 | |
*** code-R_ has quit IRC | 15:40 | |
*** zz_dimtruck is now known as dimtruck | 15:40 | |
*** code-R has joined #openstack-nova | 15:40 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: WIP: [proxy-api] microversion 2.39 deprecates image-metadata proxy API https://review.openstack.org/405461 | 15:44 |
jaypipes | _gryf: hey, if you're looking for stuff to do, I wouldn't mind you fixing up https://review.openstack.org/384807's nit and release note error if you have time. | 15:44 |
*** sridharg has quit IRC | 15:44 | |
_gryf | jaypipes, yup, I'll do that | 15:44 |
jaypipes | _gryf: cheers Roman | 15:44 |
_gryf | jaypipes, np Jay | 15:45 |
*** jvgrant has quit IRC | 15:46 | |
*** dims has quit IRC | 15:46 | |
*** sandanar has quit IRC | 15:46 | |
*** jvgrant has joined #openstack-nova | 15:47 | |
pkholkin | alex_xu: mriedem_beauty: hey folks, I've started working on the implementation, this seems to be the main part of the code (tested on devstack), feel free to review if you have time - wip patch https://review.openstack.org/#/c/405461 | 15:47 |
*** links has joined #openstack-nova | 15:48 | |
*** jwcroppe has quit IRC | 15:49 | |
cmartin | Hey I have had this patch up for almost two months. It basically fixes a bug with soft-delete by making instances that were soft deleted not release their quotas until they are ACTUALLY deleted. Would love some reviews if anybody has time https://review.openstack.org/#/c/386756/1 | 15:51 |
*** yingjun_ has quit IRC | 15:51 | |
sdague | jaypipes / mriedem_beauty / mdbooth - we decided on including ddt for sure? - https://review.openstack.org/#/c/339114/13 - I don't love it, but if others are all on board I'll +2 | 15:53 |
*** cdent has joined #openstack-nova | 15:53 | |
sdague | oh, there is a commit message to that regard | 15:53 |
sdague | got it | 15:53 |
*** yingjun has joined #openstack-nova | 15:54 | |
*** larainema has quit IRC | 15:54 | |
mdbooth | sdague: FWIW I *really* like the test name munging | 15:54 |
mdbooth | What's the other one? testresources? | 15:54 |
mdbooth | Something like that | 15:54 |
sdague | testscenarios | 15:54 |
mdbooth | Anyway, it doesn't do it | 15:54 |
*** Kevin_Zheng has quit IRC | 15:54 | |
mdbooth | Which means you can run a single test in isolation | 15:55 |
* mdbooth uses this all the time: | 15:55 | |
mdbooth | function testone() { | 15:55 |
mdbooth | .tox/py27/bin/python -m testtools.run "$@" | 15:55 |
mdbooth | } | 15:55 |
mdbooth | It doesn't work with testscenarios, but it works with ddt | 15:55 |
sdague | hmmmm, I'm pretty sure that works with scenarios | 15:55 |
sdague | because my emacs plugin pretty much does that | 15:56 |
*** larainema has joined #openstack-nova | 15:56 | |
mdbooth | sdague: That would be my only objection anyway, so if it's out of date I have none :) | 15:56 |
mdbooth | Regardless, ddt was pretty nice. | 15:56 |
dansmith | sdague: I don't love it, fwiw | 15:56 |
jaypipes | sdague: yeah.. | 15:57 |
sdague | yeh, it's fine, it looks like the decision was made. I just wanted to double check that before approving | 15:57 |
*** Kevin_Zheng has joined #openstack-nova | 15:57 | |
*** code-R_ has joined #openstack-nova | 16:00 | |
*** liverpooler has quit IRC | 16:00 | |
*** dims has joined #openstack-nova | 16:00 | |
*** hongbin has joined #openstack-nova | 16:00 | |
jaypipes | dansmith: your final word on https://review.openstack.org/#/c/386710/ would also be appreciated (nested resource providers spec) | 16:01 |
*** armax has joined #openstack-nova | 16:01 | |
*** liverpooler has joined #openstack-nova | 16:01 | |
*** mdrabe has quit IRC | 16:01 | |
*** Kevin_Zheng has quit IRC | 16:02 | |
*** code-R has quit IRC | 16:02 | |
*** dave-mccowan has quit IRC | 16:02 | |
*** nic has joined #openstack-nova | 16:03 | |
dansmith | jaypipes: I will look when I'm done with my current thing | 16:03 |
*** Kevin_Zheng has joined #openstack-nova | 16:04 | |
jaypipes | dansmith: danke | 16:05 |
sdague | jaypipes: super easy thing to make the libguestfs errors more correct and informative - https://review.openstack.org/#/c/401366/4 | 16:05 |
*** voelzmo has quit IRC | 16:05 | |
*** nic has quit IRC | 16:08 | |
*** stevemar_znc is now known as topol_ | 16:12 | |
*** mdrabe has joined #openstack-nova | 16:13 | |
*** rcernin has quit IRC | 16:13 | |
*** jwcroppe has joined #openstack-nova | 16:15 | |
*** dave-mccowan has joined #openstack-nova | 16:16 | |
*** annegentle has joined #openstack-nova | 16:18 | |
openstackgerrit | Gábor Antal proposed openstack/nova: Remove mox in unit/cells/test_cells_manager.py https://review.openstack.org/399036 | 16:19 |
*** tbachman has quit IRC | 16:19 | |
*** mdnadeem has quit IRC | 16:19 | |
*** topol_ is now known as topol | 16:20 | |
jaypipes | sdague: done | 16:21 |
dansmith | johnthetubaguy: still around? | 16:23 |
johnthetubaguy | dansmith: yes | 16:23 |
dansmith | johnthetubaguy: are you cool with jay's nested spec? I don't think I've ever really been through that fully and you have | 16:23 |
dansmith | johnthetubaguy: might be better for you to be the +w on there instead of me trying to cram in a skim | 16:23 |
*** rmart04 has quit IRC | 16:25 | |
*** markus_z has quit IRC | 16:26 | |
*** kaisers_ has joined #openstack-nova | 16:26 | |
johnthetubaguy | dansmith: oh, good question, I was close on that, I will take a peak | 16:28 |
dansmith | johnthetubaguy: maybe take a peek too while you're at it | 16:28 |
johnthetubaguy | yeah, both of those :) | 16:28 |
dansmith | it's good to be thorough | 16:29 |
* johnthetubaguy stands on tip toes | 16:29 | |
openstackgerrit | Sujitha proposed openstack/nova: Allow finding instance with invalid regex name https://review.openstack.org/392305 | 16:29 |
*** jaosorior has quit IRC | 16:30 | |
*** asettle has left #openstack-nova | 16:31 | |
*** bvanhav_ has quit IRC | 16:34 | |
*** kaisers_ has quit IRC | 16:35 | |
*** liverpooler has quit IRC | 16:35 | |
*** bvanhav_ has joined #openstack-nova | 16:35 | |
*** mjura has quit IRC | 16:38 | |
*** paul-carlton2 has quit IRC | 16:39 | |
*** browne has joined #openstack-nova | 16:40 | |
*** siva_krish has joined #openstack-nova | 16:41 | |
*** jbernard has quit IRC | 16:41 | |
*** jbernard has joined #openstack-nova | 16:42 | |
*** danpawlik has quit IRC | 16:43 | |
*** dave-mccowan has quit IRC | 16:46 | |
*** aarefiev is now known as aarefiev_afk | 16:46 | |
pkholkin | bauzas: hi, do you have time to think about AggregateImagePropertiesIsolation? | 16:47 |
*** josecastroleon1 has quit IRC | 16:48 | |
*** yingjun has quit IRC | 16:48 | |
*** yingjun has joined #openstack-nova | 16:48 | |
*** tbachman has joined #openstack-nova | 16:48 | |
*** rcernin has joined #openstack-nova | 16:50 | |
johnthetubaguy | jaypipes: on that nested spec, I think you want SRIOV_NET_VF (and _PF) resources to live in a child resource provider of the NUMA node | 16:51 |
*** ayogi has quit IRC | 16:51 | |
johnthetubaguy | jaypipes: but we can totally leave that for the code to sort out | 16:51 |
*** links has quit IRC | 16:53 | |
*** mriedem_beauty is now known as mriedem | 16:53 | |
*** yingjun has quit IRC | 16:53 | |
*** links has joined #openstack-nova | 16:53 | |
*** moshele has joined #openstack-nova | 16:53 | |
*** andreas_s has quit IRC | 16:54 | |
*** nic has joined #openstack-nova | 16:55 | |
*** tbachman_ has joined #openstack-nova | 16:55 | |
*** tbachman has quit IRC | 16:56 | |
*** tbachman_ is now known as tbachman | 16:56 | |
*** dave-mccowan has joined #openstack-nova | 16:56 | |
*** unicell has joined #openstack-nova | 16:56 | |
*** edmondsw has quit IRC | 16:59 | |
*** hoobaman has quit IRC | 16:59 | |
mriedem | ok we're all in on no n-net in master except cells v1 now https://review.openstack.org/#/c/403855/ | 17:00 |
*** matrohon has quit IRC | 17:02 | |
openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | 17:02 |
*** xinliang has quit IRC | 17:03 | |
johnthetubaguy | mriedem: amazing :) | 17:03 |
*** igordcard has joined #openstack-nova | 17:03 | |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Never copy a swap disk during cold migration https://review.openstack.org/331115 | 17:04 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Rename Backend snapshot and image https://review.openstack.org/333272 | 17:04 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Test disk creation in test_hard_reboot https://review.openstack.org/338993 | 17:04 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Cleanup test_create_configdrive https://review.openstack.org/339114 | 17:04 |
openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_attach notification https://review.openstack.org/401992 | 17:04 |
*** sudipto has quit IRC | 17:04 | |
*** sudipto_ has quit IRC | 17:04 | |
mriedem | pkholkin: looking | 17:05 |
johnthetubaguy | jaypipes: I read your comments, got my head straight on that now | 17:05 |
*** liverpooler has joined #openstack-nova | 17:06 | |
openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_attach notification https://review.openstack.org/401992 | 17:08 |
*** bvanhav_ has quit IRC | 17:08 | |
openstackgerrit | John Garbutt proposed openstack/nova: objects: Removes base code that already exists in o.vo https://review.openstack.org/307041 | 17:08 |
*** rama_y has joined #openstack-nova | 17:08 | |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Don't re-resize disks in finish_migration() https://review.openstack.org/331118 | 17:09 |
mdbooth | jaypipes: I've updated and re-pushed those 6 patches | 17:09 |
wznoinsk | mriedem, our multinode made nonvoting this morning GMT, thanks for pining | 17:10 |
*** Swami has joined #openstack-nova | 17:10 | |
wznoinsk | mriedem, re not running on docs changes, yes, we're on adding those conditions in zuul, this week | 17:11 |
mriedem | pkholkin: comments inline, it's a nice start | 17:12 |
mriedem | wznoinsk: thanks | 17:12 |
*** slaweq_ has quit IRC | 17:12 | |
*** sdatko has quit IRC | 17:13 | |
*** sdatko has joined #openstack-nova | 17:14 | |
pkholkin | mriedem: thanks Matt, will look! I needed some feedback to know that I'm on correct way) | 17:14 |
pkholkin | I'm also not sure in removing/or not quotas checks | 17:15 |
*** xinliang has joined #openstack-nova | 17:15 | |
mriedem | pkholkin: i think that's in the spec | 17:18 |
mriedem | yeah https://review.openstack.org/#/c/377528/4/specs/ocata/approved/deprecate-image-meta-proxy-api.rst@24 | 17:19 |
mriedem | basically just says we shouldn't enforce it in nova, let glance handle it | 17:19 |
mriedem | b/c glance makes the same quota check | 17:19 |
*** derekh has quit IRC | 17:20 | |
pkholkin | mriedem: answered to the comments | 17:21 |
jaypipes | mdbooth: awesome. will review shortly. | 17:22 |
pkholkin | yes, I found in in the spec, too, also in work items | 17:22 |
jaypipes | johnthetubaguy: cool, thanks! | 17:22 |
pkholkin | it* (removing checks) | 17:22 |
pkholkin | mriedem: tests will be done, of course | 17:23 |
pkholkin | mriedem: thanks for clarifying these moments! | 17:23 |
pkholkin | will continue | 17:23 |
mriedem | sure, np | 17:24 |
*** slaweq_ has joined #openstack-nova | 17:24 | |
mriedem | thanks for working it | 17:24 |
pkholkin | np! | 17:24 |
pkholkin | nice work item for me) | 17:24 |
cdent | mdbooth: is this the appropriate starting place for me to review your stack of many things? https://review.openstack.org/#/c/337159/ | 17:25 |
*** kylek3h has quit IRC | 17:25 | |
*** r0rg has joined #openstack-nova | 17:30 | |
*** liverpooler has quit IRC | 17:31 | |
*** bvanhav_ has joined #openstack-nova | 17:31 | |
*** liverpooler has joined #openstack-nova | 17:31 | |
r0rg | Asked in #openstack-dev, not sure if right place, so I'll ask here too - I am writing a simple custom filter for nova and am confused about how run_filter_once_per_request works when multiple instances are requested at once. I expected run_filter_once_per_request=False (the default) means my filter code gets called for every VM in the request, but my filter is only called once. Is that correct? | 17:31 |
*** kaisers_ has joined #openstack-nova | 17:32 | |
mriedem | sdague: dansmith: any takers? https://review.openstack.org/#/c/405407/ | 17:32 |
*** diogogmt has joined #openstack-nova | 17:34 | |
*** lucasagomes is now known as lucas-afk | 17:35 | |
*** penick has joined #openstack-nova | 17:37 | |
*** anush has quit IRC | 17:38 | |
*** kaisers_ has quit IRC | 17:39 | |
*** paul-carlton2 has joined #openstack-nova | 17:42 | |
*** nic has quit IRC | 17:43 | |
mriedem | jaypipes: small issues in https://review.openstack.org/#/c/400448/ | 17:43 |
*** sahid has quit IRC | 17:45 | |
*** browne has quit IRC | 17:47 | |
*** unicell has quit IRC | 17:47 | |
*** ayoung has quit IRC | 17:48 | |
*** slaweq_ has quit IRC | 17:48 | |
*** code-R_ has quit IRC | 17:52 | |
*** tblakes_ has joined #openstack-nova | 17:52 | |
*** code-R has joined #openstack-nova | 17:52 | |
*** kfarr has quit IRC | 17:53 | |
*** code-R has quit IRC | 17:53 | |
*** code-R has joined #openstack-nova | 17:54 | |
*** bkopilov has quit IRC | 17:54 | |
*** tblakes has quit IRC | 17:55 | |
*** tblakes_ is now known as tblakes | 17:55 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs: Remove templates from approved/implemented specs https://review.openstack.org/405550 | 17:55 |
*** paul-carlton2 has quit IRC | 17:55 | |
openstackgerrit | jichenjc proposed openstack/nova: Remove incorrect comments https://review.openstack.org/405551 | 17:56 |
*** claudiub|2 has quit IRC | 17:56 | |
sfinucan | I /think/ that's what you were looking for in the Pike template, mriedem? ^ | 17:56 |
mriedem | i think so, let's see how the docs turn out | 17:57 |
*** paul-carlton2 has joined #openstack-nova | 17:57 | |
*** bkopilov has joined #openstack-nova | 17:58 | |
*** _ducttape_ has joined #openstack-nova | 17:58 | |
*** siva_krish has quit IRC | 17:59 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: [WIP] Add service_token for nova-cinder interaction https://review.openstack.org/397399 | 18:00 |
*** smatzek has joined #openstack-nova | 18:00 | |
cardeois | Is there any core reviewer that would have time to +2 or workflow +1 this review? https://review.openstack.org/#/c/400785/ Well if agrees to it obviously | 18:00 |
openstackgerrit | jichenjc proposed openstack/nova: no instance info cache update if instance deleted https://review.openstack.org/363585 | 18:00 |
*** siva_krish has joined #openstack-nova | 18:01 | |
*** nic has joined #openstack-nova | 18:01 | |
*** ducttape_ has quit IRC | 18:02 | |
jaypipes | mriedem: k, will fix up shortly, thanks for the review! | 18:02 |
*** code-R has quit IRC | 18:04 | |
*** baoli has quit IRC | 18:05 | |
*** baoli has joined #openstack-nova | 18:05 | |
* mriedem goes to raid the fridge | 18:08 | |
*** ijw has joined #openstack-nova | 18:08 | |
*** ijw has quit IRC | 18:09 | |
*** yamahata has joined #openstack-nova | 18:09 | |
*** ijw has joined #openstack-nova | 18:10 | |
mriedem | sfinucan: https://review.openstack.org/#/c/405550/ looks good btw | 18:10 |
sfinucan | mriedem: Excellent. Happy fridge raiding | 18:10 |
*** ralonsoh_ has quit IRC | 18:13 | |
openstackgerrit | Roman Dobosz proposed openstack/nova: placement: adds REST API for nested providers https://review.openstack.org/384807 | 18:14 |
*** ijw has quit IRC | 18:15 | |
*** voelzmo has joined #openstack-nova | 18:15 | |
*** mvk has quit IRC | 18:17 | |
*** penick has quit IRC | 18:18 | |
*** morgan is now known as morgred | 18:20 | |
*** krtaylor has quit IRC | 18:20 | |
*** amoralej is now known as amoralej|off | 18:20 | |
*** morgred is now known as morgan | 18:21 | |
*** bvanhav__ has joined #openstack-nova | 18:22 | |
*** bvanhav_ has quit IRC | 18:22 | |
*** yamahata has quit IRC | 18:24 | |
*** penick has joined #openstack-nova | 18:24 | |
*** yamahata has joined #openstack-nova | 18:26 | |
*** r0rg has quit IRC | 18:27 | |
openstackgerrit | ayoung proposed openstack/nova: API Policy enforcement contingent on is_admin_project https://review.openstack.org/384148 | 18:28 |
*** faizy has quit IRC | 18:28 | |
*** nherciu has quit IRC | 18:29 | |
*** browne has joined #openstack-nova | 18:29 | |
*** liverpooler has quit IRC | 18:32 | |
*** liverpooler has joined #openstack-nova | 18:32 | |
*** mkoderer has quit IRC | 18:33 | |
*** cheran has joined #openstack-nova | 18:34 | |
*** kaisers_ has joined #openstack-nova | 18:36 | |
*** _ducttape_ has quit IRC | 18:38 | |
*** ducttape_ has joined #openstack-nova | 18:39 | |
*** gszasz has quit IRC | 18:39 | |
*** unicell has joined #openstack-nova | 18:41 | |
oomichi | alex_xu: re https://review.openstack.org/#/c/405118 , I feel we need more discussions before merging | 18:41 |
*** unicell1 has joined #openstack-nova | 18:42 | |
*** unicell has quit IRC | 18:42 | |
*** Apoorva has joined #openstack-nova | 18:42 | |
*** kaisers_ has quit IRC | 18:43 | |
*** voelzmo has quit IRC | 18:45 | |
*** jianghuaw has quit IRC | 18:47 | |
openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | 18:50 |
*** voelzmo has joined #openstack-nova | 18:50 | |
*** cdent has quit IRC | 18:50 | |
*** ijw has joined #openstack-nova | 18:50 | |
*** rama_y has quit IRC | 18:53 | |
*** paul-carlton2 has quit IRC | 18:53 | |
*** jianghuaw has joined #openstack-nova | 18:54 | |
*** baoli has quit IRC | 18:54 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: WIP: Resource tracker doesn't free resources on confirm resize https://review.openstack.org/405575 | 18:55 |
*** daemontool has quit IRC | 18:55 | |
lbeliveau | jaypipes: ^ the RT bug I told you about yesterday | 18:55 |
jaypipes | lbeliveau: ah, cheers. coding for a bit longer and will look into that later this afternoon. | 18:55 |
lbeliveau | jaypipes: np, thanks ! | 18:56 |
*** gjayavelu has joined #openstack-nova | 18:58 | |
*** dave-mccowan has quit IRC | 18:59 | |
*** rama_y has joined #openstack-nova | 19:01 | |
*** swamireddy has quit IRC | 19:05 | |
*** smatzek has quit IRC | 19:06 | |
*** ihrachys has quit IRC | 19:07 | |
*** penick has quit IRC | 19:07 | |
*** baoli has joined #openstack-nova | 19:09 | |
*** penick has joined #openstack-nova | 19:09 | |
*** tyrola has joined #openstack-nova | 19:12 | |
*** smatzek has joined #openstack-nova | 19:12 | |
*** xyang1 has joined #openstack-nova | 19:13 | |
*** mvk has joined #openstack-nova | 19:14 | |
jaypipes | _gryf: can you fix up mriedem's comments on https://review.openstack.org/#/c/391959/23/nova/api/openstack/placement/rest_api_version_history.rst? | 19:15 |
mriedem | jaypipes: i'm not done with that guy yet | 19:15 |
jaypipes | mriedem: ah, ok. | 19:15 |
*** prometheanfire has left #openstack-nova | 19:15 | |
mriedem | soon, soon... | 19:15 |
jaypipes | mriedem: _gryf was fixing up a couple things, so wanted to let him know... | 19:16 |
*** kaisers_ has joined #openstack-nova | 19:17 | |
mriedem | jaypipes: _gryf: done with the code part of the review, didn't do tests | 19:18 |
mriedem | found some other nuggests | 19:18 |
mriedem | *nuggets | 19:18 |
_gryf | jaypipes, mriedem putting that on my queue | 19:18 |
sdague | jaypipes: you going to rereview mdbooth's bottom patch right - https://review.openstack.org/#/c/337159 ? | 19:19 |
*** dgonzalez_ has joined #openstack-nova | 19:19 | |
*** voelzmo has quit IRC | 19:20 | |
*** voelzmo has joined #openstack-nova | 19:20 | |
jaypipes | sdague: yuup | 19:22 |
sdague | jaypipes: there is one other patch in the middle that you didn't yet have a +2 on | 19:23 |
sdague | but if you are good with that one too, there are I think 7 that will merge | 19:23 |
*** burt has joined #openstack-nova | 19:25 | |
*** swamireddy has joined #openstack-nova | 19:26 | |
*** matrohon has joined #openstack-nova | 19:26 | |
*** voelzmo has quit IRC | 19:27 | |
oomichi | alex_xu: I feel we don't need to support a little odd name of the config value on https://review.openstack.org/#/c/392077 | 19:27 |
*** david-lyle_ has joined #openstack-nova | 19:28 | |
*** gjayavelu has quit IRC | 19:30 | |
*** giri has joined #openstack-nova | 19:30 | |
openstackgerrit | Ludovic Beliveau proposed openstack/nova: Release PCI devices on drop_move_claim() https://review.openstack.org/370374 | 19:31 |
*** david-lyle has quit IRC | 19:31 | |
*** openstackgerrit has quit IRC | 19:32 | |
*** openstackgerrit has joined #openstack-nova | 19:33 | |
*** openstackgerrit has quit IRC | 19:36 | |
*** tyrola has quit IRC | 19:37 | |
*** voelzmo has joined #openstack-nova | 19:37 | |
oomichi | alex_xu: https://review.openstack.org/#/c/385212 is super easy for you | 19:38 |
*** voelzmo has quit IRC | 19:39 | |
*** voelzmo has joined #openstack-nova | 19:40 | |
*** krtaylor has joined #openstack-nova | 19:40 | |
*** dave-mccowan has joined #openstack-nova | 19:41 | |
*** rfolco has quit IRC | 19:42 | |
*** voelzmo has quit IRC | 19:44 | |
*** kylek3h has joined #openstack-nova | 19:46 | |
*** jed56 has quit IRC | 19:47 | |
*** josecastroleon has joined #openstack-nova | 19:49 | |
*** openstackgerrit has joined #openstack-nova | 19:51 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: remove deprecated ironic options https://review.openstack.org/405597 | 19:51 |
*** jamielennox|away is now known as jamielennox | 19:53 | |
*** josecastroleon has quit IRC | 19:53 | |
*** baoli has quit IRC | 19:54 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: remove deprecated nova quota options https://review.openstack.org/395706 | 19:57 |
*** dane-fichter has joined #openstack-nova | 19:59 | |
*** baoli has joined #openstack-nova | 20:00 | |
*** david-lyle_ is now known as david-lyle | 20:01 | |
mriedem | dane-fichter: see my reply in https://review.openstack.org/#/c/383293/ about post-config, you were asking as i was looking it up too | 20:03 |
mriedem | dane-fichter: would have to ask sdague details on how to do that in a ci job though... | 20:03 |
dane-fichter | mriedem: Im reading your response right now | 20:03 |
mriedem | alternatively, the barbican devstack plugin could maybe set this | 20:04 |
mriedem | when configuring nova | 20:04 |
dane-fichter | tempest plugins can't configure services as far as I can tell | 20:04 |
dane-fichter | tempest discovers plugins which are installed, grabs their tests and runs them | 20:05 |
mriedem | like https://review.openstack.org/#/c/375079/8/devstack/plugin.sh@61 | 20:05 |
dane-fichter | but I believe the plugin can only access tempest's config | 20:05 |
mriedem | it's not the tempest plugin, | 20:05 |
mriedem | it's the devstack plugin | 20:05 |
dane-fichter | mriedem: how would the barbican plugin know whether the user wants signed images turned on in nova | 20:06 |
mriedem | same logic if you want, could just use a flag | 20:06 |
dane-fichter | just because you're using barbican doesn't mean you want signed images turned on | 20:06 |
mriedem | the flag has to be set by the job that runs this stuff | 20:06 |
mriedem | otherwise figure out how to pass post-config through from devstack-gate to devstack, which is going to require talking to sdague | 20:07 |
dane-fichter | sounds like we've decided that configuring nova via an env variable is unacceptable to devstack folks | 20:07 |
dane-fichter | so we're just pushing it into barbican to get it accepted | 20:07 |
jaypipes | sdague: yeah, I'll get to mdbooth's series in just a little bit. still running tests on a local patch I'm working | 20:08 |
mriedem | well, i think to use post-config in a job is going to require this https://review.openstack.org/#/c/326585/ and it's dependencies to get merged | 20:08 |
*** links has quit IRC | 20:09 | |
*** Guest80606 has quit IRC | 20:10 | |
dane-fichter | mriedem: we still have a number of patches that need to land (and we likely have to create a new project for our tempest plugin) so I'm not in a huge hurry on this nova.conf change | 20:11 |
*** tyrola has joined #openstack-nova | 20:11 | |
dane-fichter | I'd rather have a "sanctioned" way to set nova.conf options for the job than hack something into barbican's devstack plugin | 20:12 |
*** tyrola_ has joined #openstack-nova | 20:16 | |
*** sreeram_v has joined #openstack-nova | 20:20 | |
mriedem | sean-k-mooney: can you confirm my question in here? https://review.openstack.org/#/c/402097/1/nova/virt/libvirt/vif.py | 20:20 |
sean-k-mooney | mriedem: looking at it now | 20:21 |
sean-k-mooney | mriedem: so yes i did not add the host=none to them since they wont be called that way | 20:22 |
mriedem | cool | 20:22 |
mriedem | just wanted to make sure | 20:22 |
*** owalsh_ has joined #openstack-nova | 20:23 | |
sean-k-mooney | im commenting to the same effect on the patch now to keep track of that also | 20:23 |
*** owalsh has quit IRC | 20:25 | |
*** sreeram_v has quit IRC | 20:25 | |
*** dane-fichter has quit IRC | 20:26 | |
mriedem | sean-k-mooney: missing a unit test case in https://review.openstack.org/#/c/334048/ | 20:27 |
*** bvanhav__ has quit IRC | 20:27 | |
mriedem | after that i'm +2 there also | 20:27 |
sean-k-mooney | mriedem: oh ok for the new check. yes i can add that | 20:28 |
*** READ10 has quit IRC | 20:29 | |
sean-k-mooney | mriedem: would it be better to move the new check into designer.set_vif_host_backend_vhostuser_config or will i just leave it as is | 20:29 |
*** ihrachys has joined #openstack-nova | 20:29 | |
mriedem | i'd just leave it where it is | 20:30 |
mriedem | danpb told me once he wanted to kill the designer module | 20:30 |
mriedem | and while the duplication kind of sucks, i think eventually we get to drop the non-os-vif parts of vif.py | 20:30 |
mriedem | we could always move that common code to a private shared method. when i was originally reviewing the base change from dan for this stuff there was some duplication and he said he didn't want to make common methods for the old and new stuff to use b/c eventually we'd drop the old. | 20:31 |
mriedem | so that's my mindset on this code going forward | 20:31 |
sean-k-mooney | ok cool. ya that makes sense. once all non os-vif pluging is move to os-vif we dont need the old code anymoer | 20:31 |
mriedem | it also means less for me to review the diff in PS9 and the faster we can get this merged :) | 20:31 |
sean-k-mooney | yep it would be nice to get this merged sooner rather then later. ill make that change and upload again tonight or tommorw | 20:32 |
sean-k-mooney | ie just the unit test | 20:32 |
*** catinthe_ has quit IRC | 20:34 | |
*** matrohon has quit IRC | 20:34 | |
*** voelzmo has joined #openstack-nova | 20:35 | |
openstackgerrit | ayoung proposed openstack/nova: API Policy enforcement contingent on is_admin_project https://review.openstack.org/384148 | 20:36 |
*** giri has quit IRC | 20:36 | |
*** ijw_ has joined #openstack-nova | 20:37 | |
*** unicell1 has quit IRC | 20:38 | |
*** ijw has quit IRC | 20:41 | |
*** openstack has joined #openstack-nova | 20:44 | |
*** pradk has joined #openstack-nova | 20:46 | |
*** siva_krish has quit IRC | 20:51 | |
*** tyrola_ has quit IRC | 20:51 | |
*** lpetrut has joined #openstack-nova | 20:52 | |
*** owalsh_ is now known as owalsh | 20:56 | |
*** siva_krish has joined #openstack-nova | 20:58 | |
*** lpetrut has quit IRC | 20:58 | |
*** annegentle has quit IRC | 20:59 | |
*** penick has quit IRC | 21:01 | |
*** toure is now known as toure|gone | 21:04 | |
*** toure|gone is now known as toure|biab | 21:04 | |
*** penick has joined #openstack-nova | 21:05 | |
*** jwcroppe has quit IRC | 21:07 | |
*** jwcroppe has joined #openstack-nova | 21:07 | |
*** voelzmo has quit IRC | 21:08 | |
*** pradk has quit IRC | 21:08 | |
*** liverpooler has quit IRC | 21:08 | |
*** rtheis has quit IRC | 21:09 | |
*** pradk has joined #openstack-nova | 21:09 | |
*** rcernin has quit IRC | 21:10 | |
*** ihrachys has quit IRC | 21:11 | |
*** jwcroppe_ has joined #openstack-nova | 21:11 | |
*** jwcroppe has quit IRC | 21:12 | |
*** gjayavelu has joined #openstack-nova | 21:12 | |
*** jwcroppe_ has quit IRC | 21:16 | |
cfriesen_ | already support --file and --meta | 21:16 |
cfriesen_ | whoops...got cut off somehow. Has anyone considered adding a "--user-data" option to the rebuild operation? we already support --file and --meta | 21:17 |
melwitt | cfriesen_: for what purpose? to change user data after initial boot? the original user data will be used upon a rebuild already, I think | 21:19 |
*** Apoorva_ has joined #openstack-nova | 21:21 | |
*** Apoorva has quit IRC | 21:21 | |
*** TravT has quit IRC | 21:21 | |
*** jwcroppe has joined #openstack-nova | 21:21 | |
cfriesen_ | melwitt: the requested use-case is to rebuild with different user-data | 21:21 |
cfriesen_ | melwitt: given that we can currently rebuild with different --file and --meta options | 21:21 |
melwitt | I see. I don't recall if anyone has discussed adding it before | 21:23 |
*** hamzy has quit IRC | 21:23 | |
*** zzelle has joined #openstack-nova | 21:24 | |
zzelle | browne, hi | 21:27 |
*** zzelle has quit IRC | 21:27 | |
*** pradk has quit IRC | 21:28 | |
*** smatzek has quit IRC | 21:28 | |
*** pradk has joined #openstack-nova | 21:28 | |
*** kaisers_ has quit IRC | 21:29 | |
*** siva_krish has quit IRC | 21:30 | |
jaypipes | anyone else noticing a "fake/" directory showing up after running tests locally now? | 21:32 |
sdague | jaypipes: that is probably a missing fixture for something that does imagecache testing | 21:33 |
sdague | when I was narrowing down issues like that before, I'd make the directory 000 and run the tests and see what failed | 21:34 |
*** Jeffrey4l_ has quit IRC | 21:34 | |
*** siva_krish has joined #openstack-nova | 21:35 | |
*** moshele has quit IRC | 21:37 | |
*** Jeffrey4l_ has joined #openstack-nova | 21:37 | |
*** bdeschenes has joined #openstack-nova | 21:39 | |
*** dimtruck is now known as zz_dimtruck | 21:41 | |
*** nicodemus_ has quit IRC | 21:44 | |
*** diogogmt has quit IRC | 21:45 | |
*** jwcroppe has quit IRC | 21:46 | |
jaypipes | sdague: good idea. will look into it... | 21:46 |
*** jwcroppe has joined #openstack-nova | 21:47 | |
*** oanson has quit IRC | 21:49 | |
*** jwcroppe_ has joined #openstack-nova | 21:50 | |
*** jwcroppe has quit IRC | 21:51 | |
*** cdent has joined #openstack-nova | 21:51 | |
jaypipes | sdague: k, bottom 6 patches of mdbooth's series are off to the sarlacc pits. | 21:52 |
*** baoli has quit IRC | 21:53 | |
*** ihrachys has joined #openstack-nova | 21:54 | |
cdent | sweet balm for sore eyes | 21:55 |
*** krtaylor has quit IRC | 21:56 | |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs: Document review priorities for Ocata https://review.openstack.org/404456 | 21:58 |
mriedem | bauzas: jaypipes: sdague: johnthetubaguy: melwitt: cdent: alex_xu: Kevin_Zheng: ^ would like to make sure i didn't misrepresent anything in there | 21:58 |
sdague | mriedem: ok, I'll look in the morning, I need to get started on dinner | 21:58 |
*** kaisers_ has joined #openstack-nova | 21:59 | |
mriedem | sfinucan: ^ i decided to flesh my version out because it has a bit more background on each item, because i expect non-nova-devs to look at that and need more info - plus it's eventually what i use for the foundation marketing thingy i have to do each release :( | 21:59 |
bauzas | mriedem: okay, I'll look at it | 21:59 |
openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | 22:01 |
cdent | yay, more reading material | 22:01 |
*** smatzek has joined #openstack-nova | 22:01 | |
*** annegentle has joined #openstack-nova | 22:01 | |
mriedem | cdent: you're not on a toilet atm are you? | 22:01 |
cdent | i am always on the toilet | 22:03 |
*** openstackgerrit has quit IRC | 22:03 | |
cdent | herr doctor professor poopypants | 22:03 |
*** jamesdenton has quit IRC | 22:04 | |
*** cmartin has quit IRC | 22:04 | |
*** eharney has quit IRC | 22:04 | |
mriedem | i usually reserve that kind of language until mikal shows up | 22:06 |
*** openstackgerrit has joined #openstack-nova | 22:06 | |
openstackgerrit | melanie witt proposed openstack/nova: Always use python2.7 for docs target https://review.openstack.org/405665 | 22:06 |
mriedem | i keep it classy until the aussies are around | 22:06 |
*** unicell has joined #openstack-nova | 22:07 | |
cdent | jaypipes, mriedem : so is nested resource providers not counted as a priority at this point? | 22:08 |
*** unicell has quit IRC | 22:08 | |
mriedem | i've asked myself that same question, | 22:08 |
mriedem | because looking back at the summit session notes, it was'nt liste | 22:09 |
mriedem | *listed | 22:09 |
*** unicell has joined #openstack-nova | 22:09 | |
mriedem | i gave the spec an exception though because i thought we still wanted to work on that in ocata | 22:10 |
mriedem | given the sriov/fpga/gpu/unicorn type things that depend on it | 22:10 |
*** smatzek has quit IRC | 22:10 | |
*** kaisers__ has joined #openstack-nova | 22:10 | |
cdent | Looking at the list I'd say there are already plenty of priorities, so I'm not suggesting we should hork it in, I just figured it already was one, but memory is foggy | 22:11 |
mriedem | jaypipes might feel differently, but i think we've got enough to do as it is with the priorities we have listed | 22:11 |
mriedem | yeah same here | 22:11 |
dansmith | me too | 22:12 |
*** kaisers_ has quit IRC | 22:13 | |
*** nic has quit IRC | 22:13 | |
*** bdeschenes has quit IRC | 22:14 | |
*** claudiub|2 has joined #openstack-nova | 22:15 | |
*** gouthamr has quit IRC | 22:17 | |
*** jwcroppe_ is now known as jwcroppe | 22:19 | |
*** tbachman has quit IRC | 22:19 | |
*** thorst_ has quit IRC | 22:20 | |
*** ducttape_ has quit IRC | 22:20 | |
*** liangy has joined #openstack-nova | 22:21 | |
*** nic has joined #openstack-nova | 22:21 | |
*** jheroux has quit IRC | 22:23 | |
jaypipes | mriedem, cdent, dansmith: yeah, my focus first and foremost is Ironic and the custom resource classes work. if I can get all the n-r-p work *pushed up* and available for review showing the SRIOV/NUMA/PCI stuff working, I will be happy (i.e. I'm not expecting the n-r-p patches to merge, just to have eyeballs so that Atlanta will be as productive as possible) | 22:27 |
mriedem | that sounds good to me | 22:34 |
mriedem | scheduler filters in db is top priority, but i think bauzas is doing that, then aggregates which is you and cdent - the rest api portions of that are done now right? | 22:35 |
mriedem | and then resource classes which is making decent progress | 22:35 |
cdent | yeah, aggregates on the http api side are in | 22:36 |
*** smatzek has joined #openstack-nova | 22:37 | |
jaypipes | mriedem: yup, that is 100% correct. | 22:37 |
mriedem | \o/ | 22:38 |
mriedem | i'd like a smelly sticker please | 22:38 |
cdent | a scratch and sniff? | 22:39 |
mriedem | yes | 22:40 |
*** liangy has quit IRC | 22:40 | |
* cdent is a awash in a sea of nostalgia | 22:40 | |
*** baoli has joined #openstack-nova | 22:40 | |
*** baoli has quit IRC | 22:42 | |
*** smatzek has quit IRC | 22:42 | |
*** krtaylor has joined #openstack-nova | 22:42 | |
*** baoli has joined #openstack-nova | 22:42 | |
*** liangy has joined #openstack-nova | 22:43 | |
*** tjones has joined #openstack-nova | 22:43 | |
*** artom_ has quit IRC | 22:43 | |
openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | 22:43 |
*** artom has joined #openstack-nova | 22:44 | |
*** tblakes has quit IRC | 22:48 | |
*** tjones has left #openstack-nova | 22:50 | |
*** bnemec has quit IRC | 22:57 | |
*** mdrabe has quit IRC | 22:57 | |
*** Swami has quit IRC | 23:00 | |
*** kylek3h has quit IRC | 23:00 | |
*** ijw_ has quit IRC | 23:01 | |
* cdent waves goodnight | 23:03 | |
*** cdent has quit IRC | 23:03 | |
openstackgerrit | Chris Dent proposed openstack/nova: Some improvement to the process doc https://review.openstack.org/404991 | 23:04 |
*** esberglu has quit IRC | 23:05 | |
*** esberglu has joined #openstack-nova | 23:06 | |
*** ihrachys has quit IRC | 23:08 | |
*** masuberu has quit IRC | 23:11 | |
*** esberglu has quit IRC | 23:11 | |
*** xyang1 has quit IRC | 23:12 | |
*** masber has joined #openstack-nova | 23:12 | |
*** ayoung has joined #openstack-nova | 23:12 | |
*** dave-mccowan has quit IRC | 23:15 | |
*** annegentle has quit IRC | 23:15 | |
*** burt has quit IRC | 23:16 | |
*** masber has quit IRC | 23:17 | |
*** esberglu has joined #openstack-nova | 23:19 | |
mriedem | melwitt: some questions/comments in here https://review.openstack.org/#/c/399710/ | 23:22 |
mriedem | that one hurt my brain | 23:22 |
melwitt | mriedem: it hurt my brain writing it, so you are not alone | 23:22 |
mriedem | i really should have looked at the usage in the test first | 23:22 |
*** esberglu has quit IRC | 23:23 | |
*** unicell has quit IRC | 23:23 | |
melwitt | yesterday dansmith and I were talking about it a bit and I definitely need to add more code comments explaining everything | 23:24 |
melwitt | I was holding off until he tested it more with the cells scheduling interaction patch | 23:24 |
*** penick has quit IRC | 23:25 | |
mriedem | ok yeah that was several of my comments, to add more comments | 23:25 |
*** ducttape_ has joined #openstack-nova | 23:26 | |
*** dave-mccowan has joined #openstack-nova | 23:31 | |
*** jwcroppe has quit IRC | 23:34 | |
*** jwcroppe has joined #openstack-nova | 23:35 | |
*** unicell has joined #openstack-nova | 23:36 | |
*** dave-mccowan has quit IRC | 23:37 | |
*** unicell1 has joined #openstack-nova | 23:38 | |
*** unicell has quit IRC | 23:38 | |
*** jwcroppe has quit IRC | 23:40 | |
*** siva_krish has quit IRC | 23:40 | |
*** thorst_ has joined #openstack-nova | 23:41 | |
*** weshay is now known as weshay_pto | 23:43 | |
*** Swami has joined #openstack-nova | 23:43 | |
*** ducttape_ has quit IRC | 23:44 | |
*** penick has joined #openstack-nova | 23:45 | |
*** nic has quit IRC | 23:45 | |
*** thorst_ has quit IRC | 23:46 | |
*** nic has joined #openstack-nova | 23:46 | |
*** penick has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!