Thursday, 2017-01-12

*** ducttape_ has quit IRC00:01
dansmithmriedem: passed the cells job but failed something else, probably unrelatedly00:02
*** tbachman has quit IRC00:07
*** FL1SK has joined #openstack-nova00:10
*** aslezil_ has quit IRC00:11
*** annegentle has joined #openstack-nova00:14
*** tbachman has joined #openstack-nova00:14
*** hfu has joined #openstack-nova00:16
*** mriedem has quit IRC00:19
*** mriedem has joined #openstack-nova00:20
*** jwcroppe has joined #openstack-nova00:22
*** CristinaPauna has quit IRC00:25
*** CristinaPauna has joined #openstack-nova00:37
*** rfolco has joined #openstack-nova00:37
*** rfolco has quit IRC00:37
mriedemso apparently my foundation membership has lapsed b/c i haven't been voting in board of directors elections,00:39
mriedemis there an easy way to get my membership back or i just need to do the initial sign up stuff all over again?00:39
mriedemcan i be ptl if i'm not a foundation member? i'm pretty sure i'm breaking some laws right now.00:41
*** swamireddy has joined #openstack-nova00:45
*** hfu has quit IRC00:46
*** hfu has joined #openstack-nova00:47
*** chyka has quit IRC00:48
mriedemooo i'm back in00:48
*** jamielennox is now known as jamielennox|away00:50
*** annegentle has quit IRC00:51
*** zz_dimtruck is now known as dimtruck00:51
*** thorst_ has joined #openstack-nova00:53
*** thorst_ has quit IRC00:58
*** hoangcx has joined #openstack-nova01:00
*** phuongnh has joined #openstack-nova01:05
*** sdague has quit IRC01:05
*** mtanino has quit IRC01:11
*** rama_y_ has quit IRC01:11
*** tuanluong has joined #openstack-nova01:12
*** dtp has quit IRC01:14
*** jose-phillips has quit IRC01:15
*** thorst_ has joined #openstack-nova01:17
*** jamielennox|away is now known as jamielennox01:21
*** kevinz has joined #openstack-nova01:22
*** Jinxing has joined #openstack-nova01:25
*** Jinxing has quit IRC01:26
*** yuntongjin has joined #openstack-nova01:31
*** ducttape_ has joined #openstack-nova01:33
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Deny invalid flavor extraspec for cpu_policy
*** gouthamr has quit IRC01:36
*** dimtruck is now known as zz_dimtruck01:42
*** gcb has joined #openstack-nova01:43
*** tovin07_ is now known as tovin0701:45
*** browne has quit IRC01:48
*** zz_dimtruck is now known as dimtruck01:49
*** jaypipes has quit IRC01:50
openstackgerritMatt Riedemann proposed openstack/nova: Hyper-V: Adds vNUMA implementation
*** zayro_ has joined #openstack-nova01:57
*** yuntongjin has quit IRC01:58
tovin07johnthetubaguy, mriedem, could you review this one ? patch in novaclient is OK now. Thank you!01:59
*** yuntongjin has joined #openstack-nova02:01
*** zayro_ has quit IRC02:02
*** tovin07_ has joined #openstack-nova02:02
*** unicell has quit IRC02:02
EmilienMmriedem: thanks!02:03
*** zayro has joined #openstack-nova02:03
*** tbachman has quit IRC02:04
mriedemtovin07: probably not tonight02:13
*** kaisers has quit IRC02:13
mriedembut it's on the list02:13
*** kaisers1 has quit IRC02:13
mriedemdansmith: looks like my series of backports for the scheduler report client in newton are going to be needed after all for ironic
mriedem^ was failing before the depends-on02:14
tovin07mriedem, thanks!02:14
mriedemwhich pulls in this whole series
*** ducttape_ has quit IRC02:16
*** ducttape_ has joined #openstack-nova02:17
*** ijw has quit IRC02:18
*** yingjun has joined #openstack-nova02:21
*** kaisers_ has quit IRC02:21
*** kaisers has joined #openstack-nova02:30
*** kaisers1 has joined #openstack-nova02:30
*** gouthamr has joined #openstack-nova02:32
*** hongbin_ has joined #openstack-nova02:33
*** markvoelker has quit IRC02:38
*** thorst_ has quit IRC02:38
*** thorst_ has joined #openstack-nova02:39
*** _ducttape_ has joined #openstack-nova02:40
*** raunak has quit IRC02:40
*** markvoelker_ has joined #openstack-nova02:41
*** ducttape_ has quit IRC02:43
*** yamahata has quit IRC02:43
*** thorst_ has quit IRC02:43
*** zayro has quit IRC02:45
*** zayro has joined #openstack-nova02:46
*** tovin07 has quit IRC02:52
*** markvoelker_ has quit IRC02:56
*** tovin07 has joined #openstack-nova02:56
*** _ducttape_ has quit IRC03:07
*** ducttape_ has joined #openstack-nova03:08
*** ijw has joined #openstack-nova03:08
*** tovin07 has quit IRC03:09
*** hoangcx_ has joined #openstack-nova03:10
*** tovin07 has joined #openstack-nova03:10
*** hieulq has quit IRC03:10
*** tuanluong_ has joined #openstack-nova03:10
*** tuanluong has quit IRC03:10
*** hoangcx has quit IRC03:10
*** tovin07_ has quit IRC03:11
*** phuongnh has quit IRC03:11
*** phuongnh has joined #openstack-nova03:11
*** hoangcx_ is now known as hoangcx03:12
*** ducttape_ has quit IRC03:12
*** dimtruck is now known as zz_dimtruck03:12
*** zz_dimtruck is now known as dimtruck03:12
*** ijw has quit IRC03:13
*** ijw_ has joined #openstack-nova03:13
*** bkopilov has quit IRC03:13
*** jamesdenton has joined #openstack-nova03:14
alex_xudiana_clarke: yea, agree with you , we need better error message. At least the "query parameter 0" confuse user. I guess "0" due to the input are array type.03:14
*** ijw_ has quit IRC03:14
*** phuongnh has quit IRC03:17
*** ijw has joined #openstack-nova03:17
*** phuongnh has joined #openstack-nova03:17
*** ijw has quit IRC03:18
*** jamesdenton has quit IRC03:18
*** baoli has joined #openstack-nova03:20
*** ijw has joined #openstack-nova03:22
*** ijw_ has joined #openstack-nova03:23
*** tlian has quit IRC03:24
*** tovin07_ has joined #openstack-nova03:24
*** hieulq has joined #openstack-nova03:25
*** tlian has joined #openstack-nova03:25
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Better black list for py35 tests
*** ijw has quit IRC03:27
mriedemdansmith: we should talk to vladikr about this tomorrow
mriedemi don't want to forget about that one03:32
*** yuntongjin has quit IRC03:35
vladikrmriedem, I'm here - I'm try to re-implement it all with storing the vlan in info_cache - having some issues with that though.. that's why I didn't update yet03:35
mriedemvladikr: ok yeah i assumed you'd need to see how that change makes the rest of the series behave03:35
*** links has joined #openstack-nova03:39
*** pbandark has joined #openstack-nova03:39
*** ducttape_ has joined #openstack-nova03:54
*** hongbin_ has quit IRC03:55
*** baoli has quit IRC03:57
*** markvoelker has joined #openstack-nova03:57
openstackgerritZhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters.
*** madhu_ak has joined #openstack-nova04:03
*** sree has joined #openstack-nova04:04
*** sree has joined #openstack-nova04:04
*** psachin has joined #openstack-nova04:05
*** tlian has quit IRC04:09
*** madhu_ak has quit IRC04:10
*** ducttape_ has quit IRC04:11
*** Jeffrey4l__ has joined #openstack-nova04:11
*** nicolasbock has quit IRC04:11
*** ducttape_ has joined #openstack-nova04:11
*** Jeffrey4l_ has quit IRC04:14
*** aslezil_ has joined #openstack-nova04:14
*** ducttape_ has quit IRC04:16
*** mdnadeem has joined #openstack-nova04:18
*** hongbin_ has joined #openstack-nova04:21
*** diga has joined #openstack-nova04:21
*** amotoki has quit IRC04:22
*** amotoki has joined #openstack-nova04:22
*** ratailor has joined #openstack-nova04:29
*** sudipto has joined #openstack-nova04:29
*** sudipto_ has joined #openstack-nova04:29
*** bkopilov has joined #openstack-nova04:38
openstackgerritzhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm
*** karthiks has joined #openstack-nova04:40
*** zayro has quit IRC04:40
*** zayro has joined #openstack-nova04:41
openstackgerritzhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm
*** karthiks has quit IRC04:46
*** dikonoor has joined #openstack-nova04:48
openstackgerritzhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm
*** pbandark has quit IRC04:53
*** unicell has joined #openstack-nova04:55
*** pbandark has joined #openstack-nova04:59
*** jamespage has quit IRC05:00
*** karthiks has joined #openstack-nova05:06
*** armax has quit IRC05:06
*** voelzmo has joined #openstack-nova05:07
*** aslezil_ has quit IRC05:11
*** armax has joined #openstack-nova05:11
*** voelzmo has quit IRC05:11
*** hongbin_ has quit IRC05:13
*** prateek has joined #openstack-nova05:13
*** sudipto has quit IRC05:14
*** sudipto_ has quit IRC05:14
*** adisky_ has joined #openstack-nova05:18
*** sc68cal has quit IRC05:18
*** sc68cal has joined #openstack-nova05:20
*** yamahata has joined #openstack-nova05:21
*** sacharya has quit IRC05:25
*** salv-orlando has joined #openstack-nova05:26
*** salv-orlando has quit IRC05:31
*** thorst_ has joined #openstack-nova05:40
*** yuntongjin has joined #openstack-nova05:44
*** thorst_ has quit IRC05:44
*** khushbu has joined #openstack-nova05:52
*** ayogi has joined #openstack-nova05:55
*** ayogi has quit IRC05:56
*** sudipto has joined #openstack-nova05:58
*** sudipto_ has joined #openstack-nova05:58
*** moshele has joined #openstack-nova06:03
*** slaweq has joined #openstack-nova06:03
*** andrewbogott has quit IRC06:04
*** andrewbogott has joined #openstack-nova06:04
*** tbachman has joined #openstack-nova06:05
*** armax has quit IRC06:07
*** armax has joined #openstack-nova06:07
*** armax has quit IRC06:08
khushbuHi! I am working on this trying to recreate the issue can ayone send the doc link to run tests for oslo.concurrency06:08
openstackLaunchpad bug 1630575 in oslo.concurrency "python3 memoryview error" [Undecided,New] - Assigned to Khushbuparakh (khushbuparakh)06:08
khushbu  these are log file06:08
*** tbachman has quit IRC06:10
*** tbachman has joined #openstack-nova06:10
*** unicell1 has joined #openstack-nova06:16
*** tbachman_ has joined #openstack-nova06:17
*** unicell has quit IRC06:17
*** tbachman has quit IRC06:18
*** tbachman_ is now known as tbachman06:18
*** karthiks has quit IRC06:19
*** unicell1 has quit IRC06:21
*** unicell has joined #openstack-nova06:21
*** mdnadeem has quit IRC06:22
*** sacharya has joined #openstack-nova06:25
*** lpetrut has joined #openstack-nova06:27
*** salv-orlando has joined #openstack-nova06:28
openstackgerritHussain Chachuliya proposed openstack/nova: Deny volume swapping with non-bootable volume
*** sridharg has joined #openstack-nova06:29
*** sacharya has quit IRC06:30
*** salv-orlando has quit IRC06:32
*** mdnadeem has joined #openstack-nova06:34
*** karthiks has joined #openstack-nova06:34
*** huanxie has joined #openstack-nova06:36
*** thorst_ has joined #openstack-nova06:40
*** mjura has joined #openstack-nova06:42
*** nkrinner_afk is now known as nkrinner06:45
*** thorst_ has quit IRC06:45
*** satyar has joined #openstack-nova06:46
openstackgerritZhihai Song proposed openstack/nova: Enable functional.test_servers on Python 3
gokhanhi team, I have a question about nova-lxd . I have openstack mitaka installation. I created container with lxd. it is running but network is unreacheable. I am using linux bridge . These are logs what can be reason of this. Which settings must be done with lxdbridge ?06:51
openstackgerritzhangyujun proposed openstack/nova: Update JSON Schema for flavor access
*** kaisers_ has joined #openstack-nova06:57
*** salv-orlando has joined #openstack-nova06:57
*** hoangcx_ has joined #openstack-nova06:57
*** hoangcx has quit IRC07:00
openstackgerritzhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm
openstackgerritHuan Xie proposed openstack/nova: XenAPI: Fix vif plug problem during VM rescue/unrescue
*** ayogi has joined #openstack-nova07:04
*** tjones has quit IRC07:09
openstackgerritHuan Xie proposed openstack/nova: Fix class type error in attach_interface() function
*** khushbu has quit IRC07:13
*** nkrinner is now known as nkrinner_afk07:14
*** tesseract has joined #openstack-nova07:14
*** tbachman has quit IRC07:15
*** raunak has joined #openstack-nova07:17
*** mnestratov has joined #openstack-nova07:17
*** andreas_s has joined #openstack-nova07:18
*** prateek_ has joined #openstack-nova07:22
*** prateek has quit IRC07:22
*** lpetrut has quit IRC07:24
*** mdnadeem has quit IRC07:24
*** ayogi has quit IRC07:25
*** mdnadeem has joined #openstack-nova07:25
*** psachin has quit IRC07:27
*** pbandark has quit IRC07:27
*** tovin07 has quit IRC07:28
*** psachin has joined #openstack-nova07:29
*** lpetrut has joined #openstack-nova07:32
*** pbandark has joined #openstack-nova07:33
*** sudipto has quit IRC07:36
*** sudipto_ has quit IRC07:36
*** nherciu has joined #openstack-nova07:38
openstackgerritWang Qing wu proposed openstack/nova: WIP(3): Introduce base PowerVM driver (console)
*** ttx has quit IRC07:40
*** ttx has joined #openstack-nova07:40
*** gouthamr has quit IRC07:42
*** ttx has quit IRC07:47
*** ttx has joined #openstack-nova07:47
*** logan- has quit IRC07:47
*** tiendc has joined #openstack-nova07:48
*** hoangcx has joined #openstack-nova07:49
*** nherciu_ has joined #openstack-nova07:49
*** hoangcx_ has quit IRC07:51
*** ralonsoh has joined #openstack-nova07:52
*** nherciu has quit IRC07:52
*** logan- has joined #openstack-nova07:56
*** lpetrut has quit IRC08:00
*** sacharya has joined #openstack-nova08:01
*** raunak has quit IRC08:01
*** sapcc-bot has joined #openstack-nova08:05
*** carthaca_ has joined #openstack-nova08:05
*** mkoderer_ has joined #openstack-nova08:05
*** haplo37_ has quit IRC08:05
*** sacharya has quit IRC08:06
*** mkoderer_ has quit IRC08:07
*** carthaca_ has quit IRC08:07
*** mfeoktistov has joined #openstack-nova08:08
*** haplo37_ has joined #openstack-nova08:09
*** aloga has quit IRC08:12
*** aloga has joined #openstack-nova08:15
*** hongbin has quit IRC08:16
*** zenoway has joined #openstack-nova08:18
*** mfeoktistov has left #openstack-nova08:21
*** mfeoktistov has joined #openstack-nova08:21
*** dimtruck is now known as zz_dimtruck08:22
*** diga has quit IRC08:26
*** markus_z has joined #openstack-nova08:26
*** sudipto_ has joined #openstack-nova08:31
*** sudipto has joined #openstack-nova08:31
*** moshele has quit IRC08:32
*** moshele has joined #openstack-nova08:33
*** omnipresent has joined #openstack-nova08:34
*** yamahata has quit IRC08:35
mfeoktistovHello! I would like to add a new filter to etc/nova/rootwrap.d/compute.filters08:36
mfeoktistovstring like "ploop: RegExpFilter, ploop, root, ploop, init, -s, .*, .*"08:36
mfeoktistovI can see that we use oslo.privsep now.08:36
mfeoktistovAnd I have a question. How to use it?08:36
*** yuntongjin has quit IRC08:36
*** zenoway has quit IRC08:36
*** databus23_ has joined #openstack-nova08:39
openstackgerritzhangyujun proposed openstack/nova: Query parameter validation for hosts API
*** kberger has quit IRC08:41
*** jwcroppe has quit IRC08:41
*** moshele has quit IRC08:41
*** thorst_ has joined #openstack-nova08:41
*** jwcroppe has joined #openstack-nova08:42
*** moshele has joined #openstack-nova08:42
*** salv-orl_ has joined #openstack-nova08:43
*** salv-orlando has quit IRC08:43
*** nkrinner_afk is now known as nkrinner08:44
*** jwcroppe has quit IRC08:46
*** thorst_ has quit IRC08:46
*** ratailor has quit IRC08:46
openstackgerritZhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters.
*** lyarwood is now known as lyarwood_08:54
*** lyarwood_ is now known as lyarwood08:54
*** tojuvone has quit IRC08:58
*** manasm has joined #openstack-nova08:59
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-nova09:00
*** yingjun has quit IRC09:00
*** david-lyle has quit IRC09:01
*** sacharya has joined #openstack-nova09:01
*** yassine has joined #openstack-nova09:02
*** yassine is now known as Guest2982209:02
*** khushbu has joined #openstack-nova09:02
*** zenoway has joined #openstack-nova09:05
*** sacharya has quit IRC09:06
*** omnipresent has quit IRC09:08
*** ratailor has joined #openstack-nova09:08
*** roeyc has joined #openstack-nova09:10
*** khushbu has quit IRC09:12
*** mvk has quit IRC09:18
*** lucas-afk is now known as lucasagomes09:22
*** david-lyle has joined #openstack-nova09:24
*** sapcc-bot has quit IRC09:25
*** databus23_ has quit IRC09:25
*** mkoderer_ has joined #openstack-nova09:25
*** carthaca_ has joined #openstack-nova09:25
*** sapcc-bot has joined #openstack-nova09:25
*** databus23_ has joined #openstack-nova09:25
*** salv-orl_ has quit IRC09:26
*** mkoderer_ has quit IRC09:27
*** carthaca_ has quit IRC09:27
*** omnipresent has joined #openstack-nova09:32
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix a parameter in
*** abalutoiu has joined #openstack-nova09:34
*** zenoway has quit IRC09:35
*** CristinaPauna has quit IRC09:35
*** zhangyujun has quit IRC09:36
*** aloga has quit IRC09:37
*** aloga has joined #openstack-nova09:38
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements
*** zenoway has joined #openstack-nova09:43
*** avolkov has joined #openstack-nova09:44
*** lpetrut has joined #openstack-nova09:46
*** omnipresent has quit IRC09:46
*** owalsh-afk has joined #openstack-nova09:47
*** mfedosin has joined #openstack-nova09:47
*** hfu has quit IRC09:48
*** owalsh-afk is now known as owalsh09:49
*** aloga has quit IRC09:50
*** aloga has joined #openstack-nova09:51
*** mvk has joined #openstack-nova09:51
*** abalutoiu has quit IRC09:55
*** zenoway has quit IRC09:56
*** zayro has quit IRC09:58
*** tiendc has quit IRC10:00
alex_xugmann: johnthetubaguy Kevin_Zheng, another idea, we write a new formatter which always reject the validation. Then the schema may looks like this {"system_metadata": {"type": "string", "format": "reject_always"}}, then when user input system_metadata in the query, 400 returned. And we have a way to custom the error message returned from formatter.10:00
*** zhangyujun has joined #openstack-nova10:02
*** abalutoiu has joined #openstack-nova10:08
*** derekh has joined #openstack-nova10:08
gmannalex_xu:  i see.10:10
gmannalex_xu: i like to idea but worrying if it make json schema confusing but format name is conveying that anyways10:11
*** kevinz has quit IRC10:11
alex_xugmann: yea, benefits are we needn't python code to raise badrequest, less hacky in other places, no need one more decorator10:12
gmannalex_xu:  but one issue,  format will not work if it is not string10:12
alex_xugmann: the query string in the url, always string :)10:13
gmannalex_xu:  yea better than python code doing that10:13
gmannalex_xu: ah yea10:13
alex_xuKevin_Zheng will give a try, to see how that looks like10:15
gmannalex_xu:  but when it comes to schema it will be list of values right10:16
* gmann checking10:16
*** moshele has quit IRC10:16
*** ralonsoh_ has joined #openstack-nova10:17
*** moshele has joined #openstack-nova10:17
alex_xugmann: yea10:18
gmannso "system_metadata" value will  be in list while doing validation10:18
alex_xugmann: I think the key reason for this trouble was there is no way to express "I want to some specific properties, but I don't want some specific properites, and others just ignore" in the jsonschema10:18
*** moshele has quit IRC10:19
alex_xugmann: yes10:19
*** moshele has joined #openstack-nova10:19
alex_xugmann: and we still need to use patternProperties for internal attributes, the regex is "^_"10:19
gmannalex_xu: yea, that is missing in json schema lib, they should provide any way to restrict few known properties10:20
*** ralonsoh has quit IRC10:20
gmannalex_xu: true10:20
johnthetubaguyalex_xu: I quite like that10:21
alex_xujohnthetubaguy: cool \o/10:21
johnthetubaguyalex_xu: but yeah, I guess you still have to keep the regex thing10:21
johnthetubaguyalex_xu: what about type: "reject_always"?10:22
johnthetubaguyor is that not allowed10:22
gmannalex_xu: johnthetubaguy  but will it work as values will not be string10:22
alex_xuprobably "patternProperties": {"^_": {"type": "string", "format": reject_always"}}10:22
*** dgonzalez_ has joined #openstack-nova10:23
*** carthaca_ has joined #openstack-nova10:23
alex_xujohnthetubaguy: i'm not sure json-schema have a way to extend the type, I need to check that10:23
*** owalsh is now known as owalsh-brb10:24
johnthetubaguyI mean they are all strings in query string params anyways10:24
*** carthaca_ has quit IRC10:25
*** dgonzalez_ has quit IRC10:25
gmannbut we do convert those into list of values for validation, so they are array for schema10:25
johnthetubaguywell, I guess I mean everything is a list of strings10:26
gmannyea but json schema just ignore format validation and pass if instance is not string10:27
*** hoangcx has quit IRC10:27
*** sree has quit IRC10:28
*** phuongnh has quit IRC10:28
*** sree has joined #openstack-nova10:28
alex_xujohnthetubaguy: gmann we can add new type. but I guess there is no way to change the error message. User will get a message about "this isn't a type of reject_always"10:28
johnthetubaguygood point10:29
johnthetubaguywhy are we moving away from the decorator approach?10:29
alex_xujohnthetubaguy: probably avoid one more decorator, and we put all the info into the schema: it is not part of in the schema and part of in the decorator10:30
alex_xujohnthetubaguy: and Kevin_Zheng show me this, I feel the change is bigger than I thought10:30
alex_xuBut I guess there can be some code sharing, but another worry is another refactor for the code10:31
johnthetubaguywe don't really need min and max though10:31
johnthetubaguyI thought10:31
johnthetubaguynot yet anyways10:31
alex_xuit needs a version control10:32
*** sree has quit IRC10:32
alex_xuin the future we may add new filter before we reject all?10:32
gmannyea version things we can avoid as of not and do when microversion bump10:32
alex_xuoops, sorry, that isn't the case10:32
Kevin_Zhengyeah, otherwise we can just do it in schema with additional=false10:32
openstackgerritzhangyujun proposed openstack/nova: Query parameter validation for hosts API
*** satyar has quit IRC10:35
*** mvk has quit IRC10:36
*** owalsh-brb is now known as owalsh10:37
alex_xuwhen we reject all, that decorator still can be there.10:37
*** abalutoiu has quit IRC10:37, yes, sounds like no version is ok10:39
*** thorst_ has joined #openstack-nova10:42
alex_xujohnthetubaguy: gmann Kevin_Zheng I guess the only different is we want to put all the info together, or just split that special case out of schema? is that question we should answer?10:43
*** CristinaPauna has joined #openstack-nova10:43
*** JoseMello has joined #openstack-nova10:43
*** cdent has joined #openstack-nova10:44
*** huanxie has quit IRC10:45
*** thorst_ has quit IRC10:47
gmannalex_xu:  you mean in case we add in schema with new formatter ?10:48
*** mvk has joined #openstack-nova10:48
alex_xugmann: yes10:48
gmannalex_xu: but  'format' only work if instance going to be validated is string and in our case it is list of values right10:49
alex_xugmann: we have macro function 'multi_params', that works for list10:49
*** abalutoiu has joined #openstack-nova10:50
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Better black list for py35 tests
gmannalex_xu: yea but instance (values) will be list and we would not be able to define  like {"system_metadata": {"type": "string", "format": "reject_always"}}10:52
alex_xugmann: here is
gmannwe have to do like this - {"system_metadata": {multi_params, "format": "reject_always"}}10:52
alex_xugmann: sorry, it should be {"system_metadata": multi_params({"type": "string", "format": "reject_always"})}10:52
gmannalex_xu:  ahh i see, so that each item will be validated against  "reject_always"10:54
alex_xugmann: yea10:54
*** sapcc-bot has quit IRC10:54
*** databus23_ has quit IRC10:54
alex_xubut have to say reject_always format is another hacky thing. is it decorator more explicitly?10:54
alex_xus/is it decorator/ is decorator/10:55
*** carthaca_ has joined #openstack-nova10:55
*** dgonzalez_ has joined #openstack-nova10:55
*** databus23_ has joined #openstack-nova10:55
*** sapcc-bot has joined #openstack-nova10:55
*** claudiub|2 has joined #openstack-nova10:55
*** gszasz has joined #openstack-nova10:55
gmannhumm, another issue may be error message otherwise i like new formatter way10:56
*** amotoki has quit IRC10:56
gmannalex_xu: but we can catch and format error message which will be other hack but wotrks10:56
*** carthaca_ has quit IRC10:57
*** dgonzalez_ has quit IRC10:57
alex_xugmann: yea, we already have one case, then probably add another one10:57
gmannjohnthetubaguy:  i think string thing solved here as alex_xu  mentioned we can validate against each item of list and 'format' works10:57
gmannalex_xu:   :) aboout to give that example10:58
*** Jeffrey4l__ is now known as Jeffrey4l10:58
gmannalex_xu:  i am +1 with new formatter.10:58
alex_xugmann: :)10:58
gmannalex_xu: johnthetubaguy  have to rush for train. ll see log later10:58
alex_xugmann: yea, I have to go home also, back later10:59
*** tojuvone has joined #openstack-nova11:00
openstackgerritZhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters.
*** sacharya has joined #openstack-nova11:02
*** amotoki has joined #openstack-nova11:06
*** sacharya has quit IRC11:07
*** databus23_ has quit IRC11:15
*** sapcc-bot has quit IRC11:15
*** sapcc-bot has joined #openstack-nova11:16
*** databus23_ has joined #openstack-nova11:16
*** carthaca_ has joined #openstack-nova11:16
*** dgonzalez_ has joined #openstack-nova11:16
*** carthaca_ has quit IRC11:18
*** dgonzalez_ has quit IRC11:18
openstackgerritZhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters.
openstackgerritzhangyujun proposed openstack/nova: Update JSON Schema for flavor access
*** rfolco has joined #openstack-nova11:21
*** sudipto has quit IRC11:22
*** sudipto_ has quit IRC11:22
*** cdent has quit IRC11:23
*** manasm has quit IRC11:32
*** nicolasbock has joined #openstack-nova11:34
*** smatzek has joined #openstack-nova11:36
openstackgerritZhihai Song proposed openstack/nova: Update py35 functional tests blacklist
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_attach notification
*** voelzmo has joined #openstack-nova11:41
*** ralonsoh_ is now known as ralonsoh11:42
*** sree has joined #openstack-nova11:46
*** voelzmo has quit IRC11:47
*** prateek has joined #openstack-nova11:47
*** voelzmo has joined #openstack-nova11:48
openstackgerritWang Qing wu proposed openstack/nova: WIP(4): Introduce base PowerVM driver (cfg drv)
*** ociuhandu has quit IRC11:50
*** sree has quit IRC11:50
*** voelzmo has quit IRC11:52
*** amotoki has quit IRC11:53
*** ralonsoh_ has joined #openstack-nova11:55
*** masber has quit IRC11:56
openstackgerritZhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters.
*** amotoki has joined #openstack-nova11:58
*** ralonsoh has quit IRC11:59
*** abalutoiu_ has joined #openstack-nova11:59
*** bkopilov has quit IRC11:59
openstackgerritZhihai Song proposed openstack/nova: Enable tests.functional.db.api.test_migrations for py35
*** voelzmo has joined #openstack-nova12:00
*** ducttape_ has joined #openstack-nova12:01
*** ducttape_ has quit IRC12:01
openstackgerritZhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters.
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_attach notification
*** abalutoiu has quit IRC12:02
*** amotoki_ has joined #openstack-nova12:03
*** cdent has joined #openstack-nova12:03
*** abalutoiu_ has quit IRC12:04
*** voelzmo has quit IRC12:05
*** abalutoiu has joined #openstack-nova12:05
*** amotoki has quit IRC12:05
*** tuanluong_ has quit IRC12:06
*** sahid has joined #openstack-nova12:08
*** abalutoiu has quit IRC12:09
*** amotoki_ has quit IRC12:10
*** rtheis has joined #openstack-nova12:11
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_detach notification
*** links has quit IRC12:13
*** dave-mccowan has joined #openstack-nova12:13
*** sree has joined #openstack-nova12:13
*** baoli has joined #openstack-nova12:14
*** baoli has quit IRC12:15
openstackgerritBéla Vancsics proposed openstack/nova: Reduce code duplication
*** baoli has joined #openstack-nova12:15
*** derekh has quit IRC12:16
*** derekh has joined #openstack-nova12:16
*** manasm has joined #openstack-nova12:19
*** mdnadeem has quit IRC12:19
*** sheel has joined #openstack-nova12:19
*** baoli has quit IRC12:21
*** bvanhav__ has joined #openstack-nova12:21
openstackgerritIstvan Imre proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication
*** voelzmo has joined #openstack-nova12:22
openstackgerritZhihai Song proposed openstack/nova: Update py35 functional tests blacklist
*** owalsh is now known as owalsh-lunch12:25
*** voelzmo has quit IRC12:26
*** lucasagomes is now known as lucas-hungry12:26
*** abalutoiu has joined #openstack-nova12:29
dimsmriedem : bauzas : the review for the py35 functional test blacklist is ready -
*** yuntongjin has joined #openstack-nova12:32
*** ociuhandu has joined #openstack-nova12:33
*** Prophidys has quit IRC12:35
*** yuntongjin has quit IRC12:35
*** zhangyujun has quit IRC12:36
*** manasm has quit IRC12:37
*** pbandark has quit IRC12:38
*** tommylikehu has quit IRC12:39
*** tommylikehu has joined #openstack-nova12:40
*** Prophidys has joined #openstack-nova12:40
openstackgerritChris Dent proposed openstack/nova: Small improvements to placement.rst
*** sdague has joined #openstack-nova12:43
*** thorst_ has joined #openstack-nova12:46
cdentmriedem, bauzas : can we get that merged or otherwise reviewed? Or if not, let me know so I can abandon it.12:46
*** gcb has quit IRC12:49
openstackgerritBéla Vancsics proposed openstack/nova: Reduced the complexity of the _init_instance method
*** gongysh has joined #openstack-nova12:52
*** manasm has joined #openstack-nova12:52
openstackgerritJohn Garbutt proposed openstack/nova: Pass objects into _create_ports_for_instance
*** voelzmo has joined #openstack-nova12:54
*** voelzmo has quit IRC12:58
*** dgonzalez has quit IRC12:58
*** mdnadeem has joined #openstack-nova13:00
bauzascdent: looking13:02
*** lucas-hungry is now known as lucasagomes13:02
bauzascdent: +2d13:03
cdentmore thanks!13:03
bauzascdent: I'll abandon my doc patch changing the port number13:03
*** sacharya has joined #openstack-nova13:03
*** salv-orlando has joined #openstack-nova13:04
*** dgonzalez has joined #openstack-nova13:05
*** gongysh has quit IRC13:07
*** sacharya has quit IRC13:08
*** mdnadeem has quit IRC13:09
*** edmondsw has joined #openstack-nova13:10
gibihi nova!13:13
gibiI have a question about lazy-loaded fields13:13
cdenthi gibi !13:13
cdent(someone has had their coffee today)13:14
gibicdent: :)13:14
gibiDo I see correctly that instance.flavor.projects access is a double lazy-load?13:14
gibiand that it will not work13:14
gibias when the flavor is loaded into the instance13:14
gibithen the Flavor object is orphaned13:15
*** alexpilo_ has joined #openstack-nova13:15
*** efried has joined #openstack-nova13:15
* cdent has not had enough coffee today to parse that13:16
gibiso I have an instance object13:16
gibiand I access instance.flavor13:16
gibiwhich will lazy load the Falvor object13:16
gibiand then I try to access the projects field of that Flavor object that is again a lazy load13:17
gibithen that is fails as the Falvor object is orphaned13:17
*** alexpilotti has quit IRC13:17
*** aunnam has quit IRC13:17
*** gokhan has quit IRC13:17
*** kylek3h has quit IRC13:18
*** gokhan has joined #openstack-nova13:18
gibiI started here
gibiwith an instance13:18
gibithen that notification sending first access instance.flavor and that is OK as the instance is not orphaned13:19
gibibut after that the code needs instance.flavor.projects and that fails13:19
cdentgibi: this is the sort of question I'd love to see on the mailing list so that the response is preserved somewhere more readable by more people than IRC. Also I don't know the answer :)13:19
gibiOrphanedObjectError: Cannot call _load_projects on orphaned Flavor object13:19
*** aunnam has joined #openstack-nova13:19
gibicdent: OK, I post to ML13:19
cdentit looks like those flavor objects being created never get a context?13:21
openstackgerritZhenyu Zheng proposed openstack/nova: [poc] add some code to reject known bad filters.
gibiyes, it seems to me the context is missingf13:22
cdentwhich presumably means someone wanted to make sure you can't do what you're trying to do? :)13:23
*** ralonsoh_ is now known as ralonsoh13:23
gibiI'm not sure about that13:24
gibiI think it is more likely that we forgot the context there13:25
*** kberger has joined #openstack-nova13:25
Dinesh_Bhorcdent: Hi, do you have some time? I am not much clear about 'Content-Type' in response so thought to ask you few doubts.13:25
*** links has joined #openstack-nova13:25
cdentDinesh_Bhor: I can try. What's up?13:26
*** aarefiev_afk is now known as aarefiev13:26
Dinesh_Bhorcdent: Is it compulsory that all openstack services should return 'Content-Type' in response header?13:26
Dinesh_Bhorcdent: I have seen most of the openstack services returning 'Content-Type' in response header.13:26
cdentDinesh_Bhor: that's a requirement of HTTP, not just openstack13:28
cdentif there is a body in the response there needs to be a content-type header to identify what media type it is13:28
cdentDinesh_Bhor: there's some extensive information in the RFC:
*** claudiub has joined #openstack-nova13:30
cdentDinesh_Bhor: does that help?13:31
Dinesh_Bhorcdent: yes, thank you so much13:31
cdentthe same thing is true of a request: if it has a body it needs a content-type header too13:32
*** claudiub|2 has quit IRC13:33
*** ralonsoh_ has joined #openstack-nova13:33
openstackgerritBéla Vancsics proposed openstack/nova: Reduced the complexity of the _init_instance method (2)
*** ralonsoh has quit IRC13:36
*** sree_ has joined #openstack-nova13:36
dimsbauzas : you may have missed my ping :)
*** gongysh has joined #openstack-nova13:36
bauzasdims: heh, oops :)13:36
*** sree_ is now known as Guest6700913:36
dimsno worries :)13:36
*** sudipto_ has joined #openstack-nova13:37
*** sudipto has joined #openstack-nova13:37
openstackgerritJulian proposed openstack/nova: Create script that prints JSON Schema of Notification Payload Classes
*** manasm has quit IRC13:38
*** sree has quit IRC13:39
*** salv-orlando has quit IRC13:39
*** bkopilov has joined #openstack-nova13:39
*** sree has joined #openstack-nova13:39
Dinesh_Bhorcdent: sry to disturb you again. agree that If the request contains body then there must have content-type but if service returns an http exception then in response will that content-type be available?13:41
efriedmriedem: Can we add a PowerVM section in ?13:41
*** voelzmo has joined #openstack-nova13:41
*** Guest67009 has quit IRC13:41
cdentDinesh_Bhor: the content-type header should always say what the media type of the body is, even when returning an exception. If the exception has been formatted to JSON then the content-type should be application/json. If it is html, then text/html. If it is straight text then text/plain13:42
*** takashin has joined #openstack-nova13:42
Dinesh_Bhorcdent: ok, explains a lot13:43
*** sree has quit IRC13:43
cdentDinesh_Bhor: just out of curiosity what are you working on that raised these questions?13:43
Dinesh_Bhorcdent: this one13:45
Dinesh_Bhorcdent: here all logic is based on content-type13:45
* cdent looks13:45
*** voelzmo has quit IRC13:46
*** owalsh-lunch is now known as owalsh13:46
*** sree has joined #openstack-nova13:47
Dinesh_Bhorcdent: and I am trying to solve bug in openstacksdk by refering that logic13:47
* cdent nods13:47
*** eharney has quit IRC13:49
*** efried has quit IRC13:50
*** sridharg has quit IRC13:51
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_detach notification
*** efried has joined #openstack-nova13:52
mriedemefried: yea13:54
*** kylek3h has joined #openstack-nova13:54
dimsmriedem : please bless this
*** pradk has joined #openstack-nova13:55
mriedemdims: done13:56
dimsthanks mriedem13:56
mriedemlyarwood: fyi the placement job on stable/newton should be fixed now13:57
mriedembauzas: ^13:57
mriedemjroll: now that is merged are you good to do an ironicclient release?13:58
*** lamt has joined #openstack-nova13:58
*** tblakes has joined #openstack-nova13:58
dimsmriedem : yep, added the failing ones, then sort and uniq, that's it13:59
*** ratailor has quit IRC13:59
efriedmriedem: done (etherpad update)13:59
*** prateek_ has quit IRC14:03
*** bvanhav_ has joined #openstack-nova14:03
*** prateek has quit IRC14:03
*** mdrabe has joined #openstack-nova14:04
*** bvanhav__ has quit IRC14:04
bauzasmriedem: nova meeting ? :)14:05
*** burt has joined #openstack-nova14:05
*** amotoki has joined #openstack-nova14:09
openstackgerritsahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result
openstackgerritsahid proposed openstack/nova: libvirt: ensure live-migration success
*** lpetrut has quit IRC14:11
*** gouthamr has joined #openstack-nova14:11
*** huanxie has joined #openstack-nova14:11
*** eharney has joined #openstack-nova14:11
openstackgerritTanvir Talukder proposed openstack/nova-specs: Support sub-admin roles in Nova
openstackgerritTanvir Talukder proposed openstack/nova-specs: Support sub-admin roles in Nova
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working
openstackgerritStephen Finucane proposed openstack/nova: scheduler: Don't modify RequestSpec.numa_topology
*** liverpooler has quit IRC14:20
*** mlavalle has joined #openstack-nova14:22
*** bvanhav_ is now known as bvanhav14:22
jrollmriedem: yep, will be doing that today14:23
*** baoli has joined #openstack-nova14:23
*** amotoki has quit IRC14:24
openstackgerritTanvir Talukder proposed openstack/nova-specs: Support sub-admin roles in Nova
*** psachin has quit IRC14:28
*** mriedem has quit IRC14:28
*** amotoki has joined #openstack-nova14:29
*** ducttape_ has joined #openstack-nova14:29
*** satyar has joined #openstack-nova14:30
*** smatzek has quit IRC14:30
*** amotoki has quit IRC14:31
openstackgerritClaudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization
*** amotoki has joined #openstack-nova14:33
*** cdent has quit IRC14:34
*** cmartin has joined #openstack-nova14:34
*** tlian has joined #openstack-nova14:34
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working
*** sridharg has joined #openstack-nova14:37
*** tblakes has quit IRC14:37
*** salv-orlando has joined #openstack-nova14:39
*** prateek_ has joined #openstack-nova14:40
artommdbooth, around? Feel like weighing in on a debate between vladikr and I? We're discussing what's the best way to match block devices between the BDM object (in the DB) and the instance XML in libvirt. It used to be done with device name, and I'm changing it to serial (aka volume uuid). Here's the review:
*** prateek has joined #openstack-nova14:41
*** salv-orlando has quit IRC14:41
mdboothartom: Looking14:41
*** salv-orlando has joined #openstack-nova14:41
*** xinliang has quit IRC14:42
*** liverpooler has joined #openstack-nova14:43
*** baoli has quit IRC14:46
*** aslezil_ has joined #openstack-nova14:47
*** gongysh has quit IRC14:48
*** dikonoor has quit IRC14:48
*** tbachman has joined #openstack-nova14:50
openstackgerritMaciej Szankin proposed openstack/nova: config options: remove libvirt imagecache
*** takashin has left #openstack-nova14:55
*** xinliang has joined #openstack-nova14:55
*** sapcc-bot has quit IRC14:56
*** databus23_ has quit IRC14:56
*** sapcc-bot has joined #openstack-nova14:56
*** databus23_ has joined #openstack-nova14:56
*** carthaca_ has joined #openstack-nova14:56
*** yingjun has joined #openstack-nova14:56
openstackgerritIstvan Imre proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication
*** gcb has joined #openstack-nova14:58
*** smatzek has joined #openstack-nova14:58
*** carthaca_ has quit IRC14:58
*** hongbin has joined #openstack-nova14:59
*** lucasagomes has quit IRC14:59
*** lucasagomes has joined #openstack-nova15:00
*** lamt has quit IRC15:02
*** mriedem has joined #openstack-nova15:02
openstackgerritRadoslav Gerganov proposed openstack/nova: Update all instances when their AZ is renamed
*** sree has quit IRC15:02
mriedembauzas: thanks for running the meeting - i had to get my daughter ready for school so the 8am meeting always throws me off15:02
bauzasmriedem: I have the exact same problem for the scheduler meeting15:02
bauzasmriedem: so I understand you15:02
bauzasmy proposal to stop scholarizing my daughter unfortunately got a NACK from my wife :/15:03
*** lamt has joined #openstack-nova15:03
bauzasdon't understand why...15:03
*** sacharya has joined #openstack-nova15:04
mriedemjust send her out during the day and let her learn the lessons of the wild15:04
*** cleong has joined #openstack-nova15:04
bauzasat 6, yeah15:04
*** amotoki has quit IRC15:05
edleafemriedem: drop her off early. That'll toughen her up in Minnesota winters!15:05
*** tblakes has joined #openstack-nova15:05
bauzasI should have a dog by april, I'll teach my daughter how to dog sled15:05
mriedemi had to walk to school at her age in the winter...15:05
mriedemso back in my day...15:05
openstackgerritStephen Finucane proposed openstack/nova: scheduler: Don't modify RequestSpec.numa_topology
jrollshe'll literally get buried trying to walk in the snow up there, that seems unwise15:06
*** tlian has quit IRC15:06
openstackgerritEd Leafe proposed openstack/nova: Remove the Allocation.create() method.
openstackgerritEd Leafe proposed openstack/nova: Add check for invalid allocation amounts
openstackgerritEd Leafe proposed openstack/nova: Fix missing RP generation update
*** sheel has quit IRC15:07
*** huanxie has quit IRC15:07
mriedemlyarwood: just fyi before you see it, i've got a series of backports for newton to make this pass
mriedemi.e. ironic in newton will fail if placement is enabled w/o that series of fixes15:08
*** rama_y has joined #openstack-nova15:08
mriedem is the target fix, but there are several dependent patches before it to keep the diff sane15:08
*** rama_y_ has joined #openstack-nova15:09
*** sacharya has quit IRC15:09
mriedemsome aren't bug fixes, they are refactors, but not new features so shouldn't be too concerning15:09
mriedemwznoinsk: the intel nfv ci job tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial seems to always fail on stable/newton changes - is there something we need to backport to fix that or is it even worth running that job on newton?15:10
*** yingjun has quit IRC15:11
*** yingjun has joined #openstack-nova15:11
mriedemjohnthetubaguy: this is ready for you
mriedemraj_singh: i left a comment in but i'm not sure what, if anything, to do about testing that15:12
*** mfeoktistov has quit IRC15:12
*** jamesdenton has joined #openstack-nova15:13
mriedemraj_singh: it seems like we should at least have a unit test that sets send_service_user_token=True and makes the neutronclient non-admin connection15:13
*** zz_dimtruck is now known as dimtruck15:14
*** tlian has joined #openstack-nova15:15
*** claudiub|2 has joined #openstack-nova15:16
lyarwoodmriedem: ack thanks, I'll try to get to them tomorrow if that's okay, currently stuck downstream fighting fires15:17
mriedemlyarwood: yeah that's fine, just giving you a heads up15:18
lyarwoodmriedem: cheers, likewise there's a few from me with +2 from tonyb if you have a chance15:18
*** claudiub has quit IRC15:19
*** aslezil_ has quit IRC15:19
*** yamahata has joined #openstack-nova15:20
raj_singhmriedem: Ok, Let me look into that. Also the Glance patch I can split into 2, but service token change is just 1 line code change, so I figure to do it in just one patch.15:21
*** cfriesen has joined #openstack-nova15:22
*** jaosorior has joined #openstack-nova15:22
*** yingjun has quit IRC15:23
*** mtanino has joined #openstack-nova15:24
*** roeyc has quit IRC15:25
*** markvoelker has quit IRC15:27
dansmithmriedem: I think bauzas wants you to +W this:
*** jwcroppe has joined #openstack-nova15:28
mriedemhave to run to a meeting15:28
*** yingjun has joined #openstack-nova15:29
*** yingjun has quit IRC15:29
mriedemdansmith: on the placement reconnect backport, there is a change beneath it too15:29
*** yingjun has joined #openstack-nova15:29
dansmithmriedem: oh okay15:29
*** mdrabe has quit IRC15:32
*** mtanino has quit IRC15:36
openstackgerritDan Smith proposed openstack/nova: WIP Move instance creation to conductor
*** mdrabe has joined #openstack-nova15:39
*** sacharya has joined #openstack-nova15:41
*** marst has joined #openstack-nova15:41
openstackgerritMaciej Szankin proposed openstack/nova: Add CPUWeigher
*** Tryn00 has joined #openstack-nova15:42
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged nic attachment
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged volume attachment
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged volume attachment
openstackgerritArtom Lifshitz proposed openstack/nova: API support for tagged device attachment
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged nic attachment
mdboothartom: Is the user able to see 'serial' as known to cinder?15:43
*** mvk has quit IRC15:44
artommdbooth, it's the volume uuid15:44
mdboothBecause if so, they can already find that that volume15:44
mdboothIf present, this specify serial number of virtual hard drive. For example, it may look like <serial>WD-WMAP9A966149</serial>. Not supported for scsi-block devices, that is those using disk type 'block' using device 'lun' on bus 'scsi'. Since 0.7.115:45
mdboothAm I missing something?15:45
mdboothThe user doesn't have to look up the hardware address in metadata, because they can just look for the disk with the given serial15:46
*** yingjun has quit IRC15:46
*** raj_singh_ has joined #openstack-nova15:46
artommdbooth, heh, good point...15:46
artomI don't have an answer for that, but I have another question - can we trust the device name to at least match between instance XML and block_device_mapping in the db?15:47
mdboothartom: That's what I've been looking at15:47
mdboothShort answer is no, we can't15:48
artomThe way our current Tempest test for that is written, we can15:48
artomBut the test definitely doens't cover all possible weird cases15:48
artomAnd I know for volume attachment it didn't match15:48
mdboothe.g. I believe the following will bork it:15:49
mdboothCreate instance with config disk15:49
*** jaypipes has joined #openstack-nova15:49
mdboothattach volume15:49
mdboothAfter reboot/migrate, xml will be rewritten and iirc config disk will be last again15:49
mdboothSo volume name will have changed15:50
*** sridharg has quit IRC15:51
artomThat doesn't sound like it's fixable...15:51
mdboothIn this patch we're entirely rewriting device_metadata if we attach a tagged volume, right?15:51
artommdbooth, yeah15:52
mdboothAny chance of not doing that?15:52
artomYou're thinking we just add the new bdm tag without recalculating everything?15:52
mdboothe.g. just updating it15:52
*** markvoelker has joined #openstack-nova15:52
mdboothWe only created it on line 1212, and we've still got the conf it was created from15:53
mdboothDo we really need to reparse the whole xml?15:53
mdboothHmm, _prepare_device_bus reads assigned hw address...15:53
mdboothSo I guess the answer is yes15:54
artomGlad that worked out without me having to answer ;)15:54
shanerin kilo, when performing a live-migration, it's not showing up when doing a 'migration-list'15:54
shanerbut, doesn't happen in mitaka15:54
mdboothHowever, in this specific case all we need to do is match a single device, which we just added, and parse its assigned hw address15:54
*** gszasz has quit IRC15:55
artommdbooth, would that actually solve the bdm <-> xml match problem though?15:55
mdboothI agree with vladikr that relying on the contents of connection_info is unpleasant, though15:55
mdboothAlthough in this case, if it's not set we do at least have the opportunity to set it15:56
*** bkopilov has quit IRC15:56
*** cdent has joined #openstack-nova15:56
*** aslezil_ has joined #openstack-nova15:58
*** pcaruana has joined #openstack-nova15:58
mdboothartom: Still thinking. Will comment on the review15:59
*** gszasz has joined #openstack-nova15:59
artommdbooth, many thanks :) From what I'm gathering, we have two ways to perform that bdm <-> xml matching (serial and device name), and both won't work 100% of the time15:59
artomSo the question becomes, which one is easier to "fix"?16:00
mriedemmnestratov: can someone from VZ fix up this comment quick?
mriedemmnestratov: otherwise i'm +2 on that change16:00
mriedemmnestratov: nevermind, i'll just update that myself16:01
*** cmartin has quit IRC16:03
*** sudipto has quit IRC16:05
*** sudipto_ has quit IRC16:05
*** sudipto_ has joined #openstack-nova16:05
*** sudipto has joined #openstack-nova16:05
*** nkrinner is now known as nkrinner_afk16:06
*** armax has joined #openstack-nova16:06
mriedem+2 on now16:08
mriedemneeds another core16:08
*** rtheis has quit IRC16:10
*** sacharya_ has joined #openstack-nova16:11
*** Zealoussnow_ has quit IRC16:13
*** sacharya has quit IRC16:14
mriedemdansmith: done on - created a bug for the map_cell0 thing16:14
dansmithmriedem: ack thanks16:14
mriedemdansmith: are you going to make depend on ?16:15
mriedemit seems it has to16:15
mriedemif you're busy i can make that change16:15
*** pradk has quit IRC16:16
dansmithmriedem: no, I was just hoping we'd merge the nova change and then poke sdague16:16
dansmithbut I can if you want16:16
sdaguewhat's up?16:16
mriedemi think we should use the depends-on16:17
*** lpetrut has joined #openstack-nova16:17
dansmithit doesn't get us any testing and probably isn't in danger of merging without us noticing,16:17
dansmithbut .. done16:17
dansmithsdague: this is ready and blocked on the nova change that is required for us to merge it:
dansmithit has survived quite a bit of abuse thus far, so pretty confident :)16:18
*** rama_y_ has quit IRC16:19
*** rama_y has quit IRC16:19
mriedemclaudiub|2: unless you want to make a case for it, i'm going to defer to pike16:19
sdagueyeh, I had an old +2 on it16:19
*** annegentle has joined #openstack-nova16:19
sdaguehow soon do we need a merge for it?16:19
mriedemsdague: no rush i don't think16:19
mriedembauzas: i'm going to move to pike16:20
sdagueok, mtreinish is on a plane to .au today, I'll see if other devstack folks pop up on it16:20
dansmithmriedem: it's not like amazingly urgent,16:20
dansmithbut it certainly helps me get stuff done before I disappear16:20
claudiub|2mriedem: thati is what i'm currently testing at the moment. i'm setting up an environment for it, and i'll try to run the intel pci tempest tests16:20
mriedemclaudiub|2: ok, i'll hold off then16:20
mriedemdansmith: ok16:20
mriedemi think we could get it in by eod then16:20
*** Tryn00 has quit IRC16:21
*** READ10 has joined #openstack-nova16:21
*** manasm has joined #openstack-nova16:21
*** salv-orl_ has joined #openstack-nova16:23
*** cmartin has joined #openstack-nova16:24
*** _ducttape_ has joined #openstack-nova16:24
*** prateek_ has quit IRC16:24
*** prateek has quit IRC16:25
cmartinHey could somebody unabandon this patch for me so I can work on it?
mriedemcmartin: done16:25
*** salv-orlando has quit IRC16:26
cmartinmriedem: thanks16:26
*** ducttape_ has quit IRC16:27
openstackgerritChristopher Martin proposed openstack/nova: Stop using mox in unit/virt/disk/
mriedemsean-k-mooney: fyi that os-vif 1.4.0 breaks the nova unit tests, seen here :
*** prateek has joined #openstack-nova16:30
*** prateek_ has joined #openstack-nova16:30
mriedemlooks like 'vif_name': u'nicdc065497-3c' is new16:31
*** markus_z has quit IRC16:33
*** bkopilov has joined #openstack-nova16:33
*** _ducttape_ has quit IRC16:34
mriedemhmmm, so the nova unit test is going to need to transform the object to it's known good version, which would be 1.016:34
*** ducttape_ has joined #openstack-nova16:35
*** links has quit IRC16:37
*** ociuhandu has quit IRC16:38
mnestratovmriedem: hi16:39
mnestratovmriedem: sorry, just saw your message16:39
*** mtanino has joined #openstack-nova16:39
*** tojuvone has quit IRC16:40
*** tojuvone has joined #openstack-nova16:41
mnestratovmriedem: thanks for fixing the review for us )16:42
*** aslezil_ has quit IRC16:43
*** rama_y_ has joined #openstack-nova16:44
*** rama_y has joined #openstack-nova16:44
*** andreas_s has quit IRC16:44
mdboothartom: It occurs to me that we don't call _build_device_metadata often enough16:47
mdboothWe need to call it every time we regenerate libvirt domain xml, because all hw address will change every time we do that16:47
*** sneti has joined #openstack-nova16:51
*** bvanhav has quit IRC16:52
openstackgerritMatt Riedemann proposed openstack/nova: WIP: Make unit tests work with os-vif 1.4.0
mriedemdansmith: jaypipes: i've got a problem with ^ because of
mriedemi'm backporting the VIFHostUser object to 1.0 but it's nested 'network' object isn't getting backported recursively16:53
mriedemwell, i think it's trying, but there is no rule for it16:53
mriedemi do see this though
*** dtp has joined #openstack-nova16:54
*** sneti has quit IRC16:54
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working
dansmithmriedem: is it calling super in make compatible?16:59
mriedemdansmith: yup16:59
dtpdo i understand your comment on that instead of relying on the mapping being there, we need to rely instead on cells.enable setting?16:59
mriedemlooks like _obj_relationships_for doesn't have a manifest on the thing i'm backporting16:59
dansmithmriedem: does the manifest call for the older version/16:59
*** abalutoiu has quit IRC16:59
mriedemwhere does the manifest get set on the object?17:00
*** gszasz has quit IRC17:00
mriedemoh i see it doesn't have a manifest17:00
mriedemso it tries to use the old school self.obj_relationships[field]17:00
dansmithdtp: which comment?17:00
mriedemand we don't have a rule for it17:00
dtpdansmith the commit message at the top17:00
dansmithmriedem: yeah, manifest is just passed into the call, not stored anywhere17:00
dansmithdtp: we need to ignore the fact that the mapping is in place, if we're still on cellsv1, so that we don't bypass the replication and go straight to the cell database, which might have not-yet-replicated stuff in it17:01
dtpok, thank you17:01
mriedemok so i need to call obj_make_compatible_from_manifest() instead and provide my own manifest on how to handle this nested field?17:02
dansmithdtp: cells.enable is really cellsv1.enable17:02
dtpyeah i have that burned to my brain roms :D17:02
*** manasm has quit IRC17:03
mdboothartom: Replied.17:03
* mdbooth has to go get his car before the garage shuts.17:03
*** mjura has quit IRC17:05
*** unicell has quit IRC17:07
*** mtani____ has joined #openstack-nova17:07
*** sudswas__ has joined #openstack-nova17:07
*** mtanino has quit IRC17:07
*** sudipto_ has quit IRC17:07
*** xek has quit IRC17:07
*** sudipto has quit IRC17:08
*** xek has joined #openstack-nova17:08
*** sudipto has joined #openstack-nova17:08
edleafeCan someone explain the failure here:
*** bvanhav has joined #openstack-nova17:10
*** medberry has quit IRC17:10
edleafeIt seems all the tests passed, but the returncode was 117:10
*** sheel has joined #openstack-nova17:11
mriedemedleafe: this looks odd
mriedem2017-01-12 15:25:20.506 4337 INFO nova.osapi_compute.wsgi.server [req-471b1e60-9717-479e-a053-06834d8fe63f fake fake - - -] (4337) wsgi exited, is_accepting=True17:11
jaypipesmriedem: lookin...17:12
*** aloga has quit IRC17:12
*** aloga has joined #openstack-nova17:12
*** ralonsoh_ has quit IRC17:13
*** browne has joined #openstack-nova17:13
*** raunak has joined #openstack-nova17:13
edleafemriedem: odd is a good word17:13
*** med_ has joined #openstack-nova17:14
*** med_ is now known as Guest8778317:14
*** Swami has joined #openstack-nova17:14
*** chyka has joined #openstack-nova17:15
jaypipesmriedem: ah, yeah... I ran into similar recently when trying to add a UUID field to the NUMACell object. Objects that had their versions changed but never got an obj_make_compatible() method run into this failure. To fix, you need to manually set the obj_relationships class attribute on the object in osvif :(17:18
mriedemwhat's really crazy,17:18
mriedemwhen this test was added to nova
jaypipesmriedem: we aren't yet sending osvif objects over the wire, though, so it may be we could do a hack of the object manifests with dansmith's help?17:19
mriedemit's setting the vif_name which passed even though vif_name wasn't a field on that type in os-vif 1.3.0 which is what we were testing against17:19
mriedemso...i guess when the test converts it to a primitive,17:19
mriedembecause vif_name wasn't a 'registered' field it just excluded it?17:19
mriedemso the equality check was ok?17:20
mriedemif that's the case, i'm not sure why vif_name isn't showing up on the actual object when we do the compare with os-vif 1.4.0
jaypipesmriedem: vif_name is a field:
mriedemjaypipes: these have obj_make_compatible methods17:21
dansmithjaypipes: obj_relationships should not be used anymore17:21
mriedemjaypipes: vif_name wasn't a field in VIFHostUser until 1.117:21
jaypipesdansmith: yeah, I know, but I found no other way to fix that bug.17:22
mriedemand ^ was just released in os-vif 1.4.017:22
jaypipesmriedem: ah.'17:22
jaypipesmriedem: you sure about that?
jaypipesmriedem: shows added in 2015.17:22
mriedemjaypipes: on which object?17:23
mriedemwe're not dealing with vif generic or bridge,17:23
mriedemit's VIFHostUser17:23
mriedemthat adds the vif_name field to VIFHostUser and bumps it's version to 1.1, and that change is released in os-vif 1.4.0, which is now breaking nova unit tests17:24
mriedembecause vif_name is in our expected object on the nova side, but it's not in the actual obj we're getting from os-vif for some reason17:24
jaypipesmriedem: hmm, yes, you're totally correct.17:25
mriedemeven though both primitives are showing17:25
mriedem'': 'VIFVHostUser',17:25
mriedem'versioned_object.version': '1.1'}17:25
jaypipesyup you're right.17:25
*** rama_y has quit IRC17:26
*** rama_y_ has quit IRC17:26
jaypipesmriedem: weird... I wonder how ever worked then?17:26
mriedemwell that seems straight forward17:27
jaypipesmriedem: sorry, I mean how the nova side didn't break when that was merged...17:28
mriedemyou mean when vif_name didn't exist in VIFHostUser?17:28
mriedemi assume because it's not a registered field so the obj_to_primitive() ignored the field17:28
*** mnestratov|2 has joined #openstack-nova17:28
mriedemso it wasn't in the primitive17:28
mriedemyou can set random attributes on versioned objects17:28
mriedembut the only thing that goes into the primitive is the fields17:29
mriedemwhich in VIFHostUser 1.0 when that test was written didn't have a vif_name field17:29
mriedemso it wouldn't be in the primitive and the nova test passed17:29
jaypipesthat are in the manifest for that version, yes.17:29
mriedemunless i'm mistaken there isn't a manifest used in any of these tests17:29
*** moshele has quit IRC17:30
*** mnestratov has quit IRC17:31
mriedemi think i have an easier fix than what i was trying17:33
jaypipesmriedem: so I'm looking at that output in the console log from the unit test failure. really weird that the actual object has a version of 1.1 but doesn't include the vif_name field...17:33
jaypipesmriedem: I mean, version 1.1 added the vif_name field and nothing else, no? so if it knows of the 1.1 object version, there should be a vif_name field.17:34
mriedemjaypipes: right17:34
mriedemi don't get that at all17:34
*** pradk has joined #openstack-nova17:34
*** gouthamr has quit IRC17:35
mriedemunless it's somehow thinking it needs to backport to 1.0 for some reason17:35
mriedembut i don't see anything telling it to do that17:35
openstackgerritMatt Riedemann proposed openstack/nova: Make unit tests work with os-vif 1.4.0
mriedemso ^ should fix the nova test, but i'm kind of worried about what's actually going on on the os-vif side17:39
*** BobBall is now known as BobBall_AWOL17:40
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements
jaypipesmriedem: will try to look into this further in a bit. have meetings currently..17:41
mriedemok, i'm going to get some lunch17:41
*** tlian has quit IRC17:42
*** tlian has joined #openstack-nova17:42
*** yamahata has quit IRC17:43
*** derekh has quit IRC17:43
*** claudiub has joined #openstack-nova17:46
*** sahid has quit IRC17:47
*** karthiks has quit IRC17:48
*** gouthamr has joined #openstack-nova17:49
*** lucasagomes is now known as lucas-afk17:50
*** claudiub|2 has quit IRC17:50
*** owalsh has quit IRC17:51
armaxmriedem: hi17:54
armaxmriedem: do you happen to know if these types of errors are expected?17:54
armaxor maybe jaypipes?17:55
dansmitharmax: they are early in the run yeah17:56
dansmithI mean, they shouldn't be making a big fuss like they are, but...17:56
armaxdansmith: ok17:56
dansmitharmax: but17:57
dansmitharmax: a bit down, it says placement isn't responding, which should't be right unless placement isn't configured for this test, just a sec17:57
dansmitharmax: ah yeah no placement in that test, which is why you see the warnings17:58
*** nic has joined #openstack-nova17:58
mriedemarmax: it's because placement isn't up yet17:58
armaxdansmith: I haven’t looked much deeper than this log file17:58
mriedemdevstack starts n-cpu before placement17:58
*** jose-phillips has joined #openstack-nova17:58
armaxmriedem: I see17:58
mriedemthere is placement in this job
mriedemit's on by default in all jobs in master17:58
mriedemit's just the startup order of the services17:58
dansmithoh it's not in a screen, right17:58
dansmithdidn't see the log, but forgot it was under apache17:59
mriedemarmax: what i did notice yesterday was this
mriedemarmax: ^ has started showing up a lot, it's not new either apparently17:59
dansmithmriedem: but there are warnings much later in the run about not being able to contact placement17:59
dansmithI guess it's only a minute later18:00
openstackgerritJohn Garbutt proposed openstack/nova: Extract preallocate_for_instance
openstackgerritJohn Garbutt proposed openstack/nova: Pass objects into _update_ports_for_instance
openstackgerritJohn Garbutt proposed openstack/nova: Stop passing network when you only need dns_domain
mriedemNeutron client was not able to generate a valid admin token, please verify Neutron admin credential located in nova.conf18:02
armaxmriedem: let me look into that18:02
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working
mriedemarmax: ok i'll report a bug for it too just to track it18:02
armaxmriedem: cool18:03
*** prateek_ has quit IRC18:05
openstackLaunchpad bug 1656056 in OpenStack Compute (nova) "NeutronAdminCredentialConfigurationInvalid all over n-cpu logs in successful gate runs during network teardown" [High,Confirmed]18:06
*** lpetrut has quit IRC18:06
*** unicell has joined #openstack-nova18:07
mriedemarmax: ?18:08
*** mvk has joined #openstack-nova18:09
*** ociuhandu has joined #openstack-nova18:09
mriedemnvm that's not released yet18:10
*** roeyc has joined #openstack-nova18:11
*** efried has quit IRC18:11
mriedemcould also be this
*** rama_y_ has joined #openstack-nova18:13
*** rama_y has joined #openstack-nova18:13
*** weshay is now known as weshay_bbiab18:13
*** efried has joined #openstack-nova18:14
openstackgerritRafael Folco proposed openstack/nova: DELETE all inventory for a resource provider
*** sacharya has joined #openstack-nova18:17
*** sacharya_ has quit IRC18:17
*** slaweq has quit IRC18:17
openstackgerritJohn Garbutt proposed openstack/nova: WIP: Call preallocate_for_instance before scheduler
openstackgerritJohn Garbutt proposed openstack/nova: WIP: introduce preallocate_for_instance method.
*** slaweq has joined #openstack-nova18:19
*** yamahata has joined #openstack-nova18:22
*** ijw_ has quit IRC18:24
*** raj_singh_ has quit IRC18:26
*** raj_singh_ has joined #openstack-nova18:27
*** efried has quit IRC18:28
*** bvanhav_ has joined #openstack-nova18:30
*** bvanhav has quit IRC18:30
openstackgerritDan Smith proposed openstack/nova: WIP: Make api_samples tests use simple cell environment
openstackgerritDan Smith proposed openstack/nova: WIP Move instance creation to conductor
*** liangy has quit IRC18:31
*** openstackgerrit has quit IRC18:33
sean-k-mooneymriedem: regarding the os-vif 1.4 release are the only failing test in or are there others18:33
mriedemsean-k-mooney: i'm trying to fix it here
sean-k-mooneyif its just effecting that is because the upperconstraits is not allowing 1.4 to be used18:34
mriedembut that's failing with something different now:
*** pcaruana has quit IRC18:34
*** lpetrut has joined #openstack-nova18:34
sean-k-mooneylooking at you fix18:34
mriedemsean-k-mooney: there is some earlier scrollback conversation between myself and jaypipes where i don't really understand what's going on in the original failure, i.e. we're getting a 1.1 VIFHostUser object from os-vif but it doesn't have the vif_name field set in the primitive18:35
mriedemwhich doesn't make any sense to me18:36
sean-k-mooneythat is strange. does it only get added if it is used?18:36
sean-k-mooneywe are not currently using the vif_name field as we havent gone to 1.4 yet18:37
mriedemsean-k-mooney: ah yeah18:37
mriedem            if self.obj_attr_is_set(name):18:37
mriedem                primitive[name] = field.to_primitive(self, name,18:37
mriedem                                                     getattr(self, name))18:37
*** READ10 has quit IRC18:38
sean-k-mooneymriedem: the issue is even with the version bump in nova in that change the upperconstrains is downgrading to 1.3.018:39
sean-k-mooneyso untill the upper-constraints patch merges the tests wont pass18:40
sean-k-mooneythe upper-constratins is downgrading below the minium set in nova's requirements.txt18:40
sean-k-mooneyif we merge teh upperconstraints change the test should pass then we can raise the minium in the global requirements18:41
mriedemsean-k-mooney: i really thought the u-c and g-r changes would be in the same patch18:41
sean-k-mooneythe were in my patch18:41
sean-k-mooneybut i abandoned it becase francesco had one open too18:42
sean-k-mooneyhis just raised the gloabl requirements patch and there was a seperate patch for upper constraints18:42
sean-k-mooneymriedem:  global reques upper constraitns
mriedemyeah i know, which now depends on the nova fix18:44
*** efried has joined #openstack-nova18:44
mriedemwhich fails
mriedemoslo_versionedobjects.exception.ObjectActionError: Object action obj_make_compatible failed because: No rule for port_profile18:44
*** sajeesh has joined #openstack-nova18:44
*** efried has quit IRC18:45
mriedemi'm not sure where ^ is coming from18:45
mriedemi assume it's VIFBase18:45
sean-k-mooneyneither am i i dont recall any changes related to the port_profile18:46
mriedemi could just be i need to pass a manifest in for the backport conversion18:46
sean-k-mooneyi still think merging would resolve the conflict but ill dig a little deeper18:46
dansmithmriedem: see that test example I pointed you to?18:46
mriedemdansmith: i couldn't really make heads or tails of that18:47
dansmithmriedem: it passes in a manifest of what it wants the system to think the remote looks like18:47
mriedemsean-k-mooney: it's a chicken and egg, we can't merge
mriedembecause the nova unit tests are failing in that chnage18:47
dansmithmriedem: in that test it mocks get_versions or whatever, but there are others in there that just pass a manifest with one or two object versions18:47
sean-k-mooneyyour right hum ok im just trying to figure out what is different between them.18:49
sean-k-mooneyah the 'vif_name': u'nicdc065497-3c'18:50
mriedemsean-k-mooney: yeah :)18:50
mriedemit's in the expected object from the nova test, but not in the actual object from the os-vif side18:50
mriedemwhich is weird because it's version on the object is 1.118:50
mriedemwhich was the version when vif_name was added to VIFHostUser18:51
mriedemoh but you said,18:51
*** lpetrut has quit IRC18:51
sean-k-mooneythe expect result is incorrect as before os-vif 1.4 that field did not exist18:51
mriedemwe don't use that yet?18:51
mriedemsean-k-mooney: yeah that's another thing i noted earlier18:51
mriedemand removed in my fix patch,18:51
mriedembut maybe that's just the fix?18:51
*** tesseract has quit IRC18:51
mriedemi'll try that out as i have a recreate locally18:52
sean-k-mooney is the change that should add the vif_name to the unit test18:52
mriedemok, well just removing vif_name makes it work18:52
mriedemso i'll cleanup my patch18:52
sean-k-mooneyso if you remove it now it can be reintoduce in when the filed actully exists in the os-vif object18:53
sean-k-mooneythis is related to a previous conversation i had with danile berange about the fact that oslo versioned objects allows you to set filds in objecst that are not in the defined set of fields18:54
mriedemyeah...i remember that18:56
mriedemwe use it to our advantage at times in nova,18:56
mriedemfor fields we want to set in the nova-net layer for example and then those are used in the nova-api layer, but aren't persisted in the nova db18:56
mriedemi think i had mentioned at some point about changing ovo to add a flag to be strict about which attributes can be set18:57
*** openstackgerrit has joined #openstack-nova18:57
openstackgerritMatt Riedemann proposed openstack/nova: Make unit tests work with os-vif 1.4.0
sean-k-mooneyyes you had. by the way i just book my ptg flights/hotel. one thing i would like to add to os-vif is a dsvm gate to increase the level of testing.18:57
*** slaweq has quit IRC18:58
mriedemwant to throw that in ?18:58
sean-k-mooneyim not sure it would have caught this but it would be better to have some intergration testing of os-vif18:58
*** dtp has quit IRC18:58
sean-k-mooneyam sure. should i add a generic os-vif section or just os-vif gateing18:59
sean-k-mooneythere is also the topic of neutron intergration18:59
sean-k-mooneyi would like to complete that in pike also18:59
*** ijw has joined #openstack-nova18:59
*** ijw has quit IRC19:00
mriedemsean-k-mooney: i think there is a job in the nova experimental queue that already does that19:00
*** ijw has joined #openstack-nova19:00
sean-k-mooneymriedem: perhaps. i would like to add a job to os-vif though that tested with the head of nova/neutron master too with the os-vif change19:01
mriedemi think that's what that job does19:01
*** lpetrut has joined #openstack-nova19:01
mriedemexport PROJECTS="openstack/os-vif $PROJECTS"                                          export DEVSTACK_LOCAL_CONFIG+=$'\n'"LIBS_FROM_GIT=os-vif"19:02
sean-k-mooneyyes but that only runs on chnage to nova19:02
*** dharinic is now known as dharinic|lunch19:02
mriedemsean-k-mooney: you just have to add that job to the os-vif template in layouts.yaml then19:02
sean-k-mooneyi would like to basically add that jobe to the check pipeline for os-vif19:02
mriedemif you want to run that job on os-vif19:02
mriedemthen make it so :)19:02
mriedemhonestly i don't know why danpb didn't do that originally19:02
mriedemyou can cancel your PTG flight and hotel now, problem solved :)19:03
sean-k-mooneyok i will, should i add it to check experimental first to make sure it works.19:03
mriedemin os-vif? that's probably not a bad idea19:03
sean-k-mooneymriedem: i have some other things to adress too :) but that is one less item19:03
mriedemgoes in here somewhere
sean-k-mooneymriedem: ok ill submit a patch to add it to check experimental and then do some testing. if it works ill move it to the main check pipeline for os-vif19:04
*** sudipto has quit IRC19:05
*** sudswas__ has quit IRC19:05
*** ociuhandu has quit IRC19:05
mriedemjroll: i just remembered
mriedemyou might want to get that in before you request an ironicclient release, or just know you'll have to do two19:06
jrollmriedem: yep, it's on my list19:07
mriedemsean-k-mooney: is happy now19:07
mriedemso u-c should be good soon19:08
sean-k-mooneycool glad the solution was found before any of the requirements go bumped.19:08
mriedemmelwitt: i'm +2 on dan's bottom change now for cells v1 glory
EmilienMdansmith, mriedem: I have a good news19:12
mriedemthere is a nit in one of the code comments that could be addressed on top of that change19:12
EmilienMthe patch in nova that fixed the placement retry thing, works very well19:12
mriedem0 days without a TripleO incident?!19:12
EmilienMyou can see it in the logs19:12
EmilienMfirst it fails
EmilienMthen it works
EmilienM(thx again)19:12
mriedemon a side note,
EmilienMmriedem: mhh, is it placement endpoint not reachable from creds in [placement] ?19:15
EmilienMoh no I know19:15
EmilienMlet me confirm, a sec19:15
mriedemmy guess is bad auth_plugin?19:16
mriedemplacement.auth_type            = password19:16
mriedemi guess i don't know19:16
EmilienMthe keystone stuff were created *after* starting nova compute19:16
EmilienMbut thanks to the retry, we don't care19:17
EmilienMbecause it retries and works a few min later19:17
mriedemyeah we just don't want the stacktrace19:17
mriedemanyway it's a low-priority bug for nova to handle that
openstackLaunchpad bug 1656075 in OpenStack Compute (nova) "DiscoveryFailure when trying to get resource providers from the scheduler report client" [Low,Confirmed]19:17
EmilienMmriedem: "Created resource provider record via placement API for resource provider with UUID 5c4bb2d9-60bd-46e3-bb2a-eb6730932c63 and name centos-7-osic-cloud1-s3500-6631948."19:17
* jaypipes reading back...19:17
EmilienMmriedem: I think this ^ means keystone auth worked at some point19:18
mriedemEmilienM: yes it did19:18
mriedemwe handle some known KSA failures when trying to make a connection to the placement endpoint,19:18
*** efried has joined #openstack-nova19:18
mriedembut there are many ways KSA can fail and we don't handle them all apparently19:18
mriedemjaypipes: dansmith: is good to go19:19
mriedemthe upper-constraints job passed on that
*** rama_y has quit IRC19:19
*** rama_y_ has quit IRC19:19
*** sajeesh has quit IRC19:20
mriedemsdague: you said mtreinish is en route to AU?19:21
mriedemsdague: because we're good with now19:21
sdaguemriedem: yeh19:21
mriedemtime to rassle up some other devstack cores19:21
jaypipesmriedem: wallaby'd. amazing how simple a fix was in the end..19:22
mriedemjaypipes: yeah, plus stepping away for lunch helped19:22
sdaguemriedem: honestly, it's a really small straight forward change. I'll just approve19:22
mriedemsc68cal: you know you're my favorite person in the world right?
jaypipesmriedem: was it really just a matter of the expected and actual being reversed in the console.log test output and that confusing us?19:22
mriedemjaypipes: no that wasn't it19:22
dansmithsdague: plus it's me, so it's obviously bug-free19:23
mriedemjaypipes: it was in the expected because the nova test put it in there explicitly19:23
mriedemjaypipes: it was'nt in the actual because the field wasn't set on the actual object19:23
jaypipesmriedem: gotcha.19:23
mriedemso it was omitted from the actual primitive19:23
mriedemand kablammo19:23
jaypipesmriedem: strange about the version being 1.1 in both actual and expected, though, no?19:23
mriedemjaypipes: in this case it was using the latest object so i think 1.1 is expected,19:24
jaypipesor do I just need to re-caffeinate?19:24
mriedemjaypipes: no it was this
mriedemnothing in nova was setting that field yet19:24
mriedemso ovo didn't include it in the actual primitive19:25
*** weshay_bbiab is now known as weshay19:25
mriedemsdague: if you're feeling saucy you could hit the dependent nova change too
* dansmith steps back so as not to get splashed on19:27
* jaypipes goes back to rebasing yet another resource providers patch19:27
sean-k-mooneyjaypipes: it was a sutble bug but mriedem fix resolves it. the nova tests should not have been setting the vif_name when it was not a field in the ovo19:28
*** nicolasbock has quit IRC19:28
sean-k-mooneyjaypipes: mriedem  i just opend the reviews for adding gate-tempest-dsvm-nova-os-vif-ubuntu-xenial-nv to the experimental and then check pipelines for os-vif19:29
sean-k-mooneyjaypipes: mriedem and
sean-k-mooneyill set the workflow to - one on moveing it to check untill i have tested it.19:30
*** nicolasbock has joined #openstack-nova19:31
*** tbachman has quit IRC19:34
*** roeyc has quit IRC19:35
bauzasjaypipes: given maybe you could just +2/+W ?19:36
*** tbachman has joined #openstack-nova19:37
*** satyar has quit IRC19:37
*** rama_y has joined #openstack-nova19:38
*** rama_y_ has joined #openstack-nova19:38
*** migi has quit IRC19:39
mriedembauzas: i'm going to get that one this afternoon19:39
mriedemsorry it's taking awhile, i keep getting distracted19:40
bauzasmriedem: <319:40
*** lucas-afk has quit IRC19:41
sdaguemriedem: done19:42
*** lucasagomes has joined #openstack-nova19:44
openstackgerritClaudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization
mriedemsdague: thanks19:45
*** dtp has joined #openstack-nova19:51
*** dharinic|lunch is now known as dharinic19:54
*** salv-orl_ has quit IRC19:54
jaypipesbauzas: I told mriedem yesterday I didn't feel comfortable +2/W'ing that one because I co-authored it...19:56
jaypipesbauzas: was hoping either mriedem or dansmith might have a chance to review it.19:56
bauzasno worries19:56
*** liangy has joined #openstack-nova20:01
*** artom has quit IRC20:01
*** artom has joined #openstack-nova20:01
*** salv-orlando has joined #openstack-nova20:01
*** liangy has quit IRC20:01
*** raj_singh_ has quit IRC20:02
*** raj_singh has left #openstack-nova20:03
*** raj_singh has joined #openstack-nova20:03
*** kaisers_ has quit IRC20:05
mriedemi've got a fresh cup of coffee20:05
mriedemso it's time20:05
-openstackstatus- NOTICE: Gerrit will be offline between now and 20:30 for scheduled maintenance:
*** ChanServ changes topic to "Gerrit will be offline between now and 20:30 for scheduled maintenance:"20:08
mriedemha saved by the project rename bell20:10
*** tjones has joined #openstack-nova20:12
*** slaweq has joined #openstack-nova20:12
openstackgerritMario Villaplana proposed openstack/nova: Add ironic security group support to support matrix doc
melwittdansmith: thanks for reviewing the quota objects migration. I hadn't seen an online migration done in a transaction before. how is it done? by passing a session to the methods?20:15
*** Sukhdev has joined #openstack-nova20:18
*** abalutoiu has joined #openstack-nova20:19
mriedemmelwitt: i believe he's en route20:25
mriedemto the great white north20:25
mriedemmelwitt: can't that be done by using the @db_api.pick_context_manager_writer decorator?20:27
melwittmriedem: oh, thanks. I didn't know he left already20:27
melwittmriedem: I think so, if all the calls stay under one decorator. I have a loop that calls a method that is already decorated, so I guess if I break that out into a separate undecorated function, I could decorate the loop one and a non-loop one separately20:30
cfriesenI'm in the great white north, it's -18F right now.  Looking forward to Atlanta.20:30
melwittyikes -18F20:32
sean-k-mooneymelwitt: you can have multple decorators on the same fuction/class20:32
sean-k-mooneymelwitt: unless you ment it is allready decoated with @db_api.pick_context_manager_writer20:33
-openstackstatus- NOTICE: Updated: Gerrit will be offline until 20:45 for scheduled maintenance (running longer than anticipated):
*** ChanServ changes topic to "Updated: Gerrit will be offline until 20:45 for scheduled maintenance (running longer than anticipated):"20:33
*** kaisers_ has joined #openstack-nova20:34
melwittsean-k-mooney: yeah, I mean the "create in db" method is already decorated with @db_api.pick_context_manager_writer and there's a loop doing several "create in db". so to do all of them in one transaction, I thought I have to move the decorator, or can they be nested? I hadn't seen nesting before20:36
sean-k-mooneyi dont know. if the decorate is opening the transation then it will do so when you enter the fucntion so all the actions in the loop should be in one transation20:38
sean-k-mooneythat said i have not read the code you are refering too20:38
sean-k-mooneyand gerrit is currently down so that is just a guess20:38
melwittsean-k-mooney: yeah, that's my understanding. I was thinking I can't just slap another decorator on the outside of the loop when there's one already on the method I'm calling (so that they nest). I'm not sure though20:40
sean-k-mooneyah ok can you apply decoratos to loops directly? i have never tried that before20:41
melwittso I was thinking I would have to create a small wrapper function with the decorator for when I want to call it non-loop and move the decorator there20:41
melwittno, sorry, I meant apply the decorator to the outer function. the one that is doing a loop20:42
mriedemmelwitt: i'd ask rpodolyaka20:42
sean-k-mooneyah ok. ya without seeing the code or trying it im not sure either20:43
mriedemi see some stuff in the transaction factory code that looks like it can pull an existing session from the context20:43
*** bvanhav_ has quit IRC20:44
melwittthis is what it looks like, snippet
openstackgerritSarafraj Singh proposed openstack/nova: Add service_token for nova-neutron interaction
melwittI haven't seen any nesting in db/sqlalchemy/api before, so I thought it wasn't a thing20:45
rpodolyakamelwitt: they can be nested - the inner calls will participate in the ongoing transaction20:46
melwittrpodolyaka: ah, thank you. that makes it easy then20:46
openstackgerritSarafraj Singh proposed openstack/nova: DNM: Test service token
rpodolyakamelwitt: they only thing you can't do is to go from async to writer, writer -> writer is fine20:47
melwittgotcha, learned something new20:48
sean-k-mooneyok cool so each of the _create_limit_in_db will inherit the transaction from migrate_quota_limits_to_api_db and unless they all complete succefully they will all be rolled back20:49
melwittyeah, that was the suggestion in the review20:51
rpodolyakaah, there is one catch, though20:51
sean-k-mooneywell the outer trasaction will not be commited unless all the inner creates that inherit it complete sucessfully rather then rolling back if it fails20:51
sean-k-mooneyrpodolyaka:  :) and that is?20:51
rpodolyakawhen is raised db_exc.DBDuplicateEntry the transaction must be rolled back20:51
mriedemgerrit is back btw20:52
rpodolyakaso I guess what you want in is SAVEPOINT's20:52
rpodolyakaor independent transactions20:52
sean-k-mooneyok so in migrate_quota_limits_to_api_db you need to catch db_exc.DBDuplicateEntry and roleback?20:53
melwitthere's the actual review now that gerrit is back
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. Please see:"20:53
rpodolyakasean-k-mooney: you can, but you'd effectively roll back limits saved for previous iterations of the loop20:54
rpodolyakayou could use the savepoint() modifier -
rpodolyakato create a SAVEPOINT for each iteration of the loop20:56
rpodolyakaso that ROLLBACK happens only for the one that caused DuplicateError20:56
melwittoh, cool20:57
sean-k-mooneyis that the intended behavior or if you have a duplicatate shoudl they all be roled back?20:59
sean-k-mooneye.g. is a partal migration with removal of duplicate the desired outcome20:59
melwittduplicate should just be passed over/ignored21:01
*** jwcroppe has quit IRC21:01
*** david-lyle has quit IRC21:01
sean-k-mooneyok cool just checking :)21:01
melwittignored for writing to the api db, and should be deleted from the main db if present21:01
*** david-lyle has joined #openstack-nova21:02
*** prateek has quit IRC21:04
*** browne has quit IRC21:05
dansmithmelwitt: what mriedem said yeah21:14
*** eharney has quit IRC21:15
dansmithmelwitt: just a method that is "take this list of stuff and jam it into place" that is wrapped in one decorator will ensure that they all get applied or none do21:15
ildikovmriedem: hi21:15
*** tbachman has quit IRC21:16
ildikovmriedem: I'm trying to test the new Cinder API with Nova and experiencing odd things, which might be because of API microversioning in Cinder in the sense of something might be missing on the Nova side21:16
*** openstackgerrit has quit IRC21:18
ildikovmriedem: I'm less familiar with how microversioning works between OpenStack services. Is there anything I should theoretically set up in Nova to have the calls towards the latest Cinder API microversion work?21:18
mriedembauzas: cdent: jaypipes: edleafe: posted some comments in the resource providers handler code for
mriedemthe -1 is really about the fact that i think we're making a backward incompatible change21:19
*** adisky_ has quit IRC21:19
*** avolkov has quit IRC21:19
mriedemildikov: i'd expect cinderclient to be passing any microversion header to cinder api when using the v3 client21:19
melwittrpodolyaka: do I need savepoint considering DBDuplicateEntry is caught and ignored in the loop? or does it still cause some sort of rollback to happen?21:20
ildikovmriedem: the same call succeeds if I call it from the Cinderclient and fails if I call it from Nova21:20
*** ducttape_ has quit IRC21:20
mriedemildikov: do you have the cinderclient call output with --debug?21:21
*** ducttape_ has joined #openstack-nova21:21
mriedemto see the headers?21:21
rpodolyakamelwitt: it still does - the fact that it was raised in the first place means that a DB query failed with an integrity error - you need to rollback a transaction at this point21:21
melwittrpodolyaka: oh, I see. thanks21:22
rpodolyakathe only way to avoid that is to create a SAVEPOINT before the potential fail21:22
ildikovmriedem: I have now :)21:23
bauzasmriedem: you mean ?21:24
mriedembauzas: yup21:24
*** dimtruck is now known as zz_dimtruck21:24
bauzasmriedem: accepted21:25
ildikovmriedem: that contains the API microversion21:25
dansmithrpodolyaka: but we want it to roll back all the way in this case21:25
mriedemildikov: can you put it into a paste?21:25
dansmithrpodolyaka: so no savepoint, as you said21:25
*** hamzy has quit IRC21:25
melwittdansmith: I thought we just wanted to skip duplicates? and commit all the non-duplicates in one transaction21:25
bauzasmriedem: so, about the member_of query21:26
dansmithmelwitt: sure, but if something else happens you want to unwind all of them21:26
bauzasmriedem: we first added the member_of field in allowed_filters without microversing it21:26
*** smatzek has quit IRC21:27
dansmithmelwitt: otherwise you've got some moved and not others, which will make the code start to look at just the subset, instead of going back to the main db while you figure out what to do21:27
ildikovmriedem: here it is:
bauzasmriedem: so, before that, we were not accepting member_of and then we accepted it21:27
*** browne has joined #openstack-nova21:27
melwittdansmith: yeah, I guess I'm confused about what happens then if we don't use a savepoint and get a duplicate, that it would rollback the entire transaction?21:27
*** openstackgerrit has joined #openstack-nova21:27
openstackgerritSarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client.
bauzasmriedem: for both 1.0 and 1.121:27
openstackgerritSarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client.
dansmithmelwitt: you're ignoring duplicates, right?21:28
melwittdansmith: yeah, but rpodolyaka said it would still roll back everything?21:28
bauzasmriedem: and then, cdent added the v1.3 microversion for still accepting member_of even if that was not this version21:28
*** ducttape_ has quit IRC21:28
dansmithmelwitt: no, he said it would roll back everything if you allow an exception to be raised,21:28
bauzaswhich is IMO terrible but okay21:28
dansmithwhich is what we want for everything other than dupes, which you catch and swallow21:28
cdentwe discussed it at length and decide that it impacted approximately zero real people21:29
*** ducttape_ has joined #openstack-nova21:29
rpodolyakadansmith: the problem is that you can't have one transcation and swallow duplicate errors21:29
melwittdansmith: yeah, I actually asked if I still need savepoint considering I'm catching and ignoring DBDuplicateEntry and the answer was yes. maybe there's a misunderstanding21:29
ildikovmriedem: this is the n-api log for the same attachment-create call:
rpodolyakaunless you use savepoints21:29
rpodolyakabut the rollback in the outer transcation will still rollback everything21:29
bauzascdent: mriedem: anyway, I'll -W it and work tomorow morning my time for a next PS21:30
dansmithrpodolyaka: I don't know why that is21:30
*** jose-phillips has quit IRC21:30
mriedembauzas: yeah so up until 1.4 we always accepted member_of,21:30
mriedembut if < 1.3 we don't filter on member_of21:30
smcginnisildikov: I don't see "Openstack-Api-Version: volume 3.24" in there.21:31
bauzasmriedem: not really but yeah21:31
mriedembut it's not an error to put it in the query string, because of the aforementioned missing of the versioning21:31
bauzasmriedem: for example, Newton is not accepting it for 1.021:31
ildikovsmcginnis: me neither, but I also don't know what should put it there :)21:31
rpodolyakadansmith: lemme give it a try on  a small snippet21:31
smcginnisildikov: :)21:31
mriedembauzas: oh because member_of wasn't in allowed_filters until ocata21:31
bauzasjust verifying it21:32
bauzasfor stable/newton21:32
jaypipesmriedem: responded to your review comments on the patch.21:32
bauzasmriedem: yup that21:32
*** rama_y_ has quit IRC21:32
*** rama_y has quit IRC21:32
*** jose-phillips has joined #openstack-nova21:33
bauzasjaypipes: lemme work on a next patchset tomorrow21:33
dansmithrpodolyaka: my understanding is that an insert will still fail with DBDuplicate when you do it, and the thing that does the abort/commit of the transaction is the top-level facade decorator,21:33
openstackgerritJay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory
openstackgerritJay Pipes proposed openstack/nova: rt: explicitly pass compute node to _update()
openstackgerritJay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance
bauzasjaypipes: given it's the end of your afternoon :)21:33
jaypipesbauzas: no problemo. I'm flying all day :)21:33
dansmithrpodolyaka: so if you appear to exit your function cleanly, it will commit and you save anything you successfully inserted, unless you hit *another* dupe because you raced with another transaction21:33
bauzasjaypipes: heh, seems terrible :)21:33
bauzasmriedem: so, confirmed, stable/newton is not accepting member_of
*** Jeffrey4l has quit IRC21:34
rpodolyakadansmith: the problem is that it's the very same transaction - once you have an integrity error you must roll it back at this point21:34
bauzascdent: ^ see that21:34
mriedemyeah ok...21:34
*** JoseMello has quit IRC21:35
dansmithrpodolyaka: why must you roll back?21:35
cdentbauzas: what are you trying to tell me?21:35
mriedemso it might be fine to bend the rules and make the schema validation strict again21:35
bauzascdent: I think that if we silently accept member_of, it's not zero folks impacted21:35
mriedemi.e. we didn't allow it, then we allowed it for a short window, then we didn't again21:35
mriedemand the only user is internal to nova right now21:35
mriedemexcluding whatever mlavalle is doing21:35
dansmithrpodolyaka: we did another migration like this that I think we've since purged, so if this doesn't work then that didn't either21:35
rpodolyakadansmith: mysql will tell you the transaction is invalid and must be rolled back. just like with any other error in a transaction21:35
rpodolyakayou sure that were not independent transactions?21:36
bauzasmriedem: either way, you have lots of other comments, will respond to those21:36
dansmithrpodolyaka: yeah21:36
dansmithrpodolyaka: well, I don't know anything about mysql making you do that, but surely willing to believe you know more than me21:36
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Refactor _post_live_migratiion
bauzasanyway, calling it a end of day21:37
rpodolyakadansmith: heh, I'm a bit sleepy, so maybe I'm missing something obvious :P21:37
dansmithrpodolyaka: not sure we were filtering for dupes before, which I guess is the wrinkle21:37
dansmithmelwitt: either way, if rpodolyaka is right, a save point before each insert and a revert in a generic handler is not hard right?21:37
melwittyeah, I couldn't find a current migration that does a loop in one transaction, to use as an example21:38
dansmithmelwitt: also, do you need the dupe handling if you apply them in a transaction?21:38
mriedemjaypipes: what do you mean this is unreadable?! (?:[A-Z0-9_]+\:[0-9]+),?21:38
melwittdansmith: hm, I dunno. maybe not21:39
*** zz_dimtruck is now known as dimtruck21:39
openstackgerritSarafraj Singh proposed openstack/nova: Add service_token for nova-glance interaction
mlavallemriedem, bauzas: I am not using any filters with resource providers in my core. Feel free to go ahead21:42
mriedembauzas: jaypipes: ok i replied to the replies. :) i still think that we can enforce the format of the uuid parameter to be a uuid, as it's not being used with in:21:47
mriedem"in:" is only used with member_of21:47
*** sheel has quit IRC21:47
*** eharney has joined #openstack-nova21:48
openstackgerritSarafraj Singh proposed openstack/nova: DNM: Test service token in Glance
mriedemildikov: ok so "-H "OpenStack-API-Version: volume 3.24""21:49
dansmithrpodolyaka: okay, I found some references to what you're describing21:49
rpodolyakadansmith: shit, it works on mysql - but fails on postgresql without savepoints...
dansmithrpodolyaka: seems like enginefacade could manage this for us.. automatically doing savepoints or something, if we nest calls21:50
mriedemildikov: yeah so the "OpenStack-API-Version" header isn't in the paste from the nova-api call21:50
dansmithrpodolyaka: but regardless, gotta handle it for now I guess21:50
mriedemildikov: but i don't think nova is supposed to be picking the microversion is it, cinderclient is, at least by default it would be 3.021:50
mriedemildikov: is there a difference in how cinderclient's shell creates the client object and makes requests for v3 vs how nova is doing it?21:51
*** lpetrut has quit IRC21:51
mriedemsmcginnis: cinder is up to microversion 3.24 already?21:51
smcginnismriedem: Sounds right.21:51
rpodolyakadansmith: yeah, it's just that we do not create a SAVEPOINT for each nested call - so we've got a modifier -
rpodolyakawhich should be used in such cases21:51
mriedemsmcginnis: where do you guys document your REST API version history?21:51
mriedemnot finding it here
rpodolyakaalthough, we don't probably use it anywhere in nova21:52
ildikovmriedem: that's an amazing question, I have no clue :)21:52
smcginnismriedem: Kidding. One moment.21:52
mriedemsmcginnis: i guess here
smcginnismriedem: Beat me to it.21:52
ildikovmriedem: it's 3.23, I test jgriffith's new attach API patch, which adds the 3.2421:52
jgriffithas of an hour ago21:53
melwittrpodolyaka: there are use of the savepoint modifier in nova/db/sqlalchemy/api for several things that catch/expect DBDuplicateEntry21:53
mriedemildikov: so my guess is,21:53
rpodolyakamelwitt: ah, then I missed those21:53
mriedemthe cinderclient shell code does some version discovery with the cinder api and gets the latest available microversion from the server and negotiates that with what the client understands,21:53
mriedemthat's how novaclient works21:54
dansmithrpodolyaka: cool, thanks21:54
mriedemand right now the max version in cinderclient is 3.15 i guess?
ildikovmriedem: that sounds reasonable21:54
mriedemnot sure how that works if you're getting it to use 3.2421:54
*** cleong has quit IRC21:55
ildikovmriedem: I'm setting OS_VOLUME_API_VERSION=3.2421:55
* dansmith notes not to argue with rpodolyaka 21:55
ildikovmriedem: that's the only magic on the Cinder side to make it work21:56
*** yamahata has quit IRC21:56
rpodolyakadansmith: lol :)21:56
*** yamahata has joined #openstack-nova21:56
mriedemwtf where is cinderclient.API_MIN_VERSION set?21:57
*** thorst_ has quit IRC21:57
mriedemand cinderclient.API_MAX_VERSION21:58
*** stewie925 has joined #openstack-nova21:58
ildikovmriedem: you're checking the cinderclient code now?21:59
stewie925hello guys21:59
mriedemildikov: yes22:00
ildikovmriedem: ok, I've just started with that, maybe scottda can help us22:00
stewie925I'm setting up openstack (controller, compute) and I am following the setup steps to set up the nova compute component on the controller node.22:01
*** amotoki has joined #openstack-nova22:01
stewie925so far so good... but when the step calls for 'service nova-api restart'  I am getting a 'nova-api:unrecognized service'22:02
*** annegentle has quit IRC22:02
mriedemildikov:     if api_version and api_version.ver_minor != 0:22:02
mriedem        headers["OpenStack-API-Version"] = "volume " + api_version.get_string()22:02
mriedemnova is constructing a base cinderclient.v3.client.Client class22:02
mriedemwhich from the entry point is going to just have api_version set to '3.0'22:03
mriedemso looking at that cinderclient code, it's not going to send the header for 3.022:03
mriedemand kaboom22:03
mriedemildikov: so nova is going to create the client object using this
mriedemnova would be using this
scottdaildikov: are you using this patch?
mriedemildikov: note that does " return importutils.import_class(client_path)"22:04
mriedemwhich doesn't pass in the api_version kwarg22:05
mriedemcompared to which does pass in the api_version kwarg22:05
ildikovscottda: no, I'm depending on another one already22:05
mriedemand ^ is going to be using 3.022:05
mriedemanyway that gets us here
mriedemand then
scottdaildikov: Does your patch call api_versions.get_highest_version(client) ?22:06
mriedemand then we create a session client here
*** stewie925_ has joined #openstack-nova22:06
mriedembecause nova is using a session22:06
scottdaildikov: or point me to your patch(es)22:07
mriedemwhen session client makes a request it updates the headers here
mriedemwhich gets us here
ildikovscottda: I don't touch the client part in my patch22:07
mriedemand for whatever reason, that only sets the header if the minor version is > 022:07
mriedemwhich seems like a bug22:07
ildikovscottda: so I don't call get_highest_version either22:07
scottdaWell, the cinderclient doesn't auto-negotiate to the highest mutually supported version (yet)22:08
mriedemi bet you $100 that that's just a copy/paste from the novaclient update_headers code22:08
mriedembecause 2.0 is legacy compute api, 2.1 is new hotness with microversions22:08
mriedemthere is no nova 3.022:08
*** stewie925 has quit IRC22:08
mriedembut cinder decided to jump from 2.0 to 3.022:08
mriedemscottda: ildikov: so yeah your client is busted22:09
*** darrenc is now known as darrenc_afk22:09
mriedemi'll take the $100 consulting fee in cash or check22:09
smcginnismriedem: Nova auto-negotiates to the highest? Don't you consider that a risk?22:10
mriedemsmcginnis: for the shell,22:10
ildikovmriedem: does that contain the figuring out the endpoint not found issue too? :)22:10
mriedemnot the python API22:10
mriedemildikov: no22:10
mriedemthat's ksa22:10
smcginnismriedem: Still seems like a risk.22:10
mriedemsmcginnis: if you're coding to the shell...well...22:10
ildikovmriedem: fair enough22:10
mriedemif you're coding to the shell you deserve to get broken22:11
*** gabor_antal has quit IRC22:11
*** gabor_antal_ has joined #openstack-nova22:11
smcginnisWell, if you're just running commands from the CLI, that seems a risk that suddenly you could get different behavior.22:11
*** jamesdenton has quit IRC22:13
ildikovmriedem: thanks much for the help/explanation of the pain I'm experiencing with testing :)22:13
openstackLaunchpad bug 1656105 in python-cinderclient "api_versions.update_headers doesn't set the microversion header if version is 3.0" [Undecided,New]22:14
ildikovmriedem: thanks much!22:14
scottdaI'll put up a patch for that ^^^..When I get back from the bus stop.22:15
ildikovscottda: sounds great, thanks22:15
mriedemsmcginnis: if you're coding to the shell you can override with --os-compute-api-version22:15
mriedemto opt in or pin the version22:15
mriedemwhich is exactly what you have to do if you're requesting specific microversions via the python API22:15
scottdaildikov: But why are you using 3.0? You'll still need the version with the new APIs22:15
mriedemmicroversions in the python API bindings is opt-in,22:16
mriedemthe shell is a convenience to use the latest available that the client understands and the server can provide,22:16
mriedemif you're coding to the shell and worry about changes with microversions, then you also have to pin with --os-compute-api-version22:16
*** unicell has quit IRC22:16
ildikovscottda: I'm trying to make Nova pick up the new Cinder APIs and I kind of got stuck with how to do that and hence the questions on every relevant channel22:17
*** jose-phillips has quit IRC22:19
openstackgerritDan Smith proposed openstack/nova: Make api_samples tests use simple cell environment
openstackgerritDan Smith proposed openstack/nova: WIP Move instance creation to conductor
*** gabor_antal_ has quit IRC22:23
*** salv-orl_ has joined #openstack-nova22:23
*** gabor_antal has joined #openstack-nova22:23
*** edmondsw has quit IRC22:24
*** edmondsw has joined #openstack-nova22:24
*** jose-phillips has joined #openstack-nova22:25
*** unicell has joined #openstack-nova22:25
*** salv-orlando has quit IRC22:25
*** jwcroppe has joined #openstack-nova22:26
*** annegentle has joined #openstack-nova22:26
cdent#success edleafe found narrowed down an important bug in gabbi22:26
openstackstatuscdent: Added success to Success page22:26
cdentI've wanted to try that for a while22:27
mriedemfound narrowed down?22:27
*** cmartin has quit IRC22:28
cdentenglish, when typed, is my 6th language22:28
*** edmondsw has quit IRC22:29
cdentsadly, I'm a total fail at solving the bug22:31
cdentI guess that'll have to be tomorrow22:31
*** thorst_ has joined #openstack-nova22:32
mriedemjust mark the bug as low-hanging-fruit22:32
mriedemyou'll have 10 new contributors lined up to fix it22:33
stewie925_hello all, hopefully a quick question - I have set up compute on my openstack and then I tried "sudo service nova-api restart"   - it returned "nova-api stop/waiting nova-api start/running, process 4383"22:33
stewie925_is that a confirmation that the nova-api restarted successfully?22:33
mriedemstewie925_: i know you're not new to this channel, but see the channel topic22:33
cdentmriedem: that explains it. I haven't been tagging the bugs.22:34
mriedemhow you're deploying it on which distro and what packages etc etc isn't really for this channel22:34
mriedemnp - you'll know it's running if there are logs somewhere22:34
*** nherciu_ has quit IRC22:35
*** thorst_ has quit IRC22:37
*** annegentle has quit IRC22:40
*** darrenc_afk is now known as darrenc22:41
*** Swami has quit IRC22:43
*** jaypipes has quit IRC22:46
*** tbachman has joined #openstack-nova22:50
*** _ducttape_ has joined #openstack-nova22:50
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working
dimsmriedem : i think i am very close to nova boot a vm with this
*** ducttape_ has quit IRC22:54
*** _ducttape_ has quit IRC22:55
mriedem[WIP][py35] Trying to get cinder+rally working ?22:56
mriedemwrong title?22:56
dimsmriedem : actually i am watching gate-rally-dsvm-py35-cinder-nv over at and debugging nova started from a rally test22:57
*** annegentle has joined #openstack-nova22:59
*** mdrabe has quit IRC23:00
*** owalsh has joined #openstack-nova23:00
*** databus23_1 has joined #openstack-nova23:02
*** sapcc-bot1 has joined #openstack-nova23:02
*** sapcc-bot has quit IRC23:02
*** databus23_ has quit IRC23:02
mriedemjroll: fyi
mriedemjust updated that thing23:07
jrollmriedem: u-c already landed, and I put up this morning23:08
* jroll didn't see that one23:08
mriedemjroll: is the one that the nova change depends on23:08
jrollyeah, I see that now23:08
mriedem depends on ^23:08
* jroll abandons23:08
mriedemand is therefore infinitely more important :)23:08
*** kylek3h has quit IRC23:09
*** yamahata has quit IRC23:10
*** stewie925_ is now known as stewie92523:12
*** yamahata has joined #openstack-nova23:12
*** dave-mccowan has quit IRC23:17
*** jaosorior has quit IRC23:22
*** tblakes has quit IRC23:27
*** marst has quit IRC23:28
*** rama_y has joined #openstack-nova23:29
*** rama_y_ has joined #openstack-nova23:29
*** rama_y_ has quit IRC23:31
*** rama_y has quit IRC23:31
*** mriedem has quit IRC23:33
*** thorst_ has joined #openstack-nova23:33
*** kberger has quit IRC23:35
*** haplo37_ has quit IRC23:36
*** Jeffrey4l has joined #openstack-nova23:37
*** thorst_ has quit IRC23:37
*** haplo37_ has joined #openstack-nova23:39
openstackgerritEd Leafe proposed openstack/nova: Remove the Allocation.create() method.
openstackgerritEd Leafe proposed openstack/nova: Add check for invalid allocation amounts
openstackgerritEd Leafe proposed openstack/nova: Fix missing RP generation update
*** annegentle has quit IRC23:46
*** stewie925 has quit IRC23:48
*** salv-orl_ has quit IRC23:48
*** owalsh has quit IRC23:51
*** Swami has joined #openstack-nova23:54
*** Swami_ has joined #openstack-nova23:54
dimsnova.boot_server/attach_volume/detach_volume works!
*** tjones has quit IRC23:55
*** lamt has quit IRC23:55
*** cdent has quit IRC23:57

Generated by 2.14.0 by Marius Gedminas - find it at!