*** gouthamr has quit IRC | 00:02 | |
*** jamesdenton has joined #openstack-nova | 00:04 | |
*** vladikr has quit IRC | 00:04 | |
*** nic has quit IRC | 00:06 | |
*** sdague has quit IRC | 00:12 | |
*** jamesdenton has quit IRC | 00:15 | |
*** Swami_ has quit IRC | 00:17 | |
*** Swami_ has joined #openstack-nova | 00:17 | |
*** tjones has joined #openstack-nova | 00:18 | |
*** hongbin has quit IRC | 00:19 | |
*** Swami__ has joined #openstack-nova | 00:23 | |
*** gouthamr has joined #openstack-nova | 00:26 | |
*** Swami has quit IRC | 00:26 | |
*** kylek3h has joined #openstack-nova | 00:29 | |
*** chyka has quit IRC | 00:30 | |
*** mlavalle has quit IRC | 00:34 | |
*** Guest29822 has quit IRC | 00:37 | |
*** thorst_ has joined #openstack-nova | 00:38 | |
*** jose-phillips has quit IRC | 00:40 | |
*** thorst_ has quit IRC | 00:43 | |
*** gouthamr has quit IRC | 00:47 | |
*** mtani____ has quit IRC | 00:47 | |
*** hoangcx has joined #openstack-nova | 00:48 | |
*** hfu has joined #openstack-nova | 00:48 | |
*** tjones has quit IRC | 00:48 | |
*** tjones has joined #openstack-nova | 00:50 | |
*** tjones has left #openstack-nova | 00:51 | |
*** tjones has joined #openstack-nova | 00:51 | |
*** dtp has quit IRC | 00:56 | |
*** thorst_ has joined #openstack-nova | 00:59 | |
*** tjones has quit IRC | 01:00 | |
*** thorst_ has quit IRC | 01:03 | |
*** thorst_ has joined #openstack-nova | 01:04 | |
*** thorst_ has quit IRC | 01:04 | |
*** tjones has joined #openstack-nova | 01:05 | |
*** hamzy has joined #openstack-nova | 01:12 | |
*** kevinz has joined #openstack-nova | 01:13 | |
*** tjones has quit IRC | 01:13 | |
*** rfolco has quit IRC | 01:18 | |
*** zayro has joined #openstack-nova | 01:19 | |
*** salv-orlando has joined #openstack-nova | 01:19 | |
*** salv-orlando has quit IRC | 01:24 | |
*** tjones has joined #openstack-nova | 01:26 | |
*** baoli has joined #openstack-nova | 01:29 | |
*** artom has quit IRC | 01:32 | |
*** artom has joined #openstack-nova | 01:32 | |
*** artom has quit IRC | 01:32 | |
*** artom has joined #openstack-nova | 01:33 | |
*** kaisers2 has joined #openstack-nova | 01:36 | |
*** kaisers3 has joined #openstack-nova | 01:36 | |
*** kaisers1 has quit IRC | 01:37 | |
*** kaisers has quit IRC | 01:38 | |
*** rfolco has joined #openstack-nova | 01:39 | |
*** Sukhdev has quit IRC | 01:40 | |
*** gongysh has joined #openstack-nova | 01:40 | |
*** tjones has quit IRC | 01:43 | |
*** weshay has quit IRC | 01:47 | |
*** weshay has joined #openstack-nova | 01:49 | |
*** yuntongjin has joined #openstack-nova | 01:50 | |
*** baoli has quit IRC | 01:54 | |
*** baoli has joined #openstack-nova | 01:54 | |
*** dimtruck is now known as zz_dimtruck | 01:58 | |
*** zz_dimtruck is now known as dimtruck | 01:59 | |
*** Swami_ has quit IRC | 02:00 | |
*** Swami__ has quit IRC | 02:00 | |
*** tjones has joined #openstack-nova | 02:00 | |
*** thorst_ has joined #openstack-nova | 02:05 | |
*** rfolco has quit IRC | 02:06 | |
*** thorst_ has quit IRC | 02:08 | |
*** markvoelker has quit IRC | 02:09 | |
*** browne has quit IRC | 02:09 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Don't delete neutron port when attach failed https://review.openstack.org/403568 | 02:12 |
---|---|---|
*** kaisers has joined #openstack-nova | 02:17 | |
*** dave-mccowan has joined #openstack-nova | 02:17 | |
*** ducttape_ has joined #openstack-nova | 02:19 | |
*** kaisers_ has quit IRC | 02:20 | |
alex_xu | Kevin_Zheng: just commented on https://review.openstack.org/#/c/419256/7, we still can make it simpler | 02:24 |
*** hfu has quit IRC | 02:24 | |
Kevin_Zheng | Thanks | 02:25 |
*** hfu has joined #openstack-nova | 02:25 | |
*** hfu has quit IRC | 02:27 | |
*** raunak has quit IRC | 02:28 | |
*** hfu has joined #openstack-nova | 02:29 | |
*** smatzek has joined #openstack-nova | 02:30 | |
*** Jeffrey4l_ has joined #openstack-nova | 02:30 | |
*** gouthamr has joined #openstack-nova | 02:33 | |
*** Jeffrey4l has quit IRC | 02:34 | |
*** tjones has quit IRC | 02:37 | |
*** hfu has quit IRC | 02:41 | |
*** hfu has joined #openstack-nova | 02:42 | |
*** gouthamr has quit IRC | 02:43 | |
*** gouthamr has joined #openstack-nova | 02:45 | |
openstackgerrit | Jeremy Liu proposed openstack/python-novaclient: Enable coverage report in console output https://review.openstack.org/419723 | 02:45 |
*** unicell has quit IRC | 02:46 | |
*** tovin07 has joined #openstack-nova | 02:46 | |
*** dimtruck is now known as zz_dimtruck | 02:48 | |
*** mriedem has joined #openstack-nova | 02:49 | |
*** smatzek has quit IRC | 02:49 | |
*** tbachman has quit IRC | 02:50 | |
*** ijw_ has joined #openstack-nova | 02:51 | |
*** amotoki has quit IRC | 02:53 | |
*** baoli has quit IRC | 02:53 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 02:54 |
*** ijw has quit IRC | 02:54 | |
*** hongbin has joined #openstack-nova | 02:59 | |
*** ducttape_ has quit IRC | 02:59 | |
*** ducttape_ has joined #openstack-nova | 03:00 | |
*** hongbin_ has joined #openstack-nova | 03:03 | |
*** hongbin has quit IRC | 03:03 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 03:04 |
*** ducttape_ has quit IRC | 03:04 | |
*** baoli has joined #openstack-nova | 03:05 | |
*** diga has joined #openstack-nova | 03:15 | |
*** liuyulong_ is now known as liuyulong | 03:16 | |
*** ferest has joined #openstack-nova | 03:17 | |
*** ducttape_ has joined #openstack-nova | 03:18 | |
*** timello has quit IRC | 03:19 | |
*** Jeffrey4l_ has quit IRC | 03:19 | |
*** salv-orlando has joined #openstack-nova | 03:21 | |
*** Jeffrey4l_ has joined #openstack-nova | 03:21 | |
*** timello has joined #openstack-nova | 03:21 | |
*** salv-orlando has quit IRC | 03:25 | |
*** gcb has quit IRC | 03:26 | |
*** raunak has joined #openstack-nova | 03:27 | |
*** zz_dimtruck is now known as dimtruck | 03:27 | |
*** ferest has left #openstack-nova | 03:28 | |
mriedem | edleafe: have you ever seen this failure in a functional test run for placement? http://logs.openstack.org/60/416760/1/check/gate-nova-tox-db-functional-ubuntu-xenial/f192837/console.html#_2017-01-12_15_22_00_609678 | 03:28 |
openstackgerrit | zhaolihui proposed openstack/nova: Fix keypair quota error https://review.openstack.org/403529 | 03:28 |
*** gongysh has quit IRC | 03:29 | |
mriedem | seems to be random | 03:30 |
*** yamahata has quit IRC | 03:32 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add some code to reject known bad filters. https://review.openstack.org/419256 | 03:33 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working https://review.openstack.org/419476 | 03:33 |
*** thorst_ has joined #openstack-nova | 03:35 | |
*** thorst_ has quit IRC | 03:37 | |
mriedem | nvm i think it's a problem in that change actually | 03:37 |
mriedem | i'm probably missing some backport | 03:37 |
*** baoli has quit IRC | 03:39 | |
*** baoli has joined #openstack-nova | 03:39 | |
*** ducttape_ has quit IRC | 03:42 | |
*** ducttape_ has joined #openstack-nova | 03:42 | |
*** ijw_ has quit IRC | 03:42 | |
*** ducttape_ has quit IRC | 03:44 | |
*** ducttape_ has joined #openstack-nova | 03:44 | |
*** baoli has quit IRC | 03:45 | |
*** yuntongjin has quit IRC | 03:46 | |
alex_xu | johnthetubaguy: gmann, Kevin_Zheng puts two ideas into single patch https://review.openstack.org/419256, probably enough to take look at how those looks like in the code. | 03:46 |
*** mriedem has quit IRC | 03:49 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working https://review.openstack.org/419476 | 03:53 |
*** tjones has joined #openstack-nova | 03:53 | |
*** links has joined #openstack-nova | 03:54 | |
gmann | alex_xu: johnthetubaguy Kevin_Zheng thanks, while giving try i got a way to reject known property from schema itself | 03:55 |
*** raunak has quit IRC | 03:55 | |
gmann | alex_xu: johnthetubaguy Kevin_Zheng we can do with 'not' propoerty, i commented on this about how - https://review.openstack.org/#/c/408571/38 | 03:55 |
*** raunak has joined #openstack-nova | 03:56 | |
gmann | actually in draft3 formatter it was 'disallow' and in 4 it is 'not' | 03:56 |
*** mdnadeem has joined #openstack-nova | 03:56 | |
gmann | https://github.com/json-schema/json-schema/wiki/anyOf,-allOf,-oneOf,-not#not | 03:56 |
gmann | https://github.com/json-schema/json-schema/wiki/anyOf,-allOf,-oneOf,-not#replacing-schemas-in-disallow | 03:56 |
gmann | so basically with empty object with not like- 'not': {} we can reject all values of given element | 03:56 |
alex_xu | gmann: what kind of error message we can get? | 03:57 |
diga | gibi: Hi | 03:58 |
gmann | alex_xu: yea that is nice point | 03:58 |
gmann | alex_xu: it will like Invalid input for field/attribute system_metadata. Value: . {} is not allowed for 'mymeta' | 03:58 |
gmann | which we might need to modify seems | 03:58 |
Kevin_Zheng | Actually I like the format way better | 04:00 |
alex_xu | gmann: if we can get a correct message that will be great, not sure there is way to change that message | 04:00 |
Kevin_Zheng | it will be harder than the new format thing I think | 04:01 |
alex_xu | yea, i'm also worry about that | 04:01 |
gmann | alex_xu: yea error message is issue but let me check if we can easily modify that | 04:01 |
Kevin_Zheng | the mssage is below the one I changed for the current way | 04:02 |
Kevin_Zheng | maybe hard to identify the "not" thing because it might be a validation error? | 04:02 |
alex_xu | gmann: really appreciate that :) | 04:02 |
Kevin_Zheng | VallidationError | 04:03 |
gmann | Kevin_Zheng: yea it will be validation error from json itself | 04:03 |
*** gouthamr has quit IRC | 04:04 | |
Kevin_Zheng | gmann: yeah, but other also raise ValidationError and the msg was generated. So we have to identify the case of this | 04:04 |
Kevin_Zheng | maybe harder than the current way | 04:04 |
gmann | Kevin_Zheng: yea, that is pain point. | 04:05 |
* gmann checking.. | 04:05 | |
*** ducttape_ has quit IRC | 04:08 | |
*** ducttape_ has joined #openstack-nova | 04:09 | |
*** kiran-r has joined #openstack-nova | 04:09 | |
*** ducttape_ has quit IRC | 04:11 | |
*** ducttape_ has joined #openstack-nova | 04:12 | |
*** tjones has left #openstack-nova | 04:13 | |
gmann | alex_xu: Kevin_Zheng yea we have to add hack for that which kindda new overridden code on top of json schema. That is what new formatter way. | 04:14 |
*** psachin has joined #openstack-nova | 04:14 | |
*** nicolasbock has quit IRC | 04:16 | |
*** armax has quit IRC | 04:17 | |
*** ducttape_ has quit IRC | 04:18 | |
*** liverpooler has quit IRC | 04:21 | |
*** yuntongjin has joined #openstack-nova | 04:21 | |
*** dikonoor has joined #openstack-nova | 04:24 | |
*** pbandark has joined #openstack-nova | 04:24 | |
*** manasm has joined #openstack-nova | 04:27 | |
*** sree has joined #openstack-nova | 04:30 | |
*** sree has quit IRC | 04:30 | |
*** sree has joined #openstack-nova | 04:30 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working https://review.openstack.org/419476 | 04:31 |
gmann | alex_xu: Kevin_Zheng i think formatter is ok which is much easy, how about showing few schema example with new 'format' also in https://review.openstack.org/#/c/419256/7 | 04:36 |
*** phuongnh has joined #openstack-nova | 04:39 | |
*** baoli has joined #openstack-nova | 04:42 | |
*** tojuvone has quit IRC | 04:44 | |
*** karthiks has joined #openstack-nova | 04:44 | |
*** amotoki has joined #openstack-nova | 04:46 | |
*** baoli has quit IRC | 04:47 | |
*** markvoelker has joined #openstack-nova | 04:52 | |
*** kaisers has quit IRC | 04:54 | |
*** larainema has quit IRC | 04:56 | |
*** masber has joined #openstack-nova | 04:57 | |
*** diga has quit IRC | 05:01 | |
*** hongbin_ has quit IRC | 05:02 | |
*** tbachman has joined #openstack-nova | 05:03 | |
*** Sukhdev has joined #openstack-nova | 05:07 | |
*** udesale has joined #openstack-nova | 05:08 | |
*** ratailor has joined #openstack-nova | 05:08 | |
*** tbachman has quit IRC | 05:09 | |
*** tlian has quit IRC | 05:10 | |
*** dimtruck is now known as zz_dimtruck | 05:11 | |
*** unicell has joined #openstack-nova | 05:12 | |
*** tbachman has joined #openstack-nova | 05:14 | |
*** sudipto has joined #openstack-nova | 05:18 | |
*** sudipto_ has joined #openstack-nova | 05:18 | |
*** prateek has joined #openstack-nova | 05:19 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add some code to reject known bad filters. https://review.openstack.org/419256 | 05:19 |
Kevin_Zheng | gmann: thanks, and I replied your comment, and I just came up with the idea to also assert the error message in one test, will add it later | 05:21 |
*** markvoelker_ has joined #openstack-nova | 05:22 | |
gmann | Kevin_Zheng: i see, nice. thanks test case will be nice there | 05:24 |
*** markvoelker has quit IRC | 05:26 | |
*** dave-mccowan has quit IRC | 05:27 | |
*** gongysh has joined #openstack-nova | 05:30 | |
*** larainema has joined #openstack-nova | 05:34 | |
*** thorst_ has joined #openstack-nova | 05:37 | |
*** adisky_ has joined #openstack-nova | 05:38 | |
*** thorst_ has quit IRC | 05:42 | |
*** baoli has joined #openstack-nova | 05:44 | |
*** karthiks has quit IRC | 05:46 | |
*** hoangcx has quit IRC | 05:47 | |
*** tbachman has quit IRC | 05:47 | |
*** baoli has quit IRC | 05:48 | |
*** sacharya has quit IRC | 05:50 | |
*** kaisers has joined #openstack-nova | 05:55 | |
*** tbachman has joined #openstack-nova | 05:57 | |
openstackgerrit | zhaolihui proposed openstack/nova: Fix keypair quota error https://review.openstack.org/403529 | 05:57 |
*** karthiks has joined #openstack-nova | 05:59 | |
*** lpetrut has joined #openstack-nova | 05:59 | |
*** salv-orlando has joined #openstack-nova | 06:07 | |
*** hoangcx has joined #openstack-nova | 06:10 | |
*** raunak has quit IRC | 06:13 | |
*** tbachman has quit IRC | 06:14 | |
*** tbachman has joined #openstack-nova | 06:14 | |
*** swamireddy has quit IRC | 06:15 | |
*** dikonoor has quit IRC | 06:16 | |
openstackgerrit | Jeremy Liu proposed openstack/python-novaclient: Enable coverage report in console output https://review.openstack.org/419723 | 06:16 |
*** hoangcx has quit IRC | 06:19 | |
*** Kevin_Zheng has quit IRC | 06:20 | |
*** Kevin_Zheng has joined #openstack-nova | 06:20 | |
*** jwcroppe has quit IRC | 06:23 | |
*** tojuvone has joined #openstack-nova | 06:25 | |
*** oomichi has quit IRC | 06:25 | |
*** oomichi has joined #openstack-nova | 06:26 | |
*** tbachman has quit IRC | 06:26 | |
*** phuongnh has quit IRC | 06:27 | |
*** phuongnh has joined #openstack-nova | 06:27 | |
*** oomichi has quit IRC | 06:30 | |
*** oomichi has joined #openstack-nova | 06:31 | |
openstackgerrit | Istvan Imre proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication https://review.openstack.org/419441 | 06:35 |
*** kiran-r has quit IRC | 06:35 | |
*** manasm has quit IRC | 06:36 | |
*** oomichi has quit IRC | 06:38 | |
*** kaisers has quit IRC | 06:40 | |
*** oomichi has joined #openstack-nova | 06:40 | |
*** mjura has joined #openstack-nova | 06:42 | |
*** salv-orlando has quit IRC | 06:43 | |
*** ijw_ has joined #openstack-nova | 06:45 | |
*** lpetrut has quit IRC | 06:50 | |
*** sacharya has joined #openstack-nova | 06:51 | |
*** yamahata has joined #openstack-nova | 06:51 | |
*** oomichi has quit IRC | 06:55 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add some code to reject known bad filters. https://review.openstack.org/419256 | 06:56 |
*** hfu has quit IRC | 06:56 | |
*** sacharya has quit IRC | 06:56 | |
Kevin_Zheng | gmann, alex_xu tests added ^ | 06:57 |
*** gongysh has quit IRC | 06:57 | |
*** oomichi has joined #openstack-nova | 06:57 | |
*** avolkov has joined #openstack-nova | 06:58 | |
*** manasm has joined #openstack-nova | 07:00 | |
*** hfu has joined #openstack-nova | 07:07 | |
*** hfu has quit IRC | 07:11 | |
*** tesseract has joined #openstack-nova | 07:11 | |
*** hfu has joined #openstack-nova | 07:12 | |
*** nkrinner_afk is now known as nkrinner | 07:15 | |
*** andreas_s has joined #openstack-nova | 07:18 | |
*** moshele has joined #openstack-nova | 07:18 | |
*** fengzhr has quit IRC | 07:20 | |
*** fengzhr has joined #openstack-nova | 07:23 | |
*** voelzmo has joined #openstack-nova | 07:23 | |
*** salv-orlando has joined #openstack-nova | 07:27 | |
*** Kevin_Zheng has quit IRC | 07:28 | |
*** Vek has quit IRC | 07:28 | |
*** csatari has quit IRC | 07:28 | |
*** fmccrthy has quit IRC | 07:28 | |
*** auggy has quit IRC | 07:28 | |
*** nikhil has quit IRC | 07:28 | |
*** Oku_OSz has quit IRC | 07:28 | |
*** Vek has joined #openstack-nova | 07:28 | |
*** markmcclain has quit IRC | 07:29 | |
*** moshele has quit IRC | 07:29 | |
*** adisky_ has quit IRC | 07:29 | |
*** tomhambleton has quit IRC | 07:29 | |
*** TheJulia has quit IRC | 07:29 | |
*** rpodolyaka has quit IRC | 07:30 | |
*** tr3buchet has quit IRC | 07:30 | |
*** yonglihe has quit IRC | 07:30 | |
*** dhellmann has quit IRC | 07:30 | |
*** rmcadams has quit IRC | 07:30 | |
*** mwhahaha has quit IRC | 07:30 | |
*** Hazelesque has quit IRC | 07:30 | |
*** sridharg has joined #openstack-nova | 07:31 | |
*** voelzmo has quit IRC | 07:31 | |
*** Hazelesque has joined #openstack-nova | 07:31 | |
*** mwhahaha has joined #openstack-nova | 07:31 | |
*** nikhil has joined #openstack-nova | 07:31 | |
*** rmcadams has joined #openstack-nova | 07:31 | |
*** tomhambleton has joined #openstack-nova | 07:32 | |
*** yonglihe has joined #openstack-nova | 07:32 | |
*** rpodolyaka has joined #openstack-nova | 07:33 | |
*** TheJulia has joined #openstack-nova | 07:34 | |
*** markmcclain has joined #openstack-nova | 07:34 | |
*** fmccrthy has joined #openstack-nova | 07:34 | |
*** auggy has joined #openstack-nova | 07:34 | |
*** Oku_OS-away has joined #openstack-nova | 07:35 | |
*** dhellmann has joined #openstack-nova | 07:35 | |
*** adisky_ has joined #openstack-nova | 07:36 | |
*** tr3buchet has joined #openstack-nova | 07:36 | |
*** kaisers has joined #openstack-nova | 07:36 | |
*** Kevin_Zheng has joined #openstack-nova | 07:36 | |
*** csatari has joined #openstack-nova | 07:37 | |
*** thorst_ has joined #openstack-nova | 07:39 | |
*** voelzmo has joined #openstack-nova | 07:41 | |
*** thorst_ has quit IRC | 07:43 | |
*** satyar has joined #openstack-nova | 07:46 | |
*** sahid has joined #openstack-nova | 07:48 | |
*** tiendc has joined #openstack-nova | 07:50 | |
*** markus_z has joined #openstack-nova | 07:51 | |
*** phuongnh has quit IRC | 07:51 | |
*** fmccrthy has quit IRC | 07:57 | |
*** fmccrthy has joined #openstack-nova | 07:57 | |
*** nherciu has joined #openstack-nova | 07:58 | |
*** manasm has quit IRC | 07:59 | |
*** Sukhdev has quit IRC | 08:00 | |
snikitin | alex_xu: Hi Alex! good point about upgrade problem in diagnostics api. You described case when we have new api and old compute, right? I think we can handle this case in view class https://review.openstack.org/#/c/355540/18/nova/api/openstack/compute/views/server_diagnostics.py | 08:04 |
snikitin | As response of new micriversion is standartized we must return all diagnostics fields. But as we noted in spec and docs, some of this fields may be 'None' because some hypervisors can't provides some kinf in information. | 08:04 |
snikitin | In our upgrade case we can try to fill diagnostics fields by information we got from old hypervisor drivers (most of fields in old and new diagnostics objects are equal) and left other fields empty. And of course we should log warning something like "Your compute is to old so data in diagnostics response may be incomplete" . What do you think? | 08:04 |
snikitin | *some kind of information | 08:04 |
*** aloga has quit IRC | 08:05 | |
*** aloga has joined #openstack-nova | 08:05 | |
alex_xu | snikitin: emm....i feel it is ok | 08:08 |
snikitin | alex_xu, good! ty | 08:09 |
alex_xu | snikitin: i'm thinking whether it makes the API behaviour different in the upgrade | 08:09 |
alex_xu | snikitin: but yes, empty is valid value | 08:10 |
openstackgerrit | Istvan Imre proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication https://review.openstack.org/419441 | 08:10 |
alex_xu | we didn't break any API contract | 08:10 |
snikitin | okay | 08:10 |
*** manasm has joined #openstack-nova | 08:15 | |
*** ralonsoh has joined #openstack-nova | 08:19 | |
*** hfu has quit IRC | 08:22 | |
*** hfu has joined #openstack-nova | 08:26 | |
*** tuanluong has joined #openstack-nova | 08:28 | |
*** manasm has quit IRC | 08:34 | |
*** kaisers has quit IRC | 08:41 | |
*** zayro has quit IRC | 08:41 | |
*** salv-orlando has quit IRC | 08:43 | |
*** salv-orlando has joined #openstack-nova | 08:44 | |
*** manasm has joined #openstack-nova | 08:47 | |
*** timello has quit IRC | 08:48 | |
*** timello has joined #openstack-nova | 08:51 | |
*** ri0 has joined #openstack-nova | 08:51 | |
*** burt has quit IRC | 08:52 | |
*** phuongnh has joined #openstack-nova | 08:55 | |
*** burt has joined #openstack-nova | 08:56 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-nova | 09:00 | |
*** tovin07_ has quit IRC | 09:02 | |
*** ratailor has quit IRC | 09:04 | |
*** mnestratov has joined #openstack-nova | 09:04 | |
*** ociuhandu has joined #openstack-nova | 09:05 | |
*** mnestratov|2 has quit IRC | 09:07 | |
*** hfu has quit IRC | 09:07 | |
*** ratailor has joined #openstack-nova | 09:08 | |
*** hfu has joined #openstack-nova | 09:08 | |
*** tiendc has quit IRC | 09:08 | |
*** amotoki has quit IRC | 09:18 | |
*** rmart04 has joined #openstack-nova | 09:18 | |
*** ri0 has quit IRC | 09:19 | |
*** yuntongjin has quit IRC | 09:19 | |
*** karthiks has quit IRC | 09:19 | |
*** ijw_ has quit IRC | 09:20 | |
*** tiendc has joined #openstack-nova | 09:22 | |
*** yassine has joined #openstack-nova | 09:23 | |
*** yassine is now known as Guest60015 | 09:23 | |
*** rmart04_ has joined #openstack-nova | 09:25 | |
*** mvk has quit IRC | 09:25 | |
*** derekh has joined #openstack-nova | 09:25 | |
*** dansmith has quit IRC | 09:27 | |
*** dansmith has joined #openstack-nova | 09:27 | |
*** rmart04 has quit IRC | 09:27 | |
*** rmart04_ is now known as rmart04 | 09:27 | |
*** dansmith is now known as Guest45759 | 09:27 | |
*** satyar has quit IRC | 09:29 | |
*** voelzmo has quit IRC | 09:29 | |
*** sahid has quit IRC | 09:33 | |
*** sahid has joined #openstack-nova | 09:35 | |
*** tovin07 has quit IRC | 09:35 | |
*** karthiks has joined #openstack-nova | 09:36 | |
*** amotoki has joined #openstack-nova | 09:36 | |
*** hfu has quit IRC | 09:38 | |
*** sahid has quit IRC | 09:41 | |
*** sahid has joined #openstack-nova | 09:41 | |
*** voelzmo has joined #openstack-nova | 09:50 | |
*** ayogi has joined #openstack-nova | 09:51 | |
*** amoralej has joined #openstack-nova | 09:53 | |
*** mvk has joined #openstack-nova | 09:56 | |
*** sheel has joined #openstack-nova | 09:56 | |
amoralej | hi, i have a question about cellsv2 in ocata | 09:57 |
amoralej | when initially deploying nova, we create cell0 and map the registered compute nodes using simple_cell_setup | 09:57 |
amoralej | but, if i add new compute nodes, are they automatically added or do i need to run nova-manage manually to map them? | 09:58 |
*** karthiks has quit IRC | 10:02 | |
*** mnestratov|2 has joined #openstack-nova | 10:06 | |
*** voelzmo has quit IRC | 10:07 | |
*** lpetrut has joined #openstack-nova | 10:08 | |
*** kevinz has quit IRC | 10:08 | |
*** tuanluong has quit IRC | 10:09 | |
*** mnestratov has quit IRC | 10:09 | |
*** tuanluong has joined #openstack-nova | 10:10 | |
*** tuanluong has quit IRC | 10:11 | |
*** ratailor has quit IRC | 10:12 | |
*** ratailor has joined #openstack-nova | 10:16 | |
johnthetubaguy | amoralej: I think this is the command you want: https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1367 | 10:17 |
amoralej | thanks johnthetubaguy | 10:17 |
*** JoseMello has joined #openstack-nova | 10:18 | |
*** openstackgerrit has quit IRC | 10:18 | |
*** salv-orl_ has joined #openstack-nova | 10:23 | |
*** salv-orlando has quit IRC | 10:25 | |
*** voelzmo has joined #openstack-nova | 10:26 | |
*** cdent has joined #openstack-nova | 10:31 | |
Kevin_Zheng | johnthetubaguy: hi, I update the code here: https://review.openstack.org/#/c/419256/ | 10:31 |
Kevin_Zheng | it contains two approach, could you have a look? | 10:31 |
Kevin_Zheng | the reject bad param thing :) | 10:31 |
*** BobBall_AWOL is now known as BobBall | 10:33 | |
*** yamahata has quit IRC | 10:33 | |
*** tiendc has quit IRC | 10:35 | |
*** kaisers has joined #openstack-nova | 10:36 | |
*** ayogi has quit IRC | 10:41 | |
*** ayogi has joined #openstack-nova | 10:41 | |
*** openstackgerrit has joined #openstack-nova | 10:44 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working https://review.openstack.org/419476 | 10:44 |
*** phuongnh has quit IRC | 10:46 | |
*** ayogi has quit IRC | 10:48 | |
*** ayogi has joined #openstack-nova | 10:48 | |
*** udesale has quit IRC | 11:01 | |
*** sudipto_ has quit IRC | 11:05 | |
*** sudipto has quit IRC | 11:05 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: handle uninited fields in notification payload https://review.openstack.org/415857 | 11:06 |
mdbooth | lyarwood: Any reason you split https://review.openstack.org/#/c/402163/ and its predecessor into separate patches? | 11:10 |
*** gszasz has joined #openstack-nova | 11:11 | |
*** owalsh has joined #openstack-nova | 11:11 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: handle uninited fields in notification payload https://review.openstack.org/415857 | 11:12 |
lyarwood | mdbooth: not that I can think of, happy to squash them togther tbh | 11:14 |
*** ijw has joined #openstack-nova | 11:14 | |
mdbooth | lyarwood: Got a bit of a narrative going on there, btw. I asked you for an additional test, but then said you don't seem to need to parse filesystem at all. | 11:15 |
mdbooth | In which case you wouldn't need a test, I guess. | 11:15 |
mdbooth | The code which consumes this already assumes it's a disk, not a filesystem | 11:15 |
lyarwood | mdbooth: hmm do we not even call this when using lxc? | 11:18 |
*** ijw has quit IRC | 11:18 | |
mdbooth | lyarwood: I don't know, but it's already busted in the case I think | 11:18 |
lyarwood | mdbooth: true | 11:19 |
mdbooth | https://review.openstack.org/#/c/402163/10/nova/virt/libvirt/guest.py | 11:19 |
mdbooth | node = doc.find("./devices/disk/target[@dev='%s'].." % target_device) | 11:19 |
mdbooth | Line 311 | 11:19 |
mdbooth | Do we support filesystems as volumes? | 11:20 |
*** manasm has quit IRC | 11:20 | |
mdbooth | If no, I think we don't worry about it for the moment | 11:20 |
mdbooth | Maybe leave a comment | 11:20 |
*** manasm has joined #openstack-nova | 11:21 | |
lyarwood | mdbooth: I'm not sure tbh, the lookup hasn't changed here so if we do it's already broken | 11:21 |
mdbooth | My thinking too | 11:21 |
mdbooth | I suspect we don't | 11:22 |
lyarwood | we do as eph storage right? | 11:23 |
mdbooth | I'd have to check. Don't recall off the top of my head. | 11:25 |
mdbooth | eph is local, though, so completely different. | 11:25 |
*** smatzek has joined #openstack-nova | 11:26 | |
mdbooth | lyarwood: Are you working on this series while I'm reviewing, btw? | 11:26 |
lyarwood | mdbooth: not yet, give me 10 and I'll squash the first two | 11:27 |
mdbooth | i.e. Do you want me to continue sending a stream of consciousness, or wait a bit between hitting the DENIED button? | 11:27 |
lyarwood | mdbooth: feel free to continue | 11:27 |
*** liuyulong has quit IRC | 11:30 | |
*** ratailor has quit IRC | 11:30 | |
mdbooth | lyarwood: Maybe hold off squashing... | 11:31 |
Kevin_Zheng | johnthetubaguy: so you are suggesting the decorator idea? | 11:31 |
mdbooth | That's easy done later | 11:31 |
johnthetubaguy | Kevin_Zheng: that was my preference at the meeting, but honestly, I am tempted to merge what we have now, and refactor later | 11:32 |
johnthetubaguy | Kevin_Zheng: I don't think we are talking about behaviour changes (apart from maybe different error messages?) | 11:32 |
*** rfolco has joined #openstack-nova | 11:33 | |
cdent | Kevin_Zheng: since you're around, are you still working on https://review.openstack.org/#/c/410128/ or would you prefer someone else pick that up? | 11:34 |
Kevin_Zheng | cdent: one sec, I'm having some problem with my network now :( | 11:35 |
Kevin_Zheng | cdent: Ah, you can pick it up | 11:37 |
dims | cdent : good afternoon. have some time for me? | 11:37 |
amoralej | may i get some help on https://bugs.launchpad.net/puppet-nova/+bug/1656276 ?, i'd like to understand the best workflow to deploy nova environment with cellsv2 | 11:37 |
openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | 11:37 |
cdent | Kevin_Zheng: will do, I didn't want to mess with it if you still had is in progress | 11:37 |
cdent | dims: I always have at least a little time for you | 11:37 |
mdbooth | lyarwood: I'm looking here, line 1530 | 11:37 |
mdbooth | lyarwood: And here: http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainBlockJobAbort | 11:38 |
Kevin_Zheng | cdent: yeah thanks for ask | 11:38 |
dims | cdent thanks :) please review a WIP for me https://review.openstack.org/#/c/419476/ | 11:38 |
dims | cdent : with those changes, i can get some nova scenarios working http://logs.openstack.org/43/418643/5/check/gate-rally-dsvm-py35-cinder-nv/0a95698/rally-plot/results.html.gz#/CinderVolumes.create_and_attach_volume/details | 11:38 |
mdbooth | lyarwood: It seems to me that if we already have an unambiguous full patch to the source disk, using target dev name is only a potential source of error? | 11:38 |
Kevin_Zheng | johnthetubaguy: you mean the current implement of https://review.openstack.org/#/c/408571/ | 11:38 |
mdbooth | lyarwood: What was your thinking in making this change? | 11:39 |
* cdent looks | 11:39 | |
johnthetubaguy | Kevin_Zheng: yeah | 11:39 |
mdbooth | I haven't looked at the next patch yet, so may be missing context | 11:39 |
*** baoli has joined #openstack-nova | 11:39 | |
lyarwood | mdbooth: sorry you didn't link to the review, which file are we looking at? | 11:39 |
mdbooth | https://review.openstack.org/#/c/402163/10/nova/virt/libvirt/driver.py | 11:39 |
lyarwood | thanks | 11:40 |
Kevin_Zheng | johnthetubaguy: hmm fine by me, maybe check with alex? | 11:40 |
*** nicolasbock has joined #openstack-nova | 11:40 | |
mdbooth | lyarwood: Trying to understand the motivation moving from disk_path -> target | 11:40 |
*** thorst_ has joined #openstack-nova | 11:40 | |
mdbooth | The purpose of this change and the previous one seems to be to move away from using disk_path, but I don't get why yet. | 11:40 |
*** manasm has quit IRC | 11:42 | |
lyarwood | mdbooth: so off the top of my head I think this was to allow us to swap rbd volumes etc | 11:42 |
lyarwood | mdbooth: basically anytime we don't have an actual path | 11:42 |
lyarwood | mdbooth: let me go over this again quickly | 11:42 |
*** kaisers has quit IRC | 11:43 | |
mdbooth | lyarwood: Ah.... | 11:43 |
mdbooth | RBD has no path | 11:43 |
*** baoli has quit IRC | 11:44 | |
mdbooth | Although, libvirt has its own representation of rbd 'paths' iirc | 11:44 |
openstackgerrit | jichenjc proposed openstack/nova: Allow -1 as limit value to pager https://review.openstack.org/419893 | 11:44 |
*** thorst_ has quit IRC | 11:45 | |
lyarwood | mdbooth: ah and the main reason for doing this was that we would end up stashing either a disk_path or target_dev in BlockDevice._disk that was really confusing | 11:46 |
lyarwood | mdbooth: so I thnk i just went with target_dev as we should always have it and it's going to work when we don't have a file path | 11:47 |
cdent | dims, left a comment, what's there is probably fine, but I also offered an alternative plan which I can do (but not today) if you think it is better. | 11:47 |
lyarwood | mdbooth: sorry I should really get all of this context back in my head before asking for a review ;) | 11:47 |
*** voelzmo has quit IRC | 11:47 | |
cdent | dims I gotta go to lunch now, but will check back with you and/or the review later in the day | 11:47 |
*** openstackgerrit has quit IRC | 11:47 | |
*** cdent has quit IRC | 11:48 | |
*** voelzmo has joined #openstack-nova | 11:50 | |
*** sdague has joined #openstack-nova | 11:50 | |
*** voelzmo has quit IRC | 11:50 | |
*** voelzmo has joined #openstack-nova | 11:52 | |
*** openstackgerrit has joined #openstack-nova | 11:52 | |
*** hieulq_ has joined #openstack-nova | 11:54 | |
*** salv-orl_ has quit IRC | 11:55 | |
*** hieulq_ has quit IRC | 11:55 | |
*** hieulq_ has joined #openstack-nova | 11:56 | |
mdbooth | lyarwood: FYI, in terms of merging, I think I'd split your change to Guest.get_disk into a separate patch, and merge the rest of the patch into the previous patch. | 11:56 |
*** voelzmo has quit IRC | 11:57 | |
mdbooth | I think that makes it a little more obvious what's going on. | 11:57 |
*** salv-orlando has joined #openstack-nova | 11:59 | |
lyarwood | mdbooth: ack thanks | 12:01 |
*** dtp has joined #openstack-nova | 12:01 | |
mdbooth | lyarwood: I'm still going, btw. | 12:01 |
mdbooth | I don't like the change to BlockDevice, just writing why. | 12:01 |
alex_xu | johnthetubaguy: Kevin_Zheng i'm good with refactor the code later | 12:02 |
*** rtheis has joined #openstack-nova | 12:03 | |
johnthetubaguy | alex_xu: one thing, do we reject with 400 the bad ones in that patch? | 12:03 |
mdbooth | lyarwood: Hmm, potentially scratch that. | 12:03 |
alex_xu | johnthetubaguy: you mean for joinedtable and internal attrs? | 12:04 |
johnthetubaguy | alex_xu: the joinedtable ones | 12:05 |
alex_xu | johnthetubaguy: yea, the current patch return 400 | 12:05 |
openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488 | 12:05 |
johnthetubaguy | alex_xu: I think the behaviour is the key thing | 12:05 |
johnthetubaguy | alex_xu: so we should be good | 12:05 |
alex_xu | johnthetubaguy: ++, the behaviour is everyone expected | 12:05 |
openstackgerrit | sahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260 | 12:07 |
openstackgerrit | sahid proposed openstack/nova: libvirt: ensure live-migration success https://review.openstack.org/409261 | 12:07 |
*** adisky_ has quit IRC | 12:09 | |
*** manasm has joined #openstack-nova | 12:10 | |
*** hieulq_ has quit IRC | 12:13 | |
openstackgerrit | jichenjc proposed openstack/nova: make limit=0 means query 0 data https://review.openstack.org/419913 | 12:13 |
*** ijw has joined #openstack-nova | 12:15 | |
*** hieulq_ has joined #openstack-nova | 12:15 | |
mdbooth | lyarwood: Any reason for https://review.openstack.org/#/c/399735/ to depend on the previous 2 patches? | 12:17 |
mdbooth | Seems the middle 2 are about fixing something Rbd related? | 12:18 |
*** rtheis has quit IRC | 12:18 | |
lyarwood | mdbooth: other than using self._guest.get_disk_by_target_device no I don't think so | 12:18 |
*** hieulq_ has quit IRC | 12:19 | |
*** voelzmo has joined #openstack-nova | 12:19 | |
*** ijw has quit IRC | 12:20 | |
*** moshele has joined #openstack-nova | 12:22 | |
*** catintheroof has joined #openstack-nova | 12:30 | |
*** catintheroof has quit IRC | 12:31 | |
*** catintheroof has joined #openstack-nova | 12:32 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: scheduler: Don't modify RequestSpec in filtering https://review.openstack.org/419479 | 12:32 |
openstackgerrit | Emilien Macchi proposed openstack/nova: CI test - never merge https://review.openstack.org/419926 | 12:36 |
*** bvanhav_ has joined #openstack-nova | 12:38 | |
*** kaisers has joined #openstack-nova | 12:39 | |
*** lucasagomes is now known as lucas-afk | 12:39 | |
openstackgerrit | Emilien Macchi proposed openstack/nova: Debug https://bugs.launchpad.net/tripleo/+bug/1656276 https://review.openstack.org/419926 | 12:39 |
openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | 12:39 |
*** manasm has quit IRC | 12:41 | |
EmilienM | hey nova folks, we're having a new issue with a patch merged in Nova yesterday, https://review.openstack.org/#/c/409890/ - details are reported here: https://bugs.launchpad.net/tripleo/+bug/1656276 - any feedback is welcome | 12:41 |
openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | 12:41 |
*** thorst_ has joined #openstack-nova | 12:41 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | 12:43 |
*** mfedosin has quit IRC | 12:44 | |
*** manasm has joined #openstack-nova | 12:45 | |
*** ayogi has quit IRC | 12:48 | |
dtp | good morning. are quotas enforced in the database? | 12:55 |
*** kevinz has joined #openstack-nova | 12:55 | |
openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | 12:56 |
*** liverpooler has joined #openstack-nova | 13:00 | |
*** kevinz has quit IRC | 13:00 | |
*** psachin has quit IRC | 13:02 | |
*** voelzmo has quit IRC | 13:03 | |
*** liverpooler has quit IRC | 13:03 | |
*** liverpooler has joined #openstack-nova | 13:04 | |
*** thorst_ has quit IRC | 13:05 | |
*** thorst_ has joined #openstack-nova | 13:09 | |
openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | 13:13 |
*** moshele has quit IRC | 13:15 | |
*** ijw has joined #openstack-nova | 13:17 | |
*** sudipto_ has joined #openstack-nova | 13:19 | |
*** sudipto has joined #openstack-nova | 13:19 | |
*** amotoki has quit IRC | 13:19 | |
*** ijw has quit IRC | 13:21 | |
*** kaisers has quit IRC | 13:27 | |
sahid | JayF: | 13:27 |
*** Dinesh_Bhor has quit IRC | 13:29 | |
*** sree has quit IRC | 13:30 | |
*** sree has joined #openstack-nova | 13:30 | |
*** ducttape_ has joined #openstack-nova | 13:31 | |
*** sree has quit IRC | 13:31 | |
*** sree has joined #openstack-nova | 13:31 | |
*** sree has quit IRC | 13:33 | |
*** sree has joined #openstack-nova | 13:33 | |
*** manasm has quit IRC | 13:34 | |
*** mdnadeem has quit IRC | 13:36 | |
*** sree has quit IRC | 13:36 | |
*** sree has joined #openstack-nova | 13:37 | |
*** voelzmo has joined #openstack-nova | 13:37 | |
*** yuntongjin has joined #openstack-nova | 13:40 | |
*** sree has quit IRC | 13:40 | |
*** cdent has joined #openstack-nova | 13:42 | |
*** prateek has quit IRC | 13:43 | |
*** edmondsw has joined #openstack-nova | 13:45 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] try py35 functional with a clean slate https://review.openstack.org/419968 | 13:45 |
openstackgerrit | Vladyslav Drok proposed openstack/nova: Generate necessary network metadata for portgroups https://review.openstack.org/388756 | 13:45 |
cdent | i'm back dims, in case that's of any use | 13:48 |
dims | cdent : hehe, sorry i had gotten distracted with some shiny stuff. so yes, "EncodeUTF8 middleware" sounds awesome. we could do it as a 2 step tango too, let this change in and then do the middleware. right? | 13:50 |
dims | cdent : i'am currently poking at what functional tests start working with this change | 13:50 |
cdent | dims: yeah two step tango would work well | 13:53 |
dims | cool thanks cdent. let me un-black list stuff some tests and get it ready later today. | 13:54 |
cdent | \o/ | 13:54 |
*** ducttape_ has quit IRC | 13:55 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Fix missing RP generation update https://review.openstack.org/419137 | 13:57 |
*** pbandark has quit IRC | 13:58 | |
openstackgerrit | Vasyl Saienko proposed openstack/nova: WIP implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | 13:59 |
openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488 | 13:59 |
*** bvanhav_ has quit IRC | 14:00 | |
*** edleafe is now known as figleaf | 14:00 | |
*** cdent_ has joined #openstack-nova | 14:01 | |
*** cdent has quit IRC | 14:01 | |
*** cdent_ is now known as cdent | 14:01 | |
*** mdrabe has joined #openstack-nova | 14:01 | |
*** vladikr has joined #openstack-nova | 14:02 | |
*** dtp has quit IRC | 14:04 | |
*** xyang1 has joined #openstack-nova | 14:06 | |
openstackgerrit | sahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260 | 14:06 |
openstackgerrit | sahid proposed openstack/nova: libvirt: ensure live-migration success https://review.openstack.org/409261 | 14:06 |
*** bvanhav_ has joined #openstack-nova | 14:08 | |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: Call preallocate_for_instance before scheduler https://review.openstack.org/413124 | 14:08 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: introduce preallocate_for_instance method. https://review.openstack.org/418881 | 14:08 |
openstackgerrit | John Garbutt proposed openstack/nova: Tidy up preallocate_for_instance https://review.openstack.org/419978 | 14:08 |
openstackgerrit | John Garbutt proposed openstack/nova: Fix no networks preallocate_for_instance return https://review.openstack.org/419979 | 14:08 |
lyarwood | mdbooth: just looking at the swap volume fix again, I think we do need the previous 2 patches still. _swap_volume only provides a file path so we can't lookup the disk in the domain using guest.get_disk. I'll squash these down now for review. | 14:10 |
EmilienM | bauzas: have you looked https://bugs.launchpad.net/nova/+bug/1656276 ? | 14:11 |
openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | 14:11 |
*** eglynn has joined #openstack-nova | 14:13 | |
*** yuntongjin has quit IRC | 14:13 | |
*** amoralej is now known as amoralej|lunch | 14:14 | |
*** gouthamr has joined #openstack-nova | 14:15 | |
*** ijw has joined #openstack-nova | 14:18 | |
*** kaisers has joined #openstack-nova | 14:22 | |
*** ijw has quit IRC | 14:23 | |
openstackgerrit | garyk proposed openstack/nova: VMware: retry network lookup if network not ready https://review.openstack.org/391778 | 14:24 |
*** kevinz has joined #openstack-nova | 14:24 | |
openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | 14:25 |
*** baoli has joined #openstack-nova | 14:28 | |
*** smatzek has quit IRC | 14:30 | |
*** bvanhav_ has quit IRC | 14:30 | |
bauzas | EmilienM: hola, sorry was afk due to 10cm of snow and my frontyark needing cleanup :) | 14:30 |
bauzas | frontyard* even | 14:30 |
bauzas | EmilienM: owalsh pointed me the issue | 14:30 |
EmilienM | bauzas: 10 cm only? :-P | 14:31 |
bauzas | we're in France, and you know how 10cm of snow can be terrible for us :p | 14:31 |
bauzas | (even living in the French alps) | 14:31 |
*** bvanhav_ has joined #openstack-nova | 14:31 | |
bauzas | anyway | 14:31 |
EmilienM | bauzas: ok cool, let me know if there is something we need to change in the tripleo workflow or if you spot something in nova itself | 14:31 |
*** kevinz has quit IRC | 14:31 | |
bauzas | so, owalsh pointed me the sequence that puppet does | 14:31 |
bauzas | https://github.com/openstack/puppet-nova/blob/master/manifests/db/sync_cell_v2.pp#L41 means that it runs after API DB sync, right? | 14:32 |
bauzas | EmilienM: ^ | 14:32 |
lyarwood | mdbooth: correction, we need them still thanks to _live_snapshot, I've updated the review with a comment. | 14:32 |
EmilienM | bauzas: right | 14:32 |
*** ababich has joined #openstack-nova | 14:32 | |
*** bvanhav_ is now known as bvanhav | 14:32 | |
bauzas | EmilienM: okay, so you populated the DB, which is good | 14:32 |
bauzas | EmilienM: but you haven't started the compute nodes, right? | 14:33 |
bauzas | EmilienM: so they aren't registered in the Nova DB, correct? | 14:33 |
EmilienM | bauzas: that is true | 14:33 |
bauzas | okay | 14:33 |
openstackgerrit | Vasyl Saienko proposed openstack/nova: WIP implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | 14:33 |
*** tommylikehu has quit IRC | 14:33 | |
bauzas | EmilienM: in theory, that shouldn't be a problem | 14:33 |
*** tommylikehu has joined #openstack-nova | 14:34 | |
EmilienM | bauzas: that was 2 weeks ago, wanna help? https://twitter.com/EmilienMacchi/status/814838163654975488 | 14:34 |
bauzas | heh | 14:34 |
bauzas | EmilienM: the error occurs on a fresh new install, not an upgrade ? | 14:36 |
openstackgerrit | Vladyslav Drok proposed openstack/nova: Generate necessary network metadata for portgroups https://review.openstack.org/388756 | 14:36 |
EmilienM | bauzas: fresh | 14:36 |
bauzas | ok | 14:36 |
EmilienM | bauzas: we haven't the CI job in place for upgrade yet (it's WIP) | 14:36 |
bauzas | ack | 14:37 |
EmilienM | actually, we have but it fails because of this cellv2 thing | 14:37 |
EmilienM | and mwhahaha is working on it | 14:37 |
EmilienM | https://review.openstack.org/#/q/topic:bug/1649341 | 14:37 |
*** salv-orlando has quit IRC | 14:38 | |
bauzas | EmilienM: so, the goal of that simple_cells command is to populate your cellsv2 database with the necessary mappings for the compute nodes being in cells | 14:39 |
bauzas | EmilienM: if you don't have nodes already, then you have no cell mapping AFAICT | 14:39 |
*** tlian has joined #openstack-nova | 14:39 | |
bauzas | but when you add a node, then you have to run again the simple cells command in order to assign it a cell | 14:40 |
EmilienM | why isn't it dynamic? | 14:40 |
EmilienM | why conductor or something wouldn't do it for us? | 14:40 |
bauzas | because it hasn't been done yet | 14:40 |
EmilienM | ah ok, it's in the roadmap | 14:40 |
bauzas | well | 14:40 |
bauzas | the fact is | 14:40 |
bauzas | only the operator can know what cell the node should be added to, nova can't guess for it except putting the node into a default cell | 14:41 |
EmilienM | we could have the cell name in the nova.conf on each compute node | 14:41 |
EmilienM | and compute would send this name to conductor which write in db | 14:42 |
EmilienM | so you can scale up/down cells dynamically without running nova-manage | 14:42 |
bauzas | that's a possibility but like I said, it's not written yet :) | 14:42 |
EmilienM | cool np | 14:42 |
bauzas | so | 14:43 |
bauzas | I'm trying to understand where exactly puppet fails | 14:43 |
bauzas | when running the simple cell command | 14:43 |
bauzas | EmilienM: do you have some trace that I can look at ? | 14:43 |
bauzas | I guess only https://bugs.launchpad.net/nova/+bug/1656276 ? | 14:43 |
openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | 14:43 |
EmilienM | it's running "nova-manage cell_v2 simple_cell_setup" as part of the nova database initialization when no compute nodes have been created and it returns 1 | 14:43 |
openstackgerrit | Vladyslav Drok proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | 14:44 |
EmilienM | yes there is no trace but I can easily give one to you, let me do something quickly | 14:44 |
openstackgerrit | Emilien Macchi proposed openstack/nova: Debug https://bugs.launchpad.net/tripleo/+bug/1656276 https://review.openstack.org/419926 | 14:44 |
EmilienM | bauzas: i'm preparing a CI job with more debug, let me 5 min | 14:45 |
bauzas | EmilienM: anyway, I think the bug description has a first point to look | 14:45 |
bauzas | EmilienM: so https://github.com/openstack/puppet-nova/blob/master/manifests/db/sync_cell_v2.pp#L36 means that we try 10 times every 5 secs until the return code is zero, right?N | 14:46 |
EmilienM | bauzas: "No hosts found to map to cell, exiting" | 14:46 |
EmilienM | bauzas: exactly | 14:46 |
*** amoralej|lunch is now known as amoralej | 14:46 | |
*** eharney has quit IRC | 14:46 | |
EmilienM | bauzas: keep in mind we can change puppet to accept any return code for this Exec | 14:46 |
EmilienM | bauzas: but I'm afraid accepting 0,1 is not the right thing to do | 14:47 |
bauzas | EmilienM: okay, so why does the puppet command failed only once ? | 14:47 |
openstackgerrit | Vladyslav Drok proposed openstack/nova: Generate necessary network metadata for portgroups https://review.openstack.org/388756 | 14:47 |
EmilienM | because what is the exec fails for a good reason, we won't see it | 14:47 |
bauzas | EmilienM: it should have failed 10 times ? | 14:47 |
EmilienM | bauzas: it tried 10 times and show output of last failure | 14:47 |
EmilienM | but I guess it's 10 times the same failure | 14:47 |
bauzas | ah ok | 14:48 |
EmilienM | it returned 1 ten times | 14:48 |
EmilienM | this "No hosts found to map to cell, exiting" means "no compute has been found, fail"? | 14:48 |
*** amotoki has joined #openstack-nova | 14:49 | |
bauzas | https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1251 is the reason behind it | 14:49 |
bauzas | EmilienM: which returns 1 indeed | 14:50 |
bauzas | https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1114 | 14:50 |
EmilienM | indeed | 14:50 |
amoralej | bauzas, EmilienM, i've been doing some additional tests and if no computes are found when running the command the cell is not added to cell_mappints table | 14:50 |
amoralej | so, it may be right to fail if no compute nodes are found | 14:51 |
bauzas | amoralej: that's an expected behaviour | 14:51 |
*** markvoelker has joined #openstack-nova | 14:51 | |
*** markvoelker_ has quit IRC | 14:51 | |
bauzas | so, the point is, what is the meaning of that return code equal to 1 | 14:51 |
EmilienM | so we need to run nova-compute *before* running this command? it might be very tricky | 14:51 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: Call preallocate_for_instance before scheduler https://review.openstack.org/413124 | 14:51 |
EmilienM | in multinode deployments specially | 14:51 |
*** liverpooler has quit IRC | 14:51 | |
*** hieulq_ has joined #openstack-nova | 14:51 | |
amoralej | bauzas, then in any case we need to get compute nodes before running it | 14:51 |
bauzas | EmilienM: well, I think no computes nodes doesn't mean that the command failed | 14:52 |
EmilienM | bauzas: https://github.com/openstack/nova/commit/a86d78f5f048e11ddb7e375f2d6cc707108b9478 | 14:52 |
bauzas | EmilienM: so, there are 2 possibilites | 14:52 |
EmilienM | alaski: ^ | 14:52 |
bauzas | either we say it's okay to have no computes when running that command, and then we should soft-fail with return code 0 | 14:52 |
bauzas | or, we ask users to deploy compute nodes before running that command | 14:53 |
amoralej | bauzas, in option 1, we'd need to re-run it after adding the compute nodes? | 14:53 |
bauzas | amoralej: indeed | 14:53 |
*** mjura has quit IRC | 14:54 | |
amoralej | then, option 1 converts to option 2 | 14:54 |
*** prateek has joined #openstack-nova | 14:54 | |
amoralej | even if command exit with rc 0, we need to orchestrate | 14:54 |
bauzas | you're right | 14:54 |
mdbooth | lyarwood: That's a separate issue, right? | 14:54 |
*** beagles is now known as beagles_afk | 14:54 | |
mdbooth | I mean, isn't that broken either way? | 14:54 |
amoralej | bauzas, i have a doubt about cell0 | 14:54 |
bauzas | amoralej: EmilienM: I was a bit off the recent cellsv2 discussions, so I don't know if we're planning something like an automatic mapping when adding nodes | 14:55 |
amoralej | what i find when i'm running the command after adding compute nodes is that a new cell is created in cell_mappings | 14:55 |
bauzas | amoralej: cell0 is a total different story | 14:55 |
bauzas | amoralej: cell0 is not a cell :p | 14:55 |
bauzas | well, it is a cell | 14:55 |
bauzas | but we could have named it "cemetery cell" | 14:56 |
amoralej | ok, then i have a new doubt, :) | 14:56 |
bauzas | it's for failed instances not having a compute node | 14:56 |
bauzas | ie. when the scheduler returns NoValidHosts, then the instance is mapped to cell0 | 14:56 |
lyarwood | mdbooth: nope, my change introduces the lookup, previously all the calls made by BlockDevice to libvirt would work with either a path or target dev | 14:56 |
amoralej | so, for single cell deployments, do i need only cell0 or cell0 and "reall cell" ? | 14:57 |
bauzas | instead of being mapped to the cell that the compute belongs to | 14:57 |
mdbooth | lyarwood: Of course. Got it. | 14:57 |
bauzas | amoralej: for real deployments, you need cell0 *and* a single cell | 14:57 |
*** sheel has quit IRC | 14:57 | |
amoralej | ok, understood | 14:57 |
*** prateek has quit IRC | 14:57 | |
*** prateek has joined #openstack-nova | 14:58 | |
bauzas | amoralej: that's why we populate cell0 with a db sync | 14:58 |
bauzas | so that we have everything like if it was a normal cell | 14:58 |
bauzas | anyway | 14:58 |
bauzas | EmilienM: amoralej: so, in order to tackle your problem | 14:58 |
bauzas | https://github.com/openstack/nova/commit/a18f601753f92ff4a2a42be0962a188f583bbfb9 just canary-tested an existing problem | 14:59 |
*** mtanino has joined #openstack-nova | 14:59 | |
bauzas | because previously, it was returning 0 as you were already having a cell0 | 15:00 |
bauzas | now, we're going past this point | 15:00 |
*** hongbin has joined #openstack-nova | 15:00 | |
*** dave-mccowan has joined #openstack-nova | 15:00 | |
amoralej | yes bauzas, i'm going to summarize this findings in the LP | 15:02 |
*** mandy has joined #openstack-nova | 15:04 | |
*** ducttape_ has joined #openstack-nova | 15:04 | |
mandy | hi | 15:05 |
*** liverpooler has joined #openstack-nova | 15:05 | |
*** jaosorior has joined #openstack-nova | 15:05 | |
mandy | could you anyone help me ?? | 15:06 |
*** jaosorior has quit IRC | 15:07 | |
bauzas | amoralej: so, just verified and FWIW, we create cells (and run the single cell command) *after* starting n-cpu in devstack | 15:08 |
bauzas | EmilienM: ^ | 15:08 |
bauzas | that's why the upstream nova jobs aren't trampled | 15:08 |
figleaf | mandy: just ask your question. | 15:08 |
*** eharney has joined #openstack-nova | 15:08 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] try py35 functional with a clean slate https://review.openstack.org/419968 | 15:08 |
*** mriedem has joined #openstack-nova | 15:08 | |
amoralej | bauzas, could you take a look to comment #3 in https://bugs.launchpad.net/nova/+bug/1656276 and confirm if it's right? | 15:09 |
openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | 15:09 |
*** claudiub|2 has joined #openstack-nova | 15:09 | |
*** ducttape_ has quit IRC | 15:09 | |
*** annegentle has joined #openstack-nova | 15:10 | |
mandy | actualy i am successfully create one vm in openstack using devtsack | 15:10 |
mandy | * devstack but unable to ping that vm ....could you plz help me | 15:11 |
mandy | ?? | 15:11 |
*** tblakes has joined #openstack-nova | 15:11 | |
*** mnestratov|2 has quit IRC | 15:11 | |
EmilienM | bauzas: interesting | 15:11 |
*** liverpooler has quit IRC | 15:11 | |
EmilienM | bauzas: link? | 15:11 |
*** liverpooler has joined #openstack-nova | 15:11 | |
mandy | i used private network | 15:12 |
*** claudiub|3 has joined #openstack-nova | 15:12 | |
*** claudiub has quit IRC | 15:12 | |
mandy | is anyone there | 15:12 |
mandy | ?? | 15:12 |
mriedem | ceph job is now non-voting, fyi | 15:13 |
openstackgerrit | sahid proposed openstack/nova: compute: reset instance events https://review.openstack.org/420026 | 15:13 |
diana_clarke | mandy: Those kinds of support/usage questions don't typically get answered here (see channel topic). | 15:13 |
mandy | ok | 15:14 |
mandy | thanks | 15:14 |
mandy | bye | 15:14 |
*** mandy has left #openstack-nova | 15:14 | |
*** claudiub|2 has quit IRC | 15:15 | |
*** jaosorior has joined #openstack-nova | 15:16 | |
EmilienM | mwhahaha: out of your mind, would it be doable to run this cell_v2 simple_cell_setup *after* starting nova-compute in tripleo? | 15:16 |
EmilienM | mwhahaha: I'm wondering about the steps | 15:16 |
*** annegentle has quit IRC | 15:16 | |
*** jwcroppe has joined #openstack-nova | 15:17 | |
bauzas | EmilienM: http://logs.openstack.org/90/409890/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/447ab55/logs/devstacklog.txt.gz#_2016-12-12_21_54_28_042 | 15:17 |
mriedem | mdbooth: how are you feeling about https://review.openstack.org/#/c/312488/ ? | 15:17 |
bauzas | (sorry, in internal meeting now) | 15:17 |
mriedem | the vz ci is running test_verify_created_server_ephemeral_disk now | 15:17 |
*** satyar has joined #openstack-nova | 15:17 | |
openstackgerrit | Vasyl Saienko proposed openstack/nova: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | 15:17 |
openstackgerrit | Vasyl Saienko proposed openstack/nova: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | 15:17 |
mwhahaha | why is this cell v2 setup stuff so complex | 15:18 |
mdbooth | mriedem: In a meeting. Get back in an hour or so. | 15:18 |
mwhahaha | it's so not 'simple' if you require cross node coordination prior to running it | 15:18 |
amoralej | EmilienM, i can start by removing the command as part of nova::db::sync and adding it at the end in p-o-i | 15:19 |
amoralej | that would be the first step, am i right? | 15:19 |
*** jaosorior has quit IRC | 15:19 | |
*** zz_dimtruck is now known as dimtruck | 15:19 | |
amoralej | mwhahaha ^ | 15:19 |
*** xyang1 has quit IRC | 15:19 | |
mwhahaha | no | 15:19 |
mwhahaha | it's lined up in the nova::deps | 15:19 |
EmilienM | amoralej: change needs to happen in puppet-nova, not poi (if we have to change something) | 15:19 |
*** ijw has joined #openstack-nova | 15:19 | |
EmilienM | right | 15:19 |
mwhahaha | https://github.com/openstack/puppet-nova/blob/master/manifests/deps.pp#L23-L26 | 15:20 |
*** smatzek has joined #openstack-nova | 15:20 | |
mwhahaha | also we would need to remove https://github.com/openstack/puppet-nova/blob/master/manifests/db/sync_api.pp#L45-L47 | 15:20 |
amoralej | this one is the one i have seen, not the deps stuff | 15:21 |
mwhahaha | we would want to touch both because we want to run sync after compute service starts | 15:21 |
*** jaosorior has joined #openstack-nova | 15:22 | |
mwhahaha | i still don't understand why these things keep getting added as hard requirements after the fact | 15:22 |
mwhahaha | first it was the db upgrade that broke everything and now it's you have to run it after computes, is any of this stuff documented? | 15:22 |
EmilienM | I agree it's not easy for deployers :( | 15:22 |
bauzas | EmilienM: amoralej: so, about a very short-term fix, here are my thoughts | 15:22 |
EmilienM | mriedem: ^ fyi | 15:22 |
amoralej | not really mwhahaha, i've spent the whole morning trying to understand it | 15:23 |
mwhahaha | i've probably wasted over a month on this stuff and operators are expected to use it? | 15:23 |
bauzas | EmilienM: amoralej: while I understand the point that it could be fancy for operators to have a way to automatically add the cell mapping when starting the compute, that's not written yet | 15:23 |
mwhahaha | why is cell v2 being a hard requirement if docs and the code aren't written yet? | 15:24 |
bauzas | EmilienM: amoralej: here, instead, in order to punt your problem, I'd rather recommend you to modify https://github.com/openstack/puppet-nova/blob/master/manifests/db/sync_cell_v2.pp#L32 and accept return codes to be 0 and 1 | 15:24 |
amoralej | bauzas, and requiring to run discover_hosts after every new compute nodes should be automated too, imho | 15:24 |
EmilienM | bauzas: but would tables be created in DB? | 15:24 |
mwhahaha | bauzas: that still doesn't handle the upgrade case where we need to have it created before we run the api sync for n ->o | 15:24 |
mwhahaha | bauzas: that's not acceptable | 15:24 |
bauzas | EmilienM: amoralej: it would put your CI back green, but would still require the cell command to be run *after* starting the compute | 15:25 |
*** ijw has quit IRC | 15:25 | |
bauzas | mwhahaha: upgrade is a very different case | 15:25 |
bauzas | mwhahaha: because you already have computes | 15:25 |
mwhahaha | bauzas: please point me to the documentation for upgrades vs install of cell v2 | 15:26 |
*** armax has joined #openstack-nova | 15:26 | |
bauzas | mwhahaha: here, the discussion is about the critical bug that tramples both puppet users and the TripleO CI | 15:26 |
*** jpena has joined #openstack-nova | 15:26 | |
bauzas | I'm just trying to tackle the problem asp | 15:27 |
bauzas | asap | 15:27 |
mwhahaha | this problem has existed in one form or another for more than a month | 15:27 |
mwhahaha | and every time we make progress, nova checks a change that completely destroys what we thought the process was previously | 15:27 |
mwhahaha | so i'd like not to have to repeat this again in a week | 15:27 |
mwhahaha | so we all understand how this thing is supposed to work, is there any documentation around how this is expected to function | 15:28 |
*** markvoelker has quit IRC | 15:28 | |
bauzas | mwhahaha: http://docs.openstack.org/releasenotes/nova/unreleased.html#id2 can help you | 15:28 |
EmilienM | I agree this thing is complex to deploy outside devstack | 15:28 |
EmilienM | specially in production | 15:28 |
bauzas | "Ocata requires that your deployment have created the cell and host mappings in Newton. If you have not done this, Ocata’s db sync command will fail. Small deployments will want to run nova-manage cell_v2 simple_cell_setup on Newton before upgrading. Operators must create a new database for cell0 before running cell_v2 simple_cell_setup. The simple cell setup command expects the name of the cell0 database to be <API database | 15:28 |
mwhahaha | bauzas: that's what we're doing | 15:29 |
mwhahaha | bauzas: but no mention of discover hosts or anything else | 15:29 |
mwhahaha | also release notes != documentation on the overall process | 15:29 |
*** tbachman has joined #openstack-nova | 15:29 | |
EmilienM | it doesn't mention ordering with nova-compute process, does it? | 15:29 |
* mwhahaha brb kids -> school | 15:29 | |
*** andreas_s has quit IRC | 15:30 | |
*** sacharya has joined #openstack-nova | 15:32 | |
bauzas | EmilienM: well, that's because we added the simple cell command in Newton :( | 15:33 |
bauzas | EmilienM: to answer your question, http://docs.openstack.org/releasenotes/nova/unreleased.html#id10 | 15:33 |
*** ducttape_ has joined #openstack-nova | 15:33 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [py35] Fixes to get rally scenarios working https://review.openstack.org/419476 | 15:35 |
mriedem | so docs is a known gap, i.e. docs that aren't release notes | 15:35 |
mriedem | i think dansmith was working on a blog post to start that, | 15:35 |
mriedem | but it would eventually be in the devref | 15:35 |
mriedem | laski had started some docs at one point but it's probably diverged quite a bit from how things actualy work now | 15:35 |
mriedem | having said all that, dan is out on vacation for a week | 15:36 |
mriedem | i don't know how far along dan was on a blog post, but i might start a doc if i can get some time | 15:37 |
melwitt | yeah, there isn't yet detail about how compute nodes are needed before running simple_cell_setup | 15:37 |
*** nkrinner is now known as nkrinner_afk | 15:37 | |
*** cleong has joined #openstack-nova | 15:37 | |
mriedem | melwitt: you mean otherwise you have to run discover_hosts? | 15:37 |
mriedem | i haven't read all of the scollback, | 15:38 |
melwitt | mriedem: well, discover_hosts actually won't work either because that requires you have at least one cell_mapping already | 15:38 |
melwitt | so really it would be you have to run map_cell_and_hosts I think | 15:38 |
melwitt | after compute hosts show up later | 15:38 |
mriedem | but if there are major things that people have run into in practice trying to get this setup, it would be helpful to post those in the mailing list for posterity rather than a dump in IRC which hits maybe 1% of people right now on a friday | 15:38 |
mriedem | EmilienM: mwhahaha: amoralej: ^ | 15:39 |
mriedem | because those are the things i want to make sure are addressed in a doc | 15:39 |
melwitt | what I'm wondering is whether the cells v2 upgrade check runs on a fresh install or not? | 15:39 |
mwhahaha | it doesn't | 15:39 |
*** kaisers has quit IRC | 15:39 | |
mwhahaha | the upgrade problem is something else | 15:39 |
mwhahaha | the problem is that you're adding requirements that no one know sabout | 15:39 |
mriedem | melwitt: which cells v2 upgrade check? the db schema migration? | 15:39 |
bauzas | melwitt: https://bugs.launchpad.net/nova/+bug/1656276 refers to a fresh install | 15:39 |
openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | 15:39 |
mwhahaha | oh yea,that's new as of today | 15:40 |
melwitt | mriedem: the thing that raises an error if there aren't two cell mappings | 15:40 |
bauzas | melwitt: and the proposed fix to amend https://github.com/openstack/puppet-nova/blob/master/manifests/db/sync_cell_v2.pp#L32 with return code 1 as valid would fix $ | 15:40 |
bauzas | would fix ^ (I mean) | 15:40 |
mriedem | melwitt: mwhahaha: so the db schema migration runs on a fresh install by first checking to see if there are any flavors, if there aren't then it noops | 15:40 |
bauzas | what mwhahaha is discussing is another issue, related to the upgrade path | 15:40 |
mwhahaha | https://bugs.launchpad.net/tripleo/+bug/1649341 was teh upgrade bug | 15:40 |
openstack | Launchpad bug 1649341 in tripleo "Undercloud upgrade fails with "Cell mappings are not created, but required for Ocata"" [Critical,In progress] - Assigned to Alex Schultz (alex-schultz) | 15:40 |
bauzas | so another bug | 15:40 |
melwitt | mriedem: the (_('Cells v2'), _check_cellsv2), in nova/cmd/status.py | 15:40 |
mriedem | melwitt: so that's different | 15:41 |
melwitt | I see | 15:41 |
mriedem | and we haven't integrated the nova-status upgrade check stuff into our CI pipeline yet | 15:41 |
mriedem | another TODO of mine | 15:41 |
mwhahaha | which the problem is to solve https://bugs.launchpad.net/tripleo/+bug/1649341 i need to know how to properly tackle https://bugs.launchpad.net/nova/+bug/1656276 | 15:41 |
openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | 15:41 |
mwhahaha | where i didn't until today | 15:41 |
mwhahaha | so now we're just adding complexity on complexity | 15:41 |
mwhahaha | and adding accept 1 doesn't solve the upgrade case | 15:42 |
melwitt | yeah, I don't think accepting 1 helps anything really | 15:42 |
mwhahaha | i had a solution for the upgrade until the requirement of compute nodes was added | 15:42 |
mriedem | mwhahaha: EmilienM: so can we hold on a minute, | 15:43 |
mriedem | i understand you're frustrated, | 15:43 |
bauzas | melwitt: it only helps their CI to be green | 15:43 |
* bauzas shrugs | 15:43 | |
mriedem | i need help with posting the list of issues you have in a form that doesn't require me to be chasing 3 conversations at once | 15:43 |
melwitt | I'm not sure it'll run correctly after that if there are no cell mappings created though (nova) | 15:43 |
EmilienM | it's not about a green CI | 15:43 |
EmilienM | it's about how people outside devstack deploy your software | 15:44 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [py35] Fixes to get rally scenarios working https://review.openstack.org/419476 | 15:44 |
mriedem | mwhahaha: EmilienM: so can you guys help me out by starting a ML thread with the current known issues you have so we can work through it there? | 15:44 |
EmilienM | mriedem: of course | 15:44 |
mriedem | b/c right now i'm not keeping up with this fire hose of stuff | 15:44 |
mriedem | and not everyone is around right now | 15:45 |
mriedem | so we need to start a list of items in the ML and tackle those | 15:45 |
mwhahaha | yea we can move to the ML | 15:45 |
bauzas | EmilienM: I don't disagree, I'm just trying to reduce the criticity so we can sit down and discuss without having the tense of urgency | 15:45 |
mriedem | we could start an etherpad too if that is helpful | 15:46 |
mriedem | hell i'm pretty sure we already have an etherpad for cells v2 | 15:46 |
bauzas | EmilienM: I'm really sorry that you folks are experiencing bugs against our recent improvements and I think your insights are definitely valid | 15:46 |
mriedem | i can't find the etherpad, only the wiki page | 15:47 |
mriedem | melwitt: do you know if we had a generic cells v2 etherpad for work items? | 15:48 |
*** burt has quit IRC | 15:48 | |
melwitt | mriedem: we've had a number of etherpads, let me see | 15:48 |
*** cdent has quit IRC | 15:48 | |
mriedem | melwitt: yeah this is the older wiki https://wiki.openstack.org/wiki/Nova-Cells-v2 | 15:49 |
mriedem | but not seeing anything generic there | 15:49 |
EmilienM | bauzas: let's get this thing fixed | 15:49 |
melwitt | https://etherpad.openstack.org/p/nova-multiple-cells https://etherpad.openstack.org/p/cellsV2-remaining-work-items are old ones | 15:50 |
*** mdrabe has quit IRC | 15:50 | |
*** prateek has quit IRC | 15:51 | |
*** mvk has quit IRC | 15:51 | |
mriedem | melwitt: thanks i added those to the wiki | 15:51 |
*** hieulq_ has quit IRC | 15:51 | |
*** hieulq_ has joined #openstack-nova | 15:52 | |
*** hieulq_ has quit IRC | 15:52 | |
*** markvoelker has joined #openstack-nova | 15:54 | |
mriedem | trying to update the TODOs in there also | 15:54 |
*** mlakat has quit IRC | 15:54 | |
*** markvoelker_ has joined #openstack-nova | 15:55 | |
*** markvoelker has quit IRC | 15:55 | |
melwitt | thanks mriedem | 15:56 |
mriedem | also https://review.openstack.org/#/c/420051/ | 15:57 |
mriedem | EmilienM: melwitt: bauzas: mwhahaha: ok i've updated https://wiki.openstack.org/wiki/Nova-Cells-v2#Nova_Cells_v2 a bit - linked in those older etherpads, freshed up the TODOs, and added those bugs | 15:58 |
mriedem | let me know if i missed something | 15:58 |
EmilienM | mriedem: thanks for helping | 15:59 |
EmilienM | mriedem: are we sure to backport https://review.openstack.org/#/c/420051/ ? | 16:00 |
EmilienM | it broke us on master :/ | 16:00 |
*** mdrabe has joined #openstack-nova | 16:00 | |
mriedem | EmilienM: i thought that change was made on master specifically for you guys | 16:01 |
mwhahaha | no | 16:02 |
mwhahaha | it's not for us, we were working prior to that | 16:02 |
melwitt | I think it was sort of a coincidence that it broke you, because simple_cell_setup has always returned 1 in the case of not finding compute nodes. the reason you got past it is because you ran map_cell0 separately before running simple_cell_setup, and the old version of simple_cell_setup returned 0 if it found cell0 i.e. it assumed it had already run in hte past | 16:02 |
mwhahaha | we don't run map_cell0 | 16:02 |
mwhahaha | cause we didn't know that was a thing | 16:02 |
*** marst has joined #openstack-nova | 16:03 | |
mriedem | ok i don't have the context on how that change broke you, is that in a bug somewhere? | 16:04 |
melwitt | in https://bugs.launchpad.net/nova/+bug/1656276 amoralej said you were mapping cell0 separately? | 16:04 |
openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | 16:04 |
mriedem | is that https://bugs.launchpad.net/tripleo/+bug/1649341 ? | 16:04 |
openstack | Launchpad bug 1649341 in tripleo "Undercloud upgrade fails with "Cell mappings are not created, but required for Ocata"" [Critical,In progress] - Assigned to Alex Schultz (alex-schultz) | 16:04 |
*** sridharg has quit IRC | 16:04 | |
melwitt | also from the code it's the only way you could have gotten simple_cell_setup to return 0 without any compute nodes | 16:04 |
melwitt | unless I've missed something | 16:05 |
mriedem | sorry i meant https://bugs.launchpad.net/nova/+bug/1656276 | 16:05 |
mwhahaha | so we're relying on puppet, and all we knew is that we had to run the simple setup (thats what we were told last time we came here with problems) | 16:05 |
mriedem | ok i've -W'd the backport until we can sort it out | 16:05 |
mwhahaha | so i went and implemented just the simple setup | 16:05 |
melwitt | mriedem: I *think* it's because they are running 'map_cell0' and then 'simple_cell_setup', before the idempotence patch it would all return 0, after the patch it returns 1 because it gets to the 'checking for hosts' part | 16:06 |
mwhahaha | cause i didn't know those other commands were required | 16:06 |
melwitt | the other commands aren't required | 16:06 |
amoralej | melwitt, we get cell0 by simple_cell_setup command | 16:06 |
mwhahaha | melwitt: evidently they are | 16:06 |
mwhahaha | melwitt: they weren't until that patch | 16:06 |
alaski | EmilienM: bauzas I've been out of discussions for a bit, but I had a PoC up at one point for computes to self register with a cell. It put an entry in the db that they could pull which told them which cell they were in, and then I was adding an HTTP API call for them to hit for registration. | 16:07 |
mriedem | melwitt: so you mean they got here https://review.openstack.org/#/c/420051/1/nova/cmd/manage.py@1240 ? | 16:07 |
mriedem | after that change i mean | 16:07 |
melwitt | yes | 16:07 |
*** voelzmo has quit IRC | 16:08 | |
amoralej | melwitt, we were getting return 0 in second execution | 16:08 |
mwhahaha | are you sure we're just not failing from line 1226 | 16:08 |
amoralej | because we retry it | 16:08 |
*** voelzmo has joined #openstack-nova | 16:08 | |
mriedem | melwitt: and that's because they got to https://review.openstack.org/#/c/420051/1/nova/cmd/manage.py@1379 ? | 16:08 |
mriedem | i.e. no computes yet so it would return 1 | 16:08 |
*** voelzmo has quit IRC | 16:08 | |
mriedem | well, | 16:08 |
alaski | bauzas: EmilienM https://review.openstack.org/#/c/369634/ | 16:08 |
mriedem | return None from that method, and simple_cell_setup would return 1 | 16:08 |
mriedem | which then broke tripleo, right? | 16:08 |
*** raunak has joined #openstack-nova | 16:09 | |
bauzas | alaski: yeah I remember now our discussions | 16:09 |
alaski | that was just an idea I had though, there had been no real discussion or consensus on the direction | 16:09 |
bauzas | yup, what I told to EmilienM and amoralej | 16:10 |
bauzas | EmilienM: amoralej: mwhahaha: melwitt: mriedem: sorry, was in a meeting | 16:10 |
*** hieulq_ has joined #openstack-nova | 16:10 | |
melwitt | alaski: that requires that a first cell was ever created though, right? they're in a situation where they have no compute hosts and no cell mapping other than cell0 | 16:11 |
amoralej | but, why can't create a cell without compute nodes? | 16:11 |
melwitt | I'm guessing to avoid creating orphaned cells | 16:11 |
bauzas | melwitt: we could simple setup cells with no computes, and populate the mappings when adding the nodes | 16:11 |
alaski | melwitt: right. that wouldn't solve their issue. I wasn't exactly clear what's being discussed now. | 16:11 |
mwhahaha | shouldn't the cell be created first then nodes added to it? | 16:12 |
mwhahaha | like it seems weird to do the other way around | 16:12 |
melwitt | alaski: is that why we don't create cell mappings with no hosts? to avoid orphaned cells? | 16:12 |
amoralej | from a functional, operational point of view, creating the cell first and registering compute nodes later make sense imo | 16:12 |
amoralej | in fact compute nodes should be automatically added | 16:12 |
amoralej | i'd say | 16:12 |
melwitt | they could, but they'd have to know what cell to automatically map to | 16:13 |
mriedem | the compute nodes self registering with a cell mapping requires an upcall from the compute to the api which we were trying to avoid, | 16:13 |
mriedem | but is what alaski's WIP patch was for i think | 16:13 |
mwhahaha | but if you have the transport url, isn't it just a message? | 16:13 |
melwitt | if you have several, they'd have to automatically go to some 'staging cell' before you move them to where you actually want them. I think that's why it's not straightforward to be automatic. unless you're talking single cell | 16:13 |
mwhahaha | i mean whats the point of adding the transport url to the cell config | 16:13 |
alaski | mriedem: yep, but I was going for an HTTP call which sidesteps it a bit. it's assuming there's an admin API for registering a node in a cell | 16:13 |
alaski | melwitt: I'm not sure there was a conscious decision to not allow mapping an empty cell, at least not that I'm aware of. | 16:14 |
melwitt | mwhahaha: that's for the api cell to call into a compute cell. when the cell mapping is created in the api, the compute cell's transport_url is part of the mapping so the api cell can talk to it | 16:14 |
alaski | melwitt: it is a bit strange to stand up a cell if there are no ready computes, but I can see why people would want that | 16:15 |
melwitt | alaski: okay. all the code is written that way so I think I assumed there was some consensus I missed :P | 16:15 |
melwitt | yeah. it only makes sense in the fresh install case | 16:15 |
alaski | melwitt: it's also possible I'm forgetting some discussion that happened | 16:15 |
mwhahaha | alaski: i would respectfully disagree because as you deploy, people don't configure comptues first | 16:15 |
*** cdelatte has joined #openstack-nova | 16:15 | |
mwhahaha | alaski: controllers (and their config) generally are first which is why this is a problem | 16:16 |
mriedem | honestly i think we probably just always thought about cells v2 in an upgrade scenario, not fresh install | 16:16 |
mriedem | for the most part | 16:16 |
alaski | yeah | 16:16 |
alaski | for the initial deploy an empty cell makes more sense, but standing up a second cell wouldn't typically happen if there are no computes for it | 16:16 |
melwitt | okay. well, I saw andrey has a review up for creating an empty cell | 16:17 |
mwhahaha | no it still makes sense | 16:17 |
mwhahaha | because you're growing your cloud, so you create the cell config and populate it with the new nodes | 16:17 |
alaski | mwhahaha: I'm not saying it doesn't make sense, but it also makes sense to say don't stand up a new cell if there are no computes for it yet | 16:17 |
cfriesen | mdbooth: are you there? | 16:18 |
melwitt | typically I think we've thought of adding cells as something that you do while the cloud is running, not during code deploy. right? | 16:18 |
alaski | yes | 16:19 |
melwitt | it's just this initial state problem | 16:19 |
mdbooth | cfriesen: Yep | 16:20 |
*** ijw has joined #openstack-nova | 16:21 | |
mwhahaha | alaski: so i guess i'm not clear on what you mean 'to say don't stand up a new cell if there are no computes for it' | 16:21 |
cfriesen | re: my question at https://review.openstack.org/#/c/337160/17/nova/virt/libvirt/driver.py. I'm trying to figure out why we unconditionally call root_disk.create_snap(). Why is it needed for resize/migration to a different host? | 16:21 |
mwhahaha | alaski: do you mean as a recommendation to operators that you shouldn't have an empty cell running? | 16:21 |
EmilienM | I agree, compute nodes are usually deployed at the very end | 16:21 |
*** dtp has joined #openstack-nova | 16:22 | |
mwhahaha | alaski: what's the impact of the empty cell? would break something? | 16:22 |
EmilienM | I think part of the reason is because in the past it used to requires some API to be running | 16:22 |
mdbooth | cfriesen: It's used for rollback of Rbd disks. | 16:22 |
alaski | mwhahaha: I'm saying that as a deployer I would not add a new cell to the system unless I had computes ready to add to that cell. I'm not going to stand up a new cell that won't do anything yet | 16:22 |
mdbooth | cfriesen: IIRC it's a no-op for all other backends. | 16:22 |
mdbooth | However, cold migration/resize have a resize->confirm/rollback workflow | 16:23 |
mwhahaha | alaski: well if i know i'm goign to have computes, i'd want to create the cell but wait to add the computes until i get to that phase of my install | 16:23 |
mwhahaha | alaski: that's the thing, fuel, kolla, tripleo we all do controller configs first then add computes later because we need to have keystone and stuff running first | 16:23 |
mdbooth | For disk-based local storage, we copy the instance dir, whether single host or migrating host | 16:23 |
mdbooth | For rbd, they're the same disks, so if we didn't snapshot we wouldn't be able to rollback. | 16:24 |
alaski | mwhahaha: an empty cell should not break anything afaik, but I've been out of cells for a bit now so I may be mistaken. | 16:24 |
cfriesen | mdbooth: okay, that makes sense. missed the fact it was a no-op for most cases. | 16:24 |
mwhahaha | alaski: sure, just trying to understand this better | 16:24 |
mriedem | alaski: is your perspective on that model biased to how it was done with cells v1? | 16:24 |
*** raunak has quit IRC | 16:24 | |
mriedem | an empty cell shouldn't break anything, no | 16:25 |
mdbooth | cfriesen: It's a reasonable hook. Possible other storage could be cleverer under some circumstances, but Rbd requires it. | 16:25 |
alaski | mriedem: very likely, I'm irreparably damaged from v1 | 16:25 |
mriedem | alaski: you're safe now, it's OK :) | 16:25 |
openstackgerrit | Sven Anderson proposed openstack/nova: Fix suggested database migration command https://review.openstack.org/420060 | 16:25 |
cfriesen | mdbooth: agreed, it's fine. I just didn't understand what was going on. | 16:25 |
* mwhahaha hides cell v1 under alaski's bed | 16:25 | |
mriedem | ok so i've updated https://wiki.openstack.org/wiki/Nova-Cells-v2#Nova_Cells_v2 with bugs, todos and open questoins | 16:26 |
mriedem | *questions | 16:26 |
alaski | note that I'm not trying to argue for not allowing an empty cell, just explaining why that assumption was in my head when writing code which likely affected the direction | 16:26 |
*** ijw has quit IRC | 16:26 | |
dtp | dansmith melwitt i'm at your disposal today | 16:27 |
mriedem | alaski: yup | 16:27 |
dims | mriedem : bauzas : https://review.openstack.org/#/c/419476/ gets the full cinder/rally test working. that test does a nova boot/attach/detach/delete etc. should be easy to review as well (almost all code protected with six.PY3 checks so wont regress existing stuff too) | 16:28 |
melwitt | dtp: dansmith is on PTO today FYI | 16:28 |
dtp | ok | 16:28 |
* dims waves to alaski | 16:29 | |
*** annegentle has joined #openstack-nova | 16:29 | |
alaski | o/ | 16:29 |
melwitt | so things used to work prior to that patch because the first run of simple_cell_setup created cell0 and then failed when it found no compute nodes, then the retry found cell0 and returned 0 | 16:29 |
melwitt | so it continued on without creating any cell mapping | 16:30 |
bauzas | melwitt: yup | 16:30 |
*** markus_z has quit IRC | 16:31 | |
dtp | melwitt i'll just be reviewing your and dan's changes under your blueprints. lemme know if there's something else i should do | 16:33 |
*** kaisers has joined #openstack-nova | 16:35 | |
dtp | if i don't respond immdediately, i'm trapped in a meeting | 16:35 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: handle uninited fields in notification payload https://review.openstack.org/415857 | 16:36 |
mriedem | melwitt: so the question right now is shoud this be a 1 or a 0 https://github.com/openstack/nova/blob/3ec43d81c324d8229bbb4b5db301175886a049b6/nova/cmd/manage.py#L1114 | 16:36 |
*** pcaruana has joined #openstack-nova | 16:36 | |
*** rmart04 has quit IRC | 16:37 | |
mriedem | that's also called from the map_cell_and_hosts CLI https://github.com/openstack/nova/blob/3ec43d81c324d8229bbb4b5db301175886a049b6/nova/cmd/manage.py#L1316 | 16:37 |
mriedem | note the comment in there about what the return codes mean (0 everything is done, 1 means you have more to do) | 16:37 |
melwitt | yeah. I think the 1 is supposed to be a signal that "hey, I didn't create any cell mappings other than cell0" | 16:38 |
mriedem | i think i took issue with that a bit during a review because i consider >0 == error | 16:38 |
sdague | which is the standard unixism | 16:38 |
melwitt | yeah | 16:38 |
sdague | set -e on bash, and this will blow up any script running it | 16:38 |
bauzas | mriedem: I think that if we wanna have simple_cell_setup idempotent, it's acceptable to have it return 0 if you have no hosts | 16:39 |
*** tjones has joined #openstack-nova | 16:39 | |
mriedem | right i tend to think that simple_cell_setup should not return >0 unless there is a real error | 16:39 |
melwitt | that's what I'm not sure of. I thought the command means "create cell mappings" and if there are no hosts, it doesn't | 16:39 |
bauzas | I agree | 16:39 |
bauzas | well, I agree with mriedem | 16:40 |
mriedem | map_cell_and_hosts *should* return 1 if there are no computes | 16:40 |
owalsh | mriedem: what's worse is that unhandled exceptions will return 1 | 16:40 |
mriedem | because you're specifically telling it to map hosts to cell mappings and if there are no computes, it's an error | 16:40 |
melwitt | mriedem: okay, I see what you're getting at | 16:40 |
mriedem | owalsh: well it depends on what the exception is | 16:40 |
bauzas | mriedem: I agree (again) | 16:40 |
bauzas | people could put simple_cells_setup in a cron and leave it run | 16:41 |
*** yamahata has joined #openstack-nova | 16:41 | |
mriedem | we also need to, at some point in the near future, probably do an audit of the various commands and figure out in which scenarios you'd use them | 16:41 |
mriedem | because we have a glut of CLIs for this right now | 16:41 |
owalsh | mriedem: anything uncaught that subclasses Exception it caugh in __main__ | 16:41 |
mriedem | owalsh: i don't see a problem with that | 16:41 |
bauzas | mriedem: melwitt: fancy leaving me submit a patch for changing the return code to 0 ? | 16:42 |
mriedem | owalsh: if we can't connect to the database and it raises an exception, then i think we should return a non-0 exit code | 16:42 |
dims | mriedem : "IBM PowerKVM" CI uses github to pull stuff? "GIT_BASE=git://github.com" (http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/76/419476/11/check/tempest-dsvm-full-xenial/2649398/console.html) | 16:42 |
bauzas | mriedem: yup, if we can't connect, it's a very different situation | 16:42 |
mriedem | dims: ask mmedvede | 16:42 |
bauzas | something is messed up | 16:42 |
owalsh | mriedem: yees, but having 1 == on computes, 2 == something else doesn't communicate any info | 16:42 |
owalsh | s/on/no/ | 16:42 |
* bauzas firing a patch | 16:42 | |
dims | mmedvede : looks like "IBM PowerKVM CI" got busted when github went down | 16:42 |
*** lamt has joined #openstack-nova | 16:42 | |
*** mlavalle has joined #openstack-nova | 16:42 | |
*** bnemec is now known as beekneemech | 16:43 | |
mriedem | bauzas: i think that's something we should at least put up a patch for yeah for bug 1656276 - make simple_cell_setup return 0 if map_cell_and_hosts returns None, and change map_cell_and_hosts (the CLI) to return 1 if there is nothing mapped | 16:43 |
openstack | bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] https://launchpad.net/bugs/1656276 | 16:43 |
mriedem | owalsh: i'm saying i don't like a non-0 exit code communicating non-error conditions, | 16:43 |
bauzas | mriedem: yup, and you reported a bug too ? | 16:43 |
mriedem | i.e. 1 == no computes | 16:43 |
mriedem | bauzas: that's bug 1656276 | 16:43 |
mriedem | it's what tripleo is hitting | 16:43 |
rfolco | dims, looking | 16:44 |
mmedvede | dims: yeah, we had problems pulling from git.o.o at some point | 16:44 |
bauzas | mriedem: I was thinking of https://bugs.launchpad.net/nova/+bug/1656017 | 16:44 |
openstack | Launchpad bug 1656017 in OpenStack Compute (nova) "nova-manage cell_v2 map_cell0 always returns a non-0 exit code" [Medium,Confirmed] | 16:44 |
mmedvede | that is the reason | 16:44 |
mriedem | bauzas: that's different | 16:44 |
dims | mmedvede : interesting, talked to our infra folks? | 16:44 |
bauzas | mriedem: but yeah, the patch I'm writing on is against 1656276 | 16:44 |
bauzas | mriedem: ie. changing what we return | 16:44 |
mriedem | dtp: you could tackle bug 1656017 if you want | 16:44 |
mriedem | dtp: that fix should be pretty straight-forward | 16:45 |
mmedvede | dims: it appeared to be a problem with our internal network, so I did not discuss with infra | 16:45 |
dtp | ok, i'll check it out | 16:45 |
dims | mmedvede : ack. thanks | 16:45 |
mriedem | bauzas: melwitt: the only reservation i have is that simpe_cell_setup will now return 0 for an incomplete setup | 16:45 |
mriedem | bauzas: melwitt: and we need to understand the implications of that | 16:45 |
mmedvede | dims: do you think there are inherent problems with using github vs git.o.o? | 16:45 |
melwitt | mriedem: yeah, that's what I was thinking about | 16:46 |
mriedem | it might just mean, print a message saying you need to run map_cell_and_hosts or discover_hosts after you've added compute nodes | 16:46 |
bauzas | mriedem: I know a bit of puppet world and idempotence, and I think it's reasonable | 16:46 |
bauzas | I mean, it's a reasonable assertion that an idempotent script can only provide a portion of what it can modify on the first run | 16:46 |
mmedvede | dims: ok, I see your comment above now re our CI going down with github | 16:46 |
dims | mmedvede : just surprised. you may get a stronger reaction from infra folks if you tell them :) | 16:46 |
dims | mmedvede : right | 16:46 |
owalsh | mriedem: yea, I don't like it either, but if we do want to communicate a specific condition in this way then non-zero, but not 1 | 16:46 |
bauzas | but eventually, after X runs, it would do all required | 16:46 |
*** READ10 has joined #openstack-nova | 16:47 | |
*** jose-phillips has joined #openstack-nova | 16:47 | |
mriedem | bauzas: melwitt: note that with the nova-status upgrade check command, | 16:47 |
mriedem | we don't consider it a failure if you don't have any computes yet https://github.com/openstack/nova/blob/3ec43d81c324d8229bbb4b5db301175886a049b6/nova/cmd/status.py#L168 | 16:47 |
mriedem | but you have cell mappings and cell0 | 16:47 |
mriedem | which is specifically for the fresh install case | 16:47 |
melwitt | mriedem: right, that's what I was trying to work backward from | 16:47 |
melwitt | mriedem: I like your idea about printing a message if simple_cell_setup finds no hosts, with a reminder what to do once you have compute hosts. the thing is the incomplete setup, things actually work fine for now because we have a bunch of fallbacks if no cell mappings, we run the old way | 16:49 |
rfolco | dims, stronger reaction means they disagree ? | 16:50 |
*** Apoorva has joined #openstack-nova | 16:50 | |
dims | rfolco : i think they would prefer direct git.openstack.org for sure | 16:50 |
*** liverpooler is now known as yrabl|lunch | 16:51 | |
mriedem | melwitt: hmm, the db schema migration will fail if you don't have cell mappings, | 16:51 |
mriedem | melwitt: but if you run that before adding flavors, then it's a noop | 16:51 |
bauzas | mriedem: melwitt: interesting, we return 0 in map_cell_and_hosts even if we have no hosts... | 16:51 |
rfolco | dims, ah ok. thanks for the ping. | 16:52 |
mriedem | so you could run the api_db sync, it passes b/c no flavors, then you run simple_cell_setup which only creates cell0, and then you register your computes - you won't have any cell mappings for those | 16:52 |
mriedem | bauzas: yeah i think that's part of the bug fix | 16:52 |
mriedem | as noted above | 16:52 |
*** lamt has quit IRC | 16:52 | |
mriedem | melwitt: i'm pretty sure we are dumping warnings in the logs if we don't find a cell mapping and fallback to the main db | 16:52 |
bauzas | mriedem: yeah, I will change that | 16:52 |
melwitt | yeah, I can't remember how that got decided. probably the argument of "error condition vs not" | 16:53 |
mriedem | melwitt: the automatic compute node / cell mapping registration would fix this...but it's just not something we've been serious about adding | 16:53 |
mriedem | thinking about gradually increasing levels of pain, which has been our MO, | 16:54 |
melwitt | mriedem: yeah. it's not straightforward how to do that because, how do you make assumptions about what cell to auto map new hosts to? usually that's deliberate decision on the part of the operator | 16:54 |
mriedem | we could do the fallback with a warning in ocata, then make that an error in pike | 16:54 |
dtp | afk a bit | 16:54 |
mriedem | melwitt: right you'd need to probably flag some cell mapping as the 'default' to auto-register with | 16:54 |
mriedem | so in ocata we have the fallback mechanism if we don't find a cell mapping, | 16:55 |
melwitt | yeah, that's what I had in mind. new stuff goes into some "staging cell" and then after that you have to re-map. though I don't even think we have a way to re-map | 16:55 |
mriedem | which buys us some time to consider an auto-registration in pike, or remove the fallback and make it an error | 16:55 |
mriedem | melwitt: we'd probably have to write a REST API for remapping, or nova-manage CLI | 16:56 |
melwitt | yeah, probably nova-manage | 16:56 |
*** bvanhav_ has joined #openstack-nova | 16:56 | |
*** bvanhav has quit IRC | 16:57 | |
mriedem | ok i've added those questions to https://wiki.openstack.org/wiki/Nova-Cells-v2#Open_Questions | 16:58 |
melwitt | mriedem: I'm wondering if maybe map_cell_and_hosts should stay as returning 0 (since it prints what the deal is, if it found nothing to map) | 16:58 |
bauzas | mriedem: melwitt: patch is wired, just a few mins for adapting tests | 16:59 |
*** ralonsoh has quit IRC | 16:59 | |
melwitt | and later code warnings let you know that you need to do something, if no cell mappings are found while nova is running | 16:59 |
mriedem | melwitt: _map_cell_and_hosts treats that differently | 17:00 |
mriedem | if things are already done, it returns a uuid https://github.com/openstack/nova/blob/3ec43d81c324d8229bbb4b5db301175886a049b6/nova/cmd/manage.py#L1275 | 17:00 |
mriedem | if there are no computes, it returns None | 17:00 |
mriedem | None is the error, the uuid is the non-error we're already done case | 17:00 |
melwitt | okay, yeah | 17:01 |
bauzas | mriedem: melwitt: is the proposed patch http://paste.openstack.org/show/594860/ | 17:01 |
*** sudipto has quit IRC | 17:01 | |
*** sudipto_ has quit IRC | 17:01 | |
melwitt | I think we have had this debate before, is doing nothing really an error. I think we usually say it isn't | 17:02 |
melwitt | from the perspective of returning a non-zero | 17:02 |
mriedem | it probably depends on the command | 17:04 |
*** ociuhandu has quit IRC | 17:07 | |
*** sahid has quit IRC | 17:07 | |
mriedem | sdague: melwitt: if you're not otherwise distracted, can you take a look at this https://review.openstack.org/#/c/398472/ - would be good to get that in and avoid more rebasing | 17:08 |
*** burt has joined #openstack-nova | 17:08 | |
*** derekh has quit IRC | 17:08 | |
mriedem | bauzas: when you're done with this bug fix are you going to address my comments on the resource providers 'resources' query patch | 17:09 |
mriedem | ? | 17:09 |
*** cdent has joined #openstack-nova | 17:09 | |
bauzas | mriedem: I had an hard day | 17:09 |
bauzas | mriedem: but yeah it's in my pipe | 17:09 |
mriedem | heh, ok :) | 17:09 |
mriedem | jay might be able to make those updates too but he's not around right now | 17:10 |
*** raunak has joined #openstack-nova | 17:11 | |
bauzas | mriedem: no worries, today is not ended for me | 17:12 |
dims | mriedem : sdague : the py35 change for nova boot/attach/detach/delete working is all green - https://review.openstack.org/#/c/419476/ | 17:12 |
bauzas | I'm not Jack Bauer but there 24 hours in a day | 17:12 |
mriedem | sean-k-mooney: if you're willing it'd be great to rebase this series https://review.openstack.org/#/c/410737/ | 17:13 |
mriedem | the merge conflict is i think b/c of the os-vif unit test fix i made yesterday | 17:13 |
mdbooth | bauzas: Jack Bauer would say that if he was trying to maintain cover... | 17:14 |
mdbooth | Just saying | 17:14 |
sean-k-mooney | mriedem: sure if francesco is not around i have i can rebase them | 17:14 |
mriedem | sean-k-mooney: i don't know his irc nick, | 17:14 |
mriedem | or if he's even on irc but don't see him | 17:14 |
mriedem | frasantoro - nope | 17:15 |
sean-k-mooney | im just finishing up another commit but ill try and rebase this in the next hour or so if that works for you. | 17:15 |
mriedem | sounds good, i'll get to it eventually if you can't, it's fine | 17:15 |
mriedem | i'm going to head to lunch, bbiab | 17:15 |
*** rmart04 has joined #openstack-nova | 17:16 | |
*** nic has joined #openstack-nova | 17:16 | |
*** rmart04 has quit IRC | 17:17 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Accept simple_cell_setup to partially complete its tasks https://review.openstack.org/420079 | 17:17 |
bauzas | melwitt: mriedem: ^ | 17:17 |
*** lamt has joined #openstack-nova | 17:18 | |
*** rwmjones|hols is now known as rwmjones | 17:19 | |
*** mriedem1 has joined #openstack-nova | 17:19 | |
*** mriedem has quit IRC | 17:20 | |
*** swamireddy has joined #openstack-nova | 17:25 | |
*** swebster has quit IRC | 17:27 | |
*** rmart04 has joined #openstack-nova | 17:28 | |
*** rmart04 has quit IRC | 17:28 | |
*** nherciu_ has joined #openstack-nova | 17:28 | |
*** eharney has quit IRC | 17:29 | |
*** gszasz has quit IRC | 17:29 | |
*** nherciu has quit IRC | 17:29 | |
*** slaweq has quit IRC | 17:30 | |
*** kaisers has quit IRC | 17:30 | |
*** nherciu__ has joined #openstack-nova | 17:31 | |
*** patriciadomin has joined #openstack-nova | 17:31 | |
dims | thanks sdague ! | 17:31 |
*** slaweq has joined #openstack-nova | 17:32 | |
*** lpetrut has quit IRC | 17:33 | |
*** nherciu_ has quit IRC | 17:34 | |
*** mvk has joined #openstack-nova | 17:38 | |
*** yamahata has quit IRC | 17:38 | |
*** ri0 has joined #openstack-nova | 17:40 | |
*** _ducttape_ has joined #openstack-nova | 17:41 | |
*** tbachman has quit IRC | 17:41 | |
*** rama_y has joined #openstack-nova | 17:41 | |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: Call preallocate_for_instance before scheduler https://review.openstack.org/413124 | 17:42 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: Add processed_requests to allocate_for_instance https://review.openstack.org/420103 | 17:42 |
*** ducttape_ has quit IRC | 17:44 | |
*** cdent has quit IRC | 17:44 | |
*** salv-orlando has joined #openstack-nova | 17:45 | |
*** unicell has quit IRC | 17:47 | |
*** ri0 has left #openstack-nova | 17:48 | |
*** eharney has joined #openstack-nova | 17:51 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 17:52 |
cfriesen | any libvirt experts around? When nova calls self._domain.resume(), is that an async call or a sync call? i.e. when it returns has qemu actually transitioned to a "running" state, or does it just send a message but it could be delayed due to scheduling? | 17:55 |
*** jwcroppe has quit IRC | 17:56 | |
*** ociuhandu has joined #openstack-nova | 17:58 | |
*** jwcroppe has joined #openstack-nova | 17:59 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 17:59 |
*** satyar has quit IRC | 18:01 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 18:01 |
openstackgerrit | John Garbutt proposed openstack/nova: WIP: Call preallocate_for_instance before scheduler https://review.openstack.org/413124 | 18:03 |
*** Guest45759 is now known as dansmith | 18:04 | |
*** jpena is now known as jpena|brb | 18:04 | |
*** ijw has joined #openstack-nova | 18:04 | |
*** hieulq_ has quit IRC | 18:06 | |
*** links has quit IRC | 18:12 | |
*** swebster has joined #openstack-nova | 18:15 | |
*** browne has joined #openstack-nova | 18:16 | |
*** yamahata has joined #openstack-nova | 18:16 | |
*** Swami has joined #openstack-nova | 18:22 | |
jroll | mriedem1: I'm +1 on the ironic attach/detach/portgroups patches, ruby is out today but I expect she'll be happy with them too | 18:24 |
jroll | the soft power client patch needs another re-spin | 18:24 |
jroll | I think that's all I have to update you on... | 18:25 |
jroll | oh, the hashring thing we did last cycle, that's released in tooz now, do y'all have time for a patch to move to use tooz this cycle yet? (should be mostly ripping code out) | 18:25 |
*** _ducttape_ has quit IRC | 18:25 | |
*** pcaruana has quit IRC | 18:26 | |
*** ducttape_ has joined #openstack-nova | 18:26 | |
*** kaisers has joined #openstack-nova | 18:27 | |
*** owalsh has quit IRC | 18:28 | |
*** unicell has joined #openstack-nova | 18:28 | |
*** owalsh has joined #openstack-nova | 18:29 | |
*** tbachman has joined #openstack-nova | 18:30 | |
*** mriedem1 is now known as mriedem | 18:33 | |
mriedem | jroll: umm, maybe | 18:33 |
mriedem | jroll: there was also the inject nmi patch but i think that was waiting on some dependencies too | 18:34 |
mriedem | cfriesen: i usually default to think that anything libvirt/qemu does is async | 18:34 |
jroll | mriedem: yeah, that's not even done in ironic, I don't expect it this cycle | 18:34 |
mriedem | i think most things are done via an async job | 18:34 |
mriedem | cfriesen: kashyap or mdbooth or sahid are the people i'd ask | 18:35 |
mriedem | jroll: ok | 18:35 |
jroll | mriedem: I'll do the tooz thing now so you can see how simple it is. it passed tests with flying colors about a month ago with some weird depends-ons | 18:36 |
mriedem | ok, just got back from lunch and still sore from the cells v2 beating i took this morning | 18:37 |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Move to tooz hash ring implementation https://review.openstack.org/399022 | 18:37 |
jroll | oh, easiest merge conflict ever | 18:37 |
jroll | there you are if curious | 18:37 |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Move to tooz hash ring implementation https://review.openstack.org/399022 | 18:38 |
jroll | much better with the right version | 18:39 |
*** pcaruana has joined #openstack-nova | 18:39 | |
*** sree has joined #openstack-nova | 18:41 | |
*** tbachman has quit IRC | 18:41 | |
*** dharinic is now known as dharinic|lunch | 18:42 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me - ry py35 functional with a clean slate https://review.openstack.org/419968 | 18:43 |
*** lpetrut has joined #openstack-nova | 18:43 | |
*** sree has quit IRC | 18:46 | |
*** jwcroppe has quit IRC | 18:48 | |
*** tbachman has joined #openstack-nova | 18:51 | |
cfriesen | mriedem: thanks...I did some experiments and it looks like it's actually sync...if I send a SIGSTOP to qemu or libvirtd the nova call to self._domain.resume() hangs until I send a SIGCONT | 18:51 |
*** jwcroppe has joined #openstack-nova | 18:53 | |
openstackgerrit | Dan Peschman proposed openstack/nova: nova-manage cell_v2 map_cell0 exit 0 https://review.openstack.org/420132 | 18:53 |
*** tesseract has quit IRC | 18:53 | |
dtp | mriedem ^ going to lunch | 18:54 |
harlowja | dtp thx for helping here :) | 18:54 |
dtp | why you're welcome harlowja! :) | 18:55 |
harlowja | :-P | 18:55 |
*** openstack has joined #openstack-nova | 18:59 | |
sean-k-mooney | mriedem: i have resolved most of the erros in francesco's patches locally but one of his changes need the fastpath os-vif plugin to work which is incorrect http://logs.openstack.org/61/385061/7/check/gate-nova-python27-db-ubuntu-xenial/336f68e/console.html#_2017-01-12_23_22_43_325595 | 19:01 |
*** kaisers has quit IRC | 19:01 | |
*** lpetrut has quit IRC | 19:01 | |
sean-k-mooney | mriedem: im going to invert the order of his patches so https://review.openstack.org/#/c/410737/ can merge | 19:01 |
sean-k-mooney | or at least be unblocked by the gate | 19:02 |
*** gouthamr has joined #openstack-nova | 19:02 | |
*** pcaruana has quit IRC | 19:02 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me - ry py35 functional with a clean slate https://review.openstack.org/419968 | 19:05 |
*** satyar has joined #openstack-nova | 19:06 | |
*** lpetrut has joined #openstack-nova | 19:09 | |
*** jpena|brb is now known as jpena | 19:09 | |
mriedem | sean-k-mooney: sounds good to me | 19:11 |
*** jamielennox is now known as jamielennox|away | 19:12 | |
*** jpena is now known as jpena|away | 19:17 | |
*** dharinic|lunch is now known as dharinic | 19:17 | |
mriedem | GET /jaypipes | 19:19 |
openstackgerrit | sean mooney proposed openstack/nova: os-vif: convert libvirt driver to use os-vif for fast path vhostuser https://review.openstack.org/385061 | 19:19 |
openstackgerrit | sean mooney proposed openstack/nova: os-vif-util: set vif_name for vhostuser ovs os-vif port https://review.openstack.org/410737 | 19:19 |
*** markvoelker_ has quit IRC | 19:19 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: WIP - libvirt: workaround findmnt behaviour change https://review.openstack.org/420146 | 19:20 |
*** markvoelker has joined #openstack-nova | 19:20 | |
openstackgerrit | Lee Yarwood proposed openstack/nova: WIP - libvirt: workaround findmnt behaviour change https://review.openstack.org/420146 | 19:25 |
*** markvoelker has quit IRC | 19:25 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me - ry py35 functional with a clean slate https://review.openstack.org/419968 | 19:35 |
mriedem | jroll: is there any way for you to tell if this job failed for a known ironic timeout http://logs.openstack.org/73/398473/22/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/3dbaaef/ ? | 19:35 |
openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Use the mirror element to detect when to pivot https://review.openstack.org/399735 | 19:35 |
mriedem | jroll: b/c it failed on https://review.openstack.org/#/c/398473/ which is moving a bunch of parts around in the compute resource tracker | 19:35 |
jroll | mriedem: so, this is pretty typical http://logs.openstack.org/73/398473/22/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/3dbaaef/console.html#_2017-01-13_16_02_01_111488 | 19:36 |
jroll | but could also be because pxe booting got broken somehow or whatever | 19:36 |
mriedem | it passed on the patch before and after that one so i assume it's not due to the actual change being tested | 19:37 |
jroll | wtf empty console logs | 19:37 |
jroll | yeah, probably not then | 19:37 |
jroll | mriedem: sometimes node* here is indicative (you'll see it cut off during boot or whatever) but something went wrong and they're empty http://logs.openstack.org/73/398473/22/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/3dbaaef/logs/ironic-bm-logs/ | 19:38 |
mriedem | cool, just rechecked it | 19:38 |
jroll | cool | 19:38 |
lyarwood | mriedem: is the placement job voting in the stable/newton gate btw? | 19:38 |
jroll | we've been seeing timeouts creep back up lately, unclear why | 19:38 |
mriedem | lyarwood: no | 19:38 |
lyarwood | mriedem: I just ack'd the two reviews from yesterday, they both failed the placement job a few days ago | 19:38 |
mriedem | lyarwood: the placement job was failing on newton b/c of an infra issue with the job definition, it was trying to call a post test hook which didn't exist | 19:39 |
mriedem | i fixed that on wednesday | 19:39 |
lyarwood | argh, they failed on Thursday | 19:40 |
mriedem | lyarwood: maybe i fixed it thursday :) | 19:40 |
mriedem | http://logs.openstack.org/17/419217/1/check/gate-tempest-dsvm-neutron-placement-full-ubuntu-xenial-nv/086c49e/logs/devstack-gate-post_test_hook.txt.gz | 19:40 |
mriedem | but ^ was the issue | 19:40 |
mriedem | https://review.openstack.org/#/c/419243/ | 19:41 |
lyarwood | ah cool | 19:41 |
mriedem | yeah it was yesterday | 19:41 |
mriedem | been a long week | 19:41 |
lyarwood | yeah, tell me about it | 19:41 |
mriedem | the other series in newton for placement that i have here https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton+topic:bug/1651678 | 19:41 |
mriedem | one of the changes towards the end is failing functional tests for some reason which i need to investigate | 19:42 |
mriedem | so you can hold off on that series | 19:42 |
lyarwood | don't worry I was going to :) | 19:42 |
mriedem | heh | 19:42 |
mriedem | i mean at quarter to 8 on a friday, reviewing that series is about as much fun as you should have | 19:42 |
lyarwood | haha aye, unfortunately my presence is required downstream to fight another fire, otherwise I'd be all over that at this time on Friday ;) | 19:44 |
*** Guest87783 is now known as med_ | 19:47 | |
*** med_ has joined #openstack-nova | 19:47 | |
*** med_ is now known as medberry | 19:47 | |
*** eglynn has quit IRC | 19:48 | |
dims | mriedem : so got one +2 from sdague and a review from cdent in the morning. any chance for getting it merged today? https://review.openstack.org/#/c/419476/ | 19:51 |
*** gouthamr has quit IRC | 19:51 | |
dims | mriedem : thanks in advance! | 19:51 |
mriedem | not from me right now, i have other fires | 19:51 |
* mriedem puts out the nova core distress signal | 19:52 | |
dims | :) no worries. just did not want to keep asking | 19:52 |
*** dimtruck is now known as zz_dimtruck | 19:52 | |
dims | melwitt : how about you? :) | 19:52 |
melwitt | maybe later, working on something related to cells v2 fire right now | 19:53 |
dims | ack thanks melwitt | 19:54 |
*** amoralej is now known as amoralej|off | 19:54 | |
*** gouthamr has joined #openstack-nova | 19:55 | |
*** kaisers has joined #openstack-nova | 19:57 | |
*** openstackstatus has quit IRC | 19:57 | |
*** openstack has joined #openstack-nova | 19:59 | |
*** david-lyle is now known as baling-wire | 20:00 | |
*** nherciu__ has quit IRC | 20:01 | |
sdague | timing on that sucks, mostly with dansmith heading out to the wood with only a ham radio | 20:02 |
mriedem | well i think he's around a bit yet | 20:02 |
mriedem | but yes | 20:02 |
melwitt | he said he'll be around this afternoon, we'll have him on monday too. but starting tuesday he's out next week | 20:03 |
mriedem | ok i've replied to the ML thread | 20:05 |
mriedem | with my brain dump | 20:05 |
dims | hmm, looks like cdent is done for the day as well. seeing some gabbit related issues | 20:06 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me - ry py35 functional with a clean slate https://review.openstack.org/419968 | 20:06 |
mriedem | sdague: we also need https://review.openstack.org/#/c/392569/ updaed | 20:08 |
mriedem | *updated | 20:08 |
mriedem | although i haven't gone through that whole patch yet | 20:09 |
mriedem | and the things i pointed out already probably aren't the end of the world | 20:09 |
melwitt | mriedem: I'm fixing up the create_cell patch right now, just fyi | 20:10 |
*** psachin has joined #openstack-nova | 20:10 | |
mriedem | melwitt: yup, i know (already) :) | 20:11 |
*** liusheng has quit IRC | 20:11 | |
*** eharney has quit IRC | 20:11 | |
*** liusheng has joined #openstack-nova | 20:11 | |
EmilienM | mriedem: thanks for your help, very appreciated | 20:12 |
mriedem | yw | 20:13 |
*** tbachman has quit IRC | 20:17 | |
*** READ10 has quit IRC | 20:19 | |
*** rfolco has quit IRC | 20:19 | |
*** moshele has joined #openstack-nova | 20:23 | |
*** zz_dimtruck is now known as dimtruck | 20:24 | |
*** eharney has joined #openstack-nova | 20:26 | |
*** openstackstatus has quit IRC | 20:27 | |
*** openstack has joined #openstack-nova | 20:29 | |
*** moshele has quit IRC | 20:30 | |
*** salv-orlando has quit IRC | 20:32 | |
*** bvanhav_ has quit IRC | 20:36 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me - ry py35 functional with a clean slate https://review.openstack.org/419968 | 20:41 |
*** cdelatte has quit IRC | 20:43 | |
*** jaosorior has quit IRC | 20:45 | |
*** jaosorior has joined #openstack-nova | 20:45 | |
openstackgerrit | Slawek Kaplonski proposed openstack/nova: Set sysinfo_serial="none" in LibvirtDriverTestCase https://review.openstack.org/420176 | 20:46 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make metadata server know about cell mappings https://review.openstack.org/417962 | 20:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Multicell support for instance listing https://review.openstack.org/396775 | 20:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Make api_samples tests use simple cell environment https://review.openstack.org/410473 | 20:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | 20:48 |
*** marst has quit IRC | 20:49 | |
*** slaweq has quit IRC | 20:50 | |
*** satyar has quit IRC | 20:51 | |
*** annegentle has quit IRC | 20:55 | |
*** annegentle has joined #openstack-nova | 20:59 | |
*** claudiub has joined #openstack-nova | 21:00 | |
mriedem | sdague: i'm cool with this pretty simple patch https://review.openstack.org/#/c/417962/ | 21:04 |
*** claudiub|3 has quit IRC | 21:04 | |
*** lpetrut has quit IRC | 21:05 | |
*** ijw has quit IRC | 21:05 | |
*** browne has quit IRC | 21:07 | |
openstackgerrit | melanie witt proposed openstack/nova: Add nova-manage cell_v2 create_cell command https://review.openstack.org/332713 | 21:08 |
*** browne has joined #openstack-nova | 21:09 | |
*** kaisers has quit IRC | 21:10 | |
*** rha has quit IRC | 21:14 | |
openstackgerrit | sean mooney proposed openstack/os-vif: [DO NOT MERGE] this a test patch for os-vif gate. https://review.openstack.org/420179 | 21:14 |
*** Apoorva has joined #openstack-nova | 21:16 | |
openstackgerrit | Diana Clarke proposed openstack/nova: copy pasta error https://review.openstack.org/420180 | 21:17 |
diana_clarke | ^ easy review for Friday brains ;) | 21:17 |
*** rfolco has joined #openstack-nova | 21:18 | |
*** rfolco has quit IRC | 21:23 | |
*** JoseMello has quit IRC | 21:25 | |
*** tbachman has joined #openstack-nova | 21:28 | |
*** xyang1 has joined #openstack-nova | 21:28 | |
*** gouthamr has quit IRC | 21:31 | |
openstackgerrit | Diana Clarke proposed openstack/nova: DNM: check experimental queue https://review.openstack.org/420186 | 21:34 |
*** Jeffrey4l__ has joined #openstack-nova | 21:34 | |
*** Jeffrey4l_ has quit IRC | 21:35 | |
mriedem | sean-k-mooney: i think https://review.openstack.org/#/c/410737/ is depending on the wrong patch | 21:38 |
mriedem | that's why gate-nova-requirements failed | 21:39 |
mriedem | i'll update it quick | 21:39 |
openstackgerrit | Matt Riedemann proposed openstack/nova: os-vif: convert libvirt driver to use os-vif for fast path vhostuser https://review.openstack.org/385061 | 21:40 |
openstackgerrit | Matt Riedemann proposed openstack/nova: os-vif-util: set vif_name for vhostuser ovs os-vif port https://review.openstack.org/410737 | 21:40 |
*** weshay is now known as weshay_afk | 21:44 | |
*** timello has quit IRC | 21:48 | |
dtp | anyone need anything re cells v2? | 21:51 |
mriedem | dtp: for right now i don't think so | 21:51 |
dtp | ok | 21:51 |
*** timello has joined #openstack-nova | 21:53 | |
*** cleong has quit IRC | 21:54 | |
*** smatzek has quit IRC | 21:54 | |
*** salv-orlando has joined #openstack-nova | 21:55 | |
*** jamielennox|away is now known as jamielennox | 21:59 | |
*** thorst_ has quit IRC | 22:02 | |
*** ijw has joined #openstack-nova | 22:03 | |
*** thorst has joined #openstack-nova | 22:03 | |
*** eharney has quit IRC | 22:06 | |
*** kaisers has joined #openstack-nova | 22:06 | |
*** jdurgin1 has joined #openstack-nova | 22:07 | |
*** thorst has quit IRC | 22:07 | |
*** ijw has quit IRC | 22:07 | |
*** ijw has joined #openstack-nova | 22:11 | |
*** xyang1 has quit IRC | 22:21 | |
melwitt | mriedem: trying to make sure I have this right in my head ... is the expectation during an upgrade to ocata that the appropriate cells v2 setup commands be run using the ocata code, before running the db sync? or is the expectation to run the setup using the newton code before starting the upgrade | 22:22 |
*** salv-orl_ has joined #openstack-nova | 22:22 | |
mriedem | melwitt: in grenade we run simple_cell_setup in newton before going to ocata: https://review.openstack.org/#/c/393441/2/projects/60_nova/from-newton/upgrade-nova | 22:24 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me - ry py35 functional with a clean slate https://review.openstack.org/419968 | 22:24 |
mriedem | but simple_cell_setup is meant to be idempotent so you can run it as many times as needed | 22:24 |
mriedem | but you're asking because we don't have create_cell in newton | 22:25 |
melwitt | okay. I was wondering if it's also fine to run them in ocata, just before the db sync | 22:25 |
melwitt | yes, pretty much | 22:25 |
*** salv-orlando has quit IRC | 22:25 | |
mriedem | well, for the nova_api db sync to work, you have to have created the cell mappings and cell0 | 22:25 |
mriedem | so (1) simple_cell_setup, (2) api-db sync | 22:25 |
melwitt | and also the simple_cell_setup has an enhancement in ocata to take the transport url from the conf, which is pretty important. I think it can be backported (I checked oslo.messaging stuff) | 22:25 |
mriedem | because (2) has the blocking schema migration | 22:25 |
melwitt | but I was thinking, do we need to backport all this stuff or no | 22:25 |
melwitt | right | 22:26 |
mriedem | melwitt: i remember you asking about backporting that one, i think if it was ok w/ the oslo.messaging version in newton i think we can backport it | 22:26 |
mriedem | if you haven't already done so | 22:26 |
*** baling-wire is now known as david-lyle | 22:26 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add some cellsv2 setup docs https://review.openstack.org/420198 | 22:26 |
mriedem | well look who it is | 22:26 |
dansmith | mriedem: melwitt ^ | 22:26 |
melwitt | yeah, I was just wondering if it's necessary. maybe not necessary but it would be nice to have the option to run them in newton? | 22:26 |
*** ducttape_ has quit IRC | 22:27 | |
dansmith | after writing that, I almost think maybe we should do away with the simple command, or at least not stress its usage | 22:27 |
dansmith | once we have the create command | 22:27 |
dansmith | I think it's more straightforward to think about "create cell, discovery hosts" | 22:27 |
dansmith | once we merge the create command I will change devstack to do the same thing for cellsv1 and normal, removing the simple usage | 22:28 |
*** thorst has joined #openstack-nova | 22:28 | |
melwitt | yeah, not surprisingly the highly niched batch command ends up being more confusing than it's worth | 22:29 |
dansmith | well, it was supposed to make it easy for people, but... | 22:29 |
mriedem | dansmith: yeah i did mention something to that effect in the ML, i.e. doing different things for upgrade scripts (grenade) and fresh install scripts (devstack) | 22:29 |
mriedem | but it depends on where we end up probably | 22:30 |
melwitt | dansmith: I dunno if you saw my earlier question but, I was asking is it equally okay to run cells v2 setup stuff after you've gotten ocata code, just make sure you do it before any db sync? | 22:30 |
openstackgerrit | Scott DAngelo proposed openstack/nova: WIP Do Not Merge https://review.openstack.org/420201 | 22:30 |
melwitt | or do we need to backport all these command changes to newton | 22:30 |
mriedem | if create_cell is going to be required for upgrade, then we're going to have to backport it to newton and change grenade | 22:30 |
dansmith | yeah | 22:30 |
dansmith | although the simple command will still work for people upgrading, | 22:30 |
melwitt | okay | 22:30 |
mriedem | right | 22:30 |
mriedem | i like simple_cell_setup in grenade, but not devstack | 22:31 |
dansmith | so maybe we just backport changes to it to make it work, and bill it as the "get you to ocata command" and then do away with it later | 22:31 |
dansmith | yeah | 22:31 |
mriedem | sure | 22:31 |
scottda | mriedem: That patch fixes the problem with not having cinderv3 in Nova's catalog ^^^^ | 22:31 |
dansmith | if one of you will skim that patch to see if there's anything majorly wrong with it, then I can send it to the ML on that thread for some wider view | 22:31 |
*** thorst has quit IRC | 22:31 | |
mriedem | omfg my eyes https://review.openstack.org/#/c/420201/1/nova/context.py | 22:32 |
mriedem | scottda: you could have thrown that in the other WIP couldn't you? | 22:32 |
mriedem | not sure how many DNM patches we are going to have here :) | 22:32 |
melwitt | dansmith: the main thing I noticed is I wouldn't want to imply the db and mq urls are required by putting them in the examples. operators really don't want to put secret creds on the command line | 22:33 |
dansmith | melwitt: it just seems clearer to me to do that | 22:33 |
*** smatzek has joined #openstack-nova | 22:34 | |
scottda | mriedem: Yeah, I'm going to abandon the first...was too messy to keep and change all the logic. | 22:34 |
mriedem | you can make a note that it's for illustration but simple_cell_setup will read the transport url and database connection url from nova.conf | 22:34 |
melwitt | I've been noticing feedback about it and think it will make people think they have to put them on the command line | 22:34 |
dansmith | melwitt: because if you don't, then you don't see the magic that $db_cell0 is used, etc | 22:34 |
dansmith | melwitt: then it's just three commands you run, but you don't know what thing in the config file goes with what | 22:34 |
melwitt | okay. maybe we'll just note that it's not required in words in each section or something | 22:34 |
melwitt | because I think in real life, operators will not pass those things on the command line | 22:35 |
dansmith | melwitt: yeah, I can add something about that | 22:35 |
*** smatzek has quit IRC | 22:35 | |
melwitt | it's more about what --config they pass to nova-manage | 22:35 |
melwitt | that will determine where it gets the values from | 22:35 |
*** smatzek has joined #openstack-nova | 22:35 | |
dansmith | melwitt: the thing is, I think the current situation we have with doing everything from the config file is just really obscure | 22:35 |
openstackgerrit | Scott DAngelo proposed openstack/nova: WIP Do Not Merge https://review.openstack.org/420201 | 22:35 |
dansmith | melwitt: when writing that, I started without the args, and had to go look up how we figure out what the values would be | 22:36 |
melwitt | dansmith: it is. so I'm cool with just notes that they don't have to do that and probably shouldn't in a real scenario | 22:36 |
melwitt | that it will pull the values from the nova.conf passed to nova-manage --config <nova.conf> | 22:37 |
*** catintheroof has quit IRC | 22:38 | |
*** annegentle has quit IRC | 22:42 | |
melwitt | dansmith: overall looks reasonable to me | 22:42 |
mriedem | i don't consider those whitespaces as reasonable | 22:42 |
*** sree has joined #openstack-nova | 22:42 | |
melwitt | that's true. shame on you dansmith | 22:43 |
mriedem | gdi where is jay when i need him | 22:44 |
melwitt | in the air, right? I thought he mentioned he was traveling today | 22:44 |
dansmith | melwitt: I feel like operators that are sensitive about their creds are also not hand-typing them into a history-preserving bash shell, but.. regardless, I think the changes I just made will appease the concern | 22:44 |
mriedem | i think i figured it out | 22:44 |
melwitt | dansmith: what do you mean? i.e. what is the case you're talking about where they type them somewhere but don't put them in the nova-manage command? | 22:45 |
openstackgerrit | Dan Smith proposed openstack/nova: Add some cellsv2 setup docs https://review.openstack.org/420198 | 22:46 |
*** sree has quit IRC | 22:47 | |
dansmith | melwitt: not sure I grok that.. I'm just saying I think being afraid of creds on on the command line is being overly sensitive, given the lack of security we enforce on the very same systems you'd be running these on | 22:47 |
dansmith | melwitt: see what you think about that ^ | 22:47 |
*** slaweq has joined #openstack-nova | 22:49 | |
melwitt | dansmith: oh. I think at my last company they wouldn't put db/mq creds on the command line at all. but I have also gotten feedback from mwhahaha about the same issue recently. so I think there's enough reason to be really clear about it so people understand what their options are | 22:51 |
*** wasmum has joined #openstack-nova | 22:52 | |
dansmith | yeah, I totally get that people are worried about it, I just think it's silly :) | 22:52 |
melwitt | heh, okay | 22:52 |
mwhahaha | well it's information leakage | 22:52 |
mwhahaha | it's always been a bad idea and continues to be so | 22:52 |
mwhahaha | even though many newer apps have all their stuff via command line | 22:53 |
* mwhahaha is looking at you kubernetes | 22:53 | |
dansmith | it didn't used to be reasonable to use secure throw-away VMs as consoles for this kind of stuff | 22:53 |
dansmith | and since this should be stuff you run from an administrative console... | 22:53 |
dansmith | but regardless, | 22:53 |
dansmith | the visual correlation of which url goes with which thing is what I think is important for the examples | 22:54 |
mriedem | figleaf: can i not use env vars in a gabbit query string like this? | 22:54 |
mriedem | PUT: /resource_providers/$ENVIRON['RP_UUID']/aggregates | 22:54 |
mwhahaha | well it then ends up in scripts and other stuffs | 22:54 |
dansmith | much easier to map things in your head when you're trying to grok it | 22:54 |
figleaf | mriedem: yes, that's pretty much how you have to do it | 22:54 |
mwhahaha | anyway it's something we need to be conscious of especially if we want our apps to be consumed in the finance and government space | 22:55 |
mriedem | ok i was missing "content-type" | 22:55 |
mriedem | oops | 22:55 |
melwitt | dansmith: cool, thanks. I see you kept the trailing whitespace though, mriedem wouldn't approve | 22:55 |
mriedem | i was missing the content-type: application/json request header | 22:55 |
dansmith | melwitt: I fixed a few | 22:55 |
mwhahaha | whether or not it's silly is moot in the eyes of regulations and audits | 22:55 |
figleaf | mriedem: I go through about 20 oops a day with gabbi | 22:55 |
dansmith | melwitt: thought I got them all.. my editor's rst mode is working against me | 22:55 |
melwitt | that's all you're getting mriedem | 22:55 |
figleaf | the only way to learn! | 22:55 |
mriedem | figleaf: yeah, copy/paste is about the only way i make this work | 22:56 |
mriedem | but now i've got it | 22:56 |
mriedem | ok, RP ?resources= patch update coming | 22:56 |
mriedem | with a bunch more edge case testing | 22:56 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Expose a REST API for a specific list of RPs https://review.openstack.org/392569 | 22:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Add some cellsv2 setup docs https://review.openstack.org/420198 | 22:57 |
mriedem | OH F YEAH ^ | 22:57 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me - ry py35 functional with a clean slate https://review.openstack.org/419968 | 22:57 |
mriedem | bauzas: i addressed my concerns in https://review.openstack.org/392569 | 22:57 |
mriedem | and added a bunch more testing | 22:57 |
mriedem | plus more docs about min/max unit and step size consideratoins | 22:58 |
*** jpena|away is now known as jpena | 22:58 | |
mriedem | *considerations | 22:58 |
*** Swami has quit IRC | 22:58 | |
*** ducttape_ has joined #openstack-nova | 22:59 | |
mwhahaha | dansmith: it should noted that these command in the case of puppet may get logged which is why I asked for using the config and not cmd line params. we have things to hide secrets when they get put into the config files but not so much for command line executions | 23:00 |
dansmith | mwhahaha: I understand your plight | 23:00 |
*** pradk has quit IRC | 23:00 | |
mriedem | does it matter that we leak tokens in the logs all over the place? | 23:01 |
*** smatzek has quit IRC | 23:01 | |
dansmith | mwhahaha: hopefully you understand my point about illustrative examples with big fat caveats | 23:01 |
mriedem | and people post the logs to bug reports and kibana | 23:01 |
mwhahaha | we're not supposed to be leaking tokens anywhere | 23:01 |
mriedem | if your token expires fast enough it's not an issue | 23:01 |
mriedem | but... | 23:01 |
mwhahaha | but yea, i get it but passwords don't change like tokens :D | 23:01 |
melwitt | mriedem: yeah, it matters. we had some patches to redact tokens in the logs | 23:01 |
mriedem | i know, but it's whack a mole | 23:02 |
melwitt | yes. that's true | 23:02 |
mwhahaha | always is | 23:02 |
dansmith | these credentials are super easy for you to programmatically rotate too, if you're concerned about it | 23:02 |
mwhahaha | database passwords are worse because many times the permissions people are setting with the service users are wide open | 23:02 |
mwhahaha | well they should be, but i've done my fair share of db password rotations and it never goes well | 23:03 |
mwhahaha | cause someone ultimately uses it for something aren't supposed to and the world falls apart :D | 23:03 |
melwitt | that depends on your infra whether it's easy to rotate them, but yeah | 23:04 |
dansmith | well, I see we're far outside the realm of realism here | 23:04 |
dansmith | melwitt: have you got anything brewing for that create_cell patch? | 23:04 |
mriedem | sdague: alex_xu: i'm +2 on this now https://review.openstack.org/#/c/392569/ | 23:04 |
melwitt | it was not a picnic when the passwords got compromised and had to be changed, in my recollection | 23:05 |
*** tblakes has quit IRC | 23:05 | |
melwitt | dansmith: yeah, it's failing py35 test only and I'm trying to fix it | 23:05 |
dansmith | oh, | 23:05 |
dansmith | I see you already did | 23:05 |
mriedem | alright i'm heading out | 23:06 |
mriedem | will be back on this week i'm sure | 23:06 |
mriedem | *weekend | 23:06 |
melwitt | *sad trombone* | 23:06 |
mriedem | but getting that scheduler RPs query thing +2ed unblocks the scheduler using placement | 23:06 |
mriedem | so is a high priority to get that patch in | 23:06 |
melwitt | is that the one you mentioned to me this morning? | 23:07 |
mriedem | i don't think so? | 23:07 |
melwitt | okay. nvm then | 23:07 |
mriedem | if you're looking, https://review.openstack.org/#/c/398472/ and https://review.openstack.org/#/c/417962/ are +2 and need to get in | 23:07 |
melwitt | okay yeah it was the first one you mentioned | 23:08 |
mriedem | ok now i'm out - i'm told there is casserole at home dontchaknow | 23:08 |
*** mriedem has quit IRC | 23:09 | |
*** mdrabe has quit IRC | 23:10 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 23:11 |
slaweq | mriedem: hello, can You maybe have a look on https://review.openstack.org/#/c/420176/ ? thx in advance | 23:11 |
*** kaisers has quit IRC | 23:14 | |
*** yrabl|lunch has quit IRC | 23:15 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me - Try py35 functional with a clean slate https://review.openstack.org/419968 | 23:24 |
*** marst has joined #openstack-nova | 23:26 | |
*** salv-orl_ has quit IRC | 23:26 | |
*** jpena is now known as jpena|off | 23:27 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add hacking rule to avoid unnecessary space in method https://review.openstack.org/417582 | 23:27 |
openstackgerrit | melanie witt proposed openstack/nova: Add nova-manage cell_v2 create_cell command https://review.openstack.org/332713 | 23:28 |
*** edmondsw has quit IRC | 23:29 | |
*** jaosorior has quit IRC | 23:31 | |
*** thorst has joined #openstack-nova | 23:32 | |
*** edmondsw has joined #openstack-nova | 23:36 | |
*** thorst has quit IRC | 23:37 | |
*** edmondsw_ has joined #openstack-nova | 23:38 | |
*** edmonds__ has joined #openstack-nova | 23:40 | |
*** edmondsw has quit IRC | 23:41 | |
*** edmondsw_ has quit IRC | 23:43 | |
*** figleaf is now known as edleafe | 23:43 | |
*** baoli has quit IRC | 23:46 | |
*** tommylikehu has quit IRC | 23:46 | |
*** tommylikehu has joined #openstack-nova | 23:46 | |
*** edmonds__ has quit IRC | 23:47 | |
*** jwcroppe has quit IRC | 23:47 | |
dims | down to 1 test in py35 functional black list. yay! | 23:49 |
*** tbachman has quit IRC | 23:51 | |
*** mriedem has joined #openstack-nova | 23:52 | |
*** gouthamr has joined #openstack-nova | 23:53 | |
*** harlowja has quit IRC | 23:56 | |
*** tbachman has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!