Tuesday, 2017-01-24

*** thorst_ has joined #openstack-nova00:00
*** zz_dimtruck is now known as dimtruck00:00
*** edmondsw has quit IRC00:04
takashinbauzas: Could you review https://review.openstack.org/#/c/408955/ again and check my comments?00:04
bauzastakashin: hola00:04
*** hongbin has quit IRC00:04
bauzastakashin: sorry, it's 1:05am for me now00:05
bauzastakashin: I'm just about to visit my bed00:05
bauzastakashin: but I'll try to look at it by tomorrow in case my above change is not getting a new problme00:05
takashinbauzas: Thank you.00:05
bauzastakashin: FWIW, opening a tab to remember it00:06
bauzastakashin: but ping me later if you wish (I'm UTC+1)00:06
takashinbauzas: I will ping you later.00:07
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V PCI Passthrough  https://review.openstack.org/42061400:08
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Add unit tests for JSON-Schema' items behavior  https://review.openstack.org/41533300:12
takashinoomichi: Are you around?00:16
*** thorst_ has quit IRC00:17
*** thorst_ has joined #openstack-nova00:17
oomichitakashin: yep00:17
takashinoomichi: Could you review https://review.openstack.org/#/c/408964/ ?00:18
oomichimay I help00:18
oomichitakashin: ok, will review it soon00:18
takashinoomichi: Thank you.00:18
oomichitakashin: oh, huge one ;)00:19
oomichimaybe alex_xu also will help00:19
*** thorst_ has quit IRC00:22
takashinoomichi: I understand that.00:22
*** dimtruck is now known as zz_dimtruck00:28
*** rfolco has joined #openstack-nova00:29
amrithandreykurilin, I will try00:31
*** efried has quit IRC00:34
*** jdurgin has quit IRC00:37
*** jwcroppe has quit IRC00:41
*** thorst_ has joined #openstack-nova00:42
*** jwcroppe has joined #openstack-nova00:42
*** thorst_ has quit IRC00:44
*** breitz has joined #openstack-nova00:45
*** jwcroppe has quit IRC00:47
bauzasmriedem: dansmith: FWIW, I think we probably have a grenade issue for the scheduler upcall change http://logs.openstack.org/61/417961/19/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/b497772/logs/new/screen-n-sch.txt.gz?level=TRACE#_2017-01-24_00_30_31_47600:47
*** hoangcx has joined #openstack-nova00:47
*** efried has joined #openstack-nova00:47
bauzasI'm getting a MissingAuthPlugin exception from Keystone...00:47
*** tbachman has quit IRC00:48
*** zhurong has joined #openstack-nova00:48
*** claudiub has quit IRC00:49
*** jamesdenton has joined #openstack-nova00:49
*** jdurgin has joined #openstack-nova00:51
*** tbachman has joined #openstack-nova00:52
*** jamesden_ has joined #openstack-nova00:53
*** mingyu has joined #openstack-nova00:53
*** dtp has quit IRC00:53
*** jamesdenton has quit IRC00:54
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937900:56
*** browne has quit IRC00:56
dansmithmriedem: bauzas: melwitt: ^ all three patches are passing now, just updated to remove the WIP from the last one00:56
bauzasdansmith: I'll look at it tomorrow morning my time00:57
dansmithbauzas: kthx00:57
bauzasdansmith: in the meantime, it seems we don't provide the placement opts for grenade00:58
*** mingyu has quit IRC00:58
dansmithbauzas: yeah I saw above, have't looked yet tho00:58
bauzasdansmith: ie. http://logs.openstack.org/61/417961/19/check/gate-tempest-dsvm-cells-ubuntu-xenial/e99ce7c/logs/etc/nova/nova.conf.txt.gz has a placement section00:58
bauzasdansmith: vs. http://logs.openstack.org/61/417961/19/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/b497772/logs/etc/nova/nova.conf.txt.gz not having it00:58
*** phuongnh has joined #openstack-nova00:58
bauzasdansmith: so my WIP change is currently +1 for all the dsvm jobs but not for grenade00:58
bauzaspossibly because we miss https://github.com/openstack-dev/devstack/blob/master/lib/placement#L102 in grenade00:59
dansmithyeah01:00
bauzasso the problem is that we have not the above for the Newton cloud01:01
bauzaswhich means that it's not really working in grenade01:02
bauzasI mean, the placement job01:02
bauzaslooks terrible to me01:02
*** jamielennox is now known as jamielennox|away01:02
bauzasdansmith: I need direction here before going to bed01:04
bauzasdansmith: because tomorrow morning I won't be knowing what to do01:05
dansmithbauzas: if we have something we have to do in order to upgrade, that has to go into grenade01:05
*** a-pugachev has quit IRC01:05
bauzasdansmith: when we have a config option missed by the old version but needed by the new version, what to do ?01:05
dansmithbauzas: however, I think you could just make the grenade job do whatever we do in newton to enable placement, so that you don't make a grenade change01:05
bauzasjust adding it straight to grenade ?01:06
dansmithwhich config option?01:06
bauzasdansmith: I guess those two https://github.com/openstack-dev/devstack/blob/master/lib/placement#L102-L10301:06
dansmithit's possible to start placement in newton01:06
dansmithyou mean devstack/newton can't?01:06
bauzasmaybe, lemme look at the stable branch01:06
*** armax has quit IRC01:07
dansmithbauzas: if not, I think it's going to be kinda ugly.. starting that in grenade, because you'll have to alter the devstack config and because what we *want* is people to start placement in newton01:07
bauzasdansmith: mmm, weirdo https://github.com/openstack-dev/devstack/blob/stable/newton/lib/placement#L110-L11101:07
bauzasdansmith: just remembering how grenade works01:08
bauzasdansmith: so, we first use the devstack stable branch for running the cloud, then applying the master branch01:08
bauzasright?01:08
bauzasI'm not very expert of grenade unfortunatelty01:09
bauzasnevermind, seeing https://github.com/openstack-dev/grenade#basic-flow01:09
*** zz_dimtruck is now known as dimtruck01:10
bauzasokay, I'll try to investigate then01:10
dansmithyes, that's how it works01:11
bauzasdansmith: okay, thanks01:12
bauzasjust stopping today for me01:12
bauzasbye01:12
dansmitho/01:12
*** baoli has joined #openstack-nova01:15
*** jamielennox|away is now known as jamielennox01:17
*** kevinz has joined #openstack-nova01:20
*** baoli has quit IRC01:20
*** mlavalle has quit IRC01:23
*** mvk has quit IRC01:26
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Add unit tests for JSON-Schema' items behavior  https://review.openstack.org/41533301:27
*** markvoelker has joined #openstack-nova01:27
*** mtanino has quit IRC01:30
*** mtanino has joined #openstack-nova01:32
openstackgerritZhenyu Zheng proposed openstack/nova: Fix device taging after API microversion 2.37  https://review.openstack.org/42395201:33
*** sofie has joined #openstack-nova01:34
openstackgerritZhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail  https://review.openstack.org/41514201:37
*** armax has joined #openstack-nova01:38
*** rfolco has quit IRC01:45
*** Swami has quit IRC01:49
*** mingyu has joined #openstack-nova01:54
*** mingyu has quit IRC01:58
*** Sukhdev_ has quit IRC02:01
*** kaisers_ has joined #openstack-nova02:05
openstackgerritZhenyu Zheng proposed openstack/nova: Don't delete neutron port when attach failed  https://review.openstack.org/40356802:07
*** kaisers has quit IRC02:08
*** mingyu has joined #openstack-nova02:09
*** Apoorva has quit IRC02:10
*** edmondsw has joined #openstack-nova02:22
openstackgerritTakashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2)  https://review.openstack.org/40895502:33
*** diga has joined #openstack-nova02:33
*** mtanino has quit IRC02:40
*** yuntongjin has joined #openstack-nova02:40
*** jose-phillips has quit IRC02:44
*** harlowja has quit IRC02:44
*** tovin07_ has joined #openstack-nova02:44
*** thorst_ has joined #openstack-nova02:49
*** thorst_ has quit IRC02:49
*** edmondsw has quit IRC02:51
*** edmondsw has joined #openstack-nova02:52
*** edmondsw has quit IRC02:54
*** edmondsw has joined #openstack-nova02:54
*** tovin07 has quit IRC02:56
*** hongbin has joined #openstack-nova02:56
*** mriedem has quit IRC02:57
*** edmondsw has quit IRC02:59
openstackgerritgengchc2 proposed openstack/nova: Improved-the-judgment-of-the-service-status-in-memcache  https://review.openstack.org/42375403:05
*** tovin07 has joined #openstack-nova03:07
*** tbachman has quit IRC03:09
*** yamahata has quit IRC03:22
*** armax has quit IRC03:23
openstackgerritZhenyu Zheng proposed openstack/nova: Fix device taging after API microversion 2.37  https://review.openstack.org/42395203:24
*** thorst_ has joined #openstack-nova03:33
*** thorst_ has quit IRC03:34
*** jamesden_ has quit IRC03:34
*** zhurong has quit IRC03:40
*** jamesdenton has joined #openstack-nova03:45
*** sudipto has joined #openstack-nova03:46
*** sudipto_ has joined #openstack-nova03:46
openstackgerritTakashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2)  https://review.openstack.org/40896403:47
*** tbachman has joined #openstack-nova03:47
*** mdnadeem has joined #openstack-nova03:48
*** nicolasbock has quit IRC03:54
*** yuntongjin has quit IRC03:55
*** ociuhandu has quit IRC03:57
*** tbachman has quit IRC03:58
*** jerrygb_ has quit IRC04:02
*** jwcroppe has joined #openstack-nova04:02
*** jwcroppe has quit IRC04:02
*** jwcroppe has joined #openstack-nova04:02
*** jerrygb has joined #openstack-nova04:09
*** jerrygb has quit IRC04:10
*** Apoorva has joined #openstack-nova04:11
gmannKevin_Zheng:  few comments on tagging fix04:12
Kevin_ZhengI added those test files just for functional testing, do you have any suggestion? cos I found that only one create-req file could exist for one microversion04:13
gmannKevin_Zheng:  actually common req resp file should be fine as with 2.37 one04:14
gmannKevin_Zheng: all other version req etc should be ok with those till they do not add mandatory field ion req or resp04:14
*** tlian has quit IRC04:14
Kevin_ZhengI will have a closer check after lunch, thanks alot04:15
openstackgerritHuan Xie proposed openstack/nova: Fix live migrate with XenServer  https://review.openstack.org/42442804:15
gmann2.37 was added because it add networks filed as mandatory in req04:15
*** Apoorva_ has joined #openstack-nova04:16
gmannalex_xu: johnthetubaguy oomichi:  what do you think whether it will break users - https://review.openstack.org/42395204:17
gmannif someone using wrong tag pattern then yes otherwise no change on tag length etc04:17
*** Apoorva has quit IRC04:20
*** hongbin has quit IRC04:20
*** ociuhandu has joined #openstack-nova04:21
*** sree has joined #openstack-nova04:24
*** pbandark has joined #openstack-nova04:24
*** sdague has joined #openstack-nova04:28
*** ayogi has joined #openstack-nova04:29
*** jamesdenton has quit IRC04:30
*** jwcroppe has quit IRC04:31
*** udesale has joined #openstack-nova04:34
*** avolkov has quit IRC04:38
*** psachin has joined #openstack-nova04:39
*** diga has quit IRC04:43
*** sree has quit IRC04:54
*** sree has joined #openstack-nova04:56
*** dikonoor has joined #openstack-nova04:59
*** armax has joined #openstack-nova05:00
*** takashin has left #openstack-nova05:00
*** sneti_ has joined #openstack-nova05:01
*** nic has quit IRC05:05
*** adisky_ has joined #openstack-nova05:06
*** kevinz has quit IRC05:09
*** dikonoor has quit IRC05:09
*** diga has joined #openstack-nova05:10
*** jerrygb has joined #openstack-nova05:11
*** prateek has joined #openstack-nova05:11
*** yuntongjin has joined #openstack-nova05:16
*** jerrygb has quit IRC05:16
*** ssurana has joined #openstack-nova05:16
*** ssurana has quit IRC05:16
*** dimtruck is now known as zz_dimtruck05:16
*** sneti_ has quit IRC05:18
*** dikonoor has joined #openstack-nova05:19
*** tommylikehu1 has joined #openstack-nova05:20
*** tommylikehu has quit IRC05:20
*** tommylikehu1 is now known as tommylikehu05:20
*** sdague has quit IRC05:23
*** jwcroppe has joined #openstack-nova05:26
*** ratailor has joined #openstack-nova05:28
*** swamireddy has quit IRC05:30
*** vladikr has quit IRC05:34
*** thorst_ has joined #openstack-nova05:35
*** udesale has quit IRC05:36
*** udesale has joined #openstack-nova05:36
*** thorst_ has quit IRC05:40
*** sudipto_ has quit IRC05:47
*** sudipto has quit IRC05:49
*** guchihiro has joined #openstack-nova05:50
openstackgerritPushkar Umaranikar proposed openstack/nova: Remove unused columns from BuildRequest table in nova_api db  https://review.openstack.org/42225905:52
*** armax has quit IRC05:56
*** moshele has joined #openstack-nova06:04
openstackgerritPushkar Umaranikar proposed openstack/nova: Remove unused columns from BuildRequest table in nova_api db  https://review.openstack.org/42225906:07
openstackgerritgengchc2 proposed openstack/nova: Improved-the-judgment-of-the-service-status-in-memcache  https://review.openstack.org/42375406:07
*** kevinz has joined #openstack-nova06:11
*** lpetrut has joined #openstack-nova06:15
*** satyar has joined #openstack-nova06:16
Kevin_Zhenggmann: are you still around?06:19
gmannKevin_Zheng:  yea06:20
Kevin_Zhenggmann: hi06:20
Kevin_Zhenggmann: I understand what you are saying in the comment06:20
Kevin_Zhengwhat I want to do is to test adding tags for virt devices for version 2.3706:21
Kevin_Zhengbecause we did it wrong in version 237 before06:22
gmannKevin_Zheng:  yea, in 2.37 file it is fine06:23
gmannKevin_Zheng:  and you can add tests with higher version also by using the same 2.37 json file06:23
gmann2.40 json file is not needed i think06:24
Kevin_Zhenghmm, maybe I can create two servers in 2.37 json?06:24
*** jwcroppe has quit IRC06:24
gmannKevin_Zheng:  2 servers means ?06:24
Kevin_Zhengbecause in 237 we actually tested using "auto" for networks,06:24
Kevin_Zhengwe cannot add tag to network parameter06:24
Kevin_Zhengthats why I added another one06:25
Kevin_Zhengand it seems the test structure can only read file name with server-create-req.json06:25
gmannKevin_Zheng:  you can change that auto to what you want to tests - https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_samples/servers/server-create-req-v237.json.tpl06:25
gmannKevin_Zheng:  under 2.37, auto bits are being tested alone - https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_samples/servers/v2.37/server-create-req.json.tpl06:26
Kevin_Zhengyeah, I did that in the last patchset06:26
Kevin_Zhengno before the last06:27
gmannKevin_Zheng:  ok06:27
Kevin_Zhengbut the compuete node seems not supported tagging06:27
Kevin_Zhengcould you have a check and maybe show me how to fix it? because I tried alittle but failed so I tried this way06:27
*** sacharya_ has quit IRC06:28
*** armax has joined #openstack-nova06:28
gmannKevin_Zheng:  sure, ll look06:28
Kevin_Zhengpatchset 506:28
*** sridharg has joined #openstack-nova06:28
*** armax has quit IRC06:28
*** zzzeek has quit IRC06:29
*** ekuris_ has joined #openstack-nova06:29
*** harlowja has joined #openstack-nova06:34
openstackgerritMoshe Levi proposed openstack/nova: Remove mox in network/test_linux_net.py  https://review.openstack.org/31642706:34
*** mjura has joined #openstack-nova06:36
*** mnestratov has joined #openstack-nova06:36
openstackgerritWang Qing wu proposed openstack/nova: WIP(6): Introduce base PowerVM driver (ssp drv)  https://review.openstack.org/42259406:39
*** diga has quit IRC06:40
*** armax has joined #openstack-nova06:43
*** armax has quit IRC06:43
satyarHi jaypipes06:43
satyarjaypipes around06:44
gmannKevin_Zheng: that is strange for me, functional tests runs with fake driver06:46
* gmann checking..06:46
*** armax has joined #openstack-nova06:47
*** bkopilov has quit IRC06:47
*** armax has quit IRC06:48
Kevin_Zhenggmann: yeah, Thanks06:51
*** claudiub has joined #openstack-nova06:51
alex_xuKevin_Zheng: just checked https://review.openstack.org/#/c/415330/17, that is what I expected.06:52
satyarKevin_Zheng is the nova_api_cell0 changed to nova_cell0 now?06:53
Kevin_Zhengalex_xu: thanks, then lets work on the tests06:53
*** udesale__ has joined #openstack-nova06:53
alex_xuKevin_Zheng: thanks for working on it06:53
Kevin_Zhengsatyar: sorry I think you asked the wrong person06:53
satyar:P sorry06:53
satyaralex_xu06:54
*** claudiub|2 has joined #openstack-nova06:54
satyari saw some changes from Dan Smith06:54
satyarnot sure whats the handler here06:54
alex_xusatyar: dansmith is right person to answer that, but I saw this patch https://review.openstack.org/#/c/420437/06:55
*** udesale has quit IRC06:56
*** lpetrut has quit IRC06:56
satyarThanks alex_xu06:57
*** claudiub has quit IRC06:57
alex_xusatyar: np06:57
*** nkrinner_afk is now known as nkrinner06:59
satyarHi dansmith06:59
*** jerrygb has joined #openstack-nova07:00
openstackgerritBéla Vancsics proposed openstack/nova: Reduce code duplication  https://review.openstack.org/34218707:00
*** swamireddy has joined #openstack-nova07:00
*** udesale has joined #openstack-nova07:01
*** udesale__ has quit IRC07:03
*** udesale has quit IRC07:04
*** avolkov has joined #openstack-nova07:04
*** jerrygb has quit IRC07:06
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533007:08
*** andreas_s has joined #openstack-nova07:12
*** udesale has joined #openstack-nova07:12
moshelealex_xu: hi can you review https://review.openstack.org/#/c/423608/ ?07:13
*** oanson has quit IRC07:16
*** lpetrut has joined #openstack-nova07:16
*** oanson has joined #openstack-nova07:17
*** adisky_ has quit IRC07:19
*** markus_z has joined #openstack-nova07:19
*** Oku_OS-away is now known as Oku_OS07:20
*** sridharg has quit IRC07:21
*** sridharg has joined #openstack-nova07:21
*** Apoorva_ has quit IRC07:23
*** harlowja has quit IRC07:26
*** sacharya has joined #openstack-nova07:28
*** sacharya has quit IRC07:33
*** mvk has joined #openstack-nova07:35
*** thorst_ has joined #openstack-nova07:36
*** baoli has joined #openstack-nova07:36
*** tesseract has joined #openstack-nova07:37
*** avolkov has quit IRC07:38
*** Sukhdev has joined #openstack-nova07:38
*** mvk has quit IRC07:40
*** baoli has quit IRC07:40
*** thorst_ has quit IRC07:40
*** yuntongjin has quit IRC07:45
alex_xumoshele: just add it to my list07:46
moshelealex_xu: thanks :)07:46
*** ralonsoh has joined #openstack-nova07:47
alex_xumoshele: np07:47
*** mvk has joined #openstack-nova07:50
*** lpetrut has quit IRC07:50
*** ijw has quit IRC07:55
*** udesale__ has joined #openstack-nova07:55
*** udesale has quit IRC07:58
*** sacharya has joined #openstack-nova07:59
*** guchihiro has quit IRC08:00
*** openstackgerrit has quit IRC08:03
*** gszasz has joined #openstack-nova08:04
*** sacharya has quit IRC08:04
*** lpetrut has joined #openstack-nova08:06
*** praveen has joined #openstack-nova08:17
*** jpena|off is now known as jpena08:22
*** amotoki has quit IRC08:24
*** gszasz has quit IRC08:25
alex_xugmann: just prepare to send a mail about the device tag08:26
gmannalex_xu:  nice, thanks.08:28
gmannalex_xu: looks like some issue in functional tests also. debugging that08:29
*** udesale__ has quit IRC08:30
*** udesale has joined #openstack-nova08:30
alex_xugmann: let us put all the info in the mail and discuss at here08:31
alex_xus/here/there/08:31
*** Sukhdev has quit IRC08:31
*** slaweq has quit IRC08:31
gmannalex_xu: +108:32
*** amotoki has joined #openstack-nova08:33
*** slaweq has joined #openstack-nova08:33
*** jpena is now known as jpena|off08:33
*** jpena|off is now known as jpena08:40
*** mfeoktistov has joined #openstack-nova08:44
*** pcaruana has joined #openstack-nova08:45
*** kashyap has quit IRC08:47
*** openstackgerrit has joined #openstack-nova08:51
*** amotoki has quit IRC08:53
snikitinalex_xu: Hi, Alex! I changed a file name in diagnostics patch and lost your +2 :( Can you look again please? Also I left a comment about your proposal for docs https://review.openstack.org/#/c/355540/08:54
alex_xusnikitin: ok, I will check that08:55
snikitinthanks!08:55
*** lpetrut has quit IRC08:56
*** zzzeek has joined #openstack-nova09:00
*** jerrygb has joined #openstack-nova09:02
*** a-pugachev has joined #openstack-nova09:03
*** karimb has joined #openstack-nova09:07
*** bkopilov has joined #openstack-nova09:08
*** jerrygb has quit IRC09:08
openstackgerritIldiko Vancsa proposed openstack/nova: Implement new attach/detach Cinder flow  https://review.openstack.org/33028509:13
*** efoley has joined #openstack-nova09:13
openstackgerritIldiko Vancsa proposed openstack/nova: Implement new attach/detach Cinder flow  https://review.openstack.org/33028509:14
openstackgerritIldiko Vancsa proposed openstack/nova: Remove check_attach  https://review.openstack.org/33535809:14
*** efoley_ has joined #openstack-nova09:17
*** efoley has quit IRC09:21
*** ijw has joined #openstack-nova09:23
*** owalsh-afk is now known as owalsh09:23
*** derekh has joined #openstack-nova09:25
*** ijw has quit IRC09:27
*** ekuris_ has quit IRC09:28
*** thorst_ has joined #openstack-nova09:30
moshelesfinucan: hi can you review this https://review.openstack.org/#/c/423608/09:31
sfinucanmoshele: Sure09:31
*** lucas-afk is now known as lucasagomes09:31
openstackgerritHironori Shiina proposed openstack/nova: Ironic: Add soft power off support to Ironic driver.  https://review.openstack.org/40797709:32
*** yassine has joined #openstack-nova09:34
*** yassine is now known as Guest8671809:34
*** thorst_ has quit IRC09:35
*** efoley__ has joined #openstack-nova09:39
*** karimb has quit IRC09:40
*** karimb has joined #openstack-nova09:41
*** mvk has quit IRC09:41
*** karimb has quit IRC09:42
sfinucanmoshele: Done09:42
*** efoley_ has quit IRC09:43
*** mingyu has quit IRC09:43
*** kevinz has quit IRC09:44
*** mingyu has joined #openstack-nova09:45
moshelesfinucan: thanks09:45
sfinucanbauzas: Could you take a look at https://review.openstack.org/#/c/419479 when you have a moment?09:47
bauzassfinucan: currently under the water because of the scheduler upcall, but I'll try09:47
*** sambetts|afk is now known as sambetts09:47
sfinucanbauzas: No panic at all. Priorities :)09:47
*** mingyu has quit IRC09:48
*** mingyu_ has joined #openstack-nova09:48
bauzassfinucan: I'm just investigating a grenade issue, hopefully to sort it out soonish09:50
*** avolkov has joined #openstack-nova09:51
*** mingyu_ has quit IRC09:52
*** kashyap has joined #openstack-nova09:52
*** ekuris_ has joined #openstack-nova09:54
*** karimb has joined #openstack-nova09:56
*** amotoki has joined #openstack-nova09:57
*** mdnadeem has quit IRC09:58
johnthetubaguybauzas: I have added a few ideas on that call placement from scheduler thing: https://review.openstack.org/#/c/41796109:58
johnthetubaguybauzas: FWIW, the caching scheduler looks correct to me09:59
bauzasjohnthetubaguy: lemme look at10:00
*** efoley_ has joined #openstack-nova10:01
*** efoley__ has quit IRC10:04
*** tovin07_ has quit IRC10:04
*** satyar has quit IRC10:06
*** hoangcx has quit IRC10:06
johnthetubaguymdbooth: was reading your comment on here: https://review.openstack.org/#/c/40800210:09
johnthetubaguymdbooth: very, very valid10:09
bauzasjohnthetubaguy: got a few mins for discussing about https://review.openstack.org/#/c/417961 ?10:09
johnthetubaguymdbooth: I thought of a slight alternative, we could update the config option docs to very clearly state there are 10 steps10:09
mdboothjohnthetubaguy: I wonder if anybody has ever tuned this, tbh.10:10
johnthetubaguymdbooth: most people just tune the 500 total timeout, AFAIK10:10
johnthetubaguymdbooth: kill it all might be a better solution (i.e. just hard code it)10:11
johnthetubaguybauzas: sure thing10:11
bauzasjohnthetubaguy: so, AFAICU we're discussing on how to have a right interface10:11
mdboothWe could add a new config variable which is a total, and immediately deprecate the old 2. The new value will default to the product of the deprecated values if not set explicitly. We hardcode 10 steps.10:12
bauzasjohnthetubaguy: so, you'd prefer to have https://review.openstack.org/#/c/417961/19/nova/scheduler/host_manager.py@635 in the scheduler report client ?10:13
mdboothjohnthetubaguy: If this is up against the wire I can probably write that today myself, btw. Is this on anybody's radar?10:14
johnthetubaguymdbooth: we already have the total as a config setting I think, thats the delay between steps, not the size of the steps10:14
johnthetubaguymdbooth: pkoniszewski is usually responsive if he is around10:14
mdboothI don't think there's a total time, it's calculated.10:14
*** mdnadeem has joined #openstack-nova10:15
pkoniszewskiI'm around10:15
pkoniszewskiyeah, I also agree with mdbooth comment, very good point10:15
johnthetubaguybauzas: I think I would like to see the scheduler directly call the placement client, then pass the return value into the host_state to get back the list of objects10:15
johnthetubaguybauzas: it could go into the scheduler or the placement client I think10:15
johnthetubaguymdbooth: I think live_migration_downtime is the config I mean10:16
bauzasjohnthetubaguy: you mean the scheduler driver, not the host manager ?10:16
bauzasjohnthetubaguy: so we could just drill down a list of hosts to the host manager?10:16
johnthetubaguymdbooth: there is the total timeout, and the time to reach the total timeout in the steps10:16
*** mvk has joined #openstack-nova10:16
bauzasjohnthetubaguy: I need to consider that if so10:16
johnthetubaguymdbooth: given we also define a time after which the live-migrate is considered failed and we give up, we could use that to define the steps10:16
bauzasjohnthetubaguy: I actually made that split because of the CachingScheduler, but lemme think about that loud10:17
pkoniszewskijohnthetubaguy: live migration timeout can be set to 0 to disable it10:17
johnthetubaguybauzas: I think we would pass resource providers into the host manager10:17
pkoniszewskijohnthetubaguy: however, nova still needs to increase downtime over time10:17
bauzasjohnthetubaguy: I'm not sure I like that10:17
johnthetubaguybauzas: it shouldn't affect the caching scheduler10:17
bauzasjohnthetubaguy: I would pass hosts, not RPs to the Hostmanager10:17
gmannalex_xu:  seems like we just broke the validation part, feature still should work10:17
johnthetubaguypkoniszewski: yeah, we would need a default if that timeout is zero10:17
pkoniszewskiwe would need some kind of a magic number10:17
bauzasjohnthetubaguy: I mean, lemme clarify10:18
bauzasjohnthetubaguy: I think having the filter scheduler directly calling the reportclient to get the list of RPs is a good idea10:18
alex_xugmann: is there still a way to set tag to the bdm or network device?10:18
johnthetubaguypkoniszewski: it could be some multiple of the 500 seconds setting, if overall timeout is 010:18
bauzasjohnthetubaguy: what I'm saying is that the translation from RP to compute nodes should still be filter scheduler thing10:18
johnthetubaguybauzas: agreed10:18
johnthetubaguybauzas: I think the filter scheduler method stays the same, its just whats in there that changes10:19
bauzasjohnthetubaguy: from an interface PoV, that's actually an excellent point10:19
bauzasI mean, the filter scheduler returns compute nodes10:19
bauzasthe host manager returns host states10:19
johnthetubaguybauzas: I kinda like passing the spec_obj into the placement client10:19
bauzasthat, I'm not sure10:19
johnthetubaguyah, OK, you want that to be resource providers?10:20
johnthetubaguythats fair enough10:20
bauzasjohnthetubaguy: because I'd like to see the "spec to RC usage" logic be still a scheduler thing10:20
bauzasthe placement client shouldn't expect anything about how the scheduler works10:20
mdboothjohnthetubaguy pkoniszewski: Sorry, even though I only read it yesterday, I still had to refresh it :)10:21
gmannalex_xu: for bdm yes as there is no additionalProperties=False there but yes for network it is not allowed as additionalProperties=False :(10:21
bauzasjohnthetubaguy: in particular given I'm now very opiniated on having the resource query being optional depending on the filters10:21
gmannalex_xu: i am modifying tempest device tag tests with all combination and with all version mentioned by you10:21
mdboothSo there's live_migration_downtime, which is the maximum permitted downtime of an instance during live migration10:21
gmannalex_xu: let's see how bdm tag behave on those10:21
bauzasjohnthetubaguy: the last 3 days convinced me we need to opt-in the filters10:21
*** udesale has quit IRC10:21
johnthetubaguymdbooth: totally with you on need to refresh, I guess thats the problem the operators are having too10:22
*** kashyap has quit IRC10:22
mdboothThen there live_migration_downtime_steps, which is the number of steps to take towards that maximum, and live_migration_downtime_delay, which is the delay between each step.10:22
bauzasjohnthetubaguy: either way, thanks for reviewing, that's very good insight, and I can do a new iteration this morning10:22
bauzasjohnthetubaguy: FWIW, I'm stuck with grenade not liking the placement service in newton10:22
johnthetubaguybauzas: I was thinking it would ideally be an object we pass into the placement client (that could be empty)10:22
mdboothSo the total time until we go with the maximum is live_migration_downtime_steps * live_migration_downtime_delay10:22
mdboothpkoniszewski: Am I reading that right? ^^^10:22
johnthetubaguybauzas: ah yeah, that... :(10:22
alex_xugmann: initial I also think there is no addtionalProperties, but I found it copy that from bdm v1 schema https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/block_device_mapping.py#L6110:22
pkoniszewskijohnthetubaguy: but im still considering a new config option, i see a case where operator might want to get to target downtime in a couple of seconds but still such live migration might need 10+ minutes to complete10:23
bauzasjohnthetubaguy: for the moment, I was seeing a dict10:23
pkoniszewskimdbooth: right, that's the current state10:23
bauzasjohnthetubaguy: but longer term, why not an object, agreed10:23
johnthetubaguybauzas: honestly, a TODO in there saying this argument sucks might be all I need on that bit, lol10:23
bauzasI'm just thinking it shouldn't be the Spec object10:23
*** adisky_ has joined #openstack-nova10:23
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type  https://review.openstack.org/42425610:24
johnthetubaguybauzas: yeah, thats cool, I just re-read that file, it has to be resource providers10:24
bauzasyup zactly10:24
gmannalex_xu: ahh, yea, thanks for pointing that10:24
bauzasand the scheduler has some internal logic for translating the Spec object into a ResourceProviderQuery object10:24
mdboothpkoniszewski: My idea just was to add a new option which is the total time, hardcode the number of steps to 10 as you've done, and default the total to the product of the set deprecated values (if they're set).10:24
bauzaswhatever the object is10:24
johnthetubaguybauzas: so maybe if you pass the return value of placement into host_manger get, even if thats just the list of uuids, that would be better10:24
alex_xugmann: np, I drop in that trap also :)10:24
johnthetubaguybauzas: yeah, that sounds good10:25
johnthetubaguybauzas: right now its a dict, but thats OK for now I guess10:25
bauzasjohnthetubaguy: I can forge a patch soon10:25
mdboothpkoniszewski: Incidentally, I also wonderered about setting guest.migrate_configure_max_downtime() on every iteration, regardless of steps.10:25
mdboothWould that be expensive?10:25
bauzasjohnthetubaguy: and I'll wait for sean about how to discuss the grenade thing10:25
bauzasbecause the issue I guess is that we don't default running the placement service in newton10:25
johnthetubaguybauzas: cool, hopefully that helps, just didn't quite read as I expected10:26
gmannalex_xu:  heh10:26
bauzasso, when upgrading, it fails because the config file is not correctly setup10:26
bauzasthat would suppose we would modify the config between newton and ocata, but that's pretty high impacty10:26
johnthetubaguybauzas: honestly, we might just need to support not having placement while the min_service_version is below a threshold, and only start using it after that point?10:27
*** sileht has quit IRC10:27
*** haplo37 has quit IRC10:27
bauzasjohnthetubaguy: that's why I'm waiting the US folks to be up before engaging that convo10:27
bauzas:)10:27
*** sileht has joined #openstack-nova10:27
*** kashyap has joined #openstack-nova10:27
bauzaslots of discussions went already around about the upgrade path10:27
johnthetubaguymdbooth: we still need something that sets QEMU occasionally on some periodic task, but thats a good point, you can just work out where you should be on the line, and set that value10:27
johnthetubaguybauzas: yeah10:28
johnthetubaguybauzas: just curious why we don't do it the usual way, but thats for later10:28
bauzasjohnthetubaguy: meaning be gentle with not having the placement service for newton ?10:28
bauzasand gracefully fallback if we don't have the version supported ?10:28
bauzasthat's one option but the consensus was that it was okay to have a maintenance window10:29
johnthetubaguybauzas: well its not really a maintenance window right, its just if you want no outage, you have to do more work10:29
openstackgerritRadomir Dopieralski proposed openstack/python-novaclient: ListExtResource given in place of ListExtManager  https://review.openstack.org/42457010:33
*** efoley__ has joined #openstack-nova10:33
*** derekh has quit IRC10:35
*** haplo37 has joined #openstack-nova10:36
*** efoley_ has quit IRC10:37
*** phuongnh has quit IRC10:37
bauzasjohnthetubaguy: tried to summarize our convo in https://review.openstack.org/#/c/417961/19/nova/scheduler/client/report.py@212, just drop a note if you think I misunderstood our agreement10:38
bauzasmeanwhile, writing a new iteration10:38
gmannalex_xu: johnthetubaguy  oomichi additionalProperties=False saved us many times but this we only got under its hammer :)10:38
gmann*this time10:38
johnthetubaguybauzas: we would pass resource providers uuids into the host manager I guess?10:41
openstackgerritHuan Xie proposed openstack/nova: Fix live migrate with XenServer  https://review.openstack.org/42442810:41
bauzasjohnthetubaguy: I'm not opiniated on that10:42
bauzasjohnthetubaguy: that's fine to me10:42
bauzasbecause a RP uuid is the compute uuid10:42
johnthetubaguybauzas: me neither, that just seems simplest at the moment10:42
bauzasso I'd name it compute_uuids10:42
bauzasjust to make it clear that I'd never name something related to resource providers into the host manager10:43
bauzasthe hostmanager only knows hosts and returns host states10:43
bauzashence why I think you made an excellent and valid comment10:43
bauzasbecause my current proposal sucked10:43
johnthetubaguybauzas: it wasn't that bad, but yeah, that sounds worth a try10:44
bauzasjohnthetubaguy: it was poorly designed, if you prefer10:44
*** rfolco has joined #openstack-nova10:44
johnthetubaguya class was operating on multiple levels of abstractions, causing some confusion, or something like that10:44
bauzasthe exact reason why I haven't yet written UTs :)10:45
bauzasbecause I needed kind of an agreement on the interfaces before moving on10:45
openstackgerritBalazs Gibizer proposed openstack/nova: Fix race condition in instance.update sample test  https://review.openstack.org/42457410:46
BobBalljohnthetubaguy: https://bugs.launchpad.net/nova/+bug/1658877 - found a bug which prevents all XAPI live migrations and we'd really appreciate your input on it.10:47
openstackLaunchpad bug 1658877 in OpenStack Compute (nova) "live migration failed with XenServer as hypervisor" [Undecided,In progress] - Assigned to huan (huan-xie)10:47
johnthetubaguyBobBall: I think I saw that patch pass by, will take a peak10:48
BobBallAwesome, thanks.10:48
johnthetubaguyBobBall: why did it work before without the vif mappings there?10:49
openstackgerritMatthew Booth proposed openstack/nova: libvirt: Fix races in glusterfs mount/umount  https://review.openstack.org/42340210:50
BobBalljohnthetubaguy: The addition of the interim network to fix the neutron vlan tagging on vif/tap bug (and also to support neutron security groups) introduces a per-VIF network.  The per-VIF network doesn't exist (by name) on the destination and therefore XAPI can no longer make a good guess for what the vif mapping should be.10:51
johnthetubaguyBobBall: that would totally do it10:51
BobBalljohnthetubaguy: Indeed :(10:52
johnthetubaguyBobBall: this isn't backportable, because of the object version stuff10:53
johnthetubaguyas a heads up10:53
BobBallUnderstood.  I am trying to also understand whether we actually need to pass the mapping back; if we create a network with the same name on the target wouldn't XAPI just do the right thing(tm)?10:54
*** ekuris_ has quit IRC10:54
BobBallAnyway - I'll put review comments in the code.  Just wanted to highlight it for you as a heads up.10:54
*** derekh has joined #openstack-nova10:56
*** yonglihe has quit IRC10:57
johnthetubaguyBobBall: why is the vif thing only used for VM.migrate_send?10:57
johnthetubaguyBobBall: is it not accepted by the other call?10:57
BobBalljohnthetubaguy: Not needed for sure - it would probably be ignored if it was present.10:58
BobBalljohnthetubaguy: Good comment though, we can check the API to be sure.10:58
openstackgerritGábor Antal proposed openstack/nova: Transform instance.trigger_crash_dump notification  https://review.openstack.org/39622511:01
*** jerrygb has joined #openstack-nova11:04
*** tbachman has joined #openstack-nova11:04
openstackgerritGábor Antal proposed openstack/nova: Transform instance.trigger_crash_dump notification  https://review.openstack.org/39622511:05
*** efoley_ has joined #openstack-nova11:05
*** amotoki has quit IRC11:07
*** ekuris_ has joined #openstack-nova11:07
dimssean-k-mooney : around?11:07
dimssean-k-mooney : https://review.openstack.org/#/c/423718/ is ready. got the linuxbridge thing working11:07
*** efoley__ has quit IRC11:08
*** jerrygb has quit IRC11:09
*** hfu has joined #openstack-nova11:10
*** aloga has quit IRC11:17
*** edmondsw has joined #openstack-nova11:20
openstackgerritSylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API  https://review.openstack.org/41796111:20
bauzasjohnthetubaguy: new iteration, comments welcome $11:20
* bauzas goes afk for lunch11:21
*** mnestratov has quit IRC11:22
*** dikonoo has joined #openstack-nova11:22
*** mnestratov has joined #openstack-nova11:22
*** prateek has quit IRC11:22
*** prateek has joined #openstack-nova11:23
*** ekuris_ has quit IRC11:24
*** edmondsw has quit IRC11:24
*** dikonoor has quit IRC11:26
*** ratailor has quit IRC11:27
*** sree has quit IRC11:28
*** tbachman has quit IRC11:28
*** amotoki has joined #openstack-nova11:30
*** thorst_ has joined #openstack-nova11:31
*** thorst_ has quit IRC11:36
*** ekuris_ has joined #openstack-nova11:37
mdboothpkoniszewski: Hey, I'm just looking at https://review.openstack.org/#/c/244489/11:37
*** tbachman has joined #openstack-nova11:37
mdboothInevitably looking at live migration flow11:38
mdboothSo, source does a call to destination.check_can_live_migrate_destination(), which itself does a call back to source.check_can_live_migrate_source(), and then the destination returns the result of the call to the source back to the source over rpc11:39
mdboothSo we're calling check_can_live_migrate_source() on the source, sending the results to the destanation, which then sends them back to the source11:39
mdboothThat seems a little inefficient :)11:40
mdboothAnyway, that's a problem for another day11:40
mdboothMore immediately, I think there might be a deadlock if there's an exception in _do_check_can_live_migrate_destination, but I'd very much like a second opinion11:41
mdboothAlthough... I think I may just have provided my own :)11:42
* mdbooth thinks again11:42
pkoniszewskimdbooth: its not source that calls check_can_live_migrate_destination11:42
pkoniszewskibut conductor11:42
mdboothAh, es11:42
mdboothOk11:42
*** tbachman has quit IRC11:42
* mdbooth still doesn't understand why we use conductor here11:43
mdboothIt just seems like an additional source of potential failure11:43
*** owalsh is now known as owalsh-brb11:43
*** nicolasbock has joined #openstack-nova11:44
mdboothRe the deadlock, I was thinking that the lock held by live_migration_claim would be held for the duration of the claim context, but of course it's only held whilst generating the claim11:45
mdboothThere's no deadlock11:45
*** smatzek_ has joined #openstack-nova11:45
*** owalsh-brb has quit IRC11:48
*** owalsh-brb has joined #openstack-nova11:50
*** owalsh-brb is now known as owalsh11:53
*** aloga has joined #openstack-nova11:54
*** udesale has joined #openstack-nova11:55
*** rmart04 has joined #openstack-nova11:57
johnthetubaguymdbooth: its only partially implemented, compute <-> compute RPC traffic shouldn't be allowed, from a security point of view, so ideally you have the conductor own the task, and send messages to the two compute nodes as required, and monitor progress. But naturally we don't have any of that, just the bad bits12:01
*** dikonoo has quit IRC12:03
*** hoangcx has joined #openstack-nova12:08
*** hoangcx has quit IRC12:09
*** hoangcx has joined #openstack-nova12:11
*** sahid has joined #openstack-nova12:12
*** sahid has quit IRC12:12
*** sahid has joined #openstack-nova12:13
*** gouthamr has joined #openstack-nova12:13
openstackgerritGábor Antal proposed openstack/nova: Transform instance.reboot notifications  https://review.openstack.org/38295912:16
*** catintheroof has joined #openstack-nova12:16
openstackgerritOpenStack Proposal Bot proposed openstack/os-vif: Updated from global requirements  https://review.openstack.org/39534712:18
*** lucasagomes is now known as lucas-hungry12:19
*** bvanhav has joined #openstack-nova12:20
openstackgerritGábor Antal proposed openstack/nova: Transform instance.reboot notifications  https://review.openstack.org/38295912:21
*** hoangcx has quit IRC12:25
*** ducttape_ has joined #openstack-nova12:27
*** aojea has quit IRC12:28
*** hfu has quit IRC12:30
*** hfu has joined #openstack-nova12:30
*** hfu has quit IRC12:31
*** aojea has joined #openstack-nova12:31
*** hfu has joined #openstack-nova12:31
*** hfu has quit IRC12:31
*** hfu has joined #openstack-nova12:32
*** hfu has quit IRC12:32
*** gszasz has joined #openstack-nova12:33
*** udesale has quit IRC12:37
*** hoangcx has joined #openstack-nova12:37
*** lpetrut has joined #openstack-nova12:37
*** edmondsw has joined #openstack-nova12:41
openstackgerritMoshe Levi proposed openstack/nova: Assign mac address to vf netdevice when using macvtap port  https://review.openstack.org/42463912:41
*** edmondsw has quit IRC12:45
*** thorst_ has joined #openstack-nova12:47
*** hoangcx has quit IRC12:48
openstackgerritAlex Xu proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533012:50
*** stvnoyes has quit IRC12:50
*** sahid has quit IRC12:50
openstackgerritNeil Jerram proposed openstack/nova: libvirt: avoid generating script with empty path  https://review.openstack.org/41193612:51
*** sahid has joined #openstack-nova12:51
openstackgerritAlex Xu proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533012:51
alex_xujohnthetubaguy: gmann ^ just done the policy one12:51
*** krtaylor has quit IRC12:51
openstackgerritAlex Xu proposed openstack/nova: Add sort_key white list for server list/detail  https://review.openstack.org/41514212:53
*** mingyu has joined #openstack-nova12:53
*** hoangcx has joined #openstack-nova12:54
*** bkopilov has quit IRC12:55
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type  https://review.openstack.org/42425612:57
openstackgerritStephen Finucane proposed openstack/nova: conf: Deprecate two more nova-net options  https://review.openstack.org/41239012:57
openstackgerritStephen Finucane proposed openstack/nova: WIP: libvirt: Always enable firewall  https://review.openstack.org/42464712:57
*** mingyu has quit IRC12:58
*** hoangcx has quit IRC12:58
andreykurilinhi folks! there are several blocked projects(horizon, trove, cinder?!, murano-dashboard...) due to bug with token auth method. Here is a fix https://review.openstack.org/#/c/419441 . Functional tests are also attached there.12:59
andreykurilinPlease review as soon as possible12:59
andreykurilinalex_xu johnthetubaguy sdague ^12:59
*** mtanino has joined #openstack-nova13:00
*** owalsh is now known as owalsh-lunch13:00
macszdanpb ping13:00
andreykurilinAlso, I found that token auth method via CLI was broken for a long time(for several novaclient's releases). Fix is the next patch in the chain13:00
*** baoli has joined #openstack-nova13:01
openstackgerritStephen Finucane proposed openstack/nova: console: Move proxies to 'console/proxy'  https://review.openstack.org/40819213:01
openstackgerritStephen Finucane proposed openstack/nova: conf: Deprecate 'console_driver'  https://review.openstack.org/40819313:01
kashyapmacsz: He's not on the channel13:01
*** baoli has quit IRC13:01
andreykurilinamrith: several folks verified that fix to novaclient helped with horizon (it uses token auth too). It should help in your case too. let's merge it, make new novaclient's release and recheck trove's code13:01
macszkashyap do you know where can i find him?13:02
kashyapmacsz: Maybe email him or, if it's a public Nova issue, write to upstream openstack-dev list, and CC him13:02
johnthetubaguyandreykurilin: I am running to lunch, but do we know which patch caused the problem?13:02
macszkashyap: thanks13:02
*** baoli has joined #openstack-nova13:02
*** liverpooler has joined #openstack-nova13:02
andreykurilin johnthetubaguy: bon appetit!13:02
sfinucanjohnthetubaguy: An easy, post-merge conflict +2/+W for you (for after lunch :)) https://review.openstack.org/40819313:03
andreykurilinjohnthetubaguy: for python-api - my patch which removes custome implementation of HTTPClient made it. there were a bunch of patches with + from keystone cores, but we missed to transmit several variables to keystone Token class13:03
openstackgerritSteven Webster proposed openstack/nova: Release PCI devices on drop_move_claim()  https://review.openstack.org/37037413:04
*** krtaylor has joined #openstack-nova13:04
*** sree has joined #openstack-nova13:04
*** lpetrut has quit IRC13:04
andreykurilinjohnthetubaguy: as for CLI, imo, https://github.com/openstack/python-novaclient/commit/1f11840dd84f3570330d1fcd53d1e8eea5ff7922 broke it. more than a year ago..13:04
*** takashin has joined #openstack-nova13:05
*** cdent has joined #openstack-nova13:05
takashinbauzas: Are you around?13:05
*** jerrygb has joined #openstack-nova13:05
*** stvnoyes has joined #openstack-nova13:05
mdboothDo we currently recalculate numa topology on live migration?13:06
andreykurilinjohnthetubaguy: in case of python-API: previously, Token auth method worked only via our custom HTTPClient implementation. It means that only Keystone V2 was supported. Switch to SessionClient for 100% cases was done here - https://review.openstack.org/#/c/304035/13:07
sfinucanmdbooth: Narp13:08
sfinucanmdbooth: Isn't that the patch you were reviewing last night?13:08
mdboothsfinucan: Ok, cool.13:08
mdboothsfinucan: I'm reviewing it now, but I was wondering if it clashed with anything :)13:08
*** sree has quit IRC13:08
* mdbooth thought we already did that for some reason.13:08
sfinucanAha, no - you're good. None of that stuff is recalculated at present, leading to a host of bugs around CPU pinning, hugepages and anything else NUMA-affinitized13:09
mdboothsfinucan: Have you reviewed this, btw?13:09
*** jerrygb has quit IRC13:10
sfinucanAye, multiple times. I never made it to the end though before it got respun :)13:10
mdboothI'm assuming that means that, priority list or not, it's not making it into Ocata.13:11
mdboothIt's 'one of those'13:12
mdboothsfinucan: Incidentally, how do guests feel about having their instance topologies changed?13:13
mdboothsahid: Do you know the answer to ^^^ ?13:13
sfinucanmdbooth: idk - it really needs to get in but we keep finding corner cases (race conditions, etc.)13:13
sfinucan...and it's so damn big that reviewing it turns into a chore each time13:14
mdboothWhere have the races been?13:14
mdboothThere's one in there now, btw. I already commented on that.13:14
mdboothIt's trivial to fix, though, just a missing sync context manager13:14
sfinucancfriesen pointed out a few some time back. I don't know if they were addressed13:14
*** tbachman has joined #openstack-nova13:15
sfinucanmdbooth: As for the instance topology, I don't think the actual topologies change13:15
sfinucani.e. how many sockets/cores/threads everything has13:15
*** lucas-hungry is now known as lucasagomes13:16
sfinucanrather, how these are aligned under the hood13:16
sfinucanon the host, that is13:16
* mdbooth hasn't looked at the implementation of numa_fit_instance_to_host13:16
*** dave-mccowan has joined #openstack-nova13:18
*** edmondsw has joined #openstack-nova13:18
sfinucanI could be wrong there though. The scheduler is still mostly black magic to me :(13:19
*** edmondsw has quit IRC13:20
sfinucanmdbooth: numa_fit_instance_to_host takes an already defined instance_topology and shouldn't change anything about that (besides pinning information, which is the bug I'm sidestepping here https://review.openstack.org/#/c/419479/)13:20
*** edmondsw has joined #openstack-nova13:20
mdboothsfinucan: Cool.13:20
openstackgerritStephen Finucane proposed openstack/nova: pci: Validate behavior of empty devname  https://review.openstack.org/39613013:23
*** ijw has joined #openstack-nova13:23
*** tbachman has quit IRC13:24
*** tbachman has joined #openstack-nova13:26
*** ayogi has quit IRC13:26
*** ijw has quit IRC13:28
*** ducttape_ has quit IRC13:29
openstackgerritRadomir Dopieralski proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication  https://review.openstack.org/41944113:32
*** gouthamr has quit IRC13:32
*** armax has joined #openstack-nova13:34
*** sree has joined #openstack-nova13:36
*** kylek3h has joined #openstack-nova13:37
*** praveen has quit IRC13:38
*** hoangcx has joined #openstack-nova13:39
*** mdnadeem has quit IRC13:39
*** acabot has joined #openstack-nova13:41
*** Jeffrey4l_ is now known as Jeffrey4l13:42
openstackgerritGábor Antal proposed openstack/nova: Added instance.reboot.error to the legacy notifications  https://review.openstack.org/41181613:44
*** pbandark has quit IRC13:44
*** jpena is now known as jpena|lunch13:45
*** vladikr has joined #openstack-nova13:45
*** huanxie has joined #openstack-nova13:50
bauzasjohnthetubaguy: not sure I see which points in particular you want to change for https://review.openstack.org/#/c/417961/20 ?13:50
*** udesale has joined #openstack-nova13:50
bauzasjohnthetubaguy: just a naming thing, or more about how to not return a NoValidHosts in case we don't have the placement service ready yet ?13:50
johnthetubaguybauzas: the naming thing was my main worry13:50
bauzasthe latter needs discussion because I think the general agreement was against that13:50
bauzasbut that's tied to the grenade issue13:51
bauzasmaybe an hangout could help with folks around13:51
bauzasbut we would be missing jaypipes and matt13:51
bauzas:(13:51
bauzasin the meantime, I can do the naming thing13:52
cdentbauzas, johnthetubaguy : I'm not yet caught up on that review, but will be within about two hours. Will try to add my perspective, if it differs from anything already there.13:52
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication  https://review.openstack.org/41944113:52
openstackgerritGábor Antal proposed openstack/nova: Transform instance.reboot.error notification  https://review.openstack.org/41179113:53
bauzascdent: refrain your pencil, I have a patch to do for modifying the interface name13:53
cdent13:53
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type  https://review.openstack.org/42425613:53
*** armax has quit IRC13:54
andreykurilinbauzas: hi! please look at https://review.openstack.org/#/c/419441 it is critical fix for several projects13:54
*** cdent has quit IRC13:56
*** udesale has quit IRC13:57
takashinbauzas: Could you review https://review.openstack.org/#/c/408955/ again and check my comments?13:59
openstackgerritGábor Antal proposed openstack/nova: Transform instance.reboot.error notification  https://review.openstack.org/41179113:59
tdurakovpaul-carlton2 eliqiao shaohe_feng pkoniszewski yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov andreas_s abhishekk mrhillsman raj_singh wznoinsk siva_krishnan hi folks, live migration subteam meeting in a minute13:59
*** owalsh-lunch is now known as owalsh14:00
*** karimb has quit IRC14:00
takashinbauzas: Are you around?14:01
johnthetubaguybauzas: I think I don't really understand fully what the current proposal for update is / means, so its hard to comment on it.14:01
bauzasjohnthetubaguy: that's why I think an hangout could be nice14:02
*** prateek has quit IRC14:02
takashinbauzas: Could you review https://review.openstack.org/#/c/408955/ again and check my comments?14:02
bauzasjohnthetubaguy: so you could  give your insight once knowing all14:02
*** karimb has joined #openstack-nova14:02
*** timello has quit IRC14:03
johnthetubaguybauzas: yeah, that could work14:03
bauzasjohnthetubaguy: and honestly, I tend to listen to your voice for operating insights :)14:03
bauzastakashin: yup, in my queue, I haven't forgotten14:03
bauzasjust feeling the FF breeze chilling me14:03
takashinbauzas: Thank you.14:03
openstackgerritRadomir Dopieralski proposed openstack/python-novaclient: ListExtResource given in place of ListExtManager  https://review.openstack.org/42457014:04
bauzasunrelated, having the UTs running with osprofiler anytime seems sooo wrong to me14:04
bauzasDinaBelova: around ?14:05
bauzasDinaBelova: why are we needing to verify osprofiler anytime we run U14:05
bauzasUTs?14:05
bauzascan't it be part of the regular unittest job?14:05
bauzasas a developer, I don't really need to verify that anytime I'm modifying an internal change14:06
bauzasthat's... silly14:06
bauzasbut I truly understand it could be part of the UT coverage14:06
bauzasor a specific job14:06
*** ducttape_ has joined #openstack-nova14:06
*** acabot has quit IRC14:08
*** mdrabe has joined #openstack-nova14:08
*** jamesdenton has joined #openstack-nova14:08
*** tblakes has joined #openstack-nova14:09
*** bvanhav_ has joined #openstack-nova14:10
*** jsheeren has joined #openstack-nova14:10
*** bvanhav has quit IRC14:11
jsheerenhi all, the default flavors in mitaka and earlier had a naming like m1.small etc,  what is the origin of this?  to be similar to amazon?14:11
*** ducttape_ has quit IRC14:11
*** timello has joined #openstack-nova14:12
*** rmart04 has quit IRC14:12
andreykurilinACHTUNG! Nova's intergration with Horizon, Trove, Murano-dashboard, Cinder(?!) is broken - https://review.openstack.org/#/c/41944114:12
openstackgerritSylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API  https://review.openstack.org/41796114:13
*** mtanino has quit IRC14:13
andreykurilinjaypipes ^14:13
bauzasandreykurilin: on it14:14
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_attach notification  https://review.openstack.org/40199214:14
andreykurilinbauzas: thanks :)14:14
bauzasandreykurilin: AFAIK, it's impacting TripleO as well, so I'd recommend to tag the bug as critical14:14
andreykurilinbauzas: done14:15
*** takashin has left #openstack-nova14:15
*** gouthamr has joined #openstack-nova14:16
*** esberglu has joined #openstack-nova14:16
bauzasandreykurilin: diana_clarke: there is a follow-up for fixing CLI, correct?14:17
diana_clarkebauzas: yup14:17
andreykurilinbauzas: https://review.openstack.org/#/c/42425614:17
bauzasokay, let's merge the first one and see the CLI then14:17
andreykurilinbauzas: it is broken for more than a year :(14:18
bauzasdiana_clarke: could you please mark your change as Related-bug ?14:18
*** krtaylor has quit IRC14:18
diana_clarke^ andreykurilin14:18
diana_clarke(I don't have a change to mark as related)14:19
andreykurilinbauzas: I think we do not have a right bug-report for CLI, but I can create it for proper history14:19
bauzasandreykurilin: oh wait, the bug is 6 month old ?14:19
bauzasif so, that's definitely not a critical :p14:20
andreykurilinlol14:20
andreykurilinbauzas: token auth via python API is broken since 7.0.014:20
andreykurilinit is just several weeks14:20
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Use the mirror element to detect job completion  https://review.openstack.org/39973514:20
andreykurilinbauzas: keystoneauth1 provides helpers for CLI layer and usage of it was broken from the beggining (~1 year)14:21
*** sahid has quit IRC14:21
*** smatzek_ has quit IRC14:21
johnthetubaguyandreykurilin: had some concerns with the CLI patch, not sure if I am correct though14:21
*** tbachman has quit IRC14:22
johnthetubaguybauzas: andreykurilin: when is release freeze for the client though?14:22
*** gszasz has quit IRC14:23
johnthetubaguyI think its this week14:23
*** mingyu has joined #openstack-nova14:23
bauzasjohnthetubaguy: it was last week14:24
*** flaper87 has quit IRC14:24
bauzashence my concern about the prio of the bug14:24
johnthetubaguywasn't that non-clients14:24
bauzasoh wait14:24
bauzasI guess you're right14:24
bauzassec, verifying14:24
johnthetubaguyseems like we just released something that is really quite broken14:24
johnthetubaguyand it used to work in the previous "stable" release14:24
bauzasJan 23 - Jan 2714:24
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_attach notification  https://review.openstack.org/40199214:24
bauzashttps://releases.openstack.org/ocata/schedule.html14:24
johnthetubaguyyeah, thats how I read it too14:24
bauzaswe're all good14:25
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_detach notification  https://review.openstack.org/40867614:25
johnthetubaguybauzas: it does feel quite urgent to me14:25
bauzasjohnthetubaguy: agreed, just wanted to understand the problem statement14:26
*** tovin07_ has joined #openstack-nova14:26
bauzasand why it's broken since weeks14:26
bauzasthe bug is open since early January14:26
*** sree has quit IRC14:27
diana_clarkebauzas: because it wasn't used by other projects until u-c was bumped, IIUC.14:27
*** acabot has joined #openstack-nova14:27
bauzaswhen was the bump ?14:27
diana_clarkebauzas: 19th14:27
bauzasdiana_clarke: ah ok14:27
diana_clarkebauzas: https://review.openstack.org/#/c/414170/14:27
bauzasthat explains more14:27
*** tbachman has joined #openstack-nova14:27
johnthetubaguyyeah, I was just checking that14:28
*** mingyu has quit IRC14:28
johnthetubaguythat makes sense14:28
*** satyar has joined #openstack-nova14:28
*** amotoki has quit IRC14:29
*** mlavalle has joined #openstack-nova14:29
*** tovin07_ has quit IRC14:29
*** breitz has quit IRC14:30
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_detach notification  https://review.openstack.org/40867614:30
*** krtaylor has joined #openstack-nova14:31
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type  https://review.openstack.org/42425614:31
andreykurilinjohnthetubaguy: fixed your comment ^14:31
johnthetubaguyandreykurilin: sorry, I added another comment after I spotted something else14:32
johnthetubaguyaround the domain being optional14:33
andreykurilinjohnthetubaguy: I left an answer to it :)14:33
andreykurilinjohnthetubaguy: it is optional but has default values14:33
*** udesale has joined #openstack-nova14:34
*** larainema has joined #openstack-nova14:34
andreykurilinjohnthetubaguy: since it exist in both token and password auth methods, it is ok. user_id exists only in password method and in case of token one, it is just filtered and no metter do we have default values or not14:34
johnthetubaguyandreykurilin: doh, I can't read problem, I see your comment now, makes sense14:34
johnthetubaguys/read problem/read properly/14:34
andreykurilinjohnthetubaguy: :)14:35
*** amotoki has joined #openstack-nova14:35
*** eharney has joined #openstack-nova14:37
*** ducttape_ has joined #openstack-nova14:37
*** krtaylor has quit IRC14:37
*** tovin07_ has joined #openstack-nova14:38
kuzkohello,I would like to know if there are special command lines or something special to do to allow for UEFI boot of a volume?14:38
*** bvanhav_ is now known as bvanhav14:38
*** tovin07_ has quit IRC14:38
andreykurilinbauzas johnthetubaguy: there is one more high priority bug, which affects cinder and horizon(and openstackclient ?!). Fix is almost ready, just require proper release note. I'll try to reach the author of fix to make it asap14:39
johnthetubaguyandreykurilin: cool, thanks for chasing, as always!14:39
*** jsheeren has quit IRC14:39
bauzasandreykurilin: have you discussed with matt about a release soon ?14:39
bauzasandreykurilin: do you want me to tag the release ?14:40
*** cdent has joined #openstack-nova14:40
bauzasandreykurilin: I mean, I'm theorically the release liaison so release management cores would be okay with me providing this change without matt +1ing it14:41
andreykurilinbauzas: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2017-01-23.log.html#t2017-01-23T17:31:5114:41
andreykurilinbauzas: yesturday I informed Matt about an issue and notified him about required release, he gave ack :)14:42
*** lpetrut has joined #openstack-nova14:43
openstackgerritRadomir Dopieralski proposed openstack/python-novaclient: ListExtResource given in place of ListExtManager  https://review.openstack.org/42457014:43
bauzasandreykurilin: johnthetubaguy: I have a nit about the reno note14:44
andreykurilinbauzas: again. CLI brackage was introduced a year ago14:44
*** jerrygb has joined #openstack-nova14:44
andreykurilinin 201514:44
andreykurilin:)14:44
bauzasandreykurilin: I'd prefer if you could respin very quick so I could apply a +2/+W based on john's already giving you +214:44
bauzasandreykurilin: sure, but the novaclient thing is new14:44
andreykurilinbauzas: I attached a bug report in commit message with link to patch that introduced an issue14:44
bauzasandreykurilin: please consider application developers that fetch novaclient and look at the release notes to see what changed14:45
bauzasandreykurilin: those people wouldn't read the commit msg14:45
bauzasandreykurilin: I got that the CLI breakage is old, but the novaclient thing is new, right?14:45
bauzasandreykurilin: so, maybe 2 bullets is fine by me, but you should at least explain since when we had that regression14:46
andreykurilinbauzas: usage via python api yes - it is new:) via cli is old.14:46
*** sahid has joined #openstack-nova14:46
bauzasor people would say "WAT? I wasn't able to use token auth? seriously?"14:46
andreykurilinWe broke CLI in 3.1.0 release of novaclient. lol14:47
bauzas3.1.0 is not that old14:47
bauzaswe have people running it14:47
bauzasthat I know14:47
andreykurilinheh14:47
dansmithjohnthetubaguy: if you have any time to review the bottom two patches on the cells series I'd appreciate it: https://review.openstack.org/#/c/396775/4214:47
dansmithjohnthetubaguy: those three patches basically get us to our goal for cellsv2 for the cycle14:47
bauzasso, yeah, I think that's important for us to comment when the breakage was introduced14:47
*** jerrygb_ has joined #openstack-nova14:47
andreykurilinok. I'll update my patch in seconds to not scare people:)14:47
*** pradk has quit IRC14:47
bauzasdansmith: I haven't forgotten you14:47
*** pradk has joined #openstack-nova14:48
johnthetubaguydansmith: I will take a peak at that now14:48
*** gouthamr_ has joined #openstack-nova14:49
*** jerrygb__ has joined #openstack-nova14:49
*** vladikr has quit IRC14:49
*** jpena|lunch is now known as jpena14:49
*** psachin has quit IRC14:50
*** rmart04 has joined #openstack-nova14:50
*** tovin07_ has joined #openstack-nova14:50
*** gouthamr has quit IRC14:50
mdboothpkoniszewski: Just been reading through the review history on that patch. moshele mentioned the save() issue here: https://review.openstack.org/#/c/244489/46/nova/compute/manager.py14:50
*** jerrygb has quit IRC14:51
mdboothMy confidence is growing that the rollback issue is real.14:51
*** gouthamr_ is now known as gouthamr14:51
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type  https://review.openstack.org/42425614:51
andreykurilinbauzas: ^14:52
*** jerrygb_ has quit IRC14:52
*** smatzek has joined #openstack-nova14:53
pkoniszewskimdbooth: that's right14:53
pkoniszewskimdbooth: but the pre_live_migration bit is correct14:53
mdboothYeah. I didn't see a problem there, btw.14:54
*** karimb has quit IRC14:54
*** knikolla has joined #openstack-nova14:55
*** belmoreira has joined #openstack-nova14:55
mdboothI think it's probably futile to try to prevent calling save on the instance object on such a wide ranging function. Perhaps we should just concede it will happen and deal with it?14:55
mdboothWell, for live migration we *know* it happens, because we do it in compute manager.14:56
openstackgerritRadomir Dopieralski proposed openstack/python-novaclient: ListExtResource given in place of ListExtManager  https://review.openstack.org/42457014:57
*** rmart04 has quit IRC14:57
*** amotoki has quit IRC14:57
*** karimb has joined #openstack-nova14:57
*** krtaylor has joined #openstack-nova14:58
*** rmart04 has joined #openstack-nova14:58
andreykurilinbauzas: and yes, it will be cool, if you propose a new novaclient's release. Not sure about right version- 7.0.1 (since it fixes several issues from 7.0.0) or 7.1.0 (since it contains a bit feauture - support of osprofiler)14:58
*** pbandark has joined #openstack-nova14:58
*** armax has joined #openstack-nova14:58
andreykurilinbauzas johnthetubaguy: it is another high priority fix - https://review.openstack.org/#/c/424570 . just +10, -1 with release notes14:59
*** jwcroppe has joined #openstack-nova15:00
*** tbachman has quit IRC15:00
openstackgerritVladik Romanovsky proposed openstack/nova: libvirt: set vlan tag for macvtap on SR-IOV VFs  https://review.openstack.org/42118615:00
*** prateek has joined #openstack-nova15:01
*** tovin07_ has quit IRC15:01
*** jerrygb has joined #openstack-nova15:01
*** sahid has quit IRC15:02
*** mriedem has joined #openstack-nova15:02
dansmithjohnthetubaguy: thanks.. it's going to be a hard push to get this in by thurs, but I'm still trying15:03
*** tovin07_ has joined #openstack-nova15:04
*** tlian has joined #openstack-nova15:04
*** jerrygb__ has quit IRC15:05
mriedemdansmith: don't forget to breath15:05
dansmithmriedem: hoo hoo heee, hoo hoo heee15:05
mriedemexactly15:06
*** hoangcx has quit IRC15:06
*** sahid has joined #openstack-nova15:07
*** hongbin has joined #openstack-nova15:08
andreykurilinjohnthetubaguy: Can you put +2 again to https://review.openstack.org/424256 ?)15:08
*** kfarr has joined #openstack-nova15:09
*** tbachman has joined #openstack-nova15:10
*** vladikr has joined #openstack-nova15:11
*** sree has joined #openstack-nova15:12
bauzasdansmith: who's core in grenade ?15:12
dansmithbauzas: me, sdague and dtroyer15:12
bauzasdansmith: I'm firing a patch for making sure we run the placement-engine in Ocata when upgrading, which is not the case15:13
*** mtanino has joined #openstack-nova15:13
dansmithack15:13
*** gouthamr has quit IRC15:13
bauzasdansmith: http://logs.openstack.org/61/417961/20/check/gate-grenade-dsvm-neutron-ubuntu-xenial/35a48ec/logs/new/local.conf.txt.gz15:13
bauzasdansmith: there is no enabled service that runs the placement engine15:13
*** cdelatte has joined #openstack-nova15:13
bauzashence the grenade failure on my change15:13
dansmithack part deux15:14
bauzasso I'm thinking of updating https://github.com/openstack-dev/grenade/blob/master/projects/60_nova/from-newton/upgrade-nova15:14
bauzasdansmith: but any idea how I would do that ?15:14
bauzasis the above pre calling devstack ?15:14
*** mtanino has quit IRC15:15
diana_clarkebauzas: dansmith beat me to it, but for those following along from home, you can see the core here: https://review.openstack.org/#/admin/groups/188,members15:15
*** mtanino has joined #openstack-nova15:15
diana_clarkes/core/cores15:15
*** rmart04 has quit IRC15:16
dansmithbauzas: you can call devstack functions if they're included, yeah, like initialize_database there is from devstack15:17
*** rmart04 has joined #openstack-nova15:17
*** READ10 has joined #openstack-nova15:17
*** markvoelker has quit IRC15:18
bauzasdansmith: I think I got the idea from https://github.com/openstack-dev/grenade/blob/master/projects/60_nova/from-mitaka/upgrade-nova15:19
bauzasI could source lib/placement15:19
johnthetubaguydansmith: should I be worried about the order of the list of CELLS we are iterating over being the same on all API workers?15:19
dansmithjohnthetubaguy: from a sorting perspective?15:19
dansmither, instance sorting?15:19
johnthetubaguydansmith: yeah, I was thinking from a fetching a marker perspective15:19
*** sahid has quit IRC15:20
bauzasjohnthetubaguy: you mean adding a new cell meanwhile we're iterating ?15:20
dansmithjohnthetubaguy: well, so the deal here is that this code is here to officially support only one cell for ocata,15:20
johnthetubaguydansmith: good point15:20
bauzasjohnthetubaguy: if so, I discussed on that yesterday with dansmith and we agreed on not being a problem for ocata15:20
dansmithjohnthetubaguy: but so that we can move to the third patch where we're creating in conductor (and thus potentially multiple cells). None of the naive sorting stuff is in here yet, so I think any concern for that is moot,15:20
dansmithbut this enables people to play with it15:21
*** sahid has joined #openstack-nova15:21
johnthetubaguydansmith: in terms of staging things so we get someone, totally makes sense15:21
johnthetubaguys/someone/somewhere15:21
dansmithjohnthetubaguy: right15:21
*** markvoelker has joined #openstack-nova15:21
*** amotoki has joined #openstack-nova15:22
dansmithjohnthetubaguy: but yes, following this, we'll want stable sorting of cells, reloading of the cells list, a naive sort approach, etc15:22
*** vladikr has quit IRC15:22
johnthetubaguydansmith: ack15:22
mriedemoh great device tags is all fubar in the api now too huh15:23
*** sree has quit IRC15:24
dansmithbauzas: johnthetubaguy: sfinucan: the patch after that, by the way, is just a tweak to the api_samples setup, and an approach sdague suggested, so it should be fairly easy to hit I think15:24
dansmithto prevent api_samples from tripping over itself in the final patch15:24
bauzasdansmith: yeah I just began to look at it15:25
dansmithcool15:25
*** jaosorior has joined #openstack-nova15:25
*** zz_dimtruck is now known as dimtruck15:25
*** sree has joined #openstack-nova15:26
dansmithmriedem: if you want an easy one to +W to make your vacation feel productive, this trivial one from sfinucan would be good: https://review.openstack.org/#/c/419479/515:26
*** amotoki has quit IRC15:26
amriththx andreykurilin15:26
*** amotoki has joined #openstack-nova15:26
amrithplease let me know once the novaclient patch is released15:26
amriththat'll be the easiest way to test in the gate15:27
amrithcould we mark 7.0.0 as bad?15:27
*** amotoki has quit IRC15:27
mriedemamrith: 7.0 isn't in g-r is it?15:27
*** amotoki has joined #openstack-nova15:27
mriedemor u-c rather15:27
amrithwell, it is what we're getting now from pypi15:27
andreykurilinmriedem: 7.0 is a version from u-c now :)15:27
mriedemare you using upper-constraints?15:27
andreykurilinalso it is a min version of requirements15:28
mriedemandreykurilin: ok, then i guess we should blacklist 7.0 in g-r15:28
mriedemreally? why?15:28
amrithmriedem, yes15:28
diana_clarkemriedem: it was merged into u-c on the 19th https://review.openstack.org/#/c/414170/15:28
amrithglobal-requirements.txt:python-novaclient>=2.29.0,!=2.33.0  # Apache-2.015:28
amrithprojects.txt:openstack/python-novaclient15:28
amrithupper-constraints.txt:python-novaclient===7.0.015:28
amrithmriedem, yes we're using u-c15:28
andreykurilinmriedem: I think today we will have everything for next release (7.0.1/7.1.0) and we will able to make everything together - blacklist and put right version15:28
mriedemi don't know why we'd require 7.0 as the minimum15:29
*** bkopilov has joined #openstack-nova15:29
*** ducttape_ has quit IRC15:29
amrithmriedem, andreykurilin it may be a good idea to have periodic jobs that test against the tip of master in nova client like we do with oslo. I'll propose such a periodic job15:29
mriedemalso the wifi here sucks so everything takes forever to load15:29
mriedemamrith: and where do the results of those jobs go and who is going to be monitoring them?15:30
amrithmriedem, I get an email when they fail15:30
amrithlet me find out how that is setup15:30
amrithit is something that dims (I believe) setup a while back15:30
mriedemok15:30
amrithin general, I'd think that is something that for trove, should be trove's to monitor15:31
mriedemamrith: have you talked to the requirements team about getting a trove unit test job to run as part of changes like this? https://review.openstack.org/#/c/414170/15:31
amrithhave not15:31
andreykurilinmriedem: because all "right version" from min to max should be compatible. we have too much changes now to use 2.29 as a min (like it was previously)15:31
amrithbut it is a good idea as well15:31
andreykurilinI mean it is a hard task to write a compatible code for 2.29 and 7.015:32
mriedemandreykurilin: well yeah, and that's why we use semver for major changes15:32
mriedemeven with fixing the token thing, 7.0 probably breaks a bunch of things15:32
andreykurilinmriedem: it breaks two things - token auth via python API (for CLI it was broken for a year) and list_extension15:33
andreykurilinboth of these things have fixes on review15:33
mriedemwell by 'break' i mean, intentional changes to remove functionality15:34
bauzas7.0.0 is breaking more than the token thing ?15:34
mriedemwhich is why we released it with a major version bump15:34
bauzasdo we have a g-r change that blocks it ?15:34
mriedembauzas: the requirements changes aren't run against trove unit tests,15:34
mriedemotherwise something might have been caught15:34
bauzasand if we have a couple of fixes, let's name the next release 7.0.1 even if we add the osprofiler thing15:34
andreykurilinmriedem: I think we done everything in backward compatible way (except usage of our inner variables)15:34
*** armax has quit IRC15:34
*** armax_ has joined #openstack-nova15:34
bauzasmriedem: yeah, but as per andreykurilin 7.0.0 blew up more than just trove15:35
*** prateek has quit IRC15:35
bauzasmriedem: at least the tripleo folks and the murano folks AFAICS15:35
mriedembauzas: new features need to be a min version bump at least to 7.1.015:35
bauzasI know15:35
andreykurilinbauzas: one more thing that is broken by 7.0 - https://review.openstack.org/#/c/424570/ :)15:35
bauzasI'm saying 7.0.0 is doomed so we would signal that there is a new release fixing it15:36
mriedemon https://review.openstack.org/#/c/423808/ i would have made the min 6.0, and u-c 7.015:36
andreykurilinok, let's use 6.0 as a min, but not 2.29 like it was15:36
bauzasyup :(15:36
mriedemandreykurilin: do you want me to push that change quick?15:37
*** huanxie has quit IRC15:37
mriedem>=6.0.0,!=7.0.015:37
andreykurilinmriedem: no, please take a rest. you are on vacation15:37
andreykurilinI'll do it15:37
*** sneti_ has joined #openstack-nova15:37
mriedemit's morning and i've got a caffiene headache but ok15:38
mriedem*caffeine15:38
bauzasmriedem: you okay if I'm tagging a 7.1.0 with the help of andreykurilin ?15:38
bauzasonce all the fixes are done of course15:38
mriedembauzas: that's fine15:38
mriedemalex_xu: cdent: artom: gmann: where are we on the device tags thing?15:39
bauzasmriedem: client libraries freeze is thursday as well ?15:39
mriedembauzas: yes client release freeze is thursday15:39
bauzasok15:39
cdentmriedem: I don't know, haven't revisited since I lit the fire...15:40
*** sneti_ has quit IRC15:40
mriedemit's a time that i wish we could just fix the bugs in the api w/o the microversion15:40
artommriedem, nowhere as far as I can tell - what's the plan? We document before ocata FF and unfuck it in Pike?15:40
artomIf so I can submit the documentation patch15:41
mriedem(a) this version works, but (b) x-y don't work, except z, so (c) we'll fix it all in microversion 2.5015:41
artomBut I wasn't sure we had consensus on that15:41
robcresswelldiana_clarke: Thanks for the response on the horizon discussion, that was useful15:41
*** amotoki has quit IRC15:41
*** aojea has quit IRC15:41
mriedemartom: if we're not going to fix it with a microversion in ocata we can document it probably whenever before ocata rc115:41
*** marst has joined #openstack-nova15:42
artommriedem, do we have time to squeeze it in in 2 days? I can write the code...15:42
artom(The new microversion I mean)15:42
mriedemartom: we probably don't have the review bandwidth in 2 days15:42
*** jose-phillips has joined #openstack-nova15:43
mriedemalternatively we microversion it for a bug fix and it's not tied to FF since it's not a feature, it's a bug fix15:43
diana_clarkerobcresswell: np, I know the whole approach is somewhat sub-optimal, but I'm not sure how else we could have proceeded.15:43
mriedemi thought we did that with the vm status microversion in newton15:43
artommriedem, oh right, I forgot FF != halt all evarything15:43
*** ekuris_ has quit IRC15:44
artommriedem, if I have your PTLness backing me on this, I can drive it as a microversion bugfix before ocata release15:44
artom;)15:44
cdentI think bugfix sounds like the right approach15:44
cdentgives some time to do it right15:44
*** nkrinner is now known as nkrinner_afk15:44
cdentand it _is_ a bugfix15:44
*** aojea has joined #openstack-nova15:45
robcresswelldiana_clarke: Yeah, understood15:45
mriedemespecially this one https://review.openstack.org/#/c/304510/64/nova/api/openstack/compute/block_device_mapping.py i'd really like to just fix that w/o a microversion,15:45
mriedembut that probably goes against everything we've always said15:45
*** sacharya has joined #openstack-nova15:46
*** ducttape_ has joined #openstack-nova15:46
artommriedem, I don't think we can. For all intents and purposes, there's no tag in >=2.33. And adding an API parameter is a new microversion...15:47
mriedemyes i know, but 2.33->2.43 or whatever with no bdm tag support, and then it's back in, is just super terrible UX15:48
*** ociuhandu has quit IRC15:48
cdentbauzas: are your placement changes in a good state to review now?15:48
*** vladikr has joined #openstack-nova15:48
bauzascdent: it is indeed15:48
cdenton it15:48
bauzascdent: I need to write a grenade change for fixing the related jobs but that shouldn't be impacting my WIP15:48
artommriedem, I totally agree on that point... And to be fair, I can't think of any core that would stop working15:48
*** burgerk has joined #openstack-nova15:49
bauzascdent: FWIW, there is now only one patch left, I abandoned the fixture one15:49
cdentk15:49
artomTags were optional, so if you tried to use them in 2.33 it would break, but no one filed a but so no one noticed15:49
artomBut if you weren't using them re-adding them as an optional parameter doesn't break anything15:49
*** mvk has quit IRC15:49
artomHrmm, maybe we *can* just silently re-add them15:49
artomSame logic goes for networks15:49
bauzasdansmith: quick question on grenade, do you think it's a valid approach to just source the placement lib, and call out the appropriate functions, or try to modify local.conf to include placement?15:50
mriedemi doubt anyone noticed because (a) most clouds aren't at newton yet and/or (b) no one is using them, yeah15:50
*** burgerk_ has joined #openstack-nova15:50
dansmithbauzas: source and use existing functions15:50
*** acabot_ has quit IRC15:50
mriedemhowever,15:50
bauzasdansmith: that would mean local.conf wouldn't be accurate then15:50
*** hieulq_ has joined #openstack-nova15:51
*** breitz has joined #openstack-nova15:51
mriedem2.1 and microversions is all about correcting mistakes, and in the old 2.0 API we always said we couldn't fix things regardless of the wart15:51
bauzasdansmith: if that's not a necessary requirement, I'm fine15:51
mriedemunless we used extensions or some garbage like that15:51
dansmithbauzas: oh, thought you meant nova.conf.. I still think that's okay and consistent, FWIW15:51
bauzasdansmith: the fact is that the grenade-upgrade local.conf wouldn't be valid in case the deployer wants to unstack/stack15:52
mriedemandreykurilin: ping me when your requirements change is up to change the minimum back to 6.0 and blacklist 7.015:52
cdentmriedem: sounds like you should join the thread about api compatbility/stability seeing as you have opinions ;)/215:52
andreykurilinmridem: it is here https://review.openstack.org/#/c/424705/15:52
mriedemcdent: well i lean toward the microversion fix15:53
mriedemjust because it's the "right thing to do"15:53
openstackgerritBalazs Gibizer proposed openstack/nova: handle uninited fields in notification payload  https://review.openstack.org/41585715:53
*** burgerk has quit IRC15:53
openstackgerritsahid proposed openstack/nova: numa: add numa constraints for emulator threads policy  https://review.openstack.org/38502315:54
openstackgerritsahid proposed openstack/nova: libvirt: return a CPU overhead if isolate emulator threads requested  https://review.openstack.org/38536415:54
openstackgerritsahid proposed openstack/nova: objects: add new field cpuset_reserved in NUMACell  https://review.openstack.org/40087415:54
openstackgerritsahid proposed openstack/nova: numa: fit instance topology with cpus reserved onto cores  https://review.openstack.org/40087515:54
artommriedem, it *is* more transparent15:54
openstackgerritsahid proposed openstack/nova: virt: update overhead to take into account vCPUs  https://review.openstack.org/38502415:54
openstackgerritsahid proposed openstack/nova: libvirt: make emulator threads to run on the reserved pCPU  https://review.openstack.org/40087815:54
openstackgerritsahid proposed openstack/nova: numa: take into account cpus reserved  https://review.openstack.org/40087615:54
openstackgerritsahid proposed openstack/nova: numa: update numa usage incording the cpu reserved  https://review.openstack.org/40087715:54
artomYeah, anyone can dig through the git logs and review history, but putting it in the API version history is more accessible if folks start wondering wtf15:54
lyarwoodmdbooth: https://review.openstack.org/399735 could use another review if you have time today15:55
*** briancurtin has left #openstack-nova15:55
*** jdurgin1 has joined #openstack-nova15:56
*** amotoki has joined #openstack-nova15:57
mdboothlyarwood: Yep. It takes me almost 10 minutes to make a moka of coffee, I'll do it then :)15:57
*** udesale has quit IRC15:58
*** mdrabe has quit IRC15:58
*** _ducttape_ has joined #openstack-nova15:59
mriedemsfinucan: "While this doesn't cause any issues currently, it is a latent bug that has caused issues downstream." - in other words, it's currently causing issues :)16:02
*** aojea has quit IRC16:02
sfinucanmriedem: You got it :)16:02
*** ducttape_ has quit IRC16:03
sfinucanI meant "this doesn't cause issues with upstream-only code", of course16:03
*** dillaman has joined #openstack-nova16:03
*** cdent_ has joined #openstack-nova16:04
*** cdent has quit IRC16:04
*** cdent_ is now known as cdent16:04
andreykurilinmriedem: btw, are you ok about putting 7.1.0 to u-c ?16:05
*** jose-phillips has quit IRC16:05
mriedemsfinucan: is it blowing up another out of tree scheduler filter or something?16:05
mriedemsfinucan: or you're just not allowed to talk about it?16:05
mriedemandreykurilin: yes16:05
andreykurilinnice16:05
*** amoralej|off has quit IRC16:06
*** ltomasbo has quit IRC16:06
mriedemsfinucan: dansmith: ok +W16:06
*** dmellado has quit IRC16:07
sfinucanmriedem: Aye, we've a downstream only workaround to handle that long running "nova doesn't recalculate CPU topologies on live migration" bug16:07
mriedemthanks for not ramming that in all red hat cores16:07
*** jpena has quit IRC16:07
andreykurilinjohnthetubaguy: your comment about transmitting --os-user-id in case of token auth made gates to fail :( it requires more changes in novaclient's code. will recent a fix soon16:07
*** breitz has quit IRC16:07
*** sree has quit IRC16:07
*** breitz has joined #openstack-nova16:08
sfinucanWe check for CPU pinning info in the topology and compare it against the free host cores. The pinning info should only exist in a live migrate case, but that bug broke the assumption and broke scheduling :)16:08
*** jerrygb has quit IRC16:08
*** mfeoktistov has quit IRC16:09
sfinucanmriedem: Thanks for the review. I can go sleep now, heh16:09
dansmithyea, it's pretty nasty16:09
*** cdent has quit IRC16:09
*** mat128|afk is now known as mat12816:09
*** jerrygb has joined #openstack-nova16:09
*** cdent has joined #openstack-nova16:09
*** a-pugachev has quit IRC16:10
*** rmart04 has quit IRC16:11
*** _ducttape_ has quit IRC16:11
*** ducttape_ has joined #openstack-nova16:12
mdboothlyarwood: I've still got a -1 on its parent, right?16:13
mdboothOr is it direct on master now? Gerrit doesn't make this clear.16:13
mdboothAt a glance, anyway.16:14
lyarwoodmdbooth: yeah it really doesn't, it's direct on master now16:14
mdboothk16:14
lyarwoodmdbooth: there's an additional workaround in there so it can be btw16:15
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type  https://review.openstack.org/42425616:15
lyarwoodmdbooth: https://review.openstack.org/#/c/399735/18/nova/virt/libvirt/guest.py16:15
*** aojea has joined #openstack-nova16:15
*** mlavalle has quit IRC16:16
mdboothlyarwood: How's your xpath-fu?16:16
*** pcaruana has quit IRC16:16
* mdbooth wrote a *lot* of xpath in a previous life16:16
lyarwoodmdbooth: not great but that's a copy paste from the original16:16
mdboothand xslt16:16
mdboothYou can do the source/target thing in a single query :)16:17
mdboothI won't inflict that on anybody, though.16:17
mdbooth(Well, I probably would if I'd written it ;))16:17
*** a-pugachev has joined #openstack-nova16:17
lyarwoodeven with a different attribute for both?16:17
lyarwoodnice16:17
mdboothYeah16:18
mriedemdansmith: so what do you want me to look at for cells v2?16:18
*** ijw has joined #openstack-nova16:18
dansmithmriedem: this and the following: https://review.openstack.org/#/c/410473/1316:18
mriedemkeeping in mind i've got a 5 year old girl asking me when i'm going to take a shower so i can go swimming16:18
dansmithmriedem: I had to recheck the d-g patch, let me go check that again16:18
mriedemi just rechecked it16:19
dansmithokay it's +116:19
dansmithI emailed sdague about it yesterday but don't see that he looked at it16:19
mriedemon https://review.openstack.org/#/c/396775/ and the stable sort limitation,16:19
dansmithI'll poke clarkb16:19
mriedemare we going to just doc that in a reno? or will we just say in release notes that multiple cells aren't supported in ocata?16:20
*** ociuhandu has joined #openstack-nova16:21
dansmithmriedem: yeah, I've been kinda waiting to see how far I get, but a release note with the status of things was my plan16:21
EmilienMmriedem: hi! quick question, do we wait https://review.openstack.org/#/c/424256/ to release the next novaclient?16:22
*** ijw has quit IRC16:23
openstackgerritPushkar Umaranikar proposed openstack/nova: Remove unused columns from BuildRequest table in nova_api db  https://review.openstack.org/42225916:23
sfinucandansmith: (Best effort) comments left on https://review.openstack.org/#/c/41047316:24
*** marst_ has joined #openstack-nova16:26
*** marst has quit IRC16:26
dansmithsfinucan: thanks, I'll explain in there16:27
sfinucan(y)16:27
*** edleafe- is now known as edleafe16:27
mriedemEmilienM: yes, andrey has a patch up in reqs repo to blacklist 7.016:27
*** bvanhav has quit IRC16:28
*** bvanhav_ has joined #openstack-nova16:28
*** _ducttape_ has joined #openstack-nova16:28
EmilienMmriedem: ok, thank you !16:28
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type  https://review.openstack.org/42425616:29
*** baoli has quit IRC16:29
*** annegentle has joined #openstack-nova16:29
*** tbachman has quit IRC16:30
*** mdrabe has joined #openstack-nova16:30
dansmithsfinucan: I tried to re-state the commit message.. let me know if that makes any more sense and if you think I should tweak what I have in some way16:30
dansmithsfinucan: it is a pretty complicated problem that took a long time to figure out, although the actual change is rather small16:30
sfinucandansmith: Cheers. Will do16:31
*** ducttape_ has quit IRC16:31
mriedemdansmith: i'll start keeping a tally of things we need to reno in the cells v2 wiki16:32
dansmithmriedem: okay16:33
dansmithmriedem: I could also just start a reno patch that we can keep augmenting for a while16:33
mriedemthat works too16:33
dansmithlemme do that while I'm waiting16:33
andreykurilinmriedem: About your reply to "Device tag in the API breaks in the old microversion". If the fix should be done via new microversion, should we wait a bit for adding it to new novaclient's release ?16:33
openstackgerritBalazs Gibizer proposed openstack/nova: handle uninited fields in notification payload  https://review.openstack.org/41585716:34
mriedemandreykurilin: we're going to have to bug fix it in novaclient16:34
mriedemandreykurilin: e.g. --nic tag won't work in 2.37+16:34
melwittdansmith: this block is still commented out. I don't quite understand the comment, does it need to be moved to the conductor tests or? https://review.openstack.org/#/c/319379/72/nova/tests/unit/compute/test_compute.py@793716:34
mriedemso the client will probably need to handle that16:34
dansmithmelwitt: I moved it16:34
dansmithoh, did I forgetto remove?16:35
*** hamzy has quit IRC16:35
andreykurilinmriedem: sure, but should we wait for that bug fix to release it with 7.1.0 ?16:35
dansmithmelwitt: https://review.openstack.org/#/c/319379/72/nova/tests/unit/conductor/test_conductor.py16:35
dansmithI forgot to remove, sorry16:35
mriedemandreykurilin: i don't think we'll probably have time, unless someone fixes it today16:35
melwittdansmith: okay, I see16:35
andreykurilinmriedem: nobody can do it until fix is not merged in nova's at first :)16:36
mriedemalex_xu: cdent: Kevin_Zheng: do we have a bug to track the device tags issue?16:36
*** tovin07_ has quit IRC16:36
mriedemandreykurilin: we already have a bug in novaclient16:36
dansmithmelwitt: thanks for catching those, I'm blind to this at this point16:36
openstackgerritDan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation  https://review.openstack.org/42471916:36
mriedemandreykurilin: i.e. if you try to create a server with the latest microversion and specify bdm or nic tags, it won't work16:36
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937916:36
mriedemandreykurilin: i'm guessing you'd get a 400 for the schema validation error16:37
cdentmriedem: https://bugs.launchpad.net/nova/+bug/1658571 ?16:37
openstackLaunchpad bug 1658571 in OpenStack Compute (nova) "Microversion 2.37 break 2.32 usage" [High,In progress] - Assigned to Zhenyu Zheng (zhengzhenyu)16:37
cdentor do we need an additional one16:37
openstackgerritStephen Finucane proposed openstack/nova: Assign mac address to vf netdevice when using macvtap port  https://review.openstack.org/42463916:37
mriedemcdent: looks right16:37
mriedemwe'll use one16:37
mriedemadded novaclient to it16:38
*** tbachman has joined #openstack-nova16:38
cdent16:38
openstackgerritSylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API  https://review.openstack.org/41796116:39
openstackgerritDan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2  https://review.openstack.org/42473716:39
*** ociuhandu has quit IRC16:40
andreykurilinmriedem:as far as I understand nothing special should be done at novaclient's side16:40
andreykurilinmriedem: just bumping max version16:40
andreykurilinsince it is just validation step at API side16:40
mriedemandreykurilin: at a minimum, the help text on the nova boot command will need to be updated16:40
mriedemto say that bdm tags only work with 2.32, and nic tags only work with 2.32->2.3616:41
mriedemotherwise someone will be wondering why they can't create a server with device tags and microversion 2.40, for example16:41
andreykurilinmriedem: can we reserve next microversion for that bug-fix, so it will be possible to release novaclient with support of that microversion today and than merge patch to API side?16:42
*** tbachman_ has joined #openstack-nova16:42
melwittdansmith: I pointed out on PS71 but didn't notice it's still there (sorry). did you want this logging here? https://review.openstack.org/#/c/319379/73/nova/compute/api.py@251716:42
andreykurilin*next microversion number16:42
mriedemandreykurilin: i'd rather not try to reserve a microversion16:42
*** _ducttape_ has quit IRC16:42
mriedemandreykurilin: since there are some patches still up for review for nova before FF that bump microversions16:42
*** tbachman has quit IRC16:42
*** tbachman_ is now known as tbachman16:42
dansmithmelwitt: yeah I was going to keep that and the related ones as it helped me debug and only runs once16:43
melwittokay, cool16:43
openstackgerritRoman Podoliaka proposed openstack/nova: neutron: re-raise 401 for a non-admin client  https://review.openstack.org/42269616:43
andreykurilinmriedem: but it sounds like only possible solution to release novaclient with fixed bug16:43
mdboothlyarwood: Have the test changes in that patch gotten mixed up with one of the other patches?16:44
mriedemandreykurilin: it's already broken in older versions of novaclient,16:44
mdboothlyarwood: https://review.openstack.org/#/c/399735/18/nova/tests/unit/virt/libvirt/test_driver.py16:44
mriedemandreykurilin: so i'm less worried about rushing a fix in on the client side for a new microversion,16:44
mriedemandreykurilin: i think it's good to just get a change into novaclient for ocata that updates the help to note the limitation on usage16:44
mriedemandreykurilin: we can get the novaclient fix with the new microversion released in pike16:44
*** gszasz has joined #openstack-nova16:45
*** jpena_ has joined #openstack-nova16:45
*** sridharg has quit IRC16:45
*** andreas_s has quit IRC16:46
*** jpena_ is now known as jpena16:46
*** luis5tb has joined #openstack-nova16:46
lyarwoodmdbooth: I don't think so, it was easier to rewrite some of the snapshot tests in mock that have increased the size if that's an issue16:47
mdboothlyarwood: Couldn't really see what was changing, tbh.16:47
*** dmellado has joined #openstack-nova16:48
*** luis5tb is now known as ltomasbo16:48
mdboothHowever, if it's just my lack of understanding...16:48
mdboothlyarwood: Personally I'd have called that out in the commit message, or ideally do the test rewriting in the patch before.16:48
lyarwoodmdbooth: so we shouldn't really change anything aside from mocking out the additional XMLDesc calls16:48
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Clarify description for tags  https://review.openstack.org/42474516:49
andreykurilinmriedem: do you mean something like this -  https://review.openstack.org/424745 ?16:49
mdboothIt's just a surprising amount of churn. If it's necessary then ok, I'll just look harder.16:49
lyarwoodmdbooth: yeah, maybe I'm missing a smaller change we can make to the original mox tests tbh16:50
lyarwoodmdbooth: and if I am please feel free to call it out and I'll go over this again16:50
*** a-pugachev has quit IRC16:50
*** stewie925_ has joined #openstack-nova16:50
mdboothlyarwood: I'll keep looking. I thought you'd just made a mistake so I didn't look all that hard.16:51
*** stewie925_ is now known as stewie92516:51
*** ltomasbo has quit IRC16:53
*** jpena has quit IRC16:53
*** dmellado has quit IRC16:53
*** tbachman has quit IRC16:53
sfinucanvladikr: I don't know why mriedem removed his -2 on this https://review.openstack.org/#/c/405951 - doesn't it still require a version bump?16:53
vladikrsfinucan, looking16:54
sfinucanActually, wait - you did bump the version. nvm :) What about a reno?16:54
mriedemsfinucan: i had a -2 on it when the series was much longer and i wanted to make sure the tempest testing was done and testing that API change first16:54
*** mlavalle has joined #openstack-nova16:55
*** browne has joined #openstack-nova16:55
mriedemvladikr: you should link to the tempest change in the commit message16:55
*** sdague has joined #openstack-nova16:55
sfinucanmriedem: Gotcha16:55
sfinucanmriedem: Also, aren't you supposed to be drinking cocktails on a beach somewhere? :)16:55
*** sudipto has joined #openstack-nova16:55
*** sudipto_ has joined #openstack-nova16:56
vladikrmriedem, ok, got it. so I need a new tempest test written for this right?16:56
mriedemvladikr: i thought you already had one started16:56
vladikrmriedem, no, but will do now16:56
vladikrsfinucan, do I need a reno for that change? I thought we wanted to update the user guide16:57
*** owalsh is now known as owalsh-afk16:57
openstackgerritRoman Podoliaka proposed openstack/nova: block_device: fix propagation of instance AZ to Cinder  https://review.openstack.org/36672416:57
mriedemi'd have a feature reno for it and the metadata API version change16:57
sfinucanvladikr: if it introduces a new, user-visible change then I would assume so?16:58
*** lucasagomes is now known as lucas-afk16:58
vladikrsfinucan, mriedem, will add now16:58
*** nic has joined #openstack-nova16:58
sfinucan(y)16:59
*** ltomasbo has joined #openstack-nova16:59
johnthetubaguymelwitt: I had a sudden memory of how the flavor stuff avoid duplicates earlier, I added a comment on that quota patch16:59
*** annegentle has quit IRC16:59
*** dmellado has joined #openstack-nova16:59
melwittjohnthetubaguy: I saw and replied. thanks :) I will go that route. working through all of the changes on the series now17:00
johnthetubaguymelwitt: cool17:00
*** jpena|off has joined #openstack-nova17:01
*** moshele has quit IRC17:01
*** jaypipes_ has joined #openstack-nova17:01
mriedemvladikr: will this change work for config drive too?17:01
*** sudipto has quit IRC17:01
*** sudipto_ has quit IRC17:01
*** tbachman has joined #openstack-nova17:01
*** a-pugachev has joined #openstack-nova17:01
*** claudiub has joined #openstack-nova17:02
vladikrmriedem, yes, sure17:02
*** annegentle has joined #openstack-nova17:02
mriedemvladikr: i'm not so sure, because that's done separately in the libvirt driver https://github.com/openstack/nova/blob/45e79583cea3a87df931c7333bf3c82de2979105/nova/virt/libvirt/driver.py#L318017:03
vladikrmriedem, config drive uses InstanceMetadata to build17:03
mriedemyes i know,17:03
vladikrlooking17:03
mriedembut what you're changing in the metadata is the route from an API request to get the metadata17:03
*** sudipto has joined #openstack-nova17:04
mriedemartom: have you noticed that we build the device metadata for an instance (which hits the db) even if we don't build the config drive? https://github.com/openstack/nova/blob/45e79583cea3a87df931c7333bf3c82de2979105/nova/virt/libvirt/driver.py#L318017:04
*** sudipto_ has joined #openstack-nova17:04
*** claudiub|2 has quit IRC17:04
openstackgerritGábor Antal proposed openstack/nova: Remove mox in unit/cells/test_cells_manager.py  https://review.openstack.org/39903617:05
dansmithjohnthetubaguy: see if those explanations make sense17:05
*** jpena|off is now known as jpena17:05
dansmithjohnthetubaguy: sorry for saying this was simple. I've factored out all the complexity of "why" in my head I guess :)17:05
johnthetubaguydansmith: will take a peak, was just looking at next one17:05
*** bkopilov has quit IRC17:05
johnthetubaguydansmith: heh, no worries17:05
johnthetubaguydansmith: in that follow up, I saw a comment about 404 if nova-api service minimum version < 15, can't we avoid that?17:06
dansmithjohnthetubaguy: let me refresh my memory but I don't think we can17:07
mriedemvladikr: ok i see how InstanceMetadata.metadata_for_config_drive is called from the config drive builder in the virt driver,17:07
mriedemso it should work,17:07
mriedembut i'm wondering why we have the explicit _build_device_metadata stuff in the libvirt driver then for device tags?17:07
dansmithjohnthetubaguy: oh that's in a piece that is already merged right?17:08
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Clarify description for tags  https://review.openstack.org/42474517:08
artommriedem, we need it for the metadata API, but I agree that it's a weird place to put it17:08
dansmithjohnthetubaguy: actually, I'm not sure which of the version<15 checks you're talking about.. linky?17:09
melwittdansmith: I think he means this https://review.openstack.org/#/c/319379/73/nova/tests/functional/integrated_helpers.py@22617:09
*** markmcclain has quit IRC17:09
johnthetubaguydansmith: yeah, https://review.openstack.org/#/c/319379/73/nova/tests/functional/integrated_helpers.py@22817:10
melwittthat is, immediately after requesting a boot you could assume the instance exists before. but with the move to conductor, you can't17:10
mriedemartom: vladikr: oh i see, so we build the device metadata in the virt driver and store that on instance.device_metadata, which the metadata API uses to build the md json for the config drive17:10
*** ducttape_ has joined #openstack-nova17:10
johnthetubaguyI thought we would return it in the API list, because the uuid would be in the cell mapping table to avoid that17:10
dansmithohg that17:10
melwittyeah, I mean wouldn't we have the build request to create the instance from with the new stuff?17:10
artommriedem, we have to build the device metadatain (or at least from) the virt driver because only it knows the hardware metadata like devices addresses17:11
*** markmcclain has joined #openstack-nova17:11
artommriedem, but I don't think the metadata API builds anything for the config drive...17:11
vladikrartom is typing much faster :)17:11
dansmithjohnthetubaguy: melwitt good question, that might've been an early attempt by avolkov to address the sync spawn thing, lemme check17:11
artomWhen the config drive builds itself (for lack of a better work) it gets the instance metadata on its own17:11
*** cdelatte has quit IRC17:11
artomvladikr, jinx ;)17:11
*** dave-mccowan has quit IRC17:11
melwittdansmith: yeah, I would think we don't need that change because we should be getting the same behavior as before via build request17:12
mriedemartom: well it's used here v17:12
mriedemhttps://github.com/openstack/nova/blob/45e79583cea3a87df931c7333bf3c82de2979105/nova/virt/configdrive.py#L6917:12
dansmithmelwitt: yeah, I dunno, I'll try removing it17:12
mriedemand i suppose we persist instance.device_metadata later in the compute manager when it calls instance.save()17:12
mriedemso that later metadata API requests (when not using config drive) can retrieve the device tags17:13
dansmithjohnthetubaguy: I would think that if it's really an api thing we'd be failing tempest17:13
johnthetubaguydansmith: yeah, +117:13
*** sudipto_ has quit IRC17:14
*** sudipto has quit IRC17:14
artommriedem, ah, didn't know about metadata_for_configdrive17:14
artomThen yeah, the metadata service (not API surely?) builds the metadata for the config drive17:14
sfinucanvladikr, sahid: Could ye take a look at https://review.openstack.org/#/c/370374 at some point? I think it looks good but I'd like more opinions and moshele is offline17:14
artommriedem, the instance.save() part is I think just lucky, because when coding the tagged attached stuff I don't recall ever seeing it in the existing code17:15
openstackgerritMatthew Booth proposed openstack/nova: libvirt: Fix races in glusterfs mount/umount  https://review.openstack.org/42340217:15
artomFor attach I have to call it explicitly17:15
vladikrsfinucan, sure17:15
dansmithjohnthetubaguy: sfinucan: so for that flag set in the api_samples patch, all I can think of as a comment to help is:17:15
openstackgerritStephen Finucane proposed openstack/nova: pci: Validate behavior of empty devname  https://review.openstack.org/39613017:15
dansmithjohnthetubaguy: sfinucan: "Default our global database connection info to be the first cell for any non-cells-aware code"17:15
mriedemartom: yeah after driver.spawn(), the compute manager changes the state to ACTIVE on the instance and calls instance.save()17:15
gibimriedem: I think I have solution for the randomly failing notification sample functional test https://review.openstack.org/#/c/424574/17:15
dansmithjohnthetubaguy: sfinucan: would that help?17:15
mriedemso anything the virt driver changed on the instance during spawn is going to get persisted with that17:15
sfinucanvladikr: Cheers. No panic, mind - VLAN stuff take priority17:16
johnthetubaguydansmith: that would work for me I think17:16
dansmithjohnthetubaguy: ack17:16
*** sahid has quit IRC17:16
artommriedem, cool - not sure if that was intentional on our part to not call save() from the virt drive to save on DB requests, but glad that it works :D17:16
* dansmith notes he started toast toasting an hour ago17:17
artom(toast)^2ing17:18
*** ducttape_ has quit IRC17:20
mdboothsfinucan: ^^^ TODO'd btw17:22
* sfinucan looks17:22
mdboothdansmith: I was trying to reference something the other day which says that reboot() has a secondary function of 'try to fix all the hypervisor things'.17:23
mdboothAre you aware of anything?17:23
dansmithmdbooth: um, what?17:24
mdboothdansmith: I'm guessing that a no ;)17:24
dansmithheh17:24
openstackgerritBalazs Gibizer proposed openstack/nova: Fix race condition in instance.update sample test  https://review.openstack.org/42457417:24
mdboothSo, when you reboot an instance we rewrite the domain xml and recreate backing files which should already exist.17:24
mdboothcburgess: ^^^17:24
mdboothAnyway, this is very messy and sahid proposed a patch to remove it. However, if this is operator-expected behaviour then we can't do that without replacement.17:25
*** dtp has joined #openstack-nova17:25
gibimriedem: thanks for the quick review. I've fixed your comments17:26
openstackgerritArtom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.32 and 2.37  https://review.openstack.org/42475917:31
* artom WIPs up some fixes to the tag disappearing and continues with the functional tests17:31
dansmithjohnthetubaguy: melwitt: confirmed, that integrated helpers hack isn't needed17:33
melwittcool, good catch johnthetubaguy17:33
johnthetubaguyit was jst that comment that made my eyes pop out a little17:33
melwittheh17:34
johnthetubaguydansmith: I am missing why we need to call _validate_bdm twice in there, are there more accurate instance details the second time around?17:34
*** baoli has joined #openstack-nova17:35
sfinucanmdbooth: and +2'd17:35
*** mjura has quit IRC17:35
johnthetubaguydansmith: thinking about: https://review.openstack.org/#/c/319379/73/nova/compute/api.py@122717:35
dansmithjohnthetubaguy: see the comments in there. we previously figured out that we do need to do that, but we don't remember why. so I've stacked a patch on the end we can experiment with17:35
melwittjohnthetubaguy: I pointed that out too, and I remember dansmith, mriedem and I all dug into once on a different review. but I can't remember what review it was so we can look at it17:35
johnthetubaguydansmith: melwitt: ah, gotcha, sorry, didn't check the history around that bit17:36
openstackgerritDan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2  https://review.openstack.org/42473717:36
openstackgerritDan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation  https://review.openstack.org/42471917:36
openstackgerritDan Smith proposed openstack/nova: Make api_samples tests use simple cell environment  https://review.openstack.org/41047317:36
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937917:36
dansmithjohnthetubaguy: np, good eye :)17:36
mriedemwasn't it the object copy thing?17:36
dansmithmelwitt: johnthetubaguy: comment added on the first, and that hack removed from the second ^17:36
melwittmriedem to the rescue17:37
mriedemit was avolkov's patch17:37
*** tjones has joined #openstack-nova17:37
dansmithmriedem: yeah, but we must have discussed on irc17:37
mriedemi thought we had captured the conversation in the review too17:38
*** amotoki has quit IRC17:38
mriedemi don't remember the context on the object copy thing now either17:38
*** cdelatte has joined #openstack-nova17:38
johnthetubaguyits odd how we update the BDM, after the initial validate, duno if thats related: https://github.com/openstack/nova/blob/065cd6a8d69c1ec862e5b402a3150131f35b2420/nova/compute/api.py#L130217:39
melwittI thought we discussed on the review too17:39
mriedemhttps://review.openstack.org/#/c/374267/ is the patch i'm thinking of fwiw17:40
melwittyep that's the one17:40
melwittlet's see if we recorded the detail of what's going on there17:40
*** cdent has quit IRC17:41
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type  https://review.openstack.org/42425617:41
mriedemhttps://review.openstack.org/#/c/374267/21/nova/compute/api.py@119717:41
*** belmoreira has quit IRC17:42
*** ducttape_ has joined #openstack-nova17:43
melwittnice17:43
*** derekh has quit IRC17:44
*** claudiub|2 has joined #openstack-nova17:44
*** mvk has joined #openstack-nova17:44
*** d34dh0r53 is now known as ID-Ten-T17:45
sfinucandansmith: Yeah, that comment WFM too. Re-reviewing now17:46
dansmithsfinucan: cool17:46
*** claudiub has quit IRC17:46
*** hieulq_ has quit IRC17:46
pawHi, how do you specify a microversion for nova/api? I'm trying to test some interoperability issue. Thanks.17:47
*** ID-Ten-T is now known as blarnath17:48
*** annegentle has quit IRC17:48
*** ijw has joined #openstack-nova17:48
*** ijw has quit IRC17:48
*** blarnath is now known as d34dh0r5317:48
artompaw, in the client? --os-compute-api-version=2.4017:49
*** ijw has joined #openstack-nova17:49
pawas in the python-novaclient?17:49
*** dave-mccowan has joined #openstack-nova17:50
pawaries: confirmed. thanks17:50
artompaw, that option I gave is for the client, yes - both novaclient and openstackclient accept I think17:50
pawartom: thanks17:51
artompaw, you're welcome :)17:51
openstackgerritDan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2  https://review.openstack.org/42473717:52
dansmithjohnthetubaguy: gdi.17:52
openstackgerritDan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation  https://review.openstack.org/42471917:52
openstackgerritDan Smith proposed openstack/nova: Make api_samples tests use simple cell environment  https://review.openstack.org/41047317:52
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937917:52
*** Sukhdev has joined #openstack-nova17:52
dansmithjohnthetubaguy: I don't know what to do in a world where _you_ are finding _my_ typos :P17:52
*** tblakes has quit IRC17:55
johnthetubaguydansmith: its a very crazy day!17:55
dansmithheh17:55
cburgessmdbooth Yes correct. An in general do anything we can to make sure the VM comes up.17:56
cburgessmdbooth Think of it as a check list of what can we do to attempt to fix *anything* that might be wrong.17:56
*** karimb has quit IRC17:56
*** jose-phillips has joined #openstack-nova17:56
melwittfrom what I can tell, I don't see why we would need the second _validate_bdm call. it doesn't seem to do anything except check things17:57
*** a-pugachev has quit IRC17:57
melwittin that other patch where we discussed the double validation, it was more than that, it was two calls of the self._bdm_validate_set_size_and_instance function, which does more17:58
*** nvela has joined #openstack-nova17:58
dansmithmelwitt: well, lets see if we get a full run of the wip patch18:00
* melwitt nods18:00
mriedemwell i'm going to call it a morning and head out for awhile, i'm already in trouble18:01
melwitto/18:01
*** ralonsoh has quit IRC18:02
dansmithmriedem: thanks18:02
*** krtaylor has quit IRC18:02
openstackgerritSarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client.  https://review.openstack.org/41263418:02
*** Apoorva has joined #openstack-nova18:03
*** ijw has quit IRC18:04
*** amotoki has joined #openstack-nova18:04
*** ijw has joined #openstack-nova18:05
*** ijw has quit IRC18:05
openstackgerritSarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client.  https://review.openstack.org/41263418:05
*** ijw has joined #openstack-nova18:05
*** amotoki has quit IRC18:06
*** bvanhav__ has joined #openstack-nova18:07
*** bvanhav_ has quit IRC18:07
*** tblakes has joined #openstack-nova18:09
*** Swami has joined #openstack-nova18:10
*** bkopilov has joined #openstack-nova18:12
*** annegentle has joined #openstack-nova18:13
*** rfolco has quit IRC18:14
*** mfeoktistov has joined #openstack-nova18:14
*** cdent has joined #openstack-nova18:15
*** markus_z has quit IRC18:16
*** sean-k-mooney has quit IRC18:16
*** sean-k-mooney has joined #openstack-nova18:17
*** efoley_ has quit IRC18:17
*** annegentle has quit IRC18:18
*** aarefiev is now known as aarefiev_afk18:18
*** chyka has joined #openstack-nova18:20
*** ducttape_ has quit IRC18:21
*** ducttape_ has joined #openstack-nova18:21
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged nic attachment  https://review.openstack.org/41562218:22
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged volume attachment  https://review.openstack.org/41810018:22
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged volume attachment  https://review.openstack.org/39194118:22
openstackgerritArtom Lifshitz proposed openstack/nova: API support for tagged device attachment  https://review.openstack.org/37602118:22
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged nic attachment  https://review.openstack.org/41552018:22
*** sambetts is now known as sambetts|afk18:22
*** hfu has joined #openstack-nova18:24
*** ducttape_ has quit IRC18:26
*** hamzy has joined #openstack-nova18:27
*** rfolco has joined #openstack-nova18:28
openstackgerritSTEW TY proposed openstack/nova: Transform instance.resize_confirm notification  https://review.openstack.org/39065418:28
*** mriedem has quit IRC18:29
openstackgerritGábor Antal proposed openstack/nova: Remove mox in unit/cells/test_cells_manager.py  https://review.openstack.org/39903618:29
*** dave-mccowan has quit IRC18:30
*** pbandark has quit IRC18:30
*** sdague has quit IRC18:33
*** jwcroppe_ has joined #openstack-nova18:34
openstackgerritArtom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.32 and 2.37  https://review.openstack.org/42475918:36
*** jwcroppe has quit IRC18:37
*** jwcroppe_ has quit IRC18:38
*** tesseract has quit IRC18:39
*** Sukhdev has quit IRC18:43
*** krtaylor has joined #openstack-nova18:44
*** hfu has quit IRC18:44
*** bvanhav__ has quit IRC18:45
*** jpena is now known as jpena|off18:46
*** hfu has joined #openstack-nova18:46
*** moshele has joined #openstack-nova18:46
*** hfu has quit IRC18:46
*** Sukhdev has joined #openstack-nova18:47
*** adisky_ has quit IRC18:49
*** moshele has quit IRC18:50
*** bvanhav__ has joined #openstack-nova18:50
*** yamahata has joined #openstack-nova18:53
*** kfarr has quit IRC18:55
*** sdague has joined #openstack-nova18:55
*** dave-mccowan has joined #openstack-nova18:57
*** swamireddy has quit IRC18:58
*** Sukhdev has quit IRC19:01
*** slaweq has quit IRC19:04
*** slaweq has joined #openstack-nova19:06
*** belmoreira has joined #openstack-nova19:07
*** belmoreira has quit IRC19:07
*** ducttape_ has joined #openstack-nova19:11
*** karts has joined #openstack-nova19:12
*** karthiks has quit IRC19:15
*** ducttape_ has quit IRC19:15
*** lpetrut has quit IRC19:16
cdentbauzas: in your (not so) copious free time, you might find this bug fix to the resource tracker interesting: https://review.openstack.org/#/c/424305/19:17
*** sdague has quit IRC19:18
*** alexpilotti has quit IRC19:18
*** alexpilotti has joined #openstack-nova19:19
*** Oku_OS is now known as Oku_OS-away19:20
openstackgerritDan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2  https://review.openstack.org/42473719:20
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937919:20
*** alexpilo_ has joined #openstack-nova19:22
*** eharney has quit IRC19:22
dansmithmelwitt: johnthetubaguy: okay I think I can just nuke the extra validate, so I did ^19:22
*** alexpilotti has quit IRC19:23
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: DO NOT MERGE: experiment  https://review.openstack.org/42480919:24
*** ducttape_ has joined #openstack-nova19:26
*** alexpilo_ has quit IRC19:27
*** owalsh-afk has quit IRC19:27
*** ijw has quit IRC19:28
*** owalsh-afk has joined #openstack-nova19:30
*** sdague has joined #openstack-nova19:31
*** jdurgin1 has quit IRC19:33
artomWell crap, how does a vif in network_info end up with a vlan? I'm working on the tempest test for https://review.openstack.org/#/c/405951/ and the only way I've found to set a vlan on a Neutron network is to use provider:segmentation_id, but that required provider:network_type to be vxlan and for me to be an admin19:34
*** sdague has quit IRC19:36
*** eharney has joined #openstack-nova19:37
openstackgerritStephen Finucane proposed openstack/nova: objects: add new field cpuset_reserved in NUMACell  https://review.openstack.org/40087419:38
*** smatzek has quit IRC19:40
*** tbachman has quit IRC19:40
*** harlowja has joined #openstack-nova19:41
dansmithjohnthetubaguy I think this is good to go now: https://review.openstack.org/#/c/410473/19:42
*** Sukhdev has joined #openstack-nova19:49
*** ijw has joined #openstack-nova19:49
*** ijw has quit IRC19:54
openstackgerritVladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata  https://review.openstack.org/40595119:54
openstackgerritSTEW TY proposed openstack/nova: Transform instance.resize_revert notification  https://review.openstack.org/39681119:55
*** flaper87 has joined #openstack-nova19:59
*** rfolco has quit IRC20:00
bauzasdansmith: cdent: I could probably need some help for my grenade change20:02
bauzashttp://logs.openstack.org/30/424730/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/15ad17c/logs/grenade.sh.txt.gz#_2017-01-24_17_11_42_86220:02
* cdent looks20:03
*** armax_ is now known as armax20:03
*** alexpilotti has joined #openstack-nova20:03
bauzascdent: we need to deploy the placement engine by grenade20:03
bauzasgiven the newton devstack doesn't deploy yet the placement service20:04
dansmithbauzas: you're not sourcing something that brings in the base variable I imagine20:05
cdent$FILES is not defined, looks like it is usually defined by stack.sh20:05
bauzasmmm ok20:05
* bauzas looking where FILES is provided20:06
dansmithlooks like in stack.sh20:06
dansmithso define it in there before you call those methods20:06
dansmith$TOP_DIR/files20:06
cdentbauzas: see upgrade-tempest for an example20:08
cdentbauzas: and/or projects/30_swift/upgrade.sh20:08
bauzascdent: roger20:08
cdentlooks like those use $TARGET_DEVSTACK_DIR/files20:09
bauzasdansmith: I guess I can deploy grenade on my local devstack for testing ?20:11
dansmithif you're really really lucky :)20:11
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/42482820:11
bauzasdansmith: you mean it's difficult?20:12
dansmithbauzas: I mean I often have issues20:13
cdentbauzas: I agree with dansmith: I often have issues, and in addition it takes forever to reach those issues, at which point you throw your hands up in the air20:14
dansmithyeah20:14
bauzasokay, so let's hit the gate...20:14
*** smatzek has joined #openstack-nova20:15
*** slaweq has quit IRC20:17
*** moshele has joined #openstack-nova20:18
*** lennyb has quit IRC20:18
*** slaweq has joined #openstack-nova20:19
*** sdague has joined #openstack-nova20:20
*** READ10 has quit IRC20:21
*** karimb has joined #openstack-nova20:25
*** sdague has quit IRC20:26
*** vsaienko has joined #openstack-nova20:28
*** tbachman has joined #openstack-nova20:31
*** aojea has quit IRC20:31
*** xyang1 has joined #openstack-nova20:36
amrithandreykurilin, the patch to requirements repo has come down to trove via the req bot. I've dep'ed your change on that. Hope that's what you intended.20:37
*** slaweq has quit IRC20:39
*** sdague has joined #openstack-nova20:40
*** slaweq has joined #openstack-nova20:41
*** oanson has quit IRC20:41
andreykurilinamrith: everything should work now in trove20:42
andreykurilinwithout my patch20:42
*** oanson has joined #openstack-nova20:42
*** aojea has joined #openstack-nova20:44
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type  https://review.openstack.org/42425620:45
amrithandreykurilin, cool. in that case I'm going to announce my retirement and move to a beach somewhere where it is warm.20:45
amrith:)20:46
andreykurilinheh20:46
amriththanks andreykurilin I very much appreciate your help with this set of changes.20:46
andreykurilinamrith: I'll return to them with new novaclient 7.1.0 :) but I'll try to do it before breaking gates20:47
amrithOK, and I'll propose some of the tests that I mentioned this morning against head of nova20:47
andreykurilinamrith: it will be cool, thanks20:48
openstackgerritSTEW TY proposed openstack/nova: Transform instance.resize_revert notification  https://review.openstack.org/39681120:51
*** bvanhav__ has quit IRC20:54
*** karimb has quit IRC20:54
*** moshele has quit IRC20:57
*** _ducttape_ has joined #openstack-nova20:57
*** gcb has joined #openstack-nova21:01
*** kaisers_ has quit IRC21:01
*** ducttape_ has quit IRC21:01
*** jerrygb_ has joined #openstack-nova21:01
openstackgerritDan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2  https://review.openstack.org/42473721:01
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937921:01
*** kaisers has joined #openstack-nova21:02
*** jerrygb has quit IRC21:03
*** jerrygb_ has quit IRC21:04
*** tjones has quit IRC21:04
*** vsaienko has quit IRC21:05
*** alexpilotti has quit IRC21:08
*** satyar has quit IRC21:08
*** alexpilotti has joined #openstack-nova21:08
*** ijw has joined #openstack-nova21:10
*** dave-mccowan has quit IRC21:10
*** lpetrut has joined #openstack-nova21:10
*** spligak has joined #openstack-nova21:11
*** mriedem has joined #openstack-nova21:11
*** sacharya has quit IRC21:12
mriedemi hope my insurance covers a bad case of sand crack21:12
*** alexpilotti has quit IRC21:13
*** sacharya has joined #openstack-nova21:14
*** sdague has quit IRC21:14
cdentget some talcum powder on that ass21:15
*** dimtruck is now known as zz_dimtruck21:15
*** pradk has quit IRC21:16
*** gszasz has quit IRC21:18
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: DO NOT MERGE: check OSC  https://review.openstack.org/42094121:19
*** vsaienko has joined #openstack-nova21:21
*** pradk has joined #openstack-nova21:23
mriedemvladikr: so i was thinking about vlan vifs and tempest testing, we probably don't have any jobs that use vlan tags on ports do we?21:23
*** READ10 has joined #openstack-nova21:28
*** kaisers has quit IRC21:29
*** kaisers_ has joined #openstack-nova21:29
cdentbauzas: your grenade run has just finished21:29
bauzascdent: yup, was following21:29
cdenton the old side it looks like placement auth isn't in place: http://logs.openstack.org/30/424730/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/6ccea97/logs/old/screen-n-cpu.txt.gz#_2017-01-24_20_36_57_93721:30
bauzascdent: that's for the full grenade job right?21:30
bauzascdent: if so, I think it's not a problem21:31
cdentOh, is it just changed for one of the jobs not all?21:31
bauzascdent: I was rather looking at the multinode job21:31
bauzascdent: I provided a from-newton script21:31
bauzascdent: so it's not changing the old side AFAICU21:32
cdentah, I follow now21:32
bauzascdent: that said, I'd like to see the old compute calling the new scheduler by grenade21:33
bauzascdent: so IIUC it's the multinode job21:33
bauzasbut maybe dansmith can insight?21:33
bauzasI think I'm also starting the placement engine for any node, including a specific compute only21:34
*** vsaienko has quit IRC21:34
*** Jeffrey4l_ has joined #openstack-nova21:34
cdentbauzas: I've got to call it a night, but if there's something I can do to help out tomorrow morning leave me a note somewhere (email or here is fine)21:34
bauzascdent: I'm just rechecking the scheduler change21:34
* cdent waves goodnight21:34
bauzascdent: for seeing if it's now happy21:35
bauzascdent: sure21:35
*** catintheroof has quit IRC21:35
*** cdent has quit IRC21:35
*** Jeffrey4l has quit IRC21:35
*** catintheroof has joined #openstack-nova21:35
*** catintheroof has quit IRC21:35
*** _ducttape_ has quit IRC21:37
dansmithbauzas: from-$release only runs on the main node AFAK21:37
*** zz_dimtruck is now known as dimtruck21:37
*** ducttape_ has joined #openstack-nova21:37
bauzasdansmith: I replied to you on the ML thread about optional resources21:38
bauzasdansmith: have you seen my other emails ?21:38
dansmithyeah21:38
*** ducttape_ has quit IRC21:38
bauzasand why I think it's understandable, I think asking that for Ocata seems difficult to me21:39
bauzasthe gate itself is even not running DiskFilter...21:39
bauzasoops21:39
bauzasCoreFilter I meant21:39
*** ducttape_ has joined #openstack-nova21:39
bauzasand we also have an assertion that says amount can't be 0 - but we have a lot of flavors having root_gb=021:39
bauzasso what should I ask for if a flavor is set to root_gb=0 for example ?21:40
bauzasI mean, I totally understand jaypipes's opinion about why it's a wrong direction21:41
bauzasI just think it's not something we should stop by Ocata21:41
cburgessdansmith: If I have an instance object (returned from novaclient) is there an easy way to refresh the status and task_status from the DB? Or do I have to do a full server.get() again?21:42
dansmithcburgess: you don't get instance objects back from novaclient, you get a dict.. so yeah, you have to .get() again21:43
cburgessOK well not from the DB since clearly it has to make an API call since I'm using novaclient. I mean do you just get it again or is there some swanky built-in to refresh it?21:43
cburgessOh ok..21:43
bauzasdansmith: saw my points above ?21:44
cburgessHmm weird.. its got methods defined on it, but I get your point. I'll re-fetch it.21:44
dansmithbauzas: yes, I've read your emails and the points above, I'm not sure what to say and I'm frantically trying to get other work done21:44
dansmithbauzas: it's just MHO21:44
*** kaisers has joined #openstack-nova21:45
bauzasdansmith: okay again, I don't disagree with both of you21:45
bauzasdansmith: I'm just trying to be pragmatic21:45
*** kaisers_ has quit IRC21:48
vladikrmriedem, sorry I was away.. Yes, I didn't find any jobs that uses vlans21:49
vladikrmriedem, also, in order to test it, we need something that will set the {binding:{details:{vlan: X}}}21:50
vladikrmriedem, which is not available for all vnic types21:51
mriedemvladikr: right that's what got me thinking about it21:51
mriedemif we don't have a job that sets the vlan tag on the port details,21:51
mriedemthen any tempest test for checking it probably isn't going to do anything21:52
vladikrmriedem, I'm still looking for how to do it.. artom is helping as well (took a break to pickup the kids though) - but I don't know if it's all possible21:53
mriedemvladikr: if the vif details don't have a vlan tag, do we not put anything into the metadata json response? if we always have something in there for vlan tags, even if it's just None or [], we could check for that21:54
vladikrmriedem, if we don't have anything in the binding we just skip the device (unless it has tags)21:55
*** thorst_ has quit IRC21:55
*** gszasz has joined #openstack-nova21:55
mriedembauzas: replied to your thread with a question/clarification21:58
*** breitz has quit IRC21:59
*** breitz has joined #openstack-nova22:00
*** kaisers_ has joined #openstack-nova22:01
*** amotoki has joined #openstack-nova22:02
*** kaisers__ has joined #openstack-nova22:02
bauzasmriedem: I think your clarification works with me22:03
bauzasmriedem: I'm not only worried by CDs like TripleO22:03
bauzasmriedem: I'm more worried of people trying to change their cloud because we decided so without a warning cycle22:03
*** READ10 has quit IRC22:04
*** kaisers__ has quit IRC22:04
bauzasin general, we try to first notice them for a cycle and do the cut on the next one22:04
*** kaisers has quit IRC22:04
bauzashere, if you're not changing your cloud before upgrading, you won't get any failure but the scheduler won't work like you set it previosuly22:05
*** kaisers has joined #openstack-nova22:05
bauzasso I'm pretty sure lots of folks will be confused then22:05
*** kaisers_ has quit IRC22:05
bauzasthat said, I'm still having 2 concerns22:05
mriedembauzas: well you should be reading the release notes before upgrading22:06
bauzasmriedem: I know22:06
bauzasmriedem: and I'm all in favor of that22:06
bauzasbut for example, take the flavor root_gb=022:06
bauzaspeople do that for avoiding having issues with shared volumes, right?22:07
bauzasI know we're going to help them with the aggregates BP22:07
bauzasbut for the moment, they still have flavors set with that zero size22:07
mriedemwe account for that in the RT don't we?22:07
mriedem*scheduler report client22:08
mriedemfor disk inventory22:08
bauzasmriedem: but what should we ask to the PlacementAPI if the flavor is 0 ?22:08
*** baoli has quit IRC22:08
bauzasmriedem: eg. https://review.openstack.org/#/c/417961/22/nova/scheduler/filter_scheduler.py@16422:08
mriedemlooking at https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L12922:09
*** tblakes has quit IRC22:09
mriedemit looks like we wouldn't include the DISK_GB resource class if the flavor is 0 root_gb22:09
mriedembauzas: yeah what you have in there looks correct22:10
bauzasmriedem: because we don't accept an amount of 022:10
bauzasin the PlacementAPI22:10
bauzasanyway, my thoughts are: we all agree it's bad to disable those filters22:11
bauzaspeople should rather use allocation ratios22:11
bauzasand that, we all agreed multiple times in the past22:11
*** aojea has quit IRC22:12
bauzaswhat I'm advocating is a certain deprecation window for operators22:12
bauzasasking them to make sure they set correct allocation ratios to their computes22:12
bauzasthat could be infinite22:12
bauzasthat's where I want to be pragmatic22:13
mriedemi personally don't have a problem with that, if we're deprecating the Core/RAM/Disk filters at the same time22:13
mriedemthe thing is,22:13
mriedemif we mark those as deprecated, people will probably remove them from their enabled_filters list22:13
mriedemwhich then gets them into this situation where we don't request VCPU and log a warning saying you don't have the CoreFilter in enabled_filters22:13
mriedemso it gets weird22:13
amrithmriedem, andreykurilin I see that the requirements change has blocked novaclient 7.0.022:14
amrithis there a new client version coming?22:14
mriedemamrith: working on it22:14
amrithok, thx mriedem22:14
bauzasmriedem: the fact with those legacy filters is that johnthetubaguy pointed out that CachingScheduler still needs them22:15
mriedemok so we can't deprecate them,22:15
bauzasmriedem: so I haven't targeted to deprecate them22:15
bauzasexactly22:15
mriedemand if CoreFilter isn't in the enabled_filters list for the filter scheduler, it's going to log a warning?22:16
bauzaswhy so?22:16
*** smatzek has quit IRC22:16
dansmithmriedem: we have to account for swap and ephemeral in DISK_GB, remember..22:16
mriedembecause long-term we don't want to rely on that22:16
mriedembauzas: i'm trying to figure out at what point this becomes an error,22:16
mriedemand how you plan to signal that22:16
bauzasmriedem: I was rather thinking of the contrary22:18
bauzasmriedem: ie. signal that by Pike you shouldn't use the legacy filters *if and only if you run the FilterScheduler*22:18
*** eharney has quit IRC22:18
*** baoli has joined #openstack-nova22:19
mriedemwhich means removing CoreFilter from the enabled_filters list right?22:19
bauzasmriedem: yup22:19
bauzasideally, deployers should stop having the CoreFilter set by Pike22:20
bauzasunless they use another scheduler driver22:20
mriedemand when you make that a hard requirement, you'll remove any conditional check on the CoreFilter such that you're always requesting VCPU filtering of RPs in the filter scheduler?22:20
bauzasyup22:20
bauzaspeople in general don't disable all three legacy filters22:21
bauzasso they would still get a warning for at least one22:21
mriedemstill,22:21
mriedem"ideally, deployers should stop having the CoreFilter set by Pike"22:21
mriedemso at runtime in Ocata, are you going to log a warning if CoreFilter is in enabled_filters?22:21
bauzasmriedem: that's not part of my change yet but I could do that22:22
mriedembut if you do that,22:22
mriedemit means, 'remove CoreFilter from enabled_filters before pike'22:22
mriedemwhich also means, you don't get an VCPU filtering with RPs in the filter scheduler22:22
mriedemso it's a catch-2222:22
bauzasmmm good point22:22
mriedems/an/any/22:22
bauzaslemme reconsider that22:23
bauzasokay, so your option22:23
bauzaswithin the FilterScheduler, log a warning if one of the 3 filters is disabled22:23
*** tbachman has quit IRC22:23
bauzasthat's for Ocata22:24
*** aojea has joined #openstack-nova22:24
*** baoli has quit IRC22:24
bauzasso people would need to change their ratios for that during Ocata and enable the filter in Ocata22:24
bauzasnow, in Pike we would assume that all clouds have those 3 filters enabled and we would remove the conditionals I just wrote22:25
*** karimb has joined #openstack-nova22:25
bauzashonestly, I dunno22:26
*** owalsh-afk is now known as owalsh22:26
bauzasmaybe it's because it's becoming late to me and my brain is fried22:26
*** krtaylor has quit IRC22:27
*** alexpilotti has joined #openstack-nova22:27
bauzasdansmith: FWIW, devstack uses the flavor #42 which is having both root, ephemeral and swap set to 022:27
mriedemenabling the filters just to say, 'don't do this b/c we're going to stop caring about them for the filter scheduler' is very weird22:28
*** tbachman has joined #openstack-nova22:28
bauzasmriedem: I agree, that doesn't sound a great plan22:28
dansmithbauzas: yeah, I know.. I'm not sure what root=0 has to do with this discussion at all22:29
bauzasdansmith: https://review.openstack.org/#/c/417961/22/nova/scheduler/filter_scheduler.py@16422:30
*** tblakes has joined #openstack-nova22:30
mriedembauzas: those are different issues,22:30
*** baoli has joined #openstack-nova22:32
*** alexpilotti has quit IRC22:32
openstackgerritSteven Webster proposed openstack/nova: Release PCI devices on drop_move_claim()  https://review.openstack.org/37037422:32
mriedembauzas: given the retarded dance we'd have to come up with just to say this stuff is changing, i think i'd prefer to just always request VCPU/RAM/DISK_GB as outlined in the spec and make it clear in the release notes that if you didn't have those filters enabled before, you need to adjust for that with allocation ratios now before upgrading to ocata22:34
mriedembauzas: and as dansmith said, we could also work that into the nova-status upgrade check22:34
*** Guest86718 has quit IRC22:35
*** karts has quit IRC22:35
bauzasmriedem: okay, I then need to hurry up to change a few more things22:36
bauzasand hope nobody won't complain too much22:36
*** baoli has quit IRC22:36
mriedembauzas: and then reply to the ML thread signing away your consent22:37
bauzasmriedem: tbc, I won't have the bandwidth for the nova-status check22:37
bauzasmriedem: neither me notifying the operators they have to move on22:38
mriedembauzas: i can do nova-status22:38
bauzasfor what I see, I only have 1.5 day left for changing at least a couple of tests22:38
bauzasat least some of the functional tests22:38
* mriedem overnights some meth to bauzas22:38
bauzasmriedem: you're on vacation, remember :)22:38
*** marst_ has quit IRC22:39
bauzasmriedem: well, I don't have a RV for that22:39
*** moshele has joined #openstack-nova22:40
mriedemjaypipes: how are things looking for this last patch in the resource classes series? https://review.openstack.org/#/c/404472/22:43
bauzassooooo, the grenade change didn't help the scheduler change22:43
bauzasI'm depressed22:43
*** lpetrut has quit IRC22:44
*** owalsh_ has joined #openstack-nova22:44
mriedemjaypipes: er i guess it's no longer the last change in the series22:44
*** alexpilotti has joined #openstack-nova22:45
bauzaslet's be clear, given the grenade problem, I'm not feeling we could merge https://review.openstack.org/#/c/417961 by Ocata22:46
bauzasanyway22:46
bauzasI'll need to bail out for the night or I'm doomed22:46
*** owalsh has quit IRC22:47
*** karts has joined #openstack-nova22:47
bauzasso in case folks have a bit of interest about https://review.openstack.org/#/c/417961 and are knowing grenade, feel free to help22:47
*** burgerk__ has joined #openstack-nova22:48
*** esberglu has quit IRC22:48
*** esberglu has joined #openstack-nova22:48
*** alexpilotti has quit IRC22:49
*** david-lyle has quit IRC22:50
*** burgerk_ has quit IRC22:51
*** owalsh_ is now known as owalsh22:51
*** dimtruck is now known as zz_dimtruck22:52
*** esberglu has quit IRC22:53
*** david-lyle has joined #openstack-nova22:53
*** tblakes has quit IRC22:53
andreykurilinstevemar: please, put W-1 at https://review.openstack.org/#/c/424847/1 . It breaks novaclient's gates22:54
andreykurilin:(22:54
*** burgerk__ has quit IRC22:54
*** mdrabe has quit IRC22:54
andreykurilinit looks like we need to bump openstacksdk and openstackclient versions together22:54
mriedemandreykurilin: reminder on https://review.openstack.org/#/c/418190/ in case you have to use it22:55
*** alexpilotti has joined #openstack-nova22:55
stevemarandreykurilin: that'll blow the requirements teams minds22:55
mriedemonly thing on ^ is we'd have to cleanup the commit message22:55
*** alexpilotti has quit IRC22:56
stevemarmriedem: fi-lgtm22:56
*** alexpilotti has joined #openstack-nova22:56
stevemarandreykurilin: i rebased it, should be bumped out of the gate (don't think it even got that far)22:57
dansmithbauzas: it's not starting the placement api, looks like22:57
dansmithbauzas: I see no placement-api log22:57
stevemarandreykurilin: how would bumping OSC min solve the issue?22:57
andreykurilinmriedem: but why we have multiple networks with latest openstacksdk and do not have them with old version?22:58
*** edmondsw has quit IRC22:58
*** alexpilo_ has joined #openstack-nova22:59
mriedemandreykurilin: because the sdk broke the filtering on available networks :)22:59
*** xyang1 has quit IRC22:59
andreykurilinmriedem: oh22:59
*** moshele has quit IRC22:59
mriedemat least i think that's what kevinbenton found when he looked at that issue before23:00
mriedemhis notes are in that patch23:00
stevemarandreykurilin: mriedem can we just get the nova functional tests working with the newer version?23:00
andreykurilinmriedem: can you update commit message?23:00
stevemari guess that's what https://review.openstack.org/#/c/418190/ does23:00
mriedemstevemar: well shouldn't that be a major version bump on the sdk?23:00
stevemarmriedem: they have a stance that since they are pre 1.0 they are allowed to break compatibility23:01
*** alexpilotti has quit IRC23:01
stevemarmriedem: like how gmail was in beta for a decade23:02
mriedemstevemar: jesus h c23:02
stevemarosc and senlinclient *need* the latest version23:02
bauzasdansmith: roger, I'll try to investigate tomorrow morning but I'm just exhausted23:02
andreykurilinstevemar: I'm ok to merge mriedem fix for our gates and then look at the process of merging g-r update. I do not want to see g-r update at first, since we need to merge one patch before cutting new release23:02
mriedemwell they should shit or get off that pot23:02
*** esberglu has joined #openstack-nova23:02
andreykurilinheh23:02
stevemarmriedem: soon (tm)23:02
stevemarandreykurilin: i would looove that23:03
*** alexpilo_ has quit IRC23:03
*** alexpilotti has joined #openstack-nova23:03
stevemarandreykurilin: rally is good right?23:03
andreykurilinstevemar: yes. setting quotas works. thanks23:04
Kevin_Zhengmriedem: https://bugs.launchpad.net/nova/+bug/165857123:04
openstackLaunchpad bug 1658571 in OpenStack Compute (nova) "Microversion 2.37 break 2.32 usage" [High,In progress] - Assigned to Artom Lifshitz (notartom)23:04
andreykurilinstevemar: PS: I wonder why are so dependent on pre 1.0 library which can do whatever they want(as you said) ..23:05
andreykurilin*why we are23:05
mriedemandreykurilin: yeah good question23:05
*** gcb has quit IRC23:06
*** alexpilo_ has joined #openstack-nova23:06
mriedemstevemar: so is OSC going to have a thing in it's release notes saying, oh btw, when you create private tenant networks in this release things are doing to be different?23:06
stevemarandreykurilin: theres some history there23:06
mriedemKevin_Zheng: hi23:06
mriedemKevin_Zheng: did you see the ML thread?23:06
*** alexpilo_ has quit IRC23:06
*** esberglu has quit IRC23:06
*** alexpilo_ has joined #openstack-nova23:07
andreykurilinstevemar: if they want to play with us in the same sandbox, they should follow the same rules23:07
*** timello has quit IRC23:07
Kevin_Zhengmriedem: not yet, left early yesterday23:07
stevemarmriedem: we can add that to the release notes, but i think we rename the column/info properly23:08
*** alexpilotti has quit IRC23:08
*** harlowja has quit IRC23:08
bauzasmriedem: what kind of important note should we write for telling to ops "folks, you need to change your cloud before upgrading to Ocata"?23:09
bauzasmriedem: given the upgrade section is already huuuuuge23:09
*** krtaylor has joined #openstack-nova23:09
bauzaspossibly in the prelude I guess23:09
dansmithbauzas: made changes.. start_placement() isn't getting called which means no a2ensite, restart, etc23:10
mriedembauzas: yeah and probably in the placement devref23:10
*** timello has joined #openstack-nova23:10
bauzasdansmith: kewl thanks !23:10
mriedembauzas: we'll have something in the prelude section for placement and cells v2 for sure23:10
mriedemi'd also like docs reflected in the devref which we have for placement and cells v223:10
mriedemfor stuff like this23:10
bauzasdansmith:jam+123:10
*** jamesdenton has quit IRC23:10
dansmithheh23:11
stevemarmriedem: plus, everyone uses neutron anyway :P23:11
*** alexpilo_ has quit IRC23:11
*** sacharya has quit IRC23:12
*** jaosorior has quit IRC23:12
Kevin_Zhengmriedem: just read, so a new microversion?23:13
*** zz_dimtruck is now known as dimtruck23:13
mriedemKevin_Zheng: yes23:13
mriedemKevin_Zheng: but i think we can handle that as a bug fix after the feature freeze23:13
mriedemso we're not rushing toward thursday23:13
Kevin_ZhengCool23:13
bauzasdansmith: wrt grenade, how can we make sure that we don't run a placement API in the compute-only for the multinode job ?23:14
mriedemstevemar: this is like earth-shattering issue #4 today so i've lost my sense of humor about it :)23:14
Kevin_ZhengBut Chinese New Year comes this week23:14
stevemarmriedem: samesies23:14
dansmithbauzas: by not starting one in the subnode?23:14
mriedemKevin_Zheng: i think artom is planning to work on it23:14
Kevin_ZhengOk23:14
dansmithbauzas: the subnode only has ENABLED_SERVICES='n-cpu' or something23:14
bauzasdansmith: yeah, but since I'm updating from-newton, am I sure it's not for the subnode?23:15
dansmithyes23:15
*** amotoki has quit IRC23:15
bauzasdansmith: okay, but I'd still want to have the subnode running placement_compute_only23:15
dansmithbauzas: if that was a problem, all the db creation stuff above your code would run on the subnode too23:15
andreykurilinbauzas mriedem: can you look at https://review.openstack.org/#/c/424256/ ? neutron job stuck, but all others passed.23:16
*** haplo37 has quit IRC23:18
mriedemandreykurilin: looks like it's running23:18
andreykurilinmriedem: ~2,5 hours...23:19
andreykurilinusually it takes less than an hour23:19
mriedemoh hrm23:19
mriedemyou might want to ask in -infra23:19
mriedemstevemar: so on https://review.openstack.org/#/c/418190/ you want me to basically just reword the commit to say, the sdk has changed things in a backward incompatible way which breaks osc used in devstack runs, so we have to workaround that now?23:20
*** ducttape_ has quit IRC23:20
mriedemi need to get cleaned up before dinner, full of salt water23:21
*** amotoki has joined #openstack-nova23:22
*** haplo37 has joined #openstack-nova23:27
*** dimtruck is now known as zz_dimtruck23:27
*** Swami_ has joined #openstack-nova23:29
*** mtanino_ has joined #openstack-nova23:29
andreykurilinmriedem: quick question: does version negotiation require to be authenticated ?23:29
stevemarmriedem: let dtroyer take a looksy, i told him about it in -sdks23:29
stevemarmriedem: i'm damn exhausted23:29
*** shaner has quit IRC23:30
*** mtanino has quit IRC23:30
andreykurilinmriedem: and please, check https://review.openstack.org/#/c/424745/ . Not sure is that what you want or not.23:32
*** Swami has quit IRC23:32
*** dave-mccowan has joined #openstack-nova23:34
mriedemandreykurilin: that varies by service, would need to test it out23:34
*** edmondsw has joined #openstack-nova23:34
*** dtroyer has joined #openstack-nova23:34
*** owalsh is now known as owalsh-afk23:35
*** Swami_ has quit IRC23:35
*** stewie925 has quit IRC23:35
mriedemwhy do we need to change grenade for placement? i thought from-newton was already doing something there?23:36
*** takashin has joined #openstack-nova23:36
mriedemnvm i guess we didn't,23:37
mriedemwe made placement enabled by default in d-g on master23:38
mriedembut grenade would start on stable/newton23:38
mriedemandreykurilin: on https://review.openstack.org/#/c/424745/ i think there are also some things in the python API code that i need to look at,23:38
*** edmondsw has quit IRC23:38
mriedembut probably won't have time right now23:38
andreykurilinnp23:39
bauzasmriedem: because placement is not defaulted by devstack in newton23:39
bauzasmriedem: that's why I started to write a script for from-newton23:40
mriedemyup23:40
dtroyerandreykurilin: your last comment on https://review.openstack.org/#/c/424847/, you are about to release another novaclient?23:40
andreykurilindtroyer: yes23:40
andreykurilindtroyer: we need just to merge https://review.openstack.org/#/c/424256/ . It is last known(for me) blocker23:41
dtroyerany chance https://review.openstack.org/#/c/418190/ can go in too?  AIUI that'ss unblock the SDK stuff23:41
mriedembauzas: was thinking about this https://github.com/openstack-infra/devstack-gate/commit/c1b64743b8404dad93d4c06bcb26cf87cbc5240c23:41
*** amotoki has quit IRC23:42
mriedemandreykurilin: so i'll update the commit message in https://review.openstack.org/#/c/418190/ quick23:42
mriedemsince it sounds like we need it regardless23:42
andreykurilindtroyer: ^23:42
bauzasmriedem: yup, me too23:42
openstackgerritDan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2  https://review.openstack.org/42473723:43
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937923:43
bauzasmriedem: that's why when I saw grenade being sad for my scheduler change, I looked around and saw there was no placement section23:43
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/42482823:43
andreykurilindtroyer: I think we will have a change that unblocks us soon, so we can start a process of merging updates of g-r. these two changes should not conflict.23:46
openstackgerritMatt Riedemann proposed openstack/python-novaclient: Fix functional tests to deal with multiple networks  https://review.openstack.org/41819023:47
mriedemandreykurilin: ^ updated the commit message23:47
andreykurilinmriedem: cool!23:47
mriedemi have now done exactly 2 useful things today i think23:48
andreykurilin))23:48
andreykurilinthanks!23:48
andreykurilinyou are hero23:48
mriedemthat calls for a chateaubriand23:48
andreykurilinmriedem bauzas: https://review.openstack.org/#/c/424256/10 posted results ;) it changes just cli, so result of neutron-tempest job should not be affected. it is the last nice-to-have feature before release23:50
andreykurilinok, I need to go sleep. bye folks!23:52
*** alexpilotti has joined #openstack-nova23:53
dtroyerandreykurilin, mriedem: thanks,23:53
gmannmriedem: alex_xu  artom  I am  +1 to fix in this cycle only23:54
openstackgerritSylvain Bauza proposed openstack/nova: Scheduler calling the Placement API  https://review.openstack.org/41796123:55
artomKevin_Zheng, hey, yeah, I kinda stepped on your feet with my patch, apologies23:55
dansmithbauzas: did you get a run?23:55
artomUmm, I guess mine and yours are different enough that it's defensible to have two approaches proposed?23:55
bauzasdansmith: not yet23:55
bauzasdansmith: I just provided a new PS23:56
dansmithbauzas: but you just rev'd it?23:56
bauzasyup23:56
dansmithmmkay, was waiting for that run23:56
bauzasoh sorry :(23:56
Kevin_Zhengartom: ah, NP, I didn't see the ML yesterday, maybe your way is the way that we all like23:56
bauzasI haven't seen you rechecked it23:56
bauzassorry :(23:56
dansmithit was still running, right?23:56
*** thorst_ has joined #openstack-nova23:57
Kevin_Zhengartom: also our holiday is coming so maybe you can fix it more faster than me :)23:57
*** thorst_ has quit IRC23:57
mriedemok i've got to run for the night, will update the ML thread on the RP / enabled filters thing in the morning23:57
*** alexpilotti has quit IRC23:57
*** mriedem has quit IRC23:57
*** ducttape_ has joined #openstack-nova23:58
artomKevin_Zheng, hah, OK, happy it works out then :D23:58
bauzasdansmith: I haven't looked at zuul23:58
bauzasbefore uploading it again23:58
bauzasso I dunno :(23:58
*** harlowja has joined #openstack-nova23:58
dansmithokay, well, it was like 15 minutes from a run completion or something23:58
dansmithanyway23:58
* dansmith heads out for a bit23:58
*** Swami has joined #openstack-nova23:58
gmannartom:  Kevin_Zheng so this is one going as fix - https://review.openstack.org/#/c/424759/23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!