Wednesday, 2017-01-25

artomgmann, yeah, I guess so, Kevin_Zheng didn't take it personally ;)00:00
gmanncool00:00
*** sdague has joined #openstack-nova00:02
*** dtp has quit IRC00:05
*** Swami_ has joined #openstack-nova00:08
*** alexpilotti has joined #openstack-nova00:09
*** Swami has quit IRC00:10
*** tbachman has quit IRC00:11
bauzasfolks, calling it a day00:11
bauzas\o00:11
*** nicolasbock has quit IRC00:12
bauzasdansmith: shit http://logs.openstack.org/30/424730/3/check/gate-grenade-dsvm-neutron-ubuntu-xenial/905a9b0/logs/grenade.sh.txt.gz#_2017-01-24_23_54_03_66800:13
bauzasI'll have forge a new rev on the scheduler change because it requires a functional test modification00:14
*** alexpilotti has quit IRC00:15
dansmithbauzas: I just pushed a rev to the grenade patch00:16
dansmithbauzas: stop threatening to sleep and sleep00:16
bauzasyeah...00:16
*** tlian2 has joined #openstack-nova00:21
*** hongbin has quit IRC00:22
*** tlian has quit IRC00:24
*** esberglu has joined #openstack-nova00:26
*** mtanino has joined #openstack-nova00:26
*** yamahata has quit IRC00:27
*** mlavalle has quit IRC00:27
*** mtanino_ has quit IRC00:28
*** nicolasbock has joined #openstack-nova00:28
*** nvela has quit IRC00:31
*** esberglu has quit IRC00:31
*** mtanino has quit IRC00:32
*** nicolasbock has quit IRC00:33
*** chyka has quit IRC00:33
*** chyka has joined #openstack-nova00:34
alex_xuartom: Kevin_Zheng cool, thanks artom work on it also. today is my last work day before holidays also.00:35
gmannalex_xu: oh, then you should review by today :) i ll also review as high priority00:37
alex_xugmann: yea00:37
gmannalex_xu:  but have a nice holiday any case :)00:37
alex_xugmann: thanks :)00:37
alex_xugmann: would you like help on review this one https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-whitelist-for-server-list-filter-sort-parameters00:37
gmannalex_xu: this is winter vacation  or something else00:37
alex_xugmann: the policy just updated last night00:37
gmannalex_xu: sure ll check it00:37
alex_xugmann: it is chinese new year, we probably disapear while next week00:38
alex_xugmann: thanks00:38
alex_xus/while/whole/00:38
*** hoangcx has joined #openstack-nova00:39
*** chyka has quit IRC00:39
gmannalex_xu: on policy things, we are going with approach you mentioned like- detection of overridden rule and then leave that as it is and force new behavior for everything else00:39
alex_xugmann: yea00:40
*** alexpilotti has joined #openstack-nova00:41
*** thorst_ has joined #openstack-nova00:42
*** zhurong has joined #openstack-nova00:45
*** ducttape_ has quit IRC00:47
*** nicolasbock has joined #openstack-nova00:49
*** amotoki has joined #openstack-nova00:49
*** nvela has joined #openstack-nova00:51
*** thorst_ has quit IRC00:58
*** sdague has quit IRC01:01
*** phuongnh has joined #openstack-nova01:01
openstackgerritVladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata  https://review.openstack.org/40595101:02
*** namnh has joined #openstack-nova01:06
*** tbachman has joined #openstack-nova01:06
*** tbachman has quit IRC01:08
*** tbachman has joined #openstack-nova01:09
*** zz_dimtruck is now known as dimtruck01:13
*** nic has quit IRC01:17
*** ducttape_ has joined #openstack-nova01:19
*** nic has joined #openstack-nova01:20
*** mtanino has joined #openstack-nova01:25
artomvladikr, I left a comment on https://review.openstack.org/#/c/405951/9 about the feasibility of a Tempest test01:28
vladikrartom, great, thanks01:28
vladikr!01:28
vladikr :)01:28
artomvladikr, does it make sense to you? Can you think of a third party CI where we would be able to test this?01:30
vladikrartom, mellanox perhaps.. but they have issues with testing macvtap and I'm not sure if they are testing PF assignment01:31
artomvladikr, hrmpf. Oh well, we'll see what Matt says tomorrow01:33
*** tbachman_ has joined #openstack-nova01:33
vladikrartom, yeah, thanks!01:33
*** tbachman has quit IRC01:34
*** tbachman_ is now known as tbachman01:34
*** jaypipes_ has quit IRC01:41
*** tovin07_ has joined #openstack-nova01:43
*** John341__ has quit IRC01:43
*** Sukhdev has quit IRC01:45
*** John341_ has joined #openstack-nova01:45
*** jose-phillips has quit IRC01:49
*** huanxie has joined #openstack-nova01:49
*** yuntongjin has joined #openstack-nova01:50
nvelaPING01:53
*** jose-phillips has joined #openstack-nova01:56
*** jaypipes_ has joined #openstack-nova01:58
openstackgerritZhenguo Niu proposed openstack/nova: Fix breaking out of nested loops  https://review.openstack.org/42493101:59
*** yuntongjin has quit IRC02:00
*** Swami_ has quit IRC02:00
*** jamesden_ has joined #openstack-nova02:04
*** nvela has quit IRC02:05
*** ducttape_ has quit IRC02:06
*** kaisers has quit IRC02:07
openstackgerritTakashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2)  https://review.openstack.org/40896402:08
*** ducttape_ has joined #openstack-nova02:10
openstackgerritTakashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2)  https://review.openstack.org/40895502:10
openstackgerritTakashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2)  https://review.openstack.org/40896402:11
openstackgerritTakashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host  https://review.openstack.org/41492602:11
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action  https://review.openstack.org/41004202:11
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host  https://review.openstack.org/40670702:12
*** mtanino has quit IRC02:12
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix path parameters in os-hypervisors.inc  https://review.openstack.org/41691102:12
openstackgerritTakashi NATSUME proposed openstack/nova: Avoid forcing translation on logging calls  https://review.openstack.org/41387602:13
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix keypair API parameters  https://review.openstack.org/42062602:13
openstackgerritTakashi NATSUME proposed openstack/nova: Refactor a test method including 3 test cases  https://review.openstack.org/39473802:13
openstackgerritTakashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases  https://review.openstack.org/39543602:13
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-hosts.inc  https://review.openstack.org/41644402:13
*** pradk has quit IRC02:13
openstackgerritTakashi NATSUME proposed openstack/nova: api-ref: Fix deprecated proxy API parameters  https://review.openstack.org/41688202:13
*** Apoorva has quit IRC02:14
*** sacharya has joined #openstack-nova02:15
openstackgerritZhenguo Niu proposed openstack/nova: Fix breaking out of nested loops  https://review.openstack.org/42493102:16
*** browne has quit IRC02:16
*** Apoorva has joined #openstack-nova02:16
*** karimb has quit IRC02:18
*** Apoorva has quit IRC02:18
*** jamesden_ has quit IRC02:24
*** armax has quit IRC02:31
*** haplo37 has quit IRC02:34
*** tbachman has quit IRC02:34
*** haplo37 has joined #openstack-nova02:42
*** pradk has joined #openstack-nova02:43
*** jamesdenton has joined #openstack-nova02:43
*** sudipto has joined #openstack-nova02:47
*** sudipto_ has joined #openstack-nova02:47
*** browne has joined #openstack-nova02:51
*** tlian2 has quit IRC02:56
*** thorst_ has joined #openstack-nova02:57
*** thorst_ has quit IRC02:57
*** yuntongjin has joined #openstack-nova02:59
*** hongbin has joined #openstack-nova03:02
*** tommylikehu has quit IRC03:05
openstackgerritZhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail  https://review.openstack.org/41514203:07
*** takashin has left #openstack-nova03:08
*** mriedem has joined #openstack-nova03:11
*** pradk has quit IRC03:15
*** duonghq has joined #openstack-nova03:17
duonghqHello, have we close "remove-mox" for Ocata cycle?03:17
*** jamesdenton has quit IRC03:20
*** hongbin has quit IRC03:20
*** pbandark has joined #openstack-nova03:21
*** hongbin has joined #openstack-nova03:21
*** ijw has quit IRC03:21
*** browne has quit IRC03:23
*** dikonoor has joined #openstack-nova03:26
*** gszasz has quit IRC03:26
mriedemduonghq: those can still go in until thursday03:27
mriedemduonghq: but i suspect those aren't getting much review attention right now as we try to close other higher priority things out03:27
mriedemduonghq: anything that does not make it in ocata will just be deferred to pike03:28
duonghqmriedem, thank you03:28
duonghqhope that somebody can give me review on https://review.openstack.org/#/c/342648/03:28
duonghqdue to this is last commit of the chain for test_shelve03:29
duonghq:)03:29
*** hfu has joined #openstack-nova03:32
openstackgerritliusheng proposed openstack/nova: Trivial-fix: replace "json" with "yaml" in policy README  https://review.openstack.org/42496103:33
*** udesale has joined #openstack-nova03:33
duonghqsfinucan, are you there? due to you reviewed all others my ps about remove-mox of test_shelve, can you review the last one: https://review.openstack.org/#/c/342593/03:33
*** gcb has joined #openstack-nova03:38
*** ijw has joined #openstack-nova03:42
*** Apoorva has joined #openstack-nova03:44
*** Apoorva_ has joined #openstack-nova03:46
*** browne has joined #openstack-nova03:46
*** ijw has quit IRC03:46
Kevin_Zhengmriedem: could you have a look on https://review.openstack.org/415142 and https://review.openstack.org/#/c/415330/ ?03:47
mriedemKevin_Zheng: yeah i have the first open right now03:47
Kevin_ZhengYeah, thanks, it's the last day before alex on holiday, so kind hope it can be merged today03:48
Kevin_Zhenggo for launch, will address any comment at that, thanks alot'03:49
*** Apoorva has quit IRC03:49
*** yuntongjin has quit IRC03:51
*** ducttape_ has quit IRC03:57
*** mdnadeem has joined #openstack-nova03:59
*** marst has joined #openstack-nova04:01
*** tovin07 has quit IRC04:02
*** armax has joined #openstack-nova04:10
gmannKevin_Zheng: alex_xu  policy one looks fine to me04:14
*** ljxiash has joined #openstack-nova04:15
gmannKevin_Zheng:  alex_xu  my concern for overriding with default value is fine now as we will honor those in same way as they are overridden. means no affect on old deployer04:15
*** nicolasbock has quit IRC04:16
mriedemdansmith: i guess we need to remove the WIP on this https://review.openstack.org/#/c/424730/04:19
mriedemi think sdague is going to ask that the commit message point to a nova change with a release note saying why we need the from-newton step, which would be bauzas' filter scheduler change04:20
mriedemi'll just leave a comment on there, but jenkins is happy with it which is good04:21
*** hongbin has quit IRC04:23
*** browne has quit IRC04:23
mriedemKevin_Zheng: left a question in https://review.openstack.org/#/c/415142/04:24
*** ducttape_ has joined #openstack-nova04:24
*** ljxiash has quit IRC04:26
*** ljxiash has joined #openstack-nova04:27
alex_xumriedem: thanks, looks like we just miss that key.04:29
mriedemdo we want to be able to filter on instance_type_id?04:30
mriedems/filter/sort/04:30
*** dave-mccowan has quit IRC04:30
alex_xuthere should be alias for that, it called flavor I remember04:30
*** armax has quit IRC04:30
mriedemok04:30
mriedemyeah i know we leak the flavor.id out of the REST API04:30
alex_xuin the filter, that is flavor.flavor_id04:31
*** ljxiash has quit IRC04:31
mriedemok04:31
mriedemi'll check back on it tomorrow04:31
mriedemi've got to go to bed04:31
alex_xumriedem: thanks, have good sleep04:31
mriedemother than that it's looking good so shouldn't be a problem to get it in tomorrow04:32
mriedemalex_xu: just +2 when you're happy with it04:32
*** mriedem has quit IRC04:32
alex_xugmann: thanks for the review04:35
*** Sukhdev has joined #openstack-nova04:37
alex_xugmann: re: https://review.openstack.org/#/c/415330/21/nova/tests/unit/api/openstack/compute/test_serversV21.py, are you looking for cases for the new rule is overriden?04:38
alex_xuif you are looking for the cases for old rule is overriden, it is already there.04:39
*** jose-phillips has quit IRC04:40
*** hongbin has joined #openstack-nova04:41
*** browne has joined #openstack-nova04:41
*** diga has joined #openstack-nova04:41
*** psachin has joined #openstack-nova04:42
*** gcb has quit IRC04:43
*** gcb has joined #openstack-nova04:44
*** ayogi has joined #openstack-nova04:45
*** ducttape_ has quit IRC04:46
*** sree has joined #openstack-nova04:46
*** sree has quit IRC04:46
*** sree has joined #openstack-nova04:46
gmannalex_xu:  yea, old rule is there. i was thinking we can have tests only with new rule(overridden and not overridden) which are nothing but new deployer04:46
*** hongbin has quit IRC04:53
*** armax has joined #openstack-nova04:55
*** yamahata has joined #openstack-nova04:56
*** armax has quit IRC04:56
*** thorst_ has joined #openstack-nova04:59
*** edmondsw has joined #openstack-nova05:02
*** thorst_ has quit IRC05:03
*** adisky_ has joined #openstack-nova05:04
*** jamielennox is now known as jamielennox|away05:06
*** edmondsw has quit IRC05:06
openstackgerritZhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail  https://review.openstack.org/41514205:11
*** prateek has joined #openstack-nova05:11
*** udesale__ has joined #openstack-nova05:17
*** udesale has quit IRC05:17
*** gongysh has joined #openstack-nova05:18
*** ratailor has joined #openstack-nova05:18
*** udesale has joined #openstack-nova05:19
*** tlbr_ has quit IRC05:20
*** ljxiash has joined #openstack-nova05:20
*** udesale__ has quit IRC05:21
*** lpetrut has joined #openstack-nova05:33
*** Apoorva_ has quit IRC05:43
*** ducttape_ has joined #openstack-nova05:46
*** sudswas__ has joined #openstack-nova05:47
*** tlbr has joined #openstack-nova05:49
*** sudipto has quit IRC05:50
*** sudipto_ has quit IRC05:50
*** sudipto has joined #openstack-nova05:50
*** sacharya has quit IRC05:51
*** ducttape_ has quit IRC05:51
*** kaisers has joined #openstack-nova06:06
*** irenab_ has joined #openstack-nova06:11
*** irenab_ has quit IRC06:12
*** armax has joined #openstack-nova06:13
*** slagle has quit IRC06:15
*** Prophidys has quit IRC06:16
*** armax has quit IRC06:16
*** Prophidys has joined #openstack-nova06:16
*** slagle has joined #openstack-nova06:17
*** jpena|off has quit IRC06:18
openstackgerritZhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail  https://review.openstack.org/41514206:18
*** jpena|off has joined #openstack-nova06:20
openstackgerritSreeram Vancheeswaran proposed openstack/nova: [WIP] Driver function call to enable attach volume for nova-dpm  https://review.openstack.org/42499606:25
*** ekuris_ has joined #openstack-nova06:34
*** Sukhdev has quit IRC06:39
*** lpetrut has quit IRC06:45
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533006:48
*** mjura has joined #openstack-nova06:48
*** Jeffrey4l_ has quit IRC06:48
*** ratailor is now known as ratailor|afk06:49
*** edmondsw has joined #openstack-nova06:51
*** Jeffrey4l has joined #openstack-nova06:53
*** tovin07 has joined #openstack-nova06:54
*** edmondsw has quit IRC06:55
*** udesale__ has joined #openstack-nova06:56
*** hoangcx_ has joined #openstack-nova06:57
*** thorst_ has joined #openstack-nova06:59
*** hoangcx has quit IRC07:00
*** thorst_ has quit IRC07:04
*** namnh has quit IRC07:06
*** aojea has quit IRC07:06
*** sridharg has joined #openstack-nova07:09
*** sudipto_ has joined #openstack-nova07:13
*** sudipto has quit IRC07:14
*** sudswas__ has quit IRC07:14
*** Oku_OS-away is now known as Oku_OS07:14
*** sudipto has joined #openstack-nova07:14
*** ratailor|afk is now known as ratailor07:14
openstackgerritZhenyu Zheng proposed openstack/nova: Add release note and docs for filter/sort whitelist  https://review.openstack.org/42176007:17
*** ducttape_ has joined #openstack-nova07:17
*** mpaolino has joined #openstack-nova07:18
*** aojea has joined #openstack-nova07:19
*** dimtruck is now known as zz_dimtruck07:20
*** markus_z has joined #openstack-nova07:22
*** ducttape_ has quit IRC07:22
*** pcaruana has joined #openstack-nova07:28
*** hfu has quit IRC07:29
*** hfu has joined #openstack-nova07:30
*** hfu has quit IRC07:30
*** tovin07 has quit IRC07:32
*** tesseract has joined #openstack-nova07:34
*** andreas_s has joined #openstack-nova07:37
openstackgerritGhanshyam Mann proposed openstack/nova: Add "supports_device_tagging" in fake driver for tests  https://review.openstack.org/42503007:45
*** tovin07 has joined #openstack-nova07:45
*** hoangcx has joined #openstack-nova07:46
*** browne has quit IRC07:46
*** moshele has joined #openstack-nova07:48
gmannalex_xu: Kevin_Zheng  this was causing issue on tag fix patch - https://review.openstack.org/#/c/425030/107:48
*** hoangcx_ has quit IRC07:48
Kevin_Zhenggmann: AH, thanks07:49
*** sahid has joined #openstack-nova07:52
alex_xugmann: cool07:52
*** lennyb has joined #openstack-nova07:53
*** abalutoiu_ has quit IRC07:54
*** mingyu has joined #openstack-nova07:54
*** avolkov has quit IRC07:56
*** lennyb has quit IRC07:57
*** avolkov has joined #openstack-nova07:57
*** sree_ has joined #openstack-nova08:02
*** sree_ is now known as Guest5453508:02
*** sree has quit IRC08:02
*** kaisers_ has joined #openstack-nova08:07
*** lennyb_ has joined #openstack-nova08:09
*** lennyb_ has quit IRC08:09
*** lennyb has joined #openstack-nova08:10
*** yonglihe has joined #openstack-nova08:11
*** kaisers has quit IRC08:11
*** yonglihe has left #openstack-nova08:12
*** yonglihe has joined #openstack-nova08:12
*** tovin07 has quit IRC08:13
*** abalutoiu_ has joined #openstack-nova08:17
*** yuntongjin has joined #openstack-nova08:20
*** ralonsoh has joined #openstack-nova08:24
*** tovin07 has joined #openstack-nova08:29
*** Jeffrey4l_ has joined #openstack-nova08:30
*** avolkov has quit IRC08:31
*** Matias has quit IRC08:33
*** Jeffrey4l has quit IRC08:34
*** moshele has quit IRC08:34
*** moshele has joined #openstack-nova08:34
*** avolkov has joined #openstack-nova08:35
*** Matias has joined #openstack-nova08:36
*** Matias has quit IRC08:41
*** hfu has joined #openstack-nova08:42
*** lpetrut has joined #openstack-nova08:42
*** lpetrut has quit IRC08:42
*** lpetrut has joined #openstack-nova08:44
openstackgerritHironori Shiina proposed openstack/nova: Ironic: Add soft power off support to Ironic driver.  https://review.openstack.org/40797708:45
*** amotoki has quit IRC08:47
*** ducttape_ has joined #openstack-nova08:48
*** hferenc has joined #openstack-nova08:50
*** abalutoiu__ has joined #openstack-nova08:50
*** yuntongjin has quit IRC08:50
*** ducttape_ has quit IRC08:52
*** abalutoiu_ has quit IRC08:53
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533008:54
*** Matias has joined #openstack-nova08:55
*** tlbr has quit IRC08:58
*** hfu has quit IRC08:59
*** hoangcx has quit IRC09:00
*** zzzeek has quit IRC09:00
*** thorst_ has joined #openstack-nova09:00
*** zzzeek has joined #openstack-nova09:00
*** tovin07 has quit IRC09:00
claudiub|2moshele: hi. I've replied to your comments on https://review.openstack.org/#/c/420614/ . Regarding PF/VF passthrough, I *might* be able to get a compute node with such capabilities today, so I check that out as well.09:01
*** claudiub|2 is now known as claudiub09:02
openstackgerritRikimaru Honjo proposed openstack/nova: Add checks for preventing unexpected detaching volume  https://review.openstack.org/35461709:02
*** thorst_ has quit IRC09:05
sfinucanduonghq: Here now (Irish time). I'll take a look09:06
*** tlbr has joined #openstack-nova09:06
*** hfu has joined #openstack-nova09:08
*** jpena|off is now known as jpena09:11
mosheleclaudiub|2: cool09:13
mosheleclaudiub: cool09:13
sahidjohnthetubaguy: any chance you ack that one https://review.openstack.org/#/c/400874/, jaypipes already +2 it but i holidays now09:13
*** zhurong has quit IRC09:14
*** tovin07 has joined #openstack-nova09:15
openstackgerritMoshe Levi proposed openstack/nova: PCI: Check pci_requests object is empty before passing to support_requests  https://review.openstack.org/42360809:16
lyarwoodhttps://review.openstack.org/#/c/420146/ looking for a final core +2 +W on this findmnt workaround if anyone has time this morning09:20
openstackgerritGuillaume Espanel proposed openstack/nova: Reduce time and memory usage of tenant usage.  https://review.openstack.org/34373409:20
*** efoley has joined #openstack-nova09:21
*** efoley_ has joined #openstack-nova09:23
*** jpena is now known as jpena|off09:25
lyarwoodjohnthetubaguy, mikal, tonyb, claudiub ; I'm also looking to land https://review.openstack.org/#/c/412201/ on stable/newton today if anyone has the time to review this.09:26
*** hfu_ has joined #openstack-nova09:26
openstackgerritZhenyu Zheng proposed openstack/nova: Disallow assgined floating IP that already assigned to other ports.  https://review.openstack.org/42507709:26
*** efoley has quit IRC09:27
*** lucas-afk is now known as lucasagomes09:27
*** hfu has quit IRC09:29
*** liusheng has quit IRC09:29
*** yassine has joined #openstack-nova09:29
*** yassine is now known as Guest5300509:30
duonghqsfinucan, thank you09:31
*** jpena|off is now known as jpena09:31
gcbsfinucan: I think we can merge another python 3 enable patch now :)  https://review.openstack.org/#/c/414420/09:36
*** mdnadeem has quit IRC09:37
sfinucangcb: I think the same :)09:37
gcbsfinucan, cool, thanks09:39
*** mdnadeem has joined #openstack-nova09:39
*** ljxiash has quit IRC09:40
*** tovin07 has quit IRC09:41
lyarwoodjohnthetubaguy, claudiub ; thanks! :)09:42
sfinucanlyarwood: Backporting is simply 'cherry-pick -x', right?09:47
*** udesale__ has quit IRC09:47
*** udesale has quit IRC09:47
* sfinucan could only find this (rather unhelpful) guide http://docs.openstack.org/contributor-guide/additional-git-workflow/backport.html09:47
*** derekh has joined #openstack-nova09:47
lyarwoodsfinucan: yeah, there's better docs here http://docs.openstack.org/project-team-guide/stable-branches.html09:48
sfinucanActually, do we still bother with those 'backport' lines? I figured every bug should be backported, if it applied to the stable code too and didn't introduce a functional change09:48
sfinucanlyarwood: (y)09:48
lyarwoodsfinucan: http://docs.openstack.org/project-team-guide/stable-branches.html#proposing-fixes for the actual workflow09:48
openstackgerritDuong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (3)  https://review.openstack.org/34264809:48
*** adisky_ has quit IRC09:49
sfinucanlyarwood: Excellent. Thank you. Think I've done it now (https://review.openstack.org/425087)09:49
sfinucanHmm, commits to stable branches don't appear in IRC. Interesting...09:50
sfinucanduonghq: Thanks for respinning that. Appreciate it :)09:51
duonghqsfinucan, thank you very much09:52
*** tovin07_ has quit IRC09:55
*** sahid has quit IRC09:57
*** sahid has joined #openstack-nova09:59
*** tlbr has quit IRC10:02
*** duonghq has quit IRC10:05
*** sambetts|afk is now known as sambetts10:13
*** hfu_ has quit IRC10:16
*** phuongnh has quit IRC10:17
*** openstackgerrit has quit IRC10:17
*** amotoki has joined #openstack-nova10:19
*** mdnadeem has quit IRC10:21
*** ociuhandu has joined #openstack-nova10:22
*** openstackgerrit has joined #openstack-nova10:23
openstackgerritStephen Finucane proposed openstack/nova: adding debug info for pinning calculation  https://review.openstack.org/35515010:23
*** mvk has quit IRC10:23
*** edmondsw has joined #openstack-nova10:28
*** yuntongjin has joined #openstack-nova10:28
*** mingyu has quit IRC10:29
*** mdnadeem has joined #openstack-nova10:29
*** owalsh-afk is now known as owalsh10:30
*** sree has joined #openstack-nova10:31
*** cdent has joined #openstack-nova10:31
*** edmondsw has quit IRC10:32
*** aarefiev_afk is now known as aarefiev10:32
*** Guest54535 has quit IRC10:33
openstackgerritStephen Finucane proposed openstack/nova: Add PCIWeigher  https://review.openstack.org/37952410:36
openstackgerritStephen Finucane proposed openstack/nova-specs: Remove templates from approved/implemented specs  https://review.openstack.org/40555010:37
*** Nisha_ has joined #openstack-nova10:37
*** tlbr has joined #openstack-nova10:38
*** Guest53005 has quit IRC10:41
*** zerda2 has joined #openstack-nova10:41
*** zerda2 has quit IRC10:41
*** zerda2 has joined #openstack-nova10:41
*** zerda2 has quit IRC10:43
*** zerda2 has joined #openstack-nova10:43
openstackgerritHuan Xie proposed openstack/nova: Fix live migrate with XenServer  https://review.openstack.org/42442810:44
*** huanxie has quit IRC10:45
*** tlbr has quit IRC10:46
*** yuntongjin has quit IRC10:49
*** sree has quit IRC10:53
*** sree has joined #openstack-nova10:53
*** Nisha_ has quit IRC10:53
*** Guest53005 has joined #openstack-nova10:55
*** sree has quit IRC10:55
*** mvk has joined #openstack-nova10:56
*** yamahata has quit IRC10:56
bhagyashrisHi all, I have one question, In the multinode environment , Is there a need to enable the placement api service on compute node also?10:58
openstackgerritVasyl Saienko proposed openstack/nova: Implement interface attach/detach in ironic virt driver  https://review.openstack.org/41997510:58
johnthetubaguybhagyashris: everything talks to a single placement API endpoint (as defined in the keystone service catalog), over HTTP, if that helps.10:59
*** tlbr has joined #openstack-nova10:59
BobBalljohnthetubaguy: Regarding https://review.openstack.org/#/c/424428/3/nova/objects/migrate_data.py is the "legacy dictionary" used anywhere now?  i.e. should the to_legacy_dict method care about new fields added to the object?11:01
*** thorst_ has joined #openstack-nova11:01
johnthetubaguyBobBall: I suspect now both old a new nodes are sending objects, we can drop all that code11:01
BobBallRather than dropping in this patch I was assuming not bothering updating the legacy dict?11:02
johnthetubaguyBobBall: although technically speaking, we should bump the compute API major version to make that explicit11:02
BobBallI presume there should be a more global legacy-dictionary cleanup effort?  rather than a per-object piecemeal approach?11:02
BobBallbah, you know what, the easiest path is just to update the dict anyway.  Makes sure that if there is any dodgy code anywhere that it'll all work...11:03
johnthetubaguyBobBall: I like being consistent and updating that, if I am honest, but I have no functional reason, just prettyness11:03
ildikovjohnthetubaguy: hi. can you look into this Doodle poll please: http://doodle.com/poll/9per237agrdy7rqz ?11:04
*** thorst_ has quit IRC11:05
ildikovjohnthetubaguy: I know you have collisions around the time slot I hope to keep on other days, but Monday is unfortunately not working for a few Cinder guys :(11:06
johnthetubaguyildikov: so its not too bad until we high daylight savings, when many of the other days are tricky11:07
johnthetubaguyildikov: but hopefully we will have complete all our work by then :)11:07
ildikovjohnthetubaguy: we can reconsider when we switch again11:08
johnthetubaguythat too11:08
ildikovjohnthetubaguy: hehe, I like your optimism! :)11:08
ildikovjohnthetubaguy: I just would like to have a slot that works for most so we can prep for the PTG11:08
*** nicolasbock has joined #openstack-nova11:09
ildikovjohnthetubaguy: so that we can complete all our work before the next daylight savings switch ;)11:09
ildikovjohnthetubaguy: great, thank you!11:09
ildikovjohnthetubaguy: I will harass a few Cinder folks and it seems we will most prolly switch back to Thursdays for a bit, will announce this week I hope11:10
*** hfu has joined #openstack-nova11:14
bauzascdent: mmm, there is a bug with https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L129-L13111:16
bauzascdent: swap is counted in MB11:16
bauzascdent: https://github.com/openstack/nova/blob/master/nova/scheduler/filters/disk_filter.py#L36-L3811:16
bauzasso we don't report correctly the right size11:17
cdentwhoops11:17
bauzasjust creating a bug report11:17
cdentnice find11:17
mdboothbauzas: I've hit that a bunch of times, btw. In general, I'd prefer to see a coding style guideline that all storage sizes are in bytes.11:20
mdboothWe variously use B, MB and GB throughout the code, and it's super-easy to make mistakes.11:21
cdentit's good ux for it be other things for humans, but yeah, as soon as the data passes into internal code it ought to be all the same11:21
bauzasmdbooth: sure but changing the Flavors attributes seems a bit long to do11:22
mdboothYep11:22
mdboothbauzas: Oh, yeah. I think we need to live with our existing mistakes :) Just not make new ones.11:22
*** owalsh is now known as owalsh-afk11:23
*** cdelatte has quit IRC11:23
mdboothi.e. Any new code which represents a storage size should use bytes exclusively.11:23
*** rfolco has joined #openstack-nova11:26
openstackgerritMatthew Booth proposed openstack/nova: libvirt: Mock is_job_complete in test_driver  https://review.openstack.org/42514011:27
mdboothlyarwood: ^^^11:27
*** jbernard has quit IRC11:27
mdboothlyarwood: Could you take a quick look at the above change. If you approve, I would rebase your mirror attribute fix on top of it and remove all the changes in test_driver.py11:28
*** owalsh-afk has quit IRC11:28
*** mingyu has joined #openstack-nova11:29
bauzasmdbooth: agreed11:29
*** yuntongjin has joined #openstack-nova11:29
bauzasmdbooth: it should count on bytes11:29
bauzascdent: FYI https://bugs.launchpad.net/nova/+bug/165926611:30
openstackLaunchpad bug 1659266 in OpenStack Compute (nova) "Disk allocation for instance is not good with swap" [High,Confirmed]11:30
cdent✔11:30
lyarwoodmdbooth: thanks, yeah that looks good if people are happy for us to mix mox and mock, I assumed there was an unwritten rule stopping us from doing this11:30
mdboothlyarwood: I think we don't write new mox. Partial mox->mock is acceptable, I believe?11:31
bauzascdent: in theory, we would need to data migrate the existing allocations11:31
mdboothI mean going the whole hog is great. The main change is from functional->unity there, rather than mox->mock11:31
bauzascdent: are we wiping off the existing allocations somewhere when we auto-heal ?11:31
lyarwoodmdbooth: yeah, I might stash what I have and follow up with the full move to mock after this11:32
mdboothlyarwood: As I mention in the commit, we should either have a test library for this, or mock at the function boundary.11:32
*** jbernard has joined #openstack-nova11:32
*** ociuhandu has quit IRC11:32
mdboothThe real change is mocking is_job_complete, rather than modelling the corresponding behaviour of the libvirt daemon.11:33
mdboothI prefer the latter, but we don't have that in place, and doing it piecemeal isn't maintainable.11:33
cdentbauzas: we update allocations when is_new_instance or is_removed_instance11:33
mdboothlyarwood: Anyway, would you mind if I rebased your mirror tag change on to it?11:34
mdboothIt would make your change a lot smaller. No changes required in test_driver.py.11:34
cdentbauzas: we update inventory frequently11:34
lyarwoodmdbooth: not at all if you have the time to work on it11:34
mdboothYeah, it'll only take me a second.11:34
lyarwoodmdbooth: awesome thanks11:34
*** mingyu has quit IRC11:34
bauzascdent: my concerns are if we have wrong allocations when a new instance comes in11:35
cdentbauzas: yeah. I haven't looked closely enough. Is the bug such that the allocations will be over or under where they should be?11:36
bauzasyup11:36
bauzasbut I need to bail out for lunch11:36
bauzasif I have a swap of 1MB11:37
bauzasroot to 1GB and eph to 011:37
bauzasthen I'll express an allocation of 2GB with that bug instead of 1.00111:37
* cdent nods11:37
*** mpaolino_ has joined #openstack-nova11:38
cdentWhen nova-compute restarts does it rewrite all allocations?11:38
openstackgerritMatthew Booth proposed openstack/nova: libvirt: Use the mirror element to detect job completion  https://review.openstack.org/39973511:39
mdboothlyarwood: ^^^11:39
mdbooth75 insertions(+), 9 deletions(-) Much smaller :)11:39
cdentbauzas: I'll do some experimenting in devstack today (because I was planning to do that anyway)11:39
lyarwoodmdbooth: nice!11:40
mdboothlyarwood: It's identical to your change, just test_driver changes removed11:41
bhagyashrisjohnthetubaguy: i am new to placement api  feature, Does it mean, the placement api only needs to be enabled on controller node ?11:41
johnthetubaguybhagyashris: I think so11:41
*** mpaolino has quit IRC11:42
lyarwoodmdbooth: that's great, I would say thanks but my LOC changed stats just took a hit :D11:44
cdentbhagyashris: yes, it goes on a controller and needs to be in the service catalog11:44
mdboothlyarwood: lol11:44
* mdbooth thinks LOCs deleted should count for twice as much as lines added anyway11:45
cdentmdbooth++11:45
lyarwoodmdbooth: I agree https://review.openstack.org/#/c/391597/11:45
lyarwood^_^11:45
mdboothlyarwood: Oh, wow11:47
mdboothThat's fantastic :)11:47
*** ducttape_ has joined #openstack-nova11:49
*** ratailor has quit IRC11:49
*** smatzek has joined #openstack-nova11:49
mdboothGerrit is a bit 500-y this morning11:51
bhagyashriscdent: thank you for information, however if I am having two node setup then how many resource_providers will be created? two or one? In my case it is creating single resource_provider only11:53
*** ducttape_ has quit IRC11:53
cdentbhagyashris: you should get as many resource providers as you have compute nodes11:54
*** smatzek has quit IRC11:54
*** abhishekk has joined #openstack-nova11:54
*** smatzek has joined #openstack-nova11:54
cdentif you have two compute nodes but are only seeing one, then it may be that one of the compute nodes does not have the right stuff in the [placement] section of nova.conf11:54
bhagyashriscdent: ok, so in both compute nodes I need to add placement section in nova.conf? actually I am using devstack for multinode setup so one one node it does not create placement section11:56
bhagyashriscdent: thank you for useful information11:56
bhagyashriscdent: i will check accordingly11:56
cdentthe [placement] section is used by the resource tracker (and eventually nova-scheduler) so needs to be where those things are running11:57
bhagyashriscdent: ok. Thank you for information. :)11:58
*** hfu has quit IRC12:00
*** hfu has joined #openstack-nova12:00
*** hfu has quit IRC12:01
*** hfu has joined #openstack-nova12:01
*** lucasagomes is now known as lucas-hungry12:01
*** hfu has quit IRC12:01
*** hfu has joined #openstack-nova12:02
*** hfu has quit IRC12:02
*** hfu has joined #openstack-nova12:03
*** hfu has quit IRC12:03
*** hfu has joined #openstack-nova12:03
*** hfu has quit IRC12:04
*** owalsh-afk has joined #openstack-nova12:05
*** owalsh-afk is now known as owalsh12:05
*** moshele has quit IRC12:05
*** moshele has joined #openstack-nova12:05
gmannKevin_Zheng:  left few comments on https://review.openstack.org/#/c/415330/2312:06
gmannKevin_Zheng:  more tests for new rule i mean, without old rule so that we can tests the way new deployer ll use12:07
*** haplo37_ has quit IRC12:08
*** CristinaPauna has quit IRC12:08
*** CristinaPauna has joined #openstack-nova12:09
*** haplo37_ has joined #openstack-nova12:10
*** cdelatte has joined #openstack-nova12:10
stevemaro/12:14
stevemarcan we get a review of https://review.openstack.org/#/c/418190/ if possible, thanks already mriedem and andreykurilin12:15
*** yuntongjin has quit IRC12:20
*** bvanhav__ has joined #openstack-nova12:21
*** bvanhav__ is now known as bvanhav12:25
*** mnestratov has quit IRC12:27
*** catintheroof has joined #openstack-nova12:28
*** Guest53005 has quit IRC12:31
*** rmart04 has joined #openstack-nova12:33
lyarwoodAny additional core reviews on the following would be appreciated - https://review.openstack.org/#/c/420146/ - libvirt: workaround findmnt behaviour change12:34
*** sudipto has quit IRC12:39
*** sudipto_ has quit IRC12:39
*** pradk has joined #openstack-nova12:40
Kevin_Zhenggmann: will add one, but I think thats what we should add when we remove the old rule, because for the new users using Ocata, old rule is still there, just not checking them12:42
gmannKevin_Zheng: yea but after this change, user can also have only new rule in their policy.json12:43
Kevin_Zhengyeah, but the old rule still exist in code12:43
*** mnestratov has joined #openstack-nova12:44
*** ayogi has quit IRC12:44
*** thorst_ has joined #openstack-nova12:44
Kevin_Zhengit will make not difference than the current test12:44
gmannKevin_Zheng: ah, you mean code still have those.12:45
Kevin_Zhengyeah12:45
gmannKevin_Zheng:  got it, thanks.12:45
gmannKevin_Zheng:  and while removing the old rule those tests will be with new rule only12:45
Kevin_Zhengso, I will just update the comments then12:45
Kevin_Zhengyeah, we will change the test then12:46
alex_xunova api meeting is in 15 mins at #openstack-meeting-412:46
*** Guest53005 has joined #openstack-nova12:46
-openstackstatus- NOTICE: Gerrit is going to be restarted due to slow performance12:46
gmannKevin_Zheng: cool  thanks12:46
*** ducttape_ has joined #openstack-nova12:48
alex_xugmann: thanks for the review!12:50
-openstackstatus- NOTICE: Gerrit has been successfully restarted12:50
gmannalex_xu: np!12:50
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533012:52
*** moshele has quit IRC12:57
Kevin_Zhenghttps://review.openstack.org/#/c/421760/12:59
Kevin_Zheng^ please also review the doc patch?12:59
*** lucas-hungry is now known as lucasagomes13:00
openstackgerritBalazs Gibizer proposed openstack/nova: Fix race condition in instance.update sample test  https://review.openstack.org/42457413:01
alex_xunova api meeting is running13:02
*** tbachman has joined #openstack-nova13:05
*** hfu has joined #openstack-nova13:05
*** stvnoyes has quit IRC13:05
*** stvnoyes has joined #openstack-nova13:05
*** hfu has quit IRC13:10
*** tbachman has quit IRC13:12
*** tbachman_ has joined #openstack-nova13:12
*** ociuhandu has joined #openstack-nova13:26
*** vsaienko has joined #openstack-nova13:27
*** tongli has joined #openstack-nova13:27
*** edmondsw has joined #openstack-nova13:28
*** esberglu has joined #openstack-nova13:28
*** mingyu has joined #openstack-nova13:31
*** liverpooler has quit IRC13:31
*** liverpooler has joined #openstack-nova13:32
*** moshele has joined #openstack-nova13:33
*** tbachman_ is now known as tbachman13:33
*** udesale has joined #openstack-nova13:33
*** ducttape_ has quit IRC13:34
*** mingyu has quit IRC13:36
*** xyang1 has joined #openstack-nova13:39
bauzascdent: have you seen our discussion with matt yesterday and the conclusion email ?13:41
bauzascdent: we agreed on rather asking to modify the allocation ratios13:41
bauzascdent: so I needed to modify a functional test for server_groups13:42
bauzascdent: but I discovered a problem13:42
bauzascdent: when having an allocation, it still doesn't work because we also verify the max unit13:42
bauzaswhich is not changed if using the ratio13:42
cdentbauzas: max unit shouldn't have anything directly to do with allocation ratio, can you explain what you mean a different way?13:43
bauzasI mean https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L61513:43
bauzascdent: okay, so the problem is when operators don't use legacy filters in Newton13:44
bauzasie. the CoreFilter or the DiskFilter13:44
*** kylek3h_ has joined #openstack-nova13:44
bauzasthen in case you don't have enough resources, it's fine13:44
bauzasthe scheduler would still give you destinations13:44
bauzasnow that we have the placement call, it's asking for both VCPU, mem and disk13:45
bauzasas we agreed on not optionally ask for them13:45
bauzasbut13:45
bauzasgiven the solution was to say 'just amend the ratio and put for example 9999.0', it would still work for Newton13:45
bauzasbecause for example CoreFilter doesn't verify the max unit13:45
bauzasbut when upgrading to Ocata, then the placement API wouldn't return that destination13:46
bauzasbecause we now verify also by max unit13:46
bauzasse ?13:46
*** kylek3h has quit IRC13:46
bauzaslemme upload two changes and hopefully you'll understand13:46
cdentI'm still not seeing how max unit is involved in wha you are describing. it is the max for an individual request13:47
*** vsaienko has quit IRC13:47
*** jpena is now known as jpena|lunch13:50
*** vsaienko has joined #openstack-nova13:51
bauzascdent: sec, uploading my branch13:51
*** mdnadeem has quit IRC13:53
openstackgerritSylvain Bauza proposed openstack/nova: Scheduler calling the Placement API  https://review.openstack.org/41796113:53
openstackgerritSylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters  https://review.openstack.org/42518513:53
bauzascdent: see the bottom patch https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L61513:54
bauzasoops13:54
bauzascdent: https://review.openstack.org/42518513:54
*** mdnadeem has joined #openstack-nova13:55
*** sridharg has quit IRC13:55
cdentbauzas: I'm looking but I still don't get where max_unit is involved?13:55
bauzascdent: not for that change13:56
bauzascdent: it will have the functional test +113:56
kashyapmdbooth: You might find this interesting, upstream QEMU just merged this command-line switch called '--only-migratable' -- what it does is, if you add any devices to your VM that are _not_ migratable, it'll fail upfront13:56
bauzascdent: now, the latter change using the scheduler would not agree now13:56
mdboothkashyap: Nice13:56
bauzasfor those tests13:56
andreykurilinbauzas: sorry for disturbing. OpenstackClient, senlinclient teams are blocked by https://review.openstack.org/#/c/418190/ . They want to bump openstacksdk version in g-r, but it will break our gates without that patch13:56
kashyapmdbooth: As an example, trying to add a USB audio device results in:13:56
kashyap./x86_64-softmmu/qemu-system-x86_64 --only-migratable -nographic -device usb-audio13:56
kashyapqemu-system-x86_64: -device usb-audio: Device usb-audio is not migratable, but --only-migratable was specified13:56
bauzasandreykurilin: I wanted to ask you when you feel it's okay to release a version, but you consider the above blocking ?13:57
andreykurilinbauzas: so we need to merge at least https://review.openstack.org/#/c/424256/ . it is required for our release. You previously put +2, but gates decided that I'm doing something wrong, so I push another patch-set13:58
bauzascdent: it wouldn't work because of the new calculation we made for GET /RPs here https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L61513:58
*** baoli has joined #openstack-nova13:58
*** marst has quit IRC13:58
andreykurilinbauzas: https://review.openstack.org/#/c/418190/ doesn't block us. But without it, our functional tests can't work with latest openstacksdk, which is needed for several projects13:59
bauzasok13:59
cdentbauzas: I'm hearing you say that, what I'm asking is for you to explain why that's the case.13:59
cdent(using words, instead of pointing at code)13:59
andreykurilinbauzas: stevemar put -W for his patch to g-r https://review.openstack.org/#/c/424847/ and waiting for us:)13:59
*** baoli_ has joined #openstack-nova14:00
alex_xujohnthetubaguy: gmann Kevin_Zheng sorry, let us continue at here14:00
gmannyea14:00
cdentbauzas: what matters is that AMOUNT_X is less than max_unit. that's all.14:00
gmannjohnthetubaguy: alex_xu another point will be, can we do another microversion in Ocata? i can update code soon but review might be issue14:01
andreykurilinbauzas: also, there is patch with clarification docs (relates to thread -  "[openstack-dev] [nova] Device tag in the API breaks in the old microversion"), but it is not critical, just nice to have14:01
bauzascdent: yup, so lemme clarify14:01
*** mdrabe has joined #openstack-nova14:01
openstackgerritJohn Garbutt proposed openstack/nova: Add release note and docs for filter/sort whitelist  https://review.openstack.org/42176014:01
bauzascdent: previously, we were calculating if (amount + used) was under total * ratio, that's it14:02
bauzasI mean in the legacy filter14:02
* cdent nods14:02
bauzascdent: now the placement method does extra checks, one being that amount is less than max unit, period.14:02
cdentcorrect14:02
johnthetubaguygmann: it does seem too close to the wire, but also feels less urgent than the other pieces of the puzzle14:02
cdentthose values are set the "real" values on the compute node14:02
bauzascdent: if so, we can't say to operators to just modify their ratios in order to get the same behaviour14:03
cdentit doesn't matter14:03
bauzascdent: because once the scheduler upgraded to Ocata, it will not return the exact same nodes14:03
cdentan operator could never place a host on a node that had fewer vcpus than requested14:03
bauzascdent: and hosts that were okay for Newton won't be available per Ocata14:03
*** baoli has quit IRC14:03
cdentbut they are not okay14:03
bauzascdent: people did14:03
cdenthow does that even work?14:04
bauzascdent: because they disabled their filters14:04
cdentcan I run an 8vcpu server on a 2 vcpus host?14:04
gmannjohnthetubaguy: ok, let me push changes tomorrow and then we can see till where we can go with those14:04
bauzasyou can if you don't enable the CoreFilter14:04
cdentthat's bonkers14:04
*** vsaienko has quit IRC14:04
bauzascdent: yet again, we can be pedantic and say that14:04
edleafebauzas: you could get that back from scheduler, but it would fail to build14:05
bauzasor we can be pragmatic and find a way that doesn't trample operators14:05
alex_xugmann: really appreciate that14:05
Kevin_Zhengcdent: hi, since you are here, is this an issue? https://bugs.launchpad.net/nova/+bug/165886814:05
openstackLaunchpad bug 1658868 in OpenStack Compute (nova) "Should raise retry limit exceed error instead of class exist in Placement API" [Undecided,New] - Assigned to Zhenyu Zheng (zhengzhenyu)14:05
cdentWell a) clearly I don't know enough about what people are doing to have a straight opinion on this stuff, but b) I don't think we should allow bonker-ness, c) I'd defer to matt and dan on this14:05
bauzasedleafe: the claim could14:05
cdentwill look in just a sec Kevin_Zheng14:05
edleafebauzas: the claim could... what?14:05
bauzasedleafe: but the claim takes care of the ratio as a limit14:05
*** ducttape_ has joined #openstack-nova14:06
bauzasedleafe: you know the process, right?14:06
bauzasso14:06
edleafebauzas: yeah, I've seen it once or twice14:06
gmannalex_xu: np!14:06
bauzasokay, so the problem is that we suddently stop supporting something without a clear upgrade path just because we advocate it's bonkers14:06
bauzasthat doesn't look a correct answer to me14:07
*** vsaienko has joined #openstack-nova14:07
bauzassince we allowed for a while to opt-out filters14:07
edleafebauzas: so are you saying that today if you disable CoreFilter, you could successfully build a VM with 8 VCPUs on a 2 VCPU host?14:07
bauzasedleafe: if you live-migrate, yes14:08
cdentthe "build a VM" part is the critical question, not what select_destionations does or does not return14:08
edleafeI am unaware of any hypervisor that can do that magic14:08
bauzaslet's be clear, you can live-migrate a 8 VCPU VM to a 2 VCPU node14:09
bauzasat least Nova doesn't prevent you to do so14:09
johnthetubaguybauzas: we can deprecate something, saying its bonkers, and remove it the following cycle14:09
bauzasjohnthetubaguy: that was the original approach14:09
edleafebauzas: but do you get an 8 VCPU vm?14:09
bauzasjohnthetubaguy: but I got strong consensus to not do that and rather straight not accepting14:09
johnthetubaguythats defiantly my preference, because of the release tags we are signed up to14:09
*** vsaienko has quit IRC14:10
bauzasedleafe: that depends on your driver14:10
cdentKevin_Zheng: I'll respond on the issue14:10
bauzasedleafe: but whatever the situation is, nova *is* accepting that14:10
Kevin_Zhengcdent: thanks14:10
johnthetubaguybauzas: you have to get an 8 VCPU vm, else it wouldn't live-migrate, as I understand it14:11
*** pbandark has quit IRC14:11
bauzasin other words, folks, how can I make that functional test be working when using the placement API ?14:11
*** pradk has quit IRC14:11
bauzasI think there is a big misunderstanding between vcpus and pcpus14:11
cdentbauzas: when you say "accepting that" what do you mean by "that", explicitly?14:11
bauzascdent: accepting to give you a destination that is not verifying the max unit14:11
johnthetubaguyFWIW, I know rackspace cloud have never run the core filter, we only run the RAM filter14:11
*** tlian has joined #openstack-nova14:12
bauzasjohnthetubaguy: then you could be in serious touble14:12
cdentbauzas: sure but destinations don't matter, where vms are built does14:12
bauzasjohnthetubaguy: see https://review.openstack.org/#/c/417961/24/releasenotes/notes/resource_providers_scheduler_db_filters-16b2ed3da00c51dd.yaml14:12
johnthetubaguywe would just have to set the over-comitt ratio correctly, but thats OK as a warning14:12
cdentthat's what I keep trying to clarify here: is the behavior of where vms built actually changing, or just the list of destinations?14:12
sahidjohnthetubaguy: i replied to your questions about the patch related to the feature emulator threads14:12
*** zzzeek has quit IRC14:12
sahidhope that is going to clarify your mind14:13
bauzasjohnthetubaguy: cdent: seriously, I'm done14:13
bauzasI'm trying to spot issues that could come up in production and I'm only seeing a "meh, it's bonkers"14:14
cdentbauzas: why? I'm really trying hard to understand the situation.14:14
bauzascdent: Jenkins will tell you the situation14:14
cdentIf it is the case that "the behavior of where vms built actually changing" then we have an issue.14:14
*** zzzeek has joined #openstack-nova14:14
*** cleong has joined #openstack-nova14:15
cdentfunctional tests failing isn't necessarily telling us anything because we've demonstrated time and again (recently) that the functional tests have bad setups.14:15
*** sdague has joined #openstack-nova14:15
bauzascdent: in particular, tbp, some functional tests in the test_server_group testcase won't give you the same exact result once we call the placement service, which is to me a good indicator that placement decisions are not feature-parity between Newton and Ocata14:15
cdentthat's a good indicator, but only if we verify that the tests are correct14:16
cdentso I guess the next step is to wait and see what fails and go from there14:16
*** dave-mccowan has joined #openstack-nova14:16
johnthetubaguyso for folks with the core filter turned off the decisions will be different now we enforce that, it seems to me14:17
bauzasjohnthetubaguy: my point indeed14:17
johnthetubaguybauzas: yep, I am trying to agree with you here14:17
bauzasjohnthetubaguy: I spotted that problem in a ML thread14:17
johnthetubaguybauzas: I liked that first version of your code that dealt with that14:18
bauzasjohnthetubaguy: and the agreement we made with matt and jay was to rather ask the operators to set their ratios to an high value14:18
*** jamesdenton has joined #openstack-nova14:18
cdentall along my position has been "bauzas' suggestion sounds sane but I defer to jay, dan and matt". I still do.14:18
edleafejohnthetubaguy: I'm really not getting this. You're saying that it is expected behavior that Nova will build an 8 VCPU VM on a 2 VCPU host?14:18
bauzasjohnthetubaguy: but I'm trying to explain that because of an implementation detail and a design agreement that the placement engine should respect max units, we can't have the same14:19
bauzasedleafe: a 2VCPU host doesn't mean anything to me14:19
bauzasedleafe: hosts have physical threads14:19
*** hfu has joined #openstack-nova14:20
*** READ10 has joined #openstack-nova14:20
sfinucansahid: Left a comment on https://review.openstack.org/#/c/400875. Could you take a look so I can continue with the rest of the series, please :)14:20
johnthetubaguyedleafe: thats not my point here, my point is we are breaking folks existing configurations across upgrade14:20
*** diga has quit IRC14:20
johnthetubaguyedleafe: if folks have the core filter off, they probably have not set the over commit raitio correctly14:20
edleafejohnthetubaguy: I was using bauzas's example.14:21
johnthetubaguyedleafe: when we change the default filters, it broke the XenAPI CI, for one example14:21
edleafejohnthetubaguy: so our release notes tell them how to fix that14:21
bauzasedleafe: but the releasenote I wrote is not *fixing* that14:21
bauzasedleafe: I thought yesterday it was the case14:21
bauzasbut it's not14:21
bauzasbecause *again* we cap on max_unit14:22
edleafejohnthetubaguy: I understand it can break tests, but what is the effect in the real world?14:22
openstackgerritVladik Romanovsky proposed openstack/nova: Adding vlans field to Device tagging metadata  https://review.openstack.org/40595114:22
*** psachin has quit IRC14:22
bauzaseither way, we're 24 hours of the FF, and what we all discuss can possibly be a no-brainer if we are not able to amend grenade in time14:22
johnthetubaguyaye14:23
cdentbauzas: when a compute node reports inventory it reports a value from compute_node.vcpus. how is that calculated?14:23
cdent(I'm trying to expand my understanding here, nothing else)14:23
bauzascdent: you mean the helper method, but how nova can know what cpus the node has ?14:23
bauzass/but/or14:23
cdentI saying: there's a properly on the compute_node object called vcpus, which is set by update_from_virt_driver14:24
cdentwhat does it mean?14:24
johnthetubaguybauzas: random thought, what if we change max unit to pCPU * allocation ratio?14:27
johnthetubaguyedleafe: real world, feels like it only makes sense for test rigs and dev rigs14:27
edleafejohnthetubaguy: what if we dump max_unit altogether?14:29
bauzasjohnthetubaguy: I'm pretty sure I would get a strong negative feedback on that approach14:29
johnthetubaguyedleafe: it makes sense for some resources, just not all14:29
*** tblakes has joined #openstack-nova14:29
johnthetubaguyedleafe: I think disk it was particularly useful for, from what I remember14:30
*** liang_ has joined #openstack-nova14:30
*** gouthamr has joined #openstack-nova14:31
*** liang_ has quit IRC14:31
*** liangy has joined #openstack-nova14:31
johnthetubaguyhmm, I duno, it all feels very edge case, and there are work arounds if folks hit things14:31
bauzasI'm feeling my patch is like a giant canary patch for spotting placement integration with nova14:32
*** mingyu has joined #openstack-nova14:32
bauzasand being so close to FF makes me absolutely nervous14:32
bauzasso we could spend yet another hours for discussing the good and the bad of operatoes14:33
bauzasbut the fact is that the landing window is reducing fast14:33
*** ducttape_ has quit IRC14:33
johnthetubaguybauzas: its also the most important patch to get all the lovelyness of placement exposed to our users, if that makes you feel better14:34
bauzasi know14:34
bauzasbut that doesn't help if we're stuck14:34
*** tlbr has quit IRC14:35
johnthetubaguyso the reality is, this is a big change, its going to be a bit bumpy14:35
mdboothSpeaking of which, this is a not-insubstantial change which has been sitting a while: https://review.openstack.org/#/c/383859/14:35
johnthetubaguythe sooner we get this out there, the sooner we get to fix the stuff that really affects people14:35
mdboothI know it's a bugfix, but if it gets any additional exposure from landing before FF that would be great.14:35
*** Swami has joined #openstack-nova14:36
*** udesale has quit IRC14:36
*** mingyu has quit IRC14:37
edleafejohnthetubaguy: bauzas: from the RP spec: "As an example, let us say that a particular compute node has two quad-core Xeon processors, providing 8 total physical cores. Even though the cloud administrator may have set the cpu_allocation_ratio to 16 (the default), the compute node cannot accept requests for instances needing more than 8 vCPUs. So, while there may be 128 total vCPUs available on the14:38
edleafecompute node, the min_unit would be set to 1 and the max_unit would be set to 8 in order to prevent unacceptable matching of resources to requests."14:38
edleafeis this reasoning wrong?14:39
johnthetubaguyso it has 16 threads, with hyperthreading I guess, which feels a better match to vCPU14:40
*** vsaienko has joined #openstack-nova14:40
*** xinliang has quit IRC14:40
cdentwhat max_unit is set to for vcpu is dependent on what the virt driver reports. if it is hyperthreading aware, it probalby reports more.14:41
edleafejohnthetubaguy: so you're saying that the reasoning in the spec is wrong?14:41
*** liangy has quit IRC14:41
* edleafe has to run out for a bit to take his daughter to school14:41
*** liangy has joined #openstack-nova14:41
*** tongli has quit IRC14:42
dansmithjohnthetubaguy or bauzas: easy --verbose patch that is at the bottom of all the remaining cells/devstack/devstack gate changes: https://review.openstack.org/#/c/421228/14:42
*** gcb has quit IRC14:42
bauzasdansmith: aye14:43
bauzasI'm stuck anyway, I have now plenty of time for reviews14:43
dansmithlet me catch up for the morning and then we can look14:44
dansmithat your stuff14:44
bauzasdansmith: I'll need to send an email14:45
*** tblakes_ has joined #openstack-nova14:50
BobBalledleafe: Which spec are you talking about there? I've just been chatting to one of the Xen developers and they believe its dangerous to over-commit in a single VM.  Linux slows to a crawl (and may crash) and Windows definitely crashes.  Apparently.14:51
*** tblakes has quit IRC14:52
*** xinliang has joined #openstack-nova14:53
*** hongbin has joined #openstack-nova14:55
*** tblakes has joined #openstack-nova14:55
*** mvk has quit IRC14:55
*** tblakes_ has quit IRC14:56
sfinucanjohnthetubaguy, sdague: Easy Mox-mock patch that holding back a bug fix (ye've both reviews Mox-mock patches before :))14:56
*** jpena|lunch is now known as jpena14:56
*** marst has joined #openstack-nova14:57
openstackgerritTakashi NATSUME proposed openstack/nova: Use ListOfIntegersField in oslo.versionedobjects  https://review.openstack.org/42391214:57
johnthetubaguydansmith: I am wondering about this, do we get away without needing a context manager there? https://review.openstack.org/#/c/319379/78/nova/compute/api.py@180014:59
cdentBobBall: that was the original resource providers spec: http://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/resource-providers.html15:00
BobBallah ok15:00
*** udesale has joined #openstack-nova15:00
*** catinthe_ has joined #openstack-nova15:00
*** mlavalle has joined #openstack-nova15:00
*** sridharg has joined #openstack-nova15:01
BobBallThanks.15:01
*** catintheroof has quit IRC15:02
bauzasjohnthetubaguy: cdent: edleafe: dansmith: just made a summary in the ML thread about the problem15:04
bauzaswith a silver bullet in it15:04
dansmithjohnthetubaguy: yeah, i think you might be right15:04
dansmithjohnthetubaguy: I'm surprised melwitt didn't do that though, so I'm wondering if she knows better15:05
dansmithjohnthetubaguy: I will queue a change though and then ask her when she's aroune15:05
johnthetubaguydansmith: cool, thanks15:05
melwittI think that's my bad. it was part of a bleary-eyed debugging session15:05
bauzascdent: you could defer to others for that, but I'd still love your thoughts15:06
*** eharney has joined #openstack-nova15:06
dansmithmelwitt: ack, I'll fix15:06
cdentbauzas: thanks for doing that, will look soon, in the midst of some debugging in devstack15:06
bauzascdent: edleafe: dansmith: johnthetubaguy: http://lists.openstack.org/pipermail/openstack-dev/2017-January/110938.html is the summary email15:07
*** eglynn has joined #openstack-nova15:08
*** ducttape_ has joined #openstack-nova15:08
bauzasinteresting, my English level is dropping fast15:08
bauzasand we're at the middle of the week15:08
bauzasbut that email is awfully covered of mistakes so I apologize15:09
*** jaosorior has joined #openstack-nova15:10
*** hfu has quit IRC15:11
*** karimb has joined #openstack-nova15:11
*** sdague has quit IRC15:12
openstackgerritArtom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.32 and 2.37  https://review.openstack.org/42475915:12
openstackgerritArtom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.33 and 2.37  https://review.openstack.org/42475915:13
*** yufei has joined #openstack-nova15:17
openstackgerritDan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2  https://review.openstack.org/42473715:17
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937915:17
*** timello has quit IRC15:17
*** stvnoyes1 has joined #openstack-nova15:19
*** stvnoyes has quit IRC15:21
bhagyashrisVek : alex_xu: Hi, could you please review the patch [1] https://review.openstack.org/#/c/409644/ ?15:21
*** yufei has quit IRC15:25
*** zz_dimtruck is now known as dimtruck15:26
*** burgerk has joined #openstack-nova15:27
edleafeBobBall: (reading back) Yes, concern about over-commmit was the reason that max_unit exists15:28
BobBall*nod* I had mis-read.  Thanks for confirming.15:28
edleafeBobBall: Apparently some operators want to be able to override that.15:28
*** jdurgin1 has joined #openstack-nova15:28
BobBallCrazy people :)15:28
edleafeBobBall: supposedly adding that sanity check will negatively affect them15:29
*** baoli_ has quit IRC15:29
andreykurilinstevemar: it looks like you can remove your -W to g-r patch:)15:29
*** mpaolino_ has quit IRC15:30
*** mtanino has joined #openstack-nova15:30
*** markvoelker has quit IRC15:31
*** markvoelker has joined #openstack-nova15:32
*** timello has joined #openstack-nova15:33
*** sridharg has quit IRC15:35
*** pradk has joined #openstack-nova15:36
*** markvoelker has quit IRC15:36
*** rmart04 has quit IRC15:38
andreas_sHi adreznec, quick question regarding nova-powervm devref creation15:41
*** jschwarz is now known as jschwarz|brb15:41
*** ekuris_ has quit IRC15:41
andreas_sadreznec, you have your config options defined here: https://github.com/openstack/nova-powervm/blob/master/doc/source/devref/usage.rst15:41
andreas_sadreznec, have those been autogenerated somehow, or did yo create those tables by hand?15:42
andreas_sI'm trying to achieve something similar for the nova-dpm project...15:42
bauzasedleafe: BobBall: crazy people can be RAX15:42
bauzasgiven they don't use the CoreFilter15:42
* bauzas shrugs15:42
*** catintheroof has joined #openstack-nova15:43
adreznecandreas_s: I believe thorst_ built that set of documentation. Not sure what his exact steps were - do you remember thorst_?15:43
thorst_andreas_s: unfortunately, I did it all by hand.15:44
thorst_so it could be out of date.15:44
BobBallbauzas: Only crazy if they offer flavours with more CPUs than the minimum number on their hosts?15:44
andreas_sthorst_, adreznec ok thanks - maybe I'll find a way to automate that a bit..15:44
*** jose-phillips has joined #openstack-nova15:44
thorst_andreas_s: let us know if you get it automated...I'd like to use that  :-)15:45
sfinucanpkoniszewski: If you want to fix this up quickly, I can +2 https://review.openstack.org/#/c/410817/515:45
andreas_sthorst_, sure15:45
pkoniszewskisfinucan: sure, thanks!15:45
dansmithbauzas: I don't understand the problem in your email15:45
bauzasdansmith: sorry, like I said, my English level in that email is just terrible15:46
*** catinthe_ has quit IRC15:46
bauzasdansmith: let me restate the problem I spotted15:46
dansmithbauzas: I get that max_unit causes some slightly different behavior?15:46
*** Swami_ has joined #openstack-nova15:46
bauzasdansmith: yup15:47
bauzasdansmith: for example15:47
dansmithmax_unit is the maximum size of any given allocation of that resource type, yes?15:47
bauzasdansmith: say an instance with a flavor of 2 vCPUs15:47
bauzasdansmith: max_unit is the max resource class amount the provider supports15:48
bauzasin its inventory15:48
bauzaseg.15:48
dansmitho.O15:48
bauzasa compute exposing 1 CPU15:48
bauzaswill have max_unit=115:48
*** jschwarz|brb is now known as jschwarz15:48
bauzaslike the FakeDriver15:48
bauzasI mean the SmallFakeDriver15:48
bauzasnow, count an instance with a flavor of 2 vcpus15:49
dansmithI don't think that's right.. total should be the maximum available15:49
bauzasif we set a cpu ratio to 9999.0, then the CoreFilter will be happy15:49
dansmithI think max_unit is the largest single allocation, and min_unit is the smallest15:49
*** tbachman has quit IRC15:49
dansmithso if you want to not let someone request 1MB of RAM, for example, min_unit might be 6415:49
*** Swami has quit IRC15:49
bauzasdansmith: lemme show you the code15:49
openstackgerritPawel Koniszewski proposed openstack/nova: Add new configuration option live_migration_scheme  https://review.openstack.org/41081715:50
dansmithhttps://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L656-L66515:50
dansmithI'm looking at that ^15:50
*** Oku_OS is now known as Oku_OS-away15:50
*** Sukhdev has joined #openstack-nova15:51
bauzasdansmith: see how we report it per compute https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L9415:51
bauzasI mean, L95 rather15:51
dansmithright,15:51
bauzasso take my example15:51
bauzasa driver reporting 1 VCPU15:51
bauzasand an instance asking 2 vCPUs15:51
*** owalsh_ has joined #openstack-nova15:52
bauzasif we use the allocation ratio of 999.0 then the compute will satisfy the request per the CoreFilter rules15:52
bauzashttps://github.com/openstack/nova/blob/master/nova/scheduler/filters/core_filter.py#L4715:53
*** owalsh has quit IRC15:53
dansmithyou're saying that max_unit isn't scaled by allocation ratio, right?15:53
dansmith(effectively)15:53
edleafebauzas: lines 54-56 are what I'm looking at15:54
cdentdansmith: yes, and the questions are whether that is correct or not, and even if it not correct, if deprecation of some kind is required to deal15:54
bauzasdansmith: wait, I think I'm puzzled15:55
dansmithcdent: so the change from what we have now is that any one instance can't overcommit the host, effectively15:55
edleafeI thought the issue was for operators who disabled CoreFilter15:55
cdentdansmith: yes15:55
dansmithcdent: like if the host has 1 vcpu to give, then you can have $allocation_ratio instances there, but not a multi-vcpu instance15:55
edleafeThey can currently put an 8VCPU request on a 2 VCPU host15:55
edleafeBut they won't be able to now, because of max_unit15:56
mdboothartom vladikr: volume_id in connection_info came up in review the other week, no?15:56
dansmithedleafe: which is kinda what max_unit is for15:56
edleafedansmith: agreed15:56
mdboothartom vladikr: I'm currently doing a trawl of cinder volume drivers, and so far I've found at least 1 which doesn't set it.15:56
edleafedansmith: but bauzas and johnthetubaguy point out that that's a change w/o deprecation15:56
artommdbooth, yeah, you said it was a bad idea15:56
dansmithedleafe: right now we just set it to the max, assuming a sane default, but we could change that later if someone has a good reason to allow such a thing15:56
mdboothartom vladikr: It's all very ad-hoc15:56
bauzaswhat the hell15:57
artommdbooth, and then I went and re-checked with traget_dev/device_name, and it turns out that it works15:57
dansmithedleafe: yeah, I can kinda see that, but.. it's also not very smart15:57
artommdbooth, my previous testing must have been as ad-hoc as colume id in cinder :)15:57
mdboothartom: Awesome. Wasn't sure what the resolution was, just thought I'd throw in a data point :)15:57
edleafedansmith: ok, so we have "bonkers", "crazy people", and "not very smart" to describe that15:57
edleafedansmith: you win the prize for most polite15:57
dansmithedleafe: artom cdent: If someone had a problem with this, we could allow setting insanity_mode=on, which would report max_unit=N*allocation_ratio15:57
* edleafe is shocked15:58
dansmithedleafe: I'd like to change my answer to "fucking stupid"15:58
* artom feels flattered to have been involved in that joke15:58
*** _ducttape_ has joined #openstack-nova15:58
* edleafe is relieved that dansmith is back to his old self15:58
* bauzas facepalms15:58
cdentlaaaaaadies and gentleman in a last minute change, dansmith wins15:58
bauzaswe don't use CoreFilter in the default list of filters15:59
bauzassoooooo great15:59
dansmithbauzas: that's not news, is it?15:59
bauzasit is to me15:59
*** dtroyer has left #openstack-nova15:59
bauzasI thought the gate was special15:59
bauzasbut that we allowed corefilter by default15:59
bauzasI'm utterly surprised16:00
bauzasso I'm just discovering that we *never* verified in Newton the CPU resources16:00
bauzasunless you explicitely asked for16:00
bauzasbecause if so, the CoreFilter would deny like the placement engine16:01
bauzasthat's even worst !16:01
bauzasholy shit16:01
bauzaspardon my language16:02
*** ducttape_ has quit IRC16:02
bauzasdansmith: ^16:02
*** Oku_OS-away is now known as Oku_OS16:02
edleafebauzas: at least curse in French16:02
bauzasso, just to be clear, lemme restate for the audience16:02
dansmitheven worse in what way? that it's a change?16:02
bauzasin Newton, we totally accept that we can return a destination that doesn't satisfy the vCPU requirements16:03
bauzasthat's worst because that's changing the scheduler behaviour16:03
*** sdague has joined #openstack-nova16:03
edleafeReturning a destination is an implementation detail, not a behavior16:03
bauzasplacing an instance on a target is a behavioural choice16:04
dansmithbauzas: but the whole point of placement is making better decisions right?16:04
edleafeIf anything, the change should reduce the number of retries16:04
dansmithnot less opinionated ones, but better ones16:04
edleafedansmith: jinx (sorta)16:04
dansmithaye16:04
*** toure|biab is now known as toure16:05
*** derekh has quit IRC16:05
bauzasedleafe: dansmith: the fun with that is that the problem still remains for RAMFilter16:06
dansmithbut really,16:06
bauzaseven if we say "fair enough, we don't need to advert operators to modify their ratios for cpu"16:06
*** gongysh has quit IRC16:07
bauzasthe problem remains for ram16:07
dansmithovercommitting the whole node in a single VM is just nuts16:07
dansmitheve more nuts than cpu16:07
dansmithif we want to offer an insanity_mode config option, then let's do it16:07
dansmithand make it clear what it is16:07
dansmithI'll write the patch16:07
*** prateek has quit IRC16:08
bauzasI'm still wondering why we never used CoreFilter in that case16:08
* sfinucan keeps pressing ] on Google to go to the next page :( #gerrithabits16:08
dansmithall I really care about is getting this patch in so we're not kicking it to another release16:08
edleafedansmith: "If you want to stick your fork into the electrical socket..."16:08
dansmithedleafe: that can go in the help text16:08
bauzasso you gonna rev'd my change?16:09
dansmithit doesn't affect your change, right? it'd be a reporting change16:09
dansmithbut yes, if I need to write that patch to move us forward I'll do it16:09
edleafeI think that's the wrong approach16:10
edleafeIt's not breaking anything16:11
*** dikonoor has quit IRC16:11
dansmithedleafe: you think what is wrong? allowing insanity_mode?16:11
edleafedansmith: yes16:11
edleafeIf someone is actively relying on this, they *should* fail16:12
dansmithedleafe: IMHO, I'd wait for people to complain and then do it to get them out of hot water16:12
edleafeand they should feel bad16:12
dansmithhah16:12
dansmithbut if bauzas is going to rage quit now, then I could be persuaded to add it now16:12
dansmithbut I agree, it seems like making better choices to me16:12
bauzasI'm not rage quitting, just exhausted16:12
dansmithjohnthetubaguy: were you one of the concerned porties/16:13
dansmithjeez16:13
dansmith*parties?16:13
bauzasbecause in particular, my f**** change is hitting a functional test issue16:13
bauzasbased on that particular assumption16:13
dansmithbauzas: that's trivial to fix right?16:13
*** mdnadeem has quit IRC16:13
dansmiththat functional test is reporting something that depends on the broken behavior to work, right?16:13
bauzashonestly? I dunno16:13
bauzaswe could fix up what the compute reports16:14
bauzasthat sounds the better approach16:14
*** shewless has quit IRC16:14
dansmithbauzas: you mean what compute reports in that functional test, yes?16:14
bauzasbut those whole tests are so opininiated about what should fail and what should succeed16:14
bauzasdansmith: yup16:14
edleafebauzas: So you think that the test is absolutely correct in what it's testing?16:14
*** mdrabe has quit IRC16:15
bauzasedleafe: I just think that functional test is fine by me, it's just not taking care of other resources16:15
edleafebauzas: or could it be making the same incorrect assumption?16:15
dansmithbauzas: but that test is relying on overcommitting the node with a single vm right?16:15
bauzasedleafe: since we default verifying those resources, we could have to change the tests16:15
edleafeTests are code, and all code has bugs16:15
bauzasdansmith: yup, it was just taking care of RAM previously16:16
dansmithright, so the test is wrong16:16
dansmithlet's fix and move on16:16
*** tbachman has joined #openstack-nova16:16
dansmithI, for one, am fairly concerned about what happens if we don't merge this code this cycle16:16
dansmithI dunno about anyone else16:16
*** owalsh has joined #openstack-nova16:16
* bauzas raises his sleeves16:16
dansmithso I'm really not looking to settle for not landing it for anything other than a major problem16:17
*** markvoelker has joined #openstack-nova16:17
bauzasdansmith: I don't disagree at all16:17
bauzasI'm just focusing on the right path to success16:17
*** armax has joined #openstack-nova16:18
*** mfeoktistov has quit IRC16:18
*** vsaienko has quit IRC16:18
*** markvoelker_ has joined #openstack-nova16:18
johnthetubaguydansmith: +1, I think we have to land it, warts and all16:18
dansmithjohnthetubaguy: so is RAX one that would care about not being able to overcommit the node with a single instance?16:18
johnthetubaguyso I should be very specific on my concern16:19
johnthetubaguyright now we don't run the core filter16:19
*** owalsh_ has quit IRC16:19
johnthetubaguyso the overcomit raito is not set correctly16:19
johnthetubaguythats easily fixable, but does bend our upgrade rules a bit16:19
dansmithjohnthetubaguy: ah I see.. we start honoring a config variable that you may not have had to set before.. that's a rather small bend...16:20
johnthetubaguythe 10vCPU VM on an 8pCPU host doesn't worry me16:20
dansmithjohnthetubaguy: it's also hard to know how we'd communicate that if we were giving a cycle for reprecation16:20
dansmithjohnthetubaguy: also, overcommit on cpu is set to something large by default isn't it?16:21
dansmith16 and 1.516:21
dansmithso people with defaults are probably in the sane range already I'd imagine16:21
johnthetubaguytrue, that is quite high already16:21
*** mdrabe has joined #openstack-nova16:21
dansmithbauzas: are you working on fixing the test?16:22
johnthetubaguythe complexity is certainly less than having to check if the core filter is enabled16:22
*** markvoelker has quit IRC16:22
bauzasdansmith: indeed16:22
dansmithjohnthetubaguy: and more intuitive than having to enable a legacy filter to make the math work like you (should) expect for the new system16:22
dansmithbauzas: okay I'll reply to the ML thread then16:23
bauzasdansmith: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L683 is an example of what I mean by "opiniated"16:23
*** _ducttape_ has quit IRC16:23
*** ducttape_ has joined #openstack-nova16:23
*** sacharya has joined #openstack-nova16:24
*** sacharya has quit IRC16:24
*** mvk has joined #openstack-nova16:25
*** efried has quit IRC16:25
*** karimb has quit IRC16:26
*** udesale has quit IRC16:26
*** lpetrut has quit IRC16:26
sfinucandiana_clarke: Left a comment on https://review.openstack.org/#/c/421333. I can move onto the rest of the series once that's addressed16:28
*** zul has quit IRC16:28
*** annegentle has joined #openstack-nova16:29
*** zul has joined #openstack-nova16:29
*** karimb has joined #openstack-nova16:29
*** shaner has joined #openstack-nova16:31
*** mjura has quit IRC16:32
bauzasdansmith: are you done with replying to my email ? because I can do that by me, I found the solution for the test16:33
*** mingyu has joined #openstack-nova16:33
dansmithjust did16:33
bauzasokay16:33
bauzasI'm just considering how to patch correctly the FakeDriver within that testcase16:34
dansmithcan't you change the request instead of the fake driver?16:34
bauzasdansmith: I would neither change the fake driver itself or the request16:35
bauzasdansmith: the test is RAM-bounded, I'd like to keep it16:35
*** nic has quit IRC16:35
bauzasso my solution is to have enough CPU-filled computes16:35
bauzasso the test would still assume which host would fail and which not but still only based on one metric, which is RAM16:36
bauzasthat's the less invasive16:36
dansmithseems easiest to just request 100% of the compute to fill it, bu okay16:36
*** morgabra has quit IRC16:36
bauzasdansmith: it's sending 3 requests with the same big flavor with the assumption that only RAM would fail16:37
cfriesenhas anyone heard of virt.libvirt.guest.Guest.get_vcpus_map() failing with "exception: Requested operation is not valid: cpu affinity is not supported" ?  Normally this works fine, I just saw it once during a stress test.16:37
*** mingyu has quit IRC16:38
sahidcfriesen: are you in TCG?16:38
*** nic has joined #openstack-nova16:38
sahidyou should to verify first in you have well configured nova.conf to use kvm16:38
sahidshould verify16:39
*** chyka has joined #openstack-nova16:40
cfriesensahid: this is real hardware with kvm16:40
cfriesensahid: most of the time it works fine on this system, but I saw this log once during a test of multiple live migrations.16:41
*** moshele has quit IRC16:41
sahidcfriesen: hum.. so i would suggest to verify whether the intel VT module is well loaded, it's probably something around that16:42
sahidif it's not configuration issue, virt_type=kvm, the module well loaded so you will probably have to report a bug since that seems weird16:43
cfriesensahid: I'm pretty sure that the compute node stayed up and running during the test, but I'll check.16:43
sahidcfriesen: also are you trying to run something related to NUMA ?16:44
cfriesensahid: this is on Mitaka, so I'm not sure how useful a bug report would be.  CPU pinning would be enabled, so it'll be setting up InstanceNUMATopology16:44
cfriesenactually, checking the logs more closely this message occurred multiple times...will dig a bit further, see if I can find a pattern.16:46
*** owalsh_ has joined #openstack-nova16:48
*** owalsh_ has quit IRC16:48
sfinucanvladikr: The reno in https://review.openstack.org/#/c/405951/ is a little confusing16:50
bauzasdansmith: thanks for your email, appreciated16:50
bauzasdansmith: I'm about to find a solution, but since we also have the grenade issue, just lemme know if you wanna recheck anytime16:50
andreas_sthorst_, FYI https://review.openstack.org/#/c/425279/16:50
andreas_sthorst_, it's not as nice than yours, but it does the job automatically16:50
sfinucanPer my understanding, we want this feature because we want the set the VLAN tag inside the guest OS16:51
vladikr sfinucan, hmm, okay.. how can I clarify it?16:51
andreas_sthorst_, basically it's the generated file included into an rst...16:51
*** owalsh has quit IRC16:51
dansmithbauzas: I already did earlier but the gate is pretty slammed16:51
bauzasok16:51
sfinucan...but there's no way to access this from inside the instance without this feature16:51
sfinucanvladikr: Is that correct?16:51
*** owalsh_ has joined #openstack-nova16:51
*** owalsh_ is now known as owalsh16:52
cfriesensahid: It appears to be a race between the resource audit and an instance that is just starting up.  I suspect the domain hasn't yet gotten to a state where it will properly respond to this request.16:52
cfriesensahid: will need to reproduce on newer code before opening a bug report.16:52
*** andreas_s has quit IRC16:53
vladikrsfinucan, pretty much, I think. We can't set anything in side the guest. We want this field to be exposed so the guest so it will set the vlan on a virtual interface - if it need it to be set16:53
*** dtp has joined #openstack-nova16:54
openstackgerritEd Leafe proposed openstack/nova: placement: RT now adds proper Ironic inventory  https://review.openstack.org/40447216:54
vladikrsfinucan, so we just want to add additional parameter to the device metadata (that we have exposed to the guests with the device tagging work)16:55
sahidcfriesen: ok cool, just as a sidenote since you spoke about live-migration: https://review.openstack.org/#/c/419479/16:55
edleafecdent: Fixed your concern ^^16:55
cdentedleafe: thanks. was I crazy or insightful?16:56
edleafeThose are not mutually exclusive16:56
sfinucanvladikr: Right. So this sentence would suggest otherwise >>> "the VLAN configuration for the guest's virtual interfaces associated with such devices, can only be done within the guest instance itself."16:56
sfinucanat least to me, that suggests the guest can now configure VLANs for these interfaces16:57
cdentedleafe: was I right or wrong?16:57
* cdent hopes to be crazy and insightful16:57
edleafecdent: you were right16:57
* cdent gives himself a cookie16:57
vladikrsfinucan, well it says that if you have assigned an sriov device to the guest you will get a virtual interface inside the guest16:57
cfriesensahid: thanks for the reference16:58
sfinucanvladikr: Right, and it's the guest's responsibility to set the VLAN field on that virtual interface?16:58
vladikrsfinucan, the guest can now configure the vNIC using the devices metadata16:58
vladikryea16:58
sfinucanGotcha16:58
sfinucanThat's what I thought, but I wasn't 100% :)16:58
*** markvoelker_ has quit IRC16:59
openstackgerritPawel Koniszewski proposed openstack/nova: Mark live_migration_downtime_steps/delay as deprecated for removal  https://review.openstack.org/40800216:59
*** markvoelker has joined #openstack-nova16:59
vladikrsfinucan, :) maybe it's just too much information there- not sure how to make it better17:02
*** markvoelker has quit IRC17:03
*** chyka has quit IRC17:04
*** Jeffrey4l_ has quit IRC17:06
sfinucanvladikr: Left a comment suggesting as much https://review.openstack.org/#/c/405951/1217:07
vladikrsfinucan, great, thanks17:07
*** owalsh_ has joined #openstack-nova17:07
*** liangy has quit IRC17:07
*** owalsh_ has quit IRC17:08
*** owalsh_ has joined #openstack-nova17:08
*** owalsh has quit IRC17:10
*** owalsh_ is now known as owalsh17:10
cdentedleafe, bauzas, dansmith: because we haven't had enough to read about the resource tracker today, here's some analysis of things it might be doing less than perfectly with regard to the placement api: http://lists.openstack.org/pipermail/openstack-dev/2017-January/110953.html17:12
cdentsome of those are probably well known, but still worth thinking about so we avoid too many requests17:13
*** efried has joined #openstack-nova17:16
*** alexpilotti has quit IRC17:17
*** chyka has joined #openstack-nova17:18
*** alexpilotti has joined #openstack-nova17:19
*** sahid has quit IRC17:19
openstackgerritGábor Antal proposed openstack/nova: Transform instance.live_migration_rollback notification  https://review.openstack.org/40212417:21
*** browne has joined #openstack-nova17:21
*** jaosorior has quit IRC17:22
openstackgerritPushkar Umaranikar proposed openstack/nova: Adopts keystoneauth with glance client.  https://review.openstack.org/41263417:22
*** alexpilotti has quit IRC17:23
*** jheroux has joined #openstack-nova17:24
edleafecdent: yeah, was just reading that17:25
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_instances  https://review.openstack.org/42140417:25
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_cell_and_hosts  https://review.openstack.org/42142017:25
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 verify_instance  https://review.openstack.org/42143617:25
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 simple_cell_setup  https://review.openstack.org/42133317:25
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_cell0  https://review.openstack.org/42138417:25
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 delete_cell  https://review.openstack.org/42145917:25
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 discover_hosts  https://review.openstack.org/42144217:25
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 list_cells  https://review.openstack.org/42145817:25
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 create_cell  https://review.openstack.org/42144417:25
*** Jeffrey4l has joined #openstack-nova17:25
edleafecdent: A lot of those were because of the belts & braces approach to make sure we didn't miss things17:26
cdentsome of them17:26
cdentbut there's outright wrongness with the tracked_instances thing17:26
cdentand the redundancy between update and init is...annoying17:27
vladikrsfinucan, how about https://etherpad.openstack.org/p/pf_vlan_reno ?17:27
*** Swami_ has quit IRC17:27
*** alexpilotti has joined #openstack-nova17:28
*** chyka has quit IRC17:29
*** chyka has joined #openstack-nova17:30
*** Jeffrey4l has quit IRC17:30
*** Apoorva has joined #openstack-nova17:30
bauzasdansmith: I fixed the problem locally with the tests, I'm about to upload it once my run is done17:31
bauzasdansmith: are you investigating on the grenade thing ?17:31
edleafecdent: init should only be run ... well, when the compute node starts up17:31
dansmithbauzas: still waiting to get a slot to run, so just push it up17:31
openstackgerritVladik Romanovsky proposed openstack/nova: Adding vlans field to Device tagging metadata  https://review.openstack.org/40595117:31
dansmither, wait17:31
cdentedleafe: yeah, except that it's not, because it is used as a "make sure it exists"17:32
bauzasdansmith: okay17:32
bauzasdansmith: just lemme know when17:32
bauzasI can look at zuul17:32
dansmithlooks like I never rechecked it but I thought I did17:32
dansmithso yeah, pushj17:32
*** jaosorior has joined #openstack-nova17:32
*** alexpilotti has quit IRC17:32
dansmiththe grenade patch is still waiting17:33
*** tesseract has quit IRC17:33
*** karts has quit IRC17:34
bauzasok17:34
*** chyka has quit IRC17:34
bauzasdansmith: one last full run locally on the test module with now the placement API and I upload17:35
*** baoli has joined #openstack-nova17:35
*** aarefiev is now known as aarefiev_afk17:37
dansmithalright17:37
bauzasKABOOOM17:39
*** chyka has joined #openstack-nova17:40
openstackgerritSylvain Bauza proposed openstack/nova: Scheduler calling the Placement API  https://review.openstack.org/41796117:40
openstackgerritSylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters  https://review.openstack.org/42518517:40
*** alexpilotti has joined #openstack-nova17:44
*** Swami has joined #openstack-nova17:46
*** tbachman has quit IRC17:46
*** alexpilotti has quit IRC17:46
*** alexpilotti has joined #openstack-nova17:47
*** dillaman has quit IRC17:47
*** lpetrut has joined #openstack-nova17:49
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_instances  https://review.openstack.org/42140417:52
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_cell_and_hosts  https://review.openstack.org/42142017:52
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 verify_instance  https://review.openstack.org/42143617:52
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 delete_cell  https://review.openstack.org/42145917:52
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 discover_hosts  https://review.openstack.org/42144217:52
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 list_cells  https://review.openstack.org/42145817:52
openstackgerritDiana Clarke proposed openstack/nova: nova-manage docs: cell_v2 create_cell  https://review.openstack.org/42144417:52
*** dillaman has joined #openstack-nova17:53
*** lucasagomes is now known as lucas-afk17:54
*** karimb has quit IRC17:55
*** ralonsoh has quit IRC17:58
*** beagles is now known as beagles-biab17:59
*** cdent has quit IRC17:59
*** owalsh is now known as owalsh-afk18:03
*** sdague has quit IRC18:03
*** smatzek has quit IRC18:06
*** smatzek has joined #openstack-nova18:06
*** owalsh-afk has quit IRC18:08
*** owalsh-afk has joined #openstack-nova18:09
*** unicell has joined #openstack-nova18:20
*** cdent has joined #openstack-nova18:21
*** READ10 has quit IRC18:23
*** dharinic is now known as dharinic|lunch18:24
*** efoley_ has quit IRC18:26
*** vsaienko has joined #openstack-nova18:27
*** catinthe_ has joined #openstack-nova18:33
*** sambetts is now known as sambetts|afk18:34
openstackgerritmelanie witt proposed openstack/nova: WIP Count resources to check quota for cells  https://review.openstack.org/41652118:34
openstackgerritmelanie witt proposed openstack/nova: Make Quotas object favor the API database  https://review.openstack.org/41094518:34
openstackgerritmelanie witt proposed openstack/nova: Add online migration to move quotas to API database  https://review.openstack.org/41094618:34
dansmithjohnthetubaguy: if you're still around, I'll hit these ^ if you will ack them first18:35
dansmithyou clearly understand quotas :)18:35
*** mingyu has joined #openstack-nova18:35
*** catintheroof has quit IRC18:35
*** Sukhdev has quit IRC18:35
*** Sukhdev has joined #openstack-nova18:36
*** mingyu has quit IRC18:39
*** krtaylor has quit IRC18:40
*** Jeffrey4l has joined #openstack-nova18:41
*** mvk has quit IRC18:42
*** yamahata has joined #openstack-nova18:43
*** jpena is now known as jpena|off18:45
*** Jeffrey4l has quit IRC18:46
*** vsaienko has quit IRC18:46
*** sean-k-mooney has quit IRC18:47
*** sean-k-mooney has joined #openstack-nova18:48
*** markus_z has quit IRC18:51
*** pcaruana has quit IRC18:53
*** tbachman has joined #openstack-nova18:54
*** vsaienko has joined #openstack-nova18:57
*** tbachman has quit IRC18:59
*** tbachman has joined #openstack-nova18:59
*** sdague has joined #openstack-nova19:00
*** alexpilotti has quit IRC19:00
*** FL1SK has quit IRC19:01
*** cdent has quit IRC19:03
*** nicolasbock has quit IRC19:03
*** esmiurium has quit IRC19:05
*** dharinic|lunch is now known as dharinic19:06
*** abalutoiu__ has quit IRC19:06
*** ociuhandu has quit IRC19:07
*** ijw has joined #openstack-nova19:08
*** snikitin_ has joined #openstack-nova19:08
*** ijw has quit IRC19:09
*** ijw has joined #openstack-nova19:09
*** Jeffrey4l has joined #openstack-nova19:10
*** mlavalle has quit IRC19:10
snikitin_mriedem: Hi Matt! I have two +2 on my instance diagnostics patches and I need final +W. Could you please look? https://review.openstack.org/#/c/394480/ https://review.openstack.org/#/c/355540/19:11
*** moshele has joined #openstack-nova19:11
*** liangy has joined #openstack-nova19:11
*** esmiurium has joined #openstack-nova19:12
*** mlavalle has joined #openstack-nova19:12
*** Sukhdev has quit IRC19:13
*** Jeffrey4l has quit IRC19:15
*** alexpilotti has joined #openstack-nova19:15
*** moshele has quit IRC19:18
*** snikitin_ has quit IRC19:18
*** krtaylor has joined #openstack-nova19:18
*** alexpilotti has quit IRC19:19
*** tojuvone has quit IRC19:21
bauzasdansmith: still issues with grenade on the scheduler change even with your PS5 http://logs.openstack.org/61/417961/25/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/405b949/logs/new/screen-n-sch.txt.gz?level=TRACE#_2017-01-25_19_01_47_09919:21
*** jaosorior has quit IRC19:21
bauzaswill look at it later19:21
bauzasfortunatly now the functional job works :)19:23
*** sdague has quit IRC19:26
*** sdague has joined #openstack-nova19:27
*** alexpilotti has joined #openstack-nova19:30
*** alexpilotti has quit IRC19:35
*** mingyu has joined #openstack-nova19:36
openstackgerritEd Leafe proposed openstack/nova: placement: RT now adds proper Ironic inventory  https://review.openstack.org/40447219:36
*** BobBall is now known as BobBall_AWOL19:39
*** mingyu has quit IRC19:40
*** chyka has quit IRC19:45
*** chyka has joined #openstack-nova19:45
*** alexpilotti has joined #openstack-nova19:47
*** abalutoiu__ has joined #openstack-nova19:51
*** alexpilotti has quit IRC19:52
*** Sukhdev has joined #openstack-nova19:52
*** Jeffrey4l has joined #openstack-nova19:58
*** esmiurium has quit IRC19:59
pumaranikarjohnthetubaguy, https://review.openstack.org/#/c/412634/ keystoneauth with glance client. Addressed your comments20:03
*** Jeffrey4l has quit IRC20:04
*** Sukhdev has quit IRC20:05
*** sdague has quit IRC20:06
*** alexpilotti has joined #openstack-nova20:07
*** esmiurium has joined #openstack-nova20:07
*** morgabra has joined #openstack-nova20:08
*** morgabra has quit IRC20:08
*** morgabra has joined #openstack-nova20:08
bauzasdansmith: confirmed that grenade doesn't work correctly with http://logs.openstack.org/30/424730/5/check/gate-grenade-dsvm-neutron-ubuntu-xenial/b39c47f/logs/new/screen-n-cpu.txt.gz#_2017-01-25_17_42_37_32120:08
bauzasdansmith: that's due to auth_url being wrong http://logs.openstack.org/30/424730/5/check/gate-grenade-dsvm-neutron-ubuntu-xenial/b39c47f/logs/etc/nova/nova.conf.txt.gz20:09
bauzasfancy !20:09
bauzasI think I know the problem20:09
bauzasyup, we're missing some vars https://github.com/openstack-dev/devstack/blob/master/lib/placement#L10320:10
bauzasI think we just need to source lib/keystone20:11
*** jaosorior has joined #openstack-nova20:12
*** mvk has joined #openstack-nova20:13
bauzasok, updated, let's wait the run...20:13
*** spligak has quit IRC20:15
*** nicolasbock has joined #openstack-nova20:16
*** beagles-biab is now known as beagles20:16
*** jaosorior has quit IRC20:17
bauzaswow, just wow20:18
*** sdague has joined #openstack-nova20:18
bauzasthe gate is late by more than 4 hours20:18
bauzaschilly20:19
*** moshele has joined #openstack-nova20:23
*** burgerk has quit IRC20:23
*** jaosorior has joined #openstack-nova20:24
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/42482820:26
*** catinthe_ has quit IRC20:27
*** bvanhav has quit IRC20:28
*** efried has quit IRC20:35
*** slaweq has quit IRC20:40
*** slaweq has joined #openstack-nova20:41
*** Jeffrey4l has joined #openstack-nova20:45
*** jamielennox|away has quit IRC20:46
*** shaner has quit IRC20:53
*** owalsh-afk is now known as owalsh20:53
*** sdague has quit IRC20:53
*** sdague has joined #openstack-nova20:54
*** tbachman has quit IRC20:55
*** jamielennox|away has joined #openstack-nova20:56
*** jamielennox|away is now known as jamielennox20:56
*** alexpilotti has quit IRC20:58
*** burgerk has joined #openstack-nova21:00
*** FL1SK has joined #openstack-nova21:01
*** raunak_ has joined #openstack-nova21:01
*** alexpilotti has joined #openstack-nova21:02
*** burgerk_ has joined #openstack-nova21:02
*** shaner has joined #openstack-nova21:04
*** burgerk has quit IRC21:05
*** alexpilotti has quit IRC21:07
bauzasdamn, now a 401 :(21:08
bauzasdansmith: ^21:08
dansmithargh21:08
bauzasnova.conf looks correct http://logs.openstack.org/30/424730/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/16175d7/logs/etc/nova/nova.conf.txt.gz21:09
bauzasbut http://logs.openstack.org/30/424730/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/16175d7/logs/new/screen-n-cpu.txt.gz#_2017-01-25_20_43_30_77421:09
bauzasand cdent bailed out21:10
bauzas:(21:10
bauzasthe creds look correct to me also21:11
*** tbachman has joined #openstack-nova21:14
bauzasdansmith: okay, so when comparing a tempest nova.conf and a grenade nova.conf, both are similar21:14
bauzasI guess the problem is that we don't correctly have the placement API running21:14
*** dimtruck is now known as zz_dimtruck21:16
*** erlon has quit IRC21:20
*** hamzy has quit IRC21:22
*** erlon has joined #openstack-nova21:23
*** mriedem has joined #openstack-nova21:29
*** liangy has quit IRC21:29
mriedemdansmith: how goes it today?21:29
dansmithmriedem: lots of gate failures and still some discussion over the mysql host change21:30
*** eharney has quit IRC21:30
dansmithmriedem: and sounds like bauzas is still struggling with the grenade change21:31
bauzasindeed21:31
mriedemthis https://review.openstack.org/421399 ?21:31
mriedemre: mysql host21:31
bauzasthe gate is also 4 hours off21:31
*** jaosorior has quit IRC21:31
dansmithyeah21:32
mriedemdansmith: we can maybe just drop https://review.openstack.org/42139921:32
bauzasso, today is probably our last chance to get things done21:32
*** kfarr has joined #openstack-nova21:32
dansmithmriedem: we can't because we're discovering from the subnode in the devstack multinode job right?21:32
dansmithsee my comment just now21:32
bauzasandreykurilin: around ?21:32
andreykurilinbauzas: yes21:32
mriedemi couldn't remember if i needed https://review.openstack.org/421399 for how i was previously doing things in devstack21:32
bauzasandreykurilin: where are we wiht all the client changes ?21:33
bauzasmissed a bit of scope since I'm working on another thing21:33
dansmithmriedem: I'm not even sure what variable d-g has that address in21:33
andreykurilinbauzas: all client changes?21:34
*** Jeffrey4l_ has joined #openstack-nova21:34
bauzasandreykurilin: the fixes for 7.1.021:34
bauzasfor *releasing21:35
mriedemdansmith: "Because we're calling discover_hosts from the subnode in devstack-gate" isn't actually true21:35
andreykurilinbauzas: it is the last one - https://review.openstack.org/#/c/424256/21:35
*** owalsh is now known as owalsh-brb21:35
*** Jeffrey4l has quit IRC21:35
dansmithmriedem: eh?21:35
mriedemwe call it from the primary node in d-g21:35
mriedemdansmith: i'm thinking i needed the mysql host fix for something to do with https://review.openstack.org/42097621:36
mriedembut need to remember quick21:36
dansmithmriedem: isn't this using ansible to run it on the subnode? https://review.openstack.org/#/c/424252/4/devstack-vm-gate.sh@23921:36
mriedemdansmith: no,21:36
mriedem$ANSIBLE primary21:36
mriedem== primary node21:36
dansmithwhy via ansible then?21:37
*** mingyu has joined #openstack-nova21:37
mriedembecause that's what runs random shell stuff on the node?21:37
mriedemand what i was told to use21:37
dansmithmriedem: okay21:38
*** jamesdenton has quit IRC21:38
dansmithmriedem: I just removed it, so we'll see21:38
openstackgerritDan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2  https://review.openstack.org/42473721:39
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937921:39
mriedemdansmith: so i just abandoned https://review.openstack.org/#/c/421399/21:39
*** ociuhandu has joined #openstack-nova21:39
mriedemok you broke the connection to it as a dep, good21:40
dansmithyeah21:40
*** raunak_ has quit IRC21:40
*** karimb has joined #openstack-nova21:40
dansmithI still think the assertion that the subnode shouldn't know the database host is based on nova-centric architecture, but happy to have one fewer thing in the dep chain21:41
mriedemyeah basically f it and we'll sort it out later :)21:41
dansmithyep21:41
*** mingyu has quit IRC21:42
*** raunak has joined #openstack-nova21:42
mriedemso the devstack change for discover_hosts should be approved at some point today too, just pinged dtroyer21:43
dansmithI pinged him earlier21:44
dansmiththe --verbose one failed jenkins in the gate, but should be on its way again soon21:44
dansmithcheck was over 300 earlier today, but looks like it has calmed down a bit, which is good21:44
mriedemes muy triste21:45
*** tbachman has quit IRC21:45
dansmithheh21:46
*** zz_dimtruck is now known as dimtruck21:46
dansmithmelwitt: mriedem: should we remove mriedem's -2 on the bottom quotas patch since we're close? maybe let melwitt hold the -2 onit?21:47
dansmithhttps://review.openstack.org/#/c/410945/21:47
dansmithactually can we go ahead and merge the bottom two?21:48
mriedemi thought we weren't going to merge those unless the counting resources one was good21:49
mriedemi've removed the -2 btw21:49
mriedemb/c we don't have reservations in the api db in the bottom changes i thought21:50
dansmithah21:50
dansmiththe counting patch is massive21:51
dansmithwhich I guess is why it's still WIP21:51
mriedemyeah, and probably too risky at this point21:51
mriedemi.e. i think we need more burn in time with testing for a change like that21:52
dansmithso you're calling it?21:52
mriedemso does that automatically mean the bottom two changes can't get in? i believe they will just fallback to the main db for reservations/usages since those won't be in the api db21:52
mriedemwell,21:52
mriedemseems pretty damn risky at this point21:52
mriedemis melwitt around?21:52
dansmithfrom what I saw of the first two, it doesn't really change anything so I would expect the bottom ones are okay, but.. I forgot about reservations21:53
mriedemand usages21:53
mriedemi think those were the 2 tables that weren't being ported21:53
dansmithaye21:54
dansmithwell, john and I have been hitting that hard in the last day expecting to get it in, but I dunno. I guess we'll wait for melwitt to get back and advise21:54
*** owalsh-brb is now known as owalsh21:55
*** cleong has quit IRC21:57
*** raunak has quit IRC21:58
*** alexpilotti has joined #openstack-nova21:59
*** breitz has quit IRC22:00
*** breitz has joined #openstack-nova22:00
*** sdague has quit IRC22:02
*** alexpilotti has quit IRC22:03
bauzasif someone could tell me how we can raise keystoneclient.Unauthorized exceptions when calling https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L616 ...22:09
bauzasI'm puzzled22:09
*** _ducttape_ has joined #openstack-nova22:09
*** eharney has joined #openstack-nova22:09
bauzasmmmmmpf nvm https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L65222:09
*** ducttape_ has quit IRC22:12
bauzasmriedem: still around?22:14
bauzasmriedem: I'd love more context about https://review.openstack.org/#/c/416810/22:15
*** moshele has quit IRC22:16
mriedembauzas: context how?22:20
mriedemdid you read the bug report?22:20
*** raunak has joined #openstack-nova22:20
mriedemor the related change - nova.conf was misconfigured for how to connect to placement for awhile with keystone v322:20
mriedemso you'd get 40122:20
bauzasmriedem: yup, saw the change in devstack lib/placement22:21
bauzasbut I'm hitting the same 401 in grenade job22:21
bauzasAFAICS, the value is still "Default" https://github.com/openstack-dev/devstack/blob/7a1e6f042f00ac94ec30bb8c6bf5d05b34623832/lib/keystone#L10722:22
*** lpetrut has quit IRC22:22
*** gouthamr has quit IRC22:24
mriedemnot sure, would have to see that everything is configured the same and if not, what's different and what's missing22:24
mriedembut i'm taking maya to the pool so back in a few hours22:24
bauzasno worries22:25
*** avolkov has quit IRC22:25
*** browne has quit IRC22:28
*** thorst_ has quit IRC22:28
*** raunak has quit IRC22:29
*** _ducttape_ has quit IRC22:29
*** ducttape_ has joined #openstack-nova22:29
*** raunak has joined #openstack-nova22:30
*** baoli has quit IRC22:31
*** jheroux has quit IRC22:33
*** annegentle has quit IRC22:34
*** tblakes has quit IRC22:38
*** Sukhdev has joined #openstack-nova22:41
*** tbachman has joined #openstack-nova22:43
*** owalsh_ has joined #openstack-nova22:46
*** owalsh has quit IRC22:46
*** owalsh_ is now known as owalsh22:47
*** kaisers_ has quit IRC22:51
*** Guest53005 has quit IRC22:51
*** dave-mcc_ has joined #openstack-nova22:52
*** edmondsw has quit IRC22:52
*** _ducttape_ has joined #openstack-nova22:53
*** dave-mccowan has quit IRC22:54
*** edmondsw has joined #openstack-nova22:55
*** ducttape_ has quit IRC22:56
*** _ducttape_ has quit IRC22:57
*** edmondsw has quit IRC22:59
*** catintheroof has joined #openstack-nova23:00
*** dimtruck is now known as zz_dimtruck23:02
*** Swami has quit IRC23:04
*** mdrabe has quit IRC23:05
*** dave-mcc_ has quit IRC23:05
*** claudiub has quit IRC23:05
*** tbachman has quit IRC23:05
*** dave-mccowan has joined #openstack-nova23:05
*** kfarr has quit IRC23:08
*** zz_dimtruck is now known as dimtruck23:08
*** esmiurium has quit IRC23:09
*** browne has joined #openstack-nova23:10
*** marst has quit IRC23:13
bauzasdansmith: still around?23:15
bauzasdansmith: I wonder if we don't run init_placement() method within grenade23:16
bauzasjust verifying the grenade log, but in case you know...23:16
dansmithbauzas: if you don't see it, then we don't23:17
dansmithbauzas: if we don't in neutron devstack, and you don't see it in grenade then, we don't23:17
bauzassec, verifying the grenade deployment23:17
*** esmiurium has joined #openstack-nova23:18
*** krtaylor has quit IRC23:18
*** hamzy has joined #openstack-nova23:18
bauzasdansmith: confirmed23:18
bauzasdansmith: can't find it in http://logs.openstack.org/30/424730/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/16175d7/logs/grenade.sh.txt.gz23:19
bauzaslemme fix that quickly23:19
*** vsaienko has quit IRC23:20
*** tbachman has joined #openstack-nova23:20
*** xyang1 has quit IRC23:20
bauzasdansmith: do you think we should do that in the from_newton script or in upgrade.sh ?23:20
dansmithfrom-newton23:21
*** kaisers has joined #openstack-nova23:21
bauzasok23:22
*** alexpilotti has joined #openstack-nova23:23
*** alexpilotti has quit IRC23:23
bauzasdansmith: done editing23:23
bauzasdansmith: I'll have to bail out soon, I need to wake up early23:24
dansmithokay23:24
bauzasbut in case it works, could you please look at the change ?23:24
*** dimtruck is now known as zz_dimtruck23:24
bauzasI'll review your own change tomorrow morning23:24
*** ducttape_ has joined #openstack-nova23:25
dansmithcripes I keep failing this one test, but nothing has changed since it was passing23:25
dansmithgrr23:25
bauzaswhich one ?23:26
*** raunak has quit IRC23:26
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/42482823:27
dansmithbauzas: go to sleep23:28
*** raunak has joined #openstack-nova23:28
openstackgerritSylvain Bauza proposed openstack/nova: Scheduler calling the Placement API  https://review.openstack.org/41796123:28
openstackgerritSylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters  https://review.openstack.org/42518523:28
bauzasvoila... all the changes are now rebased23:28
bauzasdansmith: I'll at least wait a few mins to see if we have at least one grenade job done23:29
*** vsaienko has joined #openstack-nova23:30
*** tbachman has quit IRC23:31
dansmithoh jeez23:32
*** mlavalle has quit IRC23:35
openstackgerritDan Smith proposed openstack/nova: Move instance creation to conductor  https://review.openstack.org/31937923:36
*** mingyu has joined #openstack-nova23:39
*** pradk has quit IRC23:40
*** mingyu has quit IRC23:43
*** zz_dimtruck is now known as dimtruck23:44
*** Swami has joined #openstack-nova23:46
*** baoli has joined #openstack-nova23:47
*** tbachman has joined #openstack-nova23:47
*** Swami_ has joined #openstack-nova23:48
*** Swami has quit IRC23:51
*** Swami has joined #openstack-nova23:52
*** Swami_ has quit IRC23:55
*** esberglu has quit IRC23:56
*** catintheroof has quit IRC23:58
*** catintheroof has joined #openstack-nova23:59
*** Swami has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!