artom | gmann, yeah, I guess so, Kevin_Zheng didn't take it personally ;) | 00:00 |
---|---|---|
gmann | cool | 00:00 |
*** sdague has joined #openstack-nova | 00:02 | |
*** dtp has quit IRC | 00:05 | |
*** Swami_ has joined #openstack-nova | 00:08 | |
*** alexpilotti has joined #openstack-nova | 00:09 | |
*** Swami has quit IRC | 00:10 | |
*** tbachman has quit IRC | 00:11 | |
bauzas | folks, calling it a day | 00:11 |
bauzas | \o | 00:11 |
*** nicolasbock has quit IRC | 00:12 | |
bauzas | dansmith: shit http://logs.openstack.org/30/424730/3/check/gate-grenade-dsvm-neutron-ubuntu-xenial/905a9b0/logs/grenade.sh.txt.gz#_2017-01-24_23_54_03_668 | 00:13 |
bauzas | I'll have forge a new rev on the scheduler change because it requires a functional test modification | 00:14 |
*** alexpilotti has quit IRC | 00:15 | |
dansmith | bauzas: I just pushed a rev to the grenade patch | 00:16 |
dansmith | bauzas: stop threatening to sleep and sleep | 00:16 |
bauzas | yeah... | 00:16 |
*** tlian2 has joined #openstack-nova | 00:21 | |
*** hongbin has quit IRC | 00:22 | |
*** tlian has quit IRC | 00:24 | |
*** esberglu has joined #openstack-nova | 00:26 | |
*** mtanino has joined #openstack-nova | 00:26 | |
*** yamahata has quit IRC | 00:27 | |
*** mlavalle has quit IRC | 00:27 | |
*** mtanino_ has quit IRC | 00:28 | |
*** nicolasbock has joined #openstack-nova | 00:28 | |
*** nvela has quit IRC | 00:31 | |
*** esberglu has quit IRC | 00:31 | |
*** mtanino has quit IRC | 00:32 | |
*** nicolasbock has quit IRC | 00:33 | |
*** chyka has quit IRC | 00:33 | |
*** chyka has joined #openstack-nova | 00:34 | |
alex_xu | artom: Kevin_Zheng cool, thanks artom work on it also. today is my last work day before holidays also. | 00:35 |
gmann | alex_xu: oh, then you should review by today :) i ll also review as high priority | 00:37 |
alex_xu | gmann: yea | 00:37 |
gmann | alex_xu: but have a nice holiday any case :) | 00:37 |
alex_xu | gmann: thanks :) | 00:37 |
alex_xu | gmann: would you like help on review this one https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-whitelist-for-server-list-filter-sort-parameters | 00:37 |
gmann | alex_xu: this is winter vacation or something else | 00:37 |
alex_xu | gmann: the policy just updated last night | 00:37 |
gmann | alex_xu: sure ll check it | 00:37 |
alex_xu | gmann: it is chinese new year, we probably disapear while next week | 00:38 |
alex_xu | gmann: thanks | 00:38 |
alex_xu | s/while/whole/ | 00:38 |
*** hoangcx has joined #openstack-nova | 00:39 | |
*** chyka has quit IRC | 00:39 | |
gmann | alex_xu: on policy things, we are going with approach you mentioned like- detection of overridden rule and then leave that as it is and force new behavior for everything else | 00:39 |
alex_xu | gmann: yea | 00:40 |
*** alexpilotti has joined #openstack-nova | 00:41 | |
*** thorst_ has joined #openstack-nova | 00:42 | |
*** zhurong has joined #openstack-nova | 00:45 | |
*** ducttape_ has quit IRC | 00:47 | |
*** nicolasbock has joined #openstack-nova | 00:49 | |
*** amotoki has joined #openstack-nova | 00:49 | |
*** nvela has joined #openstack-nova | 00:51 | |
*** thorst_ has quit IRC | 00:58 | |
*** sdague has quit IRC | 01:01 | |
*** phuongnh has joined #openstack-nova | 01:01 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata https://review.openstack.org/405951 | 01:02 |
*** namnh has joined #openstack-nova | 01:06 | |
*** tbachman has joined #openstack-nova | 01:06 | |
*** tbachman has quit IRC | 01:08 | |
*** tbachman has joined #openstack-nova | 01:09 | |
*** zz_dimtruck is now known as dimtruck | 01:13 | |
*** nic has quit IRC | 01:17 | |
*** ducttape_ has joined #openstack-nova | 01:19 | |
*** nic has joined #openstack-nova | 01:20 | |
*** mtanino has joined #openstack-nova | 01:25 | |
artom | vladikr, I left a comment on https://review.openstack.org/#/c/405951/9 about the feasibility of a Tempest test | 01:28 |
vladikr | artom, great, thanks | 01:28 |
vladikr | ! | 01:28 |
vladikr | :) | 01:28 |
artom | vladikr, does it make sense to you? Can you think of a third party CI where we would be able to test this? | 01:30 |
vladikr | artom, mellanox perhaps.. but they have issues with testing macvtap and I'm not sure if they are testing PF assignment | 01:31 |
artom | vladikr, hrmpf. Oh well, we'll see what Matt says tomorrow | 01:33 |
*** tbachman_ has joined #openstack-nova | 01:33 | |
vladikr | artom, yeah, thanks! | 01:33 |
*** tbachman has quit IRC | 01:34 | |
*** tbachman_ is now known as tbachman | 01:34 | |
*** jaypipes_ has quit IRC | 01:41 | |
*** tovin07_ has joined #openstack-nova | 01:43 | |
*** John341__ has quit IRC | 01:43 | |
*** Sukhdev has quit IRC | 01:45 | |
*** John341_ has joined #openstack-nova | 01:45 | |
*** jose-phillips has quit IRC | 01:49 | |
*** huanxie has joined #openstack-nova | 01:49 | |
*** yuntongjin has joined #openstack-nova | 01:50 | |
nvela | PING | 01:53 |
*** jose-phillips has joined #openstack-nova | 01:56 | |
*** jaypipes_ has joined #openstack-nova | 01:58 | |
openstackgerrit | Zhenguo Niu proposed openstack/nova: Fix breaking out of nested loops https://review.openstack.org/424931 | 01:59 |
*** yuntongjin has quit IRC | 02:00 | |
*** Swami_ has quit IRC | 02:00 | |
*** jamesden_ has joined #openstack-nova | 02:04 | |
*** nvela has quit IRC | 02:05 | |
*** ducttape_ has quit IRC | 02:06 | |
*** kaisers has quit IRC | 02:07 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 02:08 |
*** ducttape_ has joined #openstack-nova | 02:10 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 02:10 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 02:11 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 02:11 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 02:11 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host https://review.openstack.org/406707 | 02:12 |
*** mtanino has quit IRC | 02:12 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix path parameters in os-hypervisors.inc https://review.openstack.org/416911 | 02:12 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Avoid forcing translation on logging calls https://review.openstack.org/413876 | 02:13 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix keypair API parameters https://review.openstack.org/420626 | 02:13 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Refactor a test method including 3 test cases https://review.openstack.org/394738 | 02:13 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases https://review.openstack.org/395436 | 02:13 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444 | 02:13 |
*** pradk has quit IRC | 02:13 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix deprecated proxy API parameters https://review.openstack.org/416882 | 02:13 |
*** Apoorva has quit IRC | 02:14 | |
*** sacharya has joined #openstack-nova | 02:15 | |
openstackgerrit | Zhenguo Niu proposed openstack/nova: Fix breaking out of nested loops https://review.openstack.org/424931 | 02:16 |
*** browne has quit IRC | 02:16 | |
*** Apoorva has joined #openstack-nova | 02:16 | |
*** karimb has quit IRC | 02:18 | |
*** Apoorva has quit IRC | 02:18 | |
*** jamesden_ has quit IRC | 02:24 | |
*** armax has quit IRC | 02:31 | |
*** haplo37 has quit IRC | 02:34 | |
*** tbachman has quit IRC | 02:34 | |
*** haplo37 has joined #openstack-nova | 02:42 | |
*** pradk has joined #openstack-nova | 02:43 | |
*** jamesdenton has joined #openstack-nova | 02:43 | |
*** sudipto has joined #openstack-nova | 02:47 | |
*** sudipto_ has joined #openstack-nova | 02:47 | |
*** browne has joined #openstack-nova | 02:51 | |
*** tlian2 has quit IRC | 02:56 | |
*** thorst_ has joined #openstack-nova | 02:57 | |
*** thorst_ has quit IRC | 02:57 | |
*** yuntongjin has joined #openstack-nova | 02:59 | |
*** hongbin has joined #openstack-nova | 03:02 | |
*** tommylikehu has quit IRC | 03:05 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142 | 03:07 |
*** takashin has left #openstack-nova | 03:08 | |
*** mriedem has joined #openstack-nova | 03:11 | |
*** pradk has quit IRC | 03:15 | |
*** duonghq has joined #openstack-nova | 03:17 | |
duonghq | Hello, have we close "remove-mox" for Ocata cycle? | 03:17 |
*** jamesdenton has quit IRC | 03:20 | |
*** hongbin has quit IRC | 03:20 | |
*** pbandark has joined #openstack-nova | 03:21 | |
*** hongbin has joined #openstack-nova | 03:21 | |
*** ijw has quit IRC | 03:21 | |
*** browne has quit IRC | 03:23 | |
*** dikonoor has joined #openstack-nova | 03:26 | |
*** gszasz has quit IRC | 03:26 | |
mriedem | duonghq: those can still go in until thursday | 03:27 |
mriedem | duonghq: but i suspect those aren't getting much review attention right now as we try to close other higher priority things out | 03:27 |
mriedem | duonghq: anything that does not make it in ocata will just be deferred to pike | 03:28 |
duonghq | mriedem, thank you | 03:28 |
duonghq | hope that somebody can give me review on https://review.openstack.org/#/c/342648/ | 03:28 |
duonghq | due to this is last commit of the chain for test_shelve | 03:29 |
duonghq | :) | 03:29 |
*** hfu has joined #openstack-nova | 03:32 | |
openstackgerrit | liusheng proposed openstack/nova: Trivial-fix: replace "json" with "yaml" in policy README https://review.openstack.org/424961 | 03:33 |
*** udesale has joined #openstack-nova | 03:33 | |
duonghq | sfinucan, are you there? due to you reviewed all others my ps about remove-mox of test_shelve, can you review the last one: https://review.openstack.org/#/c/342593/ | 03:33 |
*** gcb has joined #openstack-nova | 03:38 | |
*** ijw has joined #openstack-nova | 03:42 | |
*** Apoorva has joined #openstack-nova | 03:44 | |
*** Apoorva_ has joined #openstack-nova | 03:46 | |
*** browne has joined #openstack-nova | 03:46 | |
*** ijw has quit IRC | 03:46 | |
Kevin_Zheng | mriedem: could you have a look on https://review.openstack.org/415142 and https://review.openstack.org/#/c/415330/ ? | 03:47 |
mriedem | Kevin_Zheng: yeah i have the first open right now | 03:47 |
Kevin_Zheng | Yeah, thanks, it's the last day before alex on holiday, so kind hope it can be merged today | 03:48 |
Kevin_Zheng | go for launch, will address any comment at that, thanks alot' | 03:49 |
*** Apoorva has quit IRC | 03:49 | |
*** yuntongjin has quit IRC | 03:51 | |
*** ducttape_ has quit IRC | 03:57 | |
*** mdnadeem has joined #openstack-nova | 03:59 | |
*** marst has joined #openstack-nova | 04:01 | |
*** tovin07 has quit IRC | 04:02 | |
*** armax has joined #openstack-nova | 04:10 | |
gmann | Kevin_Zheng: alex_xu policy one looks fine to me | 04:14 |
*** ljxiash has joined #openstack-nova | 04:15 | |
gmann | Kevin_Zheng: alex_xu my concern for overriding with default value is fine now as we will honor those in same way as they are overridden. means no affect on old deployer | 04:15 |
*** nicolasbock has quit IRC | 04:16 | |
mriedem | dansmith: i guess we need to remove the WIP on this https://review.openstack.org/#/c/424730/ | 04:19 |
mriedem | i think sdague is going to ask that the commit message point to a nova change with a release note saying why we need the from-newton step, which would be bauzas' filter scheduler change | 04:20 |
mriedem | i'll just leave a comment on there, but jenkins is happy with it which is good | 04:21 |
*** hongbin has quit IRC | 04:23 | |
*** browne has quit IRC | 04:23 | |
mriedem | Kevin_Zheng: left a question in https://review.openstack.org/#/c/415142/ | 04:24 |
*** ducttape_ has joined #openstack-nova | 04:24 | |
*** ljxiash has quit IRC | 04:26 | |
*** ljxiash has joined #openstack-nova | 04:27 | |
alex_xu | mriedem: thanks, looks like we just miss that key. | 04:29 |
mriedem | do we want to be able to filter on instance_type_id? | 04:30 |
mriedem | s/filter/sort/ | 04:30 |
*** dave-mccowan has quit IRC | 04:30 | |
alex_xu | there should be alias for that, it called flavor I remember | 04:30 |
*** armax has quit IRC | 04:30 | |
mriedem | ok | 04:30 |
mriedem | yeah i know we leak the flavor.id out of the REST API | 04:30 |
alex_xu | in the filter, that is flavor.flavor_id | 04:31 |
*** ljxiash has quit IRC | 04:31 | |
mriedem | ok | 04:31 |
mriedem | i'll check back on it tomorrow | 04:31 |
mriedem | i've got to go to bed | 04:31 |
alex_xu | mriedem: thanks, have good sleep | 04:31 |
mriedem | other than that it's looking good so shouldn't be a problem to get it in tomorrow | 04:32 |
mriedem | alex_xu: just +2 when you're happy with it | 04:32 |
*** mriedem has quit IRC | 04:32 | |
alex_xu | gmann: thanks for the review | 04:35 |
*** Sukhdev has joined #openstack-nova | 04:37 | |
alex_xu | gmann: re: https://review.openstack.org/#/c/415330/21/nova/tests/unit/api/openstack/compute/test_serversV21.py, are you looking for cases for the new rule is overriden? | 04:38 |
alex_xu | if you are looking for the cases for old rule is overriden, it is already there. | 04:39 |
*** jose-phillips has quit IRC | 04:40 | |
*** hongbin has joined #openstack-nova | 04:41 | |
*** browne has joined #openstack-nova | 04:41 | |
*** diga has joined #openstack-nova | 04:41 | |
*** psachin has joined #openstack-nova | 04:42 | |
*** gcb has quit IRC | 04:43 | |
*** gcb has joined #openstack-nova | 04:44 | |
*** ayogi has joined #openstack-nova | 04:45 | |
*** ducttape_ has quit IRC | 04:46 | |
*** sree has joined #openstack-nova | 04:46 | |
*** sree has quit IRC | 04:46 | |
*** sree has joined #openstack-nova | 04:46 | |
gmann | alex_xu: yea, old rule is there. i was thinking we can have tests only with new rule(overridden and not overridden) which are nothing but new deployer | 04:46 |
*** hongbin has quit IRC | 04:53 | |
*** armax has joined #openstack-nova | 04:55 | |
*** yamahata has joined #openstack-nova | 04:56 | |
*** armax has quit IRC | 04:56 | |
*** thorst_ has joined #openstack-nova | 04:59 | |
*** edmondsw has joined #openstack-nova | 05:02 | |
*** thorst_ has quit IRC | 05:03 | |
*** adisky_ has joined #openstack-nova | 05:04 | |
*** jamielennox is now known as jamielennox|away | 05:06 | |
*** edmondsw has quit IRC | 05:06 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142 | 05:11 |
*** prateek has joined #openstack-nova | 05:11 | |
*** udesale__ has joined #openstack-nova | 05:17 | |
*** udesale has quit IRC | 05:17 | |
*** gongysh has joined #openstack-nova | 05:18 | |
*** ratailor has joined #openstack-nova | 05:18 | |
*** udesale has joined #openstack-nova | 05:19 | |
*** tlbr_ has quit IRC | 05:20 | |
*** ljxiash has joined #openstack-nova | 05:20 | |
*** udesale__ has quit IRC | 05:21 | |
*** lpetrut has joined #openstack-nova | 05:33 | |
*** Apoorva_ has quit IRC | 05:43 | |
*** ducttape_ has joined #openstack-nova | 05:46 | |
*** sudswas__ has joined #openstack-nova | 05:47 | |
*** tlbr has joined #openstack-nova | 05:49 | |
*** sudipto has quit IRC | 05:50 | |
*** sudipto_ has quit IRC | 05:50 | |
*** sudipto has joined #openstack-nova | 05:50 | |
*** sacharya has quit IRC | 05:51 | |
*** ducttape_ has quit IRC | 05:51 | |
*** kaisers has joined #openstack-nova | 06:06 | |
*** irenab_ has joined #openstack-nova | 06:11 | |
*** irenab_ has quit IRC | 06:12 | |
*** armax has joined #openstack-nova | 06:13 | |
*** slagle has quit IRC | 06:15 | |
*** Prophidys has quit IRC | 06:16 | |
*** armax has quit IRC | 06:16 | |
*** Prophidys has joined #openstack-nova | 06:16 | |
*** slagle has joined #openstack-nova | 06:17 | |
*** jpena|off has quit IRC | 06:18 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142 | 06:18 |
*** jpena|off has joined #openstack-nova | 06:20 | |
openstackgerrit | Sreeram Vancheeswaran proposed openstack/nova: [WIP] Driver function call to enable attach volume for nova-dpm https://review.openstack.org/424996 | 06:25 |
*** ekuris_ has joined #openstack-nova | 06:34 | |
*** Sukhdev has quit IRC | 06:39 | |
*** lpetrut has quit IRC | 06:45 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | 06:48 |
*** mjura has joined #openstack-nova | 06:48 | |
*** Jeffrey4l_ has quit IRC | 06:48 | |
*** ratailor is now known as ratailor|afk | 06:49 | |
*** edmondsw has joined #openstack-nova | 06:51 | |
*** Jeffrey4l has joined #openstack-nova | 06:53 | |
*** tovin07 has joined #openstack-nova | 06:54 | |
*** edmondsw has quit IRC | 06:55 | |
*** udesale__ has joined #openstack-nova | 06:56 | |
*** hoangcx_ has joined #openstack-nova | 06:57 | |
*** thorst_ has joined #openstack-nova | 06:59 | |
*** hoangcx has quit IRC | 07:00 | |
*** thorst_ has quit IRC | 07:04 | |
*** namnh has quit IRC | 07:06 | |
*** aojea has quit IRC | 07:06 | |
*** sridharg has joined #openstack-nova | 07:09 | |
*** sudipto_ has joined #openstack-nova | 07:13 | |
*** sudipto has quit IRC | 07:14 | |
*** sudswas__ has quit IRC | 07:14 | |
*** Oku_OS-away is now known as Oku_OS | 07:14 | |
*** sudipto has joined #openstack-nova | 07:14 | |
*** ratailor|afk is now known as ratailor | 07:14 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add release note and docs for filter/sort whitelist https://review.openstack.org/421760 | 07:17 |
*** ducttape_ has joined #openstack-nova | 07:17 | |
*** mpaolino has joined #openstack-nova | 07:18 | |
*** aojea has joined #openstack-nova | 07:19 | |
*** dimtruck is now known as zz_dimtruck | 07:20 | |
*** markus_z has joined #openstack-nova | 07:22 | |
*** ducttape_ has quit IRC | 07:22 | |
*** pcaruana has joined #openstack-nova | 07:28 | |
*** hfu has quit IRC | 07:29 | |
*** hfu has joined #openstack-nova | 07:30 | |
*** hfu has quit IRC | 07:30 | |
*** tovin07 has quit IRC | 07:32 | |
*** tesseract has joined #openstack-nova | 07:34 | |
*** andreas_s has joined #openstack-nova | 07:37 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add "supports_device_tagging" in fake driver for tests https://review.openstack.org/425030 | 07:45 |
*** tovin07 has joined #openstack-nova | 07:45 | |
*** hoangcx has joined #openstack-nova | 07:46 | |
*** browne has quit IRC | 07:46 | |
*** moshele has joined #openstack-nova | 07:48 | |
gmann | alex_xu: Kevin_Zheng this was causing issue on tag fix patch - https://review.openstack.org/#/c/425030/1 | 07:48 |
*** hoangcx_ has quit IRC | 07:48 | |
Kevin_Zheng | gmann: AH, thanks | 07:49 |
*** sahid has joined #openstack-nova | 07:52 | |
alex_xu | gmann: cool | 07:52 |
*** lennyb has joined #openstack-nova | 07:53 | |
*** abalutoiu_ has quit IRC | 07:54 | |
*** mingyu has joined #openstack-nova | 07:54 | |
*** avolkov has quit IRC | 07:56 | |
*** lennyb has quit IRC | 07:57 | |
*** avolkov has joined #openstack-nova | 07:57 | |
*** sree_ has joined #openstack-nova | 08:02 | |
*** sree_ is now known as Guest54535 | 08:02 | |
*** sree has quit IRC | 08:02 | |
*** kaisers_ has joined #openstack-nova | 08:07 | |
*** lennyb_ has joined #openstack-nova | 08:09 | |
*** lennyb_ has quit IRC | 08:09 | |
*** lennyb has joined #openstack-nova | 08:10 | |
*** yonglihe has joined #openstack-nova | 08:11 | |
*** kaisers has quit IRC | 08:11 | |
*** yonglihe has left #openstack-nova | 08:12 | |
*** yonglihe has joined #openstack-nova | 08:12 | |
*** tovin07 has quit IRC | 08:13 | |
*** abalutoiu_ has joined #openstack-nova | 08:17 | |
*** yuntongjin has joined #openstack-nova | 08:20 | |
*** ralonsoh has joined #openstack-nova | 08:24 | |
*** tovin07 has joined #openstack-nova | 08:29 | |
*** Jeffrey4l_ has joined #openstack-nova | 08:30 | |
*** avolkov has quit IRC | 08:31 | |
*** Matias has quit IRC | 08:33 | |
*** Jeffrey4l has quit IRC | 08:34 | |
*** moshele has quit IRC | 08:34 | |
*** moshele has joined #openstack-nova | 08:34 | |
*** avolkov has joined #openstack-nova | 08:35 | |
*** Matias has joined #openstack-nova | 08:36 | |
*** Matias has quit IRC | 08:41 | |
*** hfu has joined #openstack-nova | 08:42 | |
*** lpetrut has joined #openstack-nova | 08:42 | |
*** lpetrut has quit IRC | 08:42 | |
*** lpetrut has joined #openstack-nova | 08:44 | |
openstackgerrit | Hironori Shiina proposed openstack/nova: Ironic: Add soft power off support to Ironic driver. https://review.openstack.org/407977 | 08:45 |
*** amotoki has quit IRC | 08:47 | |
*** ducttape_ has joined #openstack-nova | 08:48 | |
*** hferenc has joined #openstack-nova | 08:50 | |
*** abalutoiu__ has joined #openstack-nova | 08:50 | |
*** yuntongjin has quit IRC | 08:50 | |
*** ducttape_ has quit IRC | 08:52 | |
*** abalutoiu_ has quit IRC | 08:53 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | 08:54 |
*** Matias has joined #openstack-nova | 08:55 | |
*** tlbr has quit IRC | 08:58 | |
*** hfu has quit IRC | 08:59 | |
*** hoangcx has quit IRC | 09:00 | |
*** zzzeek has quit IRC | 09:00 | |
*** thorst_ has joined #openstack-nova | 09:00 | |
*** zzzeek has joined #openstack-nova | 09:00 | |
*** tovin07 has quit IRC | 09:00 | |
claudiub|2 | moshele: hi. I've replied to your comments on https://review.openstack.org/#/c/420614/ . Regarding PF/VF passthrough, I *might* be able to get a compute node with such capabilities today, so I check that out as well. | 09:01 |
*** claudiub|2 is now known as claudiub | 09:02 | |
openstackgerrit | Rikimaru Honjo proposed openstack/nova: Add checks for preventing unexpected detaching volume https://review.openstack.org/354617 | 09:02 |
*** thorst_ has quit IRC | 09:05 | |
sfinucan | duonghq: Here now (Irish time). I'll take a look | 09:06 |
*** tlbr has joined #openstack-nova | 09:06 | |
*** hfu has joined #openstack-nova | 09:08 | |
*** jpena|off is now known as jpena | 09:11 | |
moshele | claudiub|2: cool | 09:13 |
moshele | claudiub: cool | 09:13 |
sahid | johnthetubaguy: any chance you ack that one https://review.openstack.org/#/c/400874/, jaypipes already +2 it but i holidays now | 09:13 |
*** zhurong has quit IRC | 09:14 | |
*** tovin07 has joined #openstack-nova | 09:15 | |
openstackgerrit | Moshe Levi proposed openstack/nova: PCI: Check pci_requests object is empty before passing to support_requests https://review.openstack.org/423608 | 09:16 |
lyarwood | https://review.openstack.org/#/c/420146/ looking for a final core +2 +W on this findmnt workaround if anyone has time this morning | 09:20 |
openstackgerrit | Guillaume Espanel proposed openstack/nova: Reduce time and memory usage of tenant usage. https://review.openstack.org/343734 | 09:20 |
*** efoley has joined #openstack-nova | 09:21 | |
*** efoley_ has joined #openstack-nova | 09:23 | |
*** jpena is now known as jpena|off | 09:25 | |
lyarwood | johnthetubaguy, mikal, tonyb, claudiub ; I'm also looking to land https://review.openstack.org/#/c/412201/ on stable/newton today if anyone has the time to review this. | 09:26 |
*** hfu_ has joined #openstack-nova | 09:26 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Disallow assgined floating IP that already assigned to other ports. https://review.openstack.org/425077 | 09:26 |
*** efoley has quit IRC | 09:27 | |
*** lucas-afk is now known as lucasagomes | 09:27 | |
*** hfu has quit IRC | 09:29 | |
*** liusheng has quit IRC | 09:29 | |
*** yassine has joined #openstack-nova | 09:29 | |
*** yassine is now known as Guest53005 | 09:30 | |
duonghq | sfinucan, thank you | 09:31 |
*** jpena|off is now known as jpena | 09:31 | |
gcb | sfinucan: I think we can merge another python 3 enable patch now :) https://review.openstack.org/#/c/414420/ | 09:36 |
*** mdnadeem has quit IRC | 09:37 | |
sfinucan | gcb: I think the same :) | 09:37 |
gcb | sfinucan, cool, thanks | 09:39 |
*** mdnadeem has joined #openstack-nova | 09:39 | |
*** ljxiash has quit IRC | 09:40 | |
*** tovin07 has quit IRC | 09:41 | |
lyarwood | johnthetubaguy, claudiub ; thanks! :) | 09:42 |
sfinucan | lyarwood: Backporting is simply 'cherry-pick -x', right? | 09:47 |
*** udesale__ has quit IRC | 09:47 | |
*** udesale has quit IRC | 09:47 | |
* sfinucan could only find this (rather unhelpful) guide http://docs.openstack.org/contributor-guide/additional-git-workflow/backport.html | 09:47 | |
*** derekh has joined #openstack-nova | 09:47 | |
lyarwood | sfinucan: yeah, there's better docs here http://docs.openstack.org/project-team-guide/stable-branches.html | 09:48 |
sfinucan | Actually, do we still bother with those 'backport' lines? I figured every bug should be backported, if it applied to the stable code too and didn't introduce a functional change | 09:48 |
sfinucan | lyarwood: (y) | 09:48 |
lyarwood | sfinucan: http://docs.openstack.org/project-team-guide/stable-branches.html#proposing-fixes for the actual workflow | 09:48 |
openstackgerrit | Duong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (3) https://review.openstack.org/342648 | 09:48 |
*** adisky_ has quit IRC | 09:49 | |
sfinucan | lyarwood: Excellent. Thank you. Think I've done it now (https://review.openstack.org/425087) | 09:49 |
sfinucan | Hmm, commits to stable branches don't appear in IRC. Interesting... | 09:50 |
sfinucan | duonghq: Thanks for respinning that. Appreciate it :) | 09:51 |
duonghq | sfinucan, thank you very much | 09:52 |
*** tovin07_ has quit IRC | 09:55 | |
*** sahid has quit IRC | 09:57 | |
*** sahid has joined #openstack-nova | 09:59 | |
*** tlbr has quit IRC | 10:02 | |
*** duonghq has quit IRC | 10:05 | |
*** sambetts|afk is now known as sambetts | 10:13 | |
*** hfu_ has quit IRC | 10:16 | |
*** phuongnh has quit IRC | 10:17 | |
*** openstackgerrit has quit IRC | 10:17 | |
*** amotoki has joined #openstack-nova | 10:19 | |
*** mdnadeem has quit IRC | 10:21 | |
*** ociuhandu has joined #openstack-nova | 10:22 | |
*** openstackgerrit has joined #openstack-nova | 10:23 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: adding debug info for pinning calculation https://review.openstack.org/355150 | 10:23 |
*** mvk has quit IRC | 10:23 | |
*** edmondsw has joined #openstack-nova | 10:28 | |
*** yuntongjin has joined #openstack-nova | 10:28 | |
*** mingyu has quit IRC | 10:29 | |
*** mdnadeem has joined #openstack-nova | 10:29 | |
*** owalsh-afk is now known as owalsh | 10:30 | |
*** sree has joined #openstack-nova | 10:31 | |
*** cdent has joined #openstack-nova | 10:31 | |
*** edmondsw has quit IRC | 10:32 | |
*** aarefiev_afk is now known as aarefiev | 10:32 | |
*** Guest54535 has quit IRC | 10:33 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add PCIWeigher https://review.openstack.org/379524 | 10:36 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs: Remove templates from approved/implemented specs https://review.openstack.org/405550 | 10:37 |
*** Nisha_ has joined #openstack-nova | 10:37 | |
*** tlbr has joined #openstack-nova | 10:38 | |
*** Guest53005 has quit IRC | 10:41 | |
*** zerda2 has joined #openstack-nova | 10:41 | |
*** zerda2 has quit IRC | 10:41 | |
*** zerda2 has joined #openstack-nova | 10:41 | |
*** zerda2 has quit IRC | 10:43 | |
*** zerda2 has joined #openstack-nova | 10:43 | |
openstackgerrit | Huan Xie proposed openstack/nova: Fix live migrate with XenServer https://review.openstack.org/424428 | 10:44 |
*** huanxie has quit IRC | 10:45 | |
*** tlbr has quit IRC | 10:46 | |
*** yuntongjin has quit IRC | 10:49 | |
*** sree has quit IRC | 10:53 | |
*** sree has joined #openstack-nova | 10:53 | |
*** Nisha_ has quit IRC | 10:53 | |
*** Guest53005 has joined #openstack-nova | 10:55 | |
*** sree has quit IRC | 10:55 | |
*** mvk has joined #openstack-nova | 10:56 | |
*** yamahata has quit IRC | 10:56 | |
bhagyashris | Hi all, I have one question, In the multinode environment , Is there a need to enable the placement api service on compute node also? | 10:58 |
openstackgerrit | Vasyl Saienko proposed openstack/nova: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | 10:58 |
johnthetubaguy | bhagyashris: everything talks to a single placement API endpoint (as defined in the keystone service catalog), over HTTP, if that helps. | 10:59 |
*** tlbr has joined #openstack-nova | 10:59 | |
BobBall | johnthetubaguy: Regarding https://review.openstack.org/#/c/424428/3/nova/objects/migrate_data.py is the "legacy dictionary" used anywhere now? i.e. should the to_legacy_dict method care about new fields added to the object? | 11:01 |
*** thorst_ has joined #openstack-nova | 11:01 | |
johnthetubaguy | BobBall: I suspect now both old a new nodes are sending objects, we can drop all that code | 11:01 |
BobBall | Rather than dropping in this patch I was assuming not bothering updating the legacy dict? | 11:02 |
johnthetubaguy | BobBall: although technically speaking, we should bump the compute API major version to make that explicit | 11:02 |
BobBall | I presume there should be a more global legacy-dictionary cleanup effort? rather than a per-object piecemeal approach? | 11:02 |
BobBall | bah, you know what, the easiest path is just to update the dict anyway. Makes sure that if there is any dodgy code anywhere that it'll all work... | 11:03 |
johnthetubaguy | BobBall: I like being consistent and updating that, if I am honest, but I have no functional reason, just prettyness | 11:03 |
ildikov | johnthetubaguy: hi. can you look into this Doodle poll please: http://doodle.com/poll/9per237agrdy7rqz ? | 11:04 |
*** thorst_ has quit IRC | 11:05 | |
ildikov | johnthetubaguy: I know you have collisions around the time slot I hope to keep on other days, but Monday is unfortunately not working for a few Cinder guys :( | 11:06 |
johnthetubaguy | ildikov: so its not too bad until we high daylight savings, when many of the other days are tricky | 11:07 |
johnthetubaguy | ildikov: but hopefully we will have complete all our work by then :) | 11:07 |
ildikov | johnthetubaguy: we can reconsider when we switch again | 11:08 |
johnthetubaguy | that too | 11:08 |
ildikov | johnthetubaguy: hehe, I like your optimism! :) | 11:08 |
ildikov | johnthetubaguy: I just would like to have a slot that works for most so we can prep for the PTG | 11:08 |
*** nicolasbock has joined #openstack-nova | 11:09 | |
ildikov | johnthetubaguy: so that we can complete all our work before the next daylight savings switch ;) | 11:09 |
ildikov | johnthetubaguy: great, thank you! | 11:09 |
ildikov | johnthetubaguy: I will harass a few Cinder folks and it seems we will most prolly switch back to Thursdays for a bit, will announce this week I hope | 11:10 |
*** hfu has joined #openstack-nova | 11:14 | |
bauzas | cdent: mmm, there is a bug with https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L129-L131 | 11:16 |
bauzas | cdent: swap is counted in MB | 11:16 |
bauzas | cdent: https://github.com/openstack/nova/blob/master/nova/scheduler/filters/disk_filter.py#L36-L38 | 11:16 |
bauzas | so we don't report correctly the right size | 11:17 |
cdent | whoops | 11:17 |
bauzas | just creating a bug report | 11:17 |
cdent | nice find | 11:17 |
mdbooth | bauzas: I've hit that a bunch of times, btw. In general, I'd prefer to see a coding style guideline that all storage sizes are in bytes. | 11:20 |
mdbooth | We variously use B, MB and GB throughout the code, and it's super-easy to make mistakes. | 11:21 |
cdent | it's good ux for it be other things for humans, but yeah, as soon as the data passes into internal code it ought to be all the same | 11:21 |
bauzas | mdbooth: sure but changing the Flavors attributes seems a bit long to do | 11:22 |
mdbooth | Yep | 11:22 |
mdbooth | bauzas: Oh, yeah. I think we need to live with our existing mistakes :) Just not make new ones. | 11:22 |
*** owalsh is now known as owalsh-afk | 11:23 | |
*** cdelatte has quit IRC | 11:23 | |
mdbooth | i.e. Any new code which represents a storage size should use bytes exclusively. | 11:23 |
*** rfolco has joined #openstack-nova | 11:26 | |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Mock is_job_complete in test_driver https://review.openstack.org/425140 | 11:27 |
mdbooth | lyarwood: ^^^ | 11:27 |
*** jbernard has quit IRC | 11:27 | |
mdbooth | lyarwood: Could you take a quick look at the above change. If you approve, I would rebase your mirror attribute fix on top of it and remove all the changes in test_driver.py | 11:28 |
*** owalsh-afk has quit IRC | 11:28 | |
*** mingyu has joined #openstack-nova | 11:29 | |
bauzas | mdbooth: agreed | 11:29 |
*** yuntongjin has joined #openstack-nova | 11:29 | |
bauzas | mdbooth: it should count on bytes | 11:29 |
bauzas | cdent: FYI https://bugs.launchpad.net/nova/+bug/1659266 | 11:30 |
openstack | Launchpad bug 1659266 in OpenStack Compute (nova) "Disk allocation for instance is not good with swap" [High,Confirmed] | 11:30 |
cdent | ✔ | 11:30 |
lyarwood | mdbooth: thanks, yeah that looks good if people are happy for us to mix mox and mock, I assumed there was an unwritten rule stopping us from doing this | 11:30 |
mdbooth | lyarwood: I think we don't write new mox. Partial mox->mock is acceptable, I believe? | 11:31 |
bauzas | cdent: in theory, we would need to data migrate the existing allocations | 11:31 |
mdbooth | I mean going the whole hog is great. The main change is from functional->unity there, rather than mox->mock | 11:31 |
bauzas | cdent: are we wiping off the existing allocations somewhere when we auto-heal ? | 11:31 |
lyarwood | mdbooth: yeah, I might stash what I have and follow up with the full move to mock after this | 11:32 |
mdbooth | lyarwood: As I mention in the commit, we should either have a test library for this, or mock at the function boundary. | 11:32 |
*** jbernard has joined #openstack-nova | 11:32 | |
*** ociuhandu has quit IRC | 11:32 | |
mdbooth | The real change is mocking is_job_complete, rather than modelling the corresponding behaviour of the libvirt daemon. | 11:33 |
mdbooth | I prefer the latter, but we don't have that in place, and doing it piecemeal isn't maintainable. | 11:33 |
cdent | bauzas: we update allocations when is_new_instance or is_removed_instance | 11:33 |
mdbooth | lyarwood: Anyway, would you mind if I rebased your mirror tag change on to it? | 11:34 |
mdbooth | It would make your change a lot smaller. No changes required in test_driver.py. | 11:34 |
cdent | bauzas: we update inventory frequently | 11:34 |
lyarwood | mdbooth: not at all if you have the time to work on it | 11:34 |
mdbooth | Yeah, it'll only take me a second. | 11:34 |
lyarwood | mdbooth: awesome thanks | 11:34 |
*** mingyu has quit IRC | 11:34 | |
bauzas | cdent: my concerns are if we have wrong allocations when a new instance comes in | 11:35 |
cdent | bauzas: yeah. I haven't looked closely enough. Is the bug such that the allocations will be over or under where they should be? | 11:36 |
bauzas | yup | 11:36 |
bauzas | but I need to bail out for lunch | 11:36 |
bauzas | if I have a swap of 1MB | 11:37 |
bauzas | root to 1GB and eph to 0 | 11:37 |
bauzas | then I'll express an allocation of 2GB with that bug instead of 1.001 | 11:37 |
* cdent nods | 11:37 | |
*** mpaolino_ has joined #openstack-nova | 11:38 | |
cdent | When nova-compute restarts does it rewrite all allocations? | 11:38 |
openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Use the mirror element to detect job completion https://review.openstack.org/399735 | 11:39 |
mdbooth | lyarwood: ^^^ | 11:39 |
mdbooth | 75 insertions(+), 9 deletions(-) Much smaller :) | 11:39 |
cdent | bauzas: I'll do some experimenting in devstack today (because I was planning to do that anyway) | 11:39 |
lyarwood | mdbooth: nice! | 11:40 |
mdbooth | lyarwood: It's identical to your change, just test_driver changes removed | 11:41 |
bhagyashris | johnthetubaguy: i am new to placement api feature, Does it mean, the placement api only needs to be enabled on controller node ? | 11:41 |
johnthetubaguy | bhagyashris: I think so | 11:41 |
*** mpaolino has quit IRC | 11:42 | |
lyarwood | mdbooth: that's great, I would say thanks but my LOC changed stats just took a hit :D | 11:44 |
cdent | bhagyashris: yes, it goes on a controller and needs to be in the service catalog | 11:44 |
mdbooth | lyarwood: lol | 11:44 |
* mdbooth thinks LOCs deleted should count for twice as much as lines added anyway | 11:45 | |
cdent | mdbooth++ | 11:45 |
lyarwood | mdbooth: I agree https://review.openstack.org/#/c/391597/ | 11:45 |
lyarwood | ^_^ | 11:45 |
mdbooth | lyarwood: Oh, wow | 11:47 |
mdbooth | That's fantastic :) | 11:47 |
*** ducttape_ has joined #openstack-nova | 11:49 | |
*** ratailor has quit IRC | 11:49 | |
*** smatzek has joined #openstack-nova | 11:49 | |
mdbooth | Gerrit is a bit 500-y this morning | 11:51 |
bhagyashris | cdent: thank you for information, however if I am having two node setup then how many resource_providers will be created? two or one? In my case it is creating single resource_provider only | 11:53 |
*** ducttape_ has quit IRC | 11:53 | |
cdent | bhagyashris: you should get as many resource providers as you have compute nodes | 11:54 |
*** smatzek has quit IRC | 11:54 | |
*** abhishekk has joined #openstack-nova | 11:54 | |
*** smatzek has joined #openstack-nova | 11:54 | |
cdent | if you have two compute nodes but are only seeing one, then it may be that one of the compute nodes does not have the right stuff in the [placement] section of nova.conf | 11:54 |
bhagyashris | cdent: ok, so in both compute nodes I need to add placement section in nova.conf? actually I am using devstack for multinode setup so one one node it does not create placement section | 11:56 |
bhagyashris | cdent: thank you for useful information | 11:56 |
bhagyashris | cdent: i will check accordingly | 11:56 |
cdent | the [placement] section is used by the resource tracker (and eventually nova-scheduler) so needs to be where those things are running | 11:57 |
bhagyashris | cdent: ok. Thank you for information. :) | 11:58 |
*** hfu has quit IRC | 12:00 | |
*** hfu has joined #openstack-nova | 12:00 | |
*** hfu has quit IRC | 12:01 | |
*** hfu has joined #openstack-nova | 12:01 | |
*** lucasagomes is now known as lucas-hungry | 12:01 | |
*** hfu has quit IRC | 12:01 | |
*** hfu has joined #openstack-nova | 12:02 | |
*** hfu has quit IRC | 12:02 | |
*** hfu has joined #openstack-nova | 12:03 | |
*** hfu has quit IRC | 12:03 | |
*** hfu has joined #openstack-nova | 12:03 | |
*** hfu has quit IRC | 12:04 | |
*** owalsh-afk has joined #openstack-nova | 12:05 | |
*** owalsh-afk is now known as owalsh | 12:05 | |
*** moshele has quit IRC | 12:05 | |
*** moshele has joined #openstack-nova | 12:05 | |
gmann | Kevin_Zheng: left few comments on https://review.openstack.org/#/c/415330/23 | 12:06 |
gmann | Kevin_Zheng: more tests for new rule i mean, without old rule so that we can tests the way new deployer ll use | 12:07 |
*** haplo37_ has quit IRC | 12:08 | |
*** CristinaPauna has quit IRC | 12:08 | |
*** CristinaPauna has joined #openstack-nova | 12:09 | |
*** haplo37_ has joined #openstack-nova | 12:10 | |
*** cdelatte has joined #openstack-nova | 12:10 | |
stevemar | o/ | 12:14 |
stevemar | can we get a review of https://review.openstack.org/#/c/418190/ if possible, thanks already mriedem and andreykurilin | 12:15 |
*** yuntongjin has quit IRC | 12:20 | |
*** bvanhav__ has joined #openstack-nova | 12:21 | |
*** bvanhav__ is now known as bvanhav | 12:25 | |
*** mnestratov has quit IRC | 12:27 | |
*** catintheroof has joined #openstack-nova | 12:28 | |
*** Guest53005 has quit IRC | 12:31 | |
*** rmart04 has joined #openstack-nova | 12:33 | |
lyarwood | Any additional core reviews on the following would be appreciated - https://review.openstack.org/#/c/420146/ - libvirt: workaround findmnt behaviour change | 12:34 |
*** sudipto has quit IRC | 12:39 | |
*** sudipto_ has quit IRC | 12:39 | |
*** pradk has joined #openstack-nova | 12:40 | |
Kevin_Zheng | gmann: will add one, but I think thats what we should add when we remove the old rule, because for the new users using Ocata, old rule is still there, just not checking them | 12:42 |
gmann | Kevin_Zheng: yea but after this change, user can also have only new rule in their policy.json | 12:43 |
Kevin_Zheng | yeah, but the old rule still exist in code | 12:43 |
*** mnestratov has joined #openstack-nova | 12:44 | |
*** ayogi has quit IRC | 12:44 | |
*** thorst_ has joined #openstack-nova | 12:44 | |
Kevin_Zheng | it will make not difference than the current test | 12:44 |
gmann | Kevin_Zheng: ah, you mean code still have those. | 12:45 |
Kevin_Zheng | yeah | 12:45 |
gmann | Kevin_Zheng: got it, thanks. | 12:45 |
gmann | Kevin_Zheng: and while removing the old rule those tests will be with new rule only | 12:45 |
Kevin_Zheng | so, I will just update the comments then | 12:45 |
Kevin_Zheng | yeah, we will change the test then | 12:46 |
alex_xu | nova api meeting is in 15 mins at #openstack-meeting-4 | 12:46 |
*** Guest53005 has joined #openstack-nova | 12:46 | |
-openstackstatus- NOTICE: Gerrit is going to be restarted due to slow performance | 12:46 | |
gmann | Kevin_Zheng: cool thanks | 12:46 |
*** ducttape_ has joined #openstack-nova | 12:48 | |
alex_xu | gmann: thanks for the review! | 12:50 |
-openstackstatus- NOTICE: Gerrit has been successfully restarted | 12:50 | |
gmann | alex_xu: np! | 12:50 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | 12:52 |
*** moshele has quit IRC | 12:57 | |
Kevin_Zheng | https://review.openstack.org/#/c/421760/ | 12:59 |
Kevin_Zheng | ^ please also review the doc patch? | 12:59 |
*** lucas-hungry is now known as lucasagomes | 13:00 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Fix race condition in instance.update sample test https://review.openstack.org/424574 | 13:01 |
alex_xu | nova api meeting is running | 13:02 |
*** tbachman has joined #openstack-nova | 13:05 | |
*** hfu has joined #openstack-nova | 13:05 | |
*** stvnoyes has quit IRC | 13:05 | |
*** stvnoyes has joined #openstack-nova | 13:05 | |
*** hfu has quit IRC | 13:10 | |
*** tbachman has quit IRC | 13:12 | |
*** tbachman_ has joined #openstack-nova | 13:12 | |
*** ociuhandu has joined #openstack-nova | 13:26 | |
*** vsaienko has joined #openstack-nova | 13:27 | |
*** tongli has joined #openstack-nova | 13:27 | |
*** edmondsw has joined #openstack-nova | 13:28 | |
*** esberglu has joined #openstack-nova | 13:28 | |
*** mingyu has joined #openstack-nova | 13:31 | |
*** liverpooler has quit IRC | 13:31 | |
*** liverpooler has joined #openstack-nova | 13:32 | |
*** moshele has joined #openstack-nova | 13:33 | |
*** tbachman_ is now known as tbachman | 13:33 | |
*** udesale has joined #openstack-nova | 13:33 | |
*** ducttape_ has quit IRC | 13:34 | |
*** mingyu has quit IRC | 13:36 | |
*** xyang1 has joined #openstack-nova | 13:39 | |
bauzas | cdent: have you seen our discussion with matt yesterday and the conclusion email ? | 13:41 |
bauzas | cdent: we agreed on rather asking to modify the allocation ratios | 13:41 |
bauzas | cdent: so I needed to modify a functional test for server_groups | 13:42 |
bauzas | cdent: but I discovered a problem | 13:42 |
bauzas | cdent: when having an allocation, it still doesn't work because we also verify the max unit | 13:42 |
bauzas | which is not changed if using the ratio | 13:42 |
cdent | bauzas: max unit shouldn't have anything directly to do with allocation ratio, can you explain what you mean a different way? | 13:43 |
bauzas | I mean https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L615 | 13:43 |
bauzas | cdent: okay, so the problem is when operators don't use legacy filters in Newton | 13:44 |
bauzas | ie. the CoreFilter or the DiskFilter | 13:44 |
*** kylek3h_ has joined #openstack-nova | 13:44 | |
bauzas | then in case you don't have enough resources, it's fine | 13:44 |
bauzas | the scheduler would still give you destinations | 13:44 |
bauzas | now that we have the placement call, it's asking for both VCPU, mem and disk | 13:45 |
bauzas | as we agreed on not optionally ask for them | 13:45 |
bauzas | but | 13:45 |
bauzas | given the solution was to say 'just amend the ratio and put for example 9999.0', it would still work for Newton | 13:45 |
bauzas | because for example CoreFilter doesn't verify the max unit | 13:45 |
bauzas | but when upgrading to Ocata, then the placement API wouldn't return that destination | 13:46 |
bauzas | because we now verify also by max unit | 13:46 |
bauzas | se ? | 13:46 |
*** kylek3h has quit IRC | 13:46 | |
bauzas | lemme upload two changes and hopefully you'll understand | 13:46 |
cdent | I'm still not seeing how max unit is involved in wha you are describing. it is the max for an individual request | 13:47 |
*** vsaienko has quit IRC | 13:47 | |
*** jpena is now known as jpena|lunch | 13:50 | |
*** vsaienko has joined #openstack-nova | 13:51 | |
bauzas | cdent: sec, uploading my branch | 13:51 |
*** mdnadeem has quit IRC | 13:53 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 13:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters https://review.openstack.org/425185 | 13:53 |
bauzas | cdent: see the bottom patch https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L615 | 13:54 |
bauzas | oops | 13:54 |
bauzas | cdent: https://review.openstack.org/425185 | 13:54 |
*** mdnadeem has joined #openstack-nova | 13:55 | |
*** sridharg has quit IRC | 13:55 | |
cdent | bauzas: I'm looking but I still don't get where max_unit is involved? | 13:55 |
bauzas | cdent: not for that change | 13:56 |
bauzas | cdent: it will have the functional test +1 | 13:56 |
kashyap | mdbooth: You might find this interesting, upstream QEMU just merged this command-line switch called '--only-migratable' -- what it does is, if you add any devices to your VM that are _not_ migratable, it'll fail upfront | 13:56 |
bauzas | cdent: now, the latter change using the scheduler would not agree now | 13:56 |
mdbooth | kashyap: Nice | 13:56 |
bauzas | for those tests | 13:56 |
andreykurilin | bauzas: sorry for disturbing. OpenstackClient, senlinclient teams are blocked by https://review.openstack.org/#/c/418190/ . They want to bump openstacksdk version in g-r, but it will break our gates without that patch | 13:56 |
kashyap | mdbooth: As an example, trying to add a USB audio device results in: | 13:56 |
kashyap | ./x86_64-softmmu/qemu-system-x86_64 --only-migratable -nographic -device usb-audio | 13:56 |
kashyap | qemu-system-x86_64: -device usb-audio: Device usb-audio is not migratable, but --only-migratable was specified | 13:56 |
bauzas | andreykurilin: I wanted to ask you when you feel it's okay to release a version, but you consider the above blocking ? | 13:57 |
andreykurilin | bauzas: so we need to merge at least https://review.openstack.org/#/c/424256/ . it is required for our release. You previously put +2, but gates decided that I'm doing something wrong, so I push another patch-set | 13:58 |
bauzas | cdent: it wouldn't work because of the new calculation we made for GET /RPs here https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L615 | 13:58 |
*** baoli has joined #openstack-nova | 13:58 | |
*** marst has quit IRC | 13:58 | |
andreykurilin | bauzas: https://review.openstack.org/#/c/418190/ doesn't block us. But without it, our functional tests can't work with latest openstacksdk, which is needed for several projects | 13:59 |
bauzas | ok | 13:59 |
cdent | bauzas: I'm hearing you say that, what I'm asking is for you to explain why that's the case. | 13:59 |
cdent | (using words, instead of pointing at code) | 13:59 |
andreykurilin | bauzas: stevemar put -W for his patch to g-r https://review.openstack.org/#/c/424847/ and waiting for us:) | 13:59 |
*** baoli_ has joined #openstack-nova | 14:00 | |
alex_xu | johnthetubaguy: gmann Kevin_Zheng sorry, let us continue at here | 14:00 |
gmann | yea | 14:00 |
cdent | bauzas: what matters is that AMOUNT_X is less than max_unit. that's all. | 14:00 |
gmann | johnthetubaguy: alex_xu another point will be, can we do another microversion in Ocata? i can update code soon but review might be issue | 14:01 |
andreykurilin | bauzas: also, there is patch with clarification docs (relates to thread - "[openstack-dev] [nova] Device tag in the API breaks in the old microversion"), but it is not critical, just nice to have | 14:01 |
bauzas | cdent: yup, so lemme clarify | 14:01 |
*** mdrabe has joined #openstack-nova | 14:01 | |
openstackgerrit | John Garbutt proposed openstack/nova: Add release note and docs for filter/sort whitelist https://review.openstack.org/421760 | 14:01 |
bauzas | cdent: previously, we were calculating if (amount + used) was under total * ratio, that's it | 14:02 |
bauzas | I mean in the legacy filter | 14:02 |
* cdent nods | 14:02 | |
bauzas | cdent: now the placement method does extra checks, one being that amount is less than max unit, period. | 14:02 |
cdent | correct | 14:02 |
johnthetubaguy | gmann: it does seem too close to the wire, but also feels less urgent than the other pieces of the puzzle | 14:02 |
cdent | those values are set the "real" values on the compute node | 14:02 |
bauzas | cdent: if so, we can't say to operators to just modify their ratios in order to get the same behaviour | 14:03 |
cdent | it doesn't matter | 14:03 |
bauzas | cdent: because once the scheduler upgraded to Ocata, it will not return the exact same nodes | 14:03 |
cdent | an operator could never place a host on a node that had fewer vcpus than requested | 14:03 |
bauzas | cdent: and hosts that were okay for Newton won't be available per Ocata | 14:03 |
*** baoli has quit IRC | 14:03 | |
cdent | but they are not okay | 14:03 |
bauzas | cdent: people did | 14:03 |
cdent | how does that even work? | 14:04 |
bauzas | cdent: because they disabled their filters | 14:04 |
cdent | can I run an 8vcpu server on a 2 vcpus host? | 14:04 |
gmann | johnthetubaguy: ok, let me push changes tomorrow and then we can see till where we can go with those | 14:04 |
bauzas | you can if you don't enable the CoreFilter | 14:04 |
cdent | that's bonkers | 14:04 |
*** vsaienko has quit IRC | 14:04 | |
bauzas | cdent: yet again, we can be pedantic and say that | 14:04 |
edleafe | bauzas: you could get that back from scheduler, but it would fail to build | 14:05 |
bauzas | or we can be pragmatic and find a way that doesn't trample operators | 14:05 |
alex_xu | gmann: really appreciate that | 14:05 |
Kevin_Zheng | cdent: hi, since you are here, is this an issue? https://bugs.launchpad.net/nova/+bug/1658868 | 14:05 |
openstack | Launchpad bug 1658868 in OpenStack Compute (nova) "Should raise retry limit exceed error instead of class exist in Placement API" [Undecided,New] - Assigned to Zhenyu Zheng (zhengzhenyu) | 14:05 |
cdent | Well a) clearly I don't know enough about what people are doing to have a straight opinion on this stuff, but b) I don't think we should allow bonker-ness, c) I'd defer to matt and dan on this | 14:05 |
bauzas | edleafe: the claim could | 14:05 |
cdent | will look in just a sec Kevin_Zheng | 14:05 |
edleafe | bauzas: the claim could... what? | 14:05 |
bauzas | edleafe: but the claim takes care of the ratio as a limit | 14:05 |
*** ducttape_ has joined #openstack-nova | 14:06 | |
bauzas | edleafe: you know the process, right? | 14:06 |
bauzas | so | 14:06 |
edleafe | bauzas: yeah, I've seen it once or twice | 14:06 |
gmann | alex_xu: np! | 14:06 |
bauzas | okay, so the problem is that we suddently stop supporting something without a clear upgrade path just because we advocate it's bonkers | 14:06 |
bauzas | that doesn't look a correct answer to me | 14:07 |
*** vsaienko has joined #openstack-nova | 14:07 | |
bauzas | since we allowed for a while to opt-out filters | 14:07 |
edleafe | bauzas: so are you saying that today if you disable CoreFilter, you could successfully build a VM with 8 VCPUs on a 2 VCPU host? | 14:07 |
bauzas | edleafe: if you live-migrate, yes | 14:08 |
cdent | the "build a VM" part is the critical question, not what select_destionations does or does not return | 14:08 |
edleafe | I am unaware of any hypervisor that can do that magic | 14:08 |
bauzas | let's be clear, you can live-migrate a 8 VCPU VM to a 2 VCPU node | 14:09 |
bauzas | at least Nova doesn't prevent you to do so | 14:09 |
johnthetubaguy | bauzas: we can deprecate something, saying its bonkers, and remove it the following cycle | 14:09 |
bauzas | johnthetubaguy: that was the original approach | 14:09 |
edleafe | bauzas: but do you get an 8 VCPU vm? | 14:09 |
bauzas | johnthetubaguy: but I got strong consensus to not do that and rather straight not accepting | 14:09 |
johnthetubaguy | thats defiantly my preference, because of the release tags we are signed up to | 14:09 |
*** vsaienko has quit IRC | 14:10 | |
bauzas | edleafe: that depends on your driver | 14:10 |
cdent | Kevin_Zheng: I'll respond on the issue | 14:10 |
bauzas | edleafe: but whatever the situation is, nova *is* accepting that | 14:10 |
Kevin_Zheng | cdent: thanks | 14:10 |
johnthetubaguy | bauzas: you have to get an 8 VCPU vm, else it wouldn't live-migrate, as I understand it | 14:11 |
*** pbandark has quit IRC | 14:11 | |
bauzas | in other words, folks, how can I make that functional test be working when using the placement API ? | 14:11 |
*** pradk has quit IRC | 14:11 | |
bauzas | I think there is a big misunderstanding between vcpus and pcpus | 14:11 |
cdent | bauzas: when you say "accepting that" what do you mean by "that", explicitly? | 14:11 |
bauzas | cdent: accepting to give you a destination that is not verifying the max unit | 14:11 |
johnthetubaguy | FWIW, I know rackspace cloud have never run the core filter, we only run the RAM filter | 14:11 |
*** tlian has joined #openstack-nova | 14:12 | |
bauzas | johnthetubaguy: then you could be in serious touble | 14:12 |
cdent | bauzas: sure but destinations don't matter, where vms are built does | 14:12 |
bauzas | johnthetubaguy: see https://review.openstack.org/#/c/417961/24/releasenotes/notes/resource_providers_scheduler_db_filters-16b2ed3da00c51dd.yaml | 14:12 |
johnthetubaguy | we would just have to set the over-comitt ratio correctly, but thats OK as a warning | 14:12 |
cdent | that's what I keep trying to clarify here: is the behavior of where vms built actually changing, or just the list of destinations? | 14:12 |
sahid | johnthetubaguy: i replied to your questions about the patch related to the feature emulator threads | 14:12 |
*** zzzeek has quit IRC | 14:12 | |
sahid | hope that is going to clarify your mind | 14:13 |
bauzas | johnthetubaguy: cdent: seriously, I'm done | 14:13 |
bauzas | I'm trying to spot issues that could come up in production and I'm only seeing a "meh, it's bonkers" | 14:14 |
cdent | bauzas: why? I'm really trying hard to understand the situation. | 14:14 |
bauzas | cdent: Jenkins will tell you the situation | 14:14 |
cdent | If it is the case that "the behavior of where vms built actually changing" then we have an issue. | 14:14 |
*** zzzeek has joined #openstack-nova | 14:14 | |
*** cleong has joined #openstack-nova | 14:15 | |
cdent | functional tests failing isn't necessarily telling us anything because we've demonstrated time and again (recently) that the functional tests have bad setups. | 14:15 |
*** sdague has joined #openstack-nova | 14:15 | |
bauzas | cdent: in particular, tbp, some functional tests in the test_server_group testcase won't give you the same exact result once we call the placement service, which is to me a good indicator that placement decisions are not feature-parity between Newton and Ocata | 14:15 |
cdent | that's a good indicator, but only if we verify that the tests are correct | 14:16 |
cdent | so I guess the next step is to wait and see what fails and go from there | 14:16 |
*** dave-mccowan has joined #openstack-nova | 14:16 | |
johnthetubaguy | so for folks with the core filter turned off the decisions will be different now we enforce that, it seems to me | 14:17 |
bauzas | johnthetubaguy: my point indeed | 14:17 |
johnthetubaguy | bauzas: yep, I am trying to agree with you here | 14:17 |
bauzas | johnthetubaguy: I spotted that problem in a ML thread | 14:17 |
johnthetubaguy | bauzas: I liked that first version of your code that dealt with that | 14:18 |
bauzas | johnthetubaguy: and the agreement we made with matt and jay was to rather ask the operators to set their ratios to an high value | 14:18 |
*** jamesdenton has joined #openstack-nova | 14:18 | |
cdent | all along my position has been "bauzas' suggestion sounds sane but I defer to jay, dan and matt". I still do. | 14:18 |
edleafe | johnthetubaguy: I'm really not getting this. You're saying that it is expected behavior that Nova will build an 8 VCPU VM on a 2 VCPU host? | 14:18 |
bauzas | johnthetubaguy: but I'm trying to explain that because of an implementation detail and a design agreement that the placement engine should respect max units, we can't have the same | 14:19 |
bauzas | edleafe: a 2VCPU host doesn't mean anything to me | 14:19 |
bauzas | edleafe: hosts have physical threads | 14:19 |
*** hfu has joined #openstack-nova | 14:20 | |
*** READ10 has joined #openstack-nova | 14:20 | |
sfinucan | sahid: Left a comment on https://review.openstack.org/#/c/400875. Could you take a look so I can continue with the rest of the series, please :) | 14:20 |
johnthetubaguy | edleafe: thats not my point here, my point is we are breaking folks existing configurations across upgrade | 14:20 |
*** diga has quit IRC | 14:20 | |
johnthetubaguy | edleafe: if folks have the core filter off, they probably have not set the over commit raitio correctly | 14:20 |
edleafe | johnthetubaguy: I was using bauzas's example. | 14:21 |
johnthetubaguy | edleafe: when we change the default filters, it broke the XenAPI CI, for one example | 14:21 |
edleafe | johnthetubaguy: so our release notes tell them how to fix that | 14:21 |
bauzas | edleafe: but the releasenote I wrote is not *fixing* that | 14:21 |
bauzas | edleafe: I thought yesterday it was the case | 14:21 |
bauzas | but it's not | 14:21 |
bauzas | because *again* we cap on max_unit | 14:22 |
edleafe | johnthetubaguy: I understand it can break tests, but what is the effect in the real world? | 14:22 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding vlans field to Device tagging metadata https://review.openstack.org/405951 | 14:22 |
*** psachin has quit IRC | 14:22 | |
bauzas | either way, we're 24 hours of the FF, and what we all discuss can possibly be a no-brainer if we are not able to amend grenade in time | 14:22 |
johnthetubaguy | aye | 14:23 |
cdent | bauzas: when a compute node reports inventory it reports a value from compute_node.vcpus. how is that calculated? | 14:23 |
cdent | (I'm trying to expand my understanding here, nothing else) | 14:23 |
bauzas | cdent: you mean the helper method, but how nova can know what cpus the node has ? | 14:23 |
bauzas | s/but/or | 14:23 |
cdent | I saying: there's a properly on the compute_node object called vcpus, which is set by update_from_virt_driver | 14:24 |
cdent | what does it mean? | 14:24 |
johnthetubaguy | bauzas: random thought, what if we change max unit to pCPU * allocation ratio? | 14:27 |
johnthetubaguy | edleafe: real world, feels like it only makes sense for test rigs and dev rigs | 14:27 |
edleafe | johnthetubaguy: what if we dump max_unit altogether? | 14:29 |
bauzas | johnthetubaguy: I'm pretty sure I would get a strong negative feedback on that approach | 14:29 |
johnthetubaguy | edleafe: it makes sense for some resources, just not all | 14:29 |
*** tblakes has joined #openstack-nova | 14:29 | |
johnthetubaguy | edleafe: I think disk it was particularly useful for, from what I remember | 14:30 |
*** liang_ has joined #openstack-nova | 14:30 | |
*** gouthamr has joined #openstack-nova | 14:31 | |
*** liang_ has quit IRC | 14:31 | |
*** liangy has joined #openstack-nova | 14:31 | |
johnthetubaguy | hmm, I duno, it all feels very edge case, and there are work arounds if folks hit things | 14:31 |
bauzas | I'm feeling my patch is like a giant canary patch for spotting placement integration with nova | 14:32 |
*** mingyu has joined #openstack-nova | 14:32 | |
bauzas | and being so close to FF makes me absolutely nervous | 14:32 |
bauzas | so we could spend yet another hours for discussing the good and the bad of operatoes | 14:33 |
bauzas | but the fact is that the landing window is reducing fast | 14:33 |
*** ducttape_ has quit IRC | 14:33 | |
johnthetubaguy | bauzas: its also the most important patch to get all the lovelyness of placement exposed to our users, if that makes you feel better | 14:34 |
bauzas | i know | 14:34 |
bauzas | but that doesn't help if we're stuck | 14:34 |
*** tlbr has quit IRC | 14:35 | |
johnthetubaguy | so the reality is, this is a big change, its going to be a bit bumpy | 14:35 |
mdbooth | Speaking of which, this is a not-insubstantial change which has been sitting a while: https://review.openstack.org/#/c/383859/ | 14:35 |
johnthetubaguy | the sooner we get this out there, the sooner we get to fix the stuff that really affects people | 14:35 |
mdbooth | I know it's a bugfix, but if it gets any additional exposure from landing before FF that would be great. | 14:35 |
*** Swami has joined #openstack-nova | 14:36 | |
*** udesale has quit IRC | 14:36 | |
*** mingyu has quit IRC | 14:37 | |
edleafe | johnthetubaguy: bauzas: from the RP spec: "As an example, let us say that a particular compute node has two quad-core Xeon processors, providing 8 total physical cores. Even though the cloud administrator may have set the cpu_allocation_ratio to 16 (the default), the compute node cannot accept requests for instances needing more than 8 vCPUs. So, while there may be 128 total vCPUs available on the | 14:38 |
edleafe | compute node, the min_unit would be set to 1 and the max_unit would be set to 8 in order to prevent unacceptable matching of resources to requests." | 14:38 |
edleafe | is this reasoning wrong? | 14:39 |
johnthetubaguy | so it has 16 threads, with hyperthreading I guess, which feels a better match to vCPU | 14:40 |
*** vsaienko has joined #openstack-nova | 14:40 | |
*** xinliang has quit IRC | 14:40 | |
cdent | what max_unit is set to for vcpu is dependent on what the virt driver reports. if it is hyperthreading aware, it probalby reports more. | 14:41 |
edleafe | johnthetubaguy: so you're saying that the reasoning in the spec is wrong? | 14:41 |
*** liangy has quit IRC | 14:41 | |
* edleafe has to run out for a bit to take his daughter to school | 14:41 | |
*** liangy has joined #openstack-nova | 14:41 | |
*** tongli has quit IRC | 14:42 | |
dansmith | johnthetubaguy or bauzas: easy --verbose patch that is at the bottom of all the remaining cells/devstack/devstack gate changes: https://review.openstack.org/#/c/421228/ | 14:42 |
*** gcb has quit IRC | 14:42 | |
bauzas | dansmith: aye | 14:43 |
bauzas | I'm stuck anyway, I have now plenty of time for reviews | 14:43 |
dansmith | let me catch up for the morning and then we can look | 14:44 |
dansmith | at your stuff | 14:44 |
bauzas | dansmith: I'll need to send an email | 14:45 |
*** tblakes_ has joined #openstack-nova | 14:50 | |
BobBall | edleafe: Which spec are you talking about there? I've just been chatting to one of the Xen developers and they believe its dangerous to over-commit in a single VM. Linux slows to a crawl (and may crash) and Windows definitely crashes. Apparently. | 14:51 |
*** tblakes has quit IRC | 14:52 | |
*** xinliang has joined #openstack-nova | 14:53 | |
*** hongbin has joined #openstack-nova | 14:55 | |
*** tblakes has joined #openstack-nova | 14:55 | |
*** mvk has quit IRC | 14:55 | |
*** tblakes_ has quit IRC | 14:56 | |
sfinucan | johnthetubaguy, sdague: Easy Mox-mock patch that holding back a bug fix (ye've both reviews Mox-mock patches before :)) | 14:56 |
*** jpena|lunch is now known as jpena | 14:56 | |
*** marst has joined #openstack-nova | 14:57 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Use ListOfIntegersField in oslo.versionedobjects https://review.openstack.org/423912 | 14:57 |
johnthetubaguy | dansmith: I am wondering about this, do we get away without needing a context manager there? https://review.openstack.org/#/c/319379/78/nova/compute/api.py@1800 | 14:59 |
cdent | BobBall: that was the original resource providers spec: http://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/resource-providers.html | 15:00 |
BobBall | ah ok | 15:00 |
*** udesale has joined #openstack-nova | 15:00 | |
*** catinthe_ has joined #openstack-nova | 15:00 | |
*** mlavalle has joined #openstack-nova | 15:00 | |
*** sridharg has joined #openstack-nova | 15:01 | |
BobBall | Thanks. | 15:01 |
*** catintheroof has quit IRC | 15:02 | |
bauzas | johnthetubaguy: cdent: edleafe: dansmith: just made a summary in the ML thread about the problem | 15:04 |
bauzas | with a silver bullet in it | 15:04 |
dansmith | johnthetubaguy: yeah, i think you might be right | 15:04 |
dansmith | johnthetubaguy: I'm surprised melwitt didn't do that though, so I'm wondering if she knows better | 15:05 |
dansmith | johnthetubaguy: I will queue a change though and then ask her when she's aroune | 15:05 |
johnthetubaguy | dansmith: cool, thanks | 15:05 |
melwitt | I think that's my bad. it was part of a bleary-eyed debugging session | 15:05 |
bauzas | cdent: you could defer to others for that, but I'd still love your thoughts | 15:06 |
*** eharney has joined #openstack-nova | 15:06 | |
dansmith | melwitt: ack, I'll fix | 15:06 |
cdent | bauzas: thanks for doing that, will look soon, in the midst of some debugging in devstack | 15:06 |
bauzas | cdent: edleafe: dansmith: johnthetubaguy: http://lists.openstack.org/pipermail/openstack-dev/2017-January/110938.html is the summary email | 15:07 |
*** eglynn has joined #openstack-nova | 15:08 | |
*** ducttape_ has joined #openstack-nova | 15:08 | |
bauzas | interesting, my English level is dropping fast | 15:08 |
bauzas | and we're at the middle of the week | 15:08 |
bauzas | but that email is awfully covered of mistakes so I apologize | 15:09 |
*** jaosorior has joined #openstack-nova | 15:10 | |
*** hfu has quit IRC | 15:11 | |
*** karimb has joined #openstack-nova | 15:11 | |
*** sdague has quit IRC | 15:12 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.32 and 2.37 https://review.openstack.org/424759 | 15:12 |
openstackgerrit | Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.33 and 2.37 https://review.openstack.org/424759 | 15:13 |
*** yufei has joined #openstack-nova | 15:17 | |
openstackgerrit | Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 15:17 |
openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 15:17 |
*** timello has quit IRC | 15:17 | |
*** stvnoyes1 has joined #openstack-nova | 15:19 | |
*** stvnoyes has quit IRC | 15:21 | |
bhagyashris | Vek : alex_xu: Hi, could you please review the patch [1] https://review.openstack.org/#/c/409644/ ? | 15:21 |
*** yufei has quit IRC | 15:25 | |
*** zz_dimtruck is now known as dimtruck | 15:26 | |
*** burgerk has joined #openstack-nova | 15:27 | |
edleafe | BobBall: (reading back) Yes, concern about over-commmit was the reason that max_unit exists | 15:28 |
BobBall | *nod* I had mis-read. Thanks for confirming. | 15:28 |
edleafe | BobBall: Apparently some operators want to be able to override that. | 15:28 |
*** jdurgin1 has joined #openstack-nova | 15:28 | |
BobBall | Crazy people :) | 15:28 |
edleafe | BobBall: supposedly adding that sanity check will negatively affect them | 15:29 |
*** baoli_ has quit IRC | 15:29 | |
andreykurilin | stevemar: it looks like you can remove your -W to g-r patch:) | 15:29 |
*** mpaolino_ has quit IRC | 15:30 | |
*** mtanino has joined #openstack-nova | 15:30 | |
*** markvoelker has quit IRC | 15:31 | |
*** markvoelker has joined #openstack-nova | 15:32 | |
*** timello has joined #openstack-nova | 15:33 | |
*** sridharg has quit IRC | 15:35 | |
*** pradk has joined #openstack-nova | 15:36 | |
*** markvoelker has quit IRC | 15:36 | |
*** rmart04 has quit IRC | 15:38 | |
andreas_s | Hi adreznec, quick question regarding nova-powervm devref creation | 15:41 |
*** jschwarz is now known as jschwarz|brb | 15:41 | |
*** ekuris_ has quit IRC | 15:41 | |
andreas_s | adreznec, you have your config options defined here: https://github.com/openstack/nova-powervm/blob/master/doc/source/devref/usage.rst | 15:41 |
andreas_s | adreznec, have those been autogenerated somehow, or did yo create those tables by hand? | 15:42 |
andreas_s | I'm trying to achieve something similar for the nova-dpm project... | 15:42 |
bauzas | edleafe: BobBall: crazy people can be RAX | 15:42 |
bauzas | given they don't use the CoreFilter | 15:42 |
* bauzas shrugs | 15:42 | |
*** catintheroof has joined #openstack-nova | 15:43 | |
adreznec | andreas_s: I believe thorst_ built that set of documentation. Not sure what his exact steps were - do you remember thorst_? | 15:43 |
thorst_ | andreas_s: unfortunately, I did it all by hand. | 15:44 |
thorst_ | so it could be out of date. | 15:44 |
BobBall | bauzas: Only crazy if they offer flavours with more CPUs than the minimum number on their hosts? | 15:44 |
andreas_s | thorst_, adreznec ok thanks - maybe I'll find a way to automate that a bit.. | 15:44 |
*** jose-phillips has joined #openstack-nova | 15:44 | |
thorst_ | andreas_s: let us know if you get it automated...I'd like to use that :-) | 15:45 |
sfinucan | pkoniszewski: If you want to fix this up quickly, I can +2 https://review.openstack.org/#/c/410817/5 | 15:45 |
andreas_s | thorst_, sure | 15:45 |
pkoniszewski | sfinucan: sure, thanks! | 15:45 |
dansmith | bauzas: I don't understand the problem in your email | 15:45 |
bauzas | dansmith: sorry, like I said, my English level in that email is just terrible | 15:46 |
*** catinthe_ has quit IRC | 15:46 | |
bauzas | dansmith: let me restate the problem I spotted | 15:46 |
dansmith | bauzas: I get that max_unit causes some slightly different behavior? | 15:46 |
*** Swami_ has joined #openstack-nova | 15:46 | |
bauzas | dansmith: yup | 15:47 |
bauzas | dansmith: for example | 15:47 |
dansmith | max_unit is the maximum size of any given allocation of that resource type, yes? | 15:47 |
bauzas | dansmith: say an instance with a flavor of 2 vCPUs | 15:47 |
bauzas | dansmith: max_unit is the max resource class amount the provider supports | 15:48 |
bauzas | in its inventory | 15:48 |
bauzas | eg. | 15:48 |
dansmith | o.O | 15:48 |
bauzas | a compute exposing 1 CPU | 15:48 |
bauzas | will have max_unit=1 | 15:48 |
*** jschwarz|brb is now known as jschwarz | 15:48 | |
bauzas | like the FakeDriver | 15:48 |
bauzas | I mean the SmallFakeDriver | 15:48 |
bauzas | now, count an instance with a flavor of 2 vcpus | 15:49 |
dansmith | I don't think that's right.. total should be the maximum available | 15:49 |
bauzas | if we set a cpu ratio to 9999.0, then the CoreFilter will be happy | 15:49 |
dansmith | I think max_unit is the largest single allocation, and min_unit is the smallest | 15:49 |
*** tbachman has quit IRC | 15:49 | |
dansmith | so if you want to not let someone request 1MB of RAM, for example, min_unit might be 64 | 15:49 |
*** Swami has quit IRC | 15:49 | |
bauzas | dansmith: lemme show you the code | 15:49 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Add new configuration option live_migration_scheme https://review.openstack.org/410817 | 15:50 |
dansmith | https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L656-L665 | 15:50 |
dansmith | I'm looking at that ^ | 15:50 |
*** Oku_OS is now known as Oku_OS-away | 15:50 | |
*** Sukhdev has joined #openstack-nova | 15:51 | |
bauzas | dansmith: see how we report it per compute https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L94 | 15:51 |
bauzas | I mean, L95 rather | 15:51 |
dansmith | right, | 15:51 |
bauzas | so take my example | 15:51 |
bauzas | a driver reporting 1 VCPU | 15:51 |
bauzas | and an instance asking 2 vCPUs | 15:51 |
*** owalsh_ has joined #openstack-nova | 15:52 | |
bauzas | if we use the allocation ratio of 999.0 then the compute will satisfy the request per the CoreFilter rules | 15:52 |
bauzas | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/core_filter.py#L47 | 15:53 |
*** owalsh has quit IRC | 15:53 | |
dansmith | you're saying that max_unit isn't scaled by allocation ratio, right? | 15:53 |
dansmith | (effectively) | 15:53 |
edleafe | bauzas: lines 54-56 are what I'm looking at | 15:54 |
cdent | dansmith: yes, and the questions are whether that is correct or not, and even if it not correct, if deprecation of some kind is required to deal | 15:54 |
bauzas | dansmith: wait, I think I'm puzzled | 15:55 |
dansmith | cdent: so the change from what we have now is that any one instance can't overcommit the host, effectively | 15:55 |
edleafe | I thought the issue was for operators who disabled CoreFilter | 15:55 |
cdent | dansmith: yes | 15:55 |
dansmith | cdent: like if the host has 1 vcpu to give, then you can have $allocation_ratio instances there, but not a multi-vcpu instance | 15:55 |
edleafe | They can currently put an 8VCPU request on a 2 VCPU host | 15:55 |
edleafe | But they won't be able to now, because of max_unit | 15:56 |
mdbooth | artom vladikr: volume_id in connection_info came up in review the other week, no? | 15:56 |
dansmith | edleafe: which is kinda what max_unit is for | 15:56 |
edleafe | dansmith: agreed | 15:56 |
mdbooth | artom vladikr: I'm currently doing a trawl of cinder volume drivers, and so far I've found at least 1 which doesn't set it. | 15:56 |
edleafe | dansmith: but bauzas and johnthetubaguy point out that that's a change w/o deprecation | 15:56 |
artom | mdbooth, yeah, you said it was a bad idea | 15:56 |
dansmith | edleafe: right now we just set it to the max, assuming a sane default, but we could change that later if someone has a good reason to allow such a thing | 15:56 |
mdbooth | artom vladikr: It's all very ad-hoc | 15:56 |
bauzas | what the hell | 15:57 |
artom | mdbooth, and then I went and re-checked with traget_dev/device_name, and it turns out that it works | 15:57 |
dansmith | edleafe: yeah, I can kinda see that, but.. it's also not very smart | 15:57 |
artom | mdbooth, my previous testing must have been as ad-hoc as colume id in cinder :) | 15:57 |
mdbooth | artom: Awesome. Wasn't sure what the resolution was, just thought I'd throw in a data point :) | 15:57 |
edleafe | dansmith: ok, so we have "bonkers", "crazy people", and "not very smart" to describe that | 15:57 |
edleafe | dansmith: you win the prize for most polite | 15:57 |
dansmith | edleafe: artom cdent: If someone had a problem with this, we could allow setting insanity_mode=on, which would report max_unit=N*allocation_ratio | 15:57 |
* edleafe is shocked | 15:58 | |
dansmith | edleafe: I'd like to change my answer to "fucking stupid" | 15:58 |
* artom feels flattered to have been involved in that joke | 15:58 | |
*** _ducttape_ has joined #openstack-nova | 15:58 | |
* edleafe is relieved that dansmith is back to his old self | 15:58 | |
* bauzas facepalms | 15:58 | |
cdent | laaaaaadies and gentleman in a last minute change, dansmith wins | 15:58 |
bauzas | we don't use CoreFilter in the default list of filters | 15:59 |
bauzas | soooooo great | 15:59 |
dansmith | bauzas: that's not news, is it? | 15:59 |
bauzas | it is to me | 15:59 |
*** dtroyer has left #openstack-nova | 15:59 | |
bauzas | I thought the gate was special | 15:59 |
bauzas | but that we allowed corefilter by default | 15:59 |
bauzas | I'm utterly surprised | 16:00 |
bauzas | so I'm just discovering that we *never* verified in Newton the CPU resources | 16:00 |
bauzas | unless you explicitely asked for | 16:00 |
bauzas | because if so, the CoreFilter would deny like the placement engine | 16:01 |
bauzas | that's even worst ! | 16:01 |
bauzas | holy shit | 16:01 |
bauzas | pardon my language | 16:02 |
*** ducttape_ has quit IRC | 16:02 | |
bauzas | dansmith: ^ | 16:02 |
*** Oku_OS-away is now known as Oku_OS | 16:02 | |
edleafe | bauzas: at least curse in French | 16:02 |
bauzas | so, just to be clear, lemme restate for the audience | 16:02 |
dansmith | even worse in what way? that it's a change? | 16:02 |
bauzas | in Newton, we totally accept that we can return a destination that doesn't satisfy the vCPU requirements | 16:03 |
bauzas | that's worst because that's changing the scheduler behaviour | 16:03 |
*** sdague has joined #openstack-nova | 16:03 | |
edleafe | Returning a destination is an implementation detail, not a behavior | 16:03 |
bauzas | placing an instance on a target is a behavioural choice | 16:04 |
dansmith | bauzas: but the whole point of placement is making better decisions right? | 16:04 |
edleafe | If anything, the change should reduce the number of retries | 16:04 |
dansmith | not less opinionated ones, but better ones | 16:04 |
edleafe | dansmith: jinx (sorta) | 16:04 |
dansmith | aye | 16:04 |
*** toure|biab is now known as toure | 16:05 | |
*** derekh has quit IRC | 16:05 | |
bauzas | edleafe: dansmith: the fun with that is that the problem still remains for RAMFilter | 16:06 |
dansmith | but really, | 16:06 |
bauzas | even if we say "fair enough, we don't need to advert operators to modify their ratios for cpu" | 16:06 |
*** gongysh has quit IRC | 16:07 | |
bauzas | the problem remains for ram | 16:07 |
dansmith | overcommitting the whole node in a single VM is just nuts | 16:07 |
dansmith | eve more nuts than cpu | 16:07 |
dansmith | if we want to offer an insanity_mode config option, then let's do it | 16:07 |
dansmith | and make it clear what it is | 16:07 |
dansmith | I'll write the patch | 16:07 |
*** prateek has quit IRC | 16:08 | |
bauzas | I'm still wondering why we never used CoreFilter in that case | 16:08 |
* sfinucan keeps pressing ] on Google to go to the next page :( #gerrithabits | 16:08 | |
dansmith | all I really care about is getting this patch in so we're not kicking it to another release | 16:08 |
edleafe | dansmith: "If you want to stick your fork into the electrical socket..." | 16:08 |
dansmith | edleafe: that can go in the help text | 16:08 |
bauzas | so you gonna rev'd my change? | 16:09 |
dansmith | it doesn't affect your change, right? it'd be a reporting change | 16:09 |
dansmith | but yes, if I need to write that patch to move us forward I'll do it | 16:09 |
edleafe | I think that's the wrong approach | 16:10 |
edleafe | It's not breaking anything | 16:11 |
*** dikonoor has quit IRC | 16:11 | |
dansmith | edleafe: you think what is wrong? allowing insanity_mode? | 16:11 |
edleafe | dansmith: yes | 16:11 |
edleafe | If someone is actively relying on this, they *should* fail | 16:12 |
dansmith | edleafe: IMHO, I'd wait for people to complain and then do it to get them out of hot water | 16:12 |
edleafe | and they should feel bad | 16:12 |
dansmith | hah | 16:12 |
dansmith | but if bauzas is going to rage quit now, then I could be persuaded to add it now | 16:12 |
dansmith | but I agree, it seems like making better choices to me | 16:12 |
bauzas | I'm not rage quitting, just exhausted | 16:12 |
dansmith | johnthetubaguy: were you one of the concerned porties/ | 16:13 |
dansmith | jeez | 16:13 |
dansmith | *parties? | 16:13 |
bauzas | because in particular, my f**** change is hitting a functional test issue | 16:13 |
bauzas | based on that particular assumption | 16:13 |
dansmith | bauzas: that's trivial to fix right? | 16:13 |
*** mdnadeem has quit IRC | 16:13 | |
dansmith | that functional test is reporting something that depends on the broken behavior to work, right? | 16:13 |
bauzas | honestly? I dunno | 16:13 |
bauzas | we could fix up what the compute reports | 16:14 |
bauzas | that sounds the better approach | 16:14 |
*** shewless has quit IRC | 16:14 | |
dansmith | bauzas: you mean what compute reports in that functional test, yes? | 16:14 |
bauzas | but those whole tests are so opininiated about what should fail and what should succeed | 16:14 |
bauzas | dansmith: yup | 16:14 |
edleafe | bauzas: So you think that the test is absolutely correct in what it's testing? | 16:14 |
*** mdrabe has quit IRC | 16:15 | |
bauzas | edleafe: I just think that functional test is fine by me, it's just not taking care of other resources | 16:15 |
edleafe | bauzas: or could it be making the same incorrect assumption? | 16:15 |
dansmith | bauzas: but that test is relying on overcommitting the node with a single vm right? | 16:15 |
bauzas | edleafe: since we default verifying those resources, we could have to change the tests | 16:15 |
edleafe | Tests are code, and all code has bugs | 16:15 |
bauzas | dansmith: yup, it was just taking care of RAM previously | 16:16 |
dansmith | right, so the test is wrong | 16:16 |
dansmith | let's fix and move on | 16:16 |
*** tbachman has joined #openstack-nova | 16:16 | |
dansmith | I, for one, am fairly concerned about what happens if we don't merge this code this cycle | 16:16 |
dansmith | I dunno about anyone else | 16:16 |
*** owalsh has joined #openstack-nova | 16:16 | |
* bauzas raises his sleeves | 16:16 | |
dansmith | so I'm really not looking to settle for not landing it for anything other than a major problem | 16:17 |
*** markvoelker has joined #openstack-nova | 16:17 | |
bauzas | dansmith: I don't disagree at all | 16:17 |
bauzas | I'm just focusing on the right path to success | 16:17 |
*** armax has joined #openstack-nova | 16:18 | |
*** mfeoktistov has quit IRC | 16:18 | |
*** vsaienko has quit IRC | 16:18 | |
*** markvoelker_ has joined #openstack-nova | 16:18 | |
johnthetubaguy | dansmith: +1, I think we have to land it, warts and all | 16:18 |
dansmith | johnthetubaguy: so is RAX one that would care about not being able to overcommit the node with a single instance? | 16:18 |
johnthetubaguy | so I should be very specific on my concern | 16:19 |
johnthetubaguy | right now we don't run the core filter | 16:19 |
*** owalsh_ has quit IRC | 16:19 | |
johnthetubaguy | so the overcomit raito is not set correctly | 16:19 |
johnthetubaguy | thats easily fixable, but does bend our upgrade rules a bit | 16:19 |
dansmith | johnthetubaguy: ah I see.. we start honoring a config variable that you may not have had to set before.. that's a rather small bend... | 16:20 |
johnthetubaguy | the 10vCPU VM on an 8pCPU host doesn't worry me | 16:20 |
dansmith | johnthetubaguy: it's also hard to know how we'd communicate that if we were giving a cycle for reprecation | 16:20 |
dansmith | johnthetubaguy: also, overcommit on cpu is set to something large by default isn't it? | 16:21 |
dansmith | 16 and 1.5 | 16:21 |
dansmith | so people with defaults are probably in the sane range already I'd imagine | 16:21 |
johnthetubaguy | true, that is quite high already | 16:21 |
*** mdrabe has joined #openstack-nova | 16:21 | |
dansmith | bauzas: are you working on fixing the test? | 16:22 |
johnthetubaguy | the complexity is certainly less than having to check if the core filter is enabled | 16:22 |
*** markvoelker has quit IRC | 16:22 | |
bauzas | dansmith: indeed | 16:22 |
dansmith | johnthetubaguy: and more intuitive than having to enable a legacy filter to make the math work like you (should) expect for the new system | 16:22 |
dansmith | bauzas: okay I'll reply to the ML thread then | 16:23 |
bauzas | dansmith: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L683 is an example of what I mean by "opiniated" | 16:23 |
*** _ducttape_ has quit IRC | 16:23 | |
*** ducttape_ has joined #openstack-nova | 16:23 | |
*** sacharya has joined #openstack-nova | 16:24 | |
*** sacharya has quit IRC | 16:24 | |
*** mvk has joined #openstack-nova | 16:25 | |
*** efried has quit IRC | 16:25 | |
*** karimb has quit IRC | 16:26 | |
*** udesale has quit IRC | 16:26 | |
*** lpetrut has quit IRC | 16:26 | |
sfinucan | diana_clarke: Left a comment on https://review.openstack.org/#/c/421333. I can move onto the rest of the series once that's addressed | 16:28 |
*** zul has quit IRC | 16:28 | |
*** annegentle has joined #openstack-nova | 16:29 | |
*** zul has joined #openstack-nova | 16:29 | |
*** karimb has joined #openstack-nova | 16:29 | |
*** shaner has joined #openstack-nova | 16:31 | |
*** mjura has quit IRC | 16:32 | |
bauzas | dansmith: are you done with replying to my email ? because I can do that by me, I found the solution for the test | 16:33 |
*** mingyu has joined #openstack-nova | 16:33 | |
dansmith | just did | 16:33 |
bauzas | okay | 16:33 |
bauzas | I'm just considering how to patch correctly the FakeDriver within that testcase | 16:34 |
dansmith | can't you change the request instead of the fake driver? | 16:34 |
bauzas | dansmith: I would neither change the fake driver itself or the request | 16:35 |
bauzas | dansmith: the test is RAM-bounded, I'd like to keep it | 16:35 |
*** nic has quit IRC | 16:35 | |
bauzas | so my solution is to have enough CPU-filled computes | 16:35 |
bauzas | so the test would still assume which host would fail and which not but still only based on one metric, which is RAM | 16:36 |
bauzas | that's the less invasive | 16:36 |
dansmith | seems easiest to just request 100% of the compute to fill it, bu okay | 16:36 |
*** morgabra has quit IRC | 16:36 | |
bauzas | dansmith: it's sending 3 requests with the same big flavor with the assumption that only RAM would fail | 16:37 |
cfriesen | has anyone heard of virt.libvirt.guest.Guest.get_vcpus_map() failing with "exception: Requested operation is not valid: cpu affinity is not supported" ? Normally this works fine, I just saw it once during a stress test. | 16:37 |
*** mingyu has quit IRC | 16:38 | |
sahid | cfriesen: are you in TCG? | 16:38 |
*** nic has joined #openstack-nova | 16:38 | |
sahid | you should to verify first in you have well configured nova.conf to use kvm | 16:38 |
sahid | should verify | 16:39 |
*** chyka has joined #openstack-nova | 16:40 | |
cfriesen | sahid: this is real hardware with kvm | 16:40 |
cfriesen | sahid: most of the time it works fine on this system, but I saw this log once during a test of multiple live migrations. | 16:41 |
*** moshele has quit IRC | 16:41 | |
sahid | cfriesen: hum.. so i would suggest to verify whether the intel VT module is well loaded, it's probably something around that | 16:42 |
sahid | if it's not configuration issue, virt_type=kvm, the module well loaded so you will probably have to report a bug since that seems weird | 16:43 |
cfriesen | sahid: I'm pretty sure that the compute node stayed up and running during the test, but I'll check. | 16:43 |
sahid | cfriesen: also are you trying to run something related to NUMA ? | 16:44 |
cfriesen | sahid: this is on Mitaka, so I'm not sure how useful a bug report would be. CPU pinning would be enabled, so it'll be setting up InstanceNUMATopology | 16:44 |
cfriesen | actually, checking the logs more closely this message occurred multiple times...will dig a bit further, see if I can find a pattern. | 16:46 |
*** owalsh_ has joined #openstack-nova | 16:48 | |
*** owalsh_ has quit IRC | 16:48 | |
sfinucan | vladikr: The reno in https://review.openstack.org/#/c/405951/ is a little confusing | 16:50 |
bauzas | dansmith: thanks for your email, appreciated | 16:50 |
bauzas | dansmith: I'm about to find a solution, but since we also have the grenade issue, just lemme know if you wanna recheck anytime | 16:50 |
andreas_s | thorst_, FYI https://review.openstack.org/#/c/425279/ | 16:50 |
andreas_s | thorst_, it's not as nice than yours, but it does the job automatically | 16:50 |
sfinucan | Per my understanding, we want this feature because we want the set the VLAN tag inside the guest OS | 16:51 |
vladikr | sfinucan, hmm, okay.. how can I clarify it? | 16:51 |
andreas_s | thorst_, basically it's the generated file included into an rst... | 16:51 |
*** owalsh has quit IRC | 16:51 | |
dansmith | bauzas: I already did earlier but the gate is pretty slammed | 16:51 |
bauzas | ok | 16:51 |
sfinucan | ...but there's no way to access this from inside the instance without this feature | 16:51 |
sfinucan | vladikr: Is that correct? | 16:51 |
*** owalsh_ has joined #openstack-nova | 16:51 | |
*** owalsh_ is now known as owalsh | 16:52 | |
cfriesen | sahid: It appears to be a race between the resource audit and an instance that is just starting up. I suspect the domain hasn't yet gotten to a state where it will properly respond to this request. | 16:52 |
cfriesen | sahid: will need to reproduce on newer code before opening a bug report. | 16:52 |
*** andreas_s has quit IRC | 16:53 | |
vladikr | sfinucan, pretty much, I think. We can't set anything in side the guest. We want this field to be exposed so the guest so it will set the vlan on a virtual interface - if it need it to be set | 16:53 |
*** dtp has joined #openstack-nova | 16:54 | |
openstackgerrit | Ed Leafe proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 16:54 |
vladikr | sfinucan, so we just want to add additional parameter to the device metadata (that we have exposed to the guests with the device tagging work) | 16:55 |
sahid | cfriesen: ok cool, just as a sidenote since you spoke about live-migration: https://review.openstack.org/#/c/419479/ | 16:55 |
edleafe | cdent: Fixed your concern ^^ | 16:55 |
cdent | edleafe: thanks. was I crazy or insightful? | 16:56 |
edleafe | Those are not mutually exclusive | 16:56 |
sfinucan | vladikr: Right. So this sentence would suggest otherwise >>> "the VLAN configuration for the guest's virtual interfaces associated with such devices, can only be done within the guest instance itself." | 16:56 |
sfinucan | at least to me, that suggests the guest can now configure VLANs for these interfaces | 16:57 |
cdent | edleafe: was I right or wrong? | 16:57 |
* cdent hopes to be crazy and insightful | 16:57 | |
edleafe | cdent: you were right | 16:57 |
* cdent gives himself a cookie | 16:57 | |
vladikr | sfinucan, well it says that if you have assigned an sriov device to the guest you will get a virtual interface inside the guest | 16:57 |
cfriesen | sahid: thanks for the reference | 16:58 |
sfinucan | vladikr: Right, and it's the guest's responsibility to set the VLAN field on that virtual interface? | 16:58 |
vladikr | sfinucan, the guest can now configure the vNIC using the devices metadata | 16:58 |
vladikr | yea | 16:58 |
sfinucan | Gotcha | 16:58 |
sfinucan | That's what I thought, but I wasn't 100% :) | 16:58 |
*** markvoelker_ has quit IRC | 16:59 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Mark live_migration_downtime_steps/delay as deprecated for removal https://review.openstack.org/408002 | 16:59 |
*** markvoelker has joined #openstack-nova | 16:59 | |
vladikr | sfinucan, :) maybe it's just too much information there- not sure how to make it better | 17:02 |
*** markvoelker has quit IRC | 17:03 | |
*** chyka has quit IRC | 17:04 | |
*** Jeffrey4l_ has quit IRC | 17:06 | |
sfinucan | vladikr: Left a comment suggesting as much https://review.openstack.org/#/c/405951/12 | 17:07 |
vladikr | sfinucan, great, thanks | 17:07 |
*** owalsh_ has joined #openstack-nova | 17:07 | |
*** liangy has quit IRC | 17:07 | |
*** owalsh_ has quit IRC | 17:08 | |
*** owalsh_ has joined #openstack-nova | 17:08 | |
*** owalsh has quit IRC | 17:10 | |
*** owalsh_ is now known as owalsh | 17:10 | |
cdent | edleafe, bauzas, dansmith: because we haven't had enough to read about the resource tracker today, here's some analysis of things it might be doing less than perfectly with regard to the placement api: http://lists.openstack.org/pipermail/openstack-dev/2017-January/110953.html | 17:12 |
cdent | some of those are probably well known, but still worth thinking about so we avoid too many requests | 17:13 |
*** efried has joined #openstack-nova | 17:16 | |
*** alexpilotti has quit IRC | 17:17 | |
*** chyka has joined #openstack-nova | 17:18 | |
*** alexpilotti has joined #openstack-nova | 17:19 | |
*** sahid has quit IRC | 17:19 | |
openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.live_migration_rollback notification https://review.openstack.org/402124 | 17:21 |
*** browne has joined #openstack-nova | 17:21 | |
*** jaosorior has quit IRC | 17:22 | |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 17:22 |
*** alexpilotti has quit IRC | 17:23 | |
*** jheroux has joined #openstack-nova | 17:24 | |
edleafe | cdent: yeah, was just reading that | 17:25 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_instances https://review.openstack.org/421404 | 17:25 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_cell_and_hosts https://review.openstack.org/421420 | 17:25 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 verify_instance https://review.openstack.org/421436 | 17:25 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 simple_cell_setup https://review.openstack.org/421333 | 17:25 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_cell0 https://review.openstack.org/421384 | 17:25 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 delete_cell https://review.openstack.org/421459 | 17:25 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 discover_hosts https://review.openstack.org/421442 | 17:25 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 list_cells https://review.openstack.org/421458 | 17:25 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 create_cell https://review.openstack.org/421444 | 17:25 |
*** Jeffrey4l has joined #openstack-nova | 17:25 | |
edleafe | cdent: A lot of those were because of the belts & braces approach to make sure we didn't miss things | 17:26 |
cdent | some of them | 17:26 |
cdent | but there's outright wrongness with the tracked_instances thing | 17:26 |
cdent | and the redundancy between update and init is...annoying | 17:27 |
vladikr | sfinucan, how about https://etherpad.openstack.org/p/pf_vlan_reno ? | 17:27 |
*** Swami_ has quit IRC | 17:27 | |
*** alexpilotti has joined #openstack-nova | 17:28 | |
*** chyka has quit IRC | 17:29 | |
*** chyka has joined #openstack-nova | 17:30 | |
*** Jeffrey4l has quit IRC | 17:30 | |
*** Apoorva has joined #openstack-nova | 17:30 | |
bauzas | dansmith: I fixed the problem locally with the tests, I'm about to upload it once my run is done | 17:31 |
bauzas | dansmith: are you investigating on the grenade thing ? | 17:31 |
edleafe | cdent: init should only be run ... well, when the compute node starts up | 17:31 |
dansmith | bauzas: still waiting to get a slot to run, so just push it up | 17:31 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding vlans field to Device tagging metadata https://review.openstack.org/405951 | 17:31 |
dansmith | er, wait | 17:31 |
cdent | edleafe: yeah, except that it's not, because it is used as a "make sure it exists" | 17:32 |
bauzas | dansmith: okay | 17:32 |
bauzas | dansmith: just lemme know when | 17:32 |
bauzas | I can look at zuul | 17:32 |
dansmith | looks like I never rechecked it but I thought I did | 17:32 |
dansmith | so yeah, pushj | 17:32 |
*** jaosorior has joined #openstack-nova | 17:32 | |
*** alexpilotti has quit IRC | 17:32 | |
dansmith | the grenade patch is still waiting | 17:33 |
*** tesseract has quit IRC | 17:33 | |
*** karts has quit IRC | 17:34 | |
bauzas | ok | 17:34 |
*** chyka has quit IRC | 17:34 | |
bauzas | dansmith: one last full run locally on the test module with now the placement API and I upload | 17:35 |
*** baoli has joined #openstack-nova | 17:35 | |
*** aarefiev is now known as aarefiev_afk | 17:37 | |
dansmith | alright | 17:37 |
bauzas | KABOOOM | 17:39 |
*** chyka has joined #openstack-nova | 17:40 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 17:40 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters https://review.openstack.org/425185 | 17:40 |
*** alexpilotti has joined #openstack-nova | 17:44 | |
*** Swami has joined #openstack-nova | 17:46 | |
*** tbachman has quit IRC | 17:46 | |
*** alexpilotti has quit IRC | 17:46 | |
*** alexpilotti has joined #openstack-nova | 17:47 | |
*** dillaman has quit IRC | 17:47 | |
*** lpetrut has joined #openstack-nova | 17:49 | |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_instances https://review.openstack.org/421404 | 17:52 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_cell_and_hosts https://review.openstack.org/421420 | 17:52 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 verify_instance https://review.openstack.org/421436 | 17:52 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 delete_cell https://review.openstack.org/421459 | 17:52 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 discover_hosts https://review.openstack.org/421442 | 17:52 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 list_cells https://review.openstack.org/421458 | 17:52 |
openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 create_cell https://review.openstack.org/421444 | 17:52 |
*** dillaman has joined #openstack-nova | 17:53 | |
*** lucasagomes is now known as lucas-afk | 17:54 | |
*** karimb has quit IRC | 17:55 | |
*** ralonsoh has quit IRC | 17:58 | |
*** beagles is now known as beagles-biab | 17:59 | |
*** cdent has quit IRC | 17:59 | |
*** owalsh is now known as owalsh-afk | 18:03 | |
*** sdague has quit IRC | 18:03 | |
*** smatzek has quit IRC | 18:06 | |
*** smatzek has joined #openstack-nova | 18:06 | |
*** owalsh-afk has quit IRC | 18:08 | |
*** owalsh-afk has joined #openstack-nova | 18:09 | |
*** unicell has joined #openstack-nova | 18:20 | |
*** cdent has joined #openstack-nova | 18:21 | |
*** READ10 has quit IRC | 18:23 | |
*** dharinic is now known as dharinic|lunch | 18:24 | |
*** efoley_ has quit IRC | 18:26 | |
*** vsaienko has joined #openstack-nova | 18:27 | |
*** catinthe_ has joined #openstack-nova | 18:33 | |
*** sambetts is now known as sambetts|afk | 18:34 | |
openstackgerrit | melanie witt proposed openstack/nova: WIP Count resources to check quota for cells https://review.openstack.org/416521 | 18:34 |
openstackgerrit | melanie witt proposed openstack/nova: Make Quotas object favor the API database https://review.openstack.org/410945 | 18:34 |
openstackgerrit | melanie witt proposed openstack/nova: Add online migration to move quotas to API database https://review.openstack.org/410946 | 18:34 |
dansmith | johnthetubaguy: if you're still around, I'll hit these ^ if you will ack them first | 18:35 |
dansmith | you clearly understand quotas :) | 18:35 |
*** mingyu has joined #openstack-nova | 18:35 | |
*** catintheroof has quit IRC | 18:35 | |
*** Sukhdev has quit IRC | 18:35 | |
*** Sukhdev has joined #openstack-nova | 18:36 | |
*** mingyu has quit IRC | 18:39 | |
*** krtaylor has quit IRC | 18:40 | |
*** Jeffrey4l has joined #openstack-nova | 18:41 | |
*** mvk has quit IRC | 18:42 | |
*** yamahata has joined #openstack-nova | 18:43 | |
*** jpena is now known as jpena|off | 18:45 | |
*** Jeffrey4l has quit IRC | 18:46 | |
*** vsaienko has quit IRC | 18:46 | |
*** sean-k-mooney has quit IRC | 18:47 | |
*** sean-k-mooney has joined #openstack-nova | 18:48 | |
*** markus_z has quit IRC | 18:51 | |
*** pcaruana has quit IRC | 18:53 | |
*** tbachman has joined #openstack-nova | 18:54 | |
*** vsaienko has joined #openstack-nova | 18:57 | |
*** tbachman has quit IRC | 18:59 | |
*** tbachman has joined #openstack-nova | 18:59 | |
*** sdague has joined #openstack-nova | 19:00 | |
*** alexpilotti has quit IRC | 19:00 | |
*** FL1SK has quit IRC | 19:01 | |
*** cdent has quit IRC | 19:03 | |
*** nicolasbock has quit IRC | 19:03 | |
*** esmiurium has quit IRC | 19:05 | |
*** dharinic|lunch is now known as dharinic | 19:06 | |
*** abalutoiu__ has quit IRC | 19:06 | |
*** ociuhandu has quit IRC | 19:07 | |
*** ijw has joined #openstack-nova | 19:08 | |
*** snikitin_ has joined #openstack-nova | 19:08 | |
*** ijw has quit IRC | 19:09 | |
*** ijw has joined #openstack-nova | 19:09 | |
*** Jeffrey4l has joined #openstack-nova | 19:10 | |
*** mlavalle has quit IRC | 19:10 | |
snikitin_ | mriedem: Hi Matt! I have two +2 on my instance diagnostics patches and I need final +W. Could you please look? https://review.openstack.org/#/c/394480/ https://review.openstack.org/#/c/355540/ | 19:11 |
*** moshele has joined #openstack-nova | 19:11 | |
*** liangy has joined #openstack-nova | 19:11 | |
*** esmiurium has joined #openstack-nova | 19:12 | |
*** mlavalle has joined #openstack-nova | 19:12 | |
*** Sukhdev has quit IRC | 19:13 | |
*** Jeffrey4l has quit IRC | 19:15 | |
*** alexpilotti has joined #openstack-nova | 19:15 | |
*** moshele has quit IRC | 19:18 | |
*** snikitin_ has quit IRC | 19:18 | |
*** krtaylor has joined #openstack-nova | 19:18 | |
*** alexpilotti has quit IRC | 19:19 | |
*** tojuvone has quit IRC | 19:21 | |
bauzas | dansmith: still issues with grenade on the scheduler change even with your PS5 http://logs.openstack.org/61/417961/25/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/405b949/logs/new/screen-n-sch.txt.gz?level=TRACE#_2017-01-25_19_01_47_099 | 19:21 |
*** jaosorior has quit IRC | 19:21 | |
bauzas | will look at it later | 19:21 |
bauzas | fortunatly now the functional job works :) | 19:23 |
*** sdague has quit IRC | 19:26 | |
*** sdague has joined #openstack-nova | 19:27 | |
*** alexpilotti has joined #openstack-nova | 19:30 | |
*** alexpilotti has quit IRC | 19:35 | |
*** mingyu has joined #openstack-nova | 19:36 | |
openstackgerrit | Ed Leafe proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 19:36 |
*** BobBall is now known as BobBall_AWOL | 19:39 | |
*** mingyu has quit IRC | 19:40 | |
*** chyka has quit IRC | 19:45 | |
*** chyka has joined #openstack-nova | 19:45 | |
*** alexpilotti has joined #openstack-nova | 19:47 | |
*** abalutoiu__ has joined #openstack-nova | 19:51 | |
*** alexpilotti has quit IRC | 19:52 | |
*** Sukhdev has joined #openstack-nova | 19:52 | |
*** Jeffrey4l has joined #openstack-nova | 19:58 | |
*** esmiurium has quit IRC | 19:59 | |
pumaranikar | johnthetubaguy, https://review.openstack.org/#/c/412634/ keystoneauth with glance client. Addressed your comments | 20:03 |
*** Jeffrey4l has quit IRC | 20:04 | |
*** Sukhdev has quit IRC | 20:05 | |
*** sdague has quit IRC | 20:06 | |
*** alexpilotti has joined #openstack-nova | 20:07 | |
*** esmiurium has joined #openstack-nova | 20:07 | |
*** morgabra has joined #openstack-nova | 20:08 | |
*** morgabra has quit IRC | 20:08 | |
*** morgabra has joined #openstack-nova | 20:08 | |
bauzas | dansmith: confirmed that grenade doesn't work correctly with http://logs.openstack.org/30/424730/5/check/gate-grenade-dsvm-neutron-ubuntu-xenial/b39c47f/logs/new/screen-n-cpu.txt.gz#_2017-01-25_17_42_37_321 | 20:08 |
bauzas | dansmith: that's due to auth_url being wrong http://logs.openstack.org/30/424730/5/check/gate-grenade-dsvm-neutron-ubuntu-xenial/b39c47f/logs/etc/nova/nova.conf.txt.gz | 20:09 |
bauzas | fancy ! | 20:09 |
bauzas | I think I know the problem | 20:09 |
bauzas | yup, we're missing some vars https://github.com/openstack-dev/devstack/blob/master/lib/placement#L103 | 20:10 |
bauzas | I think we just need to source lib/keystone | 20:11 |
*** jaosorior has joined #openstack-nova | 20:12 | |
*** mvk has joined #openstack-nova | 20:13 | |
bauzas | ok, updated, let's wait the run... | 20:13 |
*** spligak has quit IRC | 20:15 | |
*** nicolasbock has joined #openstack-nova | 20:16 | |
*** beagles-biab is now known as beagles | 20:16 | |
*** jaosorior has quit IRC | 20:17 | |
bauzas | wow, just wow | 20:18 |
*** sdague has joined #openstack-nova | 20:18 | |
bauzas | the gate is late by more than 4 hours | 20:18 |
bauzas | chilly | 20:19 |
*** moshele has joined #openstack-nova | 20:23 | |
*** burgerk has quit IRC | 20:23 | |
*** jaosorior has joined #openstack-nova | 20:24 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828 | 20:26 |
*** catinthe_ has quit IRC | 20:27 | |
*** bvanhav has quit IRC | 20:28 | |
*** efried has quit IRC | 20:35 | |
*** slaweq has quit IRC | 20:40 | |
*** slaweq has joined #openstack-nova | 20:41 | |
*** Jeffrey4l has joined #openstack-nova | 20:45 | |
*** jamielennox|away has quit IRC | 20:46 | |
*** shaner has quit IRC | 20:53 | |
*** owalsh-afk is now known as owalsh | 20:53 | |
*** sdague has quit IRC | 20:53 | |
*** sdague has joined #openstack-nova | 20:54 | |
*** tbachman has quit IRC | 20:55 | |
*** jamielennox|away has joined #openstack-nova | 20:56 | |
*** jamielennox|away is now known as jamielennox | 20:56 | |
*** alexpilotti has quit IRC | 20:58 | |
*** burgerk has joined #openstack-nova | 21:00 | |
*** FL1SK has joined #openstack-nova | 21:01 | |
*** raunak_ has joined #openstack-nova | 21:01 | |
*** alexpilotti has joined #openstack-nova | 21:02 | |
*** burgerk_ has joined #openstack-nova | 21:02 | |
*** shaner has joined #openstack-nova | 21:04 | |
*** burgerk has quit IRC | 21:05 | |
*** alexpilotti has quit IRC | 21:07 | |
bauzas | damn, now a 401 :( | 21:08 |
bauzas | dansmith: ^ | 21:08 |
dansmith | argh | 21:08 |
bauzas | nova.conf looks correct http://logs.openstack.org/30/424730/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/16175d7/logs/etc/nova/nova.conf.txt.gz | 21:09 |
bauzas | but http://logs.openstack.org/30/424730/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/16175d7/logs/new/screen-n-cpu.txt.gz#_2017-01-25_20_43_30_774 | 21:09 |
bauzas | and cdent bailed out | 21:10 |
bauzas | :( | 21:10 |
bauzas | the creds look correct to me also | 21:11 |
*** tbachman has joined #openstack-nova | 21:14 | |
bauzas | dansmith: okay, so when comparing a tempest nova.conf and a grenade nova.conf, both are similar | 21:14 |
bauzas | I guess the problem is that we don't correctly have the placement API running | 21:14 |
*** dimtruck is now known as zz_dimtruck | 21:16 | |
*** erlon has quit IRC | 21:20 | |
*** hamzy has quit IRC | 21:22 | |
*** erlon has joined #openstack-nova | 21:23 | |
*** mriedem has joined #openstack-nova | 21:29 | |
*** liangy has quit IRC | 21:29 | |
mriedem | dansmith: how goes it today? | 21:29 |
dansmith | mriedem: lots of gate failures and still some discussion over the mysql host change | 21:30 |
*** eharney has quit IRC | 21:30 | |
dansmith | mriedem: and sounds like bauzas is still struggling with the grenade change | 21:31 |
bauzas | indeed | 21:31 |
mriedem | this https://review.openstack.org/421399 ? | 21:31 |
mriedem | re: mysql host | 21:31 |
bauzas | the gate is also 4 hours off | 21:31 |
*** jaosorior has quit IRC | 21:31 | |
dansmith | yeah | 21:32 |
mriedem | dansmith: we can maybe just drop https://review.openstack.org/421399 | 21:32 |
bauzas | so, today is probably our last chance to get things done | 21:32 |
*** kfarr has joined #openstack-nova | 21:32 | |
dansmith | mriedem: we can't because we're discovering from the subnode in the devstack multinode job right? | 21:32 |
dansmith | see my comment just now | 21:32 |
bauzas | andreykurilin: around ? | 21:32 |
andreykurilin | bauzas: yes | 21:32 |
mriedem | i couldn't remember if i needed https://review.openstack.org/421399 for how i was previously doing things in devstack | 21:32 |
bauzas | andreykurilin: where are we wiht all the client changes ? | 21:33 |
bauzas | missed a bit of scope since I'm working on another thing | 21:33 |
dansmith | mriedem: I'm not even sure what variable d-g has that address in | 21:33 |
andreykurilin | bauzas: all client changes? | 21:34 |
*** Jeffrey4l_ has joined #openstack-nova | 21:34 | |
bauzas | andreykurilin: the fixes for 7.1.0 | 21:34 |
bauzas | for *releasing | 21:35 |
mriedem | dansmith: "Because we're calling discover_hosts from the subnode in devstack-gate" isn't actually true | 21:35 |
andreykurilin | bauzas: it is the last one - https://review.openstack.org/#/c/424256/ | 21:35 |
*** owalsh is now known as owalsh-brb | 21:35 | |
*** Jeffrey4l has quit IRC | 21:35 | |
dansmith | mriedem: eh? | 21:35 |
mriedem | we call it from the primary node in d-g | 21:35 |
mriedem | dansmith: i'm thinking i needed the mysql host fix for something to do with https://review.openstack.org/420976 | 21:36 |
mriedem | but need to remember quick | 21:36 |
dansmith | mriedem: isn't this using ansible to run it on the subnode? https://review.openstack.org/#/c/424252/4/devstack-vm-gate.sh@239 | 21:36 |
mriedem | dansmith: no, | 21:36 |
mriedem | $ANSIBLE primary | 21:36 |
mriedem | == primary node | 21:36 |
dansmith | why via ansible then? | 21:37 |
*** mingyu has joined #openstack-nova | 21:37 | |
mriedem | because that's what runs random shell stuff on the node? | 21:37 |
mriedem | and what i was told to use | 21:37 |
dansmith | mriedem: okay | 21:38 |
*** jamesdenton has quit IRC | 21:38 | |
dansmith | mriedem: I just removed it, so we'll see | 21:38 |
openstackgerrit | Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 21:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 21:39 |
mriedem | dansmith: so i just abandoned https://review.openstack.org/#/c/421399/ | 21:39 |
*** ociuhandu has joined #openstack-nova | 21:39 | |
mriedem | ok you broke the connection to it as a dep, good | 21:40 |
dansmith | yeah | 21:40 |
*** raunak_ has quit IRC | 21:40 | |
*** karimb has joined #openstack-nova | 21:40 | |
dansmith | I still think the assertion that the subnode shouldn't know the database host is based on nova-centric architecture, but happy to have one fewer thing in the dep chain | 21:41 |
mriedem | yeah basically f it and we'll sort it out later :) | 21:41 |
dansmith | yep | 21:41 |
*** mingyu has quit IRC | 21:42 | |
*** raunak has joined #openstack-nova | 21:42 | |
mriedem | so the devstack change for discover_hosts should be approved at some point today too, just pinged dtroyer | 21:43 |
dansmith | I pinged him earlier | 21:44 |
dansmith | the --verbose one failed jenkins in the gate, but should be on its way again soon | 21:44 |
dansmith | check was over 300 earlier today, but looks like it has calmed down a bit, which is good | 21:44 |
mriedem | es muy triste | 21:45 |
*** tbachman has quit IRC | 21:45 | |
dansmith | heh | 21:46 |
*** zz_dimtruck is now known as dimtruck | 21:46 | |
dansmith | melwitt: mriedem: should we remove mriedem's -2 on the bottom quotas patch since we're close? maybe let melwitt hold the -2 onit? | 21:47 |
dansmith | https://review.openstack.org/#/c/410945/ | 21:47 |
dansmith | actually can we go ahead and merge the bottom two? | 21:48 |
mriedem | i thought we weren't going to merge those unless the counting resources one was good | 21:49 |
mriedem | i've removed the -2 btw | 21:49 |
mriedem | b/c we don't have reservations in the api db in the bottom changes i thought | 21:50 |
dansmith | ah | 21:50 |
dansmith | the counting patch is massive | 21:51 |
dansmith | which I guess is why it's still WIP | 21:51 |
mriedem | yeah, and probably too risky at this point | 21:51 |
mriedem | i.e. i think we need more burn in time with testing for a change like that | 21:52 |
dansmith | so you're calling it? | 21:52 |
mriedem | so does that automatically mean the bottom two changes can't get in? i believe they will just fallback to the main db for reservations/usages since those won't be in the api db | 21:52 |
mriedem | well, | 21:52 |
mriedem | seems pretty damn risky at this point | 21:52 |
mriedem | is melwitt around? | 21:52 |
dansmith | from what I saw of the first two, it doesn't really change anything so I would expect the bottom ones are okay, but.. I forgot about reservations | 21:53 |
mriedem | and usages | 21:53 |
mriedem | i think those were the 2 tables that weren't being ported | 21:53 |
dansmith | aye | 21:54 |
dansmith | well, john and I have been hitting that hard in the last day expecting to get it in, but I dunno. I guess we'll wait for melwitt to get back and advise | 21:54 |
*** owalsh-brb is now known as owalsh | 21:55 | |
*** cleong has quit IRC | 21:57 | |
*** raunak has quit IRC | 21:58 | |
*** alexpilotti has joined #openstack-nova | 21:59 | |
*** breitz has quit IRC | 22:00 | |
*** breitz has joined #openstack-nova | 22:00 | |
*** sdague has quit IRC | 22:02 | |
*** alexpilotti has quit IRC | 22:03 | |
bauzas | if someone could tell me how we can raise keystoneclient.Unauthorized exceptions when calling https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L616 ... | 22:09 |
bauzas | I'm puzzled | 22:09 |
*** _ducttape_ has joined #openstack-nova | 22:09 | |
*** eharney has joined #openstack-nova | 22:09 | |
bauzas | mmmmmpf nvm https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L652 | 22:09 |
*** ducttape_ has quit IRC | 22:12 | |
bauzas | mriedem: still around? | 22:14 |
bauzas | mriedem: I'd love more context about https://review.openstack.org/#/c/416810/ | 22:15 |
*** moshele has quit IRC | 22:16 | |
mriedem | bauzas: context how? | 22:20 |
mriedem | did you read the bug report? | 22:20 |
*** raunak has joined #openstack-nova | 22:20 | |
mriedem | or the related change - nova.conf was misconfigured for how to connect to placement for awhile with keystone v3 | 22:20 |
mriedem | so you'd get 401 | 22:20 |
bauzas | mriedem: yup, saw the change in devstack lib/placement | 22:21 |
bauzas | but I'm hitting the same 401 in grenade job | 22:21 |
bauzas | AFAICS, the value is still "Default" https://github.com/openstack-dev/devstack/blob/7a1e6f042f00ac94ec30bb8c6bf5d05b34623832/lib/keystone#L107 | 22:22 |
*** lpetrut has quit IRC | 22:22 | |
*** gouthamr has quit IRC | 22:24 | |
mriedem | not sure, would have to see that everything is configured the same and if not, what's different and what's missing | 22:24 |
mriedem | but i'm taking maya to the pool so back in a few hours | 22:24 |
bauzas | no worries | 22:25 |
*** avolkov has quit IRC | 22:25 | |
*** browne has quit IRC | 22:28 | |
*** thorst_ has quit IRC | 22:28 | |
*** raunak has quit IRC | 22:29 | |
*** _ducttape_ has quit IRC | 22:29 | |
*** ducttape_ has joined #openstack-nova | 22:29 | |
*** raunak has joined #openstack-nova | 22:30 | |
*** baoli has quit IRC | 22:31 | |
*** jheroux has quit IRC | 22:33 | |
*** annegentle has quit IRC | 22:34 | |
*** tblakes has quit IRC | 22:38 | |
*** Sukhdev has joined #openstack-nova | 22:41 | |
*** tbachman has joined #openstack-nova | 22:43 | |
*** owalsh_ has joined #openstack-nova | 22:46 | |
*** owalsh has quit IRC | 22:46 | |
*** owalsh_ is now known as owalsh | 22:47 | |
*** kaisers_ has quit IRC | 22:51 | |
*** Guest53005 has quit IRC | 22:51 | |
*** dave-mcc_ has joined #openstack-nova | 22:52 | |
*** edmondsw has quit IRC | 22:52 | |
*** _ducttape_ has joined #openstack-nova | 22:53 | |
*** dave-mccowan has quit IRC | 22:54 | |
*** edmondsw has joined #openstack-nova | 22:55 | |
*** ducttape_ has quit IRC | 22:56 | |
*** _ducttape_ has quit IRC | 22:57 | |
*** edmondsw has quit IRC | 22:59 | |
*** catintheroof has joined #openstack-nova | 23:00 | |
*** dimtruck is now known as zz_dimtruck | 23:02 | |
*** Swami has quit IRC | 23:04 | |
*** mdrabe has quit IRC | 23:05 | |
*** dave-mcc_ has quit IRC | 23:05 | |
*** claudiub has quit IRC | 23:05 | |
*** tbachman has quit IRC | 23:05 | |
*** dave-mccowan has joined #openstack-nova | 23:05 | |
*** kfarr has quit IRC | 23:08 | |
*** zz_dimtruck is now known as dimtruck | 23:08 | |
*** esmiurium has quit IRC | 23:09 | |
*** browne has joined #openstack-nova | 23:10 | |
*** marst has quit IRC | 23:13 | |
bauzas | dansmith: still around? | 23:15 |
bauzas | dansmith: I wonder if we don't run init_placement() method within grenade | 23:16 |
bauzas | just verifying the grenade log, but in case you know... | 23:16 |
dansmith | bauzas: if you don't see it, then we don't | 23:17 |
dansmith | bauzas: if we don't in neutron devstack, and you don't see it in grenade then, we don't | 23:17 |
bauzas | sec, verifying the grenade deployment | 23:17 |
*** esmiurium has joined #openstack-nova | 23:18 | |
*** krtaylor has quit IRC | 23:18 | |
*** hamzy has joined #openstack-nova | 23:18 | |
bauzas | dansmith: confirmed | 23:18 |
bauzas | dansmith: can't find it in http://logs.openstack.org/30/424730/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/16175d7/logs/grenade.sh.txt.gz | 23:19 |
bauzas | lemme fix that quickly | 23:19 |
*** vsaienko has quit IRC | 23:20 | |
*** tbachman has joined #openstack-nova | 23:20 | |
*** xyang1 has quit IRC | 23:20 | |
bauzas | dansmith: do you think we should do that in the from_newton script or in upgrade.sh ? | 23:20 |
dansmith | from-newton | 23:21 |
*** kaisers has joined #openstack-nova | 23:21 | |
bauzas | ok | 23:22 |
*** alexpilotti has joined #openstack-nova | 23:23 | |
*** alexpilotti has quit IRC | 23:23 | |
bauzas | dansmith: done editing | 23:23 |
bauzas | dansmith: I'll have to bail out soon, I need to wake up early | 23:24 |
dansmith | okay | 23:24 |
bauzas | but in case it works, could you please look at the change ? | 23:24 |
*** dimtruck is now known as zz_dimtruck | 23:24 | |
bauzas | I'll review your own change tomorrow morning | 23:24 |
*** ducttape_ has joined #openstack-nova | 23:25 | |
dansmith | cripes I keep failing this one test, but nothing has changed since it was passing | 23:25 |
dansmith | grr | 23:25 |
bauzas | which one ? | 23:26 |
*** raunak has quit IRC | 23:26 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828 | 23:27 |
dansmith | bauzas: go to sleep | 23:28 |
*** raunak has joined #openstack-nova | 23:28 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 23:28 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters https://review.openstack.org/425185 | 23:28 |
bauzas | voila... all the changes are now rebased | 23:28 |
bauzas | dansmith: I'll at least wait a few mins to see if we have at least one grenade job done | 23:29 |
*** vsaienko has joined #openstack-nova | 23:30 | |
*** tbachman has quit IRC | 23:31 | |
dansmith | oh jeez | 23:32 |
*** mlavalle has quit IRC | 23:35 | |
openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 23:36 |
*** mingyu has joined #openstack-nova | 23:39 | |
*** pradk has quit IRC | 23:40 | |
*** mingyu has quit IRC | 23:43 | |
*** zz_dimtruck is now known as dimtruck | 23:44 | |
*** Swami has joined #openstack-nova | 23:46 | |
*** baoli has joined #openstack-nova | 23:47 | |
*** tbachman has joined #openstack-nova | 23:47 | |
*** Swami_ has joined #openstack-nova | 23:48 | |
*** Swami has quit IRC | 23:51 | |
*** Swami has joined #openstack-nova | 23:52 | |
*** Swami_ has quit IRC | 23:55 | |
*** esberglu has quit IRC | 23:56 | |
*** catintheroof has quit IRC | 23:58 | |
*** catintheroof has joined #openstack-nova | 23:59 | |
*** Swami has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!