Tuesday, 2017-02-07

*** smatzek has joined #openstack-nova00:01
*** smatzek_ has joined #openstack-nova00:03
*** sacharya has joined #openstack-nova00:03
*** crushil has quit IRC00:04
*** salv-orl_ has quit IRC00:05
*** smatzek has quit IRC00:06
*** crushil has joined #openstack-nova00:07
*** sacharya has quit IRC00:07
*** jamesdenton has quit IRC00:08
*** alineb has joined #openstack-nova00:08
*** yingjun has joined #openstack-nova00:11
*** thorst_ has joined #openstack-nova00:19
*** smatzek_ has quit IRC00:25
*** adisky_ has quit IRC00:29
*** hongbin_ has quit IRC00:30
*** iceyao has joined #openstack-nova00:31
*** chyka has quit IRC00:32
*** guchihiro has joined #openstack-nova00:33
*** guchihiro has left #openstack-nova00:33
*** jamesdenton has joined #openstack-nova00:35
*** raunak has joined #openstack-nova00:37
*** zz_dimtruck is now known as dimtruck00:40
*** ducttape_ has joined #openstack-nova00:42
*** zhurong has joined #openstack-nova00:44
*** hoangcx has joined #openstack-nova00:49
*** jamesdenton has quit IRC00:51
*** tuanluong has joined #openstack-nova00:55
*** iceyao_ has joined #openstack-nova00:57
*** phuongnh has joined #openstack-nova01:01
*** iceyao has quit IRC01:01
*** kylek3h_away has joined #openstack-nova01:06
*** david-lyle has quit IRC01:06
*** thorst_ has quit IRC01:09
*** yingjun has quit IRC01:11
*** kevinz has joined #openstack-nova01:16
*** alexpilo_ has quit IRC01:16
*** sacharya has joined #openstack-nova01:19
*** sacharya has quit IRC01:24
*** aweeks has joined #openstack-nova01:24
*** alexpilotti has joined #openstack-nova01:27
*** Apoorva has quit IRC01:29
*** baoli has joined #openstack-nova01:31
*** alexpilotti has quit IRC01:31
*** jose-phillips has quit IRC01:31
*** alexpilotti has joined #openstack-nova01:34
*** alexpilotti has quit IRC01:38
*** mvensky has joined #openstack-nova01:38
*** ducttape_ has quit IRC01:39
*** raunak has quit IRC01:56
*** mvensky has quit IRC01:57
*** sdague_ has quit IRC01:57
*** sacharya has joined #openstack-nova01:59
*** owalsh is now known as owalsh-afk02:01
*** panda|bbl is now known as panda|zZ02:03
*** vsaienko has quit IRC02:03
*** jamesdenton has joined #openstack-nova02:05
*** tanee is now known as tanee_away02:07
*** tanee_away is now known as tanee02:07
*** diga has quit IRC02:10
*** gcb has joined #openstack-nova02:12
openstackgerritChangBo Guo(gcb) proposed openstack/nova master: Enable more virt.xenapi tests on Python 3  https://review.openstack.org/41442102:18
openstackgerritChangBo Guo(gcb) proposed openstack/nova master: Skip unit tests for SSL + py3  https://review.openstack.org/42650502:18
*** mlavalle has quit IRC02:19
*** unicell1 has quit IRC02:19
*** hfu has joined #openstack-nova02:20
*** gongysh has joined #openstack-nova02:31
openstackgerritHuan Xie proposed openstack/nova master: Fix live migrate with XenServer  https://review.openstack.org/42442802:32
*** alexpilotti has joined #openstack-nova02:32
*** ducttape_ has joined #openstack-nova02:33
*** jamesdenton has quit IRC02:36
*** alexpilotti has quit IRC02:37
*** ducttape_ has quit IRC02:45
*** thorst_ has joined #openstack-nova02:48
*** thorst_ has quit IRC02:48
alex_xuoomichi: yea, will check that after meeting02:51
*** hongbin has joined #openstack-nova02:55
*** sdague has joined #openstack-nova02:55
*** sudipto_ has joined #openstack-nova02:55
*** sudipto has joined #openstack-nova02:55
*** burgerk has joined #openstack-nova03:00
*** ducttape_ has joined #openstack-nova03:02
*** thorst_ has joined #openstack-nova03:04
*** thorst_ has quit IRC03:04
*** david-lyle has joined #openstack-nova03:13
*** sdague has quit IRC03:13
*** diga has joined #openstack-nova03:18
*** yamahata has quit IRC03:22
*** burgerk has quit IRC03:22
*** gouthamr has quit IRC03:26
openstackgerritVladik Romanovsky proposed openstack/nova master: neutron: retrieve physical netwrok name from a multi-provider network  https://review.openstack.org/43002603:29
openstackgerritChangBo Guo(gcb) proposed openstack/nova master: Use min parameter to restrict live-migration config options  https://review.openstack.org/32331303:29
*** alexpilotti has joined #openstack-nova03:32
*** nic has quit IRC03:34
*** owalsh has joined #openstack-nova03:35
*** owalsh-afk has quit IRC03:35
*** edmondsw has joined #openstack-nova03:37
*** alexpilotti has quit IRC03:37
*** ducttape_ has quit IRC03:37
*** links has joined #openstack-nova03:41
*** edmondsw has quit IRC03:41
*** yamahata has joined #openstack-nova03:42
*** ducttape_ has joined #openstack-nova03:47
*** sdague has joined #openstack-nova03:54
*** zhurong has quit IRC03:57
*** ijw has joined #openstack-nova03:58
*** thorst_ has joined #openstack-nova03:59
*** thorst_ has quit IRC04:00
*** nicolasbock has quit IRC04:01
*** ijw has quit IRC04:03
*** ducttape_ has quit IRC04:03
*** ducttape_ has joined #openstack-nova04:05
*** ducttape_ has quit IRC04:05
*** ducttape_ has joined #openstack-nova04:06
*** bkopilov_ has joined #openstack-nova04:12
*** bkopilov has joined #openstack-nova04:12
*** baoli has quit IRC04:13
*** dave-mccowan has quit IRC04:14
*** jose-phillips has joined #openstack-nova04:15
openstackgerritEmilien Macchi proposed openstack/nova master: DNM - test tripleo without nova api in WSGI/apache  https://review.openstack.org/42900804:15
*** Nakato_ is now known as Nakato04:18
*** thorst_ has joined #openstack-nova04:19
*** thorst_ has quit IRC04:19
*** raunak has joined #openstack-nova04:19
*** armax has quit IRC04:21
*** nmathew has joined #openstack-nova04:24
*** jose-phillips has quit IRC04:25
*** mdnadeem has joined #openstack-nova04:25
*** hongbin has quit IRC04:26
*** ducttape_ has quit IRC04:30
*** takashin has joined #openstack-nova04:32
*** alexpilotti has joined #openstack-nova04:35
*** ducttape_ has joined #openstack-nova04:37
*** unicell has joined #openstack-nova04:38
*** crushil has quit IRC04:39
*** Daisy has joined #openstack-nova04:39
*** jose-phillips has joined #openstack-nova04:40
*** alexpilotti has quit IRC04:40
*** prateek has joined #openstack-nova04:41
*** prateek_ has joined #openstack-nova04:43
*** ducttape_ has quit IRC04:44
*** psachin has joined #openstack-nova04:49
*** dikonoor has joined #openstack-nova04:49
*** sudipto_ has quit IRC04:50
*** sudipto has quit IRC04:50
*** sree has joined #openstack-nova04:50
*** sudipto_ has joined #openstack-nova04:51
*** sudipto has joined #openstack-nova04:51
*** sudipto_ has quit IRC04:51
*** yingjun has joined #openstack-nova04:52
*** alexpilotti has joined #openstack-nova04:53
Kevin_Zhengoomichi: could you check https://review.openstack.org/#/c/403568/ it is also high bug04:55
*** alexpilotti has quit IRC04:58
*** ayogi has joined #openstack-nova04:59
*** ratailor has joined #openstack-nova05:01
*** pbandark has joined #openstack-nova05:02
*** yingjun has quit IRC05:03
*** bswartz has quit IRC05:08
*** Daisy has quit IRC05:08
*** Daisy has joined #openstack-nova05:08
*** Daviey has quit IRC05:11
*** sudipto has joined #openstack-nova05:12
*** sudipto_ has joined #openstack-nova05:12
*** Daisy has quit IRC05:13
*** prateek has quit IRC05:20
*** prateek_ has quit IRC05:20
*** prateek has joined #openstack-nova05:22
*** trinaths has joined #openstack-nova05:22
*** markvoelker_ has quit IRC05:28
*** markvoelker has joined #openstack-nova05:28
*** markvoelker has quit IRC05:33
*** Daisy has joined #openstack-nova05:36
*** yingjun has joined #openstack-nova05:38
*** salv-orlando has joined #openstack-nova05:39
*** david-lyle has quit IRC05:40
*** Daisy has quit IRC05:41
*** salv-orlando has quit IRC05:44
openstackgerritLi Yingjun proposed openstack/nova master: libvirt: Enable custom video vgamem setting  https://review.openstack.org/41119105:47
*** sacharya has quit IRC05:48
*** links has quit IRC05:51
*** Daisy has joined #openstack-nova05:52
*** lpetrut has joined #openstack-nova05:54
*** liuyulong has quit IRC05:59
*** rcernin has joined #openstack-nova06:00
*** moshele has joined #openstack-nova06:00
*** moshele has quit IRC06:03
*** rcernin has quit IRC06:03
*** rcernin has joined #openstack-nova06:04
*** yingjun has quit IRC06:05
*** links has joined #openstack-nova06:07
*** satyar has joined #openstack-nova06:16
*** thorst_ has joined #openstack-nova06:20
*** links has quit IRC06:22
*** nkrinner_afk is now known as nkrinner06:22
*** jose-phillips has quit IRC06:23
*** zhurong has joined #openstack-nova06:23
*** thorst_ has quit IRC06:25
*** ekuris__ has joined #openstack-nova06:28
*** markvoelker has joined #openstack-nova06:28
*** markvoelker has quit IRC06:33
*** moshele has joined #openstack-nova06:34
*** Hosam has joined #openstack-nova06:35
*** links has joined #openstack-nova06:38
*** Daisy has quit IRC06:38
*** Daisy has joined #openstack-nova06:39
*** salv-orlando has joined #openstack-nova06:40
*** Hosam_ has joined #openstack-nova06:41
*** raunak has quit IRC06:42
*** Hosam has quit IRC06:43
*** salv-orlando has quit IRC06:44
*** Daisy_ has joined #openstack-nova06:45
*** lpetrut has quit IRC06:46
*** Daisy has quit IRC06:48
*** alexpilotti has joined #openstack-nova06:55
*** udesale has joined #openstack-nova06:55
*** avolkov has joined #openstack-nova06:56
*** tovin07_ has joined #openstack-nova06:57
openstackgerritMarkMielke proposed openstack/nova master: DiskFilter should only check if sufficient available storage exists, if storage has been requested.  https://review.openstack.org/43009106:57
*** alexpilotti has quit IRC06:59
*** dimtruck is now known as zz_dimtruck07:06
*** links has quit IRC07:07
*** nkrinner is now known as nkrinner_afk07:08
*** unicell1 has joined #openstack-nova07:10
*** unicell has quit IRC07:10
*** salv-orlando has joined #openstack-nova07:11
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: WIP add FusionCompute driver  https://review.openstack.org/43009907:13
*** panda|zZ is now known as panda|sick07:14
*** edmondsw has joined #openstack-nova07:15
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: WIP add FusionCompute driver  https://review.openstack.org/43009907:16
*** edmondsw has quit IRC07:19
*** links has joined #openstack-nova07:19
*** sridharg has joined #openstack-nova07:21
*** kaisers has joined #openstack-nova07:27
*** markvoelker has joined #openstack-nova07:29
*** trinaths has quit IRC07:30
*** nkrinner_afk is now known as nkrinner07:30
*** links has quit IRC07:30
*** zhurong has quit IRC07:31
*** tesseract has joined #openstack-nova07:31
*** markvoelker has quit IRC07:35
*** zhurong has joined #openstack-nova07:35
*** Hosam_ has quit IRC07:38
*** Hosam has joined #openstack-nova07:38
*** slaweq has joined #openstack-nova07:40
*** Hosam has quit IRC07:40
*** Hosam has joined #openstack-nova07:40
*** andreas_s has joined #openstack-nova07:41
*** links has joined #openstack-nova07:42
*** pcaruana has joined #openstack-nova07:46
*** pcaruana has quit IRC07:48
*** salv-orl_ has joined #openstack-nova07:49
*** salv-orlando has quit IRC07:52
*** trinaths has joined #openstack-nova07:53
*** slaweq has quit IRC07:53
*** pcaruana has joined #openstack-nova07:55
openstackgerritSergey Nikitin proposed openstack/nova-specs master: PCI NUMA Policies  https://review.openstack.org/36114007:59
*** jamielennox is now known as jamielennox|away07:59
*** takashin has left #openstack-nova08:02
*** Cristina__ is now known as CristinaPauna08:02
*** alexpilotti has joined #openstack-nova08:04
*** jamielennox|away is now known as jamielennox08:06
*** alexpilotti has quit IRC08:09
*** salv-orlando has joined #openstack-nova08:15
*** salv-orl_ has quit IRC08:21
*** thorst_ has joined #openstack-nova08:21
*** thorst_ has quit IRC08:26
*** amoralej|off is now known as amoralej08:28
*** slaweq has joined #openstack-nova08:31
*** markvoelker has joined #openstack-nova08:32
*** lpetrut has joined #openstack-nova08:32
*** alexpilotti has joined #openstack-nova08:34
*** markvoelker has quit IRC08:38
*** alexpilotti has quit IRC08:38
openstackgerritmelanie witt proposed openstack/nova master: WIP Request zero root disk for boot-from-volume instances  https://review.openstack.org/42848108:41
openstackgerritmelanie witt proposed openstack/nova master: Report zero root disk for boot-from-volume instances  https://review.openstack.org/42850508:41
*** mjura has joined #openstack-nova08:44
gcbsfinucan, https://review.openstack.org/#/c/414421/ is ready to merge now.08:53
*** dgonzalez_ has joined #openstack-nova08:54
*** sapcc-bot1 has joined #openstack-nova08:54
*** databus23_1 has joined #openstack-nova08:54
*** carthaca_1 has joined #openstack-nova08:54
*** david_1 has joined #openstack-nova08:54
*** mkoderer_ has joined #openstack-nova08:54
*** databus23_ has quit IRC08:54
*** sapcc-bot has quit IRC08:54
*** carthaca_ has quit IRC08:54
*** dgonzalez_ has quit IRC08:56
*** mkoderer_ has quit IRC08:56
*** david_1 has quit IRC08:56
openstackgerritxianming.mao proposed openstack/nova-specs master: Add support for volume online-migrate when backend has RBD  https://review.openstack.org/43013108:58
*** markus_z has joined #openstack-nova08:59
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-nova09:00
*** adisky_ has joined #openstack-nova09:03
*** salv-orlando has quit IRC09:04
*** salv-orlando has joined #openstack-nova09:07
*** kashyap` is now known as kashyap09:07
johnthetubaguygcb: do we thing those tests are OK now because mox has been removed?09:08
gcbjohnthetubaguy, I don't look too much about mox issue09:09
johnthetubaguygcb: how did we prove they don't still randomly fail?09:09
gcbjohnthetubaguy,  we discussed this before and get conclusion: enable one each  in one week to make sure we can figure out failure reason.09:11
gcbjohnthetubaguy, let me find out the discussion09:12
*** Guest35321 has quit IRC09:12
johnthetubaguygcb: yeah, I think I remember that now. It would be good to add that context in the git commit message, so others all know why it was done09:12
gcbjohnthetubaguy, will update it now09:13
johnthetubaguygcb: seriously though, we disable them because mox3 was failing randomly, I would rather do the mox conversion before we enabled them09:13
gcbjohnthetubaguy, what's the reason ? mox3 or  usage of mox309:16
*** yamahata has quit IRC09:17
johnthetubaguygcb: basically mox3 assertions seemed to fail randomly with py3, we never got to the root cause, but we decided to remove all mox from our tests to avoid hitting this issue: https://blueprints.launchpad.net/nova/+spec/remove-mox-pike09:18
johnthetubaguygcb: I think sdague might remember the details more09:18
openstackgerritxianming.mao proposed openstack/nova-specs master: Add support for volume online-migrate when backend has RBD  https://review.openstack.org/43013109:18
johnthetubaguygcb: a tiny bit more context is here: https://blueprints.launchpad.net/nova/+spec/remove-mox09:18
gcbjohnthetubaguy,  thanks09:18
*** Hosam has quit IRC09:19
*** aloga_ has joined #openstack-nova09:19
*** Daviey has joined #openstack-nova09:22
gcbjohnthetubaguy,  make removing mox/mox3 as a community goal ? :)09:22
johnthetubaguygcb: possibly, although all the slots are full for pike right now09:23
johnthetubaguygcb: not sure how many projects actually use mox, that might be an interesting thing to check (it might just be Nova!)09:23
gcbjohnthetubaguy,  http://codesearch.openstack.org/?q=mox3&i=nope&files=&repos=   Nova and horizon use a lot of them :)09:24
johnthetubaguyits probably an age thing09:25
robcresswellMox makes us sad :(09:25
robcresswell(Horizon, that is)09:25
johnthetubaguyrobcresswell: you are not alone in that09:26
gcbthen we can retire mox3 from oslo side09:26
johnthetubaguyI never like the record/reply pattern09:26
robcresswellI've just dealt with far too many cryptic failures. Testing with mox should not be *that* much more difficult than writing your actual logic.09:27
*** Daisy_ has quit IRC09:27
openstackgerritJohn Garbutt proposed openstack/nova master: Default live_migration_progress_timeout to off  https://review.openstack.org/42979809:27
robcresswellThat said, its generally been "good enough" so we've never actually removed it. There's always been higher priority issues.09:27
gcbThe third party mock module doesn't seem to be maintained anymore, suggest use unittest.mock on Python 309:27
gcbI try to use unittest.mock on Python 3 , there is an example https://review.openstack.org/#/c/429196/09:28
sfinucangcb: We do that anyway on Python3, no?09:28
sfinucan...and fall back to mock from pip for Python2.709:28
sfinucan(seeing as Python2.7 doesn't have it)09:29
*** lucas-afk is now known as lucasagomes09:29
*** gongysh has quit IRC09:29
gcbmock works well for python 2.7, just use unittest.mock on Python 309:29
*** gongysh has joined #openstack-nova09:29
*** jose-phillips has joined #openstack-nova09:29
johnthetubaguygcb: I thought thats what we did, but not 100% sure09:29
*** gongysh has quit IRC09:30
johnthetubaguygcb: it might be that mock got ahead of the py3 lib at one point, but I don't 100% remember now09:30
gcboslotest add this for six in https://github.com/openstack/oslotest/blob/master/oslotest/__init__.py09:31
*** liuyulong has joined #openstack-nova09:31
johnthetubaguygcb: ah, so we don't use the standard one, I see now09:31
johnthetubaguygcb: yeah, thats worth doing then09:31
gcbjohnthetubaguy, yeah09:31
sfinucanah, they're different imports. oops09:32
sfinucanYeah, definitely worth doing09:32
sfinucanthough lower than mox->mock :)09:32
johnthetubaguygcb: FWIW, its when mock looked like it was getting into python we totally stopped allowing more mox tests09:32
sfinucanjohnthetubaguy: We're ok to go merge stuff again, right?09:32
johnthetubaguysfinucan: that was news to me too09:33
sfinucani.e. trivial mox->mock stuff09:33
johnthetubaguysfinucan: ish, so the limitation is we don't want to make backports too hard, for the next week or so09:33
sfinucanah, I'll hold off on those so09:33
*** derekh has joined #openstack-nova09:33
sfinucanlest anyone want to backport tests too09:33
*** litao has quit IRC09:34
*** markvoelker has joined #openstack-nova09:34
*** litao has joined #openstack-nova09:35
johnthetubaguysfinucan: yeah, its worth waiting a week I think09:36
gcblet me add one item on https://etherpad.openstack.org/p/community-goals later, then we can start to move and set the the target in following cycle09:36
*** mnasiadka has joined #openstack-nova09:36
*** yassine has joined #openstack-nova09:37
johnthetubaguygcb: it feels like part of the prep for py3, so its probably a good stepping stone I guess09:37
*** yassine is now known as Guest5868909:37
johnthetubaguygcb: although I honestly think it would be quicker to get the functional tests passing on py3, before we get all the unit tests passing on py309:37
johnthetubaguyfor Nova that is09:37
*** mariusv has quit IRC09:38
*** mariusv has joined #openstack-nova09:39
*** mariusv has quit IRC09:39
*** mariusv has joined #openstack-nova09:39
gcbjohnthetubaguy, I added gate-nova-tox-db-functional-py35-ubuntu-xenial as non-voting, maybe we can make it votable09:40
johnthetubaguygcb: I think that would be a good thing to try09:40
*** markvoelker has quit IRC09:40
johnthetubaguygcb: you can always to a tempest skip list, like we have for cellsv1: https://github.com/openstack/nova/blob/master/devstack/tempest-dsvm-cells-rc09:41
johnthetubaguyi.e. get a job that passes creating at least one instance, then slowly enable more goodness as the fixes go in09:41
gcbI will be back after dinner :)09:42
*** zhurong has quit IRC09:44
openstackgerritJohn Garbutt proposed openstack/nova-specs master: WIP: Spec idea on the future of quotas for Nova  https://review.openstack.org/42967809:44
*** jose-phillips has quit IRC09:46
*** Dave___ is now known as Dave09:52
*** tovin07_ has quit IRC09:55
*** tovin07 has quit IRC09:56
*** CristinaPauna has quit IRC09:57
*** jschwarz has quit IRC10:01
*** jschwarz has joined #openstack-nova10:01
*** iceyao_ has quit IRC10:04
lyarwoodmdbooth: https://review.openstack.org/#/c/427364/ - I added the comments you requested btw, any chance of a quick review if you have time this morning?10:05
mdboothlyarwood: Got my head in something right now. Is there a chance of follow-on core review?10:05
mdbooth(iow: will my review achieve anything this morning)10:06
*** CristinaPauna has joined #openstack-nova10:06
lyarwoodmdbooth: ah, np, I was going to ask around now that we are past RC but don't go out of your way if you're in the middle of something10:07
*** carthaca_1 has quit IRC10:07
*** sapcc-bot1 has quit IRC10:07
*** databus23_1 has quit IRC10:07
*** sapcc-bot has joined #openstack-nova10:07
*** databus23_ has joined #openstack-nova10:07
*** carthaca_ has joined #openstack-nova10:07
*** mkoderer_ has joined #openstack-nova10:07
*** david_1 has joined #openstack-nova10:07
*** dgonzalez_ has joined #openstack-nova10:07
*** hoangcx has quit IRC10:08
*** mkoderer_ has quit IRC10:09
*** david_1 has quit IRC10:09
*** dgonzalez_ has quit IRC10:09
*** mariusv has quit IRC10:10
*** kevinz has quit IRC10:17
*** salv-orl_ has joined #openstack-nova10:19
mdboothShould we be logging authentication tokens?10:19
mdbooth2017-02-06 16:37:53.021 [n-api.log] 29609 DEBUG cinderclient.v2.client [req-f47e58e1-65a9-44b3-b9ea-90959d0255ab tempest-TestVolumeSwap-787392718 tempest-TestVolumeSwap-787392718] REQ: curl -g -i -X GET -H "X-Service-Token: {SHA1}161c3fe7af35615c3f7a8136153d893316c4afa5" -H "User-Agent: python-cinderclient" -H "Accept:10:20
mdboothapplication/json" -H "X-Auth-Token: {SHA1}dfc5e07945c13b29514dd78d29b374cf2e5d3a1f" _http_log_request /usr/local/lib/python2.7/dist-packages/keystoneauth1/session.py:34710:20
mdboothWhat's the lifetime of one of those tokens?10:20
markus_zbauzas: Do you have a minute?10:20
markus_zbauzas: It's about https://review.openstack.org/#/c/420079/110:21
bauzasmarkus_z: sure, but I'm a bit off this week10:21
rpodolyakamdbooth: we specifically store a hash of a token, so that it (i.e. a valid token) does not show up in logs, don?10:21
rpodolyaka* don't we10:21
*** salv-orlando has quit IRC10:21
bauzasmarkus_z: mmm, I should abandon this change10:21
mdboothrpodolyaka: Well the above it a cut/paste from my logs10:21
rpodolyakabut you still can track usage of a particular token in logs10:21
rpodolyakabut it's a hash10:21
rpodolyakanot a token itself10:22
rpodolyakaor I am missing something obvious? :)10:22
markus_zbauzas: I was wondering about the alternatives to this change.10:22
mdboothrpodolyaka: I'm wondering the same thing :)10:22
*** thorst_ has joined #openstack-nova10:22
mdboothIf it's the thing we send to cinder, does it matter if it's a hash or not?10:22
mdboothDoes it, eg, include a nonce component so it changes every time?10:22
markus_zbauzas: Our s390 CI is broken because of "No hosts found to map to cell, exiting." and I don't find a solution for that.10:22
rpodolyakamdbooth: it's not what goes over the wire10:22
rpodolyakait's just the way it's shown in logs10:23
rpodolyakai.e. a sha1 hash10:23
mdboothrpodolyaka: Ah... so that's logging an sha1 of what went over the wire?10:23
bauzasmarkus_z: see the bug https://bugs.launchpad.net/nova/+bug/165627610:23
openstackLaunchpad bug 1656276 in OpenStack Compute (nova) "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Undecided,In progress] - Assigned to Sylvain Bauza (sylvain-bauza)10:23
rpodolyakamdbooth: yep10:23
bauzasmarkus_z: that's the consensus now https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=dc2f3a358663c0fb97795666b16dec63cfcc387210:24
mdboothAre you sure about that? Seems kinda weird we wouldn't just elide it.10:24
mdboothIn other places we replace passwords with ***10:24
rpodolyakamdbooth: strace of `nova list` http://paste.openstack.org/raw/597914/10:25
rpodolyakawell, the relevant part of it :)10:25
mdboothrpodolyaka: Cool, that doesn't look like an sha1 :)10:25
mdboothrpodolyaka: Thanks10:25
*** Daisy has joined #openstack-nova10:26
*** thorst_ has quit IRC10:26
bauzasmarkus_z: also http://docs.openstack.org/developer/nova/cells.html#first-time-setup now differs from http://docs.openstack.org/developer/nova/cells.html#upgrade-minimal10:27
markus_zbauzas: We see that issue when we setup devstack (with devstack-gate). I'm not sure how that change applies to that situation.10:27
*** satyar has quit IRC10:28
openstackgerritBob Ball proposed openstack/nova master: XenAPI: fix memory usage miscalculation  https://review.openstack.org/39485710:28
bauzasmarkus_z: tbc, unless you're upgrading a newton cloud, you now need to stop using single_cell_setup and rather use map_cell0, then discover_hosts()10:28
*** Daisy has quit IRC10:30
*** udesale has quit IRC10:31
markus_zbauzas: Do I need to configure that in Devstacks local.conf? As said, it's for our CI.10:31
*** udesale has joined #openstack-nova10:31
bauzasmarkus_z: what do you mean by local.conf ?10:34
bauzasmarkus_z: you don't really need to modify your workflow10:35
bauzasif you're using devstack, it starts n-cpu because running simple_cell_setup AFAIK10:35
bauzaswhich is then all good10:35
bauzasthe problem here is when you start n-cpu after running simple_cell_setup10:35
bauzasthen that call considers finding no hosts is an error10:36
*** markvoelker has joined #openstack-nova10:37
markus_zbauzas: To make sure I understand it: This call is the correct one https://github.com/openstack-dev/devstack/blob/bd14f7f23e01968aba70f0025b85dc15f110abc1/lib/nova#L95210:38
*** sulo_ is now known as sulo10:39
markus_zAnd then nova-manage "discover_hosts" is called? https://github.com/openstack/nova/blob/9eb7bcea05ce2447496f6561caa1ae46b800f85d/nova/cmd/manage.py#L1379-L137910:40
bauzasdiscover_hosts is when you add a compute *after* doing the cellsv2 setup10:41
bauzasmarkus_z: ^10:41
bauzasfor the moment, there is no auto-registration of hosts in the cellsv2 world, but we need their mappings to order to place instances onto them10:42
*** markvoelker has quit IRC10:43
*** sambetts_ is now known as sambetts10:43
markus_zbauzas: I still don't get it :/  At the end of January there has to be a change which introduced something in that area which our CI isn't prepared to deal with.10:44
markus_zbauzas: Do I understand it correctly that "n-cpu" has to run *before* simple_cell_setup is called?10:46
bauzasmarkus_z: leave me 10 mins and we could hangout if you wish, okay10:47
markus_zbauzas: Let me dig more into the issue on my side before I'm consuming you time, but thanks a lot for the offer.10:49
*** cdent has joined #openstack-nova10:51
*** Guest58689 has quit IRC10:51
*** jkraj has joined #openstack-nova10:51
*** nmathew has quit IRC10:51
*** Guest58689 has joined #openstack-nova10:55
johnthetubaguymarkus_z: did you see the new docs that just merged by the way10:56
johnthetubaguymarkus_z: they explain things a lot better10:56
johnthetubaguymarkus_z: the thing that confused me is that "db sync" created cell0, only after you first did the create_cell0 thing, it could be a different thing you hit10:57
mdboothlyarwood: Hey, so detach_volume races with delete()10:57
tdurakovjohnthetubaguy: hi, which docs?10:57
mdboothi.e. if you detach_volume(), delete() really quickly, the delete will do the detach which is already in progress10:58
johnthetubaguytdurakov: https://github.com/openstack/nova/commit/da591bc543c84fb601e5d832ba6a28e38c03690110:58
mdboothlyarwood: Can you think of any bad things this might cause on the cinder side?10:58
tdurakovprevious time I've deployed multinode devstack, I need to run nova-manage cell_v2 simple_cell_setup after second compute is deployed10:58
mdboothjohnthetubaguy: Same question ^^^^ ?10:58
tdurakovtoday I've deployed new one, and it doesn't recognise second compute is added10:59
tdurakovthanks for the link!10:59
lyarwoodmdbooth: about to jump on a call10:59
johnthetubaguytdurakov: markus_z: there is an ordering issue I suspect. You need to have started n-cpu to be able to discover it10:59
mdboothlyarwood: k10:59
lyarwoodmdbooth: I can't think of anything bad on the cinder cide10:59
lyarwoodmdbooth: but that is going to screw up host state and leave things hanging around with iSCSI/FC etc10:59
lyarwoodmdbooth: ah no wait we have locks around disconnect_volume11:00
mdboothWell it's going do to do 2 detaches11:00
tdurakovjohnthetubaguy: hm... I'm not sure how this should work11:00
mdboothSo it's that going to extra cleanup?11:00
johnthetubaguymdbooth: lyarwood: unsure on cinder, I suspect its OK11:00
tdurakovlocal.conf on compute only node already has endpoints of controller node11:00
lyarwoodmdbooth: double terminate_connection calls should be fine as long as something has disconnected the volume from the host11:00
tdurakovso how I should reorder them properly11:01
*** pbandark has quit IRC11:01
johnthetubaguytdurakov: like I say, the docs do try cover that now, including the nova-manage man pages: https://github.com/openstack/nova/blob/5dad7eaef7f8562425cce6b233aed610ca2d3148/doc/source/man/nova-manage.rst11:01
mdboothlyarwood: Thanks11:01
johnthetubaguytdurakov: I would talk you through it, but I would like to test the docs :)11:01
*** nicolasbock has joined #openstack-nova11:01
tdurakovjohnthetubaguy: that's ok11:01
tdurakovthank you11:01
*** pbandark has joined #openstack-nova11:01
johnthetubaguytdurakov: now worries, this is the rendered docs: http://docs.openstack.org/developer/nova/cells.html#step-by-step-for-common-use-cases11:02
johnthetubaguymarkus_z: http://docs.openstack.org/developer/nova/cells.html#step-by-step-for-common-use-cases and https://github.com/openstack/nova/blob/5dad7eaef7f8562425cce6b233aed610ca2d3148/doc/source/man/nova-manage.rst should be your friend11:02
mdboothAh... attach/delete would be worse, which is probably why that takes an instance lock11:03
* mdbooth suspects detach should also take the instance lock, but it's 'probably' ok11:04
* mdbooth adds a patch11:04
johnthetubaguymdbooth: I am wondering about the end API state vs what we have on the host, its not clear what we end up with11:04
*** sudipto has quit IRC11:05
*** sudipto_ has quit IRC11:05
*** rfolco has joined #openstack-nova11:06
*** phuongnh has quit IRC11:12
*** Hosam has joined #openstack-nova11:15
*** owalsh_ has joined #openstack-nova11:18
*** owalsh has quit IRC11:18
*** sree has quit IRC11:18
*** sree has joined #openstack-nova11:19
*** ducttape_ has joined #openstack-nova11:20
*** sree has quit IRC11:23
*** ducttape_ has quit IRC11:24
*** gszasz has joined #openstack-nova11:25
*** liusheng has quit IRC11:26
*** Hosam_ has joined #openstack-nova11:26
*** vi01et03 has joined #openstack-nova11:26
*** liusheng has joined #openstack-nova11:26
*** diga has quit IRC11:27
*** mvk has quit IRC11:27
*** pbandark has quit IRC11:27
*** Hosam has quit IRC11:28
*** edmondsw has joined #openstack-nova11:33
*** edmondsw has quit IRC11:37
*** markvoelker has joined #openstack-nova11:39
openstackgerritMatthew Booth proposed openstack/nova master: Fix various races with detach_volume  https://review.openstack.org/43021311:42
openstackgerritSergey Nikitin proposed openstack/nova master: TrivialFix: replace list comprehension with 'for'  https://review.openstack.org/43021411:42
*** owalsh_ is now known as owalsh11:43
*** markvoelker has quit IRC11:46
*** salv-orl_ has quit IRC11:47
*** salv-orlando has joined #openstack-nova11:48
markus_zjohnthetubaguy: thanks, I haven't yet read the new docs, I'll do that today.11:51
*** tbachman has quit IRC11:52
johnthetubaguymarkus_z: no worries, hopefully it should help11:52
johnthetubaguymarkus_z: if not we should fix the docs :)11:52
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: Remove stuck live-migration detection  https://review.openstack.org/43021811:58
*** jschwarz has quit IRC12:00
johnthetubaguypkoniszewski: kick started the discussion around that bug in the above patch^12:00
mdboothjohnthetubaguy: Haven't looked at what it does yet, but +87, -163 looks good :)12:01
johnthetubaguymdbooth: heh :)12:01
*** brault is now known as brault|away12:06
*** mvk has joined #openstack-nova12:07
*** tuanluong has quit IRC12:07
*** mnestratov has joined #openstack-nova12:08
*** smatzek_ has joined #openstack-nova12:08
*** purplerbot has quit IRC12:15
*** purplerbot has joined #openstack-nova12:15
*** lucasagomes is now known as lucas-hungry12:18
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: Remove stuck live-migration detection  https://review.openstack.org/43021812:26
*** bkopilov_ has quit IRC12:28
*** bkopilov has quit IRC12:28
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: Remove stuck live-migration detection  https://review.openstack.org/43021812:28
*** mnestratov|2 has joined #openstack-nova12:29
*** cdent has quit IRC12:30
*** mnestratov has quit IRC12:32
*** sdague_ has joined #openstack-nova12:32
*** mnestratov has joined #openstack-nova12:34
*** gcb has quit IRC12:36
*** mnestratov|2 has quit IRC12:37
*** mnestratov has quit IRC12:37
*** mnestratov has joined #openstack-nova12:37
*** gcb has joined #openstack-nova12:37
*** vi01et03 has quit IRC12:39
*** bvanhav__ has joined #openstack-nova12:39
*** kevinz has joined #openstack-nova12:39
*** thorst_ has joined #openstack-nova12:39
*** ratailor has quit IRC12:40
BobBall_AWOLjohnthetubaguy: Could you re-approve https://review.openstack.org/#/c/424428/ pls? :)12:40
*** BobBall_AWOL is now known as BobBall12:40
*** markvoelker has joined #openstack-nova12:41
*** sandanar has joined #openstack-nova12:43
openstackgerritVladik Romanovsky proposed openstack/nova master: neutron: retrieve physical netwrok name from a multi-provider network  https://review.openstack.org/43002612:43
*** vsaienko has joined #openstack-nova12:43
mdboothvladikr: nit: you have a typo in the title12:44
*** gcb has quit IRC12:45
*** trinaths has quit IRC12:45
*** kevinz has quit IRC12:46
vladikrmdbooth, ah, thanks! :)12:46
*** kevinz has joined #openstack-nova12:47
*** markvoelker has quit IRC12:48
*** links has quit IRC12:48
openstackgerritVladik Romanovsky proposed openstack/nova master: neutron: retrieve physical network name from a multi-provider network  https://review.openstack.org/43002612:48
*** mnasiadka has quit IRC12:49
*** aloga_ has quit IRC12:49
*** catintheroof has joined #openstack-nova12:50
*** ducttape_ has joined #openstack-nova12:51
*** sdague has quit IRC12:52
*** gcb has joined #openstack-nova12:53
gcbsfinucan, can you remove your -2 now ? https://review.openstack.org/#/c/323313/12:53
*** ducttape_ has quit IRC12:55
*** dave-mccowan has joined #openstack-nova12:55
*** kevinz has quit IRC12:56
*** prateek has quit IRC12:57
*** kevinz has joined #openstack-nova12:57
sfinucangcb: Sure13:02
sfinucangcb: Actually, per johnthetubaguy's comments, perhaps we should wait until next week to merge that?13:03
gcbsfinucan, agree13:03
sfinucangcb: So the reason changes but the -2 remains until then :)13:04
gcbsfinucan, okay13:04
sfinucanbut ping me next week and I'll re-review13:05
*** ducttape_ has joined #openstack-nova13:08
*** gcb has quit IRC13:09
*** tblakes has joined #openstack-nova13:09
*** salv-orlando has quit IRC13:09
*** liverpooler has quit IRC13:10
*** liverpooler has joined #openstack-nova13:10
*** sudipto has joined #openstack-nova13:12
*** sudipto_ has joined #openstack-nova13:12
*** sree has joined #openstack-nova13:14
*** lucas-hungry is now known as lucasagomes13:20
*** jheroux has joined #openstack-nova13:21
*** tbachman has joined #openstack-nova13:21
*** edmondsw has joined #openstack-nova13:23
*** ralonsoh has joined #openstack-nova13:23
*** s1rp has left #openstack-nova13:24
*** karimb has joined #openstack-nova13:25
*** mptacekx has joined #openstack-nova13:26
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova master: Initiate network changes from source during live migration  https://review.openstack.org/40460713:28
*** jpena is now known as jpena|lunch13:31
openstackgerritMatthew Booth proposed openstack/nova master: Fix various races with detach_volume  https://review.openstack.org/43021313:35
pumaranikarjohnthetubaguy, cdent can you please check https://review.openstack.org/#/c/395194/ . Placement json formatter change13:36
*** hoangcx has joined #openstack-nova13:36
mdboothlyarwood: A festival of obscure syntax: https://github.com/mdbooth/openstack-dev-hacks/commit/1e13942134c298dd27af674fdcaf7a5ac72b1e82 :)13:39
johnthetubaguypumaranikar: whats the plan for all the other handlers?13:39
mdboothTo top it off, here's how I just called it: ci_log_fetch http://logs.openstack.org/09/395709/6/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/f829785/logs/ {c-{api,vol},n-{api,cond,cpu}}13:40
pumaranikarjohnthetubaguy, will be addressing in follow up patches13:40
*** cdelatte has joined #openstack-nova13:43
johnthetubaguypumaranikar: that LOG.error in your handler, did the original bug want that added?13:43
tdurakovpkoniszewski: hi, are you around?13:43
*** markvoelker has joined #openstack-nova13:44
pumaranikarjohnthetubaguy, it was not a requirement to add logging here13:44
*** sree_ has joined #openstack-nova13:44
*** amotoki has joined #openstack-nova13:44
*** Hosam_ has quit IRC13:44
*** ducttape_ has quit IRC13:44
*** egarbade- has quit IRC13:44
*** sree_ is now known as Guest6072313:45
*** ekhugen has quit IRC13:45
johnthetubaguypumaranikar: have you seen this, its worth a read: https://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html13:45
*** sree has quit IRC13:45
*** ekhugen has joined #openstack-nova13:47
pkoniszewskitdurakov: yes13:47
*** mtanino has quit IRC13:47
*** zz_dimtruck is now known as dimtruck13:47
*** egarbade- has joined #openstack-nova13:47
*** baoli has joined #openstack-nova13:48
lyarwoodmdbooth: nice!13:48
tdurakovpkoniszewski: there are some intersections in my schedule today, could you chair l-m meeting?13:48
pkoniszewskii'm afraid i need to skip the meeting today13:48
pkoniszewskileaving office in 10-15 minutes13:48
tdurakovpkoniszewski: ok13:49
*** markvoelker has quit IRC13:50
*** udesale__ has joined #openstack-nova13:50
*** salv-orlando has joined #openstack-nova13:50
*** udesale has quit IRC13:51
*** bswartz has joined #openstack-nova13:51
pumaranikarjohnthetubaguy, do you think error log level is not appropriate here ?13:51
*** bkopilov_ has joined #openstack-nova13:51
johnthetubaguypumaranikar: yeah, added comments13:51
tdurakovmdbooth: hi,  are you ok chairing lm meeting today?13:52
johnthetubaguypumaranikar: "Error: Serious issue with cloud, administrator should be notified immediately via email/pager. On call people expected to respond."13:52
*** bkopilov has joined #openstack-nova13:52
mdboothtdurakov: Not really, I'm totally not on top of it13:52
johnthetubaguypumaranikar: sometimes these errors raised by placement are almost expected, like not found error when you check something is deleted, etc13:52
mdboothtdurakov: If you'd asked me yesterday, maybe :)13:52
*** vsaienko has quit IRC13:53
pumaranikarjohnthetubaguy, yes. I thought of error level logging since it is in exception block13:53
tdurakovpaul-carlton2 eliqiao shaohe_feng pkoniszewski yuntongjin kashyap kmartin claudiub tobasco abhishekk mrhillsman raj_singh wznoinsk siva_krishnan, folks, let's skip the l-m meeting this week.13:53
johnthetubaguypumaranikar: yeah, need to think about the consumer of the message, it doesn't rally help them in this case13:53
johnthetubaguypumaranikar: but a debug log might be a good idea, if we include information on the specific exception13:54
johnthetubaguytdurakov: did you see this: https://review.openstack.org/#/c/429798/13:55
johnthetubaguytdurakov: trying to get it into RC2, if possible13:55
*** egonzalez has joined #openstack-nova13:56
pumaranikarjohnthetubaguy, ok. i will have look at your comment and make change accordingly13:56
*** skarthik is now known as karthiks13:56
tdurakovjohnthetubaguy: I'll review it in 1.5 hours, or earlier13:56
johnthetubaguytdurakov: I was wondering if the folks in the meeting agree if we should try get that into RC2 I guess13:57
*** vsaienko has joined #openstack-nova13:58
*** baoli has quit IRC13:58
*** baoli has joined #openstack-nova13:59
tdurakovjohnthetubaguy: btw, have you seen this one https://review.openstack.org/#/c/40800213:59
johnthetubaguytdurakov: yeah, I need to look at that one again14:00
johnthetubaguytdurakov: thats a new option though, not suitable past feature freeze, but good for pike14:00
*** bvanhav_ has joined #openstack-nova14:03
*** bvanhav_ is now known as bvanhav14:03
*** bvanhav__ has quit IRC14:04
markus_zIs the placement service mandatory? (I'm still living under a rock :/ )14:05
*** prateek has joined #openstack-nova14:06
johnthetubaguymarkus_z: it is for ocata14:07
johnthetubaguymarkus_z: n-cpu should fail to start if its not configured with the placement URL now14:07
*** READ10 has joined #openstack-nova14:08
markus_zjohnthetubaguy: Hm, I think that's the issue in our s390 CI. We don't start the placement service (because we have an outdated version of devstack-gate).14:08
*** eglynn has joined #openstack-nova14:08
*** claudiub has joined #openstack-nova14:10
markus_zjohnthetubaguy: Even if it is not the root-cause, good to know that we are behind (again). I have to fix that.14:10
markus_zjohnthetubaguy: dammit, yeah, that's it14:10
openstackgerritTrevor McCasland proposed openstack/nova-specs master: Add spec for Accelerating SR-IOV with DPDK  https://review.openstack.org/42986714:11
*** tbachman_ has joined #openstack-nova14:12
openstackgerritJohn Garbutt proposed openstack/nova master: Default live_migration_progress_timeout to off  https://review.openstack.org/42979814:13
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: Remove stuck live-migration detection  https://review.openstack.org/43021814:13
*** tbachman has quit IRC14:14
*** tbachman_ is now known as tbachman14:14
*** amoralej is now known as amoralej|lunch14:14
openstackgerritPushkar Umaranikar proposed openstack/nova master: Placement api: set custom json_error_formatter in allocations  https://review.openstack.org/39519414:14
*** vsaienko has quit IRC14:14
*** mdrabe has joined #openstack-nova14:14
*** breitz has joined #openstack-nova14:16
johnthetubaguypumaranikar: thanks14:16
*** breitz_ has quit IRC14:17
pumaranikarjohnthetubaguy, thanks for quick review14:18
openstackgerritEd Leafe proposed openstack/nova master: Add check for invalid inventory amounts  https://review.openstack.org/42880014:25
openstackgerritEd Leafe proposed openstack/nova master: Add check for invalid allocation amounts  https://review.openstack.org/41675214:25
*** mlavalle has joined #openstack-nova14:25
*** jamesdenton has joined #openstack-nova14:26
openstackgerritStephen Finucane proposed openstack/nova master: conf: Deprecate two more nova-net options  https://review.openstack.org/41239014:27
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Standardize indentation of test_vif  https://review.openstack.org/43027114:27
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Standardize naming of variables  https://review.openstack.org/43027214:27
*** mriedem has joined #openstack-nova14:27
*** Daisy has joined #openstack-nova14:28
openstackgerritSilvan Kaiser proposed openstack/nova master: Removes getfattr from Quobyte Nova driver  https://review.openstack.org/42864614:28
*** sree has joined #openstack-nova14:30
*** Guest60723 has quit IRC14:31
*** jamesden_ has joined #openstack-nova14:32
*** Daisy has quit IRC14:32
*** jamesdenton has quit IRC14:33
*** vsaienko has joined #openstack-nova14:34
*** zhurong has joined #openstack-nova14:34
*** smatzek_ has quit IRC14:35
*** aloga_ has joined #openstack-nova14:35
*** kevinz has quit IRC14:36
johnthetubaguysfinucan: doesn't allow_same_net_traffic get used by neutron, or do we use a different firewall driver?14:38
sfinucanjohnthetubaguy: What's that in context to?14:38
*** jpena|lunch is now known as jpena14:38
*** amoralej|lunch is now known as amoralej14:39
sfinucanjohnthetubaguy: I'm pretty sure it's mainly used by nova-network, but libvirt also overloads it for its own firewall14:39
johnthetubaguysfinucan: https://review.openstack.org/#/c/412390/6/nova/conf/network.py@95714:40
*** nmathew has joined #openstack-nova14:40
*** stvnoyes has quit IRC14:40
sfinucanjohnthetubaguy: Yeah, so my reply to the first option also stands for the second one14:40
*** nmathew has quit IRC14:41
sfinucanWe're overloading the value for libvirt's firewall and that option should be either (a) removed altogether or (b) moved to the libvirt group14:41
johnthetubaguysfinucan: agreed with the first one, but trying to workout what does the neutron firewalling? isn't it using this code too? https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/virt/libvirt/firewall.py#L16514:41
johnthetubaguysfinucan: I think its shared in virt via this one though: https://github.com/openstack/nova/blob/4f91ed3a547965ed96a22520edcfb783e7936e95/nova/virt/firewall.py#L30714:42
johnthetubaguysfinucan: I guess the others maybe don't use it for any neutron drivers yet, unsure14:42
*** prateek has quit IRC14:43
sfinucanjohnthetubaguy: Hmm, that's a good point14:43
*** cdelatte has quit IRC14:43
sfinucanjohnthetubaguy: If we're reading that right, the comments for 'use_ipv6' are also wrong https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/virt/libvirt/firewall.py#L15814:45
johnthetubaguysfinucan: yeah, it looks that way14:45
sfinucangrr, whoever thought it was a good idea to reuse nova-net options for neutron deserves a smack14:46
*** markvoelker has joined #openstack-nova14:46
*** gouthamr has joined #openstack-nova14:48
*** sudipto_ has quit IRC14:48
*** sudipto has quit IRC14:48
*** ducttape_ has joined #openstack-nova14:49
*** dimtruck is now known as zz_dimtruck14:51
sfinucanAnd use_ipv6 is *also* used for that injected network template (compute.injected_network_template). Ugh...14:51
*** markvoelker has quit IRC14:52
*** owalsh is now known as owalsh-brb14:53
*** mtanino has joined #openstack-nova14:54
*** dikonoor has quit IRC14:55
*** jamesden_ has quit IRC14:55
*** smatzek_ has joined #openstack-nova14:55
*** smatzek__ has joined #openstack-nova14:56
*** jamesdenton has joined #openstack-nova14:57
*** owalsh-brb has quit IRC14:57
*** sree has quit IRC14:58
*** vsaienko has quit IRC14:58
*** sree has joined #openstack-nova14:58
lyarwoodhttps://review.openstack.org/#/c/427364/ - I'd appreciate reviews on this swap_volume bugfix if any cores have time today. sfinucan, mdbooth's NFS fix now depends on this btw.15:00
*** smatzek_ has quit IRC15:01
*** owalsh-brb has joined #openstack-nova15:01
*** eharney has joined #openstack-nova15:01
*** smatzek_ has joined #openstack-nova15:02
sfinucanlyarwood: I'll take a gawk shortly15:02
lyarwoodsfinucan: cheers15:02
*** sree has quit IRC15:03
*** crushil has joined #openstack-nova15:03
openstackgerritJordan Pittier proposed openstack/nova master: api-ref: document the 'tenant_id' query parameter  https://review.openstack.org/43029015:05
*** satyar has joined #openstack-nova15:06
*** smatzek__ has quit IRC15:06
lyarwoodhmmmm there's no #openstack-devstack channel, does anyone know if openstack-infra is the best place to ask for devstack reviews? I'm looking for reviews on https://review.openstack.org/#/c/427602/ so our ceph job can pass again...15:06
*** vsaienko has joined #openstack-nova15:06
dansmithlyarwood: -qa15:06
lyarwooddansmith: thanks15:07
*** sree has joined #openstack-nova15:08
*** owalsh-brb is now known as owalsh15:08
*** david-lyle has joined #openstack-nova15:08
*** xinliang has quit IRC15:09
*** david-lyle has quit IRC15:10
*** david-lyle has joined #openstack-nova15:11
*** tbachman has quit IRC15:12
*** mdnadeem has quit IRC15:12
*** tbachman has joined #openstack-nova15:13
*** cdent has joined #openstack-nova15:14
*** david-lyle has quit IRC15:16
*** sdague_ is now known as sdague15:17
*** aloga_ has quit IRC15:18
*** sacharya has joined #openstack-nova15:19
*** bauzas has quit IRC15:19
*** zz_dimtruck is now known as dimtruck15:19
sfinucanjohnthetubaguy: Out of curiosity, what's the finger in the air estimate for cells v1 going bye bye?15:20
sfinucan...and, in turn, nova-network15:21
openstackgerritChristopher Martin proposed openstack/nova master: Stop using mox in test_compute_cells.py  https://review.openstack.org/38975015:21
*** hongbin has joined #openstack-nova15:21
johnthetubaguysfinucan: we need to implement the transition code, then let that cook for a release.15:22
*** gouthamr has quit IRC15:22
johnthetubaguysfinucan: after we actually support two cells v2 cells15:22
*** xinliang has joined #openstack-nova15:22
johnthetubaguysfinucan: so another two or three cycles till we delete, maybe :(15:22
*** bauzas has joined #openstack-nova15:22
johnthetubaguysfinucan: looking after our users is expensive15:23
sfinucanjohnthetubaguy: aye, and sadly necessary15:23
* johnthetubaguy nods15:23
*** dave-mccowan has quit IRC15:24
*** hoangcx has quit IRC15:24
*** gouthamr has joined #openstack-nova15:29
*** gouthamr has quit IRC15:30
*** MVenesio has joined #openstack-nova15:32
dansmithsfinucan: but we should only maintain n-net for cellsv1 users with legit bugs I think, not just anyone15:32
*** armax has joined #openstack-nova15:34
sfinucandansmith: I was hoping for an easy way out of unravelling the nest of conf options that are shared between nova-net and libvirt/Xen/other things15:34
sfinucannamely, wait until nova-net is gone then remove the ones we don't have references for anymore :)15:34
*** armax has quit IRC15:34
*** armax has joined #openstack-nova15:35
sfinucanjohnthetubaguy: So I'm figuring out what nova-network options /have been/ repurposed and duplicate them in other groups with UPGRADE renos15:37
sfinucanthen I'm going to mass migrate all nova-net opts to a single conf file which we can leave to d̶i̶e̶ mature15:37
sfinucanSound fair?15:38
johnthetubaguythat sounds like a good plan15:38
*** vsaienko has quit IRC15:38
*** moshele has quit IRC15:39
*** cdelatte has joined #openstack-nova15:40
*** mdrabe has quit IRC15:40
*** coreywright has quit IRC15:41
*** tovin07 has joined #openstack-nova15:42
*** yamahata has joined #openstack-nova15:43
*** dave-mccowan has joined #openstack-nova15:43
*** egarbade- has quit IRC15:44
*** ekhugen has quit IRC15:45
*** coreywright has joined #openstack-nova15:45
BobBalljohnthetubaguy: Thanks for the review - are you +2 on the revision to https://review.openstack.org/#/c/424428/ or are further changes needed?15:46
*** larainema has quit IRC15:46
*** salv-orlando has quit IRC15:46
*** egarbade- has joined #openstack-nova15:47
*** ekhugen has joined #openstack-nova15:47
*** mdrabe has joined #openstack-nova15:48
*** markvoelker has joined #openstack-nova15:49
*** mptacekx has quit IRC15:52
openstackgerritBalazs Gibizer proposed openstack/nova master: handle uninited fields in notification payload  https://review.openstack.org/41585715:52
*** david-lyle has joined #openstack-nova15:53
*** esberglu has joined #openstack-nova15:53
*** markvoelker has quit IRC15:55
*** jdurgin1 has joined #openstack-nova15:55
*** sandanar has quit IRC15:56
*** lpetrut has quit IRC15:56
*** pkovacs has joined #openstack-nova15:58
*** hieulq_ has joined #openstack-nova15:58
*** salv-orlando has joined #openstack-nova16:04
pkholkinjohnthetubaguy: mriedem: jaypipes: baoli16:06
pkholkinjohnthetubaguy: mriedem: jaypipes: bauzas: dansmith: alex_xu: and all nova folks, I decided to leave OpenStack, thank you for your work in community and your support! maybe we will meet once again, wish you all the best and good luck! :)16:08
dansmithpkholkin: bummer, but good luck on your next adventure!16:09
mriedempkholkin: thanks for your contributions and good luck in the new position16:09
pkholkindansmith: sorry) thank you !16:09
pkholkinmriedem: thanks! it was a great pleasure to work in our community!16:10
*** burgerk has joined #openstack-nova16:10
*** mjura has quit IRC16:11
*** tovin07 has left #openstack-nova16:11
*** cdelatte has quit IRC16:12
*** markvoelker has joined #openstack-nova16:13
*** markvoelker has quit IRC16:14
*** ekuris__ has quit IRC16:14
*** markvoelker has joined #openstack-nova16:14
*** stvnoyes has joined #openstack-nova16:14
rpodolyakapkholkin: good luck, Pasha! really sad to see you go :(16:15
*** rcernin has quit IRC16:16
markus_zpkholkin: too bad, thanks for your time16:16
*** pcaruana has quit IRC16:17
pkholkinrpodolyaka: me too( thank you very much, Roman !16:17
*** zhurong has quit IRC16:17
pkholkinmarkus_z: thanks!16:17
*** jaosorior has joined #openstack-nova16:18
mdboothThe detach/delete race isn't fixable on the compute host16:20
mdboothBecause api gets the bdms and sends them to the compute host, which then acts on them16:20
mdboothEven though they might be out of date16:20
mriedemmdbooth: did you find my comment in the compute manager code about that already?16:21
mdboothmriedem: Not yet. I have spelunked significantly, but not everywhere.16:21
*** tbachman has quit IRC16:21
mdboothmriedem: Incidentally, while I'd like to fix this race, I think it's orthogonal to the NFS thing.16:22
mdboothBecause the NFS change is safe either way.16:22
mdboothIt's just ugly complaining about removing things which no longer exist.16:22
mdboothmriedem: Why not just ignore what api gave us and refresh anyway?16:23
cfriesenmdbooth: couldn't they still be out of date, just less likely?16:23
mdboothcfriesen: Once we're on the compute host we can hold a lock16:24
*** artom_ has joined #openstack-nova16:24
mdboothBut obviously only against other thing which mutate bdms on the compute host16:24
mdboothIt would fix *this* race, for eg16:24
*** egonzalez has left #openstack-nova16:24
cfriesenmdbooth: coming from the linux kernel I was surprised (shocked, appalled) at the locking in nova. :)16:25
mdboothcfriesen: locking in nova?16:25
mdboothcfriesen: Yeah, I'm right there with you.16:25
*** xinli has joined #openstack-nova16:25
pumaranikarcdent, I have updated json formatter patch. Please have a look when you get time https://review.openstack.org/#/c/395194/16:25
*** artom has quit IRC16:27
*** trevormc has joined #openstack-nova16:27
mdboothmriedem: What's the significance of refresh if volume_id isn't set there?16:27
cdentpumaranikar: yup, will do, is definitely on my list for today16:27
mriedemto get the volume_id so we can delete the volume16:28
mriedemif we're deleting the instance while it's spawning during a boot from volume where nova creates the volume16:28
pumaranikarcdent, thanks.16:28
mdboothmriedem: The race here is between detach and delete16:29
*** bvanhav has quit IRC16:29
mdboothSo the issue is that when delete runs, it has a bdm in its list which has already been deleted by detach16:30
*** ayogi has quit IRC16:30
mriedemmdbooth: there is where that comment and refresh came from https://review.openstack.org/#/c/258118/16:30
*** udesale__ has quit IRC16:31
mdboothmriedem: Fun. Any reason not to refresh unconditionally?16:31
mdboothIt's slightly more expensive, but it's unlikely to add a great deal to a delete operation.16:31
*** egarbade- has quit IRC16:32
*** baoli has quit IRC16:32
mriedemmdbooth: no, i had a targeted refresh for the specific thing i was fixing to avoid round tripping and pulling the bdm list unconditionally when i didn't need to16:32
mriedemmdbooth: that doesn't fix the race though right?16:32
mdboothCritically, refresh while holding the instance lock on the compute host16:32
*** ekhugen has quit IRC16:32
mriedemso lock in delete and lock in detach16:32
mriedemyou're saying16:32
mdboothYeah. delete already locks.16:32
mdboothI added a patch to lock in detach.16:32
*** sree has quit IRC16:32
*** sree has joined #openstack-nova16:33
*** nkrinner is now known as nkrinner_afk16:33
*** ekhugen_alt has quit IRC16:33
*** patriciadomin has quit IRC16:34
mdboothdetach currently races with itself, so I don't understand why that's not already there16:34
* mdbooth wonders if there's some obtuse reason detach doesn't lock, but everything else does.16:34
mriedemwhat do you mean by races with itself?16:34
mdboothDetach the same volume multiple times in quick succession16:35
mdboothThey'll all run concurrently.16:35
*** lpetrut has joined #openstack-nova16:35
*** openstackgerrit has quit IRC16:35
*** vsaienko has joined #openstack-nova16:37
*** aloga_ has joined #openstack-nova16:38
*** openstackgerrit has joined #openstack-nova16:38
openstackgerritArtom Lifshitz proposed openstack/nova master: Run api sample tests against 2.latest  https://review.openstack.org/43035216:38
*** artom_ is now known as artom16:38
mriedemmdbooth: i imagine it's not there because in that scenario, eventually the first one wins and the user doesn't see any errors in the compute but they see the detach eventually complete, so they are happy16:39
mriedemthe admin might see an error in the logs if they are monitoring16:39
mriedemanyway, left a comment in your chnage16:40
mdboothmriedem: But meanwhile the backend is busy hassling cinder about it, and doing multiple cleanups simultaneously, and we've got our fingers crossed there are no side effects we haven't thought of.16:40
mriedemcrap, *change*16:40
mriedemwell like all bugs, it's not a bug until it is and someone cares about it16:40
mriedemso shrug16:40
mdboothmriedem: TBH, I only care about it because I wrote a patch which causes it to be noticed :)16:42
mriedemjust put out a TC resolution to drop support for NFS and then you don't need to worry about this16:43
mdboothmriedem: Well it would have to be *any* filesystem based volume backend. My patch supports them all :)16:44
*** markus_z has quit IRC16:44
cdentpumaranikar: nice work! I've left some questions within on that but they are mostly for johnthetubaguy and sdague16:44
* mdbooth is pretty sure no real users care about these things, anyway16:44
*** chyka has joined #openstack-nova16:44
openstackgerritDan Smith proposed openstack/nova master: Add an update_cell command to nova-manage  https://review.openstack.org/43035416:46
*** pkovacs has quit IRC16:47
pumaranikarcdent, thanks for quick review :)16:48
*** cdelatte has joined #openstack-nova16:49
*** jdurgin1 has quit IRC16:49
*** bvanhav has joined #openstack-nova16:50
*** psachin has quit IRC16:50
lyarwoodmdbooth: speaking of something that end users don't really care about, shouldn't all of that logic be in the DriverVolumeBlockDevice class like it is for attach_volume?16:51
mriedemarmax: thanks for https://review.openstack.org/#/c/429984/ - i left some comments in there16:51
mdboothlyarwood: Nope. See code comment.16:51
armaxmriedem: thanks, I’ll have another pass16:51
mdboothlyarwood: It's only relevant to backends which use it. Ideally that would be all of them, but I chose not to do them all in 1 patch.16:52
dansmithmriedem: this might be good to get in  https://review.openstack.org/43035416:53
dansmithmriedem: it's non-runtime and gives us yet another way to tweak those records if they get created incorrectly16:53
sdaguecdent: for https://review.openstack.org/#/c/395194/11/nova/api/openstack/placement/wsgi_wrapper.py - is that always going to be a 5xx error, or are 4xx in that mix as well16:53
dansmithmriedem: I've now encountered two people that created their records and needed to change them16:53
cdentsdague that always not 5xx at that stage, only intentionally raised 4xx16:53
mriedemdansmith: we have create_cell and delete_cell16:53
dansmithmriedem: yeah, but you can't do that once you've created instances16:54
mriedemoh yeah16:54
lyarwoodmdbooth: sorry which comment?16:54
mriedemdansmith: let me contemplate this in the men's room16:55
cdentsdague: the goal there is to only add the formatting. there's middleware much further "out" which deals with trapping unexpected exceptions16:55
*** hieulq_ has quit IRC16:55
sdaguecdent: right, so I wouldn't add the logging there then16:55
* cdent nods16:55
sdaguebecause we don't want to be logging the same error multiple times if it's already gathered elsewhere16:55
*** lpetrut has quit IRC16:56
cdentsdague: these particular excpeptions will not leave the app (into middleware) as exceptions. webob turns them into proper responses. so any logging that is happening is either right there, or when the original exception is raised16:58
*** andreas_s has quit IRC16:59
cdentthe need for this superclass is precisely because of the way webob turns exceptions within wsgify decorated functions into responses16:59
mdboothlyarwood: https://review.openstack.org/#/c/383859/13/nova/virt/libvirt/volume/fs.py16:59
*** adrian_otto has joined #openstack-nova16:59
lyarwoodmdbooth: ah sorry, I'm talking about moving the _detach_volume logic from the compute layer into https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L205 like we did for attach17:00
*** eharney_ has joined #openstack-nova17:01
mdboothlyarwood: I guess. You'd still need to resolve the locking issues in compute manager, though17:02
*** eharney has quit IRC17:03
*** eharney_ is now known as eharney17:03
*** hamzy has quit IRC17:03
lyarwoodmdbooth: yeah, I just thought of it again when I saw your change, it's something Nikola wanted to do before he left but never got around to. Anyway, ignore me, sorry for the noise.17:03
*** sridharg has quit IRC17:04
*** derekh has quit IRC17:05
*** unicell has joined #openstack-nova17:08
*** unicell1 has quit IRC17:08
*** lpetrut has joined #openstack-nova17:08
sfinucansean-k-mooney, jaypipes: Do you know if os-vif publishes whether a VIF should support IPv6 or not?17:09
sfinucani.e. as part of the VIF model17:09
sean-k-mooneyit is not a property of the VIF17:09
sean-k-mooneyits a property of the neutron subnet17:09
sean-k-mooneyi would not expect this to be reported by os-vif17:10
openstackgerritBalazs Gibizer proposed openstack/nova master: Improve assertJsonEqual error reporting  https://review.openstack.org/42819917:10
sean-k-mooneysfinucan:  also ^^17:10
sean-k-mooneysfinucan: i should have mentioned you in the reply17:11
sfinucansean-k-mooney: OK, cool17:12
mriedemdansmith: you know what might be nice is to put the service version in the os-services output17:12
mdboothlyarwood mriedem: rebuild also disconnects twice. Once explicitly in compute manager, once again in the driver during destroy.17:12
mriedemdansmith: now that we have all of this stuff that depends on having computes at a certain version17:12
sfinucanSo there's merit in keeping around the use_ipv6 option for building VIF filters in libvirt17:12
sfinucane.g. https://libvirt.org/formatnwfilter.html17:12
sean-k-mooneysfinucan: am im not sure but i dont we use that and i dont think we should17:13
dansmithmriedem: might be good to abstract it a bit if we do.. so report "LATEST" and "OLD" or something17:13
*** tbachman has joined #openstack-nova17:13
sean-k-mooneysfinucan: i would like to completely remove libvirt form our port binding if we can17:13
mriedemdansmith: yeah, was just thinking about a doc that armax is working on for get me a network and we don't have a way to tell you if your computes are new enough to use that17:13
*** raunak has joined #openstack-nova17:14
sfinucansean-k-mooney: I don't think we can, assuming we want to keep the interface firewalls https://github.com/openstack/nova/blob/master/nova/virt/libvirt/firewall.py#L138-L17917:14
dansmithmriedem: aye, although they log the service version on startup I think so we could also just rely on that for the short term17:14
sean-k-mooneysfinucan: the only place we use libvirt for port binding currently is the non hybrid plug case for ovs. that really should be done by os-vif17:14
*** raunak has quit IRC17:14
*** alaski_ is now known as alaski17:14
sean-k-mooneysfinucan: no we can we just need to not add the interfaces as an openvswithc interface in the libvirt xml. just add it as a generic tap17:15
lyarwoodmdbooth: ewww, we can't really remove the compute layer call as other virt drivers might not do that right?17:15
sean-k-mooneysfinucan: then have os-vif add it to the ovs bridge17:15
mdboothlyarwood: Presumably not17:15
*** Apoorva has joined #openstack-nova17:15
lyarwoodmdbooth: as mriedem said before I think it's just another case of us assuming that nothing bad will happen if you disconnect_volume twice :|17:15
*** breitz has quit IRC17:15
mriedemi said that?17:16
sean-k-mooneysfinucan: where is _get_instance_filter_parameters used17:16
lyarwoodmriedem: something along the lines of that if I understood correctly, maybe I didn't17:16
*** yamahata has quit IRC17:16
sfinucansean-k-mooney: Here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/firewall.py#L181-L19317:16
mriedemif it was smart, then yes i said it17:16
sfinucansean-k-mooney: Which is in turn called here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/firewall.py#L112-L13617:16
sean-k-mooneyyep tracking back now. im trying to figure out if this code is still executed with os-vif17:17
sfinucansean-k-mooney: I think it is. It's called in a few places in the libvirt driver.py17:18
mdboothmriedem: So, I've been through the ERRORs generated against my NFS patch with a fine toothed comb. There are 2, and they're both existing errors where we're double-calling disconnect from higher up. They cause no ill effects other than the log message.17:18
sean-k-mooneybasically i think we could move this to os-vif if it was still needed17:18
cburgessmriedem Sorry missed your messages yesterday, yes we use live_migration_progress_timeout why?17:18
mriedemcburgess: https://review.openstack.org/#/c/42979817:18
mdboothI originally made them ERROR because I didn't expect the errors higher up, which with hindsight perhaps I should have.17:18
*** nikeshm has joined #openstack-nova17:19
mdboothI suggest I turn them into warnings and file bugs about them, but that we go with the NFS patch anyway.17:19
sean-k-mooneysfinucan: so it is really called here https://github.com/openstack/nova/blob/417dac50364357000c479bb2cb7c71773172a930/nova/virt/libvirt/driver.py#L137117:19
nikeshmi am getting this error libvirtError: Requested operation is not valid: pivot of disk 'vdb' requires an active copy job17:19
mriedemlyarwood: ^17:19
* lyarwood looks17:20
cburgessmriedem Oh cute... thanks for the heads up. This might actually explain some issues we saw recently.17:20
nikeshmtempest.api.compute.admin.test_volume_swap.TestVolumeSwap.test_volume_swap [416.350838s] ... FAILED17:20
mdboothlyarwood: If mriedem is looking for a detailed second opinion, I don't mind walking you through the logs in the morning.17:20
mdboothWould probably take an hour or so.17:20
lyarwoodmdbooth: sure17:20
sfinucansean-k-mooney: Yup17:20
sean-k-mooneysfinucan: so this si currently called after plug but im not sure its valide to call it here in all cases.17:21
sfinucanand it's used for "MAC, IP, and ARP spoofing protection"17:21
lyarwoodnikeshm: what virt_type are you using?17:21
mdboothlyarwood: Thanks! It's a date.17:21
sean-k-mooneysfinucan: i dont think this will have any effect for vhost-user for example17:21
sfinucansean-k-mooney: No? How come?17:21
nikeshmlyarwood: virt_type = qemu17:22
sean-k-mooneyhow would that function configure mac,arp,ip spoofing on a vhost-user interfaces17:22
sean-k-mooneysfinucan: that would have to be done in ovs17:22
lyarwoodnikeshm: and which verison of qemu?17:22
sfinucansean-k-mooney: aha, correct17:22
sfinucanthat is for IPTables only17:22
*** jgrassler has quit IRC17:22
*** jaosorior has quit IRC17:22
sfinucanit's part of the IptablesFirewallDriver17:23
sean-k-mooneysfinucan: it is for when you are using the old nova firewall not neutron security groups17:23
*** jgr has joined #openstack-nova17:23
sfinucansean-k-mooney: danpb suggested otherwise though17:23
sean-k-mooneysfinucan: it basically part of nova networks i think17:23
sean-k-mooneysfinucan: i could be wrong17:23
mdboothlyarwood: Plan is to walk through the errors reported here: http://logs.openstack.org/09/395709/6/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/c8091c2/logs/screen-n-cpu.txt.gz?level=ERROR17:23
* sfinucan goes to check johnthetubaguy's comments on a related review17:23
*** jaosorior has joined #openstack-nova17:23
*** nic has joined #openstack-nova17:23
*** jaosorior has quit IRC17:24
sean-k-mooneysfinucan: but i dont think this will have any eefect with the conntrack firewall driver in neutron for example17:24
*** sree has quit IRC17:24
dansmithmriedem: you want me to replicate that multiline warning on each help string for transport and db?17:24
mriedemdansmith: well they'd be slightly different but yeah, i don't think the actual docstring gets dumped in the cli help17:24
mriedemi can check quick17:24
*** jaosorior has joined #openstack-nova17:24
dansmithoh I thought it did17:25
sean-k-mooneysfinucan: looking at https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/virt/libvirt/firewall.py#L117-L12017:25
dansmiththat's the point of putting return value stuff in there right?17:25
mriedemthe help for the args is printed out,17:25
sean-k-mooneysfinucan: it will disable this code if securty groupd are enabled17:25
mriedembut i don't think the docstring gets into the help output for the command17:25
mriedemand i guess i don't have a test vm handy to verify17:25
mriedembut i had that issue with the nova-status stuff17:25
mriedemwhich is why i also pushed for man pages17:25
*** unicell has quit IRC17:26
dansmithmriedem: remember you making me document the return values for the new cells commands there? I thought that was because the user, you know, sees that shit :)17:26
*** jogo has quit IRC17:27
mriedemdo you have a devstack you can verify quick because i don't17:27
lyarwoodnikeshm: feel free to write this up in a bug btw if it's easier - https://bugs.launchpad.net/nova/+filebug17:27
*** efried has quit IRC17:28
dansmithmriedem: I have an old one only, but let me look17:28
mriedemjust do like: nova-manage cell_v2 create_cell -h17:28
dansmithit's too old for that :)17:29
sfinucansean-k-mooney: Yeah, all the guides I'm seeing suggest that nwfilter - the thing that reads that config - is only for ebtables17:29
sfinucani.e. not OVS17:29
dansmithmriedem: my liberty system doesn't show that text at least17:29
dansmithso unless something has changed...17:29
mriedemnova-manage db sync -h17:29
mriedemwould show "Sync the database up to the most recent version" if it worked17:29
mriedemit should show the help on the --version option though "Database version"17:30
sean-k-mooneysfinucan: yes so this code should really only be run for linuxbridge or macvtap binding17:31
sean-k-mooneyso it proable should be moved into the linuxbridge pluging for os-vif17:31
sfinucansean-k-mooney: ...and even then, doesn't neutron have its own anti-spoofing stuff?17:31
sfinucane.g. http://kimizhang.com/neutron-ml2-port-security/17:32
sean-k-mooneyfor ovs yes17:32
sean-k-mooneyfor linux bridge proably17:32
sean-k-mooneynot sure though17:32
sean-k-mooneyagain i think this is mainly for nova-networks17:32
sfinucanthat blog suggests yes for linucbridge17:32
openstackgerritDan Smith proposed openstack/nova master: Add an update_cell command to nova-manage  https://review.openstack.org/43035417:32
sean-k-mooneyif you are using nova-netwokrs this code would be needed for firewall support because you would not have nova17:33
sean-k-mooney* neutron17:33
nikeshmlyarwood:  qemu-utils                           2.0.0+dfsg-2ubuntu1.30                amd64        QEMU utilities17:33
sean-k-mooneynova-networks without nova would be hard17:33
*** kaisers has quit IRC17:33
sean-k-mooneygeneral question but is nova-networks dead yet?17:34
sean-k-mooneycan we actully start deleting the code for it. i kindof lost track of that effort17:35
lyarwoodnikeshm: and libvirt?17:35
*** Apoorva has quit IRC17:35
nikeshmlyarwood:   libvirt-dev                          1.2.2-0ubuntu13.1.17                  amd64        development files for the libvirt library17:36
*** Apoorva has joined #openstack-nova17:36
*** Swami has joined #openstack-nova17:36
*** kaisers has joined #openstack-nova17:37
*** mvk has quit IRC17:37
*** Swami has quit IRC17:37
*** rfolco has quit IRC17:38
*** esberglu has quit IRC17:38
*** nikhil|afk has joined #openstack-nova17:38
*** Swami has joined #openstack-nova17:38
*** slaweq has quit IRC17:39
sfinucansean-k-mooney: Nope. It's there for another 2-3 cycles at least :(17:40
sean-k-mooney:( really... why...17:41
*** efried has joined #openstack-nova17:41
sfinucansean-k-mooney: cells v117:42
sfinucanneed a migration path to cells v2 then another cycle for folks to switch over17:42
sean-k-mooneycells v1 only works with nova-networks?17:42
sfinucanfrom the looks of things, yup17:43
sean-k-mooneysfinucan: so ocate cells v2 pike miragtion and queens remove nova networks?17:43
sfinucannope. cells v2 isn't complete yet17:44
sean-k-mooneyhum ok i taught cells v1 worked with neutron i guess not.17:44
sfinucanyou can't use more than one cell in cells v217:44
mriedemsean-k-mooney: sfinucan: you can use neutron with cells v117:44
mriedemgodaddy is running ovs17:44
mriedemit requires patches for the external vif plug event callbackstuff17:45
mriedembut people are doing it17:45
sfinucanmriedem: So what's the tie with nova-net?17:45
mriedemnova-net will only start in ocata if running cells v117:45
sfinucanI thought that was the one blocker stopping us killing it17:45
mriedemnova-net will go when cells v1 goes17:45
sfinucanright, but not the other way round17:45
*** karimb has quit IRC17:45
lyarwoodnikeshm: hmmm can you document this in a bug and I'll take a look this evening? I can't reproduce that locally on Fedora 2417:46
sfinucanso why don't we keep cells v1 (which doesn't have a complete migration path) and kill nova-net (which does - neutron)17:46
*** patriciadomin has joined #openstack-nova17:46
mriedemsfinucan: because then we'd have to switch the cells v1 CI job to neutron,17:46
*** ekhugen has joined #openstack-nova17:46
mriedemand we don't have that external vif plugging callback stuff plumbed into cells v1 upstream17:46
mriedemwhich would require work to make cells v1 work with nova in our CI17:47
mriedemwork we don't care to do for something that we're effectively crippling and setting up to remove17:47
*** egarbade- has joined #openstack-nova17:47
sfinucanmriedem: ah, so it's a non-trivial amount of work17:48
sfinucanGotcha. I didn't get that link. Thanks for clearing it up17:48
*** ekhugen_alt has joined #openstack-nova17:48
sfinucanmikal: Do I recall talk of file injection going away?17:49
sean-k-mooneysfinucan: so back to your original question we proably have to keep that function untill cells v1 goes... or move it to the linux bridge os-vif driver17:49
*** baoli has joined #openstack-nova17:49
sfinucansean-k-mooney: That would sound about right17:49
mriedemblam! pike is the current focus of dev now https://launchpad.net/nova17:50
*** efried has quit IRC17:50
sfinucanBut we probably don't need to keep it after that point, because neutron can do what libvirt is doing here17:50
*** sree has joined #openstack-nova17:50
*** raunak has joined #openstack-nova17:50
sfinucan...and what libvirt is doing probably wouldn't even work for folks using OVS and/or security groups, which is most people if the surveys are to be believed17:51
*** esberglu has joined #openstack-nova17:52
*** nikeshm has quit IRC17:52
*** adrian_otto has quit IRC17:53
*** adrian_otto has joined #openstack-nova17:54
*** efried has joined #openstack-nova17:54
*** adrian_otto has quit IRC17:54
*** sudipto_ has joined #openstack-nova17:55
*** sudipto has joined #openstack-nova17:55
mriedemsfinucan: i plan on proposing a spec for pike to deprecate file injection (personalities) in the REST API (outside of config drive anyway)17:55
mdboothmriedem: Fun. Does that mean nobody is using that?17:56
mriedemvia config drive or the personality files or just in general?17:57
*** browne has joined #openstack-nova17:57
gabor_antal_Hey there, may I ask a question? Is it okay if I update test-requirements with a newer version of hacking?17:57
mdboothcfriesen mriedem: Incidentally, IIRC that also fails for config drives because we're constantly blowing config drives away and rebuilding them.17:57
mriedemgabor_antal_: requirements changes to nova go through the openstack/requirements repo, and updating hacking there is a global change which impacts all projects,17:58
mriedemgabor_antal_: so it's a large undertaking17:58
mriedemmdbooth: http://lists.openstack.org/pipermail/openstack-dev/2016-November/107195.html was also in the operators list and go no responses17:58
auggynova bugs team meeting at the top of the hour in #openstack-meeting-4 !17:58
mriedemso i have no idea how much it's used17:59
johnthetubaguyhonestly, I am not sure as operators if they would know either18:00
openstackgerritDiana Clarke proposed openstack/nova master: Reduce the number of COMMIT & SELECT 1 statements  https://review.openstack.org/43039018:00
gabor_antal_mriedem: Should we propose to that repo or where? I just checked the new hacking, and has a great feature18:00
*** ralonsoh has quit IRC18:00
*** rfolco has joined #openstack-nova18:00
mriedemgabor_antal_: if you're going to propose it, it starts in the openstack/requirements repo18:00
*** tesseract has quit IRC18:01
*** gouthamr has joined #openstack-nova18:02
*** lucasagomes is now known as lucas-afk18:02
*** alexpilotti has joined #openstack-nova18:02
*** abalutoiu__ is now known as abalutoiu18:02
*** yamahata has joined #openstack-nova18:02
*** aloga_ has quit IRC18:03
*** krtaylor has quit IRC18:03
gabor_antal_mriedem: I think I wanted to push this, but that is already merged: https://review.openstack.org/#/c/409626/18:03
*** vsaienko has quit IRC18:04
mriedemgabor_antal_: oh so we just need to update https://github.com/openstack/nova/blob/master/test-requirements.txt#L518:04
mriedemi didn't realize hacking was excluded from global updates18:04
mriedemthen i guess it's simpler since it's just nova18:04
gabor_antal_Yeah, so then it's okay if I modify this line,18:05
*** gszasz has quit IRC18:06
*** sudipto_ has quit IRC18:23
*** sudipto has quit IRC18:23
*** faizy has joined #openstack-nova18:23
*** vsaienko has joined #openstack-nova18:26
*** jpena is now known as jpena|away18:33
*** jpena|away is now known as jpena18:33
*** aloga_ has joined #openstack-nova18:33
*** unicell has joined #openstack-nova18:33
openstackgerritMatthew Booth proposed openstack/nova master: libvirt: Fix races with nfs volume mount/umount  https://review.openstack.org/38385918:35
*** hamzy has joined #openstack-nova18:35
*** gouthamr has quit IRC18:35
*** jpena is now known as jpena|lunch18:37
*** jpena|lunch is now known as jpena|away18:37
*** owalsh is now known as owalsh-afk18:38
*** sambetts is now known as sambetts|afk18:38
*** satyar_ has joined #openstack-nova18:39
*** krtaylor has joined #openstack-nova18:39
*** satyar has quit IRC18:40
*** karimb has joined #openstack-nova18:40
*** jdurgin has quit IRC18:41
*** jkraj has quit IRC18:41
*** ducttape_ has quit IRC18:41
*** aloga_ has quit IRC18:44
*** moshele has joined #openstack-nova18:49
*** vsaienko has quit IRC18:51
*** vsaienko has joined #openstack-nova18:52
openstackgerritSean McCully proposed openstack/nova master: allocations.consumer_id is not used in query.  https://review.openstack.org/43039918:52
*** sree has quit IRC18:53
*** avolkov has quit IRC18:53
*** vsaienko has quit IRC18:54
*** alexpilo_ has joined #openstack-nova18:55
*** alexpilotti has quit IRC18:55
*** jdurgin has joined #openstack-nova18:57
openstackgerritJohn Garbutt proposed openstack/nova master: Stop _undefine_domain erroring if domain not found  https://review.openstack.org/43040019:00
*** bvanhav_ has joined #openstack-nova19:00
*** bvanhav has quit IRC19:01
cdentedleafe, bauzas: didn't we already have a fix like 430399 ^^ before?19:02
*** ociuhandu has joined #openstack-nova19:03
*** vsaienko has joined #openstack-nova19:04
*** ducttape_ has joined #openstack-nova19:10
*** vsaienko has quit IRC19:14
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: Stop leaving failed live-migrates in the migrating state  https://review.openstack.org/43040419:15
cdentedleafe, bauzas never mind, it's not, it's the same problem somewhere else19:15
*** faizy has quit IRC19:16
johnthetubaguymriedem: FYI, there seems to be another nastly little live-migrate bug that has cropped up in our testing: https://review.openstack.org/43040019:17
johnthetubaguymriedem: still investigation, just a general heads up that stuff is cooking there19:17
* johnthetubaguy goes to sort out food19:17
*** satyar_ has quit IRC19:18
mriedemjohnthetubaguy: ok i've left my -1 for your dessert :)19:19
*** vsaienko has joined #openstack-nova19:22
openstackgerritSean McCully proposed openstack/nova master: allocations.consumer_id is not used in query.  https://review.openstack.org/43039919:24
*** ducttape_ has quit IRC19:31
*** vsaienko has quit IRC19:34
*** vsaienko has joined #openstack-nova19:36
*** adrian_otto has joined #openstack-nova19:38
*** Daisy has joined #openstack-nova19:39
*** gouthamr has joined #openstack-nova19:41
*** gouthamr has quit IRC19:41
*** owalsh-afk has quit IRC19:43
*** Daisy has quit IRC19:43
*** breitz has joined #openstack-nova19:44
*** xinli has quit IRC19:44
*** salv-orl_ has joined #openstack-nova19:50
cfriesenjohnthetubaguy: got a theory on the race in https://bugs.launchpad.net/nova/+bug/1662626 between live migration and deletion.  instance deletion synchronizes on instance.uuid, but I don't think _post_live_migration() does.19:50
openstackLaunchpad bug 1662626 in OpenStack Compute (nova) "live-migrate left in migrating as domain not found" [Undecided,In progress] - Assigned to John Garbutt (johngarbutt)19:50
*** salv-orlando has quit IRC19:52
*** ducttape_ has joined #openstack-nova19:54
*** xinli has joined #openstack-nova20:01
johnthetubaguycfriesen: it could be, I need to look at what the periodic tasks are doing, there is just a loop of live-migrates on a test rig for this test, AFAIK.20:02
johnthetubaguymriedem: yeah, you are right, I meant to look that up, but wanted dinner20:02
*** mvensky has joined #openstack-nova20:03
*** salv-orl_ has quit IRC20:04
cfriesenquestion...if instance.old_flavor refers to a deleted flavor, will it still be able to load it from the DB?20:04
*** annegentle has joined #openstack-nova20:10
*** oomichi_ has joined #openstack-nova20:11
*** ducttape_ has quit IRC20:14
*** ducttape_ has joined #openstack-nova20:14
*** READ10 has quit IRC20:16
*** dave-mccowan has quit IRC20:19
*** rfolco has quit IRC20:26
mriedemcfriesen: yes20:28
mriedemthe old_flavor is stored in the extras table20:29
*** amoralej is now known as amoralej|off20:29
*** ducttape_ has quit IRC20:31
*** bvanhav_ has quit IRC20:36
*** dave-mccowan has joined #openstack-nova20:37
cfriesendo we allow resizing from a flavor with ephemeral/swap to a flavor without?  I only see a check for root_gb.20:38
cfriesenmriedem: thanks20:38
*** jaosorior has quit IRC20:40
openstackgerritEmilien Macchi proposed openstack/nova master: DNM - test tripleo without nova api in WSGI/apache  https://review.openstack.org/42900820:43
*** ducttape_ has joined #openstack-nova20:43
openstackgerritMaciej Szankin proposed openstack/nova master: conf: mark glance.api_servers opt as required  https://review.openstack.org/42824120:43
*** dimtruck is now known as zz_dimtruck20:47
*** karimb has quit IRC20:49
*** karimb has joined #openstack-nova20:50
*** amotoki has quit IRC20:51
*** rtheis has joined #openstack-nova20:53
*** rtheis has quit IRC20:53
*** ijw has joined #openstack-nova20:57
*** crushil has quit IRC20:58
*** ducttape_ has quit IRC20:59
*** ducttape_ has joined #openstack-nova20:59
*** rfolco has joined #openstack-nova21:00
*** owalsh-afk has joined #openstack-nova21:00
*** ducttape_ has quit IRC21:01
*** oomichi_ has quit IRC21:03
smcginnisjohnthetubaguy: Start here: https://review.openstack.org/#/c/297140/21:03
smcginnisjohnthetubaguy: Then here: https://review.openstack.org/#/c/346438/21:03
*** nicolasbock has quit IRC21:04
smcginnisjohnthetubaguy: Actually, the second one isn't the one I was looking for. This one might be more interesting: https://review.openstack.org/#/c/346470/21:04
*** ianw has quit IRC21:07
*** moshele has quit IRC21:07
openstackgerritDiana Clarke proposed openstack/nova master: Reduce the number of COMMIT & SELECT 1 statements  https://review.openstack.org/43039021:07
*** ianw has joined #openstack-nova21:08
*** moshele has joined #openstack-nova21:09
*** harlowja has quit IRC21:09
*** rfolco has quit IRC21:10
*** dave-mccowan has quit IRC21:10
johnthetubaguysmcginnis: cool, thank you, something for the morning :)21:11
*** nicolasbock has joined #openstack-nova21:11
*** eglynn has quit IRC21:14
*** zz_dimtruck is now known as dimtruck21:14
*** crushil has joined #openstack-nova21:14
*** moshele has quit IRC21:15
cdentdiana_clarke: I want to subscribe to your newsletter21:15
*** eglynn has joined #openstack-nova21:16
*** ijw has quit IRC21:16
diana_clarkecdent: Nah... it's just a low-hanging fruit, migration 216 only, thing. Nothing much to see there.21:19
cdentdiana_clarke I don't know, there's just something fascinating about the collected works of your commits. Not sure what it is.21:20
*** ijw has joined #openstack-nova21:20
*** gouthamr has joined #openstack-nova21:21
diana_clarkecdent: perhaps it's because I have no clue what openstack is, so my commits always dance around that, lol.21:23
cdentoh you still worry about that? yeah, apparently you're supposed to stop worrying about that and just accept it21:23
artomdiana_clarke, don't tell anyone, openstack is everything to everyone21:24
*** delattec has joined #openstack-nova21:25
*** cdelatte has quit IRC21:26
mriedemdiana_clarke: any numbers on how much faster that makes that migration?21:26
mriedemi came across an open nova bug last week from tripleo about how the nova db migrations were timing them out21:26
artomTelcos want to orchestrate some NFV stuff, Rackspace wants a webhosting cloud, you want a job, and I want something I can use to forget the loneliness when alcohol isn't doing it21:26
mriedemartom: there is always opium21:27
artommriedem, that's next on the list: 1. Alcohol 2. Openstack 3. Opium 4. ??? 5. Profit!21:27
cdentartom, that's the best description of openstack I've ever read21:28
artomI'll proll'y never reach 5 though21:28
mriedemdiana_clarke: this one https://bugs.launchpad.net/nova/+bug/166139621:28
openstackLaunchpad bug 1661396 in OpenStack Compute (nova) "undercloud install fails (nova-db-sync timeout) on VM on an SATA disk hypervisor" [Undecided,Incomplete]21:28
artomcdent, :)21:28
dansmithmriedem: that's ours and it's something with our setup as far as we can tell21:28
mriedem"This seems to be related to the switch to innodb_file_per_table to ON which has doubled the amount of time the db sync takes on this class of hardware."21:29
*** smatzek_ has quit IRC21:29
diana_clarkemriedem: It doesn't make 216 all that much faster, just a few seconds. Here are the nova db migrations, sorted slowest to fastest: http://paste.openstack.org/show/598003/21:29
dansmithit's way more than double, it's like 100x or something21:29
mriedemheh, 267 is mine21:30
mriedembut that's also because it's scanning all of the tables21:31
cdent"Many of you in the audience are responsible for running automated tests on your codebase before deploying to production"21:31
diana_clarkemriedem: I started looking at them b/c of that tripleo bug, but honestly I don't think this will help much. Something else is up (like dansmith already said, I see now).21:31
dansmithbut if it makes unit tests faster and doesn't alter the schema at all, then that's cool, although I'm skeptical since we cache the schema the first time we create it in the fixture21:32
diana_clarkedansmith: before I take the WIP off my patch, I'll do a DB dump before and after and diff them. It's already on my TODO list.21:33
dansmithdiana_clarke: excellent, thanks21:33
diana_clarkemriedem: And here are the api database migration times, if you're curious. This time sorted by migration number: http://paste.openstack.org/show/598005/21:34
*** Jeffrey4l has quit IRC21:35
*** harlowja has joined #openstack-nova21:35
* cdent waves goodnight21:35
*** cdent has quit IRC21:36
mriedemdiana_clarke: fyi https://github.com/openstack/nova/blob/master/tools/db/schema_diff.py21:36
mriedemdprince wrote that when he was collapsing migrations way back when21:36
*** Jeffrey4l has joined #openstack-nova21:36
diana_clarkemriedem: ah, thanks!21:36
*** MVenesio has quit IRC21:37
*** salv-orlando has joined #openstack-nova21:37
*** jamielennox is now known as jamielennox|away21:42
*** salv-orlando has quit IRC21:42
*** gouthamr has quit IRC21:45
*** catintheroof has quit IRC21:48
*** catintheroof has joined #openstack-nova21:49
*** salv-orlando has joined #openstack-nova21:50
*** shaner has quit IRC21:52
*** haypo has joined #openstack-nova21:53
*** haypo has joined #openstack-nova21:53
*** haypo has left #openstack-nova21:53
*** krtaylor has quit IRC21:54
*** catintheroof has quit IRC21:54
*** shaner has joined #openstack-nova21:54
*** adrian_otto has quit IRC21:59
*** tesseract has joined #openstack-nova21:59
*** smatzek_ has joined #openstack-nova22:00
*** tesseract- has joined #openstack-nova22:00
*** thorst_ has quit IRC22:01
*** ducttape_ has joined #openstack-nova22:02
*** thorst_ has joined #openstack-nova22:03
pumaranikarsdague, can you please check https://review.openstack.org/#/c/395194/. Placement json formatter change.22:05
*** tesseract has quit IRC22:07
*** tesseract- has quit IRC22:07
*** thorst_ has quit IRC22:08
*** tesseract has joined #openstack-nova22:08
openstackgerritDiana Clarke proposed openstack/nova master: Reduce the number of COMMIT & SELECT 1 statements  https://review.openstack.org/43039022:10
*** trevormc has quit IRC22:11
*** ducttape_ has quit IRC22:13
*** thorst_ has joined #openstack-nova22:20
*** jheroux has quit IRC22:22
openstackgerritAlex Szarka proposed openstack/nova master: Refactor init_instance:resume_guests_state  https://review.openstack.org/34958222:24
*** baoli has quit IRC22:24
*** vladikr has quit IRC22:24
*** baoli has joined #openstack-nova22:24
*** thorst_ has quit IRC22:25
openstackgerritAlex Szarka proposed openstack/nova master: Changed maximum code complexity to 25  https://review.openstack.org/35117622:25
*** smatzek_ has quit IRC22:26
*** tesseract is now known as tesseract-RH22:26
*** edmondsw has quit IRC22:29
mordredmriedem: so - I've got this question about boot from volume22:29
*** baoli has quit IRC22:29
*** burgerk has quit IRC22:30
mordredmriedem: http://developer.openstack.org/api-ref/compute/?expanded=create-server-detail#create-server says that block_device_mapping_v2.boot_index takes a string and also that None should be used for volumes not used as boot volumes22:30
*** tesseract-RH is now known as tesseract22:31
mriedemwas just packing up...22:32
mordredmriedem: but we just got an error "Invalid input for field/attribute boot_index. Value: None. None is not of type 'integer"22:32
*** ducttape_ has joined #openstack-nova22:32
mriedemmordred: http://docs.openstack.org/developer/nova/block_device_mapping.html might be helpful22:32
mordredmriedem: yup. it also says None is valid22:32
*** ijw has quit IRC22:32
mriedemi feel like something was just recently changed in the json schema there, is this master?22:34
mordreddhellmann: you were doing master devstack?22:34
*** vsaienko has quit IRC22:34
mordredmriedem: I think so yeah?22:34
dhellmannmordred : yes, master devstack (from a few hours ago)22:34
* mordred goes to look at json schema22:34
mriedemwhat's the image and dest type?22:36
mriedemsource_type and destination_type i mean22:36
mriedembecause https://github.com/openstack/nova/blob/master/nova/block_device.py#L19822:37
dhellmannit's a qcow2 ubuntu image22:37
mordreddestination_type would be 'volume'22:37
mriedemand source_type is?22:37
dhellmannI want to boot it ephemeral  and attach a volume22:37
mordredyah- source_type also volume22:37
mriedemhave you tried omitting boot_index22:38
*** alexpilotti has joined #openstack-nova22:38
mordredyes. that works22:38
mordredas does providing -1 or '-1'22:38
*** alexpilo_ has quit IRC22:38
mordredhowever, None worked in the past and is still referneced in the docs ... so maybe there's a bug somewhere, I'm just not sure what to file/write up22:38
mordred(we can make shade dtrt by omitting or using -122:38
mriedemoomichi: Kevin_Zheng: gmann: alex_xu: do you remember anything recently related to this? ^22:39
mriedemmordred: i wouldn't put a ton of faith in the api-ref docs on this one22:40
mordredmriedem: ok22:40
openstackgerritPushkar Umaranikar proposed openstack/nova master: Placement api: set custom json_error_formatter in resource_class  https://review.openstack.org/43046322:41
mriedemi'd be interested in knowing if it's different on like a liberty install22:41
mordredmriedem: None worked against dreamhost - whatever version is running there22:41
mriedemmordred: because my guess is the wording in the api-ref was pulled from http://docs.openstack.org/developer/nova/block_device_mapping.html and that's more about the actual object code in nova rather than the API22:41
mordredah - k. so it's likely just a docs bug22:42
dhellmanndreamhost is either mitaka or newton22:42
*** jamielennox|away is now known as jamielennox22:42
mriedemi'd file a bug either way so we can investigate22:42
dhellmannI can do that22:42
mriedemplus, if the api is ok but the docs are wrong, we can use the bug to fix the docs22:42
mordredthanks dhellmann !22:42
openstackgerritAlex Szarka proposed openstack/nova master: Changed maximum code complexity to 30  https://review.openstack.org/35117622:43
dhellmannthanks, mordred & mriedem22:43
mriedemi wonder if you were hitting a nova v2 vs v2.1 endpoint before...22:45
mriedemv2 didn't have schema validation22:45
mriedemmordred: dhellmann: ^22:45
*** gouthamr has joined #openstack-nova22:45
mordredoh - it's entirely possible22:45
mordredshade is (currently) just piggybacking novaclient which grabs latest microversion aiui22:46
*** tblakes has quit IRC22:46
mordredI haven't gotten to doing explicit microversion code myself22:46
mordred(that'll be next month - expect plenty of questions from me)22:46
mriedemthere is where the legacy v2 api bdm v2 stuff happened https://github.com/openstack/nova/blob/liberty-eol/nova/api/openstack/compute/legacy_v2/servers.py#L42422:47
mriedemwhich only checked boot_index here https://github.com/openstack/nova/blob/liberty-eol/nova/block_device.py#L20122:47
mriedemif source_type == 'image' and destination_type == 'local':22:48
mriedemand then that dict was probably turned into an object https://github.com/openstack/nova/blob/liberty-eol/nova/objects/block_device.py#L7322:48
mriedemwhere boot_index can be None22:48
mriedemthe compute api did some validation here too https://github.com/openstack/nova/blob/liberty-eol/nova/compute/api.py#L131522:49
mriedemon the object22:49
mriedemi think it just means that the v2.1 API json schema validation regressed from the v2 API validation22:49
mriedemwould be cool if you guys could confirm that it was working when you were talking to a v2 compute endpoint cloud vs v2.122:49
mriedembut that'd be my professional opinion22:50
mriedemdr debug22:50
mriedemdhellmann: i've got to run but just throw ^ into the bug report and i'll check it out later when i'm home22:51
dhellmannmriedem : ok22:51
dhellmannmriedem : I am currently working my way through the rather long instructions for filing a nova bug22:51
*** mriedem has quit IRC22:51
*** eharney has quit IRC22:51
*** jogo has joined #openstack-nova22:56
dhellmannmriedem: https://bugs.launchpad.net/nova/+bug/166269922:56
openstackLaunchpad bug 1662699 in OpenStack Compute (nova) "API documentation and behavior do not match for booting with attached volumes" [Undecided,New]22:56
*** ducttape_ has quit IRC22:56
*** Swami has quit IRC22:57
*** edmondsw has joined #openstack-nova22:59
*** esberglu has quit IRC23:00
*** esberglu has joined #openstack-nova23:00
*** tesseract has quit IRC23:00
*** tesseract has joined #openstack-nova23:00
*** tesseract-RH has joined #openstack-nova23:01
*** esberglu has quit IRC23:01
*** tesseract has quit IRC23:01
*** tesseract-RH has quit IRC23:01
Davieydhellmann: I *think* that might have been the same issue i saw when using Packer with volumes. Had to change Packer's usage with Volumes23:02
openstackgerritAlex Szarka proposed openstack/nova master: Reduce code complexity - servers.py  https://review.openstack.org/35986123:02
openstackgerritAlex Szarka proposed openstack/nova master: Reduce code complexity - manager.py  https://review.openstack.org/35986823:02
openstackgerritAlex Szarka proposed openstack/nova master: Reduce code complexity - linux_net.py  https://review.openstack.org/35987123:02
dhellmannDaviey : yeah, it's a behavior change but it's not clear if it's a bug and if so where (code or docs)23:03
*** edmondsw has quit IRC23:04
*** jamesdenton has quit IRC23:06
*** fragatina has joined #openstack-nova23:07
*** lpetrut has quit IRC23:07
*** mdrabe has quit IRC23:09
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance-exists notification  https://review.openstack.org/40366023:11
*** sdague has quit IRC23:12
*** ijw has joined #openstack-nova23:14
*** ijw has quit IRC23:16
*** esberglu has joined #openstack-nova23:16
*** esberglu has quit IRC23:18
*** tlian has quit IRC23:26
*** zhurong has joined #openstack-nova23:26
*** zhurong has quit IRC23:28
*** xinli has quit IRC23:28
*** dimtruck is now known as zz_dimtruck23:33
openstackgerritDan Smith proposed openstack/nova master: Add an update_cell command to nova-manage  https://review.openstack.org/43035423:35
*** ducttape_ has joined #openstack-nova23:40
*** tlian has joined #openstack-nova23:42
*** tbachman has quit IRC23:42
*** Swami has joined #openstack-nova23:44
*** Swami has quit IRC23:45
*** baoli has joined #openstack-nova23:45
*** ducttape_ has quit IRC23:50
*** ducttape_ has joined #openstack-nova23:51
*** unicell has quit IRC23:52
*** karimb has quit IRC23:54
*** tbachman has joined #openstack-nova23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!